jro_apps/redmine Commit - r14231:671fce04dec6

Don't propose projects without trackers when editing an issue (#20463)....

Jean-Philippe Lang -

r14231:671fce04dec6

parent child

Context file:

r14231:671fce04dec6

app/models/issue.rb +1 -1

                 if current_project
                   condition = ["(#{condition}) OR #{Project.table_name}.id = ?", current_project.id]
                 end
-                Project.where(condition)
+                Project.where(condition).having_trackers
               end
               private

app/models/project.rb +3 0

                 end
               }
               scope :sorted, lambda {order(:lft)}
+              scope :having_trackers, lambda {
+                where("#{Project.table_name}.id IN (SELECT DISTINCT project_id FROM #{table_name_prefix}projects_trackers#{table_name_suffix})")
+              }
               def initialize(attributes=nil, *args)
                 super

test/unit/issue_test.rb +6 0

                 assert_not_include Project.find(2), Issue.allowed_target_projects(User.find(2))
               end
+              def test_allowed_target_projects_should_not_include_projects_without_trackers
+                project = Project.generate!(:tracker_ids => [])
+                assert project.trackers.empty?
+                assert_not_include project, Issue.allowed_target_projects(User.find(1))
+              end
               def test_move_to_another_project_with_same_category
                 issue = Issue.find(1)
                 issue.project = Project.find(2)

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages