jro_apps/redmine Commit - r14007:670340e543ce

The test email action should only be accessible with POST (#20203)....

Jean-Philippe Lang -

r14007:670340e543ce

parent child

Context file:

r14007:670340e543ce

app/views/settings/_notifications.html.erb +1 -1

             </fieldset>
             <div style="float:right;">
-            <%= link_to l(:label_send_test_email), :controller => 'admin', :action => 'test_email' %>
+            <%= link_to l(:label_send_test_email), { :controller => 'admin', :action => 'test_email' }, :method => :post %>
             </div>
             <%= submit_tag l(:button_save) %>

config/routes.rb +1 -1

               match 'admin/projects', :controller => 'admin', :action => 'projects', :via => :get
               match 'admin/plugins', :controller => 'admin', :action => 'plugins', :via => :get
               match 'admin/info', :controller => 'admin', :action => 'info', :via => :get
-              match 'admin/test_email', :controller => 'admin', :action => 'test_email', :via => :get
+              match 'admin/test_email', :controller => 'admin', :action => 'test_email', :via => :post
               match 'admin/default_configuration', :controller => 'admin', :action => 'default_configuration', :via => :post
               resources :auth_sources do

test/functional/admin_controller_test.rb +2 -2

                 user.pref.save!
                 ActionMailer::Base.deliveries.clear
-                get :test_email
+                post :test_email
                 assert_redirected_to '/settings?tab=notifications'
                 mail = ActionMailer::Base.deliveries.last
                 assert_not_nil mail
               def test_test_email_failure_should_display_the_error
                 Mailer.stubs(:test_email).raises(Exception, 'Some error message')
-                get :test_email
+                post :test_email
                 assert_redirected_to '/settings?tab=notifications'
                 assert_match /Some error message/, flash[:error]
               end

test/integration/routing/admin_test.rb +1 -1

                 should_route 'GET /admin/projects' => 'admin#projects'
                 should_route 'GET /admin/plugins' => 'admin#plugins'
                 should_route 'GET /admin/info' => 'admin#info'
-                should_route 'GET /admin/test_email' => 'admin#test_email'
+                should_route 'POST /admin/test_email' => 'admin#test_email'
                 should_route 'POST /admin/default_configuration' => 'admin#default_configuration'
               end
             end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages