jro_apps/redmine Commit - r6029:66f026aa7818

Normalize issue description EOLs do prevent false journal details (#8712)....

Jean-Philippe Lang -

r6029:66f026aa7818

parent child

Context file:

r6029:66f026aa7818

app/models/issue.rb +7 0

                 result
               end
+              def description=(arg)
+                if arg.is_a?(String)
+                  arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
+                end
+                write_attribute(:description, arg)
+              end
               # Overrides attributes= so that tracker_id gets assigned first
               def attributes_with_tracker_first=(new_attributes, *args)
                 return if new_attributes.nil?

test/unit/issue_test.rb +6 -1

                 IssueCustomField.delete_all
                 Issue.update_all("description = NULL", "id=1")
-                i = Issue.first
+                i = Issue.find(1)
                 i.init_journal(User.find(2))
                 i.subject = "blank description"
                 i.description = "\r\n"
                 end
               end
+              def test_description_eol_should_be_normalized
+                i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
+                assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
+              end
               def test_saving_twice_should_not_duplicate_journal_details
                 i = Issue.find(:first)
                 i.init_journal(User.find(2), 'Some notes')

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages