##// END OF EJS Templates
remove unneeded Relation#all from Group#user_removed...
Toshi MARUYAMA -
r12261:66bdc014d417
parent child
Show More
@@ -1,92 +1,91
1 # Redmine - project management software
1 # Redmine - project management software
2 # Copyright (C) 2006-2013 Jean-Philippe Lang
2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 #
3 #
4 # This program is free software; you can redistribute it and/or
4 # This program is free software; you can redistribute it and/or
5 # modify it under the terms of the GNU General Public License
5 # modify it under the terms of the GNU General Public License
6 # as published by the Free Software Foundation; either version 2
6 # as published by the Free Software Foundation; either version 2
7 # of the License, or (at your option) any later version.
7 # of the License, or (at your option) any later version.
8 #
8 #
9 # This program is distributed in the hope that it will be useful,
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
12 # GNU General Public License for more details.
13 #
13 #
14 # You should have received a copy of the GNU General Public License
14 # You should have received a copy of the GNU General Public License
15 # along with this program; if not, write to the Free Software
15 # along with this program; if not, write to the Free Software
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17
17
18 class Group < Principal
18 class Group < Principal
19 include Redmine::SafeAttributes
19 include Redmine::SafeAttributes
20
20
21 has_and_belongs_to_many :users,
21 has_and_belongs_to_many :users,
22 :join_table => "#{table_name_prefix}groups_users#{table_name_suffix}",
22 :join_table => "#{table_name_prefix}groups_users#{table_name_suffix}",
23 :after_add => :user_added,
23 :after_add => :user_added,
24 :after_remove => :user_removed
24 :after_remove => :user_removed
25
25
26 acts_as_customizable
26 acts_as_customizable
27
27
28 validates_presence_of :lastname
28 validates_presence_of :lastname
29 validates_uniqueness_of :lastname, :case_sensitive => false
29 validates_uniqueness_of :lastname, :case_sensitive => false
30 validates_length_of :lastname, :maximum => 255
30 validates_length_of :lastname, :maximum => 255
31
31
32 before_destroy :remove_references_before_destroy
32 before_destroy :remove_references_before_destroy
33
33
34 scope :sorted, lambda { order("#{table_name}.lastname ASC") }
34 scope :sorted, lambda { order("#{table_name}.lastname ASC") }
35 scope :named, lambda {|arg| where("LOWER(#{table_name}.lastname) = LOWER(?)", arg.to_s.strip)}
35 scope :named, lambda {|arg| where("LOWER(#{table_name}.lastname) = LOWER(?)", arg.to_s.strip)}
36
36
37 safe_attributes 'name',
37 safe_attributes 'name',
38 'user_ids',
38 'user_ids',
39 'custom_field_values',
39 'custom_field_values',
40 'custom_fields',
40 'custom_fields',
41 :if => lambda {|group, user| user.admin?}
41 :if => lambda {|group, user| user.admin?}
42
42
43 def to_s
43 def to_s
44 lastname.to_s
44 lastname.to_s
45 end
45 end
46
46
47 def name
47 def name
48 lastname
48 lastname
49 end
49 end
50
50
51 def name=(arg)
51 def name=(arg)
52 self.lastname = arg
52 self.lastname = arg
53 end
53 end
54
54
55 def user_added(user)
55 def user_added(user)
56 members.each do |member|
56 members.each do |member|
57 next if member.project.nil?
57 next if member.project.nil?
58 user_member = Member.find_by_project_id_and_user_id(member.project_id, user.id) || Member.new(:project_id => member.project_id, :user_id => user.id)
58 user_member = Member.find_by_project_id_and_user_id(member.project_id, user.id) || Member.new(:project_id => member.project_id, :user_id => user.id)
59 member.member_roles.each do |member_role|
59 member.member_roles.each do |member_role|
60 user_member.member_roles << MemberRole.new(:role => member_role.role, :inherited_from => member_role.id)
60 user_member.member_roles << MemberRole.new(:role => member_role.role, :inherited_from => member_role.id)
61 end
61 end
62 user_member.save!
62 user_member.save!
63 end
63 end
64 end
64 end
65
65
66 def user_removed(user)
66 def user_removed(user)
67 members.each do |member|
67 members.each do |member|
68 MemberRole.
68 MemberRole.
69 includes(:member).
69 includes(:member).
70 where("#{Member.table_name}.user_id = ? AND #{MemberRole.table_name}.inherited_from IN (?)", user.id, member.member_role_ids).
70 where("#{Member.table_name}.user_id = ? AND #{MemberRole.table_name}.inherited_from IN (?)", user.id, member.member_role_ids).
71 all.
72 each(&:destroy)
71 each(&:destroy)
73 end
72 end
74 end
73 end
75
74
76 def self.human_attribute_name(attribute_key_name, *args)
75 def self.human_attribute_name(attribute_key_name, *args)
77 attr_name = attribute_key_name.to_s
76 attr_name = attribute_key_name.to_s
78 if attr_name == 'lastname'
77 if attr_name == 'lastname'
79 attr_name = "name"
78 attr_name = "name"
80 end
79 end
81 super(attr_name, *args)
80 super(attr_name, *args)
82 end
81 end
83
82
84 private
83 private
85
84
86 # Removes references that are not handled by associations
85 # Removes references that are not handled by associations
87 def remove_references_before_destroy
86 def remove_references_before_destroy
88 return if self.id.nil?
87 return if self.id.nil?
89
88
90 Issue.where(['assigned_to_id = ?', id]).update_all('assigned_to_id = NULL')
89 Issue.where(['assigned_to_id = ?', id]).update_all('assigned_to_id = NULL')
91 end
90 end
92 end
91 end
General Comments 0
You need to be logged in to leave comments. Login now