##// END OF EJS Templates
Fixes User/CustomValue association broken by r2869 (#3978)....
Jean-Philippe Lang -
r2791:6656d41a413a
parent child
Show More
@@ -0,0 +1,9
1 class FixUsersCustomValues < ActiveRecord::Migration
2 def self.up
3 CustomValue.update_all("customized_type = 'Principal'", "customized_type = 'User'")
4 end
5
6 def self.down
7 CustomValue.update_all("customized_type = 'User'", "customized_type = 'Principal'")
8 end
9 end
@@ -1,86 +1,86
1 1 ---
2 2 custom_values_006:
3 3 customized_type: Issue
4 4 custom_field_id: 2
5 5 customized_id: 3
6 6 id: 6
7 7 value: "125"
8 8 custom_values_007:
9 9 customized_type: Project
10 10 custom_field_id: 3
11 11 customized_id: 1
12 12 id: 7
13 13 value: Stable
14 14 custom_values_001:
15 customized_type: User
15 customized_type: Principal
16 16 custom_field_id: 4
17 17 customized_id: 3
18 18 id: 1
19 19 value: ""
20 20 custom_values_002:
21 customized_type: User
21 customized_type: Principal
22 22 custom_field_id: 4
23 23 customized_id: 4
24 24 id: 2
25 25 value: 01 23 45 67 89
26 26 custom_values_003:
27 customized_type: User
27 customized_type: Principal
28 28 custom_field_id: 4
29 29 customized_id: 2
30 30 id: 3
31 31 value: ""
32 32 custom_values_004:
33 33 customized_type: Issue
34 34 custom_field_id: 2
35 35 customized_id: 1
36 36 id: 4
37 37 value: "125"
38 38 custom_values_005:
39 39 customized_type: Issue
40 40 custom_field_id: 2
41 41 customized_id: 2
42 42 id: 5
43 43 value: ""
44 44 custom_values_008:
45 45 customized_type: Issue
46 46 custom_field_id: 1
47 47 customized_id: 3
48 48 id: 8
49 49 value: "MySQL"
50 50 custom_values_009:
51 51 customized_type: Issue
52 52 custom_field_id: 2
53 53 customized_id: 3
54 54 id: 9
55 55 value: "this is a stringforcustomfield search"
56 56 custom_values_010:
57 57 customized_type: Issue
58 58 custom_field_id: 6
59 59 customized_id: 1
60 60 id: 10
61 61 value: "2.1"
62 62 custom_values_011:
63 63 customized_type: Issue
64 64 custom_field_id: 6
65 65 customized_id: 2
66 66 id: 11
67 67 value: "2.05"
68 68 custom_values_012:
69 69 customized_type: Issue
70 70 custom_field_id: 6
71 71 customized_id: 3
72 72 id: 12
73 73 value: "11.65"
74 74 custom_values_013:
75 75 customized_type: Issue
76 76 custom_field_id: 6
77 77 customized_id: 7
78 78 id: 13
79 79 value: ""
80 80 custom_values_014:
81 81 customized_type: Issue
82 82 custom_field_id: 6
83 83 customized_id: 5
84 84 id: 14
85 85 value: "-7.6"
86 86 No newline at end of file
@@ -1,117 +1,123
1 1 # redMine - project management software
2 2 # Copyright (C) 2006-2007 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.dirname(__FILE__) + '/../test_helper'
19 19
20 20 class CustomValueTest < ActiveSupport::TestCase
21 fixtures :custom_fields
21 fixtures :custom_fields, :custom_values, :users
22 22
23 23 def test_string_field_validation_with_blank_value
24 24 f = CustomField.new(:field_format => 'string')
25 25 v = CustomValue.new(:custom_field => f)
26 26
27 27 v.value = nil
28 28 assert v.valid?
29 29 v.value = ''
30 30 assert v.valid?
31 31
32 32 f.is_required = true
33 33 v.value = nil
34 34 assert !v.valid?
35 35 v.value = ''
36 36 assert !v.valid?
37 37 end
38 38
39 39 def test_string_field_validation_with_min_and_max_lengths
40 40 f = CustomField.new(:field_format => 'string', :min_length => 2, :max_length => 5)
41 41 v = CustomValue.new(:custom_field => f, :value => '')
42 42 assert v.valid?
43 43 v.value = 'a'
44 44 assert !v.valid?
45 45 v.value = 'a' * 2
46 46 assert v.valid?
47 47 v.value = 'a' * 6
48 48 assert !v.valid?
49 49 end
50 50
51 51 def test_string_field_validation_with_regexp
52 52 f = CustomField.new(:field_format => 'string', :regexp => '^[A-Z0-9]*$')
53 53 v = CustomValue.new(:custom_field => f, :value => '')
54 54 assert v.valid?
55 55 v.value = 'abc'
56 56 assert !v.valid?
57 57 v.value = 'ABC'
58 58 assert v.valid?
59 59 end
60 60
61 61 def test_date_field_validation
62 62 f = CustomField.new(:field_format => 'date')
63 63 v = CustomValue.new(:custom_field => f, :value => '')
64 64 assert v.valid?
65 65 v.value = 'abc'
66 66 assert !v.valid?
67 67 v.value = '1975-07-14'
68 68 assert v.valid?
69 69 end
70 70
71 71 def test_list_field_validation
72 72 f = CustomField.new(:field_format => 'list', :possible_values => ['value1', 'value2'])
73 73 v = CustomValue.new(:custom_field => f, :value => '')
74 74 assert v.valid?
75 75 v.value = 'abc'
76 76 assert !v.valid?
77 77 v.value = 'value2'
78 78 assert v.valid?
79 79 end
80 80
81 81 def test_int_field_validation
82 82 f = CustomField.new(:field_format => 'int')
83 83 v = CustomValue.new(:custom_field => f, :value => '')
84 84 assert v.valid?
85 85 v.value = 'abc'
86 86 assert !v.valid?
87 87 v.value = '123'
88 88 assert v.valid?
89 89 v.value = '+123'
90 90 assert v.valid?
91 91 v.value = '-123'
92 92 assert v.valid?
93 93 end
94 94
95 95 def test_float_field_validation
96 96 v = CustomValue.new(:customized => User.find(:first), :custom_field => UserCustomField.find_by_name('Money'))
97 97 v.value = '11.2'
98 98 assert v.save
99 99 v.value = ''
100 100 assert v.save
101 101 v.value = '-6.250'
102 102 assert v.save
103 103 v.value = '6a'
104 104 assert !v.save
105 105 end
106 106
107 107 def test_default_value
108 108 field = CustomField.find_by_default_value('Default string')
109 109 assert_not_nil field
110 110
111 111 v = CustomValue.new(:custom_field => field)
112 112 assert_equal 'Default string', v.value
113 113
114 114 v = CustomValue.new(:custom_field => field, :value => 'Not empty')
115 115 assert_equal 'Not empty', v.value
116 116 end
117
118 def test_sti_polymorphic_association
119 # Rails uses top level sti class for polymorphic association. See #3978.
120 assert !User.find(4).custom_values.empty?
121 assert !CustomValue.find(2).customized.nil?
122 end
117 123 end
General Comments 0
You need to be logged in to leave comments. Login now