jro_apps/redmine Commit - r5165:6550ef9df55f

Fixed: deleting a parent issue may lead to a stale object error (#7920)....

Jean-Philippe Lang -

r5165:6550ef9df55f

parent child

Context file:

r5165:6550ef9df55f

test/unit/issue_nested_set_test.rb +10 0

                  assert_equal [issue1.id, 2, 3], [issue4.root_id, issue4.lft, issue4.rgt]
                end
+               def test_destroy_parent_issue_updated_during_children_destroy
+                 parent = create_issue!
+                 create_issue!(:start_date => Date.today, :parent_issue_id => parent.id)
+                 create_issue!(:start_date => 2.days.from_now, :parent_issue_id => parent.id)
+                 assert_difference 'Issue.count', -3 do
+                   Issue.find(parent.id).destroy
+                 end
+               end
                def test_destroy_child_issue_with_children
                  root = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'root')
                  child = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => root.id)

vendor/plugins/awesome_nested_set/lib/awesome_nested_set.rb +3 0

                            ["#{quoted_right_column_name} >= ?", right]
                          )
                        end
+                       # Reload is needed because children may have updated their parent (self) during deletion.
+                       reload
                      end
                      # reload left, right, and parent

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages