jro_apps/redmine Commit - r5165:6550ef9df55f

Fixed: deleting a parent issue may lead to a stale object error (#7920)....

Jean-Philippe Lang -

r5165:6550ef9df55f

parent child

Context file:

r5165:6550ef9df55f

Collapse all files

test/unit/issue_nested_set_test.rb +10 0

             # redMine - project management software
             # Copyright (C) 2006-2007  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class IssueNestedSetTest < ActiveSupport::TestCase
               fixtures :projects, :users, :members, :member_roles, :roles,
                        :trackers, :projects_trackers,
                        :versions,
                        :issue_statuses, :issue_categories, :issue_relations, :workflows,
                        :enumerations,
                        :issues,
                        :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
                        :time_entries
               self.use_transactional_fixtures = false
               def test_create_root_issue
                 issue1 = create_issue!
                 issue2 = create_issue!
                 issue1.reload
                 issue2.reload
                 assert_equal [issue1.id, nil, 1, 2], [issue1.root_id, issue1.parent_id, issue1.lft, issue1.rgt]
                 assert_equal [issue2.id, nil, 1, 2], [issue2.root_id, issue2.parent_id, issue2.lft, issue2.rgt]
               end
               def test_create_child_issue
                 parent = create_issue!
                 child =  create_issue!(:parent_issue_id => parent.id)
                 parent.reload
                 child.reload
                 assert_equal [parent.id, nil, 1, 4], [parent.root_id, parent.parent_id, parent.lft, parent.rgt]
                 assert_equal [parent.id, parent.id, 2, 3], [child.root_id, child.parent_id, child.lft, child.rgt]
               end
               def test_creating_a_child_in_different_project_should_not_validate
                 issue = create_issue!
                 child = Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1, :subject => 'child', :parent_issue_id => issue.id)
                 assert !child.save
                 assert_not_nil child.errors.on(:parent_issue_id)
               end
               def test_move_a_root_to_child
                 parent1 = create_issue!
                 parent2 = create_issue!
                 child = create_issue!(:parent_issue_id => parent1.id)
                 parent2.parent_issue_id = parent1.id
                 parent2.save!
                 child.reload
                 parent1.reload
                 parent2.reload
                 assert_equal [parent1.id, 1, 6], [parent1.root_id, parent1.lft, parent1.rgt]
                 assert_equal [parent1.id, 4, 5], [parent2.root_id, parent2.lft, parent2.rgt]
                 assert_equal [parent1.id, 2, 3], [child.root_id, child.lft, child.rgt]
               end
               def test_move_a_child_to_root
                 parent1 = create_issue!
                 parent2 = create_issue!
                 child =   create_issue!(:parent_issue_id => parent1.id)
                 child.parent_issue_id = nil
                 child.save!
                 child.reload
                 parent1.reload
                 parent2.reload
                 assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
                 assert_equal [parent2.id, 1, 2], [parent2.root_id, parent2.lft, parent2.rgt]
                 assert_equal [child.id, 1, 2], [child.root_id, child.lft, child.rgt]
               end
               def test_move_a_child_to_another_issue
                 parent1 = create_issue!
                 parent2 = create_issue!
                 child =   create_issue!(:parent_issue_id => parent1.id)
                 child.parent_issue_id = parent2.id
                 child.save!
                 child.reload
                 parent1.reload
                 parent2.reload
                 assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
                 assert_equal [parent2.id, 1, 4], [parent2.root_id, parent2.lft, parent2.rgt]
                 assert_equal [parent2.id, 2, 3], [child.root_id, child.lft, child.rgt]
               end
               def test_move_a_child_with_descendants_to_another_issue
                 parent1 = create_issue!
                 parent2 = create_issue!
                 child =   create_issue!(:parent_issue_id => parent1.id)
                 grandchild = create_issue!(:parent_issue_id => child.id)
                 parent1.reload
                 parent2.reload
                 child.reload
                 grandchild.reload
                 assert_equal [parent1.id, 1, 6], [parent1.root_id, parent1.lft, parent1.rgt]
                 assert_equal [parent2.id, 1, 2], [parent2.root_id, parent2.lft, parent2.rgt]
                 assert_equal [parent1.id, 2, 5], [child.root_id, child.lft, child.rgt]
                 assert_equal [parent1.id, 3, 4], [grandchild.root_id, grandchild.lft, grandchild.rgt]
                 child.reload.parent_issue_id = parent2.id
                 child.save!
                 child.reload
                 grandchild.reload
                 parent1.reload
                 parent2.reload
                 assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
                 assert_equal [parent2.id, 1, 6], [parent2.root_id, parent2.lft, parent2.rgt]
                 assert_equal [parent2.id, 2, 5], [child.root_id, child.lft, child.rgt]
                 assert_equal [parent2.id, 3, 4], [grandchild.root_id, grandchild.lft, grandchild.rgt]
               end
               def test_move_a_child_with_descendants_to_another_project
                 parent1 = create_issue!
                 child =   create_issue!(:parent_issue_id => parent1.id)
                 grandchild = create_issue!(:parent_issue_id => child.id)
                 assert child.reload.move_to_project(Project.find(2))
                 child.reload
                 grandchild.reload
                 parent1.reload
                 assert_equal [1, parent1.id, 1, 2], [parent1.project_id, parent1.root_id, parent1.lft, parent1.rgt]
                 assert_equal [2, child.id, 1, 4], [child.project_id, child.root_id, child.lft, child.rgt]
                 assert_equal [2, child.id, 2, 3], [grandchild.project_id, grandchild.root_id, grandchild.lft, grandchild.rgt]
               end
               def test_invalid_move_to_another_project
                 parent1 = create_issue!
                 child =   create_issue!(:parent_issue_id => parent1.id)
                 grandchild = create_issue!(:parent_issue_id => child.id, :tracker_id => 2)
                 Project.find(2).tracker_ids = [1]
                 parent1.reload
                 assert_equal [1, parent1.id, 1, 6], [parent1.project_id, parent1.root_id, parent1.lft, parent1.rgt]
                 # child can not be moved to Project 2 because its child is on a disabled tracker
                 assert_equal false, Issue.find(child.id).move_to_project(Project.find(2))
                 child.reload
                 grandchild.reload
                 parent1.reload
                 # no change
                 assert_equal [1, parent1.id, 1, 6], [parent1.project_id, parent1.root_id, parent1.lft, parent1.rgt]
                 assert_equal [1, parent1.id, 2, 5], [child.project_id, child.root_id, child.lft, child.rgt]
                 assert_equal [1, parent1.id, 3, 4], [grandchild.project_id, grandchild.root_id, grandchild.lft, grandchild.rgt]
               end
               def test_moving_an_issue_to_a_descendant_should_not_validate
                 parent1 = create_issue!
                 parent2 = create_issue!
                 child =   create_issue!(:parent_issue_id => parent1.id)
                 grandchild = create_issue!(:parent_issue_id => child.id)
                 child.reload
                 child.parent_issue_id = grandchild.id
                 assert !child.save
                 assert_not_nil child.errors.on(:parent_issue_id)
               end
               def test_moving_an_issue_should_keep_valid_relations_only
                 issue1 = create_issue!
                 issue2 = create_issue!
                 issue3 = create_issue!(:parent_issue_id => issue2.id)
                 issue4 = create_issue!
                 r1 = IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
                 r2 = IssueRelation.create!(:issue_from => issue1, :issue_to => issue3, :relation_type => IssueRelation::TYPE_PRECEDES)
                 r3 = IssueRelation.create!(:issue_from => issue2, :issue_to => issue4, :relation_type => IssueRelation::TYPE_PRECEDES)
                 issue2.reload
                 issue2.parent_issue_id = issue1.id
                 issue2.save!
                 assert !IssueRelation.exists?(r1.id)
                 assert !IssueRelation.exists?(r2.id)
                 assert IssueRelation.exists?(r3.id)
               end
               def test_destroy_should_destroy_children
                 issue1 = create_issue!
                 issue2 = create_issue!
                 issue3 = create_issue!(:parent_issue_id => issue2.id)
                 issue4 = create_issue!(:parent_issue_id => issue1.id)
                 issue3.init_journal(User.find(2))
                 issue3.subject = 'child with journal'
                 issue3.save!
                 assert_difference 'Issue.count', -2 do
                   assert_difference 'Journal.count', -1 do
                     assert_difference 'JournalDetail.count', -1 do
                       Issue.find(issue2.id).destroy
                     end
                   end
                 end
                 issue1.reload
                 issue4.reload
                 assert !Issue.exists?(issue2.id)
                 assert !Issue.exists?(issue3.id)
                 assert_equal [issue1.id, 1, 4], [issue1.root_id, issue1.lft, issue1.rgt]
                 assert_equal [issue1.id, 2, 3], [issue4.root_id, issue4.lft, issue4.rgt]
               end
+              def test_destroy_parent_issue_updated_during_children_destroy
+                parent = create_issue!
+                create_issue!(:start_date => Date.today, :parent_issue_id => parent.id)
+                create_issue!(:start_date => 2.days.from_now, :parent_issue_id => parent.id)
+                assert_difference 'Issue.count', -3 do
+                  Issue.find(parent.id).destroy
+                end
+              end
               def test_destroy_child_issue_with_children
                 root = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'root')
                 child = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => root.id)
                 leaf = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'leaf', :parent_issue_id => child.id)
                 leaf.init_journal(User.find(2))
                 leaf.subject = 'leaf with journal'
                 leaf.save!
                 assert_difference 'Issue.count', -2 do
                   assert_difference 'Journal.count', -1 do
                     assert_difference 'JournalDetail.count', -1 do
                       Issue.find(child.id).destroy
                     end
                   end
                 end
                 root = Issue.find(root.id)
                 assert root.leaf?, "Root issue is not a leaf (lft: #{root.lft}, rgt: #{root.rgt})"
               end
               def test_parent_priority_should_be_the_highest_child_priority
                 parent = create_issue!(:priority => IssuePriority.find_by_name('Normal'))
                 # Create children
                 child1 = create_issue!(:priority => IssuePriority.find_by_name('High'), :parent_issue_id => parent.id)
                 assert_equal 'High', parent.reload.priority.name
                 child2 = create_issue!(:priority => IssuePriority.find_by_name('Immediate'), :parent_issue_id => child1.id)
                 assert_equal 'Immediate', child1.reload.priority.name
                 assert_equal 'Immediate', parent.reload.priority.name
                 child3 = create_issue!(:priority => IssuePriority.find_by_name('Low'), :parent_issue_id => parent.id)
                 assert_equal 'Immediate', parent.reload.priority.name
                 # Destroy a child
                 child1.destroy
                 assert_equal 'Low', parent.reload.priority.name
                 # Update a child
                 child3.reload.priority = IssuePriority.find_by_name('Normal')
                 child3.save!
                 assert_equal 'Normal', parent.reload.priority.name
               end
               def test_parent_dates_should_be_lowest_start_and_highest_due_dates
                 parent = create_issue!
                 create_issue!(:start_date => '2010-01-25', :due_date => '2010-02-15', :parent_issue_id => parent.id)
                 create_issue!(                             :due_date => '2010-02-13', :parent_issue_id => parent.id)
                 create_issue!(:start_date => '2010-02-01', :due_date => '2010-02-22', :parent_issue_id => parent.id)
                 parent.reload
                 assert_equal Date.parse('2010-01-25'), parent.start_date
                 assert_equal Date.parse('2010-02-22'), parent.due_date
               end
               def test_parent_done_ratio_should_be_average_done_ratio_of_leaves
                 parent = create_issue!
                 create_issue!(:done_ratio => 20, :parent_issue_id => parent.id)
                 assert_equal 20, parent.reload.done_ratio
                 create_issue!(:done_ratio => 70, :parent_issue_id => parent.id)
                 assert_equal 45, parent.reload.done_ratio
                 child = create_issue!(:done_ratio => 0, :parent_issue_id => parent.id)
                 assert_equal 30, parent.reload.done_ratio
                 create_issue!(:done_ratio => 30, :parent_issue_id => child.id)
                 assert_equal 30, child.reload.done_ratio
                 assert_equal 40, parent.reload.done_ratio
               end
               def test_parent_done_ratio_should_be_weighted_by_estimated_times_if_any
                 parent = create_issue!
                 create_issue!(:estimated_hours => 10, :done_ratio => 20, :parent_issue_id => parent.id)
                 assert_equal 20, parent.reload.done_ratio
                 create_issue!(:estimated_hours => 20, :done_ratio => 50, :parent_issue_id => parent.id)
                 assert_equal (50 * 20 + 20 * 10) / 30, parent.reload.done_ratio
               end
               def test_parent_estimate_should_be_sum_of_leaves
                 parent = create_issue!
                 create_issue!(:estimated_hours => nil, :parent_issue_id => parent.id)
                 assert_equal nil, parent.reload.estimated_hours
                 create_issue!(:estimated_hours => 5, :parent_issue_id => parent.id)
                 assert_equal 5, parent.reload.estimated_hours
                 create_issue!(:estimated_hours => 7, :parent_issue_id => parent.id)
                 assert_equal 12, parent.reload.estimated_hours
               end
               def test_move_parent_updates_old_parent_attributes
                 first_parent = create_issue!
                 second_parent = create_issue!
                 child = create_issue!(:estimated_hours => 5, :parent_issue_id => first_parent.id)
                 assert_equal 5, first_parent.reload.estimated_hours
                 child.update_attributes(:estimated_hours => 7, :parent_issue_id => second_parent.id)
                 assert_equal 7, second_parent.reload.estimated_hours
                 assert_nil first_parent.reload.estimated_hours
               end
               def test_reschuling_a_parent_should_reschedule_subtasks
                 parent = create_issue!
                 c1 = create_issue!(:start_date => '2010-05-12', :due_date => '2010-05-18', :parent_issue_id => parent.id)
                 c2 = create_issue!(:start_date => '2010-06-03', :due_date => '2010-06-10', :parent_issue_id => parent.id)
                 parent.reload
                 parent.reschedule_after(Date.parse('2010-06-02'))
                 c1.reload
                 assert_equal [Date.parse('2010-06-02'), Date.parse('2010-06-08')], [c1.start_date, c1.due_date]
                 c2.reload
                 assert_equal [Date.parse('2010-06-03'), Date.parse('2010-06-10')], [c2.start_date, c2.due_date] # no change
                 parent.reload
                 assert_equal [Date.parse('2010-06-02'), Date.parse('2010-06-10')], [parent.start_date, parent.due_date]
               end
               def test_project_copy_should_copy_issue_tree
                 p = Project.create!(:name => 'Tree copy', :identifier => 'tree-copy', :tracker_ids => [1, 2])
                 i1 = create_issue!(:project_id => p.id, :subject => 'i1')
                 i2 = create_issue!(:project_id => p.id, :subject => 'i2', :parent_issue_id => i1.id)
                 i3 = create_issue!(:project_id => p.id, :subject => 'i3', :parent_issue_id => i1.id)
                 i4 = create_issue!(:project_id => p.id, :subject => 'i4', :parent_issue_id => i2.id)
                 i5 = create_issue!(:project_id => p.id, :subject => 'i5')
                 c = Project.new(:name => 'Copy', :identifier => 'copy', :tracker_ids => [1, 2])
                 c.copy(p, :only => 'issues')
                 c.reload
                 assert_equal 5, c.issues.count
                 ic1, ic2, ic3, ic4, ic5 = c.issues.find(:all, :order => 'subject')
                 assert ic1.root?
                 assert_equal ic1, ic2.parent
                 assert_equal ic1, ic3.parent
                 assert_equal ic2, ic4.parent
                 assert ic5.root?
               end
               # Helper that creates an issue with default attributes
               def create_issue!(attributes={})
                 Issue.create!({:project_id => 1, :tracker_id => 1, :author_id => 1, :subject => 'test'}.merge(attributes))
               end
             end

vendor/plugins/awesome_nested_set/lib/awesome_nested_set.rb +3 0

             module CollectiveIdea #:nodoc:
               module Acts #:nodoc:
                 module NestedSet #:nodoc:
                   def self.included(base)
                     base.extend(SingletonMethods)
                   end
                   # This acts provides Nested Set functionality. Nested Set is a smart way to implement
                   # an _ordered_ tree, with the added feature that you can select the children and all of their
                   # descendants with a single query. The drawback is that insertion or move need some complex
                   # sql queries. But everything is done here by this module!
                   #
                   # Nested sets are appropriate each time you want either an orderd tree (menus,
                   # commercial categories) or an efficient way of querying big trees (threaded posts).
                   #
                   # == API
                   #
                   # Methods names are aligned with acts_as_tree as much as possible, to make replacment from one
                   # by another easier, except for the creation:
                   #
                   # in acts_as_tree:
                   #   item.children.create(:name => "child1")
                   #
                   # in acts_as_nested_set:
                   #   # adds a new item at the "end" of the tree, i.e. with child.left = max(tree.right)+1
                   #   child = MyClass.new(:name => "child1")
                   #   child.save
                   #   # now move the item to its right place
                   #   child.move_to_child_of my_item
                   #
                   # You can pass an id or an object to:
                   # * <tt>#move_to_child_of</tt>
                   # * <tt>#move_to_right_of</tt>
                   # * <tt>#move_to_left_of</tt>
                   #
                   module SingletonMethods
                     # Configuration options are:
                     #
                     # * +:parent_column+ - specifies the column name to use for keeping the position integer (default: parent_id)
                     # * +:left_column+ - column name for left boundry data, default "lft"
                     # * +:right_column+ - column name for right boundry data, default "rgt"
                     # * +:scope+ - restricts what is to be considered a list. Given a symbol, it'll attach "_id"
                     #   (if it hasn't been already) and use that as the foreign key restriction. You
                     #   can also pass an array to scope by multiple attributes.
                     #   Example: <tt>acts_as_nested_set :scope => [:notable_id, :notable_type]</tt>
                     # * +:dependent+ - behavior for cascading destroy. If set to :destroy, all the
                     #   child objects are destroyed alongside this object by calling their destroy
                     #   method. If set to :delete_all (default), all the child objects are deleted
                     #   without calling their destroy method.
                     #
                     # See CollectiveIdea::Acts::NestedSet::ClassMethods for a list of class methods and
                     # CollectiveIdea::Acts::NestedSet::InstanceMethods for a list of instance methods added
                     # to acts_as_nested_set models
                     def acts_as_nested_set(options = {})
                       options = {
                         :parent_column => 'parent_id',
                         :left_column => 'lft',
                         :right_column => 'rgt',
                         :order => 'id',
                         :dependent => :delete_all, # or :destroy
                       }.merge(options)
                       if options[:scope].is_a?(Symbol) && options[:scope].to_s !~ /_id$/
                         options[:scope] = "#{options[:scope]}_id".intern
                       end
                       write_inheritable_attribute :acts_as_nested_set_options, options
                       class_inheritable_reader :acts_as_nested_set_options
                       include Comparable
                       include Columns
                       include InstanceMethods
                       extend Columns
                       extend ClassMethods
                       # no bulk assignment
                       attr_protected  left_column_name.intern,
                                       right_column_name.intern,
                                       parent_column_name.intern
                       before_create :set_default_left_and_right
                       before_destroy :prune_from_tree
                       # no assignment to structure fields
                       [left_column_name, right_column_name, parent_column_name].each do |column|
                         module_eval <<-"end_eval", __FILE__, __LINE__
                           def #{column}=(x)
                             raise ActiveRecord::ActiveRecordError, "Unauthorized assignment to #{column}: it's an internal field handled by acts_as_nested_set code, use move_to_* methods instead."
                           end
                         end_eval
                       end
                       named_scope :roots, :conditions => {parent_column_name => nil}, :order => quoted_left_column_name
                       named_scope :leaves, :conditions => "#{quoted_right_column_name} - #{quoted_left_column_name} = 1", :order => quoted_left_column_name
                       if self.respond_to?(:define_callbacks)
                         define_callbacks("before_move", "after_move")
                       end
                     end
                   end
                   module ClassMethods
                     # Returns the first root
                     def root
                       roots.find(:first)
                     end
                     def valid?
                       left_and_rights_valid? && no_duplicates_for_columns? && all_roots_valid?
                     end
                     def left_and_rights_valid?
                       count(
                         :joins => "LEFT OUTER JOIN #{quoted_table_name} AS parent ON " +
                           "#{quoted_table_name}.#{quoted_parent_column_name} = parent.#{primary_key}",
                         :conditions =>
                           "#{quoted_table_name}.#{quoted_left_column_name} IS NULL OR " +
                           "#{quoted_table_name}.#{quoted_right_column_name} IS NULL OR " +
                           "#{quoted_table_name}.#{quoted_left_column_name} >= " +
                             "#{quoted_table_name}.#{quoted_right_column_name} OR " +
                           "(#{quoted_table_name}.#{quoted_parent_column_name} IS NOT NULL AND " +
                             "(#{quoted_table_name}.#{quoted_left_column_name} <= parent.#{quoted_left_column_name} OR " +
                             "#{quoted_table_name}.#{quoted_right_column_name} >= parent.#{quoted_right_column_name}))"
                       ) == 0
                     end
                     def no_duplicates_for_columns?
                       scope_string = Array(acts_as_nested_set_options[:scope]).map do |c|
                         connection.quote_column_name(c)
                       end.push(nil).join(", ")
                       [quoted_left_column_name, quoted_right_column_name].all? do |column|
                         # No duplicates
                         find(:first,
                           :select => "#{scope_string}#{column}, COUNT(#{column})",
                           :group => "#{scope_string}#{column}
                             HAVING COUNT(#{column}) > 1").nil?
                       end
                     end
                     # Wrapper for each_root_valid? that can deal with scope.
                     def all_roots_valid?
                       if acts_as_nested_set_options[:scope]
                         roots(:group => scope_column_names).group_by{|record| scope_column_names.collect{|col| record.send(col.to_sym)}}.all? do |scope, grouped_roots|
                           each_root_valid?(grouped_roots)
                         end
                       else
                         each_root_valid?(roots)
                       end
                     end
                     def each_root_valid?(roots_to_validate)
                       left = right = 0
                       roots_to_validate.all? do |root|
                         (root.left > left && root.right > right).tap do
                           left = root.left
                           right = root.right
                         end
                       end
                     end
                     # Rebuilds the left & rights if unset or invalid.  Also very useful for converting from acts_as_tree.
                     def rebuild!
                       # Don't rebuild a valid tree.
                       return true if valid?
                       scope = lambda{|node|}
                       if acts_as_nested_set_options[:scope]
                         scope = lambda{|node|
                           scope_column_names.inject(""){|str, column_name|
                             str << "AND #{connection.quote_column_name(column_name)} = #{connection.quote(node.send(column_name.to_sym))} "
                           }
                         }
                       end
                       indices = {}
                       set_left_and_rights = lambda do |node|
                         # set left
                         node[left_column_name] = indices[scope.call(node)] += 1
                         # find
                         find(:all, :conditions => ["#{quoted_parent_column_name} = ? #{scope.call(node)}", node], :order => "#{quoted_left_column_name}, #{quoted_right_column_name}, #{acts_as_nested_set_options[:order]}").each{|n| set_left_and_rights.call(n) }
                         # set right
                         node[right_column_name] = indices[scope.call(node)] += 1
                         node.save!
                       end
                       # Find root node(s)
                       root_nodes = find(:all, :conditions => "#{quoted_parent_column_name} IS NULL", :order => "#{quoted_left_column_name}, #{quoted_right_column_name}, #{acts_as_nested_set_options[:order]}").each do |root_node|
                         # setup index for this scope
                         indices[scope.call(root_node)] ||= 0
                         set_left_and_rights.call(root_node)
                       end
                     end
                   end
                   # Mixed into both classes and instances to provide easy access to the column names
                   module Columns
                     def left_column_name
                       acts_as_nested_set_options[:left_column]
                     end
                     def right_column_name
                       acts_as_nested_set_options[:right_column]
                     end
                     def parent_column_name
                       acts_as_nested_set_options[:parent_column]
                     end
                     def scope_column_names
                       Array(acts_as_nested_set_options[:scope])
                     end
                     def quoted_left_column_name
                       connection.quote_column_name(left_column_name)
                     end
                     def quoted_right_column_name
                       connection.quote_column_name(right_column_name)
                     end
                     def quoted_parent_column_name
                       connection.quote_column_name(parent_column_name)
                     end
                     def quoted_scope_column_names
                       scope_column_names.collect {|column_name| connection.quote_column_name(column_name) }
                     end
                   end
                   # Any instance method that returns a collection makes use of Rails 2.1's named_scope (which is bundled for Rails 2.0), so it can be treated as a finder.
                   #
                   #   category.self_and_descendants.count
                   #   category.ancestors.find(:all, :conditions => "name like '%foo%'")
                   module InstanceMethods
                     # Value of the parent column
                     def parent_id
                       self[parent_column_name]
                     end
                     # Value of the left column
                     def left
                       self[left_column_name]
                     end
                     # Value of the right column
                     def right
                       self[right_column_name]
                     end
                     # Returns true if this is a root node.
                     def root?
                       parent_id.nil?
                     end
                     def leaf?
                       new_record? || (right - left == 1)
                     end
                     # Returns true is this is a child node
                     def child?
                       !parent_id.nil?
                     end
                     # order by left column
                     def <=>(x)
                       left <=> x.left
                     end
                     # Redefine to act like active record
                     def ==(comparison_object)
                       comparison_object.equal?(self) ||
                         (comparison_object.instance_of?(self.class) &&
                           comparison_object.id == id &&
                           !comparison_object.new_record?)
                     end
                     # Returns root
                     def root
                       self_and_ancestors.find(:first)
                     end
                     # Returns the immediate parent
                     def parent
                       nested_set_scope.find_by_id(parent_id) if parent_id
                     end
                     # Returns the array of all parents and self
                     def self_and_ancestors
                       nested_set_scope.scoped :conditions => [
                         "#{self.class.table_name}.#{quoted_left_column_name} <= ? AND #{self.class.table_name}.#{quoted_right_column_name} >= ?", left, right
                       ]
                     end
                     # Returns an array of all parents
                     def ancestors
                       without_self self_and_ancestors
                     end
                     # Returns the array of all children of the parent, including self
                     def self_and_siblings
                       nested_set_scope.scoped :conditions => {parent_column_name => parent_id}
                     end
                     # Returns the array of all children of the parent, except self
                     def siblings
                       without_self self_and_siblings
                     end
                     # Returns a set of all of its nested children which do not have children
                     def leaves
                       descendants.scoped :conditions => "#{self.class.table_name}.#{quoted_right_column_name} - #{self.class.table_name}.#{quoted_left_column_name} = 1"
                     end
                     # Returns the level of this object in the tree
                     # root level is 0
                     def level
                       parent_id.nil? ? 0 : ancestors.count
                     end
                     # Returns a set of itself and all of its nested children
                     def self_and_descendants
                       nested_set_scope.scoped :conditions => [
                         "#{self.class.table_name}.#{quoted_left_column_name} >= ? AND #{self.class.table_name}.#{quoted_right_column_name} <= ?", left, right
                       ]
                     end
                     # Returns a set of all of its children and nested children
                     def descendants
                       without_self self_and_descendants
                     end
                     # Returns a set of only this entry's immediate children
                     def children
                       nested_set_scope.scoped :conditions => {parent_column_name => self}
                     end
                     def is_descendant_of?(other)
                       other.left < self.left && self.left < other.right && same_scope?(other)
                     end
                     def is_or_is_descendant_of?(other)
                       other.left <= self.left && self.left < other.right && same_scope?(other)
                     end
                     def is_ancestor_of?(other)
                       self.left < other.left && other.left < self.right && same_scope?(other)
                     end
                     def is_or_is_ancestor_of?(other)
                       self.left <= other.left && other.left < self.right && same_scope?(other)
                     end
                     # Check if other model is in the same scope
                     def same_scope?(other)
                       Array(acts_as_nested_set_options[:scope]).all? do |attr|
                         self.send(attr) == other.send(attr)
                       end
                     end
                     # Find the first sibling to the left
                     def left_sibling
                       siblings.find(:first, :conditions => ["#{self.class.table_name}.#{quoted_left_column_name} < ?", left],
                         :order => "#{self.class.table_name}.#{quoted_left_column_name} DESC")
                     end
                     # Find the first sibling to the right
                     def right_sibling
                       siblings.find(:first, :conditions => ["#{self.class.table_name}.#{quoted_left_column_name} > ?", left])
                     end
                     # Shorthand method for finding the left sibling and moving to the left of it.
                     def move_left
                       move_to_left_of left_sibling
                     end
                     # Shorthand method for finding the right sibling and moving to the right of it.
                     def move_right
                       move_to_right_of right_sibling
                     end
                     # Move the node to the left of another node (you can pass id only)
                     def move_to_left_of(node)
                       move_to node, :left
                     end
                     # Move the node to the left of another node (you can pass id only)
                     def move_to_right_of(node)
                       move_to node, :right
                     end
                     # Move the node to the child of another node (you can pass id only)
                     def move_to_child_of(node)
                       move_to node, :child
                     end
                     # Move the node to root nodes
                     def move_to_root
                       move_to nil, :root
                     end
                     def move_possible?(target)
                       self != target && # Can't target self
                       same_scope?(target) && # can't be in different scopes
                       # !(left..right).include?(target.left..target.right) # this needs tested more
                       # detect impossible move
                       !((left <= target.left && right >= target.left) or (left <= target.right && right >= target.right))
                     end
                     def to_text
                       self_and_descendants.map do |node|
                         "#{'*'*(node.level+1)} #{node.id} #{node.to_s} (#{node.parent_id}, #{node.left}, #{node.right})"
                       end.join("\n")
                     end
                   protected
                     def without_self(scope)
                       scope.scoped :conditions => ["#{self.class.table_name}.#{self.class.primary_key} != ?", self]
                     end
                     # All nested set queries should use this nested_set_scope, which performs finds on
                     # the base ActiveRecord class, using the :scope declared in the acts_as_nested_set
                     # declaration.
                     def nested_set_scope
                       options = {:order => quoted_left_column_name}
                       scopes = Array(acts_as_nested_set_options[:scope])
                       options[:conditions] = scopes.inject({}) do |conditions,attr|
                         conditions.merge attr => self[attr]
                       end unless scopes.empty?
                       self.class.base_class.scoped options
                     end
                     # on creation, set automatically lft and rgt to the end of the tree
                     def set_default_left_and_right
                       maxright = nested_set_scope.maximum(right_column_name) || 0
                       # adds the new node to the right of all existing nodes
                       self[left_column_name] = maxright + 1
                       self[right_column_name] = maxright + 2
                     end
                     # Prunes a branch off of the tree, shifting all of the elements on the right
                     # back to the left so the counts still work.
                     def prune_from_tree
                       return if right.nil? || left.nil? || !self.class.exists?(id)
                       delete_method = acts_as_nested_set_options[:dependent] == :destroy ?
                         :destroy_all : :delete_all
                       self.class.base_class.transaction do
                         reload_nested_set
                         nested_set_scope.send(delete_method,
                           ["#{quoted_left_column_name} > ? AND #{quoted_right_column_name} < ?",
                             left, right]
                         )
                         reload_nested_set
                         diff = right - left + 1
                         nested_set_scope.update_all(
                           ["#{quoted_left_column_name} = (#{quoted_left_column_name} - ?)", diff],
                           ["#{quoted_left_column_name} >= ?", right]
                         )
                         nested_set_scope.update_all(
                           ["#{quoted_right_column_name} = (#{quoted_right_column_name} - ?)", diff],
                           ["#{quoted_right_column_name} >= ?", right]
                         )
                       end
+                      # Reload is needed because children may have updated their parent (self) during deletion.
+                      reload
                     end
                     # reload left, right, and parent
                     def reload_nested_set
                       reload(:select => "#{quoted_left_column_name}, " +
                         "#{quoted_right_column_name}, #{quoted_parent_column_name}")
                     end
                     def move_to(target, position)
                       raise ActiveRecord::ActiveRecordError, "You cannot move a new node" if self.new_record?
                       return if callback(:before_move) == false
                       transaction do
                         if target.is_a? self.class.base_class
                           target.reload_nested_set
                         elsif position != :root
                           # load object if node is not an object
                           target = nested_set_scope.find(target)
                         end
                         self.reload_nested_set
                         unless position == :root || move_possible?(target)
                           raise ActiveRecord::ActiveRecordError, "Impossible move, target node cannot be inside moved tree."
                         end
                         bound = case position
                           when :child;  target[right_column_name]
                           when :left;   target[left_column_name]
                           when :right;  target[right_column_name] + 1
                           when :root;   1
                           else raise ActiveRecord::ActiveRecordError, "Position should be :child, :left, :right or :root ('#{position}' received)."
                         end
                         if bound > self[right_column_name]
                           bound = bound - 1
                           other_bound = self[right_column_name] + 1
                         else
                           other_bound = self[left_column_name] - 1
                         end
                         # there would be no change
                         return if bound == self[right_column_name] || bound == self[left_column_name]
                         # we have defined the boundaries of two non-overlapping intervals,
                         # so sorting puts both the intervals and their boundaries in order
                         a, b, c, d = [self[left_column_name], self[right_column_name], bound, other_bound].sort
                         new_parent = case position
                           when :child;  target.id
                           when :root;   nil
                           else          target[parent_column_name]
                         end
                         self.class.base_class.update_all([
                           "#{quoted_left_column_name} = CASE " +
                             "WHEN #{quoted_left_column_name} BETWEEN :a AND :b " +
                               "THEN #{quoted_left_column_name} + :d - :b " +
                             "WHEN #{quoted_left_column_name} BETWEEN :c AND :d " +
                               "THEN #{quoted_left_column_name} + :a - :c " +
                             "ELSE #{quoted_left_column_name} END, " +
                           "#{quoted_right_column_name} = CASE " +
                             "WHEN #{quoted_right_column_name} BETWEEN :a AND :b " +
                               "THEN #{quoted_right_column_name} + :d - :b " +
                             "WHEN #{quoted_right_column_name} BETWEEN :c AND :d " +
                               "THEN #{quoted_right_column_name} + :a - :c " +
                             "ELSE #{quoted_right_column_name} END, " +
                           "#{quoted_parent_column_name} = CASE " +
                             "WHEN #{self.class.base_class.primary_key} = :id THEN :new_parent " +
                             "ELSE #{quoted_parent_column_name} END",
                           {:a => a, :b => b, :c => c, :d => d, :id => self.id, :new_parent => new_parent}
                         ], nested_set_scope.proxy_options[:conditions])
                       end
                       target.reload_nested_set if target
                       self.reload_nested_set
                       callback(:after_move)
                     end
                   end
                 end
               end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages