##// END OF EJS Templates
jro_apps » redmine
RSS
Rails 3.1 compatibility....
Jean-Philippe Lang -
r8953:64d843a4d715
parent child
Show More
Side by Side Unified
Context file:
r8953:64d843a4d715 Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,123 +1,126
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class AttachmentsController < ApplicationController
19 19 before_filter :find_project, :except => :upload
20 20 before_filter :file_readable, :read_authorize, :only => [:show, :download]
21 21 before_filter :delete_authorize, :only => :destroy
22 22 before_filter :authorize_global, :only => :upload
23 23
24 24 accept_api_auth :show, :download, :upload
25 25
26 26 def show
27 27 respond_to do |format|
28 28 format.html {
29 29 if @attachment.is_diff?
30 30 @diff = File.new(@attachment.diskfile, "rb").read
31 31 @diff_type = params[:type] || User.current.pref[:diff_type] || 'inline'
32 32 @diff_type = 'inline' unless %w(inline sbs).include?(@diff_type)
33 33 # Save diff type as user preference
34 34 if User.current.logged? && @diff_type != User.current.pref[:diff_type]
35 35 User.current.pref[:diff_type] = @diff_type
36 36 User.current.preference.save
37 37 end
38 38 render :action => 'diff'
39 39 elsif @attachment.is_text? && @attachment.filesize <= Setting.file_max_size_displayed.to_i.kilobyte
40 40 @content = File.new(@attachment.diskfile, "rb").read
41 41 render :action => 'file'
42 42 else
43 43 download
44 44 end
45 45 }
46 46 format.api
47 47 end
48 48 end
49 49
50 50 def download
51 51 if @attachment.container.is_a?(Version) || @attachment.container.is_a?(Project)
52 52 @attachment.increment_download
53 53 end
54 54
55 55 # images are sent inline
56 56 send_file @attachment.diskfile, :filename => filename_for_content_disposition(@attachment.filename),
57 57 :type => detect_content_type(@attachment),
58 58 :disposition => (@attachment.image? ? 'inline' : 'attachment')
59 59
60 60 end
61 61
62 62 def upload
63 63 # Make sure that API users get used to set this content type
64 64 # as it won't trigger Rails' automatic parsing of the request body for parameters
65 65 unless request.content_type == 'application/octet-stream'
66 66 render :nothing => true, :status => 406
67 67 return
68 68 end
69 69
70 70 @attachment = Attachment.new(:file => request.body)
71 71 @attachment.author = User.current
72 72 @attachment.filename = Redmine::Utils.random_hex(16)
73 73
74 74 if @attachment.save
75 75 respond_to do |format|
76 76 format.api { render :action => 'upload', :status => :created }
77 77 end
78 78 else
79 79 respond_to do |format|
80 80 format.api { render_validation_errors(@attachment) }
81 81 end
82 82 end
83 83 end
84 84
85 85 def destroy
86 if @attachment.container.respond_to?(:init_journal)
87 @attachment.container.init_journal(User.current)
88 end
86 89 # Make sure association callbacks are called
87 90 @attachment.container.attachments.delete(@attachment)
88 91 redirect_to :back
89 92 rescue ::ActionController::RedirectBackError
90 93 redirect_to :controller => 'projects', :action => 'show', :id => @project
91 94 end
92 95
93 96 private
94 97 def find_project
95 98 @attachment = Attachment.find(params[:id])
96 99 # Show 404 if the filename in the url is wrong
97 100 raise ActiveRecord::RecordNotFound if params[:filename] && params[:filename] != @attachment.filename
98 101 @project = @attachment.project
99 102 rescue ActiveRecord::RecordNotFound
100 103 render_404
101 104 end
102 105
103 106 # Checks that the file exists and is readable
104 107 def file_readable
105 108 @attachment.readable? ? true : render_404
106 109 end
107 110
108 111 def read_authorize
109 112 @attachment.visible? ? true : deny_access
110 113 end
111 114
112 115 def delete_authorize
113 116 @attachment.deletable? ? true : deny_access
114 117 end
115 118
116 119 def detect_content_type(attachment)
117 120 content_type = attachment.content_type
118 121 if content_type.blank?
119 122 content_type = Redmine::MimeType.of(attachment.filename)
120 123 end
121 124 content_type.to_s
122 125 end
123 126 end
Show file before | Show file after | Hide comments
@@ -1,1078 +1,1077
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class Issue < ActiveRecord::Base
19 19 include Redmine::SafeAttributes
20 20
21 21 belongs_to :project
22 22 belongs_to :tracker
23 23 belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
24 24 belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
25 25 belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
26 26 belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
27 27 belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
28 28 belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
29 29
30 30 has_many :journals, :as => :journalized, :dependent => :destroy
31 31 has_many :time_entries, :dependent => :delete_all
32 32 has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
33 33
34 34 has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
35 35 has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
36 36
37 37 acts_as_nested_set :scope => 'root_id', :dependent => :destroy
38 38 acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
39 39 acts_as_customizable
40 40 acts_as_watchable
41 41 acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
42 42 :include => [:project, :journals],
43 43 # sort by id so that limited eager loading doesn't break with postgresql
44 44 :order_column => "#{table_name}.id"
45 45 acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
46 46 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
47 47 :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
48 48
49 49 acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
50 50 :author_key => :author_id
51 51
52 52 DONE_RATIO_OPTIONS = %w(issue_field issue_status)
53 53
54 54 attr_reader :current_journal
55 55
56 56 validates_presence_of :subject, :priority, :project, :tracker, :author, :status
57 57
58 58 validates_length_of :subject, :maximum => 255
59 59 validates_inclusion_of :done_ratio, :in => 0..100
60 60 validates_numericality_of :estimated_hours, :allow_nil => true
61 61 validate :validate_issue
62 62
63 63 named_scope :visible, lambda {|*args| { :include => :project,
64 64 :conditions => Issue.visible_condition(args.shift || User.current, *args) } }
65 65
66 66 named_scope :open, lambda {|*args|
67 67 is_closed = args.size > 0 ? !args.first : false
68 68 {:conditions => ["#{IssueStatus.table_name}.is_closed = ?", is_closed], :include => :status}
69 69 }
70 70
71 71 named_scope :recently_updated, :order => "#{Issue.table_name}.updated_on DESC"
72 72 named_scope :with_limit, lambda { |limit| { :limit => limit} }
73 73 named_scope :on_active_project, :include => [:status, :project, :tracker],
74 74 :conditions => ["#{Project.table_name}.status=#{Project::STATUS_ACTIVE}"]
75 75
76 76 before_create :default_assign
77 77 before_save :close_duplicates, :update_done_ratio_from_issue_status
78 78 after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
79 79 after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
80 80 after_destroy :update_parent_attributes
81 81
82 82 # Returns a SQL conditions string used to find all issues visible by the specified user
83 83 def self.visible_condition(user, options={})
84 84 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
85 85 case role.issues_visibility
86 86 when 'all'
87 87 nil
88 88 when 'default'
89 89 user_ids = [user.id] + user.groups.map(&:id)
90 90 "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
91 91 when 'own'
92 92 user_ids = [user.id] + user.groups.map(&:id)
93 93 "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
94 94 else
95 95 '1=0'
96 96 end
97 97 end
98 98 end
99 99
100 100 # Returns true if usr or current user is allowed to view the issue
101 101 def visible?(usr=nil)
102 102 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
103 103 case role.issues_visibility
104 104 when 'all'
105 105 true
106 106 when 'default'
107 107 !self.is_private? || self.author == user || user.is_or_belongs_to?(assigned_to)
108 108 when 'own'
109 109 self.author == user || user.is_or_belongs_to?(assigned_to)
110 110 else
111 111 false
112 112 end
113 113 end
114 114 end
115 115
116 116 def initialize(attributes=nil, *args)
117 117 super
118 118 if new_record?
119 119 # set default values for new records only
120 120 self.status ||= IssueStatus.default
121 121 self.priority ||= IssuePriority.default
122 122 self.watcher_user_ids = []
123 123 end
124 124 end
125 125
126 126 # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
127 127 def available_custom_fields
128 128 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
129 129 end
130 130
131 131 # Copies attributes from another issue, arg can be an id or an Issue
132 132 def copy_from(arg, options={})
133 133 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
134 134 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
135 135 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
136 136 self.status = issue.status
137 137 self.author = User.current
138 138 unless options[:attachments] == false
139 139 self.attachments = issue.attachments.map do |attachement|
140 140 attachement.copy(:container => self)
141 141 end
142 142 end
143 143 @copied_from = issue
144 144 self
145 145 end
146 146
147 147 # Returns an unsaved copy of the issue
148 148 def copy(attributes=nil)
149 149 copy = self.class.new.copy_from(self)
150 150 copy.attributes = attributes if attributes
151 151 copy
152 152 end
153 153
154 154 # Returns true if the issue is a copy
155 155 def copy?
156 156 @copied_from.present?
157 157 end
158 158
159 159 # Moves/copies an issue to a new project and tracker
160 160 # Returns the moved/copied issue on success, false on failure
161 161 def move_to_project(new_project, new_tracker=nil, options={})
162 162 ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."
163 163
164 164 if options[:copy]
165 165 issue = self.copy
166 166 else
167 167 issue = self
168 168 end
169 169
170 170 issue.init_journal(User.current, options[:notes])
171 171
172 172 # Preserve previous behaviour
173 173 # #move_to_project doesn't change tracker automatically
174 174 issue.send :project=, new_project, true
175 175 if new_tracker
176 176 issue.tracker = new_tracker
177 177 end
178 178 # Allow bulk setting of attributes on the issue
179 179 if options[:attributes]
180 180 issue.attributes = options[:attributes]
181 181 end
182 182
183 183 issue.save ? issue : false
184 184 end
185 185
186 186 def status_id=(sid)
187 187 self.status = nil
188 188 write_attribute(:status_id, sid)
189 189 end
190 190
191 191 def priority_id=(pid)
192 192 self.priority = nil
193 193 write_attribute(:priority_id, pid)
194 194 end
195 195
196 196 def category_id=(cid)
197 197 self.category = nil
198 198 write_attribute(:category_id, cid)
199 199 end
200 200
201 201 def fixed_version_id=(vid)
202 202 self.fixed_version = nil
203 203 write_attribute(:fixed_version_id, vid)
204 204 end
205 205
206 206 def tracker_id=(tid)
207 207 self.tracker = nil
208 208 result = write_attribute(:tracker_id, tid)
209 209 @custom_field_values = nil
210 210 result
211 211 end
212 212
213 213 def project_id=(project_id)
214 214 if project_id.to_s != self.project_id.to_s
215 215 self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
216 216 end
217 217 end
218 218
219 219 def project=(project, keep_tracker=false)
220 220 project_was = self.project
221 221 write_attribute(:project_id, project ? project.id : nil)
222 222 association_instance_set('project', project)
223 223 if project_was && project && project_was != project
224 224 unless keep_tracker || project.trackers.include?(tracker)
225 225 self.tracker = project.trackers.first
226 226 end
227 227 # Reassign to the category with same name if any
228 228 if category
229 229 self.category = project.issue_categories.find_by_name(category.name)
230 230 end
231 231 # Keep the fixed_version if it's still valid in the new_project
232 232 if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
233 233 self.fixed_version = nil
234 234 end
235 235 if parent && parent.project_id != project_id
236 236 self.parent_issue_id = nil
237 237 end
238 238 @custom_field_values = nil
239 239 end
240 240 end
241 241
242 242 def description=(arg)
243 243 if arg.is_a?(String)
244 244 arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
245 245 end
246 246 write_attribute(:description, arg)
247 247 end
248 248
249 249 # Overrides attributes= so that project and tracker get assigned first
250 250 def attributes_with_project_and_tracker_first=(new_attributes, *args)
251 251 return if new_attributes.nil?
252 252 attrs = new_attributes.dup
253 253 attrs.stringify_keys!
254 254
255 255 %w(project project_id tracker tracker_id).each do |attr|
256 256 if attrs.has_key?(attr)
257 257 send "#{attr}=", attrs.delete(attr)
258 258 end
259 259 end
260 260 send :attributes_without_project_and_tracker_first=, attrs, *args
261 261 end
262 262 # Do not redefine alias chain on reload (see #4838)
263 263 alias_method_chain(:attributes=, :project_and_tracker_first) unless method_defined?(:attributes_without_project_and_tracker_first=)
264 264
265 265 def estimated_hours=(h)
266 266 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
267 267 end
268 268
269 269 safe_attributes 'project_id',
270 270 :if => lambda {|issue, user|
271 271 if issue.new_record?
272 272 issue.copy?
273 273 elsif user.allowed_to?(:move_issues, issue.project)
274 274 projects = Issue.allowed_target_projects_on_move(user)
275 275 projects.include?(issue.project) && projects.size > 1
276 276 end
277 277 }
278 278
279 279 safe_attributes 'tracker_id',
280 280 'status_id',
281 281 'category_id',
282 282 'assigned_to_id',
283 283 'priority_id',
284 284 'fixed_version_id',
285 285 'subject',
286 286 'description',
287 287 'start_date',
288 288 'due_date',
289 289 'done_ratio',
290 290 'estimated_hours',
291 291 'custom_field_values',
292 292 'custom_fields',
293 293 'lock_version',
294 294 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
295 295
296 296 safe_attributes 'status_id',
297 297 'assigned_to_id',
298 298 'fixed_version_id',
299 299 'done_ratio',
300 300 'lock_version',
301 301 :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
302 302
303 303 safe_attributes 'watcher_user_ids',
304 304 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
305 305
306 306 safe_attributes 'is_private',
307 307 :if => lambda {|issue, user|
308 308 user.allowed_to?(:set_issues_private, issue.project) ||
309 309 (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
310 310 }
311 311
312 312 safe_attributes 'parent_issue_id',
313 313 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
314 314 user.allowed_to?(:manage_subtasks, issue.project)}
315 315
316 316 # Safely sets attributes
317 317 # Should be called from controllers instead of #attributes=
318 318 # attr_accessible is too rough because we still want things like
319 319 # Issue.new(:project => foo) to work
320 320 def safe_attributes=(attrs, user=User.current)
321 321 return unless attrs.is_a?(Hash)
322 322
323 323 # User can change issue attributes only if he has :edit permission or if a workflow transition is allowed
324 324 attrs = delete_unsafe_attributes(attrs, user)
325 325 return if attrs.empty?
326 326
327 327 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
328 328 if p = attrs.delete('project_id')
329 329 if allowed_target_projects(user).collect(&:id).include?(p.to_i)
330 330 self.project_id = p
331 331 end
332 332 end
333 333
334 334 if t = attrs.delete('tracker_id')
335 335 self.tracker_id = t
336 336 end
337 337
338 338 if attrs['status_id']
339 339 unless new_statuses_allowed_to(user).collect(&:id).include?(attrs['status_id'].to_i)
340 340 attrs.delete('status_id')
341 341 end
342 342 end
343 343
344 344 unless leaf?
345 345 attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
346 346 end
347 347
348 348 if attrs['parent_issue_id'].present?
349 349 attrs.delete('parent_issue_id') unless Issue.visible(user).exists?(attrs['parent_issue_id'].to_i)
350 350 end
351 351
352 352 # mass-assignment security bypass
353 353 self.send :attributes=, attrs, false
354 354 end
355 355
356 356 def done_ratio
357 357 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
358 358 status.default_done_ratio
359 359 else
360 360 read_attribute(:done_ratio)
361 361 end
362 362 end
363 363
364 364 def self.use_status_for_done_ratio?
365 365 Setting.issue_done_ratio == 'issue_status'
366 366 end
367 367
368 368 def self.use_field_for_done_ratio?
369 369 Setting.issue_done_ratio == 'issue_field'
370 370 end
371 371
372 372 def validate_issue
373 373 if self.due_date.nil? && @attributes['due_date'] && !@attributes['due_date'].empty?
374 374 errors.add :due_date, :not_a_date
375 375 end
376 376
377 377 if self.due_date and self.start_date and self.due_date < self.start_date
378 378 errors.add :due_date, :greater_than_start_date
379 379 end
380 380
381 381 if start_date && soonest_start && start_date < soonest_start
382 382 errors.add :start_date, :invalid
383 383 end
384 384
385 385 if fixed_version
386 386 if !assignable_versions.include?(fixed_version)
387 387 errors.add :fixed_version_id, :inclusion
388 388 elsif reopened? && fixed_version.closed?
389 389 errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
390 390 end
391 391 end
392 392
393 393 # Checks that the issue can not be added/moved to a disabled tracker
394 394 if project && (tracker_id_changed? || project_id_changed?)
395 395 unless project.trackers.include?(tracker)
396 396 errors.add :tracker_id, :inclusion
397 397 end
398 398 end
399 399
400 400 # Checks parent issue assignment
401 401 if @parent_issue
402 402 if @parent_issue.project_id != project_id
403 403 errors.add :parent_issue_id, :not_same_project
404 404 elsif !new_record?
405 405 # moving an existing issue
406 406 if @parent_issue.root_id != root_id
407 407 # we can always move to another tree
408 408 elsif move_possible?(@parent_issue)
409 409 # move accepted inside tree
410 410 else
411 411 errors.add :parent_issue_id, :not_a_valid_parent
412 412 end
413 413 end
414 414 end
415 415 end
416 416
417 417 # Set the done_ratio using the status if that setting is set. This will keep the done_ratios
418 418 # even if the user turns off the setting later
419 419 def update_done_ratio_from_issue_status
420 420 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
421 421 self.done_ratio = status.default_done_ratio
422 422 end
423 423 end
424 424
425 425 def init_journal(user, notes = "")
426 426 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
427 427 if new_record?
428 428 @current_journal.notify = false
429 429 else
430 430 @attributes_before_change = attributes.dup
431 431 @custom_values_before_change = {}
432 432 self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
433 433 end
434 434 # Make sure updated_on is updated when adding a note.
435 435 updated_on_will_change!
436 436 @current_journal
437 437 end
438 438
439 439 # Returns the id of the last journal or nil
440 440 def last_journal_id
441 441 if new_record?
442 442 nil
443 443 else
444 444 journals.first(:order => "#{Journal.table_name}.id DESC").try(:id)
445 445 end
446 446 end
447 447
448 448 # Return true if the issue is closed, otherwise false
449 449 def closed?
450 450 self.status.is_closed?
451 451 end
452 452
453 453 # Return true if the issue is being reopened
454 454 def reopened?
455 455 if !new_record? && status_id_changed?
456 456 status_was = IssueStatus.find_by_id(status_id_was)
457 457 status_new = IssueStatus.find_by_id(status_id)
458 458 if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
459 459 return true
460 460 end
461 461 end
462 462 false
463 463 end
464 464
465 465 # Return true if the issue is being closed
466 466 def closing?
467 467 if !new_record? && status_id_changed?
468 468 status_was = IssueStatus.find_by_id(status_id_was)
469 469 status_new = IssueStatus.find_by_id(status_id)
470 470 if status_was && status_new && !status_was.is_closed? && status_new.is_closed?
471 471 return true
472 472 end
473 473 end
474 474 false
475 475 end
476 476
477 477 # Returns true if the issue is overdue
478 478 def overdue?
479 479 !due_date.nil? && (due_date < Date.today) && !status.is_closed?
480 480 end
481 481
482 482 # Is the amount of work done less than it should for the due date
483 483 def behind_schedule?
484 484 return false if start_date.nil? || due_date.nil?
485 485 done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
486 486 return done_date <= Date.today
487 487 end
488 488
489 489 # Does this issue have children?
490 490 def children?
491 491 !leaf?
492 492 end
493 493
494 494 # Users the issue can be assigned to
495 495 def assignable_users
496 496 users = project.assignable_users
497 497 users << author if author
498 498 users << assigned_to if assigned_to
499 499 users.uniq.sort
500 500 end
501 501
502 502 # Versions that the issue can be assigned to
503 503 def assignable_versions
504 504 @assignable_versions ||= (project.shared_versions.open + [Version.find_by_id(fixed_version_id_was)]).compact.uniq.sort
505 505 end
506 506
507 507 # Returns true if this issue is blocked by another issue that is still open
508 508 def blocked?
509 509 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
510 510 end
511 511
512 512 # Returns an array of status that user is able to apply
513 513 def new_statuses_allowed_to(user=User.current, include_default=false)
514 514 statuses = status.find_new_statuses_allowed_to(
515 515 user.admin ? Role.all : user.roles_for_project(project),
516 516 tracker,
517 517 author == user,
518 518 assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
519 519 )
520 520 statuses << status unless statuses.empty?
521 521 statuses << IssueStatus.default if include_default
522 522 statuses = statuses.uniq.sort
523 523 blocked? ? statuses.reject {|s| s.is_closed?} : statuses
524 524 end
525 525
526 526 def assigned_to_was
527 527 if assigned_to_id_changed? && assigned_to_id_was.present?
528 528 @assigned_to_was ||= User.find_by_id(assigned_to_id_was)
529 529 end
530 530 end
531 531
532 532 # Returns the mail adresses of users that should be notified
533 533 def recipients
534 534 notified = []
535 535 # Author and assignee are always notified unless they have been
536 536 # locked or don't want to be notified
537 537 notified << author if author
538 538 if assigned_to
539 539 notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
540 540 end
541 541 if assigned_to_was
542 542 notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
543 543 end
544 544 notified = notified.select {|u| u.active? && u.notify_about?(self)}
545 545
546 546 notified += project.notified_users
547 547 notified.uniq!
548 548 # Remove users that can not view the issue
549 549 notified.reject! {|user| !visible?(user)}
550 550 notified.collect(&:mail)
551 551 end
552 552
553 553 # Returns the number of hours spent on this issue
554 554 def spent_hours
555 555 @spent_hours ||= time_entries.sum(:hours) || 0
556 556 end
557 557
558 558 # Returns the total number of hours spent on this issue and its descendants
559 559 #
560 560 # Example:
561 561 # spent_hours => 0.0
562 562 # spent_hours => 50.2
563 563 def total_spent_hours
564 564 @total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",
565 565 :joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0
566 566 end
567 567
568 568 def relations
569 569 @relations ||= (relations_from + relations_to).sort
570 570 end
571 571
572 572 # Preloads relations for a collection of issues
573 573 def self.load_relations(issues)
574 574 if issues.any?
575 575 relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])
576 576 issues.each do |issue|
577 577 issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
578 578 end
579 579 end
580 580 end
581 581
582 582 # Preloads visible spent time for a collection of issues
583 583 def self.load_visible_spent_hours(issues, user=User.current)
584 584 if issues.any?
585 585 hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)
586 586 issues.each do |issue|
587 587 issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
588 588 end
589 589 end
590 590 end
591 591
592 592 # Finds an issue relation given its id.
593 593 def find_relation(relation_id)
594 594 IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])
595 595 end
596 596
597 597 def all_dependent_issues(except=[])
598 598 except << self
599 599 dependencies = []
600 600 relations_from.each do |relation|
601 601 if relation.issue_to && !except.include?(relation.issue_to)
602 602 dependencies << relation.issue_to
603 603 dependencies += relation.issue_to.all_dependent_issues(except)
604 604 end
605 605 end
606 606 dependencies
607 607 end
608 608
609 609 # Returns an array of issues that duplicate this one
610 610 def duplicates
611 611 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
612 612 end
613 613
614 614 # Returns the due date or the target due date if any
615 615 # Used on gantt chart
616 616 def due_before
617 617 due_date || (fixed_version ? fixed_version.effective_date : nil)
618 618 end
619 619
620 620 # Returns the time scheduled for this issue.
621 621 #
622 622 # Example:
623 623 # Start Date: 2/26/09, End Date: 3/04/09
624 624 # duration => 6
625 625 def duration
626 626 (start_date && due_date) ? due_date - start_date : 0
627 627 end
628 628
629 629 def soonest_start
630 630 @soonest_start ||= (
631 631 relations_to.collect{|relation| relation.successor_soonest_start} +
632 632 ancestors.collect(&:soonest_start)
633 633 ).compact.max
634 634 end
635 635
636 636 def reschedule_after(date)
637 637 return if date.nil?
638 638 if leaf?
639 639 if start_date.nil? || start_date < date
640 640 self.start_date, self.due_date = date, date + duration
641 641 begin
642 642 save
643 643 rescue ActiveRecord::StaleObjectError
644 644 reload
645 645 self.start_date, self.due_date = date, date + duration
646 646 save
647 647 end
648 648 end
649 649 else
650 650 leaves.each do |leaf|
651 651 leaf.reschedule_after(date)
652 652 end
653 653 end
654 654 end
655 655
656 656 def <=>(issue)
657 657 if issue.nil?
658 658 -1
659 659 elsif root_id != issue.root_id
660 660 (root_id || 0) <=> (issue.root_id || 0)
661 661 else
662 662 (lft || 0) <=> (issue.lft || 0)
663 663 end
664 664 end
665 665
666 666 def to_s
667 667 "#{tracker} ##{id}: #{subject}"
668 668 end
669 669
670 670 # Returns a string of css classes that apply to the issue
671 671 def css_classes
672 672 s = "issue status-#{status.position} priority-#{priority.position}"
673 673 s << ' closed' if closed?
674 674 s << ' overdue' if overdue?
675 675 s << ' child' if child?
676 676 s << ' parent' unless leaf?
677 677 s << ' private' if is_private?
678 678 s << ' created-by-me' if User.current.logged? && author_id == User.current.id
679 679 s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
680 680 s
681 681 end
682 682
683 683 # Saves an issue and a time_entry from the parameters
684 684 def save_issue_with_child_records(params, existing_time_entry=nil)
685 685 Issue.transaction do
686 686 if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
687 687 @time_entry = existing_time_entry || TimeEntry.new
688 688 @time_entry.project = project
689 689 @time_entry.issue = self
690 690 @time_entry.user = User.current
691 691 @time_entry.spent_on = User.current.today
692 692 @time_entry.attributes = params[:time_entry]
693 693 self.time_entries << @time_entry
694 694 end
695 695
696 696 # TODO: Rename hook
697 697 Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
698 698 if save
699 699 # TODO: Rename hook
700 700 Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
701 701 else
702 702 raise ActiveRecord::Rollback
703 703 end
704 704 end
705 705 end
706 706
707 707 # Unassigns issues from +version+ if it's no longer shared with issue's project
708 708 def self.update_versions_from_sharing_change(version)
709 709 # Update issues assigned to the version
710 710 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
711 711 end
712 712
713 713 # Unassigns issues from versions that are no longer shared
714 714 # after +project+ was moved
715 715 def self.update_versions_from_hierarchy_change(project)
716 716 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
717 717 # Update issues of the moved projects and issues assigned to a version of a moved project
718 718 Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
719 719 end
720 720
721 721 def parent_issue_id=(arg)
722 722 parent_issue_id = arg.blank? ? nil : arg.to_i
723 723 if parent_issue_id && @parent_issue = Issue.find_by_id(parent_issue_id)
724 724 @parent_issue.id
725 725 else
726 726 @parent_issue = nil
727 727 nil
728 728 end
729 729 end
730 730
731 731 def parent_issue_id
732 732 if instance_variable_defined? :@parent_issue
733 733 @parent_issue.nil? ? nil : @parent_issue.id
734 734 else
735 735 parent_id
736 736 end
737 737 end
738 738
739 739 # Extracted from the ReportsController.
740 740 def self.by_tracker(project)
741 741 count_and_group_by(:project => project,
742 742 :field => 'tracker_id',
743 743 :joins => Tracker.table_name)
744 744 end
745 745
746 746 def self.by_version(project)
747 747 count_and_group_by(:project => project,
748 748 :field => 'fixed_version_id',
749 749 :joins => Version.table_name)
750 750 end
751 751
752 752 def self.by_priority(project)
753 753 count_and_group_by(:project => project,
754 754 :field => 'priority_id',
755 755 :joins => IssuePriority.table_name)
756 756 end
757 757
758 758 def self.by_category(project)
759 759 count_and_group_by(:project => project,
760 760 :field => 'category_id',
761 761 :joins => IssueCategory.table_name)
762 762 end
763 763
764 764 def self.by_assigned_to(project)
765 765 count_and_group_by(:project => project,
766 766 :field => 'assigned_to_id',
767 767 :joins => User.table_name)
768 768 end
769 769
770 770 def self.by_author(project)
771 771 count_and_group_by(:project => project,
772 772 :field => 'author_id',
773 773 :joins => User.table_name)
774 774 end
775 775
776 776 def self.by_subproject(project)
777 777 ActiveRecord::Base.connection.select_all("select s.id as status_id,
778 778 s.is_closed as closed,
779 779 #{Issue.table_name}.project_id as project_id,
780 780 count(#{Issue.table_name}.id) as total
781 781 from
782 782 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
783 783 where
784 784 #{Issue.table_name}.status_id=s.id
785 785 and #{Issue.table_name}.project_id = #{Project.table_name}.id
786 786 and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
787 787 and #{Issue.table_name}.project_id <> #{project.id}
788 788 group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
789 789 end
790 790 # End ReportsController extraction
791 791
792 792 # Returns an array of projects that user can assign the issue to
793 793 def allowed_target_projects(user=User.current)
794 794 if new_record?
795 795 Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))
796 796 else
797 797 self.class.allowed_target_projects_on_move(user)
798 798 end
799 799 end
800 800
801 801 # Returns an array of projects that user can move issues to
802 802 def self.allowed_target_projects_on_move(user=User.current)
803 803 projects = []
804 804 if user.admin?
805 805 # admin is allowed to move issues to any active (visible) project
806 806 projects = Project.visible(user).all
807 807 elsif user.logged?
808 808 if Role.non_member.allowed_to?(:move_issues)
809 809 projects = Project.visible(user).all
810 810 else
811 811 user.memberships.each {|m| projects << m.project if m.roles.detect {|r| r.allowed_to?(:move_issues)}}
812 812 end
813 813 end
814 814 projects
815 815 end
816 816
817 817 private
818 818
819 819 def after_project_change
820 820 # Update project_id on related time entries
821 821 TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})
822 822
823 823 # Delete issue relations
824 824 unless Setting.cross_project_issue_relations?
825 825 relations_from.clear
826 826 relations_to.clear
827 827 end
828 828
829 829 # Move subtasks
830 830 children.each do |child|
831 831 # Change project and keep project
832 832 child.send :project=, project, true
833 833 unless child.save
834 834 raise ActiveRecord::Rollback
835 835 end
836 836 end
837 837 end
838 838
839 839 def update_nested_set_attributes
840 840 if root_id.nil?
841 841 # issue was just created
842 842 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
843 843 set_default_left_and_right
844 844 Issue.update_all("root_id = #{root_id}, lft = #{lft}, rgt = #{rgt}", ["id = ?", id])
845 845 if @parent_issue
846 846 move_to_child_of(@parent_issue)
847 847 end
848 848 reload
849 849 elsif parent_issue_id != parent_id
850 850 former_parent_id = parent_id
851 851 # moving an existing issue
852 852 if @parent_issue && @parent_issue.root_id == root_id
853 853 # inside the same tree
854 854 move_to_child_of(@parent_issue)
855 855 else
856 856 # to another tree
857 857 unless root?
858 858 move_to_right_of(root)
859 859 reload
860 860 end
861 861 old_root_id = root_id
862 862 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
863 863 target_maxright = nested_set_scope.maximum(right_column_name) || 0
864 864 offset = target_maxright + 1 - lft
865 865 Issue.update_all("root_id = #{root_id}, lft = lft + #{offset}, rgt = rgt + #{offset}",
866 866 ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
867 867 self[left_column_name] = lft + offset
868 868 self[right_column_name] = rgt + offset
869 869 if @parent_issue
870 870 move_to_child_of(@parent_issue)
871 871 end
872 872 end
873 873 reload
874 874 # delete invalid relations of all descendants
875 875 self_and_descendants.each do |issue|
876 876 issue.relations.each do |relation|
877 877 relation.destroy unless relation.valid?
878 878 end
879 879 end
880 880 # update former parent
881 881 recalculate_attributes_for(former_parent_id) if former_parent_id
882 882 end
883 883 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
884 884 end
885 885
886 886 def update_parent_attributes
887 887 recalculate_attributes_for(parent_id) if parent_id
888 888 end
889 889
890 890 def recalculate_attributes_for(issue_id)
891 891 if issue_id && p = Issue.find_by_id(issue_id)
892 892 # priority = highest priority of children
893 893 if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)
894 894 p.priority = IssuePriority.find_by_position(priority_position)
895 895 end
896 896
897 897 # start/due dates = lowest/highest dates of children
898 898 p.start_date = p.children.minimum(:start_date)
899 899 p.due_date = p.children.maximum(:due_date)
900 900 if p.start_date && p.due_date && p.due_date < p.start_date
901 901 p.start_date, p.due_date = p.due_date, p.start_date
902 902 end
903 903
904 904 # done ratio = weighted average ratio of leaves
905 905 unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
906 906 leaves_count = p.leaves.count
907 907 if leaves_count > 0
908 908 average = p.leaves.average(:estimated_hours).to_f
909 909 if average == 0
910 910 average = 1
911 911 end
912 912 done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f
913 913 progress = done / (average * leaves_count)
914 914 p.done_ratio = progress.round
915 915 end
916 916 end
917 917
918 918 # estimate = sum of leaves estimates
919 919 p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
920 920 p.estimated_hours = nil if p.estimated_hours == 0.0
921 921
922 922 # ancestors will be recursively updated
923 923 p.save(false)
924 924 end
925 925 end
926 926
927 927 # Update issues so their versions are not pointing to a
928 928 # fixed_version that is not shared with the issue's project
929 929 def self.update_versions(conditions=nil)
930 930 # Only need to update issues with a fixed_version from
931 931 # a different project and that is not systemwide shared
932 932 Issue.scoped(:conditions => conditions).all(
933 933 :conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +
934 934 " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
935 935 " AND #{Version.table_name}.sharing <> 'system'",
936 936 :include => [:project, :fixed_version]
937 937 ).each do |issue|
938 938 next if issue.project.nil? || issue.fixed_version.nil?
939 939 unless issue.project.shared_versions.include?(issue.fixed_version)
940 940 issue.init_journal(User.current)
941 941 issue.fixed_version = nil
942 942 issue.save
943 943 end
944 944 end
945 945 end
946 946
947 947 # Callback on attachment deletion
948 948 def attachment_added(obj)
949 949 if @current_journal && !obj.new_record?
950 950 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
951 951 end
952 952 end
953 953
954 954 # Callback on attachment deletion
955 955 def attachment_removed(obj)
956 journal = init_journal(User.current)
957 journal.details << JournalDetail.new(:property => 'attachment',
958 :prop_key => obj.id,
959 :old_value => obj.filename)
960 journal.save
956 if @current_journal && !obj.new_record?
957 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)
958 @current_journal.save
959 end
961 960 end
962 961
963 962 # Default assignment based on category
964 963 def default_assign
965 964 if assigned_to.nil? && category && category.assigned_to
966 965 self.assigned_to = category.assigned_to
967 966 end
968 967 end
969 968
970 969 # Updates start/due dates of following issues
971 970 def reschedule_following_issues
972 971 if start_date_changed? || due_date_changed?
973 972 relations_from.each do |relation|
974 973 relation.set_issue_to_dates
975 974 end
976 975 end
977 976 end
978 977
979 978 # Closes duplicates if the issue is being closed
980 979 def close_duplicates
981 980 if closing?
982 981 duplicates.each do |duplicate|
983 982 # Reload is need in case the duplicate was updated by a previous duplicate
984 983 duplicate.reload
985 984 # Don't re-close it if it's already closed
986 985 next if duplicate.closed?
987 986 # Same user and notes
988 987 if @current_journal
989 988 duplicate.init_journal(@current_journal.user, @current_journal.notes)
990 989 end
991 990 duplicate.update_attribute :status, self.status
992 991 end
993 992 end
994 993 end
995 994
996 995 # Saves the changes in a Journal
997 996 # Called after_save
998 997 def create_journal
999 998 if @current_journal
1000 999 # attributes changes
1001 1000 if @attributes_before_change
1002 1001 (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on)).each {|c|
1003 1002 before = @attributes_before_change[c]
1004 1003 after = send(c)
1005 1004 next if before == after || (before.blank? && after.blank?)
1006 1005 @current_journal.details << JournalDetail.new(:property => 'attr',
1007 1006 :prop_key => c,
1008 1007 :old_value => before,
1009 1008 :value => after)
1010 1009 }
1011 1010 end
1012 1011 if @custom_values_before_change
1013 1012 # custom fields changes
1014 1013 custom_field_values.each {|c|
1015 1014 before = @custom_values_before_change[c.custom_field_id]
1016 1015 after = c.value
1017 1016 next if before == after || (before.blank? && after.blank?)
1018 1017
1019 1018 if before.is_a?(Array) || after.is_a?(Array)
1020 1019 before = [before] unless before.is_a?(Array)
1021 1020 after = [after] unless after.is_a?(Array)
1022 1021
1023 1022 # values removed
1024 1023 (before - after).reject(&:blank?).each do |value|
1025 1024 @current_journal.details << JournalDetail.new(:property => 'cf',
1026 1025 :prop_key => c.custom_field_id,
1027 1026 :old_value => value,
1028 1027 :value => nil)
1029 1028 end
1030 1029 # values added
1031 1030 (after - before).reject(&:blank?).each do |value|
1032 1031 @current_journal.details << JournalDetail.new(:property => 'cf',
1033 1032 :prop_key => c.custom_field_id,
1034 1033 :old_value => nil,
1035 1034 :value => value)
1036 1035 end
1037 1036 else
1038 1037 @current_journal.details << JournalDetail.new(:property => 'cf',
1039 1038 :prop_key => c.custom_field_id,
1040 1039 :old_value => before,
1041 1040 :value => after)
1042 1041 end
1043 1042 }
1044 1043 end
1045 1044 @current_journal.save
1046 1045 # reset current journal
1047 1046 init_journal @current_journal.user, @current_journal.notes
1048 1047 end
1049 1048 end
1050 1049
1051 1050 # Query generator for selecting groups of issue counts for a project
1052 1051 # based on specific criteria
1053 1052 #
1054 1053 # Options
1055 1054 # * project - Project to search in.
1056 1055 # * field - String. Issue field to key off of in the grouping.
1057 1056 # * joins - String. The table name to join against.
1058 1057 def self.count_and_group_by(options)
1059 1058 project = options.delete(:project)
1060 1059 select_field = options.delete(:field)
1061 1060 joins = options.delete(:joins)
1062 1061
1063 1062 where = "#{Issue.table_name}.#{select_field}=j.id"
1064 1063
1065 1064 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1066 1065 s.is_closed as closed,
1067 1066 j.id as #{select_field},
1068 1067 count(#{Issue.table_name}.id) as total
1069 1068 from
1070 1069 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
1071 1070 where
1072 1071 #{Issue.table_name}.status_id=s.id
1073 1072 and #{where}
1074 1073 and #{Issue.table_name}.project_id=#{Project.table_name}.id
1075 1074 and #{visible_condition(User.current, :project => project)}
1076 1075 group by s.id, s.is_closed, j.id")
1077 1076 end
1078 1077 end
Show file before | Show file after | Hide comments
@@ -1,313 +1,316
1 1 # encoding: utf-8
2 2 #
3 3 # Redmine - project management software
4 4 # Copyright (C) 2006-2011 Jean-Philippe Lang
5 5 #
6 6 # This program is free software; you can redistribute it and/or
7 7 # modify it under the terms of the GNU General Public License
8 8 # as published by the Free Software Foundation; either version 2
9 9 # of the License, or (at your option) any later version.
10 10 #
11 11 # This program is distributed in the hope that it will be useful,
12 12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
13 13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 14 # GNU General Public License for more details.
15 15 #
16 16 # You should have received a copy of the GNU General Public License
17 17 # along with this program; if not, write to the Free Software
18 18 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
19 19
20 20 require File.expand_path('../../test_helper', __FILE__)
21 21 require 'attachments_controller'
22 22
23 23 # Re-raise errors caught by the controller.
24 24 class AttachmentsController; def rescue_action(e) raise e end; end
25 25
26 26 class AttachmentsControllerTest < ActionController::TestCase
27 27 fixtures :users, :projects, :roles, :members, :member_roles,
28 28 :enabled_modules, :issues, :trackers, :attachments,
29 29 :versions, :wiki_pages, :wikis, :documents
30 30
31 31 def setup
32 32 @controller = AttachmentsController.new
33 33 @request = ActionController::TestRequest.new
34 34 @response = ActionController::TestResponse.new
35 35 User.current = nil
36 36 set_fixtures_attachments_directory
37 37 end
38 38
39 39 def teardown
40 40 set_tmp_attachments_directory
41 41 end
42 42
43 43 def test_show_diff
44 44 ['inline', 'sbs'].each do |dt|
45 45 # 060719210727_changeset_utf8.diff
46 46 get :show, :id => 14, :type => dt
47 47 assert_response :success
48 48 assert_template 'diff'
49 49 assert_equal 'text/html', @response.content_type
50 50 assert_tag 'th',
51 51 :attributes => {:class => /filename/},
52 52 :content => /issues_controller.rb\t\(rΓ©vision 1484\)/
53 53 assert_tag 'td',
54 54 :attributes => {:class => /line-code/},
55 55 :content => /Demande créée avec succès/
56 56 end
57 57 set_tmp_attachments_directory
58 58 end
59 59
60 60 def test_show_diff_replcace_cannot_convert_content
61 61 with_settings :repositories_encodings => 'UTF-8' do
62 62 ['inline', 'sbs'].each do |dt|
63 63 # 060719210727_changeset_iso8859-1.diff
64 64 get :show, :id => 5, :type => dt
65 65 assert_response :success
66 66 assert_template 'diff'
67 67 assert_equal 'text/html', @response.content_type
68 68 assert_tag 'th',
69 69 :attributes => {:class => "filename"},
70 70 :content => /issues_controller.rb\t\(r\?vision 1484\)/
71 71 assert_tag 'td',
72 72 :attributes => {:class => /line-code/},
73 73 :content => /Demande cr\?\?e avec succ\?s/
74 74 end
75 75 end
76 76 set_tmp_attachments_directory
77 77 end
78 78
79 79 def test_show_diff_latin_1
80 80 with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do
81 81 ['inline', 'sbs'].each do |dt|
82 82 # 060719210727_changeset_iso8859-1.diff
83 83 get :show, :id => 5, :type => dt
84 84 assert_response :success
85 85 assert_template 'diff'
86 86 assert_equal 'text/html', @response.content_type
87 87 assert_tag 'th',
88 88 :attributes => {:class => "filename"},
89 89 :content => /issues_controller.rb\t\(rΓ©vision 1484\)/
90 90 assert_tag 'td',
91 91 :attributes => {:class => /line-code/},
92 92 :content => /Demande créée avec succès/
93 93 end
94 94 end
95 95 set_tmp_attachments_directory
96 96 end
97 97
98 98 def test_save_diff_type
99 99 @request.session[:user_id] = 1 # admin
100 100 user = User.find(1)
101 101 get :show, :id => 5
102 102 assert_response :success
103 103 assert_template 'diff'
104 104 user.reload
105 105 assert_equal "inline", user.pref[:diff_type]
106 106 get :show, :id => 5, :type => 'sbs'
107 107 assert_response :success
108 108 assert_template 'diff'
109 109 user.reload
110 110 assert_equal "sbs", user.pref[:diff_type]
111 111 end
112 112
113 113 def test_show_text_file
114 114 get :show, :id => 4
115 115 assert_response :success
116 116 assert_template 'file'
117 117 assert_equal 'text/html', @response.content_type
118 118 set_tmp_attachments_directory
119 119 end
120 120
121 121 def test_show_text_file_utf_8
122 122 set_tmp_attachments_directory
123 123 a = Attachment.new(:container => Issue.find(1),
124 124 :file => uploaded_test_file("japanese-utf-8.txt", "text/plain"),
125 125 :author => User.find(1))
126 126 assert a.save
127 127 assert_equal 'japanese-utf-8.txt', a.filename
128 128
129 129 str_japanese = "\xe6\x97\xa5\xe6\x9c\xac\xe8\xaa\x9e"
130 130 str_japanese.force_encoding('UTF-8') if str_japanese.respond_to?(:force_encoding)
131 131
132 132 get :show, :id => a.id
133 133 assert_response :success
134 134 assert_template 'file'
135 135 assert_equal 'text/html', @response.content_type
136 136 assert_tag :tag => 'th',
137 137 :content => '1',
138 138 :attributes => { :class => 'line-num' },
139 139 :sibling => { :tag => 'td', :content => /#{str_japanese}/ }
140 140 end
141 141
142 142 def test_show_text_file_replcace_cannot_convert_content
143 143 set_tmp_attachments_directory
144 144 with_settings :repositories_encodings => 'UTF-8' do
145 145 a = Attachment.new(:container => Issue.find(1),
146 146 :file => uploaded_test_file("iso8859-1.txt", "text/plain"),
147 147 :author => User.find(1))
148 148 assert a.save
149 149 assert_equal 'iso8859-1.txt', a.filename
150 150
151 151 get :show, :id => a.id
152 152 assert_response :success
153 153 assert_template 'file'
154 154 assert_equal 'text/html', @response.content_type
155 155 assert_tag :tag => 'th',
156 156 :content => '7',
157 157 :attributes => { :class => 'line-num' },
158 158 :sibling => { :tag => 'td', :content => /Demande cr\?\?e avec succ\?s/ }
159 159 end
160 160 end
161 161
162 162 def test_show_text_file_latin_1
163 163 set_tmp_attachments_directory
164 164 with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do
165 165 a = Attachment.new(:container => Issue.find(1),
166 166 :file => uploaded_test_file("iso8859-1.txt", "text/plain"),
167 167 :author => User.find(1))
168 168 assert a.save
169 169 assert_equal 'iso8859-1.txt', a.filename
170 170
171 171 get :show, :id => a.id
172 172 assert_response :success
173 173 assert_template 'file'
174 174 assert_equal 'text/html', @response.content_type
175 175 assert_tag :tag => 'th',
176 176 :content => '7',
177 177 :attributes => { :class => 'line-num' },
178 178 :sibling => { :tag => 'td', :content => /Demande créée avec succès/ }
179 179 end
180 180 end
181 181
182 182 def test_show_text_file_should_send_if_too_big
183 183 Setting.file_max_size_displayed = 512
184 184 Attachment.find(4).update_attribute :filesize, 754.kilobyte
185 185
186 186 get :show, :id => 4
187 187 assert_response :success
188 188 assert_equal 'application/x-ruby', @response.content_type
189 189 set_tmp_attachments_directory
190 190 end
191 191
192 192 def test_show_other
193 193 get :show, :id => 6
194 194 assert_response :success
195 195 assert_equal 'application/octet-stream', @response.content_type
196 196 set_tmp_attachments_directory
197 197 end
198 198
199 199 def test_show_file_from_private_issue_without_permission
200 200 get :show, :id => 15
201 201 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2F15'
202 202 set_tmp_attachments_directory
203 203 end
204 204
205 205 def test_show_file_from_private_issue_with_permission
206 206 @request.session[:user_id] = 2
207 207 get :show, :id => 15
208 208 assert_response :success
209 209 assert_tag 'h2', :content => /private.diff/
210 210 set_tmp_attachments_directory
211 211 end
212 212
213 213 def test_show_file_without_container_should_be_denied
214 214 set_tmp_attachments_directory
215 215 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
216 216
217 217 @request.session[:user_id] = 2
218 218 get :show, :id => attachment.id
219 219 assert_response 403
220 220 end
221 221
222 222 def test_show_invalid_should_respond_with_404
223 223 get :show, :id => 999
224 224 assert_response 404
225 225 end
226 226
227 227 def test_download_text_file
228 228 get :download, :id => 4
229 229 assert_response :success
230 230 assert_equal 'application/x-ruby', @response.content_type
231 231 set_tmp_attachments_directory
232 232 end
233 233
234 234 def test_download_version_file_with_issue_tracking_disabled
235 235 Project.find(1).disable_module! :issue_tracking
236 236 get :download, :id => 9
237 237 assert_response :success
238 238 end
239 239
240 240 def test_download_should_assign_content_type_if_blank
241 241 Attachment.find(4).update_attribute(:content_type, '')
242 242
243 243 get :download, :id => 4
244 244 assert_response :success
245 245 assert_equal 'text/x-ruby', @response.content_type
246 246 set_tmp_attachments_directory
247 247 end
248 248
249 249 def test_download_missing_file
250 250 get :download, :id => 2
251 251 assert_response 404
252 252 set_tmp_attachments_directory
253 253 end
254 254
255 255 def test_anonymous_on_private_private
256 256 get :download, :id => 7
257 257 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2Fdownload%2F7'
258 258 set_tmp_attachments_directory
259 259 end
260 260
261 261 def test_destroy_issue_attachment
262 262 set_tmp_attachments_directory
263 263 issue = Issue.find(3)
264 264 @request.session[:user_id] = 2
265 265
266 266 assert_difference 'issue.attachments.count', -1 do
267 delete :destroy, :id => 1
267 assert_difference 'Journal.count' do
268 delete :destroy, :id => 1
269 assert_redirected_to '/projects/ecookbook'
270 end
268 271 end
269 # no referrer
270 assert_redirected_to '/projects/ecookbook'
271 272 assert_nil Attachment.find_by_id(1)
272 j = issue.journals.find(:first, :order => 'created_on DESC')
273 j = Journal.first(:order => 'id DESC')
274 assert_equal issue, j.journalized
273 275 assert_equal 'attachment', j.details.first.property
274 276 assert_equal '1', j.details.first.prop_key
275 277 assert_equal 'error281.txt', j.details.first.old_value
278 assert_equal User.find(2), j.user
276 279 end
277 280
278 281 def test_destroy_wiki_page_attachment
279 282 set_tmp_attachments_directory
280 283 @request.session[:user_id] = 2
281 284 assert_difference 'Attachment.count', -1 do
282 285 delete :destroy, :id => 3
283 286 assert_response 302
284 287 end
285 288 end
286 289
287 290 def test_destroy_project_attachment
288 291 set_tmp_attachments_directory
289 292 @request.session[:user_id] = 2
290 293 assert_difference 'Attachment.count', -1 do
291 294 delete :destroy, :id => 8
292 295 assert_response 302
293 296 end
294 297 end
295 298
296 299 def test_destroy_version_attachment
297 300 set_tmp_attachments_directory
298 301 @request.session[:user_id] = 2
299 302 assert_difference 'Attachment.count', -1 do
300 303 delete :destroy, :id => 9
301 304 assert_response 302
302 305 end
303 306 end
304 307
305 308 def test_destroy_without_permission
306 309 set_tmp_attachments_directory
307 310 assert_no_difference 'Attachment.count' do
308 311 delete :destroy, :id => 3
309 312 end
310 313 assert_response 302
311 314 assert Attachment.find_by_id(3)
312 315 end
313 316 end
General Comments 0
You need to be logged in to leave comments. Login now