jro_apps/redmine Commit - r14237:64a80066bd86

Error message when editing a child project without add project/subprojects permissions (#20282)....

Jean-Philippe Lang -

r14237:64a80066bd86

parent child

Context file:

r14237:64a80066bd86

Collapse all files

app/models/project.rb +8 -6

              # Redmine - project management software
              # Copyright (C) 2006-2015  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              class Project < ActiveRecord::Base
                include Redmine::SafeAttributes
                include Redmine::NestedSet::ProjectNestedSet
                # Project statuses
                STATUS_ACTIVE     = 1
                STATUS_CLOSED     = 5
                STATUS_ARCHIVED   = 9
                # Maximum length for project identifiers
                IDENTIFIER_MAX_LENGTH = 100
                # Specific overridden Activities
                has_many :time_entry_activities
                has_many :memberships, :class_name => 'Member', :inverse_of => :project
                # Memberships of active users only
                has_many :members,
                         lambda { joins(:principal).where(:users => {:type => 'User', :status => Principal::STATUS_ACTIVE}) }
                has_many :enabled_modules, :dependent => :delete_all
                has_and_belongs_to_many :trackers, lambda {order(:position)}
                has_many :issues, :dependent => :destroy
                has_many :issue_changes, :through => :issues, :source => :journals
                has_many :versions, lambda {order("#{Version.table_name}.effective_date DESC, #{Version.table_name}.name DESC")}, :dependent => :destroy
                has_many :time_entries, :dependent => :destroy
                has_many :queries, :class_name => 'IssueQuery', :dependent => :delete_all
                has_many :documents, :dependent => :destroy
                has_many :news, lambda {includes(:author)}, :dependent => :destroy
                has_many :issue_categories, lambda {order("#{IssueCategory.table_name}.name")}, :dependent => :delete_all
                has_many :boards, lambda {order("position ASC")}, :dependent => :destroy
                has_one :repository, lambda {where(["is_default = ?", true])}
                has_many :repositories, :dependent => :destroy
                has_many :changesets, :through => :repository
                has_one :wiki, :dependent => :destroy
                # Custom field for the project issues
                has_and_belongs_to_many :issue_custom_fields,
                                        lambda {order("#{CustomField.table_name}.position")},
                                        :class_name => 'IssueCustomField',
                                        :join_table => "#{table_name_prefix}custom_fields_projects#{table_name_suffix}",
                                        :association_foreign_key => 'custom_field_id'
                acts_as_attachable :view_permission => :view_files,
                                   :edit_permission => :manage_files,
                                   :delete_permission => :manage_files
                acts_as_customizable
                acts_as_searchable :columns => ['name', 'identifier', 'description'], :project_key => "#{Project.table_name}.id", :permission => nil
                acts_as_event :title => Proc.new {|o| "#{l(:label_project)}: #{o.name}"},
                              :url => Proc.new {|o| {:controller => 'projects', :action => 'show', :id => o}},
                              :author => nil
                attr_protected :status
                validates_presence_of :name, :identifier
                validates_uniqueness_of :identifier, :if => Proc.new {|p| p.identifier_changed?}
                validates_length_of :name, :maximum => 255
                validates_length_of :homepage, :maximum => 255
                validates_length_of :identifier, :in => 1..IDENTIFIER_MAX_LENGTH
                # downcase letters, digits, dashes but not digits only
                validates_format_of :identifier, :with => /\A(?!\d+$)[a-z0-9\-_]*\z/, :if => Proc.new { |p| p.identifier_changed? }
                # reserved words
                validates_exclusion_of :identifier, :in => %w( new )
                validate :validate_parent
                after_save :update_inherited_members, :if => Proc.new {|project| project.inherit_members_changed?}
                after_save :remove_inherited_member_roles, :add_inherited_member_roles, :if => Proc.new {|project| project.parent_id_changed?}
                after_update :update_versions_from_hierarchy_change, :if => Proc.new {|project| project.parent_id_changed?}
                before_destroy :delete_all_members
                scope :has_module, lambda {|mod|
                  where("#{Project.table_name}.id IN (SELECT em.project_id FROM #{EnabledModule.table_name} em WHERE em.name=?)", mod.to_s)
                }
                scope :active, lambda { where(:status => STATUS_ACTIVE) }
                scope :status, lambda {|arg| where(arg.blank? ? nil : {:status => arg.to_i}) }
                scope :all_public, lambda { where(:is_public => true) }
                scope :visible, lambda {|*args| where(Project.visible_condition(args.shift || User.current, *args)) }
                scope :allowed_to, lambda {|*args|
                  user = User.current
                  permission = nil
                  if args.first.is_a?(Symbol)
                    permission = args.shift
                  else
                    user = args.shift
                    permission = args.shift
                  end
                  where(Project.allowed_to_condition(user, permission, *args))
                }
                scope :like, lambda {|arg|
                  if arg.blank?
                    where(nil)
                  else
                    pattern = "%#{arg.to_s.strip.downcase}%"
                    where("LOWER(identifier) LIKE :p OR LOWER(name) LIKE :p", :p => pattern)
                  end
                }
                scope :sorted, lambda {order(:lft)}
                scope :having_trackers, lambda {
                  where("#{Project.table_name}.id IN (SELECT DISTINCT project_id FROM #{table_name_prefix}projects_trackers#{table_name_suffix})")
                }
                def initialize(attributes=nil, *args)
                  super
                  initialized = (attributes || {}).stringify_keys
                  if !initialized.key?('identifier') && Setting.sequential_project_identifiers?
                    self.identifier = Project.next_identifier
                  end
                  if !initialized.key?('is_public')
                    self.is_public = Setting.default_projects_public?
                  end
                  if !initialized.key?('enabled_module_names')
                    self.enabled_module_names = Setting.default_projects_modules
                  end
                  if !initialized.key?('trackers') && !initialized.key?('tracker_ids')
                    default = Setting.default_projects_tracker_ids
                    if default.is_a?(Array)
                      self.trackers = Tracker.where(:id => default.map(&:to_i)).sorted.to_a
                    else
                      self.trackers = Tracker.sorted.to_a
                    end
                  end
                end
                def identifier=(identifier)
                  super unless identifier_frozen?
                end
                def identifier_frozen?
                  errors[:identifier].blank? && !(new_record? || identifier.blank?)
                end
                # returns latest created projects
                # non public projects will be returned only if user is a member of those
                def self.latest(user=nil, count=5)
                  visible(user).limit(count).order("created_on DESC").to_a
                end
                # Returns true if the project is visible to +user+ or to the current user.
                def visible?(user=User.current)
                  user.allowed_to?(:view_project, self)
                end
                # Returns a SQL conditions string used to find all projects visible by the specified user.
                #
                # Examples:
                #   Project.visible_condition(admin)        => "projects.status = 1"
                #   Project.visible_condition(normal_user)  => "((projects.status = 1) AND (projects.is_public = 1 OR projects.id IN (1,3,4)))"
                #   Project.visible_condition(anonymous)    => "((projects.status = 1) AND (projects.is_public = 1))"
                def self.visible_condition(user, options={})
                  allowed_to_condition(user, :view_project, options)
                end
                # Returns a SQL conditions string used to find all projects for which +user+ has the given +permission+
                #
                # Valid options:
                # * :project => limit the condition to project
                # * :with_subprojects => limit the condition to project and its subprojects
                # * :member => limit the condition to the user projects
                def self.allowed_to_condition(user, permission, options={})
                  perm = Redmine::AccessControl.permission(permission)
                  base_statement = (perm && perm.read? ? "#{Project.table_name}.status <> #{Project::STATUS_ARCHIVED}" : "#{Project.table_name}.status = #{Project::STATUS_ACTIVE}")
                  if perm && perm.project_module
                    # If the permission belongs to a project module, make sure the module is enabled
                    base_statement << " AND #{Project.table_name}.id IN (SELECT em.project_id FROM #{EnabledModule.table_name} em WHERE em.name='#{perm.project_module}')"
                  end
                  if project = options[:project]
                    project_statement = project.project_condition(options[:with_subprojects])
                    base_statement = "(#{project_statement}) AND (#{base_statement})"
                  end
                  if user.admin?
                    base_statement
                  else
                    statement_by_role = {}
                    unless options[:member]
                      role = user.builtin_role
                      if role.allowed_to?(permission)
                        s = "#{Project.table_name}.is_public = #{connection.quoted_true}"
                        if user.id
                          s = "(#{s} AND #{Project.table_name}.id NOT IN (SELECT project_id FROM #{Member.table_name} WHERE user_id = #{user.id}))"
                        end
                        statement_by_role[role] = s
                      end
                    end
                    user.projects_by_role.each do |role, projects|
                      if role.allowed_to?(permission) && projects.any?
                        statement_by_role[role] = "#{Project.table_name}.id IN (#{projects.collect(&:id).join(',')})"
                      end
                    end
                    if statement_by_role.empty?
                      "1=0"
                    else
                      if block_given?
                        statement_by_role.each do |role, statement|
                          if s = yield(role, user)
                            statement_by_role[role] = "(#{statement} AND (#{s}))"
                          end
                        end
                      end
                      "((#{base_statement}) AND (#{statement_by_role.values.join(' OR ')}))"
                    end
                  end
                end
                def override_roles(role)
                  @override_members ||= memberships.
                    joins(:principal).
                    where(:users => {:type => ['GroupAnonymous', 'GroupNonMember']}).to_a
                  group_class = role.anonymous? ? GroupAnonymous : GroupNonMember
                  member = @override_members.detect {|m| m.principal.is_a? group_class}
                  member ? member.roles.to_a : [role]
                end
                def principals
                  @principals ||= Principal.active.joins(:members).where("#{Member.table_name}.project_id = ?", id).uniq
                end
                def users
                  @users ||= User.active.joins(:members).where("#{Member.table_name}.project_id = ?", id).uniq
                end
                # Returns the Systemwide and project specific activities
                def activities(include_inactive=false)
                  t = TimeEntryActivity.table_name
                  scope = TimeEntryActivity.where("#{t}.project_id IS NULL OR #{t}.project_id = ?", id)
                  overridden_activity_ids = self.time_entry_activities.pluck(:parent_id).compact
                  if overridden_activity_ids.any?
                    scope = scope.where("#{t}.id NOT IN (?)", overridden_activity_ids)
                  end
                  unless include_inactive
                    scope = scope.active
                  end
                  scope
                end
                # Will create a new Project specific Activity or update an existing one
                #
                # This will raise a ActiveRecord::Rollback if the TimeEntryActivity
                # does not successfully save.
                def update_or_create_time_entry_activity(id, activity_hash)
                  if activity_hash.respond_to?(:has_key?) && activity_hash.has_key?('parent_id')
                    self.create_time_entry_activity_if_needed(activity_hash)
                  else
                    activity = project.time_entry_activities.find_by_id(id.to_i)
                    activity.update_attributes(activity_hash) if activity
                  end
                end
                # Create a new TimeEntryActivity if it overrides a system TimeEntryActivity
                #
                # This will raise a ActiveRecord::Rollback if the TimeEntryActivity
                # does not successfully save.
                def create_time_entry_activity_if_needed(activity)
                  if activity['parent_id']
                    parent_activity = TimeEntryActivity.find(activity['parent_id'])
                    activity['name'] = parent_activity.name
                    activity['position'] = parent_activity.position
                    if Enumeration.overriding_change?(activity, parent_activity)
                      project_activity = self.time_entry_activities.create(activity)
                      if project_activity.new_record?
                        raise ActiveRecord::Rollback, "Overriding TimeEntryActivity was not successfully saved"
                      else
                        self.time_entries.
                          where(["activity_id = ?", parent_activity.id]).
                          update_all("activity_id = #{project_activity.id}")
                      end
                    end
                  end
                end
                # Returns a :conditions SQL string that can be used to find the issues associated with this project.
                #
                # Examples:
                #   project.project_condition(true)  => "(projects.id = 1 OR (projects.lft > 1 AND projects.rgt < 10))"
                #   project.project_condition(false) => "projects.id = 1"
                def project_condition(with_subprojects)
                  cond = "#{Project.table_name}.id = #{id}"
                  cond = "(#{cond} OR (#{Project.table_name}.lft > #{lft} AND #{Project.table_name}.rgt < #{rgt}))" if with_subprojects
                  cond
                end
                def self.find(*args)
                  if args.first && args.first.is_a?(String) && !args.first.match(/^\d*$/)
                    project = find_by_identifier(*args)
                    raise ActiveRecord::RecordNotFound, "Couldn't find Project with identifier=#{args.first}" if project.nil?
                    project
                  else
                    super
                  end
                end
                def self.find_by_param(*args)
                  self.find(*args)
                end
                alias :base_reload :reload
                def reload(*args)
                  @principals = nil
                  @users = nil
                  @shared_versions = nil
                  @rolled_up_versions = nil
                  @rolled_up_trackers = nil
                  @all_issue_custom_fields = nil
                  @all_time_entry_custom_fields = nil
                  @to_param = nil
                  @allowed_parents = nil
                  @allowed_permissions = nil
                  @actions_allowed = nil
                  @start_date = nil
                  @due_date = nil
                  @override_members = nil
                  @assignable_users = nil
                  base_reload(*args)
                end
                def to_param
                  if new_record?
                    nil
                  else
                    # id is used for projects with a numeric identifier (compatibility)
                    @to_param ||= (identifier.to_s =~ %r{^\d*$} ? id.to_s : identifier)
                  end
                end
                def active?
                  self.status == STATUS_ACTIVE
                end
                def archived?
                  self.status == STATUS_ARCHIVED
                end
                # Archives the project and its descendants
                def archive
                  # Check that there is no issue of a non descendant project that is assigned
                  # to one of the project or descendant versions
                  version_ids = self_and_descendants.joins(:versions).pluck("#{Version.table_name}.id")
                  if version_ids.any? &&
                    Issue.
                      includes(:project).
                      where("#{Project.table_name}.lft < ? OR #{Project.table_name}.rgt > ?", lft, rgt).
                      where(:fixed_version_id => version_ids).
                      exists?
                    return false
                  end
                  Project.transaction do
                    archive!
                  end
                  true
                end
                # Unarchives the project
                # All its ancestors must be active
                def unarchive
                  return false if ancestors.detect {|a| !a.active?}
                  update_attribute :status, STATUS_ACTIVE
                end
                def close
                  self_and_descendants.status(STATUS_ACTIVE).update_all :status => STATUS_CLOSED
                end
                def reopen
                  self_and_descendants.status(STATUS_CLOSED).update_all :status => STATUS_ACTIVE
                end
                # Returns an array of projects the project can be moved to
                # by the current user
                def allowed_parents(user=User.current)
                  return @allowed_parents if @allowed_parents
                  @allowed_parents = Project.allowed_to(user, :add_subprojects).to_a
                  @allowed_parents = @allowed_parents - self_and_descendants
                  if user.allowed_to?(:add_project, nil, :global => true) || (!new_record? && parent.nil?)
                    @allowed_parents << nil
                  end
                  unless parent.nil? || @allowed_parents.empty? || @allowed_parents.include?(parent)
                    @allowed_parents << parent
                  end
                  @allowed_parents
                end
                # Sets the parent of the project with authorization check
                def set_allowed_parent!(p)
                  ActiveSupport::Deprecation.warn "Project#set_allowed_parent! is deprecated and will be removed in Redmine 4, use #safe_attributes= instead."
                  p = p.id if p.is_a?(Project)
                  send :safe_attributes, {:project_id => p}
                  save
                end
                # Sets the parent of the project and saves the project
                # Argument can be either a Project, a String, a Fixnum or nil
                def set_parent!(p)
                  if p.is_a?(Project)
                    self.parent = p
                  else
                    self.parent_id = p
                  end
                  save
                end
                # Returns an array of the trackers used by the project and its active sub projects
                def rolled_up_trackers
                  @rolled_up_trackers ||=
                    Tracker.
                      joins(:projects).
                      joins("JOIN #{EnabledModule.table_name} ON #{EnabledModule.table_name}.project_id = #{Project.table_name}.id AND #{EnabledModule.table_name}.name = 'issue_tracking'").
                      where("#{Project.table_name}.lft >= ? AND #{Project.table_name}.rgt <= ? AND #{Project.table_name}.status <> ?", lft, rgt, STATUS_ARCHIVED).
                      uniq.
                      sorted.
                      to_a
                end
                # Closes open and locked project versions that are completed
                def close_completed_versions
                  Version.transaction do
                    versions.where(:status => %w(open locked)).each do |version|
                      if version.completed?
                        version.update_attribute(:status, 'closed')
                      end
                    end
                  end
                end
                # Returns a scope of the Versions on subprojects
                def rolled_up_versions
                  @rolled_up_versions ||=
                    Version.
                      joins(:project).
                      where("#{Project.table_name}.lft >= ? AND #{Project.table_name}.rgt <= ? AND #{Project.table_name}.status <> ?", lft, rgt, STATUS_ARCHIVED)
                end
                # Returns a scope of the Versions used by the project
                def shared_versions
                  if new_record?
                    Version.
                      joins(:project).
                      preload(:project).
                      where("#{Project.table_name}.status <> ? AND #{Version.table_name}.sharing = 'system'", STATUS_ARCHIVED)
                  else
                    @shared_versions ||= begin
                      r = root? ? self : root
                      Version.
                        joins(:project).
                        preload(:project).
                        where("#{Project.table_name}.id = #{id}" +
                                " OR (#{Project.table_name}.status <> #{Project::STATUS_ARCHIVED} AND (" +
                                  " #{Version.table_name}.sharing = 'system'" +
                                  " OR (#{Project.table_name}.lft >= #{r.lft} AND #{Project.table_name}.rgt <= #{r.rgt} AND #{Version.table_name}.sharing = 'tree')" +
                                  " OR (#{Project.table_name}.lft < #{lft} AND #{Project.table_name}.rgt > #{rgt} AND #{Version.table_name}.sharing IN ('hierarchy', 'descendants'))" +
                                  " OR (#{Project.table_name}.lft > #{lft} AND #{Project.table_name}.rgt < #{rgt} AND #{Version.table_name}.sharing = 'hierarchy')" +
                                "))")
                    end
                  end
                end
                # Returns a hash of project users grouped by role
                def users_by_role
                  members.includes(:user, :roles).inject({}) do |h, m|
                    m.roles.each do |r|
                      h[r] ||= []
                      h[r] << m.user
                    end
                    h
                  end
                end
                # Adds user as a project member with the default role
                # Used for when a non-admin user creates a project
                def add_default_member(user)
                  role = Role.givable.find_by_id(Setting.new_project_user_role_id.to_i) || Role.givable.first
                  member = Member.new(:project => self, :principal => user, :roles => [role])
                  self.members << member
                  member
                end
                # Deletes all project's members
                def delete_all_members
                  me, mr = Member.table_name, MemberRole.table_name
                  self.class.connection.delete("DELETE FROM #{mr} WHERE #{mr}.member_id IN (SELECT #{me}.id FROM #{me} WHERE #{me}.project_id = #{id})")
                  Member.delete_all(['project_id = ?', id])
                end
                # Return a Principal scope of users/groups issues can be assigned to
                def assignable_users
                  types = ['User']
                  types << 'Group' if Setting.issue_group_assignment?
                  @assignable_users ||= Principal.
                    active.
                    joins(:members => :roles).
                    where(:type => types, :members => {:project_id => id}, :roles => {:assignable => true}).
                    uniq.
                    sorted
                end
                # Returns the mail addresses of users that should be always notified on project events
                def recipients
                  notified_users.collect {|user| user.mail}
                end
                # Returns the users that should be notified on project events
                def notified_users
                  # TODO: User part should be extracted to User#notify_about?
                  members.select {|m| m.principal.present? && (m.mail_notification? || m.principal.mail_notification == 'all')}.collect {|m| m.principal}
                end
                # Returns a scope of all custom fields enabled for project issues
                # (explicitly associated custom fields and custom fields enabled for all projects)
                def all_issue_custom_fields
                  if new_record?
                    @all_issue_custom_fields ||= IssueCustomField.
                      sorted.
                      where("is_for_all = ? OR id IN (?)", true, issue_custom_field_ids)
                  else
                    @all_issue_custom_fields ||= IssueCustomField.
                      sorted.
                      where("is_for_all = ? OR id IN (SELECT DISTINCT cfp.custom_field_id" +
                        " FROM #{table_name_prefix}custom_fields_projects#{table_name_suffix} cfp" +
                        " WHERE cfp.project_id = ?)", true, id)
                  end
                end
                def project
                  self
                end
                def <=>(project)
                  name.casecmp(project.name)
                end
                def to_s
                  name
                end
                # Returns a short description of the projects (first lines)
                def short_description(length = 255)
                  description.gsub(/^(.{#{length}}[^\n\r]*).*$/m, '\1...').strip if description
                end
                def css_classes
                  s = 'project'
                  s << ' root' if root?
                  s << ' child' if child?
                  s << (leaf? ? ' leaf' : ' parent')
                  unless active?
                    if archived?
                      s << ' archived'
                    else
                      s << ' closed'
                    end
                  end
                  s
                end
                # The earliest start date of a project, based on it's issues and versions
                def start_date
                  @start_date ||= [
                   issues.minimum('start_date'),
                   shared_versions.minimum('effective_date'),
                   Issue.fixed_version(shared_versions).minimum('start_date')
                  ].compact.min
                end
                # The latest due date of an issue or version
                def due_date
                  @due_date ||= [
                   issues.maximum('due_date'),
                   shared_versions.maximum('effective_date'),
                   Issue.fixed_version(shared_versions).maximum('due_date')
                  ].compact.max
                end
                def overdue?
                  active? && !due_date.nil? && (due_date < Date.today)
                end
                # Returns the percent completed for this project, based on the
                # progress on it's versions.
                def completed_percent(options={:include_subprojects => false})
                  if options.delete(:include_subprojects)
                    total = self_and_descendants.collect(&:completed_percent).sum
                    total / self_and_descendants.count
                  else
                    if versions.count > 0
                      total = versions.collect(&:completed_percent).sum
                      total / versions.count
                    else
 
                    end
                  end
                end
                # Return true if this project allows to do the specified action.
                # action can be:
                # * a parameter-like Hash (eg. :controller => 'projects', :action => 'edit')
                # * a permission Symbol (eg. :edit_project)
                def allows_to?(action)
                  if archived?
                    # No action allowed on archived projects
                    return false
                  end
                  unless active? || Redmine::AccessControl.read_action?(action)
                    # No write action allowed on closed projects
                    return false
                  end
                  # No action allowed on disabled modules
                  if action.is_a? Hash
                    allowed_actions.include? "#{action[:controller]}/#{action[:action]}"
                  else
                    allowed_permissions.include? action
                  end
                end
                # Return the enabled module with the given name
                # or nil if the module is not enabled for the project
                def enabled_module(name)
                  name = name.to_s
                  enabled_modules.detect {|m| m.name == name}
                end
                # Return true if the module with the given name is enabled
                def module_enabled?(name)
                  enabled_module(name).present?
                end
                def enabled_module_names=(module_names)
                  if module_names && module_names.is_a?(Array)
                    module_names = module_names.collect(&:to_s).reject(&:blank?)
                    self.enabled_modules = module_names.collect {|name| enabled_modules.detect {|mod| mod.name == name} || EnabledModule.new(:name => name)}
                  else
                    enabled_modules.clear
                  end
                end
                # Returns an array of the enabled modules names
                def enabled_module_names
                  enabled_modules.collect(&:name)
                end
                # Enable a specific module
                #
                # Examples:
                #   project.enable_module!(:issue_tracking)
                #   project.enable_module!("issue_tracking")
                def enable_module!(name)
                  enabled_modules << EnabledModule.new(:name => name.to_s) unless module_enabled?(name)
                end
                # Disable a module if it exists
                #
                # Examples:
                #   project.disable_module!(:issue_tracking)
                #   project.disable_module!("issue_tracking")
                #   project.disable_module!(project.enabled_modules.first)
                def disable_module!(target)
                  target = enabled_modules.detect{|mod| target.to_s == mod.name} unless enabled_modules.include?(target)
                  target.destroy unless target.blank?
                end
                safe_attributes 'name',
                  'description',
                  'homepage',
                  'is_public',
                  'identifier',
                  'custom_field_values',
                  'custom_fields',
                  'tracker_ids',
                  'issue_custom_field_ids',
                  'parent_id'
                safe_attributes 'enabled_module_names',
                  :if => lambda {|project, user| project.new_record? || user.allowed_to?(:select_project_modules, project) }
                safe_attributes 'inherit_members',
                  :if => lambda {|project, user| project.parent.nil? || project.parent.visible?(user)}
                def safe_attributes=(attrs, user=User.current)
                  return unless attrs.is_a?(Hash)
                  attrs = attrs.deep_dup
                  @unallowed_parent_id = nil
-                 parent_id_param = attrs['parent_id'].to_s
-                 if parent_id_param.blank? || parent_id_param != parent_id.to_s
-                   p = parent_id_param.present? ? Project.find_by_id(parent_id_param) : nil
-                   unless allowed_parents(user).include?(p)
-                     attrs.delete('parent_id')
-                     @unallowed_parent_id = true
+                 if new_record? || attrs.key?('parent_id')
+                   parent_id_param = attrs['parent_id'].to_s
+                   if new_record? || parent_id_param != parent_id.to_s
+                     p = parent_id_param.present? ? Project.find_by_id(parent_id_param) : nil
+                     unless allowed_parents(user).include?(p)
+                       attrs.delete('parent_id')
+                       @unallowed_parent_id = true
+                     end
                    end
                  end
                  super(attrs, user)
                end
                # Returns an auto-generated project identifier based on the last identifier used
                def self.next_identifier
                  p = Project.order('id DESC').first
                  p.nil? ? nil : p.identifier.to_s.succ
                end
                # Copies and saves the Project instance based on the +project+.
                # Duplicates the source project's:
                # * Wiki
                # * Versions
                # * Categories
                # * Issues
                # * Members
                # * Queries
                #
                # Accepts an +options+ argument to specify what to copy
                #
                # Examples:
                #   project.copy(1)                                    # => copies everything
                #   project.copy(1, :only => 'members')                # => copies members only
                #   project.copy(1, :only => ['members', 'versions'])  # => copies members and versions
                def copy(project, options={})
                  project = project.is_a?(Project) ? project : Project.find(project)
                  to_be_copied = %w(wiki versions issue_categories issues members queries boards)
                  to_be_copied = to_be_copied & Array.wrap(options[:only]) unless options[:only].nil?
                  Project.transaction do
                    if save
                      reload
                      to_be_copied.each do |name|
                        send "copy_#{name}", project
                      end
                      Redmine::Hook.call_hook(:model_project_copy_before_save, :source_project => project, :destination_project => self)
                      save
                    else
                      false
                    end
                  end
                end
                def member_principals
                  ActiveSupport::Deprecation.warn "Project#member_principals is deprecated and will be removed in Redmine 4.0. Use #memberships.active instead."
                  memberships.active
                end
                # Returns a new unsaved Project instance with attributes copied from +project+
                def self.copy_from(project)
                  project = project.is_a?(Project) ? project : Project.find(project)
                  # clear unique attributes
                  attributes = project.attributes.dup.except('id', 'name', 'identifier', 'status', 'parent_id', 'lft', 'rgt')
                  copy = Project.new(attributes)
                  copy.enabled_module_names = project.enabled_module_names
                  copy.trackers = project.trackers
                  copy.custom_values = project.custom_values.collect {|v| v.clone}
                  copy.issue_custom_fields = project.issue_custom_fields
                  copy
                end
                # Yields the given block for each project with its level in the tree
                def self.project_tree(projects, &block)
                  ancestors = []
                  projects.sort_by(&:lft).each do |project|
                    while (ancestors.any? && !project.is_descendant_of?(ancestors.last))
                      ancestors.pop
                    end
                    yield project, ancestors.size
                    ancestors << project
                  end
                end
                private
                def update_inherited_members
                  if parent
                    if inherit_members? && !inherit_members_was
                      remove_inherited_member_roles
                      add_inherited_member_roles
                    elsif !inherit_members? && inherit_members_was
                      remove_inherited_member_roles
                    end
                  end
                end
                def remove_inherited_member_roles
                  member_roles = memberships.map(&:member_roles).flatten
                  member_role_ids = member_roles.map(&:id)
                  member_roles.each do |member_role|
                    if member_role.inherited_from && !member_role_ids.include?(member_role.inherited_from)
                      member_role.destroy
                    end
                  end
                end
                def add_inherited_member_roles
                  if inherit_members? && parent
                    parent.memberships.each do |parent_member|
                      member = Member.find_or_new(self.id, parent_member.user_id)
                      parent_member.member_roles.each do |parent_member_role|
                        member.member_roles << MemberRole.new(:role => parent_member_role.role, :inherited_from => parent_member_role.id)
                      end
                      member.save!
                    end
                    memberships.reset
                  end
                end
                def update_versions_from_hierarchy_change
                  Issue.update_versions_from_hierarchy_change(self)
                end
                def validate_parent
                  if @unallowed_parent_id
                    errors.add(:parent_id, :invalid)
                  elsif parent_id_changed?
                    unless parent.nil? || (parent.active? && move_possible?(parent))
                      errors.add(:parent_id, :invalid)
                    end
                  end
                end
                # Copies wiki from +project+
                def copy_wiki(project)
                  # Check that the source project has a wiki first
                  unless project.wiki.nil?
                    wiki = self.wiki || Wiki.new
                    wiki.attributes = project.wiki.attributes.dup.except("id", "project_id")
                    wiki_pages_map = {}
                    project.wiki.pages.each do |page|
                      # Skip pages without content
                      next if page.content.nil?
                      new_wiki_content = WikiContent.new(page.content.attributes.dup.except("id", "page_id", "updated_on"))
                      new_wiki_page = WikiPage.new(page.attributes.dup.except("id", "wiki_id", "created_on", "parent_id"))
                      new_wiki_page.content = new_wiki_content
                      wiki.pages << new_wiki_page
                      wiki_pages_map[page.id] = new_wiki_page
                    end
                    self.wiki = wiki
                    wiki.save
                    # Reproduce page hierarchy
                    project.wiki.pages.each do |page|
                      if page.parent_id && wiki_pages_map[page.id]
                        wiki_pages_map[page.id].parent = wiki_pages_map[page.parent_id]
                        wiki_pages_map[page.id].save
                      end
                    end
                  end
                end
                # Copies versions from +project+
                def copy_versions(project)
                  project.versions.each do |version|
                    new_version = Version.new
                    new_version.attributes = version.attributes.dup.except("id", "project_id", "created_on", "updated_on")
                    self.versions << new_version
                  end
                end
                # Copies issue categories from +project+
                def copy_issue_categories(project)
                  project.issue_categories.each do |issue_category|
                    new_issue_category = IssueCategory.new
                    new_issue_category.attributes = issue_category.attributes.dup.except("id", "project_id")
                    self.issue_categories << new_issue_category
                  end
                end
                # Copies issues from +project+
                def copy_issues(project)
                  # Stores the source issue id as a key and the copied issues as the
                  # value.  Used to map the two together for issue relations.
                  issues_map = {}
                  # Store status and reopen locked/closed versions
                  version_statuses = versions.reject(&:open?).map {|version| [version, version.status]}
                  version_statuses.each do |version, status|
                    version.update_attribute :status, 'open'
                  end
                  # Get issues sorted by root_id, lft so that parent issues
                  # get copied before their children
                  project.issues.reorder('root_id, lft').each do |issue|
                    new_issue = Issue.new
                    new_issue.copy_from(issue, :subtasks => false, :link => false)
                    new_issue.project = self
                    # Changing project resets the custom field values
                    # TODO: handle this in Issue#project=
                    new_issue.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
                    # Reassign fixed_versions by name, since names are unique per project
                    if issue.fixed_version && issue.fixed_version.project == project
                      new_issue.fixed_version = self.versions.detect {|v| v.name == issue.fixed_version.name}
                    end
                    # Reassign version custom field values
                    new_issue.custom_field_values.each do |custom_value|
                      if custom_value.custom_field.field_format == 'version' && custom_value.value.present?
                        versions = Version.where(:id => custom_value.value).to_a
                        new_value = versions.map do |version|
                          if version.project == project
                            self.versions.detect {|v| v.name == version.name}.try(:id)
                          else
                            version.id
                          end
                        end
                        new_value.compact!
                        new_value = new_value.first unless custom_value.custom_field.multiple?
                        custom_value.value = new_value
                      end
                    end
                    # Reassign the category by name, since names are unique per project
                    if issue.category
                      new_issue.category = self.issue_categories.detect {|c| c.name == issue.category.name}
                    end
                    # Parent issue
                    if issue.parent_id
                      if copied_parent = issues_map[issue.parent_id]
                        new_issue.parent_issue_id = copied_parent.id
                      end
                    end
                    self.issues << new_issue
                    if new_issue.new_record?
                      logger.info "Project#copy_issues: issue ##{issue.id} could not be copied: #{new_issue.errors.full_messages}" if logger && logger.info?
                    else
                      issues_map[issue.id] = new_issue unless new_issue.new_record?
                    end
                  end
                  # Restore locked/closed version statuses
                  version_statuses.each do |version, status|
                    version.update_attribute :status, status
                  end
                  # Relations after in case issues related each other
                  project.issues.each do |issue|
                    new_issue = issues_map[issue.id]
                    unless new_issue
                      # Issue was not copied
                      next
                    end
                    # Relations
                    issue.relations_from.each do |source_relation|
                      new_issue_relation = IssueRelation.new
                      new_issue_relation.attributes = source_relation.attributes.dup.except("id", "issue_from_id", "issue_to_id")
                      new_issue_relation.issue_to = issues_map[source_relation.issue_to_id]
                      if new_issue_relation.issue_to.nil? && Setting.cross_project_issue_relations?
                        new_issue_relation.issue_to = source_relation.issue_to
                      end
                      new_issue.relations_from << new_issue_relation
                    end
                    issue.relations_to.each do |source_relation|
                      new_issue_relation = IssueRelation.new
                      new_issue_relation.attributes = source_relation.attributes.dup.except("id", "issue_from_id", "issue_to_id")
                      new_issue_relation.issue_from = issues_map[source_relation.issue_from_id]
                      if new_issue_relation.issue_from.nil? && Setting.cross_project_issue_relations?
                        new_issue_relation.issue_from = source_relation.issue_from
                      end
                      new_issue.relations_to << new_issue_relation
                    end
                  end
                end
                # Copies members from +project+
                def copy_members(project)
                  # Copy users first, then groups to handle members with inherited and given roles
                  members_to_copy = []
                  members_to_copy += project.memberships.select {|m| m.principal.is_a?(User)}
                  members_to_copy += project.memberships.select {|m| !m.principal.is_a?(User)}
                  members_to_copy.each do |member|
                    new_member = Member.new
                    new_member.attributes = member.attributes.dup.except("id", "project_id", "created_on")
                    # only copy non inherited roles
                    # inherited roles will be added when copying the group membership
                    role_ids = member.member_roles.reject(&:inherited?).collect(&:role_id)
                    next if role_ids.empty?
                    new_member.role_ids = role_ids
                    new_member.project = self
                    self.members << new_member
                  end
                end
                # Copies queries from +project+
                def copy_queries(project)
                  project.queries.each do |query|
                    new_query = IssueQuery.new
                    new_query.attributes = query.attributes.dup.except("id", "project_id", "sort_criteria", "user_id", "type")
                    new_query.sort_criteria = query.sort_criteria if query.sort_criteria
                    new_query.project = self
                    new_query.user_id = query.user_id
                    new_query.role_ids = query.role_ids if query.visibility == IssueQuery::VISIBILITY_ROLES
                    self.queries << new_query
                  end
                end
                # Copies boards from +project+
                def copy_boards(project)
                  project.boards.each do |board|
                    new_board = Board.new
                    new_board.attributes = board.attributes.dup.except("id", "project_id", "topics_count", "messages_count", "last_message_id")
                    new_board.project = self
                    self.boards << new_board
                  end
                end
                def allowed_permissions
                  @allowed_permissions ||= begin
                    module_names = enabled_modules.loaded? ? enabled_modules.map(&:name) : enabled_modules.pluck(:name)
                    Redmine::AccessControl.modules_permissions(module_names).collect {|p| p.name}
                  end
                end
                def allowed_actions
                  @actions_allowed ||= allowed_permissions.inject([]) { |actions, permission| actions += Redmine::AccessControl.allowed_actions(permission) }.flatten
                end
                # Archives subprojects recursively
                def archive!
                  children.each do |subproject|
                    subproject.send :archive!
                  end
                  update_attribute :status, STATUS_ARCHIVED
                end
              end

test/functional/projects_controller_test.rb +11 0

              # Redmine - project management software
              # Copyright (C) 2006-2015  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              require File.expand_path('../../test_helper', __FILE__)
              class ProjectsControllerTest < ActionController::TestCase
                fixtures :projects, :versions, :users, :email_addresses, :roles, :members,
                         :member_roles, :issues, :journals, :journal_details,
                         :trackers, :projects_trackers, :issue_statuses,
                         :enabled_modules, :enumerations, :boards, :messages,
                         :attachments, :custom_fields, :custom_values, :time_entries,
                         :wikis, :wiki_pages, :wiki_contents, :wiki_content_versions
                def setup
                  @request.session[:user_id] = nil
                  Setting.default_language = 'en'
                end
                def test_index_by_anonymous_should_not_show_private_projects
                  get :index
                  assert_response :success
                  assert_template 'index'
                  projects = assigns(:projects)
                  assert_not_nil projects
                  assert projects.all?(&:is_public?)
                  assert_select 'ul' do
                    assert_select 'li' do
                      assert_select 'a', :text => 'eCookbook'
                      assert_select 'ul' do
                        assert_select 'a', :text => 'Child of private child'
                      end
                    end
                  end
                  assert_select 'a', :text => /Private child of eCookbook/, :count => 0
                end
                def test_index_atom
                  get :index, :format => 'atom'
                  assert_response :success
                  assert_template 'common/feed'
                  assert_select 'feed>title', :text => 'Redmine: Latest projects'
                  assert_select 'feed>entry', :count => Project.visible(User.current).count
                end
                test "#index by non-admin user with view_time_entries permission should show overall spent time link" do
                  @request.session[:user_id] = 3
                  get :index
                  assert_template 'index'
                  assert_select 'a[href=?]', '/time_entries'
                end
                test "#index by non-admin user without view_time_entries permission should not show overall spent time link" do
                  Role.find(2).remove_permission! :view_time_entries
                  Role.non_member.remove_permission! :view_time_entries
                  Role.anonymous.remove_permission! :view_time_entries
                  @request.session[:user_id] = 3
                  get :index
                  assert_template 'index'
                  assert_select 'a[href=?]', '/time_entries', 0
                end
                test "#index by non-admin user with permission should show add project link" do
                  Role.find(1).add_permission! :add_project
                  @request.session[:user_id] = 2
                  get :index
                  assert_template 'index'
                  assert_select 'a[href=?]', '/projects/new'
                end
                test "#new by admin user should accept get" do
                  @request.session[:user_id] = 1
                  get :new
                  assert_response :success
                  assert_template 'new'
                end
                test "#new by non-admin user with add_project permission should accept get" do
                  Role.non_member.add_permission! :add_project
                  @request.session[:user_id] = 9
                  get :new
                  assert_response :success
                  assert_template 'new'
                  assert_select 'select[name=?]', 'project[parent_id]', 0
                end
                test "#new by non-admin user with add_subprojects permission should accept get" do
                  Role.find(1).remove_permission! :add_project
                  Role.find(1).add_permission! :add_subprojects
                  @request.session[:user_id] = 2
                  get :new, :parent_id => 'ecookbook'
                  assert_response :success
                  assert_template 'new'
                  assert_select 'select[name=?]', 'project[parent_id]' do
                    # parent project selected
                    assert_select 'option[value="1"][selected=selected]'
                    # no empty value
                    assert_select 'option[value=""]', 0
                  end
                end
                def test_new_should_not_display_invalid_search_link
                  @request.session[:user_id] = 1
                  get :new
                  assert_response :success
                  assert_select '#quick-search form[action=?]', '/search'
                  assert_select '#quick-search a[href=?]', '/search'
                end
                test "#create by admin user should create a new project" do
                  @request.session[:user_id] = 1
                  post :create,
                    :project => {
                      :name => "blog",
                      :description => "weblog",
                      :homepage => 'http://weblog',
                      :identifier => "blog",
                      :is_public => 1,
                      :custom_field_values => { '3' => 'Beta' },
                      :tracker_ids => ['1', '3'],
                      # an issue custom field that is not for all project
                      :issue_custom_field_ids => ['9'],
                      :enabled_module_names => ['issue_tracking', 'news', 'repository']
                    }
                  assert_redirected_to '/projects/blog/settings'
                  project = Project.find_by_name('blog')
                  assert_kind_of Project, project
                  assert project.active?
                  assert_equal 'weblog', project.description
                  assert_equal 'http://weblog', project.homepage
                  assert_equal true, project.is_public?
                  assert_nil project.parent
                  assert_equal 'Beta', project.custom_value_for(3).value
                  assert_equal [1, 3], project.trackers.map(&:id).sort
                  assert_equal ['issue_tracking', 'news', 'repository'], project.enabled_module_names.sort
                  assert project.issue_custom_fields.include?(IssueCustomField.find(9))
                end
                test "#create by admin user should create a new subproject" do
                  @request.session[:user_id] = 1
                  assert_difference 'Project.count' do
                    post :create, :project => { :name => "blog",
                                             :description => "weblog",
                                             :identifier => "blog",
                                             :is_public => 1,
                                             :custom_field_values => { '3' => 'Beta' },
                                             :parent_id => 1
                                            }
                    assert_redirected_to '/projects/blog/settings'
                  end
                  project = Project.find_by_name('blog')
                  assert_kind_of Project, project
                  assert_equal Project.find(1), project.parent
                end
                test "#create by admin user should continue" do
                  @request.session[:user_id] = 1
                  assert_difference 'Project.count' do
                    post :create, :project => {:name => "blog", :identifier => "blog"}, :continue => 'Create and continue'
                  end
                  assert_redirected_to '/projects/new'
                end
                test "#create by non-admin user with add_project permission should create a new project" do
                  Role.non_member.add_permission! :add_project
                  @request.session[:user_id] = 9
                  post :create, :project => { :name => "blog",
                                           :description => "weblog",
                                           :identifier => "blog",
                                           :is_public => 1,
                                           :custom_field_values => { '3' => 'Beta' },
                                           :tracker_ids => ['1', '3'],
                                           :enabled_module_names => ['issue_tracking', 'news', 'repository']
                                          }
                  assert_redirected_to '/projects/blog/settings'
                  project = Project.find_by_name('blog')
                  assert_kind_of Project, project
                  assert_equal 'weblog', project.description
                  assert_equal true, project.is_public?
                  assert_equal [1, 3], project.trackers.map(&:id).sort
                  assert_equal ['issue_tracking', 'news', 'repository'], project.enabled_module_names.sort
                  # User should be added as a project member
                  assert User.find(9).member_of?(project)
                  assert_equal 1, project.members.size
                end
                test "#create by non-admin user with add_project permission should fail with parent_id" do
                  Role.non_member.add_permission! :add_project
                  @request.session[:user_id] = 9
                  assert_no_difference 'Project.count' do
                    post :create, :project => { :name => "blog",
                                             :description => "weblog",
                                             :identifier => "blog",
                                             :is_public => 1,
                                             :custom_field_values => { '3' => 'Beta' },
                                             :parent_id => 1
                                            }
                  end
                  assert_response :success
                  project = assigns(:project)
                  assert_kind_of Project, project
                  assert_not_equal [], project.errors[:parent_id]
                end
                test "#create by non-admin user with add_subprojects permission should create a project with a parent_id" do
                  Role.find(1).remove_permission! :add_project
                  Role.find(1).add_permission! :add_subprojects
                  @request.session[:user_id] = 2
                  post :create, :project => { :name => "blog",
                                           :description => "weblog",
                                           :identifier => "blog",
                                           :is_public => 1,
                                           :custom_field_values => { '3' => 'Beta' },
                                           :parent_id => 1
                                          }
                  assert_redirected_to '/projects/blog/settings'
                  project = Project.find_by_name('blog')
                end
                test "#create by non-admin user with add_subprojects permission should fail without parent_id" do
                  Role.find(1).remove_permission! :add_project
                  Role.find(1).add_permission! :add_subprojects
                  @request.session[:user_id] = 2
                  assert_no_difference 'Project.count' do
                    post :create, :project => { :name => "blog",
                                             :description => "weblog",
                                             :identifier => "blog",
                                             :is_public => 1,
                                             :custom_field_values => { '3' => 'Beta' }
                                            }
                  end
                  assert_response :success
                  project = assigns(:project)
                  assert_kind_of Project, project
                  assert_not_equal [], project.errors[:parent_id]
                end
                test "#create by non-admin user with add_subprojects permission should fail with unauthorized parent_id" do
                  Role.find(1).remove_permission! :add_project
                  Role.find(1).add_permission! :add_subprojects
                  @request.session[:user_id] = 2
                  assert !User.find(2).member_of?(Project.find(6))
                  assert_no_difference 'Project.count' do
                    post :create, :project => { :name => "blog",
                                             :description => "weblog",
                                             :identifier => "blog",
                                             :is_public => 1,
                                             :custom_field_values => { '3' => 'Beta' },
                                             :parent_id => 6
                                            }
                  end
                  assert_response :success
                  project = assigns(:project)
                  assert_kind_of Project, project
                  assert_not_equal [], project.errors[:parent_id]
                end
                def test_create_subproject_with_inherit_members_should_inherit_members
                  Role.find_by_name('Manager').add_permission! :add_subprojects
                  parent = Project.find(1)
                  @request.session[:user_id] = 2
                  assert_difference 'Project.count' do
                    post :create, :project => {
                      :name => 'inherited', :identifier => 'inherited', :parent_id => parent.id, :inherit_members => '1'
                    }
                    assert_response 302
                  end
                  project = Project.order('id desc').first
                  assert_equal 'inherited', project.name
                  assert_equal parent, project.parent
                  assert project.memberships.count > 0
                  assert_equal parent.memberships.count, project.memberships.count
                end
                def test_create_should_preserve_modules_on_validation_failure
                  with_settings :default_projects_modules => ['issue_tracking', 'repository'] do
                    @request.session[:user_id] = 1
                    assert_no_difference 'Project.count' do
                      post :create, :project => {
                        :name => "blog",
                        :identifier => "",
                        :enabled_module_names => %w(issue_tracking news)
                      }
                    end
                    assert_response :success
                    project = assigns(:project)
                    assert_equal %w(issue_tracking news), project.enabled_module_names.sort
                  end
                end
                def test_show_by_id
                  get :show, :id => 1
                  assert_response :success
                  assert_template 'show'
                  assert_not_nil assigns(:project)
                end
                def test_show_by_identifier
                  get :show, :id => 'ecookbook'
                  assert_response :success
                  assert_template 'show'
                  assert_not_nil assigns(:project)
                  assert_equal Project.find_by_identifier('ecookbook'), assigns(:project)
                  assert_select 'li', :text => /Development status/
                end
                def test_show_should_not_display_empty_sidebar
                  p = Project.find(1)
                  p.enabled_module_names = []
                  p.save!
                  get :show, :id => 'ecookbook'
                  assert_response :success
                  assert_select '#main.nosidebar'
                end
                def test_show_should_not_display_hidden_custom_fields
                  ProjectCustomField.find_by_name('Development status').update_attribute :visible, false
                  get :show, :id => 'ecookbook'
                  assert_response :success
                  assert_template 'show'
                  assert_not_nil assigns(:project)
                  assert_select 'li', :text => /Development status/, :count => 0
                end
                def test_show_should_not_display_blank_custom_fields_with_multiple_values
                  f1 = ProjectCustomField.generate! :field_format => 'list', :possible_values => %w(Foo Bar), :multiple => true
                  f2 = ProjectCustomField.generate! :field_format => 'list', :possible_values => %w(Baz Qux), :multiple => true
                  project = Project.generate!(:custom_field_values => {f2.id.to_s => %w(Qux)})
                  get :show, :id => project.id
                  assert_response :success
                  assert_select 'li', :text => /#{f1.name}/, :count => 0
                  assert_select 'li', :text => /#{f2.name}/
                end
                def test_show_should_not_display_blank_text_custom_fields
                  f1 = ProjectCustomField.generate! :field_format => 'text'
                  get :show, :id => 1
                  assert_response :success
                  assert_select 'li', :text => /#{f1.name}/, :count => 0
                end
                def test_show_should_not_fail_when_custom_values_are_nil
                  project = Project.find_by_identifier('ecookbook')
                  project.custom_values.first.update_attribute(:value, nil)
                  get :show, :id => 'ecookbook'
                  assert_response :success
                  assert_template 'show'
                  assert_not_nil assigns(:project)
                  assert_equal Project.find_by_identifier('ecookbook'), assigns(:project)
                end
                def show_archived_project_should_be_denied
                  project = Project.find_by_identifier('ecookbook')
                  project.archive!
                  get :show, :id => 'ecookbook'
                  assert_response 403
                  assert_nil assigns(:project)
                  assert_select 'p', :text => /archived/
                end
                def test_show_should_not_show_private_subprojects_that_are_not_visible
                  get :show, :id => 'ecookbook'
                  assert_response :success
                  assert_template 'show'
                  assert_select 'a', :text => /Private child/, :count => 0
                end
                def test_show_should_show_private_subprojects_that_are_visible
                  @request.session[:user_id] = 2 # manager who is a member of the private subproject
                  get :show, :id => 'ecookbook'
                  assert_response :success
                  assert_template 'show'
                  assert_select 'a', :text => /Private child/
                end
                def test_settings
                  @request.session[:user_id] = 2 # manager
                  get :settings, :id => 1
                  assert_response :success
                  assert_template 'settings'
                end
                def test_settings_of_subproject
                  @request.session[:user_id] = 2
                  get :settings, :id => 'private-child'
                  assert_response :success
                  assert_template 'settings'
                  assert_select 'input[type=checkbox][name=?]', 'project[inherit_members]'
                end
                def test_settings_should_be_denied_for_member_on_closed_project
                  Project.find(1).close
                  @request.session[:user_id] = 2 # manager
                  get :settings, :id => 1
                  assert_response 403
                end
                def test_settings_should_be_denied_for_anonymous_on_closed_project
                  Project.find(1).close
                  get :settings, :id => 1
                  assert_response 302
                end
                def test_setting_with_wiki_module_and_no_wiki
                  Project.find(1).wiki.destroy
                  Role.find(1).add_permission! :manage_wiki
                  @request.session[:user_id] = 2
                  get :settings, :id => 1
                  assert_response :success
                  assert_template 'settings'
                  assert_select 'form[action=?]', '/projects/ecookbook/wiki' do
                    assert_select 'input[name=?]', 'wiki[start_page]'
                  end
                end
                def test_update
                  @request.session[:user_id] = 2 # manager
                  post :update, :id => 1, :project => {:name => 'Test changed name',
                                                     :issue_custom_field_ids => ['']}
                  assert_redirected_to '/projects/ecookbook/settings'
                  project = Project.find(1)
                  assert_equal 'Test changed name', project.name
                end
                def test_update_with_failure
                  @request.session[:user_id] = 2 # manager
                  post :update, :id => 1, :project => {:name => ''}
                  assert_response :success
                  assert_template 'settings'
                  assert_select_error /name cannot be blank/i
                end
                def test_update_should_be_denied_for_member_on_closed_project
                  Project.find(1).close
                  @request.session[:user_id] = 2 # manager
                  post :update, :id => 1, :project => {:name => 'Closed'}
                  assert_response 403
                  assert_equal 'eCookbook', Project.find(1).name
                end
                def test_update_should_be_denied_for_anonymous_on_closed_project
                  Project.find(1).close
                  post :update, :id => 1, :project => {:name => 'Closed'}
                  assert_response 302
                  assert_equal 'eCookbook', Project.find(1).name
                end
+               def test_update_child_project_without_parent_permission_should_not_show_validation_error
+                 child = Project.generate_with_parent!
+                 user = User.generate!
+                 User.add_to_project(user, child, Role.generate!(:permissions => [:edit_project]))
+                 @request.session[:user_id] = user.id
+                 post :update, :id => child.id, :project => {:name => 'Updated'}
+                 assert_response 302
+                 assert_match /Successful update/, flash[:notice]
+               end
                def test_modules
                  @request.session[:user_id] = 2
                  Project.find(1).enabled_module_names = ['issue_tracking', 'news']
                  post :modules, :id => 1, :enabled_module_names => ['issue_tracking', 'repository', 'documents']
                  assert_redirected_to '/projects/ecookbook/settings/modules'
                  assert_equal ['documents', 'issue_tracking', 'repository'], Project.find(1).enabled_module_names.sort
                end
                def test_destroy_leaf_project_without_confirmation_should_show_confirmation
                  @request.session[:user_id] = 1 # admin
                  assert_no_difference 'Project.count' do
                    delete :destroy, :id => 2
                    assert_response :success
                    assert_template 'destroy'
                  end
                end
                def test_destroy_without_confirmation_should_show_confirmation_with_subprojects
                  @request.session[:user_id] = 1 # admin
                  assert_no_difference 'Project.count' do
                    delete :destroy, :id => 1
                    assert_response :success
                    assert_template 'destroy'
                  end
                  assert_select 'strong',
                                :text => ['Private child of eCookbook',
                                          'Child of private child, eCookbook Subproject 1',
                                          'eCookbook Subproject 2'].join(', ')
                end
                def test_destroy_with_confirmation_should_destroy_the_project_and_subprojects
                  @request.session[:user_id] = 1 # admin
                  assert_difference 'Project.count', -5 do
                    delete :destroy, :id => 1, :confirm => 1
                    assert_redirected_to '/admin/projects'
                  end
                  assert_nil Project.find_by_id(1)
                end
                def test_archive
                  @request.session[:user_id] = 1 # admin
                  post :archive, :id => 1
                  assert_redirected_to '/admin/projects'
                  assert !Project.find(1).active?
                end
                def test_archive_with_failure
                  @request.session[:user_id] = 1
                  Project.any_instance.stubs(:archive).returns(false)
                  post :archive, :id => 1
                  assert_redirected_to '/admin/projects'
                  assert_match /project cannot be archived/i, flash[:error]
                end
                def test_unarchive
                  @request.session[:user_id] = 1 # admin
                  Project.find(1).archive
                  post :unarchive, :id => 1
                  assert_redirected_to '/admin/projects'
                  assert Project.find(1).active?
                end
                def test_close
                  @request.session[:user_id] = 2
                  post :close, :id => 1
                  assert_redirected_to '/projects/ecookbook'
                  assert_equal Project::STATUS_CLOSED, Project.find(1).status
                end
                def test_reopen
                  Project.find(1).close
                  @request.session[:user_id] = 2
                  post :reopen, :id => 1
                  assert_redirected_to '/projects/ecookbook'
                  assert Project.find(1).active?
                end
                def test_project_breadcrumbs_should_be_limited_to_3_ancestors
                  CustomField.delete_all
                  parent = nil
 .times do |i|
                    p = Project.generate_with_parent!(parent)
                    get :show, :id => p
                    assert_select '#header h1' do
                      assert_select 'a', :count => [i, 3].min
                    end
                    parent = p
                  end
                end
                def test_get_copy
                  @request.session[:user_id] = 1 # admin
                  get :copy, :id => 1
                  assert_response :success
                  assert_template 'copy'
                  assert assigns(:project)
                  assert_equal Project.find(1).description, assigns(:project).description
                  assert_nil assigns(:project).id
                  assert_select 'input[name=?][value=?]', 'project[enabled_module_names][]', 'issue_tracking', 1
                end
                def test_get_copy_with_invalid_source_should_respond_with_404
                  @request.session[:user_id] = 1
                  get :copy, :id => 99
                  assert_response 404
                end
                def test_get_copy_should_preselect_custom_fields
                  field1 = IssueCustomField.generate!(:is_for_all => false)
                  field2 = IssueCustomField.generate!(:is_for_all => false)
                  source = Project.generate!(:issue_custom_fields => [field1])
                  @request.session[:user_id] = 1
                  get :copy, :id => source.id
                  assert_response :success
                  assert_select 'fieldset#project_issue_custom_fields' do
                    assert_select 'input[type=checkbox][value=?][checked=checked]', field1.id.to_s
                    assert_select 'input[type=checkbox][value=?]:not([checked])', field2.id.to_s
                  end
                end
                def test_post_copy_should_copy_requested_items
                  @request.session[:user_id] = 1 # admin
                  CustomField.delete_all
                  assert_difference 'Project.count' do
                    post :copy, :id => 1,
                      :project => {
                        :name => 'Copy',
                        :identifier => 'unique-copy',
                        :tracker_ids => ['1', '2', '3', ''],
                        :enabled_module_names => %w(issue_tracking time_tracking)
                      },
                      :only => %w(issues versions)
                  end
                  project = Project.find('unique-copy')
                  source = Project.find(1)
                  assert_equal %w(issue_tracking time_tracking), project.enabled_module_names.sort
                  assert_equal source.versions.count, project.versions.count, "All versions were not copied"
                  assert_equal source.issues.count, project.issues.count, "All issues were not copied"
                  assert_equal 0, project.members.count
                end
                def test_post_copy_should_redirect_to_settings_when_successful
                  @request.session[:user_id] = 1 # admin
                  post :copy, :id => 1, :project => {:name => 'Copy', :identifier => 'unique-copy'}
                  assert_response :redirect
                  assert_redirected_to :controller => 'projects', :action => 'settings', :id => 'unique-copy'
                end
                def test_post_copy_with_failure
                  @request.session[:user_id] = 1
                  post :copy, :id => 1, :project => {:name => 'Copy', :identifier => ''}
                  assert_response :success
                  assert_template 'copy'
                end
                def test_jump_should_redirect_to_active_tab
                  get :show, :id => 1, :jump => 'issues'
                  assert_redirected_to '/projects/ecookbook/issues'
                end
                def test_jump_should_not_redirect_to_inactive_tab
                  get :show, :id => 3, :jump => 'documents'
                  assert_response :success
                  assert_template 'show'
                end
                def test_jump_should_not_redirect_to_unknown_tab
                  get :show, :id => 3, :jump => 'foobar'
                  assert_response :success
                  assert_template 'show'
                end
                def test_body_should_have_project_css_class
                  get :show, :id => 1
                  assert_select 'body.project-ecookbook'
                end
                def test_project_menu_should_include_new_issue_link
                  @request.session[:user_id] = 2
                  get :show, :id => 1
                  assert_select '#main-menu a.new-issue[href="/projects/ecookbook/issues/new"]', :text => 'New issue'
                end
                def test_project_menu_should_not_include_new_issue_link_for_project_without_trackers
                  Project.find(1).trackers.clear
                  @request.session[:user_id] = 2
                  get :show, :id => 1
                  assert_select '#main-menu a.new-issue', 0
                end
                def test_project_menu_should_not_include_new_issue_link_for_users_with_copy_issues_permission_only
                  role = Role.find(1)
                  role.remove_permission! :add_issues
                  role.add_permission! :copy_issues
                  @request.session[:user_id] = 2
                  get :show, :id => 1
                  assert_select '#main-menu a.new-issue', 0
                end
              end

test/object_helpers.rb +4 -1

              module ObjectHelpers
                def User.generate!(attributes={})
                  @generated_user_login ||= 'user0'
                  @generated_user_login.succ!
                  user = User.new(attributes)
                  user.login = @generated_user_login.dup if user.login.blank?
                  user.mail = "#{@generated_user_login}@example.com" if user.mail.blank?
                  user.firstname = "Bob" if user.firstname.blank?
                  user.lastname = "Doe" if user.lastname.blank?
                  yield user if block_given?
                  user.save!
                  user
                end
                def User.add_to_project(user, project, roles=nil)
                  roles = Role.find(1) if roles.nil?
                  roles = [roles] if roles.is_a?(Role)
                  Member.create!(:principal => user, :project => project, :roles => roles)
                end
                def Group.generate!(attributes={})
                  @generated_group_name ||= 'Group 0'
                  @generated_group_name.succ!
                  group = Group.new(attributes)
                  group.name = @generated_group_name.dup if group.name.blank?
                  yield group if block_given?
                  group.save!
                  group
                end
                def Project.generate!(attributes={})
                  @generated_project_identifier ||= 'project-0000'
                  @generated_project_identifier.succ!
                  project = Project.new(attributes)
                  project.name = @generated_project_identifier.dup if project.name.blank?
                  project.identifier = @generated_project_identifier.dup if project.identifier.blank?
                  yield project if block_given?
                  project.save!
                  project
                end
-               def Project.generate_with_parent!(parent, attributes={})
+               def Project.generate_with_parent!(*args)
+                 attributes = args.last.is_a?(Hash) ? args.pop : {}
+                 parent = args.size > 0 ? args.first : Project.generate!
                  project = Project.generate!(attributes) do |p|
                    p.parent = parent
                  end
                  parent.reload if parent
                  project
                end
                def IssueStatus.generate!(attributes={})
                  @generated_status_name ||= 'Status 0'
                  @generated_status_name.succ!
                  status = IssueStatus.new(attributes)
                  status.name = @generated_status_name.dup if status.name.blank?
                  yield status if block_given?
                  status.save!
                  status
                end
                def Tracker.generate!(attributes={})
                  @generated_tracker_name ||= 'Tracker 0'
                  @generated_tracker_name.succ!
                  tracker = Tracker.new(attributes)
                  tracker.name = @generated_tracker_name.dup if tracker.name.blank?
                  tracker.default_status ||= IssueStatus.order('position').first || IssueStatus.generate!
                  yield tracker if block_given?
                  tracker.save!
                  tracker
                end
                def Role.generate!(attributes={})
                  @generated_role_name ||= 'Role 0'
                  @generated_role_name.succ!
                  role = Role.new(attributes)
                  role.name = @generated_role_name.dup if role.name.blank?
                  yield role if block_given?
                  role.save!
                  role
                end
                # Generates an unsaved Issue
                def Issue.generate(attributes={})
                  issue = Issue.new(attributes)
                  issue.project ||= Project.find(1)
                  issue.tracker ||= issue.project.trackers.first
                  issue.subject = 'Generated' if issue.subject.blank?
                  issue.author ||= User.find(2)
                  yield issue if block_given?
                  issue
                end
                # Generates a saved Issue
                def Issue.generate!(attributes={}, &block)
                  issue = Issue.generate(attributes, &block)
                  issue.save!
                  issue
                end
                # Generates an issue with 2 children and a grandchild
                def Issue.generate_with_descendants!(attributes={})
                  issue = Issue.generate!(attributes)
                  child = Issue.generate!(:project => issue.project, :subject => 'Child1', :parent_issue_id => issue.id)
                  Issue.generate!(:project => issue.project, :subject => 'Child2', :parent_issue_id => issue.id)
                  Issue.generate!(:project => issue.project, :subject => 'Child11', :parent_issue_id => child.id)
                  issue.reload
                end
                def Issue.generate_with_child!(attributes={})
                  issue = Issue.generate!(attributes)
                  Issue.generate!(:parent_issue_id => issue.id)
                  issue.reload
                end
                def Journal.generate!(attributes={})
                  journal = Journal.new(attributes)
                  journal.user ||= User.first
                  journal.journalized ||= Issue.first
                  yield journal if block_given?
                  journal.save!
                  journal
                end
                def Version.generate!(attributes={})
                  @generated_version_name ||= 'Version 0'
                  @generated_version_name.succ!
                  version = Version.new(attributes)
                  version.name = @generated_version_name.dup if version.name.blank?
                  version.project ||= Project.find(1)
                  yield version if block_given?
                  version.save!
                  version
                end
                def TimeEntry.generate!(attributes={})
                  entry = TimeEntry.new(attributes)
                  entry.user ||= User.find(2)
                  entry.issue ||= Issue.find(1) unless entry.project
                  entry.project ||= entry.issue.project
                  entry.activity ||= TimeEntryActivity.first
                  entry.spent_on ||= Date.today
                  entry.hours ||= 1.0
                  entry.save!
                  entry
                end
                def AuthSource.generate!(attributes={})
                  @generated_auth_source_name ||= 'Auth 0'
                  @generated_auth_source_name.succ!
                  source = AuthSource.new(attributes)
                  source.name = @generated_auth_source_name.dup if source.name.blank?
                  yield source if block_given?
                  source.save!
                  source
                end
                def Board.generate!(attributes={})
                  @generated_board_name ||= 'Forum 0'
                  @generated_board_name.succ!
                  board = Board.new(attributes)
                  board.name = @generated_board_name.dup if board.name.blank?
                  board.description = @generated_board_name.dup if board.description.blank?
                  yield board if block_given?
                  board.save!
                  board
                end
                def Attachment.generate!(attributes={})
                  @generated_filename ||= 'testfile0'
                  @generated_filename.succ!
                  attributes = attributes.dup
                  attachment = Attachment.new(attributes)
                  attachment.container ||= Issue.find(1)
                  attachment.author ||= User.find(2)
                  attachment.filename = @generated_filename.dup if attachment.filename.blank?
                  attachment.save!
                  attachment
                end
                def CustomField.generate!(attributes={})
                  @generated_custom_field_name ||= 'Custom field 0'
                  @generated_custom_field_name.succ!
                  field = new(attributes)
                  field.name = @generated_custom_field_name.dup if field.name.blank?
                  field.field_format = 'string' if field.field_format.blank?
                  yield field if block_given?
                  field.save!
                  field
                end
                def Changeset.generate!(attributes={})
                  @generated_changeset_rev ||= '123456'
                  @generated_changeset_rev.succ!
                  changeset = new(attributes)
                  changeset.repository ||= Project.find(1).repository
                  changeset.revision ||= @generated_changeset_rev
                  changeset.committed_on ||= Time.now
                  yield changeset if block_given?
                  changeset.save!
                  changeset
                end
                def Query.generate!(attributes={})
                  query = new(attributes)
                  query.name = "Generated query" if query.name.blank?
                  query.user ||= User.find(1)
                  query.save!
                  query
                end
                def generate_import(fixture_name='import_issues.csv')
                  import = IssueImport.new
                  import.user_id = 2
                  import.file = uploaded_test_file(fixture_name, 'text/csv')
                  import.save!
                  import
                end
                def generate_import_with_mapping(fixture_name='import_issues.csv')
                  import = generate_import(fixture_name)
                  import.settings = {
                    'separator' => ";", 'wrapper' => '"', 'encoding' => "UTF-8",
                    'mapping' => {'project_id' => '1', 'tracker_id' => '2', 'subject' => '1'}
                  }
                  import.save!
                  import
                end
              end
              module TrackerObjectHelpers
                def generate_transitions!(*args)
                  options = args.last.is_a?(Hash) ? args.pop : {}
                  if args.size == 1
                    args << args.first
                  end
                  if options[:clear]
                    WorkflowTransition.where(:tracker_id => id).delete_all
                  end
                  args.each_cons(2) do |old_status_id, new_status_id|
                    WorkflowTransition.create!(
                      :tracker => self,
                      :role_id => (options[:role_id] || 1),
                      :old_status_id => old_status_id,
                      :new_status_id => new_status_id
                    )
                  end
                end
              end
              Tracker.send :include, TrackerObjectHelpers
              module IssueObjectHelpers
                def close!
                  self.status = IssueStatus.where(:is_closed => true).first
                  save!
                end
                def generate_child!(attributes={})
                  Issue.generate!(attributes.merge(:parent_issue_id => self.id))
                end
              end
              Issue.send :include, IssueObjectHelpers

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages