##// END OF EJS Templates
Rails3: test: replace deprecated Errors#on to Errors#[] and join with to_s at test/functional/issues_controller_test.rb...
Toshi MARUYAMA -
r8013:63d27a5389a4
parent child
Show More
@@ -1,2064 +1,2065
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19 require 'issues_controller'
20 20
21 21 class IssuesControllerTest < ActionController::TestCase
22 22 fixtures :projects,
23 23 :users,
24 24 :roles,
25 25 :members,
26 26 :member_roles,
27 27 :issues,
28 28 :issue_statuses,
29 29 :versions,
30 30 :trackers,
31 31 :projects_trackers,
32 32 :issue_categories,
33 33 :enabled_modules,
34 34 :enumerations,
35 35 :attachments,
36 36 :workflows,
37 37 :custom_fields,
38 38 :custom_values,
39 39 :custom_fields_projects,
40 40 :custom_fields_trackers,
41 41 :time_entries,
42 42 :journals,
43 43 :journal_details,
44 44 :queries
45 45
46 46 include Redmine::I18n
47 47
48 48 def setup
49 49 @controller = IssuesController.new
50 50 @request = ActionController::TestRequest.new
51 51 @response = ActionController::TestResponse.new
52 52 User.current = nil
53 53 end
54 54
55 55 def test_index
56 56 Setting.default_language = 'en'
57 57
58 58 get :index
59 59 assert_response :success
60 60 assert_template 'index'
61 61 assert_not_nil assigns(:issues)
62 62 assert_nil assigns(:project)
63 63 assert_tag :tag => 'a', :content => /Can't print recipes/
64 64 assert_tag :tag => 'a', :content => /Subproject issue/
65 65 # private projects hidden
66 66 assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
67 67 assert_no_tag :tag => 'a', :content => /Issue on project 2/
68 68 # project column
69 69 assert_tag :tag => 'th', :content => /Project/
70 70 end
71 71
72 72 def test_index_should_not_list_issues_when_module_disabled
73 73 EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
74 74 get :index
75 75 assert_response :success
76 76 assert_template 'index'
77 77 assert_not_nil assigns(:issues)
78 78 assert_nil assigns(:project)
79 79 assert_no_tag :tag => 'a', :content => /Can't print recipes/
80 80 assert_tag :tag => 'a', :content => /Subproject issue/
81 81 end
82 82
83 83 def test_index_should_list_visible_issues_only
84 84 get :index, :per_page => 100
85 85 assert_response :success
86 86 assert_not_nil assigns(:issues)
87 87 assert_nil assigns(:issues).detect {|issue| !issue.visible?}
88 88 end
89 89
90 90 def test_index_with_project
91 91 Setting.display_subprojects_issues = 0
92 92 get :index, :project_id => 1
93 93 assert_response :success
94 94 assert_template 'index'
95 95 assert_not_nil assigns(:issues)
96 96 assert_tag :tag => 'a', :content => /Can't print recipes/
97 97 assert_no_tag :tag => 'a', :content => /Subproject issue/
98 98 end
99 99
100 100 def test_index_with_project_and_subprojects
101 101 Setting.display_subprojects_issues = 1
102 102 get :index, :project_id => 1
103 103 assert_response :success
104 104 assert_template 'index'
105 105 assert_not_nil assigns(:issues)
106 106 assert_tag :tag => 'a', :content => /Can't print recipes/
107 107 assert_tag :tag => 'a', :content => /Subproject issue/
108 108 assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
109 109 end
110 110
111 111 def test_index_with_project_and_subprojects_should_show_private_subprojects
112 112 @request.session[:user_id] = 2
113 113 Setting.display_subprojects_issues = 1
114 114 get :index, :project_id => 1
115 115 assert_response :success
116 116 assert_template 'index'
117 117 assert_not_nil assigns(:issues)
118 118 assert_tag :tag => 'a', :content => /Can't print recipes/
119 119 assert_tag :tag => 'a', :content => /Subproject issue/
120 120 assert_tag :tag => 'a', :content => /Issue of a private subproject/
121 121 end
122 122
123 123 def test_index_with_project_and_default_filter
124 124 get :index, :project_id => 1, :set_filter => 1
125 125 assert_response :success
126 126 assert_template 'index'
127 127 assert_not_nil assigns(:issues)
128 128
129 129 query = assigns(:query)
130 130 assert_not_nil query
131 131 # default filter
132 132 assert_equal({'status_id' => {:operator => 'o', :values => ['']}}, query.filters)
133 133 end
134 134
135 135 def test_index_with_project_and_filter
136 136 get :index, :project_id => 1, :set_filter => 1,
137 137 :f => ['tracker_id'],
138 138 :op => {'tracker_id' => '='},
139 139 :v => {'tracker_id' => ['1']}
140 140 assert_response :success
141 141 assert_template 'index'
142 142 assert_not_nil assigns(:issues)
143 143
144 144 query = assigns(:query)
145 145 assert_not_nil query
146 146 assert_equal({'tracker_id' => {:operator => '=', :values => ['1']}}, query.filters)
147 147 end
148 148
149 149 def test_index_with_short_filters
150 150
151 151 to_test = {
152 152 'status_id' => {
153 153 'o' => { :op => 'o', :values => [''] },
154 154 'c' => { :op => 'c', :values => [''] },
155 155 '7' => { :op => '=', :values => ['7'] },
156 156 '7|3|4' => { :op => '=', :values => ['7', '3', '4'] },
157 157 '=7' => { :op => '=', :values => ['7'] },
158 158 '!3' => { :op => '!', :values => ['3'] },
159 159 '!7|3|4' => { :op => '!', :values => ['7', '3', '4'] }},
160 160 'subject' => {
161 161 'This is a subject' => { :op => '=', :values => ['This is a subject'] },
162 162 'o' => { :op => '=', :values => ['o'] },
163 163 '~This is part of a subject' => { :op => '~', :values => ['This is part of a subject'] },
164 164 '!~This is part of a subject' => { :op => '!~', :values => ['This is part of a subject'] }},
165 165 'tracker_id' => {
166 166 '3' => { :op => '=', :values => ['3'] },
167 167 '=3' => { :op => '=', :values => ['3'] }},
168 168 'start_date' => {
169 169 '2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
170 170 '=2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
171 171 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
172 172 '<=2011-10-12' => { :op => '<=', :values => ['2011-10-12'] },
173 173 '><2011-10-01|2011-10-30' => { :op => '><', :values => ['2011-10-01', '2011-10-30'] },
174 174 '<t+2' => { :op => '<t+', :values => ['2'] },
175 175 '>t+2' => { :op => '>t+', :values => ['2'] },
176 176 't+2' => { :op => 't+', :values => ['2'] },
177 177 't' => { :op => 't', :values => [''] },
178 178 'w' => { :op => 'w', :values => [''] },
179 179 '>t-2' => { :op => '>t-', :values => ['2'] },
180 180 '<t-2' => { :op => '<t-', :values => ['2'] },
181 181 't-2' => { :op => 't-', :values => ['2'] }},
182 182 'created_on' => {
183 183 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
184 184 '<t+2' => { :op => '=', :values => ['<t+2'] },
185 185 '>t+2' => { :op => '=', :values => ['>t+2'] },
186 186 't+2' => { :op => 't', :values => ['+2'] }},
187 187 'cf_1' => {
188 188 'c' => { :op => '=', :values => ['c'] },
189 189 '!c' => { :op => '!', :values => ['c'] },
190 190 '!*' => { :op => '!*', :values => [''] },
191 191 '*' => { :op => '*', :values => [''] }},
192 192 'estimated_hours' => {
193 193 '=13.4' => { :op => '=', :values => ['13.4'] },
194 194 '>=45' => { :op => '>=', :values => ['45'] },
195 195 '<=125' => { :op => '<=', :values => ['125'] },
196 196 '><10.5|20.5' => { :op => '><', :values => ['10.5', '20.5'] },
197 197 '!*' => { :op => '!*', :values => [''] },
198 198 '*' => { :op => '*', :values => [''] }}
199 199 }
200 200
201 201 default_filter = { 'status_id' => {:operator => 'o', :values => [''] }}
202 202
203 203 to_test.each do |field, expression_and_expected|
204 204 expression_and_expected.each do |filter_expression, expected|
205 205
206 206 get :index, :set_filter => 1, field => filter_expression
207 207
208 208 assert_response :success
209 209 assert_template 'index'
210 210 assert_not_nil assigns(:issues)
211 211
212 212 query = assigns(:query)
213 213 assert_not_nil query
214 214 assert query.has_filter?(field)
215 215 assert_equal(default_filter.merge({field => {:operator => expected[:op], :values => expected[:values]}}), query.filters)
216 216 end
217 217 end
218 218
219 219 end
220 220
221 221 def test_index_with_project_and_empty_filters
222 222 get :index, :project_id => 1, :set_filter => 1, :fields => ['']
223 223 assert_response :success
224 224 assert_template 'index'
225 225 assert_not_nil assigns(:issues)
226 226
227 227 query = assigns(:query)
228 228 assert_not_nil query
229 229 # no filter
230 230 assert_equal({}, query.filters)
231 231 end
232 232
233 233 def test_index_with_query
234 234 get :index, :project_id => 1, :query_id => 5
235 235 assert_response :success
236 236 assert_template 'index'
237 237 assert_not_nil assigns(:issues)
238 238 assert_nil assigns(:issue_count_by_group)
239 239 end
240 240
241 241 def test_index_with_query_grouped_by_tracker
242 242 get :index, :project_id => 1, :query_id => 6
243 243 assert_response :success
244 244 assert_template 'index'
245 245 assert_not_nil assigns(:issues)
246 246 assert_not_nil assigns(:issue_count_by_group)
247 247 end
248 248
249 249 def test_index_with_query_grouped_by_list_custom_field
250 250 get :index, :project_id => 1, :query_id => 9
251 251 assert_response :success
252 252 assert_template 'index'
253 253 assert_not_nil assigns(:issues)
254 254 assert_not_nil assigns(:issue_count_by_group)
255 255 end
256 256
257 257 def test_index_with_query_id_and_project_id_should_set_session_query
258 258 get :index, :project_id => 1, :query_id => 4
259 259 assert_response :success
260 260 assert_kind_of Hash, session[:query]
261 261 assert_equal 4, session[:query][:id]
262 262 assert_equal 1, session[:query][:project_id]
263 263 end
264 264
265 265 def test_index_with_cross_project_query_in_session_should_show_project_issues
266 266 q = Query.create!(:name => "test", :user_id => 2, :is_public => false, :project => nil)
267 267 @request.session[:query] = {:id => q.id, :project_id => 1}
268 268
269 269 with_settings :display_subprojects_issues => '0' do
270 270 get :index, :project_id => 1
271 271 end
272 272 assert_response :success
273 273 assert_not_nil assigns(:query)
274 274 assert_equal q.id, assigns(:query).id
275 275 assert_equal 1, assigns(:query).project_id
276 276 assert_equal [1], assigns(:issues).map(&:project_id).uniq
277 277 end
278 278
279 279 def test_private_query_should_not_be_available_to_other_users
280 280 q = Query.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
281 281 @request.session[:user_id] = 3
282 282
283 283 get :index, :query_id => q.id
284 284 assert_response 403
285 285 end
286 286
287 287 def test_private_query_should_be_available_to_its_user
288 288 q = Query.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
289 289 @request.session[:user_id] = 2
290 290
291 291 get :index, :query_id => q.id
292 292 assert_response :success
293 293 end
294 294
295 295 def test_public_query_should_be_available_to_other_users
296 296 q = Query.create!(:name => "private", :user => User.find(2), :is_public => true, :project => nil)
297 297 @request.session[:user_id] = 3
298 298
299 299 get :index, :query_id => q.id
300 300 assert_response :success
301 301 end
302 302
303 303 def test_index_csv
304 304 get :index, :format => 'csv'
305 305 assert_response :success
306 306 assert_not_nil assigns(:issues)
307 307 assert_equal 'text/csv', @response.content_type
308 308 assert @response.body.starts_with?("#,")
309 309 lines = @response.body.chomp.split("\n")
310 310 assert_equal assigns(:query).columns.size + 1, lines[0].split(',').size
311 311 end
312 312
313 313 def test_index_csv_with_project
314 314 get :index, :project_id => 1, :format => 'csv'
315 315 assert_response :success
316 316 assert_not_nil assigns(:issues)
317 317 assert_equal 'text/csv', @response.content_type
318 318 end
319 319
320 320 def test_index_csv_with_description
321 321 get :index, :format => 'csv', :description => '1'
322 322 assert_response :success
323 323 assert_not_nil assigns(:issues)
324 324 assert_equal 'text/csv', @response.content_type
325 325 assert @response.body.starts_with?("#,")
326 326 lines = @response.body.chomp.split("\n")
327 327 assert_equal assigns(:query).columns.size + 2, lines[0].split(',').size
328 328 end
329 329
330 330 def test_index_csv_with_all_columns
331 331 get :index, :format => 'csv', :columns => 'all'
332 332 assert_response :success
333 333 assert_not_nil assigns(:issues)
334 334 assert_equal 'text/csv', @response.content_type
335 335 assert @response.body.starts_with?("#,")
336 336 lines = @response.body.chomp.split("\n")
337 337 assert_equal assigns(:query).available_columns.size + 1, lines[0].split(',').size
338 338 end
339 339
340 340 def test_index_csv_big_5
341 341 with_settings :default_language => "zh-TW" do
342 342 str_utf8 = "\xe4\xb8\x80\xe6\x9c\x88"
343 343 str_big5 = "\xa4@\xa4\xeb"
344 344 if str_utf8.respond_to?(:force_encoding)
345 345 str_utf8.force_encoding('UTF-8')
346 346 str_big5.force_encoding('Big5')
347 347 end
348 348 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
349 349 :status_id => 1, :priority => IssuePriority.all.first,
350 350 :subject => str_utf8)
351 351 assert issue.save
352 352
353 353 get :index, :project_id => 1,
354 354 :f => ['subject'],
355 355 :op => '=', :values => [str_utf8],
356 356 :format => 'csv'
357 357 assert_equal 'text/csv', @response.content_type
358 358 lines = @response.body.chomp.split("\n")
359 359 s1 = "\xaa\xac\xbaA"
360 360 if str_utf8.respond_to?(:force_encoding)
361 361 s1.force_encoding('Big5')
362 362 end
363 363 assert lines[0].include?(s1)
364 364 assert lines[1].include?(str_big5)
365 365 end
366 366 end
367 367
368 368 def test_index_csv_cannot_convert_should_be_replaced_big_5
369 369 with_settings :default_language => "zh-TW" do
370 370 str_utf8 = "\xe4\xbb\xa5\xe5\x86\x85"
371 371 if str_utf8.respond_to?(:force_encoding)
372 372 str_utf8.force_encoding('UTF-8')
373 373 end
374 374 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
375 375 :status_id => 1, :priority => IssuePriority.all.first,
376 376 :subject => str_utf8)
377 377 assert issue.save
378 378
379 379 get :index, :project_id => 1,
380 380 :f => ['subject'],
381 381 :op => '=', :values => [str_utf8],
382 382 :c => ['status', 'subject'],
383 383 :format => 'csv',
384 384 :set_filter => 1
385 385 assert_equal 'text/csv', @response.content_type
386 386 lines = @response.body.chomp.split("\n")
387 387 s1 = "\xaa\xac\xbaA" # status
388 388 if str_utf8.respond_to?(:force_encoding)
389 389 s1.force_encoding('Big5')
390 390 end
391 391 assert lines[0].include?(s1)
392 392 s2 = lines[1].split(",")[2]
393 393 if s1.respond_to?(:force_encoding)
394 394 s3 = "\xa5H?" # subject
395 395 s3.force_encoding('Big5')
396 396 assert_equal s3, s2
397 397 elsif RUBY_PLATFORM == 'java'
398 398 assert_equal "??", s2
399 399 else
400 400 assert_equal "\xa5H???", s2
401 401 end
402 402 end
403 403 end
404 404
405 405 def test_index_csv_tw
406 406 with_settings :default_language => "zh-TW" do
407 407 str1 = "test_index_csv_tw"
408 408 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
409 409 :status_id => 1, :priority => IssuePriority.all.first,
410 410 :subject => str1, :estimated_hours => '1234.5')
411 411 assert issue.save
412 412 assert_equal 1234.5, issue.estimated_hours
413 413
414 414 get :index, :project_id => 1,
415 415 :f => ['subject'],
416 416 :op => '=', :values => [str1],
417 417 :c => ['estimated_hours', 'subject'],
418 418 :format => 'csv',
419 419 :set_filter => 1
420 420 assert_equal 'text/csv', @response.content_type
421 421 lines = @response.body.chomp.split("\n")
422 422 assert_equal "#{issue.id},1234.5,#{str1}", lines[1]
423 423
424 424 str_tw = "Traditional Chinese (\xe7\xb9\x81\xe9\xab\x94\xe4\xb8\xad\xe6\x96\x87)"
425 425 if str_tw.respond_to?(:force_encoding)
426 426 str_tw.force_encoding('UTF-8')
427 427 end
428 428 assert_equal str_tw, l(:general_lang_name)
429 429 assert_equal ',', l(:general_csv_separator)
430 430 assert_equal '.', l(:general_csv_decimal_separator)
431 431 end
432 432 end
433 433
434 434 def test_index_csv_fr
435 435 with_settings :default_language => "fr" do
436 436 str1 = "test_index_csv_fr"
437 437 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
438 438 :status_id => 1, :priority => IssuePriority.all.first,
439 439 :subject => str1, :estimated_hours => '1234.5')
440 440 assert issue.save
441 441 assert_equal 1234.5, issue.estimated_hours
442 442
443 443 get :index, :project_id => 1,
444 444 :f => ['subject'],
445 445 :op => '=', :values => [str1],
446 446 :c => ['estimated_hours', 'subject'],
447 447 :format => 'csv',
448 448 :set_filter => 1
449 449 assert_equal 'text/csv', @response.content_type
450 450 lines = @response.body.chomp.split("\n")
451 451 assert_equal "#{issue.id};1234,5;#{str1}", lines[1]
452 452
453 453 str_fr = "Fran\xc3\xa7ais"
454 454 if str_fr.respond_to?(:force_encoding)
455 455 str_fr.force_encoding('UTF-8')
456 456 end
457 457 assert_equal str_fr, l(:general_lang_name)
458 458 assert_equal ';', l(:general_csv_separator)
459 459 assert_equal ',', l(:general_csv_decimal_separator)
460 460 end
461 461 end
462 462
463 463 def test_index_pdf
464 464 ["en", "zh", "zh-TW", "ja", "ko"].each do |lang|
465 465 with_settings :default_language => lang do
466 466
467 467 get :index
468 468 assert_response :success
469 469 assert_template 'index'
470 470
471 471 if lang == "ja"
472 472 if RUBY_PLATFORM != 'java'
473 473 assert_equal "CP932", l(:general_pdf_encoding)
474 474 end
475 475 if RUBY_PLATFORM == 'java' && l(:general_pdf_encoding) == "CP932"
476 476 next
477 477 end
478 478 end
479 479
480 480 get :index, :format => 'pdf'
481 481 assert_response :success
482 482 assert_not_nil assigns(:issues)
483 483 assert_equal 'application/pdf', @response.content_type
484 484
485 485 get :index, :project_id => 1, :format => 'pdf'
486 486 assert_response :success
487 487 assert_not_nil assigns(:issues)
488 488 assert_equal 'application/pdf', @response.content_type
489 489
490 490 get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
491 491 assert_response :success
492 492 assert_not_nil assigns(:issues)
493 493 assert_equal 'application/pdf', @response.content_type
494 494 end
495 495 end
496 496 end
497 497
498 498 def test_index_pdf_with_query_grouped_by_list_custom_field
499 499 get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
500 500 assert_response :success
501 501 assert_not_nil assigns(:issues)
502 502 assert_not_nil assigns(:issue_count_by_group)
503 503 assert_equal 'application/pdf', @response.content_type
504 504 end
505 505
506 506 def test_index_sort
507 507 get :index, :sort => 'tracker,id:desc'
508 508 assert_response :success
509 509
510 510 sort_params = @request.session['issues_index_sort']
511 511 assert sort_params.is_a?(String)
512 512 assert_equal 'tracker,id:desc', sort_params
513 513
514 514 issues = assigns(:issues)
515 515 assert_not_nil issues
516 516 assert !issues.empty?
517 517 assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
518 518 end
519 519
520 520 def test_index_sort_by_field_not_included_in_columns
521 521 Setting.issue_list_default_columns = %w(subject author)
522 522 get :index, :sort => 'tracker'
523 523 end
524 524
525 525 def test_index_sort_by_assigned_to
526 526 get :index, :sort => 'assigned_to'
527 527 assert_response :success
528 528 assignees = assigns(:issues).collect(&:assigned_to).compact
529 529 assert_equal assignees.sort, assignees
530 530 end
531 531
532 532 def test_index_sort_by_assigned_to_desc
533 533 get :index, :sort => 'assigned_to:desc'
534 534 assert_response :success
535 535 assignees = assigns(:issues).collect(&:assigned_to).compact
536 536 assert_equal assignees.sort.reverse, assignees
537 537 end
538 538
539 539 def test_index_group_by_assigned_to
540 540 get :index, :group_by => 'assigned_to', :sort => 'priority'
541 541 assert_response :success
542 542 end
543 543
544 544 def test_index_sort_by_author
545 545 get :index, :sort => 'author'
546 546 assert_response :success
547 547 authors = assigns(:issues).collect(&:author)
548 548 assert_equal authors.sort, authors
549 549 end
550 550
551 551 def test_index_sort_by_author_desc
552 552 get :index, :sort => 'author:desc'
553 553 assert_response :success
554 554 authors = assigns(:issues).collect(&:author)
555 555 assert_equal authors.sort.reverse, authors
556 556 end
557 557
558 558 def test_index_group_by_author
559 559 get :index, :group_by => 'author', :sort => 'priority'
560 560 assert_response :success
561 561 end
562 562
563 563 def test_index_sort_by_spent_hours
564 564 get :index, :sort => 'spent_hours:desc'
565 565 assert_response :success
566 566 hours = assigns(:issues).collect(&:spent_hours)
567 567 assert_equal hours.sort.reverse, hours
568 568 end
569 569
570 570 def test_index_with_columns
571 571 columns = ['tracker', 'subject', 'assigned_to']
572 572 get :index, :set_filter => 1, :c => columns
573 573 assert_response :success
574 574
575 575 # query should use specified columns
576 576 query = assigns(:query)
577 577 assert_kind_of Query, query
578 578 assert_equal columns, query.column_names.map(&:to_s)
579 579
580 580 # columns should be stored in session
581 581 assert_kind_of Hash, session[:query]
582 582 assert_kind_of Array, session[:query][:column_names]
583 583 assert_equal columns, session[:query][:column_names].map(&:to_s)
584 584
585 585 # ensure only these columns are kept in the selected columns list
586 586 assert_tag :tag => 'select', :attributes => { :id => 'selected_columns' },
587 587 :children => { :count => 3 }
588 588 assert_no_tag :tag => 'option', :attributes => { :value => 'project' },
589 589 :parent => { :tag => 'select', :attributes => { :id => "selected_columns" } }
590 590 end
591 591
592 592 def test_index_without_project_should_implicitly_add_project_column_to_default_columns
593 593 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
594 594 get :index, :set_filter => 1
595 595
596 596 # query should use specified columns
597 597 query = assigns(:query)
598 598 assert_kind_of Query, query
599 599 assert_equal [:project, :tracker, :subject, :assigned_to], query.columns.map(&:name)
600 600 end
601 601
602 602 def test_index_without_project_and_explicit_default_columns_should_not_add_project_column
603 603 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
604 604 columns = ['tracker', 'subject', 'assigned_to']
605 605 get :index, :set_filter => 1, :c => columns
606 606
607 607 # query should use specified columns
608 608 query = assigns(:query)
609 609 assert_kind_of Query, query
610 610 assert_equal columns.map(&:to_sym), query.columns.map(&:name)
611 611 end
612 612
613 613 def test_index_with_custom_field_column
614 614 columns = %w(tracker subject cf_2)
615 615 get :index, :set_filter => 1, :c => columns
616 616 assert_response :success
617 617
618 618 # query should use specified columns
619 619 query = assigns(:query)
620 620 assert_kind_of Query, query
621 621 assert_equal columns, query.column_names.map(&:to_s)
622 622
623 623 assert_tag :td,
624 624 :attributes => {:class => 'cf_2 string'},
625 625 :ancestor => {:tag => 'table', :attributes => {:class => /issues/}}
626 626 end
627 627
628 628 def test_index_with_date_column
629 629 Issue.find(1).update_attribute :start_date, '1987-08-24'
630 630
631 631 with_settings :date_format => '%d/%m/%Y' do
632 632 get :index, :set_filter => 1, :c => %w(start_date)
633 633 assert_tag 'td', :attributes => {:class => /start_date/}, :content => '24/08/1987'
634 634 end
635 635 end
636 636
637 637 def test_index_with_done_ratio
638 638 Issue.find(1).update_attribute :done_ratio, 40
639 639
640 640 get :index, :set_filter => 1, :c => %w(done_ratio)
641 641 assert_tag 'td', :attributes => {:class => /done_ratio/},
642 642 :child => {:tag => 'table', :attributes => {:class => 'progress'},
643 643 :descendant => {:tag => 'td', :attributes => {:class => 'closed', :style => 'width: 40%;'}}
644 644 }
645 645 end
646 646
647 647 def test_index_with_spent_hours_column
648 648 get :index, :set_filter => 1, :c => %w(subject spent_hours)
649 649
650 650 assert_tag 'tr', :attributes => {:id => 'issue-3'},
651 651 :child => {
652 652 :tag => 'td', :attributes => {:class => /spent_hours/}, :content => '1.00'
653 653 }
654 654 end
655 655
656 656 def test_index_should_not_show_spent_hours_column_without_permission
657 657 Role.anonymous.remove_permission! :view_time_entries
658 658 get :index, :set_filter => 1, :c => %w(subject spent_hours)
659 659
660 660 assert_no_tag 'td', :attributes => {:class => /spent_hours/}
661 661 end
662 662
663 663 def test_index_with_fixed_version
664 664 get :index, :set_filter => 1, :c => %w(fixed_version)
665 665 assert_tag 'td', :attributes => {:class => /fixed_version/},
666 666 :child => {:tag => 'a', :content => '1.0', :attributes => {:href => '/versions/2'}}
667 667 end
668 668
669 669 def test_index_send_html_if_query_is_invalid
670 670 get :index, :f => ['start_date'], :op => {:start_date => '='}
671 671 assert_equal 'text/html', @response.content_type
672 672 assert_template 'index'
673 673 end
674 674
675 675 def test_index_send_nothing_if_query_is_invalid
676 676 get :index, :f => ['start_date'], :op => {:start_date => '='}, :format => 'csv'
677 677 assert_equal 'text/csv', @response.content_type
678 678 assert @response.body.blank?
679 679 end
680 680
681 681 def test_show_by_anonymous
682 682 get :show, :id => 1
683 683 assert_response :success
684 684 assert_template 'show'
685 685 assert_not_nil assigns(:issue)
686 686 assert_equal Issue.find(1), assigns(:issue)
687 687
688 688 # anonymous role is allowed to add a note
689 689 assert_tag :tag => 'form',
690 690 :descendant => { :tag => 'fieldset',
691 691 :child => { :tag => 'legend',
692 692 :content => /Notes/ } }
693 693 assert_tag :tag => 'title',
694 694 :content => "Bug #1: Can't print recipes - eCookbook - Redmine"
695 695 end
696 696
697 697 def test_show_by_manager
698 698 @request.session[:user_id] = 2
699 699 get :show, :id => 1
700 700 assert_response :success
701 701
702 702 assert_tag :tag => 'a',
703 703 :content => /Quote/
704 704
705 705 assert_tag :tag => 'form',
706 706 :descendant => { :tag => 'fieldset',
707 707 :child => { :tag => 'legend',
708 708 :content => /Change properties/ } },
709 709 :descendant => { :tag => 'fieldset',
710 710 :child => { :tag => 'legend',
711 711 :content => /Log time/ } },
712 712 :descendant => { :tag => 'fieldset',
713 713 :child => { :tag => 'legend',
714 714 :content => /Notes/ } }
715 715 end
716 716
717 717 def test_update_form_should_not_display_inactive_enumerations
718 718 @request.session[:user_id] = 2
719 719 get :show, :id => 1
720 720 assert_response :success
721 721
722 722 assert ! IssuePriority.find(15).active?
723 723 assert_no_tag :option, :attributes => {:value => '15'},
724 724 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
725 725 end
726 726
727 727 def test_update_form_should_allow_attachment_upload
728 728 @request.session[:user_id] = 2
729 729 get :show, :id => 1
730 730
731 731 assert_tag :tag => 'form',
732 732 :attributes => {:id => 'issue-form', :method => 'post', :enctype => 'multipart/form-data'},
733 733 :descendant => {
734 734 :tag => 'input',
735 735 :attributes => {:type => 'file', :name => 'attachments[1][file]'}
736 736 }
737 737 end
738 738
739 739 def test_show_should_deny_anonymous_access_without_permission
740 740 Role.anonymous.remove_permission!(:view_issues)
741 741 get :show, :id => 1
742 742 assert_response :redirect
743 743 end
744 744
745 745 def test_show_should_deny_anonymous_access_to_private_issue
746 746 Issue.update_all(["is_private = ?", true], "id = 1")
747 747 get :show, :id => 1
748 748 assert_response :redirect
749 749 end
750 750
751 751 def test_show_should_deny_non_member_access_without_permission
752 752 Role.non_member.remove_permission!(:view_issues)
753 753 @request.session[:user_id] = 9
754 754 get :show, :id => 1
755 755 assert_response 403
756 756 end
757 757
758 758 def test_show_should_deny_non_member_access_to_private_issue
759 759 Issue.update_all(["is_private = ?", true], "id = 1")
760 760 @request.session[:user_id] = 9
761 761 get :show, :id => 1
762 762 assert_response 403
763 763 end
764 764
765 765 def test_show_should_deny_member_access_without_permission
766 766 Role.find(1).remove_permission!(:view_issues)
767 767 @request.session[:user_id] = 2
768 768 get :show, :id => 1
769 769 assert_response 403
770 770 end
771 771
772 772 def test_show_should_deny_member_access_to_private_issue_without_permission
773 773 Issue.update_all(["is_private = ?", true], "id = 1")
774 774 @request.session[:user_id] = 3
775 775 get :show, :id => 1
776 776 assert_response 403
777 777 end
778 778
779 779 def test_show_should_allow_author_access_to_private_issue
780 780 Issue.update_all(["is_private = ?, author_id = 3", true], "id = 1")
781 781 @request.session[:user_id] = 3
782 782 get :show, :id => 1
783 783 assert_response :success
784 784 end
785 785
786 786 def test_show_should_allow_assignee_access_to_private_issue
787 787 Issue.update_all(["is_private = ?, assigned_to_id = 3", true], "id = 1")
788 788 @request.session[:user_id] = 3
789 789 get :show, :id => 1
790 790 assert_response :success
791 791 end
792 792
793 793 def test_show_should_allow_member_access_to_private_issue_with_permission
794 794 Issue.update_all(["is_private = ?", true], "id = 1")
795 795 User.find(3).roles_for_project(Project.find(1)).first.update_attribute :issues_visibility, 'all'
796 796 @request.session[:user_id] = 3
797 797 get :show, :id => 1
798 798 assert_response :success
799 799 end
800 800
801 801 def test_show_should_not_disclose_relations_to_invisible_issues
802 802 Setting.cross_project_issue_relations = '1'
803 803 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
804 804 # Relation to a private project issue
805 805 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
806 806
807 807 get :show, :id => 1
808 808 assert_response :success
809 809
810 810 assert_tag :div, :attributes => { :id => 'relations' },
811 811 :descendant => { :tag => 'a', :content => /#2$/ }
812 812 assert_no_tag :div, :attributes => { :id => 'relations' },
813 813 :descendant => { :tag => 'a', :content => /#4$/ }
814 814 end
815 815
816 816 def test_show_should_list_subtasks
817 817 Issue.generate!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
818 818
819 819 get :show, :id => 1
820 820 assert_response :success
821 821 assert_tag 'div', :attributes => {:id => 'issue_tree'},
822 822 :descendant => {:tag => 'td', :content => /Child Issue/, :attributes => {:class => /subject/}}
823 823 end
824 824
825 825 def test_show_should_list_parents
826 826 issue = Issue.generate!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
827 827
828 828 get :show, :id => issue.id
829 829 assert_response :success
830 830 assert_tag 'div', :attributes => {:class => 'subject'},
831 831 :descendant => {:tag => 'h3', :content => 'Child Issue'}
832 832 assert_tag 'div', :attributes => {:class => 'subject'},
833 833 :descendant => {:tag => 'a', :attributes => {:href => '/issues/1'}}
834 834 end
835 835
836 836 def test_show_atom
837 837 get :show, :id => 2, :format => 'atom'
838 838 assert_response :success
839 839 assert_template 'journals/index'
840 840 # Inline image
841 841 assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10'))
842 842 end
843 843
844 844 def test_show_export_to_pdf
845 845 get :show, :id => 3, :format => 'pdf'
846 846 assert_response :success
847 847 assert_equal 'application/pdf', @response.content_type
848 848 assert @response.body.starts_with?('%PDF')
849 849 assert_not_nil assigns(:issue)
850 850 end
851 851
852 852 def test_get_new
853 853 @request.session[:user_id] = 2
854 854 get :new, :project_id => 1, :tracker_id => 1
855 855 assert_response :success
856 856 assert_template 'new'
857 857
858 858 assert_tag :tag => 'input', :attributes => { :name => 'issue[custom_field_values][2]',
859 859 :value => 'Default string' }
860 860
861 861 # Be sure we don't display inactive IssuePriorities
862 862 assert ! IssuePriority.find(15).active?
863 863 assert_no_tag :option, :attributes => {:value => '15'},
864 864 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
865 865 end
866 866
867 867 def test_get_new_without_default_start_date_is_creation_date
868 868 Setting.default_issue_start_date_to_creation_date = 0
869 869
870 870 @request.session[:user_id] = 2
871 871 get :new, :project_id => 1, :tracker_id => 1
872 872 assert_response :success
873 873 assert_template 'new'
874 874
875 875 assert_tag :tag => 'input', :attributes => { :name => 'issue[start_date]',
876 876 :value => nil }
877 877 end
878 878
879 879 def test_get_new_with_default_start_date_is_creation_date
880 880 Setting.default_issue_start_date_to_creation_date = 1
881 881
882 882 @request.session[:user_id] = 2
883 883 get :new, :project_id => 1, :tracker_id => 1
884 884 assert_response :success
885 885 assert_template 'new'
886 886
887 887 assert_tag :tag => 'input', :attributes => { :name => 'issue[start_date]',
888 888 :value => Date.today.to_s }
889 889 end
890 890
891 891 def test_get_new_form_should_allow_attachment_upload
892 892 @request.session[:user_id] = 2
893 893 get :new, :project_id => 1, :tracker_id => 1
894 894
895 895 assert_tag :tag => 'form',
896 896 :attributes => {:id => 'issue-form', :method => 'post', :enctype => 'multipart/form-data'},
897 897 :descendant => {
898 898 :tag => 'input',
899 899 :attributes => {:type => 'file', :name => 'attachments[1][file]'}
900 900 }
901 901 end
902 902
903 903 def test_get_new_without_tracker_id
904 904 @request.session[:user_id] = 2
905 905 get :new, :project_id => 1
906 906 assert_response :success
907 907 assert_template 'new'
908 908
909 909 issue = assigns(:issue)
910 910 assert_not_nil issue
911 911 assert_equal Project.find(1).trackers.first, issue.tracker
912 912 end
913 913
914 914 def test_get_new_with_no_default_status_should_display_an_error
915 915 @request.session[:user_id] = 2
916 916 IssueStatus.delete_all
917 917
918 918 get :new, :project_id => 1
919 919 assert_response 500
920 920 assert_error_tag :content => /No default issue/
921 921 end
922 922
923 923 def test_get_new_with_no_tracker_should_display_an_error
924 924 @request.session[:user_id] = 2
925 925 Tracker.delete_all
926 926
927 927 get :new, :project_id => 1
928 928 assert_response 500
929 929 assert_error_tag :content => /No tracker/
930 930 end
931 931
932 932 def test_update_new_form
933 933 @request.session[:user_id] = 2
934 934 xhr :post, :new, :project_id => 1,
935 935 :issue => {:tracker_id => 2,
936 936 :subject => 'This is the test_new issue',
937 937 :description => 'This is the description',
938 938 :priority_id => 5}
939 939 assert_response :success
940 940 assert_template 'attributes'
941 941
942 942 issue = assigns(:issue)
943 943 assert_kind_of Issue, issue
944 944 assert_equal 1, issue.project_id
945 945 assert_equal 2, issue.tracker_id
946 946 assert_equal 'This is the test_new issue', issue.subject
947 947 end
948 948
949 949 def test_post_create
950 950 @request.session[:user_id] = 2
951 951 assert_difference 'Issue.count' do
952 952 post :create, :project_id => 1,
953 953 :issue => {:tracker_id => 3,
954 954 :status_id => 2,
955 955 :subject => 'This is the test_new issue',
956 956 :description => 'This is the description',
957 957 :priority_id => 5,
958 958 :start_date => '2010-11-07',
959 959 :estimated_hours => '',
960 960 :custom_field_values => {'2' => 'Value for field 2'}}
961 961 end
962 962 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
963 963
964 964 issue = Issue.find_by_subject('This is the test_new issue')
965 965 assert_not_nil issue
966 966 assert_equal 2, issue.author_id
967 967 assert_equal 3, issue.tracker_id
968 968 assert_equal 2, issue.status_id
969 969 assert_equal Date.parse('2010-11-07'), issue.start_date
970 970 assert_nil issue.estimated_hours
971 971 v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2})
972 972 assert_not_nil v
973 973 assert_equal 'Value for field 2', v.value
974 974 end
975 975
976 976 def test_post_new_with_group_assignment
977 977 group = Group.find(11)
978 978 project = Project.find(1)
979 979 project.members << Member.new(:principal => group, :roles => [Role.first])
980 980
981 981 with_settings :issue_group_assignment => '1' do
982 982 @request.session[:user_id] = 2
983 983 assert_difference 'Issue.count' do
984 984 post :create, :project_id => project.id,
985 985 :issue => {:tracker_id => 3,
986 986 :status_id => 1,
987 987 :subject => 'This is the test_new_with_group_assignment issue',
988 988 :assigned_to_id => group.id}
989 989 end
990 990 end
991 991 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
992 992
993 993 issue = Issue.find_by_subject('This is the test_new_with_group_assignment issue')
994 994 assert_not_nil issue
995 995 assert_equal group, issue.assigned_to
996 996 end
997 997
998 998 def test_post_create_without_start_date_and_default_start_date_is_not_creation_date
999 999 Setting.default_issue_start_date_to_creation_date = 0
1000 1000
1001 1001 @request.session[:user_id] = 2
1002 1002 assert_difference 'Issue.count' do
1003 1003 post :create, :project_id => 1,
1004 1004 :issue => {:tracker_id => 3,
1005 1005 :status_id => 2,
1006 1006 :subject => 'This is the test_new issue',
1007 1007 :description => 'This is the description',
1008 1008 :priority_id => 5,
1009 1009 :estimated_hours => '',
1010 1010 :custom_field_values => {'2' => 'Value for field 2'}}
1011 1011 end
1012 1012 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1013 1013
1014 1014 issue = Issue.find_by_subject('This is the test_new issue')
1015 1015 assert_not_nil issue
1016 1016 assert_nil issue.start_date
1017 1017 end
1018 1018
1019 1019 def test_post_create_without_start_date_and_default_start_date_is_creation_date
1020 1020 Setting.default_issue_start_date_to_creation_date = 1
1021 1021
1022 1022 @request.session[:user_id] = 2
1023 1023 assert_difference 'Issue.count' do
1024 1024 post :create, :project_id => 1,
1025 1025 :issue => {:tracker_id => 3,
1026 1026 :status_id => 2,
1027 1027 :subject => 'This is the test_new issue',
1028 1028 :description => 'This is the description',
1029 1029 :priority_id => 5,
1030 1030 :estimated_hours => '',
1031 1031 :custom_field_values => {'2' => 'Value for field 2'}}
1032 1032 end
1033 1033 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1034 1034
1035 1035 issue = Issue.find_by_subject('This is the test_new issue')
1036 1036 assert_not_nil issue
1037 1037 assert_equal Date.today, issue.start_date
1038 1038 end
1039 1039
1040 1040 def test_post_create_and_continue
1041 1041 @request.session[:user_id] = 2
1042 1042 assert_difference 'Issue.count' do
1043 1043 post :create, :project_id => 1,
1044 1044 :issue => {:tracker_id => 3, :subject => 'This is first issue', :priority_id => 5},
1045 1045 :continue => ''
1046 1046 end
1047 1047
1048 1048 issue = Issue.first(:order => 'id DESC')
1049 1049 assert_redirected_to :controller => 'issues', :action => 'new', :project_id => 'ecookbook', :issue => {:tracker_id => 3}
1050 1050 assert_not_nil flash[:notice], "flash was not set"
1051 1051 assert flash[:notice].include?("<a href='/issues/#{issue.id}'>##{issue.id}</a>"), "issue link not found in flash: #{flash[:notice]}"
1052 1052 end
1053 1053
1054 1054 def test_post_create_without_custom_fields_param
1055 1055 @request.session[:user_id] = 2
1056 1056 assert_difference 'Issue.count' do
1057 1057 post :create, :project_id => 1,
1058 1058 :issue => {:tracker_id => 1,
1059 1059 :subject => 'This is the test_new issue',
1060 1060 :description => 'This is the description',
1061 1061 :priority_id => 5}
1062 1062 end
1063 1063 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1064 1064 end
1065 1065
1066 1066 def test_post_create_with_required_custom_field_and_without_custom_fields_param
1067 1067 field = IssueCustomField.find_by_name('Database')
1068 1068 field.update_attribute(:is_required, true)
1069 1069
1070 1070 @request.session[:user_id] = 2
1071 1071 post :create, :project_id => 1,
1072 1072 :issue => {:tracker_id => 1,
1073 1073 :subject => 'This is the test_new issue',
1074 1074 :description => 'This is the description',
1075 1075 :priority_id => 5}
1076 1076 assert_response :success
1077 1077 assert_template 'new'
1078 1078 issue = assigns(:issue)
1079 1079 assert_not_nil issue
1080 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
1080 assert_equal I18n.translate('activerecord.errors.messages.invalid'),
1081 issue.errors[:custom_values].to_s
1081 1082 end
1082 1083
1083 1084 def test_post_create_with_watchers
1084 1085 @request.session[:user_id] = 2
1085 1086 ActionMailer::Base.deliveries.clear
1086 1087
1087 1088 assert_difference 'Watcher.count', 2 do
1088 1089 post :create, :project_id => 1,
1089 1090 :issue => {:tracker_id => 1,
1090 1091 :subject => 'This is a new issue with watchers',
1091 1092 :description => 'This is the description',
1092 1093 :priority_id => 5,
1093 1094 :watcher_user_ids => ['2', '3']}
1094 1095 end
1095 1096 issue = Issue.find_by_subject('This is a new issue with watchers')
1096 1097 assert_not_nil issue
1097 1098 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
1098 1099
1099 1100 # Watchers added
1100 1101 assert_equal [2, 3], issue.watcher_user_ids.sort
1101 1102 assert issue.watched_by?(User.find(3))
1102 1103 # Watchers notified
1103 1104 mail = ActionMailer::Base.deliveries.last
1104 1105 assert_kind_of TMail::Mail, mail
1105 1106 assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
1106 1107 end
1107 1108
1108 1109 def test_post_create_subissue
1109 1110 @request.session[:user_id] = 2
1110 1111
1111 1112 assert_difference 'Issue.count' do
1112 1113 post :create, :project_id => 1,
1113 1114 :issue => {:tracker_id => 1,
1114 1115 :subject => 'This is a child issue',
1115 1116 :parent_issue_id => 2}
1116 1117 end
1117 1118 issue = Issue.find_by_subject('This is a child issue')
1118 1119 assert_not_nil issue
1119 1120 assert_equal Issue.find(2), issue.parent
1120 1121 end
1121 1122
1122 1123 def test_post_create_subissue_with_non_numeric_parent_id
1123 1124 @request.session[:user_id] = 2
1124 1125
1125 1126 assert_difference 'Issue.count' do
1126 1127 post :create, :project_id => 1,
1127 1128 :issue => {:tracker_id => 1,
1128 1129 :subject => 'This is a child issue',
1129 1130 :parent_issue_id => 'ABC'}
1130 1131 end
1131 1132 issue = Issue.find_by_subject('This is a child issue')
1132 1133 assert_not_nil issue
1133 1134 assert_nil issue.parent
1134 1135 end
1135 1136
1136 1137 def test_post_create_private
1137 1138 @request.session[:user_id] = 2
1138 1139
1139 1140 assert_difference 'Issue.count' do
1140 1141 post :create, :project_id => 1,
1141 1142 :issue => {:tracker_id => 1,
1142 1143 :subject => 'This is a private issue',
1143 1144 :is_private => '1'}
1144 1145 end
1145 1146 issue = Issue.first(:order => 'id DESC')
1146 1147 assert issue.is_private?
1147 1148 end
1148 1149
1149 1150 def test_post_create_private_with_set_own_issues_private_permission
1150 1151 role = Role.find(1)
1151 1152 role.remove_permission! :set_issues_private
1152 1153 role.add_permission! :set_own_issues_private
1153 1154
1154 1155 @request.session[:user_id] = 2
1155 1156
1156 1157 assert_difference 'Issue.count' do
1157 1158 post :create, :project_id => 1,
1158 1159 :issue => {:tracker_id => 1,
1159 1160 :subject => 'This is a private issue',
1160 1161 :is_private => '1'}
1161 1162 end
1162 1163 issue = Issue.first(:order => 'id DESC')
1163 1164 assert issue.is_private?
1164 1165 end
1165 1166
1166 1167 def test_post_create_should_send_a_notification
1167 1168 ActionMailer::Base.deliveries.clear
1168 1169 @request.session[:user_id] = 2
1169 1170 assert_difference 'Issue.count' do
1170 1171 post :create, :project_id => 1,
1171 1172 :issue => {:tracker_id => 3,
1172 1173 :subject => 'This is the test_new issue',
1173 1174 :description => 'This is the description',
1174 1175 :priority_id => 5,
1175 1176 :estimated_hours => '',
1176 1177 :custom_field_values => {'2' => 'Value for field 2'}}
1177 1178 end
1178 1179 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1179 1180
1180 1181 assert_equal 1, ActionMailer::Base.deliveries.size
1181 1182 end
1182 1183
1183 1184 def test_post_create_should_preserve_fields_values_on_validation_failure
1184 1185 @request.session[:user_id] = 2
1185 1186 post :create, :project_id => 1,
1186 1187 :issue => {:tracker_id => 1,
1187 1188 # empty subject
1188 1189 :subject => '',
1189 1190 :description => 'This is a description',
1190 1191 :priority_id => 6,
1191 1192 :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
1192 1193 assert_response :success
1193 1194 assert_template 'new'
1194 1195
1195 1196 assert_tag :textarea, :attributes => { :name => 'issue[description]' },
1196 1197 :content => 'This is a description'
1197 1198 assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
1198 1199 :child => { :tag => 'option', :attributes => { :selected => 'selected',
1199 1200 :value => '6' },
1200 1201 :content => 'High' }
1201 1202 # Custom fields
1202 1203 assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' },
1203 1204 :child => { :tag => 'option', :attributes => { :selected => 'selected',
1204 1205 :value => 'Oracle' },
1205 1206 :content => 'Oracle' }
1206 1207 assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]',
1207 1208 :value => 'Value for field 2'}
1208 1209 end
1209 1210
1210 1211 def test_post_create_should_ignore_non_safe_attributes
1211 1212 @request.session[:user_id] = 2
1212 1213 assert_nothing_raised do
1213 1214 post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
1214 1215 end
1215 1216 end
1216 1217
1217 1218 def test_post_create_with_attachment
1218 1219 set_tmp_attachments_directory
1219 1220 @request.session[:user_id] = 2
1220 1221
1221 1222 assert_difference 'Issue.count' do
1222 1223 assert_difference 'Attachment.count' do
1223 1224 post :create, :project_id => 1,
1224 1225 :issue => { :tracker_id => '1', :subject => 'With attachment' },
1225 1226 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
1226 1227 end
1227 1228 end
1228 1229
1229 1230 issue = Issue.first(:order => 'id DESC')
1230 1231 attachment = Attachment.first(:order => 'id DESC')
1231 1232
1232 1233 assert_equal issue, attachment.container
1233 1234 assert_equal 2, attachment.author_id
1234 1235 assert_equal 'testfile.txt', attachment.filename
1235 1236 assert_equal 'text/plain', attachment.content_type
1236 1237 assert_equal 'test file', attachment.description
1237 1238 assert_equal 59, attachment.filesize
1238 1239 assert File.exists?(attachment.diskfile)
1239 1240 assert_equal 59, File.size(attachment.diskfile)
1240 1241 end
1241 1242
1242 1243 context "without workflow privilege" do
1243 1244 setup do
1244 1245 Workflow.delete_all(["role_id = ?", Role.anonymous.id])
1245 1246 Role.anonymous.add_permission! :add_issues, :add_issue_notes
1246 1247 end
1247 1248
1248 1249 context "#new" do
1249 1250 should "propose default status only" do
1250 1251 get :new, :project_id => 1
1251 1252 assert_response :success
1252 1253 assert_template 'new'
1253 1254 assert_tag :tag => 'select',
1254 1255 :attributes => {:name => 'issue[status_id]'},
1255 1256 :children => {:count => 1},
1256 1257 :child => {:tag => 'option', :attributes => {:value => IssueStatus.default.id.to_s}}
1257 1258 end
1258 1259
1259 1260 should "accept default status" do
1260 1261 assert_difference 'Issue.count' do
1261 1262 post :create, :project_id => 1,
1262 1263 :issue => {:tracker_id => 1,
1263 1264 :subject => 'This is an issue',
1264 1265 :status_id => 1}
1265 1266 end
1266 1267 issue = Issue.last(:order => 'id')
1267 1268 assert_equal IssueStatus.default, issue.status
1268 1269 end
1269 1270
1270 1271 should "ignore unauthorized status" do
1271 1272 assert_difference 'Issue.count' do
1272 1273 post :create, :project_id => 1,
1273 1274 :issue => {:tracker_id => 1,
1274 1275 :subject => 'This is an issue',
1275 1276 :status_id => 3}
1276 1277 end
1277 1278 issue = Issue.last(:order => 'id')
1278 1279 assert_equal IssueStatus.default, issue.status
1279 1280 end
1280 1281 end
1281 1282
1282 1283 context "#update" do
1283 1284 should "ignore status change" do
1284 1285 assert_difference 'Journal.count' do
1285 1286 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
1286 1287 end
1287 1288 assert_equal 1, Issue.find(1).status_id
1288 1289 end
1289 1290
1290 1291 should "ignore attributes changes" do
1291 1292 assert_difference 'Journal.count' do
1292 1293 put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2}
1293 1294 end
1294 1295 issue = Issue.find(1)
1295 1296 assert_equal "Can't print recipes", issue.subject
1296 1297 assert_nil issue.assigned_to
1297 1298 end
1298 1299 end
1299 1300 end
1300 1301
1301 1302 context "with workflow privilege" do
1302 1303 setup do
1303 1304 Workflow.delete_all(["role_id = ?", Role.anonymous.id])
1304 1305 Workflow.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
1305 1306 Workflow.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
1306 1307 Role.anonymous.add_permission! :add_issues, :add_issue_notes
1307 1308 end
1308 1309
1309 1310 context "#update" do
1310 1311 should "accept authorized status" do
1311 1312 assert_difference 'Journal.count' do
1312 1313 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
1313 1314 end
1314 1315 assert_equal 3, Issue.find(1).status_id
1315 1316 end
1316 1317
1317 1318 should "ignore unauthorized status" do
1318 1319 assert_difference 'Journal.count' do
1319 1320 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2}
1320 1321 end
1321 1322 assert_equal 1, Issue.find(1).status_id
1322 1323 end
1323 1324
1324 1325 should "accept authorized attributes changes" do
1325 1326 assert_difference 'Journal.count' do
1326 1327 put :update, :id => 1, :notes => 'just trying', :issue => {:assigned_to_id => 2}
1327 1328 end
1328 1329 issue = Issue.find(1)
1329 1330 assert_equal 2, issue.assigned_to_id
1330 1331 end
1331 1332
1332 1333 should "ignore unauthorized attributes changes" do
1333 1334 assert_difference 'Journal.count' do
1334 1335 put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed'}
1335 1336 end
1336 1337 issue = Issue.find(1)
1337 1338 assert_equal "Can't print recipes", issue.subject
1338 1339 end
1339 1340 end
1340 1341
1341 1342 context "and :edit_issues permission" do
1342 1343 setup do
1343 1344 Role.anonymous.add_permission! :add_issues, :edit_issues
1344 1345 end
1345 1346
1346 1347 should "accept authorized status" do
1347 1348 assert_difference 'Journal.count' do
1348 1349 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
1349 1350 end
1350 1351 assert_equal 3, Issue.find(1).status_id
1351 1352 end
1352 1353
1353 1354 should "ignore unauthorized status" do
1354 1355 assert_difference 'Journal.count' do
1355 1356 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2}
1356 1357 end
1357 1358 assert_equal 1, Issue.find(1).status_id
1358 1359 end
1359 1360
1360 1361 should "accept authorized attributes changes" do
1361 1362 assert_difference 'Journal.count' do
1362 1363 put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2}
1363 1364 end
1364 1365 issue = Issue.find(1)
1365 1366 assert_equal "changed", issue.subject
1366 1367 assert_equal 2, issue.assigned_to_id
1367 1368 end
1368 1369 end
1369 1370 end
1370 1371
1371 1372 def test_copy_issue
1372 1373 @request.session[:user_id] = 2
1373 1374 get :new, :project_id => 1, :copy_from => 1
1374 1375 assert_template 'new'
1375 1376 assert_not_nil assigns(:issue)
1376 1377 orig = Issue.find(1)
1377 1378 assert_equal orig.subject, assigns(:issue).subject
1378 1379 end
1379 1380
1380 1381 def test_get_edit
1381 1382 @request.session[:user_id] = 2
1382 1383 get :edit, :id => 1
1383 1384 assert_response :success
1384 1385 assert_template 'edit'
1385 1386 assert_not_nil assigns(:issue)
1386 1387 assert_equal Issue.find(1), assigns(:issue)
1387 1388
1388 1389 # Be sure we don't display inactive IssuePriorities
1389 1390 assert ! IssuePriority.find(15).active?
1390 1391 assert_no_tag :option, :attributes => {:value => '15'},
1391 1392 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
1392 1393 end
1393 1394
1394 1395 def test_get_edit_should_display_the_time_entry_form_with_log_time_permission
1395 1396 @request.session[:user_id] = 2
1396 1397 Role.find_by_name('Manager').update_attribute :permissions, [:view_issues, :edit_issues, :log_time]
1397 1398
1398 1399 get :edit, :id => 1
1399 1400 assert_tag 'input', :attributes => {:name => 'time_entry[hours]'}
1400 1401 end
1401 1402
1402 1403 def test_get_edit_should_not_display_the_time_entry_form_without_log_time_permission
1403 1404 @request.session[:user_id] = 2
1404 1405 Role.find_by_name('Manager').remove_permission! :log_time
1405 1406
1406 1407 get :edit, :id => 1
1407 1408 assert_no_tag 'input', :attributes => {:name => 'time_entry[hours]'}
1408 1409 end
1409 1410
1410 1411 def test_get_edit_with_params
1411 1412 @request.session[:user_id] = 2
1412 1413 get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 },
1413 1414 :time_entry => { :hours => '2.5', :comments => 'test_get_edit_with_params', :activity_id => TimeEntryActivity.first.id }
1414 1415 assert_response :success
1415 1416 assert_template 'edit'
1416 1417
1417 1418 issue = assigns(:issue)
1418 1419 assert_not_nil issue
1419 1420
1420 1421 assert_equal 5, issue.status_id
1421 1422 assert_tag :select, :attributes => { :name => 'issue[status_id]' },
1422 1423 :child => { :tag => 'option',
1423 1424 :content => 'Closed',
1424 1425 :attributes => { :selected => 'selected' } }
1425 1426
1426 1427 assert_equal 7, issue.priority_id
1427 1428 assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
1428 1429 :child => { :tag => 'option',
1429 1430 :content => 'Urgent',
1430 1431 :attributes => { :selected => 'selected' } }
1431 1432
1432 1433 assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => '2.5' }
1433 1434 assert_tag :select, :attributes => { :name => 'time_entry[activity_id]' },
1434 1435 :child => { :tag => 'option',
1435 1436 :attributes => { :selected => 'selected', :value => TimeEntryActivity.first.id } }
1436 1437 assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => 'test_get_edit_with_params' }
1437 1438 end
1438 1439
1439 1440 def test_update_edit_form
1440 1441 @request.session[:user_id] = 2
1441 1442 xhr :post, :new, :project_id => 1,
1442 1443 :id => 1,
1443 1444 :issue => {:tracker_id => 2,
1444 1445 :subject => 'This is the test_new issue',
1445 1446 :description => 'This is the description',
1446 1447 :priority_id => 5}
1447 1448 assert_response :success
1448 1449 assert_template 'attributes'
1449 1450
1450 1451 issue = assigns(:issue)
1451 1452 assert_kind_of Issue, issue
1452 1453 assert_equal 1, issue.id
1453 1454 assert_equal 1, issue.project_id
1454 1455 assert_equal 2, issue.tracker_id
1455 1456 assert_equal 'This is the test_new issue', issue.subject
1456 1457 end
1457 1458
1458 1459 def test_update_using_invalid_http_verbs
1459 1460 @request.session[:user_id] = 2
1460 1461 subject = 'Updated by an invalid http verb'
1461 1462
1462 1463 get :update, :id => 1, :issue => {:subject => subject}
1463 1464 assert_not_equal subject, Issue.find(1).subject
1464 1465
1465 1466 post :update, :id => 1, :issue => {:subject => subject}
1466 1467 assert_not_equal subject, Issue.find(1).subject
1467 1468
1468 1469 delete :update, :id => 1, :issue => {:subject => subject}
1469 1470 assert_not_equal subject, Issue.find(1).subject
1470 1471 end
1471 1472
1472 1473 def test_put_update_without_custom_fields_param
1473 1474 @request.session[:user_id] = 2
1474 1475 ActionMailer::Base.deliveries.clear
1475 1476
1476 1477 issue = Issue.find(1)
1477 1478 assert_equal '125', issue.custom_value_for(2).value
1478 1479 old_subject = issue.subject
1479 1480 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
1480 1481
1481 1482 assert_difference('Journal.count') do
1482 1483 assert_difference('JournalDetail.count', 2) do
1483 1484 put :update, :id => 1, :issue => {:subject => new_subject,
1484 1485 :priority_id => '6',
1485 1486 :category_id => '1' # no change
1486 1487 }
1487 1488 end
1488 1489 end
1489 1490 assert_redirected_to :action => 'show', :id => '1'
1490 1491 issue.reload
1491 1492 assert_equal new_subject, issue.subject
1492 1493 # Make sure custom fields were not cleared
1493 1494 assert_equal '125', issue.custom_value_for(2).value
1494 1495
1495 1496 mail = ActionMailer::Base.deliveries.last
1496 1497 assert_kind_of TMail::Mail, mail
1497 1498 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
1498 1499 assert mail.body.include?("Subject changed from #{old_subject} to #{new_subject}")
1499 1500 end
1500 1501
1501 1502 def test_put_update_with_custom_field_change
1502 1503 @request.session[:user_id] = 2
1503 1504 issue = Issue.find(1)
1504 1505 assert_equal '125', issue.custom_value_for(2).value
1505 1506
1506 1507 assert_difference('Journal.count') do
1507 1508 assert_difference('JournalDetail.count', 3) do
1508 1509 put :update, :id => 1, :issue => {:subject => 'Custom field change',
1509 1510 :priority_id => '6',
1510 1511 :category_id => '1', # no change
1511 1512 :custom_field_values => { '2' => 'New custom value' }
1512 1513 }
1513 1514 end
1514 1515 end
1515 1516 assert_redirected_to :action => 'show', :id => '1'
1516 1517 issue.reload
1517 1518 assert_equal 'New custom value', issue.custom_value_for(2).value
1518 1519
1519 1520 mail = ActionMailer::Base.deliveries.last
1520 1521 assert_kind_of TMail::Mail, mail
1521 1522 assert mail.body.include?("Searchable field changed from 125 to New custom value")
1522 1523 end
1523 1524
1524 1525 def test_put_update_with_status_and_assignee_change
1525 1526 issue = Issue.find(1)
1526 1527 assert_equal 1, issue.status_id
1527 1528 @request.session[:user_id] = 2
1528 1529 assert_difference('TimeEntry.count', 0) do
1529 1530 put :update,
1530 1531 :id => 1,
1531 1532 :issue => { :status_id => 2, :assigned_to_id => 3 },
1532 1533 :notes => 'Assigned to dlopper',
1533 1534 :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
1534 1535 end
1535 1536 assert_redirected_to :action => 'show', :id => '1'
1536 1537 issue.reload
1537 1538 assert_equal 2, issue.status_id
1538 1539 j = Journal.find(:first, :order => 'id DESC')
1539 1540 assert_equal 'Assigned to dlopper', j.notes
1540 1541 assert_equal 2, j.details.size
1541 1542
1542 1543 mail = ActionMailer::Base.deliveries.last
1543 1544 assert mail.body.include?("Status changed from New to Assigned")
1544 1545 # subject should contain the new status
1545 1546 assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
1546 1547 end
1547 1548
1548 1549 def test_put_update_with_note_only
1549 1550 notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
1550 1551 # anonymous user
1551 1552 put :update,
1552 1553 :id => 1,
1553 1554 :notes => notes
1554 1555 assert_redirected_to :action => 'show', :id => '1'
1555 1556 j = Journal.find(:first, :order => 'id DESC')
1556 1557 assert_equal notes, j.notes
1557 1558 assert_equal 0, j.details.size
1558 1559 assert_equal User.anonymous, j.user
1559 1560
1560 1561 mail = ActionMailer::Base.deliveries.last
1561 1562 assert mail.body.include?(notes)
1562 1563 end
1563 1564
1564 1565 def test_put_update_with_note_and_spent_time
1565 1566 @request.session[:user_id] = 2
1566 1567 spent_hours_before = Issue.find(1).spent_hours
1567 1568 assert_difference('TimeEntry.count') do
1568 1569 put :update,
1569 1570 :id => 1,
1570 1571 :notes => '2.5 hours added',
1571 1572 :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id }
1572 1573 end
1573 1574 assert_redirected_to :action => 'show', :id => '1'
1574 1575
1575 1576 issue = Issue.find(1)
1576 1577
1577 1578 j = Journal.find(:first, :order => 'id DESC')
1578 1579 assert_equal '2.5 hours added', j.notes
1579 1580 assert_equal 0, j.details.size
1580 1581
1581 1582 t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time')
1582 1583 assert_not_nil t
1583 1584 assert_equal 2.5, t.hours
1584 1585 assert_equal spent_hours_before + 2.5, issue.spent_hours
1585 1586 end
1586 1587
1587 1588 def test_put_update_with_attachment_only
1588 1589 set_tmp_attachments_directory
1589 1590
1590 1591 # Delete all fixtured journals, a race condition can occur causing the wrong
1591 1592 # journal to get fetched in the next find.
1592 1593 Journal.delete_all
1593 1594
1594 1595 # anonymous user
1595 1596 assert_difference 'Attachment.count' do
1596 1597 put :update, :id => 1,
1597 1598 :notes => '',
1598 1599 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
1599 1600 end
1600 1601
1601 1602 assert_redirected_to :action => 'show', :id => '1'
1602 1603 j = Issue.find(1).journals.find(:first, :order => 'id DESC')
1603 1604 assert j.notes.blank?
1604 1605 assert_equal 1, j.details.size
1605 1606 assert_equal 'testfile.txt', j.details.first.value
1606 1607 assert_equal User.anonymous, j.user
1607 1608
1608 1609 attachment = Attachment.first(:order => 'id DESC')
1609 1610 assert_equal Issue.find(1), attachment.container
1610 1611 assert_equal User.anonymous, attachment.author
1611 1612 assert_equal 'testfile.txt', attachment.filename
1612 1613 assert_equal 'text/plain', attachment.content_type
1613 1614 assert_equal 'test file', attachment.description
1614 1615 assert_equal 59, attachment.filesize
1615 1616 assert File.exists?(attachment.diskfile)
1616 1617 assert_equal 59, File.size(attachment.diskfile)
1617 1618
1618 1619 mail = ActionMailer::Base.deliveries.last
1619 1620 assert mail.body.include?('testfile.txt')
1620 1621 end
1621 1622
1622 1623 def test_put_update_with_attachment_that_fails_to_save
1623 1624 set_tmp_attachments_directory
1624 1625
1625 1626 # Delete all fixtured journals, a race condition can occur causing the wrong
1626 1627 # journal to get fetched in the next find.
1627 1628 Journal.delete_all
1628 1629
1629 1630 # Mock out the unsaved attachment
1630 1631 Attachment.any_instance.stubs(:create).returns(Attachment.new)
1631 1632
1632 1633 # anonymous user
1633 1634 put :update,
1634 1635 :id => 1,
1635 1636 :notes => '',
1636 1637 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
1637 1638 assert_redirected_to :action => 'show', :id => '1'
1638 1639 assert_equal '1 file(s) could not be saved.', flash[:warning]
1639 1640
1640 1641 end if Object.const_defined?(:Mocha)
1641 1642
1642 1643 def test_put_update_with_no_change
1643 1644 issue = Issue.find(1)
1644 1645 issue.journals.clear
1645 1646 ActionMailer::Base.deliveries.clear
1646 1647
1647 1648 put :update,
1648 1649 :id => 1,
1649 1650 :notes => ''
1650 1651 assert_redirected_to :action => 'show', :id => '1'
1651 1652
1652 1653 issue.reload
1653 1654 assert issue.journals.empty?
1654 1655 # No email should be sent
1655 1656 assert ActionMailer::Base.deliveries.empty?
1656 1657 end
1657 1658
1658 1659 def test_put_update_should_send_a_notification
1659 1660 @request.session[:user_id] = 2
1660 1661 ActionMailer::Base.deliveries.clear
1661 1662 issue = Issue.find(1)
1662 1663 old_subject = issue.subject
1663 1664 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
1664 1665
1665 1666 put :update, :id => 1, :issue => {:subject => new_subject,
1666 1667 :priority_id => '6',
1667 1668 :category_id => '1' # no change
1668 1669 }
1669 1670 assert_equal 1, ActionMailer::Base.deliveries.size
1670 1671 end
1671 1672
1672 1673 def test_put_update_with_invalid_spent_time_hours_only
1673 1674 @request.session[:user_id] = 2
1674 1675 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
1675 1676
1676 1677 assert_no_difference('Journal.count') do
1677 1678 put :update,
1678 1679 :id => 1,
1679 1680 :notes => notes,
1680 1681 :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
1681 1682 end
1682 1683 assert_response :success
1683 1684 assert_template 'edit'
1684 1685
1685 1686 assert_error_tag :descendant => {:content => /Activity can't be blank/}
1686 1687 assert_tag :textarea, :attributes => { :name => 'notes' }, :content => notes
1687 1688 assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" }
1688 1689 end
1689 1690
1690 1691 def test_put_update_with_invalid_spent_time_comments_only
1691 1692 @request.session[:user_id] = 2
1692 1693 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
1693 1694
1694 1695 assert_no_difference('Journal.count') do
1695 1696 put :update,
1696 1697 :id => 1,
1697 1698 :notes => notes,
1698 1699 :time_entry => {"comments"=>"this is my comment", "activity_id"=>"", "hours"=>""}
1699 1700 end
1700 1701 assert_response :success
1701 1702 assert_template 'edit'
1702 1703
1703 1704 assert_error_tag :descendant => {:content => /Activity can't be blank/}
1704 1705 assert_error_tag :descendant => {:content => /Hours can't be blank/}
1705 1706 assert_tag :textarea, :attributes => { :name => 'notes' }, :content => notes
1706 1707 assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => "this is my comment" }
1707 1708 end
1708 1709
1709 1710 def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
1710 1711 issue = Issue.find(2)
1711 1712 @request.session[:user_id] = 2
1712 1713
1713 1714 put :update,
1714 1715 :id => issue.id,
1715 1716 :issue => {
1716 1717 :fixed_version_id => 4
1717 1718 }
1718 1719
1719 1720 assert_response :redirect
1720 1721 issue.reload
1721 1722 assert_equal 4, issue.fixed_version_id
1722 1723 assert_not_equal issue.project_id, issue.fixed_version.project_id
1723 1724 end
1724 1725
1725 1726 def test_put_update_should_redirect_back_using_the_back_url_parameter
1726 1727 issue = Issue.find(2)
1727 1728 @request.session[:user_id] = 2
1728 1729
1729 1730 put :update,
1730 1731 :id => issue.id,
1731 1732 :issue => {
1732 1733 :fixed_version_id => 4
1733 1734 },
1734 1735 :back_url => '/issues'
1735 1736
1736 1737 assert_response :redirect
1737 1738 assert_redirected_to '/issues'
1738 1739 end
1739 1740
1740 1741 def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
1741 1742 issue = Issue.find(2)
1742 1743 @request.session[:user_id] = 2
1743 1744
1744 1745 put :update,
1745 1746 :id => issue.id,
1746 1747 :issue => {
1747 1748 :fixed_version_id => 4
1748 1749 },
1749 1750 :back_url => 'http://google.com'
1750 1751
1751 1752 assert_response :redirect
1752 1753 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id
1753 1754 end
1754 1755
1755 1756 def test_get_bulk_edit
1756 1757 @request.session[:user_id] = 2
1757 1758 get :bulk_edit, :ids => [1, 2]
1758 1759 assert_response :success
1759 1760 assert_template 'bulk_edit'
1760 1761
1761 1762 assert_tag :input, :attributes => {:name => 'issue[parent_issue_id]'}
1762 1763
1763 1764 # Project specific custom field, date type
1764 1765 field = CustomField.find(9)
1765 1766 assert !field.is_for_all?
1766 1767 assert_equal 'date', field.field_format
1767 1768 assert_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
1768 1769
1769 1770 # System wide custom field
1770 1771 assert CustomField.find(1).is_for_all?
1771 1772 assert_tag :select, :attributes => {:name => 'issue[custom_field_values][1]'}
1772 1773
1773 1774 # Be sure we don't display inactive IssuePriorities
1774 1775 assert ! IssuePriority.find(15).active?
1775 1776 assert_no_tag :option, :attributes => {:value => '15'},
1776 1777 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
1777 1778 end
1778 1779
1779 1780 def test_get_bulk_edit_on_different_projects
1780 1781 @request.session[:user_id] = 2
1781 1782 get :bulk_edit, :ids => [1, 2, 6]
1782 1783 assert_response :success
1783 1784 assert_template 'bulk_edit'
1784 1785
1785 1786 # Can not set issues from different projects as children of an issue
1786 1787 assert_no_tag :input, :attributes => {:name => 'issue[parent_issue_id]'}
1787 1788
1788 1789 # Project specific custom field, date type
1789 1790 field = CustomField.find(9)
1790 1791 assert !field.is_for_all?
1791 1792 assert !field.project_ids.include?(Issue.find(6).project_id)
1792 1793 assert_no_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
1793 1794 end
1794 1795
1795 1796 def test_get_bulk_edit_with_user_custom_field
1796 1797 field = IssueCustomField.create!(:name => 'Tester', :field_format => 'user', :is_for_all => true)
1797 1798
1798 1799 @request.session[:user_id] = 2
1799 1800 get :bulk_edit, :ids => [1, 2]
1800 1801 assert_response :success
1801 1802 assert_template 'bulk_edit'
1802 1803
1803 1804 assert_tag :select,
1804 1805 :attributes => {:name => "issue[custom_field_values][#{field.id}]"},
1805 1806 :children => {
1806 1807 :only => {:tag => 'option'},
1807 1808 :count => Project.find(1).users.count + 1
1808 1809 }
1809 1810 end
1810 1811
1811 1812 def test_get_bulk_edit_with_version_custom_field
1812 1813 field = IssueCustomField.create!(:name => 'Affected version', :field_format => 'version', :is_for_all => true)
1813 1814
1814 1815 @request.session[:user_id] = 2
1815 1816 get :bulk_edit, :ids => [1, 2]
1816 1817 assert_response :success
1817 1818 assert_template 'bulk_edit'
1818 1819
1819 1820 assert_tag :select,
1820 1821 :attributes => {:name => "issue[custom_field_values][#{field.id}]"},
1821 1822 :children => {
1822 1823 :only => {:tag => 'option'},
1823 1824 :count => Project.find(1).shared_versions.count + 1
1824 1825 }
1825 1826 end
1826 1827
1827 1828 def test_bulk_update
1828 1829 @request.session[:user_id] = 2
1829 1830 # update issues priority
1830 1831 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
1831 1832 :issue => {:priority_id => 7,
1832 1833 :assigned_to_id => '',
1833 1834 :custom_field_values => {'2' => ''}}
1834 1835
1835 1836 assert_response 302
1836 1837 # check that the issues were updated
1837 1838 assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
1838 1839
1839 1840 issue = Issue.find(1)
1840 1841 journal = issue.journals.find(:first, :order => 'created_on DESC')
1841 1842 assert_equal '125', issue.custom_value_for(2).value
1842 1843 assert_equal 'Bulk editing', journal.notes
1843 1844 assert_equal 1, journal.details.size
1844 1845 end
1845 1846
1846 1847 def test_bulk_update_with_group_assignee
1847 1848 group = Group.find(11)
1848 1849 project = Project.find(1)
1849 1850 project.members << Member.new(:principal => group, :roles => [Role.first])
1850 1851
1851 1852 @request.session[:user_id] = 2
1852 1853 # update issues assignee
1853 1854 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
1854 1855 :issue => {:priority_id => '',
1855 1856 :assigned_to_id => group.id,
1856 1857 :custom_field_values => {'2' => ''}}
1857 1858
1858 1859 assert_response 302
1859 1860 assert_equal [group, group], Issue.find_all_by_id([1, 2]).collect {|i| i.assigned_to}
1860 1861 end
1861 1862
1862 1863 def test_bulk_update_on_different_projects
1863 1864 @request.session[:user_id] = 2
1864 1865 # update issues priority
1865 1866 post :bulk_update, :ids => [1, 2, 6], :notes => 'Bulk editing',
1866 1867 :issue => {:priority_id => 7,
1867 1868 :assigned_to_id => '',
1868 1869 :custom_field_values => {'2' => ''}}
1869 1870
1870 1871 assert_response 302
1871 1872 # check that the issues were updated
1872 1873 assert_equal [7, 7, 7], Issue.find([1,2,6]).map(&:priority_id)
1873 1874
1874 1875 issue = Issue.find(1)
1875 1876 journal = issue.journals.find(:first, :order => 'created_on DESC')
1876 1877 assert_equal '125', issue.custom_value_for(2).value
1877 1878 assert_equal 'Bulk editing', journal.notes
1878 1879 assert_equal 1, journal.details.size
1879 1880 end
1880 1881
1881 1882 def test_bulk_update_on_different_projects_without_rights
1882 1883 @request.session[:user_id] = 3
1883 1884 user = User.find(3)
1884 1885 action = { :controller => "issues", :action => "bulk_update" }
1885 1886 assert user.allowed_to?(action, Issue.find(1).project)
1886 1887 assert ! user.allowed_to?(action, Issue.find(6).project)
1887 1888 post :bulk_update, :ids => [1, 6], :notes => 'Bulk should fail',
1888 1889 :issue => {:priority_id => 7,
1889 1890 :assigned_to_id => '',
1890 1891 :custom_field_values => {'2' => ''}}
1891 1892 assert_response 403
1892 1893 assert_not_equal "Bulk should fail", Journal.last.notes
1893 1894 end
1894 1895
1895 1896 def test_bullk_update_should_send_a_notification
1896 1897 @request.session[:user_id] = 2
1897 1898 ActionMailer::Base.deliveries.clear
1898 1899 post(:bulk_update,
1899 1900 {
1900 1901 :ids => [1, 2],
1901 1902 :notes => 'Bulk editing',
1902 1903 :issue => {
1903 1904 :priority_id => 7,
1904 1905 :assigned_to_id => '',
1905 1906 :custom_field_values => {'2' => ''}
1906 1907 }
1907 1908 })
1908 1909
1909 1910 assert_response 302
1910 1911 assert_equal 2, ActionMailer::Base.deliveries.size
1911 1912 end
1912 1913
1913 1914 def test_bulk_update_status
1914 1915 @request.session[:user_id] = 2
1915 1916 # update issues priority
1916 1917 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing status',
1917 1918 :issue => {:priority_id => '',
1918 1919 :assigned_to_id => '',
1919 1920 :status_id => '5'}
1920 1921
1921 1922 assert_response 302
1922 1923 issue = Issue.find(1)
1923 1924 assert issue.closed?
1924 1925 end
1925 1926
1926 1927 def test_bulk_update_parent_id
1927 1928 @request.session[:user_id] = 2
1928 1929 post :bulk_update, :ids => [1, 3],
1929 1930 :notes => 'Bulk editing parent',
1930 1931 :issue => {:priority_id => '', :assigned_to_id => '', :status_id => '', :parent_issue_id => '2'}
1931 1932
1932 1933 assert_response 302
1933 1934 parent = Issue.find(2)
1934 1935 assert_equal parent.id, Issue.find(1).parent_id
1935 1936 assert_equal parent.id, Issue.find(3).parent_id
1936 1937 assert_equal [1, 3], parent.children.collect(&:id).sort
1937 1938 end
1938 1939
1939 1940 def test_bulk_update_custom_field
1940 1941 @request.session[:user_id] = 2
1941 1942 # update issues priority
1942 1943 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing custom field',
1943 1944 :issue => {:priority_id => '',
1944 1945 :assigned_to_id => '',
1945 1946 :custom_field_values => {'2' => '777'}}
1946 1947
1947 1948 assert_response 302
1948 1949
1949 1950 issue = Issue.find(1)
1950 1951 journal = issue.journals.find(:first, :order => 'created_on DESC')
1951 1952 assert_equal '777', issue.custom_value_for(2).value
1952 1953 assert_equal 1, journal.details.size
1953 1954 assert_equal '125', journal.details.first.old_value
1954 1955 assert_equal '777', journal.details.first.value
1955 1956 end
1956 1957
1957 1958 def test_bulk_update_unassign
1958 1959 assert_not_nil Issue.find(2).assigned_to
1959 1960 @request.session[:user_id] = 2
1960 1961 # unassign issues
1961 1962 post :bulk_update, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'}
1962 1963 assert_response 302
1963 1964 # check that the issues were updated
1964 1965 assert_nil Issue.find(2).assigned_to
1965 1966 end
1966 1967
1967 1968 def test_post_bulk_update_should_allow_fixed_version_to_be_set_to_a_subproject
1968 1969 @request.session[:user_id] = 2
1969 1970
1970 1971 post :bulk_update, :ids => [1,2], :issue => {:fixed_version_id => 4}
1971 1972
1972 1973 assert_response :redirect
1973 1974 issues = Issue.find([1,2])
1974 1975 issues.each do |issue|
1975 1976 assert_equal 4, issue.fixed_version_id
1976 1977 assert_not_equal issue.project_id, issue.fixed_version.project_id
1977 1978 end
1978 1979 end
1979 1980
1980 1981 def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter
1981 1982 @request.session[:user_id] = 2
1982 1983 post :bulk_update, :ids => [1,2], :back_url => '/issues'
1983 1984
1984 1985 assert_response :redirect
1985 1986 assert_redirected_to '/issues'
1986 1987 end
1987 1988
1988 1989 def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
1989 1990 @request.session[:user_id] = 2
1990 1991 post :bulk_update, :ids => [1,2], :back_url => 'http://google.com'
1991 1992
1992 1993 assert_response :redirect
1993 1994 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier
1994 1995 end
1995 1996
1996 1997 def test_destroy_issue_with_no_time_entries
1997 1998 assert_nil TimeEntry.find_by_issue_id(2)
1998 1999 @request.session[:user_id] = 2
1999 2000 post :destroy, :id => 2
2000 2001 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
2001 2002 assert_nil Issue.find_by_id(2)
2002 2003 end
2003 2004
2004 2005 def test_destroy_issues_with_time_entries
2005 2006 @request.session[:user_id] = 2
2006 2007 post :destroy, :ids => [1, 3]
2007 2008 assert_response :success
2008 2009 assert_template 'destroy'
2009 2010 assert_not_nil assigns(:hours)
2010 2011 assert Issue.find_by_id(1) && Issue.find_by_id(3)
2011 2012 end
2012 2013
2013 2014 def test_destroy_issues_and_destroy_time_entries
2014 2015 @request.session[:user_id] = 2
2015 2016 post :destroy, :ids => [1, 3], :todo => 'destroy'
2016 2017 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
2017 2018 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
2018 2019 assert_nil TimeEntry.find_by_id([1, 2])
2019 2020 end
2020 2021
2021 2022 def test_destroy_issues_and_assign_time_entries_to_project
2022 2023 @request.session[:user_id] = 2
2023 2024 post :destroy, :ids => [1, 3], :todo => 'nullify'
2024 2025 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
2025 2026 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
2026 2027 assert_nil TimeEntry.find(1).issue_id
2027 2028 assert_nil TimeEntry.find(2).issue_id
2028 2029 end
2029 2030
2030 2031 def test_destroy_issues_and_reassign_time_entries_to_another_issue
2031 2032 @request.session[:user_id] = 2
2032 2033 post :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2
2033 2034 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
2034 2035 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
2035 2036 assert_equal 2, TimeEntry.find(1).issue_id
2036 2037 assert_equal 2, TimeEntry.find(2).issue_id
2037 2038 end
2038 2039
2039 2040 def test_destroy_issues_from_different_projects
2040 2041 @request.session[:user_id] = 2
2041 2042 post :destroy, :ids => [1, 2, 6], :todo => 'destroy'
2042 2043 assert_redirected_to :controller => 'issues', :action => 'index'
2043 2044 assert !(Issue.find_by_id(1) || Issue.find_by_id(2) || Issue.find_by_id(6))
2044 2045 end
2045 2046
2046 2047 def test_destroy_parent_and_child_issues
2047 2048 parent = Issue.generate!(:project_id => 1, :tracker_id => 1)
2048 2049 child = Issue.generate!(:project_id => 1, :tracker_id => 1, :parent_issue_id => parent.id)
2049 2050 assert child.is_descendant_of?(parent.reload)
2050 2051
2051 2052 @request.session[:user_id] = 2
2052 2053 assert_difference 'Issue.count', -2 do
2053 2054 post :destroy, :ids => [parent.id, child.id], :todo => 'destroy'
2054 2055 end
2055 2056 assert_response 302
2056 2057 end
2057 2058
2058 2059 def test_default_search_scope
2059 2060 get :index
2060 2061 assert_tag :div, :attributes => {:id => 'quick-search'},
2061 2062 :child => {:tag => 'form',
2062 2063 :child => {:tag => 'input', :attributes => {:name => 'issues', :type => 'hidden', :value => '1'}}}
2063 2064 end
2064 2065 end
General Comments 0
You need to be logged in to leave comments. Login now