##// END OF EJS Templates
Merged r4652 from trunk....
Toshi MARUYAMA -
r4533:6318affd314e
parent child
Show More
@@ -1,316 +1,318
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2008 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class IssuesController < ApplicationController
19 19 menu_item :new_issue, :only => [:new, :create]
20 20 default_search_scope :issues
21 21
22 22 before_filter :find_issue, :only => [:show, :edit, :update]
23 23 before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :move, :perform_move, :destroy]
24 24 before_filter :check_project_uniqueness, :only => [:move, :perform_move]
25 25 before_filter :find_project, :only => [:new, :create]
26 26 before_filter :authorize, :except => [:index]
27 27 before_filter :find_optional_project, :only => [:index]
28 28 before_filter :check_for_default_issue_status, :only => [:new, :create]
29 29 before_filter :build_new_issue_from_params, :only => [:new, :create]
30 30 accept_key_auth :index, :show, :create, :update, :destroy
31 31
32 32 rescue_from Query::StatementInvalid, :with => :query_statement_invalid
33 33
34 34 helper :journals
35 35 helper :projects
36 36 include ProjectsHelper
37 37 helper :custom_fields
38 38 include CustomFieldsHelper
39 39 helper :issue_relations
40 40 include IssueRelationsHelper
41 41 helper :watchers
42 42 include WatchersHelper
43 43 helper :attachments
44 44 include AttachmentsHelper
45 45 helper :queries
46 46 include QueriesHelper
47 helper :repositories
48 include RepositoriesHelper
47 49 helper :sort
48 50 include SortHelper
49 51 include IssuesHelper
50 52 helper :timelog
51 53 helper :gantt
52 54 include Redmine::Export::PDF
53 55
54 56 verify :method => [:post, :delete],
55 57 :only => :destroy,
56 58 :render => { :nothing => true, :status => :method_not_allowed }
57 59
58 60 verify :method => :post, :only => :create, :render => {:nothing => true, :status => :method_not_allowed }
59 61 verify :method => :post, :only => :bulk_update, :render => {:nothing => true, :status => :method_not_allowed }
60 62 verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed }
61 63
62 64 def index
63 65 retrieve_query
64 66 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
65 67 sort_update(@query.sortable_columns)
66 68
67 69 if @query.valid?
68 70 case params[:format]
69 71 when 'csv', 'pdf'
70 72 @limit = Setting.issues_export_limit.to_i
71 73 when 'atom'
72 74 @limit = Setting.feeds_limit.to_i
73 75 when 'xml', 'json'
74 76 @offset, @limit = api_offset_and_limit
75 77 else
76 78 @limit = per_page_option
77 79 end
78 80
79 81 @issue_count = @query.issue_count
80 82 @issue_pages = Paginator.new self, @issue_count, @limit, params['page']
81 83 @offset ||= @issue_pages.current.offset
82 84 @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
83 85 :order => sort_clause,
84 86 :offset => @offset,
85 87 :limit => @limit)
86 88 @issue_count_by_group = @query.issue_count_by_group
87 89
88 90 respond_to do |format|
89 91 format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? }
90 92 format.api
91 93 format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
92 94 format.csv { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') }
93 95 format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }
94 96 end
95 97 else
96 98 # Send html if the query is not valid
97 99 render(:template => 'issues/index.rhtml', :layout => !request.xhr?)
98 100 end
99 101 rescue ActiveRecord::RecordNotFound
100 102 render_404
101 103 end
102 104
103 105 def show
104 106 @journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")
105 107 @journals.each_with_index {|j,i| j.indice = i+1}
106 108 @journals.reverse! if User.current.wants_comments_in_reverse_order?
107 109 @changesets = @issue.changesets.visible.all
108 110 @changesets.reverse! if User.current.wants_comments_in_reverse_order?
109 111 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
110 112 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
111 113 @priorities = IssuePriority.all
112 114 @time_entry = TimeEntry.new
113 115 respond_to do |format|
114 116 format.html { render :template => 'issues/show.rhtml' }
115 117 format.api
116 118 format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }
117 119 format.pdf { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }
118 120 end
119 121 end
120 122
121 123 # Add a new issue
122 124 # The new issue will be created from an existing one if copy_from parameter is given
123 125 def new
124 126 respond_to do |format|
125 127 format.html { render :action => 'new', :layout => !request.xhr? }
126 128 format.js { render :partial => 'attributes' }
127 129 end
128 130 end
129 131
130 132 def create
131 133 call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
132 134 if @issue.save
133 135 attachments = Attachment.attach_files(@issue, params[:attachments])
134 136 render_attachment_warning_if_needed(@issue)
135 137 flash[:notice] = l(:notice_successful_create)
136 138 call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
137 139 respond_to do |format|
138 140 format.html {
139 141 redirect_to(params[:continue] ? { :action => 'new', :project_id => @project, :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :
140 142 { :action => 'show', :id => @issue })
141 143 }
142 144 format.api { render :action => 'show', :status => :created, :location => issue_url(@issue) }
143 145 end
144 146 return
145 147 else
146 148 respond_to do |format|
147 149 format.html { render :action => 'new' }
148 150 format.api { render_validation_errors(@issue) }
149 151 end
150 152 end
151 153 end
152 154
153 155 def edit
154 156 update_issue_from_params
155 157
156 158 @journal = @issue.current_journal
157 159
158 160 respond_to do |format|
159 161 format.html { }
160 162 format.xml { }
161 163 end
162 164 end
163 165
164 166 def update
165 167 update_issue_from_params
166 168
167 169 if @issue.save_issue_with_child_records(params, @time_entry)
168 170 render_attachment_warning_if_needed(@issue)
169 171 flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
170 172
171 173 respond_to do |format|
172 174 format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }
173 175 format.api { head :ok }
174 176 end
175 177 else
176 178 render_attachment_warning_if_needed(@issue)
177 179 flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
178 180 @journal = @issue.current_journal
179 181
180 182 respond_to do |format|
181 183 format.html { render :action => 'edit' }
182 184 format.api { render_validation_errors(@issue) }
183 185 end
184 186 end
185 187 end
186 188
187 189 # Bulk edit a set of issues
188 190 def bulk_edit
189 191 @issues.sort!
190 192 @available_statuses = @projects.map{|p|Workflow.available_statuses(p)}.inject{|memo,w|memo & w}
191 193 @custom_fields = @projects.map{|p|p.all_issue_custom_fields}.inject{|memo,c|memo & c}
192 194 @assignables = @projects.map(&:assignable_users).inject{|memo,a| memo & a}
193 195 @trackers = @projects.map(&:trackers).inject{|memo,t| memo & t}
194 196 end
195 197
196 198 def bulk_update
197 199 @issues.sort!
198 200 attributes = parse_params_for_bulk_issue_attributes(params)
199 201
200 202 unsaved_issue_ids = []
201 203 @issues.each do |issue|
202 204 issue.reload
203 205 journal = issue.init_journal(User.current, params[:notes])
204 206 issue.safe_attributes = attributes
205 207 call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
206 208 unless issue.save
207 209 # Keep unsaved issue ids to display them in flash error
208 210 unsaved_issue_ids << issue.id
209 211 end
210 212 end
211 213 set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)
212 214 redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})
213 215 end
214 216
215 217 def destroy
216 218 @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f
217 219 if @hours > 0
218 220 case params[:todo]
219 221 when 'destroy'
220 222 # nothing to do
221 223 when 'nullify'
222 224 TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])
223 225 when 'reassign'
224 226 reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
225 227 if reassign_to.nil?
226 228 flash.now[:error] = l(:error_issue_not_found_in_project)
227 229 return
228 230 else
229 231 TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])
230 232 end
231 233 else
232 234 # display the destroy form if it's a user request
233 235 return unless api_request?
234 236 end
235 237 end
236 238 @issues.each(&:destroy)
237 239 respond_to do |format|
238 240 format.html { redirect_back_or_default(:action => 'index', :project_id => @project) }
239 241 format.api { head :ok }
240 242 end
241 243 end
242 244
243 245 private
244 246 def find_issue
245 247 @issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])
246 248 @project = @issue.project
247 249 rescue ActiveRecord::RecordNotFound
248 250 render_404
249 251 end
250 252
251 253 def find_project
252 254 project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id]
253 255 @project = Project.find(project_id)
254 256 rescue ActiveRecord::RecordNotFound
255 257 render_404
256 258 end
257 259
258 260 # Used by #edit and #update to set some common instance variables
259 261 # from the params
260 262 # TODO: Refactor, not everything in here is needed by #edit
261 263 def update_issue_from_params
262 264 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
263 265 @priorities = IssuePriority.all
264 266 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
265 267 @time_entry = TimeEntry.new
266 268 @time_entry.attributes = params[:time_entry]
267 269
268 270 @notes = params[:notes] || (params[:issue].present? ? params[:issue][:notes] : nil)
269 271 @issue.init_journal(User.current, @notes)
270 272 @issue.safe_attributes = params[:issue]
271 273 end
272 274
273 275 # TODO: Refactor, lots of extra code in here
274 276 # TODO: Changing tracker on an existing issue should not trigger this
275 277 def build_new_issue_from_params
276 278 if params[:id].blank?
277 279 @issue = Issue.new
278 280 @issue.copy_from(params[:copy_from]) if params[:copy_from]
279 281 @issue.project = @project
280 282 else
281 283 @issue = @project.issues.visible.find(params[:id])
282 284 end
283 285
284 286 @issue.project = @project
285 287 # Tracker must be set before custom field values
286 288 @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
287 289 if @issue.tracker.nil?
288 290 render_error l(:error_no_tracker_in_project)
289 291 return false
290 292 end
291 293 @issue.start_date ||= Date.today
292 294 if params[:issue].is_a?(Hash)
293 295 @issue.safe_attributes = params[:issue]
294 296 if User.current.allowed_to?(:add_issue_watchers, @project) && @issue.new_record?
295 297 @issue.watcher_user_ids = params[:issue]['watcher_user_ids']
296 298 end
297 299 end
298 300 @issue.author = User.current
299 301 @priorities = IssuePriority.all
300 302 @allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)
301 303 end
302 304
303 305 def check_for_default_issue_status
304 306 if IssueStatus.default.nil?
305 307 render_error l(:error_no_default_issue_status)
306 308 return false
307 309 end
308 310 end
309 311
310 312 def parse_params_for_bulk_issue_attributes(params)
311 313 attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
312 314 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
313 315 attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]
314 316 attributes
315 317 end
316 318 end
@@ -1,10 +1,10
1 1 <% changesets.each do |changeset| %>
2 2 <div class="changeset <%= cycle('odd', 'even') %>">
3 <p><%= link_to("#{l(:label_revision)} #{changeset.revision}",
4 :controller => 'repositories', :action => 'revision', :id => changeset.project, :rev => changeset.revision) %><br />
3 <p><%= link_to_revision(changeset, changeset.project,
4 :text => "#{l(:label_revision)} #{changeset.format_identifier}") %><br />
5 5 <span class="author"><%= authoring(changeset.committed_on, changeset.author) %></span></p>
6 6 <div class="changeset-changes">
7 7 <%= textilizable(changeset, :comments) %>
8 8 </div>
9 9 </div>
10 10 <% end %>
General Comments 0
You need to be logged in to leave comments. Login now