jro_apps/redmine Commit - r11635:61dfab12fd72

Removed some shoulda context....

Jean-Philippe Lang -

r11635:61dfab12fd72

parent child

Context file:

r11635:61dfab12fd72

Collapse all files

test/object_helpers.rb +1 0

             module ObjectHelpers
               def User.generate!(attributes={})
                 @generated_user_login ||= 'user0'
                 @generated_user_login.succ!
                 user = User.new(attributes)
                 user.login = @generated_user_login.dup if user.login.blank?
                 user.mail = "#{@generated_user_login}@example.com" if user.mail.blank?
                 user.firstname = "Bob" if user.firstname.blank?
                 user.lastname = "Doe" if user.lastname.blank?
                 yield user if block_given?
                 user.save!
                 user
               end
               def User.add_to_project(user, project, roles=nil)
                 roles = Role.find(1) if roles.nil?
                 roles = [roles] unless roles.is_a?(Array)
                 Member.create!(:principal => user, :project => project, :roles => roles)
               end
               def Group.generate!(attributes={})
                 @generated_group_name ||= 'Group 0'
                 @generated_group_name.succ!
                 group = Group.new(attributes)
                 group.name = @generated_group_name.dup if group.name.blank?
                 yield group if block_given?
                 group.save!
                 group
               end
               def Project.generate!(attributes={})
                 @generated_project_identifier ||= 'project-0000'
                 @generated_project_identifier.succ!
                 project = Project.new(attributes)
                 project.name = @generated_project_identifier.dup if project.name.blank?
                 project.identifier = @generated_project_identifier.dup if project.identifier.blank?
                 yield project if block_given?
                 project.save!
                 project
               end
               def Project.generate_with_parent!(parent, attributes={})
                 project = Project.generate!(attributes)
                 project.set_parent!(parent)
                 project
               end
               def Tracker.generate!(attributes={})
                 @generated_tracker_name ||= 'Tracker 0'
                 @generated_tracker_name.succ!
                 tracker = Tracker.new(attributes)
                 tracker.name = @generated_tracker_name.dup if tracker.name.blank?
                 yield tracker if block_given?
                 tracker.save!
                 tracker
               end
               def Role.generate!(attributes={})
                 @generated_role_name ||= 'Role 0'
                 @generated_role_name.succ!
                 role = Role.new(attributes)
                 role.name = @generated_role_name.dup if role.name.blank?
                 yield role if block_given?
                 role.save!
                 role
               end
               def Issue.generate!(attributes={})
                 issue = Issue.new(attributes)
                 issue.project ||= Project.find(1)
                 issue.tracker ||= issue.project.trackers.first
                 issue.subject = 'Generated' if issue.subject.blank?
                 issue.author ||= User.find(2)
                 yield issue if block_given?
                 issue.save!
                 issue
               end
               # Generates an issue with 2 children and a grandchild
               def Issue.generate_with_descendants!(attributes={})
                 issue = Issue.generate!(attributes)
                 child = Issue.generate!(:project => issue.project, :subject => 'Child1', :parent_issue_id => issue.id)
                 Issue.generate!(:project => issue.project, :subject => 'Child2', :parent_issue_id => issue.id)
                 Issue.generate!(:project => issue.project, :subject => 'Child11', :parent_issue_id => child.id)
                 issue.reload
               end
               def Journal.generate!(attributes={})
                 journal = Journal.new(attributes)
                 journal.user ||= User.first
                 journal.journalized ||= Issue.first
                 yield journal if block_given?
                 journal.save!
                 journal
               end
               def Version.generate!(attributes={})
                 @generated_version_name ||= 'Version 0'
                 @generated_version_name.succ!
                 version = Version.new(attributes)
                 version.name = @generated_version_name.dup if version.name.blank?
+                version.project ||= Project.find(1)
                 yield version if block_given?
                 version.save!
                 version
               end
               def TimeEntry.generate!(attributes={})
                 entry = TimeEntry.new(attributes)
                 entry.user ||= User.find(2)
                 entry.issue ||= Issue.find(1) unless entry.project
                 entry.project ||= entry.issue.project
                 entry.activity ||= TimeEntryActivity.first
                 entry.spent_on ||= Date.today
                 entry.hours ||= 1.0
                 entry.save!
                 entry
               end
               def AuthSource.generate!(attributes={})
                 @generated_auth_source_name ||= 'Auth 0'
                 @generated_auth_source_name.succ!
                 source = AuthSource.new(attributes)
                 source.name = @generated_auth_source_name.dup if source.name.blank?
                 yield source if block_given?
                 source.save!
                 source
               end
               def Board.generate!(attributes={})
                 @generated_board_name ||= 'Forum 0'
                 @generated_board_name.succ!
                 board = Board.new(attributes)
                 board.name = @generated_board_name.dup if board.name.blank?
                 board.description = @generated_board_name.dup if board.description.blank?
                 yield board if block_given?
                 board.save!
                 board
               end
               def Attachment.generate!(attributes={})
                 @generated_filename ||= 'testfile0'
                 @generated_filename.succ!
                 attributes = attributes.dup
                 attachment = Attachment.new(attributes)
                 attachment.container ||= Issue.find(1)
                 attachment.author ||= User.find(2)
                 attachment.filename = @generated_filename.dup if attachment.filename.blank?
                 attachment.save!
                 attachment
               end
               def CustomField.generate!(attributes={})
                 @generated_custom_field_name ||= 'Custom field 0'
                 @generated_custom_field_name.succ!
                 field = new(attributes)
                 field.name = @generated_custom_field_name.dup if field.name.blank?
                 field.field_format = 'string' if field.field_format.blank?
                 yield field if block_given?
                 field.save!
                 field
               end
             end

test/unit/initializers/patches_test.rb +11 -13

             # Redmine - project management software
             # Copyright (C) 2006-2013  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../../test_helper', __FILE__)
             class PatchesTest < ActiveSupport::TestCase
               include Redmine::I18n
-              context "ActiveRecord::Base.human_attribute_name" do
+              def setup
-                setup do
+                Setting.default_language = 'en'
-                  Setting.default_language = 'en'
+              end
-                end
-                should "transform name to field_name" do
+              test "ActiveRecord::Base.human_attribute_name should transform name to field_name" do
-                  assert_equal l('field_last_login_on'), ActiveRecord::Base.human_attribute_name('last_login_on')
+                assert_equal l('field_last_login_on'), ActiveRecord::Base.human_attribute_name('last_login_on')
-                end
+              end
-                should "cut extra _id suffix for better validation" do
+              test "ActiveRecord::Base.human_attribute_name should cut extra _id suffix for better validation" do
-                  assert_equal l('field_last_login_on'), ActiveRecord::Base.human_attribute_name('last_login_on_id')
+                assert_equal l('field_last_login_on'), ActiveRecord::Base.human_attribute_name('last_login_on_id')
-                end
+              end
-                should "default to humanized value if no translation has been found (useful for custom fields)" do
+              test "ActiveRecord::Base.human_attribute_name should default to humanized value if no translation has been found (useful for custom fields)" do
-                  assert_equal 'Patch name', ActiveRecord::Base.human_attribute_name('Patch name')
+                assert_equal 'Patch name', ActiveRecord::Base.human_attribute_name('Patch name')
-                end
               end
             end

test/unit/lib/redmine/menu_manager/mapper_test.rb +10 -12

             # Redmine - project management software
             # Copyright (C) 2006-2013  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../../../../test_helper', __FILE__)
             class Redmine::MenuManager::MapperTest < ActiveSupport::TestCase
-              context "Mapper#initialize" do
+              test "Mapper#initialize should define a root MenuNode if menu is not present in items" do
-                should "define a root MenuNode if menu is not present in items" do
+                menu_mapper = Redmine::MenuManager::Mapper.new(:test_menu, {})
-                  menu_mapper = Redmine::MenuManager::Mapper.new(:test_menu, {})
+                node = menu_mapper.menu_items
-                  node = menu_mapper.menu_items
+                assert_not_nil node
-                  assert_not_nil node
+                assert_equal :root, node.name
-                  assert_equal :root, node.name
+              end
-                end
-                should "use existing MenuNode if present" do
+              test "Mapper#initialize should use existing MenuNode if present" do
-                  node = "foo" # just an arbitrary reference
+                node = "foo" # just an arbitrary reference
-                  menu_mapper = Redmine::MenuManager::Mapper.new(:test_menu, {:test_menu => node})
+                menu_mapper = Redmine::MenuManager::Mapper.new(:test_menu, {:test_menu => node})
-                  assert_equal node, menu_mapper.menu_items
+                assert_equal node, menu_mapper.menu_items
-                end
               end
               def test_push_onto_root
                 menu_mapper = Redmine::MenuManager::Mapper.new(:test_menu, {})
                 menu_mapper.push :test_overview, { :controller => 'projects', :action => 'show'}, {}
                 menu_mapper.exists?(:test_overview)
               end
               def test_push_onto_parent
                 menu_mapper = Redmine::MenuManager::Mapper.new(:test_menu, {})
                 menu_mapper.push :test_overview, { :controller => 'projects', :action => 'show'}, {}
                 menu_mapper.push :test_child, { :controller => 'projects', :action => 'show'}, {:parent => :test_overview}
                 assert menu_mapper.exists?(:test_child)
                 assert_equal :test_child, menu_mapper.find(:test_child).name
               end
               def test_push_onto_grandparent
                 menu_mapper = Redmine::MenuManager::Mapper.new(:test_menu, {})
                 menu_mapper.push :test_overview, { :controller => 'projects', :action => 'show'}, {}
                 menu_mapper.push :test_child, { :controller => 'projects', :action => 'show'}, {:parent => :test_overview}
                 menu_mapper.push :test_grandchild, { :controller => 'projects', :action => 'show'}, {:parent => :test_child}
                 assert menu_mapper.exists?(:test_grandchild)
                 grandchild = menu_mapper.find(:test_grandchild)
                 assert_equal :test_grandchild, grandchild.name
                 assert_equal :test_child, grandchild.parent.name
               end
               def test_push_first
                 menu_mapper = Redmine::MenuManager::Mapper.new(:test_menu, {})
                 menu_mapper.push :test_second, { :controller => 'projects', :action => 'show'}, {}
                 menu_mapper.push :test_third, { :controller => 'projects', :action => 'show'}, {}
                 menu_mapper.push :test_fourth, { :controller => 'projects', :action => 'show'}, {}
                 menu_mapper.push :test_fifth, { :controller => 'projects', :action => 'show'}, {}
                 menu_mapper.push :test_first, { :controller => 'projects', :action => 'show'}, {:first => true}
                 root = menu_mapper.find(:root)
                 assert_equal 5, root.children.size
                 {0 => :test_first, 1 => :test_second, 2 => :test_third, 3 => :test_fourth, 4 => :test_fifth}.each do |position, name|
                   assert_not_nil root.children[position]
                   assert_equal name, root.children[position].name
                 end
               end
               def test_push_before
                 menu_mapper = Redmine::MenuManager::Mapper.new(:test_menu, {})
                 menu_mapper.push :test_first, { :controller => 'projects', :action => 'show'}, {}
                 menu_mapper.push :test_second, { :controller => 'projects', :action => 'show'}, {}
                 menu_mapper.push :test_fourth, { :controller => 'projects', :action => 'show'}, {}
                 menu_mapper.push :test_fifth, { :controller => 'projects', :action => 'show'}, {}
                 menu_mapper.push :test_third, { :controller => 'projects', :action => 'show'}, {:before => :test_fourth}
                 root = menu_mapper.find(:root)
                 assert_equal 5, root.children.size
                 {0 => :test_first, 1 => :test_second, 2 => :test_third, 3 => :test_fourth, 4 => :test_fifth}.each do |position, name|
                   assert_not_nil root.children[position]
                   assert_equal name, root.children[position].name
                 end
               end
               def test_push_after
                 menu_mapper = Redmine::MenuManager::Mapper.new(:test_menu, {})
                 menu_mapper.push :test_first, { :controller => 'projects', :action => 'show'}, {}
                 menu_mapper.push :test_second, { :controller => 'projects', :action => 'show'}, {}
                 menu_mapper.push :test_third, { :controller => 'projects', :action => 'show'}, {}
                 menu_mapper.push :test_fifth, { :controller => 'projects', :action => 'show'}, {}
                 menu_mapper.push :test_fourth, { :controller => 'projects', :action => 'show'}, {:after => :test_third}
                 root = menu_mapper.find(:root)
                 assert_equal 5, root.children.size
                 {0 => :test_first, 1 => :test_second, 2 => :test_third, 3 => :test_fourth, 4 => :test_fifth}.each do |position, name|
                   assert_not_nil root.children[position]
                   assert_equal name, root.children[position].name
                 end
               end
               def test_push_last
                 menu_mapper = Redmine::MenuManager::Mapper.new(:test_menu, {})
                 menu_mapper.push :test_first, { :controller => 'projects', :action => 'show'}, {}
                 menu_mapper.push :test_second, { :controller => 'projects', :action => 'show'}, {}
                 menu_mapper.push :test_third, { :controller => 'projects', :action => 'show'}, {}
                 menu_mapper.push :test_fifth, { :controller => 'projects', :action => 'show'}, {:last => true}
                 menu_mapper.push :test_fourth, { :controller => 'projects', :action => 'show'}, {}
                 root = menu_mapper.find(:root)
                 assert_equal 5, root.children.size
                 {0 => :test_first, 1 => :test_second, 2 => :test_third, 3 => :test_fourth, 4 => :test_fifth}.each do |position, name|
                   assert_not_nil root.children[position]
                   assert_equal name, root.children[position].name
                 end
               end
               def test_exists_for_child_node
                 menu_mapper = Redmine::MenuManager::Mapper.new(:test_menu, {})
                 menu_mapper.push :test_overview, { :controller => 'projects', :action => 'show'}, {}
                 menu_mapper.push :test_child, { :controller => 'projects', :action => 'show'}, {:parent => :test_overview }
                 assert menu_mapper.exists?(:test_child)
               end
               def test_exists_for_invalid_node
                 menu_mapper = Redmine::MenuManager::Mapper.new(:test_menu, {})
                 menu_mapper.push :test_overview, { :controller => 'projects', :action => 'show'}, {}
                 assert !menu_mapper.exists?(:nothing)
               end
               def test_find
                 menu_mapper = Redmine::MenuManager::Mapper.new(:test_menu, {})
                 menu_mapper.push :test_overview, { :controller => 'projects', :action => 'show'}, {}
                 item = menu_mapper.find(:test_overview)
                 assert_equal :test_overview, item.name
                 assert_equal({:controller => 'projects', :action => 'show'}, item.url)
               end
               def test_find_missing
                 menu_mapper = Redmine::MenuManager::Mapper.new(:test_menu, {})
                 menu_mapper.push :test_overview, { :controller => 'projects', :action => 'show'}, {}
                 item = menu_mapper.find(:nothing)
                 assert_equal nil, item
               end
               def test_delete
                 menu_mapper = Redmine::MenuManager::Mapper.new(:test_menu, {})
                 menu_mapper.push :test_overview, { :controller => 'projects', :action => 'show'}, {}
                 assert_not_nil menu_mapper.delete(:test_overview)
                 assert_nil menu_mapper.find(:test_overview)
               end
               def test_delete_missing
                 menu_mapper = Redmine::MenuManager::Mapper.new(:test_menu, {})
                 assert_nil menu_mapper.delete(:test_missing)
               end
               test 'deleting all items' do
                 # Exposed by deleting :last items
                 Redmine::MenuManager.map :test_menu do |menu|
                   menu.push :not_last, Redmine::Info.help_url
                   menu.push :administration, { :controller => 'projects', :action => 'show'}, {:last => true}
                   menu.push :help, Redmine::Info.help_url, :last => true
                 end
                 assert_nothing_raised do
                   Redmine::MenuManager.map :test_menu do |menu|
                     menu.delete(:administration)
                     menu.delete(:help)
                     menu.push :test_overview, { :controller => 'projects', :action => 'show'}, {}
                  end
                 end
               end
             end

test/unit/user_test.rb +67 -82

             # Redmine - project management software
             # Copyright (C) 2006-2013  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class UserTest < ActiveSupport::TestCase
               fixtures :users, :members, :projects, :roles, :member_roles, :auth_sources,
                         :trackers, :issue_statuses,
                         :projects_trackers,
                         :watchers,
                         :issue_categories, :enumerations, :issues,
                         :journals, :journal_details,
                         :groups_users,
                         :enabled_modules
               def setup
                 @admin = User.find(1)
                 @jsmith = User.find(2)
                 @dlopper = User.find(3)
               end
               def test_sorted_scope_should_sort_user_by_display_name
                 assert_equal User.all.map(&:name).map(&:downcase).sort, User.sorted.all.map(&:name).map(&:downcase)
               end
               def test_generate
                 User.generate!(:firstname => 'Testing connection')
                 User.generate!(:firstname => 'Testing connection')
                 assert_equal 2, User.count(:all, :conditions => {:firstname => 'Testing connection'})
               end
               def test_truth
                 assert_kind_of User, @jsmith
               end
               def test_mail_should_be_stripped
                 u = User.new
                 u.mail = " foo@bar.com  "
                 assert_equal "foo@bar.com", u.mail
               end
               def test_mail_validation
                 u = User.new
                 u.mail = ''
                 assert !u.valid?
                 assert_include I18n.translate('activerecord.errors.messages.blank'), u.errors[:mail]
               end
               def test_login_length_validation
                 user = User.new(:firstname => "new", :lastname => "user", :mail => "newuser@somenet.foo")
                 user.login = "x" * (User::LOGIN_LENGTH_LIMIT+1)
                 assert !user.valid?
                 user.login = "x" * (User::LOGIN_LENGTH_LIMIT)
                 assert user.valid?
                 assert user.save
               end
               def test_generate_password_should_respect_minimum_password_length
                 with_settings :password_min_length => 15 do
                   user = User.generate!(:generate_password => true)
                   assert user.password.length >= 15
                 end
               end
               def test_generate_password_should_not_generate_password_with_less_than_10_characters
                 with_settings :password_min_length => 4 do
                   user = User.generate!(:generate_password => true)
                   assert user.password.length >= 10
                 end
               end
               def test_generate_password_on_create_should_set_password
                 user = User.new(:firstname => "new", :lastname => "user", :mail => "newuser@somenet.foo")
                 user.login = "newuser"
                 user.generate_password = true
                 assert user.save
                 password = user.password
                 assert user.check_password?(password)
               end
               def test_generate_password_on_update_should_update_password
                 user = User.find(2)
                 hash = user.hashed_password
                 user.generate_password = true
                 assert user.save
                 password = user.password
                 assert user.check_password?(password)
                 assert_not_equal hash, user.reload.hashed_password
               end
               def test_create
                 user = User.new(:firstname => "new", :lastname => "user", :mail => "newuser@somenet.foo")
                 user.login = "jsmith"
                 user.password, user.password_confirmation = "password", "password"
                 # login uniqueness
                 assert !user.save
                 assert_equal 1, user.errors.count
                 user.login = "newuser"
                 user.password, user.password_confirmation = "password", "pass"
                 # password confirmation
                 assert !user.save
                 assert_equal 1, user.errors.count
                 user.password, user.password_confirmation = "password", "password"
                 assert user.save
               end
               def test_user_before_create_should_set_the_mail_notification_to_the_default_setting
                 @user1 = User.generate!
                 assert_equal 'only_my_events', @user1.mail_notification
                 with_settings :default_notification_option => 'all' do
                   @user2 = User.generate!
                   assert_equal 'all', @user2.mail_notification
                 end
               end
               def test_user_login_should_be_case_insensitive
                 u = User.new(:firstname => "new", :lastname => "user", :mail => "newuser@somenet.foo")
                 u.login = 'newuser'
                 u.password, u.password_confirmation = "password", "password"
                 assert u.save
                 u = User.new(:firstname => "Similar", :lastname => "User", :mail => "similaruser@somenet.foo")
                 u.login = 'NewUser'
                 u.password, u.password_confirmation = "password", "password"
                 assert !u.save
                 assert_include I18n.translate('activerecord.errors.messages.taken'), u.errors[:login]
               end
               def test_mail_uniqueness_should_not_be_case_sensitive
                 u = User.new(:firstname => "new", :lastname => "user", :mail => "newuser@somenet.foo")
                 u.login = 'newuser1'
                 u.password, u.password_confirmation = "password", "password"
                 assert u.save
                 u = User.new(:firstname => "new", :lastname => "user", :mail => "newUser@Somenet.foo")
                 u.login = 'newuser2'
                 u.password, u.password_confirmation = "password", "password"
                 assert !u.save
                 assert_include I18n.translate('activerecord.errors.messages.taken'), u.errors[:mail]
               end
               def test_update
                 assert_equal "admin", @admin.login
                 @admin.login = "john"
                 assert @admin.save, @admin.errors.full_messages.join("; ")
                 @admin.reload
                 assert_equal "john", @admin.login
               end
               def test_update_should_not_fail_for_legacy_user_with_different_case_logins
                 u1 = User.new(:firstname => "new", :lastname => "user", :mail => "newuser1@somenet.foo")
                 u1.login = 'newuser1'
                 assert u1.save
                 u2 = User.new(:firstname => "new", :lastname => "user", :mail => "newuser2@somenet.foo")
                 u2.login = 'newuser1'
                 assert u2.save(:validate => false)
                 user = User.find(u2.id)
                 user.firstname = "firstname"
                 assert user.save, "Save failed"
               end
               def test_destroy_should_delete_members_and_roles
                 members = Member.find_all_by_user_id(2)
                 ms = members.size
                 rs = members.collect(&:roles).flatten.size
                 assert_difference 'Member.count', - ms do
                   assert_difference 'MemberRole.count', - rs do
                     User.find(2).destroy
                   end
                 end
                 assert_nil User.find_by_id(2)
                 assert Member.find_all_by_user_id(2).empty?
               end
               def test_destroy_should_update_attachments
                 attachment = Attachment.create!(:container => Project.find(1),
                   :file => uploaded_test_file("testfile.txt", "text/plain"),
                   :author_id => 2)
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous, attachment.reload.author
               end
               def test_destroy_should_update_comments
                 comment = Comment.create!(
                   :commented => News.create!(:project_id => 1, :author_id => 1, :title => 'foo', :description => 'foo'),
                   :author => User.find(2),
                   :comments => 'foo'
                 )
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous, comment.reload.author
               end
               def test_destroy_should_update_issues
                 issue = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'foo')
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous, issue.reload.author
               end
               def test_destroy_should_unassign_issues
                 issue = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'foo', :assigned_to_id => 2)
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_nil issue.reload.assigned_to
               end
               def test_destroy_should_update_journals
                 issue = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'foo')
                 issue.init_journal(User.find(2), "update")
                 issue.save!
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous, issue.journals.first.reload.user
               end
               def test_destroy_should_update_journal_details_old_value
                 issue = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'foo', :assigned_to_id => 2)
                 issue.init_journal(User.find(1), "update")
                 issue.assigned_to_id = nil
                 assert_difference 'JournalDetail.count' do
                   issue.save!
                 end
                 journal_detail = JournalDetail.first(:order => 'id DESC')
                 assert_equal '2', journal_detail.old_value
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous.id.to_s, journal_detail.reload.old_value
               end
               def test_destroy_should_update_journal_details_value
                 issue = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'foo')
                 issue.init_journal(User.find(1), "update")
                 issue.assigned_to_id = 2
                 assert_difference 'JournalDetail.count' do
                   issue.save!
                 end
                 journal_detail = JournalDetail.first(:order => 'id DESC')
                 assert_equal '2', journal_detail.value
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous.id.to_s, journal_detail.reload.value
               end
               def test_destroy_should_update_messages
                 board = Board.create!(:project_id => 1, :name => 'Board', :description => 'Board')
                 message = Message.create!(:board_id => board.id, :author_id => 2, :subject => 'foo', :content => 'foo')
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous, message.reload.author
               end
               def test_destroy_should_update_news
                 news = News.create!(:project_id => 1, :author_id => 2, :title => 'foo', :description => 'foo')
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous, news.reload.author
               end
               def test_destroy_should_delete_private_queries
                 query = Query.new(:name => 'foo', :is_public => false)
                 query.project_id = 1
                 query.user_id = 2
                 query.save!
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_nil Query.find_by_id(query.id)
               end
               def test_destroy_should_update_public_queries
                 query = Query.new(:name => 'foo', :is_public => true)
                 query.project_id = 1
                 query.user_id = 2
                 query.save!
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous, query.reload.user
               end
               def test_destroy_should_update_time_entries
                 entry = TimeEntry.new(:hours => '2', :spent_on => Date.today, :activity => TimeEntryActivity.create!(:name => 'foo'))
                 entry.project_id = 1
                 entry.user_id = 2
                 entry.save!
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous, entry.reload.user
               end
               def test_destroy_should_delete_tokens
                 token = Token.create!(:user_id => 2, :value => 'foo')
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_nil Token.find_by_id(token.id)
               end
               def test_destroy_should_delete_watchers
                 issue = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'foo')
                 watcher = Watcher.create!(:user_id => 2, :watchable => issue)
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_nil Watcher.find_by_id(watcher.id)
               end
               def test_destroy_should_update_wiki_contents
                 wiki_content = WikiContent.create!(
                   :text => 'foo',
                   :author_id => 2,
                   :page => WikiPage.create!(:title => 'Foo', :wiki => Wiki.create!(:project_id => 1, :start_page => 'Start'))
                 )
                 wiki_content.text = 'bar'
                 assert_difference 'WikiContent::Version.count' do
                   wiki_content.save!
                 end
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous, wiki_content.reload.author
                 wiki_content.versions.each do |version|
                   assert_equal User.anonymous, version.reload.author
                 end
               end
               def test_destroy_should_nullify_issue_categories
                 category = IssueCategory.create!(:project_id => 1, :assigned_to_id => 2, :name => 'foo')
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_nil category.reload.assigned_to_id
               end
               def test_destroy_should_nullify_changesets
                 changeset = Changeset.create!(
                   :repository => Repository::Subversion.create!(
                     :project_id => 1,
                     :url => 'file:///tmp',
                     :identifier => 'tmp'
                   ),
                   :revision => '12',
                   :committed_on => Time.now,
                   :committer => 'jsmith'
                   )
                 assert_equal 2, changeset.user_id
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_nil changeset.reload.user_id
               end
               def test_anonymous_user_should_not_be_destroyable
                 assert_no_difference 'User.count' do
                   assert_equal false, User.anonymous.destroy
                 end
               end
               def test_validate_login_presence
                 @admin.login = ""
                 assert !@admin.save
                 assert_equal 1, @admin.errors.count
               end
               def test_validate_mail_notification_inclusion
                 u = User.new
                 u.mail_notification = 'foo'
                 u.save
                 assert_not_nil u.errors[:mail_notification]
               end
-              context "User#try_to_login" do
+              test "User#try_to_login should fall-back to case-insensitive if user login is not found as-typed" do
-                should "fall-back to case-insensitive if user login is not found as-typed." do
+                user = User.try_to_login("AdMin", "admin")
-                  user = User.try_to_login("AdMin", "admin")
+                assert_kind_of User, user
-                  assert_kind_of User, user
+                assert_equal "admin", user.login
-                  assert_equal "admin", user.login
+              end
-                end
-                should "select the exact matching user first" do
-                  case_sensitive_user = User.generate! do |user|
-                    user.password = "admin123"
-                  end
-                  # bypass validations to make it appear like existing data
-                  case_sensitive_user.update_attribute(:login, 'ADMIN')
-                  user = User.try_to_login("ADMIN", "admin123")
-                  assert_kind_of User, user
-                  assert_equal "ADMIN", user.login
+              test "User#try_to_login should select the exact matching user first" do
+                case_sensitive_user = User.generate! do |user|
+                  user.password = "admin123"
                 end
+                # bypass validations to make it appear like existing data
+                case_sensitive_user.update_attribute(:login, 'ADMIN')
+                user = User.try_to_login("ADMIN", "admin123")
+                assert_kind_of User, user
+                assert_equal "ADMIN", user.login
               end
               def test_password
                 user = User.try_to_login("admin", "admin")
                 assert_kind_of User, user
                 assert_equal "admin", user.login
                 user.password = "hello123"
                 assert user.save
                 user = User.try_to_login("admin", "hello123")
                 assert_kind_of User, user
                 assert_equal "admin", user.login
               end
               def test_validate_password_length
                 with_settings :password_min_length => '100' do
                   user = User.new(:firstname => "new100", :lastname => "user100", :mail => "newuser100@somenet.foo")
                   user.login = "newuser100"
                   user.password, user.password_confirmation = "password100", "password100"
                   assert !user.save
                   assert_equal 1, user.errors.count
                 end
               end
               def test_name_format
                 assert_equal 'John S.', @jsmith.name(:firstname_lastinitial)
                 assert_equal 'Smith, John', @jsmith.name(:lastname_coma_firstname)
                 with_settings :user_format => :firstname_lastname do
                   assert_equal 'John Smith', @jsmith.reload.name
                 end
                 with_settings :user_format => :username do
                   assert_equal 'jsmith', @jsmith.reload.name
                 end
                 with_settings :user_format => :lastname do
                   assert_equal 'Smith', @jsmith.reload.name
                 end
               end
               def test_today_should_return_the_day_according_to_user_time_zone
                 preference = User.find(1).pref
                 date = Date.new(2012, 05, 15)
                 time = Time.gm(2012, 05, 15, 23, 30).utc # 2012-05-15 23:30 UTC
                 Date.stubs(:today).returns(date)
                 Time.stubs(:now).returns(time)
                 preference.update_attribute :time_zone, 'Baku' # UTC+4
                 assert_equal '2012-05-16', User.find(1).today.to_s
                 preference.update_attribute :time_zone, 'La Paz' # UTC-4
                 assert_equal '2012-05-15', User.find(1).today.to_s
                 preference.update_attribute :time_zone, ''
                 assert_equal '2012-05-15', User.find(1).today.to_s
               end
               def test_time_to_date_should_return_the_date_according_to_user_time_zone
                 preference = User.find(1).pref
                 time = Time.gm(2012, 05, 15, 23, 30).utc # 2012-05-15 23:30 UTC
                 preference.update_attribute :time_zone, 'Baku' # UTC+4
                 assert_equal '2012-05-16', User.find(1).time_to_date(time).to_s
                 preference.update_attribute :time_zone, 'La Paz' # UTC-4
                 assert_equal '2012-05-15', User.find(1).time_to_date(time).to_s
                 preference.update_attribute :time_zone, ''
                 assert_equal '2012-05-15', User.find(1).time_to_date(time).to_s
               end
               def test_fields_for_order_statement_should_return_fields_according_user_format_setting
                 with_settings :user_format => 'lastname_coma_firstname' do
                   assert_equal ['users.lastname', 'users.firstname', 'users.id'], User.fields_for_order_statement
                 end
               end
               def test_fields_for_order_statement_width_table_name_should_prepend_table_name
                 with_settings :user_format => 'lastname_firstname' do
                   assert_equal ['authors.lastname', 'authors.firstname', 'authors.id'], User.fields_for_order_statement('authors')
                 end
               end
               def test_fields_for_order_statement_with_blank_format_should_return_default
                 with_settings :user_format => '' do
                   assert_equal ['users.firstname', 'users.lastname', 'users.id'], User.fields_for_order_statement
                 end
               end
               def test_fields_for_order_statement_with_invalid_format_should_return_default
                 with_settings :user_format => 'foo' do
                   assert_equal ['users.firstname', 'users.lastname', 'users.id'], User.fields_for_order_statement
                 end
               end
               def test_lock
                 user = User.try_to_login("jsmith", "jsmith")
                 assert_equal @jsmith, user
                 @jsmith.status = User::STATUS_LOCKED
                 assert @jsmith.save
                 user = User.try_to_login("jsmith", "jsmith")
                 assert_equal nil, user
               end
-              context ".try_to_login" do
+              test ".try_to_login with good credentials should return the user" do
-                context "with good credentials" do
+                user = User.try_to_login("admin", "admin")
-                  should "return the user" do
+                assert_kind_of User, user
-                    user = User.try_to_login("admin", "admin")
+                assert_equal "admin", user.login
-                    assert_kind_of User, user
+              end
-                    assert_equal "admin", user.login
-                  end
-                end
-                context "with wrong credentials" do
+              test ".try_to_login with wrong credentials should return nil" do
-                  should "return nil" do
+                assert_nil User.try_to_login("admin", "foo")
-                    assert_nil User.try_to_login("admin", "foo")
-                  end
-                end
               end
               if ldap_configured?
                 context "#try_to_login using LDAP" do
                   context "with failed connection to the LDAP server" do
                     should "return nil" do
                       @auth_source = AuthSourceLdap.find(1)
                       AuthSource.any_instance.stubs(:initialize_ldap_con).raises(Net::LDAP::LdapError, 'Cannot connect')
                       assert_equal nil, User.try_to_login('edavis', 'wrong')
                     end
                   end
                   context "with an unsuccessful authentication" do
                     should "return nil" do
                       assert_equal nil, User.try_to_login('edavis', 'wrong')
                     end
                   end
                   context "binding with user's account" do
                     setup do
                       @auth_source = AuthSourceLdap.find(1)
                       @auth_source.account = "uid=$login,ou=Person,dc=redmine,dc=org"
                       @auth_source.account_password = ''
                       @auth_source.save!
                       @ldap_user = User.new(:mail => 'example1@redmine.org', :firstname => 'LDAP', :lastname => 'user', :auth_source_id => 1)
                       @ldap_user.login = 'example1'
                       @ldap_user.save!
                     end
                     context "with a successful authentication" do
                       should "return the user" do
                         assert_equal @ldap_user, User.try_to_login('example1', '123456')
                       end
                     end
                     context "with an unsuccessful authentication" do
                       should "return nil" do
                         assert_nil User.try_to_login('example1', '11111')
                       end
                     end
                   end
                   context "on the fly registration" do
                     setup do
                       @auth_source = AuthSourceLdap.find(1)
                       @auth_source.update_attribute :onthefly_register, true
                     end
                     context "with a successful authentication" do
                       should "create a new user account if it doesn't exist" do
                         assert_difference('User.count') do
                           user = User.try_to_login('edavis', '123456')
                           assert !user.admin?
                         end
                       end
                       should "retrieve existing user" do
                         user = User.try_to_login('edavis', '123456')
                         user.admin = true
                         user.save!
                         assert_no_difference('User.count') do
                           user = User.try_to_login('edavis', '123456')
                           assert user.admin?
                         end
                       end
                     end
                     context "binding with user's account" do
                       setup do
                         @auth_source = AuthSourceLdap.find(1)
                         @auth_source.account = "uid=$login,ou=Person,dc=redmine,dc=org"
                         @auth_source.account_password = ''
                         @auth_source.save!
                       end
                       context "with a successful authentication" do
                         should "create a new user account if it doesn't exist" do
                           assert_difference('User.count') do
                             user = User.try_to_login('example1', '123456')
                             assert_kind_of User, user
                           end
                         end
                       end
                       context "with an unsuccessful authentication" do
                         should "return nil" do
                           assert_nil User.try_to_login('example1', '11111')
                         end
                       end
                     end
                   end
                 end
               else
                 puts "Skipping LDAP tests."
               end
               def test_create_anonymous
                 AnonymousUser.delete_all
                 anon = User.anonymous
                 assert !anon.new_record?
                 assert_kind_of AnonymousUser, anon
               end
               def test_ensure_single_anonymous_user
                 AnonymousUser.delete_all
                 anon1 = User.anonymous
                 assert !anon1.new_record?
                 assert_kind_of AnonymousUser, anon1
                 anon2 = AnonymousUser.create(
                             :lastname => 'Anonymous', :firstname => '',
                             :mail => '', :login => '', :status => 0)
                 assert_equal 1, anon2.errors.count
               end
               def test_rss_key
                 assert_nil @jsmith.rss_token
                 key = @jsmith.rss_key
                 assert_equal 40, key.length
                 @jsmith.reload
                 assert_equal key, @jsmith.rss_key
               end
               def test_rss_key_should_not_be_generated_twice
                 assert_difference 'Token.count', 1 do
                   key1 = @jsmith.rss_key
                   key2 = @jsmith.rss_key
                   assert_equal key1, key2
                 end
               end
               def test_api_key_should_not_be_generated_twice
                 assert_difference 'Token.count', 1 do
                   key1 = @jsmith.api_key
                   key2 = @jsmith.api_key
                   assert_equal key1, key2
                 end
               end
-              context "User#api_key" do
+              test "#api_key should generate a new one if the user doesn't have one" do
-                should "generate a new one if the user doesn't have one" do
+                user = User.generate!(:api_token => nil)
-                  user = User.generate!(:api_token => nil)
+                assert_nil user.api_token
-                  assert_nil user.api_token
-                  key = user.api_key
+                key = user.api_key
-                  assert_equal 40, key.length
+                assert_equal 40, key.length
-                  user.reload
+                user.reload
-                  assert_equal key, user.api_key
+                assert_equal key, user.api_key
-                end
+              end
-                should "return the existing api token value" do
+              test "#api_key should return the existing api token value" do
-                  user = User.generate!
+                user = User.generate!
-                  token = Token.create!(:action => 'api')
+                token = Token.create!(:action => 'api')
-                  user.api_token = token
+                user.api_token = token
-                  assert user.save
+                assert user.save
-                  assert_equal token.value, user.api_key
+                assert_equal token.value, user.api_key
-                end
               end
-              context "User#find_by_api_key" do
+              test "#find_by_api_key should return nil if no matching key is found" do
-                should "return nil if no matching key is found" do
+                assert_nil User.find_by_api_key('zzzzzzzzz')
-                  assert_nil User.find_by_api_key('zzzzzzzzz')
+              end
-                end
-                should "return nil if the key is found for an inactive user" do
+              test "#find_by_api_key should return nil if the key is found for an inactive user" do
-                  user = User.generate!
+                user = User.generate!
-                  user.status = User::STATUS_LOCKED
+                user.status = User::STATUS_LOCKED
-                  token = Token.create!(:action => 'api')
+                token = Token.create!(:action => 'api')
-                  user.api_token = token
+                user.api_token = token
-                  user.save
+                user.save
-                  assert_nil User.find_by_api_key(token.value)
+                assert_nil User.find_by_api_key(token.value)
-                end
+              end
-                should "return the user if the key is found for an active user" do
+              test "#find_by_api_key should return the user if the key is found for an active user" do
-                  user = User.generate!
+                user = User.generate!
-                  token = Token.create!(:action => 'api')
+                token = Token.create!(:action => 'api')
-                  user.api_token = token
+                user.api_token = token
-                  user.save
+                user.save
-                  assert_equal user, User.find_by_api_key(token.value)
+                assert_equal user, User.find_by_api_key(token.value)
-                end
               end
               def test_default_admin_account_changed_should_return_false_if_account_was_not_changed
                 user = User.find_by_login("admin")
                 user.password = "admin"
                 assert user.save(:validate => false)
                 assert_equal false, User.default_admin_account_changed?
               end
               def test_default_admin_account_changed_should_return_true_if_password_was_changed
                 user = User.find_by_login("admin")
                 user.password = "newpassword"
                 user.save!
                 assert_equal true, User.default_admin_account_changed?
               end
               def test_default_admin_account_changed_should_return_true_if_account_is_disabled
                 user = User.find_by_login("admin")
                 user.password = "admin"
                 user.status = User::STATUS_LOCKED
                 assert user.save(:validate => false)
                 assert_equal true, User.default_admin_account_changed?
               end
               def test_default_admin_account_changed_should_return_true_if_account_does_not_exist
                 user = User.find_by_login("admin")
                 user.destroy
                 assert_equal true, User.default_admin_account_changed?
               end
               def test_membership_with_project_should_return_membership
                 project = Project.find(1)
                 membership = @jsmith.membership(project)
                 assert_kind_of Member, membership
                 assert_equal @jsmith, membership.user
                 assert_equal project, membership.project
               end
               def test_membership_with_project_id_should_return_membership
                 project = Project.find(1)
                 membership = @jsmith.membership(1)
                 assert_kind_of Member, membership
                 assert_equal @jsmith, membership.user
                 assert_equal project, membership.project
               end
               def test_membership_for_non_member_should_return_nil
                 project = Project.find(1)
                 user = User.generate!
                 membership = user.membership(1)
                 assert_nil membership
               end
               def test_roles_for_project
                 # user with a role
                 roles = @jsmith.roles_for_project(Project.find(1))
                 assert_kind_of Role, roles.first
                 assert_equal "Manager", roles.first.name
                 # user with no role
                 assert_nil @dlopper.roles_for_project(Project.find(2)).detect {|role| role.member?}
               end
               def test_projects_by_role_for_user_with_role
                 user = User.find(2)
                 assert_kind_of Hash, user.projects_by_role
                 assert_equal 2, user.projects_by_role.size
                 assert_equal [1,5], user.projects_by_role[Role.find(1)].collect(&:id).sort
                 assert_equal [2], user.projects_by_role[Role.find(2)].collect(&:id).sort
               end
               def test_accessing_projects_by_role_with_no_projects_should_return_an_empty_array
                 user = User.find(2)
                 assert_equal [], user.projects_by_role[Role.find(3)]
                 # should not update the hash
                 assert_nil user.projects_by_role.values.detect(&:blank?)
               end
               def test_projects_by_role_for_user_with_no_role
                 user = User.generate!
                 assert_equal({}, user.projects_by_role)
               end
               def test_projects_by_role_for_anonymous
                 assert_equal({}, User.anonymous.projects_by_role)
               end
               def test_valid_notification_options
                 # without memberships
                 assert_equal 5, User.find(7).valid_notification_options.size
                 # with memberships
                 assert_equal 6, User.find(2).valid_notification_options.size
               end
               def test_valid_notification_options_class_method
                 assert_equal 5, User.valid_notification_options.size
                 assert_equal 5, User.valid_notification_options(User.find(7)).size
                 assert_equal 6, User.valid_notification_options(User.find(2)).size
               end
               def test_mail_notification_all
                 @jsmith.mail_notification = 'all'
                 @jsmith.notified_project_ids = []
                 @jsmith.save
                 @jsmith.reload
                 assert @jsmith.projects.first.recipients.include?(@jsmith.mail)
               end
               def test_mail_notification_selected
                 @jsmith.mail_notification = 'selected'
                 @jsmith.notified_project_ids = [1]
                 @jsmith.save
                 @jsmith.reload
                 assert Project.find(1).recipients.include?(@jsmith.mail)
               end
               def test_mail_notification_only_my_events
                 @jsmith.mail_notification = 'only_my_events'
                 @jsmith.notified_project_ids = []
                 @jsmith.save
                 @jsmith.reload
                 assert !@jsmith.projects.first.recipients.include?(@jsmith.mail)
               end
               def test_comments_sorting_preference
                 assert !@jsmith.wants_comments_in_reverse_order?
                 @jsmith.pref.comments_sorting = 'asc'
                 assert !@jsmith.wants_comments_in_reverse_order?
                 @jsmith.pref.comments_sorting = 'desc'
                 assert @jsmith.wants_comments_in_reverse_order?
               end
               def test_find_by_mail_should_be_case_insensitive
                 u = User.find_by_mail('JSmith@somenet.foo')
                 assert_not_nil u
                 assert_equal 'jsmith@somenet.foo', u.mail
               end
               def test_random_password
                 u = User.new
                 u.random_password
                 assert !u.password.blank?
                 assert !u.password_confirmation.blank?
               end
-              context "#change_password_allowed?" do
+              test "#change_password_allowed? should be allowed if no auth source is set" do
-                should "be allowed if no auth source is set" do
+                user = User.generate!
-                  user = User.generate!
+                assert user.change_password_allowed?
-                  assert user.change_password_allowed?
+              end
-                end
-                should "delegate to the auth source" do
+              test "#change_password_allowed? should delegate to the auth source" do
-                  user = User.generate!
+                user = User.generate!
-                  allowed_auth_source = AuthSource.generate!
+                allowed_auth_source = AuthSource.generate!
-                  def allowed_auth_source.allow_password_changes?; true; end
+                def allowed_auth_source.allow_password_changes?; true; end
-                  denied_auth_source = AuthSource.generate!
+                denied_auth_source = AuthSource.generate!
-                  def denied_auth_source.allow_password_changes?; false; end
+                def denied_auth_source.allow_password_changes?; false; end
-                  assert user.change_password_allowed?
+                assert user.change_password_allowed?
-                  user.auth_source = allowed_auth_source
+                user.auth_source = allowed_auth_source
-                  assert user.change_password_allowed?, "User not allowed to change password, though auth source does"
+                assert user.change_password_allowed?, "User not allowed to change password, though auth source does"
-                  user.auth_source = denied_auth_source
+                user.auth_source = denied_auth_source
-                  assert !user.change_password_allowed?, "User allowed to change password, though auth source does not"
+                assert !user.change_password_allowed?, "User allowed to change password, though auth source does not"
-                end
               end
               def test_own_account_deletable_should_be_true_with_unsubscrive_enabled
                 with_settings :unsubscribe => '1' do
                   assert_equal true, User.find(2).own_account_deletable?
                 end
               end
               def test_own_account_deletable_should_be_false_with_unsubscrive_disabled
                 with_settings :unsubscribe => '0' do
                   assert_equal false, User.find(2).own_account_deletable?
                 end
               end
               def test_own_account_deletable_should_be_false_for_a_single_admin
                 User.delete_all(["admin = ? AND id <> ?", true, 1])
                 with_settings :unsubscribe => '1' do
                   assert_equal false, User.find(1).own_account_deletable?
                 end
               end
               def test_own_account_deletable_should_be_true_for_an_admin_if_other_admin_exists
                 User.generate! do |user|
                   user.admin = true
                 end
                 with_settings :unsubscribe => '1' do
                   assert_equal true, User.find(1).own_account_deletable?
                 end
               end
               context "#allowed_to?" do
                 context "with a unique project" do
                   should "return false if project is archived" do
                     project = Project.find(1)
                     Project.any_instance.stubs(:status).returns(Project::STATUS_ARCHIVED)
                     assert_equal false, @admin.allowed_to?(:view_issues, Project.find(1))
                   end
                   should "return false for write action if project is closed" do
                     project = Project.find(1)
                     Project.any_instance.stubs(:status).returns(Project::STATUS_CLOSED)
                     assert_equal false, @admin.allowed_to?(:edit_project, Project.find(1))
                   end
                   should "return true for read action if project is closed" do
                     project = Project.find(1)
                     Project.any_instance.stubs(:status).returns(Project::STATUS_CLOSED)
                     assert_equal true, @admin.allowed_to?(:view_project, Project.find(1))
                   end
                   should "return false if related module is disabled" do
                     project = Project.find(1)
                     project.enabled_module_names = ["issue_tracking"]
                     assert_equal true, @admin.allowed_to?(:add_issues, project)
                     assert_equal false, @admin.allowed_to?(:view_wiki_pages, project)
                   end
                   should "authorize nearly everything for admin users" do
                     project = Project.find(1)
                     assert ! @admin.member_of?(project)
                     %w(edit_issues delete_issues manage_news add_documents manage_wiki).each do |p|
                       assert_equal true, @admin.allowed_to?(p.to_sym, project)
                     end
                   end
                   should "authorize normal users depending on their roles" do
                     project = Project.find(1)
                     assert_equal true, @jsmith.allowed_to?(:delete_messages, project)    #Manager
                     assert_equal false, @dlopper.allowed_to?(:delete_messages, project) #Developper
                   end
                 end
                 context "with multiple projects" do
                   should "return false if array is empty" do
                     assert_equal false, @admin.allowed_to?(:view_project, [])
                   end
                   should "return true only if user has permission on all these projects" do
                     assert_equal true, @admin.allowed_to?(:view_project, Project.all)
                     assert_equal false, @dlopper.allowed_to?(:view_project, Project.all) #cannot see Project(2)
                     assert_equal true, @jsmith.allowed_to?(:edit_issues, @jsmith.projects) #Manager or Developer everywhere
                     assert_equal false, @jsmith.allowed_to?(:delete_issue_watchers, @jsmith.projects) #Dev cannot delete_issue_watchers
                   end
                   should "behave correctly with arrays of 1 project" do
                     assert_equal false, User.anonymous.allowed_to?(:delete_issues, [Project.first])
                   end
                 end
                 context "with options[:global]" do
                   should "authorize if user has at least one role that has this permission" do
                     @dlopper2 = User.find(5) #only Developper on a project, not Manager anywhere
                     @anonymous = User.find(6)
                     assert_equal true, @jsmith.allowed_to?(:delete_issue_watchers, nil, :global => true)
                     assert_equal false, @dlopper2.allowed_to?(:delete_issue_watchers, nil, :global => true)
                     assert_equal true, @dlopper2.allowed_to?(:add_issues, nil, :global => true)
                     assert_equal false, @anonymous.allowed_to?(:add_issues, nil, :global => true)
                     assert_equal true, @anonymous.allowed_to?(:view_issues, nil, :global => true)
                   end
                 end
               end
               context "User#notify_about?" do
                 context "Issues" do
                   setup do
                     @project = Project.find(1)
                     @author = User.generate!
                     @assignee = User.generate!
                     @issue = Issue.generate!(:project => @project, :assigned_to => @assignee, :author => @author)
                   end
                   should "be true for a user with :all" do
                     @author.update_attribute(:mail_notification, 'all')
                     assert @author.notify_about?(@issue)
                   end
                   should "be false for a user with :none" do
                     @author.update_attribute(:mail_notification, 'none')
                     assert ! @author.notify_about?(@issue)
                   end
                   should "be false for a user with :only_my_events and isn't an author, creator, or assignee" do
                     @user = User.generate!(:mail_notification => 'only_my_events')
                     Member.create!(:user => @user, :project => @project, :role_ids => [1])
                     assert ! @user.notify_about?(@issue)
                   end
                   should "be true for a user with :only_my_events and is the author" do
                     @author.update_attribute(:mail_notification, 'only_my_events')
                     assert @author.notify_about?(@issue)
                   end
                   should "be true for a user with :only_my_events and is the assignee" do
                     @assignee.update_attribute(:mail_notification, 'only_my_events')
                     assert @assignee.notify_about?(@issue)
                   end
                   should "be true for a user with :only_assigned and is the assignee" do
                     @assignee.update_attribute(:mail_notification, 'only_assigned')
                     assert @assignee.notify_about?(@issue)
                   end
                   should "be false for a user with :only_assigned and is not the assignee" do
                     @author.update_attribute(:mail_notification, 'only_assigned')
                     assert ! @author.notify_about?(@issue)
                   end
                   should "be true for a user with :only_owner and is the author" do
                     @author.update_attribute(:mail_notification, 'only_owner')
                     assert @author.notify_about?(@issue)
                   end
                   should "be false for a user with :only_owner and is not the author" do
                     @assignee.update_attribute(:mail_notification, 'only_owner')
                     assert ! @assignee.notify_about?(@issue)
                   end
                   should "be true for a user with :selected and is the author" do
                     @author.update_attribute(:mail_notification, 'selected')
                     assert @author.notify_about?(@issue)
                   end
                   should "be true for a user with :selected and is the assignee" do
                     @assignee.update_attribute(:mail_notification, 'selected')
                     assert @assignee.notify_about?(@issue)
                   end
                   should "be false for a user with :selected and is not the author or assignee" do
                     @user = User.generate!(:mail_notification => 'selected')
                     Member.create!(:user => @user, :project => @project, :role_ids => [1])
                     assert ! @user.notify_about?(@issue)
                   end
                 end
               end
               def test_notify_about_news
                 user = User.generate!
                 news = News.new
                 User::MAIL_NOTIFICATION_OPTIONS.map(&:first).each do |option|
                   user.mail_notification = option
                   assert_equal (option != 'none'), user.notify_about?(news)
                 end
               end
               def test_salt_unsalted_passwords
                 # Restore a user with an unsalted password
                 user = User.find(1)
                 user.salt = nil
                 user.hashed_password = User.hash_password("unsalted")
                 user.save!
                 User.salt_unsalted_passwords!
                 user.reload
                 # Salt added
                 assert !user.salt.blank?
                 # Password still valid
                 assert user.check_password?("unsalted")
                 assert_equal user, User.try_to_login(user.login, "unsalted")
               end
               if Object.const_defined?(:OpenID)
               def test_setting_identity_url
                 normalized_open_id_url = 'http://example.com/'
                 u = User.new( :identity_url => 'http://example.com/' )
                 assert_equal normalized_open_id_url, u.identity_url
               end
               def test_setting_identity_url_without_trailing_slash
                 normalized_open_id_url = 'http://example.com/'
                 u = User.new( :identity_url => 'http://example.com' )
                 assert_equal normalized_open_id_url, u.identity_url
               end
               def test_setting_identity_url_without_protocol
                 normalized_open_id_url = 'http://example.com/'
                 u = User.new( :identity_url => 'example.com' )
                 assert_equal normalized_open_id_url, u.identity_url
               end
               def test_setting_blank_identity_url
                 u = User.new( :identity_url => 'example.com' )
                 u.identity_url = ''
                 assert u.identity_url.blank?
               end
               def test_setting_invalid_identity_url
                 u = User.new( :identity_url => 'this is not an openid url' )
                 assert u.identity_url.blank?
               end
               else
                 puts "Skipping openid tests."
               end
             end

test/unit/version_test.rb +58 -69

             # Redmine - project management software
             # Copyright (C) 2006-2013  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class VersionTest < ActiveSupport::TestCase
               fixtures :projects, :users, :issues, :issue_statuses, :trackers, :enumerations, :versions, :projects_trackers
               def setup
               end
               def test_create
                 v = Version.new(:project => Project.find(1), :name => '1.1', :effective_date => '2011-03-25')
                 assert v.save
                 assert_equal 'open', v.status
                 assert_equal 'none', v.sharing
               end
               def test_invalid_effective_date_validation
                 v = Version.new(:project => Project.find(1), :name => '1.1', :effective_date => '99999-01-01')
                 assert !v.valid?
                 v.effective_date = '2012-11-33'
                 assert !v.valid?
                 v.effective_date = '2012-31-11'
                 assert !v.valid?
                 v.effective_date = '-2012-31-11'
                 assert !v.valid?
                 v.effective_date = 'ABC'
                 assert !v.valid?
                 assert_include I18n.translate('activerecord.errors.messages.not_a_date'),
                                v.errors[:effective_date]
               end
               def test_progress_should_be_0_with_no_assigned_issues
                 project = Project.find(1)
                 v = Version.create!(:project => project, :name => 'Progress')
                 assert_equal 0, v.completed_percent
                 assert_equal 0, v.closed_percent
               end
               def test_progress_should_be_0_with_unbegun_assigned_issues
                 project = Project.find(1)
                 v = Version.create!(:project => project, :name => 'Progress')
                 add_issue(v)
                 add_issue(v, :done_ratio => 0)
                 assert_progress_equal 0, v.completed_percent
                 assert_progress_equal 0, v.closed_percent
               end
               def test_progress_should_be_100_with_closed_assigned_issues
                 project = Project.find(1)
                 status = IssueStatus.where(:is_closed => true).first
                 v = Version.create!(:project => project, :name => 'Progress')
                 add_issue(v, :status => status)
                 add_issue(v, :status => status, :done_ratio => 20)
                 add_issue(v, :status => status, :done_ratio => 70, :estimated_hours => 25)
                 add_issue(v, :status => status, :estimated_hours => 15)
                 assert_progress_equal 100.0, v.completed_percent
                 assert_progress_equal 100.0, v.closed_percent
               end
               def test_progress_should_consider_done_ratio_of_open_assigned_issues
                 project = Project.find(1)
                 v = Version.create!(:project => project, :name => 'Progress')
                 add_issue(v)
                 add_issue(v, :done_ratio => 20)
                 add_issue(v, :done_ratio => 70)
                 assert_progress_equal (0.0 + 20.0 + 70.0)/3, v.completed_percent
                 assert_progress_equal 0, v.closed_percent
               end
               def test_progress_should_consider_closed_issues_as_completed
                 project = Project.find(1)
                 v = Version.create!(:project => project, :name => 'Progress')
                 add_issue(v)
                 add_issue(v, :done_ratio => 20)
                 add_issue(v, :status => IssueStatus.where(:is_closed => true).first)
                 assert_progress_equal (0.0 + 20.0 + 100.0)/3, v.completed_percent
                 assert_progress_equal (100.0)/3, v.closed_percent
               end
               def test_progress_should_consider_estimated_hours_to_weigth_issues
                 project = Project.find(1)
                 v = Version.create!(:project => project, :name => 'Progress')
                 add_issue(v, :estimated_hours => 10)
                 add_issue(v, :estimated_hours => 20, :done_ratio => 30)
                 add_issue(v, :estimated_hours => 40, :done_ratio => 10)
                 add_issue(v, :estimated_hours => 25, :status => IssueStatus.where(:is_closed => true).first)
                 assert_progress_equal (10.0*0 + 20.0*0.3 + 40*0.1 + 25.0*1)/95.0*100, v.completed_percent
                 assert_progress_equal 25.0/95.0*100, v.closed_percent
               end
               def test_progress_should_consider_average_estimated_hours_to_weigth_unestimated_issues
                 project = Project.find(1)
                 v = Version.create!(:project => project, :name => 'Progress')
                 add_issue(v, :done_ratio => 20)
                 add_issue(v, :status => IssueStatus.where(:is_closed => true).first)
                 add_issue(v, :estimated_hours => 10, :done_ratio => 30)
                 add_issue(v, :estimated_hours => 40, :done_ratio => 10)
                 assert_progress_equal (25.0*0.2 + 25.0*1 + 10.0*0.3 + 40.0*0.1)/100.0*100, v.completed_percent
                 assert_progress_equal 25.0/100.0*100, v.closed_percent
               end
               def test_should_sort_scheduled_then_unscheduled_versions
                 Version.delete_all
                 v4 = Version.create!(:project_id => 1, :name => 'v4')
                 v3 = Version.create!(:project_id => 1, :name => 'v2', :effective_date => '2012-07-14')
                 v2 = Version.create!(:project_id => 1, :name => 'v1')
                 v1 = Version.create!(:project_id => 1, :name => 'v3', :effective_date => '2012-08-02')
                 v5 = Version.create!(:project_id => 1, :name => 'v5', :effective_date => '2012-07-02')
                 assert_equal [v5, v3, v1, v2, v4], [v1, v2, v3, v4, v5].sort
                 assert_equal [v5, v3, v1, v2, v4], Version.sorted.all
               end
               def test_completed_should_be_false_when_due_today
                 version = Version.create!(:project_id => 1, :effective_date => Date.today, :name => 'Due today')
                 assert_equal false, version.completed?
               end
-              context "#behind_schedule?" do
+              test "#behind_schedule? should be false if there are no issues assigned" do
-                setup do
+                version = Version.generate!(:effective_date => Date.yesterday)
-                  ProjectCustomField.destroy_all # Custom values are a mess to isolate in tests
+                assert_equal false, version.behind_schedule?
-                  @project = Project.create!(:name => 'test0', :identifier => 'test0')
+              end
-                  @project.trackers << Tracker.create!(:name => 'track')
+              test "#behind_schedule? should be false if there is no effective_date" do
-                  @version = Version.create!(:project => @project, :effective_date => nil, :name => 'version')
+                version = Version.generate!(:effective_date => nil)
-                end
+                assert_equal false, version.behind_schedule?
+              end
-                should "be false if there are no issues assigned" do
-                  @version.update_attribute(:effective_date, Date.yesterday)
+              test "#behind_schedule? should be false if all of the issues are ahead of schedule" do
-                  assert_equal false, @version.behind_schedule?
+                version = Version.generate!(:effective_date => 7.days.from_now.to_date)
-                end
+                add_issue(version, :start_date => 7.days.ago, :done_ratio => 60) # 14 day span, 60% done, 50% time left
+                add_issue(version, :start_date => 7.days.ago, :done_ratio => 60) # 14 day span, 60% done, 50% time left
-                should "be false if there is no effective_date" do
+                assert_equal 60, version.completed_percent
-                  assert_equal false, @version.behind_schedule?
+                assert_equal false, version.behind_schedule?
-                end
+              end
-                should "be false if all of the issues are ahead of schedule" do
+              test "#behind_schedule? should be true if any of the issues are behind schedule" do
-                  @version.update_attribute(:effective_date, 7.days.from_now.to_date)
+                version = Version.generate!(:effective_date => 7.days.from_now.to_date)
-                  add_issue(@version, :start_date => 7.days.ago, :done_ratio => 60) # 14 day span, 60% done, 50% time left
+                add_issue(version, :start_date => 7.days.ago, :done_ratio => 60) # 14 day span, 60% done, 50% time left
-                  add_issue(@version, :start_date => 7.days.ago, :done_ratio => 60) # 14 day span, 60% done, 50% time left
+                add_issue(version, :start_date => 7.days.ago, :done_ratio => 20) # 14 day span, 20% done, 50% time left
-                  assert_equal 60, @version.completed_percent
+                assert_equal 40, version.completed_percent
-                  assert_equal false, @version.behind_schedule?
+                assert_equal true, version.behind_schedule?
-                end
+              end
-                should "be true if any of the issues are behind schedule" do
+              test "#behind_schedule? should be false if all of the issues are complete" do
-                  @version.update_attribute(:effective_date, 7.days.from_now.to_date)
+                version = Version.generate!(:effective_date => 7.days.from_now.to_date)
-                  add_issue(@version, :start_date => 7.days.ago, :done_ratio => 60) # 14 day span, 60% done, 50% time left
+                add_issue(version, :start_date => 14.days.ago, :done_ratio => 100, :status => IssueStatus.find(5)) # 7 day span
-                  add_issue(@version, :start_date => 7.days.ago, :done_ratio => 20) # 14 day span, 20% done, 50% time left
+                add_issue(version, :start_date => 14.days.ago, :done_ratio => 100, :status => IssueStatus.find(5)) # 7 day span
-                  assert_equal 40, @version.completed_percent
+                assert_equal 100, version.completed_percent
-                  assert_equal true, @version.behind_schedule?
+                assert_equal false, version.behind_schedule?
-                end
+              end
-                should "be false if all of the issues are complete" do
+              test "#estimated_hours should return 0 with no assigned issues" do
-                  @version.update_attribute(:effective_date, 7.days.from_now.to_date)
+                version = Version.generate!
-                  add_issue(@version, :start_date => 14.days.ago, :done_ratio => 100, :status => IssueStatus.find(5)) # 7 day span
+                assert_equal 0, version.estimated_hours
-                  add_issue(@version, :start_date => 14.days.ago, :done_ratio => 100, :status => IssueStatus.find(5)) # 7 day span
+              end
-                  assert_equal 100, @version.completed_percent
-                  assert_equal false, @version.behind_schedule?
+              test "#estimated_hours should return 0 with no estimated hours" do
-                end
+                version = Version.generate!
-              end
+                add_issue(version)
+                assert_equal 0, version.estimated_hours
-              context "#estimated_hours" do
+              end
-                setup do
-                  @version = Version.create!(:project_id => 1, :name => '#estimated_hours')
+              test "#estimated_hours should return return the sum of estimated hours" do
-                end
+                version = Version.generate!
+                add_issue(version, :estimated_hours => 2.5)
-                should "return 0 with no assigned issues" do
+                add_issue(version, :estimated_hours => 5)
-                  assert_equal 0, @version.estimated_hours
+                assert_equal 7.5, version.estimated_hours
-                end
+              end
-                should "return 0 with no estimated hours" do
+              test "#estimated_hours should return the sum of leaves estimated hours" do
-                  add_issue(@version)
+                version = Version.generate!
-                  assert_equal 0, @version.estimated_hours
+                parent = add_issue(version)
-                end
+                add_issue(version, :estimated_hours => 2.5, :parent_issue_id => parent.id)
+                add_issue(version, :estimated_hours => 5, :parent_issue_id => parent.id)
-                should "return the sum of estimated hours" do
+                assert_equal 7.5, version.estimated_hours
-                  add_issue(@version, :estimated_hours => 2.5)
-                  add_issue(@version, :estimated_hours => 5)
-                  assert_equal 7.5, @version.estimated_hours
-                end
-                should "return the sum of leaves estimated hours" do
-                  parent = add_issue(@version)
-                  add_issue(@version, :estimated_hours => 2.5, :parent_issue_id => parent.id)
-                  add_issue(@version, :estimated_hours => 5, :parent_issue_id => parent.id)
-                  assert_equal 7.5, @version.estimated_hours
-                end
               end
               test "should update all issue's fixed_version associations in case the hierarchy changed XXX" do
                 User.current = User.find(1) # Need the admin's permissions
                 @version = Version.find(7)
                 # Separate hierarchy
                 project_1_issue = Issue.find(1)
                 project_1_issue.fixed_version = @version
                 assert project_1_issue.save, project_1_issue.errors.full_messages.to_s
                 project_5_issue = Issue.find(6)
                 project_5_issue.fixed_version = @version
                 assert project_5_issue.save
                 # Project
                 project_2_issue = Issue.find(4)
                 project_2_issue.fixed_version = @version
                 assert project_2_issue.save
                 # Update the sharing
                 @version.sharing = 'none'
                 assert @version.save
                 # Project 1 now out of the shared scope
                 project_1_issue.reload
                 assert_equal nil, project_1_issue.fixed_version, "Fixed version is still set after changing the Version's sharing"
                 # Project 5 now out of the shared scope
                 project_5_issue.reload
                 assert_equal nil, project_5_issue.fixed_version, "Fixed version is still set after changing the Version's sharing"
                 # Project 2 issue remains
                 project_2_issue.reload
                 assert_equal @version, project_2_issue.fixed_version
               end
               private
               def add_issue(version, attributes={})
                 Issue.create!({:project => version.project,
                                :fixed_version => version,
                                :subject => 'Test',
                                :author => User.first,
                                :tracker => version.project.trackers.first}.merge(attributes))
               end
               def assert_progress_equal(expected_float, actual_float, message="")
                 assert_in_delta(expected_float, actual_float, 0.000001, message="")
               end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages