##// END OF EJS Templates
jro_apps » redmine
RSS
code layout clean up of test_create_minimal at test/unit/issue_test.rb...
Toshi MARUYAMA -
r7355:615540a12cc4
parent child
Show More
Side by Side Unified
Context file:
r7355:615540a12cc4 Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,1088 +1,1090
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssueTest < ActiveSupport::TestCase
21 21 fixtures :projects, :users, :members, :member_roles, :roles,
22 22 :trackers, :projects_trackers,
23 23 :enabled_modules,
24 24 :versions,
25 25 :issue_statuses, :issue_categories, :issue_relations, :workflows,
26 26 :enumerations,
27 27 :issues,
28 28 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
29 29 :time_entries
30 30
31 31 def test_create
32 32 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create', :description => 'IssueTest#test_create', :estimated_hours => '1:30')
33 33 assert issue.save
34 34 issue.reload
35 35 assert_equal 1.5, issue.estimated_hours
36 36 end
37 37
38 38 def test_create_minimal
39 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create')
39 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
40 :status_id => 1, :priority => IssuePriority.all.first,
41 :subject => 'test_create')
40 42 assert issue.save
41 43 assert issue.description.nil?
42 44 end
43 45
44 46 def test_create_with_required_custom_field
45 47 field = IssueCustomField.find_by_name('Database')
46 48 field.update_attribute(:is_required, true)
47 49
48 50 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
49 51 :status_id => 1, :subject => 'test_create',
50 52 :description => 'IssueTest#test_create_with_required_custom_field')
51 53 assert issue.available_custom_fields.include?(field)
52 54 # No value for the custom field
53 55 assert !issue.save
54 56 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
55 57 # Blank value
56 58 issue.custom_field_values = { field.id => '' }
57 59 assert !issue.save
58 60 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
59 61 # Invalid value
60 62 issue.custom_field_values = { field.id => 'SQLServer' }
61 63 assert !issue.save
62 64 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
63 65 # Valid value
64 66 issue.custom_field_values = { field.id => 'PostgreSQL' }
65 67 assert issue.save
66 68 issue.reload
67 69 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
68 70 end
69 71
70 72 def test_create_with_group_assignment
71 73 with_settings :issue_group_assignment => '1' do
72 74 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1, :subject => 'Group assignment', :assigned_to_id => 11).save
73 75 issue = Issue.first(:order => 'id DESC')
74 76 assert_kind_of Group, issue.assigned_to
75 77 assert_equal Group.find(11), issue.assigned_to
76 78 end
77 79 end
78 80
79 81 def assert_visibility_match(user, issues)
80 82 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
81 83 end
82 84
83 85 def test_visible_scope_for_anonymous
84 86 # Anonymous user should see issues of public projects only
85 87 issues = Issue.visible(User.anonymous).all
86 88 assert issues.any?
87 89 assert_nil issues.detect {|issue| !issue.project.is_public?}
88 90 assert_nil issues.detect {|issue| issue.is_private?}
89 91 assert_visibility_match User.anonymous, issues
90 92 end
91 93
92 94 def test_visible_scope_for_anonymous_with_own_issues_visibility
93 95 Role.anonymous.update_attribute :issues_visibility, 'own'
94 96 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => User.anonymous.id, :subject => 'Issue by anonymous')
95 97
96 98 issues = Issue.visible(User.anonymous).all
97 99 assert issues.any?
98 100 assert_nil issues.detect {|issue| issue.author != User.anonymous}
99 101 assert_visibility_match User.anonymous, issues
100 102 end
101 103
102 104 def test_visible_scope_for_anonymous_without_view_issues_permissions
103 105 # Anonymous user should not see issues without permission
104 106 Role.anonymous.remove_permission!(:view_issues)
105 107 issues = Issue.visible(User.anonymous).all
106 108 assert issues.empty?
107 109 assert_visibility_match User.anonymous, issues
108 110 end
109 111
110 112 def test_visible_scope_for_non_member
111 113 user = User.find(9)
112 114 assert user.projects.empty?
113 115 # Non member user should see issues of public projects only
114 116 issues = Issue.visible(user).all
115 117 assert issues.any?
116 118 assert_nil issues.detect {|issue| !issue.project.is_public?}
117 119 assert_nil issues.detect {|issue| issue.is_private?}
118 120 assert_visibility_match user, issues
119 121 end
120 122
121 123 def test_visible_scope_for_non_member_with_own_issues_visibility
122 124 Role.non_member.update_attribute :issues_visibility, 'own'
123 125 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
124 126 user = User.find(9)
125 127
126 128 issues = Issue.visible(user).all
127 129 assert issues.any?
128 130 assert_nil issues.detect {|issue| issue.author != user}
129 131 assert_visibility_match user, issues
130 132 end
131 133
132 134 def test_visible_scope_for_non_member_without_view_issues_permissions
133 135 # Non member user should not see issues without permission
134 136 Role.non_member.remove_permission!(:view_issues)
135 137 user = User.find(9)
136 138 assert user.projects.empty?
137 139 issues = Issue.visible(user).all
138 140 assert issues.empty?
139 141 assert_visibility_match user, issues
140 142 end
141 143
142 144 def test_visible_scope_for_member
143 145 user = User.find(9)
144 146 # User should see issues of projects for which he has view_issues permissions only
145 147 Role.non_member.remove_permission!(:view_issues)
146 148 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
147 149 issues = Issue.visible(user).all
148 150 assert issues.any?
149 151 assert_nil issues.detect {|issue| issue.project_id != 3}
150 152 assert_nil issues.detect {|issue| issue.is_private?}
151 153 assert_visibility_match user, issues
152 154 end
153 155
154 156 def test_visible_scope_for_admin
155 157 user = User.find(1)
156 158 user.members.each(&:destroy)
157 159 assert user.projects.empty?
158 160 issues = Issue.visible(user).all
159 161 assert issues.any?
160 162 # Admin should see issues on private projects that he does not belong to
161 163 assert issues.detect {|issue| !issue.project.is_public?}
162 164 # Admin should see private issues of other users
163 165 assert issues.detect {|issue| issue.is_private? && issue.author != user}
164 166 assert_visibility_match user, issues
165 167 end
166 168
167 169 def test_visible_scope_with_project
168 170 project = Project.find(1)
169 171 issues = Issue.visible(User.find(2), :project => project).all
170 172 projects = issues.collect(&:project).uniq
171 173 assert_equal 1, projects.size
172 174 assert_equal project, projects.first
173 175 end
174 176
175 177 def test_visible_scope_with_project_and_subprojects
176 178 project = Project.find(1)
177 179 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
178 180 projects = issues.collect(&:project).uniq
179 181 assert projects.size > 1
180 182 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
181 183 end
182 184
183 185 def test_visible_and_nested_set_scopes
184 186 assert_equal 0, Issue.find(1).descendants.visible.all.size
185 187 end
186 188
187 189 def test_errors_full_messages_should_include_custom_fields_errors
188 190 field = IssueCustomField.find_by_name('Database')
189 191
190 192 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
191 193 :status_id => 1, :subject => 'test_create',
192 194 :description => 'IssueTest#test_create_with_required_custom_field')
193 195 assert issue.available_custom_fields.include?(field)
194 196 # Invalid value
195 197 issue.custom_field_values = { field.id => 'SQLServer' }
196 198
197 199 assert !issue.valid?
198 200 assert_equal 1, issue.errors.full_messages.size
199 201 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}", issue.errors.full_messages.first
200 202 end
201 203
202 204 def test_update_issue_with_required_custom_field
203 205 field = IssueCustomField.find_by_name('Database')
204 206 field.update_attribute(:is_required, true)
205 207
206 208 issue = Issue.find(1)
207 209 assert_nil issue.custom_value_for(field)
208 210 assert issue.available_custom_fields.include?(field)
209 211 # No change to custom values, issue can be saved
210 212 assert issue.save
211 213 # Blank value
212 214 issue.custom_field_values = { field.id => '' }
213 215 assert !issue.save
214 216 # Valid value
215 217 issue.custom_field_values = { field.id => 'PostgreSQL' }
216 218 assert issue.save
217 219 issue.reload
218 220 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
219 221 end
220 222
221 223 def test_should_not_update_attributes_if_custom_fields_validation_fails
222 224 issue = Issue.find(1)
223 225 field = IssueCustomField.find_by_name('Database')
224 226 assert issue.available_custom_fields.include?(field)
225 227
226 228 issue.custom_field_values = { field.id => 'Invalid' }
227 229 issue.subject = 'Should be not be saved'
228 230 assert !issue.save
229 231
230 232 issue.reload
231 233 assert_equal "Can't print recipes", issue.subject
232 234 end
233 235
234 236 def test_should_not_recreate_custom_values_objects_on_update
235 237 field = IssueCustomField.find_by_name('Database')
236 238
237 239 issue = Issue.find(1)
238 240 issue.custom_field_values = { field.id => 'PostgreSQL' }
239 241 assert issue.save
240 242 custom_value = issue.custom_value_for(field)
241 243 issue.reload
242 244 issue.custom_field_values = { field.id => 'MySQL' }
243 245 assert issue.save
244 246 issue.reload
245 247 assert_equal custom_value.id, issue.custom_value_for(field).id
246 248 end
247 249
248 250 def test_assigning_tracker_id_should_reload_custom_fields_values
249 251 issue = Issue.new(:project => Project.find(1))
250 252 assert issue.custom_field_values.empty?
251 253 issue.tracker_id = 1
252 254 assert issue.custom_field_values.any?
253 255 end
254 256
255 257 def test_assigning_attributes_should_assign_tracker_id_first
256 258 attributes = ActiveSupport::OrderedHash.new
257 259 attributes['custom_field_values'] = { '1' => 'MySQL' }
258 260 attributes['tracker_id'] = '1'
259 261 issue = Issue.new(:project => Project.find(1))
260 262 issue.attributes = attributes
261 263 assert_not_nil issue.custom_value_for(1)
262 264 assert_equal 'MySQL', issue.custom_value_for(1).value
263 265 end
264 266
265 267 def test_should_update_issue_with_disabled_tracker
266 268 p = Project.find(1)
267 269 issue = Issue.find(1)
268 270
269 271 p.trackers.delete(issue.tracker)
270 272 assert !p.trackers.include?(issue.tracker)
271 273
272 274 issue.reload
273 275 issue.subject = 'New subject'
274 276 assert issue.save
275 277 end
276 278
277 279 def test_should_not_set_a_disabled_tracker
278 280 p = Project.find(1)
279 281 p.trackers.delete(Tracker.find(2))
280 282
281 283 issue = Issue.find(1)
282 284 issue.tracker_id = 2
283 285 issue.subject = 'New subject'
284 286 assert !issue.save
285 287 assert_not_nil issue.errors.on(:tracker_id)
286 288 end
287 289
288 290 def test_category_based_assignment
289 291 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
290 292 :status_id => 1, :priority => IssuePriority.all.first,
291 293 :subject => 'Assignment test',
292 294 :description => 'Assignment test', :category_id => 1)
293 295 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
294 296 end
295 297
296 298 def test_new_statuses_allowed_to
297 299 Workflow.delete_all
298 300
299 301 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2, :author => false, :assignee => false)
300 302 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3, :author => true, :assignee => false)
301 303 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4, :author => false, :assignee => true)
302 304 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5, :author => true, :assignee => true)
303 305 status = IssueStatus.find(1)
304 306 role = Role.find(1)
305 307 tracker = Tracker.find(1)
306 308 user = User.find(2)
307 309
308 310 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1)
309 311 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
310 312
311 313 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user)
312 314 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
313 315
314 316 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :assigned_to => user)
315 317 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
316 318
317 319 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user, :assigned_to => user)
318 320 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
319 321 end
320 322
321 323 def test_copy
322 324 issue = Issue.new.copy_from(1)
323 325 assert issue.save
324 326 issue.reload
325 327 orig = Issue.find(1)
326 328 assert_equal orig.subject, issue.subject
327 329 assert_equal orig.tracker, issue.tracker
328 330 assert_equal "125", issue.custom_value_for(2).value
329 331 end
330 332
331 333 def test_copy_should_copy_status
332 334 orig = Issue.find(8)
333 335 assert orig.status != IssueStatus.default
334 336
335 337 issue = Issue.new.copy_from(orig)
336 338 assert issue.save
337 339 issue.reload
338 340 assert_equal orig.status, issue.status
339 341 end
340 342
341 343 def test_should_close_duplicates
342 344 # Create 3 issues
343 345 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Duplicates test', :description => 'Duplicates test')
344 346 assert issue1.save
345 347 issue2 = issue1.clone
346 348 assert issue2.save
347 349 issue3 = issue1.clone
348 350 assert issue3.save
349 351
350 352 # 2 is a dupe of 1
351 353 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
352 354 # And 3 is a dupe of 2
353 355 IssueRelation.create(:issue_from => issue3, :issue_to => issue2, :relation_type => IssueRelation::TYPE_DUPLICATES)
354 356 # And 3 is a dupe of 1 (circular duplicates)
355 357 IssueRelation.create(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
356 358
357 359 assert issue1.reload.duplicates.include?(issue2)
358 360
359 361 # Closing issue 1
360 362 issue1.init_journal(User.find(:first), "Closing issue1")
361 363 issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
362 364 assert issue1.save
363 365 # 2 and 3 should be also closed
364 366 assert issue2.reload.closed?
365 367 assert issue3.reload.closed?
366 368 end
367 369
368 370 def test_should_not_close_duplicated_issue
369 371 # Create 3 issues
370 372 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Duplicates test', :description => 'Duplicates test')
371 373 assert issue1.save
372 374 issue2 = issue1.clone
373 375 assert issue2.save
374 376
375 377 # 2 is a dupe of 1
376 378 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
377 379 # 2 is a dup of 1 but 1 is not a duplicate of 2
378 380 assert !issue2.reload.duplicates.include?(issue1)
379 381
380 382 # Closing issue 2
381 383 issue2.init_journal(User.find(:first), "Closing issue2")
382 384 issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
383 385 assert issue2.save
384 386 # 1 should not be also closed
385 387 assert !issue1.reload.closed?
386 388 end
387 389
388 390 def test_assignable_versions
389 391 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
390 392 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
391 393 end
392 394
393 395 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
394 396 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
395 397 assert !issue.save
396 398 assert_not_nil issue.errors.on(:fixed_version_id)
397 399 end
398 400
399 401 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
400 402 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
401 403 assert !issue.save
402 404 assert_not_nil issue.errors.on(:fixed_version_id)
403 405 end
404 406
405 407 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
406 408 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 3, :subject => 'New issue')
407 409 assert issue.save
408 410 end
409 411
410 412 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
411 413 issue = Issue.find(11)
412 414 assert_equal 'closed', issue.fixed_version.status
413 415 issue.subject = 'Subject changed'
414 416 assert issue.save
415 417 end
416 418
417 419 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
418 420 issue = Issue.find(11)
419 421 issue.status_id = 1
420 422 assert !issue.save
421 423 assert_not_nil issue.errors.on_base
422 424 end
423 425
424 426 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
425 427 issue = Issue.find(11)
426 428 issue.status_id = 1
427 429 issue.fixed_version_id = 3
428 430 assert issue.save
429 431 end
430 432
431 433 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
432 434 issue = Issue.find(12)
433 435 assert_equal 'locked', issue.fixed_version.status
434 436 issue.status_id = 1
435 437 assert issue.save
436 438 end
437 439
438 440 def test_move_to_another_project_with_same_category
439 441 issue = Issue.find(1)
440 442 assert issue.move_to_project(Project.find(2))
441 443 issue.reload
442 444 assert_equal 2, issue.project_id
443 445 # Category changes
444 446 assert_equal 4, issue.category_id
445 447 # Make sure time entries were move to the target project
446 448 assert_equal 2, issue.time_entries.first.project_id
447 449 end
448 450
449 451 def test_move_to_another_project_without_same_category
450 452 issue = Issue.find(2)
451 453 assert issue.move_to_project(Project.find(2))
452 454 issue.reload
453 455 assert_equal 2, issue.project_id
454 456 # Category cleared
455 457 assert_nil issue.category_id
456 458 end
457 459
458 460 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
459 461 issue = Issue.find(1)
460 462 issue.update_attribute(:fixed_version_id, 1)
461 463 assert issue.move_to_project(Project.find(2))
462 464 issue.reload
463 465 assert_equal 2, issue.project_id
464 466 # Cleared fixed_version
465 467 assert_equal nil, issue.fixed_version
466 468 end
467 469
468 470 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
469 471 issue = Issue.find(1)
470 472 issue.update_attribute(:fixed_version_id, 4)
471 473 assert issue.move_to_project(Project.find(5))
472 474 issue.reload
473 475 assert_equal 5, issue.project_id
474 476 # Keep fixed_version
475 477 assert_equal 4, issue.fixed_version_id
476 478 end
477 479
478 480 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
479 481 issue = Issue.find(1)
480 482 issue.update_attribute(:fixed_version_id, 1)
481 483 assert issue.move_to_project(Project.find(5))
482 484 issue.reload
483 485 assert_equal 5, issue.project_id
484 486 # Cleared fixed_version
485 487 assert_equal nil, issue.fixed_version
486 488 end
487 489
488 490 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
489 491 issue = Issue.find(1)
490 492 issue.update_attribute(:fixed_version_id, 7)
491 493 assert issue.move_to_project(Project.find(2))
492 494 issue.reload
493 495 assert_equal 2, issue.project_id
494 496 # Keep fixed_version
495 497 assert_equal 7, issue.fixed_version_id
496 498 end
497 499
498 500 def test_move_to_another_project_with_disabled_tracker
499 501 issue = Issue.find(1)
500 502 target = Project.find(2)
501 503 target.tracker_ids = [3]
502 504 target.save
503 505 assert_equal false, issue.move_to_project(target)
504 506 issue.reload
505 507 assert_equal 1, issue.project_id
506 508 end
507 509
508 510 def test_copy_to_the_same_project
509 511 issue = Issue.find(1)
510 512 copy = nil
511 513 assert_difference 'Issue.count' do
512 514 copy = issue.move_to_project(issue.project, nil, :copy => true)
513 515 end
514 516 assert_kind_of Issue, copy
515 517 assert_equal issue.project, copy.project
516 518 assert_equal "125", copy.custom_value_for(2).value
517 519 end
518 520
519 521 def test_copy_to_another_project_and_tracker
520 522 issue = Issue.find(1)
521 523 copy = nil
522 524 assert_difference 'Issue.count' do
523 525 copy = issue.move_to_project(Project.find(3), Tracker.find(2), :copy => true)
524 526 end
525 527 copy.reload
526 528 assert_kind_of Issue, copy
527 529 assert_equal Project.find(3), copy.project
528 530 assert_equal Tracker.find(2), copy.tracker
529 531 # Custom field #2 is not associated with target tracker
530 532 assert_nil copy.custom_value_for(2)
531 533 end
532 534
533 535 context "#move_to_project" do
534 536 context "as a copy" do
535 537 setup do
536 538 @issue = Issue.find(1)
537 539 @copy = nil
538 540 end
539 541
540 542 should "not create a journal" do
541 543 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
542 544 assert_equal 0, @copy.reload.journals.size
543 545 end
544 546
545 547 should "allow assigned_to changes" do
546 548 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
547 549 assert_equal 3, @copy.assigned_to_id
548 550 end
549 551
550 552 should "allow status changes" do
551 553 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:status_id => 2}})
552 554 assert_equal 2, @copy.status_id
553 555 end
554 556
555 557 should "allow start date changes" do
556 558 date = Date.today
557 559 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
558 560 assert_equal date, @copy.start_date
559 561 end
560 562
561 563 should "allow due date changes" do
562 564 date = Date.today
563 565 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:due_date => date}})
564 566
565 567 assert_equal date, @copy.due_date
566 568 end
567 569
568 570 should "set current user as author" do
569 571 User.current = User.find(9)
570 572 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {}})
571 573
572 574 assert_equal User.current, @copy.author
573 575 end
574 576
575 577 should "keep journal notes" do
576 578 date = Date.today
577 579 notes = "Notes added when copying"
578 580 User.current = User.find(9)
579 581 @issue.init_journal(User.current, notes)
580 582 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
581 583
582 584 assert_equal 1, @copy.journals.size
583 585 journal = @copy.journals.first
584 586 assert_equal 0, journal.details.size
585 587 assert_equal notes, journal.notes
586 588 end
587 589 end
588 590 end
589 591
590 592 def test_recipients_should_not_include_users_that_cannot_view_the_issue
591 593 issue = Issue.find(12)
592 594 assert issue.recipients.include?(issue.author.mail)
593 595 # move the issue to a private project
594 596 copy = issue.move_to_project(Project.find(5), Tracker.find(2), :copy => true)
595 597 # author is not a member of project anymore
596 598 assert !copy.recipients.include?(copy.author.mail)
597 599 end
598 600
599 601 def test_recipients_should_include_the_assigned_group_members
600 602 group_member = User.generate_with_protected!
601 603 group = Group.generate!
602 604 group.users << group_member
603 605
604 606 issue = Issue.find(12)
605 607 issue.assigned_to = group
606 608 assert issue.recipients.include?(group_member.mail)
607 609 end
608 610
609 611 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
610 612 user = User.find(3)
611 613 issue = Issue.find(9)
612 614 Watcher.create!(:user => user, :watchable => issue)
613 615 assert issue.watched_by?(user)
614 616 assert !issue.watcher_recipients.include?(user.mail)
615 617 end
616 618
617 619 def test_issue_destroy
618 620 Issue.find(1).destroy
619 621 assert_nil Issue.find_by_id(1)
620 622 assert_nil TimeEntry.find_by_issue_id(1)
621 623 end
622 624
623 625 def test_blocked
624 626 blocked_issue = Issue.find(9)
625 627 blocking_issue = Issue.find(10)
626 628
627 629 assert blocked_issue.blocked?
628 630 assert !blocking_issue.blocked?
629 631 end
630 632
631 633 def test_blocked_issues_dont_allow_closed_statuses
632 634 blocked_issue = Issue.find(9)
633 635
634 636 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
635 637 assert !allowed_statuses.empty?
636 638 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
637 639 assert closed_statuses.empty?
638 640 end
639 641
640 642 def test_unblocked_issues_allow_closed_statuses
641 643 blocking_issue = Issue.find(10)
642 644
643 645 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
644 646 assert !allowed_statuses.empty?
645 647 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
646 648 assert !closed_statuses.empty?
647 649 end
648 650
649 651 def test_rescheduling_an_issue_should_reschedule_following_issue
650 652 issue1 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
651 653 issue2 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
652 654 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
653 655 assert_equal issue1.due_date + 1, issue2.reload.start_date
654 656
655 657 issue1.due_date = Date.today + 5
656 658 issue1.save!
657 659 assert_equal issue1.due_date + 1, issue2.reload.start_date
658 660 end
659 661
660 662 def test_overdue
661 663 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
662 664 assert !Issue.new(:due_date => Date.today).overdue?
663 665 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
664 666 assert !Issue.new(:due_date => nil).overdue?
665 667 assert !Issue.new(:due_date => 1.day.ago.to_date, :status => IssueStatus.find(:first, :conditions => {:is_closed => true})).overdue?
666 668 end
667 669
668 670 context "#behind_schedule?" do
669 671 should "be false if the issue has no start_date" do
670 672 assert !Issue.new(:start_date => nil, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
671 673 end
672 674
673 675 should "be false if the issue has no end_date" do
674 676 assert !Issue.new(:start_date => 1.day.from_now.to_date, :due_date => nil, :done_ratio => 0).behind_schedule?
675 677 end
676 678
677 679 should "be false if the issue has more done than it's calendar time" do
678 680 assert !Issue.new(:start_date => 50.days.ago.to_date, :due_date => 50.days.from_now.to_date, :done_ratio => 90).behind_schedule?
679 681 end
680 682
681 683 should "be true if the issue hasn't been started at all" do
682 684 assert Issue.new(:start_date => 1.day.ago.to_date, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
683 685 end
684 686
685 687 should "be true if the issue has used more calendar time than it's done ratio" do
686 688 assert Issue.new(:start_date => 100.days.ago.to_date, :due_date => Date.today, :done_ratio => 90).behind_schedule?
687 689 end
688 690 end
689 691
690 692 context "#assignable_users" do
691 693 should "be Users" do
692 694 assert_kind_of User, Issue.find(1).assignable_users.first
693 695 end
694 696
695 697 should "include the issue author" do
696 698 project = Project.find(1)
697 699 non_project_member = User.generate!
698 700 issue = Issue.generate_for_project!(project, :author => non_project_member)
699 701
700 702 assert issue.assignable_users.include?(non_project_member)
701 703 end
702 704
703 705 should "include the current assignee" do
704 706 project = Project.find(1)
705 707 user = User.generate!
706 708 issue = Issue.generate_for_project!(project, :assigned_to => user)
707 709 user.lock!
708 710
709 711 assert Issue.find(issue.id).assignable_users.include?(user)
710 712 end
711 713
712 714 should "not show the issue author twice" do
713 715 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
714 716 assert_equal 2, assignable_user_ids.length
715 717
716 718 assignable_user_ids.each do |user_id|
717 719 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length, "User #{user_id} appears more or less than once"
718 720 end
719 721 end
720 722
721 723 context "with issue_group_assignment" do
722 724 should "include groups" do
723 725 issue = Issue.new(:project => Project.find(2))
724 726
725 727 with_settings :issue_group_assignment => '1' do
726 728 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
727 729 assert issue.assignable_users.include?(Group.find(11))
728 730 end
729 731 end
730 732 end
731 733
732 734 context "without issue_group_assignment" do
733 735 should "not include groups" do
734 736 issue = Issue.new(:project => Project.find(2))
735 737
736 738 with_settings :issue_group_assignment => '0' do
737 739 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
738 740 assert !issue.assignable_users.include?(Group.find(11))
739 741 end
740 742 end
741 743 end
742 744 end
743 745
744 746 def test_create_should_send_email_notification
745 747 ActionMailer::Base.deliveries.clear
746 748 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create', :estimated_hours => '1:30')
747 749
748 750 assert issue.save
749 751 assert_equal 1, ActionMailer::Base.deliveries.size
750 752 end
751 753
752 754 def test_stale_issue_should_not_send_email_notification
753 755 ActionMailer::Base.deliveries.clear
754 756 issue = Issue.find(1)
755 757 stale = Issue.find(1)
756 758
757 759 issue.init_journal(User.find(1))
758 760 issue.subject = 'Subjet update'
759 761 assert issue.save
760 762 assert_equal 1, ActionMailer::Base.deliveries.size
761 763 ActionMailer::Base.deliveries.clear
762 764
763 765 stale.init_journal(User.find(1))
764 766 stale.subject = 'Another subjet update'
765 767 assert_raise ActiveRecord::StaleObjectError do
766 768 stale.save
767 769 end
768 770 assert ActionMailer::Base.deliveries.empty?
769 771 end
770 772
771 773 def test_journalized_description
772 774 IssueCustomField.delete_all
773 775
774 776 i = Issue.first
775 777 old_description = i.description
776 778 new_description = "This is the new description"
777 779
778 780 i.init_journal(User.find(2))
779 781 i.description = new_description
780 782 assert_difference 'Journal.count', 1 do
781 783 assert_difference 'JournalDetail.count', 1 do
782 784 i.save!
783 785 end
784 786 end
785 787
786 788 detail = JournalDetail.first(:order => 'id DESC')
787 789 assert_equal i, detail.journal.journalized
788 790 assert_equal 'attr', detail.property
789 791 assert_equal 'description', detail.prop_key
790 792 assert_equal old_description, detail.old_value
791 793 assert_equal new_description, detail.value
792 794 end
793 795
794 796 def test_blank_descriptions_should_not_be_journalized
795 797 IssueCustomField.delete_all
796 798 Issue.update_all("description = NULL", "id=1")
797 799
798 800 i = Issue.find(1)
799 801 i.init_journal(User.find(2))
800 802 i.subject = "blank description"
801 803 i.description = "\r\n"
802 804
803 805 assert_difference 'Journal.count', 1 do
804 806 assert_difference 'JournalDetail.count', 1 do
805 807 i.save!
806 808 end
807 809 end
808 810 end
809 811
810 812 def test_description_eol_should_be_normalized
811 813 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
812 814 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
813 815 end
814 816
815 817 def test_saving_twice_should_not_duplicate_journal_details
816 818 i = Issue.find(:first)
817 819 i.init_journal(User.find(2), 'Some notes')
818 820 # initial changes
819 821 i.subject = 'New subject'
820 822 i.done_ratio = i.done_ratio + 10
821 823 assert_difference 'Journal.count' do
822 824 assert i.save
823 825 end
824 826 # 1 more change
825 827 i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id])
826 828 assert_no_difference 'Journal.count' do
827 829 assert_difference 'JournalDetail.count', 1 do
828 830 i.save
829 831 end
830 832 end
831 833 # no more change
832 834 assert_no_difference 'Journal.count' do
833 835 assert_no_difference 'JournalDetail.count' do
834 836 i.save
835 837 end
836 838 end
837 839 end
838 840
839 841 def test_all_dependent_issues
840 842 IssueRelation.delete_all
841 843 assert IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => IssueRelation::TYPE_PRECEDES)
842 844 assert IssueRelation.create!(:issue_from => Issue.find(2), :issue_to => Issue.find(3), :relation_type => IssueRelation::TYPE_PRECEDES)
843 845 assert IssueRelation.create!(:issue_from => Issue.find(3), :issue_to => Issue.find(8), :relation_type => IssueRelation::TYPE_PRECEDES)
844 846
845 847 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
846 848 end
847 849
848 850 def test_all_dependent_issues_with_persistent_circular_dependency
849 851 IssueRelation.delete_all
850 852 assert IssueRelation.create!(:issue_from => Issue.find(1),
851 853 :issue_to => Issue.find(2),
852 854 :relation_type => IssueRelation::TYPE_PRECEDES)
853 855 assert IssueRelation.create!(:issue_from => Issue.find(2),
854 856 :issue_to => Issue.find(3),
855 857 :relation_type => IssueRelation::TYPE_PRECEDES)
856 858 # Validation skipping
857 859 assert IssueRelation.new(:issue_from => Issue.find(3),
858 860 :issue_to => Issue.find(1),
859 861 :relation_type => IssueRelation::TYPE_PRECEDES).save(false)
860 862
861 863 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
862 864 end
863 865
864 866 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
865 867 IssueRelation.delete_all
866 868 assert IssueRelation.create!(:issue_from => Issue.find(1),
867 869 :issue_to => Issue.find(2),
868 870 :relation_type => IssueRelation::TYPE_RELATES)
869 871 assert IssueRelation.create!(:issue_from => Issue.find(2),
870 872 :issue_to => Issue.find(3),
871 873 :relation_type => IssueRelation::TYPE_RELATES)
872 874 assert IssueRelation.create!(:issue_from => Issue.find(3),
873 875 :issue_to => Issue.find(8),
874 876 :relation_type => IssueRelation::TYPE_RELATES)
875 877 # Validation skipping
876 878 assert IssueRelation.new(:issue_from => Issue.find(8),
877 879 :issue_to => Issue.find(2),
878 880 :relation_type => IssueRelation::TYPE_RELATES).save(false)
879 881 assert IssueRelation.new(:issue_from => Issue.find(3),
880 882 :issue_to => Issue.find(1),
881 883 :relation_type => IssueRelation::TYPE_RELATES).save(false)
882 884
883 885 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
884 886 end
885 887
886 888 context "#done_ratio" do
887 889 setup do
888 890 @issue = Issue.find(1)
889 891 @issue_status = IssueStatus.find(1)
890 892 @issue_status.update_attribute(:default_done_ratio, 50)
891 893 @issue2 = Issue.find(2)
892 894 @issue_status2 = IssueStatus.find(2)
893 895 @issue_status2.update_attribute(:default_done_ratio, 0)
894 896 end
895 897
896 898 context "with Setting.issue_done_ratio using the issue_field" do
897 899 setup do
898 900 Setting.issue_done_ratio = 'issue_field'
899 901 end
900 902
901 903 should "read the issue's field" do
902 904 assert_equal 0, @issue.done_ratio
903 905 assert_equal 30, @issue2.done_ratio
904 906 end
905 907 end
906 908
907 909 context "with Setting.issue_done_ratio using the issue_status" do
908 910 setup do
909 911 Setting.issue_done_ratio = 'issue_status'
910 912 end
911 913
912 914 should "read the Issue Status's default done ratio" do
913 915 assert_equal 50, @issue.done_ratio
914 916 assert_equal 0, @issue2.done_ratio
915 917 end
916 918 end
917 919 end
918 920
919 921 context "#update_done_ratio_from_issue_status" do
920 922 setup do
921 923 @issue = Issue.find(1)
922 924 @issue_status = IssueStatus.find(1)
923 925 @issue_status.update_attribute(:default_done_ratio, 50)
924 926 @issue2 = Issue.find(2)
925 927 @issue_status2 = IssueStatus.find(2)
926 928 @issue_status2.update_attribute(:default_done_ratio, 0)
927 929 end
928 930
929 931 context "with Setting.issue_done_ratio using the issue_field" do
930 932 setup do
931 933 Setting.issue_done_ratio = 'issue_field'
932 934 end
933 935
934 936 should "not change the issue" do
935 937 @issue.update_done_ratio_from_issue_status
936 938 @issue2.update_done_ratio_from_issue_status
937 939
938 940 assert_equal 0, @issue.read_attribute(:done_ratio)
939 941 assert_equal 30, @issue2.read_attribute(:done_ratio)
940 942 end
941 943 end
942 944
943 945 context "with Setting.issue_done_ratio using the issue_status" do
944 946 setup do
945 947 Setting.issue_done_ratio = 'issue_status'
946 948 end
947 949
948 950 should "change the issue's done ratio" do
949 951 @issue.update_done_ratio_from_issue_status
950 952 @issue2.update_done_ratio_from_issue_status
951 953
952 954 assert_equal 50, @issue.read_attribute(:done_ratio)
953 955 assert_equal 0, @issue2.read_attribute(:done_ratio)
954 956 end
955 957 end
956 958 end
957 959
958 960 test "#by_tracker" do
959 961 User.current = User.anonymous
960 962 groups = Issue.by_tracker(Project.find(1))
961 963 assert_equal 3, groups.size
962 964 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
963 965 end
964 966
965 967 test "#by_version" do
966 968 User.current = User.anonymous
967 969 groups = Issue.by_version(Project.find(1))
968 970 assert_equal 3, groups.size
969 971 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
970 972 end
971 973
972 974 test "#by_priority" do
973 975 User.current = User.anonymous
974 976 groups = Issue.by_priority(Project.find(1))
975 977 assert_equal 4, groups.size
976 978 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
977 979 end
978 980
979 981 test "#by_category" do
980 982 User.current = User.anonymous
981 983 groups = Issue.by_category(Project.find(1))
982 984 assert_equal 2, groups.size
983 985 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
984 986 end
985 987
986 988 test "#by_assigned_to" do
987 989 User.current = User.anonymous
988 990 groups = Issue.by_assigned_to(Project.find(1))
989 991 assert_equal 2, groups.size
990 992 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
991 993 end
992 994
993 995 test "#by_author" do
994 996 User.current = User.anonymous
995 997 groups = Issue.by_author(Project.find(1))
996 998 assert_equal 4, groups.size
997 999 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
998 1000 end
999 1001
1000 1002 test "#by_subproject" do
1001 1003 User.current = User.anonymous
1002 1004 groups = Issue.by_subproject(Project.find(1))
1003 1005 # Private descendant not visible
1004 1006 assert_equal 1, groups.size
1005 1007 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1006 1008 end
1007 1009
1008 1010 context ".allowed_target_projects_on_move" do
1009 1011 should "return all active projects for admin users" do
1010 1012 User.current = User.find(1)
1011 1013 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
1012 1014 end
1013 1015
1014 1016 should "return allowed projects for non admin users" do
1015 1017 User.current = User.find(2)
1016 1018 Role.non_member.remove_permission! :move_issues
1017 1019 assert_equal 3, Issue.allowed_target_projects_on_move.size
1018 1020
1019 1021 Role.non_member.add_permission! :move_issues
1020 1022 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
1021 1023 end
1022 1024 end
1023 1025
1024 1026 def test_recently_updated_with_limit_scopes
1025 1027 #should return the last updated issue
1026 1028 assert_equal 1, Issue.recently_updated.with_limit(1).length
1027 1029 assert_equal Issue.find(:first, :order => "updated_on DESC"), Issue.recently_updated.with_limit(1).first
1028 1030 end
1029 1031
1030 1032 def test_on_active_projects_scope
1031 1033 assert Project.find(2).archive
1032 1034
1033 1035 before = Issue.on_active_project.length
1034 1036 # test inclusion to results
1035 1037 issue = Issue.generate_for_project!(Project.find(1), :tracker => Project.find(2).trackers.first)
1036 1038 assert_equal before + 1, Issue.on_active_project.length
1037 1039
1038 1040 # Move to an archived project
1039 1041 issue.project = Project.find(2)
1040 1042 assert issue.save
1041 1043 assert_equal before, Issue.on_active_project.length
1042 1044 end
1043 1045
1044 1046 context "Issue#recipients" do
1045 1047 setup do
1046 1048 @project = Project.find(1)
1047 1049 @author = User.generate_with_protected!
1048 1050 @assignee = User.generate_with_protected!
1049 1051 @issue = Issue.generate_for_project!(@project, :assigned_to => @assignee, :author => @author)
1050 1052 end
1051 1053
1052 1054 should "include project recipients" do
1053 1055 assert @project.recipients.present?
1054 1056 @project.recipients.each do |project_recipient|
1055 1057 assert @issue.recipients.include?(project_recipient)
1056 1058 end
1057 1059 end
1058 1060
1059 1061 should "include the author if the author is active" do
1060 1062 assert @issue.author, "No author set for Issue"
1061 1063 assert @issue.recipients.include?(@issue.author.mail)
1062 1064 end
1063 1065
1064 1066 should "include the assigned to user if the assigned to user is active" do
1065 1067 assert @issue.assigned_to, "No assigned_to set for Issue"
1066 1068 assert @issue.recipients.include?(@issue.assigned_to.mail)
1067 1069 end
1068 1070
1069 1071 should "not include users who opt out of all email" do
1070 1072 @author.update_attribute(:mail_notification, :none)
1071 1073
1072 1074 assert !@issue.recipients.include?(@issue.author.mail)
1073 1075 end
1074 1076
1075 1077 should "not include the issue author if they are only notified of assigned issues" do
1076 1078 @author.update_attribute(:mail_notification, :only_assigned)
1077 1079
1078 1080 assert !@issue.recipients.include?(@issue.author.mail)
1079 1081 end
1080 1082
1081 1083 should "not include the assigned user if they are only notified of owned issues" do
1082 1084 @assignee.update_attribute(:mail_notification, :only_owner)
1083 1085
1084 1086 assert !@issue.recipients.include?(@issue.assigned_to.mail)
1085 1087 end
1086 1088
1087 1089 end
1088 1090 end
General Comments 0
You need to be logged in to leave comments. Login now