jro_apps/redmine Commit - r11731:60d2a5e322cb

Use #find_issues as before filter for issues context menu....

Jean-Philippe Lang -

r11731:60d2a5e322cb

parent child

Context file:

r11731:60d2a5e322cb

app/controllers/context_menus_controller.rb +2 -4

               helper :watchers
               helper :issues
+              before_filter :find_issues, :only => :issues
               def issues
-                @issues = Issue.visible.all(:conditions => {:id => params[:ids]}, :include => :project)
-                (render_404; return) unless @issues.present?
                 if (@issues.size == 1)
                   @issue = @issues.first
                 end
                 @issue_ids = @issues.map(&:id).sort
                 @allowed_statuses = @issues.map(&:new_statuses_allowed_to).reduce(:&)
-                @projects = @issues.collect(&:project).compact.uniq
-                @project = @projects.first if @projects.size == 1
                 @can = {:edit => User.current.allowed_to?(:edit_issues, @projects),
                         :log_time => (@project && User.current.allowed_to?(:log_time, @project)),

test/functional/context_menus_controller_test.rb +3 -5

                 assert_select 'a', :text => 'eCookbook - Shared'
               end
-              def test_context_menu_issue_visibility
+              def test_context_menu_with_issue_that_is_not_visible_should_fail
-                get :issues, :ids => [1, 4]
+                get :issues, :ids => [1, 4] # issue 4 is not visible
-                assert_response :success
+                assert_response 302
-                assert_template 'context_menu'
-                assert_equal [1], assigns(:issues).collect(&:id)
               end
               def test_should_respond_with_404_without_ids

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages