jro_apps/redmine Commit - r8704:5e0c1cc5ce9e

Bulk-edit custom fields through context menu (#6296)....

Jean-Philippe Lang -

r8704:5e0c1cc5ce9e

parent child

Context file:

r8704:5e0c1cc5ce9e

Collapse all files

app/controllers/context_menus_controller.rb +13 0

             class ContextMenusController < ApplicationController
               helper :watchers
               helper :issues
               def issues
                 @issues = Issue.visible.all(:conditions => {:id => params[:ids]}, :include => :project)
                 if (@issues.size == 1)
                   @issue = @issues.first
                   @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                 else
                   @allowed_statuses = @issues.map do |i|
                     i.new_statuses_allowed_to(User.current)
                   end.inject do |memo,s|
                     memo & s
                   end
                 end
                 @projects = @issues.collect(&:project).compact.uniq
                 @project = @projects.first if @projects.size == 1
                 @can = {:edit => User.current.allowed_to?(:edit_issues, @projects),
                         :log_time => (@project && User.current.allowed_to?(:log_time, @project)),
                         :update => (User.current.allowed_to?(:edit_issues, @projects) || (User.current.allowed_to?(:change_status, @projects) && !@allowed_statuses.blank?)),
                         :move => (@project && User.current.allowed_to?(:move_issues, @project)),
                         :copy => (@issue && @project.trackers.include?(@issue.tracker) && User.current.allowed_to?(:add_issues, @project)),
                         :delete => User.current.allowed_to?(:delete_issues, @projects)
                         }
                 if @project
                   if @issue
                     @assignables = @issue.assignable_users
                   else
                     @assignables = @project.assignable_users
                   end
                   @trackers = @project.trackers
                 else
                   #when multiple projects, we only keep the intersection of each set
                   @assignables = @projects.map(&:assignable_users).inject{|memo,a| memo & a}
                   @trackers = @projects.map(&:trackers).inject{|memo,t| memo & t}
                 end
                 @priorities = IssuePriority.active.reverse
                 @statuses = IssueStatus.find(:all, :order => 'position')
                 @back = back_url
+                @options_by_custom_field = {}
+                if @can[:edit]
+                  custom_fields = @issues.map(&:available_custom_fields).inject {|memo, f| memo & f}.select do |f|
+                    %w(bool list user version).include?(f.field_format) && !f.multiple?
+                  end
+                  custom_fields.each do |field|
+                    values = field.possible_values_options(@projects)
+                    if values.any?
+                      @options_by_custom_field[field] = values
+                    end
+                  end
+                end
                 render :layout => false
               end
               def time_entries
                 @time_entries = TimeEntry.all(
                    :conditions => {:id => params[:ids]}, :include => :project)
                 @projects = @time_entries.collect(&:project).compact.uniq
                 @project = @projects.first if @projects.size == 1
                 @activities = TimeEntryActivity.shared.active
                 @can = {:edit   => User.current.allowed_to?(:edit_time_entries, @projects),
                         :delete => User.current.allowed_to?(:edit_time_entries, @projects)
                         }
                 @back = back_url
                 render :layout => false
               end
             end

app/helpers/context_menus_helper.rb +7 0

             # encoding: utf-8
             #
             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             module ContextMenusHelper
               def context_menu_link(name, url, options={})
                 options[:class] ||= ''
                 if options.delete(:selected)
                   options[:class] << ' icon-checked disabled'
                   options[:disabled] = true
                 end
                 if options.delete(:disabled)
                   options.delete(:method)
                   options.delete(:confirm)
                   options.delete(:onclick)
                   options[:class] << ' disabled'
                   url = '#'
                 end
                 link_to h(name), url, options
               end
+              def bulk_update_custom_field_context_menu_link(field, text, value)
+                context_menu_link h(text),
+                  {:controller => 'issues', :action => 'bulk_update', :ids => @issues.collect(&:id), :issue => {'custom_field_values' => {field.id => value}}, :back_url => @back},
+                  :method => :post,
+                  :selected => (@issue && @issue.custom_field_value(field) == value)
+              end
             end

app/models/custom_field.rb +5 -1

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class CustomField < ActiveRecord::Base
               include Redmine::SubclassFactory
               has_many :custom_values, :dependent => :delete_all
               acts_as_list :scope => 'type = \'#{self.class}\''
               serialize :possible_values
               validates_presence_of :name, :field_format
               validates_uniqueness_of :name, :scope => :type
               validates_length_of :name, :maximum => 30
               validates_inclusion_of :field_format, :in => Redmine::CustomFieldFormat.available_formats
               validate :validate_custom_field
               before_validation :set_searchable
               def initialize(attributes=nil, *args)
                 super
                 self.possible_values ||= []
               end
               def set_searchable
                 # make sure these fields are not searchable
                 self.searchable = false if %w(int float date bool).include?(field_format)
                 # make sure only these fields can have multiple values
                 self.multiple = false unless %w(list user version).include?(field_format)
                 true
               end
               def validate_custom_field
                 if self.field_format == "list"
                   errors.add(:possible_values, :blank) if self.possible_values.nil? || self.possible_values.empty?
                   errors.add(:possible_values, :invalid) unless self.possible_values.is_a? Array
                 end
                 if regexp.present?
                   begin
                     Regexp.new(regexp)
                   rescue
                     errors.add(:regexp, :invalid)
                   end
                 end
                 if default_value.present? && !valid_field_value?(default_value)
                   errors.add(:default_value, :invalid)
                 end
               end
               def possible_values_options(obj=nil)
                 case field_format
                 when 'user', 'version'
                   if obj.respond_to?(:project) && obj.project
                     case field_format
                     when 'user'
                       obj.project.users.sort.collect {|u| [u.to_s, u.id.to_s]}
                     when 'version'
                       obj.project.shared_versions.sort.collect {|u| [u.to_s, u.id.to_s]}
                     end
                   elsif obj.is_a?(Array)
                     obj.collect {|o| possible_values_options(o)}.inject {|memo, v| memo & v}
                   else
                     []
                   end
+                when 'bool'
+                  [[l(:general_text_Yes), '1'], [l(:general_text_No), '0']]
                 else
-                  read_attribute :possible_values
+                  read_attribute(:possible_values) || []
                 end
               end
               def possible_values(obj=nil)
                 case field_format
                 when 'user', 'version'
                   possible_values_options(obj).collect(&:last)
+                when 'bool'
+                  ['1', '0']
                 else
                   read_attribute :possible_values
                 end
               end
               # Makes possible_values accept a multiline string
               def possible_values=(arg)
                 if arg.is_a?(Array)
                   write_attribute(:possible_values, arg.compact.collect(&:strip).select {|v| !v.blank?})
                 else
                   self.possible_values = arg.to_s.split(/[\n\r]+/)
                 end
               end
               def cast_value(value)
                 casted = nil
                 unless value.blank?
                   case field_format
                   when 'string', 'text', 'list'
                     casted = value
                   when 'date'
                     casted = begin; value.to_date; rescue; nil end
                   when 'bool'
                     casted = (value == '1' ? true : false)
                   when 'int'
                     casted = value.to_i
                   when 'float'
                     casted = value.to_f
                   when 'user', 'version'
                     casted = (value.blank? ? nil : field_format.classify.constantize.find_by_id(value.to_i))
                   end
                 end
                 casted
               end
               # Returns a ORDER BY clause that can used to sort customized
               # objects by their value of the custom field.
               # Returns false, if the custom field can not be used for sorting.
               def order_statement
                 return nil if multiple?
                 case field_format
                   when 'string', 'text', 'list', 'date', 'bool'
                     # COALESCE is here to make sure that blank and NULL values are sorted equally
                     "COALESCE((SELECT cv_sort.value FROM #{CustomValue.table_name} cv_sort" +
                       " WHERE cv_sort.customized_type='#{self.class.customized_class.name}'" +
                       " AND cv_sort.customized_id=#{self.class.customized_class.table_name}.id" +
                       " AND cv_sort.custom_field_id=#{id} LIMIT 1), '')"
                   when 'int', 'float'
                     # Make the database cast values into numeric
                     # Postgresql will raise an error if a value can not be casted!
                     # CustomValue validations should ensure that it doesn't occur
                     "(SELECT CAST(cv_sort.value AS decimal(60,3)) FROM #{CustomValue.table_name} cv_sort" +
                       " WHERE cv_sort.customized_type='#{self.class.customized_class.name}'" +
                       " AND cv_sort.customized_id=#{self.class.customized_class.table_name}.id" +
                       " AND cv_sort.custom_field_id=#{id} AND cv_sort.value <> '' AND cv_sort.value IS NOT NULL LIMIT 1)"
                   else
                     nil
                 end
               end
               def <=>(field)
                 position <=> field.position
               end
               def self.customized_class
                 self.name =~ /^(.+)CustomField$/
                 begin; $1.constantize; rescue nil; end
               end
               # to move in project_custom_field
               def self.for_all
                 find(:all, :conditions => ["is_for_all=?", true], :order => 'position')
               end
               def type_name
                 nil
               end
               # Returns the error messages for the given value
               # or an empty array if value is a valid value for the custom field
               def validate_field_value(value)
                 errs = []
                 if value.is_a?(Array)
                   if !multiple?
                     errs << ::I18n.t('activerecord.errors.messages.invalid')
                   end
                   if is_required? && value.detect(&:present?).nil?
                     errs << ::I18n.t('activerecord.errors.messages.blank')
                   end
                   value.each {|v| errs += validate_field_value_format(v)}
                 else
                   if is_required? && value.blank?
                     errs << ::I18n.t('activerecord.errors.messages.blank')
                   end
                   errs += validate_field_value_format(value)
                 end
                 errs
               end
               # Returns true if value is a valid value for the custom field
               def valid_field_value?(value)
                 validate_field_value(value).empty?
               end
               protected
               # Returns the error message for the given value regarding its format
               def validate_field_value_format(value)
                 errs = []
                 if value.present?
                   errs << ::I18n.t('activerecord.errors.messages.invalid') unless regexp.blank? or value =~ Regexp.new(regexp)
                   errs << ::I18n.t('activerecord.errors.messages.too_short', :count => min_length) if min_length > 0 and value.length < min_length
                   errs << ::I18n.t('activerecord.errors.messages.too_long', :count => max_length) if max_length > 0 and value.length > max_length
                   # Format specific validations
                   case field_format
                   when 'int'
                     errs << ::I18n.t('activerecord.errors.messages.not_a_number') unless value =~ /^[+-]?\d+$/
                   when 'float'
                     begin; Kernel.Float(value); rescue; errs << ::I18n.t('activerecord.errors.messages.invalid') end
                   when 'date'
                     errs << ::I18n.t('activerecord.errors.messages.not_a_date') unless value =~ /^\d{4}-\d{2}-\d{2}$/ && begin; value.to_date; rescue; false end
                   when 'list'
                     errs << ::I18n.t('activerecord.errors.messages.inclusion') unless possible_values.include?(value)
                   end
                 end
                 errs
               end
             end

app/views/context_menus/issues.html.erb +14 0

             <ul>
               <%= call_hook(:view_issues_context_menu_start, {:issues => @issues, :can => @can, :back => @back }) %>
             <% if !@issue.nil? -%>
               <li><%= context_menu_link l(:button_edit), {:controller => 'issues', :action => 'edit', :id => @issue},
                       :class => 'icon-edit', :disabled => !@can[:edit] %></li>
             <% else %>
               <li><%= context_menu_link l(:button_edit), {:controller => 'issues', :action => 'bulk_edit', :ids => @issues.collect(&:id)},
                       :class => 'icon-edit', :disabled => !@can[:edit] %></li>
             <% end %>
               <% if @allowed_statuses.present? %>
               <li class="folder">
                 <a href="#" class="submenu" onclick="return false;"><%= l(:field_status) %></a>
                 <ul>
                 <% @statuses.each do |s| -%>
                     <li><%= context_menu_link h(s.name), {:controller => 'issues', :action => 'bulk_update', :ids => @issues.collect(&:id), :issue => {:status_id => s}, :back_url => @back}, :method => :post,
                                               :selected => (@issue && s == @issue.status), :disabled => !(@can[:update] && @allowed_statuses.include?(s)) %></li>
                 <% end -%>
                 </ul>
               </li>
               <% end %>
               <% unless @trackers.nil? %>
               <li class="folder">
                 <a href="#" class="submenu"><%= l(:field_tracker) %></a>
                 <ul>
                 <% @trackers.each do |t| -%>
                     <li><%= context_menu_link h(t.name), {:controller => 'issues', :action => 'bulk_update', :ids => @issues.collect(&:id), :issue => {'tracker_id' => t}, :back_url => @back}, :method => :post,
                                               :selected => (@issue && t == @issue.tracker), :disabled => !@can[:edit] %></li>
                 <% end -%>
                 </ul>
               </li>
               <% end %>
               <li class="folder">
                 <a href="#" class="submenu"><%= l(:field_priority) %></a>
                 <ul>
                 <% @priorities.each do |p| -%>
                     <li><%= context_menu_link h(p.name), {:controller => 'issues', :action => 'bulk_update', :ids => @issues.collect(&:id), :issue => {'priority_id' => p}, :back_url => @back}, :method => :post,
                                               :selected => (@issue && p == @issue.priority), :disabled => (!@can[:edit] || @issues.detect {|i| !i.leaf?}) %></li>
                 <% end -%>
                 </ul>
               </li>
               <% #TODO: allow editing versions when multiple projects %>
               <% unless @project.nil? || @project.shared_versions.open.empty? -%>
               <li class="folder">
                 <a href="#" class="submenu"><%= l(:field_fixed_version) %></a>
                 <ul>
                 <% @project.shared_versions.open.sort.each do |v| -%>
                     <li><%= context_menu_link format_version_name(v), {:controller => 'issues', :action => 'bulk_update', :ids => @issues.collect(&:id), :issue => {'fixed_version_id' => v}, :back_url => @back}, :method => :post,
                                               :selected => (@issue && v == @issue.fixed_version), :disabled => !@can[:update] %></li>
                 <% end -%>
                     <li><%= context_menu_link l(:label_none), {:controller => 'issues', :action => 'bulk_update', :ids => @issues.collect(&:id), :issue => {'fixed_version_id' => 'none'}, :back_url => @back}, :method => :post,
                                               :selected => (@issue && @issue.fixed_version.nil?), :disabled => !@can[:update] %></li>
                 </ul>
               </li>
               <% end %>
               <% if @assignables.present? -%>
               <li class="folder">
                 <a href="#" class="submenu"><%= l(:field_assigned_to) %></a>
                 <ul>
                 <% if @assignables.include?(User.current) %>
                     <li><%= context_menu_link "<< #{l(:label_me)} >>", {:controller => 'issues', :action => 'bulk_update', :ids => @issues.collect(&:id), :issue => {'assigned_to_id' => User.current}, :back_url => @back}, :method => :post,
                                               :disabled => !@can[:update] %></li>
                 <% end %>
                 <% @assignables.each do |u| -%>
                     <li><%= context_menu_link h(u.name), {:controller => 'issues', :action => 'bulk_update', :ids => @issues.collect(&:id), :issue => {'assigned_to_id' => u}, :back_url => @back}, :method => :post,
                                               :selected => (@issue && u == @issue.assigned_to), :disabled => !@can[:update] %></li>
                 <% end -%>
                     <li><%= context_menu_link l(:label_nobody), {:controller => 'issues', :action => 'bulk_update', :ids => @issues.collect(&:id), :issue => {'assigned_to_id' => 'none'}, :back_url => @back}, :method => :post,
                                               :selected => (@issue && @issue.assigned_to.nil?), :disabled => !@can[:update] %></li>
                 </ul>
               </li>
               <% end %>
               <% unless @project.nil? || @project.issue_categories.empty? -%>
               <li class="folder">
                 <a href="#" class="submenu"><%= l(:field_category) %></a>
                 <ul>
                 <% @project.issue_categories.each do |u| -%>
                     <li><%= context_menu_link h(u.name), {:controller => 'issues', :action => 'bulk_update', :ids => @issues.collect(&:id), :issue => {'category_id' => u}, :back_url => @back}, :method => :post,
                                               :selected => (@issue && u == @issue.category), :disabled => !@can[:update] %></li>
                 <% end -%>
                     <li><%= context_menu_link l(:label_none), {:controller => 'issues', :action => 'bulk_update', :ids => @issues.collect(&:id), :issue => {'category_id' => 'none'}, :back_url => @back}, :method => :post,
                                               :selected => (@issue && @issue.category.nil?), :disabled => !@can[:update] %></li>
                 </ul>
               </li>
               <% end -%>
               <% if Issue.use_field_for_done_ratio? %>
               <li class="folder">
                 <a href="#" class="submenu"><%= l(:field_done_ratio) %></a>
                 <ul>
                 <% (0..10).map{|x|x*10}.each do |p| -%>
                     <li><%= context_menu_link "#{p}%", {:controller => 'issues', :action => 'bulk_update', :ids => @issues.collect(&:id), :issue => {'done_ratio' => p}, :back_url => @back}, :method => :post,
                                                   :selected => (@issue && p == @issue.done_ratio), :disabled => (!@can[:edit] || @issues.detect {|i| !i.leaf?}) %></li>
                 <% end -%>
                 </ul>
               </li>
               <% end %>
+              <% @options_by_custom_field.each do |field, options| %>
+                <li class="folder">
+                  <a href="#" class="submenu"><%= h(field.name) %></a>
+                  <ul>
+                  <% options.each do |text, value| %>
+                    <li><%= bulk_update_custom_field_context_menu_link(field, text, value || text) %></li>
+                  <% end %>
+                  <% unless field.is_required? %>
+                    <li><%= bulk_update_custom_field_context_menu_link(field, l(:label_none), '') %></li>
+                  <% end %>
+                  </ul>
+                </li>
+              <% end %>
             <% if !@issue.nil? %>
               <% if @can[:log_time] -%>
               <li><%= context_menu_link l(:button_log_time), {:controller => 'timelog', :action => 'new', :issue_id => @issue},
                       :class => 'icon-time-add' %></li>
               <% end %>
               <% if User.current.logged? %>
               <li><%= watcher_link(@issue, User.current) %></li>
               <% end %>
             <% end %>
             <% if @issue.present? %>
               <li><%= context_menu_link l(:button_copy), {:controller => 'issues', :action => 'new', :project_id => @project, :copy_from => @issue},
                       :class => 'icon-copy', :disabled => !@can[:copy] %></li>
             <% else %>
               <li><%= context_menu_link l(:button_copy), {:controller => 'issues', :action => 'bulk_edit', :ids => @issues.collect(&:id), :copy => '1'},
                                       :class => 'icon-copy', :disabled => !@can[:move] %></li>
             <% end %>
               <li><%= context_menu_link l(:button_delete), issues_path(:ids => @issues.collect(&:id), :back_url => @back),
                                         :method => :delete, :confirm => issues_destroy_confirmation_message(@issues), :class => 'icon-del', :disabled => !@can[:delete] %></li>
               <%= call_hook(:view_issues_context_menu_end, {:issues => @issues, :can => @can, :back => @back }) %>
             </ul>

public/stylesheets/context_menu.css +1 -1

             #context-menu { position: absolute; z-index: 40; font-size: 0.9em;}
             #context-menu ul, #context-menu li, #context-menu a {
                 display:block;
                 margin:0;
                 padding:0;
                 border:0;
             }
             #context-menu ul {
                 width:150px;
                 border-top:1px solid #ddd;
                 border-left:1px solid #ddd;
                 border-bottom:1px solid #777;
                 border-right:1px solid #777;
                 background:white;
                 list-style:none;
             }
             #context-menu li {
                 position:relative;
                 padding:1px;
                 z-index:39;
                 border:1px solid white;
             }
             #context-menu li.folder ul { position:absolute; left:168px; /* IE6 */ top:-2px; max-height:300px; overflow:hidden; overflow-y: auto; }
             #context-menu li.folder>ul { left:148px; }
             #context-menu.reverse-y li.folder>ul { top:auto; bottom:0; }
             #context-menu.reverse-x li.folder ul { left:auto; right:168px; /* IE6 */ }
             #context-menu.reverse-x li.folder>ul { right:148px; }
             #context-menu a {
                 text-decoration:none !important;
                 background-repeat: no-repeat;
                 background-position: 1px 50%;
                 padding: 1px 0px 1px 20px;
                 width:100%; /* IE */
             }
             #context-menu li>a { width:auto; } /* others */
             #context-menu a.disabled, #context-menu a.disabled:hover {color: #ccc;}
-            #context-menu li a.submenu { background:url("../images/bullet_arrow_right.png") right no-repeat; }
+            #context-menu li a.submenu { padding-right:16px; background:url("../images/bullet_arrow_right.png") right no-repeat; }
             #context-menu li:hover { border:1px solid gray; background-color:#eee; }
             #context-menu a:hover {color:#2A5685;}
             #context-menu li.folder:hover { z-index:40; }
             #context-menu ul ul, #context-menu  li:hover ul ul { display:none; }
             #context-menu li:hover ul, #context-menu li:hover li:hover ul { display:block; }
             /* selected element */
             .context-menu-selection { background-color:#507AAA !important; color:#f8f8f8 !important; }
             .context-menu-selection a, .context-menu-selection a:hover { color:#f8f8f8 !important; }
             .context-menu-selection:hover { background-color:#507AAA !important; color:#f8f8f8  !important; }

test/functional/context_menus_controller_test.rb +96 0

             require File.expand_path('../../test_helper', __FILE__)
             class ContextMenusControllerTest < ActionController::TestCase
               fixtures :projects,
                        :trackers,
                        :projects_trackers,
                        :roles,
                        :member_roles,
                        :members,
                        :auth_sources,
                        :enabled_modules,
                        :workflows,
                        :journals, :journal_details,
                        :versions,
                        :issues, :issue_statuses, :issue_categories,
                        :users,
                        :enumerations,
                        :time_entries
               def test_context_menu_one_issue
                 @request.session[:user_id] = 2
                 get :issues, :ids => [1]
                 assert_response :success
                 assert_template 'context_menu'
                 assert_tag :tag => 'a', :content => 'Edit',
                                         :attributes => { :href => '/issues/1/edit',
                                                          :class => 'icon-edit' }
                 assert_tag :tag => 'a', :content => 'Closed',
                                         :attributes => { :href => '/issues/bulk_update?ids%5B%5D=1&amp;issue%5Bstatus_id%5D=5',
                                                          :class => '' }
                 assert_tag :tag => 'a', :content => 'Immediate',
                                         :attributes => { :href => '/issues/bulk_update?ids%5B%5D=1&amp;issue%5Bpriority_id%5D=8',
                                                          :class => '' }
                 assert_no_tag :tag => 'a', :content => 'Inactive Priority'
                 # Versions
                 assert_tag :tag => 'a', :content => '2.0',
                                         :attributes => { :href => '/issues/bulk_update?ids%5B%5D=1&amp;issue%5Bfixed_version_id%5D=3',
                                                          :class => '' }
                 assert_tag :tag => 'a', :content => 'eCookbook Subproject 1 - 2.0',
                                         :attributes => { :href => '/issues/bulk_update?ids%5B%5D=1&amp;issue%5Bfixed_version_id%5D=4',
                                                          :class => '' }
                 assert_tag :tag => 'a', :content => 'Dave Lopper',
                                         :attributes => { :href => '/issues/bulk_update?ids%5B%5D=1&amp;issue%5Bassigned_to_id%5D=3',
                                                          :class => '' }
                 assert_tag :tag => 'a', :content => 'Copy',
                                         :attributes => { :href => '/projects/ecookbook/issues/1/copy',
                                                          :class => 'icon-copy' }
                 assert_no_tag :tag => 'a', :content => 'Move'
                 assert_tag :tag => 'a', :content => 'Delete',
                                         :attributes => { :href => '/issues?ids%5B%5D=1',
                                                          :class => 'icon-del' }
               end
               def test_context_menu_one_issue_by_anonymous
                 get :issues, :ids => [1]
                 assert_response :success
                 assert_template 'context_menu'
                 assert_tag :tag => 'a', :content => 'Delete',
                                         :attributes => { :href => '#',
                                                          :class => 'icon-del disabled' }
               end
               def test_context_menu_multiple_issues_of_same_project
                 @request.session[:user_id] = 2
                 get :issues, :ids => [1, 2]
                 assert_response :success
                 assert_template 'context_menu'
                 assert_not_nil assigns(:issues)
                 assert_equal [1, 2], assigns(:issues).map(&:id).sort
                 ids = assigns(:issues).map(&:id).map {|i| "ids%5B%5D=#{i}"}.join('&amp;')
                 assert_tag :tag => 'a', :content => 'Edit',
                                         :attributes => { :href => "/issues/bulk_edit?#{ids}",
                                                          :class => 'icon-edit' }
                 assert_tag :tag => 'a', :content => 'Closed',
                                         :attributes => { :href => "/issues/bulk_update?#{ids}&amp;issue%5Bstatus_id%5D=5",
                                                          :class => '' }
                 assert_tag :tag => 'a', :content => 'Immediate',
                                         :attributes => { :href => "/issues/bulk_update?#{ids}&amp;issue%5Bpriority_id%5D=8",
                                                          :class => '' }
                 assert_tag :tag => 'a', :content => 'Dave Lopper',
                                         :attributes => { :href => "/issues/bulk_update?#{ids}&amp;issue%5Bassigned_to_id%5D=3",
                                                          :class => '' }
                 assert_tag :tag => 'a', :content => 'Copy',
                                         :attributes => { :href => "/issues/bulk_edit?copy=1&amp;#{ids}",
                                                          :class => 'icon-copy' }
                 assert_no_tag :tag => 'a', :content => 'Move'
                 assert_tag :tag => 'a', :content => 'Delete',
                                         :attributes => { :href => "/issues?#{ids}",
                                                          :class => 'icon-del' }
               end
               def test_context_menu_multiple_issues_of_different_projects
                 @request.session[:user_id] = 2
                 get :issues, :ids => [1, 2, 6]
                 assert_response :success
                 assert_template 'context_menu'
                 assert_not_nil assigns(:issues)
                 assert_equal [1, 2, 6], assigns(:issues).map(&:id).sort
                 ids = assigns(:issues).map(&:id).map {|i| "ids%5B%5D=#{i}"}.join('&amp;')
                 assert_tag :tag => 'a', :content => 'Edit',
                                         :attributes => { :href => "/issues/bulk_edit?#{ids}",
                                                          :class => 'icon-edit' }
                 assert_tag :tag => 'a', :content => 'Closed',
                                         :attributes => { :href => "/issues/bulk_update?#{ids}&amp;issue%5Bstatus_id%5D=5",
                                                          :class => '' }
                 assert_tag :tag => 'a', :content => 'Immediate',
                                         :attributes => { :href => "/issues/bulk_update?#{ids}&amp;issue%5Bpriority_id%5D=8",
                                                          :class => '' }
                 assert_tag :tag => 'a', :content => 'John Smith',
                                         :attributes => { :href => "/issues/bulk_update?#{ids}&amp;issue%5Bassigned_to_id%5D=2",
                                                          :class => '' }
                 assert_tag :tag => 'a', :content => 'Delete',
                                         :attributes => { :href => "/issues?#{ids}",
                                                          :class => 'icon-del' }
               end
+              def test_context_menu_should_include_list_custom_fields
+                field = IssueCustomField.create!(:name => 'List', :field_format => 'list',
+                  :possible_values => ['Foo', 'Bar'], :is_for_all => true, :tracker_ids => [1, 2, 3])
+                @request.session[:user_id] = 2
+                get :issues, :ids => [1, 2]
+                assert_tag 'a',
+                  :content => 'List',
+                  :attributes => {:href => '#'},
+                  :sibling => {:tag => 'ul', :children => {:count => 3}}
+                assert_tag 'a',
+                  :content => 'Foo',
+                  :attributes => {:href => "/issues/bulk_update?ids%5B%5D=1&amp;ids%5B%5D=2&amp;issue%5Bcustom_field_values%5D%5B#{field.id}%5D=Foo"}
+                assert_tag 'a',
+                  :content => 'none',
+                  :attributes => {:href => "/issues/bulk_update?ids%5B%5D=1&amp;ids%5B%5D=2&amp;issue%5Bcustom_field_values%5D%5B#{field.id}%5D="}
+              end
+              def test_context_menu_should_not_include_null_value_for_required_custom_fields
+                field = IssueCustomField.create!(:name => 'List', :is_required => true, :field_format => 'list',
+                  :possible_values => ['Foo', 'Bar'], :is_for_all => true, :tracker_ids => [1, 2, 3])
+                @request.session[:user_id] = 2
+                get :issues, :ids => [1, 2]
+                assert_tag 'a',
+                  :content => 'List',
+                  :attributes => {:href => '#'},
+                  :sibling => {:tag => 'ul', :children => {:count => 2}}
+              end
+              def test_context_menu_on_single_issue_should_select_current_custom_field_value
+                field = IssueCustomField.create!(:name => 'List', :field_format => 'list',
+                  :possible_values => ['Foo', 'Bar'], :is_for_all => true, :tracker_ids => [1, 2, 3])
+                issue = Issue.find(1)
+                issue.custom_field_values = {field.id => 'Bar'}
+                issue.save!
+                @request.session[:user_id] = 2
+                get :issues, :ids => [1]
+                assert_tag 'a',
+                  :content => 'List',
+                  :attributes => {:href => '#'},
+                  :sibling => {:tag => 'ul', :children => {:count => 3}}
+                assert_tag 'a',
+                  :content => 'Bar',
+                  :attributes => {:class => /icon-checked/}
+              end
+              def test_context_menu_should_include_bool_custom_fields
+                field = IssueCustomField.create!(:name => 'Bool', :field_format => 'bool',
+                  :is_for_all => true, :tracker_ids => [1, 2, 3])
+                @request.session[:user_id] = 2
+                get :issues, :ids => [1, 2]
+                assert_tag 'a',
+                  :content => 'Bool',
+                  :attributes => {:href => '#'},
+                  :sibling => {:tag => 'ul', :children => {:count => 3}}
+                assert_tag 'a',
+                  :content => 'Yes',
+                  :attributes => {:href => "/issues/bulk_update?ids%5B%5D=1&amp;ids%5B%5D=2&amp;issue%5Bcustom_field_values%5D%5B#{field.id}%5D=1"}
+              end
+              def test_context_menu_should_include_user_custom_fields
+                field = IssueCustomField.create!(:name => 'User', :field_format => 'user',
+                  :is_for_all => true, :tracker_ids => [1, 2, 3])
+                @request.session[:user_id] = 2
+                get :issues, :ids => [1, 2]
+                assert_tag 'a',
+                  :content => 'User',
+                  :attributes => {:href => '#'},
+                  :sibling => {:tag => 'ul', :children => {:count => Project.find(1).members.count + 1}}
+                assert_tag 'a',
+                  :content => 'John Smith',
+                  :attributes => {:href => "/issues/bulk_update?ids%5B%5D=1&amp;ids%5B%5D=2&amp;issue%5Bcustom_field_values%5D%5B#{field.id}%5D=2"}
+              end
+              def test_context_menu_should_include_version_custom_fields
+                field = IssueCustomField.create!(:name => 'Version', :field_format => 'version', :is_for_all => true, :tracker_ids => [1, 2, 3])
+                @request.session[:user_id] = 2
+                get :issues, :ids => [1, 2]
+                assert_tag 'a',
+                  :content => 'Version',
+                  :attributes => {:href => '#'},
+                  :sibling => {:tag => 'ul', :children => {:count => Project.find(1).shared_versions.count + 1}}
+                assert_tag 'a',
+                  :content => '2.0',
+                  :attributes => {:href => "/issues/bulk_update?ids%5B%5D=1&amp;ids%5B%5D=2&amp;issue%5Bcustom_field_values%5D%5B#{field.id}%5D=3"}
+              end
               def test_context_menu_by_assignable_user_should_include_assigned_to_me_link
                 @request.session[:user_id] = 2
                 get :issues, :ids => [1]
                 assert_response :success
                 assert_template 'context_menu'
                 assert_tag :tag => 'a', :content => / me /,
                                         :attributes => { :href => '/issues/bulk_update?ids%5B%5D=1&amp;issue%5Bassigned_to_id%5D=2',
                                                          :class => '' }
               end
               def test_context_menu_issue_visibility
                 get :issues, :ids => [1, 4]
                 assert_response :success
                 assert_template 'context_menu'
                 assert_equal [1], assigns(:issues).collect(&:id)
               end
               def test_time_entries_context_menu
                 @request.session[:user_id] = 2
                 get :time_entries, :ids => [1, 2]
                 assert_response :success
                 assert_template 'time_entries'
                 assert_tag 'a', :content => 'Edit'
                 assert_no_tag 'a', :content => 'Edit', :attributes => {:class => /disabled/}
               end
               def test_time_entries_context_menu_without_edit_permission
                 @request.session[:user_id] = 2
                 Role.find_by_name('Manager').remove_permission! :edit_time_entries
                 get :time_entries, :ids => [1, 2]
                 assert_response :success
                 assert_template 'time_entries'
                 assert_tag 'a', :content => 'Edit', :attributes => {:class => /disabled/}
               end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages