jro_apps/redmine Commit - r15245:5d31eb2495c2

Don't generate pagination links with params....

Jean-Philippe Lang -

r15245:5d31eb2495c2

parent child

Context file:

r15245:5d31eb2495c2

lib/redmine/pagination.rb +1 -1

                        if block_given?
                          yield text, parameters, options
                        else
-                         link_to text, params.merge(parameters), options
+                         link_to text, {:params => request.query_parameters.merge(parameters)}, options
                        end
                      end
                    end

test/integration/issues_test.rb +4 -4

                  end
                end
-               def test_pagination_links_on_index_without_project_id_in_url
+               def test_pagination_links_should_preserve_query_parameters
                  with_settings :per_page_options => '2' do
-                   get '/issues', :project_id => 'ecookbook'
-                   assert_select 'a[href=?]', '/projects/ecookbook/issues?page=2', :text => '2'
+                   get '/projects/ecookbook/issues?foo=bar'
+                   assert_select 'a[href=?]', '/projects/ecookbook/issues?foo=bar&page=2', :text => '2'
                  end
                end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages