##// END OF EJS Templates
Merged r12367 and r12368 from trunk to 2.4-stable...
Toshi MARUYAMA -
r12114:5b1073095a2a
parent child
Show More
@@ -1,3967 +1,3967
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssuesControllerTest < ActionController::TestCase
21 21 fixtures :projects,
22 22 :users,
23 23 :roles,
24 24 :members,
25 25 :member_roles,
26 26 :issues,
27 27 :issue_statuses,
28 28 :versions,
29 29 :trackers,
30 30 :projects_trackers,
31 31 :issue_categories,
32 32 :enabled_modules,
33 33 :enumerations,
34 34 :attachments,
35 35 :workflows,
36 36 :custom_fields,
37 37 :custom_values,
38 38 :custom_fields_projects,
39 39 :custom_fields_trackers,
40 40 :time_entries,
41 41 :journals,
42 42 :journal_details,
43 43 :queries,
44 44 :repositories,
45 45 :changesets
46 46
47 47 include Redmine::I18n
48 48
49 49 def setup
50 50 User.current = nil
51 51 end
52 52
53 53 def test_index
54 54 with_settings :default_language => "en" do
55 55 get :index
56 56 assert_response :success
57 57 assert_template 'index'
58 58 assert_not_nil assigns(:issues)
59 59 assert_nil assigns(:project)
60 60
61 61 # links to visible issues
62 62 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
63 63 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
64 64 # private projects hidden
65 65 assert_select 'a[href=/issues/6]', 0
66 66 assert_select 'a[href=/issues/4]', 0
67 67 # project column
68 68 assert_select 'th', :text => /Project/
69 69 end
70 70 end
71 71
72 72 def test_index_should_not_list_issues_when_module_disabled
73 73 EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
74 74 get :index
75 75 assert_response :success
76 76 assert_template 'index'
77 77 assert_not_nil assigns(:issues)
78 78 assert_nil assigns(:project)
79 79
80 80 assert_select 'a[href=/issues/1]', 0
81 81 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
82 82 end
83 83
84 84 def test_index_should_list_visible_issues_only
85 85 get :index, :per_page => 100
86 86 assert_response :success
87 87 assert_not_nil assigns(:issues)
88 88 assert_nil assigns(:issues).detect {|issue| !issue.visible?}
89 89 end
90 90
91 91 def test_index_with_project
92 92 Setting.display_subprojects_issues = 0
93 93 get :index, :project_id => 1
94 94 assert_response :success
95 95 assert_template 'index'
96 96 assert_not_nil assigns(:issues)
97 97
98 98 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
99 99 assert_select 'a[href=/issues/5]', 0
100 100 end
101 101
102 102 def test_index_with_project_and_subprojects
103 103 Setting.display_subprojects_issues = 1
104 104 get :index, :project_id => 1
105 105 assert_response :success
106 106 assert_template 'index'
107 107 assert_not_nil assigns(:issues)
108 108
109 109 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
110 110 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
111 111 assert_select 'a[href=/issues/6]', 0
112 112 end
113 113
114 114 def test_index_with_project_and_subprojects_should_show_private_subprojects_with_permission
115 115 @request.session[:user_id] = 2
116 116 Setting.display_subprojects_issues = 1
117 117 get :index, :project_id => 1
118 118 assert_response :success
119 119 assert_template 'index'
120 120 assert_not_nil assigns(:issues)
121 121
122 122 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
123 123 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
124 124 assert_select 'a[href=/issues/6]', :text => /Issue of a private subproject/
125 125 end
126 126
127 127 def test_index_with_project_and_default_filter
128 128 get :index, :project_id => 1, :set_filter => 1
129 129 assert_response :success
130 130 assert_template 'index'
131 131 assert_not_nil assigns(:issues)
132 132
133 133 query = assigns(:query)
134 134 assert_not_nil query
135 135 # default filter
136 136 assert_equal({'status_id' => {:operator => 'o', :values => ['']}}, query.filters)
137 137 end
138 138
139 139 def test_index_with_project_and_filter
140 140 get :index, :project_id => 1, :set_filter => 1,
141 141 :f => ['tracker_id'],
142 142 :op => {'tracker_id' => '='},
143 143 :v => {'tracker_id' => ['1']}
144 144 assert_response :success
145 145 assert_template 'index'
146 146 assert_not_nil assigns(:issues)
147 147
148 148 query = assigns(:query)
149 149 assert_not_nil query
150 150 assert_equal({'tracker_id' => {:operator => '=', :values => ['1']}}, query.filters)
151 151 end
152 152
153 153 def test_index_with_short_filters
154 154 to_test = {
155 155 'status_id' => {
156 156 'o' => { :op => 'o', :values => [''] },
157 157 'c' => { :op => 'c', :values => [''] },
158 158 '7' => { :op => '=', :values => ['7'] },
159 159 '7|3|4' => { :op => '=', :values => ['7', '3', '4'] },
160 160 '=7' => { :op => '=', :values => ['7'] },
161 161 '!3' => { :op => '!', :values => ['3'] },
162 162 '!7|3|4' => { :op => '!', :values => ['7', '3', '4'] }},
163 163 'subject' => {
164 164 'This is a subject' => { :op => '=', :values => ['This is a subject'] },
165 165 'o' => { :op => '=', :values => ['o'] },
166 166 '~This is part of a subject' => { :op => '~', :values => ['This is part of a subject'] },
167 167 '!~This is part of a subject' => { :op => '!~', :values => ['This is part of a subject'] }},
168 168 'tracker_id' => {
169 169 '3' => { :op => '=', :values => ['3'] },
170 170 '=3' => { :op => '=', :values => ['3'] }},
171 171 'start_date' => {
172 172 '2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
173 173 '=2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
174 174 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
175 175 '<=2011-10-12' => { :op => '<=', :values => ['2011-10-12'] },
176 176 '><2011-10-01|2011-10-30' => { :op => '><', :values => ['2011-10-01', '2011-10-30'] },
177 177 '<t+2' => { :op => '<t+', :values => ['2'] },
178 178 '>t+2' => { :op => '>t+', :values => ['2'] },
179 179 't+2' => { :op => 't+', :values => ['2'] },
180 180 't' => { :op => 't', :values => [''] },
181 181 'w' => { :op => 'w', :values => [''] },
182 182 '>t-2' => { :op => '>t-', :values => ['2'] },
183 183 '<t-2' => { :op => '<t-', :values => ['2'] },
184 184 't-2' => { :op => 't-', :values => ['2'] }},
185 185 'created_on' => {
186 186 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
187 187 '<t-2' => { :op => '<t-', :values => ['2'] },
188 188 '>t-2' => { :op => '>t-', :values => ['2'] },
189 189 't-2' => { :op => 't-', :values => ['2'] }},
190 190 'cf_1' => {
191 191 'c' => { :op => '=', :values => ['c'] },
192 192 '!c' => { :op => '!', :values => ['c'] },
193 193 '!*' => { :op => '!*', :values => [''] },
194 194 '*' => { :op => '*', :values => [''] }},
195 195 'estimated_hours' => {
196 196 '=13.4' => { :op => '=', :values => ['13.4'] },
197 197 '>=45' => { :op => '>=', :values => ['45'] },
198 198 '<=125' => { :op => '<=', :values => ['125'] },
199 199 '><10.5|20.5' => { :op => '><', :values => ['10.5', '20.5'] },
200 200 '!*' => { :op => '!*', :values => [''] },
201 201 '*' => { :op => '*', :values => [''] }}
202 202 }
203 203
204 204 default_filter = { 'status_id' => {:operator => 'o', :values => [''] }}
205 205
206 206 to_test.each do |field, expression_and_expected|
207 207 expression_and_expected.each do |filter_expression, expected|
208 208
209 209 get :index, :set_filter => 1, field => filter_expression
210 210
211 211 assert_response :success
212 212 assert_template 'index'
213 213 assert_not_nil assigns(:issues)
214 214
215 215 query = assigns(:query)
216 216 assert_not_nil query
217 217 assert query.has_filter?(field)
218 218 assert_equal(default_filter.merge({field => {:operator => expected[:op], :values => expected[:values]}}), query.filters)
219 219 end
220 220 end
221 221 end
222 222
223 223 def test_index_with_project_and_empty_filters
224 224 get :index, :project_id => 1, :set_filter => 1, :fields => ['']
225 225 assert_response :success
226 226 assert_template 'index'
227 227 assert_not_nil assigns(:issues)
228 228
229 229 query = assigns(:query)
230 230 assert_not_nil query
231 231 # no filter
232 232 assert_equal({}, query.filters)
233 233 end
234 234
235 235 def test_index_with_project_custom_field_filter
236 236 field = ProjectCustomField.create!(:name => 'Client', :is_filter => true, :field_format => 'string')
237 237 CustomValue.create!(:custom_field => field, :customized => Project.find(3), :value => 'Foo')
238 238 CustomValue.create!(:custom_field => field, :customized => Project.find(5), :value => 'Foo')
239 239 filter_name = "project.cf_#{field.id}"
240 240 @request.session[:user_id] = 1
241 241
242 242 get :index, :set_filter => 1,
243 243 :f => [filter_name],
244 244 :op => {filter_name => '='},
245 245 :v => {filter_name => ['Foo']}
246 246 assert_response :success
247 247 assert_template 'index'
248 248 assert_equal [3, 5], assigns(:issues).map(&:project_id).uniq.sort
249 249 end
250 250
251 251 def test_index_with_query
252 252 get :index, :project_id => 1, :query_id => 5
253 253 assert_response :success
254 254 assert_template 'index'
255 255 assert_not_nil assigns(:issues)
256 256 assert_nil assigns(:issue_count_by_group)
257 257 end
258 258
259 259 def test_index_with_query_grouped_by_tracker
260 260 get :index, :project_id => 1, :query_id => 6
261 261 assert_response :success
262 262 assert_template 'index'
263 263 assert_not_nil assigns(:issues)
264 264 assert_not_nil assigns(:issue_count_by_group)
265 265 end
266 266
267 267 def test_index_with_query_grouped_by_list_custom_field
268 268 get :index, :project_id => 1, :query_id => 9
269 269 assert_response :success
270 270 assert_template 'index'
271 271 assert_not_nil assigns(:issues)
272 272 assert_not_nil assigns(:issue_count_by_group)
273 273 end
274 274
275 275 def test_index_with_query_grouped_by_user_custom_field
276 276 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
277 277 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
278 278 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
279 279 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
280 280 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
281 281
282 282 get :index, :project_id => 1, :set_filter => 1, :group_by => "cf_#{cf.id}"
283 283 assert_response :success
284 284
285 285 assert_select 'tr.group', 3
286 286 assert_select 'tr.group' do
287 287 assert_select 'a', :text => 'John Smith'
288 288 assert_select 'span.count', :text => '1'
289 289 end
290 290 assert_select 'tr.group' do
291 291 assert_select 'a', :text => 'Dave Lopper'
292 292 assert_select 'span.count', :text => '2'
293 293 end
294 294 end
295 295
296 def test_index_with_query_grouped_by_tracker
296 def test_index_with_query_grouped_by_tracker_in_normal_order
297 297 3.times {|i| Issue.generate!(:tracker_id => (i + 1))}
298 298
299 299 get :index, :set_filter => 1, :group_by => 'tracker', :sort => 'id:desc'
300 300 assert_response :success
301 301
302 302 trackers = assigns(:issues).map(&:tracker).uniq
303 303 assert_equal [1, 2, 3], trackers.map(&:id)
304 304 end
305 305
306 306 def test_index_with_query_grouped_by_tracker_in_reverse_order
307 307 3.times {|i| Issue.generate!(:tracker_id => (i + 1))}
308 308
309 309 get :index, :set_filter => 1, :group_by => 'tracker', :sort => 'id:desc,tracker:desc'
310 310 assert_response :success
311 311
312 312 trackers = assigns(:issues).map(&:tracker).uniq
313 313 assert_equal [3, 2, 1], trackers.map(&:id)
314 314 end
315 315
316 316 def test_index_with_query_id_and_project_id_should_set_session_query
317 317 get :index, :project_id => 1, :query_id => 4
318 318 assert_response :success
319 319 assert_kind_of Hash, session[:query]
320 320 assert_equal 4, session[:query][:id]
321 321 assert_equal 1, session[:query][:project_id]
322 322 end
323 323
324 324 def test_index_with_invalid_query_id_should_respond_404
325 325 get :index, :project_id => 1, :query_id => 999
326 326 assert_response 404
327 327 end
328 328
329 329 def test_index_with_cross_project_query_in_session_should_show_project_issues
330 330 q = IssueQuery.create!(:name => "test", :user_id => 2, :visibility => IssueQuery::VISIBILITY_PRIVATE, :project => nil)
331 331 @request.session[:query] = {:id => q.id, :project_id => 1}
332 332
333 333 with_settings :display_subprojects_issues => '0' do
334 334 get :index, :project_id => 1
335 335 end
336 336 assert_response :success
337 337 assert_not_nil assigns(:query)
338 338 assert_equal q.id, assigns(:query).id
339 339 assert_equal 1, assigns(:query).project_id
340 340 assert_equal [1], assigns(:issues).map(&:project_id).uniq
341 341 end
342 342
343 343 def test_private_query_should_not_be_available_to_other_users
344 344 q = IssueQuery.create!(:name => "private", :user => User.find(2), :visibility => IssueQuery::VISIBILITY_PRIVATE, :project => nil)
345 345 @request.session[:user_id] = 3
346 346
347 347 get :index, :query_id => q.id
348 348 assert_response 403
349 349 end
350 350
351 351 def test_private_query_should_be_available_to_its_user
352 352 q = IssueQuery.create!(:name => "private", :user => User.find(2), :visibility => IssueQuery::VISIBILITY_PRIVATE, :project => nil)
353 353 @request.session[:user_id] = 2
354 354
355 355 get :index, :query_id => q.id
356 356 assert_response :success
357 357 end
358 358
359 359 def test_public_query_should_be_available_to_other_users
360 360 q = IssueQuery.create!(:name => "private", :user => User.find(2), :visibility => IssueQuery::VISIBILITY_PUBLIC, :project => nil)
361 361 @request.session[:user_id] = 3
362 362
363 363 get :index, :query_id => q.id
364 364 assert_response :success
365 365 end
366 366
367 367 def test_index_should_omit_page_param_in_export_links
368 368 get :index, :page => 2
369 369 assert_response :success
370 370 assert_select 'a.atom[href=/issues.atom]'
371 371 assert_select 'a.csv[href=/issues.csv]'
372 372 assert_select 'a.pdf[href=/issues.pdf]'
373 373 assert_select 'form#csv-export-form[action=/issues.csv]'
374 374 end
375 375
376 376 def test_index_csv
377 377 get :index, :format => 'csv'
378 378 assert_response :success
379 379 assert_not_nil assigns(:issues)
380 380 assert_equal 'text/csv; header=present', @response.content_type
381 381 assert @response.body.starts_with?("#,")
382 382 lines = @response.body.chomp.split("\n")
383 383 assert_equal assigns(:query).columns.size, lines[0].split(',').size
384 384 end
385 385
386 386 def test_index_csv_with_project
387 387 get :index, :project_id => 1, :format => 'csv'
388 388 assert_response :success
389 389 assert_not_nil assigns(:issues)
390 390 assert_equal 'text/csv; header=present', @response.content_type
391 391 end
392 392
393 393 def test_index_csv_with_description
394 394 Issue.generate!(:description => 'test_index_csv_with_description')
395 395
396 396 with_settings :default_language => 'en' do
397 397 get :index, :format => 'csv', :description => '1'
398 398 assert_response :success
399 399 assert_not_nil assigns(:issues)
400 400 end
401 401
402 402 assert_equal 'text/csv; header=present', response.content_type
403 403 headers = response.body.chomp.split("\n").first.split(',')
404 404 assert_include 'Description', headers
405 405 assert_include 'test_index_csv_with_description', response.body
406 406 end
407 407
408 408 def test_index_csv_with_spent_time_column
409 409 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :subject => 'test_index_csv_with_spent_time_column', :author_id => 2)
410 410 TimeEntry.create!(:project => issue.project, :issue => issue, :hours => 7.33, :user => User.find(2), :spent_on => Date.today)
411 411
412 412 get :index, :format => 'csv', :set_filter => '1', :c => %w(subject spent_hours)
413 413 assert_response :success
414 414 assert_equal 'text/csv; header=present', @response.content_type
415 415 lines = @response.body.chomp.split("\n")
416 416 assert_include "#{issue.id},#{issue.subject},7.33", lines
417 417 end
418 418
419 419 def test_index_csv_with_all_columns
420 420 get :index, :format => 'csv', :columns => 'all'
421 421 assert_response :success
422 422 assert_not_nil assigns(:issues)
423 423 assert_equal 'text/csv; header=present', @response.content_type
424 424 assert_match /\A#,/, response.body
425 425 lines = response.body.chomp.split("\n")
426 426 assert_equal assigns(:query).available_inline_columns.size, lines[0].split(',').size
427 427 end
428 428
429 429 def test_index_csv_with_multi_column_field
430 430 CustomField.find(1).update_attribute :multiple, true
431 431 issue = Issue.find(1)
432 432 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
433 433 issue.save!
434 434
435 435 get :index, :format => 'csv', :columns => 'all'
436 436 assert_response :success
437 437 lines = @response.body.chomp.split("\n")
438 438 assert lines.detect {|line| line.include?('"MySQL, Oracle"')}
439 439 end
440 440
441 441 def test_index_csv_should_format_float_custom_fields_with_csv_decimal_separator
442 442 field = IssueCustomField.create!(:name => 'Float', :is_for_all => true, :tracker_ids => [1], :field_format => 'float')
443 443 issue = Issue.generate!(:project_id => 1, :tracker_id => 1, :custom_field_values => {field.id => '185.6'})
444 444
445 445 with_settings :default_language => 'fr' do
446 446 get :index, :format => 'csv', :columns => 'all'
447 447 assert_response :success
448 448 issue_line = response.body.chomp.split("\n").map {|line| line.split(';')}.detect {|line| line[0]==issue.id.to_s}
449 449 assert_include '185,60', issue_line
450 450 end
451 451
452 452 with_settings :default_language => 'en' do
453 453 get :index, :format => 'csv', :columns => 'all'
454 454 assert_response :success
455 455 issue_line = response.body.chomp.split("\n").map {|line| line.split(',')}.detect {|line| line[0]==issue.id.to_s}
456 456 assert_include '185.60', issue_line
457 457 end
458 458 end
459 459
460 460 def test_index_csv_big_5
461 461 with_settings :default_language => "zh-TW" do
462 462 str_utf8 = "\xe4\xb8\x80\xe6\x9c\x88"
463 463 str_big5 = "\xa4@\xa4\xeb"
464 464 if str_utf8.respond_to?(:force_encoding)
465 465 str_utf8.force_encoding('UTF-8')
466 466 str_big5.force_encoding('Big5')
467 467 end
468 468 issue = Issue.generate!(:subject => str_utf8)
469 469
470 470 get :index, :project_id => 1,
471 471 :f => ['subject'],
472 472 :op => '=', :values => [str_utf8],
473 473 :format => 'csv'
474 474 assert_equal 'text/csv; header=present', @response.content_type
475 475 lines = @response.body.chomp.split("\n")
476 476 s1 = "\xaa\xac\xbaA"
477 477 if str_utf8.respond_to?(:force_encoding)
478 478 s1.force_encoding('Big5')
479 479 end
480 480 assert_include s1, lines[0]
481 481 assert_include str_big5, lines[1]
482 482 end
483 483 end
484 484
485 485 def test_index_csv_cannot_convert_should_be_replaced_big_5
486 486 with_settings :default_language => "zh-TW" do
487 487 str_utf8 = "\xe4\xbb\xa5\xe5\x86\x85"
488 488 if str_utf8.respond_to?(:force_encoding)
489 489 str_utf8.force_encoding('UTF-8')
490 490 end
491 491 issue = Issue.generate!(:subject => str_utf8)
492 492
493 493 get :index, :project_id => 1,
494 494 :f => ['subject'],
495 495 :op => '=', :values => [str_utf8],
496 496 :c => ['status', 'subject'],
497 497 :format => 'csv',
498 498 :set_filter => 1
499 499 assert_equal 'text/csv; header=present', @response.content_type
500 500 lines = @response.body.chomp.split("\n")
501 501 s1 = "\xaa\xac\xbaA" # status
502 502 if str_utf8.respond_to?(:force_encoding)
503 503 s1.force_encoding('Big5')
504 504 end
505 505 assert lines[0].include?(s1)
506 506 s2 = lines[1].split(",")[2]
507 507 if s1.respond_to?(:force_encoding)
508 508 s3 = "\xa5H?" # subject
509 509 s3.force_encoding('Big5')
510 510 assert_equal s3, s2
511 511 elsif RUBY_PLATFORM == 'java'
512 512 assert_equal "??", s2
513 513 else
514 514 assert_equal "\xa5H???", s2
515 515 end
516 516 end
517 517 end
518 518
519 519 def test_index_csv_tw
520 520 with_settings :default_language => "zh-TW" do
521 521 str1 = "test_index_csv_tw"
522 522 issue = Issue.generate!(:subject => str1, :estimated_hours => '1234.5')
523 523
524 524 get :index, :project_id => 1,
525 525 :f => ['subject'],
526 526 :op => '=', :values => [str1],
527 527 :c => ['estimated_hours', 'subject'],
528 528 :format => 'csv',
529 529 :set_filter => 1
530 530 assert_equal 'text/csv; header=present', @response.content_type
531 531 lines = @response.body.chomp.split("\n")
532 532 assert_equal "#{issue.id},1234.50,#{str1}", lines[1]
533 533 end
534 534 end
535 535
536 536 def test_index_csv_fr
537 537 with_settings :default_language => "fr" do
538 538 str1 = "test_index_csv_fr"
539 539 issue = Issue.generate!(:subject => str1, :estimated_hours => '1234.5')
540 540
541 541 get :index, :project_id => 1,
542 542 :f => ['subject'],
543 543 :op => '=', :values => [str1],
544 544 :c => ['estimated_hours', 'subject'],
545 545 :format => 'csv',
546 546 :set_filter => 1
547 547 assert_equal 'text/csv; header=present', @response.content_type
548 548 lines = @response.body.chomp.split("\n")
549 549 assert_equal "#{issue.id};1234,50;#{str1}", lines[1]
550 550 end
551 551 end
552 552
553 553 def test_index_pdf
554 554 ["en", "zh", "zh-TW", "ja", "ko"].each do |lang|
555 555 with_settings :default_language => lang do
556 556
557 557 get :index
558 558 assert_response :success
559 559 assert_template 'index'
560 560
561 561 if lang == "ja"
562 562 if RUBY_PLATFORM != 'java'
563 563 assert_equal "CP932", l(:general_pdf_encoding)
564 564 end
565 565 if RUBY_PLATFORM == 'java' && l(:general_pdf_encoding) == "CP932"
566 566 next
567 567 end
568 568 end
569 569
570 570 get :index, :format => 'pdf'
571 571 assert_response :success
572 572 assert_not_nil assigns(:issues)
573 573 assert_equal 'application/pdf', @response.content_type
574 574
575 575 get :index, :project_id => 1, :format => 'pdf'
576 576 assert_response :success
577 577 assert_not_nil assigns(:issues)
578 578 assert_equal 'application/pdf', @response.content_type
579 579
580 580 get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
581 581 assert_response :success
582 582 assert_not_nil assigns(:issues)
583 583 assert_equal 'application/pdf', @response.content_type
584 584 end
585 585 end
586 586 end
587 587
588 588 def test_index_pdf_with_query_grouped_by_list_custom_field
589 589 get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
590 590 assert_response :success
591 591 assert_not_nil assigns(:issues)
592 592 assert_not_nil assigns(:issue_count_by_group)
593 593 assert_equal 'application/pdf', @response.content_type
594 594 end
595 595
596 596 def test_index_atom
597 597 get :index, :project_id => 'ecookbook', :format => 'atom'
598 598 assert_response :success
599 599 assert_template 'common/feed'
600 600 assert_equal 'application/atom+xml', response.content_type
601 601
602 602 assert_select 'feed' do
603 603 assert_select 'link[rel=self][href=?]', 'http://test.host/projects/ecookbook/issues.atom'
604 604 assert_select 'link[rel=alternate][href=?]', 'http://test.host/projects/ecookbook/issues'
605 605 assert_select 'entry link[href=?]', 'http://test.host/issues/1'
606 606 end
607 607 end
608 608
609 609 def test_index_sort
610 610 get :index, :sort => 'tracker,id:desc'
611 611 assert_response :success
612 612
613 613 sort_params = @request.session['issues_index_sort']
614 614 assert sort_params.is_a?(String)
615 615 assert_equal 'tracker,id:desc', sort_params
616 616
617 617 issues = assigns(:issues)
618 618 assert_not_nil issues
619 619 assert !issues.empty?
620 620 assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
621 621 end
622 622
623 623 def test_index_sort_by_field_not_included_in_columns
624 624 Setting.issue_list_default_columns = %w(subject author)
625 625 get :index, :sort => 'tracker'
626 626 end
627 627
628 628 def test_index_sort_by_assigned_to
629 629 get :index, :sort => 'assigned_to'
630 630 assert_response :success
631 631 assignees = assigns(:issues).collect(&:assigned_to).compact
632 632 assert_equal assignees.sort, assignees
633 633 end
634 634
635 635 def test_index_sort_by_assigned_to_desc
636 636 get :index, :sort => 'assigned_to:desc'
637 637 assert_response :success
638 638 assignees = assigns(:issues).collect(&:assigned_to).compact
639 639 assert_equal assignees.sort.reverse, assignees
640 640 end
641 641
642 642 def test_index_group_by_assigned_to
643 643 get :index, :group_by => 'assigned_to', :sort => 'priority'
644 644 assert_response :success
645 645 end
646 646
647 647 def test_index_sort_by_author
648 648 get :index, :sort => 'author'
649 649 assert_response :success
650 650 authors = assigns(:issues).collect(&:author)
651 651 assert_equal authors.sort, authors
652 652 end
653 653
654 654 def test_index_sort_by_author_desc
655 655 get :index, :sort => 'author:desc'
656 656 assert_response :success
657 657 authors = assigns(:issues).collect(&:author)
658 658 assert_equal authors.sort.reverse, authors
659 659 end
660 660
661 661 def test_index_group_by_author
662 662 get :index, :group_by => 'author', :sort => 'priority'
663 663 assert_response :success
664 664 end
665 665
666 666 def test_index_sort_by_spent_hours
667 667 get :index, :sort => 'spent_hours:desc'
668 668 assert_response :success
669 669 hours = assigns(:issues).collect(&:spent_hours)
670 670 assert_equal hours.sort.reverse, hours
671 671 end
672 672
673 673 def test_index_sort_by_user_custom_field
674 674 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
675 675 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
676 676 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
677 677 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
678 678 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
679 679
680 680 get :index, :project_id => 1, :set_filter => 1, :sort => "cf_#{cf.id},id"
681 681 assert_response :success
682 682
683 683 assert_equal [2, 3, 1], assigns(:issues).select {|issue| issue.custom_field_value(cf).present?}.map(&:id)
684 684 end
685 685
686 686 def test_index_with_columns
687 687 columns = ['tracker', 'subject', 'assigned_to']
688 688 get :index, :set_filter => 1, :c => columns
689 689 assert_response :success
690 690
691 691 # query should use specified columns
692 692 query = assigns(:query)
693 693 assert_kind_of IssueQuery, query
694 694 assert_equal columns, query.column_names.map(&:to_s)
695 695
696 696 # columns should be stored in session
697 697 assert_kind_of Hash, session[:query]
698 698 assert_kind_of Array, session[:query][:column_names]
699 699 assert_equal columns, session[:query][:column_names].map(&:to_s)
700 700
701 701 # ensure only these columns are kept in the selected columns list
702 702 assert_select 'select#selected_columns option' do
703 703 assert_select 'option', 3
704 704 assert_select 'option[value=tracker]'
705 705 assert_select 'option[value=project]', 0
706 706 end
707 707 end
708 708
709 709 def test_index_without_project_should_implicitly_add_project_column_to_default_columns
710 710 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
711 711 get :index, :set_filter => 1
712 712
713 713 # query should use specified columns
714 714 query = assigns(:query)
715 715 assert_kind_of IssueQuery, query
716 716 assert_equal [:id, :project, :tracker, :subject, :assigned_to], query.columns.map(&:name)
717 717 end
718 718
719 719 def test_index_without_project_and_explicit_default_columns_should_not_add_project_column
720 720 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
721 721 columns = ['id', 'tracker', 'subject', 'assigned_to']
722 722 get :index, :set_filter => 1, :c => columns
723 723
724 724 # query should use specified columns
725 725 query = assigns(:query)
726 726 assert_kind_of IssueQuery, query
727 727 assert_equal columns.map(&:to_sym), query.columns.map(&:name)
728 728 end
729 729
730 730 def test_index_with_custom_field_column
731 731 columns = %w(tracker subject cf_2)
732 732 get :index, :set_filter => 1, :c => columns
733 733 assert_response :success
734 734
735 735 # query should use specified columns
736 736 query = assigns(:query)
737 737 assert_kind_of IssueQuery, query
738 738 assert_equal columns, query.column_names.map(&:to_s)
739 739
740 740 assert_select 'table.issues td.cf_2.string'
741 741 end
742 742
743 743 def test_index_with_multi_custom_field_column
744 744 field = CustomField.find(1)
745 745 field.update_attribute :multiple, true
746 746 issue = Issue.find(1)
747 747 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
748 748 issue.save!
749 749
750 750 get :index, :set_filter => 1, :c => %w(tracker subject cf_1)
751 751 assert_response :success
752 752
753 753 assert_select 'table.issues td.cf_1', :text => 'MySQL, Oracle'
754 754 end
755 755
756 756 def test_index_with_multi_user_custom_field_column
757 757 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
758 758 :tracker_ids => [1], :is_for_all => true)
759 759 issue = Issue.find(1)
760 760 issue.custom_field_values = {field.id => ['2', '3']}
761 761 issue.save!
762 762
763 763 get :index, :set_filter => 1, :c => ['tracker', 'subject', "cf_#{field.id}"]
764 764 assert_response :success
765 765
766 766 assert_select "table.issues td.cf_#{field.id}" do
767 767 assert_select 'a', 2
768 768 assert_select 'a[href=?]', '/users/2', :text => 'John Smith'
769 769 assert_select 'a[href=?]', '/users/3', :text => 'Dave Lopper'
770 770 end
771 771 end
772 772
773 773 def test_index_with_date_column
774 774 with_settings :date_format => '%d/%m/%Y' do
775 775 Issue.find(1).update_attribute :start_date, '1987-08-24'
776 776 get :index, :set_filter => 1, :c => %w(start_date)
777 777 assert_select "table.issues td.start_date", :text => '24/08/1987'
778 778 end
779 779 end
780 780
781 781 def test_index_with_done_ratio_column
782 782 Issue.find(1).update_attribute :done_ratio, 40
783 783 get :index, :set_filter => 1, :c => %w(done_ratio)
784 784 assert_select 'table.issues td.done_ratio' do
785 785 assert_select 'table.progress' do
786 786 assert_select 'td.closed[style=?]', 'width: 40%;'
787 787 end
788 788 end
789 789 end
790 790
791 791 def test_index_with_spent_hours_column
792 792 get :index, :set_filter => 1, :c => %w(subject spent_hours)
793 793 assert_select 'table.issues tr#issue-3 td.spent_hours', :text => '1.00'
794 794 end
795 795
796 796 def test_index_should_not_show_spent_hours_column_without_permission
797 797 Role.anonymous.remove_permission! :view_time_entries
798 798 get :index, :set_filter => 1, :c => %w(subject spent_hours)
799 799 assert_select 'td.spent_hours', 0
800 800 end
801 801
802 802 def test_index_with_fixed_version_column
803 803 get :index, :set_filter => 1, :c => %w(fixed_version)
804 804 assert_select 'table.issues td.fixed_version' do
805 805 assert_select 'a[href=?]', '/versions/2', :text => '1.0'
806 806 end
807 807 end
808 808
809 809 def test_index_with_relations_column
810 810 IssueRelation.delete_all
811 811 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Issue.find(7))
812 812 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(8), :issue_to => Issue.find(1))
813 813 IssueRelation.create!(:relation_type => "blocks", :issue_from => Issue.find(1), :issue_to => Issue.find(11))
814 814 IssueRelation.create!(:relation_type => "blocks", :issue_from => Issue.find(12), :issue_to => Issue.find(2))
815 815
816 816 get :index, :set_filter => 1, :c => %w(subject relations)
817 817 assert_response :success
818 818 assert_select "tr#issue-1 td.relations" do
819 819 assert_select "span", 3
820 820 assert_select "span", :text => "Related to #7"
821 821 assert_select "span", :text => "Related to #8"
822 822 assert_select "span", :text => "Blocks #11"
823 823 end
824 824 assert_select "tr#issue-2 td.relations" do
825 825 assert_select "span", 1
826 826 assert_select "span", :text => "Blocked by #12"
827 827 end
828 828 assert_select "tr#issue-3 td.relations" do
829 829 assert_select "span", 0
830 830 end
831 831
832 832 get :index, :set_filter => 1, :c => %w(relations), :format => 'csv'
833 833 assert_response :success
834 834 assert_equal 'text/csv; header=present', response.content_type
835 835 lines = response.body.chomp.split("\n")
836 836 assert_include '1,"Related to #7, Related to #8, Blocks #11"', lines
837 837 assert_include '2,Blocked by #12', lines
838 838 assert_include '3,""', lines
839 839
840 840 get :index, :set_filter => 1, :c => %w(subject relations), :format => 'pdf'
841 841 assert_response :success
842 842 assert_equal 'application/pdf', response.content_type
843 843 end
844 844
845 845 def test_index_with_description_column
846 846 get :index, :set_filter => 1, :c => %w(subject description)
847 847
848 848 assert_select 'table.issues thead th', 3 # columns: chekbox + id + subject
849 849 assert_select 'td.description[colspan=3]', :text => 'Unable to print recipes'
850 850
851 851 get :index, :set_filter => 1, :c => %w(subject description), :format => 'pdf'
852 852 assert_response :success
853 853 assert_equal 'application/pdf', response.content_type
854 854 end
855 855
856 856 def test_index_send_html_if_query_is_invalid
857 857 get :index, :f => ['start_date'], :op => {:start_date => '='}
858 858 assert_equal 'text/html', @response.content_type
859 859 assert_template 'index'
860 860 end
861 861
862 862 def test_index_send_nothing_if_query_is_invalid
863 863 get :index, :f => ['start_date'], :op => {:start_date => '='}, :format => 'csv'
864 864 assert_equal 'text/csv', @response.content_type
865 865 assert @response.body.blank?
866 866 end
867 867
868 868 def test_show_by_anonymous
869 869 get :show, :id => 1
870 870 assert_response :success
871 871 assert_template 'show'
872 872 assert_equal Issue.find(1), assigns(:issue)
873 873 assert_select 'div.issue div.description', :text => /Unable to print recipes/
874 874 # anonymous role is allowed to add a note
875 875 assert_select 'form#issue-form' do
876 876 assert_select 'fieldset' do
877 877 assert_select 'legend', :text => 'Notes'
878 878 assert_select 'textarea[name=?]', 'issue[notes]'
879 879 end
880 880 end
881 881 assert_select 'title', :text => "Bug #1: Can&#x27;t print recipes - eCookbook - Redmine"
882 882 end
883 883
884 884 def test_show_by_manager
885 885 @request.session[:user_id] = 2
886 886 get :show, :id => 1
887 887 assert_response :success
888 888 assert_select 'a', :text => /Quote/
889 889 assert_select 'form#issue-form' do
890 890 assert_select 'fieldset' do
891 891 assert_select 'legend', :text => 'Change properties'
892 892 assert_select 'input[name=?]', 'issue[subject]'
893 893 end
894 894 assert_select 'fieldset' do
895 895 assert_select 'legend', :text => 'Log time'
896 896 assert_select 'input[name=?]', 'time_entry[hours]'
897 897 end
898 898 assert_select 'fieldset' do
899 899 assert_select 'legend', :text => 'Notes'
900 900 assert_select 'textarea[name=?]', 'issue[notes]'
901 901 end
902 902 end
903 903 end
904 904
905 905 def test_show_should_display_update_form
906 906 @request.session[:user_id] = 2
907 907 get :show, :id => 1
908 908 assert_response :success
909 909
910 910 assert_select 'form#issue-form' do
911 911 assert_select 'input[name=?]', 'issue[is_private]'
912 912 assert_select 'select[name=?]', 'issue[project_id]'
913 913 assert_select 'select[name=?]', 'issue[tracker_id]'
914 914 assert_select 'input[name=?]', 'issue[subject]'
915 915 assert_select 'textarea[name=?]', 'issue[description]'
916 916 assert_select 'select[name=?]', 'issue[status_id]'
917 917 assert_select 'select[name=?]', 'issue[priority_id]'
918 918 assert_select 'select[name=?]', 'issue[assigned_to_id]'
919 919 assert_select 'select[name=?]', 'issue[category_id]'
920 920 assert_select 'select[name=?]', 'issue[fixed_version_id]'
921 921 assert_select 'input[name=?]', 'issue[parent_issue_id]'
922 922 assert_select 'input[name=?]', 'issue[start_date]'
923 923 assert_select 'input[name=?]', 'issue[due_date]'
924 924 assert_select 'select[name=?]', 'issue[done_ratio]'
925 925 assert_select 'input[name=?]', 'issue[custom_field_values][2]'
926 926 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
927 927 assert_select 'textarea[name=?]', 'issue[notes]'
928 928 end
929 929 end
930 930
931 931 def test_show_should_display_update_form_with_minimal_permissions
932 932 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
933 933 WorkflowTransition.delete_all :role_id => 1
934 934
935 935 @request.session[:user_id] = 2
936 936 get :show, :id => 1
937 937 assert_response :success
938 938
939 939 assert_select 'form#issue-form' do
940 940 assert_select 'input[name=?]', 'issue[is_private]', 0
941 941 assert_select 'select[name=?]', 'issue[project_id]', 0
942 942 assert_select 'select[name=?]', 'issue[tracker_id]', 0
943 943 assert_select 'input[name=?]', 'issue[subject]', 0
944 944 assert_select 'textarea[name=?]', 'issue[description]', 0
945 945 assert_select 'select[name=?]', 'issue[status_id]', 0
946 946 assert_select 'select[name=?]', 'issue[priority_id]', 0
947 947 assert_select 'select[name=?]', 'issue[assigned_to_id]', 0
948 948 assert_select 'select[name=?]', 'issue[category_id]', 0
949 949 assert_select 'select[name=?]', 'issue[fixed_version_id]', 0
950 950 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
951 951 assert_select 'input[name=?]', 'issue[start_date]', 0
952 952 assert_select 'input[name=?]', 'issue[due_date]', 0
953 953 assert_select 'select[name=?]', 'issue[done_ratio]', 0
954 954 assert_select 'input[name=?]', 'issue[custom_field_values][2]', 0
955 955 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
956 956 assert_select 'textarea[name=?]', 'issue[notes]'
957 957 end
958 958 end
959 959
960 960 def test_show_should_display_update_form_with_workflow_permissions
961 961 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
962 962
963 963 @request.session[:user_id] = 2
964 964 get :show, :id => 1
965 965 assert_response :success
966 966
967 967 assert_select 'form#issue-form' do
968 968 assert_select 'input[name=?]', 'issue[is_private]', 0
969 969 assert_select 'select[name=?]', 'issue[project_id]', 0
970 970 assert_select 'select[name=?]', 'issue[tracker_id]', 0
971 971 assert_select 'input[name=?]', 'issue[subject]', 0
972 972 assert_select 'textarea[name=?]', 'issue[description]', 0
973 973 assert_select 'select[name=?]', 'issue[status_id]'
974 974 assert_select 'select[name=?]', 'issue[priority_id]', 0
975 975 assert_select 'select[name=?]', 'issue[assigned_to_id]'
976 976 assert_select 'select[name=?]', 'issue[category_id]', 0
977 977 assert_select 'select[name=?]', 'issue[fixed_version_id]'
978 978 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
979 979 assert_select 'input[name=?]', 'issue[start_date]', 0
980 980 assert_select 'input[name=?]', 'issue[due_date]', 0
981 981 assert_select 'select[name=?]', 'issue[done_ratio]'
982 982 assert_select 'input[name=?]', 'issue[custom_field_values][2]', 0
983 983 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
984 984 assert_select 'textarea[name=?]', 'issue[notes]'
985 985 end
986 986 end
987 987
988 988 def test_show_should_not_display_update_form_without_permissions
989 989 Role.find(1).update_attribute :permissions, [:view_issues]
990 990
991 991 @request.session[:user_id] = 2
992 992 get :show, :id => 1
993 993 assert_response :success
994 994
995 995 assert_select 'form#issue-form', 0
996 996 end
997 997
998 998 def test_update_form_should_not_display_inactive_enumerations
999 999 assert !IssuePriority.find(15).active?
1000 1000
1001 1001 @request.session[:user_id] = 2
1002 1002 get :show, :id => 1
1003 1003 assert_response :success
1004 1004
1005 1005 assert_select 'form#issue-form' do
1006 1006 assert_select 'select[name=?]', 'issue[priority_id]' do
1007 1007 assert_select 'option[value=4]'
1008 1008 assert_select 'option[value=15]', 0
1009 1009 end
1010 1010 end
1011 1011 end
1012 1012
1013 1013 def test_update_form_should_allow_attachment_upload
1014 1014 @request.session[:user_id] = 2
1015 1015 get :show, :id => 1
1016 1016
1017 1017 assert_select 'form#issue-form[method=post][enctype=multipart/form-data]' do
1018 1018 assert_select 'input[type=file][name=?]', 'attachments[dummy][file]'
1019 1019 end
1020 1020 end
1021 1021
1022 1022 def test_show_should_deny_anonymous_access_without_permission
1023 1023 Role.anonymous.remove_permission!(:view_issues)
1024 1024 get :show, :id => 1
1025 1025 assert_response :redirect
1026 1026 end
1027 1027
1028 1028 def test_show_should_deny_anonymous_access_to_private_issue
1029 1029 Issue.update_all(["is_private = ?", true], "id = 1")
1030 1030 get :show, :id => 1
1031 1031 assert_response :redirect
1032 1032 end
1033 1033
1034 1034 def test_show_should_deny_non_member_access_without_permission
1035 1035 Role.non_member.remove_permission!(:view_issues)
1036 1036 @request.session[:user_id] = 9
1037 1037 get :show, :id => 1
1038 1038 assert_response 403
1039 1039 end
1040 1040
1041 1041 def test_show_should_deny_non_member_access_to_private_issue
1042 1042 Issue.update_all(["is_private = ?", true], "id = 1")
1043 1043 @request.session[:user_id] = 9
1044 1044 get :show, :id => 1
1045 1045 assert_response 403
1046 1046 end
1047 1047
1048 1048 def test_show_should_deny_member_access_without_permission
1049 1049 Role.find(1).remove_permission!(:view_issues)
1050 1050 @request.session[:user_id] = 2
1051 1051 get :show, :id => 1
1052 1052 assert_response 403
1053 1053 end
1054 1054
1055 1055 def test_show_should_deny_member_access_to_private_issue_without_permission
1056 1056 Issue.update_all(["is_private = ?", true], "id = 1")
1057 1057 @request.session[:user_id] = 3
1058 1058 get :show, :id => 1
1059 1059 assert_response 403
1060 1060 end
1061 1061
1062 1062 def test_show_should_allow_author_access_to_private_issue
1063 1063 Issue.update_all(["is_private = ?, author_id = 3", true], "id = 1")
1064 1064 @request.session[:user_id] = 3
1065 1065 get :show, :id => 1
1066 1066 assert_response :success
1067 1067 end
1068 1068
1069 1069 def test_show_should_allow_assignee_access_to_private_issue
1070 1070 Issue.update_all(["is_private = ?, assigned_to_id = 3", true], "id = 1")
1071 1071 @request.session[:user_id] = 3
1072 1072 get :show, :id => 1
1073 1073 assert_response :success
1074 1074 end
1075 1075
1076 1076 def test_show_should_allow_member_access_to_private_issue_with_permission
1077 1077 Issue.update_all(["is_private = ?", true], "id = 1")
1078 1078 User.find(3).roles_for_project(Project.find(1)).first.update_attribute :issues_visibility, 'all'
1079 1079 @request.session[:user_id] = 3
1080 1080 get :show, :id => 1
1081 1081 assert_response :success
1082 1082 end
1083 1083
1084 1084 def test_show_should_not_disclose_relations_to_invisible_issues
1085 1085 Setting.cross_project_issue_relations = '1'
1086 1086 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
1087 1087 # Relation to a private project issue
1088 1088 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
1089 1089
1090 1090 get :show, :id => 1
1091 1091 assert_response :success
1092 1092
1093 1093 assert_select 'div#relations' do
1094 1094 assert_select 'a', :text => /#2$/
1095 1095 assert_select 'a', :text => /#4$/, :count => 0
1096 1096 end
1097 1097 end
1098 1098
1099 1099 def test_show_should_list_subtasks
1100 1100 Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
1101 1101
1102 1102 get :show, :id => 1
1103 1103 assert_response :success
1104 1104
1105 1105 assert_select 'div#issue_tree' do
1106 1106 assert_select 'td.subject', :text => /Child Issue/
1107 1107 end
1108 1108 end
1109 1109
1110 1110 def test_show_should_list_parents
1111 1111 issue = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
1112 1112
1113 1113 get :show, :id => issue.id
1114 1114 assert_response :success
1115 1115
1116 1116 assert_select 'div.subject' do
1117 1117 assert_select 'h3', 'Child Issue'
1118 1118 assert_select 'a[href=/issues/1]'
1119 1119 end
1120 1120 end
1121 1121
1122 1122 def test_show_should_not_display_prev_next_links_without_query_in_session
1123 1123 get :show, :id => 1
1124 1124 assert_response :success
1125 1125 assert_nil assigns(:prev_issue_id)
1126 1126 assert_nil assigns(:next_issue_id)
1127 1127
1128 1128 assert_select 'div.next-prev-links', 0
1129 1129 end
1130 1130
1131 1131 def test_show_should_display_prev_next_links_with_query_in_session
1132 1132 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => nil}
1133 1133 @request.session['issues_index_sort'] = 'id'
1134 1134
1135 1135 with_settings :display_subprojects_issues => '0' do
1136 1136 get :show, :id => 3
1137 1137 end
1138 1138
1139 1139 assert_response :success
1140 1140 # Previous and next issues for all projects
1141 1141 assert_equal 2, assigns(:prev_issue_id)
1142 1142 assert_equal 5, assigns(:next_issue_id)
1143 1143
1144 1144 count = Issue.open.visible.count
1145 1145
1146 1146 assert_select 'div.next-prev-links' do
1147 1147 assert_select 'a[href=/issues/2]', :text => /Previous/
1148 1148 assert_select 'a[href=/issues/5]', :text => /Next/
1149 1149 assert_select 'span.position', :text => "3 of #{count}"
1150 1150 end
1151 1151 end
1152 1152
1153 1153 def test_show_should_display_prev_next_links_with_saved_query_in_session
1154 1154 query = IssueQuery.create!(:name => 'test', :visibility => IssueQuery::VISIBILITY_PUBLIC, :user_id => 1,
1155 1155 :filters => {'status_id' => {:values => ['5'], :operator => '='}},
1156 1156 :sort_criteria => [['id', 'asc']])
1157 1157 @request.session[:query] = {:id => query.id, :project_id => nil}
1158 1158
1159 1159 get :show, :id => 11
1160 1160
1161 1161 assert_response :success
1162 1162 assert_equal query, assigns(:query)
1163 1163 # Previous and next issues for all projects
1164 1164 assert_equal 8, assigns(:prev_issue_id)
1165 1165 assert_equal 12, assigns(:next_issue_id)
1166 1166
1167 1167 assert_select 'div.next-prev-links' do
1168 1168 assert_select 'a[href=/issues/8]', :text => /Previous/
1169 1169 assert_select 'a[href=/issues/12]', :text => /Next/
1170 1170 end
1171 1171 end
1172 1172
1173 1173 def test_show_should_display_prev_next_links_with_query_and_sort_on_association
1174 1174 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => nil}
1175 1175
1176 1176 %w(project tracker status priority author assigned_to category fixed_version).each do |assoc_sort|
1177 1177 @request.session['issues_index_sort'] = assoc_sort
1178 1178
1179 1179 get :show, :id => 3
1180 1180 assert_response :success, "Wrong response status for #{assoc_sort} sort"
1181 1181
1182 1182 assert_select 'div.next-prev-links' do
1183 1183 assert_select 'a', :text => /(Previous|Next)/
1184 1184 end
1185 1185 end
1186 1186 end
1187 1187
1188 1188 def test_show_should_display_prev_next_links_with_project_query_in_session
1189 1189 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
1190 1190 @request.session['issues_index_sort'] = 'id'
1191 1191
1192 1192 with_settings :display_subprojects_issues => '0' do
1193 1193 get :show, :id => 3
1194 1194 end
1195 1195
1196 1196 assert_response :success
1197 1197 # Previous and next issues inside project
1198 1198 assert_equal 2, assigns(:prev_issue_id)
1199 1199 assert_equal 7, assigns(:next_issue_id)
1200 1200
1201 1201 assert_select 'div.next-prev-links' do
1202 1202 assert_select 'a[href=/issues/2]', :text => /Previous/
1203 1203 assert_select 'a[href=/issues/7]', :text => /Next/
1204 1204 end
1205 1205 end
1206 1206
1207 1207 def test_show_should_not_display_prev_link_for_first_issue
1208 1208 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
1209 1209 @request.session['issues_index_sort'] = 'id'
1210 1210
1211 1211 with_settings :display_subprojects_issues => '0' do
1212 1212 get :show, :id => 1
1213 1213 end
1214 1214
1215 1215 assert_response :success
1216 1216 assert_nil assigns(:prev_issue_id)
1217 1217 assert_equal 2, assigns(:next_issue_id)
1218 1218
1219 1219 assert_select 'div.next-prev-links' do
1220 1220 assert_select 'a', :text => /Previous/, :count => 0
1221 1221 assert_select 'a[href=/issues/2]', :text => /Next/
1222 1222 end
1223 1223 end
1224 1224
1225 1225 def test_show_should_not_display_prev_next_links_for_issue_not_in_query_results
1226 1226 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'c'}}, :project_id => 1}
1227 1227 @request.session['issues_index_sort'] = 'id'
1228 1228
1229 1229 get :show, :id => 1
1230 1230
1231 1231 assert_response :success
1232 1232 assert_nil assigns(:prev_issue_id)
1233 1233 assert_nil assigns(:next_issue_id)
1234 1234
1235 1235 assert_select 'a', :text => /Previous/, :count => 0
1236 1236 assert_select 'a', :text => /Next/, :count => 0
1237 1237 end
1238 1238
1239 1239 def test_show_show_should_display_prev_next_links_with_query_sort_by_user_custom_field
1240 1240 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
1241 1241 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
1242 1242 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
1243 1243 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
1244 1244 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
1245 1245
1246 1246 query = IssueQuery.create!(:name => 'test', :visibility => IssueQuery::VISIBILITY_PUBLIC, :user_id => 1, :filters => {},
1247 1247 :sort_criteria => [["cf_#{cf.id}", 'asc'], ['id', 'asc']])
1248 1248 @request.session[:query] = {:id => query.id, :project_id => nil}
1249 1249
1250 1250 get :show, :id => 3
1251 1251 assert_response :success
1252 1252
1253 1253 assert_equal 2, assigns(:prev_issue_id)
1254 1254 assert_equal 1, assigns(:next_issue_id)
1255 1255
1256 1256 assert_select 'div.next-prev-links' do
1257 1257 assert_select 'a[href=/issues/2]', :text => /Previous/
1258 1258 assert_select 'a[href=/issues/1]', :text => /Next/
1259 1259 end
1260 1260 end
1261 1261
1262 1262 def test_show_should_display_link_to_the_assignee
1263 1263 get :show, :id => 2
1264 1264 assert_response :success
1265 1265 assert_select '.assigned-to' do
1266 1266 assert_select 'a[href=/users/3]'
1267 1267 end
1268 1268 end
1269 1269
1270 1270 def test_show_should_display_visible_changesets_from_other_projects
1271 1271 project = Project.find(2)
1272 1272 issue = project.issues.first
1273 1273 issue.changeset_ids = [102]
1274 1274 issue.save!
1275 1275 # changesets from other projects should be displayed even if repository
1276 1276 # is disabled on issue's project
1277 1277 project.disable_module! :repository
1278 1278
1279 1279 @request.session[:user_id] = 2
1280 1280 get :show, :id => issue.id
1281 1281
1282 1282 assert_select 'a[href=?]', '/projects/ecookbook/repository/revisions/3'
1283 1283 end
1284 1284
1285 1285 def test_show_should_display_watchers
1286 1286 @request.session[:user_id] = 2
1287 1287 Issue.find(1).add_watcher User.find(2)
1288 1288
1289 1289 get :show, :id => 1
1290 1290 assert_select 'div#watchers ul' do
1291 1291 assert_select 'li' do
1292 1292 assert_select 'a[href=/users/2]'
1293 1293 assert_select 'a img[alt=Delete]'
1294 1294 end
1295 1295 end
1296 1296 end
1297 1297
1298 1298 def test_show_should_display_watchers_with_gravatars
1299 1299 @request.session[:user_id] = 2
1300 1300 Issue.find(1).add_watcher User.find(2)
1301 1301
1302 1302 with_settings :gravatar_enabled => '1' do
1303 1303 get :show, :id => 1
1304 1304 end
1305 1305
1306 1306 assert_select 'div#watchers ul' do
1307 1307 assert_select 'li' do
1308 1308 assert_select 'img.gravatar'
1309 1309 assert_select 'a[href=/users/2]'
1310 1310 assert_select 'a img[alt=Delete]'
1311 1311 end
1312 1312 end
1313 1313 end
1314 1314
1315 1315 def test_show_with_thumbnails_enabled_should_display_thumbnails
1316 1316 @request.session[:user_id] = 2
1317 1317
1318 1318 with_settings :thumbnails_enabled => '1' do
1319 1319 get :show, :id => 14
1320 1320 assert_response :success
1321 1321 end
1322 1322
1323 1323 assert_select 'div.thumbnails' do
1324 1324 assert_select 'a[href=/attachments/16/testfile.png]' do
1325 1325 assert_select 'img[src=/attachments/thumbnail/16]'
1326 1326 end
1327 1327 end
1328 1328 end
1329 1329
1330 1330 def test_show_with_thumbnails_disabled_should_not_display_thumbnails
1331 1331 @request.session[:user_id] = 2
1332 1332
1333 1333 with_settings :thumbnails_enabled => '0' do
1334 1334 get :show, :id => 14
1335 1335 assert_response :success
1336 1336 end
1337 1337
1338 1338 assert_select 'div.thumbnails', 0
1339 1339 end
1340 1340
1341 1341 def test_show_with_multi_custom_field
1342 1342 field = CustomField.find(1)
1343 1343 field.update_attribute :multiple, true
1344 1344 issue = Issue.find(1)
1345 1345 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
1346 1346 issue.save!
1347 1347
1348 1348 get :show, :id => 1
1349 1349 assert_response :success
1350 1350
1351 1351 assert_select 'td', :text => 'MySQL, Oracle'
1352 1352 end
1353 1353
1354 1354 def test_show_with_multi_user_custom_field
1355 1355 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1356 1356 :tracker_ids => [1], :is_for_all => true)
1357 1357 issue = Issue.find(1)
1358 1358 issue.custom_field_values = {field.id => ['2', '3']}
1359 1359 issue.save!
1360 1360
1361 1361 get :show, :id => 1
1362 1362 assert_response :success
1363 1363
1364 1364 # TODO: should display links
1365 1365 assert_select 'td', :text => 'Dave Lopper, John Smith'
1366 1366 end
1367 1367
1368 1368 def test_show_should_display_private_notes_with_permission_only
1369 1369 journal = Journal.create!(:journalized => Issue.find(2), :notes => 'Privates notes', :private_notes => true, :user_id => 1)
1370 1370 @request.session[:user_id] = 2
1371 1371
1372 1372 get :show, :id => 2
1373 1373 assert_response :success
1374 1374 assert_include journal, assigns(:journals)
1375 1375
1376 1376 Role.find(1).remove_permission! :view_private_notes
1377 1377 get :show, :id => 2
1378 1378 assert_response :success
1379 1379 assert_not_include journal, assigns(:journals)
1380 1380 end
1381 1381
1382 1382 def test_show_atom
1383 1383 get :show, :id => 2, :format => 'atom'
1384 1384 assert_response :success
1385 1385 assert_template 'journals/index'
1386 1386 # Inline image
1387 1387 assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10'))
1388 1388 end
1389 1389
1390 1390 def test_show_export_to_pdf
1391 1391 get :show, :id => 3, :format => 'pdf'
1392 1392 assert_response :success
1393 1393 assert_equal 'application/pdf', @response.content_type
1394 1394 assert @response.body.starts_with?('%PDF')
1395 1395 assert_not_nil assigns(:issue)
1396 1396 end
1397 1397
1398 1398 def test_show_export_to_pdf_with_ancestors
1399 1399 issue = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1400 1400
1401 1401 get :show, :id => issue.id, :format => 'pdf'
1402 1402 assert_response :success
1403 1403 assert_equal 'application/pdf', @response.content_type
1404 1404 assert @response.body.starts_with?('%PDF')
1405 1405 end
1406 1406
1407 1407 def test_show_export_to_pdf_with_descendants
1408 1408 c1 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1409 1409 c2 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1410 1410 c3 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => c1.id)
1411 1411
1412 1412 get :show, :id => 1, :format => 'pdf'
1413 1413 assert_response :success
1414 1414 assert_equal 'application/pdf', @response.content_type
1415 1415 assert @response.body.starts_with?('%PDF')
1416 1416 end
1417 1417
1418 1418 def test_show_export_to_pdf_with_journals
1419 1419 get :show, :id => 1, :format => 'pdf'
1420 1420 assert_response :success
1421 1421 assert_equal 'application/pdf', @response.content_type
1422 1422 assert @response.body.starts_with?('%PDF')
1423 1423 end
1424 1424
1425 1425 def test_show_export_to_pdf_with_changesets
1426 1426 Issue.find(3).changesets = Changeset.find_all_by_id(100, 101, 102)
1427 1427
1428 1428 get :show, :id => 3, :format => 'pdf'
1429 1429 assert_response :success
1430 1430 assert_equal 'application/pdf', @response.content_type
1431 1431 assert @response.body.starts_with?('%PDF')
1432 1432 end
1433 1433
1434 1434 def test_show_invalid_should_respond_with_404
1435 1435 get :show, :id => 999
1436 1436 assert_response 404
1437 1437 end
1438 1438
1439 1439 def test_get_new
1440 1440 @request.session[:user_id] = 2
1441 1441 get :new, :project_id => 1, :tracker_id => 1
1442 1442 assert_response :success
1443 1443 assert_template 'new'
1444 1444
1445 1445 assert_select 'form#issue-form' do
1446 1446 assert_select 'input[name=?]', 'issue[is_private]'
1447 1447 assert_select 'select[name=?]', 'issue[project_id]', 0
1448 1448 assert_select 'select[name=?]', 'issue[tracker_id]'
1449 1449 assert_select 'input[name=?]', 'issue[subject]'
1450 1450 assert_select 'textarea[name=?]', 'issue[description]'
1451 1451 assert_select 'select[name=?]', 'issue[status_id]'
1452 1452 assert_select 'select[name=?]', 'issue[priority_id]'
1453 1453 assert_select 'select[name=?]', 'issue[assigned_to_id]'
1454 1454 assert_select 'select[name=?]', 'issue[category_id]'
1455 1455 assert_select 'select[name=?]', 'issue[fixed_version_id]'
1456 1456 assert_select 'input[name=?]', 'issue[parent_issue_id]'
1457 1457 assert_select 'input[name=?]', 'issue[start_date]'
1458 1458 assert_select 'input[name=?]', 'issue[due_date]'
1459 1459 assert_select 'select[name=?]', 'issue[done_ratio]'
1460 1460 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Default string'
1461 1461 assert_select 'input[name=?]', 'issue[watcher_user_ids][]'
1462 1462 end
1463 1463
1464 1464 # Be sure we don't display inactive IssuePriorities
1465 1465 assert ! IssuePriority.find(15).active?
1466 1466 assert_select 'select[name=?]', 'issue[priority_id]' do
1467 1467 assert_select 'option[value=15]', 0
1468 1468 end
1469 1469 end
1470 1470
1471 1471 def test_get_new_with_minimal_permissions
1472 1472 Role.find(1).update_attribute :permissions, [:add_issues]
1473 1473 WorkflowTransition.delete_all :role_id => 1
1474 1474
1475 1475 @request.session[:user_id] = 2
1476 1476 get :new, :project_id => 1, :tracker_id => 1
1477 1477 assert_response :success
1478 1478 assert_template 'new'
1479 1479
1480 1480 assert_select 'form#issue-form' do
1481 1481 assert_select 'input[name=?]', 'issue[is_private]', 0
1482 1482 assert_select 'select[name=?]', 'issue[project_id]', 0
1483 1483 assert_select 'select[name=?]', 'issue[tracker_id]'
1484 1484 assert_select 'input[name=?]', 'issue[subject]'
1485 1485 assert_select 'textarea[name=?]', 'issue[description]'
1486 1486 assert_select 'select[name=?]', 'issue[status_id]'
1487 1487 assert_select 'select[name=?]', 'issue[priority_id]'
1488 1488 assert_select 'select[name=?]', 'issue[assigned_to_id]'
1489 1489 assert_select 'select[name=?]', 'issue[category_id]'
1490 1490 assert_select 'select[name=?]', 'issue[fixed_version_id]'
1491 1491 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
1492 1492 assert_select 'input[name=?]', 'issue[start_date]'
1493 1493 assert_select 'input[name=?]', 'issue[due_date]'
1494 1494 assert_select 'select[name=?]', 'issue[done_ratio]'
1495 1495 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Default string'
1496 1496 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
1497 1497 end
1498 1498 end
1499 1499
1500 1500 def test_get_new_with_list_custom_field
1501 1501 @request.session[:user_id] = 2
1502 1502 get :new, :project_id => 1, :tracker_id => 1
1503 1503 assert_response :success
1504 1504 assert_template 'new'
1505 1505
1506 1506 assert_select 'select.list_cf[name=?]', 'issue[custom_field_values][1]' do
1507 1507 assert_select 'option', 4
1508 1508 assert_select 'option[value=MySQL]', :text => 'MySQL'
1509 1509 end
1510 1510 end
1511 1511
1512 1512 def test_get_new_with_multi_custom_field
1513 1513 field = IssueCustomField.find(1)
1514 1514 field.update_attribute :multiple, true
1515 1515
1516 1516 @request.session[:user_id] = 2
1517 1517 get :new, :project_id => 1, :tracker_id => 1
1518 1518 assert_response :success
1519 1519 assert_template 'new'
1520 1520
1521 1521 assert_select 'select[name=?][multiple=multiple]', 'issue[custom_field_values][1][]' do
1522 1522 assert_select 'option', 3
1523 1523 assert_select 'option[value=MySQL]', :text => 'MySQL'
1524 1524 end
1525 1525 assert_select 'input[name=?][type=hidden][value=?]', 'issue[custom_field_values][1][]', ''
1526 1526 end
1527 1527
1528 1528 def test_get_new_with_multi_user_custom_field
1529 1529 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1530 1530 :tracker_ids => [1], :is_for_all => true)
1531 1531
1532 1532 @request.session[:user_id] = 2
1533 1533 get :new, :project_id => 1, :tracker_id => 1
1534 1534 assert_response :success
1535 1535 assert_template 'new'
1536 1536
1537 1537 assert_select 'select[name=?][multiple=multiple]', "issue[custom_field_values][#{field.id}][]" do
1538 1538 assert_select 'option', Project.find(1).users.count
1539 1539 assert_select 'option[value=2]', :text => 'John Smith'
1540 1540 end
1541 1541 assert_select 'input[name=?][type=hidden][value=?]', "issue[custom_field_values][#{field.id}][]", ''
1542 1542 end
1543 1543
1544 1544 def test_get_new_with_date_custom_field
1545 1545 field = IssueCustomField.create!(:name => 'Date', :field_format => 'date', :tracker_ids => [1], :is_for_all => true)
1546 1546
1547 1547 @request.session[:user_id] = 2
1548 1548 get :new, :project_id => 1, :tracker_id => 1
1549 1549 assert_response :success
1550 1550
1551 1551 assert_select 'input[name=?]', "issue[custom_field_values][#{field.id}]"
1552 1552 end
1553 1553
1554 1554 def test_get_new_with_text_custom_field
1555 1555 field = IssueCustomField.create!(:name => 'Text', :field_format => 'text', :tracker_ids => [1], :is_for_all => true)
1556 1556
1557 1557 @request.session[:user_id] = 2
1558 1558 get :new, :project_id => 1, :tracker_id => 1
1559 1559 assert_response :success
1560 1560
1561 1561 assert_select 'textarea[name=?]', "issue[custom_field_values][#{field.id}]"
1562 1562 end
1563 1563
1564 1564 def test_get_new_without_default_start_date_is_creation_date
1565 1565 with_settings :default_issue_start_date_to_creation_date => 0 do
1566 1566 @request.session[:user_id] = 2
1567 1567 get :new, :project_id => 1, :tracker_id => 1
1568 1568 assert_response :success
1569 1569 assert_template 'new'
1570 1570 assert_select 'input[name=?]', 'issue[start_date]'
1571 1571 assert_select 'input[name=?][value]', 'issue[start_date]', 0
1572 1572 end
1573 1573 end
1574 1574
1575 1575 def test_get_new_with_default_start_date_is_creation_date
1576 1576 with_settings :default_issue_start_date_to_creation_date => 1 do
1577 1577 @request.session[:user_id] = 2
1578 1578 get :new, :project_id => 1, :tracker_id => 1
1579 1579 assert_response :success
1580 1580 assert_template 'new'
1581 1581 assert_select 'input[name=?][value=?]', 'issue[start_date]',
1582 1582 Date.today.to_s
1583 1583 end
1584 1584 end
1585 1585
1586 1586 def test_get_new_form_should_allow_attachment_upload
1587 1587 @request.session[:user_id] = 2
1588 1588 get :new, :project_id => 1, :tracker_id => 1
1589 1589
1590 1590 assert_select 'form[id=issue-form][method=post][enctype=multipart/form-data]' do
1591 1591 assert_select 'input[name=?][type=file]', 'attachments[dummy][file]'
1592 1592 end
1593 1593 end
1594 1594
1595 1595 def test_get_new_should_prefill_the_form_from_params
1596 1596 @request.session[:user_id] = 2
1597 1597 get :new, :project_id => 1,
1598 1598 :issue => {:tracker_id => 3, :description => 'Prefilled', :custom_field_values => {'2' => 'Custom field value'}}
1599 1599
1600 1600 issue = assigns(:issue)
1601 1601 assert_equal 3, issue.tracker_id
1602 1602 assert_equal 'Prefilled', issue.description
1603 1603 assert_equal 'Custom field value', issue.custom_field_value(2)
1604 1604
1605 1605 assert_select 'select[name=?]', 'issue[tracker_id]' do
1606 1606 assert_select 'option[value=3][selected=selected]'
1607 1607 end
1608 1608 assert_select 'textarea[name=?]', 'issue[description]', :text => /Prefilled/
1609 1609 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Custom field value'
1610 1610 end
1611 1611
1612 1612 def test_get_new_should_mark_required_fields
1613 1613 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1614 1614 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1615 1615 WorkflowPermission.delete_all
1616 1616 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'required')
1617 1617 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'required')
1618 1618 @request.session[:user_id] = 2
1619 1619
1620 1620 get :new, :project_id => 1
1621 1621 assert_response :success
1622 1622 assert_template 'new'
1623 1623
1624 1624 assert_select 'label[for=issue_start_date]' do
1625 1625 assert_select 'span[class=required]', 0
1626 1626 end
1627 1627 assert_select 'label[for=issue_due_date]' do
1628 1628 assert_select 'span[class=required]'
1629 1629 end
1630 1630 assert_select 'label[for=?]', "issue_custom_field_values_#{cf1.id}" do
1631 1631 assert_select 'span[class=required]', 0
1632 1632 end
1633 1633 assert_select 'label[for=?]', "issue_custom_field_values_#{cf2.id}" do
1634 1634 assert_select 'span[class=required]'
1635 1635 end
1636 1636 end
1637 1637
1638 1638 def test_get_new_should_not_display_readonly_fields
1639 1639 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1640 1640 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1641 1641 WorkflowPermission.delete_all
1642 1642 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'readonly')
1643 1643 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'readonly')
1644 1644 @request.session[:user_id] = 2
1645 1645
1646 1646 get :new, :project_id => 1
1647 1647 assert_response :success
1648 1648 assert_template 'new'
1649 1649
1650 1650 assert_select 'input[name=?]', 'issue[start_date]'
1651 1651 assert_select 'input[name=?]', 'issue[due_date]', 0
1652 1652 assert_select 'input[name=?]', "issue[custom_field_values][#{cf1.id}]"
1653 1653 assert_select 'input[name=?]', "issue[custom_field_values][#{cf2.id}]", 0
1654 1654 end
1655 1655
1656 1656 def test_get_new_without_tracker_id
1657 1657 @request.session[:user_id] = 2
1658 1658 get :new, :project_id => 1
1659 1659 assert_response :success
1660 1660 assert_template 'new'
1661 1661
1662 1662 issue = assigns(:issue)
1663 1663 assert_not_nil issue
1664 1664 assert_equal Project.find(1).trackers.first, issue.tracker
1665 1665 end
1666 1666
1667 1667 def test_get_new_with_no_default_status_should_display_an_error
1668 1668 @request.session[:user_id] = 2
1669 1669 IssueStatus.delete_all
1670 1670
1671 1671 get :new, :project_id => 1
1672 1672 assert_response 500
1673 1673 assert_error_tag :content => /No default issue/
1674 1674 end
1675 1675
1676 1676 def test_get_new_with_no_tracker_should_display_an_error
1677 1677 @request.session[:user_id] = 2
1678 1678 Tracker.delete_all
1679 1679
1680 1680 get :new, :project_id => 1
1681 1681 assert_response 500
1682 1682 assert_error_tag :content => /No tracker/
1683 1683 end
1684 1684
1685 1685 def test_update_form_for_new_issue
1686 1686 @request.session[:user_id] = 2
1687 1687 xhr :post, :update_form, :project_id => 1,
1688 1688 :issue => {:tracker_id => 2,
1689 1689 :subject => 'This is the test_new issue',
1690 1690 :description => 'This is the description',
1691 1691 :priority_id => 5}
1692 1692 assert_response :success
1693 1693 assert_template 'update_form'
1694 1694 assert_template 'form'
1695 1695 assert_equal 'text/javascript', response.content_type
1696 1696
1697 1697 issue = assigns(:issue)
1698 1698 assert_kind_of Issue, issue
1699 1699 assert_equal 1, issue.project_id
1700 1700 assert_equal 2, issue.tracker_id
1701 1701 assert_equal 'This is the test_new issue', issue.subject
1702 1702 end
1703 1703
1704 1704 def test_update_form_for_new_issue_should_propose_transitions_based_on_initial_status
1705 1705 @request.session[:user_id] = 2
1706 1706 WorkflowTransition.delete_all
1707 1707 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2)
1708 1708 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5)
1709 1709 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 5, :new_status_id => 4)
1710 1710
1711 1711 xhr :post, :update_form, :project_id => 1,
1712 1712 :issue => {:tracker_id => 1,
1713 1713 :status_id => 5,
1714 1714 :subject => 'This is an issue'}
1715 1715
1716 1716 assert_equal 5, assigns(:issue).status_id
1717 1717 assert_equal [1,2,5], assigns(:allowed_statuses).map(&:id).sort
1718 1718 end
1719 1719
1720 1720 def test_post_create
1721 1721 @request.session[:user_id] = 2
1722 1722 assert_difference 'Issue.count' do
1723 1723 post :create, :project_id => 1,
1724 1724 :issue => {:tracker_id => 3,
1725 1725 :status_id => 2,
1726 1726 :subject => 'This is the test_new issue',
1727 1727 :description => 'This is the description',
1728 1728 :priority_id => 5,
1729 1729 :start_date => '2010-11-07',
1730 1730 :estimated_hours => '',
1731 1731 :custom_field_values => {'2' => 'Value for field 2'}}
1732 1732 end
1733 1733 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1734 1734
1735 1735 issue = Issue.find_by_subject('This is the test_new issue')
1736 1736 assert_not_nil issue
1737 1737 assert_equal 2, issue.author_id
1738 1738 assert_equal 3, issue.tracker_id
1739 1739 assert_equal 2, issue.status_id
1740 1740 assert_equal Date.parse('2010-11-07'), issue.start_date
1741 1741 assert_nil issue.estimated_hours
1742 1742 v = issue.custom_values.where(:custom_field_id => 2).first
1743 1743 assert_not_nil v
1744 1744 assert_equal 'Value for field 2', v.value
1745 1745 end
1746 1746
1747 1747 def test_post_new_with_group_assignment
1748 1748 group = Group.find(11)
1749 1749 project = Project.find(1)
1750 1750 project.members << Member.new(:principal => group, :roles => [Role.givable.first])
1751 1751
1752 1752 with_settings :issue_group_assignment => '1' do
1753 1753 @request.session[:user_id] = 2
1754 1754 assert_difference 'Issue.count' do
1755 1755 post :create, :project_id => project.id,
1756 1756 :issue => {:tracker_id => 3,
1757 1757 :status_id => 1,
1758 1758 :subject => 'This is the test_new_with_group_assignment issue',
1759 1759 :assigned_to_id => group.id}
1760 1760 end
1761 1761 end
1762 1762 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1763 1763
1764 1764 issue = Issue.find_by_subject('This is the test_new_with_group_assignment issue')
1765 1765 assert_not_nil issue
1766 1766 assert_equal group, issue.assigned_to
1767 1767 end
1768 1768
1769 1769 def test_post_create_without_start_date_and_default_start_date_is_not_creation_date
1770 1770 with_settings :default_issue_start_date_to_creation_date => 0 do
1771 1771 @request.session[:user_id] = 2
1772 1772 assert_difference 'Issue.count' do
1773 1773 post :create, :project_id => 1,
1774 1774 :issue => {:tracker_id => 3,
1775 1775 :status_id => 2,
1776 1776 :subject => 'This is the test_new issue',
1777 1777 :description => 'This is the description',
1778 1778 :priority_id => 5,
1779 1779 :estimated_hours => '',
1780 1780 :custom_field_values => {'2' => 'Value for field 2'}}
1781 1781 end
1782 1782 assert_redirected_to :controller => 'issues', :action => 'show',
1783 1783 :id => Issue.last.id
1784 1784 issue = Issue.find_by_subject('This is the test_new issue')
1785 1785 assert_not_nil issue
1786 1786 assert_nil issue.start_date
1787 1787 end
1788 1788 end
1789 1789
1790 1790 def test_post_create_without_start_date_and_default_start_date_is_creation_date
1791 1791 with_settings :default_issue_start_date_to_creation_date => 1 do
1792 1792 @request.session[:user_id] = 2
1793 1793 assert_difference 'Issue.count' do
1794 1794 post :create, :project_id => 1,
1795 1795 :issue => {:tracker_id => 3,
1796 1796 :status_id => 2,
1797 1797 :subject => 'This is the test_new issue',
1798 1798 :description => 'This is the description',
1799 1799 :priority_id => 5,
1800 1800 :estimated_hours => '',
1801 1801 :custom_field_values => {'2' => 'Value for field 2'}}
1802 1802 end
1803 1803 assert_redirected_to :controller => 'issues', :action => 'show',
1804 1804 :id => Issue.last.id
1805 1805 issue = Issue.find_by_subject('This is the test_new issue')
1806 1806 assert_not_nil issue
1807 1807 assert_equal Date.today, issue.start_date
1808 1808 end
1809 1809 end
1810 1810
1811 1811 def test_post_create_and_continue
1812 1812 @request.session[:user_id] = 2
1813 1813 assert_difference 'Issue.count' do
1814 1814 post :create, :project_id => 1,
1815 1815 :issue => {:tracker_id => 3, :subject => 'This is first issue', :priority_id => 5},
1816 1816 :continue => ''
1817 1817 end
1818 1818
1819 1819 issue = Issue.first(:order => 'id DESC')
1820 1820 assert_redirected_to :controller => 'issues', :action => 'new', :project_id => 'ecookbook', :issue => {:tracker_id => 3}
1821 1821 assert_not_nil flash[:notice], "flash was not set"
1822 1822 assert_include %|<a href="/issues/#{issue.id}" title="This is first issue">##{issue.id}</a>|, flash[:notice], "issue link not found in the flash message"
1823 1823 end
1824 1824
1825 1825 def test_post_create_without_custom_fields_param
1826 1826 @request.session[:user_id] = 2
1827 1827 assert_difference 'Issue.count' do
1828 1828 post :create, :project_id => 1,
1829 1829 :issue => {:tracker_id => 1,
1830 1830 :subject => 'This is the test_new issue',
1831 1831 :description => 'This is the description',
1832 1832 :priority_id => 5}
1833 1833 end
1834 1834 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1835 1835 end
1836 1836
1837 1837 def test_post_create_with_multi_custom_field
1838 1838 field = IssueCustomField.find_by_name('Database')
1839 1839 field.update_attribute(:multiple, true)
1840 1840
1841 1841 @request.session[:user_id] = 2
1842 1842 assert_difference 'Issue.count' do
1843 1843 post :create, :project_id => 1,
1844 1844 :issue => {:tracker_id => 1,
1845 1845 :subject => 'This is the test_new issue',
1846 1846 :description => 'This is the description',
1847 1847 :priority_id => 5,
1848 1848 :custom_field_values => {'1' => ['', 'MySQL', 'Oracle']}}
1849 1849 end
1850 1850 assert_response 302
1851 1851 issue = Issue.first(:order => 'id DESC')
1852 1852 assert_equal ['MySQL', 'Oracle'], issue.custom_field_value(1).sort
1853 1853 end
1854 1854
1855 1855 def test_post_create_with_empty_multi_custom_field
1856 1856 field = IssueCustomField.find_by_name('Database')
1857 1857 field.update_attribute(:multiple, true)
1858 1858
1859 1859 @request.session[:user_id] = 2
1860 1860 assert_difference 'Issue.count' do
1861 1861 post :create, :project_id => 1,
1862 1862 :issue => {:tracker_id => 1,
1863 1863 :subject => 'This is the test_new issue',
1864 1864 :description => 'This is the description',
1865 1865 :priority_id => 5,
1866 1866 :custom_field_values => {'1' => ['']}}
1867 1867 end
1868 1868 assert_response 302
1869 1869 issue = Issue.first(:order => 'id DESC')
1870 1870 assert_equal [''], issue.custom_field_value(1).sort
1871 1871 end
1872 1872
1873 1873 def test_post_create_with_multi_user_custom_field
1874 1874 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1875 1875 :tracker_ids => [1], :is_for_all => true)
1876 1876
1877 1877 @request.session[:user_id] = 2
1878 1878 assert_difference 'Issue.count' do
1879 1879 post :create, :project_id => 1,
1880 1880 :issue => {:tracker_id => 1,
1881 1881 :subject => 'This is the test_new issue',
1882 1882 :description => 'This is the description',
1883 1883 :priority_id => 5,
1884 1884 :custom_field_values => {field.id.to_s => ['', '2', '3']}}
1885 1885 end
1886 1886 assert_response 302
1887 1887 issue = Issue.first(:order => 'id DESC')
1888 1888 assert_equal ['2', '3'], issue.custom_field_value(field).sort
1889 1889 end
1890 1890
1891 1891 def test_post_create_with_required_custom_field_and_without_custom_fields_param
1892 1892 field = IssueCustomField.find_by_name('Database')
1893 1893 field.update_attribute(:is_required, true)
1894 1894
1895 1895 @request.session[:user_id] = 2
1896 1896 assert_no_difference 'Issue.count' do
1897 1897 post :create, :project_id => 1,
1898 1898 :issue => {:tracker_id => 1,
1899 1899 :subject => 'This is the test_new issue',
1900 1900 :description => 'This is the description',
1901 1901 :priority_id => 5}
1902 1902 end
1903 1903 assert_response :success
1904 1904 assert_template 'new'
1905 1905 issue = assigns(:issue)
1906 1906 assert_not_nil issue
1907 1907 assert_error_tag :content => /Database can&#x27;t be blank/
1908 1908 end
1909 1909
1910 1910 def test_create_should_validate_required_fields
1911 1911 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1912 1912 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1913 1913 WorkflowPermission.delete_all
1914 1914 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => 'due_date', :rule => 'required')
1915 1915 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'required')
1916 1916 @request.session[:user_id] = 2
1917 1917
1918 1918 assert_no_difference 'Issue.count' do
1919 1919 post :create, :project_id => 1, :issue => {
1920 1920 :tracker_id => 2,
1921 1921 :status_id => 1,
1922 1922 :subject => 'Test',
1923 1923 :start_date => '',
1924 1924 :due_date => '',
1925 1925 :custom_field_values => {cf1.id.to_s => '', cf2.id.to_s => ''}
1926 1926 }
1927 1927 assert_response :success
1928 1928 assert_template 'new'
1929 1929 end
1930 1930
1931 1931 assert_error_tag :content => /Due date can&#x27;t be blank/i
1932 1932 assert_error_tag :content => /Bar can&#x27;t be blank/i
1933 1933 end
1934 1934
1935 1935 def test_create_should_ignore_readonly_fields
1936 1936 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1937 1937 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1938 1938 WorkflowPermission.delete_all
1939 1939 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => 'due_date', :rule => 'readonly')
1940 1940 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'readonly')
1941 1941 @request.session[:user_id] = 2
1942 1942
1943 1943 assert_difference 'Issue.count' do
1944 1944 post :create, :project_id => 1, :issue => {
1945 1945 :tracker_id => 2,
1946 1946 :status_id => 1,
1947 1947 :subject => 'Test',
1948 1948 :start_date => '2012-07-14',
1949 1949 :due_date => '2012-07-16',
1950 1950 :custom_field_values => {cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'}
1951 1951 }
1952 1952 assert_response 302
1953 1953 end
1954 1954
1955 1955 issue = Issue.first(:order => 'id DESC')
1956 1956 assert_equal Date.parse('2012-07-14'), issue.start_date
1957 1957 assert_nil issue.due_date
1958 1958 assert_equal 'value1', issue.custom_field_value(cf1)
1959 1959 assert_nil issue.custom_field_value(cf2)
1960 1960 end
1961 1961
1962 1962 def test_post_create_with_watchers
1963 1963 @request.session[:user_id] = 2
1964 1964 ActionMailer::Base.deliveries.clear
1965 1965
1966 1966 assert_difference 'Watcher.count', 2 do
1967 1967 post :create, :project_id => 1,
1968 1968 :issue => {:tracker_id => 1,
1969 1969 :subject => 'This is a new issue with watchers',
1970 1970 :description => 'This is the description',
1971 1971 :priority_id => 5,
1972 1972 :watcher_user_ids => ['2', '3']}
1973 1973 end
1974 1974 issue = Issue.find_by_subject('This is a new issue with watchers')
1975 1975 assert_not_nil issue
1976 1976 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
1977 1977
1978 1978 # Watchers added
1979 1979 assert_equal [2, 3], issue.watcher_user_ids.sort
1980 1980 assert issue.watched_by?(User.find(3))
1981 1981 # Watchers notified
1982 1982 mail = ActionMailer::Base.deliveries.last
1983 1983 assert_not_nil mail
1984 1984 assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
1985 1985 end
1986 1986
1987 1987 def test_post_create_subissue
1988 1988 @request.session[:user_id] = 2
1989 1989
1990 1990 assert_difference 'Issue.count' do
1991 1991 post :create, :project_id => 1,
1992 1992 :issue => {:tracker_id => 1,
1993 1993 :subject => 'This is a child issue',
1994 1994 :parent_issue_id => '2'}
1995 1995 assert_response 302
1996 1996 end
1997 1997 issue = Issue.order('id DESC').first
1998 1998 assert_equal Issue.find(2), issue.parent
1999 1999 end
2000 2000
2001 2001 def test_post_create_subissue_with_sharp_parent_id
2002 2002 @request.session[:user_id] = 2
2003 2003
2004 2004 assert_difference 'Issue.count' do
2005 2005 post :create, :project_id => 1,
2006 2006 :issue => {:tracker_id => 1,
2007 2007 :subject => 'This is a child issue',
2008 2008 :parent_issue_id => '#2'}
2009 2009 assert_response 302
2010 2010 end
2011 2011 issue = Issue.order('id DESC').first
2012 2012 assert_equal Issue.find(2), issue.parent
2013 2013 end
2014 2014
2015 2015 def test_post_create_subissue_with_non_visible_parent_id_should_not_validate
2016 2016 @request.session[:user_id] = 2
2017 2017
2018 2018 assert_no_difference 'Issue.count' do
2019 2019 post :create, :project_id => 1,
2020 2020 :issue => {:tracker_id => 1,
2021 2021 :subject => 'This is a child issue',
2022 2022 :parent_issue_id => '4'}
2023 2023
2024 2024 assert_response :success
2025 2025 assert_select 'input[name=?][value=?]', 'issue[parent_issue_id]', '4'
2026 2026 assert_error_tag :content => /Parent task is invalid/i
2027 2027 end
2028 2028 end
2029 2029
2030 2030 def test_post_create_subissue_with_non_numeric_parent_id_should_not_validate
2031 2031 @request.session[:user_id] = 2
2032 2032
2033 2033 assert_no_difference 'Issue.count' do
2034 2034 post :create, :project_id => 1,
2035 2035 :issue => {:tracker_id => 1,
2036 2036 :subject => 'This is a child issue',
2037 2037 :parent_issue_id => '01ABC'}
2038 2038
2039 2039 assert_response :success
2040 2040 assert_select 'input[name=?][value=?]', 'issue[parent_issue_id]', '01ABC'
2041 2041 assert_error_tag :content => /Parent task is invalid/i
2042 2042 end
2043 2043 end
2044 2044
2045 2045 def test_post_create_private
2046 2046 @request.session[:user_id] = 2
2047 2047
2048 2048 assert_difference 'Issue.count' do
2049 2049 post :create, :project_id => 1,
2050 2050 :issue => {:tracker_id => 1,
2051 2051 :subject => 'This is a private issue',
2052 2052 :is_private => '1'}
2053 2053 end
2054 2054 issue = Issue.first(:order => 'id DESC')
2055 2055 assert issue.is_private?
2056 2056 end
2057 2057
2058 2058 def test_post_create_private_with_set_own_issues_private_permission
2059 2059 role = Role.find(1)
2060 2060 role.remove_permission! :set_issues_private
2061 2061 role.add_permission! :set_own_issues_private
2062 2062
2063 2063 @request.session[:user_id] = 2
2064 2064
2065 2065 assert_difference 'Issue.count' do
2066 2066 post :create, :project_id => 1,
2067 2067 :issue => {:tracker_id => 1,
2068 2068 :subject => 'This is a private issue',
2069 2069 :is_private => '1'}
2070 2070 end
2071 2071 issue = Issue.first(:order => 'id DESC')
2072 2072 assert issue.is_private?
2073 2073 end
2074 2074
2075 2075 def test_post_create_should_send_a_notification
2076 2076 ActionMailer::Base.deliveries.clear
2077 2077 @request.session[:user_id] = 2
2078 2078 assert_difference 'Issue.count' do
2079 2079 post :create, :project_id => 1,
2080 2080 :issue => {:tracker_id => 3,
2081 2081 :subject => 'This is the test_new issue',
2082 2082 :description => 'This is the description',
2083 2083 :priority_id => 5,
2084 2084 :estimated_hours => '',
2085 2085 :custom_field_values => {'2' => 'Value for field 2'}}
2086 2086 end
2087 2087 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
2088 2088
2089 2089 assert_equal 1, ActionMailer::Base.deliveries.size
2090 2090 end
2091 2091
2092 2092 def test_post_create_should_preserve_fields_values_on_validation_failure
2093 2093 @request.session[:user_id] = 2
2094 2094 post :create, :project_id => 1,
2095 2095 :issue => {:tracker_id => 1,
2096 2096 # empty subject
2097 2097 :subject => '',
2098 2098 :description => 'This is a description',
2099 2099 :priority_id => 6,
2100 2100 :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
2101 2101 assert_response :success
2102 2102 assert_template 'new'
2103 2103
2104 2104 assert_select 'textarea[name=?]', 'issue[description]', :text => 'This is a description'
2105 2105 assert_select 'select[name=?]', 'issue[priority_id]' do
2106 2106 assert_select 'option[value=6][selected=selected]', :text => 'High'
2107 2107 end
2108 2108 # Custom fields
2109 2109 assert_select 'select[name=?]', 'issue[custom_field_values][1]' do
2110 2110 assert_select 'option[value=Oracle][selected=selected]', :text => 'Oracle'
2111 2111 end
2112 2112 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Value for field 2'
2113 2113 end
2114 2114
2115 2115 def test_post_create_with_failure_should_preserve_watchers
2116 2116 assert !User.find(8).member_of?(Project.find(1))
2117 2117
2118 2118 @request.session[:user_id] = 2
2119 2119 post :create, :project_id => 1,
2120 2120 :issue => {:tracker_id => 1,
2121 2121 :watcher_user_ids => ['3', '8']}
2122 2122 assert_response :success
2123 2123 assert_template 'new'
2124 2124
2125 2125 assert_select 'input[name=?][value=2]:not(checked)', 'issue[watcher_user_ids][]'
2126 2126 assert_select 'input[name=?][value=3][checked=checked]', 'issue[watcher_user_ids][]'
2127 2127 assert_select 'input[name=?][value=8][checked=checked]', 'issue[watcher_user_ids][]'
2128 2128 end
2129 2129
2130 2130 def test_post_create_should_ignore_non_safe_attributes
2131 2131 @request.session[:user_id] = 2
2132 2132 assert_nothing_raised do
2133 2133 post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
2134 2134 end
2135 2135 end
2136 2136
2137 2137 def test_post_create_with_attachment
2138 2138 set_tmp_attachments_directory
2139 2139 @request.session[:user_id] = 2
2140 2140
2141 2141 assert_difference 'Issue.count' do
2142 2142 assert_difference 'Attachment.count' do
2143 2143 post :create, :project_id => 1,
2144 2144 :issue => { :tracker_id => '1', :subject => 'With attachment' },
2145 2145 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2146 2146 end
2147 2147 end
2148 2148
2149 2149 issue = Issue.first(:order => 'id DESC')
2150 2150 attachment = Attachment.first(:order => 'id DESC')
2151 2151
2152 2152 assert_equal issue, attachment.container
2153 2153 assert_equal 2, attachment.author_id
2154 2154 assert_equal 'testfile.txt', attachment.filename
2155 2155 assert_equal 'text/plain', attachment.content_type
2156 2156 assert_equal 'test file', attachment.description
2157 2157 assert_equal 59, attachment.filesize
2158 2158 assert File.exists?(attachment.diskfile)
2159 2159 assert_equal 59, File.size(attachment.diskfile)
2160 2160 end
2161 2161
2162 2162 def test_post_create_with_attachment_should_notify_with_attachments
2163 2163 ActionMailer::Base.deliveries.clear
2164 2164 set_tmp_attachments_directory
2165 2165 @request.session[:user_id] = 2
2166 2166
2167 2167 with_settings :host_name => 'mydomain.foo', :protocol => 'http' do
2168 2168 assert_difference 'Issue.count' do
2169 2169 post :create, :project_id => 1,
2170 2170 :issue => { :tracker_id => '1', :subject => 'With attachment' },
2171 2171 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2172 2172 end
2173 2173 end
2174 2174
2175 2175 assert_not_nil ActionMailer::Base.deliveries.last
2176 2176 assert_select_email do
2177 2177 assert_select 'a[href^=?]', 'http://mydomain.foo/attachments/download', 'testfile.txt'
2178 2178 end
2179 2179 end
2180 2180
2181 2181 def test_post_create_with_failure_should_save_attachments
2182 2182 set_tmp_attachments_directory
2183 2183 @request.session[:user_id] = 2
2184 2184
2185 2185 assert_no_difference 'Issue.count' do
2186 2186 assert_difference 'Attachment.count' do
2187 2187 post :create, :project_id => 1,
2188 2188 :issue => { :tracker_id => '1', :subject => '' },
2189 2189 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2190 2190 assert_response :success
2191 2191 assert_template 'new'
2192 2192 end
2193 2193 end
2194 2194
2195 2195 attachment = Attachment.first(:order => 'id DESC')
2196 2196 assert_equal 'testfile.txt', attachment.filename
2197 2197 assert File.exists?(attachment.diskfile)
2198 2198 assert_nil attachment.container
2199 2199
2200 2200 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
2201 2201 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
2202 2202 end
2203 2203
2204 2204 def test_post_create_with_failure_should_keep_saved_attachments
2205 2205 set_tmp_attachments_directory
2206 2206 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2207 2207 @request.session[:user_id] = 2
2208 2208
2209 2209 assert_no_difference 'Issue.count' do
2210 2210 assert_no_difference 'Attachment.count' do
2211 2211 post :create, :project_id => 1,
2212 2212 :issue => { :tracker_id => '1', :subject => '' },
2213 2213 :attachments => {'p0' => {'token' => attachment.token}}
2214 2214 assert_response :success
2215 2215 assert_template 'new'
2216 2216 end
2217 2217 end
2218 2218
2219 2219 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
2220 2220 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
2221 2221 end
2222 2222
2223 2223 def test_post_create_should_attach_saved_attachments
2224 2224 set_tmp_attachments_directory
2225 2225 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2226 2226 @request.session[:user_id] = 2
2227 2227
2228 2228 assert_difference 'Issue.count' do
2229 2229 assert_no_difference 'Attachment.count' do
2230 2230 post :create, :project_id => 1,
2231 2231 :issue => { :tracker_id => '1', :subject => 'Saved attachments' },
2232 2232 :attachments => {'p0' => {'token' => attachment.token}}
2233 2233 assert_response 302
2234 2234 end
2235 2235 end
2236 2236
2237 2237 issue = Issue.first(:order => 'id DESC')
2238 2238 assert_equal 1, issue.attachments.count
2239 2239
2240 2240 attachment.reload
2241 2241 assert_equal issue, attachment.container
2242 2242 end
2243 2243
2244 2244 context "without workflow privilege" do
2245 2245 setup do
2246 2246 WorkflowTransition.delete_all(["role_id = ?", Role.anonymous.id])
2247 2247 Role.anonymous.add_permission! :add_issues, :add_issue_notes
2248 2248 end
2249 2249
2250 2250 context "#new" do
2251 2251 should "propose default status only" do
2252 2252 get :new, :project_id => 1
2253 2253 assert_response :success
2254 2254 assert_template 'new'
2255 2255 assert_select 'select[name=?]', 'issue[status_id]' do
2256 2256 assert_select 'option', 1
2257 2257 assert_select 'option[value=?]', IssueStatus.default.id.to_s
2258 2258 end
2259 2259 end
2260 2260
2261 2261 should "accept default status" do
2262 2262 assert_difference 'Issue.count' do
2263 2263 post :create, :project_id => 1,
2264 2264 :issue => {:tracker_id => 1,
2265 2265 :subject => 'This is an issue',
2266 2266 :status_id => 1}
2267 2267 end
2268 2268 issue = Issue.last(:order => 'id')
2269 2269 assert_equal IssueStatus.default, issue.status
2270 2270 end
2271 2271
2272 2272 should "ignore unauthorized status" do
2273 2273 assert_difference 'Issue.count' do
2274 2274 post :create, :project_id => 1,
2275 2275 :issue => {:tracker_id => 1,
2276 2276 :subject => 'This is an issue',
2277 2277 :status_id => 3}
2278 2278 end
2279 2279 issue = Issue.last(:order => 'id')
2280 2280 assert_equal IssueStatus.default, issue.status
2281 2281 end
2282 2282 end
2283 2283
2284 2284 context "#update" do
2285 2285 should "ignore status change" do
2286 2286 assert_difference 'Journal.count' do
2287 2287 put :update, :id => 1, :issue => {:status_id => 3, :notes => 'just trying'}
2288 2288 end
2289 2289 assert_equal 1, Issue.find(1).status_id
2290 2290 end
2291 2291
2292 2292 should "ignore attributes changes" do
2293 2293 assert_difference 'Journal.count' do
2294 2294 put :update, :id => 1, :issue => {:subject => 'changed', :assigned_to_id => 2, :notes => 'just trying'}
2295 2295 end
2296 2296 issue = Issue.find(1)
2297 2297 assert_equal "Can't print recipes", issue.subject
2298 2298 assert_nil issue.assigned_to
2299 2299 end
2300 2300 end
2301 2301 end
2302 2302
2303 2303 context "with workflow privilege" do
2304 2304 setup do
2305 2305 WorkflowTransition.delete_all(["role_id = ?", Role.anonymous.id])
2306 2306 WorkflowTransition.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
2307 2307 WorkflowTransition.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
2308 2308 Role.anonymous.add_permission! :add_issues, :add_issue_notes
2309 2309 end
2310 2310
2311 2311 context "#update" do
2312 2312 should "accept authorized status" do
2313 2313 assert_difference 'Journal.count' do
2314 2314 put :update, :id => 1, :issue => {:status_id => 3, :notes => 'just trying'}
2315 2315 end
2316 2316 assert_equal 3, Issue.find(1).status_id
2317 2317 end
2318 2318
2319 2319 should "ignore unauthorized status" do
2320 2320 assert_difference 'Journal.count' do
2321 2321 put :update, :id => 1, :issue => {:status_id => 2, :notes => 'just trying'}
2322 2322 end
2323 2323 assert_equal 1, Issue.find(1).status_id
2324 2324 end
2325 2325
2326 2326 should "accept authorized attributes changes" do
2327 2327 assert_difference 'Journal.count' do
2328 2328 put :update, :id => 1, :issue => {:assigned_to_id => 2, :notes => 'just trying'}
2329 2329 end
2330 2330 issue = Issue.find(1)
2331 2331 assert_equal 2, issue.assigned_to_id
2332 2332 end
2333 2333
2334 2334 should "ignore unauthorized attributes changes" do
2335 2335 assert_difference 'Journal.count' do
2336 2336 put :update, :id => 1, :issue => {:subject => 'changed', :notes => 'just trying'}
2337 2337 end
2338 2338 issue = Issue.find(1)
2339 2339 assert_equal "Can't print recipes", issue.subject
2340 2340 end
2341 2341 end
2342 2342
2343 2343 context "and :edit_issues permission" do
2344 2344 setup do
2345 2345 Role.anonymous.add_permission! :add_issues, :edit_issues
2346 2346 end
2347 2347
2348 2348 should "accept authorized status" do
2349 2349 assert_difference 'Journal.count' do
2350 2350 put :update, :id => 1, :issue => {:status_id => 3, :notes => 'just trying'}
2351 2351 end
2352 2352 assert_equal 3, Issue.find(1).status_id
2353 2353 end
2354 2354
2355 2355 should "ignore unauthorized status" do
2356 2356 assert_difference 'Journal.count' do
2357 2357 put :update, :id => 1, :issue => {:status_id => 2, :notes => 'just trying'}
2358 2358 end
2359 2359 assert_equal 1, Issue.find(1).status_id
2360 2360 end
2361 2361
2362 2362 should "accept authorized attributes changes" do
2363 2363 assert_difference 'Journal.count' do
2364 2364 put :update, :id => 1, :issue => {:subject => 'changed', :assigned_to_id => 2, :notes => 'just trying'}
2365 2365 end
2366 2366 issue = Issue.find(1)
2367 2367 assert_equal "changed", issue.subject
2368 2368 assert_equal 2, issue.assigned_to_id
2369 2369 end
2370 2370 end
2371 2371 end
2372 2372
2373 2373 def test_new_as_copy
2374 2374 @request.session[:user_id] = 2
2375 2375 get :new, :project_id => 1, :copy_from => 1
2376 2376
2377 2377 assert_response :success
2378 2378 assert_template 'new'
2379 2379
2380 2380 assert_not_nil assigns(:issue)
2381 2381 orig = Issue.find(1)
2382 2382 assert_equal 1, assigns(:issue).project_id
2383 2383 assert_equal orig.subject, assigns(:issue).subject
2384 2384 assert assigns(:issue).copy?
2385 2385
2386 2386 assert_select 'form[id=issue-form][action=/projects/ecookbook/issues]' do
2387 2387 assert_select 'select[name=?]', 'issue[project_id]' do
2388 2388 assert_select 'option[value=1][selected=selected]', :text => 'eCookbook'
2389 2389 assert_select 'option[value=2]:not([selected])', :text => 'OnlineStore'
2390 2390 end
2391 2391 assert_select 'input[name=copy_from][value=1]'
2392 2392 end
2393 2393
2394 2394 # "New issue" menu item should not link to copy
2395 2395 assert_select '#main-menu a.new-issue[href=/projects/ecookbook/issues/new]'
2396 2396 end
2397 2397
2398 2398 def test_new_as_copy_with_attachments_should_show_copy_attachments_checkbox
2399 2399 @request.session[:user_id] = 2
2400 2400 issue = Issue.find(3)
2401 2401 assert issue.attachments.count > 0
2402 2402 get :new, :project_id => 1, :copy_from => 3
2403 2403
2404 2404 assert_select 'input[name=copy_attachments][type=checkbox][checked=checked][value=1]'
2405 2405 end
2406 2406
2407 2407 def test_new_as_copy_without_attachments_should_not_show_copy_attachments_checkbox
2408 2408 @request.session[:user_id] = 2
2409 2409 issue = Issue.find(3)
2410 2410 issue.attachments.delete_all
2411 2411 get :new, :project_id => 1, :copy_from => 3
2412 2412
2413 2413 assert_select 'input[name=copy_attachments]', 0
2414 2414 end
2415 2415
2416 2416 def test_new_as_copy_with_subtasks_should_show_copy_subtasks_checkbox
2417 2417 @request.session[:user_id] = 2
2418 2418 issue = Issue.generate_with_descendants!
2419 2419 get :new, :project_id => 1, :copy_from => issue.id
2420 2420
2421 2421 assert_select 'input[type=checkbox][name=copy_subtasks][checked=checked][value=1]'
2422 2422 end
2423 2423
2424 2424 def test_new_as_copy_with_invalid_issue_should_respond_with_404
2425 2425 @request.session[:user_id] = 2
2426 2426 get :new, :project_id => 1, :copy_from => 99999
2427 2427 assert_response 404
2428 2428 end
2429 2429
2430 2430 def test_create_as_copy_on_different_project
2431 2431 @request.session[:user_id] = 2
2432 2432 assert_difference 'Issue.count' do
2433 2433 post :create, :project_id => 1, :copy_from => 1,
2434 2434 :issue => {:project_id => '2', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
2435 2435
2436 2436 assert_not_nil assigns(:issue)
2437 2437 assert assigns(:issue).copy?
2438 2438 end
2439 2439 issue = Issue.first(:order => 'id DESC')
2440 2440 assert_redirected_to "/issues/#{issue.id}"
2441 2441
2442 2442 assert_equal 2, issue.project_id
2443 2443 assert_equal 3, issue.tracker_id
2444 2444 assert_equal 'Copy', issue.subject
2445 2445 end
2446 2446
2447 2447 def test_create_as_copy_should_copy_attachments
2448 2448 @request.session[:user_id] = 2
2449 2449 issue = Issue.find(3)
2450 2450 count = issue.attachments.count
2451 2451 assert count > 0
2452 2452 assert_difference 'Issue.count' do
2453 2453 assert_difference 'Attachment.count', count do
2454 2454 assert_difference 'Journal.count', 2 do
2455 2455 post :create, :project_id => 1, :copy_from => 3,
2456 2456 :issue => {:project_id => '1', :tracker_id => '3',
2457 2457 :status_id => '1', :subject => 'Copy with attachments'},
2458 2458 :copy_attachments => '1'
2459 2459 end
2460 2460 end
2461 2461 end
2462 2462 copy = Issue.first(:order => 'id DESC')
2463 2463 assert_equal count, copy.attachments.count
2464 2464 assert_equal issue.attachments.map(&:filename).sort, copy.attachments.map(&:filename).sort
2465 2465 end
2466 2466
2467 2467 def test_create_as_copy_without_copy_attachments_option_should_not_copy_attachments
2468 2468 @request.session[:user_id] = 2
2469 2469 issue = Issue.find(3)
2470 2470 count = issue.attachments.count
2471 2471 assert count > 0
2472 2472 assert_difference 'Issue.count' do
2473 2473 assert_no_difference 'Attachment.count' do
2474 2474 assert_difference 'Journal.count', 2 do
2475 2475 post :create, :project_id => 1, :copy_from => 3,
2476 2476 :issue => {:project_id => '1', :tracker_id => '3',
2477 2477 :status_id => '1', :subject => 'Copy with attachments'}
2478 2478 end
2479 2479 end
2480 2480 end
2481 2481 copy = Issue.first(:order => 'id DESC')
2482 2482 assert_equal 0, copy.attachments.count
2483 2483 end
2484 2484
2485 2485 def test_create_as_copy_with_attachments_should_add_new_files
2486 2486 @request.session[:user_id] = 2
2487 2487 issue = Issue.find(3)
2488 2488 count = issue.attachments.count
2489 2489 assert count > 0
2490 2490 assert_difference 'Issue.count' do
2491 2491 assert_difference 'Attachment.count', count + 1 do
2492 2492 assert_difference 'Journal.count', 2 do
2493 2493 post :create, :project_id => 1, :copy_from => 3,
2494 2494 :issue => {:project_id => '1', :tracker_id => '3',
2495 2495 :status_id => '1', :subject => 'Copy with attachments'},
2496 2496 :copy_attachments => '1',
2497 2497 :attachments => {'1' =>
2498 2498 {'file' => uploaded_test_file('testfile.txt', 'text/plain'),
2499 2499 'description' => 'test file'}}
2500 2500 end
2501 2501 end
2502 2502 end
2503 2503 copy = Issue.first(:order => 'id DESC')
2504 2504 assert_equal count + 1, copy.attachments.count
2505 2505 end
2506 2506
2507 2507 def test_create_as_copy_should_add_relation_with_copied_issue
2508 2508 @request.session[:user_id] = 2
2509 2509 assert_difference 'Issue.count' do
2510 2510 assert_difference 'IssueRelation.count' do
2511 2511 post :create, :project_id => 1, :copy_from => 1,
2512 2512 :issue => {:project_id => '1', :tracker_id => '3',
2513 2513 :status_id => '1', :subject => 'Copy'}
2514 2514 end
2515 2515 end
2516 2516 copy = Issue.first(:order => 'id DESC')
2517 2517 assert_equal 1, copy.relations.size
2518 2518 end
2519 2519
2520 2520 def test_create_as_copy_should_copy_subtasks
2521 2521 @request.session[:user_id] = 2
2522 2522 issue = Issue.generate_with_descendants!
2523 2523 count = issue.descendants.count
2524 2524 assert_difference 'Issue.count', count + 1 do
2525 2525 assert_difference 'Journal.count', (count + 1) * 2 do
2526 2526 post :create, :project_id => 1, :copy_from => issue.id,
2527 2527 :issue => {:project_id => '1', :tracker_id => '3',
2528 2528 :status_id => '1', :subject => 'Copy with subtasks'},
2529 2529 :copy_subtasks => '1'
2530 2530 end
2531 2531 end
2532 2532 copy = Issue.where(:parent_id => nil).first(:order => 'id DESC')
2533 2533 assert_equal count, copy.descendants.count
2534 2534 assert_equal issue.descendants.map(&:subject).sort, copy.descendants.map(&:subject).sort
2535 2535 end
2536 2536
2537 2537 def test_create_as_copy_without_copy_subtasks_option_should_not_copy_subtasks
2538 2538 @request.session[:user_id] = 2
2539 2539 issue = Issue.generate_with_descendants!
2540 2540 assert_difference 'Issue.count', 1 do
2541 2541 assert_difference 'Journal.count', 2 do
2542 2542 post :create, :project_id => 1, :copy_from => 3,
2543 2543 :issue => {:project_id => '1', :tracker_id => '3',
2544 2544 :status_id => '1', :subject => 'Copy with subtasks'}
2545 2545 end
2546 2546 end
2547 2547 copy = Issue.where(:parent_id => nil).first(:order => 'id DESC')
2548 2548 assert_equal 0, copy.descendants.count
2549 2549 end
2550 2550
2551 2551 def test_create_as_copy_with_failure
2552 2552 @request.session[:user_id] = 2
2553 2553 post :create, :project_id => 1, :copy_from => 1,
2554 2554 :issue => {:project_id => '2', :tracker_id => '3', :status_id => '1', :subject => ''}
2555 2555
2556 2556 assert_response :success
2557 2557 assert_template 'new'
2558 2558
2559 2559 assert_not_nil assigns(:issue)
2560 2560 assert assigns(:issue).copy?
2561 2561
2562 2562 assert_select 'form#issue-form[action=/projects/ecookbook/issues]' do
2563 2563 assert_select 'select[name=?]', 'issue[project_id]' do
2564 2564 assert_select 'option[value=1]:not([selected])', :text => 'eCookbook'
2565 2565 assert_select 'option[value=2][selected=selected]', :text => 'OnlineStore'
2566 2566 end
2567 2567 assert_select 'input[name=copy_from][value=1]'
2568 2568 end
2569 2569 end
2570 2570
2571 2571 def test_create_as_copy_on_project_without_permission_should_ignore_target_project
2572 2572 @request.session[:user_id] = 2
2573 2573 assert !User.find(2).member_of?(Project.find(4))
2574 2574
2575 2575 assert_difference 'Issue.count' do
2576 2576 post :create, :project_id => 1, :copy_from => 1,
2577 2577 :issue => {:project_id => '4', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
2578 2578 end
2579 2579 issue = Issue.first(:order => 'id DESC')
2580 2580 assert_equal 1, issue.project_id
2581 2581 end
2582 2582
2583 2583 def test_get_edit
2584 2584 @request.session[:user_id] = 2
2585 2585 get :edit, :id => 1
2586 2586 assert_response :success
2587 2587 assert_template 'edit'
2588 2588 assert_not_nil assigns(:issue)
2589 2589 assert_equal Issue.find(1), assigns(:issue)
2590 2590
2591 2591 # Be sure we don't display inactive IssuePriorities
2592 2592 assert ! IssuePriority.find(15).active?
2593 2593 assert_select 'select[name=?]', 'issue[priority_id]' do
2594 2594 assert_select 'option[value=15]', 0
2595 2595 end
2596 2596 end
2597 2597
2598 2598 def test_get_edit_should_display_the_time_entry_form_with_log_time_permission
2599 2599 @request.session[:user_id] = 2
2600 2600 Role.find_by_name('Manager').update_attribute :permissions, [:view_issues, :edit_issues, :log_time]
2601 2601
2602 2602 get :edit, :id => 1
2603 2603 assert_select 'input[name=?]', 'time_entry[hours]'
2604 2604 end
2605 2605
2606 2606 def test_get_edit_should_not_display_the_time_entry_form_without_log_time_permission
2607 2607 @request.session[:user_id] = 2
2608 2608 Role.find_by_name('Manager').remove_permission! :log_time
2609 2609
2610 2610 get :edit, :id => 1
2611 2611 assert_select 'input[name=?]', 'time_entry[hours]', 0
2612 2612 end
2613 2613
2614 2614 def test_get_edit_with_params
2615 2615 @request.session[:user_id] = 2
2616 2616 get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 },
2617 2617 :time_entry => { :hours => '2.5', :comments => 'test_get_edit_with_params', :activity_id => 10 }
2618 2618 assert_response :success
2619 2619 assert_template 'edit'
2620 2620
2621 2621 issue = assigns(:issue)
2622 2622 assert_not_nil issue
2623 2623
2624 2624 assert_equal 5, issue.status_id
2625 2625 assert_select 'select[name=?]', 'issue[status_id]' do
2626 2626 assert_select 'option[value=5][selected=selected]', :text => 'Closed'
2627 2627 end
2628 2628
2629 2629 assert_equal 7, issue.priority_id
2630 2630 assert_select 'select[name=?]', 'issue[priority_id]' do
2631 2631 assert_select 'option[value=7][selected=selected]', :text => 'Urgent'
2632 2632 end
2633 2633
2634 2634 assert_select 'input[name=?][value=2.5]', 'time_entry[hours]'
2635 2635 assert_select 'select[name=?]', 'time_entry[activity_id]' do
2636 2636 assert_select 'option[value=10][selected=selected]', :text => 'Development'
2637 2637 end
2638 2638 assert_select 'input[name=?][value=test_get_edit_with_params]', 'time_entry[comments]'
2639 2639 end
2640 2640
2641 2641 def test_get_edit_with_multi_custom_field
2642 2642 field = CustomField.find(1)
2643 2643 field.update_attribute :multiple, true
2644 2644 issue = Issue.find(1)
2645 2645 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
2646 2646 issue.save!
2647 2647
2648 2648 @request.session[:user_id] = 2
2649 2649 get :edit, :id => 1
2650 2650 assert_response :success
2651 2651 assert_template 'edit'
2652 2652
2653 2653 assert_select 'select[name=?][multiple=multiple]', 'issue[custom_field_values][1][]' do
2654 2654 assert_select 'option', 3
2655 2655 assert_select 'option[value=MySQL][selected=selected]'
2656 2656 assert_select 'option[value=Oracle][selected=selected]'
2657 2657 assert_select 'option[value=PostgreSQL]:not([selected])'
2658 2658 end
2659 2659 end
2660 2660
2661 2661 def test_update_form_for_existing_issue
2662 2662 @request.session[:user_id] = 2
2663 2663 xhr :put, :update_form, :project_id => 1,
2664 2664 :id => 1,
2665 2665 :issue => {:tracker_id => 2,
2666 2666 :subject => 'This is the test_new issue',
2667 2667 :description => 'This is the description',
2668 2668 :priority_id => 5}
2669 2669 assert_response :success
2670 2670 assert_equal 'text/javascript', response.content_type
2671 2671 assert_template 'update_form'
2672 2672 assert_template 'form'
2673 2673
2674 2674 issue = assigns(:issue)
2675 2675 assert_kind_of Issue, issue
2676 2676 assert_equal 1, issue.id
2677 2677 assert_equal 1, issue.project_id
2678 2678 assert_equal 2, issue.tracker_id
2679 2679 assert_equal 'This is the test_new issue', issue.subject
2680 2680 end
2681 2681
2682 2682 def test_update_form_for_existing_issue_should_keep_issue_author
2683 2683 @request.session[:user_id] = 3
2684 2684 xhr :put, :update_form, :project_id => 1, :id => 1, :issue => {:subject => 'Changed'}
2685 2685 assert_response :success
2686 2686 assert_equal 'text/javascript', response.content_type
2687 2687
2688 2688 issue = assigns(:issue)
2689 2689 assert_equal User.find(2), issue.author
2690 2690 assert_equal 2, issue.author_id
2691 2691 assert_not_equal User.current, issue.author
2692 2692 end
2693 2693
2694 2694 def test_update_form_for_existing_issue_should_propose_transitions_based_on_initial_status
2695 2695 @request.session[:user_id] = 2
2696 2696 WorkflowTransition.delete_all
2697 2697 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1)
2698 2698 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 5)
2699 2699 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 5, :new_status_id => 4)
2700 2700
2701 2701 xhr :put, :update_form, :project_id => 1,
2702 2702 :id => 2,
2703 2703 :issue => {:tracker_id => 2,
2704 2704 :status_id => 5,
2705 2705 :subject => 'This is an issue'}
2706 2706
2707 2707 assert_equal 5, assigns(:issue).status_id
2708 2708 assert_equal [1,2,5], assigns(:allowed_statuses).map(&:id).sort
2709 2709 end
2710 2710
2711 2711 def test_update_form_for_existing_issue_with_project_change
2712 2712 @request.session[:user_id] = 2
2713 2713 xhr :put, :update_form, :project_id => 1,
2714 2714 :id => 1,
2715 2715 :issue => {:project_id => 2,
2716 2716 :tracker_id => 2,
2717 2717 :subject => 'This is the test_new issue',
2718 2718 :description => 'This is the description',
2719 2719 :priority_id => 5}
2720 2720 assert_response :success
2721 2721 assert_template 'form'
2722 2722
2723 2723 issue = assigns(:issue)
2724 2724 assert_kind_of Issue, issue
2725 2725 assert_equal 1, issue.id
2726 2726 assert_equal 2, issue.project_id
2727 2727 assert_equal 2, issue.tracker_id
2728 2728 assert_equal 'This is the test_new issue', issue.subject
2729 2729 end
2730 2730
2731 2731 def test_update_form_should_propose_default_status_for_existing_issue
2732 2732 @request.session[:user_id] = 2
2733 2733 WorkflowTransition.delete_all
2734 2734 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 3)
2735 2735
2736 2736 xhr :put, :update_form, :project_id => 1, :id => 2
2737 2737 assert_response :success
2738 2738 assert_equal [2,3], assigns(:allowed_statuses).map(&:id).sort
2739 2739 end
2740 2740
2741 2741 def test_put_update_without_custom_fields_param
2742 2742 @request.session[:user_id] = 2
2743 2743 ActionMailer::Base.deliveries.clear
2744 2744
2745 2745 issue = Issue.find(1)
2746 2746 assert_equal '125', issue.custom_value_for(2).value
2747 2747 old_subject = issue.subject
2748 2748 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
2749 2749
2750 2750 assert_difference('Journal.count') do
2751 2751 assert_difference('JournalDetail.count', 2) do
2752 2752 put :update, :id => 1, :issue => {:subject => new_subject,
2753 2753 :priority_id => '6',
2754 2754 :category_id => '1' # no change
2755 2755 }
2756 2756 end
2757 2757 end
2758 2758 assert_redirected_to :action => 'show', :id => '1'
2759 2759 issue.reload
2760 2760 assert_equal new_subject, issue.subject
2761 2761 # Make sure custom fields were not cleared
2762 2762 assert_equal '125', issue.custom_value_for(2).value
2763 2763
2764 2764 mail = ActionMailer::Base.deliveries.last
2765 2765 assert_not_nil mail
2766 2766 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2767 2767 assert_mail_body_match "Subject changed from #{old_subject} to #{new_subject}", mail
2768 2768 end
2769 2769
2770 2770 def test_put_update_with_project_change
2771 2771 @request.session[:user_id] = 2
2772 2772 ActionMailer::Base.deliveries.clear
2773 2773
2774 2774 assert_difference('Journal.count') do
2775 2775 assert_difference('JournalDetail.count', 3) do
2776 2776 put :update, :id => 1, :issue => {:project_id => '2',
2777 2777 :tracker_id => '1', # no change
2778 2778 :priority_id => '6',
2779 2779 :category_id => '3'
2780 2780 }
2781 2781 end
2782 2782 end
2783 2783 assert_redirected_to :action => 'show', :id => '1'
2784 2784 issue = Issue.find(1)
2785 2785 assert_equal 2, issue.project_id
2786 2786 assert_equal 1, issue.tracker_id
2787 2787 assert_equal 6, issue.priority_id
2788 2788 assert_equal 3, issue.category_id
2789 2789
2790 2790 mail = ActionMailer::Base.deliveries.last
2791 2791 assert_not_nil mail
2792 2792 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2793 2793 assert_mail_body_match "Project changed from eCookbook to OnlineStore", mail
2794 2794 end
2795 2795
2796 2796 def test_put_update_with_tracker_change
2797 2797 @request.session[:user_id] = 2
2798 2798 ActionMailer::Base.deliveries.clear
2799 2799
2800 2800 assert_difference('Journal.count') do
2801 2801 assert_difference('JournalDetail.count', 2) do
2802 2802 put :update, :id => 1, :issue => {:project_id => '1',
2803 2803 :tracker_id => '2',
2804 2804 :priority_id => '6'
2805 2805 }
2806 2806 end
2807 2807 end
2808 2808 assert_redirected_to :action => 'show', :id => '1'
2809 2809 issue = Issue.find(1)
2810 2810 assert_equal 1, issue.project_id
2811 2811 assert_equal 2, issue.tracker_id
2812 2812 assert_equal 6, issue.priority_id
2813 2813 assert_equal 1, issue.category_id
2814 2814
2815 2815 mail = ActionMailer::Base.deliveries.last
2816 2816 assert_not_nil mail
2817 2817 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2818 2818 assert_mail_body_match "Tracker changed from Bug to Feature request", mail
2819 2819 end
2820 2820
2821 2821 def test_put_update_with_custom_field_change
2822 2822 @request.session[:user_id] = 2
2823 2823 issue = Issue.find(1)
2824 2824 assert_equal '125', issue.custom_value_for(2).value
2825 2825
2826 2826 assert_difference('Journal.count') do
2827 2827 assert_difference('JournalDetail.count', 3) do
2828 2828 put :update, :id => 1, :issue => {:subject => 'Custom field change',
2829 2829 :priority_id => '6',
2830 2830 :category_id => '1', # no change
2831 2831 :custom_field_values => { '2' => 'New custom value' }
2832 2832 }
2833 2833 end
2834 2834 end
2835 2835 assert_redirected_to :action => 'show', :id => '1'
2836 2836 issue.reload
2837 2837 assert_equal 'New custom value', issue.custom_value_for(2).value
2838 2838
2839 2839 mail = ActionMailer::Base.deliveries.last
2840 2840 assert_not_nil mail
2841 2841 assert_mail_body_match "Searchable field changed from 125 to New custom value", mail
2842 2842 end
2843 2843
2844 2844 def test_put_update_with_multi_custom_field_change
2845 2845 field = CustomField.find(1)
2846 2846 field.update_attribute :multiple, true
2847 2847 issue = Issue.find(1)
2848 2848 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
2849 2849 issue.save!
2850 2850
2851 2851 @request.session[:user_id] = 2
2852 2852 assert_difference('Journal.count') do
2853 2853 assert_difference('JournalDetail.count', 3) do
2854 2854 put :update, :id => 1,
2855 2855 :issue => {
2856 2856 :subject => 'Custom field change',
2857 2857 :custom_field_values => { '1' => ['', 'Oracle', 'PostgreSQL'] }
2858 2858 }
2859 2859 end
2860 2860 end
2861 2861 assert_redirected_to :action => 'show', :id => '1'
2862 2862 assert_equal ['Oracle', 'PostgreSQL'], Issue.find(1).custom_field_value(1).sort
2863 2863 end
2864 2864
2865 2865 def test_put_update_with_status_and_assignee_change
2866 2866 issue = Issue.find(1)
2867 2867 assert_equal 1, issue.status_id
2868 2868 @request.session[:user_id] = 2
2869 2869 assert_difference('TimeEntry.count', 0) do
2870 2870 put :update,
2871 2871 :id => 1,
2872 2872 :issue => { :status_id => 2, :assigned_to_id => 3, :notes => 'Assigned to dlopper' },
2873 2873 :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
2874 2874 end
2875 2875 assert_redirected_to :action => 'show', :id => '1'
2876 2876 issue.reload
2877 2877 assert_equal 2, issue.status_id
2878 2878 j = Journal.order('id DESC').first
2879 2879 assert_equal 'Assigned to dlopper', j.notes
2880 2880 assert_equal 2, j.details.size
2881 2881
2882 2882 mail = ActionMailer::Base.deliveries.last
2883 2883 assert_mail_body_match "Status changed from New to Assigned", mail
2884 2884 # subject should contain the new status
2885 2885 assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
2886 2886 end
2887 2887
2888 2888 def test_put_update_with_note_only
2889 2889 notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
2890 2890 # anonymous user
2891 2891 put :update,
2892 2892 :id => 1,
2893 2893 :issue => { :notes => notes }
2894 2894 assert_redirected_to :action => 'show', :id => '1'
2895 2895 j = Journal.order('id DESC').first
2896 2896 assert_equal notes, j.notes
2897 2897 assert_equal 0, j.details.size
2898 2898 assert_equal User.anonymous, j.user
2899 2899
2900 2900 mail = ActionMailer::Base.deliveries.last
2901 2901 assert_mail_body_match notes, mail
2902 2902 end
2903 2903
2904 2904 def test_put_update_with_private_note_only
2905 2905 notes = 'Private note'
2906 2906 @request.session[:user_id] = 2
2907 2907
2908 2908 assert_difference 'Journal.count' do
2909 2909 put :update, :id => 1, :issue => {:notes => notes, :private_notes => '1'}
2910 2910 assert_redirected_to :action => 'show', :id => '1'
2911 2911 end
2912 2912
2913 2913 j = Journal.order('id DESC').first
2914 2914 assert_equal notes, j.notes
2915 2915 assert_equal true, j.private_notes
2916 2916 end
2917 2917
2918 2918 def test_put_update_with_private_note_and_changes
2919 2919 notes = 'Private note'
2920 2920 @request.session[:user_id] = 2
2921 2921
2922 2922 assert_difference 'Journal.count', 2 do
2923 2923 put :update, :id => 1, :issue => {:subject => 'New subject', :notes => notes, :private_notes => '1'}
2924 2924 assert_redirected_to :action => 'show', :id => '1'
2925 2925 end
2926 2926
2927 2927 j = Journal.order('id DESC').first
2928 2928 assert_equal notes, j.notes
2929 2929 assert_equal true, j.private_notes
2930 2930 assert_equal 0, j.details.count
2931 2931
2932 2932 j = Journal.order('id DESC').offset(1).first
2933 2933 assert_nil j.notes
2934 2934 assert_equal false, j.private_notes
2935 2935 assert_equal 1, j.details.count
2936 2936 end
2937 2937
2938 2938 def test_put_update_with_note_and_spent_time
2939 2939 @request.session[:user_id] = 2
2940 2940 spent_hours_before = Issue.find(1).spent_hours
2941 2941 assert_difference('TimeEntry.count') do
2942 2942 put :update,
2943 2943 :id => 1,
2944 2944 :issue => { :notes => '2.5 hours added' },
2945 2945 :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id }
2946 2946 end
2947 2947 assert_redirected_to :action => 'show', :id => '1'
2948 2948
2949 2949 issue = Issue.find(1)
2950 2950
2951 2951 j = Journal.order('id DESC').first
2952 2952 assert_equal '2.5 hours added', j.notes
2953 2953 assert_equal 0, j.details.size
2954 2954
2955 2955 t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time')
2956 2956 assert_not_nil t
2957 2957 assert_equal 2.5, t.hours
2958 2958 assert_equal spent_hours_before + 2.5, issue.spent_hours
2959 2959 end
2960 2960
2961 2961 def test_put_update_should_preserve_parent_issue_even_if_not_visible
2962 2962 parent = Issue.generate!(:project_id => 1, :is_private => true)
2963 2963 issue = Issue.generate!(:parent_issue_id => parent.id)
2964 2964 assert !parent.visible?(User.find(3))
2965 2965 @request.session[:user_id] = 3
2966 2966
2967 2967 get :edit, :id => issue.id
2968 2968 assert_select 'input[name=?][value=?]', 'issue[parent_issue_id]', parent.id.to_s
2969 2969
2970 2970 put :update, :id => issue.id, :issue => {:subject => 'New subject', :parent_issue_id => parent.id.to_s}
2971 2971 assert_response 302
2972 2972 assert_equal parent, issue.parent
2973 2973 end
2974 2974
2975 2975 def test_put_update_with_attachment_only
2976 2976 set_tmp_attachments_directory
2977 2977
2978 2978 # Delete all fixtured journals, a race condition can occur causing the wrong
2979 2979 # journal to get fetched in the next find.
2980 2980 Journal.delete_all
2981 2981
2982 2982 # anonymous user
2983 2983 assert_difference 'Attachment.count' do
2984 2984 put :update, :id => 1,
2985 2985 :issue => {:notes => ''},
2986 2986 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2987 2987 end
2988 2988
2989 2989 assert_redirected_to :action => 'show', :id => '1'
2990 2990 j = Issue.find(1).journals.reorder('id DESC').first
2991 2991 assert j.notes.blank?
2992 2992 assert_equal 1, j.details.size
2993 2993 assert_equal 'testfile.txt', j.details.first.value
2994 2994 assert_equal User.anonymous, j.user
2995 2995
2996 2996 attachment = Attachment.first(:order => 'id DESC')
2997 2997 assert_equal Issue.find(1), attachment.container
2998 2998 assert_equal User.anonymous, attachment.author
2999 2999 assert_equal 'testfile.txt', attachment.filename
3000 3000 assert_equal 'text/plain', attachment.content_type
3001 3001 assert_equal 'test file', attachment.description
3002 3002 assert_equal 59, attachment.filesize
3003 3003 assert File.exists?(attachment.diskfile)
3004 3004 assert_equal 59, File.size(attachment.diskfile)
3005 3005
3006 3006 mail = ActionMailer::Base.deliveries.last
3007 3007 assert_mail_body_match 'testfile.txt', mail
3008 3008 end
3009 3009
3010 3010 def test_put_update_with_failure_should_save_attachments
3011 3011 set_tmp_attachments_directory
3012 3012 @request.session[:user_id] = 2
3013 3013
3014 3014 assert_no_difference 'Journal.count' do
3015 3015 assert_difference 'Attachment.count' do
3016 3016 put :update, :id => 1,
3017 3017 :issue => { :subject => '' },
3018 3018 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
3019 3019 assert_response :success
3020 3020 assert_template 'edit'
3021 3021 end
3022 3022 end
3023 3023
3024 3024 attachment = Attachment.first(:order => 'id DESC')
3025 3025 assert_equal 'testfile.txt', attachment.filename
3026 3026 assert File.exists?(attachment.diskfile)
3027 3027 assert_nil attachment.container
3028 3028
3029 3029 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
3030 3030 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
3031 3031 end
3032 3032
3033 3033 def test_put_update_with_failure_should_keep_saved_attachments
3034 3034 set_tmp_attachments_directory
3035 3035 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
3036 3036 @request.session[:user_id] = 2
3037 3037
3038 3038 assert_no_difference 'Journal.count' do
3039 3039 assert_no_difference 'Attachment.count' do
3040 3040 put :update, :id => 1,
3041 3041 :issue => { :subject => '' },
3042 3042 :attachments => {'p0' => {'token' => attachment.token}}
3043 3043 assert_response :success
3044 3044 assert_template 'edit'
3045 3045 end
3046 3046 end
3047 3047
3048 3048 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
3049 3049 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
3050 3050 end
3051 3051
3052 3052 def test_put_update_should_attach_saved_attachments
3053 3053 set_tmp_attachments_directory
3054 3054 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
3055 3055 @request.session[:user_id] = 2
3056 3056
3057 3057 assert_difference 'Journal.count' do
3058 3058 assert_difference 'JournalDetail.count' do
3059 3059 assert_no_difference 'Attachment.count' do
3060 3060 put :update, :id => 1,
3061 3061 :issue => {:notes => 'Attachment added'},
3062 3062 :attachments => {'p0' => {'token' => attachment.token}}
3063 3063 assert_redirected_to '/issues/1'
3064 3064 end
3065 3065 end
3066 3066 end
3067 3067
3068 3068 attachment.reload
3069 3069 assert_equal Issue.find(1), attachment.container
3070 3070
3071 3071 journal = Journal.first(:order => 'id DESC')
3072 3072 assert_equal 1, journal.details.size
3073 3073 assert_equal 'testfile.txt', journal.details.first.value
3074 3074 end
3075 3075
3076 3076 def test_put_update_with_attachment_that_fails_to_save
3077 3077 set_tmp_attachments_directory
3078 3078
3079 3079 # Delete all fixtured journals, a race condition can occur causing the wrong
3080 3080 # journal to get fetched in the next find.
3081 3081 Journal.delete_all
3082 3082
3083 3083 # Mock out the unsaved attachment
3084 3084 Attachment.any_instance.stubs(:create).returns(Attachment.new)
3085 3085
3086 3086 # anonymous user
3087 3087 put :update,
3088 3088 :id => 1,
3089 3089 :issue => {:notes => ''},
3090 3090 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
3091 3091 assert_redirected_to :action => 'show', :id => '1'
3092 3092 assert_equal '1 file(s) could not be saved.', flash[:warning]
3093 3093 end
3094 3094
3095 3095 def test_put_update_with_no_change
3096 3096 issue = Issue.find(1)
3097 3097 issue.journals.clear
3098 3098 ActionMailer::Base.deliveries.clear
3099 3099
3100 3100 put :update,
3101 3101 :id => 1,
3102 3102 :issue => {:notes => ''}
3103 3103 assert_redirected_to :action => 'show', :id => '1'
3104 3104
3105 3105 issue.reload
3106 3106 assert issue.journals.empty?
3107 3107 # No email should be sent
3108 3108 assert ActionMailer::Base.deliveries.empty?
3109 3109 end
3110 3110
3111 3111 def test_put_update_should_send_a_notification
3112 3112 @request.session[:user_id] = 2
3113 3113 ActionMailer::Base.deliveries.clear
3114 3114 issue = Issue.find(1)
3115 3115 old_subject = issue.subject
3116 3116 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
3117 3117
3118 3118 put :update, :id => 1, :issue => {:subject => new_subject,
3119 3119 :priority_id => '6',
3120 3120 :category_id => '1' # no change
3121 3121 }
3122 3122 assert_equal 1, ActionMailer::Base.deliveries.size
3123 3123 end
3124 3124
3125 3125 def test_put_update_with_invalid_spent_time_hours_only
3126 3126 @request.session[:user_id] = 2
3127 3127 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
3128 3128
3129 3129 assert_no_difference('Journal.count') do
3130 3130 put :update,
3131 3131 :id => 1,
3132 3132 :issue => {:notes => notes},
3133 3133 :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
3134 3134 end
3135 3135 assert_response :success
3136 3136 assert_template 'edit'
3137 3137
3138 3138 assert_error_tag :descendant => {:content => /Activity can&#x27;t be blank/}
3139 3139 assert_select 'textarea[name=?]', 'issue[notes]', :text => notes
3140 3140 assert_select 'input[name=?][value=?]', 'time_entry[hours]', '2z'
3141 3141 end
3142 3142
3143 3143 def test_put_update_with_invalid_spent_time_comments_only
3144 3144 @request.session[:user_id] = 2
3145 3145 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
3146 3146
3147 3147 assert_no_difference('Journal.count') do
3148 3148 put :update,
3149 3149 :id => 1,
3150 3150 :issue => {:notes => notes},
3151 3151 :time_entry => {"comments"=>"this is my comment", "activity_id"=>"", "hours"=>""}
3152 3152 end
3153 3153 assert_response :success
3154 3154 assert_template 'edit'
3155 3155
3156 3156 assert_error_tag :descendant => {:content => /Activity can&#x27;t be blank/}
3157 3157 assert_error_tag :descendant => {:content => /Hours can&#x27;t be blank/}
3158 3158 assert_select 'textarea[name=?]', 'issue[notes]', :text => notes
3159 3159 assert_select 'input[name=?][value=?]', 'time_entry[comments]', 'this is my comment'
3160 3160 end
3161 3161
3162 3162 def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
3163 3163 issue = Issue.find(2)
3164 3164 @request.session[:user_id] = 2
3165 3165
3166 3166 put :update,
3167 3167 :id => issue.id,
3168 3168 :issue => {
3169 3169 :fixed_version_id => 4
3170 3170 }
3171 3171
3172 3172 assert_response :redirect
3173 3173 issue.reload
3174 3174 assert_equal 4, issue.fixed_version_id
3175 3175 assert_not_equal issue.project_id, issue.fixed_version.project_id
3176 3176 end
3177 3177
3178 3178 def test_put_update_should_redirect_back_using_the_back_url_parameter
3179 3179 issue = Issue.find(2)
3180 3180 @request.session[:user_id] = 2
3181 3181
3182 3182 put :update,
3183 3183 :id => issue.id,
3184 3184 :issue => {
3185 3185 :fixed_version_id => 4
3186 3186 },
3187 3187 :back_url => '/issues'
3188 3188
3189 3189 assert_response :redirect
3190 3190 assert_redirected_to '/issues'
3191 3191 end
3192 3192
3193 3193 def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
3194 3194 issue = Issue.find(2)
3195 3195 @request.session[:user_id] = 2
3196 3196
3197 3197 put :update,
3198 3198 :id => issue.id,
3199 3199 :issue => {
3200 3200 :fixed_version_id => 4
3201 3201 },
3202 3202 :back_url => 'http://google.com'
3203 3203
3204 3204 assert_response :redirect
3205 3205 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id
3206 3206 end
3207 3207
3208 3208 def test_get_bulk_edit
3209 3209 @request.session[:user_id] = 2
3210 3210 get :bulk_edit, :ids => [1, 2]
3211 3211 assert_response :success
3212 3212 assert_template 'bulk_edit'
3213 3213
3214 3214 assert_select 'ul#bulk-selection' do
3215 3215 assert_select 'li', 2
3216 3216 assert_select 'li a', :text => 'Bug #1'
3217 3217 end
3218 3218
3219 3219 assert_select 'form#bulk_edit_form[action=?]', '/issues/bulk_update' do
3220 3220 assert_select 'input[name=?]', 'ids[]', 2
3221 3221 assert_select 'input[name=?][value=1][type=hidden]', 'ids[]'
3222 3222
3223 3223 assert_select 'select[name=?]', 'issue[project_id]'
3224 3224 assert_select 'input[name=?]', 'issue[parent_issue_id]'
3225 3225
3226 3226 # Project specific custom field, date type
3227 3227 field = CustomField.find(9)
3228 3228 assert !field.is_for_all?
3229 3229 assert_equal 'date', field.field_format
3230 3230 assert_select 'input[name=?]', 'issue[custom_field_values][9]'
3231 3231
3232 3232 # System wide custom field
3233 3233 assert CustomField.find(1).is_for_all?
3234 3234 assert_select 'select[name=?]', 'issue[custom_field_values][1]'
3235 3235
3236 3236 # Be sure we don't display inactive IssuePriorities
3237 3237 assert ! IssuePriority.find(15).active?
3238 3238 assert_select 'select[name=?]', 'issue[priority_id]' do
3239 3239 assert_select 'option[value=15]', 0
3240 3240 end
3241 3241 end
3242 3242 end
3243 3243
3244 3244 def test_get_bulk_edit_on_different_projects
3245 3245 @request.session[:user_id] = 2
3246 3246 get :bulk_edit, :ids => [1, 2, 6]
3247 3247 assert_response :success
3248 3248 assert_template 'bulk_edit'
3249 3249
3250 3250 # Can not set issues from different projects as children of an issue
3251 3251 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
3252 3252
3253 3253 # Project specific custom field, date type
3254 3254 field = CustomField.find(9)
3255 3255 assert !field.is_for_all?
3256 3256 assert !field.project_ids.include?(Issue.find(6).project_id)
3257 3257 assert_select 'input[name=?]', 'issue[custom_field_values][9]', 0
3258 3258 end
3259 3259
3260 3260 def test_get_bulk_edit_with_user_custom_field
3261 3261 field = IssueCustomField.create!(:name => 'Tester', :field_format => 'user', :is_for_all => true)
3262 3262
3263 3263 @request.session[:user_id] = 2
3264 3264 get :bulk_edit, :ids => [1, 2]
3265 3265 assert_response :success
3266 3266 assert_template 'bulk_edit'
3267 3267
3268 3268 assert_select 'select.user_cf[name=?]', "issue[custom_field_values][#{field.id}]" do
3269 3269 assert_select 'option', Project.find(1).users.count + 2 # "no change" + "none" options
3270 3270 end
3271 3271 end
3272 3272
3273 3273 def test_get_bulk_edit_with_version_custom_field
3274 3274 field = IssueCustomField.create!(:name => 'Affected version', :field_format => 'version', :is_for_all => true)
3275 3275
3276 3276 @request.session[:user_id] = 2
3277 3277 get :bulk_edit, :ids => [1, 2]
3278 3278 assert_response :success
3279 3279 assert_template 'bulk_edit'
3280 3280
3281 3281 assert_select 'select.version_cf[name=?]', "issue[custom_field_values][#{field.id}]" do
3282 3282 assert_select 'option', Project.find(1).shared_versions.count + 2 # "no change" + "none" options
3283 3283 end
3284 3284 end
3285 3285
3286 3286 def test_get_bulk_edit_with_multi_custom_field
3287 3287 field = CustomField.find(1)
3288 3288 field.update_attribute :multiple, true
3289 3289
3290 3290 @request.session[:user_id] = 2
3291 3291 get :bulk_edit, :ids => [1, 2]
3292 3292 assert_response :success
3293 3293 assert_template 'bulk_edit'
3294 3294
3295 3295 assert_select 'select[name=?]', 'issue[custom_field_values][1][]' do
3296 3296 assert_select 'option', field.possible_values.size + 1 # "none" options
3297 3297 end
3298 3298 end
3299 3299
3300 3300 def test_bulk_edit_should_propose_to_clear_text_custom_fields
3301 3301 @request.session[:user_id] = 2
3302 3302 get :bulk_edit, :ids => [1, 3]
3303 3303 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', '__none__'
3304 3304 end
3305 3305
3306 3306 def test_bulk_edit_should_only_propose_statuses_allowed_for_all_issues
3307 3307 WorkflowTransition.delete_all
3308 3308 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
3309 3309 :old_status_id => 1, :new_status_id => 1)
3310 3310 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
3311 3311 :old_status_id => 1, :new_status_id => 3)
3312 3312 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
3313 3313 :old_status_id => 1, :new_status_id => 4)
3314 3314 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2,
3315 3315 :old_status_id => 2, :new_status_id => 1)
3316 3316 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2,
3317 3317 :old_status_id => 2, :new_status_id => 3)
3318 3318 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2,
3319 3319 :old_status_id => 2, :new_status_id => 5)
3320 3320 @request.session[:user_id] = 2
3321 3321 get :bulk_edit, :ids => [1, 2]
3322 3322
3323 3323 assert_response :success
3324 3324 statuses = assigns(:available_statuses)
3325 3325 assert_not_nil statuses
3326 3326 assert_equal [1, 3], statuses.map(&:id).sort
3327 3327
3328 3328 assert_select 'select[name=?]', 'issue[status_id]' do
3329 3329 assert_select 'option', 3 # 2 statuses + "no change" option
3330 3330 end
3331 3331 end
3332 3332
3333 3333 def test_bulk_edit_should_propose_target_project_open_shared_versions
3334 3334 @request.session[:user_id] = 2
3335 3335 post :bulk_edit, :ids => [1, 2, 6], :issue => {:project_id => 1}
3336 3336 assert_response :success
3337 3337 assert_template 'bulk_edit'
3338 3338 assert_equal Project.find(1).shared_versions.open.all.sort, assigns(:versions).sort
3339 3339
3340 3340 assert_select 'select[name=?]', 'issue[fixed_version_id]' do
3341 3341 assert_select 'option', :text => '2.0'
3342 3342 end
3343 3343 end
3344 3344
3345 3345 def test_bulk_edit_should_propose_target_project_categories
3346 3346 @request.session[:user_id] = 2
3347 3347 post :bulk_edit, :ids => [1, 2, 6], :issue => {:project_id => 1}
3348 3348 assert_response :success
3349 3349 assert_template 'bulk_edit'
3350 3350 assert_equal Project.find(1).issue_categories.sort, assigns(:categories).sort
3351 3351
3352 3352 assert_select 'select[name=?]', 'issue[category_id]' do
3353 3353 assert_select 'option', :text => 'Recipes'
3354 3354 end
3355 3355 end
3356 3356
3357 3357 def test_bulk_update
3358 3358 @request.session[:user_id] = 2
3359 3359 # update issues priority
3360 3360 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
3361 3361 :issue => {:priority_id => 7,
3362 3362 :assigned_to_id => '',
3363 3363 :custom_field_values => {'2' => ''}}
3364 3364
3365 3365 assert_response 302
3366 3366 # check that the issues were updated
3367 3367 assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
3368 3368
3369 3369 issue = Issue.find(1)
3370 3370 journal = issue.journals.reorder('created_on DESC').first
3371 3371 assert_equal '125', issue.custom_value_for(2).value
3372 3372 assert_equal 'Bulk editing', journal.notes
3373 3373 assert_equal 1, journal.details.size
3374 3374 end
3375 3375
3376 3376 def test_bulk_update_with_group_assignee
3377 3377 group = Group.find(11)
3378 3378 project = Project.find(1)
3379 3379 project.members << Member.new(:principal => group, :roles => [Role.givable.first])
3380 3380
3381 3381 @request.session[:user_id] = 2
3382 3382 # update issues assignee
3383 3383 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
3384 3384 :issue => {:priority_id => '',
3385 3385 :assigned_to_id => group.id,
3386 3386 :custom_field_values => {'2' => ''}}
3387 3387
3388 3388 assert_response 302
3389 3389 assert_equal [group, group], Issue.find_all_by_id([1, 2]).collect {|i| i.assigned_to}
3390 3390 end
3391 3391
3392 3392 def test_bulk_update_on_different_projects
3393 3393 @request.session[:user_id] = 2
3394 3394 # update issues priority
3395 3395 post :bulk_update, :ids => [1, 2, 6], :notes => 'Bulk editing',
3396 3396 :issue => {:priority_id => 7,
3397 3397 :assigned_to_id => '',
3398 3398 :custom_field_values => {'2' => ''}}
3399 3399
3400 3400 assert_response 302
3401 3401 # check that the issues were updated
3402 3402 assert_equal [7, 7, 7], Issue.find([1,2,6]).map(&:priority_id)
3403 3403
3404 3404 issue = Issue.find(1)
3405 3405 journal = issue.journals.reorder('created_on DESC').first
3406 3406 assert_equal '125', issue.custom_value_for(2).value
3407 3407 assert_equal 'Bulk editing', journal.notes
3408 3408 assert_equal 1, journal.details.size
3409 3409 end
3410 3410
3411 3411 def test_bulk_update_on_different_projects_without_rights
3412 3412 @request.session[:user_id] = 3
3413 3413 user = User.find(3)
3414 3414 action = { :controller => "issues", :action => "bulk_update" }
3415 3415 assert user.allowed_to?(action, Issue.find(1).project)
3416 3416 assert ! user.allowed_to?(action, Issue.find(6).project)
3417 3417 post :bulk_update, :ids => [1, 6], :notes => 'Bulk should fail',
3418 3418 :issue => {:priority_id => 7,
3419 3419 :assigned_to_id => '',
3420 3420 :custom_field_values => {'2' => ''}}
3421 3421 assert_response 403
3422 3422 assert_not_equal "Bulk should fail", Journal.last.notes
3423 3423 end
3424 3424
3425 3425 def test_bullk_update_should_send_a_notification
3426 3426 @request.session[:user_id] = 2
3427 3427 ActionMailer::Base.deliveries.clear
3428 3428 post(:bulk_update,
3429 3429 {
3430 3430 :ids => [1, 2],
3431 3431 :notes => 'Bulk editing',
3432 3432 :issue => {
3433 3433 :priority_id => 7,
3434 3434 :assigned_to_id => '',
3435 3435 :custom_field_values => {'2' => ''}
3436 3436 }
3437 3437 })
3438 3438
3439 3439 assert_response 302
3440 3440 assert_equal 2, ActionMailer::Base.deliveries.size
3441 3441 end
3442 3442
3443 3443 def test_bulk_update_project
3444 3444 @request.session[:user_id] = 2
3445 3445 post :bulk_update, :ids => [1, 2], :issue => {:project_id => '2'}
3446 3446 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3447 3447 # Issues moved to project 2
3448 3448 assert_equal 2, Issue.find(1).project_id
3449 3449 assert_equal 2, Issue.find(2).project_id
3450 3450 # No tracker change
3451 3451 assert_equal 1, Issue.find(1).tracker_id
3452 3452 assert_equal 2, Issue.find(2).tracker_id
3453 3453 end
3454 3454
3455 3455 def test_bulk_update_project_on_single_issue_should_follow_when_needed
3456 3456 @request.session[:user_id] = 2
3457 3457 post :bulk_update, :id => 1, :issue => {:project_id => '2'}, :follow => '1'
3458 3458 assert_redirected_to '/issues/1'
3459 3459 end
3460 3460
3461 3461 def test_bulk_update_project_on_multiple_issues_should_follow_when_needed
3462 3462 @request.session[:user_id] = 2
3463 3463 post :bulk_update, :id => [1, 2], :issue => {:project_id => '2'}, :follow => '1'
3464 3464 assert_redirected_to '/projects/onlinestore/issues'
3465 3465 end
3466 3466
3467 3467 def test_bulk_update_tracker
3468 3468 @request.session[:user_id] = 2
3469 3469 post :bulk_update, :ids => [1, 2], :issue => {:tracker_id => '2'}
3470 3470 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3471 3471 assert_equal 2, Issue.find(1).tracker_id
3472 3472 assert_equal 2, Issue.find(2).tracker_id
3473 3473 end
3474 3474
3475 3475 def test_bulk_update_status
3476 3476 @request.session[:user_id] = 2
3477 3477 # update issues priority
3478 3478 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing status',
3479 3479 :issue => {:priority_id => '',
3480 3480 :assigned_to_id => '',
3481 3481 :status_id => '5'}
3482 3482
3483 3483 assert_response 302
3484 3484 issue = Issue.find(1)
3485 3485 assert issue.closed?
3486 3486 end
3487 3487
3488 3488 def test_bulk_update_priority
3489 3489 @request.session[:user_id] = 2
3490 3490 post :bulk_update, :ids => [1, 2], :issue => {:priority_id => 6}
3491 3491
3492 3492 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3493 3493 assert_equal 6, Issue.find(1).priority_id
3494 3494 assert_equal 6, Issue.find(2).priority_id
3495 3495 end
3496 3496
3497 3497 def test_bulk_update_with_notes
3498 3498 @request.session[:user_id] = 2
3499 3499 post :bulk_update, :ids => [1, 2], :notes => 'Moving two issues'
3500 3500
3501 3501 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3502 3502 assert_equal 'Moving two issues', Issue.find(1).journals.sort_by(&:id).last.notes
3503 3503 assert_equal 'Moving two issues', Issue.find(2).journals.sort_by(&:id).last.notes
3504 3504 end
3505 3505
3506 3506 def test_bulk_update_parent_id
3507 3507 IssueRelation.delete_all
3508 3508 @request.session[:user_id] = 2
3509 3509 post :bulk_update, :ids => [1, 3],
3510 3510 :notes => 'Bulk editing parent',
3511 3511 :issue => {:priority_id => '', :assigned_to_id => '',
3512 3512 :status_id => '', :parent_issue_id => '2'}
3513 3513 assert_response 302
3514 3514 parent = Issue.find(2)
3515 3515 assert_equal parent.id, Issue.find(1).parent_id
3516 3516 assert_equal parent.id, Issue.find(3).parent_id
3517 3517 assert_equal [1, 3], parent.children.collect(&:id).sort
3518 3518 end
3519 3519
3520 3520 def test_bulk_update_custom_field
3521 3521 @request.session[:user_id] = 2
3522 3522 # update issues priority
3523 3523 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing custom field',
3524 3524 :issue => {:priority_id => '',
3525 3525 :assigned_to_id => '',
3526 3526 :custom_field_values => {'2' => '777'}}
3527 3527
3528 3528 assert_response 302
3529 3529
3530 3530 issue = Issue.find(1)
3531 3531 journal = issue.journals.reorder('created_on DESC').first
3532 3532 assert_equal '777', issue.custom_value_for(2).value
3533 3533 assert_equal 1, journal.details.size
3534 3534 assert_equal '125', journal.details.first.old_value
3535 3535 assert_equal '777', journal.details.first.value
3536 3536 end
3537 3537
3538 3538 def test_bulk_update_custom_field_to_blank
3539 3539 @request.session[:user_id] = 2
3540 3540 post :bulk_update, :ids => [1, 3], :notes => 'Bulk editing custom field',
3541 3541 :issue => {:priority_id => '',
3542 3542 :assigned_to_id => '',
3543 3543 :custom_field_values => {'1' => '__none__'}}
3544 3544 assert_response 302
3545 3545 assert_equal '', Issue.find(1).custom_field_value(1)
3546 3546 assert_equal '', Issue.find(3).custom_field_value(1)
3547 3547 end
3548 3548
3549 3549 def test_bulk_update_multi_custom_field
3550 3550 field = CustomField.find(1)
3551 3551 field.update_attribute :multiple, true
3552 3552
3553 3553 @request.session[:user_id] = 2
3554 3554 post :bulk_update, :ids => [1, 2, 3], :notes => 'Bulk editing multi custom field',
3555 3555 :issue => {:priority_id => '',
3556 3556 :assigned_to_id => '',
3557 3557 :custom_field_values => {'1' => ['MySQL', 'Oracle']}}
3558 3558
3559 3559 assert_response 302
3560 3560
3561 3561 assert_equal ['MySQL', 'Oracle'], Issue.find(1).custom_field_value(1).sort
3562 3562 assert_equal ['MySQL', 'Oracle'], Issue.find(3).custom_field_value(1).sort
3563 3563 # the custom field is not associated with the issue tracker
3564 3564 assert_nil Issue.find(2).custom_field_value(1)
3565 3565 end
3566 3566
3567 3567 def test_bulk_update_multi_custom_field_to_blank
3568 3568 field = CustomField.find(1)
3569 3569 field.update_attribute :multiple, true
3570 3570
3571 3571 @request.session[:user_id] = 2
3572 3572 post :bulk_update, :ids => [1, 3], :notes => 'Bulk editing multi custom field',
3573 3573 :issue => {:priority_id => '',
3574 3574 :assigned_to_id => '',
3575 3575 :custom_field_values => {'1' => ['__none__']}}
3576 3576 assert_response 302
3577 3577 assert_equal [''], Issue.find(1).custom_field_value(1)
3578 3578 assert_equal [''], Issue.find(3).custom_field_value(1)
3579 3579 end
3580 3580
3581 3581 def test_bulk_update_unassign
3582 3582 assert_not_nil Issue.find(2).assigned_to
3583 3583 @request.session[:user_id] = 2
3584 3584 # unassign issues
3585 3585 post :bulk_update, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'}
3586 3586 assert_response 302
3587 3587 # check that the issues were updated
3588 3588 assert_nil Issue.find(2).assigned_to
3589 3589 end
3590 3590
3591 3591 def test_post_bulk_update_should_allow_fixed_version_to_be_set_to_a_subproject
3592 3592 @request.session[:user_id] = 2
3593 3593
3594 3594 post :bulk_update, :ids => [1,2], :issue => {:fixed_version_id => 4}
3595 3595
3596 3596 assert_response :redirect
3597 3597 issues = Issue.find([1,2])
3598 3598 issues.each do |issue|
3599 3599 assert_equal 4, issue.fixed_version_id
3600 3600 assert_not_equal issue.project_id, issue.fixed_version.project_id
3601 3601 end
3602 3602 end
3603 3603
3604 3604 def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter
3605 3605 @request.session[:user_id] = 2
3606 3606 post :bulk_update, :ids => [1,2], :back_url => '/issues'
3607 3607
3608 3608 assert_response :redirect
3609 3609 assert_redirected_to '/issues'
3610 3610 end
3611 3611
3612 3612 def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
3613 3613 @request.session[:user_id] = 2
3614 3614 post :bulk_update, :ids => [1,2], :back_url => 'http://google.com'
3615 3615
3616 3616 assert_response :redirect
3617 3617 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier
3618 3618 end
3619 3619
3620 3620 def test_bulk_update_with_all_failures_should_show_errors
3621 3621 @request.session[:user_id] = 2
3622 3622 post :bulk_update, :ids => [1, 2], :issue => {:start_date => 'foo'}
3623 3623
3624 3624 assert_response :success
3625 3625 assert_template 'bulk_edit'
3626 3626 assert_select '#errorExplanation span', :text => 'Failed to save 2 issue(s) on 2 selected: #1, #2.'
3627 3627 assert_select '#errorExplanation ul li', :text => 'Start date is not a valid date: #1, #2'
3628 3628
3629 3629 assert_equal [1, 2], assigns[:issues].map(&:id)
3630 3630 end
3631 3631
3632 3632 def test_bulk_update_with_some_failures_should_show_errors
3633 3633 issue1 = Issue.generate!(:start_date => '2013-05-12')
3634 3634 issue2 = Issue.generate!(:start_date => '2013-05-15')
3635 3635 issue3 = Issue.generate!
3636 3636 @request.session[:user_id] = 2
3637 3637 post :bulk_update, :ids => [issue1.id, issue2.id, issue3.id],
3638 3638 :issue => {:due_date => '2013-05-01'}
3639 3639 assert_response :success
3640 3640 assert_template 'bulk_edit'
3641 3641 assert_select '#errorExplanation span',
3642 3642 :text => "Failed to save 2 issue(s) on 3 selected: ##{issue1.id}, ##{issue2.id}."
3643 3643 assert_select '#errorExplanation ul li',
3644 3644 :text => "Due date must be greater than start date: ##{issue1.id}, ##{issue2.id}"
3645 3645 assert_equal [issue1.id, issue2.id], assigns[:issues].map(&:id)
3646 3646 end
3647 3647
3648 3648 def test_bulk_update_with_failure_should_preserved_form_values
3649 3649 @request.session[:user_id] = 2
3650 3650 post :bulk_update, :ids => [1, 2], :issue => {:tracker_id => '2', :start_date => 'foo'}
3651 3651
3652 3652 assert_response :success
3653 3653 assert_template 'bulk_edit'
3654 3654 assert_select 'select[name=?]', 'issue[tracker_id]' do
3655 3655 assert_select 'option[value=2][selected=selected]'
3656 3656 end
3657 3657 assert_select 'input[name=?][value=?]', 'issue[start_date]', 'foo'
3658 3658 end
3659 3659
3660 3660 def test_get_bulk_copy
3661 3661 @request.session[:user_id] = 2
3662 3662 get :bulk_edit, :ids => [1, 2, 3], :copy => '1'
3663 3663 assert_response :success
3664 3664 assert_template 'bulk_edit'
3665 3665
3666 3666 issues = assigns(:issues)
3667 3667 assert_not_nil issues
3668 3668 assert_equal [1, 2, 3], issues.map(&:id).sort
3669 3669
3670 3670 assert_select 'input[name=copy_attachments]'
3671 3671 end
3672 3672
3673 3673 def test_bulk_copy_to_another_project
3674 3674 @request.session[:user_id] = 2
3675 3675 assert_difference 'Issue.count', 2 do
3676 3676 assert_no_difference 'Project.find(1).issues.count' do
3677 3677 post :bulk_update, :ids => [1, 2], :issue => {:project_id => '2'}, :copy => '1'
3678 3678 end
3679 3679 end
3680 3680 assert_redirected_to '/projects/ecookbook/issues'
3681 3681
3682 3682 copies = Issue.all(:order => 'id DESC', :limit => issues.size)
3683 3683 copies.each do |copy|
3684 3684 assert_equal 2, copy.project_id
3685 3685 end
3686 3686 end
3687 3687
3688 3688 def test_bulk_copy_should_allow_not_changing_the_issue_attributes
3689 3689 @request.session[:user_id] = 2
3690 3690 issues = [
3691 3691 Issue.create!(:project_id => 1, :tracker_id => 1, :status_id => 1,
3692 3692 :priority_id => 2, :subject => 'issue 1', :author_id => 1,
3693 3693 :assigned_to_id => nil),
3694 3694 Issue.create!(:project_id => 2, :tracker_id => 3, :status_id => 2,
3695 3695 :priority_id => 1, :subject => 'issue 2', :author_id => 2,
3696 3696 :assigned_to_id => 3)
3697 3697 ]
3698 3698 assert_difference 'Issue.count', issues.size do
3699 3699 post :bulk_update, :ids => issues.map(&:id), :copy => '1',
3700 3700 :issue => {
3701 3701 :project_id => '', :tracker_id => '', :assigned_to_id => '',
3702 3702 :status_id => '', :start_date => '', :due_date => ''
3703 3703 }
3704 3704 end
3705 3705
3706 3706 copies = Issue.all(:order => 'id DESC', :limit => issues.size)
3707 3707 issues.each do |orig|
3708 3708 copy = copies.detect {|c| c.subject == orig.subject}
3709 3709 assert_not_nil copy
3710 3710 assert_equal orig.project_id, copy.project_id
3711 3711 assert_equal orig.tracker_id, copy.tracker_id
3712 3712 assert_equal orig.status_id, copy.status_id
3713 3713 assert_equal orig.assigned_to_id, copy.assigned_to_id
3714 3714 assert_equal orig.priority_id, copy.priority_id
3715 3715 end
3716 3716 end
3717 3717
3718 3718 def test_bulk_copy_should_allow_changing_the_issue_attributes
3719 3719 # Fixes random test failure with Mysql
3720 3720 # where Issue.where(:project_id => 2).limit(2).order('id desc')
3721 3721 # doesn't return the expected results
3722 3722 Issue.delete_all("project_id=2")
3723 3723
3724 3724 @request.session[:user_id] = 2
3725 3725 assert_difference 'Issue.count', 2 do
3726 3726 assert_no_difference 'Project.find(1).issues.count' do
3727 3727 post :bulk_update, :ids => [1, 2], :copy => '1',
3728 3728 :issue => {
3729 3729 :project_id => '2', :tracker_id => '', :assigned_to_id => '4',
3730 3730 :status_id => '1', :start_date => '2009-12-01', :due_date => '2009-12-31'
3731 3731 }
3732 3732 end
3733 3733 end
3734 3734
3735 3735 copied_issues = Issue.where(:project_id => 2).limit(2).order('id desc').to_a
3736 3736 assert_equal 2, copied_issues.size
3737 3737 copied_issues.each do |issue|
3738 3738 assert_equal 2, issue.project_id, "Project is incorrect"
3739 3739 assert_equal 4, issue.assigned_to_id, "Assigned to is incorrect"
3740 3740 assert_equal 1, issue.status_id, "Status is incorrect"
3741 3741 assert_equal '2009-12-01', issue.start_date.to_s, "Start date is incorrect"
3742 3742 assert_equal '2009-12-31', issue.due_date.to_s, "Due date is incorrect"
3743 3743 end
3744 3744 end
3745 3745
3746 3746 def test_bulk_copy_should_allow_adding_a_note
3747 3747 @request.session[:user_id] = 2
3748 3748 assert_difference 'Issue.count', 1 do
3749 3749 post :bulk_update, :ids => [1], :copy => '1',
3750 3750 :notes => 'Copying one issue',
3751 3751 :issue => {
3752 3752 :project_id => '', :tracker_id => '', :assigned_to_id => '4',
3753 3753 :status_id => '3', :start_date => '2009-12-01', :due_date => '2009-12-31'
3754 3754 }
3755 3755 end
3756 3756 issue = Issue.first(:order => 'id DESC')
3757 3757 assert_equal 1, issue.journals.size
3758 3758 journal = issue.journals.first
3759 3759 assert_equal 1, journal.details.size
3760 3760 assert_equal 'Copying one issue', journal.notes
3761 3761 end
3762 3762
3763 3763 def test_bulk_copy_should_allow_not_copying_the_attachments
3764 3764 attachment_count = Issue.find(3).attachments.size
3765 3765 assert attachment_count > 0
3766 3766 @request.session[:user_id] = 2
3767 3767
3768 3768 assert_difference 'Issue.count', 1 do
3769 3769 assert_no_difference 'Attachment.count' do
3770 3770 post :bulk_update, :ids => [3], :copy => '1',
3771 3771 :issue => {
3772 3772 :project_id => ''
3773 3773 }
3774 3774 end
3775 3775 end
3776 3776 end
3777 3777
3778 3778 def test_bulk_copy_should_allow_copying_the_attachments
3779 3779 attachment_count = Issue.find(3).attachments.size
3780 3780 assert attachment_count > 0
3781 3781 @request.session[:user_id] = 2
3782 3782
3783 3783 assert_difference 'Issue.count', 1 do
3784 3784 assert_difference 'Attachment.count', attachment_count do
3785 3785 post :bulk_update, :ids => [3], :copy => '1', :copy_attachments => '1',
3786 3786 :issue => {
3787 3787 :project_id => ''
3788 3788 }
3789 3789 end
3790 3790 end
3791 3791 end
3792 3792
3793 3793 def test_bulk_copy_should_add_relations_with_copied_issues
3794 3794 @request.session[:user_id] = 2
3795 3795
3796 3796 assert_difference 'Issue.count', 2 do
3797 3797 assert_difference 'IssueRelation.count', 2 do
3798 3798 post :bulk_update, :ids => [1, 3], :copy => '1',
3799 3799 :issue => {
3800 3800 :project_id => '1'
3801 3801 }
3802 3802 end
3803 3803 end
3804 3804 end
3805 3805
3806 3806 def test_bulk_copy_should_allow_not_copying_the_subtasks
3807 3807 issue = Issue.generate_with_descendants!
3808 3808 @request.session[:user_id] = 2
3809 3809
3810 3810 assert_difference 'Issue.count', 1 do
3811 3811 post :bulk_update, :ids => [issue.id], :copy => '1',
3812 3812 :issue => {
3813 3813 :project_id => ''
3814 3814 }
3815 3815 end
3816 3816 end
3817 3817
3818 3818 def test_bulk_copy_should_allow_copying_the_subtasks
3819 3819 issue = Issue.generate_with_descendants!
3820 3820 count = issue.descendants.count
3821 3821 @request.session[:user_id] = 2
3822 3822
3823 3823 assert_difference 'Issue.count', count+1 do
3824 3824 post :bulk_update, :ids => [issue.id], :copy => '1', :copy_subtasks => '1',
3825 3825 :issue => {
3826 3826 :project_id => ''
3827 3827 }
3828 3828 end
3829 3829 copy = Issue.where(:parent_id => nil).order("id DESC").first
3830 3830 assert_equal count, copy.descendants.count
3831 3831 end
3832 3832
3833 3833 def test_bulk_copy_should_not_copy_selected_subtasks_twice
3834 3834 issue = Issue.generate_with_descendants!
3835 3835 count = issue.descendants.count
3836 3836 @request.session[:user_id] = 2
3837 3837
3838 3838 assert_difference 'Issue.count', count+1 do
3839 3839 post :bulk_update, :ids => issue.self_and_descendants.map(&:id), :copy => '1', :copy_subtasks => '1',
3840 3840 :issue => {
3841 3841 :project_id => ''
3842 3842 }
3843 3843 end
3844 3844 copy = Issue.where(:parent_id => nil).order("id DESC").first
3845 3845 assert_equal count, copy.descendants.count
3846 3846 end
3847 3847
3848 3848 def test_bulk_copy_to_another_project_should_follow_when_needed
3849 3849 @request.session[:user_id] = 2
3850 3850 post :bulk_update, :ids => [1], :copy => '1', :issue => {:project_id => 2}, :follow => '1'
3851 3851 issue = Issue.first(:order => 'id DESC')
3852 3852 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
3853 3853 end
3854 3854
3855 3855 def test_bulk_copy_with_all_failures_should_display_errors
3856 3856 @request.session[:user_id] = 2
3857 3857 post :bulk_update, :ids => [1, 2], :copy => '1', :issue => {:start_date => 'foo'}
3858 3858
3859 3859 assert_response :success
3860 3860 end
3861 3861
3862 3862 def test_destroy_issue_with_no_time_entries
3863 3863 assert_nil TimeEntry.find_by_issue_id(2)
3864 3864 @request.session[:user_id] = 2
3865 3865
3866 3866 assert_difference 'Issue.count', -1 do
3867 3867 delete :destroy, :id => 2
3868 3868 end
3869 3869 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3870 3870 assert_nil Issue.find_by_id(2)
3871 3871 end
3872 3872
3873 3873 def test_destroy_issues_with_time_entries
3874 3874 @request.session[:user_id] = 2
3875 3875
3876 3876 assert_no_difference 'Issue.count' do
3877 3877 delete :destroy, :ids => [1, 3]
3878 3878 end
3879 3879 assert_response :success
3880 3880 assert_template 'destroy'
3881 3881 assert_not_nil assigns(:hours)
3882 3882 assert Issue.find_by_id(1) && Issue.find_by_id(3)
3883 3883
3884 3884 assert_select 'form' do
3885 3885 assert_select 'input[name=_method][value=delete]'
3886 3886 end
3887 3887 end
3888 3888
3889 3889 def test_destroy_issues_and_destroy_time_entries
3890 3890 @request.session[:user_id] = 2
3891 3891
3892 3892 assert_difference 'Issue.count', -2 do
3893 3893 assert_difference 'TimeEntry.count', -3 do
3894 3894 delete :destroy, :ids => [1, 3], :todo => 'destroy'
3895 3895 end
3896 3896 end
3897 3897 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3898 3898 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3899 3899 assert_nil TimeEntry.find_by_id([1, 2])
3900 3900 end
3901 3901
3902 3902 def test_destroy_issues_and_assign_time_entries_to_project
3903 3903 @request.session[:user_id] = 2
3904 3904
3905 3905 assert_difference 'Issue.count', -2 do
3906 3906 assert_no_difference 'TimeEntry.count' do
3907 3907 delete :destroy, :ids => [1, 3], :todo => 'nullify'
3908 3908 end
3909 3909 end
3910 3910 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3911 3911 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3912 3912 assert_nil TimeEntry.find(1).issue_id
3913 3913 assert_nil TimeEntry.find(2).issue_id
3914 3914 end
3915 3915
3916 3916 def test_destroy_issues_and_reassign_time_entries_to_another_issue
3917 3917 @request.session[:user_id] = 2
3918 3918
3919 3919 assert_difference 'Issue.count', -2 do
3920 3920 assert_no_difference 'TimeEntry.count' do
3921 3921 delete :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2
3922 3922 end
3923 3923 end
3924 3924 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3925 3925 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3926 3926 assert_equal 2, TimeEntry.find(1).issue_id
3927 3927 assert_equal 2, TimeEntry.find(2).issue_id
3928 3928 end
3929 3929
3930 3930 def test_destroy_issues_from_different_projects
3931 3931 @request.session[:user_id] = 2
3932 3932
3933 3933 assert_difference 'Issue.count', -3 do
3934 3934 delete :destroy, :ids => [1, 2, 6], :todo => 'destroy'
3935 3935 end
3936 3936 assert_redirected_to :controller => 'issues', :action => 'index'
3937 3937 assert !(Issue.find_by_id(1) || Issue.find_by_id(2) || Issue.find_by_id(6))
3938 3938 end
3939 3939
3940 3940 def test_destroy_parent_and_child_issues
3941 3941 parent = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'Parent Issue')
3942 3942 child = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'Child Issue', :parent_issue_id => parent.id)
3943 3943 assert child.is_descendant_of?(parent.reload)
3944 3944
3945 3945 @request.session[:user_id] = 2
3946 3946 assert_difference 'Issue.count', -2 do
3947 3947 delete :destroy, :ids => [parent.id, child.id], :todo => 'destroy'
3948 3948 end
3949 3949 assert_response 302
3950 3950 end
3951 3951
3952 3952 def test_destroy_invalid_should_respond_with_404
3953 3953 @request.session[:user_id] = 2
3954 3954 assert_no_difference 'Issue.count' do
3955 3955 delete :destroy, :id => 999
3956 3956 end
3957 3957 assert_response 404
3958 3958 end
3959 3959
3960 3960 def test_default_search_scope
3961 3961 get :index
3962 3962
3963 3963 assert_select 'div#quick-search form' do
3964 3964 assert_select 'input[name=issues][value=1][type=hidden]'
3965 3965 end
3966 3966 end
3967 3967 end
@@ -1,488 +1,482
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class UsersControllerTest < ActionController::TestCase
21 21 include Redmine::I18n
22 22
23 23 fixtures :users, :projects, :members, :member_roles, :roles,
24 24 :custom_fields, :custom_values, :groups_users,
25 25 :auth_sources
26 26
27 27 def setup
28 28 User.current = nil
29 29 @request.session[:user_id] = 1 # admin
30 30 end
31 31
32 32 def test_index
33 33 get :index
34 34 assert_response :success
35 35 assert_template 'index'
36 end
37
38 def test_index
39 get :index
40 assert_response :success
41 assert_template 'index'
42 36 assert_not_nil assigns(:users)
43 37 # active users only
44 38 assert_nil assigns(:users).detect {|u| !u.active?}
45 39 end
46 40
47 41 def test_index_with_status_filter
48 42 get :index, :status => 3
49 43 assert_response :success
50 44 assert_template 'index'
51 45 assert_not_nil assigns(:users)
52 46 assert_equal [3], assigns(:users).map(&:status).uniq
53 47 end
54 48
55 49 def test_index_with_name_filter
56 50 get :index, :name => 'john'
57 51 assert_response :success
58 52 assert_template 'index'
59 53 users = assigns(:users)
60 54 assert_not_nil users
61 55 assert_equal 1, users.size
62 56 assert_equal 'John', users.first.firstname
63 57 end
64 58
65 59 def test_index_with_group_filter
66 60 get :index, :group_id => '10'
67 61 assert_response :success
68 62 assert_template 'index'
69 63 users = assigns(:users)
70 64 assert users.any?
71 65 assert_equal([], (users - Group.find(10).users))
72 66 assert_select 'select[name=group_id]' do
73 67 assert_select 'option[value=10][selected=selected]'
74 68 end
75 69 end
76 70
77 71 def test_show
78 72 @request.session[:user_id] = nil
79 73 get :show, :id => 2
80 74 assert_response :success
81 75 assert_template 'show'
82 76 assert_not_nil assigns(:user)
83 77
84 78 assert_tag 'li', :content => /Phone number/
85 79 end
86 80
87 81 def test_show_should_not_display_hidden_custom_fields
88 82 @request.session[:user_id] = nil
89 83 UserCustomField.find_by_name('Phone number').update_attribute :visible, false
90 84 get :show, :id => 2
91 85 assert_response :success
92 86 assert_template 'show'
93 87 assert_not_nil assigns(:user)
94 88
95 89 assert_no_tag 'li', :content => /Phone number/
96 90 end
97 91
98 92 def test_show_should_not_fail_when_custom_values_are_nil
99 93 user = User.find(2)
100 94
101 95 # Create a custom field to illustrate the issue
102 96 custom_field = CustomField.create!(:name => 'Testing', :field_format => 'text')
103 97 custom_value = user.custom_values.build(:custom_field => custom_field).save!
104 98
105 99 get :show, :id => 2
106 100 assert_response :success
107 101 end
108 102
109 103 def test_show_inactive
110 104 @request.session[:user_id] = nil
111 105 get :show, :id => 5
112 106 assert_response 404
113 107 end
114 108
115 109 def test_show_should_not_reveal_users_with_no_visible_activity_or_project
116 110 @request.session[:user_id] = nil
117 111 get :show, :id => 9
118 112 assert_response 404
119 113 end
120 114
121 115 def test_show_inactive_by_admin
122 116 @request.session[:user_id] = 1
123 117 get :show, :id => 5
124 118 assert_response 200
125 119 assert_not_nil assigns(:user)
126 120 end
127 121
128 122 def test_show_displays_memberships_based_on_project_visibility
129 123 @request.session[:user_id] = 1
130 124 get :show, :id => 2
131 125 assert_response :success
132 126 memberships = assigns(:memberships)
133 127 assert_not_nil memberships
134 128 project_ids = memberships.map(&:project_id)
135 129 assert project_ids.include?(2) #private project admin can see
136 130 end
137 131
138 132 def test_show_current_should_require_authentication
139 133 @request.session[:user_id] = nil
140 134 get :show, :id => 'current'
141 135 assert_response 302
142 136 end
143 137
144 138 def test_show_current
145 139 @request.session[:user_id] = 2
146 140 get :show, :id => 'current'
147 141 assert_response :success
148 142 assert_template 'show'
149 143 assert_equal User.find(2), assigns(:user)
150 144 end
151 145
152 146 def test_new
153 147 get :new
154 148 assert_response :success
155 149 assert_template :new
156 150 assert assigns(:user)
157 151 end
158 152
159 153 def test_create
160 154 Setting.bcc_recipients = '1'
161 155
162 156 assert_difference 'User.count' do
163 157 assert_difference 'ActionMailer::Base.deliveries.size' do
164 158 post :create,
165 159 :user => {
166 160 :firstname => 'John',
167 161 :lastname => 'Doe',
168 162 :login => 'jdoe',
169 163 :password => 'secret123',
170 164 :password_confirmation => 'secret123',
171 165 :mail => 'jdoe@gmail.com',
172 166 :mail_notification => 'none'
173 167 },
174 168 :send_information => '1'
175 169 end
176 170 end
177 171
178 172 user = User.first(:order => 'id DESC')
179 173 assert_redirected_to :controller => 'users', :action => 'edit', :id => user.id
180 174
181 175 assert_equal 'John', user.firstname
182 176 assert_equal 'Doe', user.lastname
183 177 assert_equal 'jdoe', user.login
184 178 assert_equal 'jdoe@gmail.com', user.mail
185 179 assert_equal 'none', user.mail_notification
186 180 assert user.check_password?('secret123')
187 181
188 182 mail = ActionMailer::Base.deliveries.last
189 183 assert_not_nil mail
190 184 assert_equal [user.mail], mail.bcc
191 185 assert_mail_body_match 'secret', mail
192 186 end
193 187
194 188 def test_create_with_preferences
195 189 assert_difference 'User.count' do
196 190 post :create,
197 191 :user => {
198 192 :firstname => 'John',
199 193 :lastname => 'Doe',
200 194 :login => 'jdoe',
201 195 :password => 'secret123',
202 196 :password_confirmation => 'secret123',
203 197 :mail => 'jdoe@gmail.com',
204 198 :mail_notification => 'none'
205 199 },
206 200 :pref => {
207 201 'hide_mail' => '1',
208 202 'time_zone' => 'Paris',
209 203 'comments_sorting' => 'desc',
210 204 'warn_on_leaving_unsaved' => '0'
211 205 }
212 206 end
213 207 user = User.first(:order => 'id DESC')
214 208 assert_equal 'jdoe', user.login
215 209 assert_equal true, user.pref.hide_mail
216 210 assert_equal 'Paris', user.pref.time_zone
217 211 assert_equal 'desc', user.pref[:comments_sorting]
218 212 assert_equal '0', user.pref[:warn_on_leaving_unsaved]
219 213 end
220 214
221 215 def test_create_with_generate_password_should_email_the_password
222 216 assert_difference 'User.count' do
223 217 post :create, :user => {
224 218 :login => 'randompass',
225 219 :firstname => 'Random',
226 220 :lastname => 'Pass',
227 221 :mail => 'randompass@example.net',
228 222 :language => 'en',
229 223 :generate_password => '1',
230 224 :password => '',
231 225 :password_confirmation => ''
232 226 }, :send_information => 1
233 227 end
234 228 user = User.order('id DESC').first
235 229 assert_equal 'randompass', user.login
236 230
237 231 mail = ActionMailer::Base.deliveries.last
238 232 assert_not_nil mail
239 233 m = mail_body(mail).match(/Password: ([a-zA-Z0-9]+)/)
240 234 assert m
241 235 password = m[1]
242 236 assert user.check_password?(password)
243 237 end
244 238
245 239 def test_create_with_failure
246 240 assert_no_difference 'User.count' do
247 241 post :create, :user => {}
248 242 end
249 243 assert_response :success
250 244 assert_template 'new'
251 245 end
252 246
253 247 def test_edit
254 248 get :edit, :id => 2
255 249 assert_response :success
256 250 assert_template 'edit'
257 251 assert_equal User.find(2), assigns(:user)
258 252 end
259 253
260 254 def test_update
261 255 ActionMailer::Base.deliveries.clear
262 256 put :update, :id => 2,
263 257 :user => {:firstname => 'Changed', :mail_notification => 'only_assigned'},
264 258 :pref => {:hide_mail => '1', :comments_sorting => 'desc'}
265 259 user = User.find(2)
266 260 assert_equal 'Changed', user.firstname
267 261 assert_equal 'only_assigned', user.mail_notification
268 262 assert_equal true, user.pref[:hide_mail]
269 263 assert_equal 'desc', user.pref[:comments_sorting]
270 264 assert ActionMailer::Base.deliveries.empty?
271 265 end
272 266
273 267 def test_update_with_failure
274 268 assert_no_difference 'User.count' do
275 269 put :update, :id => 2, :user => {:firstname => ''}
276 270 end
277 271 assert_response :success
278 272 assert_template 'edit'
279 273 end
280 274
281 275 def test_update_with_group_ids_should_assign_groups
282 276 put :update, :id => 2, :user => {:group_ids => ['10']}
283 277 user = User.find(2)
284 278 assert_equal [10], user.group_ids
285 279 end
286 280
287 281 def test_update_with_activation_should_send_a_notification
288 282 u = User.new(:firstname => 'Foo', :lastname => 'Bar', :mail => 'foo.bar@somenet.foo', :language => 'fr')
289 283 u.login = 'foo'
290 284 u.status = User::STATUS_REGISTERED
291 285 u.save!
292 286 ActionMailer::Base.deliveries.clear
293 287 Setting.bcc_recipients = '1'
294 288
295 289 put :update, :id => u.id, :user => {:status => User::STATUS_ACTIVE}
296 290 assert u.reload.active?
297 291 mail = ActionMailer::Base.deliveries.last
298 292 assert_not_nil mail
299 293 assert_equal ['foo.bar@somenet.foo'], mail.bcc
300 294 assert_mail_body_match ll('fr', :notice_account_activated), mail
301 295 end
302 296
303 297 def test_update_with_password_change_should_send_a_notification
304 298 ActionMailer::Base.deliveries.clear
305 299 Setting.bcc_recipients = '1'
306 300
307 301 put :update, :id => 2, :user => {:password => 'newpass123', :password_confirmation => 'newpass123'}, :send_information => '1'
308 302 u = User.find(2)
309 303 assert u.check_password?('newpass123')
310 304
311 305 mail = ActionMailer::Base.deliveries.last
312 306 assert_not_nil mail
313 307 assert_equal [u.mail], mail.bcc
314 308 assert_mail_body_match 'newpass123', mail
315 309 end
316 310
317 311 def test_update_with_generate_password_should_email_the_password
318 312 ActionMailer::Base.deliveries.clear
319 313 Setting.bcc_recipients = '1'
320 314
321 315 put :update, :id => 2, :user => {
322 316 :generate_password => '1',
323 317 :password => '',
324 318 :password_confirmation => ''
325 319 }, :send_information => '1'
326 320
327 321 mail = ActionMailer::Base.deliveries.last
328 322 assert_not_nil mail
329 323 m = mail_body(mail).match(/Password: ([a-zA-Z0-9]+)/)
330 324 assert m
331 325 password = m[1]
332 326 assert User.find(2).check_password?(password)
333 327 end
334 328
335 329 def test_update_without_generate_password_should_not_change_password
336 330 put :update, :id => 2, :user => {
337 331 :firstname => 'changed',
338 332 :generate_password => '0',
339 333 :password => '',
340 334 :password_confirmation => ''
341 335 }, :send_information => '1'
342 336
343 337 user = User.find(2)
344 338 assert_equal 'changed', user.firstname
345 339 assert user.check_password?('jsmith')
346 340 end
347 341
348 342 def test_update_user_switchin_from_auth_source_to_password_authentication
349 343 # Configure as auth source
350 344 u = User.find(2)
351 345 u.auth_source = AuthSource.find(1)
352 346 u.save!
353 347
354 348 put :update, :id => u.id, :user => {:auth_source_id => '', :password => 'newpass123', :password_confirmation => 'newpass123'}
355 349
356 350 assert_equal nil, u.reload.auth_source
357 351 assert u.check_password?('newpass123')
358 352 end
359 353
360 354 def test_update_notified_project
361 355 get :edit, :id => 2
362 356 assert_response :success
363 357 assert_template 'edit'
364 358 u = User.find(2)
365 359 assert_equal [1, 2, 5], u.projects.collect{|p| p.id}.sort
366 360 assert_equal [1, 2, 5], u.notified_projects_ids.sort
367 361 assert_select 'input[name=?][value=?]', 'user[notified_project_ids][]', '1'
368 362 assert_equal 'all', u.mail_notification
369 363 put :update, :id => 2,
370 364 :user => {
371 365 :mail_notification => 'selected',
372 366 :notified_project_ids => [1, 2]
373 367 }
374 368 u = User.find(2)
375 369 assert_equal 'selected', u.mail_notification
376 370 assert_equal [1, 2], u.notified_projects_ids.sort
377 371 end
378 372
379 373 def test_update_status_should_not_update_attributes
380 374 user = User.find(2)
381 375 user.pref[:no_self_notified] = '1'
382 376 user.pref.save
383 377
384 378 put :update, :id => 2, :user => {:status => 3}
385 379 assert_response 302
386 380 user = User.find(2)
387 381 assert_equal 3, user.status
388 382 assert_equal '1', user.pref[:no_self_notified]
389 383 end
390 384
391 385 def test_destroy
392 386 assert_difference 'User.count', -1 do
393 387 delete :destroy, :id => 2
394 388 end
395 389 assert_redirected_to '/users'
396 390 assert_nil User.find_by_id(2)
397 391 end
398 392
399 393 def test_destroy_should_be_denied_for_non_admin_users
400 394 @request.session[:user_id] = 3
401 395
402 396 assert_no_difference 'User.count' do
403 397 get :destroy, :id => 2
404 398 end
405 399 assert_response 403
406 400 end
407 401
408 402 def test_destroy_should_redirect_to_back_url_param
409 403 assert_difference 'User.count', -1 do
410 404 delete :destroy, :id => 2, :back_url => '/users?name=foo'
411 405 end
412 406 assert_redirected_to '/users?name=foo'
413 407 end
414 408
415 409 def test_create_membership
416 410 assert_difference 'Member.count' do
417 411 post :edit_membership, :id => 7, :membership => { :project_id => 3, :role_ids => [2]}
418 412 end
419 413 assert_redirected_to :action => 'edit', :id => '7', :tab => 'memberships'
420 414 member = Member.first(:order => 'id DESC')
421 415 assert_equal User.find(7), member.principal
422 416 assert_equal [2], member.role_ids
423 417 assert_equal 3, member.project_id
424 418 end
425 419
426 420 def test_create_membership_js_format
427 421 assert_difference 'Member.count' do
428 422 post :edit_membership, :id => 7, :membership => {:project_id => 3, :role_ids => [2]}, :format => 'js'
429 423 assert_response :success
430 424 assert_template 'edit_membership'
431 425 assert_equal 'text/javascript', response.content_type
432 426 end
433 427 member = Member.first(:order => 'id DESC')
434 428 assert_equal User.find(7), member.principal
435 429 assert_equal [2], member.role_ids
436 430 assert_equal 3, member.project_id
437 431 assert_include 'tab-content-memberships', response.body
438 432 end
439 433
440 434 def test_create_membership_js_format_with_failure
441 435 assert_no_difference 'Member.count' do
442 436 post :edit_membership, :id => 7, :membership => {:project_id => 3}, :format => 'js'
443 437 assert_response :success
444 438 assert_template 'edit_membership'
445 439 assert_equal 'text/javascript', response.content_type
446 440 end
447 441 assert_include 'alert', response.body, "Alert message not sent"
448 442 assert_include 'Role can\\\'t be empty', response.body, "Error message not sent"
449 443 end
450 444
451 445 def test_update_membership
452 446 assert_no_difference 'Member.count' do
453 447 put :edit_membership, :id => 2, :membership_id => 1, :membership => { :role_ids => [2]}
454 448 assert_redirected_to :action => 'edit', :id => '2', :tab => 'memberships'
455 449 end
456 450 assert_equal [2], Member.find(1).role_ids
457 451 end
458 452
459 453 def test_update_membership_js_format
460 454 assert_no_difference 'Member.count' do
461 455 put :edit_membership, :id => 2, :membership_id => 1, :membership => {:role_ids => [2]}, :format => 'js'
462 456 assert_response :success
463 457 assert_template 'edit_membership'
464 458 assert_equal 'text/javascript', response.content_type
465 459 end
466 460 assert_equal [2], Member.find(1).role_ids
467 461 assert_include 'tab-content-memberships', response.body
468 462 end
469 463
470 464 def test_destroy_membership
471 465 assert_difference 'Member.count', -1 do
472 466 delete :destroy_membership, :id => 2, :membership_id => 1
473 467 end
474 468 assert_redirected_to :action => 'edit', :id => '2', :tab => 'memberships'
475 469 assert_nil Member.find_by_id(1)
476 470 end
477 471
478 472 def test_destroy_membership_js_format
479 473 assert_difference 'Member.count', -1 do
480 474 delete :destroy_membership, :id => 2, :membership_id => 1, :format => 'js'
481 475 assert_response :success
482 476 assert_template 'destroy_membership'
483 477 assert_equal 'text/javascript', response.content_type
484 478 end
485 479 assert_nil Member.find_by_id(1)
486 480 assert_include 'tab-content-memberships', response.body
487 481 end
488 482 end
General Comments 0
You need to be logged in to leave comments. Login now