##// END OF EJS Templates
code layout clean up test_should_not_close_duplicated_issue of unit issue test...
Toshi MARUYAMA -
r10441:5ae73e3784e5
parent child
Show More
@@ -1,1792 +1,1793
1 # Redmine - project management software
1 # Redmine - project management software
2 # Copyright (C) 2006-2012 Jean-Philippe Lang
2 # Copyright (C) 2006-2012 Jean-Philippe Lang
3 #
3 #
4 # This program is free software; you can redistribute it and/or
4 # This program is free software; you can redistribute it and/or
5 # modify it under the terms of the GNU General Public License
5 # modify it under the terms of the GNU General Public License
6 # as published by the Free Software Foundation; either version 2
6 # as published by the Free Software Foundation; either version 2
7 # of the License, or (at your option) any later version.
7 # of the License, or (at your option) any later version.
8 #
8 #
9 # This program is distributed in the hope that it will be useful,
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
12 # GNU General Public License for more details.
13 #
13 #
14 # You should have received a copy of the GNU General Public License
14 # You should have received a copy of the GNU General Public License
15 # along with this program; if not, write to the Free Software
15 # along with this program; if not, write to the Free Software
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17
17
18 require File.expand_path('../../test_helper', __FILE__)
18 require File.expand_path('../../test_helper', __FILE__)
19
19
20 class IssueTest < ActiveSupport::TestCase
20 class IssueTest < ActiveSupport::TestCase
21 fixtures :projects, :users, :members, :member_roles, :roles,
21 fixtures :projects, :users, :members, :member_roles, :roles,
22 :groups_users,
22 :groups_users,
23 :trackers, :projects_trackers,
23 :trackers, :projects_trackers,
24 :enabled_modules,
24 :enabled_modules,
25 :versions,
25 :versions,
26 :issue_statuses, :issue_categories, :issue_relations, :workflows,
26 :issue_statuses, :issue_categories, :issue_relations, :workflows,
27 :enumerations,
27 :enumerations,
28 :issues, :journals, :journal_details,
28 :issues, :journals, :journal_details,
29 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
29 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
30 :time_entries
30 :time_entries
31
31
32 include Redmine::I18n
32 include Redmine::I18n
33
33
34 def teardown
34 def teardown
35 User.current = nil
35 User.current = nil
36 end
36 end
37
37
38 def test_create
38 def test_create
39 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
39 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
40 :status_id => 1, :priority => IssuePriority.all.first,
40 :status_id => 1, :priority => IssuePriority.all.first,
41 :subject => 'test_create',
41 :subject => 'test_create',
42 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
42 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
43 assert issue.save
43 assert issue.save
44 issue.reload
44 issue.reload
45 assert_equal 1.5, issue.estimated_hours
45 assert_equal 1.5, issue.estimated_hours
46 end
46 end
47
47
48 def test_create_minimal
48 def test_create_minimal
49 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
49 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
50 :status_id => 1, :priority => IssuePriority.all.first,
50 :status_id => 1, :priority => IssuePriority.all.first,
51 :subject => 'test_create')
51 :subject => 'test_create')
52 assert issue.save
52 assert issue.save
53 assert issue.description.nil?
53 assert issue.description.nil?
54 assert_nil issue.estimated_hours
54 assert_nil issue.estimated_hours
55 end
55 end
56
56
57 def test_create_with_required_custom_field
57 def test_create_with_required_custom_field
58 set_language_if_valid 'en'
58 set_language_if_valid 'en'
59 field = IssueCustomField.find_by_name('Database')
59 field = IssueCustomField.find_by_name('Database')
60 field.update_attribute(:is_required, true)
60 field.update_attribute(:is_required, true)
61
61
62 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
62 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
63 :status_id => 1, :subject => 'test_create',
63 :status_id => 1, :subject => 'test_create',
64 :description => 'IssueTest#test_create_with_required_custom_field')
64 :description => 'IssueTest#test_create_with_required_custom_field')
65 assert issue.available_custom_fields.include?(field)
65 assert issue.available_custom_fields.include?(field)
66 # No value for the custom field
66 # No value for the custom field
67 assert !issue.save
67 assert !issue.save
68 assert_equal ["Database can't be blank"], issue.errors.full_messages
68 assert_equal ["Database can't be blank"], issue.errors.full_messages
69 # Blank value
69 # Blank value
70 issue.custom_field_values = { field.id => '' }
70 issue.custom_field_values = { field.id => '' }
71 assert !issue.save
71 assert !issue.save
72 assert_equal ["Database can't be blank"], issue.errors.full_messages
72 assert_equal ["Database can't be blank"], issue.errors.full_messages
73 # Invalid value
73 # Invalid value
74 issue.custom_field_values = { field.id => 'SQLServer' }
74 issue.custom_field_values = { field.id => 'SQLServer' }
75 assert !issue.save
75 assert !issue.save
76 assert_equal ["Database is not included in the list"], issue.errors.full_messages
76 assert_equal ["Database is not included in the list"], issue.errors.full_messages
77 # Valid value
77 # Valid value
78 issue.custom_field_values = { field.id => 'PostgreSQL' }
78 issue.custom_field_values = { field.id => 'PostgreSQL' }
79 assert issue.save
79 assert issue.save
80 issue.reload
80 issue.reload
81 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
81 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
82 end
82 end
83
83
84 def test_create_with_group_assignment
84 def test_create_with_group_assignment
85 with_settings :issue_group_assignment => '1' do
85 with_settings :issue_group_assignment => '1' do
86 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
86 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
87 :subject => 'Group assignment',
87 :subject => 'Group assignment',
88 :assigned_to_id => 11).save
88 :assigned_to_id => 11).save
89 issue = Issue.first(:order => 'id DESC')
89 issue = Issue.first(:order => 'id DESC')
90 assert_kind_of Group, issue.assigned_to
90 assert_kind_of Group, issue.assigned_to
91 assert_equal Group.find(11), issue.assigned_to
91 assert_equal Group.find(11), issue.assigned_to
92 end
92 end
93 end
93 end
94
94
95 def test_create_with_parent_issue_id
95 def test_create_with_parent_issue_id
96 issue = Issue.new(:project_id => 1, :tracker_id => 1,
96 issue = Issue.new(:project_id => 1, :tracker_id => 1,
97 :author_id => 1, :subject => 'Group assignment',
97 :author_id => 1, :subject => 'Group assignment',
98 :parent_issue_id => 1)
98 :parent_issue_id => 1)
99 assert_save issue
99 assert_save issue
100 assert_equal 1, issue.parent_issue_id
100 assert_equal 1, issue.parent_issue_id
101 assert_equal Issue.find(1), issue.parent
101 assert_equal Issue.find(1), issue.parent
102 end
102 end
103
103
104 def test_create_with_sharp_parent_issue_id
104 def test_create_with_sharp_parent_issue_id
105 issue = Issue.new(:project_id => 1, :tracker_id => 1,
105 issue = Issue.new(:project_id => 1, :tracker_id => 1,
106 :author_id => 1, :subject => 'Group assignment',
106 :author_id => 1, :subject => 'Group assignment',
107 :parent_issue_id => "#1")
107 :parent_issue_id => "#1")
108 assert_save issue
108 assert_save issue
109 assert_equal 1, issue.parent_issue_id
109 assert_equal 1, issue.parent_issue_id
110 assert_equal Issue.find(1), issue.parent
110 assert_equal Issue.find(1), issue.parent
111 end
111 end
112
112
113 def test_create_with_invalid_parent_issue_id
113 def test_create_with_invalid_parent_issue_id
114 set_language_if_valid 'en'
114 set_language_if_valid 'en'
115 issue = Issue.new(:project_id => 1, :tracker_id => 1,
115 issue = Issue.new(:project_id => 1, :tracker_id => 1,
116 :author_id => 1, :subject => 'Group assignment',
116 :author_id => 1, :subject => 'Group assignment',
117 :parent_issue_id => '01ABC')
117 :parent_issue_id => '01ABC')
118 assert !issue.save
118 assert !issue.save
119 assert_equal '01ABC', issue.parent_issue_id
119 assert_equal '01ABC', issue.parent_issue_id
120 assert_include 'Parent task is invalid', issue.errors.full_messages
120 assert_include 'Parent task is invalid', issue.errors.full_messages
121 end
121 end
122
122
123 def test_create_with_invalid_sharp_parent_issue_id
123 def test_create_with_invalid_sharp_parent_issue_id
124 set_language_if_valid 'en'
124 set_language_if_valid 'en'
125 issue = Issue.new(:project_id => 1, :tracker_id => 1,
125 issue = Issue.new(:project_id => 1, :tracker_id => 1,
126 :author_id => 1, :subject => 'Group assignment',
126 :author_id => 1, :subject => 'Group assignment',
127 :parent_issue_id => '#01ABC')
127 :parent_issue_id => '#01ABC')
128 assert !issue.save
128 assert !issue.save
129 assert_equal '#01ABC', issue.parent_issue_id
129 assert_equal '#01ABC', issue.parent_issue_id
130 assert_include 'Parent task is invalid', issue.errors.full_messages
130 assert_include 'Parent task is invalid', issue.errors.full_messages
131 end
131 end
132
132
133 def assert_visibility_match(user, issues)
133 def assert_visibility_match(user, issues)
134 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
134 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
135 end
135 end
136
136
137 def test_visible_scope_for_anonymous
137 def test_visible_scope_for_anonymous
138 # Anonymous user should see issues of public projects only
138 # Anonymous user should see issues of public projects only
139 issues = Issue.visible(User.anonymous).all
139 issues = Issue.visible(User.anonymous).all
140 assert issues.any?
140 assert issues.any?
141 assert_nil issues.detect {|issue| !issue.project.is_public?}
141 assert_nil issues.detect {|issue| !issue.project.is_public?}
142 assert_nil issues.detect {|issue| issue.is_private?}
142 assert_nil issues.detect {|issue| issue.is_private?}
143 assert_visibility_match User.anonymous, issues
143 assert_visibility_match User.anonymous, issues
144 end
144 end
145
145
146 def test_visible_scope_for_anonymous_without_view_issues_permissions
146 def test_visible_scope_for_anonymous_without_view_issues_permissions
147 # Anonymous user should not see issues without permission
147 # Anonymous user should not see issues without permission
148 Role.anonymous.remove_permission!(:view_issues)
148 Role.anonymous.remove_permission!(:view_issues)
149 issues = Issue.visible(User.anonymous).all
149 issues = Issue.visible(User.anonymous).all
150 assert issues.empty?
150 assert issues.empty?
151 assert_visibility_match User.anonymous, issues
151 assert_visibility_match User.anonymous, issues
152 end
152 end
153
153
154 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
154 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
155 assert Role.anonymous.update_attribute(:issues_visibility, 'default')
155 assert Role.anonymous.update_attribute(:issues_visibility, 'default')
156 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
156 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
157 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
157 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
158 assert !issue.visible?(User.anonymous)
158 assert !issue.visible?(User.anonymous)
159 end
159 end
160
160
161 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
161 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
162 assert Role.anonymous.update_attribute(:issues_visibility, 'own')
162 assert Role.anonymous.update_attribute(:issues_visibility, 'own')
163 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
163 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
164 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
164 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
165 assert !issue.visible?(User.anonymous)
165 assert !issue.visible?(User.anonymous)
166 end
166 end
167
167
168 def test_visible_scope_for_non_member
168 def test_visible_scope_for_non_member
169 user = User.find(9)
169 user = User.find(9)
170 assert user.projects.empty?
170 assert user.projects.empty?
171 # Non member user should see issues of public projects only
171 # Non member user should see issues of public projects only
172 issues = Issue.visible(user).all
172 issues = Issue.visible(user).all
173 assert issues.any?
173 assert issues.any?
174 assert_nil issues.detect {|issue| !issue.project.is_public?}
174 assert_nil issues.detect {|issue| !issue.project.is_public?}
175 assert_nil issues.detect {|issue| issue.is_private?}
175 assert_nil issues.detect {|issue| issue.is_private?}
176 assert_visibility_match user, issues
176 assert_visibility_match user, issues
177 end
177 end
178
178
179 def test_visible_scope_for_non_member_with_own_issues_visibility
179 def test_visible_scope_for_non_member_with_own_issues_visibility
180 Role.non_member.update_attribute :issues_visibility, 'own'
180 Role.non_member.update_attribute :issues_visibility, 'own'
181 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
181 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
182 user = User.find(9)
182 user = User.find(9)
183
183
184 issues = Issue.visible(user).all
184 issues = Issue.visible(user).all
185 assert issues.any?
185 assert issues.any?
186 assert_nil issues.detect {|issue| issue.author != user}
186 assert_nil issues.detect {|issue| issue.author != user}
187 assert_visibility_match user, issues
187 assert_visibility_match user, issues
188 end
188 end
189
189
190 def test_visible_scope_for_non_member_without_view_issues_permissions
190 def test_visible_scope_for_non_member_without_view_issues_permissions
191 # Non member user should not see issues without permission
191 # Non member user should not see issues without permission
192 Role.non_member.remove_permission!(:view_issues)
192 Role.non_member.remove_permission!(:view_issues)
193 user = User.find(9)
193 user = User.find(9)
194 assert user.projects.empty?
194 assert user.projects.empty?
195 issues = Issue.visible(user).all
195 issues = Issue.visible(user).all
196 assert issues.empty?
196 assert issues.empty?
197 assert_visibility_match user, issues
197 assert_visibility_match user, issues
198 end
198 end
199
199
200 def test_visible_scope_for_member
200 def test_visible_scope_for_member
201 user = User.find(9)
201 user = User.find(9)
202 # User should see issues of projects for which he has view_issues permissions only
202 # User should see issues of projects for which he has view_issues permissions only
203 Role.non_member.remove_permission!(:view_issues)
203 Role.non_member.remove_permission!(:view_issues)
204 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
204 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
205 issues = Issue.visible(user).all
205 issues = Issue.visible(user).all
206 assert issues.any?
206 assert issues.any?
207 assert_nil issues.detect {|issue| issue.project_id != 3}
207 assert_nil issues.detect {|issue| issue.project_id != 3}
208 assert_nil issues.detect {|issue| issue.is_private?}
208 assert_nil issues.detect {|issue| issue.is_private?}
209 assert_visibility_match user, issues
209 assert_visibility_match user, issues
210 end
210 end
211
211
212 def test_visible_scope_for_member_with_groups_should_return_assigned_issues
212 def test_visible_scope_for_member_with_groups_should_return_assigned_issues
213 user = User.find(8)
213 user = User.find(8)
214 assert user.groups.any?
214 assert user.groups.any?
215 Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
215 Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
216 Role.non_member.remove_permission!(:view_issues)
216 Role.non_member.remove_permission!(:view_issues)
217
217
218 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
218 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
219 :status_id => 1, :priority => IssuePriority.all.first,
219 :status_id => 1, :priority => IssuePriority.all.first,
220 :subject => 'Assignment test',
220 :subject => 'Assignment test',
221 :assigned_to => user.groups.first,
221 :assigned_to => user.groups.first,
222 :is_private => true)
222 :is_private => true)
223
223
224 Role.find(2).update_attribute :issues_visibility, 'default'
224 Role.find(2).update_attribute :issues_visibility, 'default'
225 issues = Issue.visible(User.find(8)).all
225 issues = Issue.visible(User.find(8)).all
226 assert issues.any?
226 assert issues.any?
227 assert issues.include?(issue)
227 assert issues.include?(issue)
228
228
229 Role.find(2).update_attribute :issues_visibility, 'own'
229 Role.find(2).update_attribute :issues_visibility, 'own'
230 issues = Issue.visible(User.find(8)).all
230 issues = Issue.visible(User.find(8)).all
231 assert issues.any?
231 assert issues.any?
232 assert issues.include?(issue)
232 assert issues.include?(issue)
233 end
233 end
234
234
235 def test_visible_scope_for_admin
235 def test_visible_scope_for_admin
236 user = User.find(1)
236 user = User.find(1)
237 user.members.each(&:destroy)
237 user.members.each(&:destroy)
238 assert user.projects.empty?
238 assert user.projects.empty?
239 issues = Issue.visible(user).all
239 issues = Issue.visible(user).all
240 assert issues.any?
240 assert issues.any?
241 # Admin should see issues on private projects that he does not belong to
241 # Admin should see issues on private projects that he does not belong to
242 assert issues.detect {|issue| !issue.project.is_public?}
242 assert issues.detect {|issue| !issue.project.is_public?}
243 # Admin should see private issues of other users
243 # Admin should see private issues of other users
244 assert issues.detect {|issue| issue.is_private? && issue.author != user}
244 assert issues.detect {|issue| issue.is_private? && issue.author != user}
245 assert_visibility_match user, issues
245 assert_visibility_match user, issues
246 end
246 end
247
247
248 def test_visible_scope_with_project
248 def test_visible_scope_with_project
249 project = Project.find(1)
249 project = Project.find(1)
250 issues = Issue.visible(User.find(2), :project => project).all
250 issues = Issue.visible(User.find(2), :project => project).all
251 projects = issues.collect(&:project).uniq
251 projects = issues.collect(&:project).uniq
252 assert_equal 1, projects.size
252 assert_equal 1, projects.size
253 assert_equal project, projects.first
253 assert_equal project, projects.first
254 end
254 end
255
255
256 def test_visible_scope_with_project_and_subprojects
256 def test_visible_scope_with_project_and_subprojects
257 project = Project.find(1)
257 project = Project.find(1)
258 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
258 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
259 projects = issues.collect(&:project).uniq
259 projects = issues.collect(&:project).uniq
260 assert projects.size > 1
260 assert projects.size > 1
261 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
261 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
262 end
262 end
263
263
264 def test_visible_and_nested_set_scopes
264 def test_visible_and_nested_set_scopes
265 assert_equal 0, Issue.find(1).descendants.visible.all.size
265 assert_equal 0, Issue.find(1).descendants.visible.all.size
266 end
266 end
267
267
268 def test_open_scope
268 def test_open_scope
269 issues = Issue.open.all
269 issues = Issue.open.all
270 assert_nil issues.detect(&:closed?)
270 assert_nil issues.detect(&:closed?)
271 end
271 end
272
272
273 def test_open_scope_with_arg
273 def test_open_scope_with_arg
274 issues = Issue.open(false).all
274 issues = Issue.open(false).all
275 assert_equal issues, issues.select(&:closed?)
275 assert_equal issues, issues.select(&:closed?)
276 end
276 end
277
277
278 def test_errors_full_messages_should_include_custom_fields_errors
278 def test_errors_full_messages_should_include_custom_fields_errors
279 field = IssueCustomField.find_by_name('Database')
279 field = IssueCustomField.find_by_name('Database')
280
280
281 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
281 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
282 :status_id => 1, :subject => 'test_create',
282 :status_id => 1, :subject => 'test_create',
283 :description => 'IssueTest#test_create_with_required_custom_field')
283 :description => 'IssueTest#test_create_with_required_custom_field')
284 assert issue.available_custom_fields.include?(field)
284 assert issue.available_custom_fields.include?(field)
285 # Invalid value
285 # Invalid value
286 issue.custom_field_values = { field.id => 'SQLServer' }
286 issue.custom_field_values = { field.id => 'SQLServer' }
287
287
288 assert !issue.valid?
288 assert !issue.valid?
289 assert_equal 1, issue.errors.full_messages.size
289 assert_equal 1, issue.errors.full_messages.size
290 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
290 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
291 issue.errors.full_messages.first
291 issue.errors.full_messages.first
292 end
292 end
293
293
294 def test_update_issue_with_required_custom_field
294 def test_update_issue_with_required_custom_field
295 field = IssueCustomField.find_by_name('Database')
295 field = IssueCustomField.find_by_name('Database')
296 field.update_attribute(:is_required, true)
296 field.update_attribute(:is_required, true)
297
297
298 issue = Issue.find(1)
298 issue = Issue.find(1)
299 assert_nil issue.custom_value_for(field)
299 assert_nil issue.custom_value_for(field)
300 assert issue.available_custom_fields.include?(field)
300 assert issue.available_custom_fields.include?(field)
301 # No change to custom values, issue can be saved
301 # No change to custom values, issue can be saved
302 assert issue.save
302 assert issue.save
303 # Blank value
303 # Blank value
304 issue.custom_field_values = { field.id => '' }
304 issue.custom_field_values = { field.id => '' }
305 assert !issue.save
305 assert !issue.save
306 # Valid value
306 # Valid value
307 issue.custom_field_values = { field.id => 'PostgreSQL' }
307 issue.custom_field_values = { field.id => 'PostgreSQL' }
308 assert issue.save
308 assert issue.save
309 issue.reload
309 issue.reload
310 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
310 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
311 end
311 end
312
312
313 def test_should_not_update_attributes_if_custom_fields_validation_fails
313 def test_should_not_update_attributes_if_custom_fields_validation_fails
314 issue = Issue.find(1)
314 issue = Issue.find(1)
315 field = IssueCustomField.find_by_name('Database')
315 field = IssueCustomField.find_by_name('Database')
316 assert issue.available_custom_fields.include?(field)
316 assert issue.available_custom_fields.include?(field)
317
317
318 issue.custom_field_values = { field.id => 'Invalid' }
318 issue.custom_field_values = { field.id => 'Invalid' }
319 issue.subject = 'Should be not be saved'
319 issue.subject = 'Should be not be saved'
320 assert !issue.save
320 assert !issue.save
321
321
322 issue.reload
322 issue.reload
323 assert_equal "Can't print recipes", issue.subject
323 assert_equal "Can't print recipes", issue.subject
324 end
324 end
325
325
326 def test_should_not_recreate_custom_values_objects_on_update
326 def test_should_not_recreate_custom_values_objects_on_update
327 field = IssueCustomField.find_by_name('Database')
327 field = IssueCustomField.find_by_name('Database')
328
328
329 issue = Issue.find(1)
329 issue = Issue.find(1)
330 issue.custom_field_values = { field.id => 'PostgreSQL' }
330 issue.custom_field_values = { field.id => 'PostgreSQL' }
331 assert issue.save
331 assert issue.save
332 custom_value = issue.custom_value_for(field)
332 custom_value = issue.custom_value_for(field)
333 issue.reload
333 issue.reload
334 issue.custom_field_values = { field.id => 'MySQL' }
334 issue.custom_field_values = { field.id => 'MySQL' }
335 assert issue.save
335 assert issue.save
336 issue.reload
336 issue.reload
337 assert_equal custom_value.id, issue.custom_value_for(field).id
337 assert_equal custom_value.id, issue.custom_value_for(field).id
338 end
338 end
339
339
340 def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
340 def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
341 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
341 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
342 :status_id => 1, :subject => 'Test',
342 :status_id => 1, :subject => 'Test',
343 :custom_field_values => {'2' => 'Test'})
343 :custom_field_values => {'2' => 'Test'})
344 assert !Tracker.find(2).custom_field_ids.include?(2)
344 assert !Tracker.find(2).custom_field_ids.include?(2)
345
345
346 issue = Issue.find(issue.id)
346 issue = Issue.find(issue.id)
347 issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
347 issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
348
348
349 issue = Issue.find(issue.id)
349 issue = Issue.find(issue.id)
350 custom_value = issue.custom_value_for(2)
350 custom_value = issue.custom_value_for(2)
351 assert_not_nil custom_value
351 assert_not_nil custom_value
352 assert_equal 'Test', custom_value.value
352 assert_equal 'Test', custom_value.value
353 end
353 end
354
354
355 def test_assigning_tracker_id_should_reload_custom_fields_values
355 def test_assigning_tracker_id_should_reload_custom_fields_values
356 issue = Issue.new(:project => Project.find(1))
356 issue = Issue.new(:project => Project.find(1))
357 assert issue.custom_field_values.empty?
357 assert issue.custom_field_values.empty?
358 issue.tracker_id = 1
358 issue.tracker_id = 1
359 assert issue.custom_field_values.any?
359 assert issue.custom_field_values.any?
360 end
360 end
361
361
362 def test_assigning_attributes_should_assign_project_and_tracker_first
362 def test_assigning_attributes_should_assign_project_and_tracker_first
363 seq = sequence('seq')
363 seq = sequence('seq')
364 issue = Issue.new
364 issue = Issue.new
365 issue.expects(:project_id=).in_sequence(seq)
365 issue.expects(:project_id=).in_sequence(seq)
366 issue.expects(:tracker_id=).in_sequence(seq)
366 issue.expects(:tracker_id=).in_sequence(seq)
367 issue.expects(:subject=).in_sequence(seq)
367 issue.expects(:subject=).in_sequence(seq)
368 issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
368 issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
369 end
369 end
370
370
371 def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
371 def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
372 attributes = ActiveSupport::OrderedHash.new
372 attributes = ActiveSupport::OrderedHash.new
373 attributes['custom_field_values'] = { '1' => 'MySQL' }
373 attributes['custom_field_values'] = { '1' => 'MySQL' }
374 attributes['tracker_id'] = '1'
374 attributes['tracker_id'] = '1'
375 issue = Issue.new(:project => Project.find(1))
375 issue = Issue.new(:project => Project.find(1))
376 issue.attributes = attributes
376 issue.attributes = attributes
377 assert_equal 'MySQL', issue.custom_field_value(1)
377 assert_equal 'MySQL', issue.custom_field_value(1)
378 end
378 end
379
379
380 def test_should_update_issue_with_disabled_tracker
380 def test_should_update_issue_with_disabled_tracker
381 p = Project.find(1)
381 p = Project.find(1)
382 issue = Issue.find(1)
382 issue = Issue.find(1)
383
383
384 p.trackers.delete(issue.tracker)
384 p.trackers.delete(issue.tracker)
385 assert !p.trackers.include?(issue.tracker)
385 assert !p.trackers.include?(issue.tracker)
386
386
387 issue.reload
387 issue.reload
388 issue.subject = 'New subject'
388 issue.subject = 'New subject'
389 assert issue.save
389 assert issue.save
390 end
390 end
391
391
392 def test_should_not_set_a_disabled_tracker
392 def test_should_not_set_a_disabled_tracker
393 p = Project.find(1)
393 p = Project.find(1)
394 p.trackers.delete(Tracker.find(2))
394 p.trackers.delete(Tracker.find(2))
395
395
396 issue = Issue.find(1)
396 issue = Issue.find(1)
397 issue.tracker_id = 2
397 issue.tracker_id = 2
398 issue.subject = 'New subject'
398 issue.subject = 'New subject'
399 assert !issue.save
399 assert !issue.save
400 assert_not_nil issue.errors[:tracker_id]
400 assert_not_nil issue.errors[:tracker_id]
401 end
401 end
402
402
403 def test_category_based_assignment
403 def test_category_based_assignment
404 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
404 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
405 :status_id => 1, :priority => IssuePriority.all.first,
405 :status_id => 1, :priority => IssuePriority.all.first,
406 :subject => 'Assignment test',
406 :subject => 'Assignment test',
407 :description => 'Assignment test', :category_id => 1)
407 :description => 'Assignment test', :category_id => 1)
408 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
408 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
409 end
409 end
410
410
411 def test_new_statuses_allowed_to
411 def test_new_statuses_allowed_to
412 WorkflowTransition.delete_all
412 WorkflowTransition.delete_all
413 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
413 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
414 :old_status_id => 1, :new_status_id => 2,
414 :old_status_id => 1, :new_status_id => 2,
415 :author => false, :assignee => false)
415 :author => false, :assignee => false)
416 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
416 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
417 :old_status_id => 1, :new_status_id => 3,
417 :old_status_id => 1, :new_status_id => 3,
418 :author => true, :assignee => false)
418 :author => true, :assignee => false)
419 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1,
419 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1,
420 :new_status_id => 4, :author => false,
420 :new_status_id => 4, :author => false,
421 :assignee => true)
421 :assignee => true)
422 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
422 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
423 :old_status_id => 1, :new_status_id => 5,
423 :old_status_id => 1, :new_status_id => 5,
424 :author => true, :assignee => true)
424 :author => true, :assignee => true)
425 status = IssueStatus.find(1)
425 status = IssueStatus.find(1)
426 role = Role.find(1)
426 role = Role.find(1)
427 tracker = Tracker.find(1)
427 tracker = Tracker.find(1)
428 user = User.find(2)
428 user = User.find(2)
429
429
430 issue = Issue.generate!(:tracker => tracker, :status => status,
430 issue = Issue.generate!(:tracker => tracker, :status => status,
431 :project_id => 1, :author_id => 1)
431 :project_id => 1, :author_id => 1)
432 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
432 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
433
433
434 issue = Issue.generate!(:tracker => tracker, :status => status,
434 issue = Issue.generate!(:tracker => tracker, :status => status,
435 :project_id => 1, :author => user)
435 :project_id => 1, :author => user)
436 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
436 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
437
437
438 issue = Issue.generate!(:tracker => tracker, :status => status,
438 issue = Issue.generate!(:tracker => tracker, :status => status,
439 :project_id => 1, :author_id => 1,
439 :project_id => 1, :author_id => 1,
440 :assigned_to => user)
440 :assigned_to => user)
441 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
441 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
442
442
443 issue = Issue.generate!(:tracker => tracker, :status => status,
443 issue = Issue.generate!(:tracker => tracker, :status => status,
444 :project_id => 1, :author => user,
444 :project_id => 1, :author => user,
445 :assigned_to => user)
445 :assigned_to => user)
446 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
446 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
447 end
447 end
448
448
449 def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
449 def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
450 admin = User.find(1)
450 admin = User.find(1)
451 issue = Issue.find(1)
451 issue = Issue.find(1)
452 assert !admin.member_of?(issue.project)
452 assert !admin.member_of?(issue.project)
453 expected_statuses = [issue.status] +
453 expected_statuses = [issue.status] +
454 WorkflowTransition.find_all_by_old_status_id(
454 WorkflowTransition.find_all_by_old_status_id(
455 issue.status_id).map(&:new_status).uniq.sort
455 issue.status_id).map(&:new_status).uniq.sort
456 assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
456 assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
457 end
457 end
458
458
459 def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
459 def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
460 issue = Issue.find(1).copy
460 issue = Issue.find(1).copy
461 assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
461 assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
462
462
463 issue = Issue.find(2).copy
463 issue = Issue.find(2).copy
464 assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
464 assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
465 end
465 end
466
466
467 def test_safe_attributes_names_should_not_include_disabled_field
467 def test_safe_attributes_names_should_not_include_disabled_field
468 tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
468 tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
469
469
470 issue = Issue.new(:tracker => tracker)
470 issue = Issue.new(:tracker => tracker)
471 assert_include 'tracker_id', issue.safe_attribute_names
471 assert_include 'tracker_id', issue.safe_attribute_names
472 assert_include 'status_id', issue.safe_attribute_names
472 assert_include 'status_id', issue.safe_attribute_names
473 assert_include 'subject', issue.safe_attribute_names
473 assert_include 'subject', issue.safe_attribute_names
474 assert_include 'description', issue.safe_attribute_names
474 assert_include 'description', issue.safe_attribute_names
475 assert_include 'custom_field_values', issue.safe_attribute_names
475 assert_include 'custom_field_values', issue.safe_attribute_names
476 assert_include 'custom_fields', issue.safe_attribute_names
476 assert_include 'custom_fields', issue.safe_attribute_names
477 assert_include 'lock_version', issue.safe_attribute_names
477 assert_include 'lock_version', issue.safe_attribute_names
478
478
479 tracker.core_fields.each do |field|
479 tracker.core_fields.each do |field|
480 assert_include field, issue.safe_attribute_names
480 assert_include field, issue.safe_attribute_names
481 end
481 end
482
482
483 tracker.disabled_core_fields.each do |field|
483 tracker.disabled_core_fields.each do |field|
484 assert_not_include field, issue.safe_attribute_names
484 assert_not_include field, issue.safe_attribute_names
485 end
485 end
486 end
486 end
487
487
488 def test_safe_attributes_should_ignore_disabled_fields
488 def test_safe_attributes_should_ignore_disabled_fields
489 tracker = Tracker.find(1)
489 tracker = Tracker.find(1)
490 tracker.core_fields = %w(assigned_to_id due_date)
490 tracker.core_fields = %w(assigned_to_id due_date)
491 tracker.save!
491 tracker.save!
492
492
493 issue = Issue.new(:tracker => tracker)
493 issue = Issue.new(:tracker => tracker)
494 issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
494 issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
495 assert_nil issue.start_date
495 assert_nil issue.start_date
496 assert_equal Date.parse('2012-07-14'), issue.due_date
496 assert_equal Date.parse('2012-07-14'), issue.due_date
497 end
497 end
498
498
499 def test_safe_attributes_should_accept_target_tracker_enabled_fields
499 def test_safe_attributes_should_accept_target_tracker_enabled_fields
500 source = Tracker.find(1)
500 source = Tracker.find(1)
501 source.core_fields = []
501 source.core_fields = []
502 source.save!
502 source.save!
503 target = Tracker.find(2)
503 target = Tracker.find(2)
504 target.core_fields = %w(assigned_to_id due_date)
504 target.core_fields = %w(assigned_to_id due_date)
505 target.save!
505 target.save!
506
506
507 issue = Issue.new(:tracker => source)
507 issue = Issue.new(:tracker => source)
508 issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
508 issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
509 assert_equal target, issue.tracker
509 assert_equal target, issue.tracker
510 assert_equal Date.parse('2012-07-14'), issue.due_date
510 assert_equal Date.parse('2012-07-14'), issue.due_date
511 end
511 end
512
512
513 def test_safe_attributes_should_not_include_readonly_fields
513 def test_safe_attributes_should_not_include_readonly_fields
514 WorkflowPermission.delete_all
514 WorkflowPermission.delete_all
515 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
515 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
516 :role_id => 1, :field_name => 'due_date',
516 :role_id => 1, :field_name => 'due_date',
517 :rule => 'readonly')
517 :rule => 'readonly')
518 user = User.find(2)
518 user = User.find(2)
519
519
520 issue = Issue.new(:project_id => 1, :tracker_id => 1)
520 issue = Issue.new(:project_id => 1, :tracker_id => 1)
521 assert_equal %w(due_date), issue.read_only_attribute_names(user)
521 assert_equal %w(due_date), issue.read_only_attribute_names(user)
522 assert_not_include 'due_date', issue.safe_attribute_names(user)
522 assert_not_include 'due_date', issue.safe_attribute_names(user)
523
523
524 issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
524 issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
525 assert_equal Date.parse('2012-07-14'), issue.start_date
525 assert_equal Date.parse('2012-07-14'), issue.start_date
526 assert_nil issue.due_date
526 assert_nil issue.due_date
527 end
527 end
528
528
529 def test_safe_attributes_should_not_include_readonly_custom_fields
529 def test_safe_attributes_should_not_include_readonly_custom_fields
530 cf1 = IssueCustomField.create!(:name => 'Writable field',
530 cf1 = IssueCustomField.create!(:name => 'Writable field',
531 :field_format => 'string',
531 :field_format => 'string',
532 :is_for_all => true, :tracker_ids => [1])
532 :is_for_all => true, :tracker_ids => [1])
533 cf2 = IssueCustomField.create!(:name => 'Readonly field',
533 cf2 = IssueCustomField.create!(:name => 'Readonly field',
534 :field_format => 'string',
534 :field_format => 'string',
535 :is_for_all => true, :tracker_ids => [1])
535 :is_for_all => true, :tracker_ids => [1])
536 WorkflowPermission.delete_all
536 WorkflowPermission.delete_all
537 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
537 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
538 :role_id => 1, :field_name => cf2.id.to_s,
538 :role_id => 1, :field_name => cf2.id.to_s,
539 :rule => 'readonly')
539 :rule => 'readonly')
540 user = User.find(2)
540 user = User.find(2)
541 issue = Issue.new(:project_id => 1, :tracker_id => 1)
541 issue = Issue.new(:project_id => 1, :tracker_id => 1)
542 assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
542 assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
543 assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
543 assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
544
544
545 issue.send :safe_attributes=, {'custom_field_values' => {
545 issue.send :safe_attributes=, {'custom_field_values' => {
546 cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
546 cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
547 }}, user
547 }}, user
548 assert_equal 'value1', issue.custom_field_value(cf1)
548 assert_equal 'value1', issue.custom_field_value(cf1)
549 assert_nil issue.custom_field_value(cf2)
549 assert_nil issue.custom_field_value(cf2)
550
550
551 issue.send :safe_attributes=, {'custom_fields' => [
551 issue.send :safe_attributes=, {'custom_fields' => [
552 {'id' => cf1.id.to_s, 'value' => 'valuea'},
552 {'id' => cf1.id.to_s, 'value' => 'valuea'},
553 {'id' => cf2.id.to_s, 'value' => 'valueb'}
553 {'id' => cf2.id.to_s, 'value' => 'valueb'}
554 ]}, user
554 ]}, user
555 assert_equal 'valuea', issue.custom_field_value(cf1)
555 assert_equal 'valuea', issue.custom_field_value(cf1)
556 assert_nil issue.custom_field_value(cf2)
556 assert_nil issue.custom_field_value(cf2)
557 end
557 end
558
558
559 def test_editable_custom_field_values_should_return_non_readonly_custom_values
559 def test_editable_custom_field_values_should_return_non_readonly_custom_values
560 cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
560 cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
561 :is_for_all => true, :tracker_ids => [1, 2])
561 :is_for_all => true, :tracker_ids => [1, 2])
562 cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
562 cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
563 :is_for_all => true, :tracker_ids => [1, 2])
563 :is_for_all => true, :tracker_ids => [1, 2])
564 WorkflowPermission.delete_all
564 WorkflowPermission.delete_all
565 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
565 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
566 :field_name => cf2.id.to_s, :rule => 'readonly')
566 :field_name => cf2.id.to_s, :rule => 'readonly')
567 user = User.find(2)
567 user = User.find(2)
568
568
569 issue = Issue.new(:project_id => 1, :tracker_id => 1)
569 issue = Issue.new(:project_id => 1, :tracker_id => 1)
570 values = issue.editable_custom_field_values(user)
570 values = issue.editable_custom_field_values(user)
571 assert values.detect {|value| value.custom_field == cf1}
571 assert values.detect {|value| value.custom_field == cf1}
572 assert_nil values.detect {|value| value.custom_field == cf2}
572 assert_nil values.detect {|value| value.custom_field == cf2}
573
573
574 issue.tracker_id = 2
574 issue.tracker_id = 2
575 values = issue.editable_custom_field_values(user)
575 values = issue.editable_custom_field_values(user)
576 assert values.detect {|value| value.custom_field == cf1}
576 assert values.detect {|value| value.custom_field == cf1}
577 assert values.detect {|value| value.custom_field == cf2}
577 assert values.detect {|value| value.custom_field == cf2}
578 end
578 end
579
579
580 def test_safe_attributes_should_accept_target_tracker_writable_fields
580 def test_safe_attributes_should_accept_target_tracker_writable_fields
581 WorkflowPermission.delete_all
581 WorkflowPermission.delete_all
582 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
582 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
583 :role_id => 1, :field_name => 'due_date',
583 :role_id => 1, :field_name => 'due_date',
584 :rule => 'readonly')
584 :rule => 'readonly')
585 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
585 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
586 :role_id => 1, :field_name => 'start_date',
586 :role_id => 1, :field_name => 'start_date',
587 :rule => 'readonly')
587 :rule => 'readonly')
588 user = User.find(2)
588 user = User.find(2)
589
589
590 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
590 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
591
591
592 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
592 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
593 'due_date' => '2012-07-14'}, user
593 'due_date' => '2012-07-14'}, user
594 assert_equal Date.parse('2012-07-12'), issue.start_date
594 assert_equal Date.parse('2012-07-12'), issue.start_date
595 assert_nil issue.due_date
595 assert_nil issue.due_date
596
596
597 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
597 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
598 'due_date' => '2012-07-16',
598 'due_date' => '2012-07-16',
599 'tracker_id' => 2}, user
599 'tracker_id' => 2}, user
600 assert_equal Date.parse('2012-07-12'), issue.start_date
600 assert_equal Date.parse('2012-07-12'), issue.start_date
601 assert_equal Date.parse('2012-07-16'), issue.due_date
601 assert_equal Date.parse('2012-07-16'), issue.due_date
602 end
602 end
603
603
604 def test_safe_attributes_should_accept_target_status_writable_fields
604 def test_safe_attributes_should_accept_target_status_writable_fields
605 WorkflowPermission.delete_all
605 WorkflowPermission.delete_all
606 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
606 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
607 :role_id => 1, :field_name => 'due_date',
607 :role_id => 1, :field_name => 'due_date',
608 :rule => 'readonly')
608 :rule => 'readonly')
609 WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
609 WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
610 :role_id => 1, :field_name => 'start_date',
610 :role_id => 1, :field_name => 'start_date',
611 :rule => 'readonly')
611 :rule => 'readonly')
612 user = User.find(2)
612 user = User.find(2)
613
613
614 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
614 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
615
615
616 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
616 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
617 'due_date' => '2012-07-14'},
617 'due_date' => '2012-07-14'},
618 user
618 user
619 assert_equal Date.parse('2012-07-12'), issue.start_date
619 assert_equal Date.parse('2012-07-12'), issue.start_date
620 assert_nil issue.due_date
620 assert_nil issue.due_date
621
621
622 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
622 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
623 'due_date' => '2012-07-16',
623 'due_date' => '2012-07-16',
624 'status_id' => 2},
624 'status_id' => 2},
625 user
625 user
626 assert_equal Date.parse('2012-07-12'), issue.start_date
626 assert_equal Date.parse('2012-07-12'), issue.start_date
627 assert_equal Date.parse('2012-07-16'), issue.due_date
627 assert_equal Date.parse('2012-07-16'), issue.due_date
628 end
628 end
629
629
630 def test_required_attributes_should_be_validated
630 def test_required_attributes_should_be_validated
631 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
631 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
632 :is_for_all => true, :tracker_ids => [1, 2])
632 :is_for_all => true, :tracker_ids => [1, 2])
633
633
634 WorkflowPermission.delete_all
634 WorkflowPermission.delete_all
635 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
635 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
636 :role_id => 1, :field_name => 'due_date',
636 :role_id => 1, :field_name => 'due_date',
637 :rule => 'required')
637 :rule => 'required')
638 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
638 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
639 :role_id => 1, :field_name => 'category_id',
639 :role_id => 1, :field_name => 'category_id',
640 :rule => 'required')
640 :rule => 'required')
641 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
641 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
642 :role_id => 1, :field_name => cf.id.to_s,
642 :role_id => 1, :field_name => cf.id.to_s,
643 :rule => 'required')
643 :rule => 'required')
644
644
645 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
645 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
646 :role_id => 1, :field_name => 'start_date',
646 :role_id => 1, :field_name => 'start_date',
647 :rule => 'required')
647 :rule => 'required')
648 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
648 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
649 :role_id => 1, :field_name => cf.id.to_s,
649 :role_id => 1, :field_name => cf.id.to_s,
650 :rule => 'required')
650 :rule => 'required')
651 user = User.find(2)
651 user = User.find(2)
652
652
653 issue = Issue.new(:project_id => 1, :tracker_id => 1,
653 issue = Issue.new(:project_id => 1, :tracker_id => 1,
654 :status_id => 1, :subject => 'Required fields',
654 :status_id => 1, :subject => 'Required fields',
655 :author => user)
655 :author => user)
656 assert_equal [cf.id.to_s, "category_id", "due_date"],
656 assert_equal [cf.id.to_s, "category_id", "due_date"],
657 issue.required_attribute_names(user).sort
657 issue.required_attribute_names(user).sort
658 assert !issue.save, "Issue was saved"
658 assert !issue.save, "Issue was saved"
659 assert_equal ["Category can't be blank", "Due date can't be blank", "Foo can't be blank"],
659 assert_equal ["Category can't be blank", "Due date can't be blank", "Foo can't be blank"],
660 issue.errors.full_messages.sort
660 issue.errors.full_messages.sort
661
661
662 issue.tracker_id = 2
662 issue.tracker_id = 2
663 assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
663 assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
664 assert !issue.save, "Issue was saved"
664 assert !issue.save, "Issue was saved"
665 assert_equal ["Foo can't be blank", "Start date can't be blank"],
665 assert_equal ["Foo can't be blank", "Start date can't be blank"],
666 issue.errors.full_messages.sort
666 issue.errors.full_messages.sort
667
667
668 issue.start_date = Date.today
668 issue.start_date = Date.today
669 issue.custom_field_values = {cf.id.to_s => 'bar'}
669 issue.custom_field_values = {cf.id.to_s => 'bar'}
670 assert issue.save
670 assert issue.save
671 end
671 end
672
672
673 def test_required_attribute_names_for_multiple_roles_should_intersect_rules
673 def test_required_attribute_names_for_multiple_roles_should_intersect_rules
674 WorkflowPermission.delete_all
674 WorkflowPermission.delete_all
675 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
675 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
676 :role_id => 1, :field_name => 'due_date',
676 :role_id => 1, :field_name => 'due_date',
677 :rule => 'required')
677 :rule => 'required')
678 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
678 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
679 :role_id => 1, :field_name => 'start_date',
679 :role_id => 1, :field_name => 'start_date',
680 :rule => 'required')
680 :rule => 'required')
681 user = User.find(2)
681 user = User.find(2)
682 member = Member.find(1)
682 member = Member.find(1)
683 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
683 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
684
684
685 assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
685 assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
686
686
687 member.role_ids = [1, 2]
687 member.role_ids = [1, 2]
688 member.save!
688 member.save!
689 assert_equal [], issue.required_attribute_names(user.reload)
689 assert_equal [], issue.required_attribute_names(user.reload)
690
690
691 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
691 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
692 :role_id => 2, :field_name => 'due_date',
692 :role_id => 2, :field_name => 'due_date',
693 :rule => 'required')
693 :rule => 'required')
694 assert_equal %w(due_date), issue.required_attribute_names(user)
694 assert_equal %w(due_date), issue.required_attribute_names(user)
695
695
696 member.role_ids = [1, 2, 3]
696 member.role_ids = [1, 2, 3]
697 member.save!
697 member.save!
698 assert_equal [], issue.required_attribute_names(user.reload)
698 assert_equal [], issue.required_attribute_names(user.reload)
699
699
700 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
700 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
701 :role_id => 2, :field_name => 'due_date',
701 :role_id => 2, :field_name => 'due_date',
702 :rule => 'readonly')
702 :rule => 'readonly')
703 # required + readonly => required
703 # required + readonly => required
704 assert_equal %w(due_date), issue.required_attribute_names(user)
704 assert_equal %w(due_date), issue.required_attribute_names(user)
705 end
705 end
706
706
707 def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
707 def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
708 WorkflowPermission.delete_all
708 WorkflowPermission.delete_all
709 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
709 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
710 :role_id => 1, :field_name => 'due_date',
710 :role_id => 1, :field_name => 'due_date',
711 :rule => 'readonly')
711 :rule => 'readonly')
712 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
712 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
713 :role_id => 1, :field_name => 'start_date',
713 :role_id => 1, :field_name => 'start_date',
714 :rule => 'readonly')
714 :rule => 'readonly')
715 user = User.find(2)
715 user = User.find(2)
716 member = Member.find(1)
716 member = Member.find(1)
717 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
717 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
718
718
719 assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
719 assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
720
720
721 member.role_ids = [1, 2]
721 member.role_ids = [1, 2]
722 member.save!
722 member.save!
723 assert_equal [], issue.read_only_attribute_names(user.reload)
723 assert_equal [], issue.read_only_attribute_names(user.reload)
724
724
725 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
725 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
726 :role_id => 2, :field_name => 'due_date',
726 :role_id => 2, :field_name => 'due_date',
727 :rule => 'readonly')
727 :rule => 'readonly')
728 assert_equal %w(due_date), issue.read_only_attribute_names(user)
728 assert_equal %w(due_date), issue.read_only_attribute_names(user)
729 end
729 end
730
730
731 def test_copy
731 def test_copy
732 issue = Issue.new.copy_from(1)
732 issue = Issue.new.copy_from(1)
733 assert issue.copy?
733 assert issue.copy?
734 assert issue.save
734 assert issue.save
735 issue.reload
735 issue.reload
736 orig = Issue.find(1)
736 orig = Issue.find(1)
737 assert_equal orig.subject, issue.subject
737 assert_equal orig.subject, issue.subject
738 assert_equal orig.tracker, issue.tracker
738 assert_equal orig.tracker, issue.tracker
739 assert_equal "125", issue.custom_value_for(2).value
739 assert_equal "125", issue.custom_value_for(2).value
740 end
740 end
741
741
742 def test_copy_should_copy_status
742 def test_copy_should_copy_status
743 orig = Issue.find(8)
743 orig = Issue.find(8)
744 assert orig.status != IssueStatus.default
744 assert orig.status != IssueStatus.default
745
745
746 issue = Issue.new.copy_from(orig)
746 issue = Issue.new.copy_from(orig)
747 assert issue.save
747 assert issue.save
748 issue.reload
748 issue.reload
749 assert_equal orig.status, issue.status
749 assert_equal orig.status, issue.status
750 end
750 end
751
751
752 def test_copy_should_add_relation_with_copied_issue
752 def test_copy_should_add_relation_with_copied_issue
753 copied = Issue.find(1)
753 copied = Issue.find(1)
754 issue = Issue.new.copy_from(copied)
754 issue = Issue.new.copy_from(copied)
755 assert issue.save
755 assert issue.save
756 issue.reload
756 issue.reload
757
757
758 assert_equal 1, issue.relations.size
758 assert_equal 1, issue.relations.size
759 relation = issue.relations.first
759 relation = issue.relations.first
760 assert_equal 'copied_to', relation.relation_type
760 assert_equal 'copied_to', relation.relation_type
761 assert_equal copied, relation.issue_from
761 assert_equal copied, relation.issue_from
762 assert_equal issue, relation.issue_to
762 assert_equal issue, relation.issue_to
763 end
763 end
764
764
765 def test_copy_should_copy_subtasks
765 def test_copy_should_copy_subtasks
766 issue = Issue.generate_with_descendants!
766 issue = Issue.generate_with_descendants!
767
767
768 copy = issue.reload.copy
768 copy = issue.reload.copy
769 copy.author = User.find(7)
769 copy.author = User.find(7)
770 assert_difference 'Issue.count', 1+issue.descendants.count do
770 assert_difference 'Issue.count', 1+issue.descendants.count do
771 assert copy.save
771 assert copy.save
772 end
772 end
773 copy.reload
773 copy.reload
774 assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
774 assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
775 child_copy = copy.children.detect {|c| c.subject == 'Child1'}
775 child_copy = copy.children.detect {|c| c.subject == 'Child1'}
776 assert_equal %w(Child11), child_copy.children.map(&:subject).sort
776 assert_equal %w(Child11), child_copy.children.map(&:subject).sort
777 assert_equal copy.author, child_copy.author
777 assert_equal copy.author, child_copy.author
778 end
778 end
779
779
780 def test_copy_should_copy_subtasks_to_target_project
780 def test_copy_should_copy_subtasks_to_target_project
781 issue = Issue.generate_with_descendants!
781 issue = Issue.generate_with_descendants!
782
782
783 copy = issue.copy(:project_id => 3)
783 copy = issue.copy(:project_id => 3)
784 assert_difference 'Issue.count', 1+issue.descendants.count do
784 assert_difference 'Issue.count', 1+issue.descendants.count do
785 assert copy.save
785 assert copy.save
786 end
786 end
787 assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
787 assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
788 end
788 end
789
789
790 def test_copy_should_not_copy_subtasks_twice_when_saving_twice
790 def test_copy_should_not_copy_subtasks_twice_when_saving_twice
791 issue = Issue.generate_with_descendants!
791 issue = Issue.generate_with_descendants!
792
792
793 copy = issue.reload.copy
793 copy = issue.reload.copy
794 assert_difference 'Issue.count', 1+issue.descendants.count do
794 assert_difference 'Issue.count', 1+issue.descendants.count do
795 assert copy.save
795 assert copy.save
796 assert copy.save
796 assert copy.save
797 end
797 end
798 end
798 end
799
799
800 def test_should_not_call_after_project_change_on_creation
800 def test_should_not_call_after_project_change_on_creation
801 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
801 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
802 :subject => 'Test', :author_id => 1)
802 :subject => 'Test', :author_id => 1)
803 issue.expects(:after_project_change).never
803 issue.expects(:after_project_change).never
804 issue.save!
804 issue.save!
805 end
805 end
806
806
807 def test_should_not_call_after_project_change_on_update
807 def test_should_not_call_after_project_change_on_update
808 issue = Issue.find(1)
808 issue = Issue.find(1)
809 issue.project = Project.find(1)
809 issue.project = Project.find(1)
810 issue.subject = 'No project change'
810 issue.subject = 'No project change'
811 issue.expects(:after_project_change).never
811 issue.expects(:after_project_change).never
812 issue.save!
812 issue.save!
813 end
813 end
814
814
815 def test_should_call_after_project_change_on_project_change
815 def test_should_call_after_project_change_on_project_change
816 issue = Issue.find(1)
816 issue = Issue.find(1)
817 issue.project = Project.find(2)
817 issue.project = Project.find(2)
818 issue.expects(:after_project_change).once
818 issue.expects(:after_project_change).once
819 issue.save!
819 issue.save!
820 end
820 end
821
821
822 def test_adding_journal_should_update_timestamp
822 def test_adding_journal_should_update_timestamp
823 issue = Issue.find(1)
823 issue = Issue.find(1)
824 updated_on_was = issue.updated_on
824 updated_on_was = issue.updated_on
825
825
826 issue.init_journal(User.first, "Adding notes")
826 issue.init_journal(User.first, "Adding notes")
827 assert_difference 'Journal.count' do
827 assert_difference 'Journal.count' do
828 assert issue.save
828 assert issue.save
829 end
829 end
830 issue.reload
830 issue.reload
831
831
832 assert_not_equal updated_on_was, issue.updated_on
832 assert_not_equal updated_on_was, issue.updated_on
833 end
833 end
834
834
835 def test_should_close_duplicates
835 def test_should_close_duplicates
836 # Create 3 issues
836 # Create 3 issues
837 issue1 = Issue.generate!
837 issue1 = Issue.generate!
838 issue2 = Issue.generate!
838 issue2 = Issue.generate!
839 issue3 = Issue.generate!
839 issue3 = Issue.generate!
840
840
841 # 2 is a dupe of 1
841 # 2 is a dupe of 1
842 IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
842 IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
843 :relation_type => IssueRelation::TYPE_DUPLICATES)
843 :relation_type => IssueRelation::TYPE_DUPLICATES)
844 # And 3 is a dupe of 2
844 # And 3 is a dupe of 2
845 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
845 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
846 :relation_type => IssueRelation::TYPE_DUPLICATES)
846 :relation_type => IssueRelation::TYPE_DUPLICATES)
847 # And 3 is a dupe of 1 (circular duplicates)
847 # And 3 is a dupe of 1 (circular duplicates)
848 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
848 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
849 :relation_type => IssueRelation::TYPE_DUPLICATES)
849 :relation_type => IssueRelation::TYPE_DUPLICATES)
850
850
851 assert issue1.reload.duplicates.include?(issue2)
851 assert issue1.reload.duplicates.include?(issue2)
852
852
853 # Closing issue 1
853 # Closing issue 1
854 issue1.init_journal(User.find(:first), "Closing issue1")
854 issue1.init_journal(User.find(:first), "Closing issue1")
855 issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
855 issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
856 assert issue1.save
856 assert issue1.save
857 # 2 and 3 should be also closed
857 # 2 and 3 should be also closed
858 assert issue2.reload.closed?
858 assert issue2.reload.closed?
859 assert issue3.reload.closed?
859 assert issue3.reload.closed?
860 end
860 end
861
861
862 def test_should_not_close_duplicated_issue
862 def test_should_not_close_duplicated_issue
863 issue1 = Issue.generate!
863 issue1 = Issue.generate!
864 issue2 = Issue.generate!
864 issue2 = Issue.generate!
865
865
866 # 2 is a dupe of 1
866 # 2 is a dupe of 1
867 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
867 IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
868 :relation_type => IssueRelation::TYPE_DUPLICATES)
868 # 2 is a dup of 1 but 1 is not a duplicate of 2
869 # 2 is a dup of 1 but 1 is not a duplicate of 2
869 assert !issue2.reload.duplicates.include?(issue1)
870 assert !issue2.reload.duplicates.include?(issue1)
870
871
871 # Closing issue 2
872 # Closing issue 2
872 issue2.init_journal(User.find(:first), "Closing issue2")
873 issue2.init_journal(User.find(:first), "Closing issue2")
873 issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
874 issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
874 assert issue2.save
875 assert issue2.save
875 # 1 should not be also closed
876 # 1 should not be also closed
876 assert !issue1.reload.closed?
877 assert !issue1.reload.closed?
877 end
878 end
878
879
879 def test_assignable_versions
880 def test_assignable_versions
880 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
881 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
881 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
882 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
882 end
883 end
883
884
884 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
885 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
885 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
886 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
886 assert !issue.save
887 assert !issue.save
887 assert_not_nil issue.errors[:fixed_version_id]
888 assert_not_nil issue.errors[:fixed_version_id]
888 end
889 end
889
890
890 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
891 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
891 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
892 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
892 assert !issue.save
893 assert !issue.save
893 assert_not_nil issue.errors[:fixed_version_id]
894 assert_not_nil issue.errors[:fixed_version_id]
894 end
895 end
895
896
896 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
897 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
897 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
898 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
898 :status_id => 1, :fixed_version_id => 3,
899 :status_id => 1, :fixed_version_id => 3,
899 :subject => 'New issue')
900 :subject => 'New issue')
900 assert issue.save
901 assert issue.save
901 end
902 end
902
903
903 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
904 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
904 issue = Issue.find(11)
905 issue = Issue.find(11)
905 assert_equal 'closed', issue.fixed_version.status
906 assert_equal 'closed', issue.fixed_version.status
906 issue.subject = 'Subject changed'
907 issue.subject = 'Subject changed'
907 assert issue.save
908 assert issue.save
908 end
909 end
909
910
910 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
911 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
911 issue = Issue.find(11)
912 issue = Issue.find(11)
912 issue.status_id = 1
913 issue.status_id = 1
913 assert !issue.save
914 assert !issue.save
914 assert_not_nil issue.errors[:base]
915 assert_not_nil issue.errors[:base]
915 end
916 end
916
917
917 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
918 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
918 issue = Issue.find(11)
919 issue = Issue.find(11)
919 issue.status_id = 1
920 issue.status_id = 1
920 issue.fixed_version_id = 3
921 issue.fixed_version_id = 3
921 assert issue.save
922 assert issue.save
922 end
923 end
923
924
924 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
925 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
925 issue = Issue.find(12)
926 issue = Issue.find(12)
926 assert_equal 'locked', issue.fixed_version.status
927 assert_equal 'locked', issue.fixed_version.status
927 issue.status_id = 1
928 issue.status_id = 1
928 assert issue.save
929 assert issue.save
929 end
930 end
930
931
931 def test_should_not_be_able_to_keep_unshared_version_when_changing_project
932 def test_should_not_be_able_to_keep_unshared_version_when_changing_project
932 issue = Issue.find(2)
933 issue = Issue.find(2)
933 assert_equal 2, issue.fixed_version_id
934 assert_equal 2, issue.fixed_version_id
934 issue.project_id = 3
935 issue.project_id = 3
935 assert_nil issue.fixed_version_id
936 assert_nil issue.fixed_version_id
936 issue.fixed_version_id = 2
937 issue.fixed_version_id = 2
937 assert !issue.save
938 assert !issue.save
938 assert_include 'Target version is not included in the list', issue.errors.full_messages
939 assert_include 'Target version is not included in the list', issue.errors.full_messages
939 end
940 end
940
941
941 def test_should_keep_shared_version_when_changing_project
942 def test_should_keep_shared_version_when_changing_project
942 Version.find(2).update_attribute :sharing, 'tree'
943 Version.find(2).update_attribute :sharing, 'tree'
943
944
944 issue = Issue.find(2)
945 issue = Issue.find(2)
945 assert_equal 2, issue.fixed_version_id
946 assert_equal 2, issue.fixed_version_id
946 issue.project_id = 3
947 issue.project_id = 3
947 assert_equal 2, issue.fixed_version_id
948 assert_equal 2, issue.fixed_version_id
948 assert issue.save
949 assert issue.save
949 end
950 end
950
951
951 def test_allowed_target_projects_on_move_should_include_projects_with_issue_tracking_enabled
952 def test_allowed_target_projects_on_move_should_include_projects_with_issue_tracking_enabled
952 assert_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
953 assert_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
953 end
954 end
954
955
955 def test_allowed_target_projects_on_move_should_not_include_projects_with_issue_tracking_disabled
956 def test_allowed_target_projects_on_move_should_not_include_projects_with_issue_tracking_disabled
956 Project.find(2).disable_module! :issue_tracking
957 Project.find(2).disable_module! :issue_tracking
957 assert_not_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
958 assert_not_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
958 end
959 end
959
960
960 def test_move_to_another_project_with_same_category
961 def test_move_to_another_project_with_same_category
961 issue = Issue.find(1)
962 issue = Issue.find(1)
962 issue.project = Project.find(2)
963 issue.project = Project.find(2)
963 assert issue.save
964 assert issue.save
964 issue.reload
965 issue.reload
965 assert_equal 2, issue.project_id
966 assert_equal 2, issue.project_id
966 # Category changes
967 # Category changes
967 assert_equal 4, issue.category_id
968 assert_equal 4, issue.category_id
968 # Make sure time entries were move to the target project
969 # Make sure time entries were move to the target project
969 assert_equal 2, issue.time_entries.first.project_id
970 assert_equal 2, issue.time_entries.first.project_id
970 end
971 end
971
972
972 def test_move_to_another_project_without_same_category
973 def test_move_to_another_project_without_same_category
973 issue = Issue.find(2)
974 issue = Issue.find(2)
974 issue.project = Project.find(2)
975 issue.project = Project.find(2)
975 assert issue.save
976 assert issue.save
976 issue.reload
977 issue.reload
977 assert_equal 2, issue.project_id
978 assert_equal 2, issue.project_id
978 # Category cleared
979 # Category cleared
979 assert_nil issue.category_id
980 assert_nil issue.category_id
980 end
981 end
981
982
982 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
983 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
983 issue = Issue.find(1)
984 issue = Issue.find(1)
984 issue.update_attribute(:fixed_version_id, 1)
985 issue.update_attribute(:fixed_version_id, 1)
985 issue.project = Project.find(2)
986 issue.project = Project.find(2)
986 assert issue.save
987 assert issue.save
987 issue.reload
988 issue.reload
988 assert_equal 2, issue.project_id
989 assert_equal 2, issue.project_id
989 # Cleared fixed_version
990 # Cleared fixed_version
990 assert_equal nil, issue.fixed_version
991 assert_equal nil, issue.fixed_version
991 end
992 end
992
993
993 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
994 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
994 issue = Issue.find(1)
995 issue = Issue.find(1)
995 issue.update_attribute(:fixed_version_id, 4)
996 issue.update_attribute(:fixed_version_id, 4)
996 issue.project = Project.find(5)
997 issue.project = Project.find(5)
997 assert issue.save
998 assert issue.save
998 issue.reload
999 issue.reload
999 assert_equal 5, issue.project_id
1000 assert_equal 5, issue.project_id
1000 # Keep fixed_version
1001 # Keep fixed_version
1001 assert_equal 4, issue.fixed_version_id
1002 assert_equal 4, issue.fixed_version_id
1002 end
1003 end
1003
1004
1004 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
1005 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
1005 issue = Issue.find(1)
1006 issue = Issue.find(1)
1006 issue.update_attribute(:fixed_version_id, 1)
1007 issue.update_attribute(:fixed_version_id, 1)
1007 issue.project = Project.find(5)
1008 issue.project = Project.find(5)
1008 assert issue.save
1009 assert issue.save
1009 issue.reload
1010 issue.reload
1010 assert_equal 5, issue.project_id
1011 assert_equal 5, issue.project_id
1011 # Cleared fixed_version
1012 # Cleared fixed_version
1012 assert_equal nil, issue.fixed_version
1013 assert_equal nil, issue.fixed_version
1013 end
1014 end
1014
1015
1015 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
1016 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
1016 issue = Issue.find(1)
1017 issue = Issue.find(1)
1017 issue.update_attribute(:fixed_version_id, 7)
1018 issue.update_attribute(:fixed_version_id, 7)
1018 issue.project = Project.find(2)
1019 issue.project = Project.find(2)
1019 assert issue.save
1020 assert issue.save
1020 issue.reload
1021 issue.reload
1021 assert_equal 2, issue.project_id
1022 assert_equal 2, issue.project_id
1022 # Keep fixed_version
1023 # Keep fixed_version
1023 assert_equal 7, issue.fixed_version_id
1024 assert_equal 7, issue.fixed_version_id
1024 end
1025 end
1025
1026
1026 def test_move_to_another_project_should_keep_parent_if_valid
1027 def test_move_to_another_project_should_keep_parent_if_valid
1027 issue = Issue.find(1)
1028 issue = Issue.find(1)
1028 issue.update_attribute(:parent_issue_id, 2)
1029 issue.update_attribute(:parent_issue_id, 2)
1029 issue.project = Project.find(3)
1030 issue.project = Project.find(3)
1030 assert issue.save
1031 assert issue.save
1031 issue.reload
1032 issue.reload
1032 assert_equal 2, issue.parent_id
1033 assert_equal 2, issue.parent_id
1033 end
1034 end
1034
1035
1035 def test_move_to_another_project_should_clear_parent_if_not_valid
1036 def test_move_to_another_project_should_clear_parent_if_not_valid
1036 issue = Issue.find(1)
1037 issue = Issue.find(1)
1037 issue.update_attribute(:parent_issue_id, 2)
1038 issue.update_attribute(:parent_issue_id, 2)
1038 issue.project = Project.find(2)
1039 issue.project = Project.find(2)
1039 assert issue.save
1040 assert issue.save
1040 issue.reload
1041 issue.reload
1041 assert_nil issue.parent_id
1042 assert_nil issue.parent_id
1042 end
1043 end
1043
1044
1044 def test_move_to_another_project_with_disabled_tracker
1045 def test_move_to_another_project_with_disabled_tracker
1045 issue = Issue.find(1)
1046 issue = Issue.find(1)
1046 target = Project.find(2)
1047 target = Project.find(2)
1047 target.tracker_ids = [3]
1048 target.tracker_ids = [3]
1048 target.save
1049 target.save
1049 issue.project = target
1050 issue.project = target
1050 assert issue.save
1051 assert issue.save
1051 issue.reload
1052 issue.reload
1052 assert_equal 2, issue.project_id
1053 assert_equal 2, issue.project_id
1053 assert_equal 3, issue.tracker_id
1054 assert_equal 3, issue.tracker_id
1054 end
1055 end
1055
1056
1056 def test_copy_to_the_same_project
1057 def test_copy_to_the_same_project
1057 issue = Issue.find(1)
1058 issue = Issue.find(1)
1058 copy = issue.copy
1059 copy = issue.copy
1059 assert_difference 'Issue.count' do
1060 assert_difference 'Issue.count' do
1060 copy.save!
1061 copy.save!
1061 end
1062 end
1062 assert_kind_of Issue, copy
1063 assert_kind_of Issue, copy
1063 assert_equal issue.project, copy.project
1064 assert_equal issue.project, copy.project
1064 assert_equal "125", copy.custom_value_for(2).value
1065 assert_equal "125", copy.custom_value_for(2).value
1065 end
1066 end
1066
1067
1067 def test_copy_to_another_project_and_tracker
1068 def test_copy_to_another_project_and_tracker
1068 issue = Issue.find(1)
1069 issue = Issue.find(1)
1069 copy = issue.copy(:project_id => 3, :tracker_id => 2)
1070 copy = issue.copy(:project_id => 3, :tracker_id => 2)
1070 assert_difference 'Issue.count' do
1071 assert_difference 'Issue.count' do
1071 copy.save!
1072 copy.save!
1072 end
1073 end
1073 copy.reload
1074 copy.reload
1074 assert_kind_of Issue, copy
1075 assert_kind_of Issue, copy
1075 assert_equal Project.find(3), copy.project
1076 assert_equal Project.find(3), copy.project
1076 assert_equal Tracker.find(2), copy.tracker
1077 assert_equal Tracker.find(2), copy.tracker
1077 # Custom field #2 is not associated with target tracker
1078 # Custom field #2 is not associated with target tracker
1078 assert_nil copy.custom_value_for(2)
1079 assert_nil copy.custom_value_for(2)
1079 end
1080 end
1080
1081
1081 context "#copy" do
1082 context "#copy" do
1082 setup do
1083 setup do
1083 @issue = Issue.find(1)
1084 @issue = Issue.find(1)
1084 end
1085 end
1085
1086
1086 should "not create a journal" do
1087 should "not create a journal" do
1087 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1088 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1088 copy.save!
1089 copy.save!
1089 assert_equal 0, copy.reload.journals.size
1090 assert_equal 0, copy.reload.journals.size
1090 end
1091 end
1091
1092
1092 should "allow assigned_to changes" do
1093 should "allow assigned_to changes" do
1093 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1094 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1094 assert_equal 3, copy.assigned_to_id
1095 assert_equal 3, copy.assigned_to_id
1095 end
1096 end
1096
1097
1097 should "allow status changes" do
1098 should "allow status changes" do
1098 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
1099 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
1099 assert_equal 2, copy.status_id
1100 assert_equal 2, copy.status_id
1100 end
1101 end
1101
1102
1102 should "allow start date changes" do
1103 should "allow start date changes" do
1103 date = Date.today
1104 date = Date.today
1104 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1105 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1105 assert_equal date, copy.start_date
1106 assert_equal date, copy.start_date
1106 end
1107 end
1107
1108
1108 should "allow due date changes" do
1109 should "allow due date changes" do
1109 date = Date.today
1110 date = Date.today
1110 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :due_date => date)
1111 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :due_date => date)
1111 assert_equal date, copy.due_date
1112 assert_equal date, copy.due_date
1112 end
1113 end
1113
1114
1114 should "set current user as author" do
1115 should "set current user as author" do
1115 User.current = User.find(9)
1116 User.current = User.find(9)
1116 copy = @issue.copy(:project_id => 3, :tracker_id => 2)
1117 copy = @issue.copy(:project_id => 3, :tracker_id => 2)
1117 assert_equal User.current, copy.author
1118 assert_equal User.current, copy.author
1118 end
1119 end
1119
1120
1120 should "create a journal with notes" do
1121 should "create a journal with notes" do
1121 date = Date.today
1122 date = Date.today
1122 notes = "Notes added when copying"
1123 notes = "Notes added when copying"
1123 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1124 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1124 copy.init_journal(User.current, notes)
1125 copy.init_journal(User.current, notes)
1125 copy.save!
1126 copy.save!
1126
1127
1127 assert_equal 1, copy.journals.size
1128 assert_equal 1, copy.journals.size
1128 journal = copy.journals.first
1129 journal = copy.journals.first
1129 assert_equal 0, journal.details.size
1130 assert_equal 0, journal.details.size
1130 assert_equal notes, journal.notes
1131 assert_equal notes, journal.notes
1131 end
1132 end
1132 end
1133 end
1133
1134
1134 def test_valid_parent_project
1135 def test_valid_parent_project
1135 issue = Issue.find(1)
1136 issue = Issue.find(1)
1136 issue_in_same_project = Issue.find(2)
1137 issue_in_same_project = Issue.find(2)
1137 issue_in_child_project = Issue.find(5)
1138 issue_in_child_project = Issue.find(5)
1138 issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
1139 issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
1139 issue_in_other_child_project = Issue.find(6)
1140 issue_in_other_child_project = Issue.find(6)
1140 issue_in_different_tree = Issue.find(4)
1141 issue_in_different_tree = Issue.find(4)
1141
1142
1142 with_settings :cross_project_subtasks => '' do
1143 with_settings :cross_project_subtasks => '' do
1143 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1144 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1144 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1145 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1145 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1146 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1146 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1147 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1147 end
1148 end
1148
1149
1149 with_settings :cross_project_subtasks => 'system' do
1150 with_settings :cross_project_subtasks => 'system' do
1150 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1151 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1151 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1152 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1152 assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
1153 assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
1153 end
1154 end
1154
1155
1155 with_settings :cross_project_subtasks => 'tree' do
1156 with_settings :cross_project_subtasks => 'tree' do
1156 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1157 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1157 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1158 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1158 assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
1159 assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
1159 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1160 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1160
1161
1161 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
1162 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
1162 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1163 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1163 end
1164 end
1164
1165
1165 with_settings :cross_project_subtasks => 'descendants' do
1166 with_settings :cross_project_subtasks => 'descendants' do
1166 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1167 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1167 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1168 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1168 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1169 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1169 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1170 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1170
1171
1171 assert_equal true, issue_in_child_project.valid_parent_project?(issue)
1172 assert_equal true, issue_in_child_project.valid_parent_project?(issue)
1172 assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1173 assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1173 end
1174 end
1174 end
1175 end
1175
1176
1176 def test_recipients_should_include_previous_assignee
1177 def test_recipients_should_include_previous_assignee
1177 user = User.find(3)
1178 user = User.find(3)
1178 user.members.update_all ["mail_notification = ?", false]
1179 user.members.update_all ["mail_notification = ?", false]
1179 user.update_attribute :mail_notification, 'only_assigned'
1180 user.update_attribute :mail_notification, 'only_assigned'
1180
1181
1181 issue = Issue.find(2)
1182 issue = Issue.find(2)
1182 issue.assigned_to = nil
1183 issue.assigned_to = nil
1183 assert_include user.mail, issue.recipients
1184 assert_include user.mail, issue.recipients
1184 issue.save!
1185 issue.save!
1185 assert !issue.recipients.include?(user.mail)
1186 assert !issue.recipients.include?(user.mail)
1186 end
1187 end
1187
1188
1188 def test_recipients_should_not_include_users_that_cannot_view_the_issue
1189 def test_recipients_should_not_include_users_that_cannot_view_the_issue
1189 issue = Issue.find(12)
1190 issue = Issue.find(12)
1190 assert issue.recipients.include?(issue.author.mail)
1191 assert issue.recipients.include?(issue.author.mail)
1191 # copy the issue to a private project
1192 # copy the issue to a private project
1192 copy = issue.copy(:project_id => 5, :tracker_id => 2)
1193 copy = issue.copy(:project_id => 5, :tracker_id => 2)
1193 # author is not a member of project anymore
1194 # author is not a member of project anymore
1194 assert !copy.recipients.include?(copy.author.mail)
1195 assert !copy.recipients.include?(copy.author.mail)
1195 end
1196 end
1196
1197
1197 def test_recipients_should_include_the_assigned_group_members
1198 def test_recipients_should_include_the_assigned_group_members
1198 group_member = User.generate!
1199 group_member = User.generate!
1199 group = Group.generate!
1200 group = Group.generate!
1200 group.users << group_member
1201 group.users << group_member
1201
1202
1202 issue = Issue.find(12)
1203 issue = Issue.find(12)
1203 issue.assigned_to = group
1204 issue.assigned_to = group
1204 assert issue.recipients.include?(group_member.mail)
1205 assert issue.recipients.include?(group_member.mail)
1205 end
1206 end
1206
1207
1207 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
1208 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
1208 user = User.find(3)
1209 user = User.find(3)
1209 issue = Issue.find(9)
1210 issue = Issue.find(9)
1210 Watcher.create!(:user => user, :watchable => issue)
1211 Watcher.create!(:user => user, :watchable => issue)
1211 assert issue.watched_by?(user)
1212 assert issue.watched_by?(user)
1212 assert !issue.watcher_recipients.include?(user.mail)
1213 assert !issue.watcher_recipients.include?(user.mail)
1213 end
1214 end
1214
1215
1215 def test_issue_destroy
1216 def test_issue_destroy
1216 Issue.find(1).destroy
1217 Issue.find(1).destroy
1217 assert_nil Issue.find_by_id(1)
1218 assert_nil Issue.find_by_id(1)
1218 assert_nil TimeEntry.find_by_issue_id(1)
1219 assert_nil TimeEntry.find_by_issue_id(1)
1219 end
1220 end
1220
1221
1221 def test_destroying_a_deleted_issue_should_not_raise_an_error
1222 def test_destroying_a_deleted_issue_should_not_raise_an_error
1222 issue = Issue.find(1)
1223 issue = Issue.find(1)
1223 Issue.find(1).destroy
1224 Issue.find(1).destroy
1224
1225
1225 assert_nothing_raised do
1226 assert_nothing_raised do
1226 assert_no_difference 'Issue.count' do
1227 assert_no_difference 'Issue.count' do
1227 issue.destroy
1228 issue.destroy
1228 end
1229 end
1229 assert issue.destroyed?
1230 assert issue.destroyed?
1230 end
1231 end
1231 end
1232 end
1232
1233
1233 def test_destroying_a_stale_issue_should_not_raise_an_error
1234 def test_destroying_a_stale_issue_should_not_raise_an_error
1234 issue = Issue.find(1)
1235 issue = Issue.find(1)
1235 Issue.find(1).update_attribute :subject, "Updated"
1236 Issue.find(1).update_attribute :subject, "Updated"
1236
1237
1237 assert_nothing_raised do
1238 assert_nothing_raised do
1238 assert_difference 'Issue.count', -1 do
1239 assert_difference 'Issue.count', -1 do
1239 issue.destroy
1240 issue.destroy
1240 end
1241 end
1241 assert issue.destroyed?
1242 assert issue.destroyed?
1242 end
1243 end
1243 end
1244 end
1244
1245
1245 def test_blocked
1246 def test_blocked
1246 blocked_issue = Issue.find(9)
1247 blocked_issue = Issue.find(9)
1247 blocking_issue = Issue.find(10)
1248 blocking_issue = Issue.find(10)
1248
1249
1249 assert blocked_issue.blocked?
1250 assert blocked_issue.blocked?
1250 assert !blocking_issue.blocked?
1251 assert !blocking_issue.blocked?
1251 end
1252 end
1252
1253
1253 def test_blocked_issues_dont_allow_closed_statuses
1254 def test_blocked_issues_dont_allow_closed_statuses
1254 blocked_issue = Issue.find(9)
1255 blocked_issue = Issue.find(9)
1255
1256
1256 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
1257 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
1257 assert !allowed_statuses.empty?
1258 assert !allowed_statuses.empty?
1258 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1259 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1259 assert closed_statuses.empty?
1260 assert closed_statuses.empty?
1260 end
1261 end
1261
1262
1262 def test_unblocked_issues_allow_closed_statuses
1263 def test_unblocked_issues_allow_closed_statuses
1263 blocking_issue = Issue.find(10)
1264 blocking_issue = Issue.find(10)
1264
1265
1265 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
1266 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
1266 assert !allowed_statuses.empty?
1267 assert !allowed_statuses.empty?
1267 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1268 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1268 assert !closed_statuses.empty?
1269 assert !closed_statuses.empty?
1269 end
1270 end
1270
1271
1271 def test_rescheduling_an_issue_should_reschedule_following_issue
1272 def test_rescheduling_an_issue_should_reschedule_following_issue
1272 issue1 = Issue.create!(:project_id => 1, :tracker_id => 1,
1273 issue1 = Issue.create!(:project_id => 1, :tracker_id => 1,
1273 :author_id => 1, :status_id => 1,
1274 :author_id => 1, :status_id => 1,
1274 :subject => '-',
1275 :subject => '-',
1275 :start_date => Date.today, :due_date => Date.today + 2)
1276 :start_date => Date.today, :due_date => Date.today + 2)
1276 issue2 = Issue.create!(:project_id => 1, :tracker_id => 1,
1277 issue2 = Issue.create!(:project_id => 1, :tracker_id => 1,
1277 :author_id => 1, :status_id => 1,
1278 :author_id => 1, :status_id => 1,
1278 :subject => '-',
1279 :subject => '-',
1279 :start_date => Date.today, :due_date => Date.today + 2)
1280 :start_date => Date.today, :due_date => Date.today + 2)
1280 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1281 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1281 :relation_type => IssueRelation::TYPE_PRECEDES)
1282 :relation_type => IssueRelation::TYPE_PRECEDES)
1282 assert_equal issue1.due_date + 1, issue2.reload.start_date
1283 assert_equal issue1.due_date + 1, issue2.reload.start_date
1283
1284
1284 issue1.due_date = Date.today + 5
1285 issue1.due_date = Date.today + 5
1285 issue1.save!
1286 issue1.save!
1286 assert_equal issue1.due_date + 1, issue2.reload.start_date
1287 assert_equal issue1.due_date + 1, issue2.reload.start_date
1287 end
1288 end
1288
1289
1289 def test_rescheduling_a_stale_issue_should_not_raise_an_error
1290 def test_rescheduling_a_stale_issue_should_not_raise_an_error
1290 stale = Issue.find(1)
1291 stale = Issue.find(1)
1291 issue = Issue.find(1)
1292 issue = Issue.find(1)
1292 issue.subject = "Updated"
1293 issue.subject = "Updated"
1293 issue.save!
1294 issue.save!
1294
1295
1295 date = 10.days.from_now.to_date
1296 date = 10.days.from_now.to_date
1296 assert_nothing_raised do
1297 assert_nothing_raised do
1297 stale.reschedule_after(date)
1298 stale.reschedule_after(date)
1298 end
1299 end
1299 assert_equal date, stale.reload.start_date
1300 assert_equal date, stale.reload.start_date
1300 end
1301 end
1301
1302
1302 def test_overdue
1303 def test_overdue
1303 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
1304 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
1304 assert !Issue.new(:due_date => Date.today).overdue?
1305 assert !Issue.new(:due_date => Date.today).overdue?
1305 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
1306 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
1306 assert !Issue.new(:due_date => nil).overdue?
1307 assert !Issue.new(:due_date => nil).overdue?
1307 assert !Issue.new(:due_date => 1.day.ago.to_date,
1308 assert !Issue.new(:due_date => 1.day.ago.to_date,
1308 :status => IssueStatus.find(:first,
1309 :status => IssueStatus.find(:first,
1309 :conditions => {:is_closed => true})
1310 :conditions => {:is_closed => true})
1310 ).overdue?
1311 ).overdue?
1311 end
1312 end
1312
1313
1313 context "#behind_schedule?" do
1314 context "#behind_schedule?" do
1314 should "be false if the issue has no start_date" do
1315 should "be false if the issue has no start_date" do
1315 assert !Issue.new(:start_date => nil,
1316 assert !Issue.new(:start_date => nil,
1316 :due_date => 1.day.from_now.to_date,
1317 :due_date => 1.day.from_now.to_date,
1317 :done_ratio => 0).behind_schedule?
1318 :done_ratio => 0).behind_schedule?
1318 end
1319 end
1319
1320
1320 should "be false if the issue has no end_date" do
1321 should "be false if the issue has no end_date" do
1321 assert !Issue.new(:start_date => 1.day.from_now.to_date,
1322 assert !Issue.new(:start_date => 1.day.from_now.to_date,
1322 :due_date => nil,
1323 :due_date => nil,
1323 :done_ratio => 0).behind_schedule?
1324 :done_ratio => 0).behind_schedule?
1324 end
1325 end
1325
1326
1326 should "be false if the issue has more done than it's calendar time" do
1327 should "be false if the issue has more done than it's calendar time" do
1327 assert !Issue.new(:start_date => 50.days.ago.to_date,
1328 assert !Issue.new(:start_date => 50.days.ago.to_date,
1328 :due_date => 50.days.from_now.to_date,
1329 :due_date => 50.days.from_now.to_date,
1329 :done_ratio => 90).behind_schedule?
1330 :done_ratio => 90).behind_schedule?
1330 end
1331 end
1331
1332
1332 should "be true if the issue hasn't been started at all" do
1333 should "be true if the issue hasn't been started at all" do
1333 assert Issue.new(:start_date => 1.day.ago.to_date,
1334 assert Issue.new(:start_date => 1.day.ago.to_date,
1334 :due_date => 1.day.from_now.to_date,
1335 :due_date => 1.day.from_now.to_date,
1335 :done_ratio => 0).behind_schedule?
1336 :done_ratio => 0).behind_schedule?
1336 end
1337 end
1337
1338
1338 should "be true if the issue has used more calendar time than it's done ratio" do
1339 should "be true if the issue has used more calendar time than it's done ratio" do
1339 assert Issue.new(:start_date => 100.days.ago.to_date,
1340 assert Issue.new(:start_date => 100.days.ago.to_date,
1340 :due_date => Date.today,
1341 :due_date => Date.today,
1341 :done_ratio => 90).behind_schedule?
1342 :done_ratio => 90).behind_schedule?
1342 end
1343 end
1343 end
1344 end
1344
1345
1345 context "#assignable_users" do
1346 context "#assignable_users" do
1346 should "be Users" do
1347 should "be Users" do
1347 assert_kind_of User, Issue.find(1).assignable_users.first
1348 assert_kind_of User, Issue.find(1).assignable_users.first
1348 end
1349 end
1349
1350
1350 should "include the issue author" do
1351 should "include the issue author" do
1351 non_project_member = User.generate!
1352 non_project_member = User.generate!
1352 issue = Issue.generate!(:author => non_project_member)
1353 issue = Issue.generate!(:author => non_project_member)
1353
1354
1354 assert issue.assignable_users.include?(non_project_member)
1355 assert issue.assignable_users.include?(non_project_member)
1355 end
1356 end
1356
1357
1357 should "include the current assignee" do
1358 should "include the current assignee" do
1358 user = User.generate!
1359 user = User.generate!
1359 issue = Issue.generate!(:assigned_to => user)
1360 issue = Issue.generate!(:assigned_to => user)
1360 user.lock!
1361 user.lock!
1361
1362
1362 assert Issue.find(issue.id).assignable_users.include?(user)
1363 assert Issue.find(issue.id).assignable_users.include?(user)
1363 end
1364 end
1364
1365
1365 should "not show the issue author twice" do
1366 should "not show the issue author twice" do
1366 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
1367 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
1367 assert_equal 2, assignable_user_ids.length
1368 assert_equal 2, assignable_user_ids.length
1368
1369
1369 assignable_user_ids.each do |user_id|
1370 assignable_user_ids.each do |user_id|
1370 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
1371 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
1371 "User #{user_id} appears more or less than once"
1372 "User #{user_id} appears more or less than once"
1372 end
1373 end
1373 end
1374 end
1374
1375
1375 context "with issue_group_assignment" do
1376 context "with issue_group_assignment" do
1376 should "include groups" do
1377 should "include groups" do
1377 issue = Issue.new(:project => Project.find(2))
1378 issue = Issue.new(:project => Project.find(2))
1378
1379
1379 with_settings :issue_group_assignment => '1' do
1380 with_settings :issue_group_assignment => '1' do
1380 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1381 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1381 assert issue.assignable_users.include?(Group.find(11))
1382 assert issue.assignable_users.include?(Group.find(11))
1382 end
1383 end
1383 end
1384 end
1384 end
1385 end
1385
1386
1386 context "without issue_group_assignment" do
1387 context "without issue_group_assignment" do
1387 should "not include groups" do
1388 should "not include groups" do
1388 issue = Issue.new(:project => Project.find(2))
1389 issue = Issue.new(:project => Project.find(2))
1389
1390
1390 with_settings :issue_group_assignment => '0' do
1391 with_settings :issue_group_assignment => '0' do
1391 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1392 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1392 assert !issue.assignable_users.include?(Group.find(11))
1393 assert !issue.assignable_users.include?(Group.find(11))
1393 end
1394 end
1394 end
1395 end
1395 end
1396 end
1396 end
1397 end
1397
1398
1398 def test_create_should_send_email_notification
1399 def test_create_should_send_email_notification
1399 ActionMailer::Base.deliveries.clear
1400 ActionMailer::Base.deliveries.clear
1400 issue = Issue.new(:project_id => 1, :tracker_id => 1,
1401 issue = Issue.new(:project_id => 1, :tracker_id => 1,
1401 :author_id => 3, :status_id => 1,
1402 :author_id => 3, :status_id => 1,
1402 :priority => IssuePriority.all.first,
1403 :priority => IssuePriority.all.first,
1403 :subject => 'test_create', :estimated_hours => '1:30')
1404 :subject => 'test_create', :estimated_hours => '1:30')
1404
1405
1405 assert issue.save
1406 assert issue.save
1406 assert_equal 1, ActionMailer::Base.deliveries.size
1407 assert_equal 1, ActionMailer::Base.deliveries.size
1407 end
1408 end
1408
1409
1409 def test_stale_issue_should_not_send_email_notification
1410 def test_stale_issue_should_not_send_email_notification
1410 ActionMailer::Base.deliveries.clear
1411 ActionMailer::Base.deliveries.clear
1411 issue = Issue.find(1)
1412 issue = Issue.find(1)
1412 stale = Issue.find(1)
1413 stale = Issue.find(1)
1413
1414
1414 issue.init_journal(User.find(1))
1415 issue.init_journal(User.find(1))
1415 issue.subject = 'Subjet update'
1416 issue.subject = 'Subjet update'
1416 assert issue.save
1417 assert issue.save
1417 assert_equal 1, ActionMailer::Base.deliveries.size
1418 assert_equal 1, ActionMailer::Base.deliveries.size
1418 ActionMailer::Base.deliveries.clear
1419 ActionMailer::Base.deliveries.clear
1419
1420
1420 stale.init_journal(User.find(1))
1421 stale.init_journal(User.find(1))
1421 stale.subject = 'Another subjet update'
1422 stale.subject = 'Another subjet update'
1422 assert_raise ActiveRecord::StaleObjectError do
1423 assert_raise ActiveRecord::StaleObjectError do
1423 stale.save
1424 stale.save
1424 end
1425 end
1425 assert ActionMailer::Base.deliveries.empty?
1426 assert ActionMailer::Base.deliveries.empty?
1426 end
1427 end
1427
1428
1428 def test_journalized_description
1429 def test_journalized_description
1429 IssueCustomField.delete_all
1430 IssueCustomField.delete_all
1430
1431
1431 i = Issue.first
1432 i = Issue.first
1432 old_description = i.description
1433 old_description = i.description
1433 new_description = "This is the new description"
1434 new_description = "This is the new description"
1434
1435
1435 i.init_journal(User.find(2))
1436 i.init_journal(User.find(2))
1436 i.description = new_description
1437 i.description = new_description
1437 assert_difference 'Journal.count', 1 do
1438 assert_difference 'Journal.count', 1 do
1438 assert_difference 'JournalDetail.count', 1 do
1439 assert_difference 'JournalDetail.count', 1 do
1439 i.save!
1440 i.save!
1440 end
1441 end
1441 end
1442 end
1442
1443
1443 detail = JournalDetail.first(:order => 'id DESC')
1444 detail = JournalDetail.first(:order => 'id DESC')
1444 assert_equal i, detail.journal.journalized
1445 assert_equal i, detail.journal.journalized
1445 assert_equal 'attr', detail.property
1446 assert_equal 'attr', detail.property
1446 assert_equal 'description', detail.prop_key
1447 assert_equal 'description', detail.prop_key
1447 assert_equal old_description, detail.old_value
1448 assert_equal old_description, detail.old_value
1448 assert_equal new_description, detail.value
1449 assert_equal new_description, detail.value
1449 end
1450 end
1450
1451
1451 def test_blank_descriptions_should_not_be_journalized
1452 def test_blank_descriptions_should_not_be_journalized
1452 IssueCustomField.delete_all
1453 IssueCustomField.delete_all
1453 Issue.update_all("description = NULL", "id=1")
1454 Issue.update_all("description = NULL", "id=1")
1454
1455
1455 i = Issue.find(1)
1456 i = Issue.find(1)
1456 i.init_journal(User.find(2))
1457 i.init_journal(User.find(2))
1457 i.subject = "blank description"
1458 i.subject = "blank description"
1458 i.description = "\r\n"
1459 i.description = "\r\n"
1459
1460
1460 assert_difference 'Journal.count', 1 do
1461 assert_difference 'Journal.count', 1 do
1461 assert_difference 'JournalDetail.count', 1 do
1462 assert_difference 'JournalDetail.count', 1 do
1462 i.save!
1463 i.save!
1463 end
1464 end
1464 end
1465 end
1465 end
1466 end
1466
1467
1467 def test_journalized_multi_custom_field
1468 def test_journalized_multi_custom_field
1468 field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
1469 field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
1469 :is_filter => true, :is_for_all => true,
1470 :is_filter => true, :is_for_all => true,
1470 :tracker_ids => [1],
1471 :tracker_ids => [1],
1471 :possible_values => ['value1', 'value2', 'value3'],
1472 :possible_values => ['value1', 'value2', 'value3'],
1472 :multiple => true)
1473 :multiple => true)
1473
1474
1474 issue = Issue.create!(:project_id => 1, :tracker_id => 1,
1475 issue = Issue.create!(:project_id => 1, :tracker_id => 1,
1475 :subject => 'Test', :author_id => 1)
1476 :subject => 'Test', :author_id => 1)
1476
1477
1477 assert_difference 'Journal.count' do
1478 assert_difference 'Journal.count' do
1478 assert_difference 'JournalDetail.count' do
1479 assert_difference 'JournalDetail.count' do
1479 issue.init_journal(User.first)
1480 issue.init_journal(User.first)
1480 issue.custom_field_values = {field.id => ['value1']}
1481 issue.custom_field_values = {field.id => ['value1']}
1481 issue.save!
1482 issue.save!
1482 end
1483 end
1483 assert_difference 'JournalDetail.count' do
1484 assert_difference 'JournalDetail.count' do
1484 issue.init_journal(User.first)
1485 issue.init_journal(User.first)
1485 issue.custom_field_values = {field.id => ['value1', 'value2']}
1486 issue.custom_field_values = {field.id => ['value1', 'value2']}
1486 issue.save!
1487 issue.save!
1487 end
1488 end
1488 assert_difference 'JournalDetail.count', 2 do
1489 assert_difference 'JournalDetail.count', 2 do
1489 issue.init_journal(User.first)
1490 issue.init_journal(User.first)
1490 issue.custom_field_values = {field.id => ['value3', 'value2']}
1491 issue.custom_field_values = {field.id => ['value3', 'value2']}
1491 issue.save!
1492 issue.save!
1492 end
1493 end
1493 assert_difference 'JournalDetail.count', 2 do
1494 assert_difference 'JournalDetail.count', 2 do
1494 issue.init_journal(User.first)
1495 issue.init_journal(User.first)
1495 issue.custom_field_values = {field.id => nil}
1496 issue.custom_field_values = {field.id => nil}
1496 issue.save!
1497 issue.save!
1497 end
1498 end
1498 end
1499 end
1499 end
1500 end
1500
1501
1501 def test_description_eol_should_be_normalized
1502 def test_description_eol_should_be_normalized
1502 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
1503 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
1503 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
1504 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
1504 end
1505 end
1505
1506
1506 def test_saving_twice_should_not_duplicate_journal_details
1507 def test_saving_twice_should_not_duplicate_journal_details
1507 i = Issue.find(:first)
1508 i = Issue.find(:first)
1508 i.init_journal(User.find(2), 'Some notes')
1509 i.init_journal(User.find(2), 'Some notes')
1509 # initial changes
1510 # initial changes
1510 i.subject = 'New subject'
1511 i.subject = 'New subject'
1511 i.done_ratio = i.done_ratio + 10
1512 i.done_ratio = i.done_ratio + 10
1512 assert_difference 'Journal.count' do
1513 assert_difference 'Journal.count' do
1513 assert i.save
1514 assert i.save
1514 end
1515 end
1515 # 1 more change
1516 # 1 more change
1516 i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id])
1517 i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id])
1517 assert_no_difference 'Journal.count' do
1518 assert_no_difference 'Journal.count' do
1518 assert_difference 'JournalDetail.count', 1 do
1519 assert_difference 'JournalDetail.count', 1 do
1519 i.save
1520 i.save
1520 end
1521 end
1521 end
1522 end
1522 # no more change
1523 # no more change
1523 assert_no_difference 'Journal.count' do
1524 assert_no_difference 'Journal.count' do
1524 assert_no_difference 'JournalDetail.count' do
1525 assert_no_difference 'JournalDetail.count' do
1525 i.save
1526 i.save
1526 end
1527 end
1527 end
1528 end
1528 end
1529 end
1529
1530
1530 def test_all_dependent_issues
1531 def test_all_dependent_issues
1531 IssueRelation.delete_all
1532 IssueRelation.delete_all
1532 assert IssueRelation.create!(:issue_from => Issue.find(1),
1533 assert IssueRelation.create!(:issue_from => Issue.find(1),
1533 :issue_to => Issue.find(2),
1534 :issue_to => Issue.find(2),
1534 :relation_type => IssueRelation::TYPE_PRECEDES)
1535 :relation_type => IssueRelation::TYPE_PRECEDES)
1535 assert IssueRelation.create!(:issue_from => Issue.find(2),
1536 assert IssueRelation.create!(:issue_from => Issue.find(2),
1536 :issue_to => Issue.find(3),
1537 :issue_to => Issue.find(3),
1537 :relation_type => IssueRelation::TYPE_PRECEDES)
1538 :relation_type => IssueRelation::TYPE_PRECEDES)
1538 assert IssueRelation.create!(:issue_from => Issue.find(3),
1539 assert IssueRelation.create!(:issue_from => Issue.find(3),
1539 :issue_to => Issue.find(8),
1540 :issue_to => Issue.find(8),
1540 :relation_type => IssueRelation::TYPE_PRECEDES)
1541 :relation_type => IssueRelation::TYPE_PRECEDES)
1541
1542
1542 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1543 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1543 end
1544 end
1544
1545
1545 def test_all_dependent_issues_with_persistent_circular_dependency
1546 def test_all_dependent_issues_with_persistent_circular_dependency
1546 IssueRelation.delete_all
1547 IssueRelation.delete_all
1547 assert IssueRelation.create!(:issue_from => Issue.find(1),
1548 assert IssueRelation.create!(:issue_from => Issue.find(1),
1548 :issue_to => Issue.find(2),
1549 :issue_to => Issue.find(2),
1549 :relation_type => IssueRelation::TYPE_PRECEDES)
1550 :relation_type => IssueRelation::TYPE_PRECEDES)
1550 assert IssueRelation.create!(:issue_from => Issue.find(2),
1551 assert IssueRelation.create!(:issue_from => Issue.find(2),
1551 :issue_to => Issue.find(3),
1552 :issue_to => Issue.find(3),
1552 :relation_type => IssueRelation::TYPE_PRECEDES)
1553 :relation_type => IssueRelation::TYPE_PRECEDES)
1553
1554
1554 r = IssueRelation.create!(:issue_from => Issue.find(3),
1555 r = IssueRelation.create!(:issue_from => Issue.find(3),
1555 :issue_to => Issue.find(7),
1556 :issue_to => Issue.find(7),
1556 :relation_type => IssueRelation::TYPE_PRECEDES)
1557 :relation_type => IssueRelation::TYPE_PRECEDES)
1557 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
1558 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
1558
1559
1559 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
1560 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
1560 end
1561 end
1561
1562
1562 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
1563 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
1563 IssueRelation.delete_all
1564 IssueRelation.delete_all
1564 assert IssueRelation.create!(:issue_from => Issue.find(1),
1565 assert IssueRelation.create!(:issue_from => Issue.find(1),
1565 :issue_to => Issue.find(2),
1566 :issue_to => Issue.find(2),
1566 :relation_type => IssueRelation::TYPE_RELATES)
1567 :relation_type => IssueRelation::TYPE_RELATES)
1567 assert IssueRelation.create!(:issue_from => Issue.find(2),
1568 assert IssueRelation.create!(:issue_from => Issue.find(2),
1568 :issue_to => Issue.find(3),
1569 :issue_to => Issue.find(3),
1569 :relation_type => IssueRelation::TYPE_RELATES)
1570 :relation_type => IssueRelation::TYPE_RELATES)
1570 assert IssueRelation.create!(:issue_from => Issue.find(3),
1571 assert IssueRelation.create!(:issue_from => Issue.find(3),
1571 :issue_to => Issue.find(8),
1572 :issue_to => Issue.find(8),
1572 :relation_type => IssueRelation::TYPE_RELATES)
1573 :relation_type => IssueRelation::TYPE_RELATES)
1573
1574
1574 r = IssueRelation.create!(:issue_from => Issue.find(8),
1575 r = IssueRelation.create!(:issue_from => Issue.find(8),
1575 :issue_to => Issue.find(7),
1576 :issue_to => Issue.find(7),
1576 :relation_type => IssueRelation::TYPE_RELATES)
1577 :relation_type => IssueRelation::TYPE_RELATES)
1577 IssueRelation.update_all("issue_to_id = 2", ["id = ?", r.id])
1578 IssueRelation.update_all("issue_to_id = 2", ["id = ?", r.id])
1578
1579
1579 r = IssueRelation.create!(:issue_from => Issue.find(3),
1580 r = IssueRelation.create!(:issue_from => Issue.find(3),
1580 :issue_to => Issue.find(7),
1581 :issue_to => Issue.find(7),
1581 :relation_type => IssueRelation::TYPE_RELATES)
1582 :relation_type => IssueRelation::TYPE_RELATES)
1582 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
1583 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
1583
1584
1584 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1585 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1585 end
1586 end
1586
1587
1587 context "#done_ratio" do
1588 context "#done_ratio" do
1588 setup do
1589 setup do
1589 @issue = Issue.find(1)
1590 @issue = Issue.find(1)
1590 @issue_status = IssueStatus.find(1)
1591 @issue_status = IssueStatus.find(1)
1591 @issue_status.update_attribute(:default_done_ratio, 50)
1592 @issue_status.update_attribute(:default_done_ratio, 50)
1592 @issue2 = Issue.find(2)
1593 @issue2 = Issue.find(2)
1593 @issue_status2 = IssueStatus.find(2)
1594 @issue_status2 = IssueStatus.find(2)
1594 @issue_status2.update_attribute(:default_done_ratio, 0)
1595 @issue_status2.update_attribute(:default_done_ratio, 0)
1595 end
1596 end
1596
1597
1597 teardown do
1598 teardown do
1598 Setting.issue_done_ratio = 'issue_field'
1599 Setting.issue_done_ratio = 'issue_field'
1599 end
1600 end
1600
1601
1601 context "with Setting.issue_done_ratio using the issue_field" do
1602 context "with Setting.issue_done_ratio using the issue_field" do
1602 setup do
1603 setup do
1603 Setting.issue_done_ratio = 'issue_field'
1604 Setting.issue_done_ratio = 'issue_field'
1604 end
1605 end
1605
1606
1606 should "read the issue's field" do
1607 should "read the issue's field" do
1607 assert_equal 0, @issue.done_ratio
1608 assert_equal 0, @issue.done_ratio
1608 assert_equal 30, @issue2.done_ratio
1609 assert_equal 30, @issue2.done_ratio
1609 end
1610 end
1610 end
1611 end
1611
1612
1612 context "with Setting.issue_done_ratio using the issue_status" do
1613 context "with Setting.issue_done_ratio using the issue_status" do
1613 setup do
1614 setup do
1614 Setting.issue_done_ratio = 'issue_status'
1615 Setting.issue_done_ratio = 'issue_status'
1615 end
1616 end
1616
1617
1617 should "read the Issue Status's default done ratio" do
1618 should "read the Issue Status's default done ratio" do
1618 assert_equal 50, @issue.done_ratio
1619 assert_equal 50, @issue.done_ratio
1619 assert_equal 0, @issue2.done_ratio
1620 assert_equal 0, @issue2.done_ratio
1620 end
1621 end
1621 end
1622 end
1622 end
1623 end
1623
1624
1624 context "#update_done_ratio_from_issue_status" do
1625 context "#update_done_ratio_from_issue_status" do
1625 setup do
1626 setup do
1626 @issue = Issue.find(1)
1627 @issue = Issue.find(1)
1627 @issue_status = IssueStatus.find(1)
1628 @issue_status = IssueStatus.find(1)
1628 @issue_status.update_attribute(:default_done_ratio, 50)
1629 @issue_status.update_attribute(:default_done_ratio, 50)
1629 @issue2 = Issue.find(2)
1630 @issue2 = Issue.find(2)
1630 @issue_status2 = IssueStatus.find(2)
1631 @issue_status2 = IssueStatus.find(2)
1631 @issue_status2.update_attribute(:default_done_ratio, 0)
1632 @issue_status2.update_attribute(:default_done_ratio, 0)
1632 end
1633 end
1633
1634
1634 context "with Setting.issue_done_ratio using the issue_field" do
1635 context "with Setting.issue_done_ratio using the issue_field" do
1635 setup do
1636 setup do
1636 Setting.issue_done_ratio = 'issue_field'
1637 Setting.issue_done_ratio = 'issue_field'
1637 end
1638 end
1638
1639
1639 should "not change the issue" do
1640 should "not change the issue" do
1640 @issue.update_done_ratio_from_issue_status
1641 @issue.update_done_ratio_from_issue_status
1641 @issue2.update_done_ratio_from_issue_status
1642 @issue2.update_done_ratio_from_issue_status
1642
1643
1643 assert_equal 0, @issue.read_attribute(:done_ratio)
1644 assert_equal 0, @issue.read_attribute(:done_ratio)
1644 assert_equal 30, @issue2.read_attribute(:done_ratio)
1645 assert_equal 30, @issue2.read_attribute(:done_ratio)
1645 end
1646 end
1646 end
1647 end
1647
1648
1648 context "with Setting.issue_done_ratio using the issue_status" do
1649 context "with Setting.issue_done_ratio using the issue_status" do
1649 setup do
1650 setup do
1650 Setting.issue_done_ratio = 'issue_status'
1651 Setting.issue_done_ratio = 'issue_status'
1651 end
1652 end
1652
1653
1653 should "change the issue's done ratio" do
1654 should "change the issue's done ratio" do
1654 @issue.update_done_ratio_from_issue_status
1655 @issue.update_done_ratio_from_issue_status
1655 @issue2.update_done_ratio_from_issue_status
1656 @issue2.update_done_ratio_from_issue_status
1656
1657
1657 assert_equal 50, @issue.read_attribute(:done_ratio)
1658 assert_equal 50, @issue.read_attribute(:done_ratio)
1658 assert_equal 0, @issue2.read_attribute(:done_ratio)
1659 assert_equal 0, @issue2.read_attribute(:done_ratio)
1659 end
1660 end
1660 end
1661 end
1661 end
1662 end
1662
1663
1663 test "#by_tracker" do
1664 test "#by_tracker" do
1664 User.current = User.anonymous
1665 User.current = User.anonymous
1665 groups = Issue.by_tracker(Project.find(1))
1666 groups = Issue.by_tracker(Project.find(1))
1666 assert_equal 3, groups.size
1667 assert_equal 3, groups.size
1667 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1668 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1668 end
1669 end
1669
1670
1670 test "#by_version" do
1671 test "#by_version" do
1671 User.current = User.anonymous
1672 User.current = User.anonymous
1672 groups = Issue.by_version(Project.find(1))
1673 groups = Issue.by_version(Project.find(1))
1673 assert_equal 3, groups.size
1674 assert_equal 3, groups.size
1674 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1675 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1675 end
1676 end
1676
1677
1677 test "#by_priority" do
1678 test "#by_priority" do
1678 User.current = User.anonymous
1679 User.current = User.anonymous
1679 groups = Issue.by_priority(Project.find(1))
1680 groups = Issue.by_priority(Project.find(1))
1680 assert_equal 4, groups.size
1681 assert_equal 4, groups.size
1681 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1682 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1682 end
1683 end
1683
1684
1684 test "#by_category" do
1685 test "#by_category" do
1685 User.current = User.anonymous
1686 User.current = User.anonymous
1686 groups = Issue.by_category(Project.find(1))
1687 groups = Issue.by_category(Project.find(1))
1687 assert_equal 2, groups.size
1688 assert_equal 2, groups.size
1688 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1689 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1689 end
1690 end
1690
1691
1691 test "#by_assigned_to" do
1692 test "#by_assigned_to" do
1692 User.current = User.anonymous
1693 User.current = User.anonymous
1693 groups = Issue.by_assigned_to(Project.find(1))
1694 groups = Issue.by_assigned_to(Project.find(1))
1694 assert_equal 2, groups.size
1695 assert_equal 2, groups.size
1695 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1696 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1696 end
1697 end
1697
1698
1698 test "#by_author" do
1699 test "#by_author" do
1699 User.current = User.anonymous
1700 User.current = User.anonymous
1700 groups = Issue.by_author(Project.find(1))
1701 groups = Issue.by_author(Project.find(1))
1701 assert_equal 4, groups.size
1702 assert_equal 4, groups.size
1702 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1703 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1703 end
1704 end
1704
1705
1705 test "#by_subproject" do
1706 test "#by_subproject" do
1706 User.current = User.anonymous
1707 User.current = User.anonymous
1707 groups = Issue.by_subproject(Project.find(1))
1708 groups = Issue.by_subproject(Project.find(1))
1708 # Private descendant not visible
1709 # Private descendant not visible
1709 assert_equal 1, groups.size
1710 assert_equal 1, groups.size
1710 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1711 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1711 end
1712 end
1712
1713
1713 def test_recently_updated_scope
1714 def test_recently_updated_scope
1714 #should return the last updated issue
1715 #should return the last updated issue
1715 assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
1716 assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
1716 end
1717 end
1717
1718
1718 def test_on_active_projects_scope
1719 def test_on_active_projects_scope
1719 assert Project.find(2).archive
1720 assert Project.find(2).archive
1720
1721
1721 before = Issue.on_active_project.length
1722 before = Issue.on_active_project.length
1722 # test inclusion to results
1723 # test inclusion to results
1723 issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
1724 issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
1724 assert_equal before + 1, Issue.on_active_project.length
1725 assert_equal before + 1, Issue.on_active_project.length
1725
1726
1726 # Move to an archived project
1727 # Move to an archived project
1727 issue.project = Project.find(2)
1728 issue.project = Project.find(2)
1728 assert issue.save
1729 assert issue.save
1729 assert_equal before, Issue.on_active_project.length
1730 assert_equal before, Issue.on_active_project.length
1730 end
1731 end
1731
1732
1732 context "Issue#recipients" do
1733 context "Issue#recipients" do
1733 setup do
1734 setup do
1734 @project = Project.find(1)
1735 @project = Project.find(1)
1735 @author = User.generate!
1736 @author = User.generate!
1736 @assignee = User.generate!
1737 @assignee = User.generate!
1737 @issue = Issue.generate!(:project => @project, :assigned_to => @assignee, :author => @author)
1738 @issue = Issue.generate!(:project => @project, :assigned_to => @assignee, :author => @author)
1738 end
1739 end
1739
1740
1740 should "include project recipients" do
1741 should "include project recipients" do
1741 assert @project.recipients.present?
1742 assert @project.recipients.present?
1742 @project.recipients.each do |project_recipient|
1743 @project.recipients.each do |project_recipient|
1743 assert @issue.recipients.include?(project_recipient)
1744 assert @issue.recipients.include?(project_recipient)
1744 end
1745 end
1745 end
1746 end
1746
1747
1747 should "include the author if the author is active" do
1748 should "include the author if the author is active" do
1748 assert @issue.author, "No author set for Issue"
1749 assert @issue.author, "No author set for Issue"
1749 assert @issue.recipients.include?(@issue.author.mail)
1750 assert @issue.recipients.include?(@issue.author.mail)
1750 end
1751 end
1751
1752
1752 should "include the assigned to user if the assigned to user is active" do
1753 should "include the assigned to user if the assigned to user is active" do
1753 assert @issue.assigned_to, "No assigned_to set for Issue"
1754 assert @issue.assigned_to, "No assigned_to set for Issue"
1754 assert @issue.recipients.include?(@issue.assigned_to.mail)
1755 assert @issue.recipients.include?(@issue.assigned_to.mail)
1755 end
1756 end
1756
1757
1757 should "not include users who opt out of all email" do
1758 should "not include users who opt out of all email" do
1758 @author.update_attribute(:mail_notification, :none)
1759 @author.update_attribute(:mail_notification, :none)
1759
1760
1760 assert !@issue.recipients.include?(@issue.author.mail)
1761 assert !@issue.recipients.include?(@issue.author.mail)
1761 end
1762 end
1762
1763
1763 should "not include the issue author if they are only notified of assigned issues" do
1764 should "not include the issue author if they are only notified of assigned issues" do
1764 @author.update_attribute(:mail_notification, :only_assigned)
1765 @author.update_attribute(:mail_notification, :only_assigned)
1765
1766
1766 assert !@issue.recipients.include?(@issue.author.mail)
1767 assert !@issue.recipients.include?(@issue.author.mail)
1767 end
1768 end
1768
1769
1769 should "not include the assigned user if they are only notified of owned issues" do
1770 should "not include the assigned user if they are only notified of owned issues" do
1770 @assignee.update_attribute(:mail_notification, :only_owner)
1771 @assignee.update_attribute(:mail_notification, :only_owner)
1771
1772
1772 assert !@issue.recipients.include?(@issue.assigned_to.mail)
1773 assert !@issue.recipients.include?(@issue.assigned_to.mail)
1773 end
1774 end
1774 end
1775 end
1775
1776
1776 def test_last_journal_id_with_journals_should_return_the_journal_id
1777 def test_last_journal_id_with_journals_should_return_the_journal_id
1777 assert_equal 2, Issue.find(1).last_journal_id
1778 assert_equal 2, Issue.find(1).last_journal_id
1778 end
1779 end
1779
1780
1780 def test_last_journal_id_without_journals_should_return_nil
1781 def test_last_journal_id_without_journals_should_return_nil
1781 assert_nil Issue.find(3).last_journal_id
1782 assert_nil Issue.find(3).last_journal_id
1782 end
1783 end
1783
1784
1784 def test_journals_after_should_return_journals_with_greater_id
1785 def test_journals_after_should_return_journals_with_greater_id
1785 assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
1786 assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
1786 assert_equal [], Issue.find(1).journals_after('2')
1787 assert_equal [], Issue.find(1).journals_after('2')
1787 end
1788 end
1788
1789
1789 def test_journals_after_with_blank_arg_should_return_all_journals
1790 def test_journals_after_with_blank_arg_should_return_all_journals
1790 assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
1791 assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
1791 end
1792 end
1792 end
1793 end
General Comments 0
You need to be logged in to leave comments. Login now