jro_apps/redmine Commit - r12201:58a63c49c49b

Fixed that magic links to existing attachments are not converted when previewing issue notes....

Jean-Philippe Lang -

r12201:58a63c49c49b

parent child

Context file:

r12201:58a63c49c49b

app/helpers/application_helper.rb +2 -1

                            repo_prefix = nil
                          end
                        when 'attachment'
-                         attachments = options[:attachments] || (obj && obj.respond_to?(:attachments) ? obj.attachments : nil)
+                         attachments = options[:attachments] || []
+                         attachments += obj.attachments if obj.respond_to?(:attachments)
                          if attachments && attachment = Attachment.latest_attach(attachments, name)
                            link = link_to_attachment(attachment, :only_path => only_path, :download => true, :class => 'attachment')
                          end

test/functional/previews_controller_test.rb +8 0

                  assert_tag :p, :content => 'Foo'
                end
+               def test_preview_issue_notes_should_support_links_to_existing_attachments
+                 Attachment.generate!(:container => Issue.find(1), :filename => 'foo.bar')
+                 @request.session[:user_id] = 2
+                 post :issue, :project_id => '1', :id => 1, :notes => 'attachment:foo.bar'
+                 assert_response :success
+                 assert_select 'a.attachment', :text => 'foo.bar'
+               end
                def test_preview_new_news
                  get :news, :project_id => 1,
                                :news => {:title => '',

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages