jro_apps/redmine Commit - r9716:56cf38135720

Code cleanup....

Etienne Massip -

r9716:56cf38135720

parent child

Context file:

r9716:56cf38135720

Collapse all files

app/helpers/application_helper.rb +9 -8

                 return unless User.current.logged?
                 projects = User.current.memberships.collect(&:project).compact.select(&:active?).uniq
                 if projects.any?
-                  s = '<select onchange="if (this.value != \'\') { window.location = this.value; }">' +
+                  options =
-                        "<option value=''>#{ l(:label_jump_to_a_project) }</option>" +
+                    ("<option value=''>#{ l(:label_jump_to_a_project) }</option>" +
-                        '<option value="" disabled="disabled">---</option>'
+                     '<option value="" disabled="disabled">---</option>').html_safe
-                  s << project_tree_options_for_select(projects, :selected => @project) do |p|
-                    { :value => url_for(:controller => 'projects', :action => 'show', :id => p, :jump => current_menu_item) }
+                  options << project_tree_options_for_select(projects, :selected => @project) do |p|
+                    { :value => project_path(:id => p, :jump => current_menu_item) }
                   end
-                  s << '</select>'
-                  s.html_safe
+                  select_tag('project_quick_jump_box', options, :onchange => 'if (this.value != \'\') { window.location = this.value; }')
                 end
               end
               def project_tree_options_for_select(projects, options = {})
                 s = ''
                 project_tree(projects) do |project, level|
-                  name_prefix = (level > 0 ? ('&nbsp;' * 2 * level + '&#187; ') : '').html_safe
+                  name_prefix = (level > 0 ? '&nbsp;' * 2 * level + '&#187; ' : '').html_safe
                   tag_options = {:value => project.id}
                   if project == options[:selected] || (options[:selected].respond_to?(:include?) && options[:selected].include?(project))
                     tag_options[:selected] = 'selected'

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages