##// END OF EJS Templates
Journalize values that are cleared after project or tracker change (#21623)....
Jean-Philippe Lang -
r15429:55be3ef1727e
parent child
Show More

The requested changes are too big and content was truncated. Show full diff

@@ -1,312 +1,320
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2016 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class Journal < ActiveRecord::Base
19 19 include Redmine::SafeAttributes
20 20
21 21 belongs_to :journalized, :polymorphic => true
22 22 # added as a quick fix to allow eager loading of the polymorphic association
23 23 # since always associated to an issue, for now
24 24 belongs_to :issue, :foreign_key => :journalized_id
25 25
26 26 belongs_to :user
27 27 has_many :details, :class_name => "JournalDetail", :dependent => :delete_all, :inverse_of => :journal
28 28 attr_accessor :indice
29 29 attr_protected :id
30 30
31 31 acts_as_event :title => Proc.new {|o| status = ((s = o.new_status) ? " (#{s})" : nil); "#{o.issue.tracker} ##{o.issue.id}#{status}: #{o.issue.subject}" },
32 32 :description => :notes,
33 33 :author => :user,
34 34 :group => :issue,
35 35 :type => Proc.new {|o| (s = o.new_status) ? (s.is_closed? ? 'issue-closed' : 'issue-edit') : 'issue-note' },
36 36 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.issue.id, :anchor => "change-#{o.id}"}}
37 37
38 38 acts_as_activity_provider :type => 'issues',
39 39 :author_key => :user_id,
40 40 :scope => preload({:issue => :project}, :user).
41 41 joins("LEFT OUTER JOIN #{JournalDetail.table_name} ON #{JournalDetail.table_name}.journal_id = #{Journal.table_name}.id").
42 42 where("#{Journal.table_name}.journalized_type = 'Issue' AND" +
43 43 " (#{JournalDetail.table_name}.prop_key = 'status_id' OR #{Journal.table_name}.notes <> '')").distinct
44 44
45 45 before_create :split_private_notes
46 46 after_create :send_notification
47 47
48 48 scope :visible, lambda {|*args|
49 49 user = args.shift || User.current
50 50 joins(:issue => :project).
51 51 where(Issue.visible_condition(user, *args)).
52 52 where("(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(user, :view_private_notes, *args)}))", false)
53 53 }
54 54
55 55 safe_attributes 'notes',
56 56 :if => lambda {|journal, user| journal.new_record? || journal.editable_by?(user)}
57 57 safe_attributes 'private_notes',
58 58 :if => lambda {|journal, user| user.allowed_to?(:set_notes_private, journal.project)}
59 59
60 60 def initialize(*args)
61 61 super
62 62 if journalized
63 63 if journalized.new_record?
64 64 self.notify = false
65 65 else
66 66 start
67 67 end
68 68 end
69 69 end
70 70
71 71 def save(*args)
72 72 journalize_changes
73 73 # Do not save an empty journal
74 74 (details.empty? && notes.blank?) ? false : super
75 75 end
76 76
77 77 # Returns journal details that are visible to user
78 78 def visible_details(user=User.current)
79 79 details.select do |detail|
80 80 if detail.property == 'cf'
81 81 detail.custom_field && detail.custom_field.visible_by?(project, user)
82 82 elsif detail.property == 'relation'
83 83 Issue.find_by_id(detail.value || detail.old_value).try(:visible?, user)
84 84 else
85 85 true
86 86 end
87 87 end
88 88 end
89 89
90 90 def each_notification(users, &block)
91 91 if users.any?
92 92 users_by_details_visibility = users.group_by do |user|
93 93 visible_details(user)
94 94 end
95 95 users_by_details_visibility.each do |visible_details, users|
96 96 if notes? || visible_details.any?
97 97 yield(users)
98 98 end
99 99 end
100 100 end
101 101 end
102 102
103 103 # Returns the JournalDetail for the given attribute, or nil if the attribute
104 104 # was not updated
105 105 def detail_for_attribute(attribute)
106 106 details.detect {|detail| detail.prop_key == attribute}
107 107 end
108 108
109 109 # Returns the new status if the journal contains a status change, otherwise nil
110 110 def new_status
111 111 s = new_value_for('status_id')
112 112 s ? IssueStatus.find_by_id(s.to_i) : nil
113 113 end
114 114
115 115 def new_value_for(prop)
116 116 detail_for_attribute(prop).try(:value)
117 117 end
118 118
119 119 def editable_by?(usr)
120 120 usr && usr.logged? && (usr.allowed_to?(:edit_issue_notes, project) || (self.user == usr && usr.allowed_to?(:edit_own_issue_notes, project)))
121 121 end
122 122
123 123 def project
124 124 journalized.respond_to?(:project) ? journalized.project : nil
125 125 end
126 126
127 127 def attachments
128 128 journalized.respond_to?(:attachments) ? journalized.attachments : nil
129 129 end
130 130
131 131 # Returns a string of css classes
132 132 def css_classes
133 133 s = 'journal'
134 134 s << ' has-notes' unless notes.blank?
135 135 s << ' has-details' unless details.blank?
136 136 s << ' private-notes' if private_notes?
137 137 s
138 138 end
139 139
140 140 def notify?
141 141 @notify != false
142 142 end
143 143
144 144 def notify=(arg)
145 145 @notify = arg
146 146 end
147 147
148 148 def notified_users
149 149 notified = journalized.notified_users
150 150 if private_notes?
151 151 notified = notified.select {|user| user.allowed_to?(:view_private_notes, journalized.project)}
152 152 end
153 153 notified
154 154 end
155 155
156 156 def recipients
157 157 notified_users.map(&:mail)
158 158 end
159 159
160 160 def notified_watchers
161 161 notified = journalized.notified_watchers
162 162 if private_notes?
163 163 notified = notified.select {|user| user.allowed_to?(:view_private_notes, journalized.project)}
164 164 end
165 165 notified
166 166 end
167 167
168 168 def watcher_recipients
169 169 notified_watchers.map(&:mail)
170 170 end
171 171
172 172 # Sets @custom_field instance variable on journals details using a single query
173 173 def self.preload_journals_details_custom_fields(journals)
174 174 field_ids = journals.map(&:details).flatten.select {|d| d.property == 'cf'}.map(&:prop_key).uniq
175 175 if field_ids.any?
176 176 fields_by_id = CustomField.where(:id => field_ids).inject({}) {|h, f| h[f.id] = f; h}
177 177 journals.each do |journal|
178 178 journal.details.each do |detail|
179 179 if detail.property == 'cf'
180 180 detail.instance_variable_set "@custom_field", fields_by_id[detail.prop_key.to_i]
181 181 end
182 182 end
183 183 end
184 184 end
185 185 journals
186 186 end
187 187
188 188 # Stores the values of the attributes and custom fields of the journalized object
189 189 def start
190 190 if journalized
191 191 @attributes_before_change = journalized.journalized_attribute_names.inject({}) do |h, attribute|
192 192 h[attribute] = journalized.send(attribute)
193 193 h
194 194 end
195 195 @custom_values_before_change = journalized.custom_field_values.inject({}) do |h, c|
196 196 h[c.custom_field_id] = c.value
197 197 h
198 198 end
199 199 end
200 200 self
201 201 end
202 202
203 203 # Adds a journal detail for an attachment that was added or removed
204 204 def journalize_attachment(attachment, added_or_removed)
205 205 key = (added_or_removed == :removed ? :old_value : :value)
206 206 details << JournalDetail.new(
207 207 :property => 'attachment',
208 208 :prop_key => attachment.id,
209 209 key => attachment.filename
210 210 )
211 211 end
212 212
213 213 # Adds a journal detail for an issue relation that was added or removed
214 214 def journalize_relation(relation, added_or_removed)
215 215 key = (added_or_removed == :removed ? :old_value : :value)
216 216 details << JournalDetail.new(
217 217 :property => 'relation',
218 218 :prop_key => relation.relation_type_for(journalized),
219 219 key => relation.other_issue(journalized).try(:id)
220 220 )
221 221 end
222 222
223 223 private
224 224
225 225 # Generates journal details for attribute and custom field changes
226 226 def journalize_changes
227 227 # attributes changes
228 228 if @attributes_before_change
229 journalized.journalized_attribute_names.each {|attribute|
229 attrs = (journalized.journalized_attribute_names + @attributes_before_change.keys).uniq
230 attrs.each do |attribute|
230 231 before = @attributes_before_change[attribute]
231 232 after = journalized.send(attribute)
232 233 next if before == after || (before.blank? && after.blank?)
233 234 add_attribute_detail(attribute, before, after)
234 }
235 end
235 236 end
237 # custom fields changes
236 238 if @custom_values_before_change
237 # custom fields changes
238 journalized.custom_field_values.each {|c|
239 before = @custom_values_before_change[c.custom_field_id]
240 after = c.value
239 values_by_custom_field_id = {}
240 @custom_values_before_change.each do |custom_field_id, value|
241 values_by_custom_field_id[custom_field_id] = nil
242 end
243 journalized.custom_field_values.each do |c|
244 values_by_custom_field_id[c.custom_field_id] = c.value
245 end
246
247 values_by_custom_field_id.each do |custom_field_id, after|
248 before = @custom_values_before_change[custom_field_id]
241 249 next if before == after || (before.blank? && after.blank?)
242 250
243 251 if before.is_a?(Array) || after.is_a?(Array)
244 252 before = [before] unless before.is_a?(Array)
245 253 after = [after] unless after.is_a?(Array)
246 254
247 255 # values removed
248 256 (before - after).reject(&:blank?).each do |value|
249 add_custom_value_detail(c, value, nil)
257 add_custom_field_detail(custom_field_id, value, nil)
250 258 end
251 259 # values added
252 260 (after - before).reject(&:blank?).each do |value|
253 add_custom_value_detail(c, nil, value)
261 add_custom_field_detail(custom_field_id, nil, value)
254 262 end
255 263 else
256 add_custom_value_detail(c, before, after)
264 add_custom_field_detail(custom_field_id, before, after)
257 265 end
258 }
266 end
259 267 end
260 268 start
261 269 end
262 270
263 271 # Adds a journal detail for an attribute change
264 272 def add_attribute_detail(attribute, old_value, value)
265 273 add_detail('attr', attribute, old_value, value)
266 274 end
267 275
268 276 # Adds a journal detail for a custom field value change
269 def add_custom_value_detail(custom_value, old_value, value)
270 add_detail('cf', custom_value.custom_field_id, old_value, value)
277 def add_custom_field_detail(custom_field_id, old_value, value)
278 add_detail('cf', custom_field_id, old_value, value)
271 279 end
272 280
273 281 # Adds a journal detail
274 282 def add_detail(property, prop_key, old_value, value)
275 283 details << JournalDetail.new(
276 284 :property => property,
277 285 :prop_key => prop_key,
278 286 :old_value => old_value,
279 287 :value => value
280 288 )
281 289 end
282 290
283 291 def split_private_notes
284 292 if private_notes?
285 293 if notes.present?
286 294 if details.any?
287 295 # Split the journal (notes/changes) so we don't have half-private journals
288 296 journal = Journal.new(:journalized => journalized, :user => user, :notes => nil, :private_notes => false)
289 297 journal.details = details
290 298 journal.save
291 299 self.details = []
292 300 self.created_on = journal.created_on
293 301 end
294 302 else
295 303 # Blank notes should not be private
296 304 self.private_notes = false
297 305 end
298 306 end
299 307 true
300 308 end
301 309
302 310 def send_notification
303 311 if notify? && (Setting.notified_events.include?('issue_updated') ||
304 312 (Setting.notified_events.include?('issue_note_added') && notes.present?) ||
305 313 (Setting.notified_events.include?('issue_status_updated') && new_status.present?) ||
306 314 (Setting.notified_events.include?('issue_assigned_to_updated') && detail_for_attribute('assigned_to_id').present?) ||
307 315 (Setting.notified_events.include?('issue_priority_updated') && new_value_for('priority_id').present?)
308 316 )
309 317 Mailer.deliver_issue_edit(self)
310 318 end
311 319 end
312 320 end
1 NO CONTENT: modified file
The requested commit or file is too big and content was truncated. Show full diff
@@ -1,2970 +1,2988
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2016 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssueTest < ActiveSupport::TestCase
21 21 fixtures :projects, :users, :email_addresses, :user_preferences, :members, :member_roles, :roles,
22 22 :groups_users,
23 23 :trackers, :projects_trackers,
24 24 :enabled_modules,
25 25 :versions,
26 26 :issue_statuses, :issue_categories, :issue_relations, :workflows,
27 27 :enumerations,
28 28 :issues, :journals, :journal_details,
29 29 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
30 30 :time_entries
31 31
32 32 include Redmine::I18n
33 33
34 34 def setup
35 35 set_language_if_valid 'en'
36 36 end
37 37
38 38 def teardown
39 39 User.current = nil
40 40 end
41 41
42 42 def test_initialize
43 43 issue = Issue.new
44 44
45 45 assert_nil issue.project_id
46 46 assert_nil issue.tracker_id
47 47 assert_nil issue.status_id
48 48 assert_nil issue.author_id
49 49 assert_nil issue.assigned_to_id
50 50 assert_nil issue.category_id
51 51
52 52 assert_equal IssuePriority.default, issue.priority
53 53 end
54 54
55 55 def test_create
56 56 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
57 57 :status_id => 1, :priority => IssuePriority.all.first,
58 58 :subject => 'test_create',
59 59 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
60 60 assert issue.save
61 61 issue.reload
62 62 assert_equal 1.5, issue.estimated_hours
63 63 end
64 64
65 65 def test_create_minimal
66 66 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :subject => 'test_create')
67 67 assert issue.save
68 68 assert_equal issue.tracker.default_status, issue.status
69 69 assert issue.description.nil?
70 70 assert_nil issue.estimated_hours
71 71 end
72 72
73 73 def test_create_with_all_fields_disabled
74 74 tracker = Tracker.find(1)
75 75 tracker.core_fields = []
76 76 tracker.save!
77 77
78 78 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :subject => 'test_create_with_all_fields_disabled')
79 79 assert_save issue
80 80 end
81 81
82 82 def test_start_date_format_should_be_validated
83 83 set_language_if_valid 'en'
84 84 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
85 85 issue = Issue.new(:start_date => invalid_date)
86 86 assert !issue.valid?
87 87 assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
88 88 end
89 89 end
90 90
91 91 def test_due_date_format_should_be_validated
92 92 set_language_if_valid 'en'
93 93 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
94 94 issue = Issue.new(:due_date => invalid_date)
95 95 assert !issue.valid?
96 96 assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
97 97 end
98 98 end
99 99
100 100 def test_due_date_lesser_than_start_date_should_not_validate
101 101 set_language_if_valid 'en'
102 102 issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
103 103 assert !issue.valid?
104 104 assert_include 'Due date must be greater than start date', issue.errors.full_messages
105 105 end
106 106
107 107 def test_start_date_lesser_than_soonest_start_should_not_validate_on_create
108 108 issue = Issue.generate(:start_date => '2013-06-04')
109 109 issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
110 110 assert !issue.valid?
111 111 assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
112 112 end
113 113
114 114 def test_start_date_lesser_than_soonest_start_should_not_validate_on_update_if_changed
115 115 issue = Issue.generate!(:start_date => '2013-06-04')
116 116 issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
117 117 issue.start_date = '2013-06-07'
118 118 assert !issue.valid?
119 119 assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
120 120 end
121 121
122 122 def test_start_date_lesser_than_soonest_start_should_validate_on_update_if_unchanged
123 123 issue = Issue.generate!(:start_date => '2013-06-04')
124 124 issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
125 125 assert issue.valid?
126 126 end
127 127
128 128 def test_estimated_hours_should_be_validated
129 129 set_language_if_valid 'en'
130 130 ['-2'].each do |invalid|
131 131 issue = Issue.new(:estimated_hours => invalid)
132 132 assert !issue.valid?
133 133 assert_include 'Estimated time is invalid', issue.errors.full_messages
134 134 end
135 135 end
136 136
137 137 def test_create_with_required_custom_field
138 138 set_language_if_valid 'en'
139 139 field = IssueCustomField.find_by_name('Database')
140 140 field.update!(:is_required => true)
141 141
142 142 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
143 143 :status_id => 1, :subject => 'test_create',
144 144 :description => 'IssueTest#test_create_with_required_custom_field')
145 145 assert issue.available_custom_fields.include?(field)
146 146 # No value for the custom field
147 147 assert !issue.save
148 148 assert_equal ["Database cannot be blank"], issue.errors.full_messages
149 149 # Blank value
150 150 issue.custom_field_values = { field.id => '' }
151 151 assert !issue.save
152 152 assert_equal ["Database cannot be blank"], issue.errors.full_messages
153 153 # Invalid value
154 154 issue.custom_field_values = { field.id => 'SQLServer' }
155 155 assert !issue.save
156 156 assert_equal ["Database is not included in the list"], issue.errors.full_messages
157 157 # Valid value
158 158 issue.custom_field_values = { field.id => 'PostgreSQL' }
159 159 assert issue.save
160 160 issue.reload
161 161 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
162 162 end
163 163
164 164 def test_create_with_group_assignment
165 165 with_settings :issue_group_assignment => '1' do
166 166 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
167 167 :subject => 'Group assignment',
168 168 :assigned_to_id => 11).save
169 169 issue = Issue.order('id DESC').first
170 170 assert_kind_of Group, issue.assigned_to
171 171 assert_equal Group.find(11), issue.assigned_to
172 172 end
173 173 end
174 174
175 175 def test_create_with_parent_issue_id
176 176 issue = Issue.new(:project_id => 1, :tracker_id => 1,
177 177 :author_id => 1, :subject => 'Group assignment',
178 178 :parent_issue_id => 1)
179 179 assert_save issue
180 180 assert_equal 1, issue.parent_issue_id
181 181 assert_equal Issue.find(1), issue.parent
182 182 end
183 183
184 184 def test_create_with_sharp_parent_issue_id
185 185 issue = Issue.new(:project_id => 1, :tracker_id => 1,
186 186 :author_id => 1, :subject => 'Group assignment',
187 187 :parent_issue_id => "#1")
188 188 assert_save issue
189 189 assert_equal 1, issue.parent_issue_id
190 190 assert_equal Issue.find(1), issue.parent
191 191 end
192 192
193 193 def test_create_with_invalid_parent_issue_id
194 194 set_language_if_valid 'en'
195 195 issue = Issue.new(:project_id => 1, :tracker_id => 1,
196 196 :author_id => 1, :subject => 'Group assignment',
197 197 :parent_issue_id => '01ABC')
198 198 assert !issue.save
199 199 assert_equal '01ABC', issue.parent_issue_id
200 200 assert_include 'Parent task is invalid', issue.errors.full_messages
201 201 end
202 202
203 203 def test_create_with_invalid_sharp_parent_issue_id
204 204 set_language_if_valid 'en'
205 205 issue = Issue.new(:project_id => 1, :tracker_id => 1,
206 206 :author_id => 1, :subject => 'Group assignment',
207 207 :parent_issue_id => '#01ABC')
208 208 assert !issue.save
209 209 assert_equal '#01ABC', issue.parent_issue_id
210 210 assert_include 'Parent task is invalid', issue.errors.full_messages
211 211 end
212 212
213 213 def assert_visibility_match(user, issues)
214 214 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
215 215 end
216 216
217 217 def test_visible_scope_for_anonymous
218 218 # Anonymous user should see issues of public projects only
219 219 issues = Issue.visible(User.anonymous).to_a
220 220 assert issues.any?
221 221 assert_nil issues.detect {|issue| !issue.project.is_public?}
222 222 assert_nil issues.detect {|issue| issue.is_private?}
223 223 assert_visibility_match User.anonymous, issues
224 224 end
225 225
226 226 def test_visible_scope_for_anonymous_without_view_issues_permissions
227 227 # Anonymous user should not see issues without permission
228 228 Role.anonymous.remove_permission!(:view_issues)
229 229 issues = Issue.visible(User.anonymous).to_a
230 230 assert issues.empty?
231 231 assert_visibility_match User.anonymous, issues
232 232 end
233 233
234 234 def test_visible_scope_for_anonymous_without_view_issues_permissions_and_membership
235 235 Role.anonymous.remove_permission!(:view_issues)
236 236 Member.create!(:project_id => 1, :principal => Group.anonymous, :role_ids => [2])
237 237
238 238 issues = Issue.visible(User.anonymous).all
239 239 assert issues.any?
240 240 assert_equal [1], issues.map(&:project_id).uniq.sort
241 241 assert_visibility_match User.anonymous, issues
242 242 end
243 243
244 244 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
245 245 Role.anonymous.update!(:issues_visibility => 'default')
246 246 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
247 247 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
248 248 assert !issue.visible?(User.anonymous)
249 249 end
250 250
251 251 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
252 252 assert Role.anonymous.update!(:issues_visibility => 'own')
253 253 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
254 254 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
255 255 assert !issue.visible?(User.anonymous)
256 256 end
257 257
258 258 def test_visible_scope_for_non_member
259 259 user = User.find(9)
260 260 assert user.projects.empty?
261 261 # Non member user should see issues of public projects only
262 262 issues = Issue.visible(user).to_a
263 263 assert issues.any?
264 264 assert_nil issues.detect {|issue| !issue.project.is_public?}
265 265 assert_nil issues.detect {|issue| issue.is_private?}
266 266 assert_visibility_match user, issues
267 267 end
268 268
269 269 def test_visible_scope_for_non_member_with_own_issues_visibility
270 270 Role.non_member.update! :issues_visibility => 'own'
271 271 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
272 272 user = User.find(9)
273 273
274 274 issues = Issue.visible(user).to_a
275 275 assert issues.any?
276 276 assert_nil issues.detect {|issue| issue.author != user}
277 277 assert_visibility_match user, issues
278 278 end
279 279
280 280 def test_visible_scope_for_non_member_without_view_issues_permissions
281 281 # Non member user should not see issues without permission
282 282 Role.non_member.remove_permission!(:view_issues)
283 283 user = User.find(9)
284 284 assert user.projects.empty?
285 285 issues = Issue.visible(user).to_a
286 286 assert issues.empty?
287 287 assert_visibility_match user, issues
288 288 end
289 289
290 290 def test_visible_scope_for_non_member_without_view_issues_permissions_and_membership
291 291 Role.non_member.remove_permission!(:view_issues)
292 292 Member.create!(:project_id => 1, :principal => Group.non_member, :role_ids => [2])
293 293 user = User.find(9)
294 294
295 295 issues = Issue.visible(user).all
296 296 assert issues.any?
297 297 assert_equal [1], issues.map(&:project_id).uniq.sort
298 298 assert_visibility_match user, issues
299 299 end
300 300
301 301 def test_visible_scope_for_member
302 302 user = User.find(9)
303 303 # User should see issues of projects for which user has view_issues permissions only
304 304 Role.non_member.remove_permission!(:view_issues)
305 305 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
306 306 issues = Issue.visible(user).to_a
307 307 assert issues.any?
308 308 assert_nil issues.detect {|issue| issue.project_id != 3}
309 309 assert_nil issues.detect {|issue| issue.is_private?}
310 310 assert_visibility_match user, issues
311 311 end
312 312
313 313 def test_visible_scope_for_member_without_view_issues_permission_and_non_member_role_having_the_permission
314 314 Role.non_member.add_permission!(:view_issues)
315 315 Role.find(1).remove_permission!(:view_issues)
316 316 user = User.find(2)
317 317
318 318 assert_equal 0, Issue.where(:project_id => 1).visible(user).count
319 319 assert_equal false, Issue.where(:project_id => 1).first.visible?(user)
320 320 end
321 321
322 322 def test_visible_scope_with_custom_non_member_role_having_restricted_permission
323 323 role = Role.generate!(:permissions => [:view_project])
324 324 assert Role.non_member.has_permission?(:view_issues)
325 325 user = User.generate!
326 326 Member.create!(:principal => Group.non_member, :project_id => 1, :roles => [role])
327 327
328 328 issues = Issue.visible(user).to_a
329 329 assert issues.any?
330 330 assert_nil issues.detect {|issue| issue.project_id == 1}
331 331 end
332 332
333 333 def test_visible_scope_with_custom_non_member_role_having_extended_permission
334 334 role = Role.generate!(:permissions => [:view_project, :view_issues])
335 335 Role.non_member.remove_permission!(:view_issues)
336 336 user = User.generate!
337 337 Member.create!(:principal => Group.non_member, :project_id => 1, :roles => [role])
338 338
339 339 issues = Issue.visible(user).to_a
340 340 assert issues.any?
341 341 assert_not_nil issues.detect {|issue| issue.project_id == 1}
342 342 end
343 343
344 344 def test_visible_scope_for_member_with_groups_should_return_assigned_issues
345 345 user = User.find(8)
346 346 assert user.groups.any?
347 347 Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
348 348 Role.non_member.remove_permission!(:view_issues)
349 349
350 350 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 3,
351 351 :status_id => 1, :priority => IssuePriority.all.first,
352 352 :subject => 'Assignment test',
353 353 :assigned_to => user.groups.first,
354 354 :is_private => true)
355 355
356 356 Role.find(2).update! :issues_visibility => 'default'
357 357 issues = Issue.visible(User.find(8)).to_a
358 358 assert issues.any?
359 359 assert issues.include?(issue)
360 360
361 361 Role.find(2).update! :issues_visibility => 'own'
362 362 issues = Issue.visible(User.find(8)).to_a
363 363 assert issues.any?
364 364 assert_include issue, issues
365 365 end
366 366
367 367 def test_visible_scope_for_member_with_limited_tracker_ids
368 368 role = Role.find(1)
369 369 role.set_permission_trackers :view_issues, [2]
370 370 role.save!
371 371 user = User.find(2)
372 372
373 373 issues = Issue.where(:project_id => 1).visible(user).to_a
374 374 assert issues.any?
375 375 assert_equal [2], issues.map(&:tracker_id).uniq
376 376
377 377 assert Issue.where(:project_id => 1).all? {|issue| issue.visible?(user) ^ issue.tracker_id != 2}
378 378 end
379 379
380 380 def test_visible_scope_should_consider_tracker_ids_on_each_project
381 381 user = User.generate!
382 382
383 383 project1 = Project.generate!
384 384 role1 = Role.generate!
385 385 role1.add_permission! :view_issues
386 386 role1.set_permission_trackers :view_issues, :all
387 387 role1.save!
388 388 User.add_to_project(user, project1, role1)
389 389
390 390 project2 = Project.generate!
391 391 role2 = Role.generate!
392 392 role2.add_permission! :view_issues
393 393 role2.set_permission_trackers :view_issues, [2]
394 394 role2.save!
395 395 User.add_to_project(user, project2, role2)
396 396
397 397 visible_issues = [
398 398 Issue.generate!(:project => project1, :tracker_id => 1),
399 399 Issue.generate!(:project => project1, :tracker_id => 2),
400 400 Issue.generate!(:project => project2, :tracker_id => 2)
401 401 ]
402 402 hidden_issue = Issue.generate!(:project => project2, :tracker_id => 1)
403 403
404 404 issues = Issue.where(:project_id => [project1.id, project2.id]).visible(user)
405 405 assert_equal visible_issues.map(&:id), issues.ids.sort
406 406
407 407 assert visible_issues.all? {|issue| issue.visible?(user)}
408 408 assert !hidden_issue.visible?(user)
409 409 end
410 410
411 411 def test_visible_scope_should_not_consider_roles_without_view_issues_permission
412 412 user = User.generate!
413 413 role1 = Role.generate!
414 414 role1.remove_permission! :view_issues
415 415 role1.set_permission_trackers :view_issues, :all
416 416 role1.save!
417 417 role2 = Role.generate!
418 418 role2.add_permission! :view_issues
419 419 role2.set_permission_trackers :view_issues, [2]
420 420 role2.save!
421 421 User.add_to_project(user, Project.find(1), [role1, role2])
422 422
423 423 issues = Issue.where(:project_id => 1).visible(user).to_a
424 424 assert issues.any?
425 425 assert_equal [2], issues.map(&:tracker_id).uniq
426 426
427 427 assert Issue.where(:project_id => 1).all? {|issue| issue.visible?(user) ^ issue.tracker_id != 2}
428 428 end
429 429
430 430 def test_visible_scope_for_admin
431 431 user = User.find(1)
432 432 user.members.each(&:destroy)
433 433 assert user.projects.empty?
434 434 issues = Issue.visible(user).to_a
435 435 assert issues.any?
436 436 # Admin should see issues on private projects that admin does not belong to
437 437 assert issues.detect {|issue| !issue.project.is_public?}
438 438 # Admin should see private issues of other users
439 439 assert issues.detect {|issue| issue.is_private? && issue.author != user}
440 440 assert_visibility_match user, issues
441 441 end
442 442
443 443 def test_visible_scope_with_project
444 444 project = Project.find(1)
445 445 issues = Issue.visible(User.find(2), :project => project).to_a
446 446 projects = issues.collect(&:project).uniq
447 447 assert_equal 1, projects.size
448 448 assert_equal project, projects.first
449 449 end
450 450
451 451 def test_visible_scope_with_project_and_subprojects
452 452 project = Project.find(1)
453 453 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).to_a
454 454 projects = issues.collect(&:project).uniq
455 455 assert projects.size > 1
456 456 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
457 457 end
458 458
459 459 def test_visible_and_nested_set_scopes
460 460 user = User.generate!
461 461 parent = Issue.generate!(:assigned_to => user)
462 462 assert parent.visible?(user)
463 463 child1 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
464 464 child2 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
465 465 parent.reload
466 466 child1.reload
467 467 child2.reload
468 468 assert child1.visible?(user)
469 469 assert child2.visible?(user)
470 470 assert_equal 2, parent.descendants.count
471 471 assert_equal 2, parent.descendants.visible(user).count
472 472 # awesome_nested_set 2-1-stable branch has regression.
473 473 # https://github.com/collectiveidea/awesome_nested_set/commit/3d5ac746542b564f6586c2316180254b088bebb6
474 474 # ActiveRecord::StatementInvalid: SQLite3::SQLException: ambiguous column name: lft:
475 475 assert_equal 2, parent.descendants.collect{|i| i}.size
476 476 assert_equal 2, parent.descendants.visible(user).collect{|i| i}.size
477 477 end
478 478
479 479 def test_visible_scope_with_unsaved_user_should_not_raise_an_error
480 480 user = User.new
481 481 assert_nothing_raised do
482 482 Issue.visible(user).to_a
483 483 end
484 484 end
485 485
486 486 def test_open_scope
487 487 issues = Issue.open.to_a
488 488 assert_nil issues.detect(&:closed?)
489 489 end
490 490
491 491 def test_open_scope_with_arg
492 492 issues = Issue.open(false).to_a
493 493 assert_equal issues, issues.select(&:closed?)
494 494 end
495 495
496 496 def test_fixed_version_scope_with_a_version_should_return_its_fixed_issues
497 497 version = Version.find(2)
498 498 assert version.fixed_issues.any?
499 499 assert_equal version.fixed_issues.to_a.sort, Issue.fixed_version(version).to_a.sort
500 500 end
501 501
502 502 def test_fixed_version_scope_with_empty_array_should_return_no_result
503 503 assert_equal 0, Issue.fixed_version([]).count
504 504 end
505 505
506 506 def test_assigned_to_scope_should_return_issues_assigned_to_the_user
507 507 user = User.generate!
508 508 issue = Issue.generate!
509 509 Issue.where(:id => issue.id).update_all :assigned_to_id => user.id
510 510 assert_equal [issue], Issue.assigned_to(user).to_a
511 511 end
512 512
513 513 def test_assigned_to_scope_should_return_issues_assigned_to_the_user_groups
514 514 group = Group.generate!
515 515 user = User.generate!
516 516 group.users << user
517 517 issue = Issue.generate!
518 518 Issue.where(:id => issue.id).update_all :assigned_to_id => group.id
519 519 assert_equal [issue], Issue.assigned_to(user).to_a
520 520 end
521 521
522 522 def test_errors_full_messages_should_include_custom_fields_errors
523 523 field = IssueCustomField.find_by_name('Database')
524 524
525 525 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
526 526 :status_id => 1, :subject => 'test_create',
527 527 :description => 'IssueTest#test_create_with_required_custom_field')
528 528 assert issue.available_custom_fields.include?(field)
529 529 # Invalid value
530 530 issue.custom_field_values = { field.id => 'SQLServer' }
531 531
532 532 assert !issue.valid?
533 533 assert_equal 1, issue.errors.full_messages.size
534 534 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
535 535 issue.errors.full_messages.first
536 536 end
537 537
538 538 def test_update_issue_with_required_custom_field
539 539 field = IssueCustomField.find_by_name('Database')
540 540 field.update!(:is_required => true)
541 541
542 542 issue = Issue.find(1)
543 543 assert_nil issue.custom_value_for(field)
544 544 assert issue.available_custom_fields.include?(field)
545 545 # No change to custom values, issue can be saved
546 546 assert issue.save
547 547 # Blank value
548 548 issue.custom_field_values = { field.id => '' }
549 549 assert !issue.save
550 550 # Valid value
551 551 issue.custom_field_values = { field.id => 'PostgreSQL' }
552 552 assert issue.save
553 553 issue.reload
554 554 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
555 555 end
556 556
557 557 def test_should_not_update_attributes_if_custom_fields_validation_fails
558 558 issue = Issue.find(1)
559 559 field = IssueCustomField.find_by_name('Database')
560 560 assert issue.available_custom_fields.include?(field)
561 561
562 562 issue.custom_field_values = { field.id => 'Invalid' }
563 563 issue.subject = 'Should be not be saved'
564 564 assert !issue.save
565 565
566 566 issue.reload
567 567 assert_equal "Cannot print recipes", issue.subject
568 568 end
569 569
570 570 def test_should_not_recreate_custom_values_objects_on_update
571 571 field = IssueCustomField.find_by_name('Database')
572 572
573 573 issue = Issue.find(1)
574 574 issue.custom_field_values = { field.id => 'PostgreSQL' }
575 575 assert issue.save
576 576 custom_value = issue.custom_value_for(field)
577 577 issue.reload
578 578 issue.custom_field_values = { field.id => 'MySQL' }
579 579 assert issue.save
580 580 issue.reload
581 581 assert_equal custom_value.id, issue.custom_value_for(field).id
582 582 end
583 583
584 584 def test_setting_project_should_set_version_to_default_version
585 585 version = Version.generate!(:project_id => 1)
586 586 Project.find(1).update!(:default_version_id => version.id)
587 587
588 588 issue = Issue.new(:project_id => 1)
589 589 assert_equal version, issue.fixed_version
590 590 end
591 591
592 592 def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
593 593 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
594 594 :status_id => 1, :subject => 'Test',
595 595 :custom_field_values => {'2' => 'Test'})
596 596 assert !Tracker.find(2).custom_field_ids.include?(2)
597 597
598 598 issue = Issue.find(issue.id)
599 599 issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
600 600
601 601 issue = Issue.find(issue.id)
602 602 custom_value = issue.custom_value_for(2)
603 603 assert_not_nil custom_value
604 604 assert_equal 'Test', custom_value.value
605 605 end
606 606
607 607 def test_assigning_tracker_id_should_reload_custom_fields_values
608 608 issue = Issue.new(:project => Project.find(1))
609 609 assert issue.custom_field_values.empty?
610 610 issue.tracker_id = 1
611 611 assert issue.custom_field_values.any?
612 612 end
613 613
614 614 def test_assigning_attributes_should_assign_project_and_tracker_first
615 615 seq = sequence('seq')
616 616 issue = Issue.new
617 617 issue.expects(:project_id=).in_sequence(seq)
618 618 issue.expects(:tracker_id=).in_sequence(seq)
619 619 issue.expects(:subject=).in_sequence(seq)
620 620 issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
621 621 end
622 622
623 623 def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
624 624 attributes = ActiveSupport::OrderedHash.new
625 625 attributes['custom_field_values'] = { '1' => 'MySQL' }
626 626 attributes['tracker_id'] = '1'
627 627 issue = Issue.new(:project => Project.find(1))
628 628 issue.attributes = attributes
629 629 assert_equal 'MySQL', issue.custom_field_value(1)
630 630 end
631 631
632 632 def test_changing_tracker_should_clear_disabled_core_fields
633 633 tracker = Tracker.find(2)
634 634 tracker.core_fields = tracker.core_fields - %w(due_date)
635 635 tracker.save!
636 636
637 637 issue = Issue.generate!(:tracker_id => 1, :start_date => Date.today, :due_date => Date.today)
638 638 issue.save!
639 639
640 640 issue.tracker_id = 2
641 641 issue.save!
642 642 assert_not_nil issue.start_date
643 643 assert_nil issue.due_date
644 644 end
645 645
646 def test_changing_tracker_should_not_add_cleared_fields_to_journal
646 def test_attribute_cleared_on_tracker_change_should_be_journalized
647 CustomField.delete_all
647 648 tracker = Tracker.find(2)
648 649 tracker.core_fields = tracker.core_fields - %w(due_date)
649 650 tracker.save!
650 651
651 652 issue = Issue.generate!(:tracker_id => 1, :due_date => Date.today)
652 653 issue.save!
653 654
654 655 assert_difference 'Journal.count' do
655 656 issue.init_journal User.find(1)
656 657 issue.tracker_id = 2
657 658 issue.save!
658 659 assert_nil issue.due_date
659 660 end
660 661 journal = Journal.order('id DESC').first
661 assert_equal 1, journal.details.count
662 details = journal.details.select {|d| d.prop_key == 'due_date'}
663 assert_equal 1, details.count
662 664 end
663 665
664 666 def test_reload_should_reload_custom_field_values
665 667 issue = Issue.generate!
666 668 issue.custom_field_values = {'2' => 'Foo'}
667 669 issue.save!
668 670
669 671 issue = Issue.order('id desc').first
670 672 assert_equal 'Foo', issue.custom_field_value(2)
671 673
672 674 issue.custom_field_values = {'2' => 'Bar'}
673 675 assert_equal 'Bar', issue.custom_field_value(2)
674 676
675 677 issue.reload
676 678 assert_equal 'Foo', issue.custom_field_value(2)
677 679 end
678 680
679 681 def test_should_update_issue_with_disabled_tracker
680 682 p = Project.find(1)
681 683 issue = Issue.find(1)
682 684
683 685 p.trackers.delete(issue.tracker)
684 686 assert !p.trackers.include?(issue.tracker)
685 687
686 688 issue.reload
687 689 issue.subject = 'New subject'
688 690 assert issue.save
689 691 end
690 692
691 693 def test_should_not_set_a_disabled_tracker
692 694 p = Project.find(1)
693 695 p.trackers.delete(Tracker.find(2))
694 696
695 697 issue = Issue.find(1)
696 698 issue.tracker_id = 2
697 699 issue.subject = 'New subject'
698 700 assert !issue.save
699 701 assert_not_equal [], issue.errors[:tracker_id]
700 702 end
701 703
702 704 def test_category_based_assignment
703 705 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
704 706 :status_id => 1, :priority => IssuePriority.all.first,
705 707 :subject => 'Assignment test',
706 708 :description => 'Assignment test', :category_id => 1)
707 709 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
708 710 end
709 711
710 712 def test_new_statuses_allowed_to
711 713 WorkflowTransition.delete_all
712 714 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
713 715 :old_status_id => 1, :new_status_id => 2,
714 716 :author => false, :assignee => false)
715 717 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
716 718 :old_status_id => 1, :new_status_id => 3,
717 719 :author => true, :assignee => false)
718 720 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
719 721 :old_status_id => 1, :new_status_id => 4,
720 722 :author => false, :assignee => true)
721 723 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
722 724 :old_status_id => 1, :new_status_id => 5,
723 725 :author => true, :assignee => true)
724 726 status = IssueStatus.find(1)
725 727 role = Role.find(1)
726 728 tracker = Tracker.find(1)
727 729 user = User.find(2)
728 730
729 731 issue = Issue.generate!(:tracker => tracker, :status => status,
730 732 :project_id => 1, :author_id => 1)
731 733 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
732 734
733 735 issue = Issue.generate!(:tracker => tracker, :status => status,
734 736 :project_id => 1, :author => user)
735 737 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
736 738
737 739 issue = Issue.generate!(:tracker => tracker, :status => status,
738 740 :project_id => 1, :author_id => 1,
739 741 :assigned_to => user)
740 742 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
741 743
742 744 issue = Issue.generate!(:tracker => tracker, :status => status,
743 745 :project_id => 1, :author => user,
744 746 :assigned_to => user)
745 747 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
746 748
747 749 group = Group.generate!
748 750 group.users << user
749 751 issue = Issue.generate!(:tracker => tracker, :status => status,
750 752 :project_id => 1, :author => user,
751 753 :assigned_to => group)
752 754 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
753 755 end
754 756
755 757 def test_new_statuses_allowed_to_should_consider_group_assignment
756 758 WorkflowTransition.delete_all
757 759 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
758 760 :old_status_id => 1, :new_status_id => 4,
759 761 :author => false, :assignee => true)
760 762 user = User.find(2)
761 763 group = Group.generate!
762 764 group.users << user
763 765
764 766 issue = Issue.generate!(:author_id => 1, :assigned_to => group)
765 767 assert_include 4, issue.new_statuses_allowed_to(user).map(&:id)
766 768 end
767 769
768 770 def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
769 771 admin = User.find(1)
770 772 issue = Issue.find(1)
771 773 assert !admin.member_of?(issue.project)
772 774 expected_statuses = [issue.status] +
773 775 WorkflowTransition.where(:old_status_id => issue.status_id).
774 776 map(&:new_status).uniq.sort
775 777 assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
776 778 end
777 779
778 780 def test_new_statuses_allowed_to_should_return_allowed_statuses_and_current_status_when_copying
779 781 Tracker.find(1).generate_transitions! :role_id => 1, :clear => true, 0 => [1, 3]
780 782
781 783 orig = Issue.generate!(:project_id => 1, :tracker_id => 1, :status_id => 4)
782 784 issue = orig.copy
783 785 assert_equal [1, 3, 4], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
784 786 assert_equal 4, issue.status_id
785 787 end
786 788
787 789 def test_safe_attributes_names_should_not_include_disabled_field
788 790 tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
789 791
790 792 issue = Issue.new(:tracker => tracker)
791 793 assert_include 'tracker_id', issue.safe_attribute_names
792 794 assert_include 'status_id', issue.safe_attribute_names
793 795 assert_include 'subject', issue.safe_attribute_names
794 796 assert_include 'description', issue.safe_attribute_names
795 797 assert_include 'custom_field_values', issue.safe_attribute_names
796 798 assert_include 'custom_fields', issue.safe_attribute_names
797 799 assert_include 'lock_version', issue.safe_attribute_names
798 800
799 801 tracker.core_fields.each do |field|
800 802 assert_include field, issue.safe_attribute_names
801 803 end
802 804
803 805 tracker.disabled_core_fields.each do |field|
804 806 assert_not_include field, issue.safe_attribute_names
805 807 end
806 808 end
807 809
808 810 def test_safe_attributes_should_ignore_disabled_fields
809 811 tracker = Tracker.find(1)
810 812 tracker.core_fields = %w(assigned_to_id due_date)
811 813 tracker.save!
812 814
813 815 issue = Issue.new(:tracker => tracker)
814 816 issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
815 817 assert_nil issue.start_date
816 818 assert_equal Date.parse('2012-07-14'), issue.due_date
817 819 end
818 820
819 821 def test_safe_attributes_should_accept_target_tracker_enabled_fields
820 822 source = Tracker.find(1)
821 823 source.core_fields = []
822 824 source.save!
823 825 target = Tracker.find(2)
824 826 target.core_fields = %w(assigned_to_id due_date)
825 827 target.save!
826 828 user = User.find(2)
827 829
828 830 issue = Issue.new(:project => Project.find(1), :tracker => source)
829 831 issue.send :safe_attributes=, {'tracker_id' => 2, 'due_date' => '2012-07-14'}, user
830 832 assert_equal target, issue.tracker
831 833 assert_equal Date.parse('2012-07-14'), issue.due_date
832 834 end
833 835
834 836 def test_safe_attributes_should_not_include_readonly_fields
835 837 WorkflowPermission.delete_all
836 838 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
837 839 :role_id => 1, :field_name => 'due_date',
838 840 :rule => 'readonly')
839 841 user = User.find(2)
840 842
841 843 issue = Issue.new(:project_id => 1, :tracker_id => 1)
842 844 assert_equal %w(due_date), issue.read_only_attribute_names(user)
843 845 assert_not_include 'due_date', issue.safe_attribute_names(user)
844 846
845 847 issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
846 848 assert_equal Date.parse('2012-07-14'), issue.start_date
847 849 assert_nil issue.due_date
848 850 end
849 851
850 852 def test_safe_attributes_should_not_include_readonly_custom_fields
851 853 cf1 = IssueCustomField.create!(:name => 'Writable field',
852 854 :field_format => 'string',
853 855 :is_for_all => true, :tracker_ids => [1])
854 856 cf2 = IssueCustomField.create!(:name => 'Readonly field',
855 857 :field_format => 'string',
856 858 :is_for_all => true, :tracker_ids => [1])
857 859 WorkflowPermission.delete_all
858 860 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
859 861 :role_id => 1, :field_name => cf2.id.to_s,
860 862 :rule => 'readonly')
861 863 user = User.find(2)
862 864 issue = Issue.new(:project_id => 1, :tracker_id => 1)
863 865 assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
864 866 assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
865 867
866 868 issue.send :safe_attributes=, {'custom_field_values' => {
867 869 cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
868 870 }}, user
869 871 assert_equal 'value1', issue.custom_field_value(cf1)
870 872 assert_nil issue.custom_field_value(cf2)
871 873
872 874 issue.send :safe_attributes=, {'custom_fields' => [
873 875 {'id' => cf1.id.to_s, 'value' => 'valuea'},
874 876 {'id' => cf2.id.to_s, 'value' => 'valueb'}
875 877 ]}, user
876 878 assert_equal 'valuea', issue.custom_field_value(cf1)
877 879 assert_nil issue.custom_field_value(cf2)
878 880 end
879 881
880 882 def test_safe_attributes_should_ignore_unassignable_assignee
881 883 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
882 884 :status_id => 1, :priority => IssuePriority.all.first,
883 885 :subject => 'test_create')
884 886 assert issue.valid?
885 887
886 888 # locked user, not allowed
887 889 issue.safe_attributes=({'assigned_to_id' => '5'})
888 890 assert_nil issue.assigned_to_id
889 891 # no member
890 892 issue.safe_attributes=({'assigned_to_id' => '1'})
891 893 assert_nil issue.assigned_to_id
892 894 # user 2 is ok
893 895 issue.safe_attributes=({'assigned_to_id' => '2'})
894 896 assert_equal 2, issue.assigned_to_id
895 897 assert issue.save
896 898
897 899 issue.reload
898 900 assert_equal 2, issue.assigned_to_id
899 901 issue.safe_attributes=({'assigned_to_id' => '5'})
900 902 assert_equal 2, issue.assigned_to_id
901 903 issue.safe_attributes=({'assigned_to_id' => '1'})
902 904 assert_equal 2, issue.assigned_to_id
903 905 # user 3 is also ok
904 906 issue.safe_attributes=({'assigned_to_id' => '3'})
905 907 assert_equal 3, issue.assigned_to_id
906 908 assert issue.save
907 909
908 910 # removal of assignee
909 911 issue.safe_attributes=({'assigned_to_id' => ''})
910 912 assert_nil issue.assigned_to_id
911 913 assert issue.save
912 914 end
913 915
914 916 def test_editable_custom_field_values_should_return_non_readonly_custom_values
915 917 cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
916 918 :is_for_all => true, :tracker_ids => [1, 2])
917 919 cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
918 920 :is_for_all => true, :tracker_ids => [1, 2])
919 921 WorkflowPermission.delete_all
920 922 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
921 923 :field_name => cf2.id.to_s, :rule => 'readonly')
922 924 user = User.find(2)
923 925
924 926 issue = Issue.new(:project_id => 1, :tracker_id => 1)
925 927 values = issue.editable_custom_field_values(user)
926 928 assert values.detect {|value| value.custom_field == cf1}
927 929 assert_nil values.detect {|value| value.custom_field == cf2}
928 930
929 931 issue.tracker_id = 2
930 932 values = issue.editable_custom_field_values(user)
931 933 assert values.detect {|value| value.custom_field == cf1}
932 934 assert values.detect {|value| value.custom_field == cf2}
933 935 end
934 936
935 937 def test_editable_custom_fields_should_return_custom_field_that_is_enabled_for_the_role_only
936 938 enabled_cf = IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1], :visible => false, :role_ids => [1,2])
937 939 disabled_cf = IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1], :visible => false, :role_ids => [2])
938 940 user = User.find(2)
939 941 issue = Issue.new(:project_id => 1, :tracker_id => 1)
940 942
941 943 assert_include enabled_cf, issue.editable_custom_fields(user)
942 944 assert_not_include disabled_cf, issue.editable_custom_fields(user)
943 945 end
944 946
945 947 def test_safe_attributes_should_accept_target_tracker_writable_fields
946 948 WorkflowPermission.delete_all
947 949 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
948 950 :role_id => 1, :field_name => 'due_date',
949 951 :rule => 'readonly')
950 952 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
951 953 :role_id => 1, :field_name => 'start_date',
952 954 :rule => 'readonly')
953 955 user = User.find(2)
954 956
955 957 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
956 958
957 959 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
958 960 'due_date' => '2012-07-14'}, user
959 961 assert_equal Date.parse('2012-07-12'), issue.start_date
960 962 assert_nil issue.due_date
961 963
962 964 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
963 965 'due_date' => '2012-07-16',
964 966 'tracker_id' => 2}, user
965 967 assert_equal Date.parse('2012-07-12'), issue.start_date
966 968 assert_equal Date.parse('2012-07-16'), issue.due_date
967 969 end
968 970
969 971 def test_safe_attributes_should_accept_target_status_writable_fields
970 972 WorkflowPermission.delete_all
971 973 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
972 974 :role_id => 1, :field_name => 'due_date',
973 975 :rule => 'readonly')
974 976 WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
975 977 :role_id => 1, :field_name => 'start_date',
976 978 :rule => 'readonly')
977 979 user = User.find(2)
978 980
979 981 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
980 982
981 983 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
982 984 'due_date' => '2012-07-14'},
983 985 user
984 986 assert_equal Date.parse('2012-07-12'), issue.start_date
985 987 assert_nil issue.due_date
986 988
987 989 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
988 990 'due_date' => '2012-07-16',
989 991 'status_id' => 2},
990 992 user
991 993 assert_equal Date.parse('2012-07-12'), issue.start_date
992 994 assert_equal Date.parse('2012-07-16'), issue.due_date
993 995 end
994 996
995 997 def test_required_attributes_should_be_validated
996 998 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
997 999 :is_for_all => true, :tracker_ids => [1, 2])
998 1000
999 1001 WorkflowPermission.delete_all
1000 1002 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1001 1003 :role_id => 1, :field_name => 'due_date',
1002 1004 :rule => 'required')
1003 1005 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1004 1006 :role_id => 1, :field_name => 'category_id',
1005 1007 :rule => 'required')
1006 1008 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1007 1009 :role_id => 1, :field_name => cf.id.to_s,
1008 1010 :rule => 'required')
1009 1011
1010 1012 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
1011 1013 :role_id => 1, :field_name => 'start_date',
1012 1014 :rule => 'required')
1013 1015 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
1014 1016 :role_id => 1, :field_name => cf.id.to_s,
1015 1017 :rule => 'required')
1016 1018 user = User.find(2)
1017 1019
1018 1020 issue = Issue.new(:project_id => 1, :tracker_id => 1,
1019 1021 :status_id => 1, :subject => 'Required fields',
1020 1022 :author => user)
1021 1023 assert_equal [cf.id.to_s, "category_id", "due_date"],
1022 1024 issue.required_attribute_names(user).sort
1023 1025 assert !issue.save, "Issue was saved"
1024 1026 assert_equal ["Category cannot be blank", "Due date cannot be blank", "Foo cannot be blank"],
1025 1027 issue.errors.full_messages.sort
1026 1028
1027 1029 issue.tracker_id = 2
1028 1030 assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
1029 1031 assert !issue.save, "Issue was saved"
1030 1032 assert_equal ["Foo cannot be blank", "Start date cannot be blank"],
1031 1033 issue.errors.full_messages.sort
1032 1034
1033 1035 issue.start_date = Date.today
1034 1036 issue.custom_field_values = {cf.id.to_s => 'bar'}
1035 1037 assert issue.save
1036 1038 end
1037 1039
1038 1040 def test_required_attribute_that_is_disabled_for_the_tracker_should_not_be_required
1039 1041 WorkflowPermission.delete_all
1040 1042 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1041 1043 :role_id => 1, :field_name => 'start_date',
1042 1044 :rule => 'required')
1043 1045 user = User.find(2)
1044 1046
1045 1047 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
1046 1048 :subject => 'Required fields', :author => user)
1047 1049 assert !issue.save
1048 1050 assert_include "Start date cannot be blank", issue.errors.full_messages
1049 1051
1050 1052 tracker = Tracker.find(1)
1051 1053 tracker.core_fields -= %w(start_date)
1052 1054 tracker.save!
1053 1055 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
1054 1056 :subject => 'Required fields', :author => user)
1055 1057 assert issue.save
1056 1058 end
1057 1059
1058 1060 def test_category_should_not_be_required_if_project_has_no_categories
1059 1061 Project.find(1).issue_categories.delete_all
1060 1062 WorkflowPermission.delete_all
1061 1063 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1062 1064 :role_id => 1, :field_name => 'category_id',:rule => 'required')
1063 1065 user = User.find(2)
1064 1066
1065 1067 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
1066 1068 :subject => 'Required fields', :author => user)
1067 1069 assert_save issue
1068 1070 end
1069 1071
1070 1072 def test_fixed_version_should_not_be_required_no_assignable_versions
1071 1073 Version.delete_all
1072 1074 WorkflowPermission.delete_all
1073 1075 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1074 1076 :role_id => 1, :field_name => 'fixed_version_id',:rule => 'required')
1075 1077 user = User.find(2)
1076 1078
1077 1079 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
1078 1080 :subject => 'Required fields', :author => user)
1079 1081 assert_save issue
1080 1082 end
1081 1083
1082 1084 def test_required_custom_field_that_is_not_visible_for_the_user_should_not_be_required
1083 1085 CustomField.delete_all
1084 1086 field = IssueCustomField.generate!(:is_required => true, :visible => false, :role_ids => [1], :trackers => Tracker.all, :is_for_all => true)
1085 1087 user = User.generate!
1086 1088 User.add_to_project(user, Project.find(1), Role.find(2))
1087 1089
1088 1090 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
1089 1091 :subject => 'Required fields', :author => user)
1090 1092 assert_save issue
1091 1093 end
1092 1094
1093 1095 def test_required_custom_field_that_is_visible_for_the_user_should_be_required
1094 1096 CustomField.delete_all
1095 1097 field = IssueCustomField.generate!(:is_required => true, :visible => false, :role_ids => [1], :trackers => Tracker.all, :is_for_all => true)
1096 1098 user = User.generate!
1097 1099 User.add_to_project(user, Project.find(1), Role.find(1))
1098 1100
1099 1101 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
1100 1102 :subject => 'Required fields', :author => user)
1101 1103 assert !issue.save
1102 1104 assert_include "#{field.name} cannot be blank", issue.errors.full_messages
1103 1105 end
1104 1106
1105 1107 def test_required_attribute_names_for_multiple_roles_should_intersect_rules
1106 1108 WorkflowPermission.delete_all
1107 1109 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1108 1110 :role_id => 1, :field_name => 'due_date',
1109 1111 :rule => 'required')
1110 1112 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1111 1113 :role_id => 1, :field_name => 'start_date',
1112 1114 :rule => 'required')
1113 1115 user = User.find(2)
1114 1116 member = Member.find(1)
1115 1117 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
1116 1118
1117 1119 assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
1118 1120
1119 1121 member.role_ids = [1, 2]
1120 1122 member.save!
1121 1123 assert_equal [], issue.required_attribute_names(user.reload)
1122 1124
1123 1125 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1124 1126 :role_id => 2, :field_name => 'due_date',
1125 1127 :rule => 'required')
1126 1128 assert_equal %w(due_date), issue.required_attribute_names(user)
1127 1129
1128 1130 member.role_ids = [1, 2, 3]
1129 1131 member.save!
1130 1132 assert_equal [], issue.required_attribute_names(user.reload)
1131 1133
1132 1134 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1133 1135 :role_id => 3, :field_name => 'due_date',
1134 1136 :rule => 'readonly')
1135 1137 # required + readonly => required
1136 1138 assert_equal %w(due_date), issue.required_attribute_names(user)
1137 1139 end
1138 1140
1139 1141 def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
1140 1142 WorkflowPermission.delete_all
1141 1143 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1142 1144 :role_id => 1, :field_name => 'due_date',
1143 1145 :rule => 'readonly')
1144 1146 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1145 1147 :role_id => 1, :field_name => 'start_date',
1146 1148 :rule => 'readonly')
1147 1149 user = User.find(2)
1148 1150 member = Member.find(1)
1149 1151 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
1150 1152
1151 1153 assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
1152 1154
1153 1155 member.role_ids = [1, 2]
1154 1156 member.save!
1155 1157 assert_equal [], issue.read_only_attribute_names(user.reload)
1156 1158
1157 1159 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1158 1160 :role_id => 2, :field_name => 'due_date',
1159 1161 :rule => 'readonly')
1160 1162 assert_equal %w(due_date), issue.read_only_attribute_names(user)
1161 1163 end
1162 1164
1163 1165 # A field that is not visible by role 2 and readonly by role 1 should be readonly for user with role 1 and 2
1164 1166 def test_read_only_attribute_names_should_include_custom_fields_that_combine_readonly_and_not_visible_for_roles
1165 1167 field = IssueCustomField.generate!(
1166 1168 :is_for_all => true, :trackers => Tracker.all, :visible => false, :role_ids => [1]
1167 1169 )
1168 1170 WorkflowPermission.delete_all
1169 1171 WorkflowPermission.create!(
1170 1172 :old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => field.id, :rule => 'readonly'
1171 1173 )
1172 1174 user = User.generate!
1173 1175 project = Project.find(1)
1174 1176 User.add_to_project(user, project, Role.where(:id => [1, 2]))
1175 1177
1176 1178 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
1177 1179 assert_equal [field.id.to_s], issue.read_only_attribute_names(user)
1178 1180 end
1179 1181
1180 1182 def test_workflow_rules_should_ignore_roles_without_issue_permissions
1181 1183 role = Role.generate! :permissions => [:view_issues, :edit_issues]
1182 1184 ignored_role = Role.generate! :permissions => [:view_issues]
1183 1185
1184 1186 WorkflowPermission.delete_all
1185 1187 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1186 1188 :role => role, :field_name => 'due_date',
1187 1189 :rule => 'required')
1188 1190 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1189 1191 :role => role, :field_name => 'start_date',
1190 1192 :rule => 'readonly')
1191 1193 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1192 1194 :role => role, :field_name => 'done_ratio',
1193 1195 :rule => 'readonly')
1194 1196 user = User.generate!
1195 1197 User.add_to_project user, Project.find(1), [role, ignored_role]
1196 1198
1197 1199 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
1198 1200
1199 1201 assert_equal %w(due_date), issue.required_attribute_names(user)
1200 1202 assert_equal %w(done_ratio start_date), issue.read_only_attribute_names(user).sort
1201 1203 end
1202 1204
1203 1205 def test_workflow_rules_should_work_for_member_with_duplicate_role
1204 1206 WorkflowPermission.delete_all
1205 1207 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1206 1208 :role_id => 1, :field_name => 'due_date',
1207 1209 :rule => 'required')
1208 1210 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1209 1211 :role_id => 1, :field_name => 'start_date',
1210 1212 :rule => 'readonly')
1211 1213
1212 1214 user = User.generate!
1213 1215 m = Member.new(:user_id => user.id, :project_id => 1)
1214 1216 m.member_roles.build(:role_id => 1)
1215 1217 m.member_roles.build(:role_id => 1)
1216 1218 m.save!
1217 1219
1218 1220 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
1219 1221
1220 1222 assert_equal %w(due_date), issue.required_attribute_names(user)
1221 1223 assert_equal %w(start_date), issue.read_only_attribute_names(user)
1222 1224 end
1223 1225
1224 1226 def test_copy
1225 1227 issue = Issue.new.copy_from(1)
1226 1228 assert issue.copy?
1227 1229 assert issue.save
1228 1230 issue.reload
1229 1231 orig = Issue.find(1)
1230 1232 assert_equal orig.subject, issue.subject
1231 1233 assert_equal orig.tracker, issue.tracker
1232 1234 assert_equal "125", issue.custom_value_for(2).value
1233 1235 end
1234 1236
1235 1237 def test_copy_should_copy_status
1236 1238 orig = Issue.find(8)
1237 1239 assert orig.status != orig.default_status
1238 1240
1239 1241 issue = Issue.new.copy_from(orig)
1240 1242 assert issue.save
1241 1243 issue.reload
1242 1244 assert_equal orig.status, issue.status
1243 1245 end
1244 1246
1245 1247 def test_copy_should_add_relation_with_copied_issue
1246 1248 copied = Issue.find(1)
1247 1249 issue = Issue.new.copy_from(copied)
1248 1250 assert issue.save
1249 1251 issue.reload
1250 1252
1251 1253 assert_equal 1, issue.relations.size
1252 1254 relation = issue.relations.first
1253 1255 assert_equal 'copied_to', relation.relation_type
1254 1256 assert_equal copied, relation.issue_from
1255 1257 assert_equal issue, relation.issue_to
1256 1258 end
1257 1259
1258 1260 def test_copy_should_copy_subtasks
1259 1261 issue = Issue.generate_with_descendants!
1260 1262
1261 1263 copy = issue.reload.copy
1262 1264 copy.author = User.find(7)
1263 1265 assert_difference 'Issue.count', 1+issue.descendants.count do
1264 1266 assert copy.save
1265 1267 end
1266 1268 copy.reload
1267 1269 assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
1268 1270 child_copy = copy.children.detect {|c| c.subject == 'Child1'}
1269 1271 assert_equal %w(Child11), child_copy.children.map(&:subject).sort
1270 1272 assert_equal copy.author, child_copy.author
1271 1273 end
1272 1274
1273 1275 def test_copy_as_a_child_of_copied_issue_should_not_copy_itself
1274 1276 parent = Issue.generate!
1275 1277 child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
1276 1278 child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
1277 1279
1278 1280 copy = parent.reload.copy
1279 1281 copy.parent_issue_id = parent.id
1280 1282 copy.author = User.find(7)
1281 1283 assert_difference 'Issue.count', 3 do
1282 1284 assert copy.save
1283 1285 end
1284 1286 parent.reload
1285 1287 copy.reload
1286 1288 assert_equal parent, copy.parent
1287 1289 assert_equal 3, parent.children.count
1288 1290 assert_equal 5, parent.descendants.count
1289 1291 assert_equal 2, copy.children.count
1290 1292 assert_equal 2, copy.descendants.count
1291 1293 end
1292 1294
1293 1295 def test_copy_as_a_descendant_of_copied_issue_should_not_copy_itself
1294 1296 parent = Issue.generate!
1295 1297 child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
1296 1298 child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
1297 1299
1298 1300 copy = parent.reload.copy
1299 1301 copy.parent_issue_id = child1.id
1300 1302 copy.author = User.find(7)
1301 1303 assert_difference 'Issue.count', 3 do
1302 1304 assert copy.save
1303 1305 end
1304 1306 parent.reload
1305 1307 child1.reload
1306 1308 copy.reload
1307 1309 assert_equal child1, copy.parent
1308 1310 assert_equal 2, parent.children.count
1309 1311 assert_equal 5, parent.descendants.count
1310 1312 assert_equal 1, child1.children.count
1311 1313 assert_equal 3, child1.descendants.count
1312 1314 assert_equal 2, copy.children.count
1313 1315 assert_equal 2, copy.descendants.count
1314 1316 end
1315 1317
1316 1318 def test_copy_should_copy_subtasks_to_target_project
1317 1319 issue = Issue.generate_with_descendants!
1318 1320
1319 1321 copy = issue.copy(:project_id => 3)
1320 1322 assert_difference 'Issue.count', 1+issue.descendants.count do
1321 1323 assert copy.save
1322 1324 end
1323 1325 assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
1324 1326 end
1325 1327
1326 1328 def test_copy_should_not_copy_subtasks_twice_when_saving_twice
1327 1329 issue = Issue.generate_with_descendants!
1328 1330
1329 1331 copy = issue.reload.copy
1330 1332 assert_difference 'Issue.count', 1+issue.descendants.count do
1331 1333 assert copy.save
1332 1334 assert copy.save
1333 1335 end
1334 1336 end
1335 1337
1336 1338 def test_should_not_call_after_project_change_on_creation
1337 1339 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
1338 1340 :subject => 'Test', :author_id => 1)
1339 1341 issue.expects(:after_project_change).never
1340 1342 issue.save!
1341 1343 end
1342 1344
1343 1345 def test_should_not_call_after_project_change_on_update
1344 1346 issue = Issue.find(1)
1345 1347 issue.project = Project.find(1)
1346 1348 issue.subject = 'No project change'
1347 1349 issue.expects(:after_project_change).never
1348 1350 issue.save!
1349 1351 end
1350 1352
1351 1353 def test_should_call_after_project_change_on_project_change
1352 1354 issue = Issue.find(1)
1353 1355 issue.project = Project.find(2)
1354 1356 issue.expects(:after_project_change).once
1355 1357 issue.save!
1356 1358 end
1357 1359
1358 1360 def test_adding_journal_should_update_timestamp
1359 1361 issue = Issue.find(1)
1360 1362 updated_on_was = issue.updated_on
1361 1363
1362 1364 issue.init_journal(User.first, "Adding notes")
1363 1365 assert_difference 'Journal.count' do
1364 1366 assert issue.save
1365 1367 end
1366 1368 issue.reload
1367 1369
1368 1370 assert_not_equal updated_on_was, issue.updated_on
1369 1371 end
1370 1372
1371 1373 def test_should_close_duplicates
1372 1374 # Create 3 issues
1373 1375 issue1 = Issue.generate!
1374 1376 issue2 = Issue.generate!
1375 1377 issue3 = Issue.generate!
1376 1378
1377 1379 # 2 is a dupe of 1
1378 1380 IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
1379 1381 :relation_type => IssueRelation::TYPE_DUPLICATES)
1380 1382 # And 3 is a dupe of 2
1381 1383 # IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
1382 1384 # :relation_type => IssueRelation::TYPE_DUPLICATES)
1383 1385 # And 3 is a dupe of 1 (circular duplicates)
1384 1386 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
1385 1387 :relation_type => IssueRelation::TYPE_DUPLICATES)
1386 1388
1387 1389 assert issue1.reload.duplicates.include?(issue2)
1388 1390
1389 1391 # Closing issue 1
1390 1392 issue1.init_journal(User.first, "Closing issue1")
1391 1393 issue1.status = IssueStatus.where(:is_closed => true).first
1392 1394 assert issue1.save
1393 1395 # 2 and 3 should be also closed
1394 1396 assert issue2.reload.closed?
1395 1397 assert issue3.reload.closed?
1396 1398 end
1397 1399
1398 1400 def test_should_close_duplicates_with_private_notes
1399 1401 issue = Issue.generate!
1400 1402 duplicate = Issue.generate!
1401 1403 IssueRelation.create!(:issue_from => duplicate, :issue_to => issue,
1402 1404 :relation_type => IssueRelation::TYPE_DUPLICATES)
1403 1405 assert issue.reload.duplicates.include?(duplicate)
1404 1406
1405 1407 # Closing issue with private notes
1406 1408 issue.init_journal(User.first, "Private notes")
1407 1409 issue.private_notes = true
1408 1410 issue.status = IssueStatus.where(:is_closed => true).first
1409 1411 assert_save issue
1410 1412
1411 1413 duplicate.reload
1412 1414 assert journal = duplicate.journals.detect {|journal| journal.notes == "Private notes"}
1413 1415 assert_equal true, journal.private_notes
1414 1416 end
1415 1417
1416 1418 def test_should_not_close_duplicated_issue
1417 1419 issue1 = Issue.generate!
1418 1420 issue2 = Issue.generate!
1419 1421
1420 1422 # 2 is a dupe of 1
1421 1423 IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
1422 1424 :relation_type => IssueRelation::TYPE_DUPLICATES)
1423 1425 # 2 is a dup of 1 but 1 is not a duplicate of 2
1424 1426 assert !issue2.reload.duplicates.include?(issue1)
1425 1427
1426 1428 # Closing issue 2
1427 1429 issue2.init_journal(User.first, "Closing issue2")
1428 1430 issue2.status = IssueStatus.where(:is_closed => true).first
1429 1431 assert issue2.save
1430 1432 # 1 should not be also closed
1431 1433 assert !issue1.reload.closed?
1432 1434 end
1433 1435
1434 1436 def test_assignable_versions
1435 1437 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1436 1438 :status_id => 1, :fixed_version_id => 1,
1437 1439 :subject => 'New issue')
1438 1440 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
1439 1441 end
1440 1442
1441 1443 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
1442 1444 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1443 1445 :status_id => 1, :fixed_version_id => 1,
1444 1446 :subject => 'New issue')
1445 1447 assert !issue.save
1446 1448 assert_not_equal [], issue.errors[:fixed_version_id]
1447 1449 end
1448 1450
1449 1451 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
1450 1452 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1451 1453 :status_id => 1, :fixed_version_id => 2,
1452 1454 :subject => 'New issue')
1453 1455 assert !issue.save
1454 1456 assert_not_equal [], issue.errors[:fixed_version_id]
1455 1457 end
1456 1458
1457 1459 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
1458 1460 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1459 1461 :status_id => 1, :fixed_version_id => 3,
1460 1462 :subject => 'New issue')
1461 1463 assert issue.save
1462 1464 end
1463 1465
1464 1466 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
1465 1467 issue = Issue.find(11)
1466 1468 assert_equal 'closed', issue.fixed_version.status
1467 1469 issue.subject = 'Subject changed'
1468 1470 assert issue.save
1469 1471 end
1470 1472
1471 1473 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
1472 1474 issue = Issue.find(11)
1473 1475 issue.status_id = 1
1474 1476 assert !issue.save
1475 1477 assert_not_equal [], issue.errors[:base]
1476 1478 end
1477 1479
1478 1480 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
1479 1481 issue = Issue.find(11)
1480 1482 issue.status_id = 1
1481 1483 issue.fixed_version_id = 3
1482 1484 assert issue.save
1483 1485 end
1484 1486
1485 1487 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
1486 1488 issue = Issue.find(12)
1487 1489 assert_equal 'locked', issue.fixed_version.status
1488 1490 issue.status_id = 1
1489 1491 assert issue.save
1490 1492 end
1491 1493
1492 1494 def test_should_not_be_able_to_keep_unshared_version_when_changing_project
1493 1495 issue = Issue.find(2)
1494 1496 assert_equal 2, issue.fixed_version_id
1495 1497 issue.project_id = 3
1496 1498 assert_nil issue.fixed_version_id
1497 1499 issue.fixed_version_id = 2
1498 1500 assert !issue.save
1499 1501 assert_include 'Target version is not included in the list', issue.errors.full_messages
1500 1502 end
1501 1503
1502 1504 def test_should_keep_shared_version_when_changing_project
1503 1505 Version.find(2).update! :sharing => 'tree'
1504 1506
1505 1507 issue = Issue.find(2)
1506 1508 assert_equal 2, issue.fixed_version_id
1507 1509 issue.project_id = 3
1508 1510 assert_equal 2, issue.fixed_version_id
1509 1511 assert issue.save
1510 1512 end
1511 1513
1512 1514 def test_allowed_target_projects_should_include_projects_with_issue_tracking_enabled
1513 1515 assert_include Project.find(2), Issue.allowed_target_projects(User.find(2))
1514 1516 end
1515 1517
1516 1518 def test_allowed_target_projects_should_not_include_projects_with_issue_tracking_disabled
1517 1519 Project.find(2).disable_module! :issue_tracking
1518 1520 assert_not_include Project.find(2), Issue.allowed_target_projects(User.find(2))
1519 1521 end
1520 1522
1521 1523 def test_allowed_target_projects_should_not_include_projects_without_trackers
1522 1524 project = Project.generate!(:tracker_ids => [])
1523 1525 assert project.trackers.empty?
1524 1526 assert_not_include project, Issue.allowed_target_projects(User.find(1))
1525 1527 end
1526 1528
1527 1529 def test_allowed_target_trackers_with_one_role_allowed_on_all_trackers
1528 1530 user = User.generate!
1529 1531 role = Role.generate!
1530 1532 role.add_permission! :add_issues
1531 1533 role.set_permission_trackers :add_issues, :all
1532 1534 role.save!
1533 1535 User.add_to_project(user, Project.find(1), role)
1534 1536
1535 1537 assert_equal [1, 2, 3], Issue.new(:project => Project.find(1)).allowed_target_trackers(user).ids.sort
1536 1538 end
1537 1539
1538 1540 def test_allowed_target_trackers_with_one_role_allowed_on_some_trackers
1539 1541 user = User.generate!
1540 1542 role = Role.generate!
1541 1543 role.add_permission! :add_issues
1542 1544 role.set_permission_trackers :add_issues, [1, 3]
1543 1545 role.save!
1544 1546 User.add_to_project(user, Project.find(1), role)
1545 1547
1546 1548 assert_equal [1, 3], Issue.new(:project => Project.find(1)).allowed_target_trackers(user).ids.sort
1547 1549 end
1548 1550
1549 1551 def test_allowed_target_trackers_with_two_roles_allowed_on_some_trackers
1550 1552 user = User.generate!
1551 1553 role1 = Role.generate!
1552 1554 role1.add_permission! :add_issues
1553 1555 role1.set_permission_trackers :add_issues, [1]
1554 1556 role1.save!
1555 1557 role2 = Role.generate!
1556 1558 role2.add_permission! :add_issues
1557 1559 role2.set_permission_trackers :add_issues, [3]
1558 1560 role2.save!
1559 1561 User.add_to_project(user, Project.find(1), [role1, role2])
1560 1562
1561 1563 assert_equal [1, 3], Issue.new(:project => Project.find(1)).allowed_target_trackers(user).ids.sort
1562 1564 end
1563 1565
1564 1566 def test_allowed_target_trackers_with_two_roles_allowed_on_all_trackers_and_some_trackers
1565 1567 user = User.generate!
1566 1568 role1 = Role.generate!
1567 1569 role1.add_permission! :add_issues
1568 1570 role1.set_permission_trackers :add_issues, :all
1569 1571 role1.save!
1570 1572 role2 = Role.generate!
1571 1573 role2.add_permission! :add_issues
1572 1574 role2.set_permission_trackers :add_issues, [1, 3]
1573 1575 role2.save!
1574 1576 User.add_to_project(user, Project.find(1), [role1, role2])
1575 1577
1576 1578 assert_equal [1, 2, 3], Issue.new(:project => Project.find(1)).allowed_target_trackers(user).ids.sort
1577 1579 end
1578 1580
1579 1581 def test_allowed_target_trackers_should_not_consider_roles_without_add_issues_permission
1580 1582 user = User.generate!
1581 1583 role1 = Role.generate!
1582 1584 role1.remove_permission! :add_issues
1583 1585 role1.set_permission_trackers :add_issues, :all
1584 1586 role1.save!
1585 1587 role2 = Role.generate!
1586 1588 role2.add_permission! :add_issues
1587 1589 role2.set_permission_trackers :add_issues, [1, 3]
1588 1590 role2.save!
1589 1591 User.add_to_project(user, Project.find(1), [role1, role2])
1590 1592
1591 1593 assert_equal [1, 3], Issue.new(:project => Project.find(1)).allowed_target_trackers(user).ids.sort
1592 1594 end
1593 1595
1594 1596 def test_allowed_target_trackers_without_project_should_be_empty
1595 1597 issue = Issue.new
1596 1598 assert_nil issue.project
1597 1599 assert_equal [], issue.allowed_target_trackers(User.find(2)).ids
1598 1600 end
1599 1601
1600 1602 def test_allowed_target_trackers_should_include_current_tracker
1601 1603 user = User.generate!
1602 1604 role = Role.generate!
1603 1605 role.add_permission! :add_issues
1604 1606 role.set_permission_trackers :add_issues, [3]
1605 1607 role.save!
1606 1608 User.add_to_project(user, Project.find(1), role)
1607 1609
1608 1610 issue = Issue.generate!(:project => Project.find(1), :tracker => Tracker.find(1))
1609 1611 assert_equal [1, 3], issue.allowed_target_trackers(user).ids.sort
1610 1612 end
1611 1613
1612 1614 def test_move_to_another_project_with_same_category
1613 1615 issue = Issue.find(1)
1614 1616 issue.project = Project.find(2)
1615 1617 assert issue.save
1616 1618 issue.reload
1617 1619 assert_equal 2, issue.project_id
1618 1620 # Category changes
1619 1621 assert_equal 4, issue.category_id
1620 1622 # Make sure time entries were move to the target project
1621 1623 assert_equal 2, issue.time_entries.first.project_id
1622 1624 end
1623 1625
1624 1626 def test_move_to_another_project_without_same_category
1625 1627 issue = Issue.find(2)
1626 1628 issue.project = Project.find(2)
1627 1629 assert issue.save
1628 1630 issue.reload
1629 1631 assert_equal 2, issue.project_id
1630 1632 # Category cleared
1631 1633 assert_nil issue.category_id
1632 1634 end
1633 1635
1634 1636 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
1635 1637 issue = Issue.find(1)
1636 1638 issue.update!(:fixed_version_id => 3)
1637 1639 issue.project = Project.find(2)
1638 1640 assert issue.save
1639 1641 issue.reload
1640 1642 assert_equal 2, issue.project_id
1641 1643 # Cleared fixed_version
1642 1644 assert_equal nil, issue.fixed_version
1643 1645 end
1644 1646
1645 1647 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
1646 1648 issue = Issue.find(1)
1647 1649 issue.update!(:fixed_version_id => 4)
1648 1650 issue.project = Project.find(5)
1649 1651 assert issue.save
1650 1652 issue.reload
1651 1653 assert_equal 5, issue.project_id
1652 1654 # Keep fixed_version
1653 1655 assert_equal 4, issue.fixed_version_id
1654 1656 end
1655 1657
1656 1658 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
1657 1659 issue = Issue.find(1)
1658 1660 issue.update!(:fixed_version_id => 3)
1659 1661 issue.project = Project.find(5)
1660 1662 assert issue.save
1661 1663 issue.reload
1662 1664 assert_equal 5, issue.project_id
1663 1665 # Cleared fixed_version
1664 1666 assert_equal nil, issue.fixed_version
1665 1667 end
1666 1668
1667 1669 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
1668 1670 issue = Issue.find(1)
1669 1671 issue.update!(:fixed_version_id => 7)
1670 1672 issue.project = Project.find(2)
1671 1673 assert issue.save
1672 1674 issue.reload
1673 1675 assert_equal 2, issue.project_id
1674 1676 # Keep fixed_version
1675 1677 assert_equal 7, issue.fixed_version_id
1676 1678 end
1677 1679
1678 1680 def test_move_to_another_project_should_keep_parent_if_valid
1679 1681 issue = Issue.find(1)
1680 1682 issue.update! :parent_issue_id => 2
1681 1683 issue.project = Project.find(3)
1682 1684 assert issue.save
1683 1685 issue.reload
1684 1686 assert_equal 2, issue.parent_id
1685 1687 end
1686 1688
1687 1689 def test_move_to_another_project_should_clear_parent_if_not_valid
1688 1690 issue = Issue.find(1)
1689 1691 issue.update! :parent_issue_id => 2
1690 1692 issue.project = Project.find(2)
1691 1693 assert issue.save
1692 1694 issue.reload
1693 1695 assert_nil issue.parent_id
1694 1696 end
1695 1697
1696 1698 def test_move_to_another_project_with_disabled_tracker
1697 1699 issue = Issue.find(1)
1698 1700 target = Project.find(2)
1699 1701 target.tracker_ids = [3]
1700 1702 target.save
1701 1703 issue.project = target
1702 1704 assert issue.save
1703 1705 issue.reload
1704 1706 assert_equal 2, issue.project_id
1705 1707 assert_equal 3, issue.tracker_id
1706 1708 end
1707 1709
1708 1710 def test_copy_to_the_same_project
1709 1711 issue = Issue.find(1)
1710 1712 copy = issue.copy
1711 1713 assert_difference 'Issue.count' do
1712 1714 copy.save!
1713 1715 end
1714 1716 assert_kind_of Issue, copy
1715 1717 assert_equal issue.project, copy.project
1716 1718 assert_equal "125", copy.custom_value_for(2).value
1717 1719 end
1718 1720
1719 1721 def test_copy_to_another_project_and_tracker
1720 1722 issue = Issue.find(1)
1721 1723 copy = issue.copy(:project_id => 3, :tracker_id => 2)
1722 1724 assert_difference 'Issue.count' do
1723 1725 copy.save!
1724 1726 end
1725 1727 copy.reload
1726 1728 assert_kind_of Issue, copy
1727 1729 assert_equal Project.find(3), copy.project
1728 1730 assert_equal Tracker.find(2), copy.tracker
1729 1731 # Custom field #2 is not associated with target tracker
1730 1732 assert_nil copy.custom_value_for(2)
1731 1733 end
1732 1734
1733 1735 test "#copy should not create a journal" do
1734 1736 copy = Issue.find(1).copy({:project_id => 3, :tracker_id => 2, :assigned_to_id => 3}, :link => false)
1735 1737 copy.save!
1736 1738 assert_equal 0, copy.reload.journals.size
1737 1739 end
1738 1740
1739 1741 test "#copy should allow assigned_to changes" do
1740 1742 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1741 1743 assert_equal 3, copy.assigned_to_id
1742 1744 end
1743 1745
1744 1746 test "#copy should allow status changes" do
1745 1747 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
1746 1748 assert_equal 2, copy.status_id
1747 1749 end
1748 1750
1749 1751 test "#copy should allow start date changes" do
1750 1752 date = Date.today
1751 1753 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1752 1754 assert_equal date, copy.start_date
1753 1755 end
1754 1756
1755 1757 test "#copy should allow due date changes" do
1756 1758 date = Date.today
1757 1759 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :due_date => date)
1758 1760 assert_equal date, copy.due_date
1759 1761 end
1760 1762
1761 1763 test "#copy should set current user as author" do
1762 1764 User.current = User.find(9)
1763 1765 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2)
1764 1766 assert_equal User.current, copy.author
1765 1767 end
1766 1768
1767 1769 test "#copy should create a journal with notes" do
1768 1770 date = Date.today
1769 1771 notes = "Notes added when copying"
1770 1772 copy = Issue.find(1).copy({:project_id => 3, :tracker_id => 2, :start_date => date}, :link => false)
1771 1773 copy.init_journal(User.current, notes)
1772 1774 copy.save!
1773 1775
1774 1776 assert_equal 1, copy.journals.size
1775 1777 journal = copy.journals.first
1776 1778 assert_equal 0, journal.details.size
1777 1779 assert_equal notes, journal.notes
1778 1780 end
1779 1781
1780 1782 def test_valid_parent_project
1781 1783 issue = Issue.find(1)
1782 1784 issue_in_same_project = Issue.find(2)
1783 1785 issue_in_child_project = Issue.find(5)
1784 1786 issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
1785 1787 issue_in_other_child_project = Issue.find(6)
1786 1788 issue_in_different_tree = Issue.find(4)
1787 1789
1788 1790 with_settings :cross_project_subtasks => '' do
1789 1791 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1790 1792 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1791 1793 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1792 1794 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1793 1795 end
1794 1796
1795 1797 with_settings :cross_project_subtasks => 'system' do
1796 1798 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1797 1799 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1798 1800 assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
1799 1801 end
1800 1802
1801 1803 with_settings :cross_project_subtasks => 'tree' do
1802 1804 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1803 1805 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1804 1806 assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
1805 1807 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1806 1808
1807 1809 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
1808 1810 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1809 1811 end
1810 1812
1811 1813 with_settings :cross_project_subtasks => 'descendants' do
1812 1814 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1813 1815 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1814 1816 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1815 1817 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1816 1818
1817 1819 assert_equal true, issue_in_child_project.valid_parent_project?(issue)
1818 1820 assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1819 1821 end
1820 1822 end
1821 1823
1822 1824 def test_recipients_should_include_previous_assignee
1823 1825 user = User.find(3)
1824 1826 user.members.update_all ["mail_notification = ?", false]
1825 1827 user.update! :mail_notification => 'only_assigned'
1826 1828
1827 1829 issue = Issue.find(2)
1828 1830 issue.assigned_to = nil
1829 1831 assert_include user.mail, issue.recipients
1830 1832 issue.save!
1831 1833 assert !issue.recipients.include?(user.mail)
1832 1834 end
1833 1835
1834 1836 def test_recipients_should_not_include_users_that_cannot_view_the_issue
1835 1837 issue = Issue.find(12)
1836 1838 assert issue.recipients.include?(issue.author.mail)
1837 1839 # copy the issue to a private project
1838 1840 copy = issue.copy(:project_id => 5, :tracker_id => 2)
1839 1841 # author is not a member of project anymore
1840 1842 assert !copy.recipients.include?(copy.author.mail)
1841 1843 end
1842 1844
1843 1845 def test_recipients_should_include_the_assigned_group_members
1844 1846 group_member = User.generate!
1845 1847 group = Group.generate!
1846 1848 group.users << group_member
1847 1849
1848 1850 issue = Issue.find(12)
1849 1851 issue.assigned_to = group
1850 1852 assert issue.recipients.include?(group_member.mail)
1851 1853 end
1852 1854
1853 1855 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
1854 1856 user = User.find(3)
1855 1857 issue = Issue.find(9)
1856 1858 Watcher.create!(:user => user, :watchable => issue)
1857 1859 assert issue.watched_by?(user)
1858 1860 assert !issue.watcher_recipients.include?(user.mail)
1859 1861 end
1860 1862
1861 1863 def test_issue_destroy
1862 1864 Issue.find(1).destroy
1863 1865 assert_nil Issue.find_by_id(1)
1864 1866 assert_nil TimeEntry.find_by_issue_id(1)
1865 1867 end
1866 1868
1867 1869 def test_destroy_should_delete_time_entries_custom_values
1868 1870 issue = Issue.generate!
1869 1871 time_entry = TimeEntry.generate!(:issue => issue, :custom_field_values => {10 => '1'})
1870 1872
1871 1873 assert_difference 'CustomValue.where(:customized_type => "TimeEntry").count', -1 do
1872 1874 assert issue.destroy
1873 1875 end
1874 1876 end
1875 1877
1876 1878 def test_destroying_a_deleted_issue_should_not_raise_an_error
1877 1879 issue = Issue.find(1)
1878 1880 Issue.find(1).destroy
1879 1881
1880 1882 assert_nothing_raised do
1881 1883 assert_no_difference 'Issue.count' do
1882 1884 issue.destroy
1883 1885 end
1884 1886 assert issue.destroyed?
1885 1887 end
1886 1888 end
1887 1889
1888 1890 def test_destroying_a_stale_issue_should_not_raise_an_error
1889 1891 issue = Issue.find(1)
1890 1892 Issue.find(1).update! :subject => "Updated"
1891 1893
1892 1894 assert_nothing_raised do
1893 1895 assert_difference 'Issue.count', -1 do
1894 1896 issue.destroy
1895 1897 end
1896 1898 assert issue.destroyed?
1897 1899 end
1898 1900 end
1899 1901
1900 1902 def test_blocked
1901 1903 blocked_issue = Issue.find(9)
1902 1904 blocking_issue = Issue.find(10)
1903 1905
1904 1906 assert blocked_issue.blocked?
1905 1907 assert !blocking_issue.blocked?
1906 1908 end
1907 1909
1908 1910 def test_blocked_issues_dont_allow_closed_statuses
1909 1911 blocked_issue = Issue.find(9)
1910 1912
1911 1913 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
1912 1914 assert !allowed_statuses.empty?
1913 1915 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1914 1916 assert closed_statuses.empty?
1915 1917 end
1916 1918
1917 1919 def test_unblocked_issues_allow_closed_statuses
1918 1920 blocking_issue = Issue.find(10)
1919 1921
1920 1922 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
1921 1923 assert !allowed_statuses.empty?
1922 1924 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1923 1925 assert !closed_statuses.empty?
1924 1926 end
1925 1927
1926 1928 def test_reschedule_an_issue_without_dates
1927 1929 with_settings :non_working_week_days => [] do
1928 1930 issue = Issue.new(:start_date => nil, :due_date => nil)
1929 1931 issue.reschedule_on '2012-10-09'.to_date
1930 1932 assert_equal '2012-10-09'.to_date, issue.start_date
1931 1933 assert_equal '2012-10-09'.to_date, issue.due_date
1932 1934 end
1933 1935
1934 1936 with_settings :non_working_week_days => %w(6 7) do
1935 1937 issue = Issue.new(:start_date => nil, :due_date => nil)
1936 1938 issue.reschedule_on '2012-10-09'.to_date
1937 1939 assert_equal '2012-10-09'.to_date, issue.start_date
1938 1940 assert_equal '2012-10-09'.to_date, issue.due_date
1939 1941
1940 1942 issue = Issue.new(:start_date => nil, :due_date => nil)
1941 1943 issue.reschedule_on '2012-10-13'.to_date
1942 1944 assert_equal '2012-10-15'.to_date, issue.start_date
1943 1945 assert_equal '2012-10-15'.to_date, issue.due_date
1944 1946 end
1945 1947 end
1946 1948
1947 1949 def test_reschedule_an_issue_with_start_date
1948 1950 with_settings :non_working_week_days => [] do
1949 1951 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
1950 1952 issue.reschedule_on '2012-10-13'.to_date
1951 1953 assert_equal '2012-10-13'.to_date, issue.start_date
1952 1954 assert_equal '2012-10-13'.to_date, issue.due_date
1953 1955 end
1954 1956
1955 1957 with_settings :non_working_week_days => %w(6 7) do
1956 1958 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
1957 1959 issue.reschedule_on '2012-10-11'.to_date
1958 1960 assert_equal '2012-10-11'.to_date, issue.start_date
1959 1961 assert_equal '2012-10-11'.to_date, issue.due_date
1960 1962
1961 1963 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
1962 1964 issue.reschedule_on '2012-10-13'.to_date
1963 1965 assert_equal '2012-10-15'.to_date, issue.start_date
1964 1966 assert_equal '2012-10-15'.to_date, issue.due_date
1965 1967 end
1966 1968 end
1967 1969
1968 1970 def test_reschedule_an_issue_with_start_and_due_dates
1969 1971 with_settings :non_working_week_days => [] do
1970 1972 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-15')
1971 1973 issue.reschedule_on '2012-10-13'.to_date
1972 1974 assert_equal '2012-10-13'.to_date, issue.start_date
1973 1975 assert_equal '2012-10-19'.to_date, issue.due_date
1974 1976 end
1975 1977
1976 1978 with_settings :non_working_week_days => %w(6 7) do
1977 1979 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19') # 8 working days
1978 1980 issue.reschedule_on '2012-10-11'.to_date
1979 1981 assert_equal '2012-10-11'.to_date, issue.start_date
1980 1982 assert_equal '2012-10-23'.to_date, issue.due_date
1981 1983
1982 1984 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19')
1983 1985 issue.reschedule_on '2012-10-13'.to_date
1984 1986 assert_equal '2012-10-15'.to_date, issue.start_date
1985 1987 assert_equal '2012-10-25'.to_date, issue.due_date
1986 1988 end
1987 1989 end
1988 1990
1989 1991 def test_rescheduling_an_issue_to_a_later_due_date_should_reschedule_following_issue
1990 1992 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1991 1993 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1992 1994 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1993 1995 :relation_type => IssueRelation::TYPE_PRECEDES)
1994 1996 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
1995 1997
1996 1998 issue1.reload
1997 1999 issue1.due_date = '2012-10-23'
1998 2000 issue1.save!
1999 2001 issue2.reload
2000 2002 assert_equal Date.parse('2012-10-24'), issue2.start_date
2001 2003 assert_equal Date.parse('2012-10-26'), issue2.due_date
2002 2004 end
2003 2005
2004 2006 def test_rescheduling_an_issue_to_an_earlier_due_date_should_reschedule_following_issue
2005 2007 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
2006 2008 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
2007 2009 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
2008 2010 :relation_type => IssueRelation::TYPE_PRECEDES)
2009 2011 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
2010 2012
2011 2013 issue1.reload
2012 2014 issue1.start_date = '2012-09-17'
2013 2015 issue1.due_date = '2012-09-18'
2014 2016 issue1.save!
2015 2017 issue2.reload
2016 2018 assert_equal Date.parse('2012-09-19'), issue2.start_date
2017 2019 assert_equal Date.parse('2012-09-21'), issue2.due_date
2018 2020 end
2019 2021
2020 2022 def test_rescheduling_reschedule_following_issue_earlier_should_consider_other_preceding_issues
2021 2023 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
2022 2024 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
2023 2025 issue3 = Issue.generate!(:start_date => '2012-10-01', :due_date => '2012-10-02')
2024 2026 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
2025 2027 :relation_type => IssueRelation::TYPE_PRECEDES)
2026 2028 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
2027 2029 :relation_type => IssueRelation::TYPE_PRECEDES)
2028 2030 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
2029 2031
2030 2032 issue1.reload
2031 2033 issue1.start_date = '2012-09-17'
2032 2034 issue1.due_date = '2012-09-18'
2033 2035 issue1.save!
2034 2036 issue2.reload
2035 2037 # Issue 2 must start after Issue 3
2036 2038 assert_equal Date.parse('2012-10-03'), issue2.start_date
2037 2039 assert_equal Date.parse('2012-10-05'), issue2.due_date
2038 2040 end
2039 2041
2040 2042 def test_rescheduling_a_stale_issue_should_not_raise_an_error
2041 2043 with_settings :non_working_week_days => [] do
2042 2044 stale = Issue.find(1)
2043 2045 issue = Issue.find(1)
2044 2046 issue.subject = "Updated"
2045 2047 issue.save!
2046 2048 date = 10.days.from_now.to_date
2047 2049 assert_nothing_raised do
2048 2050 stale.reschedule_on!(date)
2049 2051 end
2050 2052 assert_equal date, stale.reload.start_date
2051 2053 end
2052 2054 end
2053 2055
2054 2056 def test_child_issue_should_consider_parent_soonest_start_on_create
2055 2057 set_language_if_valid 'en'
2056 2058 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
2057 2059 issue2 = Issue.generate!(:start_date => '2012-10-18', :due_date => '2012-10-20')
2058 2060 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
2059 2061 :relation_type => IssueRelation::TYPE_PRECEDES)
2060 2062 issue1.reload
2061 2063 issue2.reload
2062 2064 assert_equal Date.parse('2012-10-18'), issue2.start_date
2063 2065
2064 2066 with_settings :date_format => '%m/%d/%Y' do
2065 2067 child = Issue.new(:parent_issue_id => issue2.id, :start_date => '2012-10-16',
2066 2068 :project_id => 1, :tracker_id => 1, :status_id => 1, :subject => 'Child', :author_id => 1)
2067 2069 assert !child.valid?
2068 2070 assert_include 'Start date cannot be earlier than 10/18/2012 because of preceding issues', child.errors.full_messages
2069 2071 assert_equal Date.parse('2012-10-18'), child.soonest_start
2070 2072 child.start_date = '2012-10-18'
2071 2073 assert child.save
2072 2074 end
2073 2075 end
2074 2076
2075 2077 def test_setting_parent_to_a_an_issue_that_precedes_should_not_validate
2076 2078 # tests that 3 cannot have 1 as parent:
2077 2079 #
2078 2080 # 1 -> 2 -> 3
2079 2081 #
2080 2082 set_language_if_valid 'en'
2081 2083 issue1 = Issue.generate!
2082 2084 issue2 = Issue.generate!
2083 2085 issue3 = Issue.generate!
2084 2086 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
2085 2087 IssueRelation.create!(:issue_from => issue2, :issue_to => issue3, :relation_type => IssueRelation::TYPE_PRECEDES)
2086 2088 issue3.reload
2087 2089 issue3.parent_issue_id = issue1.id
2088 2090 assert !issue3.valid?
2089 2091 assert_include 'Parent task is invalid', issue3.errors.full_messages
2090 2092 end
2091 2093
2092 2094 def test_setting_parent_to_a_an_issue_that_follows_should_not_validate
2093 2095 # tests that 1 cannot have 3 as parent:
2094 2096 #
2095 2097 # 1 -> 2 -> 3
2096 2098 #
2097 2099 set_language_if_valid 'en'
2098 2100 issue1 = Issue.generate!
2099 2101 issue2 = Issue.generate!
2100 2102 issue3 = Issue.generate!
2101 2103 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
2102 2104 IssueRelation.create!(:issue_from => issue2, :issue_to => issue3, :relation_type => IssueRelation::TYPE_PRECEDES)
2103 2105 issue1.reload
2104 2106 issue1.parent_issue_id = issue3.id
2105 2107 assert !issue1.valid?
2106 2108 assert_include 'Parent task is invalid', issue1.errors.full_messages
2107 2109 end
2108 2110
2109 2111 def test_setting_parent_to_a_an_issue_that_precedes_through_hierarchy_should_not_validate
2110 2112 # tests that 4 cannot have 1 as parent:
2111 2113 # changing the due date of 4 would update the end date of 1 which would reschedule 2
2112 2114 # which would change the end date of 3 which would reschedule 4 and so on...
2113 2115 #
2114 2116 # 3 -> 4
2115 2117 # ^
2116 2118 # 1 -> 2
2117 2119 #
2118 2120 set_language_if_valid 'en'
2119 2121 issue1 = Issue.generate!
2120 2122 issue2 = Issue.generate!
2121 2123 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
2122 2124 issue3 = Issue.generate!
2123 2125 issue2.reload
2124 2126 issue2.parent_issue_id = issue3.id
2125 2127 issue2.save!
2126 2128 issue4 = Issue.generate!
2127 2129 IssueRelation.create!(:issue_from => issue3, :issue_to => issue4, :relation_type => IssueRelation::TYPE_PRECEDES)
2128 2130 issue4.reload
2129 2131 issue4.parent_issue_id = issue1.id
2130 2132 assert !issue4.valid?
2131 2133 assert_include 'Parent task is invalid', issue4.errors.full_messages
2132 2134 end
2133 2135
2134 2136 def test_issue_and_following_issue_should_be_able_to_be_moved_to_the_same_parent
2135 2137 set_language_if_valid 'en'
2136 2138 issue1 = Issue.generate!
2137 2139 issue2 = Issue.generate!
2138 2140 relation = IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_FOLLOWS)
2139 2141 parent = Issue.generate!
2140 2142 issue1.reload.parent_issue_id = parent.id
2141 2143 assert_save issue1
2142 2144 parent.reload
2143 2145 issue2.reload.parent_issue_id = parent.id
2144 2146 assert_save issue2
2145 2147 assert IssueRelation.exists?(relation.id)
2146 2148 end
2147 2149
2148 2150 def test_issue_and_preceding_issue_should_be_able_to_be_moved_to_the_same_parent
2149 2151 set_language_if_valid 'en'
2150 2152 issue1 = Issue.generate!
2151 2153 issue2 = Issue.generate!
2152 2154 relation = IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_PRECEDES)
2153 2155 parent = Issue.generate!
2154 2156 issue1.reload.parent_issue_id = parent.id
2155 2157 assert_save issue1
2156 2158 parent.reload
2157 2159 issue2.reload.parent_issue_id = parent.id
2158 2160 assert_save issue2
2159 2161 assert IssueRelation.exists?(relation.id)
2160 2162 end
2161 2163
2162 2164 def test_issue_and_blocked_issue_should_be_able_to_be_moved_to_the_same_parent
2163 2165 set_language_if_valid 'en'
2164 2166 issue1 = Issue.generate!
2165 2167 issue2 = Issue.generate!
2166 2168 relation = IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_BLOCKED)
2167 2169 parent = Issue.generate!
2168 2170 issue1.reload.parent_issue_id = parent.id
2169 2171 assert_save issue1
2170 2172 parent.reload
2171 2173 issue2.reload.parent_issue_id = parent.id
2172 2174 assert_save issue2
2173 2175 assert IssueRelation.exists?(relation.id)
2174 2176 end
2175 2177
2176 2178 def test_issue_and_blocking_issue_should_be_able_to_be_moved_to_the_same_parent
2177 2179 set_language_if_valid 'en'
2178 2180 issue1 = Issue.generate!
2179 2181 issue2 = Issue.generate!
2180 2182 relation = IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_BLOCKS)
2181 2183 parent = Issue.generate!
2182 2184 issue1.reload.parent_issue_id = parent.id
2183 2185 assert_save issue1
2184 2186 parent.reload
2185 2187 issue2.reload.parent_issue_id = parent.id
2186 2188 assert_save issue2
2187 2189 assert IssueRelation.exists?(relation.id)
2188 2190 end
2189 2191
2190 2192 def test_issue_copy_should_be_able_to_be_moved_to_the_same_parent_as_copied_issue
2191 2193 issue = Issue.generate!
2192 2194 parent = Issue.generate!
2193 2195 issue.parent_issue_id = parent.id
2194 2196 issue.save!
2195 2197 issue.reload
2196 2198
2197 2199 copy = Issue.new.copy_from(issue, :link => true)
2198 2200 relation = new_record(IssueRelation) do
2199 2201 copy.save!
2200 2202 end
2201 2203
2202 2204 copy.parent_issue_id = parent.id
2203 2205 assert_save copy
2204 2206 assert IssueRelation.exists?(relation.id)
2205 2207 end
2206 2208
2207 2209 def test_overdue
2208 2210 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
2209 2211 assert !Issue.new(:due_date => Date.today).overdue?
2210 2212 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
2211 2213 assert !Issue.new(:due_date => nil).overdue?
2212 2214 assert !Issue.new(:due_date => 1.day.ago.to_date,
2213 2215 :status => IssueStatus.where(:is_closed => true).first
2214 2216 ).overdue?
2215 2217 end
2216 2218
2217 2219 test "#behind_schedule? should be false if the issue has no start_date" do
2218 2220 assert !Issue.new(:start_date => nil,
2219 2221 :due_date => 1.day.from_now.to_date,
2220 2222 :done_ratio => 0).behind_schedule?
2221 2223 end
2222 2224
2223 2225 test "#behind_schedule? should be false if the issue has no end_date" do
2224 2226 assert !Issue.new(:start_date => 1.day.from_now.to_date,
2225 2227 :due_date => nil,
2226 2228 :done_ratio => 0).behind_schedule?
2227 2229 end
2228 2230
2229 2231 test "#behind_schedule? should be false if the issue has more done than it's calendar time" do
2230 2232 assert !Issue.new(:start_date => 50.days.ago.to_date,
2231 2233 :due_date => 50.days.from_now.to_date,
2232 2234 :done_ratio => 90).behind_schedule?
2233 2235 end
2234 2236
2235 2237 test "#behind_schedule? should be true if the issue hasn't been started at all" do
2236 2238 assert Issue.new(:start_date => 1.day.ago.to_date,
2237 2239 :due_date => 1.day.from_now.to_date,
2238 2240 :done_ratio => 0).behind_schedule?
2239 2241 end
2240 2242
2241 2243 test "#behind_schedule? should be true if the issue has used more calendar time than it's done ratio" do
2242 2244 assert Issue.new(:start_date => 100.days.ago.to_date,
2243 2245 :due_date => Date.today,
2244 2246 :done_ratio => 90).behind_schedule?
2245 2247 end
2246 2248
2247 2249 test "#assignable_users should be Users" do
2248 2250 assert_kind_of User, Issue.find(1).assignable_users.first
2249 2251 end
2250 2252
2251 2253 test "#assignable_users should include the issue author" do
2252 2254 non_project_member = User.generate!
2253 2255 issue = Issue.generate!(:author => non_project_member)
2254 2256
2255 2257 assert issue.assignable_users.include?(non_project_member)
2256 2258 end
2257 2259
2258 2260 def test_assignable_users_should_not_include_anonymous_user
2259 2261 issue = Issue.generate!(:author => User.anonymous)
2260 2262
2261 2263 assert !issue.assignable_users.include?(User.anonymous)
2262 2264 end
2263 2265
2264 2266 def test_assignable_users_should_not_include_locked_user
2265 2267 user = User.generate!
2266 2268 issue = Issue.generate!(:author => user)
2267 2269 user.lock!
2268 2270
2269 2271 assert !issue.assignable_users.include?(user)
2270 2272 end
2271 2273
2272 2274 test "#assignable_users should include the current assignee" do
2273 2275 user = User.generate!
2274 2276 issue = Issue.generate!(:assigned_to => user)
2275 2277 user.lock!
2276 2278
2277 2279 assert Issue.find(issue.id).assignable_users.include?(user)
2278 2280 end
2279 2281
2280 2282 test "#assignable_users should not show the issue author twice" do
2281 2283 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
2282 2284 assert_equal 2, assignable_user_ids.length
2283 2285
2284 2286 assignable_user_ids.each do |user_id|
2285 2287 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
2286 2288 "User #{user_id} appears more or less than once"
2287 2289 end
2288 2290 end
2289 2291
2290 2292 test "#assignable_users with issue_group_assignment should include groups" do
2291 2293 issue = Issue.new(:project => Project.find(2))
2292 2294
2293 2295 with_settings :issue_group_assignment => '1' do
2294 2296 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
2295 2297 assert issue.assignable_users.include?(Group.find(11))
2296 2298 end
2297 2299 end
2298 2300
2299 2301 test "#assignable_users without issue_group_assignment should not include groups" do
2300 2302 issue = Issue.new(:project => Project.find(2))
2301 2303
2302 2304 with_settings :issue_group_assignment => '0' do
2303 2305 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
2304 2306 assert !issue.assignable_users.include?(Group.find(11))
2305 2307 end
2306 2308 end
2307 2309
2308 2310 def test_assignable_users_should_not_include_builtin_groups
2309 2311 Member.create!(:project_id => 1, :principal => Group.non_member, :role_ids => [1])
2310 2312 Member.create!(:project_id => 1, :principal => Group.anonymous, :role_ids => [1])
2311 2313 issue = Issue.new(:project => Project.find(1))
2312 2314
2313 2315 with_settings :issue_group_assignment => '1' do
2314 2316 assert_nil issue.assignable_users.detect {|u| u.is_a?(GroupBuiltin)}
2315 2317 end
2316 2318 end
2317 2319
2318 2320 def test_assignable_users_should_not_include_users_that_cannot_view_the_tracker
2319 2321 user = User.find(3)
2320 2322 role = Role.find(2)
2321 2323 role.set_permission_trackers :view_issues, [1, 3]
2322 2324 role.save!
2323 2325
2324 2326 issue1 = Issue.new(:project_id => 1, :tracker_id => 1)
2325 2327 issue2 = Issue.new(:project_id => 1, :tracker_id => 2)
2326 2328
2327 2329 assert_include user, issue1.assignable_users
2328 2330 assert_not_include user, issue2.assignable_users
2329 2331 end
2330 2332
2331 2333 def test_create_should_send_email_notification
2332 2334 ActionMailer::Base.deliveries.clear
2333 2335 issue = Issue.new(:project_id => 1, :tracker_id => 1,
2334 2336 :author_id => 3, :status_id => 1,
2335 2337 :priority => IssuePriority.all.first,
2336 2338 :subject => 'test_create', :estimated_hours => '1:30')
2337 2339 with_settings :notified_events => %w(issue_added) do
2338 2340 assert issue.save
2339 2341 assert_equal 1, ActionMailer::Base.deliveries.size
2340 2342 end
2341 2343 end
2342 2344
2343 2345 def test_create_should_send_one_email_notification_with_both_settings
2344 2346 ActionMailer::Base.deliveries.clear
2345 2347 issue = Issue.new(:project_id => 1, :tracker_id => 1,
2346 2348 :author_id => 3, :status_id => 1,
2347 2349 :priority => IssuePriority.all.first,
2348 2350 :subject => 'test_create', :estimated_hours => '1:30')
2349 2351 with_settings :notified_events => %w(issue_added issue_updated) do
2350 2352 assert issue.save
2351 2353 assert_equal 1, ActionMailer::Base.deliveries.size
2352 2354 end
2353 2355 end
2354 2356
2355 2357 def test_create_should_not_send_email_notification_with_no_setting
2356 2358 ActionMailer::Base.deliveries.clear
2357 2359 issue = Issue.new(:project_id => 1, :tracker_id => 1,
2358 2360 :author_id => 3, :status_id => 1,
2359 2361 :priority => IssuePriority.all.first,
2360 2362 :subject => 'test_create', :estimated_hours => '1:30')
2361 2363 with_settings :notified_events => [] do
2362 2364 assert issue.save
2363 2365 assert_equal 0, ActionMailer::Base.deliveries.size
2364 2366 end
2365 2367 end
2366 2368
2367 2369 def test_update_should_notify_previous_assignee
2368 2370 ActionMailer::Base.deliveries.clear
2369 2371 user = User.find(3)
2370 2372 user.members.update_all ["mail_notification = ?", false]
2371 2373 user.update! :mail_notification => 'only_assigned'
2372 2374
2373 2375 with_settings :notified_events => %w(issue_updated) do
2374 2376 issue = Issue.find(2)
2375 2377 issue.init_journal User.find(1)
2376 2378 issue.assigned_to = nil
2377 2379 issue.save!
2378 2380 assert_include user.mail, ActionMailer::Base.deliveries.last.bcc
2379 2381 end
2380 2382 end
2381 2383
2382 2384 def test_stale_issue_should_not_send_email_notification
2383 2385 ActionMailer::Base.deliveries.clear
2384 2386 issue = Issue.find(1)
2385 2387 stale = Issue.find(1)
2386 2388
2387 2389 issue.init_journal(User.find(1))
2388 2390 issue.subject = 'Subjet update'
2389 2391 with_settings :notified_events => %w(issue_updated) do
2390 2392 assert issue.save
2391 2393 assert_equal 1, ActionMailer::Base.deliveries.size
2392 2394 ActionMailer::Base.deliveries.clear
2393 2395
2394 2396 stale.init_journal(User.find(1))
2395 2397 stale.subject = 'Another subjet update'
2396 2398 assert_raise ActiveRecord::StaleObjectError do
2397 2399 stale.save
2398 2400 end
2399 2401 assert ActionMailer::Base.deliveries.empty?
2400 2402 end
2401 2403 end
2402 2404
2403 2405 def test_journalized_description
2404 2406 IssueCustomField.delete_all
2405 2407
2406 2408 i = Issue.first
2407 2409 old_description = i.description
2408 2410 new_description = "This is the new description"
2409 2411
2410 2412 i.init_journal(User.find(2))
2411 2413 i.description = new_description
2412 2414 assert_difference 'Journal.count', 1 do
2413 2415 assert_difference 'JournalDetail.count', 1 do
2414 2416 i.save!
2415 2417 end
2416 2418 end
2417 2419
2418 2420 detail = JournalDetail.order('id DESC').first
2419 2421 assert_equal i, detail.journal.journalized
2420 2422 assert_equal 'attr', detail.property
2421 2423 assert_equal 'description', detail.prop_key
2422 2424 assert_equal old_description, detail.old_value
2423 2425 assert_equal new_description, detail.value
2424 2426 end
2425 2427
2426 2428 def test_blank_descriptions_should_not_be_journalized
2427 2429 IssueCustomField.delete_all
2428 2430 Issue.where(:id => 1).update_all("description = NULL")
2429 2431
2430 2432 i = Issue.find(1)
2431 2433 i.init_journal(User.find(2))
2432 2434 i.subject = "blank description"
2433 2435 i.description = "\r\n"
2434 2436
2435 2437 assert_difference 'Journal.count', 1 do
2436 2438 assert_difference 'JournalDetail.count', 1 do
2437 2439 i.save!
2438 2440 end
2439 2441 end
2440 2442 end
2441 2443
2442 2444 def test_journalized_multi_custom_field
2443 2445 field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
2444 2446 :is_filter => true, :is_for_all => true,
2445 2447 :tracker_ids => [1],
2446 2448 :possible_values => ['value1', 'value2', 'value3'],
2447 2449 :multiple => true)
2448 2450
2449 2451 issue = Issue.create!(:project_id => 1, :tracker_id => 1,
2450 2452 :subject => 'Test', :author_id => 1)
2451 2453
2452 2454 assert_difference 'Journal.count' do
2453 2455 assert_difference 'JournalDetail.count' do
2454 2456 issue.init_journal(User.first)
2455 2457 issue.custom_field_values = {field.id => ['value1']}
2456 2458 issue.save!
2457 2459 end
2458 2460 assert_difference 'JournalDetail.count' do
2459 2461 issue.init_journal(User.first)
2460 2462 issue.custom_field_values = {field.id => ['value1', 'value2']}
2461 2463 issue.save!
2462 2464 end
2463 2465 assert_difference 'JournalDetail.count', 2 do
2464 2466 issue.init_journal(User.first)
2465 2467 issue.custom_field_values = {field.id => ['value3', 'value2']}
2466 2468 issue.save!
2467 2469 end
2468 2470 assert_difference 'JournalDetail.count', 2 do
2469 2471 issue.init_journal(User.first)
2470 2472 issue.custom_field_values = {field.id => nil}
2471 2473 issue.save!
2472 2474 end
2473 2475 end
2474 2476 end
2475 2477
2478 def test_custom_value_cleared_on_tracker_change_should_be_journalized
2479 a = IssueCustomField.generate!(:tracker_ids => [1])
2480 issue = Issue.generate!(:project_id => 1, :tracker_id => 1, :custom_field_values => {a.id.to_s => "foo"})
2481 assert_equal "foo", issue.custom_field_value(a)
2482
2483 journal = new_record(Journal) do
2484 issue.init_journal(User.first)
2485 issue.tracker_id = 2
2486 issue.save!
2487 end
2488 details = journal.details.select {|d| d.property == 'cf' && d.prop_key == a.id.to_s}
2489 assert_equal 1, details.size
2490 assert_equal 'foo', details.first.old_value
2491 assert_nil details.first.value
2492 end
2493
2476 2494 def test_description_eol_should_be_normalized
2477 2495 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
2478 2496 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
2479 2497 end
2480 2498
2481 2499 def test_saving_twice_should_not_duplicate_journal_details
2482 2500 i = Issue.first
2483 2501 i.init_journal(User.find(2), 'Some notes')
2484 2502 # initial changes
2485 2503 i.subject = 'New subject'
2486 2504 i.done_ratio = i.done_ratio + 10
2487 2505 assert_difference 'Journal.count' do
2488 2506 assert i.save
2489 2507 end
2490 2508 # 1 more change
2491 2509 i.priority = IssuePriority.where("id <> ?", i.priority_id).first
2492 2510 assert_no_difference 'Journal.count' do
2493 2511 assert_difference 'JournalDetail.count', 1 do
2494 2512 i.save
2495 2513 end
2496 2514 end
2497 2515 # no more change
2498 2516 assert_no_difference 'Journal.count' do
2499 2517 assert_no_difference 'JournalDetail.count' do
2500 2518 i.save
2501 2519 end
2502 2520 end
2503 2521 end
2504 2522
2505 2523 test "#done_ratio should use the issue_status according to Setting.issue_done_ratio" do
2506 2524 @issue = Issue.find(1)
2507 2525 @issue_status = IssueStatus.find(1)
2508 2526 @issue_status.update!(:default_done_ratio => 50)
2509 2527 @issue2 = Issue.find(2)
2510 2528 @issue_status2 = IssueStatus.find(2)
2511 2529 @issue_status2.update!(:default_done_ratio => 0)
2512 2530
2513 2531 with_settings :issue_done_ratio => 'issue_field' do
2514 2532 assert_equal 0, @issue.done_ratio
2515 2533 assert_equal 30, @issue2.done_ratio
2516 2534 end
2517 2535
2518 2536 with_settings :issue_done_ratio => 'issue_status' do
2519 2537 assert_equal 50, @issue.done_ratio
2520 2538 assert_equal 0, @issue2.done_ratio
2521 2539 end
2522 2540 end
2523 2541
2524 2542 test "#update_done_ratio_from_issue_status should update done_ratio according to Setting.issue_done_ratio" do
2525 2543 @issue = Issue.find(1)
2526 2544 @issue_status = IssueStatus.find(1)
2527 2545 @issue_status.update!(:default_done_ratio => 50)
2528 2546 @issue2 = Issue.find(2)
2529 2547 @issue_status2 = IssueStatus.find(2)
2530 2548 @issue_status2.update!(:default_done_ratio => 0)
2531 2549
2532 2550 with_settings :issue_done_ratio => 'issue_field' do
2533 2551 @issue.update_done_ratio_from_issue_status
2534 2552 @issue2.update_done_ratio_from_issue_status
2535 2553
2536 2554 assert_equal 0, @issue.read_attribute(:done_ratio)
2537 2555 assert_equal 30, @issue2.read_attribute(:done_ratio)
2538 2556 end
2539 2557
2540 2558 with_settings :issue_done_ratio => 'issue_status' do
2541 2559 @issue.update_done_ratio_from_issue_status
2542 2560 @issue2.update_done_ratio_from_issue_status
2543 2561
2544 2562 assert_equal 50, @issue.read_attribute(:done_ratio)
2545 2563 assert_equal 0, @issue2.read_attribute(:done_ratio)
2546 2564 end
2547 2565 end
2548 2566
2549 2567 test "#by_tracker" do
2550 2568 User.current = User.anonymous
2551 2569 groups = Issue.by_tracker(Project.find(1))
2552 2570 assert_equal 3, groups.count
2553 2571 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2554 2572 end
2555 2573
2556 2574 test "#by_version" do
2557 2575 User.current = User.anonymous
2558 2576 groups = Issue.by_version(Project.find(1))
2559 2577 assert_equal 3, groups.count
2560 2578 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2561 2579 end
2562 2580
2563 2581 test "#by_priority" do
2564 2582 User.current = User.anonymous
2565 2583 groups = Issue.by_priority(Project.find(1))
2566 2584 assert_equal 4, groups.count
2567 2585 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2568 2586 end
2569 2587
2570 2588 test "#by_category" do
2571 2589 User.current = User.anonymous
2572 2590 groups = Issue.by_category(Project.find(1))
2573 2591 assert_equal 2, groups.count
2574 2592 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2575 2593 end
2576 2594
2577 2595 test "#by_assigned_to" do
2578 2596 User.current = User.anonymous
2579 2597 groups = Issue.by_assigned_to(Project.find(1))
2580 2598 assert_equal 2, groups.count
2581 2599 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2582 2600 end
2583 2601
2584 2602 test "#by_author" do
2585 2603 User.current = User.anonymous
2586 2604 groups = Issue.by_author(Project.find(1))
2587 2605 assert_equal 4, groups.count
2588 2606 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2589 2607 end
2590 2608
2591 2609 test "#by_subproject" do
2592 2610 User.current = User.anonymous
2593 2611 groups = Issue.by_subproject(Project.find(1))
2594 2612 # Private descendant not visible
2595 2613 assert_equal 1, groups.count
2596 2614 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2597 2615 end
2598 2616
2599 2617 def test_recently_updated_scope
2600 2618 #should return the last updated issue
2601 2619 assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
2602 2620 end
2603 2621
2604 2622 def test_on_active_projects_scope
2605 2623 assert Project.find(2).archive
2606 2624
2607 2625 before = Issue.on_active_project.length
2608 2626 # test inclusion to results
2609 2627 issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
2610 2628 assert_equal before + 1, Issue.on_active_project.length
2611 2629
2612 2630 # Move to an archived project
2613 2631 issue.project = Project.find(2)
2614 2632 assert issue.save
2615 2633 assert_equal before, Issue.on_active_project.length
2616 2634 end
2617 2635
2618 2636 test "Issue#recipients should include project recipients" do
2619 2637 issue = Issue.generate!
2620 2638 assert issue.project.recipients.present?
2621 2639 issue.project.recipients.each do |project_recipient|
2622 2640 assert issue.recipients.include?(project_recipient)
2623 2641 end
2624 2642 end
2625 2643
2626 2644 test "Issue#recipients should include the author if the author is active" do
2627 2645 issue = Issue.generate!(:author => User.generate!)
2628 2646 assert issue.author, "No author set for Issue"
2629 2647 assert issue.recipients.include?(issue.author.mail)
2630 2648 end
2631 2649
2632 2650 test "Issue#recipients should include the assigned to user if the assigned to user is active" do
2633 2651 issue = Issue.generate!(:assigned_to => User.generate!)
2634 2652 assert issue.assigned_to, "No assigned_to set for Issue"
2635 2653 assert issue.recipients.include?(issue.assigned_to.mail)
2636 2654 end
2637 2655
2638 2656 test "Issue#recipients should not include users who opt out of all email" do
2639 2657 issue = Issue.generate!(:author => User.generate!)
2640 2658 issue.author.update!(:mail_notification => :none)
2641 2659 assert !issue.recipients.include?(issue.author.mail)
2642 2660 end
2643 2661
2644 2662 test "Issue#recipients should not include the issue author if they are only notified of assigned issues" do
2645 2663 issue = Issue.generate!(:author => User.generate!)
2646 2664 issue.author.update!(:mail_notification => :only_assigned)
2647 2665 assert !issue.recipients.include?(issue.author.mail)
2648 2666 end
2649 2667
2650 2668 test "Issue#recipients should not include the assigned user if they are only notified of owned issues" do
2651 2669 issue = Issue.generate!(:assigned_to => User.generate!)
2652 2670 issue.assigned_to.update!(:mail_notification => :only_owner)
2653 2671 assert !issue.recipients.include?(issue.assigned_to.mail)
2654 2672 end
2655 2673
2656 2674 def test_last_journal_id_with_journals_should_return_the_journal_id
2657 2675 assert_equal 2, Issue.find(1).last_journal_id
2658 2676 end
2659 2677
2660 2678 def test_last_journal_id_without_journals_should_return_nil
2661 2679 assert_nil Issue.find(3).last_journal_id
2662 2680 end
2663 2681
2664 2682 def test_journals_after_should_return_journals_with_greater_id
2665 2683 assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
2666 2684 assert_equal [], Issue.find(1).journals_after('2')
2667 2685 end
2668 2686
2669 2687 def test_journals_after_with_blank_arg_should_return_all_journals
2670 2688 assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
2671 2689 end
2672 2690
2673 2691 def test_css_classes_should_include_tracker
2674 2692 issue = Issue.new(:tracker => Tracker.find(2))
2675 2693 classes = issue.css_classes.split(' ')
2676 2694 assert_include 'tracker-2', classes
2677 2695 end
2678 2696
2679 2697 def test_css_classes_should_include_priority
2680 2698 issue = Issue.new(:priority => IssuePriority.find(8))
2681 2699 classes = issue.css_classes.split(' ')
2682 2700 assert_include 'priority-8', classes
2683 2701 assert_include 'priority-highest', classes
2684 2702 end
2685 2703
2686 2704 def test_css_classes_should_include_user_and_group_assignment
2687 2705 project = Project.first
2688 2706 user = User.generate!
2689 2707 group = Group.generate!
2690 2708 Member.create!(:principal => group, :project => project, :role_ids => [1, 2])
2691 2709 group.users << user
2692 2710 assert user.member_of?(project)
2693 2711 issue1 = Issue.generate(:assigned_to_id => group.id)
2694 2712 assert_include 'assigned-to-my-group', issue1.css_classes(user)
2695 2713 assert_not_include 'assigned-to-me', issue1.css_classes(user)
2696 2714 issue2 = Issue.generate(:assigned_to_id => user.id)
2697 2715 assert_not_include 'assigned-to-my-group', issue2.css_classes(user)
2698 2716 assert_include 'assigned-to-me', issue2.css_classes(user)
2699 2717 end
2700 2718
2701 2719 def test_save_attachments_with_hash_should_save_attachments_in_keys_order
2702 2720 set_tmp_attachments_directory
2703 2721 issue = Issue.generate!
2704 2722 issue.save_attachments({
2705 2723 'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')},
2706 2724 '3' => {'file' => mock_file_with_options(:original_filename => 'bar')},
2707 2725 '1' => {'file' => mock_file_with_options(:original_filename => 'foo')}
2708 2726 })
2709 2727 issue.attach_saved_attachments
2710 2728
2711 2729 assert_equal 3, issue.reload.attachments.count
2712 2730 assert_equal %w(upload foo bar), issue.attachments.map(&:filename)
2713 2731 end
2714 2732
2715 2733 def test_save_attachments_with_array_should_warn_about_missing_tokens
2716 2734 set_tmp_attachments_directory
2717 2735 issue = Issue.generate!
2718 2736 issue.save_attachments([
2719 2737 {'token' => 'missing'}
2720 2738 ])
2721 2739 assert !issue.save
2722 2740 assert issue.errors[:base].present?
2723 2741 assert_equal 0, issue.reload.attachments.count
2724 2742 end
2725 2743
2726 2744 def test_closed_on_should_be_nil_when_creating_an_open_issue
2727 2745 issue = Issue.generate!(:status_id => 1).reload
2728 2746 assert !issue.closed?
2729 2747 assert_nil issue.closed_on
2730 2748 end
2731 2749
2732 2750 def test_closed_on_should_be_set_when_creating_a_closed_issue
2733 2751 issue = Issue.generate!(:status_id => 5).reload
2734 2752 assert issue.closed?
2735 2753 assert_not_nil issue.closed_on
2736 2754 assert_equal issue.updated_on, issue.closed_on
2737 2755 assert_equal issue.created_on, issue.closed_on
2738 2756 end
2739 2757
2740 2758 def test_closed_on_should_be_nil_when_updating_an_open_issue
2741 2759 issue = Issue.find(1)
2742 2760 issue.subject = 'Not closed yet'
2743 2761 issue.save!
2744 2762 issue.reload
2745 2763 assert_nil issue.closed_on
2746 2764 end
2747 2765
2748 2766 def test_closed_on_should_be_set_when_closing_an_open_issue
2749 2767 issue = Issue.find(1)
2750 2768 issue.subject = 'Now closed'
2751 2769 issue.status_id = 5
2752 2770 issue.save!
2753 2771 issue.reload
2754 2772 assert_not_nil issue.closed_on
2755 2773 assert_equal issue.updated_on, issue.closed_on
2756 2774 end
2757 2775
2758 2776 def test_closed_on_should_not_be_updated_when_updating_a_closed_issue
2759 2777 issue = Issue.open(false).first
2760 2778 was_closed_on = issue.closed_on
2761 2779 assert_not_nil was_closed_on
2762 2780 issue.subject = 'Updating a closed issue'
2763 2781 issue.save!
2764 2782 issue.reload
2765 2783 assert_equal was_closed_on, issue.closed_on
2766 2784 end
2767 2785
2768 2786 def test_closed_on_should_be_preserved_when_reopening_a_closed_issue
2769 2787 issue = Issue.open(false).first
2770 2788 was_closed_on = issue.closed_on
2771 2789 assert_not_nil was_closed_on
2772 2790 issue.subject = 'Reopening a closed issue'
2773 2791 issue.status_id = 1
2774 2792 issue.save!
2775 2793 issue.reload
2776 2794 assert !issue.closed?
2777 2795 assert_equal was_closed_on, issue.closed_on
2778 2796 end
2779 2797
2780 2798 def test_status_was_should_return_nil_for_new_issue
2781 2799 issue = Issue.new
2782 2800 assert_nil issue.status_was
2783 2801 end
2784 2802
2785 2803 def test_status_was_should_return_status_before_change
2786 2804 issue = Issue.find(1)
2787 2805 issue.status = IssueStatus.find(2)
2788 2806 assert_equal IssueStatus.find(1), issue.status_was
2789 2807 end
2790 2808
2791 2809 def test_status_was_should_return_status_before_change_with_status_id
2792 2810 issue = Issue.find(1)
2793 2811 assert_equal IssueStatus.find(1), issue.status
2794 2812 issue.status_id = 2
2795 2813 assert_equal IssueStatus.find(1), issue.status_was
2796 2814 end
2797 2815
2798 2816 def test_status_was_should_be_reset_on_save
2799 2817 issue = Issue.find(1)
2800 2818 issue.status = IssueStatus.find(2)
2801 2819 assert_equal IssueStatus.find(1), issue.status_was
2802 2820 assert issue.save!
2803 2821 assert_equal IssueStatus.find(2), issue.status_was
2804 2822 end
2805 2823
2806 2824 def test_closing_should_return_true_when_closing_an_issue
2807 2825 issue = Issue.find(1)
2808 2826 issue.status = IssueStatus.find(2)
2809 2827 assert_equal false, issue.closing?
2810 2828 issue.status = IssueStatus.find(5)
2811 2829 assert_equal true, issue.closing?
2812 2830 end
2813 2831
2814 2832 def test_closing_should_return_true_when_closing_an_issue_with_status_id
2815 2833 issue = Issue.find(1)
2816 2834 issue.status_id = 2
2817 2835 assert_equal false, issue.closing?
2818 2836 issue.status_id = 5
2819 2837 assert_equal true, issue.closing?
2820 2838 end
2821 2839
2822 2840 def test_closing_should_return_true_for_new_closed_issue
2823 2841 issue = Issue.new
2824 2842 assert_equal false, issue.closing?
2825 2843 issue.status = IssueStatus.find(5)
2826 2844 assert_equal true, issue.closing?
2827 2845 end
2828 2846
2829 2847 def test_closing_should_return_true_for_new_closed_issue_with_status_id
2830 2848 issue = Issue.new
2831 2849 assert_equal false, issue.closing?
2832 2850 issue.status_id = 5
2833 2851 assert_equal true, issue.closing?
2834 2852 end
2835 2853
2836 2854 def test_closing_should_be_reset_after_save
2837 2855 issue = Issue.find(1)
2838 2856 issue.status_id = 5
2839 2857 assert_equal true, issue.closing?
2840 2858 issue.save!
2841 2859 assert_equal false, issue.closing?
2842 2860 end
2843 2861
2844 2862 def test_reopening_should_return_true_when_reopening_an_issue
2845 2863 issue = Issue.find(8)
2846 2864 issue.status = IssueStatus.find(6)
2847 2865 assert_equal false, issue.reopening?
2848 2866 issue.status = IssueStatus.find(2)
2849 2867 assert_equal true, issue.reopening?
2850 2868 end
2851 2869
2852 2870 def test_reopening_should_return_true_when_reopening_an_issue_with_status_id
2853 2871 issue = Issue.find(8)
2854 2872 issue.status_id = 6
2855 2873 assert_equal false, issue.reopening?
2856 2874 issue.status_id = 2
2857 2875 assert_equal true, issue.reopening?
2858 2876 end
2859 2877
2860 2878 def test_reopening_should_return_false_for_new_open_issue
2861 2879 issue = Issue.new
2862 2880 issue.status = IssueStatus.find(1)
2863 2881 assert_equal false, issue.reopening?
2864 2882 end
2865 2883
2866 2884 def test_reopening_should_be_reset_after_save
2867 2885 issue = Issue.find(8)
2868 2886 issue.status_id = 2
2869 2887 assert_equal true, issue.reopening?
2870 2888 issue.save!
2871 2889 assert_equal false, issue.reopening?
2872 2890 end
2873 2891
2874 2892 def test_default_status_without_tracker_should_be_nil
2875 2893 issue = Issue.new
2876 2894 assert_nil issue.tracker
2877 2895 assert_nil issue.default_status
2878 2896 end
2879 2897
2880 2898 def test_default_status_should_be_tracker_default_status
2881 2899 issue = Issue.new(:tracker_id => 1)
2882 2900 assert_not_nil issue.status
2883 2901 assert_equal issue.tracker.default_status, issue.default_status
2884 2902 end
2885 2903
2886 2904 def test_initializing_with_tracker_should_set_default_status
2887 2905 issue = Issue.new(:tracker => Tracker.find(1))
2888 2906 assert_not_nil issue.status
2889 2907 assert_equal issue.default_status, issue.status
2890 2908 end
2891 2909
2892 2910 def test_initializing_with_tracker_id_should_set_default_status
2893 2911 issue = Issue.new(:tracker_id => 1)
2894 2912 assert_not_nil issue.status
2895 2913 assert_equal issue.default_status, issue.status
2896 2914 end
2897 2915
2898 2916 def test_setting_tracker_should_set_default_status
2899 2917 issue = Issue.new
2900 2918 issue.tracker = Tracker.find(1)
2901 2919 assert_not_nil issue.status
2902 2920 assert_equal issue.default_status, issue.status
2903 2921 end
2904 2922
2905 2923 def test_changing_tracker_should_set_default_status_if_status_was_default
2906 2924 WorkflowTransition.delete_all
2907 2925 WorkflowTransition.create! :role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1
2908 2926 Tracker.find(2).update! :default_status_id => 2
2909 2927
2910 2928 issue = Issue.new(:tracker_id => 1, :status_id => 1)
2911 2929 assert_equal IssueStatus.find(1), issue.status
2912 2930 issue.tracker = Tracker.find(2)
2913 2931 assert_equal IssueStatus.find(2), issue.status
2914 2932 end
2915 2933
2916 2934 def test_changing_tracker_should_set_default_status_if_status_is_not_used_by_tracker
2917 2935 WorkflowTransition.delete_all
2918 2936 Tracker.find(2).update! :default_status_id => 2
2919 2937
2920 2938 issue = Issue.new(:tracker_id => 1, :status_id => 3)
2921 2939 assert_equal IssueStatus.find(3), issue.status
2922 2940 issue.tracker = Tracker.find(2)
2923 2941 assert_equal IssueStatus.find(2), issue.status
2924 2942 end
2925 2943
2926 2944 def test_changing_tracker_should_keep_status_if_status_was_not_default_and_is_used_by_tracker
2927 2945 WorkflowTransition.delete_all
2928 2946 WorkflowTransition.create! :role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 3
2929 2947 Tracker.find(2).update! :default_status_id => 2
2930 2948
2931 2949 issue = Issue.new(:tracker_id => 1, :status_id => 3)
2932 2950 assert_equal IssueStatus.find(3), issue.status
2933 2951 issue.tracker = Tracker.find(2)
2934 2952 assert_equal IssueStatus.find(3), issue.status
2935 2953 end
2936 2954
2937 2955 def test_assigned_to_was_with_a_group
2938 2956 group = Group.find(10)
2939 2957
2940 2958 issue = Issue.generate!(:assigned_to => group)
2941 2959 issue.reload.assigned_to = nil
2942 2960 assert_equal group, issue.assigned_to_was
2943 2961 end
2944 2962
2945 2963 def test_issue_overdue_should_respect_user_timezone
2946 2964 user_in_europe = users(:users_001)
2947 2965 user_in_europe.pref.update! :time_zone => 'UTC'
2948 2966
2949 2967 user_in_asia = users(:users_002)
2950 2968 user_in_asia.pref.update! :time_zone => 'Hongkong'
2951 2969
2952 2970 issue = Issue.generate! :due_date => Date.parse('2016-03-20')
2953 2971
2954 2972 # server time is UTC
2955 2973 time = Time.parse '2016-03-20 20:00 UTC'
2956 2974 Time.stubs(:now).returns(time)
2957 2975 Date.stubs(:today).returns(time.to_date)
2958 2976
2959 2977 # for a user in the same time zone as the server the issue is not overdue
2960 2978 # yet
2961 2979 User.current = user_in_europe
2962 2980 assert !issue.overdue?
2963 2981
2964 2982 # at the same time, a user in East Asia looks at the issue - it's already
2965 2983 # March 21st and the issue should be marked overdue
2966 2984 User.current = user_in_asia
2967 2985 assert issue.overdue?
2968 2986
2969 2987 end
2970 2988 end
General Comments 0
You need to be logged in to leave comments. Login now