@@ -1,779 +1,764 | |||
|
1 | 1 | # Redmine - project management software |
|
2 | 2 | # Copyright (C) 2006-2012 Jean-Philippe Lang |
|
3 | 3 | # |
|
4 | 4 | # This program is free software; you can redistribute it and/or |
|
5 | 5 | # modify it under the terms of the GNU General Public License |
|
6 | 6 | # as published by the Free Software Foundation; either version 2 |
|
7 | 7 | # of the License, or (at your option) any later version. |
|
8 | 8 | # |
|
9 | 9 | # This program is distributed in the hope that it will be useful, |
|
10 | 10 | # but WITHOUT ANY WARRANTY; without even the implied warranty of |
|
11 | 11 | # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|
12 | 12 | # GNU General Public License for more details. |
|
13 | 13 | # |
|
14 | 14 | # You should have received a copy of the GNU General Public License |
|
15 | 15 | # along with this program; if not, write to the Free Software |
|
16 | 16 | # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. |
|
17 | 17 | |
|
18 | 18 | require File.expand_path('../../../test_helper', __FILE__) |
|
19 | 19 | |
|
20 | 20 | class ApiTest::IssuesTest < ActionController::IntegrationTest |
|
21 | 21 | fixtures :projects, |
|
22 | 22 | :users, |
|
23 | 23 | :roles, |
|
24 | 24 | :members, |
|
25 | 25 | :member_roles, |
|
26 | 26 | :issues, |
|
27 | 27 | :issue_statuses, |
|
28 | 28 | :versions, |
|
29 | 29 | :trackers, |
|
30 | 30 | :projects_trackers, |
|
31 | 31 | :issue_categories, |
|
32 | 32 | :enabled_modules, |
|
33 | 33 | :enumerations, |
|
34 | 34 | :attachments, |
|
35 | 35 | :workflows, |
|
36 | 36 | :custom_fields, |
|
37 | 37 | :custom_values, |
|
38 | 38 | :custom_fields_projects, |
|
39 | 39 | :custom_fields_trackers, |
|
40 | 40 | :time_entries, |
|
41 | 41 | :journals, |
|
42 | 42 | :journal_details, |
|
43 | 43 | :queries, |
|
44 | 44 | :attachments |
|
45 | 45 | |
|
46 | 46 | def setup |
|
47 | 47 | Setting.rest_api_enabled = '1' |
|
48 | 48 | end |
|
49 | 49 | |
|
50 | 50 | context "/issues" do |
|
51 | 51 | # Use a private project to make sure auth is really working and not just |
|
52 | 52 | # only showing public issues. |
|
53 | 53 | should_allow_api_authentication(:get, "/projects/private-child/issues.xml") |
|
54 | 54 | |
|
55 | 55 | should "contain metadata" do |
|
56 | 56 | get '/issues.xml' |
|
57 | 57 | |
|
58 | 58 | assert_tag :tag => 'issues', |
|
59 | 59 | :attributes => { |
|
60 | 60 | :type => 'array', |
|
61 | 61 | :total_count => assigns(:issue_count), |
|
62 | 62 | :limit => 25, |
|
63 | 63 | :offset => 0 |
|
64 | 64 | } |
|
65 | 65 | end |
|
66 | 66 | |
|
67 | 67 | context "with offset and limit" do |
|
68 | 68 | should "use the params" do |
|
69 | 69 | get '/issues.xml?offset=2&limit=3' |
|
70 | 70 | |
|
71 | 71 | assert_equal 3, assigns(:limit) |
|
72 | 72 | assert_equal 2, assigns(:offset) |
|
73 | 73 | assert_tag :tag => 'issues', :children => {:count => 3, :only => {:tag => 'issue'}} |
|
74 | 74 | end |
|
75 | 75 | end |
|
76 | 76 | |
|
77 | 77 | context "with nometa param" do |
|
78 | 78 | should "not contain metadata" do |
|
79 | 79 | get '/issues.xml?nometa=1' |
|
80 | 80 | |
|
81 | 81 | assert_tag :tag => 'issues', |
|
82 | 82 | :attributes => { |
|
83 | 83 | :type => 'array', |
|
84 | 84 | :total_count => nil, |
|
85 | 85 | :limit => nil, |
|
86 | 86 | :offset => nil |
|
87 | 87 | } |
|
88 | 88 | end |
|
89 | 89 | end |
|
90 | 90 | |
|
91 | 91 | context "with nometa header" do |
|
92 | 92 | should "not contain metadata" do |
|
93 | 93 | get '/issues.xml', {}, {'X-Redmine-Nometa' => '1'} |
|
94 | 94 | |
|
95 | 95 | assert_tag :tag => 'issues', |
|
96 | 96 | :attributes => { |
|
97 | 97 | :type => 'array', |
|
98 | 98 | :total_count => nil, |
|
99 | 99 | :limit => nil, |
|
100 | 100 | :offset => nil |
|
101 | 101 | } |
|
102 | 102 | end |
|
103 | 103 | end |
|
104 | 104 | |
|
105 | 105 | context "with relations" do |
|
106 | 106 | should "display relations" do |
|
107 | 107 | get '/issues.xml?include=relations' |
|
108 | 108 | |
|
109 | 109 | assert_response :success |
|
110 | 110 | assert_equal 'application/xml', @response.content_type |
|
111 | 111 | assert_tag 'relations', |
|
112 | 112 | :parent => {:tag => 'issue', :child => {:tag => 'id', :content => '3'}}, |
|
113 | 113 | :children => {:count => 1}, |
|
114 | 114 | :child => { |
|
115 | 115 | :tag => 'relation', |
|
116 | 116 | :attributes => {:id => '2', :issue_id => '2', :issue_to_id => '3', :relation_type => 'relates'} |
|
117 | 117 | } |
|
118 | 118 | assert_tag 'relations', |
|
119 | 119 | :parent => {:tag => 'issue', :child => {:tag => 'id', :content => '1'}}, |
|
120 | 120 | :children => {:count => 0} |
|
121 | 121 | end |
|
122 | 122 | end |
|
123 | 123 | |
|
124 | 124 | context "with invalid query params" do |
|
125 | 125 | should "return errors" do |
|
126 | 126 | get '/issues.xml', {:f => ['start_date'], :op => {:start_date => '='}} |
|
127 | 127 | |
|
128 | 128 | assert_response :unprocessable_entity |
|
129 | 129 | assert_equal 'application/xml', @response.content_type |
|
130 | 130 | assert_tag 'errors', :child => {:tag => 'error', :content => "Start date can't be blank"} |
|
131 | 131 | end |
|
132 | 132 | end |
|
133 | 133 | |
|
134 | 134 | context "with custom field filter" do |
|
135 | 135 | should "show only issues with the custom field value" do |
|
136 | 136 | get '/issues.xml', { :set_filter => 1, :f => ['cf_1'], :op => {:cf_1 => '='}, :v => {:cf_1 => ['MySQL']}} |
|
137 | 137 | |
|
138 | 138 | expected_ids = Issue.visible.all( |
|
139 | 139 | :include => :custom_values, |
|
140 | 140 | :conditions => {:custom_values => {:custom_field_id => 1, :value => 'MySQL'}}).map(&:id) |
|
141 | 141 | |
|
142 | 142 | assert_select 'issues > issue > id', :count => expected_ids.count do |ids| |
|
143 | 143 | ids.each { |id| assert expected_ids.delete(id.children.first.content.to_i) } |
|
144 | 144 | end |
|
145 | 145 | end |
|
146 | 146 | end |
|
147 | 147 | |
|
148 | 148 | context "with custom field filter (shorthand method)" do |
|
149 | 149 | should "show only issues with the custom field value" do |
|
150 | 150 | get '/issues.xml', { :cf_1 => 'MySQL' } |
|
151 | 151 | |
|
152 | 152 | expected_ids = Issue.visible.all( |
|
153 | 153 | :include => :custom_values, |
|
154 | 154 | :conditions => {:custom_values => {:custom_field_id => 1, :value => 'MySQL'}}).map(&:id) |
|
155 | 155 | |
|
156 | 156 | assert_select 'issues > issue > id', :count => expected_ids.count do |ids| |
|
157 | 157 | ids.each { |id| assert expected_ids.delete(id.children.first.content.to_i) } |
|
158 | 158 | end |
|
159 | 159 | end |
|
160 | 160 | end |
|
161 | 161 | end |
|
162 | 162 | |
|
163 | 163 | context "/index.json" do |
|
164 | 164 | should_allow_api_authentication(:get, "/projects/private-child/issues.json") |
|
165 | 165 | end |
|
166 | 166 | |
|
167 | 167 | context "/index.xml with filter" do |
|
168 | 168 | should "show only issues with the status_id" do |
|
169 | 169 | get '/issues.xml?status_id=5' |
|
170 | 170 | |
|
171 | 171 | expected_ids = Issue.visible.all(:conditions => {:status_id => 5}).map(&:id) |
|
172 | 172 | |
|
173 | 173 | assert_select 'issues > issue > id', :count => expected_ids.count do |ids| |
|
174 | 174 | ids.each { |id| assert expected_ids.delete(id.children.first.content.to_i) } |
|
175 | 175 | end |
|
176 | 176 | end |
|
177 | 177 | end |
|
178 | 178 | |
|
179 | 179 | context "/index.json with filter" do |
|
180 | 180 | should "show only issues with the status_id" do |
|
181 | 181 | get '/issues.json?status_id=5' |
|
182 | 182 | |
|
183 | 183 | json = ActiveSupport::JSON.decode(response.body) |
|
184 | 184 | status_ids_used = json['issues'].collect {|j| j['status']['id'] } |
|
185 | 185 | assert_equal 3, status_ids_used.length |
|
186 | 186 | assert status_ids_used.all? {|id| id == 5 } |
|
187 | 187 | end |
|
188 | 188 | |
|
189 | 189 | end |
|
190 | 190 | |
|
191 | 191 | # Issue 6 is on a private project |
|
192 | 192 | context "/issues/6.xml" do |
|
193 | 193 | should_allow_api_authentication(:get, "/issues/6.xml") |
|
194 | 194 | end |
|
195 | 195 | |
|
196 | 196 | context "/issues/6.json" do |
|
197 | 197 | should_allow_api_authentication(:get, "/issues/6.json") |
|
198 | 198 | end |
|
199 | 199 | |
|
200 | 200 | context "GET /issues/:id" do |
|
201 | 201 | context "with journals" do |
|
202 | 202 | context ".xml" do |
|
203 | 203 | should "display journals" do |
|
204 | 204 | get '/issues/1.xml?include=journals' |
|
205 | 205 | |
|
206 | 206 | assert_tag :tag => 'issue', |
|
207 | 207 | :child => { |
|
208 | 208 | :tag => 'journals', |
|
209 | 209 | :attributes => { :type => 'array' }, |
|
210 | 210 | :child => { |
|
211 | 211 | :tag => 'journal', |
|
212 | 212 | :attributes => { :id => '1'}, |
|
213 | 213 | :child => { |
|
214 | 214 | :tag => 'details', |
|
215 | 215 | :attributes => { :type => 'array' }, |
|
216 | 216 | :child => { |
|
217 | 217 | :tag => 'detail', |
|
218 | 218 | :attributes => { :name => 'status_id' }, |
|
219 | 219 | :child => { |
|
220 | 220 | :tag => 'old_value', |
|
221 | 221 | :content => '1', |
|
222 | 222 | :sibling => { |
|
223 | 223 | :tag => 'new_value', |
|
224 | 224 | :content => '2' |
|
225 | 225 | } |
|
226 | 226 | } |
|
227 | 227 | } |
|
228 | 228 | } |
|
229 | 229 | } |
|
230 | 230 | } |
|
231 | 231 | end |
|
232 | 232 | end |
|
233 | 233 | end |
|
234 | 234 | |
|
235 | 235 | context "with custom fields" do |
|
236 | 236 | context ".xml" do |
|
237 | 237 | should "display custom fields" do |
|
238 | 238 | get '/issues/3.xml' |
|
239 | 239 | |
|
240 | 240 | assert_tag :tag => 'issue', |
|
241 | 241 | :child => { |
|
242 | 242 | :tag => 'custom_fields', |
|
243 | 243 | :attributes => { :type => 'array' }, |
|
244 | 244 | :child => { |
|
245 | 245 | :tag => 'custom_field', |
|
246 | 246 | :attributes => { :id => '1'}, |
|
247 | 247 | :child => { |
|
248 | 248 | :tag => 'value', |
|
249 | 249 | :content => 'MySQL' |
|
250 | 250 | } |
|
251 | 251 | } |
|
252 | 252 | } |
|
253 | 253 | |
|
254 | 254 | assert_nothing_raised do |
|
255 | 255 | Hash.from_xml(response.body).to_xml |
|
256 | 256 | end |
|
257 | 257 | end |
|
258 | 258 | end |
|
259 | 259 | end |
|
260 | 260 | |
|
261 | 261 | context "with multi custom fields" do |
|
262 | 262 | setup do |
|
263 | 263 | field = CustomField.find(1) |
|
264 | 264 | field.update_attribute :multiple, true |
|
265 | 265 | issue = Issue.find(3) |
|
266 | 266 | issue.custom_field_values = {1 => ['MySQL', 'Oracle']} |
|
267 | 267 | issue.save! |
|
268 | 268 | end |
|
269 | 269 | |
|
270 | 270 | context ".xml" do |
|
271 | 271 | should "display custom fields" do |
|
272 | 272 | get '/issues/3.xml' |
|
273 | 273 | assert_response :success |
|
274 | 274 | assert_tag :tag => 'issue', |
|
275 | 275 | :child => { |
|
276 | 276 | :tag => 'custom_fields', |
|
277 | 277 | :attributes => { :type => 'array' }, |
|
278 | 278 | :child => { |
|
279 | 279 | :tag => 'custom_field', |
|
280 | 280 | :attributes => { :id => '1'}, |
|
281 | 281 | :child => { |
|
282 | 282 | :tag => 'value', |
|
283 | 283 | :attributes => { :type => 'array' }, |
|
284 | 284 | :children => { :count => 2 } |
|
285 | 285 | } |
|
286 | 286 | } |
|
287 | 287 | } |
|
288 | 288 | |
|
289 | 289 | xml = Hash.from_xml(response.body) |
|
290 | 290 | custom_fields = xml['issue']['custom_fields'] |
|
291 | 291 | assert_kind_of Array, custom_fields |
|
292 | 292 | field = custom_fields.detect {|f| f['id'] == '1'} |
|
293 | 293 | assert_kind_of Hash, field |
|
294 | 294 | assert_equal ['MySQL', 'Oracle'], field['value'].sort |
|
295 | 295 | end |
|
296 | 296 | end |
|
297 | 297 | |
|
298 | 298 | context ".json" do |
|
299 | 299 | should "display custom fields" do |
|
300 | 300 | get '/issues/3.json' |
|
301 | 301 | assert_response :success |
|
302 | 302 | json = ActiveSupport::JSON.decode(response.body) |
|
303 | 303 | custom_fields = json['issue']['custom_fields'] |
|
304 | 304 | assert_kind_of Array, custom_fields |
|
305 | 305 | field = custom_fields.detect {|f| f['id'] == 1} |
|
306 | 306 | assert_kind_of Hash, field |
|
307 | 307 | assert_equal ['MySQL', 'Oracle'], field['value'].sort |
|
308 | 308 | end |
|
309 | 309 | end |
|
310 | 310 | end |
|
311 | 311 | |
|
312 | 312 | context "with empty value for multi custom field" do |
|
313 | 313 | setup do |
|
314 | 314 | field = CustomField.find(1) |
|
315 | 315 | field.update_attribute :multiple, true |
|
316 | 316 | issue = Issue.find(3) |
|
317 | 317 | issue.custom_field_values = {1 => ['']} |
|
318 | 318 | issue.save! |
|
319 | 319 | end |
|
320 | 320 | |
|
321 | 321 | context ".xml" do |
|
322 | 322 | should "display custom fields" do |
|
323 | 323 | get '/issues/3.xml' |
|
324 | 324 | assert_response :success |
|
325 | 325 | assert_tag :tag => 'issue', |
|
326 | 326 | :child => { |
|
327 | 327 | :tag => 'custom_fields', |
|
328 | 328 | :attributes => { :type => 'array' }, |
|
329 | 329 | :child => { |
|
330 | 330 | :tag => 'custom_field', |
|
331 | 331 | :attributes => { :id => '1'}, |
|
332 | 332 | :child => { |
|
333 | 333 | :tag => 'value', |
|
334 | 334 | :attributes => { :type => 'array' }, |
|
335 | 335 | :children => { :count => 0 } |
|
336 | 336 | } |
|
337 | 337 | } |
|
338 | 338 | } |
|
339 | 339 | |
|
340 | 340 | xml = Hash.from_xml(response.body) |
|
341 | 341 | custom_fields = xml['issue']['custom_fields'] |
|
342 | 342 | assert_kind_of Array, custom_fields |
|
343 | 343 | field = custom_fields.detect {|f| f['id'] == '1'} |
|
344 | 344 | assert_kind_of Hash, field |
|
345 | 345 | assert_equal [], field['value'] |
|
346 | 346 | end |
|
347 | 347 | end |
|
348 | 348 | |
|
349 | 349 | context ".json" do |
|
350 | 350 | should "display custom fields" do |
|
351 | 351 | get '/issues/3.json' |
|
352 | 352 | assert_response :success |
|
353 | 353 | json = ActiveSupport::JSON.decode(response.body) |
|
354 | 354 | custom_fields = json['issue']['custom_fields'] |
|
355 | 355 | assert_kind_of Array, custom_fields |
|
356 | 356 | field = custom_fields.detect {|f| f['id'] == 1} |
|
357 | 357 | assert_kind_of Hash, field |
|
358 | 358 | assert_equal [], field['value'].sort |
|
359 | 359 | end |
|
360 | 360 | end |
|
361 | 361 | end |
|
362 | 362 | |
|
363 | 363 | context "with attachments" do |
|
364 | 364 | context ".xml" do |
|
365 | 365 | should "display attachments" do |
|
366 | 366 | get '/issues/3.xml?include=attachments' |
|
367 | 367 | |
|
368 | 368 | assert_tag :tag => 'issue', |
|
369 | 369 | :child => { |
|
370 | 370 | :tag => 'attachments', |
|
371 | 371 | :children => {:count => 5}, |
|
372 | 372 | :child => { |
|
373 | 373 | :tag => 'attachment', |
|
374 | 374 | :child => { |
|
375 | 375 | :tag => 'filename', |
|
376 | 376 | :content => 'source.rb', |
|
377 | 377 | :sibling => { |
|
378 | 378 | :tag => 'content_url', |
|
379 | 379 | :content => 'http://www.example.com/attachments/download/4/source.rb' |
|
380 | 380 | } |
|
381 | 381 | } |
|
382 | 382 | } |
|
383 | 383 | } |
|
384 | 384 | end |
|
385 | 385 | end |
|
386 | 386 | end |
|
387 | 387 | |
|
388 | 388 | context "with subtasks" do |
|
389 | 389 | setup do |
|
390 | 390 | @c1 = Issue.create!(:status_id => 1, :subject => "child c1", :tracker_id => 1, :project_id => 1, :author_id => 1, :parent_issue_id => 1) |
|
391 | 391 | @c2 = Issue.create!(:status_id => 1, :subject => "child c2", :tracker_id => 1, :project_id => 1, :author_id => 1, :parent_issue_id => 1) |
|
392 | 392 | @c3 = Issue.create!(:status_id => 1, :subject => "child c3", :tracker_id => 1, :project_id => 1, :author_id => 1, :parent_issue_id => @c1.id) |
|
393 | 393 | end |
|
394 | 394 | |
|
395 | 395 | context ".xml" do |
|
396 | 396 | should "display children" do |
|
397 | 397 | get '/issues/1.xml?include=children' |
|
398 | 398 | |
|
399 | 399 | assert_tag :tag => 'issue', |
|
400 | 400 | :child => { |
|
401 | 401 | :tag => 'children', |
|
402 | 402 | :children => {:count => 2}, |
|
403 | 403 | :child => { |
|
404 | 404 | :tag => 'issue', |
|
405 | 405 | :attributes => {:id => @c1.id.to_s}, |
|
406 | 406 | :child => { |
|
407 | 407 | :tag => 'subject', |
|
408 | 408 | :content => 'child c1', |
|
409 | 409 | :sibling => { |
|
410 | 410 | :tag => 'children', |
|
411 | 411 | :children => {:count => 1}, |
|
412 | 412 | :child => { |
|
413 | 413 | :tag => 'issue', |
|
414 | 414 | :attributes => {:id => @c3.id.to_s} |
|
415 | 415 | } |
|
416 | 416 | } |
|
417 | 417 | } |
|
418 | 418 | } |
|
419 | 419 | } |
|
420 | 420 | end |
|
421 | 421 | |
|
422 | 422 | context ".json" do |
|
423 | 423 | should "display children" do |
|
424 | 424 | get '/issues/1.json?include=children' |
|
425 | 425 | |
|
426 | 426 | json = ActiveSupport::JSON.decode(response.body) |
|
427 | 427 | assert_equal([ |
|
428 | 428 | { |
|
429 | 429 | 'id' => @c1.id, 'subject' => 'child c1', 'tracker' => {'id' => 1, 'name' => 'Bug'}, |
|
430 | 430 | 'children' => [{ 'id' => @c3.id, 'subject' => 'child c3', 'tracker' => {'id' => 1, 'name' => 'Bug'} }] |
|
431 | 431 | }, |
|
432 | 432 | { 'id' => @c2.id, 'subject' => 'child c2', 'tracker' => {'id' => 1, 'name' => 'Bug'} } |
|
433 | 433 | ], |
|
434 | 434 | json['issue']['children']) |
|
435 | 435 | end |
|
436 | 436 | end |
|
437 | 437 | end |
|
438 | 438 | end |
|
439 | 439 | end |
|
440 | 440 | |
|
441 | 441 | context "POST /issues.xml" do |
|
442 | 442 | should_allow_api_authentication(:post, |
|
443 | 443 | '/issues.xml', |
|
444 | 444 | {:issue => {:project_id => 1, :subject => 'API test', :tracker_id => 2, :status_id => 3}}, |
|
445 | 445 | {:success_code => :created}) |
|
446 | 446 | |
|
447 | 447 | should "create an issue with the attributes" do |
|
448 | 448 | assert_difference('Issue.count') do |
|
449 | 449 | post '/issues.xml', {:issue => {:project_id => 1, :subject => 'API test', :tracker_id => 2, :status_id => 3}}, credentials('jsmith') |
|
450 | 450 | end |
|
451 | 451 | |
|
452 | 452 | issue = Issue.first(:order => 'id DESC') |
|
453 | 453 | assert_equal 1, issue.project_id |
|
454 | 454 | assert_equal 2, issue.tracker_id |
|
455 | 455 | assert_equal 3, issue.status_id |
|
456 | 456 | assert_equal 'API test', issue.subject |
|
457 | 457 | |
|
458 | 458 | assert_response :created |
|
459 | 459 | assert_equal 'application/xml', @response.content_type |
|
460 | 460 | assert_tag 'issue', :child => {:tag => 'id', :content => issue.id.to_s} |
|
461 | 461 | end |
|
462 | 462 | end |
|
463 | 463 | |
|
464 | 464 | context "POST /issues.xml with failure" do |
|
465 | 465 | should "have an errors tag" do |
|
466 | 466 | assert_no_difference('Issue.count') do |
|
467 | 467 | post '/issues.xml', {:issue => {:project_id => 1}}, credentials('jsmith') |
|
468 | 468 | end |
|
469 | 469 | |
|
470 | 470 | assert_tag :errors, :child => {:tag => 'error', :content => "Subject can't be blank"} |
|
471 | 471 | end |
|
472 | 472 | end |
|
473 | 473 | |
|
474 | 474 | context "POST /issues.json" do |
|
475 | 475 | should_allow_api_authentication(:post, |
|
476 | 476 | '/issues.json', |
|
477 | 477 | {:issue => {:project_id => 1, :subject => 'API test', :tracker_id => 2, :status_id => 3}}, |
|
478 | 478 | {:success_code => :created}) |
|
479 | 479 | |
|
480 | 480 | should "create an issue with the attributes" do |
|
481 | 481 | assert_difference('Issue.count') do |
|
482 | 482 | post '/issues.json', {:issue => {:project_id => 1, :subject => 'API test', :tracker_id => 2, :status_id => 3}}, credentials('jsmith') |
|
483 | 483 | end |
|
484 | 484 | |
|
485 | 485 | issue = Issue.first(:order => 'id DESC') |
|
486 | 486 | assert_equal 1, issue.project_id |
|
487 | 487 | assert_equal 2, issue.tracker_id |
|
488 | 488 | assert_equal 3, issue.status_id |
|
489 | 489 | assert_equal 'API test', issue.subject |
|
490 | 490 | end |
|
491 | 491 | |
|
492 | 492 | end |
|
493 | 493 | |
|
494 | 494 | context "POST /issues.json with failure" do |
|
495 | 495 | should "have an errors element" do |
|
496 | 496 | assert_no_difference('Issue.count') do |
|
497 | 497 | post '/issues.json', {:issue => {:project_id => 1}}, credentials('jsmith') |
|
498 | 498 | end |
|
499 | 499 | |
|
500 | 500 | json = ActiveSupport::JSON.decode(response.body) |
|
501 | 501 | assert json['errors'].include?("Subject can't be blank") |
|
502 | 502 | end |
|
503 | 503 | end |
|
504 | 504 | |
|
505 | 505 | # Issue 6 is on a private project |
|
506 | 506 | context "PUT /issues/6.xml" do |
|
507 | 507 | setup do |
|
508 | 508 | @parameters = {:issue => {:subject => 'API update', :notes => 'A new note'}} |
|
509 | 509 | end |
|
510 | 510 | |
|
511 | 511 | should_allow_api_authentication(:put, |
|
512 | 512 | '/issues/6.xml', |
|
513 | 513 | {:issue => {:subject => 'API update', :notes => 'A new note'}}, |
|
514 | 514 | {:success_code => :ok}) |
|
515 | 515 | |
|
516 | 516 | should "not create a new issue" do |
|
517 | 517 | assert_no_difference('Issue.count') do |
|
518 | 518 | put '/issues/6.xml', @parameters, credentials('jsmith') |
|
519 | 519 | end |
|
520 | 520 | end |
|
521 | 521 | |
|
522 | 522 | should "create a new journal" do |
|
523 | 523 | assert_difference('Journal.count') do |
|
524 | 524 | put '/issues/6.xml', @parameters, credentials('jsmith') |
|
525 | 525 | end |
|
526 | 526 | end |
|
527 | 527 | |
|
528 | 528 | should "add the note to the journal" do |
|
529 | 529 | put '/issues/6.xml', @parameters, credentials('jsmith') |
|
530 | 530 | |
|
531 | 531 | journal = Journal.last |
|
532 | 532 | assert_equal "A new note", journal.notes |
|
533 | 533 | end |
|
534 | 534 | |
|
535 | 535 | should "update the issue" do |
|
536 | 536 | put '/issues/6.xml', @parameters, credentials('jsmith') |
|
537 | 537 | |
|
538 | 538 | issue = Issue.find(6) |
|
539 | 539 | assert_equal "API update", issue.subject |
|
540 | 540 | end |
|
541 | 541 | |
|
542 | 542 | end |
|
543 | 543 | |
|
544 | 544 | context "PUT /issues/3.xml with custom fields" do |
|
545 | 545 | setup do |
|
546 | 546 | @parameters = {:issue => {:custom_fields => [{'id' => '1', 'value' => 'PostgreSQL' }, {'id' => '2', 'value' => '150'}]}} |
|
547 | 547 | end |
|
548 | 548 | |
|
549 | 549 | should "update custom fields" do |
|
550 | 550 | assert_no_difference('Issue.count') do |
|
551 | 551 | put '/issues/3.xml', @parameters, credentials('jsmith') |
|
552 | 552 | end |
|
553 | 553 | |
|
554 | 554 | issue = Issue.find(3) |
|
555 | 555 | assert_equal '150', issue.custom_value_for(2).value |
|
556 | 556 | assert_equal 'PostgreSQL', issue.custom_value_for(1).value |
|
557 | 557 | end |
|
558 | 558 | end |
|
559 | 559 | |
|
560 | 560 | context "PUT /issues/3.xml with multi custom fields" do |
|
561 | 561 | setup do |
|
562 | 562 | field = CustomField.find(1) |
|
563 | 563 | field.update_attribute :multiple, true |
|
564 | 564 | @parameters = {:issue => {:custom_fields => [{'id' => '1', 'value' => ['MySQL', 'PostgreSQL'] }, {'id' => '2', 'value' => '150'}]}} |
|
565 | 565 | end |
|
566 | 566 | |
|
567 | 567 | should "update custom fields" do |
|
568 | 568 | assert_no_difference('Issue.count') do |
|
569 | 569 | put '/issues/3.xml', @parameters, credentials('jsmith') |
|
570 | 570 | end |
|
571 | 571 | |
|
572 | 572 | issue = Issue.find(3) |
|
573 | 573 | assert_equal '150', issue.custom_value_for(2).value |
|
574 | 574 | assert_equal ['MySQL', 'PostgreSQL'], issue.custom_field_value(1).sort |
|
575 | 575 | end |
|
576 | 576 | end |
|
577 | 577 | |
|
578 | 578 | context "PUT /issues/3.xml with project change" do |
|
579 | 579 | setup do |
|
580 | 580 | @parameters = {:issue => {:project_id => 2, :subject => 'Project changed'}} |
|
581 | 581 | end |
|
582 | 582 | |
|
583 | 583 | should "update project" do |
|
584 | 584 | assert_no_difference('Issue.count') do |
|
585 | 585 | put '/issues/3.xml', @parameters, credentials('jsmith') |
|
586 | 586 | end |
|
587 | 587 | |
|
588 | 588 | issue = Issue.find(3) |
|
589 | 589 | assert_equal 2, issue.project_id |
|
590 | 590 | assert_equal 'Project changed', issue.subject |
|
591 | 591 | end |
|
592 | 592 | end |
|
593 | 593 | |
|
594 | 594 | context "PUT /issues/6.xml with failed update" do |
|
595 | 595 | setup do |
|
596 | 596 | @parameters = {:issue => {:subject => ''}} |
|
597 | 597 | end |
|
598 | 598 | |
|
599 | 599 | should "not create a new issue" do |
|
600 | 600 | assert_no_difference('Issue.count') do |
|
601 | 601 | put '/issues/6.xml', @parameters, credentials('jsmith') |
|
602 | 602 | end |
|
603 | 603 | end |
|
604 | 604 | |
|
605 | 605 | should "not create a new journal" do |
|
606 | 606 | assert_no_difference('Journal.count') do |
|
607 | 607 | put '/issues/6.xml', @parameters, credentials('jsmith') |
|
608 | 608 | end |
|
609 | 609 | end |
|
610 | 610 | |
|
611 | 611 | should "have an errors tag" do |
|
612 | 612 | put '/issues/6.xml', @parameters, credentials('jsmith') |
|
613 | 613 | |
|
614 | 614 | assert_tag :errors, :child => {:tag => 'error', :content => "Subject can't be blank"} |
|
615 | 615 | end |
|
616 | 616 | end |
|
617 | 617 | |
|
618 | 618 | context "PUT /issues/6.json" do |
|
619 | 619 | setup do |
|
620 | 620 | @parameters = {:issue => {:subject => 'API update', :notes => 'A new note'}} |
|
621 | 621 | end |
|
622 | 622 | |
|
623 | 623 | should_allow_api_authentication(:put, |
|
624 | 624 | '/issues/6.json', |
|
625 | 625 | {:issue => {:subject => 'API update', :notes => 'A new note'}}, |
|
626 | 626 | {:success_code => :ok}) |
|
627 | 627 | |
|
628 |
should " |
|
|
628 | should "update the issue" do | |
|
629 | 629 | assert_no_difference('Issue.count') do |
|
630 | put '/issues/6.json', @parameters, credentials('jsmith') | |
|
631 | end | |
|
632 | end | |
|
630 | assert_difference('Journal.count') do | |
|
631 | put '/issues/6.json', @parameters, credentials('jsmith') | |
|
633 | 632 | |
|
634 | should "create a new journal" do | |
|
635 | assert_difference('Journal.count') do | |
|
636 | put '/issues/6.json', @parameters, credentials('jsmith') | |
|
633 | assert_response :ok | |
|
634 | assert_equal '', response.body | |
|
635 | end | |
|
637 | 636 | end |
|
638 | end | |
|
639 | ||
|
640 | should "add the note to the journal" do | |
|
641 | put '/issues/6.json', @parameters, credentials('jsmith') | |
|
642 | ||
|
643 | journal = Journal.last | |
|
644 | assert_equal "A new note", journal.notes | |
|
645 | end | |
|
646 | ||
|
647 | should "update the issue" do | |
|
648 | put '/issues/6.json', @parameters, credentials('jsmith') | |
|
649 | 637 | |
|
650 | 638 | issue = Issue.find(6) |
|
651 | 639 | assert_equal "API update", issue.subject |
|
640 | journal = Journal.last | |
|
641 | assert_equal "A new note", journal.notes | |
|
652 | 642 | end |
|
653 | ||
|
654 | 643 | end |
|
655 | 644 | |
|
656 | 645 | context "PUT /issues/6.json with failed update" do |
|
657 | setup do | |
|
658 | @parameters = {:issue => {:subject => ''}} | |
|
659 | end | |
|
660 | ||
|
661 | should "not create a new issue" do | |
|
646 | should "return errors" do | |
|
662 | 647 | assert_no_difference('Issue.count') do |
|
663 | put '/issues/6.json', @parameters, credentials('jsmith') | |
|
664 | end | |
|
665 | end | |
|
648 | assert_no_difference('Journal.count') do | |
|
649 | put '/issues/6.json', {:issue => {:subject => ''}}, credentials('jsmith') | |
|
666 | 650 | |
|
667 | should "not create a new journal" do | |
|
668 | assert_no_difference('Journal.count') do | |
|
669 | put '/issues/6.json', @parameters, credentials('jsmith') | |
|
651 | assert_response :unprocessable_entity | |
|
652 | end | |
|
670 | 653 | end |
|
671 | end | |
|
672 | ||
|
673 | should "have an errors attribute" do | |
|
674 | put '/issues/6.json', @parameters, credentials('jsmith') | |
|
675 | 654 | |
|
676 | 655 | json = ActiveSupport::JSON.decode(response.body) |
|
677 | 656 | assert json['errors'].include?("Subject can't be blank") |
|
678 | 657 | end |
|
679 | 658 | end |
|
680 | 659 | |
|
681 | 660 | context "DELETE /issues/1.xml" do |
|
682 | 661 | should_allow_api_authentication(:delete, |
|
683 | 662 | '/issues/6.xml', |
|
684 | 663 | {}, |
|
685 | 664 | {:success_code => :ok}) |
|
686 | 665 | |
|
687 | 666 | should "delete the issue" do |
|
688 | assert_difference('Issue.count',-1) do | |
|
667 | assert_difference('Issue.count', -1) do | |
|
689 | 668 | delete '/issues/6.xml', {}, credentials('jsmith') |
|
669 | ||
|
670 | assert_response :ok | |
|
671 | assert_equal '', response.body | |
|
690 | 672 | end |
|
691 | 673 | |
|
692 | 674 | assert_nil Issue.find_by_id(6) |
|
693 | 675 | end |
|
694 | 676 | end |
|
695 | 677 | |
|
696 | 678 | context "DELETE /issues/1.json" do |
|
697 | 679 | should_allow_api_authentication(:delete, |
|
698 | 680 | '/issues/6.json', |
|
699 | 681 | {}, |
|
700 | 682 | {:success_code => :ok}) |
|
701 | 683 | |
|
702 | 684 | should "delete the issue" do |
|
703 | assert_difference('Issue.count',-1) do | |
|
685 | assert_difference('Issue.count', -1) do | |
|
704 | 686 | delete '/issues/6.json', {}, credentials('jsmith') |
|
687 | ||
|
688 | assert_response :ok | |
|
689 | assert_equal '', response.body | |
|
705 | 690 | end |
|
706 | 691 | |
|
707 | 692 | assert_nil Issue.find_by_id(6) |
|
708 | 693 | end |
|
709 | 694 | end |
|
710 | 695 | |
|
711 | 696 | def test_create_issue_with_uploaded_file |
|
712 | 697 | set_tmp_attachments_directory |
|
713 | 698 | |
|
714 | 699 | # upload the file |
|
715 | 700 | assert_difference 'Attachment.count' do |
|
716 | 701 | post '/uploads.xml', 'test_create_with_upload', {"CONTENT_TYPE" => 'application/octet-stream'}.merge(credentials('jsmith')) |
|
717 | 702 | assert_response :created |
|
718 | 703 | end |
|
719 | 704 | xml = Hash.from_xml(response.body) |
|
720 | 705 | token = xml['upload']['token'] |
|
721 | 706 | attachment = Attachment.first(:order => 'id DESC') |
|
722 | 707 | |
|
723 | 708 | # create the issue with the upload's token |
|
724 | 709 | assert_difference 'Issue.count' do |
|
725 | 710 | post '/issues.xml', |
|
726 | 711 | {:issue => {:project_id => 1, :subject => 'Uploaded file', :uploads => [{:token => token, :filename => 'test.txt', :content_type => 'text/plain'}]}}, |
|
727 | 712 | credentials('jsmith') |
|
728 | 713 | assert_response :created |
|
729 | 714 | end |
|
730 | 715 | issue = Issue.first(:order => 'id DESC') |
|
731 | 716 | assert_equal 1, issue.attachments.count |
|
732 | 717 | assert_equal attachment, issue.attachments.first |
|
733 | 718 | |
|
734 | 719 | attachment.reload |
|
735 | 720 | assert_equal 'test.txt', attachment.filename |
|
736 | 721 | assert_equal 'text/plain', attachment.content_type |
|
737 | 722 | assert_equal 'test_create_with_upload'.size, attachment.filesize |
|
738 | 723 | assert_equal 2, attachment.author_id |
|
739 | 724 | |
|
740 | 725 | # get the issue with its attachments |
|
741 | 726 | get "/issues/#{issue.id}.xml", :include => 'attachments' |
|
742 | 727 | assert_response :success |
|
743 | 728 | xml = Hash.from_xml(response.body) |
|
744 | 729 | attachments = xml['issue']['attachments'] |
|
745 | 730 | assert_kind_of Array, attachments |
|
746 | 731 | assert_equal 1, attachments.size |
|
747 | 732 | url = attachments.first['content_url'] |
|
748 | 733 | assert_not_nil url |
|
749 | 734 | |
|
750 | 735 | # download the attachment |
|
751 | 736 | get url |
|
752 | 737 | assert_response :success |
|
753 | 738 | end |
|
754 | 739 | |
|
755 | 740 | def test_update_issue_with_uploaded_file |
|
756 | 741 | set_tmp_attachments_directory |
|
757 | 742 | |
|
758 | 743 | # upload the file |
|
759 | 744 | assert_difference 'Attachment.count' do |
|
760 | 745 | post '/uploads.xml', 'test_upload_with_upload', {"CONTENT_TYPE" => 'application/octet-stream'}.merge(credentials('jsmith')) |
|
761 | 746 | assert_response :created |
|
762 | 747 | end |
|
763 | 748 | xml = Hash.from_xml(response.body) |
|
764 | 749 | token = xml['upload']['token'] |
|
765 | 750 | attachment = Attachment.first(:order => 'id DESC') |
|
766 | 751 | |
|
767 | 752 | # update the issue with the upload's token |
|
768 | 753 | assert_difference 'Journal.count' do |
|
769 | 754 | put '/issues/1.xml', |
|
770 | 755 | {:issue => {:notes => 'Attachment added', :uploads => [{:token => token, :filename => 'test.txt', :content_type => 'text/plain'}]}}, |
|
771 | 756 | credentials('jsmith') |
|
772 | 757 | assert_response :ok |
|
773 | 758 | assert_equal '', @response.body |
|
774 | 759 | end |
|
775 | 760 | |
|
776 | 761 | issue = Issue.find(1) |
|
777 | 762 | assert_include attachment, issue.attachments |
|
778 | 763 | end |
|
779 | 764 | end |
General Comments 0
You need to be logged in to leave comments.
Login now