jro_apps/redmine Commit - r9793:54d55a360a21

Adds assertions on response status and body....

Jean-Philippe Lang -

r9793:54d55a360a21

parent child

Context file:

r9793:54d55a360a21

Collapse all files

test/integration/api_test/issues_test.rb +21 -36

                                                 {:issue => {:subject => 'API update', :notes => 'A new note'}},
                                                 {:success_code => :ok})
-                should "not create a new issue" do
+                should "update the issue" do
                   assert_no_difference('Issue.count') do
-                    put '/issues/6.json', @parameters, credentials('jsmith')
+                    assert_difference('Journal.count') do
-                  end
+                      put '/issues/6.json', @parameters, credentials('jsmith')
-                end
-                should "create a new journal" do
+                      assert_response :ok
-                  assert_difference('Journal.count') do
+                      assert_equal '', response.body
-                    put '/issues/6.json', @parameters, credentials('jsmith')
+                    end
                   end
-                end
-                should "add the note to the journal" do
-                  put '/issues/6.json', @parameters, credentials('jsmith')
-                  journal = Journal.last
-                  assert_equal "A new note", journal.notes
-                end
-                should "update the issue" do
-                  put '/issues/6.json', @parameters, credentials('jsmith')
                   issue = Issue.find(6)
                   assert_equal "API update", issue.subject
+                  journal = Journal.last
+                  assert_equal "A new note", journal.notes
                 end
               end
               context "PUT /issues/6.json with failed update" do
-                setup do
+                should "return errors" do
-                  @parameters = {:issue => {:subject => ''}}
-                end
-                should "not create a new issue" do
                   assert_no_difference('Issue.count') do
-                    put '/issues/6.json', @parameters, credentials('jsmith')
+                    assert_no_difference('Journal.count') do
-                  end
+                      put '/issues/6.json', {:issue => {:subject => ''}}, credentials('jsmith')
-                end
-                should "not create a new journal" do
+                      assert_response :unprocessable_entity
-                  assert_no_difference('Journal.count') do
+                    end
-                    put '/issues/6.json', @parameters, credentials('jsmith')
                   end
-                end
-                should "have an errors attribute" do
-                  put '/issues/6.json', @parameters, credentials('jsmith')
                   json = ActiveSupport::JSON.decode(response.body)
                   assert json['errors'].include?("Subject can't be blank")
                                                 {:success_code => :ok})
                 should "delete the issue" do
-                  assert_difference('Issue.count',-1) do
+                  assert_difference('Issue.count', -1) do
                     delete '/issues/6.xml', {}, credentials('jsmith')
+                    assert_response :ok
+                    assert_equal '', response.body
                   end
                   assert_nil Issue.find_by_id(6)
                                                 {:success_code => :ok})
                 should "delete the issue" do
-                  assert_difference('Issue.count',-1) do
+                  assert_difference('Issue.count', -1) do
                     delete '/issues/6.json', {}, credentials('jsmith')
+                    assert_response :ok
+                    assert_equal '', response.body
                   end
                   assert_nil Issue.find_by_id(6)

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages