##// END OF EJS Templates
jro_apps » redmine
RSS
Rails3: model: replace deprecated errors.add_to_base at validate_issue_relation of IssueRelation...
Toshi MARUYAMA -
r7496:54d553b27f93
parent child
Show More
Side by Side Unified
Context file:
r7496:54d553b27f93 Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,142 +1,142
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class IssueRelation < ActiveRecord::Base
19 19 belongs_to :issue_from, :class_name => 'Issue', :foreign_key => 'issue_from_id'
20 20 belongs_to :issue_to, :class_name => 'Issue', :foreign_key => 'issue_to_id'
21 21
22 22 TYPE_RELATES = "relates"
23 23 TYPE_DUPLICATES = "duplicates"
24 24 TYPE_DUPLICATED = "duplicated"
25 25 TYPE_BLOCKS = "blocks"
26 26 TYPE_BLOCKED = "blocked"
27 27 TYPE_PRECEDES = "precedes"
28 28 TYPE_FOLLOWS = "follows"
29 29
30 30 TYPES = { TYPE_RELATES => { :name => :label_relates_to, :sym_name => :label_relates_to, :order => 1, :sym => TYPE_RELATES },
31 31 TYPE_DUPLICATES => { :name => :label_duplicates, :sym_name => :label_duplicated_by, :order => 2, :sym => TYPE_DUPLICATED },
32 32 TYPE_DUPLICATED => { :name => :label_duplicated_by, :sym_name => :label_duplicates, :order => 3, :sym => TYPE_DUPLICATES, :reverse => TYPE_DUPLICATES },
33 33 TYPE_BLOCKS => { :name => :label_blocks, :sym_name => :label_blocked_by, :order => 4, :sym => TYPE_BLOCKED },
34 34 TYPE_BLOCKED => { :name => :label_blocked_by, :sym_name => :label_blocks, :order => 5, :sym => TYPE_BLOCKS, :reverse => TYPE_BLOCKS },
35 35 TYPE_PRECEDES => { :name => :label_precedes, :sym_name => :label_follows, :order => 6, :sym => TYPE_FOLLOWS },
36 36 TYPE_FOLLOWS => { :name => :label_follows, :sym_name => :label_precedes, :order => 7, :sym => TYPE_PRECEDES, :reverse => TYPE_PRECEDES }
37 37 }.freeze
38 38
39 39 validates_presence_of :issue_from, :issue_to, :relation_type
40 40 validates_inclusion_of :relation_type, :in => TYPES.keys
41 41 validates_numericality_of :delay, :allow_nil => true
42 42 validates_uniqueness_of :issue_to_id, :scope => :issue_from_id
43 43
44 44 validate :validate_issue_relation
45 45
46 46 attr_protected :issue_from_id, :issue_to_id
47 47
48 48 before_save :handle_issue_order
49 49
50 50 def visible?(user=User.current)
51 51 (issue_from.nil? || issue_from.visible?(user)) && (issue_to.nil? || issue_to.visible?(user))
52 52 end
53 53
54 54 def deletable?(user=User.current)
55 55 visible?(user) &&
56 56 ((issue_from.nil? || user.allowed_to?(:manage_issue_relations, issue_from.project)) ||
57 57 (issue_to.nil? || user.allowed_to?(:manage_issue_relations, issue_to.project)))
58 58 end
59 59
60 60 def after_initialize
61 61 if new_record?
62 62 if relation_type.blank?
63 63 self.relation_type = IssueRelation::TYPE_RELATES
64 64 end
65 65 end
66 66 end
67 67
68 68 def validate_issue_relation
69 69 if issue_from && issue_to
70 70 errors.add :issue_to_id, :invalid if issue_from_id == issue_to_id
71 71 errors.add :issue_to_id, :not_same_project unless issue_from.project_id == issue_to.project_id || Setting.cross_project_issue_relations?
72 72 #detect circular dependencies depending wether the relation should be reversed
73 73 if TYPES.has_key?(relation_type) && TYPES[relation_type][:reverse]
74 errors.add_to_base :circular_dependency if issue_from.all_dependent_issues.include? issue_to
74 errors.add :base, :circular_dependency if issue_from.all_dependent_issues.include? issue_to
75 75 else
76 errors.add_to_base :circular_dependency if issue_to.all_dependent_issues.include? issue_from
76 errors.add :base, :circular_dependency if issue_to.all_dependent_issues.include? issue_from
77 77 end
78 errors.add_to_base :cant_link_an_issue_with_a_descendant if issue_from.is_descendant_of?(issue_to) || issue_from.is_ancestor_of?(issue_to)
78 errors.add :base, :cant_link_an_issue_with_a_descendant if issue_from.is_descendant_of?(issue_to) || issue_from.is_ancestor_of?(issue_to)
79 79 end
80 80 end
81 81
82 82 def other_issue(issue)
83 83 (self.issue_from_id == issue.id) ? issue_to : issue_from
84 84 end
85 85
86 86 # Returns the relation type for +issue+
87 87 def relation_type_for(issue)
88 88 if TYPES[relation_type]
89 89 if self.issue_from_id == issue.id
90 90 relation_type
91 91 else
92 92 TYPES[relation_type][:sym]
93 93 end
94 94 end
95 95 end
96 96
97 97 def label_for(issue)
98 98 TYPES[relation_type] ? TYPES[relation_type][(self.issue_from_id == issue.id) ? :name : :sym_name] : :unknow
99 99 end
100 100
101 101 def handle_issue_order
102 102 reverse_if_needed
103 103
104 104 if TYPE_PRECEDES == relation_type
105 105 self.delay ||= 0
106 106 else
107 107 self.delay = nil
108 108 end
109 109 set_issue_to_dates
110 110 end
111 111
112 112 def set_issue_to_dates
113 113 soonest_start = self.successor_soonest_start
114 114 if soonest_start && issue_to
115 115 issue_to.reschedule_after(soonest_start)
116 116 end
117 117 end
118 118
119 119 def successor_soonest_start
120 120 if (TYPE_PRECEDES == self.relation_type) && delay && issue_from && (issue_from.start_date || issue_from.due_date)
121 121 (issue_from.due_date || issue_from.start_date) + 1 + delay
122 122 end
123 123 end
124 124
125 125 def <=>(relation)
126 126 TYPES[self.relation_type][:order] <=> TYPES[relation.relation_type][:order]
127 127 end
128 128
129 129 private
130 130
131 131 # Reverses the relation if needed so that it gets stored in the proper way
132 132 # Should not be reversed before validation so that it can be displayed back
133 133 # as entered on new relation form
134 134 def reverse_if_needed
135 135 if TYPES.has_key?(relation_type) && TYPES[relation_type][:reverse]
136 136 issue_tmp = issue_to
137 137 self.issue_to = issue_from
138 138 self.issue_from = issue_tmp
139 139 self.relation_type = TYPES[relation_type][:reverse]
140 140 end
141 141 end
142 142 end
General Comments 0
You need to be logged in to leave comments. Login now