##// END OF EJS Templates
Rails3: replace deprecated 'validate' method at CustomField model....
Toshi MARUYAMA -
r6792:545c4fa6c91e
parent child
Show More
@@ -1,159 +1,161
1 # Redmine - project management software
1 # Redmine - project management software
2 # Copyright (C) 2006-2011 Jean-Philippe Lang
2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 #
3 #
4 # This program is free software; you can redistribute it and/or
4 # This program is free software; you can redistribute it and/or
5 # modify it under the terms of the GNU General Public License
5 # modify it under the terms of the GNU General Public License
6 # as published by the Free Software Foundation; either version 2
6 # as published by the Free Software Foundation; either version 2
7 # of the License, or (at your option) any later version.
7 # of the License, or (at your option) any later version.
8 #
8 #
9 # This program is distributed in the hope that it will be useful,
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
12 # GNU General Public License for more details.
13 #
13 #
14 # You should have received a copy of the GNU General Public License
14 # You should have received a copy of the GNU General Public License
15 # along with this program; if not, write to the Free Software
15 # along with this program; if not, write to the Free Software
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17
17
18 class CustomField < ActiveRecord::Base
18 class CustomField < ActiveRecord::Base
19 has_many :custom_values, :dependent => :delete_all
19 has_many :custom_values, :dependent => :delete_all
20 acts_as_list :scope => 'type = \'#{self.class}\''
20 acts_as_list :scope => 'type = \'#{self.class}\''
21 serialize :possible_values
21 serialize :possible_values
22
22
23 validates_presence_of :name, :field_format
23 validates_presence_of :name, :field_format
24 validates_uniqueness_of :name, :scope => :type
24 validates_uniqueness_of :name, :scope => :type
25 validates_length_of :name, :maximum => 30
25 validates_length_of :name, :maximum => 30
26 validates_inclusion_of :field_format, :in => Redmine::CustomFieldFormat.available_formats
26 validates_inclusion_of :field_format, :in => Redmine::CustomFieldFormat.available_formats
27
27
28 validate :validate_values
29
28 def initialize(attributes = nil)
30 def initialize(attributes = nil)
29 super
31 super
30 self.possible_values ||= []
32 self.possible_values ||= []
31 end
33 end
32
34
33 def before_validation
35 def before_validation
34 # make sure these fields are not searchable
36 # make sure these fields are not searchable
35 self.searchable = false if %w(int float date bool).include?(field_format)
37 self.searchable = false if %w(int float date bool).include?(field_format)
36 true
38 true
37 end
39 end
38
40
39 def validate
41 def validate_values
40 if self.field_format == "list"
42 if self.field_format == "list"
41 errors.add(:possible_values, :blank) if self.possible_values.nil? || self.possible_values.empty?
43 errors.add(:possible_values, :blank) if self.possible_values.nil? || self.possible_values.empty?
42 errors.add(:possible_values, :invalid) unless self.possible_values.is_a? Array
44 errors.add(:possible_values, :invalid) unless self.possible_values.is_a? Array
43 end
45 end
44
46
45 if regexp.present?
47 if regexp.present?
46 begin
48 begin
47 Regexp.new(regexp)
49 Regexp.new(regexp)
48 rescue
50 rescue
49 errors.add(:regexp, :invalid)
51 errors.add(:regexp, :invalid)
50 end
52 end
51 end
53 end
52
54
53 # validate default value
55 # validate default value
54 v = CustomValue.new(:custom_field => self.clone, :value => default_value, :customized => nil)
56 v = CustomValue.new(:custom_field => self.clone, :value => default_value, :customized => nil)
55 v.custom_field.is_required = false
57 v.custom_field.is_required = false
56 errors.add(:default_value, :invalid) unless v.valid?
58 errors.add(:default_value, :invalid) unless v.valid?
57 end
59 end
58
60
59 def possible_values_options(obj=nil)
61 def possible_values_options(obj=nil)
60 case field_format
62 case field_format
61 when 'user', 'version'
63 when 'user', 'version'
62 if obj.respond_to?(:project) && obj.project
64 if obj.respond_to?(:project) && obj.project
63 case field_format
65 case field_format
64 when 'user'
66 when 'user'
65 obj.project.users.sort.collect {|u| [u.to_s, u.id.to_s]}
67 obj.project.users.sort.collect {|u| [u.to_s, u.id.to_s]}
66 when 'version'
68 when 'version'
67 obj.project.versions.sort.collect {|u| [u.to_s, u.id.to_s]}
69 obj.project.versions.sort.collect {|u| [u.to_s, u.id.to_s]}
68 end
70 end
69 elsif obj.is_a?(Array)
71 elsif obj.is_a?(Array)
70 obj.collect {|o| possible_values_options(o)}.inject {|memo, v| memo & v}
72 obj.collect {|o| possible_values_options(o)}.inject {|memo, v| memo & v}
71 else
73 else
72 []
74 []
73 end
75 end
74 else
76 else
75 read_attribute :possible_values
77 read_attribute :possible_values
76 end
78 end
77 end
79 end
78
80
79 def possible_values(obj=nil)
81 def possible_values(obj=nil)
80 case field_format
82 case field_format
81 when 'user', 'version'
83 when 'user', 'version'
82 possible_values_options(obj).collect(&:last)
84 possible_values_options(obj).collect(&:last)
83 else
85 else
84 read_attribute :possible_values
86 read_attribute :possible_values
85 end
87 end
86 end
88 end
87
89
88 # Makes possible_values accept a multiline string
90 # Makes possible_values accept a multiline string
89 def possible_values=(arg)
91 def possible_values=(arg)
90 if arg.is_a?(Array)
92 if arg.is_a?(Array)
91 write_attribute(:possible_values, arg.compact.collect(&:strip).select {|v| !v.blank?})
93 write_attribute(:possible_values, arg.compact.collect(&:strip).select {|v| !v.blank?})
92 else
94 else
93 self.possible_values = arg.to_s.split(/[\n\r]+/)
95 self.possible_values = arg.to_s.split(/[\n\r]+/)
94 end
96 end
95 end
97 end
96
98
97 def cast_value(value)
99 def cast_value(value)
98 casted = nil
100 casted = nil
99 unless value.blank?
101 unless value.blank?
100 case field_format
102 case field_format
101 when 'string', 'text', 'list'
103 when 'string', 'text', 'list'
102 casted = value
104 casted = value
103 when 'date'
105 when 'date'
104 casted = begin; value.to_date; rescue; nil end
106 casted = begin; value.to_date; rescue; nil end
105 when 'bool'
107 when 'bool'
106 casted = (value == '1' ? true : false)
108 casted = (value == '1' ? true : false)
107 when 'int'
109 when 'int'
108 casted = value.to_i
110 casted = value.to_i
109 when 'float'
111 when 'float'
110 casted = value.to_f
112 casted = value.to_f
111 when 'user', 'version'
113 when 'user', 'version'
112 casted = (value.blank? ? nil : field_format.classify.constantize.find_by_id(value.to_i))
114 casted = (value.blank? ? nil : field_format.classify.constantize.find_by_id(value.to_i))
113 end
115 end
114 end
116 end
115 casted
117 casted
116 end
118 end
117
119
118 # Returns a ORDER BY clause that can used to sort customized
120 # Returns a ORDER BY clause that can used to sort customized
119 # objects by their value of the custom field.
121 # objects by their value of the custom field.
120 # Returns false, if the custom field can not be used for sorting.
122 # Returns false, if the custom field can not be used for sorting.
121 def order_statement
123 def order_statement
122 case field_format
124 case field_format
123 when 'string', 'text', 'list', 'date', 'bool'
125 when 'string', 'text', 'list', 'date', 'bool'
124 # COALESCE is here to make sure that blank and NULL values are sorted equally
126 # COALESCE is here to make sure that blank and NULL values are sorted equally
125 "COALESCE((SELECT cv_sort.value FROM #{CustomValue.table_name} cv_sort" +
127 "COALESCE((SELECT cv_sort.value FROM #{CustomValue.table_name} cv_sort" +
126 " WHERE cv_sort.customized_type='#{self.class.customized_class.name}'" +
128 " WHERE cv_sort.customized_type='#{self.class.customized_class.name}'" +
127 " AND cv_sort.customized_id=#{self.class.customized_class.table_name}.id" +
129 " AND cv_sort.customized_id=#{self.class.customized_class.table_name}.id" +
128 " AND cv_sort.custom_field_id=#{id} LIMIT 1), '')"
130 " AND cv_sort.custom_field_id=#{id} LIMIT 1), '')"
129 when 'int', 'float'
131 when 'int', 'float'
130 # Make the database cast values into numeric
132 # Make the database cast values into numeric
131 # Postgresql will raise an error if a value can not be casted!
133 # Postgresql will raise an error if a value can not be casted!
132 # CustomValue validations should ensure that it doesn't occur
134 # CustomValue validations should ensure that it doesn't occur
133 "(SELECT CAST(cv_sort.value AS decimal(60,3)) FROM #{CustomValue.table_name} cv_sort" +
135 "(SELECT CAST(cv_sort.value AS decimal(60,3)) FROM #{CustomValue.table_name} cv_sort" +
134 " WHERE cv_sort.customized_type='#{self.class.customized_class.name}'" +
136 " WHERE cv_sort.customized_type='#{self.class.customized_class.name}'" +
135 " AND cv_sort.customized_id=#{self.class.customized_class.table_name}.id" +
137 " AND cv_sort.customized_id=#{self.class.customized_class.table_name}.id" +
136 " AND cv_sort.custom_field_id=#{id} AND cv_sort.value <> '' AND cv_sort.value IS NOT NULL LIMIT 1)"
138 " AND cv_sort.custom_field_id=#{id} AND cv_sort.value <> '' AND cv_sort.value IS NOT NULL LIMIT 1)"
137 else
139 else
138 nil
140 nil
139 end
141 end
140 end
142 end
141
143
142 def <=>(field)
144 def <=>(field)
143 position <=> field.position
145 position <=> field.position
144 end
146 end
145
147
146 def self.customized_class
148 def self.customized_class
147 self.name =~ /^(.+)CustomField$/
149 self.name =~ /^(.+)CustomField$/
148 begin; $1.constantize; rescue nil; end
150 begin; $1.constantize; rescue nil; end
149 end
151 end
150
152
151 # to move in project_custom_field
153 # to move in project_custom_field
152 def self.for_all
154 def self.for_all
153 find(:all, :conditions => ["is_for_all=?", true], :order => 'position')
155 find(:all, :conditions => ["is_for_all=?", true], :order => 'position')
154 end
156 end
155
157
156 def type_name
158 def type_name
157 nil
159 nil
158 end
160 end
159 end
161 end
General Comments 0
You need to be logged in to leave comments. Login now