jro_apps/redmine Commit - r10690:536747b74708

Replaces find(:all) calls....

Jean-Philippe Lang -

r10690:536747b74708

parent child

Context file:

r10690:536747b74708

Expand all files

app/models/custom_field.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class CustomField < ActiveRecord::Base
               include Redmine::SubclassFactory
               has_many :custom_values, :dependent => :delete_all
               acts_as_list :scope => 'type = \'#{self.class}\''
               serialize :possible_values
               validates_presence_of :name, :field_format
               validates_uniqueness_of :name, :scope => :type
               validates_length_of :name, :maximum => 30
               validates_inclusion_of :field_format, :in => Redmine::CustomFieldFormat.available_formats
               validate :validate_custom_field
               before_validation :set_searchable
               scope :sorted, order("#{table_name}.position ASC")
               CUSTOM_FIELDS_TABS = [
                 {:name => 'IssueCustomField', :partial => 'custom_fields/index',
                  :label => :label_issue_plural},
                 {:name => 'TimeEntryCustomField', :partial => 'custom_fields/index',
                  :label => :label_spent_time},
                 {:name => 'ProjectCustomField', :partial => 'custom_fields/index',
                  :label => :label_project_plural},
                 {:name => 'VersionCustomField', :partial => 'custom_fields/index',
                  :label => :label_version_plural},
                 {:name => 'UserCustomField', :partial => 'custom_fields/index',
                  :label => :label_user_plural},
                 {:name => 'GroupCustomField', :partial => 'custom_fields/index',
                  :label => :label_group_plural},
                 {:name => 'TimeEntryActivityCustomField', :partial => 'custom_fields/index',
                  :label => TimeEntryActivity::OptionName},
                 {:name => 'IssuePriorityCustomField', :partial => 'custom_fields/index',
                  :label => IssuePriority::OptionName},
                 {:name => 'DocumentCategoryCustomField', :partial => 'custom_fields/index',
                  :label => DocumentCategory::OptionName}
               ]
               CUSTOM_FIELDS_NAMES = CUSTOM_FIELDS_TABS.collect{|v| v[:name]}
               def field_format=(arg)
                 # cannot change format of a saved custom field
                 super if new_record?
               end
               def set_searchable
                 # make sure these fields are not searchable
                 self.searchable = false if %w(int float date bool).include?(field_format)
                 # make sure only these fields can have multiple values
                 self.multiple = false unless %w(list user version).include?(field_format)
                 true
               end
               def validate_custom_field
                 if self.field_format == "list"
                   errors.add(:possible_values, :blank) if self.possible_values.nil? || self.possible_values.empty?
                   errors.add(:possible_values, :invalid) unless self.possible_values.is_a? Array
                 end
                 if regexp.present?
                   begin
                     Regexp.new(regexp)
                   rescue
                     errors.add(:regexp, :invalid)
                   end
                 end
                 if default_value.present? && !valid_field_value?(default_value)
                   errors.add(:default_value, :invalid)
                 end
               end
               def possible_values_options(obj=nil)
                 case field_format
                 when 'user', 'version'
                   if obj.respond_to?(:project) && obj.project
                     case field_format
                     when 'user'
                       obj.project.users.sort.collect {|u| [u.to_s, u.id.to_s]}
                     when 'version'
                       obj.project.shared_versions.sort.collect {|u| [u.to_s, u.id.to_s]}
                     end
                   elsif obj.is_a?(Array)
                     obj.collect {|o| possible_values_options(o)}.reduce(:&)
                   else
                     []
                   end
                 when 'bool'
                   [[l(:general_text_Yes), '1'], [l(:general_text_No), '0']]
                 else
                   possible_values || []
                 end
               end
               def possible_values(obj=nil)
                 case field_format
                 when 'user', 'version'
                   possible_values_options(obj).collect(&:last)
                 when 'bool'
                   ['1', '0']
                 else
                   values = super()
                   if values.is_a?(Array)
                     values.each do |value|
                       value.force_encoding('UTF-8') if value.respond_to?(:force_encoding)
                     end
                   end
                   values || []
                 end
               end
               # Makes possible_values accept a multiline string
               def possible_values=(arg)
                 if arg.is_a?(Array)
                   super(arg.compact.collect(&:strip).select {|v| !v.blank?})
                 else
                   self.possible_values = arg.to_s.split(/[\n\r]+/)
                 end
               end
               def cast_value(value)
                 casted = nil
                 unless value.blank?
                   case field_format
                   when 'string', 'text', 'list'
                     casted = value
                   when 'date'
                     casted = begin; value.to_date; rescue; nil end
                   when 'bool'
                     casted = (value == '1' ? true : false)
                   when 'int'
                     casted = value.to_i
                   when 'float'
                     casted = value.to_f
                   when 'user', 'version'
                     casted = (value.blank? ? nil : field_format.classify.constantize.find_by_id(value.to_i))
                   end
                 end
                 casted
               end
               def value_from_keyword(keyword, customized)
                 possible_values_options = possible_values_options(customized)
                 if possible_values_options.present?
                   keyword = keyword.to_s.downcase
                   possible_values_options.detect {|text, id| text.downcase == keyword}.try(:last)
                 else
                   keyword
                 end
               end
               # Returns a ORDER BY clause that can used to sort customized
               # objects by their value of the custom field.
               # Returns nil if the custom field can not be used for sorting.
               def order_statement
                 return nil if multiple?
                 case field_format
                   when 'string', 'text', 'list', 'date', 'bool'
                     # COALESCE is here to make sure that blank and NULL values are sorted equally
                     "COALESCE((SELECT cv_sort.value FROM #{CustomValue.table_name} cv_sort" +
                       " WHERE cv_sort.customized_type='#{self.class.customized_class.base_class.name}'" +
                       " AND cv_sort.customized_id=#{self.class.customized_class.table_name}.id" +
                       " AND cv_sort.custom_field_id=#{id} LIMIT 1), '')"
                   when 'int', 'float'
                     # Make the database cast values into numeric
                     # Postgresql will raise an error if a value can not be casted!
                     # CustomValue validations should ensure that it doesn't occur
                     "(SELECT CAST(cv_sort.value AS decimal(60,3)) FROM #{CustomValue.table_name} cv_sort" +
                       " WHERE cv_sort.customized_type='#{self.class.customized_class.base_class.name}'" +
                       " AND cv_sort.customized_id=#{self.class.customized_class.table_name}.id" +
                       " AND cv_sort.custom_field_id=#{id} AND cv_sort.value <> '' AND cv_sort.value IS NOT NULL LIMIT 1)"
                   when 'user', 'version'
                     value_class.fields_for_order_statement(value_join_alias)
                   else
                     nil
                 end
               end
               # Returns a GROUP BY clause that can used to group by custom value
               # Returns nil if the custom field can not be used for grouping.
               def group_statement
                 return nil if multiple?
                 case field_format
                   when 'list', 'date', 'bool', 'int'
                     order_statement
                   when 'user', 'version'
                     "COALESCE((SELECT cv_sort.value FROM #{CustomValue.table_name} cv_sort" +
                       " WHERE cv_sort.customized_type='#{self.class.customized_class.base_class.name}'" +
                       " AND cv_sort.customized_id=#{self.class.customized_class.table_name}.id" +
                       " AND cv_sort.custom_field_id=#{id} LIMIT 1), '')"
                   else
                     nil
                 end
               end
               def join_for_order_statement
                 case field_format
                   when 'user', 'version'
                     "LEFT OUTER JOIN #{CustomValue.table_name} #{join_alias}" +
                       " ON #{join_alias}.customized_type = '#{self.class.customized_class.base_class.name}'" +
                       " AND #{join_alias}.customized_id = #{self.class.customized_class.table_name}.id" +
                       " AND #{join_alias}.custom_field_id = #{id}" +
                       " AND #{join_alias}.value <> ''" +
                       " AND #{join_alias}.id = (SELECT max(#{join_alias}_2.id) FROM #{CustomValue.table_name} #{join_alias}_2" +
                         " WHERE #{join_alias}_2.customized_type = #{join_alias}.customized_type" +
                         " AND #{join_alias}_2.customized_id = #{join_alias}.customized_id" +
                         " AND #{join_alias}_2.custom_field_id = #{join_alias}.custom_field_id)" +
                       " LEFT OUTER JOIN #{value_class.table_name} #{value_join_alias}" +
                       " ON CAST(#{join_alias}.value as decimal(60,0)) = #{value_join_alias}.id"
                   else
                     nil
                 end
               end
               def join_alias
                 "cf_#{id}"
               end
               def value_join_alias
                 join_alias + "_" + field_format
               end
               def <=>(field)
                 position <=> field.position
               end
               # Returns the class that values represent
               def value_class
                 case field_format
                   when 'user', 'version'
                     field_format.classify.constantize
                   else
                     nil
                 end
               end
               def self.customized_class
                 self.name =~ /^(.+)CustomField$/
                 begin; $1.constantize; rescue nil; end
               end
               # to move in project_custom_field
               def self.for_all
-                find(:all, :conditions => ["is_for_all=?", true], :order => 'position')
+                where(:is_for_all => true).order('position').all
               end
               def type_name
                 nil
               end
               # Returns the error messages for the given value
               # or an empty array if value is a valid value for the custom field
               def validate_field_value(value)
                 errs = []
                 if value.is_a?(Array)
                   if !multiple?
                     errs << ::I18n.t('activerecord.errors.messages.invalid')
                   end
                   if is_required? && value.detect(&:present?).nil?
                     errs << ::I18n.t('activerecord.errors.messages.blank')
                   end
                   value.each {|v| errs += validate_field_value_format(v)}
                 else
                   if is_required? && value.blank?
                     errs << ::I18n.t('activerecord.errors.messages.blank')
                   end
                   errs += validate_field_value_format(value)
                 end
                 errs
               end
               # Returns true if value is a valid value for the custom field
               def valid_field_value?(value)
                 validate_field_value(value).empty?
               end
               def format_in?(*args)
                 args.include?(field_format)
               end
               protected
               # Returns the error message for the given value regarding its format
               def validate_field_value_format(value)
                 errs = []
                 if value.present?
                   errs << ::I18n.t('activerecord.errors.messages.invalid') unless regexp.blank? or value =~ Regexp.new(regexp)
                   errs << ::I18n.t('activerecord.errors.messages.too_short', :count => min_length) if min_length > 0 and value.length < min_length
                   errs << ::I18n.t('activerecord.errors.messages.too_long', :count => max_length) if max_length > 0 and value.length > max_length
                   # Format specific validations
                   case field_format
                   when 'int'
                     errs << ::I18n.t('activerecord.errors.messages.not_a_number') unless value =~ /^[+-]?\d+$/
                   when 'float'
                     begin; Kernel.Float(value); rescue; errs << ::I18n.t('activerecord.errors.messages.invalid') end
                   when 'date'
                     errs << ::I18n.t('activerecord.errors.messages.not_a_date') unless value =~ /^\d{4}-\d{2}-\d{2}$/ && begin; value.to_date; rescue; false end
                   when 'list'
                     errs << ::I18n.t('activerecord.errors.messages.inclusion') unless possible_values.include?(value)
                   end
                 end
                 errs
               end
             end

app/models/group.rb +5 -2

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class Group < Principal
               include Redmine::SafeAttributes
               has_and_belongs_to_many :users, :after_add => :user_added,
                                               :after_remove => :user_removed
               acts_as_customizable
               validates_presence_of :lastname
               validates_uniqueness_of :lastname, :case_sensitive => false
               validates_length_of :lastname, :maximum => 30
               before_destroy :remove_references_before_destroy
               scope :sorted, order("#{table_name}.lastname ASC")
               safe_attributes 'name',
                 'user_ids',
                 'custom_field_values',
                 'custom_fields',
                 :if => lambda {|group, user| user.admin?}
               def to_s
                 lastname.to_s
               end
               def name
                 lastname
               end
               def name=(arg)
                 self.lastname = arg
               end
               def user_added(user)
                 members.each do |member|
                   next if member.project.nil?
                   user_member = Member.find_by_project_id_and_user_id(member.project_id, user.id) || Member.new(:project_id => member.project_id, :user_id => user.id)
                   member.member_roles.each do |member_role|
                     user_member.member_roles << MemberRole.new(:role => member_role.role, :inherited_from => member_role.id)
                   end
                   user_member.save!
                 end
               end
               def user_removed(user)
                 members.each do |member|
-                  MemberRole.find(:all, :include => :member,
+                  MemberRole.
-                                        :conditions => ["#{Member.table_name}.user_id = ? AND #{MemberRole.table_name}.inherited_from IN (?)", user.id, member.member_role_ids]).each(&:destroy)
+                    includes(:member).
+                    where("#{Member.table_name}.user_id = ? AND #{MemberRole.table_name}.inherited_from IN (?)", user.id, member.member_role_ids).
+                    all.
+                    each(&:destroy)
                 end
               end
               def self.human_attribute_name(attribute_key_name, *args)
                 attr_name = attribute_key_name.to_s
                 if attr_name == 'lastname'
                   attr_name = "name"
                 end
                 super(attr_name, *args)
               end
               private
               # Removes references that are not handled by associations
               def remove_references_before_destroy
                 return if self.id.nil?
                 Issue.update_all 'assigned_to_id = NULL', ['assigned_to_id = ?', id]
               end
             end

app/models/mail_handler.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class MailHandler < ActionMailer::Base
               include ActionView::Helpers::SanitizeHelper
               include Redmine::I18n
               class UnauthorizedAction < StandardError; end
               class MissingInformation < StandardError; end
               attr_reader :email, :user
               def self.receive(email, options={})
                 @@handler_options = options.dup
                 @@handler_options[:issue] ||= {}
                 if @@handler_options[:allow_override].is_a?(String)
                   @@handler_options[:allow_override] = @@handler_options[:allow_override].split(',').collect(&:strip)
                 end
                 @@handler_options[:allow_override] ||= []
                 # Project needs to be overridable if not specified
                 @@handler_options[:allow_override] << 'project' unless @@handler_options[:issue].has_key?(:project)
                 # Status overridable by default
                 @@handler_options[:allow_override] << 'status' unless @@handler_options[:issue].has_key?(:status)
                 @@handler_options[:no_permission_check] = (@@handler_options[:no_permission_check].to_s == '1' ? true : false)
                 email.force_encoding('ASCII-8BIT') if email.respond_to?(:force_encoding)
                 super(email)
               end
               def logger
                 Rails.logger
               end
               cattr_accessor :ignored_emails_headers
               @@ignored_emails_headers = {
                 'X-Auto-Response-Suppress' => 'oof',
                 'Auto-Submitted' => /^auto-/
               }
               # Processes incoming emails
               # Returns the created object (eg. an issue, a message) or false
               def receive(email)
                 @email = email
                 sender_email = email.from.to_a.first.to_s.strip
                 # Ignore emails received from the application emission address to avoid hell cycles
                 if sender_email.downcase == Setting.mail_from.to_s.strip.downcase
                   if logger && logger.info
                     logger.info  "MailHandler: ignoring email from Redmine emission address [#{sender_email}]"
                   end
                   return false
                 end
                 # Ignore auto generated emails
                 self.class.ignored_emails_headers.each do |key, ignored_value|
                   value = email.header[key]
                   if value
                     value = value.to_s.downcase
                     if (ignored_value.is_a?(Regexp) && value.match(ignored_value)) || value == ignored_value
                       if logger && logger.info
                         logger.info "MailHandler: ignoring email with #{key}:#{value} header"
                       end
                       return false
                     end
                   end
                 end
                 @user = User.find_by_mail(sender_email) if sender_email.present?
                 if @user && !@user.active?
                   if logger && logger.info
                     logger.info  "MailHandler: ignoring email from non-active user [#{@user.login}]"
                   end
                   return false
                 end
                 if @user.nil?
                   # Email was submitted by an unknown user
                   case @@handler_options[:unknown_user]
                   when 'accept'
                     @user = User.anonymous
                   when 'create'
                     @user = create_user_from_email
                     if @user
                       if logger && logger.info
                         logger.info "MailHandler: [#{@user.login}] account created"
                       end
                       Mailer.account_information(@user, @user.password).deliver
                     else
                       if logger && logger.error
                         logger.error "MailHandler: could not create account for [#{sender_email}]"
                       end
                       return false
                     end
                   else
                     # Default behaviour, emails from unknown users are ignored
                     if logger && logger.info
                       logger.info  "MailHandler: ignoring email from unknown user [#{sender_email}]"
                     end
                     return false
                   end
                 end
                 User.current = @user
                 dispatch
               end
               private
               MESSAGE_ID_RE = %r{^<?redmine\.([a-z0-9_]+)\-(\d+)\.\d+@}
               ISSUE_REPLY_SUBJECT_RE = %r{\[[^\]]*#(\d+)\]}
               MESSAGE_REPLY_SUBJECT_RE = %r{\[[^\]]*msg(\d+)\]}
               def dispatch
                 headers = [email.in_reply_to, email.references].flatten.compact
                 subject = email.subject.to_s
                 if headers.detect {|h| h.to_s =~ MESSAGE_ID_RE}
                   klass, object_id = $1, $2.to_i
                   method_name = "receive_#{klass}_reply"
                   if self.class.private_instance_methods.collect(&:to_s).include?(method_name)
                     send method_name, object_id
                   else
                     # ignoring it
                   end
                 elsif m = subject.match(ISSUE_REPLY_SUBJECT_RE)
                   receive_issue_reply(m[1].to_i)
                 elsif m = subject.match(MESSAGE_REPLY_SUBJECT_RE)
                   receive_message_reply(m[1].to_i)
                 else
                   dispatch_to_default
                 end
               rescue ActiveRecord::RecordInvalid => e
                 # TODO: send a email to the user
                 logger.error e.message if logger
                 false
               rescue MissingInformation => e
                 logger.error "MailHandler: missing information from #{user}: #{e.message}" if logger
                 false
               rescue UnauthorizedAction => e
                 logger.error "MailHandler: unauthorized attempt from #{user}" if logger
                 false
               end
               def dispatch_to_default
                 receive_issue
               end
               # Creates a new issue
               def receive_issue
                 project = target_project
                 # check permission
                 unless @@handler_options[:no_permission_check]
                   raise UnauthorizedAction unless user.allowed_to?(:add_issues, project)
                 end
                 issue = Issue.new(:author => user, :project => project)
                 issue.safe_attributes = issue_attributes_from_keywords(issue)
                 issue.safe_attributes = {'custom_field_values' => custom_field_values_from_keywords(issue)}
                 issue.subject = cleaned_up_subject
                 if issue.subject.blank?
                   issue.subject = '(no subject)'
                 end
                 issue.description = cleaned_up_text_body
                 # add To and Cc as watchers before saving so the watchers can reply to Redmine
                 add_watchers(issue)
                 issue.save!
                 add_attachments(issue)
                 logger.info "MailHandler: issue ##{issue.id} created by #{user}" if logger && logger.info
                 issue
               end
               # Adds a note to an existing issue
               def receive_issue_reply(issue_id, from_journal=nil)
                 issue = Issue.find_by_id(issue_id)
                 return unless issue
                 # check permission
                 unless @@handler_options[:no_permission_check]
                   unless user.allowed_to?(:add_issue_notes, issue.project) ||
                            user.allowed_to?(:edit_issues, issue.project)
                     raise UnauthorizedAction
                   end
                 end
                 # ignore CLI-supplied defaults for new issues
                 @@handler_options[:issue].clear
                 journal = issue.init_journal(user)
                 if from_journal && from_journal.private_notes?
                   # If the received email was a reply to a private note, make the added note private
                   issue.private_notes = true
                 end
                 issue.safe_attributes = issue_attributes_from_keywords(issue)
                 issue.safe_attributes = {'custom_field_values' => custom_field_values_from_keywords(issue)}
                 journal.notes = cleaned_up_text_body
                 add_attachments(issue)
                 issue.save!
                 if logger && logger.info
                   logger.info "MailHandler: issue ##{issue.id} updated by #{user}"
                 end
                 journal
               end
               # Reply will be added to the issue
               def receive_journal_reply(journal_id)
                 journal = Journal.find_by_id(journal_id)
                 if journal && journal.journalized_type == 'Issue'
                   receive_issue_reply(journal.journalized_id, journal)
                 end
               end
               # Receives a reply to a forum message
               def receive_message_reply(message_id)
                 message = Message.find_by_id(message_id)
                 if message
                   message = message.root
                   unless @@handler_options[:no_permission_check]
                     raise UnauthorizedAction unless user.allowed_to?(:add_messages, message.project)
                   end
                   if !message.locked?
                     reply = Message.new(:subject => cleaned_up_subject.gsub(%r{^.*msg\d+\]}, '').strip,
                                         :content => cleaned_up_text_body)
                     reply.author = user
                     reply.board = message.board
                     message.children << reply
                     add_attachments(reply)
                     reply
                   else
                     if logger && logger.info
                       logger.info "MailHandler: ignoring reply from [#{sender_email}] to a locked topic"
                     end
                   end
                 end
               end
               def add_attachments(obj)
                 if email.attachments && email.attachments.any?
                   email.attachments.each do |attachment|
                     filename = attachment.filename
                     unless filename.respond_to?(:encoding)
                       # try to reencode to utf8 manually with ruby1.8
                       h = attachment.header['Content-Disposition']
                       unless h.nil?
                         begin
                           if m = h.value.match(/filename\*[0-9\*]*=([^=']+)'/)
                             filename = Redmine::CodesetUtil.to_utf8(filename, m[1])
                           elsif m = h.value.match(/filename=.*=\?([^\?]+)\?[BbQq]\?/)
                             # http://tools.ietf.org/html/rfc2047#section-4
                             filename = Redmine::CodesetUtil.to_utf8(filename, m[1])
                           end
                         rescue
                           # nop
                         end
                       end
                     end
                     obj.attachments << Attachment.create(:container => obj,
                                       :file => attachment.decoded,
                                       :filename => filename,
                                       :author => user,
                                       :content_type => attachment.mime_type)
                   end
                 end
               end
               # Adds To and Cc as watchers of the given object if the sender has the
               # appropriate permission
               def add_watchers(obj)
                 if user.allowed_to?("add_#{obj.class.name.underscore}_watchers".to_sym, obj.project)
                   addresses = [email.to, email.cc].flatten.compact.uniq.collect {|a| a.strip.downcase}
                   unless addresses.empty?
-                    watchers = User.active.find(:all, :conditions => ['LOWER(mail) IN (?)', addresses])
+                    watchers = User.active.where('LOWER(mail) IN (?)', addresses).all
                     watchers.each {|w| obj.add_watcher(w)}
                   end
                 end
               end
               def get_keyword(attr, options={})
                 @keywords ||= {}
                 if @keywords.has_key?(attr)
                   @keywords[attr]
                 else
                   @keywords[attr] = begin
                     if (options[:override] || @@handler_options[:allow_override].include?(attr.to_s)) &&
                           (v = extract_keyword!(plain_text_body, attr, options[:format]))
                       v
                     elsif !@@handler_options[:issue][attr].blank?
                       @@handler_options[:issue][attr]
                     end
                   end
                 end
               end
               # Destructively extracts the value for +attr+ in +text+
               # Returns nil if no matching keyword found
               def extract_keyword!(text, attr, format=nil)
                 keys = [attr.to_s.humanize]
                 if attr.is_a?(Symbol)
                   if user && user.language.present?
                     keys << l("field_#{attr}", :default => '', :locale =>  user.language)
                   end
                   if Setting.default_language.present?
                     keys << l("field_#{attr}", :default => '', :locale =>  Setting.default_language)
                   end
                 end
                 keys.reject! {|k| k.blank?}
                 keys.collect! {|k| Regexp.escape(k)}
                 format ||= '.+'
                 keyword = nil
                 regexp = /^(#{keys.join('|')})[ \t]*:[ \t]*(#{format})\s*$/i
                 if m = text.match(regexp)
                   keyword = m[2].strip
                   text.gsub!(regexp, '')
                 end
                 keyword
               end
               def target_project
                 # TODO: other ways to specify project:
                 # * parse the email To field
                 # * specific project (eg. Setting.mail_handler_target_project)
                 target = Project.find_by_identifier(get_keyword(:project))
                 raise MissingInformation.new('Unable to determine target project') if target.nil?
                 target
               end
               # Returns a Hash of issue attributes extracted from keywords in the email body
               def issue_attributes_from_keywords(issue)
                 assigned_to = (k = get_keyword(:assigned_to, :override => true)) && find_assignee_from_keyword(k, issue)
                 attrs = {
                   'tracker_id' => (k = get_keyword(:tracker)) && issue.project.trackers.named(k).first.try(:id),
                   'status_id' =>  (k = get_keyword(:status)) && IssueStatus.named(k).first.try(:id),
                   'priority_id' => (k = get_keyword(:priority)) && IssuePriority.named(k).first.try(:id),
                   'category_id' => (k = get_keyword(:category)) && issue.project.issue_categories.named(k).first.try(:id),
                   'assigned_to_id' => assigned_to.try(:id),
                   'fixed_version_id' => (k = get_keyword(:fixed_version, :override => true)) &&
                                             issue.project.shared_versions.named(k).first.try(:id),
                   'start_date' => get_keyword(:start_date, :override => true, :format => '\d{4}-\d{2}-\d{2}'),
                   'due_date' => get_keyword(:due_date, :override => true, :format => '\d{4}-\d{2}-\d{2}'),
                   'estimated_hours' => get_keyword(:estimated_hours, :override => true),
                   'done_ratio' => get_keyword(:done_ratio, :override => true, :format => '(\d|10)?0')
                 }.delete_if {|k, v| v.blank? }
                 if issue.new_record? && attrs['tracker_id'].nil?
                   attrs['tracker_id'] = issue.project.trackers.find(:first).try(:id)
                 end
                 attrs
               end
               # Returns a Hash of issue custom field values extracted from keywords in the email body
               def custom_field_values_from_keywords(customized)
                 customized.custom_field_values.inject({}) do |h, v|
                   if keyword = get_keyword(v.custom_field.name, :override => true)
                     h[v.custom_field.id.to_s] = v.custom_field.value_from_keyword(keyword, customized)
                   end
                   h
                 end
               end
               # Returns the text/plain part of the email
               # If not found (eg. HTML-only email), returns the body with tags removed
               def plain_text_body
                 return @plain_text_body unless @plain_text_body.nil?
                 part = email.text_part || email.html_part || email
                 @plain_text_body = Redmine::CodesetUtil.to_utf8(part.body.decoded, part.charset)
                 # strip html tags and remove doctype directive
                 @plain_text_body = strip_tags(@plain_text_body.strip)
                 @plain_text_body.sub! %r{^<!DOCTYPE .*$}, ''
                 @plain_text_body
               end
               def cleaned_up_text_body
                 cleanup_body(plain_text_body)
               end
               def cleaned_up_subject
                 subject = email.subject.to_s
                 unless subject.respond_to?(:encoding)
                   # try to reencode to utf8 manually with ruby1.8
                   begin
                     if h = email.header[:subject]
                       # http://tools.ietf.org/html/rfc2047#section-4
                       if m = h.value.match(/=\?([^\?]+)\?[BbQq]\?/)
                         subject = Redmine::CodesetUtil.to_utf8(subject, m[1])
                       end
                     end
                   rescue
                     # nop
                   end
                 end
                 subject.strip[0,255]
               end
               def self.full_sanitizer
                 @full_sanitizer ||= HTML::FullSanitizer.new
               end
               def self.assign_string_attribute_with_limit(object, attribute, value, limit=nil)
                 limit ||= object.class.columns_hash[attribute.to_s].limit || 255
                 value = value.to_s.slice(0, limit)
                 object.send("#{attribute}=", value)
               end
               # Returns a User from an email address and a full name
               def self.new_user_from_attributes(email_address, fullname=nil)
                 user = User.new
                 # Truncating the email address would result in an invalid format
                 user.mail = email_address
                 assign_string_attribute_with_limit(user, 'login', email_address, User::LOGIN_LENGTH_LIMIT)
                 names = fullname.blank? ? email_address.gsub(/@.*$/, '').split('.') : fullname.split
                 assign_string_attribute_with_limit(user, 'firstname', names.shift)
                 assign_string_attribute_with_limit(user, 'lastname', names.join(' '))
                 user.lastname = '-' if user.lastname.blank?
                 password_length = [Setting.password_min_length.to_i, 10].max
                 user.password = Redmine::Utils.random_hex(password_length / 2 + 1)
                 user.language = Setting.default_language
                 unless user.valid?
                   user.login = "user#{Redmine::Utils.random_hex(6)}" unless user.errors[:login].blank?
                   user.firstname = "-" unless user.errors[:firstname].blank?
                   user.lastname  = "-" unless user.errors[:lastname].blank?
                 end
                 user
               end
               # Creates a User for the +email+ sender
               # Returns the user or nil if it could not be created
               def create_user_from_email
                 from = email.header['from'].to_s
                 addr, name = from, nil
                 if m = from.match(/^"?(.+?)"?\s+<(.+@.+)>$/)
                   addr, name = m[2], m[1]
                 end
                 if addr.present?
                   user = self.class.new_user_from_attributes(addr, name)
                   if user.save
                     user
                   else
                     logger.error "MailHandler: failed to create User: #{user.errors.full_messages}" if logger
                     nil
                   end
                 else
                   logger.error "MailHandler: failed to create User: no FROM address found" if logger
                   nil
                 end
               end
               # Removes the email body of text after the truncation configurations.
               def cleanup_body(body)
                 delimiters = Setting.mail_handler_body_delimiters.to_s.split(/[\r\n]+/).reject(&:blank?).map {|s| Regexp.escape(s)}
                 unless delimiters.empty?
                   regex = Regexp.new("^[> ]*(#{ delimiters.join('|') })\s*[\r\n].*", Regexp::MULTILINE)
                   body = body.gsub(regex, '')
                 end
                 body.strip
               end
               def find_assignee_from_keyword(keyword, issue)
                 keyword = keyword.to_s.downcase
                 assignable = issue.assignable_users
                 assignee = nil
                 assignee ||= assignable.detect {|a|
                                a.mail.to_s.downcase == keyword ||
                                  a.login.to_s.downcase == keyword
                              }
                 if assignee.nil? && keyword.match(/ /)
                   firstname, lastname = *(keyword.split) # "First Last Throwaway"
                   assignee ||= assignable.detect {|a|
                                  a.is_a?(User) && a.firstname.to_s.downcase == firstname &&
                                    a.lastname.to_s.downcase == lastname
                                }
                 end
                 if assignee.nil?
                   assignee ||= assignable.detect {|a| a.name.downcase == keyword}
                 end
                 assignee
               end
             end

app/models/mailer.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class Mailer < ActionMailer::Base
               layout 'mailer'
               helper :application
               helper :issues
               helper :custom_fields
               include Redmine::I18n
               def self.default_url_options
                 { :host => Setting.host_name, :protocol => Setting.protocol }
               end
               # Builds a Mail::Message object used to email recipients of the added issue.
               #
               # Example:
               #   issue_add(issue) => Mail::Message object
               #   Mailer.issue_add(issue).deliver => sends an email to issue recipients
               def issue_add(issue)
                 redmine_headers 'Project' => issue.project.identifier,
                                 'Issue-Id' => issue.id,
                                 'Issue-Author' => issue.author.login
                 redmine_headers 'Issue-Assignee' => issue.assigned_to.login if issue.assigned_to
                 message_id issue
                 @author = issue.author
                 @issue = issue
                 @issue_url = url_for(:controller => 'issues', :action => 'show', :id => issue)
                 recipients = issue.recipients
                 cc = issue.watcher_recipients - recipients
                 mail :to => recipients,
                   :cc => cc,
                   :subject => "[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}] (#{issue.status.name}) #{issue.subject}"
               end
               # Builds a Mail::Message object used to email recipients of the edited issue.
               #
               # Example:
               #   issue_edit(journal) => Mail::Message object
               #   Mailer.issue_edit(journal).deliver => sends an email to issue recipients
               def issue_edit(journal)
                 issue = journal.journalized.reload
                 redmine_headers 'Project' => issue.project.identifier,
                                 'Issue-Id' => issue.id,
                                 'Issue-Author' => issue.author.login
                 redmine_headers 'Issue-Assignee' => issue.assigned_to.login if issue.assigned_to
                 message_id journal
                 references issue
                 @author = journal.user
                 recipients = journal.recipients
                 # Watchers in cc
                 cc = journal.watcher_recipients - recipients
                 s = "[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}] "
                 s << "(#{issue.status.name}) " if journal.new_value_for('status_id')
                 s << issue.subject
                 @issue = issue
                 @journal = journal
                 @issue_url = url_for(:controller => 'issues', :action => 'show', :id => issue, :anchor => "change-#{journal.id}")
                 mail :to => recipients,
                   :cc => cc,
                   :subject => s
               end
               def reminder(user, issues, days)
                 set_language_if_valid user.language
                 @issues = issues
                 @days = days
                 @issues_url = url_for(:controller => 'issues', :action => 'index',
                                             :set_filter => 1, :assigned_to_id => user.id,
                                             :sort => 'due_date:asc')
                 mail :to => user.mail,
                   :subject => l(:mail_subject_reminder, :count => issues.size, :days => days)
               end
               # Builds a Mail::Message object used to email users belonging to the added document's project.
               #
               # Example:
               #   document_added(document) => Mail::Message object
               #   Mailer.document_added(document).deliver => sends an email to the document's project recipients
               def document_added(document)
                 redmine_headers 'Project' => document.project.identifier
                 @author = User.current
                 @document = document
                 @document_url = url_for(:controller => 'documents', :action => 'show', :id => document)
                 mail :to => document.recipients,
                   :subject => "[#{document.project.name}] #{l(:label_document_new)}: #{document.title}"
               end
               # Builds a Mail::Message object used to email recipients of a project when an attachements are added.
               #
               # Example:
               #   attachments_added(attachments) => Mail::Message object
               #   Mailer.attachments_added(attachments).deliver => sends an email to the project's recipients
               def attachments_added(attachments)
                 container = attachments.first.container
                 added_to = ''
                 added_to_url = ''
                 @author = attachments.first.author
                 case container.class.name
                 when 'Project'
                   added_to_url = url_for(:controller => 'files', :action => 'index', :project_id => container)
                   added_to = "#{l(:label_project)}: #{container}"
                   recipients = container.project.notified_users.select {|user| user.allowed_to?(:view_files, container.project)}.collect  {|u| u.mail}
                 when 'Version'
                   added_to_url = url_for(:controller => 'files', :action => 'index', :project_id => container.project)
                   added_to = "#{l(:label_version)}: #{container.name}"
                   recipients = container.project.notified_users.select {|user| user.allowed_to?(:view_files, container.project)}.collect  {|u| u.mail}
                 when 'Document'
                   added_to_url = url_for(:controller => 'documents', :action => 'show', :id => container.id)
                   added_to = "#{l(:label_document)}: #{container.title}"
                   recipients = container.recipients
                 end
                 redmine_headers 'Project' => container.project.identifier
                 @attachments = attachments
                 @added_to = added_to
                 @added_to_url = added_to_url
                 mail :to => recipients,
                   :subject => "[#{container.project.name}] #{l(:label_attachment_new)}"
               end
               # Builds a Mail::Message object used to email recipients of a news' project when a news item is added.
               #
               # Example:
               #   news_added(news) => Mail::Message object
               #   Mailer.news_added(news).deliver => sends an email to the news' project recipients
               def news_added(news)
                 redmine_headers 'Project' => news.project.identifier
                 @author = news.author
                 message_id news
                 @news = news
                 @news_url = url_for(:controller => 'news', :action => 'show', :id => news)
                 mail :to => news.recipients,
                   :subject => "[#{news.project.name}] #{l(:label_news)}: #{news.title}"
               end
               # Builds a Mail::Message object used to email recipients of a news' project when a news comment is added.
               #
               # Example:
               #   news_comment_added(comment) => Mail::Message object
               #   Mailer.news_comment_added(comment) => sends an email to the news' project recipients
               def news_comment_added(comment)
                 news = comment.commented
                 redmine_headers 'Project' => news.project.identifier
                 @author = comment.author
                 message_id comment
                 @news = news
                 @comment = comment
                 @news_url = url_for(:controller => 'news', :action => 'show', :id => news)
                 mail :to => news.recipients,
                  :cc => news.watcher_recipients,
                  :subject => "Re: [#{news.project.name}] #{l(:label_news)}: #{news.title}"
               end
               # Builds a Mail::Message object used to email the recipients of the specified message that was posted.
               #
               # Example:
               #   message_posted(message) => Mail::Message object
               #   Mailer.message_posted(message).deliver => sends an email to the recipients
               def message_posted(message)
                 redmine_headers 'Project' => message.project.identifier,
                                 'Topic-Id' => (message.parent_id || message.id)
                 @author = message.author
                 message_id message
                 references message.parent unless message.parent.nil?
                 recipients = message.recipients
                 cc = ((message.root.watcher_recipients + message.board.watcher_recipients).uniq - recipients)
                 @message = message
                 @message_url = url_for(message.event_url)
                 mail :to => recipients,
                   :cc => cc,
                   :subject => "[#{message.board.project.name} - #{message.board.name} - msg#{message.root.id}] #{message.subject}"
               end
               # Builds a Mail::Message object used to email the recipients of a project of the specified wiki content was added.
               #
               # Example:
               #   wiki_content_added(wiki_content) => Mail::Message object
               #   Mailer.wiki_content_added(wiki_content).deliver => sends an email to the project's recipients
               def wiki_content_added(wiki_content)
                 redmine_headers 'Project' => wiki_content.project.identifier,
                                 'Wiki-Page-Id' => wiki_content.page.id
                 @author = wiki_content.author
                 message_id wiki_content
                 recipients = wiki_content.recipients
                 cc = wiki_content.page.wiki.watcher_recipients - recipients
                 @wiki_content = wiki_content
                 @wiki_content_url = url_for(:controller => 'wiki', :action => 'show',
                                                   :project_id => wiki_content.project,
                                                   :id => wiki_content.page.title)
                 mail :to => recipients,
                   :cc => cc,
                   :subject => "[#{wiki_content.project.name}] #{l(:mail_subject_wiki_content_added, :id => wiki_content.page.pretty_title)}"
               end
               # Builds a Mail::Message object used to email the recipients of a project of the specified wiki content was updated.
               #
               # Example:
               #   wiki_content_updated(wiki_content) => Mail::Message object
               #   Mailer.wiki_content_updated(wiki_content).deliver => sends an email to the project's recipients
               def wiki_content_updated(wiki_content)
                 redmine_headers 'Project' => wiki_content.project.identifier,
                                 'Wiki-Page-Id' => wiki_content.page.id
                 @author = wiki_content.author
                 message_id wiki_content
                 recipients = wiki_content.recipients
                 cc = wiki_content.page.wiki.watcher_recipients + wiki_content.page.watcher_recipients - recipients
                 @wiki_content = wiki_content
                 @wiki_content_url = url_for(:controller => 'wiki', :action => 'show',
                                                   :project_id => wiki_content.project,
                                                   :id => wiki_content.page.title)
                 @wiki_diff_url = url_for(:controller => 'wiki', :action => 'diff',
                                                :project_id => wiki_content.project, :id => wiki_content.page.title,
                                                :version => wiki_content.version)
                 mail :to => recipients,
                   :cc => cc,
                   :subject => "[#{wiki_content.project.name}] #{l(:mail_subject_wiki_content_updated, :id => wiki_content.page.pretty_title)}"
               end
               # Builds a Mail::Message object used to email the specified user their account information.
               #
               # Example:
               #   account_information(user, password) => Mail::Message object
               #   Mailer.account_information(user, password).deliver => sends account information to the user
               def account_information(user, password)
                 set_language_if_valid user.language
                 @user = user
                 @password = password
                 @login_url = url_for(:controller => 'account', :action => 'login')
                 mail :to => user.mail,
                   :subject => l(:mail_subject_register, Setting.app_title)
               end
               # Builds a Mail::Message object used to email all active administrators of an account activation request.
               #
               # Example:
               #   account_activation_request(user) => Mail::Message object
               #   Mailer.account_activation_request(user).deliver => sends an email to all active administrators
               def account_activation_request(user)
                 # Send the email to all active administrators
-                recipients = User.active.find(:all, :conditions => {:admin => true}).collect { |u| u.mail }.compact
+                recipients = User.active.where(:admin => true).all.collect { |u| u.mail }.compact
                 @user = user
                 @url = url_for(:controller => 'users', :action => 'index',
                                      :status => User::STATUS_REGISTERED,
                                      :sort_key => 'created_on', :sort_order => 'desc')
                 mail :to => recipients,
                   :subject => l(:mail_subject_account_activation_request, Setting.app_title)
               end
               # Builds a Mail::Message object used to email the specified user that their account was activated by an administrator.
               #
               # Example:
               #   account_activated(user) => Mail::Message object
               #   Mailer.account_activated(user).deliver => sends an email to the registered user
               def account_activated(user)
                 set_language_if_valid user.language
                 @user = user
                 @login_url = url_for(:controller => 'account', :action => 'login')
                 mail :to => user.mail,
                   :subject => l(:mail_subject_register, Setting.app_title)
               end
               def lost_password(token)
                 set_language_if_valid(token.user.language)
                 @token = token
                 @url = url_for(:controller => 'account', :action => 'lost_password', :token => token.value)
                 mail :to => token.user.mail,
                   :subject => l(:mail_subject_lost_password, Setting.app_title)
               end
               def register(token)
                 set_language_if_valid(token.user.language)
                 @token = token
                 @url = url_for(:controller => 'account', :action => 'activate', :token => token.value)
                 mail :to => token.user.mail,
                   :subject => l(:mail_subject_register, Setting.app_title)
               end
               def test_email(user)
                 set_language_if_valid(user.language)
                 @url = url_for(:controller => 'welcome')
                 mail :to => user.mail,
                   :subject => 'Redmine test'
               end
               # Overrides default deliver! method to prevent from sending an email
               # with no recipient, cc or bcc
               def deliver!(mail = @mail)
                 set_language_if_valid @initial_language
                 return false if (recipients.nil? || recipients.empty?) &&
                                 (cc.nil? || cc.empty?) &&
                                 (bcc.nil? || bcc.empty?)
                 # Log errors when raise_delivery_errors is set to false, Rails does not
                 raise_errors = self.class.raise_delivery_errors
                 self.class.raise_delivery_errors = true
                 begin
                   return super(mail)
                 rescue Exception => e
                   if raise_errors
                     raise e
                   elsif mylogger
                     mylogger.error "The following error occured while sending email notification: \"#{e.message}\". Check your configuration in config/configuration.yml."
                   end
                 ensure
                   self.class.raise_delivery_errors = raise_errors
                 end
               end
               # Sends reminders to issue assignees
               # Available options:
               # * :days     => how many days in the future to remind about (defaults to 7)
               # * :tracker  => id of tracker for filtering issues (defaults to all trackers)
               # * :project  => id or identifier of project to process (defaults to all projects)
               # * :users    => array of user/group ids who should be reminded
               def self.reminders(options={})
                 days = options[:days] || 7
                 project = options[:project] ? Project.find(options[:project]) : nil
                 tracker = options[:tracker] ? Tracker.find(options[:tracker]) : nil
                 user_ids = options[:users]
                 scope = Issue.open.where("#{Issue.table_name}.assigned_to_id IS NOT NULL" +
                   " AND #{Project.table_name}.status = #{Project::STATUS_ACTIVE}" +
                   " AND #{Issue.table_name}.due_date <= ?", days.day.from_now.to_date
                 )
                 scope = scope.where(:assigned_to_id => user_ids) if user_ids.present?
                 scope = scope.where(:project_id => project.id) if project
                 scope = scope.where(:tracker_id => tracker.id) if tracker
                 issues_by_assignee = scope.includes(:status, :assigned_to, :project, :tracker).all.group_by(&:assigned_to)
                 issues_by_assignee.keys.each do |assignee|
                   if assignee.is_a?(Group)
                     assignee.users.each do |user|
                       issues_by_assignee[user] ||= []
                       issues_by_assignee[user] += issues_by_assignee[assignee]
                     end
                   end
                 end
                 issues_by_assignee.each do |assignee, issues|
                   reminder(assignee, issues, days).deliver if assignee.is_a?(User) && assignee.active?
                 end
               end
               # Activates/desactivates email deliveries during +block+
               def self.with_deliveries(enabled = true, &block)
                 was_enabled = ActionMailer::Base.perform_deliveries
                 ActionMailer::Base.perform_deliveries = !!enabled
                 yield
               ensure
                 ActionMailer::Base.perform_deliveries = was_enabled
               end
               # Sends emails synchronously in the given block
               def self.with_synched_deliveries(&block)
                 saved_method = ActionMailer::Base.delivery_method
                 if m = saved_method.to_s.match(%r{^async_(.+)$})
                   synched_method = m[1]
                   ActionMailer::Base.delivery_method = synched_method.to_sym
                   ActionMailer::Base.send "#{synched_method}_settings=", ActionMailer::Base.send("async_#{synched_method}_settings")
                 end
                 yield
               ensure
                 ActionMailer::Base.delivery_method = saved_method
               end
               def mail(headers={})
                 headers.merge! 'X-Mailer' => 'Redmine',
                         'X-Redmine-Host' => Setting.host_name,
                         'X-Redmine-Site' => Setting.app_title,
                         'X-Auto-Response-Suppress' => 'OOF',
                         'Auto-Submitted' => 'auto-generated',
                         'From' => Setting.mail_from,
                         'List-Id' => "<#{Setting.mail_from.to_s.gsub('@', '.')}>"
                 # Removes the author from the recipients and cc
                 # if he doesn't want to receive notifications about what he does
                 if @author && @author.logged? && @author.pref[:no_self_notified]
                   headers[:to].delete(@author.mail) if headers[:to].is_a?(Array)
                   headers[:cc].delete(@author.mail) if headers[:cc].is_a?(Array)
                 end
                 if @author && @author.logged?
                   redmine_headers 'Sender' => @author.login
                 end
                 # Blind carbon copy recipients
                 if Setting.bcc_recipients?
                   headers[:bcc] = [headers[:to], headers[:cc]].flatten.uniq.reject(&:blank?)
                   headers[:to] = nil
                   headers[:cc] = nil
                 end
                 if @message_id_object
                   headers[:message_id] = "<#{self.class.message_id_for(@message_id_object)}>"
                 end
                 if @references_objects
                   headers[:references] = @references_objects.collect {|o| "<#{self.class.message_id_for(o)}>"}.join(' ')
                 end
                 super headers do |format|
                   format.text
                   format.html unless Setting.plain_text_mail?
                 end
                 set_language_if_valid @initial_language
               end
               def initialize(*args)
                 @initial_language = current_language
                 set_language_if_valid Setting.default_language
                 super
               end
               def self.deliver_mail(mail)
                 return false if mail.to.blank? && mail.cc.blank? && mail.bcc.blank?
                 super
               end
               def self.method_missing(method, *args, &block)
                 if m = method.to_s.match(%r{^deliver_(.+)$})
                   ActiveSupport::Deprecation.warn "Mailer.deliver_#{m[1]}(*args) is deprecated. Use Mailer.#{m[1]}(*args).deliver instead."
                   send(m[1], *args).deliver
                 else
                   super
                 end
               end
               private
               # Appends a Redmine header field (name is prepended with 'X-Redmine-')
               def redmine_headers(h)
                 h.each { |k,v| headers["X-Redmine-#{k}"] = v.to_s }
               end
               # Returns a predictable Message-Id for the given object
               def self.message_id_for(object)
                 # id + timestamp should reduce the odds of a collision
                 # as far as we don't send multiple emails for the same object
                 timestamp = object.send(object.respond_to?(:created_on) ? :created_on : :updated_on)
                 hash = "redmine.#{object.class.name.demodulize.underscore}-#{object.id}.#{timestamp.strftime("%Y%m%d%H%M%S")}"
                 host = Setting.mail_from.to_s.gsub(%r{^.*@}, '')
                 host = "#{::Socket.gethostname}.redmine" if host.empty?
                 "#{hash}@#{host}"
               end
               def message_id(object)
                 @message_id_object = object
               end
               def references(object)
                 @references_objects ||= []
                 @references_objects << object
               end
               def mylogger
                 Rails.logger
               end
             end

app/models/member_role.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class MemberRole < ActiveRecord::Base
               belongs_to :member
               belongs_to :role
               after_destroy :remove_member_if_empty
               after_create :add_role_to_group_users
               after_destroy :remove_role_from_group_users
               validates_presence_of :role
               validate :validate_role_member
               def validate_role_member
                 errors.add :role_id, :invalid if role && !role.member?
               end
               def inherited?
                 !inherited_from.nil?
               end
               private
               def remove_member_if_empty
                 if member.roles.empty?
                   member.destroy
                 end
               end
               def add_role_to_group_users
                 if member.principal.is_a?(Group)
                   member.principal.users.each do |user|
                     user_member = Member.find_by_project_id_and_user_id(member.project_id, user.id) || Member.new(:project_id => member.project_id, :user_id => user.id)
                     user_member.member_roles << MemberRole.new(:role => role, :inherited_from => id)
                     user_member.save!
                   end
                 end
               end
               def remove_role_from_group_users
-                MemberRole.find(:all, :conditions => { :inherited_from => id }).group_by(&:member).each do |member, member_roles|
+                MemberRole.where(:inherited_from => id).all.group_by(&:member).each do |member, member_roles|
                   member_roles.each(&:destroy)
                   if member && member.user
                     Watcher.prune(:user => member.user, :project => member.project)
                   end
                 end
               end
             end

app/models/project.rb +7 -9

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class Project < ActiveRecord::Base
               include Redmine::SafeAttributes
               # Project statuses
               STATUS_ACTIVE     = 1
               STATUS_CLOSED     = 5
               STATUS_ARCHIVED   = 9
               # Maximum length for project identifiers
               IDENTIFIER_MAX_LENGTH = 100
               # Specific overidden Activities
               has_many :time_entry_activities
               has_many :members, :include => [:principal, :roles], :conditions => "#{User.table_name}.type='User' AND #{User.table_name}.status=#{User::STATUS_ACTIVE}"
               has_many :memberships, :class_name => 'Member'
               has_many :member_principals, :class_name => 'Member',
                                            :include => :principal,
                                            :conditions => "#{Principal.table_name}.type='Group' OR (#{Principal.table_name}.type='User' AND #{Principal.table_name}.status=#{User::STATUS_ACTIVE})"
               has_many :users, :through => :members
               has_many :principals, :through => :member_principals, :source => :principal
               has_many :enabled_modules, :dependent => :delete_all
               has_and_belongs_to_many :trackers, :order => "#{Tracker.table_name}.position"
               has_many :issues, :dependent => :destroy, :include => [:status, :tracker]
               has_many :issue_changes, :through => :issues, :source => :journals
               has_many :versions, :dependent => :destroy, :order => "#{Version.table_name}.effective_date DESC, #{Version.table_name}.name DESC"
               has_many :time_entries, :dependent => :delete_all
               has_many :queries, :dependent => :delete_all
               has_many :documents, :dependent => :destroy
               has_many :news, :dependent => :destroy, :include => :author
               has_many :issue_categories, :dependent => :delete_all, :order => "#{IssueCategory.table_name}.name"
               has_many :boards, :dependent => :destroy, :order => "position ASC"
               has_one :repository, :conditions => ["is_default = ?", true]
               has_many :repositories, :dependent => :destroy
               has_many :changesets, :through => :repository
               has_one :wiki, :dependent => :destroy
               # Custom field for the project issues
               has_and_belongs_to_many :issue_custom_fields,
                                       :class_name => 'IssueCustomField',
                                       :order => "#{CustomField.table_name}.position",
                                       :join_table => "#{table_name_prefix}custom_fields_projects#{table_name_suffix}",
                                       :association_foreign_key => 'custom_field_id'
               acts_as_nested_set :order => 'name', :dependent => :destroy
               acts_as_attachable :view_permission => :view_files,
                                  :delete_permission => :manage_files
               acts_as_customizable
               acts_as_searchable :columns => ['name', 'identifier', 'description'], :project_key => 'id', :permission => nil
               acts_as_event :title => Proc.new {|o| "#{l(:label_project)}: #{o.name}"},
                             :url => Proc.new {|o| {:controller => 'projects', :action => 'show', :id => o}},
                             :author => nil
               attr_protected :status
               validates_presence_of :name, :identifier
               validates_uniqueness_of :identifier
               validates_associated :repository, :wiki
               validates_length_of :name, :maximum => 255
               validates_length_of :homepage, :maximum => 255
               validates_length_of :identifier, :in => 1..IDENTIFIER_MAX_LENGTH
               # donwcase letters, digits, dashes but not digits only
               validates_format_of :identifier, :with => /^(?!\d+$)[a-z0-9\-_]*$/, :if => Proc.new { |p| p.identifier_changed? }
               # reserved words
               validates_exclusion_of :identifier, :in => %w( new )
               after_save :update_position_under_parent, :if => Proc.new {|project| project.name_changed?}
               before_destroy :delete_all_members
               scope :has_module, lambda { |mod| { :conditions => ["#{Project.table_name}.id IN (SELECT em.project_id FROM #{EnabledModule.table_name} em WHERE em.name=?)", mod.to_s] } }
               scope :active, { :conditions => "#{Project.table_name}.status = #{STATUS_ACTIVE}"}
               scope :status, lambda {|arg| arg.blank? ? {} : {:conditions => {:status => arg.to_i}} }
               scope :all_public, { :conditions => { :is_public => true } }
               scope :visible, lambda {|*args| {:conditions => Project.visible_condition(args.shift || User.current, *args) }}
               scope :allowed_to, lambda {|*args|
                 user = User.current
                 permission = nil
                 if args.first.is_a?(Symbol)
                   permission = args.shift
                 else
                   user = args.shift
                   permission = args.shift
                 end
                 { :conditions => Project.allowed_to_condition(user, permission, *args) }
               }
               scope :like, lambda {|arg|
                 if arg.blank?
                   {}
                 else
                   pattern = "%#{arg.to_s.strip.downcase}%"
                   {:conditions => ["LOWER(identifier) LIKE :p OR LOWER(name) LIKE :p", {:p => pattern}]}
                 end
               }
               def initialize(attributes=nil, *args)
                 super
                 initialized = (attributes || {}).stringify_keys
                 if !initialized.key?('identifier') && Setting.sequential_project_identifiers?
                   self.identifier = Project.next_identifier
                 end
                 if !initialized.key?('is_public')
                   self.is_public = Setting.default_projects_public?
                 end
                 if !initialized.key?('enabled_module_names')
                   self.enabled_module_names = Setting.default_projects_modules
                 end
                 if !initialized.key?('trackers') && !initialized.key?('tracker_ids')
                   self.trackers = Tracker.sorted.all
                 end
               end
               def identifier=(identifier)
                 super unless identifier_frozen?
               end
               def identifier_frozen?
                 errors[:identifier].blank? && !(new_record? || identifier.blank?)
               end
               # returns latest created projects
               # non public projects will be returned only if user is a member of those
               def self.latest(user=nil, count=5)
-                visible(user).find(:all, :limit => count, :order => "created_on DESC")
+                visible(user).limit(count).order("created_on DESC").all
               end
               # Returns true if the project is visible to +user+ or to the current user.
               def visible?(user=User.current)
                 user.allowed_to?(:view_project, self)
               end
               # Returns a SQL conditions string used to find all projects visible by the specified user.
               #
               # Examples:
               #   Project.visible_condition(admin)        => "projects.status = 1"
               #   Project.visible_condition(normal_user)  => "((projects.status = 1) AND (projects.is_public = 1 OR projects.id IN (1,3,4)))"
               #   Project.visible_condition(anonymous)    => "((projects.status = 1) AND (projects.is_public = 1))"
               def self.visible_condition(user, options={})
                 allowed_to_condition(user, :view_project, options)
               end
               # Returns a SQL conditions string used to find all projects for which +user+ has the given +permission+
               #
               # Valid options:
               # * :project => limit the condition to project
               # * :with_subprojects => limit the condition to project and its subprojects
               # * :member => limit the condition to the user projects
               def self.allowed_to_condition(user, permission, options={})
                 perm = Redmine::AccessControl.permission(permission)
                 base_statement = (perm && perm.read? ? "#{Project.table_name}.status <> #{Project::STATUS_ARCHIVED}" : "#{Project.table_name}.status = #{Project::STATUS_ACTIVE}")
                 if perm && perm.project_module
                   # If the permission belongs to a project module, make sure the module is enabled
                   base_statement << " AND #{Project.table_name}.id IN (SELECT em.project_id FROM #{EnabledModule.table_name} em WHERE em.name='#{perm.project_module}')"
                 end
                 if options[:project]
                   project_statement = "#{Project.table_name}.id = #{options[:project].id}"
                   project_statement << " OR (#{Project.table_name}.lft > #{options[:project].lft} AND #{Project.table_name}.rgt < #{options[:project].rgt})" if options[:with_subprojects]
                   base_statement = "(#{project_statement}) AND (#{base_statement})"
                 end
                 if user.admin?
                   base_statement
                 else
                   statement_by_role = {}
                   unless options[:member]
                     role = user.logged? ? Role.non_member : Role.anonymous
                     if role.allowed_to?(permission)
                       statement_by_role[role] = "#{Project.table_name}.is_public = #{connection.quoted_true}"
                     end
                   end
                   if user.logged?
                     user.projects_by_role.each do |role, projects|
                       if role.allowed_to?(permission) && projects.any?
                         statement_by_role[role] = "#{Project.table_name}.id IN (#{projects.collect(&:id).join(',')})"
                       end
                     end
                   end
                   if statement_by_role.empty?
                     "1=0"
                   else
                     if block_given?
                       statement_by_role.each do |role, statement|
                         if s = yield(role, user)
                           statement_by_role[role] = "(#{statement} AND (#{s}))"
                         end
                       end
                     end
                     "((#{base_statement}) AND (#{statement_by_role.values.join(' OR ')}))"
                   end
                 end
               end
               # Returns the Systemwide and project specific activities
               def activities(include_inactive=false)
                 if include_inactive
                   return all_activities
                 else
                   return active_activities
                 end
               end
               # Will create a new Project specific Activity or update an existing one
               #
               # This will raise a ActiveRecord::Rollback if the TimeEntryActivity
               # does not successfully save.
               def update_or_create_time_entry_activity(id, activity_hash)
                 if activity_hash.respond_to?(:has_key?) && activity_hash.has_key?('parent_id')
                   self.create_time_entry_activity_if_needed(activity_hash)
                 else
                   activity = project.time_entry_activities.find_by_id(id.to_i)
                   activity.update_attributes(activity_hash) if activity
                 end
               end
               # Create a new TimeEntryActivity if it overrides a system TimeEntryActivity
               #
               # This will raise a ActiveRecord::Rollback if the TimeEntryActivity
               # does not successfully save.
               def create_time_entry_activity_if_needed(activity)
                 if activity['parent_id']
                   parent_activity = TimeEntryActivity.find(activity['parent_id'])
                   activity['name'] = parent_activity.name
                   activity['position'] = parent_activity.position
                   if Enumeration.overridding_change?(activity, parent_activity)
                     project_activity = self.time_entry_activities.create(activity)
                     if project_activity.new_record?
                       raise ActiveRecord::Rollback, "Overridding TimeEntryActivity was not successfully saved"
                     else
                       self.time_entries.update_all("activity_id = #{project_activity.id}", ["activity_id = ?", parent_activity.id])
                     end
                   end
                 end
               end
               # Returns a :conditions SQL string that can be used to find the issues associated with this project.
               #
               # Examples:
               #   project.project_condition(true)  => "(projects.id = 1 OR (projects.lft > 1 AND projects.rgt < 10))"
               #   project.project_condition(false) => "projects.id = 1"
               def project_condition(with_subprojects)
                 cond = "#{Project.table_name}.id = #{id}"
                 cond = "(#{cond} OR (#{Project.table_name}.lft > #{lft} AND #{Project.table_name}.rgt < #{rgt}))" if with_subprojects
                 cond
               end
               def self.find(*args)
                 if args.first && args.first.is_a?(String) && !args.first.match(/^\d*$/)
                   project = find_by_identifier(*args)
                   raise ActiveRecord::RecordNotFound, "Couldn't find Project with identifier=#{args.first}" if project.nil?
                   project
                 else
                   super
                 end
               end
               def self.find_by_param(*args)
                 self.find(*args)
               end
               def reload(*args)
                 @shared_versions = nil
                 @rolled_up_versions = nil
                 @rolled_up_trackers = nil
                 @all_issue_custom_fields = nil
                 @all_time_entry_custom_fields = nil
                 @to_param = nil
                 @allowed_parents = nil
                 @allowed_permissions = nil
                 @actions_allowed = nil
                 super
               end
               def to_param
                 # id is used for projects with a numeric identifier (compatibility)
                 @to_param ||= (identifier.to_s =~ %r{^\d*$} ? id.to_s : identifier)
               end
               def active?
                 self.status == STATUS_ACTIVE
               end
               def archived?
                 self.status == STATUS_ARCHIVED
               end
               # Archives the project and its descendants
               def archive
                 # Check that there is no issue of a non descendant project that is assigned
                 # to one of the project or descendant versions
                 v_ids = self_and_descendants.collect {|p| p.version_ids}.flatten
                 if v_ids.any? && Issue.find(:first, :include => :project,
                                                     :conditions => ["(#{Project.table_name}.lft < ? OR #{Project.table_name}.rgt > ?)" +
                                                                     " AND #{Issue.table_name}.fixed_version_id IN (?)", lft, rgt, v_ids])
                   return false
                 end
                 Project.transaction do
                   archive!
                 end
                 true
               end
               # Unarchives the project
               # All its ancestors must be active
               def unarchive
                 return false if ancestors.detect {|a| !a.active?}
                 update_attribute :status, STATUS_ACTIVE
               end
               def close
                 self_and_descendants.status(STATUS_ACTIVE).update_all :status => STATUS_CLOSED
               end
               def reopen
                 self_and_descendants.status(STATUS_CLOSED).update_all :status => STATUS_ACTIVE
               end
               # Returns an array of projects the project can be moved to
               # by the current user
               def allowed_parents
                 return @allowed_parents if @allowed_parents
-                @allowed_parents = Project.find(:all, :conditions => Project.allowed_to_condition(User.current, :add_subprojects))
+                @allowed_parents = Project.where(Project.allowed_to_condition(User.current, :add_subprojects)).all
                 @allowed_parents = @allowed_parents - self_and_descendants
                 if User.current.allowed_to?(:add_project, nil, :global => true) || (!new_record? && parent.nil?)
                   @allowed_parents << nil
                 end
                 unless parent.nil? || @allowed_parents.empty? || @allowed_parents.include?(parent)
                   @allowed_parents << parent
                 end
                 @allowed_parents
               end
               # Sets the parent of the project with authorization check
               def set_allowed_parent!(p)
                 unless p.nil? || p.is_a?(Project)
                   if p.to_s.blank?
                     p = nil
                   else
                     p = Project.find_by_id(p)
                     return false unless p
                   end
                 end
                 if p.nil?
                   if !new_record? && allowed_parents.empty?
                     return false
                   end
                 elsif !allowed_parents.include?(p)
                   return false
                 end
                 set_parent!(p)
               end
               # Sets the parent of the project
               # Argument can be either a Project, a String, a Fixnum or nil
               def set_parent!(p)
                 unless p.nil? || p.is_a?(Project)
                   if p.to_s.blank?
                     p = nil
                   else
                     p = Project.find_by_id(p)
                     return false unless p
                   end
                 end
                 if p == parent && !p.nil?
                   # Nothing to do
                   true
                 elsif p.nil? || (p.active? && move_possible?(p))
                   set_or_update_position_under(p)
                   Issue.update_versions_from_hierarchy_change(self)
                   true
                 else
                   # Can not move to the given target
                   false
                 end
               end
               # Recalculates all lft and rgt values based on project names
               # Unlike Project.rebuild!, these values are recalculated even if the tree "looks" valid
               # Used in BuildProjectsTree migration
               def self.rebuild_tree!
                 transaction do
                   update_all "lft = NULL, rgt = NULL"
                   rebuild!(false)
                 end
               end
               # Returns an array of the trackers used by the project and its active sub projects
               def rolled_up_trackers
                 @rolled_up_trackers ||=
                   Tracker.find(:all, :joins => :projects,
                                      :select => "DISTINCT #{Tracker.table_name}.*",
                                      :conditions => ["#{Project.table_name}.lft >= ? AND #{Project.table_name}.rgt <= ? AND #{Project.table_name}.status <> #{STATUS_ARCHIVED}", lft, rgt],
                                      :order => "#{Tracker.table_name}.position")
               end
               # Closes open and locked project versions that are completed
               def close_completed_versions
                 Version.transaction do
-                  versions.find(:all, :conditions => {:status => %w(open locked)}).each do |version|
+                  versions.where(:status => %w(open locked)).all.each do |version|
                     if version.completed?
                       version.update_attribute(:status, 'closed')
                     end
                   end
                 end
               end
               # Returns a scope of the Versions on subprojects
               def rolled_up_versions
                 @rolled_up_versions ||=
                   Version.scoped(:include => :project,
                                  :conditions => ["#{Project.table_name}.lft >= ? AND #{Project.table_name}.rgt <= ? AND #{Project.table_name}.status <> #{STATUS_ARCHIVED}", lft, rgt])
               end
               # Returns a scope of the Versions used by the project
               def shared_versions
                 if new_record?
                   Version.scoped(:include => :project,
                                  :conditions => "#{Project.table_name}.status <> #{Project::STATUS_ARCHIVED} AND #{Version.table_name}.sharing = 'system'")
                 else
                   @shared_versions ||= begin
                     r = root? ? self : root
                     Version.scoped(:include => :project,
                                    :conditions => "#{Project.table_name}.id = #{id}" +
                                                   " OR (#{Project.table_name}.status <> #{Project::STATUS_ARCHIVED} AND (" +
                                                       " #{Version.table_name}.sharing = 'system'" +
                                                       " OR (#{Project.table_name}.lft >= #{r.lft} AND #{Project.table_name}.rgt <= #{r.rgt} AND #{Version.table_name}.sharing = 'tree')" +
                                                       " OR (#{Project.table_name}.lft < #{lft} AND #{Project.table_name}.rgt > #{rgt} AND #{Version.table_name}.sharing IN ('hierarchy', 'descendants'))" +
                                                       " OR (#{Project.table_name}.lft > #{lft} AND #{Project.table_name}.rgt < #{rgt} AND #{Version.table_name}.sharing = 'hierarchy')" +
                                                       "))")
                   end
                 end
               end
               # Returns a hash of project users grouped by role
               def users_by_role
-                members.find(:all, :include => [:user, :roles]).inject({}) do |h, m|
+                members.includes(:user, :roles).all.inject({}) do |h, m|
                   m.roles.each do |r|
                     h[r] ||= []
                     h[r] << m.user
                   end
                   h
                 end
               end
               # Deletes all project's members
               def delete_all_members
                 me, mr = Member.table_name, MemberRole.table_name
                 connection.delete("DELETE FROM #{mr} WHERE #{mr}.member_id IN (SELECT #{me}.id FROM #{me} WHERE #{me}.project_id = #{id})")
                 Member.delete_all(['project_id = ?', id])
               end
               # Users/groups issues can be assigned to
               def assignable_users
                 assignable = Setting.issue_group_assignment? ? member_principals : members
                 assignable.select {|m| m.roles.detect {|role| role.assignable?}}.collect {|m| m.principal}.sort
               end
               # Returns the mail adresses of users that should be always notified on project events
               def recipients
                 notified_users.collect {|user| user.mail}
               end
               # Returns the users that should be notified on project events
               def notified_users
                 # TODO: User part should be extracted to User#notify_about?
                 members.select {|m| m.principal.present? && (m.mail_notification? || m.principal.mail_notification == 'all')}.collect {|m| m.principal}
               end
               # Returns an array of all custom fields enabled for project issues
               # (explictly associated custom fields and custom fields enabled for all projects)
               def all_issue_custom_fields
                 @all_issue_custom_fields ||= (IssueCustomField.for_all + issue_custom_fields).uniq.sort
               end
               # Returns an array of all custom fields enabled for project time entries
               # (explictly associated custom fields and custom fields enabled for all projects)
               def all_time_entry_custom_fields
                 @all_time_entry_custom_fields ||= (TimeEntryCustomField.for_all + time_entry_custom_fields).uniq.sort
               end
               def project
                 self
               end
               def <=>(project)
                 name.downcase <=> project.name.downcase
               end
               def to_s
                 name
               end
               # Returns a short description of the projects (first lines)
               def short_description(length = 255)
                 description.gsub(/^(.{#{length}}[^\n\r]*).*$/m, '\1...').strip if description
               end
               def css_classes
                 s = 'project'
                 s << ' root' if root?
                 s << ' child' if child?
                 s << (leaf? ? ' leaf' : ' parent')
                 unless active?
                   if archived?
                     s << ' archived'
                   else
                     s << ' closed'
                   end
                 end
                 s
               end
               # The earliest start date of a project, based on it's issues and versions
               def start_date
                 [
                  issues.minimum('start_date'),
                  shared_versions.collect(&:effective_date),
                  shared_versions.collect(&:start_date)
                 ].flatten.compact.min
               end
               # The latest due date of an issue or version
               def due_date
                 [
                  issues.maximum('due_date'),
                  shared_versions.collect(&:effective_date),
                  shared_versions.collect {|v| v.fixed_issues.maximum('due_date')}
                 ].flatten.compact.max
               end
               def overdue?
                 active? && !due_date.nil? && (due_date < Date.today)
               end
               # Returns the percent completed for this project, based on the
               # progress on it's versions.
               def completed_percent(options={:include_subprojects => false})
                 if options.delete(:include_subprojects)
                   total = self_and_descendants.collect(&:completed_percent).sum
                   total / self_and_descendants.count
                 else
                   if versions.count > 0
                     total = versions.collect(&:completed_pourcent).sum
                     total / versions.count
                   else
                   end
                 end
               end
               # Return true if this project allows to do the specified action.
               # action can be:
               # * a parameter-like Hash (eg. :controller => 'projects', :action => 'edit')
               # * a permission Symbol (eg. :edit_project)
               def allows_to?(action)
                 if archived?
                   # No action allowed on archived projects
                   return false
                 end
                 unless active? || Redmine::AccessControl.read_action?(action)
                   # No write action allowed on closed projects
                   return false
                 end
                 # No action allowed on disabled modules
                 if action.is_a? Hash
                   allowed_actions.include? "#{action[:controller]}/#{action[:action]}"
                 else
                   allowed_permissions.include? action
                 end
               end
               def module_enabled?(module_name)
                 module_name = module_name.to_s
                 enabled_modules.detect {|m| m.name == module_name}
               end
               def enabled_module_names=(module_names)
                 if module_names && module_names.is_a?(Array)
                   module_names = module_names.collect(&:to_s).reject(&:blank?)
                   self.enabled_modules = module_names.collect {|name| enabled_modules.detect {|mod| mod.name == name} || EnabledModule.new(:name => name)}
                 else
                   enabled_modules.clear
                 end
               end
               # Returns an array of the enabled modules names
               def enabled_module_names
                 enabled_modules.collect(&:name)
               end
               # Enable a specific module
               #
               # Examples:
               #   project.enable_module!(:issue_tracking)
               #   project.enable_module!("issue_tracking")
               def enable_module!(name)
                 enabled_modules << EnabledModule.new(:name => name.to_s) unless module_enabled?(name)
               end
               # Disable a module if it exists
               #
               # Examples:
               #   project.disable_module!(:issue_tracking)
               #   project.disable_module!("issue_tracking")
               #   project.disable_module!(project.enabled_modules.first)
               def disable_module!(target)
                 target = enabled_modules.detect{|mod| target.to_s == mod.name} unless enabled_modules.include?(target)
                 target.destroy unless target.blank?
               end
               safe_attributes 'name',
                 'description',
                 'homepage',
                 'is_public',
                 'identifier',
                 'custom_field_values',
                 'custom_fields',
                 'tracker_ids',
                 'issue_custom_field_ids'
               safe_attributes 'enabled_module_names',
                 :if => lambda {|project, user| project.new_record? || user.allowed_to?(:select_project_modules, project) }
               # Returns an array of projects that are in this project's hierarchy
               #
               # Example: parents, children, siblings
               def hierarchy
                 parents = project.self_and_ancestors || []
                 descendants = project.descendants || []
                 project_hierarchy = parents | descendants # Set union
               end
               # Returns an auto-generated project identifier based on the last identifier used
               def self.next_identifier
                 p = Project.find(:first, :order => 'created_on DESC')
                 p.nil? ? nil : p.identifier.to_s.succ
               end
               # Copies and saves the Project instance based on the +project+.
               # Duplicates the source project's:
               # * Wiki
               # * Versions
               # * Categories
               # * Issues
               # * Members
               # * Queries
               #
               # Accepts an +options+ argument to specify what to copy
               #
               # Examples:
               #   project.copy(1)                                    # => copies everything
               #   project.copy(1, :only => 'members')                # => copies members only
               #   project.copy(1, :only => ['members', 'versions'])  # => copies members and versions
               def copy(project, options={})
                 project = project.is_a?(Project) ? project : Project.find(project)
                 to_be_copied = %w(wiki versions issue_categories issues members queries boards)
                 to_be_copied = to_be_copied & options[:only].to_a unless options[:only].nil?
                 Project.transaction do
                   if save
                     reload
                     to_be_copied.each do |name|
                       send "copy_#{name}", project
                     end
                     Redmine::Hook.call_hook(:model_project_copy_before_save, :source_project => project, :destination_project => self)
                     save
                   end
                 end
               end
               # Copies +project+ and returns the new instance.  This will not save
               # the copy
               def self.copy_from(project)
                 begin
                   project = project.is_a?(Project) ? project : Project.find(project)
                   if project
                     # clear unique attributes
                     attributes = project.attributes.dup.except('id', 'name', 'identifier', 'status', 'parent_id', 'lft', 'rgt')
                     copy = Project.new(attributes)
                     copy.enabled_modules = project.enabled_modules
                     copy.trackers = project.trackers
                     copy.custom_values = project.custom_values.collect {|v| v.clone}
                     copy.issue_custom_fields = project.issue_custom_fields
                     return copy
                   else
                     return nil
                   end
                 rescue ActiveRecord::RecordNotFound
                   return nil
                 end
               end
               # Yields the given block for each project with its level in the tree
               def self.project_tree(projects, &block)
                 ancestors = []
                 projects.sort_by(&:lft).each do |project|
                   while (ancestors.any? && !project.is_descendant_of?(ancestors.last))
                     ancestors.pop
                   end
                   yield project, ancestors.size
                   ancestors << project
                 end
               end
               private
               # Copies wiki from +project+
               def copy_wiki(project)
                 # Check that the source project has a wiki first
                 unless project.wiki.nil?
                   self.wiki ||= Wiki.new
                   wiki.attributes = project.wiki.attributes.dup.except("id", "project_id")
                   wiki_pages_map = {}
                   project.wiki.pages.each do |page|
                     # Skip pages without content
                     next if page.content.nil?
                     new_wiki_content = WikiContent.new(page.content.attributes.dup.except("id", "page_id", "updated_on"))
                     new_wiki_page = WikiPage.new(page.attributes.dup.except("id", "wiki_id", "created_on", "parent_id"))
                     new_wiki_page.content = new_wiki_content
                     wiki.pages << new_wiki_page
                     wiki_pages_map[page.id] = new_wiki_page
                   end
                   wiki.save
                   # Reproduce page hierarchy
                   project.wiki.pages.each do |page|
                     if page.parent_id && wiki_pages_map[page.id]
                       wiki_pages_map[page.id].parent = wiki_pages_map[page.parent_id]
                       wiki_pages_map[page.id].save
                     end
                   end
                 end
               end
               # Copies versions from +project+
               def copy_versions(project)
                 project.versions.each do |version|
                   new_version = Version.new
                   new_version.attributes = version.attributes.dup.except("id", "project_id", "created_on", "updated_on")
                   self.versions << new_version
                 end
               end
               # Copies issue categories from +project+
               def copy_issue_categories(project)
                 project.issue_categories.each do |issue_category|
                   new_issue_category = IssueCategory.new
                   new_issue_category.attributes = issue_category.attributes.dup.except("id", "project_id")
                   self.issue_categories << new_issue_category
                 end
               end
               # Copies issues from +project+
               def copy_issues(project)
                 # Stores the source issue id as a key and the copied issues as the
                 # value.  Used to map the two togeather for issue relations.
                 issues_map = {}
                 # Store status and reopen locked/closed versions
                 version_statuses = versions.reject(&:open?).map {|version| [version, version.status]}
                 version_statuses.each do |version, status|
                   version.update_attribute :status, 'open'
                 end
                 # Get issues sorted by root_id, lft so that parent issues
                 # get copied before their children
-                project.issues.find(:all, :order => 'root_id, lft').each do |issue|
+                project.issues.reorder('root_id, lft').all.each do |issue|
                   new_issue = Issue.new
                   new_issue.copy_from(issue, :subtasks => false, :link => false)
                   new_issue.project = self
                   # Reassign fixed_versions by name, since names are unique per project
                   if issue.fixed_version && issue.fixed_version.project == project
                     new_issue.fixed_version = self.versions.detect {|v| v.name == issue.fixed_version.name}
                   end
                   # Reassign the category by name, since names are unique per project
                   if issue.category
                     new_issue.category = self.issue_categories.detect {|c| c.name == issue.category.name}
                   end
                   # Parent issue
                   if issue.parent_id
                     if copied_parent = issues_map[issue.parent_id]
                       new_issue.parent_issue_id = copied_parent.id
                     end
                   end
                   self.issues << new_issue
                   if new_issue.new_record?
                     logger.info "Project#copy_issues: issue ##{issue.id} could not be copied: #{new_issue.errors.full_messages}" if logger && logger.info
                   else
                     issues_map[issue.id] = new_issue unless new_issue.new_record?
                   end
                 end
                 # Restore locked/closed version statuses
                 version_statuses.each do |version, status|
                   version.update_attribute :status, status
                 end
                 # Relations after in case issues related each other
                 project.issues.each do |issue|
                   new_issue = issues_map[issue.id]
                   unless new_issue
                     # Issue was not copied
                     next
                   end
                   # Relations
                   issue.relations_from.each do |source_relation|
                     new_issue_relation = IssueRelation.new
                     new_issue_relation.attributes = source_relation.attributes.dup.except("id", "issue_from_id", "issue_to_id")
                     new_issue_relation.issue_to = issues_map[source_relation.issue_to_id]
                     if new_issue_relation.issue_to.nil? && Setting.cross_project_issue_relations?
                       new_issue_relation.issue_to = source_relation.issue_to
                     end
                     new_issue.relations_from << new_issue_relation
                   end
                   issue.relations_to.each do |source_relation|
                     new_issue_relation = IssueRelation.new
                     new_issue_relation.attributes = source_relation.attributes.dup.except("id", "issue_from_id", "issue_to_id")
                     new_issue_relation.issue_from = issues_map[source_relation.issue_from_id]
                     if new_issue_relation.issue_from.nil? && Setting.cross_project_issue_relations?
                       new_issue_relation.issue_from = source_relation.issue_from
                     end
                     new_issue.relations_to << new_issue_relation
                   end
                 end
               end
               # Copies members from +project+
               def copy_members(project)
                 # Copy users first, then groups to handle members with inherited and given roles
                 members_to_copy = []
                 members_to_copy += project.memberships.select {|m| m.principal.is_a?(User)}
                 members_to_copy += project.memberships.select {|m| !m.principal.is_a?(User)}
                 members_to_copy.each do |member|
                   new_member = Member.new
                   new_member.attributes = member.attributes.dup.except("id", "project_id", "created_on")
                   # only copy non inherited roles
                   # inherited roles will be added when copying the group membership
                   role_ids = member.member_roles.reject(&:inherited?).collect(&:role_id)
                   next if role_ids.empty?
                   new_member.role_ids = role_ids
                   new_member.project = self
                   self.members << new_member
                 end
               end
               # Copies queries from +project+
               def copy_queries(project)
                 project.queries.each do |query|
                   new_query = ::Query.new
                   new_query.attributes = query.attributes.dup.except("id", "project_id", "sort_criteria")
                   new_query.sort_criteria = query.sort_criteria if query.sort_criteria
                   new_query.project = self
                   new_query.user_id = query.user_id
                   self.queries << new_query
                 end
               end
               # Copies boards from +project+
               def copy_boards(project)
                 project.boards.each do |board|
                   new_board = Board.new
                   new_board.attributes = board.attributes.dup.except("id", "project_id", "topics_count", "messages_count", "last_message_id")
                   new_board.project = self
                   self.boards << new_board
                 end
               end
               def allowed_permissions
                 @allowed_permissions ||= begin
                   module_names = enabled_modules.all(:select => :name).collect {|m| m.name}
                   Redmine::AccessControl.modules_permissions(module_names).collect {|p| p.name}
                 end
               end
               def allowed_actions
                 @actions_allowed ||= allowed_permissions.inject([]) { |actions, permission| actions += Redmine::AccessControl.allowed_actions(permission) }.flatten
               end
               # Returns all the active Systemwide and project specific activities
               def active_activities
                 overridden_activity_ids = self.time_entry_activities.collect(&:parent_id)
                 if overridden_activity_ids.empty?
                   return TimeEntryActivity.shared.active
                 else
                   return system_activities_and_project_overrides
                 end
               end
               # Returns all the Systemwide and project specific activities
               # (inactive and active)
               def all_activities
                 overridden_activity_ids = self.time_entry_activities.collect(&:parent_id)
                 if overridden_activity_ids.empty?
                   return TimeEntryActivity.shared
                 else
                   return system_activities_and_project_overrides(true)
                 end
               end
               # Returns the systemwide active activities merged with the project specific overrides
               def system_activities_and_project_overrides(include_inactive=false)
                 if include_inactive
                   return TimeEntryActivity.shared.
-                    find(:all,
+                    where("id NOT IN (?)", self.time_entry_activities.collect(&:parent_id)).all +
-                         :conditions => ["id NOT IN (?)", self.time_entry_activities.collect(&:parent_id)]) +
                     self.time_entry_activities
                 else
                   return TimeEntryActivity.shared.active.
-                    find(:all,
+                    where("id NOT IN (?)", self.time_entry_activities.collect(&:parent_id)).all +
-                         :conditions => ["id NOT IN (?)", self.time_entry_activities.collect(&:parent_id)]) +
                     self.time_entry_activities.active
                 end
               end
               # Archives subprojects recursively
               def archive!
                 children.each do |subproject|
                   subproject.send :archive!
                 end
                 update_attribute :status, STATUS_ARCHIVED
               end
               def update_position_under_parent
                 set_or_update_position_under(parent)
               end
               # Inserts/moves the project so that target's children or root projects stay alphabetically sorted
               def set_or_update_position_under(target_parent)
                 sibs = (target_parent.nil? ? self.class.roots : target_parent.children)
                 to_be_inserted_before = sibs.sort_by {|c| c.name.to_s.downcase}.detect {|c| c.name.to_s.downcase > name.to_s.downcase }
                 if to_be_inserted_before
                   move_to_left_of(to_be_inserted_before)
                 elsif target_parent.nil?
                   if sibs.empty?
                     # move_to_root adds the project in first (ie. left) position
                     move_to_root
                   else
                     move_to_right_of(sibs.last) unless self == sibs.last
                   end
                 else
                   # move_to_child_of adds the project in last (ie.right) position
                   move_to_child_of(target_parent)
                 end
               end
             end

app/models/query.rb +4 -9

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class QueryColumn
               attr_accessor :name, :sortable, :groupable, :default_order
               include Redmine::I18n
               def initialize(name, options={})
                 self.name = name
                 self.sortable = options[:sortable]
                 self.groupable = options[:groupable] || false
                 if groupable == true
                   self.groupable = name.to_s
                 end
                 self.default_order = options[:default_order]
                 @caption_key = options[:caption] || "field_#{name}"
               end
               def caption
                 l(@caption_key)
               end
               # Returns true if the column is sortable, otherwise false
               def sortable?
                 !@sortable.nil?
               end
               def sortable
                 @sortable.is_a?(Proc) ? @sortable.call : @sortable
               end
               def value(issue)
                 issue.send name
               end
               def css_classes
                 name
               end
             end
             class QueryCustomFieldColumn < QueryColumn
               def initialize(custom_field)
                 self.name = "cf_#{custom_field.id}".to_sym
                 self.sortable = custom_field.order_statement || false
                 self.groupable = custom_field.group_statement || false
                 @cf = custom_field
               end
               def caption
                 @cf.name
               end
               def custom_field
                 @cf
               end
               def value(issue)
                 cv = issue.custom_values.select {|v| v.custom_field_id == @cf.id}.collect {|v| @cf.cast_value(v.value)}
                 cv.size > 1 ? cv.sort {|a,b| a.to_s <=> b.to_s} : cv.first
               end
               def css_classes
                 @css_classes ||= "#{name} #{@cf.field_format}"
               end
             end
             class Query < ActiveRecord::Base
               class StatementInvalid < ::ActiveRecord::StatementInvalid
               end
               belongs_to :project
               belongs_to :user
               serialize :filters
               serialize :column_names
               serialize :sort_criteria, Array
               attr_protected :project_id, :user_id
               validates_presence_of :name
               validates_length_of :name, :maximum => 255
               validate :validate_query_filters
               @@operators = { "="   => :label_equals,
                               "!"   => :label_not_equals,
                               "o"   => :label_open_issues,
                               "c"   => :label_closed_issues,
                               "!*"  => :label_none,
                               "*"   => :label_any,
                               ">="  => :label_greater_or_equal,
                               "<="  => :label_less_or_equal,
                               "><"  => :label_between,
                               "<t+" => :label_in_less_than,
                               ">t+" => :label_in_more_than,
                               "><t+"=> :label_in_the_next_days,
                               "t+"  => :label_in,
                               "t"   => :label_today,
                               "w"   => :label_this_week,
                               ">t-" => :label_less_than_ago,
                               "<t-" => :label_more_than_ago,
                               "><t-"=> :label_in_the_past_days,
                               "t-"  => :label_ago,
                               "~"   => :label_contains,
                               "!~"  => :label_not_contains,
                               "=p"  => :label_any_issues_in_project,
                               "=!p" => :label_any_issues_not_in_project,
                               "!p"  => :label_no_issues_in_project}
               cattr_reader :operators
               @@operators_by_filter_type = { :list => [ "=", "!" ],
                                              :list_status => [ "o", "=", "!", "c", "*" ],
                                              :list_optional => [ "=", "!", "!*", "*" ],
                                              :list_subprojects => [ "*", "!*", "=" ],
                                              :date => [ "=", ">=", "<=", "><", "<t+", ">t+", "><t+", "t+", "t", "w", ">t-", "<t-", "><t-", "t-", "!*", "*" ],
                                              :date_past => [ "=", ">=", "<=", "><", ">t-", "<t-", "><t-", "t-", "t", "w", "!*", "*" ],
                                              :string => [ "=", "~", "!", "!~", "!*", "*" ],
                                              :text => [  "~", "!~", "!*", "*" ],
                                              :integer => [ "=", ">=", "<=", "><", "!*", "*" ],
                                              :float => [ "=", ">=", "<=", "><", "!*", "*" ],
                                              :relation => ["=", "=p", "=!p", "!p", "!*", "*"]}
               cattr_reader :operators_by_filter_type
               @@available_columns = [
                 QueryColumn.new(:project, :sortable => "#{Project.table_name}.name", :groupable => true),
                 QueryColumn.new(:tracker, :sortable => "#{Tracker.table_name}.position", :groupable => true),
                 QueryColumn.new(:parent, :sortable => ["#{Issue.table_name}.root_id", "#{Issue.table_name}.lft ASC"], :default_order => 'desc', :caption => :field_parent_issue),
                 QueryColumn.new(:status, :sortable => "#{IssueStatus.table_name}.position", :groupable => true),
                 QueryColumn.new(:priority, :sortable => "#{IssuePriority.table_name}.position", :default_order => 'desc', :groupable => true),
                 QueryColumn.new(:subject, :sortable => "#{Issue.table_name}.subject"),
                 QueryColumn.new(:author, :sortable => lambda {User.fields_for_order_statement("authors")}, :groupable => true),
                 QueryColumn.new(:assigned_to, :sortable => lambda {User.fields_for_order_statement}, :groupable => true),
                 QueryColumn.new(:updated_on, :sortable => "#{Issue.table_name}.updated_on", :default_order => 'desc'),
                 QueryColumn.new(:category, :sortable => "#{IssueCategory.table_name}.name", :groupable => true),
                 QueryColumn.new(:fixed_version, :sortable => lambda {Version.fields_for_order_statement}, :groupable => true),
                 QueryColumn.new(:start_date, :sortable => "#{Issue.table_name}.start_date"),
                 QueryColumn.new(:due_date, :sortable => "#{Issue.table_name}.due_date"),
                 QueryColumn.new(:estimated_hours, :sortable => "#{Issue.table_name}.estimated_hours"),
                 QueryColumn.new(:done_ratio, :sortable => "#{Issue.table_name}.done_ratio", :groupable => true),
                 QueryColumn.new(:created_on, :sortable => "#{Issue.table_name}.created_on", :default_order => 'desc'),
                 QueryColumn.new(:relations, :caption => :label_related_issues)
               ]
               cattr_reader :available_columns
               scope :visible, lambda {|*args|
                 user = args.shift || User.current
                 base = Project.allowed_to_condition(user, :view_issues, *args)
                 user_id = user.logged? ? user.id : 0
                 {
                   :conditions => ["(#{table_name}.project_id IS NULL OR (#{base})) AND (#{table_name}.is_public = ? OR #{table_name}.user_id = ?)", true, user_id],
                   :include => :project
                 }
               }
               def initialize(attributes=nil, *args)
                 super attributes
                 self.filters ||= { 'status_id' => {:operator => "o", :values => [""]} }
                 @is_for_all = project.nil?
               end
               def validate_query_filters
                 filters.each_key do |field|
                   if values_for(field)
                     case type_for(field)
                     when :integer
                       add_filter_error(field, :invalid) if values_for(field).detect {|v| v.present? && !v.match(/^[+-]?\d+$/) }
                     when :float
                       add_filter_error(field, :invalid) if values_for(field).detect {|v| v.present? && !v.match(/^[+-]?\d+(\.\d*)?$/) }
                     when :date, :date_past
                       case operator_for(field)
                       when "=", ">=", "<=", "><"
                         add_filter_error(field, :invalid) if values_for(field).detect {|v| v.present? && (!v.match(/^\d{4}-\d{2}-\d{2}$/) || (Date.parse(v) rescue nil).nil?) }
                       when ">t-", "<t-", "t-", ">t+", "<t+", "t+", "><t+", "><t-"
                         add_filter_error(field, :invalid) if values_for(field).detect {|v| v.present? && !v.match(/^\d+$/) }
                       end
                     end
                   end
                   add_filter_error(field, :blank) unless
                       # filter requires one or more values
                       (values_for(field) and !values_for(field).first.blank?) or
                       # filter doesn't require any value
                       ["o", "c", "!*", "*", "t", "w"].include? operator_for(field)
                 end if filters
               end
               def add_filter_error(field, message)
                 m = label_for(field) + " " + l(message, :scope => 'activerecord.errors.messages')
                 errors.add(:base, m)
               end
               # Returns true if the query is visible to +user+ or the current user.
               def visible?(user=User.current)
                 (project.nil? || user.allowed_to?(:view_issues, project)) && (self.is_public? || self.user_id == user.id)
               end
               def editable_by?(user)
                 return false unless user
                 # Admin can edit them all and regular users can edit their private queries
                 return true if user.admin? || (!is_public && self.user_id == user.id)
                 # Members can not edit public queries that are for all project (only admin is allowed to)
                 is_public && !@is_for_all && user.allowed_to?(:manage_public_queries, project)
               end
               def trackers
-                @trackers ||= project.nil? ? Tracker.find(:all, :order => 'position') : project.rolled_up_trackers
+                @trackers ||= project.nil? ? Tracker.sorted.all : project.rolled_up_trackers
               end
               # Returns a hash of localized labels for all filter operators
               def self.operators_labels
                 operators.inject({}) {|h, operator| h[operator.first] = l(operator.last); h}
               end
               def available_filters
                 return @available_filters if @available_filters
                 @available_filters = {
                   "status_id" => {
                     :type => :list_status, :order => 0,
-                    :values => IssueStatus.find(:all, :order => 'position').collect{|s| [s.name, s.id.to_s] }
+                    :values => IssueStatus.sorted.all.collect{|s| [s.name, s.id.to_s] }
                    },
                   "tracker_id" => {
                     :type => :list, :order => 2, :values => trackers.collect{|s| [s.name, s.id.to_s] }
                    },
                   "priority_id" => {
                     :type => :list, :order => 3, :values => IssuePriority.all.collect{|s| [s.name, s.id.to_s] }
                    },
                   "subject" => { :type => :text, :order => 8 },
                   "created_on" => { :type => :date_past, :order => 9 },
                   "updated_on" => { :type => :date_past, :order => 10 },
                   "start_date" => { :type => :date, :order => 11 },
                   "due_date" => { :type => :date, :order => 12 },
                   "estimated_hours" => { :type => :float, :order => 13 },
                   "done_ratio" =>  { :type => :integer, :order => 14 }
                 }
                 IssueRelation::TYPES.each do |relation_type, options|
                   @available_filters[relation_type] = {
                     :type => :relation, :order => @available_filters.size + 100,
                     :label => options[:name]
                   }
                 end
                 principals = []
                 if project
                   principals += project.principals.sort
                   unless project.leaf?
                     subprojects = project.descendants.visible.all
                     if subprojects.any?
                       @available_filters["subproject_id"] = {
                         :type => :list_subprojects, :order => 13,
                         :values => subprojects.collect{|s| [s.name, s.id.to_s] }
                       }
                       principals += Principal.member_of(subprojects)
                     end
                   end
                 else
                   if all_projects.any?
                     # members of visible projects
                     principals += Principal.member_of(all_projects)
                     # project filter
                     project_values = []
                     if User.current.logged? && User.current.memberships.any?
                       project_values << ["<< #{l(:label_my_projects).downcase} >>", "mine"]
                     end
                     project_values += all_projects_values
                     @available_filters["project_id"] = {
                       :type => :list, :order => 1, :values => project_values
                     } unless project_values.empty?
                   end
                 end
                 principals.uniq!
                 principals.sort!
                 users = principals.select {|p| p.is_a?(User)}
                 assigned_to_values = []
                 assigned_to_values << ["<< #{l(:label_me)} >>", "me"] if User.current.logged?
                 assigned_to_values += (Setting.issue_group_assignment? ?
                                           principals : users).collect{|s| [s.name, s.id.to_s] }
                 @available_filters["assigned_to_id"] = {
                   :type => :list_optional, :order => 4, :values => assigned_to_values
                 } unless assigned_to_values.empty?
                 author_values = []
                 author_values << ["<< #{l(:label_me)} >>", "me"] if User.current.logged?
                 author_values += users.collect{|s| [s.name, s.id.to_s] }
                 @available_filters["author_id"] = {
                   :type => :list, :order => 5, :values => author_values
                 } unless author_values.empty?
                 group_values = Group.all.collect {|g| [g.name, g.id.to_s] }
                 @available_filters["member_of_group"] = {
                   :type => :list_optional, :order => 6, :values => group_values
                 } unless group_values.empty?
                 role_values = Role.givable.collect {|r| [r.name, r.id.to_s] }
                 @available_filters["assigned_to_role"] = {
                   :type => :list_optional, :order => 7, :values => role_values
                 } unless role_values.empty?
                 if User.current.logged?
                   @available_filters["watcher_id"] = {
                     :type => :list, :order => 15, :values => [["<< #{l(:label_me)} >>", "me"]]
                   }
                 end
                 if project
                   # project specific filters
                   categories = project.issue_categories.all
                   unless categories.empty?
                     @available_filters["category_id"] = {
                       :type => :list_optional, :order => 6,
                       :values => categories.collect{|s| [s.name, s.id.to_s] }
                     }
                   end
                   versions = project.shared_versions.all
                   unless versions.empty?
                     @available_filters["fixed_version_id"] = {
                       :type => :list_optional, :order => 7,
                       :values => versions.sort.collect{|s| ["#{s.project.name} - #{s.name}", s.id.to_s] }
                     }
                   end
                   add_custom_fields_filters(project.all_issue_custom_fields)
                 else
                   # global filters for cross project issue list
                   system_shared_versions = Version.visible.find_all_by_sharing('system')
                   unless system_shared_versions.empty?
                     @available_filters["fixed_version_id"] = {
                       :type => :list_optional, :order => 7,
                       :values => system_shared_versions.sort.collect{|s|
                                                    ["#{s.project.name} - #{s.name}", s.id.to_s]
                                                  }
                     }
                   end
-                  add_custom_fields_filters(
+                  add_custom_fields_filters(IssueCustomField.where(:is_filter => true, :is_for_all => true).all)
-                               IssueCustomField.find(:all,
-                                                     :conditions => {
-                                                        :is_filter => true,
-                                                        :is_for_all => true
-                                                     }))
                 end
                 add_associations_custom_fields_filters :project, :author, :assigned_to, :fixed_version
                 if User.current.allowed_to?(:set_issues_private, nil, :global => true) ||
                   User.current.allowed_to?(:set_own_issues_private, nil, :global => true)
                   @available_filters["is_private"] = {
                     :type => :list, :order => 16,
                     :values => [[l(:general_text_yes), "1"], [l(:general_text_no), "0"]]
                   }
                 end
                 Tracker.disabled_core_fields(trackers).each {|field|
                   @available_filters.delete field
                 }
                 @available_filters.each do |field, options|
                   options[:name] ||= l(options[:label] || "field_#{field}".gsub(/_id$/, ''))
                 end
                 @available_filters
               end
               # Returns a representation of the available filters for JSON serialization
               def available_filters_as_json
                 json = {}
                 available_filters.each do |field, options|
                   json[field] = options.slice(:type, :name, :values).stringify_keys
                 end
                 json
               end
               def all_projects
                 @all_projects ||= Project.visible.all
               end
               def all_projects_values
                 return @all_projects_values if @all_projects_values
                 values = []
                 Project.project_tree(all_projects) do |p, level|
                   prefix = (level > 0 ? ('--' * level + ' ') : '')
                   values << ["#{prefix}#{p.name}", p.id.to_s]
                 end
                 @all_projects_values = values
               end
               def add_filter(field, operator, values)
                 # values must be an array
                 return unless values.nil? || values.is_a?(Array)
                 # check if field is defined as an available filter
                 if available_filters.has_key? field
                   filter_options = available_filters[field]
                   # check if operator is allowed for that filter
                   #if @@operators_by_filter_type[filter_options[:type]].include? operator
                   #  allowed_values = values & ([""] + (filter_options[:values] || []).collect {|val| val[1]})
                   #  filters[field] = {:operator => operator, :values => allowed_values } if (allowed_values.first and !allowed_values.first.empty?) or ["o", "c", "!*", "*", "t"].include? operator
                   #end
                   filters[field] = {:operator => operator, :values => (values || [''])}
                 end
               end
               def add_short_filter(field, expression)
                 return unless expression && available_filters.has_key?(field)
                 field_type = available_filters[field][:type]
                 @@operators_by_filter_type[field_type].sort.reverse.detect do |operator|
                   next unless expression =~ /^#{Regexp.escape(operator)}(.*)$/
                   add_filter field, operator, $1.present? ? $1.split('|') : ['']
                 end || add_filter(field, '=', expression.split('|'))
               end
               # Add multiple filters using +add_filter+
               def add_filters(fields, operators, values)
                 if fields.is_a?(Array) && operators.is_a?(Hash) && (values.nil? || values.is_a?(Hash))
                   fields.each do |field|
                     add_filter(field, operators[field], values && values[field])
                   end
                 end
               end
               def has_filter?(field)
                 filters and filters[field]
               end
               def type_for(field)
                 available_filters[field][:type] if available_filters.has_key?(field)
               end
               def operator_for(field)
                 has_filter?(field) ? filters[field][:operator] : nil
               end
               def values_for(field)
                 has_filter?(field) ? filters[field][:values] : nil
               end
               def value_for(field, index=0)
                 (values_for(field) || [])[index]
               end
               def label_for(field)
                 label = available_filters[field][:name] if available_filters.has_key?(field)
                 label ||= l("field_#{field.to_s.gsub(/_id$/, '')}", :default => field)
               end
               def available_columns
                 return @available_columns if @available_columns
                 @available_columns = ::Query.available_columns.dup
                 @available_columns += (project ?
                                         project.all_issue_custom_fields :
-                                        IssueCustomField.find(:all)
+                                        IssueCustomField.all
                                        ).collect {|cf| QueryCustomFieldColumn.new(cf) }
                 if User.current.allowed_to?(:view_time_entries, project, :global => true)
                   index = nil
                   @available_columns.each_with_index {|column, i| index = i if column.name == :estimated_hours}
                   index = (index ? index + 1 : -1)
                   # insert the column after estimated_hours or at the end
                   @available_columns.insert index, QueryColumn.new(:spent_hours,
                     :sortable => "(SELECT COALESCE(SUM(hours), 0) FROM #{TimeEntry.table_name} WHERE #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id)",
                     :default_order => 'desc',
                     :caption => :label_spent_time
                   )
                 end
                 if User.current.allowed_to?(:set_issues_private, nil, :global => true) ||
                   User.current.allowed_to?(:set_own_issues_private, nil, :global => true)
                   @available_columns << QueryColumn.new(:is_private, :sortable => "#{Issue.table_name}.is_private")
                 end
                 disabled_fields = Tracker.disabled_core_fields(trackers).map {|field| field.sub(/_id$/, '')}
                 @available_columns.reject! {|column|
                   disabled_fields.include?(column.name.to_s)
                 }
                 @available_columns
               end
               def self.available_columns=(v)
                 self.available_columns = (v)
               end
               def self.add_available_column(column)
                 self.available_columns << (column) if column.is_a?(QueryColumn)
               end
               # Returns an array of columns that can be used to group the results
               def groupable_columns
                 available_columns.select {|c| c.groupable}
               end
               # Returns a Hash of columns and the key for sorting
               def sortable_columns
                 {'id' => "#{Issue.table_name}.id"}.merge(available_columns.inject({}) {|h, column|
                                                            h[column.name.to_s] = column.sortable
                                                            h
                                                          })
               end
               def columns
                 # preserve the column_names order
                 (has_default_columns? ? default_columns_names : column_names).collect do |name|
                    available_columns.find { |col| col.name == name }
                 end.compact
               end
               def default_columns_names
                 @default_columns_names ||= begin
                   default_columns = Setting.issue_list_default_columns.map(&:to_sym)
                   project.present? ? default_columns : [:project] | default_columns
                 end
               end
               def column_names=(names)
                 if names
                   names = names.select {|n| n.is_a?(Symbol) || !n.blank? }
                   names = names.collect {|n| n.is_a?(Symbol) ? n : n.to_sym }
                   # Set column_names to nil if default columns
                   if names == default_columns_names
                     names = nil
                   end
                 end
                 write_attribute(:column_names, names)
               end
               def has_column?(column)
                 column_names && column_names.include?(column.is_a?(QueryColumn) ? column.name : column)
               end
               def has_default_columns?
                 column_names.nil? || column_names.empty?
               end
               def sort_criteria=(arg)
                 c = []
                 if arg.is_a?(Hash)
                   arg = arg.keys.sort.collect {|k| arg[k]}
                 end
                 c = arg.select {|k,o| !k.to_s.blank?}.slice(0,3).collect {|k,o| [k.to_s, (o == 'desc' || o == false) ? 'desc' : 'asc']}
                 write_attribute(:sort_criteria, c)
               end
               def sort_criteria
                 read_attribute(:sort_criteria) || []
               end
               def sort_criteria_key(arg)
                 sort_criteria && sort_criteria[arg] && sort_criteria[arg].first
               end
               def sort_criteria_order(arg)
                 sort_criteria && sort_criteria[arg] && sort_criteria[arg].last
               end
               def sort_criteria_order_for(key)
                 sort_criteria.detect {|k, order| key.to_s == k}.try(:last)
               end
               # Returns the SQL sort order that should be prepended for grouping
               def group_by_sort_order
                 if grouped? && (column = group_by_column)
                   order = sort_criteria_order_for(column.name) || column.default_order
                   column.sortable.is_a?(Array) ?
                     column.sortable.collect {|s| "#{s} #{order}"}.join(',') :
                     "#{column.sortable} #{order}"
                 end
               end
               # Returns true if the query is a grouped query
               def grouped?
                 !group_by_column.nil?
               end
               def group_by_column
                 groupable_columns.detect {|c| c.groupable && c.name.to_s == group_by}
               end
               def group_by_statement
                 group_by_column.try(:groupable)
               end
               def project_statement
                 project_clauses = []
                 if project && !project.descendants.active.empty?
                   ids = [project.id]
                   if has_filter?("subproject_id")
                     case operator_for("subproject_id")
                     when '='
                       # include the selected subprojects
                       ids += values_for("subproject_id").each(&:to_i)
                     when '!*'
                       # main project only
                     else
                       # all subprojects
                       ids += project.descendants.collect(&:id)
                     end
                   elsif Setting.display_subprojects_issues?
                     ids += project.descendants.collect(&:id)
                   end
                   project_clauses << "#{Project.table_name}.id IN (%s)" % ids.join(',')
                 elsif project
                   project_clauses << "#{Project.table_name}.id = %d" % project.id
                 end
                 project_clauses.any? ? project_clauses.join(' AND ') : nil
               end
               def statement
                 # filters clauses
                 filters_clauses = []
                 filters.each_key do |field|
                   next if field == "subproject_id"
                   v = values_for(field).clone
                   next unless v and !v.empty?
                   operator = operator_for(field)
                   # "me" value subsitution
                   if %w(assigned_to_id author_id watcher_id).include?(field)
                     if v.delete("me")
                       if User.current.logged?
                         v.push(User.current.id.to_s)
                         v += User.current.group_ids.map(&:to_s) if field == 'assigned_to_id'
                       else
                         v.push("0")
                       end
                     end
                   end
                   if field == 'project_id'
                     if v.delete('mine')
                       v += User.current.memberships.map(&:project_id).map(&:to_s)
                     end
                   end
                   if field =~ /cf_(\d+)$/
                     # custom field
                     filters_clauses << sql_for_custom_field(field, operator, v, $1)
                   elsif respond_to?("sql_for_#{field}_field")
                     # specific statement
                     filters_clauses << send("sql_for_#{field}_field", field, operator, v)
                   else
                     # regular field
                     filters_clauses << '(' + sql_for_field(field, operator, v, Issue.table_name, field) + ')'
                   end
                 end if filters and valid?
                 filters_clauses << project_statement
                 filters_clauses.reject!(&:blank?)
                 filters_clauses.any? ? filters_clauses.join(' AND ') : nil
               end
               # Returns the issue count
               def issue_count
                 Issue.visible.count(:include => [:status, :project], :conditions => statement)
               rescue ::ActiveRecord::StatementInvalid => e
                 raise StatementInvalid.new(e.message)
               end
               # Returns the issue count by group or nil if query is not grouped
               def issue_count_by_group
                 r = nil
                 if grouped?
                   begin
                     # Rails3 will raise an (unexpected) RecordNotFound if there's only a nil group value
                     r = Issue.visible.count(:group => group_by_statement, :include => [:status, :project], :conditions => statement)
                   rescue ActiveRecord::RecordNotFound
                     r = {nil => issue_count}
                   end
                   c = group_by_column
                   if c.is_a?(QueryCustomFieldColumn)
                     r = r.keys.inject({}) {|h, k| h[c.custom_field.cast_value(k)] = r[k]; h}
                   end
                 end
                 r
               rescue ::ActiveRecord::StatementInvalid => e
                 raise StatementInvalid.new(e.message)
               end
               # Returns the issues
               # Valid options are :order, :offset, :limit, :include, :conditions
               def issues(options={})
                 order_option = [group_by_sort_order, options[:order]].reject {|s| s.blank?}.join(',')
                 order_option = nil if order_option.blank?
                 issues = Issue.visible.scoped(:conditions => options[:conditions]).find :all, :include => ([:status, :project] + (options[:include] || [])).uniq,
                                  :conditions => statement,
                                  :order => order_option,
                                  :joins => joins_for_order_statement(order_option),
                                  :limit  => options[:limit],
                                  :offset => options[:offset]
                 if has_column?(:spent_hours)
                   Issue.load_visible_spent_hours(issues)
                 end
                 if has_column?(:relations)
                   Issue.load_visible_relations(issues)
                 end
                 issues
               rescue ::ActiveRecord::StatementInvalid => e
                 raise StatementInvalid.new(e.message)
               end
               # Returns the issues ids
               def issue_ids(options={})
                 order_option = [group_by_sort_order, options[:order]].reject {|s| s.blank?}.join(',')
                 order_option = nil if order_option.blank?
                 Issue.visible.scoped(:conditions => options[:conditions]).scoped(:include => ([:status, :project] + (options[:include] || [])).uniq,
                                  :conditions => statement,
                                  :order => order_option,
                                  :joins => joins_for_order_statement(order_option),
                                  :limit  => options[:limit],
                                  :offset => options[:offset]).find_ids
               rescue ::ActiveRecord::StatementInvalid => e
                 raise StatementInvalid.new(e.message)
               end
               # Returns the journals
               # Valid options are :order, :offset, :limit
               def journals(options={})
                 Journal.visible.find :all, :include => [:details, :user, {:issue => [:project, :author, :tracker, :status]}],
                                    :conditions => statement,
                                    :order => options[:order],
                                    :limit => options[:limit],
                                    :offset => options[:offset]
               rescue ::ActiveRecord::StatementInvalid => e
                 raise StatementInvalid.new(e.message)
               end
               # Returns the versions
               # Valid options are :conditions
               def versions(options={})
                 Version.visible.scoped(:conditions => options[:conditions]).find :all, :include => :project, :conditions => project_statement
               rescue ::ActiveRecord::StatementInvalid => e
                 raise StatementInvalid.new(e.message)
               end
               def sql_for_watcher_id_field(field, operator, value)
                 db_table = Watcher.table_name
                 "#{Issue.table_name}.id #{ operator == '=' ? 'IN' : 'NOT IN' } (SELECT #{db_table}.watchable_id FROM #{db_table} WHERE #{db_table}.watchable_type='Issue' AND " +
                   sql_for_field(field, '=', value, db_table, 'user_id') + ')'
               end
               def sql_for_member_of_group_field(field, operator, value)
                 if operator == '*' # Any group
                   groups = Group.all
                   operator = '=' # Override the operator since we want to find by assigned_to
                 elsif operator == "!*"
                   groups = Group.all
                   operator = '!' # Override the operator since we want to find by assigned_to
                 else
                   groups = Group.find_all_by_id(value)
                 end
                 groups ||= []
                 members_of_groups = groups.inject([]) {|user_ids, group|
                   if group && group.user_ids.present?
                     user_ids << group.user_ids
                   end
                   user_ids.flatten.uniq.compact
                 }.sort.collect(&:to_s)
                 '(' + sql_for_field("assigned_to_id", operator, members_of_groups, Issue.table_name, "assigned_to_id", false) + ')'
               end
               def sql_for_assigned_to_role_field(field, operator, value)
                 case operator
                 when "*", "!*" # Member / Not member
                   sw = operator == "!*" ? 'NOT' : ''
                   nl = operator == "!*" ? "#{Issue.table_name}.assigned_to_id IS NULL OR" : ''
                   "(#{nl} #{Issue.table_name}.assigned_to_id #{sw} IN (SELECT DISTINCT #{Member.table_name}.user_id FROM #{Member.table_name}" +
                     " WHERE #{Member.table_name}.project_id = #{Issue.table_name}.project_id))"
                 when "=", "!"
                   role_cond = value.any? ?
                     "#{MemberRole.table_name}.role_id IN (" + value.collect{|val| "'#{connection.quote_string(val)}'"}.join(",") + ")" :
                     "1=0"
                   sw = operator == "!" ? 'NOT' : ''
                   nl = operator == "!" ? "#{Issue.table_name}.assigned_to_id IS NULL OR" : ''
                   "(#{nl} #{Issue.table_name}.assigned_to_id #{sw} IN (SELECT DISTINCT #{Member.table_name}.user_id FROM #{Member.table_name}, #{MemberRole.table_name}" +
                     " WHERE #{Member.table_name}.project_id = #{Issue.table_name}.project_id AND #{Member.table_name}.id = #{MemberRole.table_name}.member_id AND #{role_cond}))"
                 end
               end
               def sql_for_is_private_field(field, operator, value)
                 op = (operator == "=" ? 'IN' : 'NOT IN')
                 va = value.map {|v| v == '0' ? connection.quoted_false : connection.quoted_true}.uniq.join(',')
                 "#{Issue.table_name}.is_private #{op} (#{va})"
               end
               def sql_for_relations(field, operator, value, options={})
                 relation_options = IssueRelation::TYPES[field]
                 return relation_options unless relation_options
                 relation_type = field
                 join_column, target_join_column = "issue_from_id", "issue_to_id"
                 if relation_options[:reverse] || options[:reverse]
                   relation_type = relation_options[:reverse] || relation_type
                   join_column, target_join_column = target_join_column, join_column
                 end
                 sql = case operator
                   when "*", "!*"
                     op = (operator == "*" ? 'IN' : 'NOT IN')
                     "#{Issue.table_name}.id #{op} (SELECT DISTINCT #{IssueRelation.table_name}.#{join_column} FROM #{IssueRelation.table_name} WHERE #{IssueRelation.table_name}.relation_type = '#{connection.quote_string(relation_type)}')"
                   when "=", "!"
                     op = (operator == "=" ? 'IN' : 'NOT IN')
                     "#{Issue.table_name}.id #{op} (SELECT DISTINCT #{IssueRelation.table_name}.#{join_column} FROM #{IssueRelation.table_name} WHERE #{IssueRelation.table_name}.relation_type = '#{connection.quote_string(relation_type)}' AND #{IssueRelation.table_name}.#{target_join_column} = #{value.first.to_i})"
                   when "=p", "=!p", "!p"
                     op = (operator == "!p" ? 'NOT IN' : 'IN')
                     comp = (operator == "=!p" ? '<>' : '=')
                     "#{Issue.table_name}.id #{op} (SELECT DISTINCT #{IssueRelation.table_name}.#{join_column} FROM #{IssueRelation.table_name}, #{Issue.table_name} relissues WHERE #{IssueRelation.table_name}.relation_type = '#{connection.quote_string(relation_type)}' AND #{IssueRelation.table_name}.#{target_join_column} = relissues.id AND relissues.project_id #{comp} #{value.first.to_i})"
                   end
                 if relation_options[:sym] == field && !options[:reverse]
                   sqls = [sql, sql_for_relations(field, operator, value, :reverse => true)]
                   sqls.join(["!", "!*", "!p"].include?(operator) ? " AND " : " OR ")
                 else
                   sql
                 end
               end
               IssueRelation::TYPES.keys.each do |relation_type|
                 alias_method "sql_for_#{relation_type}_field".to_sym, :sql_for_relations
               end
               private
               def sql_for_custom_field(field, operator, value, custom_field_id)
                 db_table = CustomValue.table_name
                 db_field = 'value'
                 filter = @available_filters[field]
                 return nil unless filter
                 if filter[:format] == 'user'
                   if value.delete('me')
                     value.push User.current.id.to_s
                   end
                 end
                 not_in = nil
                 if operator == '!'
                   # Makes ! operator work for custom fields with multiple values
                   operator = '='
                   not_in = 'NOT'
                 end
                 customized_key = "id"
                 customized_class = Issue
                 if field =~ /^(.+)\.cf_/
                   assoc = $1
                   customized_key = "#{assoc}_id"
                   customized_class = Issue.reflect_on_association(assoc.to_sym).klass.base_class rescue nil
                   raise "Unknown Issue association #{assoc}" unless customized_class
                 end
                 "#{Issue.table_name}.#{customized_key} #{not_in} IN (SELECT #{customized_class.table_name}.id FROM #{customized_class.table_name} LEFT OUTER JOIN #{db_table} ON #{db_table}.customized_type='#{customized_class}' AND #{db_table}.customized_id=#{customized_class.table_name}.id AND #{db_table}.custom_field_id=#{custom_field_id} WHERE " +
                   sql_for_field(field, operator, value, db_table, db_field, true) + ')'
               end
               # Helper method to generate the WHERE sql for a +field+, +operator+ and a +value+
               def sql_for_field(field, operator, value, db_table, db_field, is_custom_filter=false)
                 sql = ''
                 case operator
                 when "="
                   if value.any?
                     case type_for(field)
                     when :date, :date_past
                       sql = date_clause(db_table, db_field, (Date.parse(value.first) rescue nil), (Date.parse(value.first) rescue nil))
                     when :integer
                       if is_custom_filter
                         sql = "(#{db_table}.#{db_field} <> '' AND CAST(#{db_table}.#{db_field} AS decimal(60,3)) = #{value.first.to_i})"
                       else
                         sql = "#{db_table}.#{db_field} = #{value.first.to_i}"
                       end
                     when :float
                       if is_custom_filter
                         sql = "(#{db_table}.#{db_field} <> '' AND CAST(#{db_table}.#{db_field} AS decimal(60,3)) BETWEEN #{value.first.to_f - 1e-5} AND #{value.first.to_f + 1e-5})"
                       else
                         sql = "#{db_table}.#{db_field} BETWEEN #{value.first.to_f - 1e-5} AND #{value.first.to_f + 1e-5}"
                       end
                     else
                       sql = "#{db_table}.#{db_field} IN (" + value.collect{|val| "'#{connection.quote_string(val)}'"}.join(",") + ")"
                     end
                   else
                     # IN an empty set
                     sql = "1=0"
                   end
                 when "!"
                   if value.any?
                     sql = "(#{db_table}.#{db_field} IS NULL OR #{db_table}.#{db_field} NOT IN (" + value.collect{|val| "'#{connection.quote_string(val)}'"}.join(",") + "))"
                   else
                     # NOT IN an empty set
                     sql = "1=1"
                   end
                 when "!*"
                   sql = "#{db_table}.#{db_field} IS NULL"
                   sql << " OR #{db_table}.#{db_field} = ''" if is_custom_filter
                 when "*"
                   sql = "#{db_table}.#{db_field} IS NOT NULL"
                   sql << " AND #{db_table}.#{db_field} <> ''" if is_custom_filter
                 when ">="
                   if [:date, :date_past].include?(type_for(field))
                     sql = date_clause(db_table, db_field, (Date.parse(value.first) rescue nil), nil)
                   else
                     if is_custom_filter
                       sql = "(#{db_table}.#{db_field} <> '' AND CAST(#{db_table}.#{db_field} AS decimal(60,3)) >= #{value.first.to_f})"
                     else
                       sql = "#{db_table}.#{db_field} >= #{value.first.to_f}"
                     end
                   end
                 when "<="
                   if [:date, :date_past].include?(type_for(field))
                     sql = date_clause(db_table, db_field, nil, (Date.parse(value.first) rescue nil))
                   else
                     if is_custom_filter
                       sql = "(#{db_table}.#{db_field} <> '' AND CAST(#{db_table}.#{db_field} AS decimal(60,3)) <= #{value.first.to_f})"
                     else
                       sql = "#{db_table}.#{db_field} <= #{value.first.to_f}"
                     end
                   end
                 when "><"
                   if [:date, :date_past].include?(type_for(field))
                     sql = date_clause(db_table, db_field, (Date.parse(value[0]) rescue nil), (Date.parse(value[1]) rescue nil))
                   else
                     if is_custom_filter
                       sql = "(#{db_table}.#{db_field} <> '' AND CAST(#{db_table}.#{db_field} AS decimal(60,3)) BETWEEN #{value[0].to_f} AND #{value[1].to_f})"
                     else
                       sql = "#{db_table}.#{db_field} BETWEEN #{value[0].to_f} AND #{value[1].to_f}"
                     end
                   end
                 when "o"
                   sql = "#{Issue.table_name}.status_id IN (SELECT id FROM #{IssueStatus.table_name} WHERE is_closed=#{connection.quoted_false})" if field == "status_id"
                 when "c"
                   sql = "#{Issue.table_name}.status_id IN (SELECT id FROM #{IssueStatus.table_name} WHERE is_closed=#{connection.quoted_true})" if field == "status_id"
                 when "><t-"
                   # between today - n days and today
                   sql = relative_date_clause(db_table, db_field, - value.first.to_i, 0)
                 when ">t-"
                   # >= today - n days
                   sql = relative_date_clause(db_table, db_field, - value.first.to_i, nil)
                 when "<t-"
                   # <= today - n days
                   sql = relative_date_clause(db_table, db_field, nil, - value.first.to_i)
                 when "t-"
                   # = n days in past
                   sql = relative_date_clause(db_table, db_field, - value.first.to_i, - value.first.to_i)
                 when "><t+"
                   # between today and today + n days
                   sql = relative_date_clause(db_table, db_field, 0, value.first.to_i)
                 when ">t+"
                   # >= today + n days
                   sql = relative_date_clause(db_table, db_field, value.first.to_i, nil)
                 when "<t+"
                   # <= today + n days
                   sql = relative_date_clause(db_table, db_field, nil, value.first.to_i)
                 when "t+"
                   # = today + n days
                   sql = relative_date_clause(db_table, db_field, value.first.to_i, value.first.to_i)
                 when "t"
                   # = today
                   sql = relative_date_clause(db_table, db_field, 0, 0)
                 when "w"
                   # = this week
                   first_day_of_week = l(:general_first_day_of_week).to_i
                   day_of_week = Date.today.cwday
                   days_ago = (day_of_week >= first_day_of_week ? day_of_week - first_day_of_week : day_of_week + 7 - first_day_of_week)
                   sql = relative_date_clause(db_table, db_field, - days_ago, - days_ago + 6)
                 when "~"
                   sql = "LOWER(#{db_table}.#{db_field}) LIKE '%#{connection.quote_string(value.first.to_s.downcase)}%'"
                 when "!~"
                   sql = "LOWER(#{db_table}.#{db_field}) NOT LIKE '%#{connection.quote_string(value.first.to_s.downcase)}%'"
                 else
                   raise "Unknown query operator #{operator}"
                 end
                 return sql
               end
               def add_custom_fields_filters(custom_fields, assoc=nil)
                 return unless custom_fields.present?
                 @available_filters ||= {}
                 custom_fields.select(&:is_filter?).each do |field|
                   case field.field_format
                   when "text"
                     options = { :type => :text, :order => 20 }
                   when "list"
                     options = { :type => :list_optional, :values => field.possible_values, :order => 20}
                   when "date"
                     options = { :type => :date, :order => 20 }
                   when "bool"
                     options = { :type => :list, :values => [[l(:general_text_yes), "1"], [l(:general_text_no), "0"]], :order => 20 }
                   when "int"
                     options = { :type => :integer, :order => 20 }
                   when "float"
                     options = { :type => :float, :order => 20 }
                   when "user", "version"
                     next unless project
                     values = field.possible_values_options(project)
                     if User.current.logged? && field.field_format == 'user'
                       values.unshift ["<< #{l(:label_me)} >>", "me"]
                     end
                     options = { :type => :list_optional, :values => values, :order => 20}
                   else
                     options = { :type => :string, :order => 20 }
                   end
                   filter_id = "cf_#{field.id}"
                   filter_name = field.name
                   if assoc.present?
                     filter_id = "#{assoc}.#{filter_id}"
                     filter_name = l("label_attribute_of_#{assoc}", :name => filter_name)
                   end
                   @available_filters[filter_id] = options.merge({
                            :name => filter_name,
                            :format => field.field_format,
                            :field => field
                          })
                 end
               end
               def add_associations_custom_fields_filters(*associations)
                 fields_by_class = CustomField.where(:is_filter => true).group_by(&:class)
                 associations.each do |assoc|
                   association_klass = Issue.reflect_on_association(assoc).klass
                   fields_by_class.each do |field_class, fields|
                     if field_class.customized_class <= association_klass
                       add_custom_fields_filters(fields, assoc)
                     end
                   end
                 end
               end
               # Returns a SQL clause for a date or datetime field.
               def date_clause(table, field, from, to)
                 s = []
                 if from
                   from_yesterday = from - 1
                   from_yesterday_time = Time.local(from_yesterday.year, from_yesterday.month, from_yesterday.day)
                   if self.class.default_timezone == :utc
                     from_yesterday_time = from_yesterday_time.utc
                   end
                   s << ("#{table}.#{field} > '%s'" % [connection.quoted_date(from_yesterday_time.end_of_day)])
                 end
                 if to
                   to_time = Time.local(to.year, to.month, to.day)
                   if self.class.default_timezone == :utc
                     to_time = to_time.utc
                   end
                   s << ("#{table}.#{field} <= '%s'" % [connection.quoted_date(to_time.end_of_day)])
                 end
                 s.join(' AND ')
               end
               # Returns a SQL clause for a date or datetime field using relative dates.
               def relative_date_clause(table, field, days_from, days_to)
                 date_clause(table, field, (days_from ? Date.today + days_from : nil), (days_to ? Date.today + days_to : nil))
               end
               # Additional joins required for the given sort options
               def joins_for_order_statement(order_options)
                 joins = []
                 if order_options
                   if order_options.include?('authors')
                     joins << "LEFT OUTER JOIN #{User.table_name} authors ON authors.id = #{Issue.table_name}.author_id"
                   end
                   order_options.scan(/cf_\d+/).uniq.each do |name|
                     column = available_columns.detect {|c| c.name.to_s == name}
                     join = column && column.custom_field.join_for_order_statement
                     if join
                       joins << join
                     end
                   end
                 end
                 joins.any? ? joins.join(' ') : nil
               end
             end

app/models/repository.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class ScmFetchError < Exception; end
             class Repository < ActiveRecord::Base
               include Redmine::Ciphering
               include Redmine::SafeAttributes
               # Maximum length for repository identifiers
               IDENTIFIER_MAX_LENGTH = 255
               belongs_to :project
               has_many :changesets, :order => "#{Changeset.table_name}.committed_on DESC, #{Changeset.table_name}.id DESC"
               has_many :filechanges, :class_name => 'Change', :through => :changesets
               serialize :extra_info
               before_save :check_default
               # Raw SQL to delete changesets and changes in the database
               # has_many :changesets, :dependent => :destroy is too slow for big repositories
               before_destroy :clear_changesets
               validates_length_of :password, :maximum => 255, :allow_nil => true
               validates_length_of :identifier, :maximum => IDENTIFIER_MAX_LENGTH, :allow_blank => true
               validates_presence_of :identifier, :unless => Proc.new { |r| r.is_default? || r.set_as_default? }
               validates_uniqueness_of :identifier, :scope => :project_id, :allow_blank => true
               validates_exclusion_of :identifier, :in => %w(show entry raw changes annotate diff show stats graph)
               # donwcase letters, digits, dashes, underscores but not digits only
               validates_format_of :identifier, :with => /^(?!\d+$)[a-z0-9\-_]*$/, :allow_blank => true
               # Checks if the SCM is enabled when creating a repository
               validate :repo_create_validation, :on => :create
               safe_attributes 'identifier',
                 'login',
                 'password',
                 'path_encoding',
                 'log_encoding',
                 'is_default'
               safe_attributes 'url',
                 :if => lambda {|repository, user| repository.new_record?}
               def repo_create_validation
                 unless Setting.enabled_scm.include?(self.class.name.demodulize)
                   errors.add(:type, :invalid)
                 end
               end
               def self.human_attribute_name(attribute_key_name, *args)
                 attr_name = attribute_key_name.to_s
                 if attr_name == "log_encoding"
                   attr_name = "commit_logs_encoding"
                 end
                 super(attr_name, *args)
               end
               # Removes leading and trailing whitespace
               def url=(arg)
                 write_attribute(:url, arg ? arg.to_s.strip : nil)
               end
               # Removes leading and trailing whitespace
               def root_url=(arg)
                 write_attribute(:root_url, arg ? arg.to_s.strip : nil)
               end
               def password
                 read_ciphered_attribute(:password)
               end
               def password=(arg)
                 write_ciphered_attribute(:password, arg)
               end
               def scm_adapter
                 self.class.scm_adapter_class
               end
               def scm
                 unless @scm
                   @scm = self.scm_adapter.new(url, root_url,
                                               login, password, path_encoding)
                   if root_url.blank? && @scm.root_url.present?
                     update_attribute(:root_url, @scm.root_url)
                   end
                 end
                 @scm
               end
               def scm_name
                 self.class.scm_name
               end
               def name
                 if identifier.present?
                   identifier
                 elsif is_default?
                   l(:field_repository_is_default)
                 else
                   scm_name
                 end
               end
               def identifier=(identifier)
                 super unless identifier_frozen?
               end
               def identifier_frozen?
                 errors[:identifier].blank? && !(new_record? || identifier.blank?)
               end
               def identifier_param
                 if is_default?
                   nil
                 elsif identifier.present?
                   identifier
                 else
                   id.to_s
                 end
               end
               def <=>(repository)
                 if is_default?
                   -1
                 elsif repository.is_default?
                 else
                   identifier.to_s <=> repository.identifier.to_s
                 end
               end
               def self.find_by_identifier_param(param)
                 if param.to_s =~ /^\d+$/
                   find_by_id(param)
                 else
                   find_by_identifier(param)
                 end
               end
               def merge_extra_info(arg)
                 h = extra_info || {}
                 return h if arg.nil?
                 h.merge!(arg)
                 write_attribute(:extra_info, h)
               end
               def report_last_commit
                 true
               end
               def supports_cat?
                 scm.supports_cat?
               end
               def supports_annotate?
                 scm.supports_annotate?
               end
               def supports_all_revisions?
                 true
               end
               def supports_directory_revisions?
                 false
               end
               def supports_revision_graph?
                 false
               end
               def entry(path=nil, identifier=nil)
                 scm.entry(path, identifier)
               end
               def entries(path=nil, identifier=nil)
                 entries = scm.entries(path, identifier)
                 load_entries_changesets(entries)
                 entries
               end
               def branches
                 scm.branches
               end
               def tags
                 scm.tags
               end
               def default_branch
                 nil
               end
               def properties(path, identifier=nil)
                 scm.properties(path, identifier)
               end
               def cat(path, identifier=nil)
                 scm.cat(path, identifier)
               end
               def diff(path, rev, rev_to)
                 scm.diff(path, rev, rev_to)
               end
               def diff_format_revisions(cs, cs_to, sep=':')
                 text = ""
                 text << cs_to.format_identifier + sep if cs_to
                 text << cs.format_identifier if cs
                 text
               end
               # Returns a path relative to the url of the repository
               def relative_path(path)
                 path
               end
               # Finds and returns a revision with a number or the beginning of a hash
               def find_changeset_by_name(name)
                 return nil if name.blank?
                 s = name.to_s
                 changesets.find(:first, :conditions => (s.match(/^\d*$/) ?
                       ["revision = ?", s] : ["revision LIKE ?", s + '%']))
               end
               def latest_changeset
                 @latest_changeset ||= changesets.find(:first)
               end
               # Returns the latest changesets for +path+
               # Default behaviour is to search in cached changesets
               def latest_changesets(path, rev, limit=10)
                 if path.blank?
                   changesets.find(
                      :all,
                      :include => :user,
                      :order => "#{Changeset.table_name}.committed_on DESC, #{Changeset.table_name}.id DESC",
                      :limit => limit)
                 else
                   filechanges.find(
                      :all,
                      :include => {:changeset => :user},
                      :conditions => ["path = ?", path.with_leading_slash],
                      :order => "#{Changeset.table_name}.committed_on DESC, #{Changeset.table_name}.id DESC",
                      :limit => limit
                    ).collect(&:changeset)
                 end
               end
               def scan_changesets_for_issue_ids
                 self.changesets.each(&:scan_comment_for_issue_ids)
               end
               # Returns an array of committers usernames and associated user_id
               def committers
                 @committers ||= Changeset.connection.select_rows(
                      "SELECT DISTINCT committer, user_id FROM #{Changeset.table_name} WHERE repository_id = #{id}")
               end
               # Maps committers username to a user ids
               def committer_ids=(h)
                 if h.is_a?(Hash)
                   committers.each do |committer, user_id|
                     new_user_id = h[committer]
                     if new_user_id && (new_user_id.to_i != user_id.to_i)
                       new_user_id = (new_user_id.to_i > 0 ? new_user_id.to_i : nil)
                       Changeset.update_all(
                            "user_id = #{ new_user_id.nil? ? 'NULL' : new_user_id }",
                            ["repository_id = ? AND committer = ?", id, committer])
                     end
                   end
                   @committers            = nil
                   @found_committer_users = nil
                   true
                 else
                   false
                 end
               end
               # Returns the Redmine User corresponding to the given +committer+
               # It will return nil if the committer is not yet mapped and if no User
               # with the same username or email was found
               def find_committer_user(committer)
                 unless committer.blank?
                   @found_committer_users ||= {}
                   return @found_committer_users[committer] if @found_committer_users.has_key?(committer)
                   user = nil
                   c = changesets.find(:first, :conditions => {:committer => committer}, :include => :user)
                   if c && c.user
                     user = c.user
                   elsif committer.strip =~ /^([^<]+)(<(.*)>)?$/
                     username, email = $1.strip, $3
                     u = User.find_by_login(username)
                     u ||= User.find_by_mail(email) unless email.blank?
                     user = u
                   end
                   @found_committer_users[committer] = user
                   user
                 end
               end
               def repo_log_encoding
                 encoding = log_encoding.to_s.strip
                 encoding.blank? ? 'UTF-8' : encoding
               end
               # Fetches new changesets for all repositories of active projects
               # Can be called periodically by an external script
               # eg. ruby script/runner "Repository.fetch_changesets"
               def self.fetch_changesets
                 Project.active.has_module(:repository).all.each do |project|
                   project.repositories.each do |repository|
                     begin
                       repository.fetch_changesets
                     rescue Redmine::Scm::Adapters::CommandFailed => e
                       logger.error "scm: error during fetching changesets: #{e.message}"
                     end
                   end
                 end
               end
               # scan changeset comments to find related and fixed issues for all repositories
               def self.scan_changesets_for_issue_ids
-                find(:all).each(&:scan_changesets_for_issue_ids)
+                all.each(&:scan_changesets_for_issue_ids)
               end
               def self.scm_name
                 'Abstract'
               end
               def self.available_scm
                 subclasses.collect {|klass| [klass.scm_name, klass.name]}
               end
               def self.factory(klass_name, *args)
                 klass = "Repository::#{klass_name}".constantize
                 klass.new(*args)
               rescue
                 nil
               end
               def self.scm_adapter_class
                 nil
               end
               def self.scm_command
                 ret = ""
                 begin
                   ret = self.scm_adapter_class.client_command if self.scm_adapter_class
                 rescue Exception => e
                   logger.error "scm: error during get command: #{e.message}"
                 end
                 ret
               end
               def self.scm_version_string
                 ret = ""
                 begin
                   ret = self.scm_adapter_class.client_version_string if self.scm_adapter_class
                 rescue Exception => e
                   logger.error "scm: error during get version string: #{e.message}"
                 end
                 ret
               end
               def self.scm_available
                 ret = false
                 begin
                   ret = self.scm_adapter_class.client_available if self.scm_adapter_class
                 rescue Exception => e
                   logger.error "scm: error during get scm available: #{e.message}"
                 end
                 ret
               end
               def set_as_default?
                 new_record? && project && !Repository.first(:conditions => {:project_id => project.id})
               end
               protected
               def check_default
                 if !is_default? && set_as_default?
                   self.is_default = true
                 end
                 if is_default? && is_default_changed?
                   Repository.update_all(["is_default = ?", false], ["project_id = ?", project_id])
                 end
               end
               def load_entries_changesets(entries)
                 if entries
                   entries.each do |entry|
                     if entry.lastrev && entry.lastrev.identifier
                       entry.changeset = find_changeset_by_name(entry.lastrev.identifier)
                     end
                   end
                 end
               end
               private
               # Deletes repository data
               def clear_changesets
                 cs = Changeset.table_name
                 ch = Change.table_name
                 ci = "#{table_name_prefix}changesets_issues#{table_name_suffix}"
                 cp = "#{table_name_prefix}changeset_parents#{table_name_suffix}"
                 connection.delete("DELETE FROM #{ch} WHERE #{ch}.changeset_id IN (SELECT #{cs}.id FROM #{cs} WHERE #{cs}.repository_id = #{id})")
                 connection.delete("DELETE FROM #{ci} WHERE #{ci}.changeset_id IN (SELECT #{cs}.id FROM #{cs} WHERE #{cs}.repository_id = #{id})")
                 connection.delete("DELETE FROM #{cp} WHERE #{cp}.changeset_id IN (SELECT #{cs}.id FROM #{cs} WHERE #{cs}.repository_id = #{id})")
                 connection.delete("DELETE FROM #{cs} WHERE #{cs}.repository_id = #{id}")
                 clear_extra_info_of_changesets
               end
               def clear_extra_info_of_changesets
               end
             end

app/models/repository/mercurial.rb +6 -5

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require 'redmine/scm/adapters/mercurial_adapter'
             class Repository::Mercurial < Repository
               # sort changesets by revision number
               has_many :changesets,
                        :order       => "#{Changeset.table_name}.id DESC",
                        :foreign_key => 'repository_id'
               attr_protected        :root_url
               validates_presence_of :url
               # number of changesets to fetch at once
               FETCH_AT_ONCE = 100
               def self.human_attribute_name(attribute_key_name, *args)
                 attr_name = attribute_key_name.to_s
                 if attr_name == "url"
                   attr_name = "path_to_repository"
                 end
                 super(attr_name, *args)
               end
               def self.scm_adapter_class
                 Redmine::Scm::Adapters::MercurialAdapter
               end
               def self.scm_name
                 'Mercurial'
               end
               def supports_directory_revisions?
                 true
               end
               def supports_revision_graph?
                 true
               end
               def repo_log_encoding
                 'UTF-8'
               end
               # Returns the readable identifier for the given mercurial changeset
               def self.format_changeset_identifier(changeset)
                 "#{changeset.revision}:#{changeset.scmid}"
               end
               # Returns the identifier for the given Mercurial changeset
               def self.changeset_identifier(changeset)
                 changeset.scmid
               end
               def diff_format_revisions(cs, cs_to, sep=':')
                 super(cs, cs_to, ' ')
               end
               # Finds and returns a revision with a number or the beginning of a hash
               def find_changeset_by_name(name)
                 return nil if name.blank?
                 s = name.to_s
                 if /[^\d]/ =~ s or s.size > 8
                   cs = changesets.where(:scmid => s).first
                 else
                   cs = changesets.where(:revision => s).first
                 end
                 return cs if cs
                 changesets.where('scmid LIKE ?', "#{s}%").first
               end
               # Returns the latest changesets for +path+; sorted by revision number
               #
               # Because :order => 'id DESC' is defined at 'has_many',
               # there is no need to set 'order'.
               # But, MySQL test fails.
               # Sqlite3 and PostgreSQL pass.
               # Is this MySQL bug?
               def latest_changesets(path, rev, limit=10)
-                changesets.find(:all,
+                changesets.
-                                :include    => :user,
+                  includes(:user).
-                                :conditions => latest_changesets_cond(path, rev, limit),
+                  where(latest_changesets_cond(path, rev, limit)).
-                                :limit      => limit,
+                  limit(limit).
-                                :order      => "#{Changeset.table_name}.id DESC")
+                  order("#{Changeset.table_name}.id DESC").
+                  all
               end
               def latest_changesets_cond(path, rev, limit)
                 cond, args = [], []
                 if scm.branchmap.member? rev
                   # Mercurial named branch is *stable* in each revision.
                   # So, named branch can be stored in database.
                   # Mercurial provides *bookmark* which is equivalent with git branch.
                   # But, bookmark is not implemented.
                   cond << "#{Changeset.table_name}.scmid IN (?)"
                   # Revisions in root directory and sub directory are not equal.
                   # So, in order to get correct limit, we need to get all revisions.
                   # But, it is very heavy.
                   # Mercurial does not treat direcotry.
                   # So, "hg log DIR" is very heavy.
                   branch_limit = path.blank? ? limit : ( limit * 5 )
                   args << scm.nodes_in_branch(rev, :limit => branch_limit)
                 elsif last = rev ? find_changeset_by_name(scm.tagmap[rev] || rev) : nil
                   cond << "#{Changeset.table_name}.id <= ?"
                   args << last.id
                 end
                 unless path.blank?
                   cond << "EXISTS (SELECT * FROM #{Change.table_name}
                              WHERE #{Change.table_name}.changeset_id = #{Changeset.table_name}.id
                              AND (#{Change.table_name}.path = ?
                                    OR #{Change.table_name}.path LIKE ? ESCAPE ?))"
                   args << path.with_leading_slash
                   args << "#{path.with_leading_slash.gsub(%r{[%_\\]}) { |s| "\\#{s}" }}/%" << '\\'
                 end
                 [cond.join(' AND '), *args] unless cond.empty?
               end
               private :latest_changesets_cond
               def fetch_changesets
                 return if scm.info.nil?
                 scm_rev = scm.info.lastrev.revision.to_i
                 db_rev  = latest_changeset ? latest_changeset.revision.to_i : -1
                 return unless db_rev < scm_rev  # already up-to-date
                 logger.debug "Fetching changesets for repository #{url}" if logger
                 (db_rev + 1).step(scm_rev, FETCH_AT_ONCE) do |i|
                   scm.each_revision('', i, [i + FETCH_AT_ONCE - 1, scm_rev].min) do |re|
                     transaction do
                       parents = (re.parents || []).collect{|rp| find_changeset_by_name(rp)}.compact
                       cs = Changeset.create(:repository   => self,
                                             :revision     => re.revision,
                                             :scmid        => re.scmid,
                                             :committer    => re.author,
                                             :committed_on => re.time,
                                             :comments     => re.message,
                                             :parents      => parents)
                       unless cs.new_record?
                         re.paths.each { |e| cs.create_change(e) }
                       end
                     end
                   end
                 end
               end
             end

app/models/watcher.rb +2 -2

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class Watcher < ActiveRecord::Base
               belongs_to :watchable, :polymorphic => true
               belongs_to :user
               validates_presence_of :user
               validates_uniqueness_of :user_id, :scope => [:watchable_type, :watchable_id]
               validate :validate_user
               # Unwatch things that users are no longer allowed to view
               def self.prune(options={})
                 if options.has_key?(:user)
                   prune_single_user(options[:user], options)
                 else
                   pruned = 0
-                  User.find(:all, :conditions => "id IN (SELECT DISTINCT user_id FROM #{table_name})").each do |user|
+                  User.where("id IN (SELECT DISTINCT user_id FROM #{table_name})").all.each do |user|
                     pruned += prune_single_user(user, options)
                   end
                   pruned
                 end
               end
               protected
               def validate_user
                 errors.add :user_id, :invalid unless user.nil? || user.active?
               end
               private
               def self.prune_single_user(user, options={})
                 return unless user.is_a?(User)
                 pruned = 0
-                find(:all, :conditions => {:user_id => user.id}).each do |watcher|
+                where(:user_id => user.id).all.each do |watcher|
                   next if watcher.watchable.nil?
                   if options.has_key?(:project)
                     next unless watcher.watchable.respond_to?(:project) && watcher.watchable.project == options[:project]
                   end
                   if watcher.watchable.respond_to?(:visible?)
                     unless watcher.watchable.visible?(user)
                       watcher.destroy
                       pruned += 1
                     end
                   end
                 end
                 pruned
               end
             end

app/views/groups/_memberships.html.erb +1 -1

             <% roles = Role.find_all_givable %>
-            <% projects = Project.active.find(:all, :order => 'lft') %>
+            <% projects = Project.active.all %>
             <div class="splitcontentleft">
             <% if @group.memberships.any? %>
             <table class="list memberships">
               <thead><tr>
                 <th><%= l(:label_project) %></th>
                 <th><%= l(:label_role_plural) %></th>
                 <th style="width:15%"></th>
               </tr></thead>
               <tbody>
               <% @group.memberships.each do |membership| %>
               <% next if membership.new_record? %>
               <tr id="member-<%= membership.id %>" class="<%= cycle 'odd', 'even' %> class">
               <td class="project"><%=h membership.project %></td>
               <td class="roles">
                 <span id="member-<%= membership.id %>-roles"><%=h membership.roles.sort.collect(&:to_s).join(', ') %></span>
                 <%= form_for(:membership, :remote => true,
                              :url => { :action => 'edit_membership', :id => @group, :membership_id => membership },
                              :html => { :id => "member-#{membership.id}-roles-form", :style => 'display:none;'}) do %>
                     <p><% roles.each do |role| %>
                     <label><%= check_box_tag 'membership[role_ids][]', role.id, membership.roles.include?(role) %> <%=h role %></label><br />
                     <% end %></p>
                     <p><%= submit_tag l(:button_change) %>
                     <%= link_to_function(
                           l(:button_cancel),
                           "$('#member-#{membership.id}-roles').show(); $('#member-#{membership.id}-roles-form').hide(); return false;"
                         ) %></p>
                 <% end %>
               </td>
               <td class="buttons">
                   <%= link_to_function(
                         l(:button_edit),
                         "$('#member-#{membership.id}-roles').hide(); $('#member-#{membership.id}-roles-form').show(); return false;",
                         :class => 'icon icon-edit'
                       ) %>
                   <%= delete_link({:controller => 'groups', :action => 'destroy_membership', :id => @group, :membership_id => membership},
                                   :remote => true,
                                   :method => :post) %>
               </td>
               </tr>
             <% end; reset_cycle %>
               </tbody>
             </table>
             <% else %>
             <p class="nodata"><%= l(:label_no_data) %></p>
             <% end %>
             </div>
             <div class="splitcontentright">
             <% if projects.any? %>
             <fieldset><legend><%=l(:label_project_new)%></legend>
             <%= form_for(:membership, :remote => true, :url => { :action => 'edit_membership', :id => @group }) do %>
             <%= label_tag "membership_project_id", l(:description_choose_project), :class => "hidden-for-sighted" %>
             <%= select_tag 'membership[project_id]', options_for_membership_project_select(@group, projects) %>
             <p><%= l(:label_role_plural) %>:
             <% roles.each do |role| %>
               <label><%= check_box_tag 'membership[role_ids][]', role.id %> <%=h role %></label>
             <% end %></p>
             <p><%= submit_tag l(:button_add) %></p>
             <% end %>
             </fieldset>
             <% end %>
             </div>

app/views/projects/settings/_members.html.erb +1 -1

             <%= error_messages_for 'member' %>
             <% roles = Role.find_all_givable
-               members = @project.member_principals.find(:all, :include => [:roles, :principal]).sort %>
+               members = @project.member_principals.includes(:roles, :principal).all.sort %>
             <div class="splitcontentleft">
             <% if members.any? %>
             <table class="list members">
               <thead><tr>
                 <th><%= l(:label_user) %> / <%= l(:label_group) %></th>
                 <th><%= l(:label_role_plural) %></th>
                 <th style="width:15%"></th>
                       <%= call_hook(:view_projects_settings_members_table_header, :project => @project) %>
               </tr></thead>
               <tbody>
               <% members.each do |member| %>
               <% next if member.new_record? %>
               <tr id="member-<%= member.id %>" class="<%= cycle 'odd', 'even' %> member">
               <td class="<%= member.principal.class.name.downcase %>"><%= link_to_user member.principal %></td>
               <td class="roles">
                 <span id="member-<%= member.id %>-roles"><%=h member.roles.sort.collect(&:to_s).join(', ') %></span>
                   <%= form_for(member, {:as => :membership, :remote => true, :url => membership_path(member),
                                                       :method => :put,
                                                       :html => { :id => "member-#{member.id}-roles-form", :class => 'hol' }}
                          ) do |f| %>
                     <p><% roles.each do |role| %>
                     <label><%= check_box_tag 'membership[role_ids][]', role.id, member.roles.include?(role),
                                                                    :disabled => member.member_roles.detect {|mr| mr.role_id == role.id && !mr.inherited_from.nil?} %> <%=h role %></label><br />
                     <% end %></p>
                     <%= hidden_field_tag 'membership[role_ids][]', '' %>
                     <p><%= submit_tag l(:button_change), :class => "small" %>
                     <%= link_to_function l(:button_cancel),
                                          "$('#member-#{member.id}-roles').show(); $('#member-#{member.id}-roles-form').hide(); return false;"
                          %></p>
                   <% end %>
               </td>
               <td class="buttons">
                   <%= link_to_function l(:button_edit),
                                        "$('#member-#{member.id}-roles').hide(); $('#member-#{member.id}-roles-form').show(); return false;",
                                        :class => 'icon icon-edit' %>
                   <%= delete_link membership_path(member),
                                   :remote => true,
                                   :data => (!User.current.admin? && member.include?(User.current) ? {:confirm => l(:text_own_membership_delete_confirmation)} : {}) if member.deletable? %>
               </td>
               <%= call_hook(:view_projects_settings_members_table_row, { :project => @project, :member => member}) %>
               </tr>
             <% end; reset_cycle %>
               </tbody>
             </table>
             <% else %>
             <p class="nodata"><%= l(:label_no_data) %></p>
             <% end %>
             </div>
             <% principals = Principal.active.not_member_of(@project).all(:limit => 100, :order => 'type, login, lastname ASC') %>
             <div class="splitcontentright">
             <% if roles.any? && principals.any? %>
               <%= form_for(@member, {:as => :membership, :url => project_memberships_path(@project), :remote => true, :method => :post}) do |f| %>
                 <fieldset><legend><%=l(:label_member_new)%></legend>
                 <p><%= label_tag "principal_search", l(:label_principal_search) %><%= text_field_tag 'principal_search', nil %></p>
                 <%= javascript_tag "observeSearchfield('principal_search', 'principals', '#{ escape_javascript autocomplete_project_memberships_path(@project) }')" %>
                 <div id="principals">
                   <%= principals_check_box_tags 'membership[user_ids][]', principals %>
                 </div>
                 <p><%= l(:label_role_plural) %>:
                 <% roles.each do |role| %>
                   <label><%= check_box_tag 'membership[role_ids][]', role.id %> <%=h role %></label>
                  <% end %></p>
                 <p><%= submit_tag l(:button_add), :id => 'member-add-submit' %></p>
                 </fieldset>
               <% end %>
             <% end %>
             </div>

app/views/settings/_repositories.html.erb +1 -1

             <%= form_tag({:action => 'edit', :tab => 'repositories'}) do %>
             <fieldset class="box settings enabled_scm">
             <legend><%= l(:setting_enabled_scm) %></legend>
             <%= hidden_field_tag 'settings[enabled_scm][]', '' %>
             <table>
               <tr>
                 <th></th>
                 <th><%= l(:text_scm_command)         %></th>
                 <th><%= l(:text_scm_command_version) %></th>
               </tr>
               <% Redmine::Scm::Base.all.collect do |choice| %>
                 <% scm_class = "Repository::#{choice}".constantize %>
                 <% text, value = (choice.is_a?(Array) ? choice : [choice, choice]) %>
                 <% setting = :enabled_scm %>
             		<% enabled = Setting.send(setting).include?(value) %>
                 <tr>
                   <td class="scm_name">
                     <label>
                     <%= check_box_tag("settings[#{setting}][]", value, enabled, :id => nil) %>
                     <%= text.to_s %>
                     </label>
                   </td>
                   <td>
                      <% if enabled %>
                      <%=
                        image_tag(
                           (scm_class.scm_available ? 'true.png' : 'exclamation.png'),
                           :style => "vertical-align:bottom;"
                        )
                        %>
                       <%= scm_class.scm_command %>
             					<% end %>
                    </td>
                    <td>
                       <%= scm_class.scm_version_string if enabled %>
                    </td>
                  </tr>
               <% end %>
             </table>
             <p><em class="info"><%= l(:text_scm_config) %></em></p>
             </fieldset>
             <div class="box tabular settings">
             <p><%= setting_check_box :autofetch_changesets %></p>
             <p><%= setting_check_box :sys_api_enabled,
                                      :onclick =>
                                          "if (this.checked) { $('#settings_sys_api_key').removeAttr('disabled'); } else { $('#settings_sys_api_key').attr('disabled', true); }" %></p>
             <p><%= setting_text_field :sys_api_key,
                                       :size     => 30,
                                       :id       => 'settings_sys_api_key',
                                       :disabled => !Setting.sys_api_enabled?,
                                       :label    => :setting_mail_handler_api_key %>
               <%= link_to_function l(:label_generate_key),
                                    "if (!$('#settings_sys_api_key').attr('disabled')) { $('#settings_sys_api_key').val(randomKey(20)) }" %>
             </p>
             <p><%= setting_text_field :repository_log_display_limit, :size => 6 %></p>
             </div>
             <fieldset class="box tabular settings">
             <legend><%= l(:text_issues_ref_in_commit_messages) %></legend>
             <p><%= setting_text_field :commit_ref_keywords, :size => 30 %>
             <em class="info"><%= l(:text_comma_separated) %></em></p>
             <p><%= setting_text_field :commit_fix_keywords, :size => 30 %>
             &nbsp;<%= l(:label_applied_status) %>: <%= setting_select :commit_fix_status_id,
                                                                       [["", 0]] +
-                                                                          IssueStatus.find(:all).collect{
+                                                                          IssueStatus.sorted.all.collect{
                                                                              |status| [status.name, status.id.to_s]
                                                                           },
                                                                       :label => false %>
             &nbsp;<%= l(:field_done_ratio) %>: <%= setting_select :commit_fix_done_ratio,
                                                                    (0..10).to_a.collect {|r| ["#{r*10} %", "#{r*10}"] },
                                                                    :blank => :label_no_change_option,
                                                                    :label => false %>
             <em class="info"><%= l(:text_comma_separated) %></em></p>
             <p><%= setting_check_box :commit_cross_project_ref %></p>
             <p><%= setting_check_box :commit_logtime_enabled,
                                      :onclick =>
                                         "if (this.checked) { $('#settings_commit_logtime_activity_id').removeAttr('disabled'); } else { $('#settings_commit_logtime_activity_id').attr('disabled', true); }"%></p>
             <p><%= setting_select :commit_logtime_activity_id,
                                   [[l(:label_default), 0]] +
                                       TimeEntryActivity.shared.active.collect{|activity| [activity.name, activity.id.to_s]},
                                   :disabled => !Setting.commit_logtime_enabled?%></p>
             </fieldset>
             <%= submit_tag l(:button_save) %>
             <% end %>

app/views/users/_memberships.html.erb +1 -1

             <% roles = Role.find_all_givable %>
-            <% projects = Project.active.find(:all, :order => 'lft') %>
+            <% projects = Project.active.all %>
             <div class="splitcontentleft">
             <% if @user.memberships.any? %>
             <table class="list memberships">
               <thead><tr>
                 <th><%= l(:label_project) %></th>
                 <th><%= l(:label_role_plural) %></th>
                 <th style="width:15%"></th>
                   <%= call_hook(:view_users_memberships_table_header, :user => @user )%>
               </tr></thead>
               <tbody>
               <% @user.memberships.each do |membership| %>
               <% next if membership.new_record? %>
               <tr id="member-<%= membership.id %>" class="<%= cycle 'odd', 'even' %> class">
               <td class="project">
                 <%= link_to_project membership.project %>
               </td>
               <td class="roles">
                 <span id="member-<%= membership.id %>-roles"><%=h membership.roles.sort.collect(&:to_s).join(', ') %></span>
                 <%= form_for(:membership, :remote => true,
                              :url => user_membership_path(@user, membership), :method => :put,
                              :html => {:id => "member-#{membership.id}-roles-form",
                                        :style => 'display:none;'}) do %>
                     <p><% roles.each do |role| %>
                     <label><%= check_box_tag 'membership[role_ids][]', role.id, membership.roles.include?(role),
                                                                        :disabled => membership.member_roles.detect {|mr| mr.role_id == role.id && !mr.inherited_from.nil?} %> <%=h role %></label><br />
                     <% end %></p>
                     <%= hidden_field_tag 'membership[role_ids][]', '' %>
                     <p><%= submit_tag l(:button_change) %>
                     <%= link_to_function l(:button_cancel),
                                          "$('#member-#{membership.id}-roles').show(); $('#member-#{membership.id}-roles-form').hide(); return false;"
                         %></p>
                 <% end %>
               </td>
               <td class="buttons">
                   <%= link_to_function l(:button_edit),
                                        "$('#member-#{membership.id}-roles').hide(); $('#member-#{membership.id}-roles-form').show(); return false;",
                                        :class => 'icon icon-edit'
                       %>
                   <%= delete_link user_membership_path(@user, membership), :remote => true if membership.deletable? %>
               </td>
                   <%= call_hook(:view_users_memberships_table_row, :user => @user, :membership => membership, :roles => roles, :projects => projects )%>
               </tr>
               <% end; reset_cycle %>
               </tbody>
             </table>
             <% else %>
             <p class="nodata"><%= l(:label_no_data) %></p>
             <% end %>
             </div>
             <div class="splitcontentright">
             <% if projects.any? %>
             <fieldset><legend><%=l(:label_project_new)%></legend>
             <%= form_for(:membership, :remote => true, :url => user_memberships_path(@user)) do %>
             <%= select_tag 'membership[project_id]', options_for_membership_project_select(@user, projects) %>
             <p><%= l(:label_role_plural) %>:
             <% roles.each do |role| %>
               <label><%= check_box_tag 'membership[role_ids][]', role.id %> <%=h role %></label>
             <% end %></p>
             <p><%= submit_tag l(:button_add) %></p>
             <% end %>
             </fieldset>
             <% end %>
             </div>

lib/plugins/acts_as_customizable/lib/acts_as_customizable.rb +1 -2

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             module Redmine
               module Acts
                 module Customizable
                   def self.included(base)
                     base.extend ClassMethods
                   end
                   module ClassMethods
                     def acts_as_customizable(options = {})
                       return if self.included_modules.include?(Redmine::Acts::Customizable::InstanceMethods)
                       cattr_accessor :customizable_options
                       self.customizable_options = options
                       has_many :custom_values, :as => :customized,
                                                :include => :custom_field,
                                                :order => "#{CustomField.table_name}.position",
                                                :dependent => :delete_all,
                                                :validate => false
                       send :include, Redmine::Acts::Customizable::InstanceMethods
                       validate :validate_custom_field_values
                       after_save :save_custom_field_values
                     end
                   end
                   module InstanceMethods
                     def self.included(base)
                       base.extend ClassMethods
                     end
                     def available_custom_fields
-                      CustomField.find(:all, :conditions => "type = '#{self.class.name}CustomField'",
+                      CustomField.where("type = '#{self.class.name}CustomField'").sorted.all
-                                             :order => 'position')
                     end
                     # Sets the values of the object's custom fields
                     # values is an array like [{'id' => 1, 'value' => 'foo'}, {'id' => 2, 'value' => 'bar'}]
                     def custom_fields=(values)
                       values_to_hash = values.inject({}) do |hash, v|
                         v = v.stringify_keys
                         if v['id'] && v.has_key?('value')
                           hash[v['id']] = v['value']
                         end
                         hash
                       end
                       self.custom_field_values = values_to_hash
                     end
                     # Sets the values of the object's custom fields
                     # values is a hash like {'1' => 'foo', 2 => 'bar'}
                     def custom_field_values=(values)
                       values = values.stringify_keys
                       custom_field_values.each do |custom_field_value|
                         key = custom_field_value.custom_field_id.to_s
                         if values.has_key?(key)
                           value = values[key]
                           if value.is_a?(Array)
                             value = value.reject(&:blank?).uniq
                             if value.empty?
                               value << ''
                             end
                           end
                           custom_field_value.value = value
                         end
                       end
                       @custom_field_values_changed = true
                     end
                     def custom_field_values
                       @custom_field_values ||= available_custom_fields.collect do |field|
                         x = CustomFieldValue.new
                         x.custom_field = field
                         x.customized = self
                         if field.multiple?
                           values = custom_values.select { |v| v.custom_field == field }
                           if values.empty?
                             values << custom_values.build(:customized => self, :custom_field => field, :value => nil)
                           end
                           x.value = values.map(&:value)
                         else
                           cv = custom_values.detect { |v| v.custom_field == field }
                           cv ||= custom_values.build(:customized => self, :custom_field => field, :value => nil)
                           x.value = cv.value
                         end
                         x
                       end
                     end
                     def visible_custom_field_values
                       custom_field_values.select(&:visible?)
                     end
                     def custom_field_values_changed?
                       @custom_field_values_changed == true
                     end
                     def custom_value_for(c)
                       field_id = (c.is_a?(CustomField) ? c.id : c.to_i)
                       custom_values.detect {|v| v.custom_field_id == field_id }
                     end
                     def custom_field_value(c)
                       field_id = (c.is_a?(CustomField) ? c.id : c.to_i)
                       custom_field_values.detect {|v| v.custom_field_id == field_id }.try(:value)
                     end
                     def validate_custom_field_values
                       if new_record? || custom_field_values_changed?
                         custom_field_values.each(&:validate_value)
                       end
                     end
                     def save_custom_field_values
                       target_custom_values = []
                       custom_field_values.each do |custom_field_value|
                         if custom_field_value.value.is_a?(Array)
                           custom_field_value.value.each do |v|
                             target = custom_values.detect {|cv| cv.custom_field == custom_field_value.custom_field && cv.value == v}
                             target ||= custom_values.build(:customized => self, :custom_field => custom_field_value.custom_field, :value => v)
                             target_custom_values << target
                           end
                         else
                           target = custom_values.detect {|cv| cv.custom_field == custom_field_value.custom_field}
                           target ||= custom_values.build(:customized => self, :custom_field => custom_field_value.custom_field)
                           target.value = custom_field_value.value
                           target_custom_values << target
                         end
                       end
                       self.custom_values = target_custom_values
                       custom_values.each(&:save)
                       @custom_field_values_changed = false
                       true
                     end
                     def reset_custom_values!
                       @custom_field_values = nil
                       @custom_field_values_changed = true
                     end
                     module ClassMethods
                     end
                   end
                 end
               end
             end

lib/redmine/default_data/loader.rb +5 -5

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             module Redmine
               module DefaultData
                 class DataAlreadyLoaded < Exception; end
                 module Loader
                   include Redmine::I18n
                   class << self
                     # Returns true if no data is already loaded in the database
                     # otherwise false
                     def no_data?
                       !Role.find(:first, :conditions => {:builtin => 0}) &&
                         !Tracker.find(:first) &&
                         !IssueStatus.find(:first) &&
                         !Enumeration.find(:first)
                     end
                     # Loads the default data
                     # Raises a RecordNotSaved exception if something goes wrong
                     def load(lang=nil)
                       raise DataAlreadyLoaded.new("Some configuration data is already loaded.") unless no_data?
                       set_language_if_valid(lang)
                       Role.transaction do
                         # Roles
                         manager = Role.create! :name => l(:default_role_manager),
                                                :issues_visibility => 'all',
                                                :position => 1
                         manager.permissions = manager.setable_permissions.collect {|p| p.name}
                         manager.save!
                         developer = Role.create!  :name => l(:default_role_developer),
                                                   :position => 2,
                                                   :permissions => [:manage_versions,
                                                                   :manage_categories,
                                                                   :view_issues,
                                                                   :add_issues,
                                                                   :edit_issues,
                                                                   :view_private_notes,
                                                                   :set_notes_private,
                                                                   :manage_issue_relations,
                                                                   :manage_subtasks,
                                                                   :add_issue_notes,
                                                                   :save_queries,
                                                                   :view_gantt,
                                                                   :view_calendar,
                                                                   :log_time,
                                                                   :view_time_entries,
                                                                   :comment_news,
                                                                   :view_documents,
                                                                   :view_wiki_pages,
                                                                   :view_wiki_edits,
                                                                   :edit_wiki_pages,
                                                                   :delete_wiki_pages,
                                                                   :add_messages,
                                                                   :edit_own_messages,
                                                                   :view_files,
                                                                   :manage_files,
                                                                   :browse_repository,
                                                                   :view_changesets,
                                                                   :commit_access,
                                                                   :manage_related_issues]
                         reporter = Role.create! :name => l(:default_role_reporter),
                                                 :position => 3,
                                                 :permissions => [:view_issues,
                                                                 :add_issues,
                                                                 :add_issue_notes,
                                                                 :save_queries,
                                                                 :view_gantt,
                                                                 :view_calendar,
                                                                 :log_time,
                                                                 :view_time_entries,
                                                                 :comment_news,
                                                                 :view_documents,
                                                                 :view_wiki_pages,
                                                                 :view_wiki_edits,
                                                                 :add_messages,
                                                                 :edit_own_messages,
                                                                 :view_files,
                                                                 :browse_repository,
                                                                 :view_changesets]
                         Role.non_member.update_attribute :permissions, [:view_issues,
                                                                         :add_issues,
                                                                         :add_issue_notes,
                                                                         :save_queries,
                                                                         :view_gantt,
                                                                         :view_calendar,
                                                                         :view_time_entries,
                                                                         :comment_news,
                                                                         :view_documents,
                                                                         :view_wiki_pages,
                                                                         :view_wiki_edits,
                                                                         :add_messages,
                                                                         :view_files,
                                                                         :browse_repository,
                                                                         :view_changesets]
                         Role.anonymous.update_attribute :permissions, [:view_issues,
                                                                        :view_gantt,
                                                                        :view_calendar,
                                                                        :view_time_entries,
                                                                        :view_documents,
                                                                        :view_wiki_pages,
                                                                        :view_wiki_edits,
                                                                        :view_files,
                                                                        :browse_repository,
                                                                        :view_changesets]
                         # Trackers
                         Tracker.create!(:name => l(:default_tracker_bug),     :is_in_chlog => true,  :is_in_roadmap => false, :position => 1)
                         Tracker.create!(:name => l(:default_tracker_feature), :is_in_chlog => true,  :is_in_roadmap => true,  :position => 2)
                         Tracker.create!(:name => l(:default_tracker_support), :is_in_chlog => false, :is_in_roadmap => false, :position => 3)
                         # Issue statuses
                         new       = IssueStatus.create!(:name => l(:default_issue_status_new), :is_closed => false, :is_default => true, :position => 1)
                         in_progress  = IssueStatus.create!(:name => l(:default_issue_status_in_progress), :is_closed => false, :is_default => false, :position => 2)
                         resolved  = IssueStatus.create!(:name => l(:default_issue_status_resolved), :is_closed => false, :is_default => false, :position => 3)
                         feedback  = IssueStatus.create!(:name => l(:default_issue_status_feedback), :is_closed => false, :is_default => false, :position => 4)
                         closed    = IssueStatus.create!(:name => l(:default_issue_status_closed), :is_closed => true, :is_default => false, :position => 5)
                         rejected  = IssueStatus.create!(:name => l(:default_issue_status_rejected), :is_closed => true, :is_default => false, :position => 6)
                         # Workflow
-                        Tracker.find(:all).each { |t|
+                        Tracker.all.each { |t|
-                          IssueStatus.find(:all).each { |os|
+                          IssueStatus.all.each { |os|
-                            IssueStatus.find(:all).each { |ns|
+                            IssueStatus.all.each { |ns|
                               WorkflowTransition.create!(:tracker_id => t.id, :role_id => manager.id, :old_status_id => os.id, :new_status_id => ns.id) unless os == ns
                             }
                           }
                         }
-                        Tracker.find(:all).each { |t|
+                        Tracker.all.each { |t|
                           [new, in_progress, resolved, feedback].each { |os|
                             [in_progress, resolved, feedback, closed].each { |ns|
                               WorkflowTransition.create!(:tracker_id => t.id, :role_id => developer.id, :old_status_id => os.id, :new_status_id => ns.id) unless os == ns
                             }
                           }
                         }
-                        Tracker.find(:all).each { |t|
+                        Tracker.all.each { |t|
                           [new, in_progress, resolved, feedback].each { |os|
                             [closed].each { |ns|
                               WorkflowTransition.create!(:tracker_id => t.id, :role_id => reporter.id, :old_status_id => os.id, :new_status_id => ns.id) unless os == ns
                             }
                           }
                           WorkflowTransition.create!(:tracker_id => t.id, :role_id => reporter.id, :old_status_id => resolved.id, :new_status_id => feedback.id)
                         }
                         # Enumerations
                         IssuePriority.create!(:name => l(:default_priority_low), :position => 1)
                         IssuePriority.create!(:name => l(:default_priority_normal), :position => 2, :is_default => true)
                         IssuePriority.create!(:name => l(:default_priority_high), :position => 3)
                         IssuePriority.create!(:name => l(:default_priority_urgent), :position => 4)
                         IssuePriority.create!(:name => l(:default_priority_immediate), :position => 5)
                         DocumentCategory.create!(:name => l(:default_doc_category_user), :position => 1)
                         DocumentCategory.create!(:name => l(:default_doc_category_tech), :position => 2)
                         TimeEntryActivity.create!(:name => l(:default_activity_design), :position => 1)
                         TimeEntryActivity.create!(:name => l(:default_activity_development), :position => 2)
                       end
                       true
                     end
                   end
                 end
               end
             end

lib/redmine/helpers/time_report.rb +2 -2

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             module Redmine
               module Helpers
                 class TimeReport
                   attr_reader :criteria, :columns, :from, :to, :hours, :total_hours, :periods
                   def initialize(project, issue, criteria, columns, from, to)
                     @project = project
                     @issue = issue
                     @criteria = criteria || []
                     @criteria = @criteria.select{|criteria| available_criteria.has_key? criteria}
                     @criteria.uniq!
                     @criteria = @criteria[0,3]
                     @columns = (columns && %w(year month week day).include?(columns)) ? columns : 'month'
                     @from = from
                     @to = to
                     run
                   end
                   def available_criteria
                     @available_criteria || load_available_criteria
                   end
                   private
                   def run
                     unless @criteria.empty?
                       scope = TimeEntry.visible.spent_between(@from, @to)
                       if @issue
                         scope = scope.on_issue(@issue)
                       elsif @project
                         scope = scope.on_project(@project, Setting.display_subprojects_issues?)
                       end
                       time_columns = %w(tyear tmonth tweek spent_on)
                       @hours = []
                       scope.sum(:hours, :include => :issue, :group => @criteria.collect{|criteria| @available_criteria[criteria][:sql]} + time_columns).each do |hash, hours|
                         h = {'hours' => hours}
                         (@criteria + time_columns).each_with_index do |name, i|
                           h[name] = hash[i]
                         end
                         @hours << h
                       end
                       @hours.each do |row|
                         case @columns
                         when 'year'
                           row['year'] = row['tyear']
                         when 'month'
                           row['month'] = "#{row['tyear']}-#{row['tmonth']}"
                         when 'week'
                           row['week'] = "#{row['tyear']}-#{row['tweek']}"
                         when 'day'
                           row['day'] = "#{row['spent_on']}"
                         end
                       end
                       if @from.nil?
                         min = @hours.collect {|row| row['spent_on']}.min
                         @from = min ? min.to_date : Date.today
                       end
                       if @to.nil?
                         max = @hours.collect {|row| row['spent_on']}.max
                         @to = max ? max.to_date : Date.today
                       end
                       @total_hours = @hours.inject(0) {|s,k| s = s + k['hours'].to_f}
                       @periods = []
                       # Date#at_beginning_of_ not supported in Rails 1.2.x
                       date_from = @from.to_time
                       # 100 columns max
                       while date_from <= @to.to_time && @periods.length < 100
                         case @columns
                         when 'year'
                           @periods << "#{date_from.year}"
                           date_from = (date_from + 1.year).at_beginning_of_year
                         when 'month'
                           @periods << "#{date_from.year}-#{date_from.month}"
                           date_from = (date_from + 1.month).at_beginning_of_month
                         when 'week'
                           @periods << "#{date_from.year}-#{date_from.to_date.cweek}"
                           date_from = (date_from + 7.day).at_beginning_of_week
                         when 'day'
                           @periods << "#{date_from.to_date}"
                           date_from = date_from + 1.day
                         end
                       end
                     end
                   end
                   def load_available_criteria
                     @available_criteria = { 'project' => {:sql => "#{TimeEntry.table_name}.project_id",
                                                           :klass => Project,
                                                           :label => :label_project},
                                              'status' => {:sql => "#{Issue.table_name}.status_id",
                                                           :klass => IssueStatus,
                                                           :label => :field_status},
                                              'version' => {:sql => "#{Issue.table_name}.fixed_version_id",
                                                           :klass => Version,
                                                           :label => :label_version},
                                              'category' => {:sql => "#{Issue.table_name}.category_id",
                                                             :klass => IssueCategory,
                                                             :label => :field_category},
                                              'member' => {:sql => "#{TimeEntry.table_name}.user_id",
                                                          :klass => User,
                                                          :label => :label_member},
                                              'tracker' => {:sql => "#{Issue.table_name}.tracker_id",
                                                           :klass => Tracker,
                                                           :label => :label_tracker},
                                              'activity' => {:sql => "#{TimeEntry.table_name}.activity_id",
                                                            :klass => TimeEntryActivity,
                                                            :label => :label_activity},
                                              'issue' => {:sql => "#{TimeEntry.table_name}.issue_id",
                                                          :klass => Issue,
                                                          :label => :label_issue}
                                            }
                     # Add list and boolean custom fields as available criteria
                     custom_fields = (@project.nil? ? IssueCustomField.for_all : @project.all_issue_custom_fields)
                     custom_fields.select {|cf| %w(list bool).include? cf.field_format }.each do |cf|
                       @available_criteria["cf_#{cf.id}"] = {:sql => "(SELECT c.value FROM #{CustomValue.table_name} c WHERE c.custom_field_id = #{cf.id} AND c.customized_type = 'Issue' AND c.customized_id = #{Issue.table_name}.id ORDER BY c.value LIMIT 1)",
                                                              :format => cf.field_format,
                                                              :label => cf.name}
                     end if @project
                     # Add list and boolean time entry custom fields
-                    TimeEntryCustomField.find(:all).select {|cf| %w(list bool).include? cf.field_format }.each do |cf|
+                    TimeEntryCustomField.all.select {|cf| %w(list bool).include? cf.field_format }.each do |cf|
                       @available_criteria["cf_#{cf.id}"] = {:sql => "(SELECT c.value FROM #{CustomValue.table_name} c WHERE c.custom_field_id = #{cf.id} AND c.customized_type = 'TimeEntry' AND c.customized_id = #{TimeEntry.table_name}.id ORDER BY c.value LIMIT 1)",
                                                              :format => cf.field_format,
                                                              :label => cf.name}
                     end
                     # Add list and boolean time entry activity custom fields
-                    TimeEntryActivityCustomField.find(:all).select {|cf| %w(list bool).include? cf.field_format }.each do |cf|
+                    TimeEntryActivityCustomField.all.select {|cf| %w(list bool).include? cf.field_format }.each do |cf|
                       @available_criteria["cf_#{cf.id}"] = {:sql => "(SELECT c.value FROM #{CustomValue.table_name} c WHERE c.custom_field_id = #{cf.id} AND c.customized_type = 'Enumeration' AND c.customized_id = #{TimeEntry.table_name}.activity_id ORDER BY c.value LIMIT 1)",
                                                              :format => cf.field_format,
                                                              :label => cf.name}
                     end
                     @available_criteria
                   end
                 end
               end
             end

lib/tasks/migrate_from_mantis.rake +7 -7

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             desc 'Mantis migration script'
             require 'active_record'
             require 'iconv'
             require 'pp'
             namespace :redmine do
             task :migrate_from_mantis => :environment do
               module MantisMigrate
                   DEFAULT_STATUS = IssueStatus.default
                   assigned_status = IssueStatus.find_by_position(2)
                   resolved_status = IssueStatus.find_by_position(3)
                   feedback_status = IssueStatus.find_by_position(4)
                   closed_status = IssueStatus.find :first, :conditions => { :is_closed => true }
                   STATUS_MAPPING = {10 => DEFAULT_STATUS,  # new
 => feedback_status, # feedback
 => DEFAULT_STATUS,  # acknowledged
 => DEFAULT_STATUS,  # confirmed
 => assigned_status, # assigned
 => resolved_status, # resolved
 => closed_status    # closed
                                     }
                   priorities = IssuePriority.all
                   DEFAULT_PRIORITY = priorities[2]
                   PRIORITY_MAPPING = {10 => priorities[1], # none
 => priorities[1], # low
 => priorities[2], # normal
 => priorities[3], # high
 => priorities[4], # urgent
 => priorities[5]  # immediate
                                       }
                   TRACKER_BUG = Tracker.find_by_position(1)
                   TRACKER_FEATURE = Tracker.find_by_position(2)
-                  roles = Role.find(:all, :conditions => {:builtin => 0}, :order => 'position ASC')
+                  roles = Role.where(:builtin => 0).order('position ASC').all
                   manager_role = roles[0]
                   developer_role = roles[1]
                   DEFAULT_ROLE = roles.last
                   ROLE_MAPPING = {10 => DEFAULT_ROLE,   # viewer
 => DEFAULT_ROLE,   # reporter
 => DEFAULT_ROLE,   # updater
 => developer_role, # developer
 => manager_role,   # manager
 => manager_role    # administrator
                                   }
                   CUSTOM_FIELD_TYPE_MAPPING = {0 => 'string', # String
 => 'int',    # Numeric
 => 'int',    # Float
 => 'list',   # Enumeration
 => 'string', # Email
 => 'bool',   # Checkbox
 => 'list',   # List
 => 'list',   # Multiselection list
 => 'date',   # Date
                                                }
                   RELATION_TYPE_MAPPING = {1 => IssueRelation::TYPE_RELATES,    # related to
 => IssueRelation::TYPE_RELATES,    # parent of
 => IssueRelation::TYPE_RELATES,    # child of
 => IssueRelation::TYPE_DUPLICATES, # duplicate of
 => IssueRelation::TYPE_DUPLICATES  # has duplicate
                                            }
                 class MantisUser < ActiveRecord::Base
                   self.table_name = :mantis_user_table
                   def firstname
                     @firstname = realname.blank? ? username : realname.split.first[0..29]
                     @firstname
                   end
                   def lastname
                     @lastname = realname.blank? ? '-' : realname.split[1..-1].join(' ')[0..29]
                     @lastname = '-' if @lastname.blank?
                     @lastname
                   end
                   def email
                     if read_attribute(:email).match(/^([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})$/i) &&
                          !User.find_by_mail(read_attribute(:email))
                       @email = read_attribute(:email)
                     else
                       @email = "#{username}@foo.bar"
                     end
                   end
                   def username
                     read_attribute(:username)[0..29].gsub(/[^a-zA-Z0-9_\-@\.]/, '-')
                   end
                 end
                 class MantisProject < ActiveRecord::Base
                   self.table_name = :mantis_project_table
                   has_many :versions, :class_name => "MantisVersion", :foreign_key => :project_id
                   has_many :categories, :class_name => "MantisCategory", :foreign_key => :project_id
                   has_many :news, :class_name => "MantisNews", :foreign_key => :project_id
                   has_many :members, :class_name => "MantisProjectUser", :foreign_key => :project_id
                   def identifier
                     read_attribute(:name).gsub(/[^a-z0-9\-]+/, '-').slice(0, Project::IDENTIFIER_MAX_LENGTH)
                   end
                 end
                 class MantisVersion < ActiveRecord::Base
                   self.table_name = :mantis_project_version_table
                   def version
                     read_attribute(:version)[0..29]
                   end
                   def description
                     read_attribute(:description)[0..254]
                   end
                 end
                 class MantisCategory < ActiveRecord::Base
                   self.table_name = :mantis_project_category_table
                 end
                 class MantisProjectUser < ActiveRecord::Base
                   self.table_name = :mantis_project_user_list_table
                 end
                 class MantisBug < ActiveRecord::Base
                   self.table_name = :mantis_bug_table
                   belongs_to :bug_text, :class_name => "MantisBugText", :foreign_key => :bug_text_id
                   has_many :bug_notes, :class_name => "MantisBugNote", :foreign_key => :bug_id
                   has_many :bug_files, :class_name => "MantisBugFile", :foreign_key => :bug_id
                   has_many :bug_monitors, :class_name => "MantisBugMonitor", :foreign_key => :bug_id
                 end
                 class MantisBugText < ActiveRecord::Base
                   self.table_name = :mantis_bug_text_table
                   # Adds Mantis steps_to_reproduce and additional_information fields
                   # to description if any
                   def full_description
                     full_description = description
                     full_description += "\n\n*Steps to reproduce:*\n\n#{steps_to_reproduce}" unless steps_to_reproduce.blank?
                     full_description += "\n\n*Additional information:*\n\n#{additional_information}" unless additional_information.blank?
                     full_description
                   end
                 end
                 class MantisBugNote < ActiveRecord::Base
                   self.table_name = :mantis_bugnote_table
                   belongs_to :bug, :class_name => "MantisBug", :foreign_key => :bug_id
                   belongs_to :bug_note_text, :class_name => "MantisBugNoteText", :foreign_key => :bugnote_text_id
                 end
                 class MantisBugNoteText < ActiveRecord::Base
                   self.table_name = :mantis_bugnote_text_table
                 end
                 class MantisBugFile < ActiveRecord::Base
                   self.table_name = :mantis_bug_file_table
                   def size
                     filesize
                   end
                   def original_filename
                     MantisMigrate.encode(filename)
                   end
                   def content_type
                     file_type
                   end
                   def read(*args)
                       if @read_finished
                           nil
                       else
                           @read_finished = true
                           content
                       end
                   end
                 end
                 class MantisBugRelationship < ActiveRecord::Base
                   self.table_name = :mantis_bug_relationship_table
                 end
                 class MantisBugMonitor < ActiveRecord::Base
                   self.table_name = :mantis_bug_monitor_table
                 end
                 class MantisNews < ActiveRecord::Base
                   self.table_name = :mantis_news_table
                 end
                 class MantisCustomField < ActiveRecord::Base
                   self.table_name = :mantis_custom_field_table
                   set_inheritance_column :none
                   has_many :values, :class_name => "MantisCustomFieldString", :foreign_key => :field_id
                   has_many :projects, :class_name => "MantisCustomFieldProject", :foreign_key => :field_id
                   def format
                     read_attribute :type
                   end
                   def name
                     read_attribute(:name)[0..29]
                   end
                 end
                 class MantisCustomFieldProject < ActiveRecord::Base
                   self.table_name = :mantis_custom_field_project_table
                 end
                 class MantisCustomFieldString < ActiveRecord::Base
                   self.table_name = :mantis_custom_field_string_table
                 end
                 def self.migrate
                   # Users
                   print "Migrating users"
                   User.delete_all "login <> 'admin'"
                   users_map = {}
                   users_migrated = 0
-                  MantisUser.find(:all).each do |user|
+                  MantisUser.all.each do |user|
                     u = User.new :firstname => encode(user.firstname),
                                  :lastname => encode(user.lastname),
                                  :mail => user.email,
                                  :last_login_on => user.last_visit
                     u.login = user.username
                     u.password = 'mantis'
                     u.status = User::STATUS_LOCKED if user.enabled != 1
                     u.admin = true if user.access_level == 90
                     next unless u.save!
                     users_migrated += 1
                     users_map[user.id] = u.id
                     print '.'
                   end
                   puts
                   # Projects
                   print "Migrating projects"
                   Project.destroy_all
                   projects_map = {}
                   versions_map = {}
                   categories_map = {}
-                  MantisProject.find(:all).each do |project|
+                  MantisProject.all.each do |project|
                     p = Project.new :name => encode(project.name),
                                     :description => encode(project.description)
                     p.identifier = project.identifier
                     next unless p.save
                     projects_map[project.id] = p.id
                     p.enabled_module_names = ['issue_tracking', 'news', 'wiki']
                     p.trackers << TRACKER_BUG unless p.trackers.include?(TRACKER_BUG)
                     p.trackers << TRACKER_FEATURE unless p.trackers.include?(TRACKER_FEATURE)
                     print '.'
                     # Project members
                     project.members.each do |member|
                       m = Member.new :user => User.find_by_id(users_map[member.user_id]),
                                        :roles => [ROLE_MAPPING[member.access_level] || DEFAULT_ROLE]
                       m.project = p
                       m.save
                     end
                     # Project versions
                     project.versions.each do |version|
                       v = Version.new :name => encode(version.version),
                                       :description => encode(version.description),
                                       :effective_date => (version.date_order ? version.date_order.to_date : nil)
                       v.project = p
                       v.save
                       versions_map[version.id] = v.id
                     end
                     # Project categories
                     project.categories.each do |category|
                       g = IssueCategory.new :name => category.category[0,30]
                       g.project = p
                       g.save
                       categories_map[category.category] = g.id
                     end
                   end
                   puts
                   # Bugs
                   print "Migrating bugs"
                   Issue.destroy_all
                   issues_map = {}
                   keep_bug_ids = (Issue.count == 0)
                   MantisBug.find_each(:batch_size => 200) do |bug|
                     next unless projects_map[bug.project_id] && users_map[bug.reporter_id]
                     i = Issue.new :project_id => projects_map[bug.project_id],
                                   :subject => encode(bug.summary),
                                   :description => encode(bug.bug_text.full_description),
                                   :priority => PRIORITY_MAPPING[bug.priority] || DEFAULT_PRIORITY,
                                   :created_on => bug.date_submitted,
                                   :updated_on => bug.last_updated
                     i.author = User.find_by_id(users_map[bug.reporter_id])
                     i.category = IssueCategory.find_by_project_id_and_name(i.project_id, bug.category[0,30]) unless bug.category.blank?
                     i.fixed_version = Version.find_by_project_id_and_name(i.project_id, bug.fixed_in_version) unless bug.fixed_in_version.blank?
                     i.status = STATUS_MAPPING[bug.status] || DEFAULT_STATUS
                     i.tracker = (bug.severity == 10 ? TRACKER_FEATURE : TRACKER_BUG)
                     i.id = bug.id if keep_bug_ids
                     next unless i.save
                     issues_map[bug.id] = i.id
                     print '.'
                     STDOUT.flush
                     # Assignee
                     # Redmine checks that the assignee is a project member
                     if (bug.handler_id && users_map[bug.handler_id])
                       i.assigned_to = User.find_by_id(users_map[bug.handler_id])
                       i.save(:validate => false)
                     end
                     # Bug notes
                     bug.bug_notes.each do |note|
                       next unless users_map[note.reporter_id]
                       n = Journal.new :notes => encode(note.bug_note_text.note),
                                       :created_on => note.date_submitted
                       n.user = User.find_by_id(users_map[note.reporter_id])
                       n.journalized = i
                       n.save
                     end
                     # Bug files
                     bug.bug_files.each do |file|
                       a = Attachment.new :created_on => file.date_added
                       a.file = file
                       a.author = User.find :first
                       a.container = i
                       a.save
                     end
                     # Bug monitors
                     bug.bug_monitors.each do |monitor|
                       next unless users_map[monitor.user_id]
                       i.add_watcher(User.find_by_id(users_map[monitor.user_id]))
                     end
                   end
                   # update issue id sequence if needed (postgresql)
                   Issue.connection.reset_pk_sequence!(Issue.table_name) if Issue.connection.respond_to?('reset_pk_sequence!')
                   puts
                   # Bug relationships
                   print "Migrating bug relations"
-                  MantisBugRelationship.find(:all).each do |relation|
+                  MantisBugRelationship.all.each do |relation|
                     next unless issues_map[relation.source_bug_id] && issues_map[relation.destination_bug_id]
                     r = IssueRelation.new :relation_type => RELATION_TYPE_MAPPING[relation.relationship_type]
                     r.issue_from = Issue.find_by_id(issues_map[relation.source_bug_id])
                     r.issue_to = Issue.find_by_id(issues_map[relation.destination_bug_id])
                     pp r unless r.save
                     print '.'
                     STDOUT.flush
                   end
                   puts
                   # News
                   print "Migrating news"
                   News.destroy_all
-                  MantisNews.find(:all, :conditions => 'project_id > 0').each do |news|
+                  MantisNews.where('project_id > 0').all.each do |news|
                     next unless projects_map[news.project_id]
                     n = News.new :project_id => projects_map[news.project_id],
                                  :title => encode(news.headline[0..59]),
                                  :description => encode(news.body),
                                  :created_on => news.date_posted
                     n.author = User.find_by_id(users_map[news.poster_id])
                     n.save
                     print '.'
                     STDOUT.flush
                   end
                   puts
                   # Custom fields
                   print "Migrating custom fields"
                   IssueCustomField.destroy_all
-                  MantisCustomField.find(:all).each do |field|
+                  MantisCustomField.all.each do |field|
                     f = IssueCustomField.new :name => field.name[0..29],
                                              :field_format => CUSTOM_FIELD_TYPE_MAPPING[field.format],
                                              :min_length => field.length_min,
                                              :max_length => field.length_max,
                                              :regexp => field.valid_regexp,
                                              :possible_values => field.possible_values.split('|'),
                                              :is_required => field.require_report?
                     next unless f.save
                     print '.'
                     STDOUT.flush
                     # Trackers association
-                    f.trackers = Tracker.find :all
+                    f.trackers = Tracker.all
                     # Projects association
                     field.projects.each do |project|
                       f.projects << Project.find_by_id(projects_map[project.project_id]) if projects_map[project.project_id]
                     end
                     # Values
                     field.values.each do |value|
                       v = CustomValue.new :custom_field_id => f.id,
                                           :value => value.value
                       v.customized = Issue.find_by_id(issues_map[value.bug_id]) if issues_map[value.bug_id]
                       v.save
                     end unless f.new_record?
                   end
                   puts
                   puts
                   puts "Users:           #{users_migrated}/#{MantisUser.count}"
                   puts "Projects:        #{Project.count}/#{MantisProject.count}"
                   puts "Memberships:     #{Member.count}/#{MantisProjectUser.count}"
                   puts "Versions:        #{Version.count}/#{MantisVersion.count}"
                   puts "Categories:      #{IssueCategory.count}/#{MantisCategory.count}"
                   puts "Bugs:            #{Issue.count}/#{MantisBug.count}"
                   puts "Bug notes:       #{Journal.count}/#{MantisBugNote.count}"
                   puts "Bug files:       #{Attachment.count}/#{MantisBugFile.count}"
                   puts "Bug relations:   #{IssueRelation.count}/#{MantisBugRelationship.count}"
                   puts "Bug monitors:    #{Watcher.count}/#{MantisBugMonitor.count}"
                   puts "News:            #{News.count}/#{MantisNews.count}"
                   puts "Custom fields:   #{IssueCustomField.count}/#{MantisCustomField.count}"
                 end
                 def self.encoding(charset)
                   @ic = Iconv.new('UTF-8', charset)
                 rescue Iconv::InvalidEncoding
                   return false
                 end
                 def self.establish_connection(params)
                   constants.each do |const|
                     klass = const_get(const)
                     next unless klass.respond_to? 'establish_connection'
                     klass.establish_connection params
                   end
                 end
                 def self.encode(text)
                   @ic.iconv text
                 rescue
                   text
                 end
               end
               puts
               if Redmine::DefaultData::Loader.no_data?
                 puts "Redmine configuration need to be loaded before importing data."
                 puts "Please, run this first:"
                 puts
                 puts "  rake redmine:load_default_data RAILS_ENV=\"#{ENV['RAILS_ENV']}\""
                 exit
               end
               puts "WARNING: Your Redmine data will be deleted during this process."
               print "Are you sure you want to continue ? [y/N] "
               STDOUT.flush
               break unless STDIN.gets.match(/^y$/i)
               # Default Mantis database settings
               db_params = {:adapter => 'mysql2',
                            :database => 'bugtracker',
                            :host => 'localhost',
                            :username => 'root',
                            :password => '' }
               puts
               puts "Please enter settings for your Mantis database"
               [:adapter, :host, :database, :username, :password].each do |param|
                 print "#{param} [#{db_params[param]}]: "
                 value = STDIN.gets.chomp!
                 db_params[param] = value unless value.blank?
               end
               while true
                 print "encoding [UTF-8]: "
                 STDOUT.flush
                 encoding = STDIN.gets.chomp!
                 encoding = 'UTF-8' if encoding.blank?
                 break if MantisMigrate.encoding encoding
                 puts "Invalid encoding!"
               end
               puts
               # Make sure bugs can refer bugs in other projects
               Setting.cross_project_issue_relations = 1 if Setting.respond_to? 'cross_project_issue_relations'
               # Turn off email notifications
               Setting.notified_events = []
               MantisMigrate.establish_connection db_params
               MantisMigrate.migrate
             end
             end

lib/tasks/migrate_from_trac.rake +6 -6

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require 'active_record'
             require 'iconv'
             require 'pp'
             namespace :redmine do
               desc 'Trac migration script'
               task :migrate_from_trac => :environment do
                 module TracMigrate
                     TICKET_MAP = []
                     DEFAULT_STATUS = IssueStatus.default
                     assigned_status = IssueStatus.find_by_position(2)
                     resolved_status = IssueStatus.find_by_position(3)
                     feedback_status = IssueStatus.find_by_position(4)
                     closed_status = IssueStatus.find :first, :conditions => { :is_closed => true }
                     STATUS_MAPPING = {'new' => DEFAULT_STATUS,
                                       'reopened' => feedback_status,
                                       'assigned' => assigned_status,
                                       'closed' => closed_status
                                       }
                     priorities = IssuePriority.all
                     DEFAULT_PRIORITY = priorities[0]
                     PRIORITY_MAPPING = {'lowest' => priorities[0],
                                         'low' => priorities[0],
                                         'normal' => priorities[1],
                                         'high' => priorities[2],
                                         'highest' => priorities[3],
                                         # ---
                                         'trivial' => priorities[0],
                                         'minor' => priorities[1],
                                         'major' => priorities[2],
                                         'critical' => priorities[3],
                                         'blocker' => priorities[4]
                                         }
                     TRACKER_BUG = Tracker.find_by_position(1)
                     TRACKER_FEATURE = Tracker.find_by_position(2)
                     DEFAULT_TRACKER = TRACKER_BUG
                     TRACKER_MAPPING = {'defect' => TRACKER_BUG,
                                        'enhancement' => TRACKER_FEATURE,
                                        'task' => TRACKER_FEATURE,
                                        'patch' =>TRACKER_FEATURE
                                        }
-                    roles = Role.find(:all, :conditions => {:builtin => 0}, :order => 'position ASC')
+                    roles = Role.where(:builtin => 0).order('position ASC').all
                     manager_role = roles[0]
                     developer_role = roles[1]
                     DEFAULT_ROLE = roles.last
                     ROLE_MAPPING = {'admin' => manager_role,
                                     'developer' => developer_role
                                     }
                   class ::Time
                     class << self
                       alias :real_now :now
                       def now
                         real_now - @fake_diff.to_i
                       end
                       def fake(time)
                         @fake_diff = real_now - time
                         res = yield
                         @fake_diff = 0
                        res
                       end
                     end
                   end
                   class TracComponent < ActiveRecord::Base
                     self.table_name = :component
                   end
                   class TracMilestone < ActiveRecord::Base
                     self.table_name = :milestone
                     # If this attribute is set a milestone has a defined target timepoint
                     def due
                       if read_attribute(:due) && read_attribute(:due) > 0
                         Time.at(read_attribute(:due)).to_date
                       else
                         nil
                       end
                     end
                     # This is the real timepoint at which the milestone has finished.
                     def completed
                       if read_attribute(:completed) && read_attribute(:completed) > 0
                         Time.at(read_attribute(:completed)).to_date
                       else
                         nil
                       end
                     end
                     def description
                       # Attribute is named descr in Trac v0.8.x
                       has_attribute?(:descr) ? read_attribute(:descr) : read_attribute(:description)
                     end
                   end
                   class TracTicketCustom < ActiveRecord::Base
                     self.table_name = :ticket_custom
                   end
                   class TracAttachment < ActiveRecord::Base
                     self.table_name = :attachment
                     set_inheritance_column :none
                     def time; Time.at(read_attribute(:time)) end
                     def original_filename
                       filename
                     end
                     def content_type
                       ''
                     end
                     def exist?
                       File.file? trac_fullpath
                     end
                     def open
                       File.open("#{trac_fullpath}", 'rb') {|f|
                         @file = f
                         yield self
                       }
                     end
                     def read(*args)
                       @file.read(*args)
                     end
                     def description
                       read_attribute(:description).to_s.slice(0,255)
                     end
                   private
                     def trac_fullpath
                       attachment_type = read_attribute(:type)
                       trac_file = filename.gsub( /[^a-zA-Z0-9\-_\.!~*']/n ) {|x| sprintf('%%%02x', x[0]) }
                       "#{TracMigrate.trac_attachments_directory}/#{attachment_type}/#{id}/#{trac_file}"
                     end
                   end
                   class TracTicket < ActiveRecord::Base
                     self.table_name = :ticket
                     set_inheritance_column :none
                     # ticket changes: only migrate status changes and comments
                     has_many :ticket_changes, :class_name => "TracTicketChange", :foreign_key => :ticket
                     has_many :customs, :class_name => "TracTicketCustom", :foreign_key => :ticket
                     def attachments
                       TracMigrate::TracAttachment.all(:conditions => ["type = 'ticket' AND id = ?", self.id.to_s])
                     end
                     def ticket_type
                       read_attribute(:type)
                     end
                     def summary
                       read_attribute(:summary).blank? ? "(no subject)" : read_attribute(:summary)
                     end
                     def description
                       read_attribute(:description).blank? ? summary : read_attribute(:description)
                     end
                     def time; Time.at(read_attribute(:time)) end
                     def changetime; Time.at(read_attribute(:changetime)) end
                   end
                   class TracTicketChange < ActiveRecord::Base
                     self.table_name = :ticket_change
                     def self.columns
                       # Hides Trac field 'field' to prevent clash with AR field_changed? method (Rails 3.0)
                       super.select {|column| column.name.to_s != 'field'}
                     end
                     def time; Time.at(read_attribute(:time)) end
                   end
                   TRAC_WIKI_PAGES = %w(InterMapTxt InterTrac InterWiki RecentChanges SandBox TracAccessibility TracAdmin TracBackup TracBrowser TracCgi TracChangeset \
                                        TracEnvironment TracFastCgi TracGuide TracImport TracIni TracInstall TracInterfaceCustomization \
                                        TracLinks TracLogging TracModPython TracNotification TracPermissions TracPlugins TracQuery \
                                        TracReports TracRevisionLog TracRoadmap TracRss TracSearch TracStandalone TracSupport TracSyntaxColoring TracTickets \
                                        TracTicketsCustomFields TracTimeline TracUnicode TracUpgrade TracWiki WikiDeletePage WikiFormatting \
                                        WikiHtml WikiMacros WikiNewPage WikiPageNames WikiProcessors WikiRestructuredText WikiRestructuredTextLinks \
                                        CamelCase TitleIndex)
                   class TracWikiPage < ActiveRecord::Base
                     self.table_name = :wiki
                     set_primary_key :name
                     def self.columns
                       # Hides readonly Trac field to prevent clash with AR readonly? method (Rails 2.0)
                       super.select {|column| column.name.to_s != 'readonly'}
                     end
                     def attachments
                       TracMigrate::TracAttachment.all(:conditions => ["type = 'wiki' AND id = ?", self.id.to_s])
                     end
                     def time; Time.at(read_attribute(:time)) end
                   end
                   class TracPermission < ActiveRecord::Base
                     self.table_name = :permission
                   end
                   class TracSessionAttribute < ActiveRecord::Base
                     self.table_name = :session_attribute
                   end
                   def self.find_or_create_user(username, project_member = false)
                     return User.anonymous if username.blank?
                     u = User.find_by_login(username)
                     if !u
                       # Create a new user if not found
                       mail = username[0, User::MAIL_LENGTH_LIMIT]
                       if mail_attr = TracSessionAttribute.find_by_sid_and_name(username, 'email')
                         mail = mail_attr.value
                       end
                       mail = "#{mail}@foo.bar" unless mail.include?("@")
                       name = username
                       if name_attr = TracSessionAttribute.find_by_sid_and_name(username, 'name')
                         name = name_attr.value
                       end
                       name =~ (/(.*)(\s+\w+)?/)
                       fn = $1.strip
                       ln = ($2 || '-').strip
                       u = User.new :mail => mail.gsub(/[^-@a-z0-9\.]/i, '-'),
                                    :firstname => fn[0, limit_for(User, 'firstname')],
                                    :lastname => ln[0, limit_for(User, 'lastname')]
                       u.login = username[0, User::LOGIN_LENGTH_LIMIT].gsub(/[^a-z0-9_\-@\.]/i, '-')
                       u.password = 'trac'
                       u.admin = true if TracPermission.find_by_username_and_action(username, 'admin')
                       # finally, a default user is used if the new user is not valid
                       u = User.find(:first) unless u.save
                     end
                     # Make sure he is a member of the project
                     if project_member && !u.member_of?(@target_project)
                       role = DEFAULT_ROLE
                       if u.admin
                         role = ROLE_MAPPING['admin']
                       elsif TracPermission.find_by_username_and_action(username, 'developer')
                         role = ROLE_MAPPING['developer']
                       end
                       Member.create(:user => u, :project => @target_project, :roles => [role])
                       u.reload
                     end
                     u
                   end
                   # Basic wiki syntax conversion
                   def self.convert_wiki_text(text)
                     # Titles
                     text = text.gsub(/^(\=+)\s(.+)\s(\=+)/) {|s| "\nh#{$1.length}. #{$2}\n"}
                     # External Links
                     text = text.gsub(/\[(http[^\s]+)\s+([^\]]+)\]/) {|s| "\"#{$2}\":#{$1}"}
                     # Ticket links:
                     #      [ticket:234 Text],[ticket:234 This is a test]
                     text = text.gsub(/\[ticket\:([^\ ]+)\ (.+?)\]/, '"\2":/issues/show/\1')
                     #      ticket:1234
                     #      #1 is working cause Redmine uses the same syntax.
                     text = text.gsub(/ticket\:([^\ ]+)/, '#\1')
                     # Milestone links:
                     #      [milestone:"0.1.0 Mercury" Milestone 0.1.0 (Mercury)]
                     #      The text "Milestone 0.1.0 (Mercury)" is not converted,
                     #      cause Redmine's wiki does not support this.
                     text = text.gsub(/\[milestone\:\"([^\"]+)\"\ (.+?)\]/, 'version:"\1"')
                     #      [milestone:"0.1.0 Mercury"]
                     text = text.gsub(/\[milestone\:\"([^\"]+)\"\]/, 'version:"\1"')
                     text = text.gsub(/milestone\:\"([^\"]+)\"/, 'version:"\1"')
                     #      milestone:0.1.0
                     text = text.gsub(/\[milestone\:([^\ ]+)\]/, 'version:\1')
                     text = text.gsub(/milestone\:([^\ ]+)/, 'version:\1')
                     # Internal Links
                     text = text.gsub(/\[\[BR\]\]/, "\n") # This has to go before the rules below
                     text = text.gsub(/\[\"(.+)\".*\]/) {|s| "[[#{$1.delete(',./?;|:')}]]"}
                     text = text.gsub(/\[wiki:\"(.+)\".*\]/) {|s| "[[#{$1.delete(',./?;|:')}]]"}
                     text = text.gsub(/\[wiki:\"(.+)\".*\]/) {|s| "[[#{$1.delete(',./?;|:')}]]"}
                     text = text.gsub(/\[wiki:([^\s\]]+)\]/) {|s| "[[#{$1.delete(',./?;|:')}]]"}
                     text = text.gsub(/\[wiki:([^\s\]]+)\s(.*)\]/) {|s| "[[#{$1.delete(',./?;|:')}|#{$2.delete(',./?;|:')}]]"}
               # Links to pages UsingJustWikiCaps
               text = text.gsub(/([^!]|^)(^| )([A-Z][a-z]+[A-Z][a-zA-Z]+)/, '\\1\\2[[\3]]')
               # Normalize things that were supposed to not be links
               # like !NotALink
               text = text.gsub(/(^| )!([A-Z][A-Za-z]+)/, '\1\2')
                     # Revisions links
                     text = text.gsub(/\[(\d+)\]/, 'r\1')
                     # Ticket number re-writing
                     text = text.gsub(/#(\d+)/) do |s|
                       if $1.length < 10
             #            TICKET_MAP[$1.to_i] ||= $1
                         "\##{TICKET_MAP[$1.to_i] || $1}"
                       else
                         s
                       end
                     end
                     # We would like to convert the Code highlighting too
                     # This will go into the next line.
                     shebang_line = false
                     # Reguar expression for start of code
                     pre_re = /\{\{\{/
                     # Code hightlighing...
                     shebang_re = /^\#\!([a-z]+)/
                     # Regular expression for end of code
                     pre_end_re = /\}\}\}/
                     # Go through the whole text..extract it line by line
                     text = text.gsub(/^(.*)$/) do |line|
                       m_pre = pre_re.match(line)
                       if m_pre
                         line = '<pre>'
                       else
                         m_sl = shebang_re.match(line)
                         if m_sl
                           shebang_line = true
                           line = '<code class="' + m_sl[1] + '">'
                         end
                         m_pre_end = pre_end_re.match(line)
                         if m_pre_end
                           line = '</pre>'
                           if shebang_line
                             line = '</code>' + line
                           end
                         end
                       end
                       line
                     end
                     # Highlighting
                     text = text.gsub(/'''''([^\s])/, '_*\1')
                     text = text.gsub(/([^\s])'''''/, '\1*_')
                     text = text.gsub(/'''/, '*')
                     text = text.gsub(/''/, '_')
                     text = text.gsub(/__/, '+')
                     text = text.gsub(/~~/, '-')
                     text = text.gsub(/`/, '@')
                     text = text.gsub(/,,/, '~')
                     # Lists
                     text = text.gsub(/^([ ]+)\* /) {|s| '*' * $1.length + " "}
                     text
                   end
                   def self.migrate
                     establish_connection
                     # Quick database test
                     TracComponent.count
                     migrated_components = 0
                     migrated_milestones = 0
                     migrated_tickets = 0
                     migrated_custom_values = 0
                     migrated_ticket_attachments = 0
                     migrated_wiki_edits = 0
                     migrated_wiki_attachments = 0
                     #Wiki system initializing...
                     @target_project.wiki.destroy if @target_project.wiki
                     @target_project.reload
                     wiki = Wiki.new(:project => @target_project, :start_page => 'WikiStart')
                     wiki_edit_count = 0
                     # Components
                     print "Migrating components"
                     issues_category_map = {}
-                    TracComponent.find(:all).each do |component|
+                    TracComponent.all.each do |component|
                     print '.'
                     STDOUT.flush
                       c = IssueCategory.new :project => @target_project,
                                             :name => encode(component.name[0, limit_for(IssueCategory, 'name')])
                     next unless c.save
                     issues_category_map[component.name] = c
                     migrated_components += 1
                     end
                     puts
                     # Milestones
                     print "Migrating milestones"
                     version_map = {}
-                    TracMilestone.find(:all).each do |milestone|
+                    TracMilestone.all.each do |milestone|
                       print '.'
                       STDOUT.flush
                       # First we try to find the wiki page...
                       p = wiki.find_or_new_page(milestone.name.to_s)
                       p.content = WikiContent.new(:page => p) if p.new_record?
                       p.content.text = milestone.description.to_s
                       p.content.author = find_or_create_user('trac')
                       p.content.comments = 'Milestone'
                       p.save
                       v = Version.new :project => @target_project,
                                       :name => encode(milestone.name[0, limit_for(Version, 'name')]),
                                       :description => nil,
                                       :wiki_page_title => milestone.name.to_s,
                                       :effective_date => milestone.completed
                       next unless v.save
                       version_map[milestone.name] = v
                       migrated_milestones += 1
                     end
                     puts
                     # Custom fields
                     # TODO: read trac.ini instead
                     print "Migrating custom fields"
                     custom_field_map = {}
                     TracTicketCustom.find_by_sql("SELECT DISTINCT name FROM #{TracTicketCustom.table_name}").each do |field|
                       print '.'
                       STDOUT.flush
                       # Redmine custom field name
                       field_name = encode(field.name[0, limit_for(IssueCustomField, 'name')]).humanize
                       # Find if the custom already exists in Redmine
                       f = IssueCustomField.find_by_name(field_name)
                       # Or create a new one
                       f ||= IssueCustomField.create(:name => encode(field.name[0, limit_for(IssueCustomField, 'name')]).humanize,
                                                     :field_format => 'string')
                       next if f.new_record?
-                      f.trackers = Tracker.find(:all)
+                      f.trackers = Tracker.all
                       f.projects << @target_project
                       custom_field_map[field.name] = f
                     end
                     puts
                     # Trac 'resolution' field as a Redmine custom field
                     r = IssueCustomField.find(:first, :conditions => { :name => "Resolution" })
                     r = IssueCustomField.new(:name => 'Resolution',
                                              :field_format => 'list',
                                              :is_filter => true) if r.nil?
-                    r.trackers = Tracker.find(:all)
+                    r.trackers = Tracker.all
                     r.projects << @target_project
                     r.possible_values = (r.possible_values + %w(fixed invalid wontfix duplicate worksforme)).flatten.compact.uniq
                     r.save!
                     custom_field_map['resolution'] = r
                     # Tickets
                     print "Migrating tickets"
                       TracTicket.find_each(:batch_size => 200) do |ticket|
                       print '.'
                       STDOUT.flush
                       i = Issue.new :project => @target_project,
                                       :subject => encode(ticket.summary[0, limit_for(Issue, 'subject')]),
                                       :description => convert_wiki_text(encode(ticket.description)),
                                       :priority => PRIORITY_MAPPING[ticket.priority] || DEFAULT_PRIORITY,
                                       :created_on => ticket.time
                       i.author = find_or_create_user(ticket.reporter)
                       i.category = issues_category_map[ticket.component] unless ticket.component.blank?
                       i.fixed_version = version_map[ticket.milestone] unless ticket.milestone.blank?
                       i.status = STATUS_MAPPING[ticket.status] || DEFAULT_STATUS
                       i.tracker = TRACKER_MAPPING[ticket.ticket_type] || DEFAULT_TRACKER
                       i.id = ticket.id unless Issue.exists?(ticket.id)
                       next unless Time.fake(ticket.changetime) { i.save }
                       TICKET_MAP[ticket.id] = i.id
                       migrated_tickets += 1
                       # Owner
                         unless ticket.owner.blank?
                           i.assigned_to = find_or_create_user(ticket.owner, true)
                           Time.fake(ticket.changetime) { i.save }
                         end
                       # Comments and status/resolution changes
                       ticket.ticket_changes.group_by(&:time).each do |time, changeset|
                           status_change = changeset.select {|change| change.field == 'status'}.first
                           resolution_change = changeset.select {|change| change.field == 'resolution'}.first
                           comment_change = changeset.select {|change| change.field == 'comment'}.first
                           n = Journal.new :notes => (comment_change ? convert_wiki_text(encode(comment_change.newvalue)) : ''),
                                           :created_on => time
                           n.user = find_or_create_user(changeset.first.author)
                           n.journalized = i
                           if status_change &&
                                STATUS_MAPPING[status_change.oldvalue] &&
                                STATUS_MAPPING[status_change.newvalue] &&
                                (STATUS_MAPPING[status_change.oldvalue] != STATUS_MAPPING[status_change.newvalue])
                             n.details << JournalDetail.new(:property => 'attr',
                                                            :prop_key => 'status_id',
                                                            :old_value => STATUS_MAPPING[status_change.oldvalue].id,
                                                            :value => STATUS_MAPPING[status_change.newvalue].id)
                           end
                           if resolution_change
                             n.details << JournalDetail.new(:property => 'cf',
                                                            :prop_key => custom_field_map['resolution'].id,
                                                            :old_value => resolution_change.oldvalue,
                                                            :value => resolution_change.newvalue)
                           end
                           n.save unless n.details.empty? && n.notes.blank?
                       end
                       # Attachments
                       ticket.attachments.each do |attachment|
                         next unless attachment.exist?
                           attachment.open {
                             a = Attachment.new :created_on => attachment.time
                             a.file = attachment
                             a.author = find_or_create_user(attachment.author)
                             a.container = i
                             a.description = attachment.description
                             migrated_ticket_attachments += 1 if a.save
                           }
                       end
                       # Custom fields
                       custom_values = ticket.customs.inject({}) do |h, custom|
                         if custom_field = custom_field_map[custom.name]
                           h[custom_field.id] = custom.value
                           migrated_custom_values += 1
                         end
                         h
                       end
                       if custom_field_map['resolution'] && !ticket.resolution.blank?
                         custom_values[custom_field_map['resolution'].id] = ticket.resolution
                       end
                       i.custom_field_values = custom_values
                       i.save_custom_field_values
                     end
                     # update issue id sequence if needed (postgresql)
                     Issue.connection.reset_pk_sequence!(Issue.table_name) if Issue.connection.respond_to?('reset_pk_sequence!')
                     puts
                     # Wiki
                     print "Migrating wiki"
                     if wiki.save
-                      TracWikiPage.find(:all, :order => 'name, version').each do |page|
+                      TracWikiPage.order('name, version').all.each do |page|
                         # Do not migrate Trac manual wiki pages
                         next if TRAC_WIKI_PAGES.include?(page.name)
                         wiki_edit_count += 1
                         print '.'
                         STDOUT.flush
                         p = wiki.find_or_new_page(page.name)
                         p.content = WikiContent.new(:page => p) if p.new_record?
                         p.content.text = page.text
                         p.content.author = find_or_create_user(page.author) unless page.author.blank? || page.author == 'trac'
                         p.content.comments = page.comment
                         Time.fake(page.time) { p.new_record? ? p.save : p.content.save }
                         next if p.content.new_record?
                         migrated_wiki_edits += 1
                         # Attachments
                         page.attachments.each do |attachment|
                           next unless attachment.exist?
                           next if p.attachments.find_by_filename(attachment.filename.gsub(/^.*(\\|\/)/, '').gsub(/[^\w\.\-]/,'_')) #add only once per page
                           attachment.open {
                             a = Attachment.new :created_on => attachment.time
                             a.file = attachment
                             a.author = find_or_create_user(attachment.author)
                             a.description = attachment.description
                             a.container = p
                             migrated_wiki_attachments += 1 if a.save
                           }
                         end
                       end
                       wiki.reload
                       wiki.pages.each do |page|
                         page.content.text = convert_wiki_text(page.content.text)
                         Time.fake(page.content.updated_on) { page.content.save }
                       end
                     end
                     puts
                     puts
                     puts "Components:      #{migrated_components}/#{TracComponent.count}"
                     puts "Milestones:      #{migrated_milestones}/#{TracMilestone.count}"
                     puts "Tickets:         #{migrated_tickets}/#{TracTicket.count}"
                     puts "Ticket files:    #{migrated_ticket_attachments}/" + TracAttachment.count(:conditions => {:type => 'ticket'}).to_s
                     puts "Custom values:   #{migrated_custom_values}/#{TracTicketCustom.count}"
                     puts "Wiki edits:      #{migrated_wiki_edits}/#{wiki_edit_count}"
                     puts "Wiki files:      #{migrated_wiki_attachments}/" + TracAttachment.count(:conditions => {:type => 'wiki'}).to_s
                   end
                   def self.limit_for(klass, attribute)
                     klass.columns_hash[attribute.to_s].limit
                   end
                   def self.encoding(charset)
                     @ic = Iconv.new('UTF-8', charset)
                   rescue Iconv::InvalidEncoding
                     puts "Invalid encoding!"
                     return false
                   end
                   def self.set_trac_directory(path)
                     @@trac_directory = path
                     raise "This directory doesn't exist!" unless File.directory?(path)
                     raise "#{trac_attachments_directory} doesn't exist!" unless File.directory?(trac_attachments_directory)
                     @@trac_directory
                   rescue Exception => e
                     puts e
                     return false
                   end
                   def self.trac_directory
                     @@trac_directory
                   end
                   def self.set_trac_adapter(adapter)
                     return false if adapter.blank?
                     raise "Unknown adapter: #{adapter}!" unless %w(sqlite3 mysql postgresql).include?(adapter)
                     # If adapter is sqlite or sqlite3, make sure that trac.db exists
                     raise "#{trac_db_path} doesn't exist!" if %w(sqlite3).include?(adapter) && !File.exist?(trac_db_path)
                     @@trac_adapter = adapter
                   rescue Exception => e
                     puts e
                     return false
                   end
                   def self.set_trac_db_host(host)
                     return nil if host.blank?
                     @@trac_db_host = host
                   end
                   def self.set_trac_db_port(port)
                     return nil if port.to_i == 0
                     @@trac_db_port = port.to_i
                   end
                   def self.set_trac_db_name(name)
                     return nil if name.blank?
                     @@trac_db_name = name
                   end
                   def self.set_trac_db_username(username)
                     @@trac_db_username = username
                   end
                   def self.set_trac_db_password(password)
                     @@trac_db_password = password
                   end
                   def self.set_trac_db_schema(schema)
                     @@trac_db_schema = schema
                   end
                   mattr_reader :trac_directory, :trac_adapter, :trac_db_host, :trac_db_port, :trac_db_name, :trac_db_schema, :trac_db_username, :trac_db_password
                   def self.trac_db_path; "#{trac_directory}/db/trac.db" end
                   def self.trac_attachments_directory; "#{trac_directory}/attachments" end
                   def self.target_project_identifier(identifier)
                     project = Project.find_by_identifier(identifier)
                     if !project
                       # create the target project
                       project = Project.new :name => identifier.humanize,
                                             :description => ''
                       project.identifier = identifier
                       puts "Unable to create a project with identifier '#{identifier}'!" unless project.save
                       # enable issues and wiki for the created project
                       project.enabled_module_names = ['issue_tracking', 'wiki']
                     else
                       puts
                       puts "This project already exists in your Redmine database."
                       print "Are you sure you want to append data to this project ? [Y/n] "
                       STDOUT.flush
                       exit if STDIN.gets.match(/^n$/i)
                     end
                     project.trackers << TRACKER_BUG unless project.trackers.include?(TRACKER_BUG)
                     project.trackers << TRACKER_FEATURE unless project.trackers.include?(TRACKER_FEATURE)
                     @target_project = project.new_record? ? nil : project
                     @target_project.reload
                   end
                   def self.connection_params
                     if trac_adapter == 'sqlite3'
                       {:adapter => 'sqlite3',
                        :database => trac_db_path}
                     else
                       {:adapter => trac_adapter,
                        :database => trac_db_name,
                        :host => trac_db_host,
                        :port => trac_db_port,
                        :username => trac_db_username,
                        :password => trac_db_password,
                        :schema_search_path => trac_db_schema
                       }
                     end
                   end
                   def self.establish_connection
                     constants.each do |const|
                       klass = const_get(const)
                       next unless klass.respond_to? 'establish_connection'
                       klass.establish_connection connection_params
                     end
                   end
                 private
                   def self.encode(text)
                     @ic.iconv text
                   rescue
                     text
                   end
                 end
                 puts
                 if Redmine::DefaultData::Loader.no_data?
                   puts "Redmine configuration need to be loaded before importing data."
                   puts "Please, run this first:"
                   puts
                   puts "  rake redmine:load_default_data RAILS_ENV=\"#{ENV['RAILS_ENV']}\""
                   exit
                 end
                 puts "WARNING: a new project will be added to Redmine during this process."
                 print "Are you sure you want to continue ? [y/N] "
                 STDOUT.flush
                 break unless STDIN.gets.match(/^y$/i)
                 puts
                 def prompt(text, options = {}, &block)
                   default = options[:default] || ''
                   while true
                     print "#{text} [#{default}]: "
                     STDOUT.flush
                     value = STDIN.gets.chomp!
                     value = default if value.blank?
                     break if yield value
                   end
                 end
                 DEFAULT_PORTS = {'mysql' => 3306, 'postgresql' => 5432}
                 prompt('Trac directory') {|directory| TracMigrate.set_trac_directory directory.strip}
                 prompt('Trac database adapter (sqlite3, mysql2, postgresql)', :default => 'sqlite3') {|adapter| TracMigrate.set_trac_adapter adapter}
                 unless %w(sqlite3).include?(TracMigrate.trac_adapter)
                   prompt('Trac database host', :default => 'localhost') {|host| TracMigrate.set_trac_db_host host}
                   prompt('Trac database port', :default => DEFAULT_PORTS[TracMigrate.trac_adapter]) {|port| TracMigrate.set_trac_db_port port}
                   prompt('Trac database name') {|name| TracMigrate.set_trac_db_name name}
                   prompt('Trac database schema', :default => 'public') {|schema| TracMigrate.set_trac_db_schema schema}
                   prompt('Trac database username') {|username| TracMigrate.set_trac_db_username username}
                   prompt('Trac database password') {|password| TracMigrate.set_trac_db_password password}
                 end
                 prompt('Trac database encoding', :default => 'UTF-8') {|encoding| TracMigrate.encoding encoding}
                 prompt('Target project identifier') {|identifier| TracMigrate.target_project_identifier identifier}
                 puts
                 # Turn off email notifications
                 Setting.notified_events = []
                 TracMigrate.migrate
               end
             end

test/functional/roles_controller_test.rb +2 -2

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class RolesControllerTest < ActionController::TestCase
               fixtures :roles, :users, :members, :member_roles, :workflows, :trackers
               def setup
                 @controller = RolesController.new
                 @request    = ActionController::TestRequest.new
                 @response   = ActionController::TestResponse.new
                 User.current = nil
                 @request.session[:user_id] = 1 # admin
               end
               def test_index
                 get :index
                 assert_response :success
                 assert_template 'index'
                 assert_not_nil assigns(:roles)
-                assert_equal Role.find(:all, :order => 'builtin, position'), assigns(:roles)
+                assert_equal Role.order('builtin, position').all, assigns(:roles)
                 assert_tag :tag => 'a', :attributes => { :href => '/roles/1/edit' },
                                         :content => 'Manager'
               end
               def test_new
                 get :new
                 assert_response :success
                 assert_template 'new'
               end
               def test_new_with_copy
                 copy_from = Role.find(2)
                 get :new, :copy => copy_from.id.to_s
                 assert_response :success
                 assert_template 'new'
                 role = assigns(:role)
                 assert_equal copy_from.permissions, role.permissions
                 assert_select 'form' do
                   # blank name
                   assert_select 'input[name=?][value=]', 'role[name]'
                   # edit_project permission checked
                   assert_select 'input[type=checkbox][name=?][value=edit_project][checked=checked]', 'role[permissions][]'
                   # add_project permission not checked
                   assert_select 'input[type=checkbox][name=?][value=add_project]', 'role[permissions][]'
                   assert_select 'input[type=checkbox][name=?][value=add_project][checked=checked]', 'role[permissions][]', 0
                   # workflow copy selected
                   assert_select 'select[name=?]', 'copy_workflow_from' do
                     assert_select 'option[value=2][selected=selected]'
                   end
                 end
               end
               def test_create_with_validaton_failure
                 post :create, :role => {:name => '',
                                      :permissions => ['add_issues', 'edit_issues', 'log_time', ''],
                                      :assignable => '0'}
                 assert_response :success
                 assert_template 'new'
                 assert_tag :tag => 'div', :attributes => { :id => 'errorExplanation' }
               end
               def test_create_without_workflow_copy
                 post :create, :role => {:name => 'RoleWithoutWorkflowCopy',
                                      :permissions => ['add_issues', 'edit_issues', 'log_time', ''],
                                      :assignable => '0'}
                 assert_redirected_to '/roles'
                 role = Role.find_by_name('RoleWithoutWorkflowCopy')
                 assert_not_nil role
                 assert_equal [:add_issues, :edit_issues, :log_time], role.permissions
                 assert !role.assignable?
               end
               def test_create_with_workflow_copy
                 post :create, :role => {:name => 'RoleWithWorkflowCopy',
                                      :permissions => ['add_issues', 'edit_issues', 'log_time', ''],
                                      :assignable => '0'},
                            :copy_workflow_from => '1'
                 assert_redirected_to '/roles'
                 role = Role.find_by_name('RoleWithWorkflowCopy')
                 assert_not_nil role
                 assert_equal Role.find(1).workflow_rules.size, role.workflow_rules.size
               end
               def test_edit
                 get :edit, :id => 1
                 assert_response :success
                 assert_template 'edit'
                 assert_equal Role.find(1), assigns(:role)
                 assert_select 'select[name=?]', 'role[issues_visibility]'
               end
               def test_edit_anonymous
                 get :edit, :id => Role.anonymous.id
                 assert_response :success
                 assert_template 'edit'
                 assert_select 'select[name=?]', 'role[issues_visibility]', 0
               end
               def test_edit_invalid_should_respond_with_404
                 get :edit, :id => 999
                 assert_response 404
               end
               def test_update
                 put :update, :id => 1,
                             :role => {:name => 'Manager',
                                       :permissions => ['edit_project', ''],
                                       :assignable => '0'}
                 assert_redirected_to '/roles'
                 role = Role.find(1)
                 assert_equal [:edit_project], role.permissions
               end
               def test_update_with_failure
                 put :update, :id => 1, :role => {:name => ''}
                 assert_response :success
                 assert_template 'edit'
               end
               def test_destroy
                 r = Role.create!(:name => 'ToBeDestroyed', :permissions => [:view_wiki_pages])
                 delete :destroy, :id => r
                 assert_redirected_to '/roles'
                 assert_nil Role.find_by_id(r.id)
               end
               def test_destroy_role_in_use
                 delete :destroy, :id => 1
                 assert_redirected_to '/roles'
                 assert_equal 'This role is in use and cannot be deleted.', flash[:error]
                 assert_not_nil Role.find_by_id(1)
               end
               def test_get_permissions
                 get :permissions
                 assert_response :success
                 assert_template 'permissions'
                 assert_not_nil assigns(:roles)
-                assert_equal Role.find(:all, :order => 'builtin, position'), assigns(:roles)
+                assert_equal Role.order('builtin, position').all, assigns(:roles)
                 assert_tag :tag => 'input', :attributes => { :type => 'checkbox',
                                                              :name => 'permissions[3][]',
                                                              :value => 'add_issues',
                                                              :checked => 'checked' }
                 assert_tag :tag => 'input', :attributes => { :type => 'checkbox',
                                                              :name => 'permissions[3][]',
                                                              :value => 'delete_issues',
                                                              :checked => nil }
               end
               def test_post_permissions
                 post :permissions, :permissions => { '0' => '', '1' => ['edit_issues'], '3' => ['add_issues', 'delete_issues']}
                 assert_redirected_to '/roles'
                 assert_equal [:edit_issues], Role.find(1).permissions
                 assert_equal [:add_issues, :delete_issues], Role.find(3).permissions
                 assert Role.find(2).permissions.empty?
               end
               def test_clear_all_permissions
                 post :permissions, :permissions => { '0' => '' }
                 assert_redirected_to '/roles'
                 assert Role.find(1).permissions.empty?
               end
               def test_move_highest
                 put :update, :id => 3, :role => {:move_to => 'highest'}
                 assert_redirected_to '/roles'
                 assert_equal 1, Role.find(3).position
               end
               def test_move_higher
                 position = Role.find(3).position
                 put :update, :id => 3, :role => {:move_to => 'higher'}
                 assert_redirected_to '/roles'
                 assert_equal position - 1, Role.find(3).position
               end
               def test_move_lower
                 position = Role.find(2).position
                 put :update, :id => 2, :role => {:move_to => 'lower'}
                 assert_redirected_to '/roles'
                 assert_equal position + 1, Role.find(2).position
               end
               def test_move_lowest
                 put :update, :id => 2, :role => {:move_to => 'lowest'}
                 assert_redirected_to '/roles'
                 assert_equal Role.count, Role.find(2).position
               end
             end

test/functional/workflows_controller_test.rb +5 -2

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             require 'workflows_controller'
             # Re-raise errors caught by the controller.
             class WorkflowsController; def rescue_action(e) raise e end; end
             class WorkflowsControllerTest < ActionController::TestCase
               fixtures :roles, :trackers, :workflows, :users, :issue_statuses
               def setup
                 @controller = WorkflowsController.new
                 @request    = ActionController::TestRequest.new
                 @response   = ActionController::TestResponse.new
                 User.current = nil
                 @request.session[:user_id] = 1 # admin
               end
               def test_index
                 get :index
                 assert_response :success
                 assert_template 'index'
                 count = WorkflowTransition.count(:all, :conditions => 'role_id = 1 AND tracker_id = 2')
                 assert_tag :tag => 'a', :content => count.to_s,
                                         :attributes => { :href => '/workflows/edit?role_id=1&amp;tracker_id=2' }
               end
               def test_get_edit
                 get :edit
                 assert_response :success
                 assert_template 'edit'
                 assert_not_nil assigns(:roles)
                 assert_not_nil assigns(:trackers)
               end
               def test_get_edit_with_role_and_tracker
                 WorkflowTransition.delete_all
                 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 2, :new_status_id => 3)
                 WorkflowTransition.create!(:role_id => 2, :tracker_id => 1, :old_status_id => 3, :new_status_id => 5)
                 get :edit, :role_id => 2, :tracker_id => 1
                 assert_response :success
                 assert_template 'edit'
                 # used status only
                 assert_not_nil assigns(:statuses)
                 assert_equal [2, 3, 5], assigns(:statuses).collect(&:id)
                 # allowed transitions
                 assert_tag :tag => 'input', :attributes => { :type => 'checkbox',
                                                              :name => 'issue_status[3][5][]',
                                                              :value => 'always',
                                                              :checked => 'checked' }
                 # not allowed
                 assert_tag :tag => 'input', :attributes => { :type => 'checkbox',
                                                              :name => 'issue_status[3][2][]',
                                                              :value => 'always',
                                                              :checked => nil }
                 # unused
                 assert_no_tag :tag => 'input', :attributes => { :type => 'checkbox',
                                                                 :name => 'issue_status[1][1][]' }
               end
               def test_get_edit_with_role_and_tracker_and_all_statuses
                 WorkflowTransition.delete_all
                 get :edit, :role_id => 2, :tracker_id => 1, :used_statuses_only => '0'
                 assert_response :success
                 assert_template 'edit'
                 assert_not_nil assigns(:statuses)
                 assert_equal IssueStatus.count, assigns(:statuses).size
                 assert_tag :tag => 'input', :attributes => { :type => 'checkbox',
                                                              :name => 'issue_status[1][1][]',
                                                              :value => 'always',
                                                              :checked => nil }
               end
               def test_post_edit
                 post :edit, :role_id => 2, :tracker_id => 1,
                   :issue_status => {
                     '4' => {'5' => ['always']},
                     '3' => {'1' => ['always'], '2' => ['always']}
                   }
                 assert_redirected_to '/workflows/edit?role_id=2&tracker_id=1'
                 assert_equal 3, WorkflowTransition.count(:conditions => {:tracker_id => 1, :role_id => 2})
                 assert_not_nil  WorkflowTransition.find(:first, :conditions => {:role_id => 2, :tracker_id => 1, :old_status_id => 3, :new_status_id => 2})
                 assert_nil      WorkflowTransition.find(:first, :conditions => {:role_id => 2, :tracker_id => 1, :old_status_id => 5, :new_status_id => 4})
               end
               def test_post_edit_with_additional_transitions
                 post :edit, :role_id => 2, :tracker_id => 1,
                   :issue_status => {
                     '4' => {'5' => ['always']},
                     '3' => {'1' => ['author'], '2' => ['assignee'], '4' => ['author', 'assignee']}
                   }
                 assert_redirected_to '/workflows/edit?role_id=2&tracker_id=1'
                 assert_equal 4, WorkflowTransition.count(:conditions => {:tracker_id => 1, :role_id => 2})
                 w = WorkflowTransition.find(:first, :conditions => {:role_id => 2, :tracker_id => 1, :old_status_id => 4, :new_status_id => 5})
                 assert ! w.author
                 assert ! w.assignee
                 w = WorkflowTransition.find(:first, :conditions => {:role_id => 2, :tracker_id => 1, :old_status_id => 3, :new_status_id => 1})
                 assert w.author
                 assert ! w.assignee
                 w = WorkflowTransition.find(:first, :conditions => {:role_id => 2, :tracker_id => 1, :old_status_id => 3, :new_status_id => 2})
                 assert ! w.author
                 assert w.assignee
                 w = WorkflowTransition.find(:first, :conditions => {:role_id => 2, :tracker_id => 1, :old_status_id => 3, :new_status_id => 4})
                 assert w.author
                 assert w.assignee
               end
               def test_clear_workflow
                 assert WorkflowTransition.count(:conditions => {:tracker_id => 1, :role_id => 2}) > 0
                 post :edit, :role_id => 2, :tracker_id => 1
                 assert_equal 0, WorkflowTransition.count(:conditions => {:tracker_id => 1, :role_id => 2})
               end
               def test_get_permissions
                 get :permissions
                 assert_response :success
                 assert_template 'permissions'
                 assert_not_nil assigns(:roles)
                 assert_not_nil assigns(:trackers)
               end
               def test_get_permissions_with_role_and_tracker
                 WorkflowPermission.delete_all
                 WorkflowPermission.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :field_name => 'assigned_to_id', :rule => 'required')
                 WorkflowPermission.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :field_name => 'fixed_version_id', :rule => 'required')
                 WorkflowPermission.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 3, :field_name => 'fixed_version_id', :rule => 'readonly')
                 get :permissions, :role_id => 1, :tracker_id => 2
                 assert_response :success
                 assert_template 'permissions'
                 assert_select 'input[name=role_id][value=1]'
                 assert_select 'input[name=tracker_id][value=2]'
                 # Required field
                 assert_select 'select[name=?]', 'permissions[assigned_to_id][2]' do
                   assert_select 'option[value=]'
                   assert_select 'option[value=][selected=selected]', 0
                   assert_select 'option[value=readonly]', :text => 'Read-only'
                   assert_select 'option[value=readonly][selected=selected]', 0
                   assert_select 'option[value=required]', :text => 'Required'
                   assert_select 'option[value=required][selected=selected]'
                 end
                 # Read-only field
                 assert_select 'select[name=?]', 'permissions[fixed_version_id][3]' do
                   assert_select 'option[value=]'
                   assert_select 'option[value=][selected=selected]', 0
                   assert_select 'option[value=readonly]', :text => 'Read-only'
                   assert_select 'option[value=readonly][selected=selected]'
                   assert_select 'option[value=required]', :text => 'Required'
                   assert_select 'option[value=required][selected=selected]', 0
                 end
                 # Other field
                 assert_select 'select[name=?]', 'permissions[due_date][3]' do
                   assert_select 'option[value=]'
                   assert_select 'option[value=][selected=selected]', 0
                   assert_select 'option[value=readonly]', :text => 'Read-only'
                   assert_select 'option[value=readonly][selected=selected]', 0
                   assert_select 'option[value=required]', :text => 'Required'
                   assert_select 'option[value=required][selected=selected]', 0
                 end
               end
               def test_get_permissions_with_required_custom_field_should_not_show_required_option
                 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :tracker_ids => [1], :is_required => true)
                 get :permissions, :role_id => 1, :tracker_id => 1
                 assert_response :success
                 assert_template 'permissions'
                 # Custom field that is always required
                 # The default option is "(Required)"
                 assert_select 'select[name=?]', "permissions[#{cf.id}][3]" do
                   assert_select 'option[value=]'
                   assert_select 'option[value=readonly]', :text => 'Read-only'
                   assert_select 'option[value=required]', 0
                 end
               end
               def test_get_permissions_with_role_and_tracker_and_all_statuses
                 WorkflowTransition.delete_all
                 get :permissions, :role_id => 1, :tracker_id => 2, :used_statuses_only => '0'
                 assert_response :success
                 assert_equal IssueStatus.sorted.all, assigns(:statuses)
               end
               def test_post_permissions
                 WorkflowPermission.delete_all
                 post :permissions, :role_id => 1, :tracker_id => 2, :permissions => {
                   'assigned_to_id' => {'1' => '', '2' => 'readonly', '3' => ''},
                   'fixed_version_id' => {'1' => 'required', '2' => 'readonly', '3' => ''},
                   'due_date' => {'1' => '', '2' => '', '3' => ''},
                 }
                 assert_redirected_to '/workflows/permissions?role_id=1&tracker_id=2'
                 workflows = WorkflowPermission.all
                 assert_equal 3, workflows.size
                 workflows.each do |workflow|
                   assert_equal 1, workflow.role_id
                   assert_equal 2, workflow.tracker_id
                 end
                 assert workflows.detect {|wf| wf.old_status_id == 2 && wf.field_name == 'assigned_to_id' && wf.rule == 'readonly'}
                 assert workflows.detect {|wf| wf.old_status_id == 1 && wf.field_name == 'fixed_version_id' && wf.rule == 'required'}
                 assert workflows.detect {|wf| wf.old_status_id == 2 && wf.field_name == 'fixed_version_id' && wf.rule == 'readonly'}
               end
               def test_post_permissions_should_clear_permissions
                 WorkflowPermission.delete_all
                 WorkflowPermission.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :field_name => 'assigned_to_id', :rule => 'required')
                 WorkflowPermission.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :field_name => 'fixed_version_id', :rule => 'required')
                 wf1 = WorkflowPermission.create!(:role_id => 1, :tracker_id => 3, :old_status_id => 2, :field_name => 'fixed_version_id', :rule => 'required')
                 wf2 = WorkflowPermission.create!(:role_id => 2, :tracker_id => 2, :old_status_id => 3, :field_name => 'fixed_version_id', :rule => 'readonly')
                 post :permissions, :role_id => 1, :tracker_id => 2
                 assert_redirected_to '/workflows/permissions?role_id=1&tracker_id=2'
                 workflows = WorkflowPermission.all
                 assert_equal 2, workflows.size
                 assert wf1.reload
                 assert wf2.reload
               end
               def test_get_copy
                 get :copy
                 assert_response :success
                 assert_template 'copy'
                 assert_select 'select[name=source_tracker_id]' do
                   assert_select 'option[value=1]', :text => 'Bug'
                 end
                 assert_select 'select[name=source_role_id]' do
                   assert_select 'option[value=2]', :text => 'Developer'
                 end
                 assert_select 'select[name=?]', 'target_tracker_ids[]' do
                   assert_select 'option[value=3]', :text => 'Support request'
                 end
                 assert_select 'select[name=?]', 'target_role_ids[]' do
                   assert_select 'option[value=1]', :text => 'Manager'
                 end
               end
               def test_post_copy_one_to_one
                 source_transitions = status_transitions(:tracker_id => 1, :role_id => 2)
                 post :copy, :source_tracker_id => '1', :source_role_id => '2',
                             :target_tracker_ids => ['3'], :target_role_ids => ['1']
                 assert_response 302
                 assert_equal source_transitions, status_transitions(:tracker_id => 3, :role_id => 1)
               end
               def test_post_copy_one_to_many
                 source_transitions = status_transitions(:tracker_id => 1, :role_id => 2)
                 post :copy, :source_tracker_id => '1', :source_role_id => '2',
                             :target_tracker_ids => ['2', '3'], :target_role_ids => ['1', '3']
                 assert_response 302
                 assert_equal source_transitions, status_transitions(:tracker_id => 2, :role_id => 1)
                 assert_equal source_transitions, status_transitions(:tracker_id => 3, :role_id => 1)
                 assert_equal source_transitions, status_transitions(:tracker_id => 2, :role_id => 3)
                 assert_equal source_transitions, status_transitions(:tracker_id => 3, :role_id => 3)
               end
               def test_post_copy_many_to_many
                 source_t2 = status_transitions(:tracker_id => 2, :role_id => 2)
                 source_t3 = status_transitions(:tracker_id => 3, :role_id => 2)
                 post :copy, :source_tracker_id => 'any', :source_role_id => '2',
                             :target_tracker_ids => ['2', '3'], :target_role_ids => ['1', '3']
                 assert_response 302
                 assert_equal source_t2, status_transitions(:tracker_id => 2, :role_id => 1)
                 assert_equal source_t3, status_transitions(:tracker_id => 3, :role_id => 1)
                 assert_equal source_t2, status_transitions(:tracker_id => 2, :role_id => 3)
                 assert_equal source_t3, status_transitions(:tracker_id => 3, :role_id => 3)
               end
               # Returns an array of status transitions that can be compared
               def status_transitions(conditions)
-                WorkflowTransition.find(:all, :conditions => conditions,
+                WorkflowTransition.
-                                    :order => 'tracker_id, role_id, old_status_id, new_status_id').collect {|w| [w.old_status, w.new_status_id]}
+                  where(conditions).
+                  order('tracker_id, role_id, old_status_id, new_status_id').
+                  all.
+                  collect {|w| [w.old_status, w.new_status_id]}
               end
             end

test/unit/helpers/application_helper_test.rb +1 -1

             # encoding: utf-8
             #
             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../../test_helper', __FILE__)
             class ApplicationHelperTest < ActionView::TestCase
               include ERB::Util
               include Rails.application.routes.url_helpers
               fixtures :projects, :roles, :enabled_modules, :users,
                        :repositories, :changesets,
                        :trackers, :issue_statuses, :issues, :versions, :documents,
                        :wikis, :wiki_pages, :wiki_contents,
                        :boards, :messages, :news,
                        :attachments, :enumerations
               def setup
                 super
                 set_tmp_attachments_directory
               end
               context "#link_to_if_authorized" do
                 context "authorized user" do
                   should "be tested"
                 end
                 context "unauthorized user" do
                   should "be tested"
                 end
                 should "allow using the :controller and :action for the target link" do
                   User.current = User.find_by_login('admin')
                   @project = Issue.first.project # Used by helper
                   response = link_to_if_authorized("By controller/action",
                                                    {:controller => 'issues', :action => 'edit', :id => Issue.first.id})
                   assert_match /href/, response
                 end
               end
               def test_auto_links
                 to_test = {
                   'http://foo.bar' => '<a class="external" href="http://foo.bar">http://foo.bar</a>',
                   'http://foo.bar/~user' => '<a class="external" href="http://foo.bar/~user">http://foo.bar/~user</a>',
                   'http://foo.bar.' => '<a class="external" href="http://foo.bar">http://foo.bar</a>.',
                   'https://foo.bar.' => '<a class="external" href="https://foo.bar">https://foo.bar</a>.',
                   'This is a link: http://foo.bar.' => 'This is a link: <a class="external" href="http://foo.bar">http://foo.bar</a>.',
                   'A link (eg. http://foo.bar).' => 'A link (eg. <a class="external" href="http://foo.bar">http://foo.bar</a>).',
                   'http://foo.bar/foo.bar#foo.bar.' => '<a class="external" href="http://foo.bar/foo.bar#foo.bar">http://foo.bar/foo.bar#foo.bar</a>.',
                   'http://www.foo.bar/Test_(foobar)' => '<a class="external" href="http://www.foo.bar/Test_(foobar)">http://www.foo.bar/Test_(foobar)</a>',
                   '(see inline link : http://www.foo.bar/Test_(foobar))' => '(see inline link : <a class="external" href="http://www.foo.bar/Test_(foobar)">http://www.foo.bar/Test_(foobar)</a>)',
                   '(see inline link : http://www.foo.bar/Test)' => '(see inline link : <a class="external" href="http://www.foo.bar/Test">http://www.foo.bar/Test</a>)',
                   '(see inline link : http://www.foo.bar/Test).' => '(see inline link : <a class="external" href="http://www.foo.bar/Test">http://www.foo.bar/Test</a>).',
                   '(see "inline link":http://www.foo.bar/Test_(foobar))' => '(see <a href="http://www.foo.bar/Test_(foobar)" class="external">inline link</a>)',
                   '(see "inline link":http://www.foo.bar/Test)' => '(see <a href="http://www.foo.bar/Test" class="external">inline link</a>)',
                   '(see "inline link":http://www.foo.bar/Test).' => '(see <a href="http://www.foo.bar/Test" class="external">inline link</a>).',
                   'www.foo.bar' => '<a class="external" href="http://www.foo.bar">www.foo.bar</a>',
                   'http://foo.bar/page?p=1&t=z&s=' => '<a class="external" href="http://foo.bar/page?p=1&#38;t=z&#38;s=">http://foo.bar/page?p=1&#38;t=z&#38;s=</a>',
                   'http://foo.bar/page#125' => '<a class="external" href="http://foo.bar/page#125">http://foo.bar/page#125</a>',
                   'http://foo@www.bar.com' => '<a class="external" href="http://foo@www.bar.com">http://foo@www.bar.com</a>',
                   'http://foo:bar@www.bar.com' => '<a class="external" href="http://foo:bar@www.bar.com">http://foo:bar@www.bar.com</a>',
                   'ftp://foo.bar' => '<a class="external" href="ftp://foo.bar">ftp://foo.bar</a>',
                   'ftps://foo.bar' => '<a class="external" href="ftps://foo.bar">ftps://foo.bar</a>',
                   'sftp://foo.bar' => '<a class="external" href="sftp://foo.bar">sftp://foo.bar</a>',
                   # two exclamation marks
                   'http://example.net/path!602815048C7B5C20!302.html' => '<a class="external" href="http://example.net/path!602815048C7B5C20!302.html">http://example.net/path!602815048C7B5C20!302.html</a>',
                   # escaping
                   'http://foo"bar' => '<a class="external" href="http://foo&quot;bar">http://foo&quot;bar</a>',
                   # wrap in angle brackets
                   '<http://foo.bar>' => '&lt;<a class="external" href="http://foo.bar">http://foo.bar</a>&gt;'
                 }
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text) }
               end
               if 'ruby'.respond_to?(:encoding)
                 def test_auto_links_with_non_ascii_characters
                   to_test = {
                     'http://foo.bar/тест' => '<a class="external" href="http://foo.bar/тест">http://foo.bar/тест</a>'
                   }
                   to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text) }
                 end
               else
                 puts 'Skipping test_auto_links_with_non_ascii_characters, unsupported ruby version'
               end
               def test_auto_mailto
                 assert_equal '<p><a class="email" href="mailto:test@foo.bar">test@foo.bar</a></p>',
                   textilizable('test@foo.bar')
               end
               def test_inline_images
                 to_test = {
                   '!http://foo.bar/image.jpg!' => '<img src="http://foo.bar/image.jpg" alt="" />',
                   'floating !>http://foo.bar/image.jpg!' => 'floating <div style="float:right"><img src="http://foo.bar/image.jpg" alt="" /></div>',
                   'with class !(some-class)http://foo.bar/image.jpg!' => 'with class <img src="http://foo.bar/image.jpg" class="some-class" alt="" />',
                   'with style !{width:100px;height:100px}http://foo.bar/image.jpg!' => 'with style <img src="http://foo.bar/image.jpg" style="width:100px;height:100px;" alt="" />',
                   'with title !http://foo.bar/image.jpg(This is a title)!' => 'with title <img src="http://foo.bar/image.jpg" title="This is a title" alt="This is a title" />',
                   'with title !http://foo.bar/image.jpg(This is a double-quoted "title")!' => 'with title <img src="http://foo.bar/image.jpg" title="This is a double-quoted &quot;title&quot;" alt="This is a double-quoted &quot;title&quot;" />',
                 }
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text) }
               end
               def test_inline_images_inside_tags
                 raw = <<-RAW
             h1. !foo.png! Heading
             Centered image:
             p=. !bar.gif!
             RAW
                 assert textilizable(raw).include?('<img src="foo.png" alt="" />')
                 assert textilizable(raw).include?('<img src="bar.gif" alt="" />')
               end
               def test_attached_images
                 to_test = {
                   'Inline image: !logo.gif!' => 'Inline image: <img src="/attachments/download/3" title="This is a logo" alt="This is a logo" />',
                   'Inline image: !logo.GIF!' => 'Inline image: <img src="/attachments/download/3" title="This is a logo" alt="This is a logo" />',
                   'No match: !ogo.gif!' => 'No match: <img src="ogo.gif" alt="" />',
                   'No match: !ogo.GIF!' => 'No match: <img src="ogo.GIF" alt="" />',
                   # link image
                   '!logo.gif!:http://foo.bar/' => '<a href="http://foo.bar/"><img src="/attachments/download/3" title="This is a logo" alt="This is a logo" /></a>',
                 }
-                attachments = Attachment.find(:all)
+                attachments = Attachment.all
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text, :attachments => attachments) }
               end
               def test_attached_images_filename_extension
                 set_tmp_attachments_directory
                 a1 = Attachment.new(
                         :container => Issue.find(1),
                         :file => mock_file_with_options({:original_filename => "testtest.JPG"}),
                         :author => User.find(1))
                 assert a1.save
                 assert_equal "testtest.JPG", a1.filename
                 assert_equal "image/jpeg", a1.content_type
                 assert a1.image?
                 a2 = Attachment.new(
                         :container => Issue.find(1),
                         :file => mock_file_with_options({:original_filename => "testtest.jpeg"}),
                         :author => User.find(1))
                 assert a2.save
                 assert_equal "testtest.jpeg", a2.filename
                 assert_equal "image/jpeg", a2.content_type
                 assert a2.image?
                 a3 = Attachment.new(
                         :container => Issue.find(1),
                         :file => mock_file_with_options({:original_filename => "testtest.JPE"}),
                         :author => User.find(1))
                 assert a3.save
                 assert_equal "testtest.JPE", a3.filename
                 assert_equal "image/jpeg", a3.content_type
                 assert a3.image?
                 a4 = Attachment.new(
                         :container => Issue.find(1),
                         :file => mock_file_with_options({:original_filename => "Testtest.BMP"}),
                         :author => User.find(1))
                 assert a4.save
                 assert_equal "Testtest.BMP", a4.filename
                 assert_equal "image/x-ms-bmp", a4.content_type
                 assert a4.image?
                 to_test = {
                   'Inline image: !testtest.jpg!' =>
                     'Inline image: <img src="/attachments/download/' + a1.id.to_s + '" alt="" />',
                   'Inline image: !testtest.jpeg!' =>
                     'Inline image: <img src="/attachments/download/' + a2.id.to_s + '" alt="" />',
                   'Inline image: !testtest.jpe!' =>
                     'Inline image: <img src="/attachments/download/' + a3.id.to_s + '" alt="" />',
                   'Inline image: !testtest.bmp!' =>
                     'Inline image: <img src="/attachments/download/' + a4.id.to_s + '" alt="" />',
                 }
                 attachments = [a1, a2, a3, a4]
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text, :attachments => attachments) }
               end
               def test_attached_images_should_read_later
                 set_fixtures_attachments_directory
                 a1 = Attachment.find(16)
                 assert_equal "testfile.png", a1.filename
                 assert a1.readable?
                 assert (! a1.visible?(User.anonymous))
                 assert a1.visible?(User.find(2))
                 a2 = Attachment.find(17)
                 assert_equal "testfile.PNG", a2.filename
                 assert a2.readable?
                 assert (! a2.visible?(User.anonymous))
                 assert a2.visible?(User.find(2))
                 assert a1.created_on < a2.created_on
                 to_test = {
                   'Inline image: !testfile.png!' =>
                     'Inline image: <img src="/attachments/download/' + a2.id.to_s + '" alt="" />',
                   'Inline image: !Testfile.PNG!' =>
                     'Inline image: <img src="/attachments/download/' + a2.id.to_s + '" alt="" />',
                 }
                 attachments = [a1, a2]
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text, :attachments => attachments) }
                 set_tmp_attachments_directory
               end
               def test_textile_external_links
                 to_test = {
                   'This is a "link":http://foo.bar' => 'This is a <a href="http://foo.bar" class="external">link</a>',
                   'This is an intern "link":/foo/bar' => 'This is an intern <a href="/foo/bar">link</a>',
                   '"link (Link title)":http://foo.bar' => '<a href="http://foo.bar" title="Link title" class="external">link</a>',
                   '"link (Link title with "double-quotes")":http://foo.bar' => '<a href="http://foo.bar" title="Link title with &quot;double-quotes&quot;" class="external">link</a>',
                   "This is not a \"Link\":\n\nAnother paragraph" => "This is not a \"Link\":</p>\n\n\n\t<p>Another paragraph",
                   # no multiline link text
                   "This is a double quote \"on the first line\nand another on a second line\":test" => "This is a double quote \"on the first line<br />and another on a second line\":test",
                   # mailto link
                   "\"system administrator\":mailto:sysadmin@example.com?subject=redmine%20permissions" => "<a href=\"mailto:sysadmin@example.com?subject=redmine%20permissions\">system administrator</a>",
                   # two exclamation marks
                   '"a link":http://example.net/path!602815048C7B5C20!302.html' => '<a href="http://example.net/path!602815048C7B5C20!302.html" class="external">a link</a>',
                   # escaping
                   '"test":http://foo"bar' => '<a href="http://foo&quot;bar" class="external">test</a>',
                 }
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text) }
               end
               if 'ruby'.respond_to?(:encoding)
                 def test_textile_external_links_with_non_ascii_characters
                   to_test = {
                     'This is a "link":http://foo.bar/тест' => 'This is a <a href="http://foo.bar/тест" class="external">link</a>'
                   }
                   to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text) }
                 end
               else
                 puts 'Skipping test_textile_external_links_with_non_ascii_characters, unsupported ruby version'
               end
               def test_redmine_links
                 issue_link = link_to('#3', {:controller => 'issues', :action => 'show', :id => 3},
                                            :class => 'issue status-1 priority-4 priority-lowest overdue', :title => 'Error 281 when updating a recipe (New)')
                 note_link = link_to('#3', {:controller => 'issues', :action => 'show', :id => 3, :anchor => 'note-14'},
                                            :class => 'issue status-1 priority-4 priority-lowest overdue', :title => 'Error 281 when updating a recipe (New)')
                 changeset_link = link_to('r1', {:controller => 'repositories', :action => 'revision', :id => 'ecookbook', :rev => 1},
                                                :class => 'changeset', :title => 'My very first commit')
                 changeset_link2 = link_to('r2', {:controller => 'repositories', :action => 'revision', :id => 'ecookbook', :rev => 2},
                                                 :class => 'changeset', :title => 'This commit fixes #1, #2 and references #1 & #3')
                 document_link = link_to('Test document', {:controller => 'documents', :action => 'show', :id => 1},
                                                          :class => 'document')
                 version_link = link_to('1.0', {:controller => 'versions', :action => 'show', :id => 2},
                                               :class => 'version')
                 board_url = {:controller => 'boards', :action => 'show', :id => 2, :project_id => 'ecookbook'}
                 message_url = {:controller => 'messages', :action => 'show', :board_id => 1, :id => 4}
                 news_url = {:controller => 'news', :action => 'show', :id => 1}
                 project_url = {:controller => 'projects', :action => 'show', :id => 'subproject1'}
                 source_url = '/projects/ecookbook/repository/entry/some/file'
                 source_url_with_rev = '/projects/ecookbook/repository/revisions/52/entry/some/file'
                 source_url_with_ext = '/projects/ecookbook/repository/entry/some/file.ext'
                 source_url_with_rev_and_ext = '/projects/ecookbook/repository/revisions/52/entry/some/file.ext'
                 export_url = '/projects/ecookbook/repository/raw/some/file'
                 export_url_with_rev = '/projects/ecookbook/repository/revisions/52/raw/some/file'
                 export_url_with_ext = '/projects/ecookbook/repository/raw/some/file.ext'
                 export_url_with_rev_and_ext = '/projects/ecookbook/repository/revisions/52/raw/some/file.ext'
                 to_test = {
                   # tickets
                   '#3, [#3], (#3) and #3.'      => "#{issue_link}, [#{issue_link}], (#{issue_link}) and #{issue_link}.",
                   # ticket notes
                   '#3-14'                       => note_link,
                   '#3#note-14'                  => note_link,
                   # should not ignore leading zero
                   '#03'                         => '#03',
                   # changesets
                   'r1'                          => changeset_link,
                   'r1.'                         => "#{changeset_link}.",
                   'r1, r2'                      => "#{changeset_link}, #{changeset_link2}",
                   'r1,r2'                       => "#{changeset_link},#{changeset_link2}",
                   # documents
                   'document#1'                  => document_link,
                   'document:"Test document"'    => document_link,
                   # versions
                   'version#2'                   => version_link,
                   'version:1.0'                 => version_link,
                   'version:"1.0"'               => version_link,
                   # source
                   'source:some/file'            => link_to('source:some/file', source_url, :class => 'source'),
                   'source:/some/file'           => link_to('source:/some/file', source_url, :class => 'source'),
                   'source:/some/file.'          => link_to('source:/some/file', source_url, :class => 'source') + ".",
                   'source:/some/file.ext.'      => link_to('source:/some/file.ext', source_url_with_ext, :class => 'source') + ".",
                   'source:/some/file. '         => link_to('source:/some/file', source_url, :class => 'source') + ".",
                   'source:/some/file.ext. '     => link_to('source:/some/file.ext', source_url_with_ext, :class => 'source') + ".",
                   'source:/some/file, '         => link_to('source:/some/file', source_url, :class => 'source') + ",",
                   'source:/some/file@52'        => link_to('source:/some/file@52', source_url_with_rev, :class => 'source'),
                   'source:/some/file.ext@52'    => link_to('source:/some/file.ext@52', source_url_with_rev_and_ext, :class => 'source'),
                   'source:/some/file#L110'      => link_to('source:/some/file#L110', source_url + "#L110", :class => 'source'),
                   'source:/some/file.ext#L110'  => link_to('source:/some/file.ext#L110', source_url_with_ext + "#L110", :class => 'source'),
                   'source:/some/file@52#L110'   => link_to('source:/some/file@52#L110', source_url_with_rev + "#L110", :class => 'source'),
                   # export
                   'export:/some/file'           => link_to('export:/some/file', export_url, :class => 'source download'),
                   'export:/some/file.ext'       => link_to('export:/some/file.ext', export_url_with_ext, :class => 'source download'),
                   'export:/some/file@52'        => link_to('export:/some/file@52', export_url_with_rev, :class => 'source download'),
                   'export:/some/file.ext@52'    => link_to('export:/some/file.ext@52', export_url_with_rev_and_ext, :class => 'source download'),
                   # forum
                   'forum#2'                     => link_to('Discussion', board_url, :class => 'board'),
                   'forum:Discussion'            => link_to('Discussion', board_url, :class => 'board'),
                   # message
                   'message#4'                   => link_to('Post 2', message_url, :class => 'message'),
                   'message#5'                   => link_to('RE: post 2', message_url.merge(:anchor => 'message-5', :r => 5), :class => 'message'),
                   # news
                   'news#1'                      => link_to('eCookbook first release !', news_url, :class => 'news'),
                   'news:"eCookbook first release !"'        => link_to('eCookbook first release !', news_url, :class => 'news'),
                   # project
                   'project#3'                   => link_to('eCookbook Subproject 1', project_url, :class => 'project'),
                   'project:subproject1'         => link_to('eCookbook Subproject 1', project_url, :class => 'project'),
                   'project:"eCookbook subProject 1"'        => link_to('eCookbook Subproject 1', project_url, :class => 'project'),
                   # not found
                   '#0123456789'                 => '#0123456789',
                   # invalid expressions
                   'source:'                     => 'source:',
                   # url hash
                   "http://foo.bar/FAQ#3"       => '<a class="external" href="http://foo.bar/FAQ#3">http://foo.bar/FAQ#3</a>',
                 }
                 @project = Project.find(1)
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text), "#{text} failed" }
               end
               def test_escaped_redmine_links_should_not_be_parsed
                 to_test = [
                   '#3.',
                   '#3-14.',
                   '#3#-note14.',
                   'r1',
                   'document#1',
                   'document:"Test document"',
                   'version#2',
                   'version:1.0',
                   'version:"1.0"',
                   'source:/some/file'
                 ]
                 @project = Project.find(1)
                 to_test.each { |text| assert_equal "<p>#{text}</p>", textilizable("!" + text), "#{text} failed" }
               end
               def test_cross_project_redmine_links
                 source_link = link_to('ecookbook:source:/some/file', {:controller => 'repositories', :action => 'entry', :id => 'ecookbook', :path => ['some', 'file']},
                   :class => 'source')
                 changeset_link = link_to('ecookbook:r2', {:controller => 'repositories', :action => 'revision', :id => 'ecookbook', :rev => 2},
                   :class => 'changeset', :title => 'This commit fixes #1, #2 and references #1 & #3')
                 to_test = {
                   # documents
                   'document:"Test document"'              => 'document:"Test document"',
                   'ecookbook:document:"Test document"'    => '<a href="/documents/1" class="document">Test document</a>',
                   'invalid:document:"Test document"'      => 'invalid:document:"Test document"',
                   # versions
                   'version:"1.0"'                         => 'version:"1.0"',
                   'ecookbook:version:"1.0"'               => '<a href="/versions/2" class="version">1.0</a>',
                   'invalid:version:"1.0"'                 => 'invalid:version:"1.0"',
                   # changeset
                   'r2'                                    => 'r2',
                   'ecookbook:r2'                          => changeset_link,
                   'invalid:r2'                            => 'invalid:r2',
                   # source
                   'source:/some/file'                     => 'source:/some/file',
                   'ecookbook:source:/some/file'           => source_link,
                   'invalid:source:/some/file'             => 'invalid:source:/some/file',
                 }
                 @project = Project.find(3)
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text), "#{text} failed" }
               end
               def test_multiple_repositories_redmine_links
                 svn = Repository::Subversion.create!(:project_id => 1, :identifier => 'svn1', :url => 'file:///foo/hg')
                 Changeset.create!(:repository => svn, :committed_on => Time.now, :revision => '123')
                 hg = Repository::Mercurial.create!(:project_id => 1, :identifier => 'hg1', :url => '/foo/hg')
                 Changeset.create!(:repository => hg, :committed_on => Time.now, :revision => '123', :scmid => 'abcd')
                 changeset_link = link_to('r2', {:controller => 'repositories', :action => 'revision', :id => 'ecookbook', :rev => 2},
                                                 :class => 'changeset', :title => 'This commit fixes #1, #2 and references #1 & #3')
                 svn_changeset_link = link_to('svn1|r123', {:controller => 'repositories', :action => 'revision', :id => 'ecookbook', :repository_id => 'svn1', :rev => 123},
                                                 :class => 'changeset', :title => '')
                 hg_changeset_link = link_to('hg1|abcd', {:controller => 'repositories', :action => 'revision', :id => 'ecookbook', :repository_id => 'hg1', :rev => 'abcd'},
                                                 :class => 'changeset', :title => '')
                 source_link = link_to('source:some/file', {:controller => 'repositories', :action => 'entry', :id => 'ecookbook', :path => ['some', 'file']}, :class => 'source')
                 hg_source_link = link_to('source:hg1|some/file', {:controller => 'repositories', :action => 'entry', :id => 'ecookbook', :repository_id => 'hg1', :path => ['some', 'file']}, :class => 'source')
                 to_test = {
                   'r2'                          => changeset_link,
                   'svn1|r123'                   => svn_changeset_link,
                   'invalid|r123'                => 'invalid|r123',
                   'commit:hg1|abcd'             => hg_changeset_link,
                   'commit:invalid|abcd'         => 'commit:invalid|abcd',
                   # source
                   'source:some/file'            => source_link,
                   'source:hg1|some/file'        => hg_source_link,
                   'source:invalid|some/file'    => 'source:invalid|some/file',
                 }
                 @project = Project.find(1)
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text), "#{text} failed" }
               end
               def test_cross_project_multiple_repositories_redmine_links
                 svn = Repository::Subversion.create!(:project_id => 1, :identifier => 'svn1', :url => 'file:///foo/hg')
                 Changeset.create!(:repository => svn, :committed_on => Time.now, :revision => '123')
                 hg = Repository::Mercurial.create!(:project_id => 1, :identifier => 'hg1', :url => '/foo/hg')
                 Changeset.create!(:repository => hg, :committed_on => Time.now, :revision => '123', :scmid => 'abcd')
                 changeset_link = link_to('ecookbook:r2', {:controller => 'repositories', :action => 'revision', :id => 'ecookbook', :rev => 2},
                                                 :class => 'changeset', :title => 'This commit fixes #1, #2 and references #1 & #3')
                 svn_changeset_link = link_to('ecookbook:svn1|r123', {:controller => 'repositories', :action => 'revision', :id => 'ecookbook', :repository_id => 'svn1', :rev => 123},
                                                 :class => 'changeset', :title => '')
                 hg_changeset_link = link_to('ecookbook:hg1|abcd', {:controller => 'repositories', :action => 'revision', :id => 'ecookbook', :repository_id => 'hg1', :rev => 'abcd'},
                                                 :class => 'changeset', :title => '')
                 source_link = link_to('ecookbook:source:some/file', {:controller => 'repositories', :action => 'entry', :id => 'ecookbook', :path => ['some', 'file']}, :class => 'source')
                 hg_source_link = link_to('ecookbook:source:hg1|some/file', {:controller => 'repositories', :action => 'entry', :id => 'ecookbook', :repository_id => 'hg1', :path => ['some', 'file']}, :class => 'source')
                 to_test = {
                   'ecookbook:r2'                           => changeset_link,
                   'ecookbook:svn1|r123'                    => svn_changeset_link,
                   'ecookbook:invalid|r123'                 => 'ecookbook:invalid|r123',
                   'ecookbook:commit:hg1|abcd'              => hg_changeset_link,
                   'ecookbook:commit:invalid|abcd'          => 'ecookbook:commit:invalid|abcd',
                   'invalid:commit:invalid|abcd'            => 'invalid:commit:invalid|abcd',
                   # source
                   'ecookbook:source:some/file'             => source_link,
                   'ecookbook:source:hg1|some/file'         => hg_source_link,
                   'ecookbook:source:invalid|some/file'     => 'ecookbook:source:invalid|some/file',
                   'invalid:source:invalid|some/file'       => 'invalid:source:invalid|some/file',
                 }
                 @project = Project.find(3)
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text), "#{text} failed" }
               end
               def test_redmine_links_git_commit
                 changeset_link = link_to('abcd',
                                            {
                                              :controller => 'repositories',
                                              :action     => 'revision',
                                              :id         => 'subproject1',
                                              :rev        => 'abcd',
                                             },
                                           :class => 'changeset', :title => 'test commit')
                 to_test = {
                   'commit:abcd' => changeset_link,
                  }
                 @project = Project.find(3)
                 r = Repository::Git.create!(:project => @project, :url => '/tmp/test/git')
                 assert r
                 c = Changeset.new(:repository => r,
                                   :committed_on => Time.now,
                                   :revision => 'abcd',
                                   :scmid => 'abcd',
                                   :comments => 'test commit')
                 assert( c.save )
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text) }
               end
               # TODO: Bazaar commit id contains mail address, so it contains '@' and '_'.
               def test_redmine_links_darcs_commit
                 changeset_link = link_to('20080308225258-98289-abcd456efg.gz',
                                            {
                                              :controller => 'repositories',
                                              :action     => 'revision',
                                              :id         => 'subproject1',
                                              :rev        => '123',
                                             },
                                           :class => 'changeset', :title => 'test commit')
                 to_test = {
                   'commit:20080308225258-98289-abcd456efg.gz' => changeset_link,
                  }
                 @project = Project.find(3)
                 r = Repository::Darcs.create!(
                         :project => @project, :url => '/tmp/test/darcs',
                         :log_encoding => 'UTF-8')
                 assert r
                 c = Changeset.new(:repository => r,
                                   :committed_on => Time.now,
                                   :revision => '123',
                                   :scmid => '20080308225258-98289-abcd456efg.gz',
                                   :comments => 'test commit')
                 assert( c.save )
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text) }
               end
               def test_redmine_links_mercurial_commit
                 changeset_link_rev = link_to('r123',
                                               {
                                                  :controller => 'repositories',
                                                  :action     => 'revision',
                                                  :id         => 'subproject1',
                                                  :rev        => '123' ,
                                               },
                                           :class => 'changeset', :title => 'test commit')
                 changeset_link_commit = link_to('abcd',
                                               {
                                                     :controller => 'repositories',
                                                     :action     => 'revision',
                                                     :id         => 'subproject1',
                                                     :rev        => 'abcd' ,
                                               },
                                           :class => 'changeset', :title => 'test commit')
                 to_test = {
                   'r123' => changeset_link_rev,
                   'commit:abcd' => changeset_link_commit,
                  }
                 @project = Project.find(3)
                 r = Repository::Mercurial.create!(:project => @project, :url => '/tmp/test')
                 assert r
                 c = Changeset.new(:repository => r,
                                   :committed_on => Time.now,
                                   :revision => '123',
                                   :scmid => 'abcd',
                                   :comments => 'test commit')
                 assert( c.save )
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text) }
               end
               def test_attachment_links
                 attachment_link = link_to('error281.txt', {:controller => 'attachments', :action => 'download', :id => '1'}, :class => 'attachment')
                 to_test = {
                   'attachment:error281.txt'      => attachment_link
                 }
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text, :attachments => Issue.find(3).attachments), "#{text} failed" }
               end
               def test_wiki_links
                 to_test = {
                   '[[CookBook documentation]]' => '<a href="/projects/ecookbook/wiki/CookBook_documentation" class="wiki-page">CookBook documentation</a>',
                   '[[Another page|Page]]' => '<a href="/projects/ecookbook/wiki/Another_page" class="wiki-page">Page</a>',
                   # title content should be formatted
                   '[[Another page|With _styled_ *title*]]' => '<a href="/projects/ecookbook/wiki/Another_page" class="wiki-page">With <em>styled</em> <strong>title</strong></a>',
                   '[[Another page|With title containing <strong>HTML entities &amp; markups</strong>]]' => '<a href="/projects/ecookbook/wiki/Another_page" class="wiki-page">With title containing &lt;strong&gt;HTML entities &amp; markups&lt;/strong&gt;</a>',
                   # link with anchor
                   '[[CookBook documentation#One-section]]' => '<a href="/projects/ecookbook/wiki/CookBook_documentation#One-section" class="wiki-page">CookBook documentation</a>',
                   '[[Another page#anchor|Page]]' => '<a href="/projects/ecookbook/wiki/Another_page#anchor" class="wiki-page">Page</a>',
                   # UTF8 anchor
                   '[[Another_page#Тест|Тест]]' => %|<a href="/projects/ecookbook/wiki/Another_page##{CGI.escape 'Тест'}" class="wiki-page">Тест</a>|,
                   # page that doesn't exist
                   '[[Unknown page]]' => '<a href="/projects/ecookbook/wiki/Unknown_page" class="wiki-page new">Unknown page</a>',
                   '[[Unknown page|404]]' => '<a href="/projects/ecookbook/wiki/Unknown_page" class="wiki-page new">404</a>',
                   # link to another project wiki
                   '[[onlinestore:]]' => '<a href="/projects/onlinestore/wiki" class="wiki-page">onlinestore</a>',
                   '[[onlinestore:|Wiki]]' => '<a href="/projects/onlinestore/wiki" class="wiki-page">Wiki</a>',
                   '[[onlinestore:Start page]]' => '<a href="/projects/onlinestore/wiki/Start_page" class="wiki-page">Start page</a>',
                   '[[onlinestore:Start page|Text]]' => '<a href="/projects/onlinestore/wiki/Start_page" class="wiki-page">Text</a>',
                   '[[onlinestore:Unknown page]]' => '<a href="/projects/onlinestore/wiki/Unknown_page" class="wiki-page new">Unknown page</a>',
                   # striked through link
                   '-[[Another page|Page]]-' => '<del><a href="/projects/ecookbook/wiki/Another_page" class="wiki-page">Page</a></del>',
                   '-[[Another page|Page]] link-' => '<del><a href="/projects/ecookbook/wiki/Another_page" class="wiki-page">Page</a> link</del>',
                   # escaping
                   '![[Another page|Page]]' => '[[Another page|Page]]',
                   # project does not exist
                   '[[unknowproject:Start]]' => '[[unknowproject:Start]]',
                   '[[unknowproject:Start|Page title]]' => '[[unknowproject:Start|Page title]]',
                 }
                 @project = Project.find(1)
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text) }
               end
               def test_wiki_links_within_local_file_generation_context
                 to_test = {
                   # link to a page
                   '[[CookBook documentation]]' => '<a href="CookBook_documentation.html" class="wiki-page">CookBook documentation</a>',
                   '[[CookBook documentation|documentation]]' => '<a href="CookBook_documentation.html" class="wiki-page">documentation</a>',
                   '[[CookBook documentation#One-section]]' => '<a href="CookBook_documentation.html#One-section" class="wiki-page">CookBook documentation</a>',
                   '[[CookBook documentation#One-section|documentation]]' => '<a href="CookBook_documentation.html#One-section" class="wiki-page">documentation</a>',
                   # page that doesn't exist
                   '[[Unknown page]]' => '<a href="Unknown_page.html" class="wiki-page new">Unknown page</a>',
                   '[[Unknown page|404]]' => '<a href="Unknown_page.html" class="wiki-page new">404</a>',
                   '[[Unknown page#anchor]]' => '<a href="Unknown_page.html#anchor" class="wiki-page new">Unknown page</a>',
                   '[[Unknown page#anchor|404]]' => '<a href="Unknown_page.html#anchor" class="wiki-page new">404</a>',
                 }
                 @project = Project.find(1)
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text, :wiki_links => :local) }
               end
               def test_wiki_links_within_wiki_page_context
                 page = WikiPage.find_by_title('Another_page' )
                 to_test = {
                   # link to another page
                   '[[CookBook documentation]]' => '<a href="/projects/ecookbook/wiki/CookBook_documentation" class="wiki-page">CookBook documentation</a>',
                   '[[CookBook documentation|documentation]]' => '<a href="/projects/ecookbook/wiki/CookBook_documentation" class="wiki-page">documentation</a>',
                   '[[CookBook documentation#One-section]]' => '<a href="/projects/ecookbook/wiki/CookBook_documentation#One-section" class="wiki-page">CookBook documentation</a>',
                   '[[CookBook documentation#One-section|documentation]]' => '<a href="/projects/ecookbook/wiki/CookBook_documentation#One-section" class="wiki-page">documentation</a>',
                   # link to the current page
                   '[[Another page]]' => '<a href="/projects/ecookbook/wiki/Another_page" class="wiki-page">Another page</a>',
                   '[[Another page|Page]]' => '<a href="/projects/ecookbook/wiki/Another_page" class="wiki-page">Page</a>',
                   '[[Another page#anchor]]' => '<a href="#anchor" class="wiki-page">Another page</a>',
                   '[[Another page#anchor|Page]]' => '<a href="#anchor" class="wiki-page">Page</a>',
                   # page that doesn't exist
                   '[[Unknown page]]' => '<a href="/projects/ecookbook/wiki/Unknown_page?parent=Another_page" class="wiki-page new">Unknown page</a>',
                   '[[Unknown page|404]]' => '<a href="/projects/ecookbook/wiki/Unknown_page?parent=Another_page" class="wiki-page new">404</a>',
                   '[[Unknown page#anchor]]' => '<a href="/projects/ecookbook/wiki/Unknown_page?parent=Another_page#anchor" class="wiki-page new">Unknown page</a>',
                   '[[Unknown page#anchor|404]]' => '<a href="/projects/ecookbook/wiki/Unknown_page?parent=Another_page#anchor" class="wiki-page new">404</a>',
                 }
                 @project = Project.find(1)
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(WikiContent.new( :text => text, :page => page ), :text) }
               end
               def test_wiki_links_anchor_option_should_prepend_page_title_to_href
                 to_test = {
                   # link to a page
                   '[[CookBook documentation]]' => '<a href="#CookBook_documentation" class="wiki-page">CookBook documentation</a>',
                   '[[CookBook documentation|documentation]]' => '<a href="#CookBook_documentation" class="wiki-page">documentation</a>',
                   '[[CookBook documentation#One-section]]' => '<a href="#CookBook_documentation_One-section" class="wiki-page">CookBook documentation</a>',
                   '[[CookBook documentation#One-section|documentation]]' => '<a href="#CookBook_documentation_One-section" class="wiki-page">documentation</a>',
                   # page that doesn't exist
                   '[[Unknown page]]' => '<a href="#Unknown_page" class="wiki-page new">Unknown page</a>',
                   '[[Unknown page|404]]' => '<a href="#Unknown_page" class="wiki-page new">404</a>',
                   '[[Unknown page#anchor]]' => '<a href="#Unknown_page_anchor" class="wiki-page new">Unknown page</a>',
                   '[[Unknown page#anchor|404]]' => '<a href="#Unknown_page_anchor" class="wiki-page new">404</a>',
                 }
                 @project = Project.find(1)
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text, :wiki_links => :anchor) }
               end
               def test_html_tags
                 to_test = {
                   "<div>content</div>" => "<p>&lt;div&gt;content&lt;/div&gt;</p>",
                   "<div class=\"bold\">content</div>" => "<p>&lt;div class=\"bold\"&gt;content&lt;/div&gt;</p>",
                   "<script>some script;</script>" => "<p>&lt;script&gt;some script;&lt;/script&gt;</p>",
                   # do not escape pre/code tags
                   "<pre>\nline 1\nline2</pre>" => "<pre>\nline 1\nline2</pre>",
                   "<pre><code>\nline 1\nline2</code></pre>" => "<pre><code>\nline 1\nline2</code></pre>",
                   "<pre><div>content</div></pre>" => "<pre>&lt;div&gt;content&lt;/div&gt;</pre>",
                   "HTML comment: <!-- no comments -->" => "<p>HTML comment: &lt;!-- no comments --&gt;</p>",
                   "<!-- opening comment" => "<p>&lt;!-- opening comment</p>",
                   # remove attributes except class
                   "<pre class='foo'>some text</pre>" => "<pre class='foo'>some text</pre>",
                   '<pre class="foo">some text</pre>' => '<pre class="foo">some text</pre>',
                   "<pre class='foo bar'>some text</pre>" => "<pre class='foo bar'>some text</pre>",
                   '<pre class="foo bar">some text</pre>' => '<pre class="foo bar">some text</pre>',
                   "<pre onmouseover='alert(1)'>some text</pre>" => "<pre>some text</pre>",
                   # xss
                   '<pre><code class=""onmouseover="alert(1)">text</code></pre>' => '<pre><code>text</code></pre>',
                   '<pre class=""onmouseover="alert(1)">text</pre>' => '<pre>text</pre>',
                 }
                 to_test.each { |text, result| assert_equal result, textilizable(text) }
               end
               def test_allowed_html_tags
                 to_test = {
                   "<pre>preformatted text</pre>" => "<pre>preformatted text</pre>",
                   "<notextile>no *textile* formatting</notextile>" => "no *textile* formatting",
                   "<notextile>this is <tag>a tag</tag></notextile>" => "this is &lt;tag&gt;a tag&lt;/tag&gt;"
                 }
                 to_test.each { |text, result| assert_equal result, textilizable(text) }
               end
               def test_pre_tags
                 raw = <<-RAW
             Before
             <pre>
             <prepared-statement-cache-size>32</prepared-statement-cache-size>
             </pre>
             After
             RAW
                 expected = <<-EXPECTED
             <p>Before</p>
             <pre>
             &lt;prepared-statement-cache-size&gt;32&lt;/prepared-statement-cache-size&gt;
             </pre>
             <p>After</p>
             EXPECTED
                 assert_equal expected.gsub(%r{[\r\n\t]}, ''), textilizable(raw).gsub(%r{[\r\n\t]}, '')
               end
               def test_pre_content_should_not_parse_wiki_and_redmine_links
                 raw = <<-RAW
             [[CookBook documentation]]
             #1
             <pre>
             [[CookBook documentation]]
             #1
             </pre>
             RAW
                 expected = <<-EXPECTED
             <p><a href="/projects/ecookbook/wiki/CookBook_documentation" class="wiki-page">CookBook documentation</a></p>
             <p><a href="/issues/1" class="issue status-1 priority-4 priority-lowest" title="Can&#x27;t print recipes (New)">#1</a></p>
             <pre>
             [[CookBook documentation]]
             #1
             </pre>
             EXPECTED
                 @project = Project.find(1)
                 assert_equal expected.gsub(%r{[\r\n\t]}, ''), textilizable(raw).gsub(%r{[\r\n\t]}, '')
               end
               def test_non_closing_pre_blocks_should_be_closed
                 raw = <<-RAW
             <pre><code>
             RAW
                 expected = <<-EXPECTED
             <pre><code>
             </code></pre>
             EXPECTED
                 @project = Project.find(1)
                 assert_equal expected.gsub(%r{[\r\n\t]}, ''), textilizable(raw).gsub(%r{[\r\n\t]}, '')
               end
               def test_syntax_highlight
                 raw = <<-RAW
             <pre><code class="ruby">
             # Some ruby code here
             </code></pre>
             RAW
                 expected = <<-EXPECTED
             <pre><code class="ruby syntaxhl"><span class=\"CodeRay\"><span class="comment"># Some ruby code here</span></span>
             </code></pre>
             EXPECTED
                 assert_equal expected.gsub(%r{[\r\n\t]}, ''), textilizable(raw).gsub(%r{[\r\n\t]}, '')
               end
               def test_to_path_param
                 assert_equal 'test1/test2', to_path_param('test1/test2')
                 assert_equal 'test1/test2', to_path_param('/test1/test2/')
                 assert_equal 'test1/test2', to_path_param('//test1/test2/')
                 assert_equal nil, to_path_param('/')
               end
               def test_wiki_links_in_tables
                 to_test = {"|[[Page|Link title]]|[[Other Page|Other title]]|\n|Cell 21|[[Last page]]|" =>
                              '<tr><td><a href="/projects/ecookbook/wiki/Page" class="wiki-page new">Link title</a></td>' +
                              '<td><a href="/projects/ecookbook/wiki/Other_Page" class="wiki-page new">Other title</a></td>' +
                              '</tr><tr><td>Cell 21</td><td><a href="/projects/ecookbook/wiki/Last_page" class="wiki-page new">Last page</a></td></tr>'
                 }
                 @project = Project.find(1)
                 to_test.each { |text, result| assert_equal "<table>#{result}</table>", textilizable(text).gsub(/[\t\n]/, '') }
               end
               def test_text_formatting
                 to_test = {'*_+bold, italic and underline+_*' => '<strong><em><ins>bold, italic and underline</ins></em></strong>',
                            '(_text within parentheses_)' => '(<em>text within parentheses</em>)',
                            'a *Humane Web* Text Generator' => 'a <strong>Humane Web</strong> Text Generator',
                            'a H *umane* W *eb* T *ext* G *enerator*' => 'a H <strong>umane</strong> W <strong>eb</strong> T <strong>ext</strong> G <strong>enerator</strong>',
                            'a *H* umane *W* eb *T* ext *G* enerator' => 'a <strong>H</strong> umane <strong>W</strong> eb <strong>T</strong> ext <strong>G</strong> enerator',
                           }
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text) }
               end
               def test_wiki_horizontal_rule
                 assert_equal '<hr />', textilizable('---')
                 assert_equal '<p>Dashes: ---</p>', textilizable('Dashes: ---')
               end
               def test_footnotes
                 raw = <<-RAW
             This is some text[1].
             fn1. This is the foot note
             RAW
                 expected = <<-EXPECTED
             <p>This is some text<sup><a href=\"#fn1\">1</a></sup>.</p>
             <p id="fn1" class="footnote"><sup>1</sup> This is the foot note</p>
             EXPECTED
                 assert_equal expected.gsub(%r{[\r\n\t]}, ''), textilizable(raw).gsub(%r{[\r\n\t]}, '')
               end
               def test_headings
                 raw = 'h1. Some heading'
                 expected = %|<a name="Some-heading"></a>\n<h1 >Some heading<a href="#Some-heading" class="wiki-anchor">&para;</a></h1>|
                 assert_equal expected, textilizable(raw)
               end
               def test_headings_with_special_chars
                 # This test makes sure that the generated anchor names match the expected
                 # ones even if the heading text contains unconventional characters
                 raw = 'h1. Some heading related to version 0.5'
                 anchor = sanitize_anchor_name("Some-heading-related-to-version-0.5")
                 expected = %|<a name="#{anchor}"></a>\n<h1 >Some heading related to version 0.5<a href="##{anchor}" class="wiki-anchor">&para;</a></h1>|
                 assert_equal expected, textilizable(raw)
               end
               def test_headings_in_wiki_single_page_export_should_be_prepended_with_page_title
                 page = WikiPage.new( :title => 'Page Title', :wiki_id => 1 )
                 content = WikiContent.new( :text => 'h1. Some heading', :page => page )
                 expected = %|<a name="Page_Title_Some-heading"></a>\n<h1 >Some heading<a href="#Page_Title_Some-heading" class="wiki-anchor">&para;</a></h1>|
                 assert_equal expected, textilizable(content, :text, :wiki_links => :anchor )
               end
               def test_table_of_content
                 raw = <<-RAW
             {{toc}}
             h1. Title
             Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Maecenas sed libero.
             h2. Subtitle with a [[Wiki]] link
             Nullam commodo metus accumsan nulla. Curabitur lobortis dui id dolor.
             h2. Subtitle with [[Wiki|another Wiki]] link
             h2. Subtitle with %{color:red}red text%
             <pre>
             some code
             </pre>
             h3. Subtitle with *some* _modifiers_
             h3. Subtitle with @inline code@
             h1. Another title
             h3. An "Internet link":http://www.redmine.org/ inside subtitle
             h2. "Project Name !/attachments/1234/logo_small.gif! !/attachments/5678/logo_2.png!":/projects/projectname/issues
             RAW
                 expected =  '<ul class="toc">' +
                               '<li><a href="#Title">Title</a>' +
                                 '<ul>' +
                                   '<li><a href="#Subtitle-with-a-Wiki-link">Subtitle with a Wiki link</a></li>' +
                                   '<li><a href="#Subtitle-with-another-Wiki-link">Subtitle with another Wiki link</a></li>' +
                                   '<li><a href="#Subtitle-with-red-text">Subtitle with red text</a>' +
                                     '<ul>' +
                                       '<li><a href="#Subtitle-with-some-modifiers">Subtitle with some modifiers</a></li>' +
                                       '<li><a href="#Subtitle-with-inline-code">Subtitle with inline code</a></li>' +
                                     '</ul>' +
                                   '</li>' +
                                 '</ul>' +
                               '</li>' +
                               '<li><a href="#Another-title">Another title</a>' +
                                 '<ul>' +
                                   '<li>' +
                                     '<ul>' +
                                       '<li><a href="#An-Internet-link-inside-subtitle">An Internet link inside subtitle</a></li>' +
                                     '</ul>' +
                                   '</li>' +
                                   '<li><a href="#Project-Name">Project Name</a></li>' +
                                 '</ul>' +
                               '</li>' +
                            '</ul>'
                 @project = Project.find(1)
                 assert textilizable(raw).gsub("\n", "").include?(expected)
               end
               def test_table_of_content_should_generate_unique_anchors
                 raw = <<-RAW
             {{toc}}
             h1. Title
             h2. Subtitle
             h2. Subtitle
             RAW
                 expected =  '<ul class="toc">' +
                               '<li><a href="#Title">Title</a>' +
                                 '<ul>' +
                                   '<li><a href="#Subtitle">Subtitle</a></li>' +
                                   '<li><a href="#Subtitle-2">Subtitle</a></li>'
                                 '</ul>'
                               '</li>' +
                            '</ul>'
                 @project = Project.find(1)
                 result = textilizable(raw).gsub("\n", "")
                 assert_include expected, result
                 assert_include '<a name="Subtitle">', result
                 assert_include '<a name="Subtitle-2">', result
               end
               def test_table_of_content_should_contain_included_page_headings
                 raw = <<-RAW
             {{toc}}
             h1. Included
             {{include(Child_1)}}
             RAW
                 expected = '<ul class="toc">' +
                            '<li><a href="#Included">Included</a></li>' +
                            '<li><a href="#Child-page-1">Child page 1</a></li>' +
                            '</ul>'
                 @project = Project.find(1)
                 assert textilizable(raw).gsub("\n", "").include?(expected)
               end
               def test_section_edit_links
                 raw = <<-RAW
             h1. Title
             Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Maecenas sed libero.
             h2. Subtitle with a [[Wiki]] link
             h2. Subtitle with *some* _modifiers_
             h2. Subtitle with @inline code@
             <pre>
             some code
             h2. heading inside pre
             <h2>html heading inside pre</h2>
             </pre>
             h2. Subtitle after pre tag
             RAW
                 @project = Project.find(1)
                 set_language_if_valid 'en'
                 result = textilizable(raw, :edit_section_links => {:controller => 'wiki', :action => 'edit', :project_id => '1', :id => 'Test'}).gsub("\n", "")
                 # heading that contains inline code
                 assert_match Regexp.new('<div class="contextual" title="Edit this section">' +
                   '<a href="/projects/1/wiki/Test/edit\?section=4"><img alt="Edit" src="/images/edit.png(\?\d+)?" /></a></div>' +
                   '<a name="Subtitle-with-inline-code"></a>' +
                   '<h2 >Subtitle with <code>inline code</code><a href="#Subtitle-with-inline-code" class="wiki-anchor">&para;</a></h2>'),
                   result
                 # last heading
                 assert_match Regexp.new('<div class="contextual" title="Edit this section">' +
                   '<a href="/projects/1/wiki/Test/edit\?section=5"><img alt="Edit" src="/images/edit.png(\?\d+)?" /></a></div>' +
                   '<a name="Subtitle-after-pre-tag"></a>' +
                   '<h2 >Subtitle after pre tag<a href="#Subtitle-after-pre-tag" class="wiki-anchor">&para;</a></h2>'),
                   result
               end
               def test_default_formatter
                 with_settings :text_formatting => 'unknown' do
                   text = 'a *link*: http://www.example.net/'
                   assert_equal '<p>a *link*: <a class="external" href="http://www.example.net/">http://www.example.net/</a></p>', textilizable(text)
                 end
               end
               def test_due_date_distance_in_words
                 to_test = { Date.today => 'Due in 0 days',
                             Date.today + 1 => 'Due in 1 day',
                             Date.today + 100 => 'Due in about 3 months',
                             Date.today + 20000 => 'Due in over 54 years',
                             Date.today - 1 => '1 day late',
                             Date.today - 100 => 'about 3 months late',
                             Date.today - 20000 => 'over 54 years late',
                            }
                 ::I18n.locale = :en
                 to_test.each do |date, expected|
                   assert_equal expected, due_date_distance_in_words(date)
                 end
               end
               def test_avatar_enabled
                 with_settings :gravatar_enabled => '1' do
                   assert avatar(User.find_by_mail('jsmith@somenet.foo')).include?(Digest::MD5.hexdigest('jsmith@somenet.foo'))
                   assert avatar('jsmith <jsmith@somenet.foo>').include?(Digest::MD5.hexdigest('jsmith@somenet.foo'))
                   # Default size is 50
                   assert avatar('jsmith <jsmith@somenet.foo>').include?('size=50')
                   assert avatar('jsmith <jsmith@somenet.foo>', :size => 24).include?('size=24')
                   # Non-avatar options should be considered html options
                   assert avatar('jsmith <jsmith@somenet.foo>', :title => 'John Smith').include?('title="John Smith"')
                   # The default class of the img tag should be gravatar
                   assert avatar('jsmith <jsmith@somenet.foo>').include?('class="gravatar"')
                   assert !avatar('jsmith <jsmith@somenet.foo>', :class => 'picture').include?('class="gravatar"')
                   assert_nil avatar('jsmith')
                   assert_nil avatar(nil)
                 end
               end
               def test_avatar_disabled
                 with_settings :gravatar_enabled => '0' do
                   assert_equal '', avatar(User.find_by_mail('jsmith@somenet.foo'))
                 end
               end
               def test_link_to_user
                 user = User.find(2)
                 assert_equal '<a href="/users/2" class="user active">John Smith</a>', link_to_user(user)
               end
               def test_link_to_user_should_not_link_to_locked_user
                 with_current_user nil do
                   user = User.find(5)
                   assert user.locked?
                   assert_equal 'Dave2 Lopper2', link_to_user(user)
                 end
               end
               def test_link_to_user_should_link_to_locked_user_if_current_user_is_admin
                 with_current_user User.find(1) do
                   user = User.find(5)
                   assert user.locked?
                   assert_equal '<a href="/users/5" class="user locked">Dave2 Lopper2</a>', link_to_user(user)
                 end
               end
               def test_link_to_user_should_not_link_to_anonymous
                 user = User.anonymous
                 assert user.anonymous?
                 t = link_to_user(user)
                 assert_equal ::I18n.t(:label_user_anonymous), t
               end
               def test_link_to_project
                 project = Project.find(1)
                 assert_equal %(<a href="/projects/ecookbook">eCookbook</a>),
                              link_to_project(project)
                 assert_equal %(<a href="/projects/ecookbook/settings">eCookbook</a>),
                              link_to_project(project, :action => 'settings')
                 assert_equal %(<a href="http://test.host/projects/ecookbook?jump=blah">eCookbook</a>),
                              link_to_project(project, {:only_path => false, :jump => 'blah'})
                 assert_equal %(<a href="/projects/ecookbook/settings" class="project">eCookbook</a>),
                              link_to_project(project, {:action => 'settings'}, :class => "project")
               end
               def test_link_to_legacy_project_with_numerical_identifier_should_use_id
                 # numeric identifier are no longer allowed
                 Project.update_all "identifier=25", "id=1"
                 assert_equal '<a href="/projects/1">eCookbook</a>',
                              link_to_project(Project.find(1))
               end
               def test_principals_options_for_select_with_users
                 User.current = nil
                 users = [User.find(2), User.find(4)]
                 assert_equal %(<option value="2">John Smith</option><option value="4">Robert Hill</option>),
                   principals_options_for_select(users)
               end
               def test_principals_options_for_select_with_selected
                 User.current = nil
                 users = [User.find(2), User.find(4)]
                 assert_equal %(<option value="2">John Smith</option><option value="4" selected="selected">Robert Hill</option>),
                   principals_options_for_select(users, User.find(4))
               end
               def test_principals_options_for_select_with_users_and_groups
                 User.current = nil
                 users = [User.find(2), Group.find(11), User.find(4), Group.find(10)]
                 assert_equal %(<option value="2">John Smith</option><option value="4">Robert Hill</option>) +
                   %(<optgroup label="Groups"><option value="10">A Team</option><option value="11">B Team</option></optgroup>),
                   principals_options_for_select(users)
               end
               def test_principals_options_for_select_with_empty_collection
                 assert_equal '', principals_options_for_select([])
               end
               def test_principals_options_for_select_should_include_me_option_when_current_user_is_in_collection
                 users = [User.find(2), User.find(4)]
                 User.current = User.find(4)
                 assert_include '<option value="4">&lt;&lt; me &gt;&gt;</option>', principals_options_for_select(users)
               end
               def test_stylesheet_link_tag_should_pick_the_default_stylesheet
                 assert_match 'href="/stylesheets/styles.css"', stylesheet_link_tag("styles")
               end
               def test_stylesheet_link_tag_for_plugin_should_pick_the_plugin_stylesheet
                 assert_match 'href="/plugin_assets/foo/stylesheets/styles.css"', stylesheet_link_tag("styles", :plugin => :foo)
               end
               def test_image_tag_should_pick_the_default_image
                 assert_match 'src="/images/image.png"', image_tag("image.png")
               end
               def test_image_tag_should_pick_the_theme_image_if_it_exists
                 theme = Redmine::Themes.themes.last
                 theme.images << 'image.png'
                 with_settings :ui_theme => theme.id do
                   assert_match %|src="/themes/#{theme.dir}/images/image.png"|, image_tag("image.png")
                   assert_match %|src="/images/other.png"|, image_tag("other.png")
                 end
               ensure
                 theme.images.delete 'image.png'
               end
               def test_image_tag_sfor_plugin_should_pick_the_plugin_image
                 assert_match 'src="/plugin_assets/foo/images/image.png"', image_tag("image.png", :plugin => :foo)
               end
               def test_javascript_include_tag_should_pick_the_default_javascript
                 assert_match 'src="/javascripts/scripts.js"', javascript_include_tag("scripts")
               end
               def test_javascript_include_tag_for_plugin_should_pick_the_plugin_javascript
                 assert_match 'src="/plugin_assets/foo/javascripts/scripts.js"', javascript_include_tag("scripts", :plugin => :foo)
               end
               def test_per_page_links_should_show_usefull_values
                 set_language_if_valid 'en'
                 stubs(:link_to).returns("[link]")
                 with_settings :per_page_options => '10, 25, 50, 100' do
                   assert_nil per_page_links(10, 3)
                   assert_nil per_page_links(25, 3)
                   assert_equal "Per page: 10, [link]", per_page_links(10, 22)
                   assert_equal "Per page: [link], 25", per_page_links(25, 22)
                   assert_equal "Per page: [link], [link], 50", per_page_links(50, 22)
                   assert_equal "Per page: [link], 25, [link]", per_page_links(25, 26)
                   assert_equal "Per page: [link], 25, [link], [link]", per_page_links(25, 120)
                 end
               end
             end

test/unit/issue_nested_set_test.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class IssueNestedSetTest < ActiveSupport::TestCase
               fixtures :projects, :users, :members, :member_roles, :roles,
                        :trackers, :projects_trackers,
                        :versions,
                        :issue_statuses, :issue_categories, :issue_relations, :workflows,
                        :enumerations,
                        :issues,
                        :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
                        :time_entries
               def test_create_root_issue
                 issue1 = Issue.generate!
                 issue2 = Issue.generate!
                 issue1.reload
                 issue2.reload
                 assert_equal [issue1.id, nil, 1, 2], [issue1.root_id, issue1.parent_id, issue1.lft, issue1.rgt]
                 assert_equal [issue2.id, nil, 1, 2], [issue2.root_id, issue2.parent_id, issue2.lft, issue2.rgt]
               end
               def test_create_child_issue
                 parent = Issue.generate!
                 child =  Issue.generate!(:parent_issue_id => parent.id)
                 parent.reload
                 child.reload
                 assert_equal [parent.id, nil, 1, 4], [parent.root_id, parent.parent_id, parent.lft, parent.rgt]
                 assert_equal [parent.id, parent.id, 2, 3], [child.root_id, child.parent_id, child.lft, child.rgt]
               end
               def test_creating_a_child_in_a_subproject_should_validate
                 issue = Issue.generate!
                 child = Issue.new(:project_id => 3, :tracker_id => 2, :author_id => 1,
                                   :subject => 'child', :parent_issue_id => issue.id)
                 assert_save child
                 assert_equal issue, child.reload.parent
               end
               def test_creating_a_child_in_an_invalid_project_should_not_validate
                 issue = Issue.generate!
                 child = Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
                                   :subject => 'child', :parent_issue_id => issue.id)
                 assert !child.save
                 assert_not_nil child.errors[:parent_issue_id]
               end
               def test_move_a_root_to_child
                 parent1 = Issue.generate!
                 parent2 = Issue.generate!
                 child = Issue.generate!(:parent_issue_id => parent1.id)
                 parent2.parent_issue_id = parent1.id
                 parent2.save!
                 child.reload
                 parent1.reload
                 parent2.reload
                 assert_equal [parent1.id, 1, 6], [parent1.root_id, parent1.lft, parent1.rgt]
                 assert_equal [parent1.id, 4, 5], [parent2.root_id, parent2.lft, parent2.rgt]
                 assert_equal [parent1.id, 2, 3], [child.root_id, child.lft, child.rgt]
               end
               def test_move_a_child_to_root
                 parent1 = Issue.generate!
                 parent2 = Issue.generate!
                 child =   Issue.generate!(:parent_issue_id => parent1.id)
                 child.parent_issue_id = nil
                 child.save!
                 child.reload
                 parent1.reload
                 parent2.reload
                 assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
                 assert_equal [parent2.id, 1, 2], [parent2.root_id, parent2.lft, parent2.rgt]
                 assert_equal [child.id, 1, 2], [child.root_id, child.lft, child.rgt]
               end
               def test_move_a_child_to_another_issue
                 parent1 = Issue.generate!
                 parent2 = Issue.generate!
                 child =   Issue.generate!(:parent_issue_id => parent1.id)
                 child.parent_issue_id = parent2.id
                 child.save!
                 child.reload
                 parent1.reload
                 parent2.reload
                 assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
                 assert_equal [parent2.id, 1, 4], [parent2.root_id, parent2.lft, parent2.rgt]
                 assert_equal [parent2.id, 2, 3], [child.root_id, child.lft, child.rgt]
               end
               def test_move_a_child_with_descendants_to_another_issue
                 parent1 = Issue.generate!
                 parent2 = Issue.generate!
                 child =   Issue.generate!(:parent_issue_id => parent1.id)
                 grandchild = Issue.generate!(:parent_issue_id => child.id)
                 parent1.reload
                 parent2.reload
                 child.reload
                 grandchild.reload
                 assert_equal [parent1.id, 1, 6], [parent1.root_id, parent1.lft, parent1.rgt]
                 assert_equal [parent2.id, 1, 2], [parent2.root_id, parent2.lft, parent2.rgt]
                 assert_equal [parent1.id, 2, 5], [child.root_id, child.lft, child.rgt]
                 assert_equal [parent1.id, 3, 4], [grandchild.root_id, grandchild.lft, grandchild.rgt]
                 child.reload.parent_issue_id = parent2.id
                 child.save!
                 child.reload
                 grandchild.reload
                 parent1.reload
                 parent2.reload
                 assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
                 assert_equal [parent2.id, 1, 6], [parent2.root_id, parent2.lft, parent2.rgt]
                 assert_equal [parent2.id, 2, 5], [child.root_id, child.lft, child.rgt]
                 assert_equal [parent2.id, 3, 4], [grandchild.root_id, grandchild.lft, grandchild.rgt]
               end
               def test_move_a_child_with_descendants_to_another_project
                 parent1 = Issue.generate!
                 child =   Issue.generate!(:parent_issue_id => parent1.id)
                 grandchild = Issue.generate!(:parent_issue_id => child.id)
                 child.reload
                 child.project = Project.find(2)
                 assert child.save
                 child.reload
                 grandchild.reload
                 parent1.reload
                 assert_equal [1, parent1.id, 1, 2], [parent1.project_id, parent1.root_id, parent1.lft, parent1.rgt]
                 assert_equal [2, child.id, 1, 4], [child.project_id, child.root_id, child.lft, child.rgt]
                 assert_equal [2, child.id, 2, 3], [grandchild.project_id, grandchild.root_id, grandchild.lft, grandchild.rgt]
               end
               def test_moving_an_issue_to_a_descendant_should_not_validate
                 parent1 = Issue.generate!
                 parent2 = Issue.generate!
                 child =   Issue.generate!(:parent_issue_id => parent1.id)
                 grandchild = Issue.generate!(:parent_issue_id => child.id)
                 child.reload
                 child.parent_issue_id = grandchild.id
                 assert !child.save
                 assert_not_nil child.errors[:parent_issue_id]
               end
               def test_moving_an_issue_should_keep_valid_relations_only
                 issue1 = Issue.generate!
                 issue2 = Issue.generate!
                 issue3 = Issue.generate!(:parent_issue_id => issue2.id)
                 issue4 = Issue.generate!
                 r1 = IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
                 r2 = IssueRelation.create!(:issue_from => issue1, :issue_to => issue3, :relation_type => IssueRelation::TYPE_PRECEDES)
                 r3 = IssueRelation.create!(:issue_from => issue2, :issue_to => issue4, :relation_type => IssueRelation::TYPE_PRECEDES)
                 issue2.reload
                 issue2.parent_issue_id = issue1.id
                 issue2.save!
                 assert !IssueRelation.exists?(r1.id)
                 assert !IssueRelation.exists?(r2.id)
                 assert IssueRelation.exists?(r3.id)
               end
               def test_destroy_should_destroy_children
                 issue1 = Issue.generate!
                 issue2 = Issue.generate!
                 issue3 = Issue.generate!(:parent_issue_id => issue2.id)
                 issue4 = Issue.generate!(:parent_issue_id => issue1.id)
                 issue3.init_journal(User.find(2))
                 issue3.subject = 'child with journal'
                 issue3.save!
                 assert_difference 'Issue.count', -2 do
                   assert_difference 'Journal.count', -1 do
                     assert_difference 'JournalDetail.count', -1 do
                       Issue.find(issue2.id).destroy
                     end
                   end
                 end
                 issue1.reload
                 issue4.reload
                 assert !Issue.exists?(issue2.id)
                 assert !Issue.exists?(issue3.id)
                 assert_equal [issue1.id, 1, 4], [issue1.root_id, issue1.lft, issue1.rgt]
                 assert_equal [issue1.id, 2, 3], [issue4.root_id, issue4.lft, issue4.rgt]
               end
               def test_destroy_child_should_update_parent
                 issue = Issue.generate!
                 child1 = Issue.generate!(:parent_issue_id => issue.id)
                 child2 = Issue.generate!(:parent_issue_id => issue.id)
                 issue.reload
                 assert_equal [issue.id, 1, 6], [issue.root_id, issue.lft, issue.rgt]
                 child2.reload.destroy
                 issue.reload
                 assert_equal [issue.id, 1, 4], [issue.root_id, issue.lft, issue.rgt]
               end
               def test_destroy_parent_issue_updated_during_children_destroy
                 parent = Issue.generate!
                 Issue.generate!(:start_date => Date.today, :parent_issue_id => parent.id)
                 Issue.generate!(:start_date => 2.days.from_now, :parent_issue_id => parent.id)
                 assert_difference 'Issue.count', -3 do
                   Issue.find(parent.id).destroy
                 end
               end
               def test_destroy_child_issue_with_children
                 root = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'root')
                 child = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => root.id)
                 leaf = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'leaf', :parent_issue_id => child.id)
                 leaf.init_journal(User.find(2))
                 leaf.subject = 'leaf with journal'
                 leaf.save!
                 assert_difference 'Issue.count', -2 do
                   assert_difference 'Journal.count', -1 do
                     assert_difference 'JournalDetail.count', -1 do
                       Issue.find(child.id).destroy
                     end
                   end
                 end
                 root = Issue.find(root.id)
                 assert root.leaf?, "Root issue is not a leaf (lft: #{root.lft}, rgt: #{root.rgt})"
               end
               def test_destroy_issue_with_grand_child
                 parent = Issue.generate!
                 issue = Issue.generate!(:parent_issue_id => parent.id)
                 child = Issue.generate!(:parent_issue_id => issue.id)
                 grandchild1 = Issue.generate!(:parent_issue_id => child.id)
                 grandchild2 = Issue.generate!(:parent_issue_id => child.id)
                 assert_difference 'Issue.count', -4 do
                   Issue.find(issue.id).destroy
                   parent.reload
                   assert_equal [1, 2], [parent.lft, parent.rgt]
                 end
               end
               def test_parent_priority_should_be_the_highest_child_priority
                 parent = Issue.generate!(:priority => IssuePriority.find_by_name('Normal'))
                 # Create children
                 child1 = Issue.generate!(:priority => IssuePriority.find_by_name('High'), :parent_issue_id => parent.id)
                 assert_equal 'High', parent.reload.priority.name
                 child2 = Issue.generate!(:priority => IssuePriority.find_by_name('Immediate'), :parent_issue_id => child1.id)
                 assert_equal 'Immediate', child1.reload.priority.name
                 assert_equal 'Immediate', parent.reload.priority.name
                 child3 = Issue.generate!(:priority => IssuePriority.find_by_name('Low'), :parent_issue_id => parent.id)
                 assert_equal 'Immediate', parent.reload.priority.name
                 # Destroy a child
                 child1.destroy
                 assert_equal 'Low', parent.reload.priority.name
                 # Update a child
                 child3.reload.priority = IssuePriority.find_by_name('Normal')
                 child3.save!
                 assert_equal 'Normal', parent.reload.priority.name
               end
               def test_parent_dates_should_be_lowest_start_and_highest_due_dates
                 parent = Issue.generate!
                 Issue.generate!(:start_date => '2010-01-25', :due_date => '2010-02-15', :parent_issue_id => parent.id)
                 Issue.generate!(                             :due_date => '2010-02-13', :parent_issue_id => parent.id)
                 Issue.generate!(:start_date => '2010-02-01', :due_date => '2010-02-22', :parent_issue_id => parent.id)
                 parent.reload
                 assert_equal Date.parse('2010-01-25'), parent.start_date
                 assert_equal Date.parse('2010-02-22'), parent.due_date
               end
               def test_parent_done_ratio_should_be_average_done_ratio_of_leaves
                 parent = Issue.generate!
                 Issue.generate!(:done_ratio => 20, :parent_issue_id => parent.id)
                 assert_equal 20, parent.reload.done_ratio
                 Issue.generate!(:done_ratio => 70, :parent_issue_id => parent.id)
                 assert_equal 45, parent.reload.done_ratio
                 child = Issue.generate!(:done_ratio => 0, :parent_issue_id => parent.id)
                 assert_equal 30, parent.reload.done_ratio
                 Issue.generate!(:done_ratio => 30, :parent_issue_id => child.id)
                 assert_equal 30, child.reload.done_ratio
                 assert_equal 40, parent.reload.done_ratio
               end
               def test_parent_done_ratio_should_be_weighted_by_estimated_times_if_any
                 parent = Issue.generate!
                 Issue.generate!(:estimated_hours => 10, :done_ratio => 20, :parent_issue_id => parent.id)
                 assert_equal 20, parent.reload.done_ratio
                 Issue.generate!(:estimated_hours => 20, :done_ratio => 50, :parent_issue_id => parent.id)
                 assert_equal (50 * 20 + 20 * 10) / 30, parent.reload.done_ratio
               end
               def test_parent_estimate_should_be_sum_of_leaves
                 parent = Issue.generate!
                 Issue.generate!(:estimated_hours => nil, :parent_issue_id => parent.id)
                 assert_equal nil, parent.reload.estimated_hours
                 Issue.generate!(:estimated_hours => 5, :parent_issue_id => parent.id)
                 assert_equal 5, parent.reload.estimated_hours
                 Issue.generate!(:estimated_hours => 7, :parent_issue_id => parent.id)
                 assert_equal 12, parent.reload.estimated_hours
               end
               def test_move_parent_updates_old_parent_attributes
                 first_parent = Issue.generate!
                 second_parent = Issue.generate!
                 child = Issue.generate!(:estimated_hours => 5, :parent_issue_id => first_parent.id)
                 assert_equal 5, first_parent.reload.estimated_hours
                 child.update_attributes(:estimated_hours => 7, :parent_issue_id => second_parent.id)
                 assert_equal 7, second_parent.reload.estimated_hours
                 assert_nil first_parent.reload.estimated_hours
               end
               def test_reschuling_a_parent_should_reschedule_subtasks
                 parent = Issue.generate!
                 c1 = Issue.generate!(:start_date => '2010-05-12', :due_date => '2010-05-18', :parent_issue_id => parent.id)
                 c2 = Issue.generate!(:start_date => '2010-06-03', :due_date => '2010-06-10', :parent_issue_id => parent.id)
                 parent.reload
                 parent.reschedule_on!(Date.parse('2010-06-02'))
                 c1.reload
                 assert_equal [Date.parse('2010-06-02'), Date.parse('2010-06-08')], [c1.start_date, c1.due_date]
                 c2.reload
                 assert_equal [Date.parse('2010-06-03'), Date.parse('2010-06-10')], [c2.start_date, c2.due_date] # no change
                 parent.reload
                 assert_equal [Date.parse('2010-06-02'), Date.parse('2010-06-10')], [parent.start_date, parent.due_date]
               end
               def test_project_copy_should_copy_issue_tree
                 p = Project.create!(:name => 'Tree copy', :identifier => 'tree-copy', :tracker_ids => [1, 2])
                 i1 = Issue.generate!(:project => p, :subject => 'i1')
                 i2 = Issue.generate!(:project => p, :subject => 'i2', :parent_issue_id => i1.id)
                 i3 = Issue.generate!(:project => p, :subject => 'i3', :parent_issue_id => i1.id)
                 i4 = Issue.generate!(:project => p, :subject => 'i4', :parent_issue_id => i2.id)
                 i5 = Issue.generate!(:project => p, :subject => 'i5')
                 c = Project.new(:name => 'Copy', :identifier => 'copy', :tracker_ids => [1, 2])
                 c.copy(p, :only => 'issues')
                 c.reload
                 assert_equal 5, c.issues.count
-                ic1, ic2, ic3, ic4, ic5 = c.issues.find(:all, :order => 'subject')
+                ic1, ic2, ic3, ic4, ic5 = c.issues.order('subject').all
                 assert ic1.root?
                 assert_equal ic1, ic2.parent
                 assert_equal ic1, ic3.parent
                 assert_equal ic2, ic4.parent
                 assert ic5.root?
               end
             end

test/unit/project_test.rb +2 -2

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class ProjectTest < ActiveSupport::TestCase
               fixtures :projects, :trackers, :issue_statuses, :issues,
                        :journals, :journal_details,
                        :enumerations, :users, :issue_categories,
                        :projects_trackers,
                        :custom_fields,
                        :custom_fields_projects,
                        :custom_fields_trackers,
                        :custom_values,
                        :roles,
                        :member_roles,
                        :members,
                        :enabled_modules,
                        :workflows,
                        :versions,
                        :wikis, :wiki_pages, :wiki_contents, :wiki_content_versions,
                        :groups_users,
                        :boards, :messages,
                        :repositories,
                        :news, :comments,
                        :documents
               def setup
                 @ecookbook = Project.find(1)
                 @ecookbook_sub1 = Project.find(3)
                 set_tmp_attachments_directory
                 User.current = nil
               end
               def test_truth
                 assert_kind_of Project, @ecookbook
                 assert_equal "eCookbook", @ecookbook.name
               end
               def test_default_attributes
                 with_settings :default_projects_public => '1' do
                   assert_equal true, Project.new.is_public
                   assert_equal false, Project.new(:is_public => false).is_public
                 end
                 with_settings :default_projects_public => '0' do
                   assert_equal false, Project.new.is_public
                   assert_equal true, Project.new(:is_public => true).is_public
                 end
                 with_settings :sequential_project_identifiers => '1' do
                   assert !Project.new.identifier.blank?
                   assert Project.new(:identifier => '').identifier.blank?
                 end
                 with_settings :sequential_project_identifiers => '0' do
                   assert Project.new.identifier.blank?
                   assert !Project.new(:identifier => 'test').blank?
                 end
                 with_settings :default_projects_modules => ['issue_tracking', 'repository'] do
                   assert_equal ['issue_tracking', 'repository'], Project.new.enabled_module_names
                 end
                 assert_equal Tracker.all.sort, Project.new.trackers.sort
                 assert_equal Tracker.find(1, 3).sort, Project.new(:tracker_ids => [1, 3]).trackers.sort
               end
               def test_update
                 assert_equal "eCookbook", @ecookbook.name
                 @ecookbook.name = "eCook"
                 assert @ecookbook.save, @ecookbook.errors.full_messages.join("; ")
                 @ecookbook.reload
                 assert_equal "eCook", @ecookbook.name
               end
               def test_validate_identifier
                 to_test = {"abc" => true,
                            "ab12" => true,
                            "ab-12" => true,
                            "ab_12" => true,
                            "12" => false,
                            "new" => false}
                 to_test.each do |identifier, valid|
                   p = Project.new
                   p.identifier = identifier
                   p.valid?
                   if valid
                     assert p.errors['identifier'].blank?, "identifier #{identifier} was not valid"
                   else
                     assert p.errors['identifier'].present?, "identifier #{identifier} was valid"
                   end
                 end
               end
               def test_identifier_should_not_be_frozen_for_a_new_project
                 assert_equal false, Project.new.identifier_frozen?
               end
               def test_identifier_should_not_be_frozen_for_a_saved_project_with_blank_identifier
                 Project.update_all(["identifier = ''"], "id = 1")
                 assert_equal false, Project.find(1).identifier_frozen?
               end
               def test_identifier_should_be_frozen_for_a_saved_project_with_valid_identifier
                 assert_equal true, Project.find(1).identifier_frozen?
               end
               def test_members_should_be_active_users
                 Project.all.each do |project|
                   assert_nil project.members.detect {|m| !(m.user.is_a?(User) && m.user.active?) }
                 end
               end
               def test_users_should_be_active_users
                 Project.all.each do |project|
                   assert_nil project.users.detect {|u| !(u.is_a?(User) && u.active?) }
                 end
               end
               def test_open_scope_on_issues_association
                 assert_kind_of Issue, Project.find(1).issues.open.first
               end
               def test_archive
                 user = @ecookbook.members.first.user
                 @ecookbook.archive
                 @ecookbook.reload
                 assert !@ecookbook.active?
                 assert @ecookbook.archived?
                 assert !user.projects.include?(@ecookbook)
                 # Subproject are also archived
                 assert !@ecookbook.children.empty?
                 assert @ecookbook.descendants.active.empty?
               end
               def test_archive_should_fail_if_versions_are_used_by_non_descendant_projects
                 # Assign an issue of a project to a version of a child project
                 Issue.find(4).update_attribute :fixed_version_id, 4
                 assert_no_difference "Project.count(:all, :conditions => 'status = #{Project::STATUS_ARCHIVED}')" do
                   assert_equal false, @ecookbook.archive
                 end
                 @ecookbook.reload
                 assert @ecookbook.active?
               end
               def test_unarchive
                 user = @ecookbook.members.first.user
                 @ecookbook.archive
                 # A subproject of an archived project can not be unarchived
                 assert !@ecookbook_sub1.unarchive
                 # Unarchive project
                 assert @ecookbook.unarchive
                 @ecookbook.reload
                 assert @ecookbook.active?
                 assert !@ecookbook.archived?
                 assert user.projects.include?(@ecookbook)
                 # Subproject can now be unarchived
                 @ecookbook_sub1.reload
                 assert @ecookbook_sub1.unarchive
               end
               def test_destroy
                 # 2 active members
                 assert_equal 2, @ecookbook.members.size
                 # and 1 is locked
-                assert_equal 3, Member.find(:all, :conditions => ['project_id = ?', @ecookbook.id]).size
+                assert_equal 3, Member.where('project_id = ?', @ecookbook.id).all.size
                 # some boards
                 assert @ecookbook.boards.any?
                 @ecookbook.destroy
                 # make sure that the project non longer exists
                 assert_raise(ActiveRecord::RecordNotFound) { Project.find(@ecookbook.id) }
                 # make sure related data was removed
                 assert_nil Member.first(:conditions => {:project_id => @ecookbook.id})
                 assert_nil Board.first(:conditions => {:project_id => @ecookbook.id})
                 assert_nil Issue.first(:conditions => {:project_id => @ecookbook.id})
               end
               def test_destroy_should_destroy_subtasks
                 issues = (0..2).to_a.map {Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :subject => 'test')}
                 issues[0].update_attribute :parent_issue_id, issues[1].id
                 issues[2].update_attribute :parent_issue_id, issues[1].id
                 assert_equal 2, issues[1].children.count
                 assert_nothing_raised do
                   Project.find(1).destroy
                 end
                 assert Issue.find_all_by_id(issues.map(&:id)).empty?
               end
               def test_destroying_root_projects_should_clear_data
                 Project.roots.each do |root|
                   root.destroy
                 end
                 assert_equal 0, Project.count, "Projects were not deleted: #{Project.all.inspect}"
                 assert_equal 0, Member.count, "Members were not deleted: #{Member.all.inspect}"
                 assert_equal 0, MemberRole.count
                 assert_equal 0, Issue.count
                 assert_equal 0, Journal.count
                 assert_equal 0, JournalDetail.count
                 assert_equal 0, Attachment.count, "Attachments were not deleted: #{Attachment.all.inspect}"
                 assert_equal 0, EnabledModule.count
                 assert_equal 0, IssueCategory.count
                 assert_equal 0, IssueRelation.count
                 assert_equal 0, Board.count
                 assert_equal 0, Message.count
                 assert_equal 0, News.count
                 assert_equal 0, Query.count(:conditions => "project_id IS NOT NULL")
                 assert_equal 0, Repository.count
                 assert_equal 0, Changeset.count
                 assert_equal 0, Change.count
                 assert_equal 0, Comment.count
                 assert_equal 0, TimeEntry.count
                 assert_equal 0, Version.count
                 assert_equal 0, Watcher.count
                 assert_equal 0, Wiki.count
                 assert_equal 0, WikiPage.count
                 assert_equal 0, WikiContent.count
                 assert_equal 0, WikiContent::Version.count
                 assert_equal 0, Project.connection.select_all("SELECT * FROM projects_trackers").size
                 assert_equal 0, Project.connection.select_all("SELECT * FROM custom_fields_projects").size
                 assert_equal 0, CustomValue.count(:conditions => {:customized_type => ['Project', 'Issue', 'TimeEntry', 'Version']})
               end
               def test_move_an_orphan_project_to_a_root_project
                 sub = Project.find(2)
                 sub.set_parent! @ecookbook
                 assert_equal @ecookbook.id, sub.parent.id
                 @ecookbook.reload
                 assert_equal 4, @ecookbook.children.size
               end
               def test_move_an_orphan_project_to_a_subproject
                 sub = Project.find(2)
                 assert sub.set_parent!(@ecookbook_sub1)
               end
               def test_move_a_root_project_to_a_project
                 sub = @ecookbook
                 assert sub.set_parent!(Project.find(2))
               end
               def test_should_not_move_a_project_to_its_children
                 sub = @ecookbook
                 assert !(sub.set_parent!(Project.find(3)))
               end
               def test_set_parent_should_add_roots_in_alphabetical_order
                 ProjectCustomField.delete_all
                 Project.delete_all
                 Project.create!(:name => 'Project C', :identifier => 'project-c').set_parent!(nil)
                 Project.create!(:name => 'Project B', :identifier => 'project-b').set_parent!(nil)
                 Project.create!(:name => 'Project D', :identifier => 'project-d').set_parent!(nil)
                 Project.create!(:name => 'Project A', :identifier => 'project-a').set_parent!(nil)
                 assert_equal 4, Project.count
                 assert_equal Project.all.sort_by(&:name), Project.all.sort_by(&:lft)
               end
               def test_set_parent_should_add_children_in_alphabetical_order
                 ProjectCustomField.delete_all
                 parent = Project.create!(:name => 'Parent', :identifier => 'parent')
                 Project.create!(:name => 'Project C', :identifier => 'project-c').set_parent!(parent)
                 Project.create!(:name => 'Project B', :identifier => 'project-b').set_parent!(parent)
                 Project.create!(:name => 'Project D', :identifier => 'project-d').set_parent!(parent)
                 Project.create!(:name => 'Project A', :identifier => 'project-a').set_parent!(parent)
                 parent.reload
                 assert_equal 4, parent.children.size
                 assert_equal parent.children.all.sort_by(&:name), parent.children.all
               end
               def test_set_parent_should_update_issue_fixed_version_associations_when_a_fixed_version_is_moved_out_of_the_hierarchy
                 # Parent issue with a hierarchy project's fixed version
                 parent_issue = Issue.find(1)
                 parent_issue.update_attribute(:fixed_version_id, 4)
                 parent_issue.reload
                 assert_equal 4, parent_issue.fixed_version_id
                 # Should keep fixed versions for the issues
                 issue_with_local_fixed_version = Issue.find(5)
                 issue_with_local_fixed_version.update_attribute(:fixed_version_id, 4)
                 issue_with_local_fixed_version.reload
                 assert_equal 4, issue_with_local_fixed_version.fixed_version_id
                 # Local issue with hierarchy fixed_version
                 issue_with_hierarchy_fixed_version = Issue.find(13)
                 issue_with_hierarchy_fixed_version.update_attribute(:fixed_version_id, 6)
                 issue_with_hierarchy_fixed_version.reload
                 assert_equal 6, issue_with_hierarchy_fixed_version.fixed_version_id
                 # Move project out of the issue's hierarchy
                 moved_project = Project.find(3)
                 moved_project.set_parent!(Project.find(2))
                 parent_issue.reload
                 issue_with_local_fixed_version.reload
                 issue_with_hierarchy_fixed_version.reload
                 assert_equal 4, issue_with_local_fixed_version.fixed_version_id, "Fixed version was not keep on an issue local to the moved project"
                 assert_equal nil, issue_with_hierarchy_fixed_version.fixed_version_id, "Fixed version is still set after moving the Project out of the hierarchy where the version is defined in"
                 assert_equal nil, parent_issue.fixed_version_id, "Fixed version is still set after moving the Version out of the hierarchy for the issue."
               end
               def test_parent
                 p = Project.find(6).parent
                 assert p.is_a?(Project)
                 assert_equal 5, p.id
               end
               def test_ancestors
                 a = Project.find(6).ancestors
                 assert a.first.is_a?(Project)
                 assert_equal [1, 5], a.collect(&:id)
               end
               def test_root
                 r = Project.find(6).root
                 assert r.is_a?(Project)
                 assert_equal 1, r.id
               end
               def test_children
                 c = Project.find(1).children
                 assert c.first.is_a?(Project)
                 assert_equal [5, 3, 4], c.collect(&:id)
               end
               def test_descendants
                 d = Project.find(1).descendants
                 assert d.first.is_a?(Project)
                 assert_equal [5, 6, 3, 4], d.collect(&:id)
               end
               def test_allowed_parents_should_be_empty_for_non_member_user
                 Role.non_member.add_permission!(:add_project)
                 user = User.find(9)
                 assert user.memberships.empty?
                 User.current = user
                 assert Project.new.allowed_parents.compact.empty?
               end
               def test_allowed_parents_with_add_subprojects_permission
                 Role.find(1).remove_permission!(:add_project)
                 Role.find(1).add_permission!(:add_subprojects)
                 User.current = User.find(2)
                 # new project
                 assert !Project.new.allowed_parents.include?(nil)
                 assert Project.new.allowed_parents.include?(Project.find(1))
                 # existing root project
                 assert Project.find(1).allowed_parents.include?(nil)
                 # existing child
                 assert Project.find(3).allowed_parents.include?(Project.find(1))
                 assert !Project.find(3).allowed_parents.include?(nil)
               end
               def test_allowed_parents_with_add_project_permission
                 Role.find(1).add_permission!(:add_project)
                 Role.find(1).remove_permission!(:add_subprojects)
                 User.current = User.find(2)
                 # new project
                 assert Project.new.allowed_parents.include?(nil)
                 assert !Project.new.allowed_parents.include?(Project.find(1))
                 # existing root project
                 assert Project.find(1).allowed_parents.include?(nil)
                 # existing child
                 assert Project.find(3).allowed_parents.include?(Project.find(1))
                 assert Project.find(3).allowed_parents.include?(nil)
               end
               def test_allowed_parents_with_add_project_and_subprojects_permission
                 Role.find(1).add_permission!(:add_project)
                 Role.find(1).add_permission!(:add_subprojects)
                 User.current = User.find(2)
                 # new project
                 assert Project.new.allowed_parents.include?(nil)
                 assert Project.new.allowed_parents.include?(Project.find(1))
                 # existing root project
                 assert Project.find(1).allowed_parents.include?(nil)
                 # existing child
                 assert Project.find(3).allowed_parents.include?(Project.find(1))
                 assert Project.find(3).allowed_parents.include?(nil)
               end
               def test_users_by_role
                 users_by_role = Project.find(1).users_by_role
                 assert_kind_of Hash, users_by_role
                 role = Role.find(1)
                 assert_kind_of Array, users_by_role[role]
                 assert users_by_role[role].include?(User.find(2))
               end
               def test_rolled_up_trackers
                 parent = Project.find(1)
                 parent.trackers = Tracker.find([1,2])
                 child = parent.children.find(3)
                 assert_equal [1, 2], parent.tracker_ids
                 assert_equal [2, 3], child.trackers.collect(&:id)
                 assert_kind_of Tracker, parent.rolled_up_trackers.first
                 assert_equal Tracker.find(1), parent.rolled_up_trackers.first
                 assert_equal [1, 2, 3], parent.rolled_up_trackers.collect(&:id)
                 assert_equal [2, 3], child.rolled_up_trackers.collect(&:id)
               end
               def test_rolled_up_trackers_should_ignore_archived_subprojects
                 parent = Project.find(1)
                 parent.trackers = Tracker.find([1,2])
                 child = parent.children.find(3)
                 child.trackers = Tracker.find([1,3])
                 parent.children.each(&:archive)
                 assert_equal [1,2], parent.rolled_up_trackers.collect(&:id)
               end
               context "#rolled_up_versions" do
                 setup do
                   @project = Project.generate!
                   @parent_version_1 = Version.generate!(:project => @project)
                   @parent_version_2 = Version.generate!(:project => @project)
                 end
                 should "include the versions for the current project" do
                   assert_same_elements [@parent_version_1, @parent_version_2], @project.rolled_up_versions
                 end
                 should "include versions for a subproject" do
                   @subproject = Project.generate!
                   @subproject.set_parent!(@project)
                   @subproject_version = Version.generate!(:project => @subproject)
                   assert_same_elements [
                                         @parent_version_1,
                                         @parent_version_2,
                                         @subproject_version
                                        ], @project.rolled_up_versions
                 end
                 should "include versions for a sub-subproject" do
                   @subproject = Project.generate!
                   @subproject.set_parent!(@project)
                   @sub_subproject = Project.generate!
                   @sub_subproject.set_parent!(@subproject)
                   @sub_subproject_version = Version.generate!(:project => @sub_subproject)
                   @project.reload
                   assert_same_elements [
                                         @parent_version_1,
                                         @parent_version_2,
                                         @sub_subproject_version
                                        ], @project.rolled_up_versions
                 end
                 should "only check active projects" do
                   @subproject = Project.generate!
                   @subproject.set_parent!(@project)
                   @subproject_version = Version.generate!(:project => @subproject)
                   assert @subproject.archive
                   @project.reload
                   assert !@subproject.active?
                   assert_same_elements [@parent_version_1, @parent_version_2], @project.rolled_up_versions
                 end
               end
               def test_shared_versions_none_sharing
                 p = Project.find(5)
                 v = Version.create!(:name => 'none_sharing', :project => p, :sharing => 'none')
                 assert p.shared_versions.include?(v)
                 assert !p.children.first.shared_versions.include?(v)
                 assert !p.root.shared_versions.include?(v)
                 assert !p.siblings.first.shared_versions.include?(v)
                 assert !p.root.siblings.first.shared_versions.include?(v)
               end
               def test_shared_versions_descendants_sharing
                 p = Project.find(5)
                 v = Version.create!(:name => 'descendants_sharing', :project => p, :sharing => 'descendants')
                 assert p.shared_versions.include?(v)
                 assert p.children.first.shared_versions.include?(v)
                 assert !p.root.shared_versions.include?(v)
                 assert !p.siblings.first.shared_versions.include?(v)
                 assert !p.root.siblings.first.shared_versions.include?(v)
               end
               def test_shared_versions_hierarchy_sharing
                 p = Project.find(5)
                 v = Version.create!(:name => 'hierarchy_sharing', :project => p, :sharing => 'hierarchy')
                 assert p.shared_versions.include?(v)
                 assert p.children.first.shared_versions.include?(v)
                 assert p.root.shared_versions.include?(v)
                 assert !p.siblings.first.shared_versions.include?(v)
                 assert !p.root.siblings.first.shared_versions.include?(v)
               end
               def test_shared_versions_tree_sharing
                 p = Project.find(5)
                 v = Version.create!(:name => 'tree_sharing', :project => p, :sharing => 'tree')
                 assert p.shared_versions.include?(v)
                 assert p.children.first.shared_versions.include?(v)
                 assert p.root.shared_versions.include?(v)
                 assert p.siblings.first.shared_versions.include?(v)
                 assert !p.root.siblings.first.shared_versions.include?(v)
               end
               def test_shared_versions_system_sharing
                 p = Project.find(5)
                 v = Version.create!(:name => 'system_sharing', :project => p, :sharing => 'system')
                 assert p.shared_versions.include?(v)
                 assert p.children.first.shared_versions.include?(v)
                 assert p.root.shared_versions.include?(v)
                 assert p.siblings.first.shared_versions.include?(v)
                 assert p.root.siblings.first.shared_versions.include?(v)
               end
               def test_shared_versions
                 parent = Project.find(1)
                 child = parent.children.find(3)
                 private_child = parent.children.find(5)
                 assert_equal [1,2,3], parent.version_ids.sort
                 assert_equal [4], child.version_ids
                 assert_equal [6], private_child.version_ids
                 assert_equal [7], Version.find_all_by_sharing('system').collect(&:id)
                 assert_equal 6, parent.shared_versions.size
                 parent.shared_versions.each do |version|
                   assert_kind_of Version, version
                 end
                 assert_equal [1,2,3,4,6,7], parent.shared_versions.collect(&:id).sort
               end
               def test_shared_versions_should_ignore_archived_subprojects
                 parent = Project.find(1)
                 child = parent.children.find(3)
                 child.archive
                 parent.reload
                 assert_equal [1,2,3], parent.version_ids.sort
                 assert_equal [4], child.version_ids
                 assert !parent.shared_versions.collect(&:id).include?(4)
               end
               def test_shared_versions_visible_to_user
                 user = User.find(3)
                 parent = Project.find(1)
                 child = parent.children.find(5)
                 assert_equal [1,2,3], parent.version_ids.sort
                 assert_equal [6], child.version_ids
                 versions = parent.shared_versions.visible(user)
                 assert_equal 4, versions.size
                 versions.each do |version|
                   assert_kind_of Version, version
                 end
                 assert !versions.collect(&:id).include?(6)
               end
               def test_shared_versions_for_new_project_should_include_system_shared_versions
                 p = Project.find(5)
                 v = Version.create!(:name => 'system_sharing', :project => p, :sharing => 'system')
                 assert_include v, Project.new.shared_versions
               end
               def test_next_identifier
                 ProjectCustomField.delete_all
                 Project.create!(:name => 'last', :identifier => 'p2008040')
                 assert_equal 'p2008041', Project.next_identifier
               end
               def test_next_identifier_first_project
                 Project.delete_all
                 assert_nil Project.next_identifier
               end
               def test_enabled_module_names
                 with_settings :default_projects_modules => ['issue_tracking', 'repository'] do
                   project = Project.new
                   project.enabled_module_names = %w(issue_tracking news)
                   assert_equal %w(issue_tracking news), project.enabled_module_names.sort
                 end
               end
               context "enabled_modules" do
                 setup do
                   @project = Project.find(1)
                 end
                 should "define module by names and preserve ids" do
                   # Remove one module
                   modules = @project.enabled_modules.slice(0..-2)
                   assert modules.any?
                   assert_difference 'EnabledModule.count', -1 do
                     @project.enabled_module_names = modules.collect(&:name)
                   end
                   @project.reload
                   # Ids should be preserved
                   assert_equal @project.enabled_module_ids.sort, modules.collect(&:id).sort
                 end
                 should "enable a module" do
                   @project.enabled_module_names = []
                   @project.reload
                   assert_equal [], @project.enabled_module_names
                   #with string
                   @project.enable_module!("issue_tracking")
                   assert_equal ["issue_tracking"], @project.enabled_module_names
                   #with symbol
                   @project.enable_module!(:gantt)
                   assert_equal ["issue_tracking", "gantt"], @project.enabled_module_names
                   #don't add a module twice
                   @project.enable_module!("issue_tracking")
                   assert_equal ["issue_tracking", "gantt"], @project.enabled_module_names
                 end
                 should "disable a module" do
                   #with string
                   assert @project.enabled_module_names.include?("issue_tracking")
                   @project.disable_module!("issue_tracking")
                   assert ! @project.reload.enabled_module_names.include?("issue_tracking")
                   #with symbol
                   assert @project.enabled_module_names.include?("gantt")
                   @project.disable_module!(:gantt)
                   assert ! @project.reload.enabled_module_names.include?("gantt")
                   #with EnabledModule object
                   first_module = @project.enabled_modules.first
                   @project.disable_module!(first_module)
                   assert ! @project.reload.enabled_module_names.include?(first_module.name)
                 end
               end
               def test_enabled_module_names_should_not_recreate_enabled_modules
                 project = Project.find(1)
                 # Remove one module
                 modules = project.enabled_modules.slice(0..-2)
                 assert modules.any?
                 assert_difference 'EnabledModule.count', -1 do
                   project.enabled_module_names = modules.collect(&:name)
                 end
                 project.reload
                 # Ids should be preserved
                 assert_equal project.enabled_module_ids.sort, modules.collect(&:id).sort
               end
               def test_copy_from_existing_project
                 source_project = Project.find(1)
                 copied_project = Project.copy_from(1)
                 assert copied_project
                 # Cleared attributes
                 assert copied_project.id.blank?
                 assert copied_project.name.blank?
                 assert copied_project.identifier.blank?
                 # Duplicated attributes
                 assert_equal source_project.description, copied_project.description
                 assert_equal source_project.enabled_modules, copied_project.enabled_modules
                 assert_equal source_project.trackers, copied_project.trackers
                 # Default attributes
                 assert_equal 1, copied_project.status
               end
               def test_activities_should_use_the_system_activities
                 project = Project.find(1)
-                assert_equal project.activities, TimeEntryActivity.find(:all, :conditions => {:active => true} )
+                assert_equal project.activities, TimeEntryActivity.where(:active => true).all
               end
               def test_activities_should_use_the_project_specific_activities
                 project = Project.find(1)
                 overridden_activity = TimeEntryActivity.new({:name => "Project", :project => project})
                 assert overridden_activity.save!
                 assert project.activities.include?(overridden_activity), "Project specific Activity not found"
               end
               def test_activities_should_not_include_the_inactive_project_specific_activities
                 project = Project.find(1)
                 overridden_activity = TimeEntryActivity.new({:name => "Project", :project => project, :parent => TimeEntryActivity.find(:first), :active => false})
                 assert overridden_activity.save!
                 assert !project.activities.include?(overridden_activity), "Inactive Project specific Activity found"
               end
               def test_activities_should_not_include_project_specific_activities_from_other_projects
                 project = Project.find(1)
                 overridden_activity = TimeEntryActivity.new({:name => "Project", :project => Project.find(2)})
                 assert overridden_activity.save!
                 assert !project.activities.include?(overridden_activity), "Project specific Activity found on a different project"
               end
               def test_activities_should_handle_nils
                 overridden_activity = TimeEntryActivity.new({:name => "Project", :project => Project.find(1), :parent => TimeEntryActivity.find(:first)})
                 TimeEntryActivity.delete_all
                 # No activities
                 project = Project.find(1)
                 assert project.activities.empty?
                 # No system, one overridden
                 assert overridden_activity.save!
                 project.reload
                 assert_equal [overridden_activity], project.activities
               end
               def test_activities_should_override_system_activities_with_project_activities
                 project = Project.find(1)
                 parent_activity = TimeEntryActivity.find(:first)
                 overridden_activity = TimeEntryActivity.new({:name => "Project", :project => project, :parent => parent_activity})
                 assert overridden_activity.save!
                 assert project.activities.include?(overridden_activity), "Project specific Activity not found"
                 assert !project.activities.include?(parent_activity), "System Activity found when it should have been overridden"
               end
               def test_activities_should_include_inactive_activities_if_specified
                 project = Project.find(1)
                 overridden_activity = TimeEntryActivity.new({:name => "Project", :project => project, :parent => TimeEntryActivity.find(:first), :active => false})
                 assert overridden_activity.save!
                 assert project.activities(true).include?(overridden_activity), "Inactive Project specific Activity not found"
               end
               test 'activities should not include active System activities if the project has an override that is inactive' do
                 project = Project.find(1)
                 system_activity = TimeEntryActivity.find_by_name('Design')
                 assert system_activity.active?
                 overridden_activity = TimeEntryActivity.create!(:name => "Project", :project => project, :parent => system_activity, :active => false)
                 assert overridden_activity.save!
                 assert !project.activities.include?(overridden_activity), "Inactive Project specific Activity not found"
                 assert !project.activities.include?(system_activity), "System activity found when the project has an inactive override"
               end
               def test_close_completed_versions
                 Version.update_all("status = 'open'")
                 project = Project.find(1)
                 assert_not_nil project.versions.detect {|v| v.completed? && v.status == 'open'}
                 assert_not_nil project.versions.detect {|v| !v.completed? && v.status == 'open'}
                 project.close_completed_versions
                 project.reload
                 assert_nil project.versions.detect {|v| v.completed? && v.status != 'closed'}
                 assert_not_nil project.versions.detect {|v| !v.completed? && v.status == 'open'}
               end
               context "Project#copy" do
                 setup do
                   ProjectCustomField.destroy_all # Custom values are a mess to isolate in tests
                   Project.destroy_all :identifier => "copy-test"
                   @source_project = Project.find(2)
                   @project = Project.new(:name => 'Copy Test', :identifier => 'copy-test')
                   @project.trackers = @source_project.trackers
                   @project.enabled_module_names = @source_project.enabled_modules.collect(&:name)
                 end
                 should "copy issues" do
                   @source_project.issues << Issue.generate!(:status => IssueStatus.find_by_name('Closed'),
                                                             :subject => "copy issue status",
                                                             :tracker_id => 1,
                                                             :assigned_to_id => 2,
                                                             :project_id => @source_project.id)
                   assert @project.valid?
                   assert @project.issues.empty?
                   assert @project.copy(@source_project)
                   assert_equal @source_project.issues.size, @project.issues.size
                   @project.issues.each do |issue|
                     assert issue.valid?
                     assert ! issue.assigned_to.blank?
                     assert_equal @project, issue.project
                   end
                   copied_issue = @project.issues.first(:conditions => {:subject => "copy issue status"})
                   assert copied_issue
                   assert copied_issue.status
                   assert_equal "Closed", copied_issue.status.name
                 end
                 should "copy issues assigned to a locked version" do
                   User.current = User.find(1)
                   assigned_version = Version.generate!(:name => "Assigned Issues")
                   @source_project.versions << assigned_version
                   Issue.generate!(:project => @source_project,
                                   :fixed_version_id => assigned_version.id,
                                   :subject => "copy issues assigned to a locked version")
                   assigned_version.update_attribute :status, 'locked'
                   assert @project.copy(@source_project)
                   @project.reload
                   copied_issue = @project.issues.first(:conditions => {:subject => "copy issues assigned to a locked version"})
                   assert copied_issue
                   assert copied_issue.fixed_version
                   assert_equal "Assigned Issues", copied_issue.fixed_version.name # Same name
                   assert_equal 'locked', copied_issue.fixed_version.status
                 end
                 should "change the new issues to use the copied version" do
                   User.current = User.find(1)
                   assigned_version = Version.generate!(:name => "Assigned Issues", :status => 'open')
                   @source_project.versions << assigned_version
                   assert_equal 3, @source_project.versions.size
                   Issue.generate!(:project => @source_project,
                                   :fixed_version_id => assigned_version.id,
                                   :subject => "change the new issues to use the copied version")
                   assert @project.copy(@source_project)
                   @project.reload
                   copied_issue = @project.issues.first(:conditions => {:subject => "change the new issues to use the copied version"})
                   assert copied_issue
                   assert copied_issue.fixed_version
                   assert_equal "Assigned Issues", copied_issue.fixed_version.name # Same name
                   assert_not_equal assigned_version.id, copied_issue.fixed_version.id # Different record
                 end
                 should "keep target shared versions from other project" do
                   assigned_version = Version.generate!(:name => "Assigned Issues", :status => 'open', :project_id => 1, :sharing => 'system')
                   issue = Issue.generate!(:project => @source_project,
                                           :fixed_version => assigned_version,
                                           :subject => "keep target shared versions")
                   assert @project.copy(@source_project)
                   @project.reload
                   copied_issue = @project.issues.first(:conditions => {:subject => "keep target shared versions"})
                   assert copied_issue
                   assert_equal assigned_version, copied_issue.fixed_version
                 end
                 should "copy issue relations" do
                   Setting.cross_project_issue_relations = '1'
                   second_issue = Issue.generate!(:status_id => 5,
                                                  :subject => "copy issue relation",
                                                  :tracker_id => 1,
                                                  :assigned_to_id => 2,
                                                  :project_id => @source_project.id)
                   source_relation = IssueRelation.create!(:issue_from => Issue.find(4),
                                                             :issue_to => second_issue,
                                                             :relation_type => "relates")
                   source_relation_cross_project = IssueRelation.create!(:issue_from => Issue.find(1),
                                                                           :issue_to => second_issue,
                                                                           :relation_type => "duplicates")
                   assert @project.copy(@source_project)
                   assert_equal @source_project.issues.count, @project.issues.count
                   copied_issue = @project.issues.find_by_subject("Issue on project 2") # Was #4
                   copied_second_issue = @project.issues.find_by_subject("copy issue relation")
                   # First issue with a relation on project
                   assert_equal 1, copied_issue.relations.size, "Relation not copied"
                   copied_relation = copied_issue.relations.first
                   assert_equal "relates", copied_relation.relation_type
                   assert_equal copied_second_issue.id, copied_relation.issue_to_id
                   assert_not_equal source_relation.id, copied_relation.id
                   # Second issue with a cross project relation
                   assert_equal 2, copied_second_issue.relations.size, "Relation not copied"
                   copied_relation = copied_second_issue.relations.select {|r| r.relation_type == 'duplicates'}.first
                   assert_equal "duplicates", copied_relation.relation_type
                   assert_equal 1, copied_relation.issue_from_id, "Cross project relation not kept"
                   assert_not_equal source_relation_cross_project.id, copied_relation.id
                 end
                 should "copy issue attachments" do
                   issue = Issue.generate!(:subject => "copy with attachment", :tracker_id => 1, :project_id => @source_project.id)
                   Attachment.create!(:container => issue, :file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 1)
                   @source_project.issues << issue
                   assert @project.copy(@source_project)
                   copied_issue = @project.issues.first(:conditions => {:subject => "copy with attachment"})
                   assert_not_nil copied_issue
                   assert_equal 1, copied_issue.attachments.count, "Attachment not copied"
                   assert_equal "testfile.txt", copied_issue.attachments.first.filename
                 end
                 should "copy memberships" do
                   assert @project.valid?
                   assert @project.members.empty?
                   assert @project.copy(@source_project)
                   assert_equal @source_project.memberships.size, @project.memberships.size
                   @project.memberships.each do |membership|
                     assert membership
                     assert_equal @project, membership.project
                   end
                 end
                 should "copy memberships with groups and additional roles" do
                   group = Group.create!(:lastname => "Copy group")
                   user = User.find(7)
                   group.users << user
                   # group role
                   Member.create!(:project_id => @source_project.id, :principal => group, :role_ids => [2])
                   member = Member.find_by_user_id_and_project_id(user.id, @source_project.id)
                   # additional role
                   member.role_ids = [1]
                   assert @project.copy(@source_project)
                   member = Member.find_by_user_id_and_project_id(user.id, @project.id)
                   assert_not_nil member
                   assert_equal [1, 2], member.role_ids.sort
                 end
                 should "copy project specific queries" do
                   assert @project.valid?
                   assert @project.queries.empty?
                   assert @project.copy(@source_project)
                   assert_equal @source_project.queries.size, @project.queries.size
                   @project.queries.each do |query|
                     assert query
                     assert_equal @project, query.project
                   end
                   assert_equal @source_project.queries.map(&:user_id).sort, @project.queries.map(&:user_id).sort
                 end
                 should "copy versions" do
                   @source_project.versions << Version.generate!
                   @source_project.versions << Version.generate!
                   assert @project.versions.empty?
                   assert @project.copy(@source_project)
                   assert_equal @source_project.versions.size, @project.versions.size
                   @project.versions.each do |version|
                     assert version
                     assert_equal @project, version.project
                   end
                 end
                 should "copy wiki" do
                   assert_difference 'Wiki.count' do
                     assert @project.copy(@source_project)
                   end
                   assert @project.wiki
                   assert_not_equal @source_project.wiki, @project.wiki
                   assert_equal "Start page", @project.wiki.start_page
                 end
                 should "copy wiki pages and content with hierarchy" do
                   assert_difference 'WikiPage.count', @source_project.wiki.pages.size do
                     assert @project.copy(@source_project)
                   end
                   assert @project.wiki
                   assert_equal @source_project.wiki.pages.size, @project.wiki.pages.size
                   @project.wiki.pages.each do |wiki_page|
                     assert wiki_page.content
                     assert !@source_project.wiki.pages.include?(wiki_page)
                   end
                   parent = @project.wiki.find_page('Parent_page')
                   child1 = @project.wiki.find_page('Child_page_1')
                   child2 = @project.wiki.find_page('Child_page_2')
                   assert_equal parent, child1.parent
                   assert_equal parent, child2.parent
                 end
                 should "copy issue categories" do
                   assert @project.copy(@source_project)
                   assert_equal 2, @project.issue_categories.size
                   @project.issue_categories.each do |issue_category|
                     assert !@source_project.issue_categories.include?(issue_category)
                   end
                 end
                 should "copy boards" do
                   assert @project.copy(@source_project)
                   assert_equal 1, @project.boards.size
                   @project.boards.each do |board|
                     assert !@source_project.boards.include?(board)
                   end
                 end
                 should "change the new issues to use the copied issue categories" do
                   issue = Issue.find(4)
                   issue.update_attribute(:category_id, 3)
                   assert @project.copy(@source_project)
                   @project.issues.each do |issue|
                     assert issue.category
                     assert_equal "Stock management", issue.category.name # Same name
                     assert_not_equal IssueCategory.find(3), issue.category # Different record
                   end
                 end
                 should "limit copy with :only option" do
                   assert @project.members.empty?
                   assert @project.issue_categories.empty?
                   assert @source_project.issues.any?
                   assert @project.copy(@source_project, :only => ['members', 'issue_categories'])
                   assert @project.members.any?
                   assert @project.issue_categories.any?
                   assert @project.issues.empty?
                 end
               end
               def test_copy_should_copy_subtasks
                 source = Project.generate!(:tracker_ids => [1])
                 issue = Issue.generate_with_descendants!(:project => source)
                 project = Project.new(:name => 'Copy', :identifier => 'copy', :tracker_ids => [1])
                 assert_difference 'Project.count' do
                   assert_difference 'Issue.count', 1+issue.descendants.count do
                     assert project.copy(source.reload)
                   end
                 end
                 copy = Issue.where(:parent_id => nil).order("id DESC").first
                 assert_equal project, copy.project
                 assert_equal issue.descendants.count, copy.descendants.count
                 child_copy = copy.children.detect {|c| c.subject == 'Child1'}
                 assert child_copy.descendants.any?
               end
               context "#start_date" do
                 setup do
                   ProjectCustomField.destroy_all # Custom values are a mess to isolate in tests
                   @project = Project.generate!(:identifier => 'test0')
                   @project.trackers << Tracker.generate!
                 end
                 should "be nil if there are no issues on the project" do
                   assert_nil @project.start_date
                 end
                 should "be tested when issues have no start date"
                 should "be the earliest start date of it's issues" do
                   early = 7.days.ago.to_date
                   Issue.generate!(:project => @project, :start_date => Date.today)
                   Issue.generate!(:project => @project, :start_date => early)
                   assert_equal early, @project.start_date
                 end
               end
               context "#due_date" do
                 setup do
                   ProjectCustomField.destroy_all # Custom values are a mess to isolate in tests
                   @project = Project.generate!(:identifier => 'test0')
                   @project.trackers << Tracker.generate!
                 end
                 should "be nil if there are no issues on the project" do
                   assert_nil @project.due_date
                 end
                 should "be tested when issues have no due date"
                 should "be the latest due date of it's issues" do
                   future = 7.days.from_now.to_date
                   Issue.generate!(:project => @project, :due_date => future)
                   Issue.generate!(:project => @project, :due_date => Date.today)
                   assert_equal future, @project.due_date
                 end
                 should "be the latest due date of it's versions" do
                   future = 7.days.from_now.to_date
                   @project.versions << Version.generate!(:effective_date => future)
                   @project.versions << Version.generate!(:effective_date => Date.today)
                   assert_equal future, @project.due_date
                 end
                 should "pick the latest date from it's issues and versions" do
                   future = 7.days.from_now.to_date
                   far_future = 14.days.from_now.to_date
                   Issue.generate!(:project => @project, :due_date => far_future)
                   @project.versions << Version.generate!(:effective_date => future)
                   assert_equal far_future, @project.due_date
                 end
               end
               context "Project#completed_percent" do
                 setup do
                   ProjectCustomField.destroy_all # Custom values are a mess to isolate in tests
                   @project = Project.generate!(:identifier => 'test0')
                   @project.trackers << Tracker.generate!
                 end
                 context "no versions" do
                   should "be 100" do
                     assert_equal 100, @project.completed_percent
                   end
                 end
                 context "with versions" do
                   should "return 0 if the versions have no issues" do
                     Version.generate!(:project => @project)
                     Version.generate!(:project => @project)
                     assert_equal 0, @project.completed_percent
                   end
                   should "return 100 if the version has only closed issues" do
                     v1 = Version.generate!(:project => @project)
                     Issue.generate!(:project => @project, :status => IssueStatus.find_by_name('Closed'), :fixed_version => v1)
                     v2 = Version.generate!(:project => @project)
                     Issue.generate!(:project => @project, :status => IssueStatus.find_by_name('Closed'), :fixed_version => v2)
                     assert_equal 100, @project.completed_percent
                   end
                   should "return the averaged completed percent of the versions (not weighted)" do
                     v1 = Version.generate!(:project => @project)
                     Issue.generate!(:project => @project, :status => IssueStatus.find_by_name('New'), :estimated_hours => 10, :done_ratio => 50, :fixed_version => v1)
                     v2 = Version.generate!(:project => @project)
                     Issue.generate!(:project => @project, :status => IssueStatus.find_by_name('New'), :estimated_hours => 10, :done_ratio => 50, :fixed_version => v2)
                     assert_equal 50, @project.completed_percent
                   end
                 end
               end
               context "#notified_users" do
                 setup do
                   @project = Project.generate!
                   @role = Role.generate!
                   @user_with_membership_notification = User.generate!(:mail_notification => 'selected')
                   Member.create!(:project => @project, :roles => [@role], :principal => @user_with_membership_notification, :mail_notification => true)
                   @all_events_user = User.generate!(:mail_notification => 'all')
                   Member.create!(:project => @project, :roles => [@role], :principal => @all_events_user)
                   @no_events_user = User.generate!(:mail_notification => 'none')
                   Member.create!(:project => @project, :roles => [@role], :principal => @no_events_user)
                   @only_my_events_user = User.generate!(:mail_notification => 'only_my_events')
                   Member.create!(:project => @project, :roles => [@role], :principal => @only_my_events_user)
                   @only_assigned_user = User.generate!(:mail_notification => 'only_assigned')
                   Member.create!(:project => @project, :roles => [@role], :principal => @only_assigned_user)
                   @only_owned_user = User.generate!(:mail_notification => 'only_owner')
                   Member.create!(:project => @project, :roles => [@role], :principal => @only_owned_user)
                 end
                 should "include members with a mail notification" do
                   assert @project.notified_users.include?(@user_with_membership_notification)
                 end
                 should "include users with the 'all' notification option" do
                   assert @project.notified_users.include?(@all_events_user)
                 end
                 should "not include users with the 'none' notification option" do
                   assert !@project.notified_users.include?(@no_events_user)
                 end
                 should "not include users with the 'only_my_events' notification option" do
                   assert !@project.notified_users.include?(@only_my_events_user)
                 end
                 should "not include users with the 'only_assigned' notification option" do
                   assert !@project.notified_users.include?(@only_assigned_user)
                 end
                 should "not include users with the 'only_owner' notification option" do
                   assert !@project.notified_users.include?(@only_owned_user)
                 end
               end
             end

test/unit/repository_bazaar_test.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class RepositoryBazaarTest < ActiveSupport::TestCase
               fixtures :projects
               include Redmine::I18n
               REPOSITORY_PATH = Rails.root.join('tmp/test/bazaar_repository').to_s
               REPOSITORY_PATH_TRUNK = File.join(REPOSITORY_PATH, "trunk")
               NUM_REV = 4
               REPOSITORY_PATH_NON_ASCII = Rails.root.join(REPOSITORY_PATH + '/' + 'non_ascii').to_s
               # Bazaar core does not support xml output such as Subversion and Mercurial.
               # "bzr" command output and command line parameter depend on locale.
               # So, non ASCII path tests cannot run independent locale.
               #
               # If you want to run Bazaar non ASCII path tests on Linux *Ruby 1.9*,
               # you need to set locale character set "ISO-8859-1".
               # E.g. "LANG=en_US.ISO-8859-1".
               # On Linux other platforms (e.g. Ruby 1.8, JRuby),
               # you need to set "RUN_LATIN1_OUTPUT_TEST = true" manually.
               #
               # On Windows, because it is too hard to change system locale,
               # you cannot run Bazaar non ASCII path tests.
               #
               RUN_LATIN1_OUTPUT_TEST = (RUBY_PLATFORM != 'java' &&
                                          REPOSITORY_PATH.respond_to?(:force_encoding) &&
                                          Encoding.locale_charmap == "ISO-8859-1")
               CHAR_1_UTF8_HEX   = "\xc3\x9c"
               CHAR_1_LATIN1_HEX = "\xdc"
               def setup
                 @project = Project.find(3)
                 @repository = Repository::Bazaar.create(
                           :project => @project, :url => REPOSITORY_PATH_TRUNK,
                           :log_encoding => 'UTF-8')
                 assert @repository
                 @char_1_utf8      = CHAR_1_UTF8_HEX.dup
                 @char_1_ascii8bit = CHAR_1_LATIN1_HEX.dup
                 if @char_1_utf8.respond_to?(:force_encoding)
                   @char_1_utf8.force_encoding('UTF-8')
                   @char_1_ascii8bit.force_encoding('ASCII-8BIT')
                 end
               end
               def test_blank_path_to_repository_error_message
                 set_language_if_valid 'en'
                 repo = Repository::Bazaar.new(
                                       :project      => @project,
                                       :identifier   => 'test',
                                       :log_encoding => 'UTF-8'
                                     )
                 assert !repo.save
                 assert_include "Path to repository can't be blank",
                                repo.errors.full_messages
               end
               def test_blank_path_to_repository_error_message_fr
                 set_language_if_valid 'fr'
                 str = "Chemin du d\xc3\xa9p\xc3\xb4t doit \xc3\xaatre renseign\xc3\xa9(e)"
                 str.force_encoding('UTF-8') if str.respond_to?(:force_encoding)
                 repo = Repository::Bazaar.new(
                                       :project      => @project,
                                       :url          => "",
                                       :identifier   => 'test',
                                       :log_encoding => 'UTF-8'
                                     )
                 assert !repo.save
                 assert_include str, repo.errors.full_messages
               end
               if File.directory?(REPOSITORY_PATH_TRUNK)
                 def test_fetch_changesets_from_scratch
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   assert_equal 9, @repository.filechanges.count
                   assert_equal 'Initial import', @repository.changesets.find_by_revision('1').comments
                 end
                 def test_fetch_changesets_incremental
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   # Remove changesets with revision > 5
-                  @repository.changesets.find(:all).each {|c| c.destroy if c.revision.to_i > 2}
+                  @repository.changesets.all.each {|c| c.destroy if c.revision.to_i > 2}
                   @project.reload
                   assert_equal 2, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                 end
                 def test_entries
                   entries = @repository.entries
                   assert_kind_of Redmine::Scm::Adapters::Entries, entries
                   assert_equal 2, entries.size
                   assert_equal 'dir', entries[0].kind
                   assert_equal 'directory', entries[0].name
                   assert_equal 'directory', entries[0].path
                   assert_equal 'file', entries[1].kind
                   assert_equal 'doc-mkdir.txt', entries[1].name
                   assert_equal 'doc-mkdir.txt', entries[1].path
                 end
                 def test_entries_in_subdirectory
                   entries = @repository.entries('directory')
                   assert_equal 3, entries.size
                   assert_equal 'file', entries.last.kind
                   assert_equal 'edit.png', entries.last.name
                   assert_equal 'directory/edit.png', entries.last.path
                 end
                 def test_previous
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   changeset = @repository.find_changeset_by_name('3')
                   assert_equal @repository.find_changeset_by_name('2'), changeset.previous
                 end
                 def test_previous_nil
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   changeset = @repository.find_changeset_by_name('1')
                   assert_nil changeset.previous
                 end
                 def test_next
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   changeset = @repository.find_changeset_by_name('2')
                   assert_equal @repository.find_changeset_by_name('3'), changeset.next
                 end
                 def test_next_nil
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   changeset = @repository.find_changeset_by_name('4')
                   assert_nil changeset.next
                 end
                 if File.directory?(REPOSITORY_PATH_NON_ASCII) && RUN_LATIN1_OUTPUT_TEST
                   def test_cat_latin1_path
                     latin1_repo = create_latin1_repo
                     buf = latin1_repo.cat(
                              "test-#{@char_1_utf8}-dir/test-#{@char_1_utf8}-2.txt", 2)
                     assert buf
                     lines = buf.split("\n")
                     assert_equal 2, lines.length
                     assert_equal 'It is written in Python.', lines[1]
                     buf = latin1_repo.cat(
                              "test-#{@char_1_utf8}-dir/test-#{@char_1_utf8}-1.txt", 2)
                     assert buf
                     lines = buf.split("\n")
                     assert_equal 1, lines.length
                     assert_equal "test-#{@char_1_ascii8bit}.txt", lines[0]
                   end
                   def test_annotate_latin1_path
                     latin1_repo = create_latin1_repo
                     ann1 = latin1_repo.annotate(
                                "test-#{@char_1_utf8}-dir/test-#{@char_1_utf8}-2.txt", 2)
                     assert_equal 2, ann1.lines.size
                     assert_equal '2', ann1.revisions[0].identifier
                     assert_equal 'test00@', ann1.revisions[0].author
                     assert_equal 'It is written in Python.', ann1.lines[1]
                     ann2 = latin1_repo.annotate(
                                "test-#{@char_1_utf8}-dir/test-#{@char_1_utf8}-1.txt", 2)
                     assert_equal 1, ann2.lines.size
                     assert_equal '2', ann2.revisions[0].identifier
                     assert_equal 'test00@', ann2.revisions[0].author
                     assert_equal "test-#{@char_1_ascii8bit}.txt", ann2.lines[0]
                   end
                   def test_diff_latin1_path
                     latin1_repo = create_latin1_repo
                     diff1 = latin1_repo.diff(
                               "test-#{@char_1_utf8}-dir/test-#{@char_1_utf8}-1.txt", 2, 1)
                     assert_equal 7, diff1.size
                     buf =  diff1[5].gsub(/\r\n|\r|\n/, "")
                     assert_equal "+test-#{@char_1_ascii8bit}.txt", buf
                   end
                   def test_entries_latin1_path
                     latin1_repo = create_latin1_repo
                     entries = latin1_repo.entries("test-#{@char_1_utf8}-dir", 2)
                     assert_kind_of Redmine::Scm::Adapters::Entries, entries
                     assert_equal 3, entries.size
                     assert_equal 'file', entries[1].kind
                     assert_equal "test-#{@char_1_utf8}-1.txt", entries[0].name
                     assert_equal "test-#{@char_1_utf8}-dir/test-#{@char_1_utf8}-1.txt", entries[0].path
                   end
                   def test_entry_latin1_path
                     latin1_repo = create_latin1_repo
                     ["test-#{@char_1_utf8}-dir",
                       "/test-#{@char_1_utf8}-dir",
                       "/test-#{@char_1_utf8}-dir/"
                     ].each do |path|
                       entry = latin1_repo.entry(path, 2)
                       assert_equal "test-#{@char_1_utf8}-dir", entry.path
                       assert_equal "dir", entry.kind
                     end
                     ["test-#{@char_1_utf8}-dir/test-#{@char_1_utf8}-1.txt",
                       "/test-#{@char_1_utf8}-dir/test-#{@char_1_utf8}-1.txt"
                     ].each do |path|
                       entry = latin1_repo.entry(path, 2)
                       assert_equal "test-#{@char_1_utf8}-dir/test-#{@char_1_utf8}-1.txt",
                                    entry.path
                       assert_equal "file", entry.kind
                     end
                   end
                   def test_changeset_latin1_path
                     latin1_repo = create_latin1_repo
                     assert_equal 0, latin1_repo.changesets.count
                     latin1_repo.fetch_changesets
                     @project.reload
                     assert_equal 3, latin1_repo.changesets.count
                     cs2 = latin1_repo.changesets.find_by_revision('2')
                     assert_not_nil cs2
                     assert_equal "test-#{@char_1_utf8}", cs2.comments
                     c2  = cs2.filechanges.sort_by(&:path)
                     assert_equal 4, c2.size
                     assert_equal 'A', c2[0].action
                     assert_equal "/test-#{@char_1_utf8}-dir/", c2[0].path
                     assert_equal 'A', c2[1].action
                     assert_equal "/test-#{@char_1_utf8}-dir/test-#{@char_1_utf8}-1.txt", c2[1].path
                     assert_equal 'A', c2[2].action
                     assert_equal "/test-#{@char_1_utf8}-dir/test-#{@char_1_utf8}-2.txt", c2[2].path
                     assert_equal 'A', c2[3].action
                     assert_equal "/test-#{@char_1_utf8}-dir/test-#{@char_1_utf8}.txt", c2[3].path
                     cs3 = latin1_repo.changesets.find_by_revision('3')
                     assert_not_nil cs3
                     assert_equal "modify, move and delete #{@char_1_utf8} files", cs3.comments
                     c3  = cs3.filechanges.sort_by(&:path)
                     assert_equal 3, c3.size
                     assert_equal 'M', c3[0].action
                     assert_equal "/test-#{@char_1_utf8}-1.txt", c3[0].path
                     assert_equal 'D', c3[1].action
                     assert_equal "/test-#{@char_1_utf8}-dir/test-#{@char_1_utf8}-2.txt", c3[1].path
                     assert_equal 'M', c3[2].action
                     assert_equal "/test-#{@char_1_utf8}-dir/test-#{@char_1_utf8}.txt", c3[2].path
                   end
                 else
                   msg = "Bazaar non ASCII output test cannot run this environment." + "\n"
                   if msg.respond_to?(:force_encoding)
                     msg += "Encoding.locale_charmap: " + Encoding.locale_charmap + "\n"
                   end
                   puts msg
                 end
                 private
                 def create_latin1_repo
                   repo = Repository::Bazaar.create(
                                         :project      => @project,
                                         :identifier   => 'latin1',
                                         :url => REPOSITORY_PATH_NON_ASCII,
                                         :log_encoding => 'ISO-8859-1'
                                     )
                   assert repo
                   repo
                 end
               else
                 puts "Bazaar test repository NOT FOUND. Skipping unit tests !!!"
                 def test_fake; assert true end
               end
             end

test/unit/repository_cvs_test.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             require 'pp'
             class RepositoryCvsTest < ActiveSupport::TestCase
               fixtures :projects
               include Redmine::I18n
               REPOSITORY_PATH = Rails.root.join('tmp/test/cvs_repository').to_s
               REPOSITORY_PATH.gsub!(/\//, "\\") if Redmine::Platform.mswin?
               # CVS module
               MODULE_NAME    = 'test'
               CHANGESETS_NUM = 7
               def setup
                 @project = Project.find(3)
                 @repository = Repository::Cvs.create(:project  => @project,
                                                      :root_url => REPOSITORY_PATH,
                                                      :url      => MODULE_NAME,
                                                      :log_encoding => 'UTF-8')
                 assert @repository
               end
               def test_blank_module_error_message
                 set_language_if_valid 'en'
                 repo = Repository::Cvs.new(
                                       :project      => @project,
                                       :identifier   => 'test',
                                       :log_encoding => 'UTF-8',
                                       :root_url     => REPOSITORY_PATH
                                     )
                 assert !repo.save
                 assert_include "Module can't be blank",
                                repo.errors.full_messages
               end
               def test_blank_module_error_message_fr
                 set_language_if_valid 'fr'
                 str = "Module doit \xc3\xaatre renseign\xc3\xa9(e)"
                 str.force_encoding('UTF-8') if str.respond_to?(:force_encoding)
                 repo = Repository::Cvs.new(
                                       :project       => @project,
                                       :identifier    => 'test',
                                       :log_encoding  => 'UTF-8',
                                       :path_encoding => '',
                                       :url           => '',
                                       :root_url      => REPOSITORY_PATH
                                     )
                 assert !repo.save
                 assert_include str, repo.errors.full_messages
               end
               def test_blank_cvsroot_error_message
                 set_language_if_valid 'en'
                 repo = Repository::Cvs.new(
                                       :project      => @project,
                                       :identifier   => 'test',
                                       :log_encoding => 'UTF-8',
                                       :url          => MODULE_NAME
                                     )
                 assert !repo.save
                 assert_include "CVSROOT can't be blank",
                                repo.errors.full_messages
               end
               def test_blank_cvsroot_error_message_fr
                 set_language_if_valid 'fr'
                 str = "CVSROOT doit \xc3\xaatre renseign\xc3\xa9(e)"
                 str.force_encoding('UTF-8') if str.respond_to?(:force_encoding)
                 repo = Repository::Cvs.new(
                                       :project       => @project,
                                       :identifier    => 'test',
                                       :log_encoding  => 'UTF-8',
                                       :path_encoding => '',
                                       :url           => MODULE_NAME,
                                       :root_url      => ''
                                     )
                 assert !repo.save
                 assert_include str, repo.errors.full_messages
               end
               if File.directory?(REPOSITORY_PATH)
                 def test_fetch_changesets_from_scratch
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal CHANGESETS_NUM, @repository.changesets.count
                   assert_equal 16, @repository.filechanges.count
                   assert_not_nil @repository.changesets.find_by_comments('Two files changed')
                   r2 = @repository.changesets.find_by_revision('2')
                   assert_equal 'v1-20071213-162510', r2.scmid
                 end
                 def test_fetch_changesets_incremental
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal CHANGESETS_NUM, @repository.changesets.count
                   # Remove changesets with revision > 3
-                  @repository.changesets.find(:all).each {|c| c.destroy if c.revision.to_i > 3}
+                  @repository.changesets.all.each {|c| c.destroy if c.revision.to_i > 3}
                   @project.reload
                   assert_equal 3, @repository.changesets.count
                   assert_equal %w|3 2 1|, @repository.changesets.all.collect(&:revision)
                   rev3_commit = @repository.changesets.find(:first, :order => 'committed_on DESC')
                   assert_equal '3', rev3_commit.revision
                    # 2007-12-14 01:27:22 +0900
                   rev3_committed_on = Time.gm(2007, 12, 13, 16, 27, 22)
                   assert_equal 'HEAD-20071213-162722', rev3_commit.scmid
                   assert_equal rev3_committed_on, rev3_commit.committed_on
                   latest_rev = @repository.latest_changeset
                   assert_equal rev3_committed_on, latest_rev.committed_on
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal CHANGESETS_NUM, @repository.changesets.count
                   assert_equal %w|7 6 5 4 3 2 1|, @repository.changesets.all.collect(&:revision)
                   rev5_commit = @repository.changesets.find_by_revision('5')
                   assert_equal 'HEAD-20071213-163001', rev5_commit.scmid
                    # 2007-12-14 01:30:01 +0900
                   rev5_committed_on = Time.gm(2007, 12, 13, 16, 30, 1)
                   assert_equal rev5_committed_on, rev5_commit.committed_on
                 end
                 def test_deleted_files_should_not_be_listed
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal CHANGESETS_NUM, @repository.changesets.count
                   entries = @repository.entries('sources')
                   assert entries.detect {|e| e.name == 'watchers_controller.rb'}
                   assert_nil entries.detect {|e| e.name == 'welcome_controller.rb'}
                 end
                 def test_entries_rev3
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal CHANGESETS_NUM, @repository.changesets.count
                   entries = @repository.entries('', '3')
                   assert_kind_of Redmine::Scm::Adapters::Entries, entries
                   assert_equal 3, entries.size
                   assert_equal entries[2].name, "README"
                   assert_equal entries[2].lastrev.time, Time.gm(2007, 12, 13, 16, 27, 22)
                   assert_equal entries[2].lastrev.identifier, '3'
                   assert_equal entries[2].lastrev.revision, '3'
                   assert_equal entries[2].lastrev.author, 'LANG'
                 end
                 def test_entries_invalid_path
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal CHANGESETS_NUM, @repository.changesets.count
                   assert_nil @repository.entries('missing')
                   assert_nil @repository.entries('missing', '3')
                 end
                 def test_entries_invalid_revision
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal CHANGESETS_NUM, @repository.changesets.count
                   assert_nil @repository.entries('', '123')
                 end
                 def test_cat
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal CHANGESETS_NUM, @repository.changesets.count
                   buf = @repository.cat('README')
                   assert buf
                   lines = buf.split("\n")
                   assert_equal 3, lines.length
                   buf = lines[1].gsub(/\r$/, "")
                   assert_equal 'with one change', buf
                   buf = @repository.cat('README', '1')
                   assert buf
                   lines = buf.split("\n")
                   assert_equal 1, lines.length
                   buf = lines[0].gsub(/\r$/, "")
                   assert_equal 'CVS test repository', buf
                   assert_nil @repository.cat('missing.rb')
                   # sources/welcome_controller.rb is removed at revision 5.
                   assert @repository.cat('sources/welcome_controller.rb', '4')
                   assert @repository.cat('sources/welcome_controller.rb', '5').blank?
                   # invalid revision
                   assert @repository.cat('README', '123').blank?
                 end
                 def test_annotate
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal CHANGESETS_NUM, @repository.changesets.count
                   ann = @repository.annotate('README')
                   assert ann
                   assert_equal 3, ann.revisions.length
                   assert_equal '1.2', ann.revisions[1].revision
                   assert_equal 'LANG', ann.revisions[1].author
                   assert_equal 'with one change', ann.lines[1]
                   ann = @repository.annotate('README', '1')
                   assert ann
                   assert_equal 1, ann.revisions.length
                   assert_equal '1.1', ann.revisions[0].revision
                   assert_equal 'LANG', ann.revisions[0].author
                   assert_equal 'CVS test repository', ann.lines[0]
                  # invalid revision
                  assert_nil @repository.annotate('README', '123')
                end
               else
                 puts "CVS test repository NOT FOUND. Skipping unit tests !!!"
                 def test_fake; assert true end
               end
             end

test/unit/repository_darcs_test.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class RepositoryDarcsTest < ActiveSupport::TestCase
               fixtures :projects
               include Redmine::I18n
               REPOSITORY_PATH = Rails.root.join('tmp/test/darcs_repository').to_s
               NUM_REV = 6
               def setup
                 @project = Project.find(3)
                 @repository = Repository::Darcs.create(
                                   :project      => @project,
                                   :url          => REPOSITORY_PATH,
                                   :log_encoding => 'UTF-8'
                                   )
                 assert @repository
               end
               def test_blank_path_to_repository_error_message
                 set_language_if_valid 'en'
                 repo = Repository::Darcs.new(
                                       :project      => @project,
                                       :identifier   => 'test',
                                       :log_encoding => 'UTF-8'
                                     )
                 assert !repo.save
                 assert_include "Path to repository can't be blank",
                                repo.errors.full_messages
               end
               def test_blank_path_to_repository_error_message_fr
                 set_language_if_valid 'fr'
                 str = "Chemin du d\xc3\xa9p\xc3\xb4t doit \xc3\xaatre renseign\xc3\xa9(e)"
                 str.force_encoding('UTF-8') if str.respond_to?(:force_encoding)
                 repo = Repository::Darcs.new(
                                       :project      => @project,
                                       :url          => "",
                                       :identifier   => 'test',
                                       :log_encoding => 'UTF-8'
                                     )
                 assert !repo.save
                 assert_include str, repo.errors.full_messages
               end
               if File.directory?(REPOSITORY_PATH)
                 def test_fetch_changesets_from_scratch
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   assert_equal 13, @repository.filechanges.count
                   assert_equal "Initial commit.", @repository.changesets.find_by_revision('1').comments
                 end
                 def test_fetch_changesets_incremental
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   # Remove changesets with revision > 3
-                  @repository.changesets.find(:all).each {|c| c.destroy if c.revision.to_i > 3}
+                  @repository.changesets.all.each {|c| c.destroy if c.revision.to_i > 3}
                   @project.reload
                   assert_equal 3, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                 end
                 def test_entries
                   entries = @repository.entries
                   assert_kind_of Redmine::Scm::Adapters::Entries, entries
                 end
                 def test_entries_invalid_revision
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   assert_nil @repository.entries('', '123')
                 end
                 def test_deleted_files_should_not_be_listed
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   entries = @repository.entries('sources')
                   assert entries.detect {|e| e.name == 'watchers_controller.rb'}
                   assert_nil entries.detect {|e| e.name == 'welcome_controller.rb'}
                 end
                 def test_cat
                   if @repository.scm.supports_cat?
                     assert_equal 0, @repository.changesets.count
                     @repository.fetch_changesets
                     @project.reload
                     assert_equal NUM_REV, @repository.changesets.count
                     cat = @repository.cat("sources/welcome_controller.rb", 2)
                     assert_not_nil cat
                     assert cat.include?('class WelcomeController < ApplicationController')
                   end
                 end
               else
                 puts "Darcs test repository NOT FOUND. Skipping unit tests !!!"
                 def test_fake; assert true end
               end
             end

test/unit/repository_mercurial_test.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class RepositoryMercurialTest < ActiveSupport::TestCase
               fixtures :projects
               include Redmine::I18n
               REPOSITORY_PATH = Rails.root.join('tmp/test/mercurial_repository').to_s
               NUM_REV = 32
               CHAR_1_HEX = "\xc3\x9c"
               def setup
                 @project    = Project.find(3)
                 @repository = Repository::Mercurial.create(
                                   :project => @project,
                                   :url     => REPOSITORY_PATH,
                                   :path_encoding => 'ISO-8859-1'
                                   )
                 assert @repository
                 @char_1        = CHAR_1_HEX.dup
                 @tag_char_1    = "tag-#{CHAR_1_HEX}-00"
                 @branch_char_0 = "branch-#{CHAR_1_HEX}-00"
                 @branch_char_1 = "branch-#{CHAR_1_HEX}-01"
                 if @char_1.respond_to?(:force_encoding)
                   @char_1.force_encoding('UTF-8')
                   @tag_char_1.force_encoding('UTF-8')
                   @branch_char_0.force_encoding('UTF-8')
                   @branch_char_1.force_encoding('UTF-8')
                 end
               end
               def test_blank_path_to_repository_error_message
                 set_language_if_valid 'en'
                 repo = Repository::Mercurial.new(
                                       :project      => @project,
                                       :identifier   => 'test'
                                     )
                 assert !repo.save
                 assert_include "Path to repository can't be blank",
                                repo.errors.full_messages
               end
               def test_blank_path_to_repository_error_message_fr
                 set_language_if_valid 'fr'
                 str = "Chemin du d\xc3\xa9p\xc3\xb4t doit \xc3\xaatre renseign\xc3\xa9(e)"
                 str.force_encoding('UTF-8') if str.respond_to?(:force_encoding)
                 repo = Repository::Mercurial.new(
                                       :project      => @project,
                                       :url          => "",
                                       :identifier   => 'test',
                                       :path_encoding => ''
                                     )
                 assert !repo.save
                 assert_include str, repo.errors.full_messages
               end
               if File.directory?(REPOSITORY_PATH)
                 def test_scm_available
                   klass = Repository::Mercurial
                   assert_equal "Mercurial", klass.scm_name
                   assert klass.scm_adapter_class
                   assert_not_equal "", klass.scm_command
                   assert_equal true, klass.scm_available
                 end
                 def test_entries
                   entries = @repository.entries
                   assert_kind_of Redmine::Scm::Adapters::Entries, entries
                 end
                 def test_fetch_changesets_from_scratch
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   assert_equal 46, @repository.filechanges.count
                   assert_equal "Initial import.\nThe repository contains 3 files.",
                                @repository.changesets.find_by_revision('0').comments
                 end
                 def test_fetch_changesets_incremental
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   # Remove changesets with revision > 2
-                  @repository.changesets.find(:all).each {|c| c.destroy if c.revision.to_i > 2}
+                  @repository.changesets.all.each {|c| c.destroy if c.revision.to_i > 2}
                   @project.reload
                   assert_equal 3, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                 end
                 def test_isodatesec
                   # Template keyword 'isodatesec' supported in Mercurial 1.0 and higher
                   if @repository.scm.class.client_version_above?([1, 0])
                     assert_equal 0, @repository.changesets.count
                     @repository.fetch_changesets
                     @project.reload
                     assert_equal NUM_REV, @repository.changesets.count
                     rev0_committed_on = Time.gm(2007, 12, 14, 9, 22, 52)
                     assert_equal @repository.changesets.find_by_revision('0').committed_on, rev0_committed_on
                   end
                 end
                 def test_changeset_order_by_revision
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   c0 = @repository.latest_changeset
                   c1 = @repository.changesets.find_by_revision('0')
                   # sorted by revision (id), not by date
                   assert c0.revision.to_i > c1.revision.to_i
                   assert c0.committed_on  < c1.committed_on
                 end
                 def test_latest_changesets
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   # with_limit
                   changesets = @repository.latest_changesets('', nil, 2)
                   assert_equal %w|31 30|, changesets.collect(&:revision)
                   # with_filepath
                   changesets = @repository.latest_changesets(
                                   '/sql_escape/percent%dir/percent%file1.txt', nil)
                   assert_equal %w|30 11 10 9|, changesets.collect(&:revision)
                   changesets = @repository.latest_changesets(
                                   '/sql_escape/underscore_dir/understrike_file.txt', nil)
                   assert_equal %w|30 12 9|, changesets.collect(&:revision)
                   changesets = @repository.latest_changesets('README', nil)
                   assert_equal %w|31 30 28 17 8 6 1 0|, changesets.collect(&:revision)
                   changesets = @repository.latest_changesets('README','8')
                   assert_equal %w|8 6 1 0|, changesets.collect(&:revision)
                   changesets = @repository.latest_changesets('README','8', 2)
                   assert_equal %w|8 6|, changesets.collect(&:revision)
                   # with_dirpath
                   changesets = @repository.latest_changesets('images', nil)
                   assert_equal %w|1 0|, changesets.collect(&:revision)
                   path = 'sql_escape/percent%dir'
                   changesets = @repository.latest_changesets(path, nil)
                   assert_equal %w|30 13 11 10 9|, changesets.collect(&:revision)
                   changesets = @repository.latest_changesets(path, '11')
                   assert_equal %w|11 10 9|, changesets.collect(&:revision)
                   changesets = @repository.latest_changesets(path, '11', 2)
                   assert_equal %w|11 10|, changesets.collect(&:revision)
                   path = 'sql_escape/underscore_dir'
                   changesets = @repository.latest_changesets(path, nil)
                   assert_equal %w|30 13 12 9|, changesets.collect(&:revision)
                   changesets = @repository.latest_changesets(path, '12')
                   assert_equal %w|12 9|, changesets.collect(&:revision)
                   changesets = @repository.latest_changesets(path, '12', 1)
                   assert_equal %w|12|, changesets.collect(&:revision)
                   # tag
                   changesets = @repository.latest_changesets('', 'tag_test.00')
                   assert_equal %w|5 4 3 2 1 0|, changesets.collect(&:revision)
                   changesets = @repository.latest_changesets('', 'tag_test.00', 2)
                   assert_equal %w|5 4|, changesets.collect(&:revision)
                   changesets = @repository.latest_changesets('sources', 'tag_test.00')
                   assert_equal %w|4 3 2 1 0|, changesets.collect(&:revision)
                   changesets = @repository.latest_changesets('sources', 'tag_test.00', 2)
                   assert_equal %w|4 3|, changesets.collect(&:revision)
                   # named branch
                   if @repository.scm.class.client_version_above?([1, 6])
                     changesets = @repository.latest_changesets('', @branch_char_1)
                     assert_equal %w|27 26|, changesets.collect(&:revision)
                   end
                   changesets = @repository.latest_changesets("latin-1-dir/test-#{@char_1}-subdir", @branch_char_1)
                   assert_equal %w|27|, changesets.collect(&:revision)
                 end
                 def test_copied_files
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   cs1 = @repository.changesets.find_by_revision('13')
                   assert_not_nil cs1
                   c1  = cs1.filechanges.sort_by(&:path)
                   assert_equal 2, c1.size
                   assert_equal 'A', c1[0].action
                   assert_equal '/sql_escape/percent%dir/percentfile1.txt',  c1[0].path
                   assert_equal '/sql_escape/percent%dir/percent%file1.txt', c1[0].from_path
                   assert_equal '3a330eb32958', c1[0].from_revision
                   assert_equal 'A', c1[1].action
                   assert_equal '/sql_escape/underscore_dir/understrike-file.txt', c1[1].path
                   assert_equal '/sql_escape/underscore_dir/understrike_file.txt', c1[1].from_path
                   cs2 = @repository.changesets.find_by_revision('15')
                   c2  = cs2.filechanges
                   assert_equal 1, c2.size
                   assert_equal 'A', c2[0].action
                   assert_equal '/README (1)[2]&,%.-3_4', c2[0].path
                   assert_equal '/README', c2[0].from_path
                   assert_equal '933ca60293d7', c2[0].from_revision
                   cs3 = @repository.changesets.find_by_revision('19')
                   c3  = cs3.filechanges
                   assert_equal 1, c3.size
                   assert_equal 'A', c3[0].action
                   assert_equal "/latin-1-dir/test-#{@char_1}-1.txt",  c3[0].path
                   assert_equal "/latin-1-dir/test-#{@char_1}.txt",    c3[0].from_path
                   assert_equal '5d9891a1b425', c3[0].from_revision
                 end
                 def test_find_changeset_by_name
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   %w|2 400bb8672109 400|.each do |r|
                     assert_equal '2', @repository.find_changeset_by_name(r).revision
                   end
                 end
                 def test_find_changeset_by_invalid_name
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   assert_nil @repository.find_changeset_by_name('100000')
                 end
                 def test_identifier
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   c = @repository.changesets.find_by_revision('2')
                   assert_equal c.scmid, c.identifier
                 end
                 def test_format_identifier
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   c = @repository.changesets.find_by_revision('2')
                   assert_equal '2:400bb8672109', c.format_identifier
                 end
                 def test_find_changeset_by_empty_name
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   ['', ' ', nil].each do |r|
                     assert_nil @repository.find_changeset_by_name(r)
                   end
                 end
                 def test_parents
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   r1 = @repository.changesets.find_by_revision('0')
                   assert_equal [], r1.parents
                   r2 = @repository.changesets.find_by_revision('1')
                   assert_equal 1, r2.parents.length
                   assert_equal "0885933ad4f6",
                                r2.parents[0].identifier
                   r3 = @repository.changesets.find_by_revision('30')
                   assert_equal 2, r3.parents.length
                   r4 = [r3.parents[0].identifier, r3.parents[1].identifier].sort
                   assert_equal "3a330eb32958", r4[0]
                   assert_equal "a94b0528f24f", r4[1]
                 end
                 def test_activities
                   c = Changeset.new(:repository   => @repository,
                                     :committed_on => Time.now,
                                     :revision     => '123',
                                     :scmid        => 'abc400bb8672',
                                     :comments     => 'test')
                   assert c.event_title.include?('123:abc400bb8672:')
                   assert_equal 'abc400bb8672', c.event_url[:rev]
                 end
                 def test_previous
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   %w|28 3ae45e2d177d 3ae45|.each do |r1|
                     changeset = @repository.find_changeset_by_name(r1)
                     %w|27 7bbf4c738e71 7bbf|.each do |r2|
                       assert_equal @repository.find_changeset_by_name(r2), changeset.previous
                     end
                   end
                 end
                 def test_previous_nil
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   %w|0 0885933ad4f6 0885|.each do |r1|
                     changeset = @repository.find_changeset_by_name(r1)
                     assert_nil changeset.previous
                   end
                 end
                 def test_next
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   %w|27 7bbf4c738e71 7bbf|.each do |r2|
                     changeset = @repository.find_changeset_by_name(r2)
                     %w|28 3ae45e2d177d 3ae45|.each do |r1|
                     assert_equal @repository.find_changeset_by_name(r1), changeset.next
                     end
                   end
                 end
                 def test_next_nil
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   %w|31 31eeee7395c8 31eee|.each do |r1|
                     changeset = @repository.find_changeset_by_name(r1)
                     assert_nil changeset.next
                   end
                 end
               else
                 puts "Mercurial test repository NOT FOUND. Skipping unit tests !!!"
                 def test_fake; assert true end
               end
             end

test/unit/repository_subversion_test.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class RepositorySubversionTest < ActiveSupport::TestCase
               fixtures :projects, :repositories, :enabled_modules, :users, :roles
               NUM_REV = 11
               def setup
                 @project = Project.find(3)
                 @repository = Repository::Subversion.create(:project => @project,
                          :url => self.class.subversion_repository_url)
                 assert @repository
               end
               if repository_configured?('subversion')
                 def test_fetch_changesets_from_scratch
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   assert_equal 20, @repository.filechanges.count
                   assert_equal 'Initial import.', @repository.changesets.find_by_revision('1').comments
                 end
                 def test_fetch_changesets_incremental
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   # Remove changesets with revision > 5
-                  @repository.changesets.find(:all).each {|c| c.destroy if c.revision.to_i > 5}
+                  @repository.changesets.all.each {|c| c.destroy if c.revision.to_i > 5}
                   @project.reload
                   assert_equal 5, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                 end
                 def test_entries
                   entries = @repository.entries
                   assert_kind_of Redmine::Scm::Adapters::Entries, entries
                 end
                 def test_entries_for_invalid_path_should_return_nil
                   entries = @repository.entries('invalid_path')
                   assert_nil entries
                 end
                 def test_latest_changesets
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   # with limit
                   changesets = @repository.latest_changesets('', nil, 2)
                   assert_equal 2, changesets.size
                   assert_equal @repository.latest_changesets('', nil).slice(0,2), changesets
                   # with path
                   changesets = @repository.latest_changesets('subversion_test/folder', nil)
                   assert_equal ["10", "9", "7", "6", "5", "2"], changesets.collect(&:revision)
                   # with path and revision
                   changesets = @repository.latest_changesets('subversion_test/folder', 8)
                   assert_equal ["7", "6", "5", "2"], changesets.collect(&:revision)
                 end
                 def test_directory_listing_with_square_brackets_in_path
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   entries = @repository.entries('subversion_test/[folder_with_brackets]')
                   assert_not_nil entries, 'Expect to find entries in folder_with_brackets'
                   assert_equal 1, entries.size, 'Expect one entry in folder_with_brackets'
                   assert_equal 'README.txt', entries.first.name
                 end
                 def test_directory_listing_with_square_brackets_in_base
                   @project = Project.find(3)
                   @repository = Repository::Subversion.create(
                                       :project => @project,
                                       :url => "file:///#{self.class.repository_path('subversion')}/subversion_test/[folder_with_brackets]")
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal 1, @repository.changesets.count, 'Expected to see 1 revision'
                   assert_equal 2, @repository.filechanges.count, 'Expected to see 2 changes, dir add and file add'
                   entries = @repository.entries('')
                   assert_not_nil entries, 'Expect to find entries'
                   assert_equal 1, entries.size, 'Expect a single entry'
                   assert_equal 'README.txt', entries.first.name
                 end
                 def test_identifier
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   c = @repository.changesets.find_by_revision('1')
                   assert_equal c.revision, c.identifier
                 end
                 def test_find_changeset_by_empty_name
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   ['', ' ', nil].each do |r|
                     assert_nil @repository.find_changeset_by_name(r)
                   end
                 end
                 def test_identifier_nine_digit
                   c = Changeset.new(:repository => @repository, :committed_on => Time.now,
                                     :revision => '123456789', :comments => 'test')
                   assert_equal c.identifier, c.revision
                 end
                 def test_format_identifier
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   c = @repository.changesets.find_by_revision('1')
                   assert_equal c.format_identifier, c.revision
                 end
                 def test_format_identifier_nine_digit
                   c = Changeset.new(:repository => @repository, :committed_on => Time.now,
                                     :revision => '123456789', :comments => 'test')
                   assert_equal c.format_identifier, c.revision
                 end
                 def test_activities
                   c = Changeset.new(:repository => @repository, :committed_on => Time.now,
                                     :revision => '1', :comments => 'test')
                   assert c.event_title.include?('1:')
                   assert_equal '1', c.event_url[:rev]
                 end
                 def test_activities_nine_digit
                   c = Changeset.new(:repository => @repository, :committed_on => Time.now,
                                     :revision => '123456789', :comments => 'test')
                   assert c.event_title.include?('123456789:')
                   assert_equal '123456789', c.event_url[:rev]
                 end
                 def test_log_encoding_ignore_setting
                   with_settings :commit_logs_encoding => 'windows-1252' do
                     s1 = "\xC2\x80"
                     s2 = "\xc3\x82\xc2\x80"
                     if s1.respond_to?(:force_encoding)
                       s1.force_encoding('ISO-8859-1')
                       s2.force_encoding('UTF-8')
                       assert_equal s1.encode('UTF-8'), s2
                     end
                     c = Changeset.new(:repository => @repository,
                                       :comments   => s2,
                                       :revision   => '123',
                                       :committed_on => Time.now)
                     assert c.save
                     assert_equal s2, c.comments
                   end
                 end
                 def test_previous
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   changeset = @repository.find_changeset_by_name('3')
                   assert_equal @repository.find_changeset_by_name('2'), changeset.previous
                 end
                 def test_previous_nil
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   changeset = @repository.find_changeset_by_name('1')
                   assert_nil changeset.previous
                 end
                 def test_next
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   changeset = @repository.find_changeset_by_name('2')
                   assert_equal @repository.find_changeset_by_name('3'), changeset.next
                 end
                 def test_next_nil
                   assert_equal 0, @repository.changesets.count
                   @repository.fetch_changesets
                   @project.reload
                   assert_equal NUM_REV, @repository.changesets.count
                   changeset = @repository.find_changeset_by_name('11')
                   assert_nil changeset.next
                 end
               else
                 puts "Subversion test repository NOT FOUND. Skipping unit tests !!!"
                 def test_fake; assert true end
               end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages