jro_apps/redmine Commit - r8857:528735b955ab

Use subclasses method instead of class variable....

Jean-Philippe Lang -

r8857:528735b955ab

parent child

Context file:

r8857:528735b955ab

Collapse all files

app/models/enumeration.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2011  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class Enumeration < ActiveRecord::Base
               include Redmine::SubclassFactory
               default_scope :order => "#{Enumeration.table_name}.position ASC"
               belongs_to :project
               acts_as_list :scope => 'type = \'#{type}\''
               acts_as_customizable
               acts_as_tree :order => 'position ASC'
               before_destroy :check_integrity
               before_save    :check_default
               attr_protected :type
               validates_presence_of :name
               validates_uniqueness_of :name, :scope => [:type, :project_id]
               validates_length_of :name, :maximum => 30
               named_scope :shared, :conditions => { :project_id => nil }
               named_scope :active, :conditions => { :active => true }
               named_scope :named, lambda {|arg| { :conditions => ["LOWER(#{table_name}.name) = LOWER(?)", arg.to_s.strip]}}
               def self.default
                 # Creates a fake default scope so Enumeration.default will check
                 # it's type.  STI subclasses will automatically add their own
                 # types to the finder.
                 if self.descends_from_active_record?
                   find(:first, :conditions => { :is_default => true, :type => 'Enumeration' })
                 else
                   # STI classes are
                   find(:first, :conditions => { :is_default => true })
                 end
               end
               # Overloaded on concrete classes
               def option_name
                 nil
               end
               def check_default
                 if is_default? && is_default_changed?
                   Enumeration.update_all("is_default = #{connection.quoted_false}", {:type => type})
                 end
               end
               # Overloaded on concrete classes
               def objects_count
               end
               def in_use?
                 self.objects_count != 0
               end
               # Is this enumeration overiding a system level enumeration?
               def is_override?
                 !self.parent.nil?
               end
               alias :destroy_without_reassign :destroy
               # Destroy the enumeration
               # If a enumeration is specified, objects are reassigned
               def destroy(reassign_to = nil)
                 if reassign_to && reassign_to.is_a?(Enumeration)
                   self.transfer_relations(reassign_to)
                 end
                 destroy_without_reassign
               end
               def <=>(enumeration)
                 position <=> enumeration.position
               end
               def to_s; name end
               # Returns the Subclasses of Enumeration.  Each Subclass needs to be
               # required in development mode.
               #
               # Note: subclasses is protected in ActiveRecord
               def self.get_subclasses
-                @@subclasses[Enumeration]
+                subclasses
               end
               # Does the +new+ Hash override the previous Enumeration?
               def self.overridding_change?(new, previous)
                 if (same_active_state?(new['active'], previous.active)) && same_custom_values?(new,previous)
                   return false
                 else
                   return true
                 end
               end
               # Does the +new+ Hash have the same custom values as the previous Enumeration?
               def self.same_custom_values?(new, previous)
                 previous.custom_field_values.each do |custom_value|
                   if custom_value.value != new["custom_field_values"][custom_value.custom_field_id.to_s]
                     return false
                   end
                 end
                 return true
               end
               # Are the new and previous fields equal?
               def self.same_active_state?(new, previous)
                 new = (new == "1" ? true : false)
                 return new == previous
               end
             private
               def check_integrity
                 raise "Can't delete enumeration" if self.in_use?
               end
             end
             # Force load the subclasses in development mode
             require_dependency 'time_entry_activity'
             require_dependency 'document_category'
             require_dependency 'issue_priority'

test/unit/enumeration_test.rb +11 0

             # Redmine - project management software
             # Copyright (C) 2006-2008  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class EnumerationTest < ActiveSupport::TestCase
               fixtures :enumerations, :issues, :custom_fields, :custom_values
               def setup
               end
               def test_objects_count
                 # low priority
                 assert_equal 6, Enumeration.find(4).objects_count
                 # urgent
                 assert_equal 0, Enumeration.find(7).objects_count
               end
               def test_in_use
                 # low priority
                 assert Enumeration.find(4).in_use?
                 # urgent
                 assert !Enumeration.find(7).in_use?
               end
               def test_default
                 e = Enumeration.default
                 assert e.is_a?(Enumeration)
                 assert e.is_default?
                 assert_equal 'Default Enumeration', e.name
               end
               def test_create
                 e = Enumeration.new(:name => 'Not default', :is_default => false)
                 e.type = 'Enumeration'
                 assert e.save
                 assert_equal 'Default Enumeration', Enumeration.default.name
               end
               def test_create_as_default
                 e = Enumeration.new(:name => 'Very urgent', :is_default => true)
                 e.type = 'Enumeration'
                 assert e.save
                 assert_equal e, Enumeration.default
               end
               def test_update_default
                 e = Enumeration.default
                 e.update_attributes(:name => 'Changed', :is_default => true)
                 assert_equal e, Enumeration.default
               end
               def test_update_default_to_non_default
                 e = Enumeration.default
                 e.update_attributes(:name => 'Changed', :is_default => false)
                 assert_nil Enumeration.default
               end
               def test_change_default
                 e = Enumeration.find_by_name('Default Enumeration')
                 e.update_attributes(:name => 'Changed Enumeration', :is_default => true)
                 assert_equal e, Enumeration.default
               end
               def test_destroy_with_reassign
                 Enumeration.find(4).destroy(Enumeration.find(6))
                 assert_nil Issue.find(:first, :conditions => {:priority_id => 4})
                 assert_equal 6, Enumeration.find(6).objects_count
               end
               def test_should_be_customizable
                 assert Enumeration.included_modules.include?(Redmine::Acts::Customizable::InstanceMethods)
               end
               def test_should_belong_to_a_project
                 association = Enumeration.reflect_on_association(:project)
                 assert association, "No Project association found"
                 assert_equal :belongs_to, association.macro
               end
               def test_should_act_as_tree
                 enumeration = Enumeration.find(4)
                 assert enumeration.respond_to?(:parent)
                 assert enumeration.respond_to?(:children)
               end
               def test_is_override
                 # Defaults to off
                 enumeration = Enumeration.find(4)
                 assert !enumeration.is_override?
                 # Setup as an override
                 enumeration.parent = Enumeration.find(5)
                 assert enumeration.is_override?
               end
+              def test_get_subclasses
+                classes = Enumeration.get_subclasses
+                assert_include IssuePriority, classes
+                assert_include DocumentCategory, classes
+                assert_include TimeEntryActivity, classes
+                classes.each do |klass|
+                  assert_equal Enumeration, klass.superclass
+                end
+              end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages