##// END OF EJS Templates
jro_apps » redmine
RSS
Fixed test failure with SQLServer introduced by r13461....
Jean-Philippe Lang -
r13086:51508f67d0cc
parent child
Show More
Side by Side Unified
Context file:
r13086:51508f67d0cc Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,1571 +1,1572
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2014 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class Issue < ActiveRecord::Base
19 19 include Redmine::SafeAttributes
20 20 include Redmine::Utils::DateCalculation
21 21 include Redmine::I18n
22 22
23 23 belongs_to :project
24 24 belongs_to :tracker
25 25 belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
26 26 belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
27 27 belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
28 28 belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
29 29 belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
30 30 belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
31 31
32 32 has_many :journals, :as => :journalized, :dependent => :destroy
33 33 has_many :visible_journals,
34 34 :class_name => 'Journal',
35 35 :as => :journalized,
36 36 :conditions => Proc.new {
37 37 ["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false]
38 38 },
39 39 :readonly => true
40 40
41 41 has_many :time_entries, :dependent => :destroy
42 42 has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
43 43
44 44 has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
45 45 has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
46 46
47 47 acts_as_nested_set :scope => 'root_id', :dependent => :destroy
48 48 acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
49 49 acts_as_customizable
50 50 acts_as_watchable
51 51 acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
52 52 :include => [:project, :visible_journals],
53 53 # sort by id so that limited eager loading doesn't break with postgresql
54 54 :order_column => "#{table_name}.id"
55 55 acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
56 56 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
57 57 :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
58 58
59 59 acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
60 60 :author_key => :author_id
61 61
62 62 DONE_RATIO_OPTIONS = %w(issue_field issue_status)
63 63
64 64 attr_reader :current_journal
65 65 delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true
66 66
67 67 validates_presence_of :subject, :priority, :project, :tracker, :author, :status
68 68
69 69 validates_length_of :subject, :maximum => 255
70 70 validates_inclusion_of :done_ratio, :in => 0..100
71 71 validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}
72 72 validates :start_date, :date => true
73 73 validates :due_date, :date => true
74 74 validate :validate_issue, :validate_required_fields
75 75
76 76 scope :visible, lambda {|*args|
77 77 includes(:project).where(Issue.visible_condition(args.shift || User.current, *args))
78 78 }
79 79
80 80 scope :open, lambda {|*args|
81 81 is_closed = args.size > 0 ? !args.first : false
82 82 includes(:status).where("#{IssueStatus.table_name}.is_closed = ?", is_closed)
83 83 }
84 84
85 85 scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }
86 86 scope :on_active_project, lambda {
87 87 includes(:status, :project, :tracker).where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)
88 88 }
89 89 scope :fixed_version, lambda {|versions|
90 90 ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}
91 91 ids.any? ? where(:fixed_version_id => ids) : where('1=0')
92 92 }
93 93
94 94 before_create :default_assign
95 95 before_save :close_duplicates, :update_done_ratio_from_issue_status,
96 96 :force_updated_on_change, :update_closed_on, :set_assigned_to_was
97 97 after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
98 98 after_save :reschedule_following_issues, :update_nested_set_attributes,
99 99 :update_parent_attributes, :create_journal
100 100 # Should be after_create but would be called before previous after_save callbacks
101 101 after_save :after_create_from_copy
102 102 after_destroy :update_parent_attributes
103 103 after_create :send_notification
104 104 # Keep it at the end of after_save callbacks
105 105 after_save :clear_assigned_to_was
106 106
107 107 # Returns a SQL conditions string used to find all issues visible by the specified user
108 108 def self.visible_condition(user, options={})
109 109 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
110 110 if user.logged?
111 111 case role.issues_visibility
112 112 when 'all'
113 113 nil
114 114 when 'default'
115 115 user_ids = [user.id] + user.groups.map(&:id).compact
116 116 "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
117 117 when 'own'
118 118 user_ids = [user.id] + user.groups.map(&:id).compact
119 119 "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
120 120 else
121 121 '1=0'
122 122 end
123 123 else
124 124 "(#{table_name}.is_private = #{connection.quoted_false})"
125 125 end
126 126 end
127 127 end
128 128
129 129 # Returns true if usr or current user is allowed to view the issue
130 130 def visible?(usr=nil)
131 131 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
132 132 if user.logged?
133 133 case role.issues_visibility
134 134 when 'all'
135 135 true
136 136 when 'default'
137 137 !self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))
138 138 when 'own'
139 139 self.author == user || user.is_or_belongs_to?(assigned_to)
140 140 else
141 141 false
142 142 end
143 143 else
144 144 !self.is_private?
145 145 end
146 146 end
147 147 end
148 148
149 149 # Returns true if user or current user is allowed to edit or add a note to the issue
150 150 def editable?(user=User.current)
151 151 user.allowed_to?(:edit_issues, project) || user.allowed_to?(:add_issue_notes, project)
152 152 end
153 153
154 154 def initialize(attributes=nil, *args)
155 155 super
156 156 if new_record?
157 157 # set default values for new records only
158 158 self.status ||= IssueStatus.default
159 159 self.priority ||= IssuePriority.default
160 160 self.watcher_user_ids = []
161 161 end
162 162 end
163 163
164 164 def create_or_update
165 165 super
166 166 ensure
167 167 @status_was = nil
168 168 end
169 169 private :create_or_update
170 170
171 171 # AR#Persistence#destroy would raise and RecordNotFound exception
172 172 # if the issue was already deleted or updated (non matching lock_version).
173 173 # This is a problem when bulk deleting issues or deleting a project
174 174 # (because an issue may already be deleted if its parent was deleted
175 175 # first).
176 176 # The issue is reloaded by the nested_set before being deleted so
177 177 # the lock_version condition should not be an issue but we handle it.
178 178 def destroy
179 179 super
180 180 rescue ActiveRecord::RecordNotFound
181 181 # Stale or already deleted
182 182 begin
183 183 reload
184 184 rescue ActiveRecord::RecordNotFound
185 185 # The issue was actually already deleted
186 186 @destroyed = true
187 187 return freeze
188 188 end
189 189 # The issue was stale, retry to destroy
190 190 super
191 191 end
192 192
193 193 alias :base_reload :reload
194 194 def reload(*args)
195 195 @workflow_rule_by_attribute = nil
196 196 @assignable_versions = nil
197 197 @relations = nil
198 198 base_reload(*args)
199 199 end
200 200
201 201 # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
202 202 def available_custom_fields
203 203 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields) : []
204 204 end
205 205
206 206 def visible_custom_field_values(user=nil)
207 207 user_real = user || User.current
208 208 custom_field_values.select do |value|
209 209 value.custom_field.visible_by?(project, user_real)
210 210 end
211 211 end
212 212
213 213 # Copies attributes from another issue, arg can be an id or an Issue
214 214 def copy_from(arg, options={})
215 215 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
216 216 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
217 217 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
218 218 self.status = issue.status
219 219 self.author = User.current
220 220 unless options[:attachments] == false
221 221 self.attachments = issue.attachments.map do |attachement|
222 222 attachement.copy(:container => self)
223 223 end
224 224 end
225 225 @copied_from = issue
226 226 @copy_options = options
227 227 self
228 228 end
229 229
230 230 # Returns an unsaved copy of the issue
231 231 def copy(attributes=nil, copy_options={})
232 232 copy = self.class.new.copy_from(self, copy_options)
233 233 copy.attributes = attributes if attributes
234 234 copy
235 235 end
236 236
237 237 # Returns true if the issue is a copy
238 238 def copy?
239 239 @copied_from.present?
240 240 end
241 241
242 242 # Moves/copies an issue to a new project and tracker
243 243 # Returns the moved/copied issue on success, false on failure
244 244 def move_to_project(new_project, new_tracker=nil, options={})
245 245 ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."
246 246
247 247 if options[:copy]
248 248 issue = self.copy
249 249 else
250 250 issue = self
251 251 end
252 252
253 253 issue.init_journal(User.current, options[:notes])
254 254
255 255 # Preserve previous behaviour
256 256 # #move_to_project doesn't change tracker automatically
257 257 issue.send :project=, new_project, true
258 258 if new_tracker
259 259 issue.tracker = new_tracker
260 260 end
261 261 # Allow bulk setting of attributes on the issue
262 262 if options[:attributes]
263 263 issue.attributes = options[:attributes]
264 264 end
265 265
266 266 issue.save ? issue : false
267 267 end
268 268
269 269 def status_id=(sid)
270 270 self.status = nil
271 271 result = write_attribute(:status_id, sid)
272 272 @workflow_rule_by_attribute = nil
273 273 result
274 274 end
275 275
276 276 def priority_id=(pid)
277 277 self.priority = nil
278 278 write_attribute(:priority_id, pid)
279 279 end
280 280
281 281 def category_id=(cid)
282 282 self.category = nil
283 283 write_attribute(:category_id, cid)
284 284 end
285 285
286 286 def fixed_version_id=(vid)
287 287 self.fixed_version = nil
288 288 write_attribute(:fixed_version_id, vid)
289 289 end
290 290
291 291 def tracker_id=(tid)
292 292 self.tracker = nil
293 293 result = write_attribute(:tracker_id, tid)
294 294 @custom_field_values = nil
295 295 @workflow_rule_by_attribute = nil
296 296 result
297 297 end
298 298
299 299 def project_id=(project_id)
300 300 if project_id.to_s != self.project_id.to_s
301 301 self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
302 302 end
303 303 end
304 304
305 305 def project=(project, keep_tracker=false)
306 306 project_was = self.project
307 307 write_attribute(:project_id, project ? project.id : nil)
308 308 association_instance_set('project', project)
309 309 if project_was && project && project_was != project
310 310 @assignable_versions = nil
311 311
312 312 unless keep_tracker || project.trackers.include?(tracker)
313 313 self.tracker = project.trackers.first
314 314 end
315 315 # Reassign to the category with same name if any
316 316 if category
317 317 self.category = project.issue_categories.find_by_name(category.name)
318 318 end
319 319 # Keep the fixed_version if it's still valid in the new_project
320 320 if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
321 321 self.fixed_version = nil
322 322 end
323 323 # Clear the parent task if it's no longer valid
324 324 unless valid_parent_project?
325 325 self.parent_issue_id = nil
326 326 end
327 327 @custom_field_values = nil
328 328 end
329 329 end
330 330
331 331 def description=(arg)
332 332 if arg.is_a?(String)
333 333 arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
334 334 end
335 335 write_attribute(:description, arg)
336 336 end
337 337
338 338 # Overrides assign_attributes so that project and tracker get assigned first
339 339 def assign_attributes_with_project_and_tracker_first(new_attributes, *args)
340 340 return if new_attributes.nil?
341 341 attrs = new_attributes.dup
342 342 attrs.stringify_keys!
343 343
344 344 %w(project project_id tracker tracker_id).each do |attr|
345 345 if attrs.has_key?(attr)
346 346 send "#{attr}=", attrs.delete(attr)
347 347 end
348 348 end
349 349 send :assign_attributes_without_project_and_tracker_first, attrs, *args
350 350 end
351 351 # Do not redefine alias chain on reload (see #4838)
352 352 alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)
353 353
354 354 def estimated_hours=(h)
355 355 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
356 356 end
357 357
358 358 safe_attributes 'project_id',
359 359 :if => lambda {|issue, user|
360 360 if issue.new_record?
361 361 issue.copy?
362 362 elsif user.allowed_to?(:move_issues, issue.project)
363 363 Issue.allowed_target_projects_on_move.count > 1
364 364 end
365 365 }
366 366
367 367 safe_attributes 'tracker_id',
368 368 'status_id',
369 369 'category_id',
370 370 'assigned_to_id',
371 371 'priority_id',
372 372 'fixed_version_id',
373 373 'subject',
374 374 'description',
375 375 'start_date',
376 376 'due_date',
377 377 'done_ratio',
378 378 'estimated_hours',
379 379 'custom_field_values',
380 380 'custom_fields',
381 381 'lock_version',
382 382 'notes',
383 383 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
384 384
385 385 safe_attributes 'status_id',
386 386 'assigned_to_id',
387 387 'fixed_version_id',
388 388 'done_ratio',
389 389 'lock_version',
390 390 'notes',
391 391 :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
392 392
393 393 safe_attributes 'notes',
394 394 :if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}
395 395
396 396 safe_attributes 'private_notes',
397 397 :if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}
398 398
399 399 safe_attributes 'watcher_user_ids',
400 400 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
401 401
402 402 safe_attributes 'is_private',
403 403 :if => lambda {|issue, user|
404 404 user.allowed_to?(:set_issues_private, issue.project) ||
405 405 (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
406 406 }
407 407
408 408 safe_attributes 'parent_issue_id',
409 409 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
410 410 user.allowed_to?(:manage_subtasks, issue.project)}
411 411
412 412 def safe_attribute_names(user=nil)
413 413 names = super
414 414 names -= disabled_core_fields
415 415 names -= read_only_attribute_names(user)
416 416 names
417 417 end
418 418
419 419 # Safely sets attributes
420 420 # Should be called from controllers instead of #attributes=
421 421 # attr_accessible is too rough because we still want things like
422 422 # Issue.new(:project => foo) to work
423 423 def safe_attributes=(attrs, user=User.current)
424 424 return unless attrs.is_a?(Hash)
425 425
426 426 attrs = attrs.dup
427 427
428 428 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
429 429 if (p = attrs.delete('project_id')) && safe_attribute?('project_id')
430 430 if allowed_target_projects(user).where(:id => p.to_i).exists?
431 431 self.project_id = p
432 432 end
433 433 end
434 434
435 435 if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')
436 436 self.tracker_id = t
437 437 end
438 438
439 439 if (s = attrs.delete('status_id')) && safe_attribute?('status_id')
440 440 if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)
441 441 self.status_id = s
442 442 end
443 443 end
444 444
445 445 attrs = delete_unsafe_attributes(attrs, user)
446 446 return if attrs.empty?
447 447
448 448 unless leaf?
449 449 attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
450 450 end
451 451
452 452 if attrs['parent_issue_id'].present?
453 453 s = attrs['parent_issue_id'].to_s
454 454 unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))
455 455 @invalid_parent_issue_id = attrs.delete('parent_issue_id')
456 456 end
457 457 end
458 458
459 459 if attrs['custom_field_values'].present?
460 460 editable_custom_field_ids = editable_custom_field_values(user).map {|v| v.custom_field_id.to_s}
461 461 # TODO: use #select when ruby1.8 support is dropped
462 462 attrs['custom_field_values'] = attrs['custom_field_values'].reject {|k, v| !editable_custom_field_ids.include?(k.to_s)}
463 463 end
464 464
465 465 if attrs['custom_fields'].present?
466 466 editable_custom_field_ids = editable_custom_field_values(user).map {|v| v.custom_field_id.to_s}
467 467 # TODO: use #select when ruby1.8 support is dropped
468 468 attrs['custom_fields'] = attrs['custom_fields'].reject {|c| !editable_custom_field_ids.include?(c['id'].to_s)}
469 469 end
470 470
471 471 # mass-assignment security bypass
472 472 assign_attributes attrs, :without_protection => true
473 473 end
474 474
475 475 def disabled_core_fields
476 476 tracker ? tracker.disabled_core_fields : []
477 477 end
478 478
479 479 # Returns the custom_field_values that can be edited by the given user
480 480 def editable_custom_field_values(user=nil)
481 481 visible_custom_field_values(user).reject do |value|
482 482 read_only_attribute_names(user).include?(value.custom_field_id.to_s)
483 483 end
484 484 end
485 485
486 486 # Returns the custom fields that can be edited by the given user
487 487 def editable_custom_fields(user=nil)
488 488 editable_custom_field_values(user).map(&:custom_field).uniq
489 489 end
490 490
491 491 # Returns the names of attributes that are read-only for user or the current user
492 492 # For users with multiple roles, the read-only fields are the intersection of
493 493 # read-only fields of each role
494 494 # The result is an array of strings where sustom fields are represented with their ids
495 495 #
496 496 # Examples:
497 497 # issue.read_only_attribute_names # => ['due_date', '2']
498 498 # issue.read_only_attribute_names(user) # => []
499 499 def read_only_attribute_names(user=nil)
500 500 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys
501 501 end
502 502
503 503 # Returns the names of required attributes for user or the current user
504 504 # For users with multiple roles, the required fields are the intersection of
505 505 # required fields of each role
506 506 # The result is an array of strings where sustom fields are represented with their ids
507 507 #
508 508 # Examples:
509 509 # issue.required_attribute_names # => ['due_date', '2']
510 510 # issue.required_attribute_names(user) # => []
511 511 def required_attribute_names(user=nil)
512 512 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys
513 513 end
514 514
515 515 # Returns true if the attribute is required for user
516 516 def required_attribute?(name, user=nil)
517 517 required_attribute_names(user).include?(name.to_s)
518 518 end
519 519
520 520 # Returns a hash of the workflow rule by attribute for the given user
521 521 #
522 522 # Examples:
523 523 # issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}
524 524 def workflow_rule_by_attribute(user=nil)
525 525 return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?
526 526
527 527 user_real = user || User.current
528 528 roles = user_real.admin ? Role.all : user_real.roles_for_project(project)
529 529 return {} if roles.empty?
530 530
531 531 result = {}
532 532 workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id))
533 533 if workflow_permissions.any?
534 534 workflow_rules = workflow_permissions.inject({}) do |h, wp|
535 535 h[wp.field_name] ||= []
536 536 h[wp.field_name] << wp.rule
537 537 h
538 538 end
539 539 workflow_rules.each do |attr, rules|
540 540 next if rules.size < roles.size
541 541 uniq_rules = rules.uniq
542 542 if uniq_rules.size == 1
543 543 result[attr] = uniq_rules.first
544 544 else
545 545 result[attr] = 'required'
546 546 end
547 547 end
548 548 end
549 549 @workflow_rule_by_attribute = result if user.nil?
550 550 result
551 551 end
552 552 private :workflow_rule_by_attribute
553 553
554 554 def done_ratio
555 555 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
556 556 status.default_done_ratio
557 557 else
558 558 read_attribute(:done_ratio)
559 559 end
560 560 end
561 561
562 562 def self.use_status_for_done_ratio?
563 563 Setting.issue_done_ratio == 'issue_status'
564 564 end
565 565
566 566 def self.use_field_for_done_ratio?
567 567 Setting.issue_done_ratio == 'issue_field'
568 568 end
569 569
570 570 def validate_issue
571 571 if due_date && start_date && (start_date_changed? || due_date_changed?) && due_date < start_date
572 572 errors.add :due_date, :greater_than_start_date
573 573 end
574 574
575 575 if start_date && start_date_changed? && soonest_start && start_date < soonest_start
576 576 errors.add :start_date, :earlier_than_minimum_start_date, :date => format_date(soonest_start)
577 577 end
578 578
579 579 if fixed_version
580 580 if !assignable_versions.include?(fixed_version)
581 581 errors.add :fixed_version_id, :inclusion
582 582 elsif reopened? && fixed_version.closed?
583 583 errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
584 584 end
585 585 end
586 586
587 587 # Checks that the issue can not be added/moved to a disabled tracker
588 588 if project && (tracker_id_changed? || project_id_changed?)
589 589 unless project.trackers.include?(tracker)
590 590 errors.add :tracker_id, :inclusion
591 591 end
592 592 end
593 593
594 594 # Checks parent issue assignment
595 595 if @invalid_parent_issue_id.present?
596 596 errors.add :parent_issue_id, :invalid
597 597 elsif @parent_issue
598 598 if !valid_parent_project?(@parent_issue)
599 599 errors.add :parent_issue_id, :invalid
600 600 elsif (@parent_issue != parent) && (all_dependent_issues.include?(@parent_issue) || @parent_issue.all_dependent_issues.include?(self))
601 601 errors.add :parent_issue_id, :invalid
602 602 elsif !new_record?
603 603 # moving an existing issue
604 604 if @parent_issue.root_id != root_id
605 605 # we can always move to another tree
606 606 elsif move_possible?(@parent_issue)
607 607 # move accepted inside tree
608 608 else
609 609 errors.add :parent_issue_id, :invalid
610 610 end
611 611 end
612 612 end
613 613 end
614 614
615 615 # Validates the issue against additional workflow requirements
616 616 def validate_required_fields
617 617 user = new_record? ? author : current_journal.try(:user)
618 618
619 619 required_attribute_names(user).each do |attribute|
620 620 if attribute =~ /^\d+$/
621 621 attribute = attribute.to_i
622 622 v = custom_field_values.detect {|v| v.custom_field_id == attribute }
623 623 if v && v.value.blank?
624 624 errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')
625 625 end
626 626 else
627 627 if respond_to?(attribute) && send(attribute).blank?
628 628 errors.add attribute, :blank
629 629 end
630 630 end
631 631 end
632 632 end
633 633
634 634 # Set the done_ratio using the status if that setting is set. This will keep the done_ratios
635 635 # even if the user turns off the setting later
636 636 def update_done_ratio_from_issue_status
637 637 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
638 638 self.done_ratio = status.default_done_ratio
639 639 end
640 640 end
641 641
642 642 def init_journal(user, notes = "")
643 643 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
644 644 if new_record?
645 645 @current_journal.notify = false
646 646 else
647 647 @attributes_before_change = attributes.dup
648 648 @custom_values_before_change = {}
649 649 self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
650 650 end
651 651 @current_journal
652 652 end
653 653
654 654 # Returns the id of the last journal or nil
655 655 def last_journal_id
656 656 if new_record?
657 657 nil
658 658 else
659 659 journals.maximum(:id)
660 660 end
661 661 end
662 662
663 663 # Returns a scope for journals that have an id greater than journal_id
664 664 def journals_after(journal_id)
665 665 scope = journals.reorder("#{Journal.table_name}.id ASC")
666 666 if journal_id.present?
667 667 scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)
668 668 end
669 669 scope
670 670 end
671 671
672 672 # Returns the initial status of the issue
673 673 # Returns nil for a new issue
674 674 def status_was
675 675 if status_id_was && status_id_was.to_i > 0
676 676 @status_was ||= IssueStatus.find_by_id(status_id_was)
677 677 end
678 678 end
679 679
680 680 # Return true if the issue is closed, otherwise false
681 681 def closed?
682 682 self.status.is_closed?
683 683 end
684 684
685 685 # Return true if the issue is being reopened
686 686 def reopened?
687 687 if !new_record? && status_id_changed?
688 688 status_was = IssueStatus.find_by_id(status_id_was)
689 689 status_new = IssueStatus.find_by_id(status_id)
690 690 if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
691 691 return true
692 692 end
693 693 end
694 694 false
695 695 end
696 696
697 697 # Return true if the issue is being closed
698 698 def closing?
699 699 if !new_record? && status_id_changed?
700 700 if status_was && status && !status_was.is_closed? && status.is_closed?
701 701 return true
702 702 end
703 703 end
704 704 false
705 705 end
706 706
707 707 # Returns true if the issue is overdue
708 708 def overdue?
709 709 !due_date.nil? && (due_date < Date.today) && !status.is_closed?
710 710 end
711 711
712 712 # Is the amount of work done less than it should for the due date
713 713 def behind_schedule?
714 714 return false if start_date.nil? || due_date.nil?
715 715 done_date = start_date + ((due_date - start_date + 1) * done_ratio / 100).floor
716 716 return done_date <= Date.today
717 717 end
718 718
719 719 # Does this issue have children?
720 720 def children?
721 721 !leaf?
722 722 end
723 723
724 724 # Users the issue can be assigned to
725 725 def assignable_users
726 726 users = project.assignable_users
727 727 users << author if author
728 728 users << assigned_to if assigned_to
729 729 users.uniq.sort
730 730 end
731 731
732 732 # Versions that the issue can be assigned to
733 733 def assignable_versions
734 734 return @assignable_versions if @assignable_versions
735 735
736 736 versions = project.shared_versions.open.all
737 737 if fixed_version
738 738 if fixed_version_id_changed?
739 739 # nothing to do
740 740 elsif project_id_changed?
741 741 if project.shared_versions.include?(fixed_version)
742 742 versions << fixed_version
743 743 end
744 744 else
745 745 versions << fixed_version
746 746 end
747 747 end
748 748 @assignable_versions = versions.uniq.sort
749 749 end
750 750
751 751 # Returns true if this issue is blocked by another issue that is still open
752 752 def blocked?
753 753 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
754 754 end
755 755
756 756 # Returns an array of statuses that user is able to apply
757 757 def new_statuses_allowed_to(user=User.current, include_default=false)
758 758 if new_record? && @copied_from
759 759 [IssueStatus.default, @copied_from.status].compact.uniq.sort
760 760 else
761 761 initial_status = nil
762 762 if new_record?
763 763 initial_status = IssueStatus.default
764 764 elsif status_id_was
765 765 initial_status = IssueStatus.find_by_id(status_id_was)
766 766 end
767 767 initial_status ||= status
768 768
769 769 initial_assigned_to_id = assigned_to_id_changed? ? assigned_to_id_was : assigned_to_id
770 770 assignee_transitions_allowed = initial_assigned_to_id.present? &&
771 771 (user.id == initial_assigned_to_id || user.group_ids.include?(initial_assigned_to_id))
772 772
773 773 statuses = initial_status.find_new_statuses_allowed_to(
774 774 user.admin ? Role.all : user.roles_for_project(project),
775 775 tracker,
776 776 author == user,
777 777 assignee_transitions_allowed
778 778 )
779 779 statuses << initial_status unless statuses.empty?
780 780 statuses << IssueStatus.default if include_default
781 781 statuses = statuses.compact.uniq.sort
782 782 blocked? ? statuses.reject {|s| s.is_closed?} : statuses
783 783 end
784 784 end
785 785
786 786 # Returns the previous assignee if changed
787 787 def assigned_to_was
788 788 # assigned_to_id_was is reset before after_save callbacks
789 789 user_id = @previous_assigned_to_id || assigned_to_id_was
790 790 if user_id && user_id != assigned_to_id
791 791 @assigned_to_was ||= User.find_by_id(user_id)
792 792 end
793 793 end
794 794
795 795 # Returns the users that should be notified
796 796 def notified_users
797 797 notified = []
798 798 # Author and assignee are always notified unless they have been
799 799 # locked or don't want to be notified
800 800 notified << author if author
801 801 if assigned_to
802 802 notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
803 803 end
804 804 if assigned_to_was
805 805 notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
806 806 end
807 807 notified = notified.select {|u| u.active? && u.notify_about?(self)}
808 808
809 809 notified += project.notified_users
810 810 notified.uniq!
811 811 # Remove users that can not view the issue
812 812 notified.reject! {|user| !visible?(user)}
813 813 notified
814 814 end
815 815
816 816 # Returns the email addresses that should be notified
817 817 def recipients
818 818 notified_users.collect(&:mail)
819 819 end
820 820
821 821 def each_notification(users, &block)
822 822 if users.any?
823 823 if custom_field_values.detect {|value| !value.custom_field.visible?}
824 824 users_by_custom_field_visibility = users.group_by do |user|
825 825 visible_custom_field_values(user).map(&:custom_field_id).sort
826 826 end
827 827 users_by_custom_field_visibility.values.each do |users|
828 828 yield(users)
829 829 end
830 830 else
831 831 yield(users)
832 832 end
833 833 end
834 834 end
835 835
836 836 # Returns the number of hours spent on this issue
837 837 def spent_hours
838 838 @spent_hours ||= time_entries.sum(:hours) || 0
839 839 end
840 840
841 841 # Returns the total number of hours spent on this issue and its descendants
842 842 #
843 843 # Example:
844 844 # spent_hours => 0.0
845 845 # spent_hours => 50.2
846 846 def total_spent_hours
847 847 @total_spent_hours ||=
848 848 self_and_descendants.
849 849 joins("LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").
850 850 sum("#{TimeEntry.table_name}.hours").to_f || 0.0
851 851 end
852 852
853 853 def relations
854 854 @relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)
855 855 end
856 856
857 857 # Preloads relations for a collection of issues
858 858 def self.load_relations(issues)
859 859 if issues.any?
860 860 relations = IssueRelation.where("issue_from_id IN (:ids) OR issue_to_id IN (:ids)", :ids => issues.map(&:id)).all
861 861 issues.each do |issue|
862 862 issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
863 863 end
864 864 end
865 865 end
866 866
867 867 # Preloads visible spent time for a collection of issues
868 868 def self.load_visible_spent_hours(issues, user=User.current)
869 869 if issues.any?
870 870 hours_by_issue_id = TimeEntry.visible(user).group(:issue_id).sum(:hours)
871 871 issues.each do |issue|
872 872 issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
873 873 end
874 874 end
875 875 end
876 876
877 877 # Preloads visible relations for a collection of issues
878 878 def self.load_visible_relations(issues, user=User.current)
879 879 if issues.any?
880 880 issue_ids = issues.map(&:id)
881 881 # Relations with issue_from in given issues and visible issue_to
882 882 relations_from = IssueRelation.includes(:issue_to => [:status, :project]).where(visible_condition(user)).where(:issue_from_id => issue_ids).all
883 883 # Relations with issue_to in given issues and visible issue_from
884 884 relations_to = IssueRelation.includes(:issue_from => [:status, :project]).where(visible_condition(user)).where(:issue_to_id => issue_ids).all
885 885
886 886 issues.each do |issue|
887 887 relations =
888 888 relations_from.select {|relation| relation.issue_from_id == issue.id} +
889 889 relations_to.select {|relation| relation.issue_to_id == issue.id}
890 890
891 891 issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)
892 892 end
893 893 end
894 894 end
895 895
896 896 # Finds an issue relation given its id.
897 897 def find_relation(relation_id)
898 898 IssueRelation.where("issue_to_id = ? OR issue_from_id = ?", id, id).find(relation_id)
899 899 end
900 900
901 901 # Returns all the other issues that depend on the issue
902 902 # The algorithm is a modified breadth first search (bfs)
903 903 def all_dependent_issues(except=[])
904 904 # The found dependencies
905 905 dependencies = []
906 906
907 907 # The visited flag for every node (issue) used by the breadth first search
908 908 eNOT_DISCOVERED = 0 # The issue is "new" to the algorithm, it has not seen it before.
909 909
910 910 ePROCESS_ALL = 1 # The issue is added to the queue. Process both children and relations of
911 911 # the issue when it is processed.
912 912
913 913 ePROCESS_RELATIONS_ONLY = 2 # The issue was added to the queue and will be output as dependent issue,
914 914 # but its children will not be added to the queue when it is processed.
915 915
916 916 eRELATIONS_PROCESSED = 3 # The related issues, the parent issue and the issue itself have been added to
917 917 # the queue, but its children have not been added.
918 918
919 919 ePROCESS_CHILDREN_ONLY = 4 # The relations and the parent of the issue have been added to the queue, but
920 920 # the children still need to be processed.
921 921
922 922 eALL_PROCESSED = 5 # The issue and all its children, its parent and its related issues have been
923 923 # added as dependent issues. It needs no further processing.
924 924
925 925 issue_status = Hash.new(eNOT_DISCOVERED)
926 926
927 927 # The queue
928 928 queue = []
929 929
930 930 # Initialize the bfs, add start node (self) to the queue
931 931 queue << self
932 932 issue_status[self] = ePROCESS_ALL
933 933
934 934 while (!queue.empty?) do
935 935 current_issue = queue.shift
936 936 current_issue_status = issue_status[current_issue]
937 937 dependencies << current_issue
938 938
939 939 # Add parent to queue, if not already in it.
940 940 parent = current_issue.parent
941 941 parent_status = issue_status[parent]
942 942
943 943 if parent && (parent_status == eNOT_DISCOVERED) && !except.include?(parent)
944 944 queue << parent
945 945 issue_status[parent] = ePROCESS_RELATIONS_ONLY
946 946 end
947 947
948 948 # Add children to queue, but only if they are not already in it and
949 949 # the children of the current node need to be processed.
950 950 if (current_issue_status == ePROCESS_CHILDREN_ONLY || current_issue_status == ePROCESS_ALL)
951 951 current_issue.children.each do |child|
952 952 next if except.include?(child)
953 953
954 954 if (issue_status[child] == eNOT_DISCOVERED)
955 955 queue << child
956 956 issue_status[child] = ePROCESS_ALL
957 957 elsif (issue_status[child] == eRELATIONS_PROCESSED)
958 958 queue << child
959 959 issue_status[child] = ePROCESS_CHILDREN_ONLY
960 960 elsif (issue_status[child] == ePROCESS_RELATIONS_ONLY)
961 961 queue << child
962 962 issue_status[child] = ePROCESS_ALL
963 963 end
964 964 end
965 965 end
966 966
967 967 # Add related issues to the queue, if they are not already in it.
968 968 current_issue.relations_from.map(&:issue_to).each do |related_issue|
969 969 next if except.include?(related_issue)
970 970
971 971 if (issue_status[related_issue] == eNOT_DISCOVERED)
972 972 queue << related_issue
973 973 issue_status[related_issue] = ePROCESS_ALL
974 974 elsif (issue_status[related_issue] == eRELATIONS_PROCESSED)
975 975 queue << related_issue
976 976 issue_status[related_issue] = ePROCESS_CHILDREN_ONLY
977 977 elsif (issue_status[related_issue] == ePROCESS_RELATIONS_ONLY)
978 978 queue << related_issue
979 979 issue_status[related_issue] = ePROCESS_ALL
980 980 end
981 981 end
982 982
983 983 # Set new status for current issue
984 984 if (current_issue_status == ePROCESS_ALL) || (current_issue_status == ePROCESS_CHILDREN_ONLY)
985 985 issue_status[current_issue] = eALL_PROCESSED
986 986 elsif (current_issue_status == ePROCESS_RELATIONS_ONLY)
987 987 issue_status[current_issue] = eRELATIONS_PROCESSED
988 988 end
989 989 end # while
990 990
991 991 # Remove the issues from the "except" parameter from the result array
992 992 dependencies -= except
993 993 dependencies.delete(self)
994 994
995 995 dependencies
996 996 end
997 997
998 998 # Returns an array of issues that duplicate this one
999 999 def duplicates
1000 1000 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
1001 1001 end
1002 1002
1003 1003 # Returns the due date or the target due date if any
1004 1004 # Used on gantt chart
1005 1005 def due_before
1006 1006 due_date || (fixed_version ? fixed_version.effective_date : nil)
1007 1007 end
1008 1008
1009 1009 # Returns the time scheduled for this issue.
1010 1010 #
1011 1011 # Example:
1012 1012 # Start Date: 2/26/09, End Date: 3/04/09
1013 1013 # duration => 6
1014 1014 def duration
1015 1015 (start_date && due_date) ? due_date - start_date : 0
1016 1016 end
1017 1017
1018 1018 # Returns the duration in working days
1019 1019 def working_duration
1020 1020 (start_date && due_date) ? working_days(start_date, due_date) : 0
1021 1021 end
1022 1022
1023 1023 def soonest_start(reload=false)
1024 1024 @soonest_start = nil if reload
1025 1025 @soonest_start ||= (
1026 1026 relations_to(reload).collect{|relation| relation.successor_soonest_start} +
1027 1027 [(@parent_issue || parent).try(:soonest_start)]
1028 1028 ).compact.max
1029 1029 end
1030 1030
1031 1031 # Sets start_date on the given date or the next working day
1032 1032 # and changes due_date to keep the same working duration.
1033 1033 def reschedule_on(date)
1034 1034 wd = working_duration
1035 1035 date = next_working_date(date)
1036 1036 self.start_date = date
1037 1037 self.due_date = add_working_days(date, wd)
1038 1038 end
1039 1039
1040 1040 # Reschedules the issue on the given date or the next working day and saves the record.
1041 1041 # If the issue is a parent task, this is done by rescheduling its subtasks.
1042 1042 def reschedule_on!(date)
1043 1043 return if date.nil?
1044 1044 if leaf?
1045 1045 if start_date.nil? || start_date != date
1046 1046 if start_date && start_date > date
1047 1047 # Issue can not be moved earlier than its soonest start date
1048 1048 date = [soonest_start(true), date].compact.max
1049 1049 end
1050 1050 reschedule_on(date)
1051 1051 begin
1052 1052 save
1053 1053 rescue ActiveRecord::StaleObjectError
1054 1054 reload
1055 1055 reschedule_on(date)
1056 1056 save
1057 1057 end
1058 1058 end
1059 1059 else
1060 1060 leaves.each do |leaf|
1061 1061 if leaf.start_date
1062 1062 # Only move subtask if it starts at the same date as the parent
1063 1063 # or if it starts before the given date
1064 1064 if start_date == leaf.start_date || date > leaf.start_date
1065 1065 leaf.reschedule_on!(date)
1066 1066 end
1067 1067 else
1068 1068 leaf.reschedule_on!(date)
1069 1069 end
1070 1070 end
1071 1071 end
1072 1072 end
1073 1073
1074 1074 def <=>(issue)
1075 1075 if issue.nil?
1076 1076 -1
1077 1077 elsif root_id != issue.root_id
1078 1078 (root_id || 0) <=> (issue.root_id || 0)
1079 1079 else
1080 1080 (lft || 0) <=> (issue.lft || 0)
1081 1081 end
1082 1082 end
1083 1083
1084 1084 def to_s
1085 1085 "#{tracker} ##{id}: #{subject}"
1086 1086 end
1087 1087
1088 1088 # Returns a string of css classes that apply to the issue
1089 1089 def css_classes(user=User.current)
1090 1090 s = "issue tracker-#{tracker_id} status-#{status_id} #{priority.try(:css_classes)}"
1091 1091 s << ' closed' if closed?
1092 1092 s << ' overdue' if overdue?
1093 1093 s << ' child' if child?
1094 1094 s << ' parent' unless leaf?
1095 1095 s << ' private' if is_private?
1096 1096 if user.logged?
1097 1097 s << ' created-by-me' if author_id == user.id
1098 1098 s << ' assigned-to-me' if assigned_to_id == user.id
1099 1099 s << ' assigned-to-my-group' if user.groups.any? {|g| g.id == assigned_to_id}
1100 1100 end
1101 1101 s
1102 1102 end
1103 1103
1104 1104 # Unassigns issues from +version+ if it's no longer shared with issue's project
1105 1105 def self.update_versions_from_sharing_change(version)
1106 1106 # Update issues assigned to the version
1107 1107 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
1108 1108 end
1109 1109
1110 1110 # Unassigns issues from versions that are no longer shared
1111 1111 # after +project+ was moved
1112 1112 def self.update_versions_from_hierarchy_change(project)
1113 1113 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
1114 1114 # Update issues of the moved projects and issues assigned to a version of a moved project
1115 1115 Issue.update_versions(
1116 1116 ["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)",
1117 1117 moved_project_ids, moved_project_ids]
1118 1118 )
1119 1119 end
1120 1120
1121 1121 def parent_issue_id=(arg)
1122 1122 s = arg.to_s.strip.presence
1123 1123 if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))
1124 1124 @invalid_parent_issue_id = nil
1125 1125 elsif s.blank?
1126 1126 @parent_issue = nil
1127 1127 @invalid_parent_issue_id = nil
1128 1128 else
1129 1129 @parent_issue = nil
1130 1130 @invalid_parent_issue_id = arg
1131 1131 end
1132 1132 end
1133 1133
1134 1134 def parent_issue_id
1135 1135 if @invalid_parent_issue_id
1136 1136 @invalid_parent_issue_id
1137 1137 elsif instance_variable_defined? :@parent_issue
1138 1138 @parent_issue.nil? ? nil : @parent_issue.id
1139 1139 else
1140 1140 parent_id
1141 1141 end
1142 1142 end
1143 1143
1144 1144 # Returns true if issue's project is a valid
1145 1145 # parent issue project
1146 1146 def valid_parent_project?(issue=parent)
1147 1147 return true if issue.nil? || issue.project_id == project_id
1148 1148
1149 1149 case Setting.cross_project_subtasks
1150 1150 when 'system'
1151 1151 true
1152 1152 when 'tree'
1153 1153 issue.project.root == project.root
1154 1154 when 'hierarchy'
1155 1155 issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)
1156 1156 when 'descendants'
1157 1157 issue.project.is_or_is_ancestor_of?(project)
1158 1158 else
1159 1159 false
1160 1160 end
1161 1161 end
1162 1162
1163 1163 # Returns an issue scope based on project and scope
1164 1164 def self.cross_project_scope(project, scope=nil)
1165 1165 if project.nil?
1166 1166 return Issue
1167 1167 end
1168 1168 case scope
1169 1169 when 'all', 'system'
1170 1170 Issue
1171 1171 when 'tree'
1172 1172 Issue.joins(:project).where("(#{Project.table_name}.lft >= :lft AND #{Project.table_name}.rgt <= :rgt)",
1173 1173 :lft => project.root.lft, :rgt => project.root.rgt)
1174 1174 when 'hierarchy'
1175 1175 Issue.joins(:project).where("(#{Project.table_name}.lft >= :lft AND #{Project.table_name}.rgt <= :rgt) OR (#{Project.table_name}.lft < :lft AND #{Project.table_name}.rgt > :rgt)",
1176 1176 :lft => project.lft, :rgt => project.rgt)
1177 1177 when 'descendants'
1178 1178 Issue.joins(:project).where("(#{Project.table_name}.lft >= :lft AND #{Project.table_name}.rgt <= :rgt)",
1179 1179 :lft => project.lft, :rgt => project.rgt)
1180 1180 else
1181 1181 Issue.where(:project_id => project.id)
1182 1182 end
1183 1183 end
1184 1184
1185 1185 def self.by_tracker(project)
1186 1186 count_and_group_by(:project => project, :association => :tracker)
1187 1187 end
1188 1188
1189 1189 def self.by_version(project)
1190 1190 count_and_group_by(:project => project, :association => :fixed_version)
1191 1191 end
1192 1192
1193 1193 def self.by_priority(project)
1194 1194 count_and_group_by(:project => project, :association => :priority)
1195 1195 end
1196 1196
1197 1197 def self.by_category(project)
1198 1198 count_and_group_by(:project => project, :association => :category)
1199 1199 end
1200 1200
1201 1201 def self.by_assigned_to(project)
1202 1202 count_and_group_by(:project => project, :association => :assigned_to)
1203 1203 end
1204 1204
1205 1205 def self.by_author(project)
1206 1206 count_and_group_by(:project => project, :association => :author)
1207 1207 end
1208 1208
1209 1209 def self.by_subproject(project)
1210 1210 r = count_and_group_by(:project => project, :with_subprojects => true, :association => :project)
1211 1211 r.reject {|r| r["project_id"] == project.id.to_s}
1212 1212 end
1213 1213
1214 1214 # Query generator for selecting groups of issue counts for a project
1215 1215 # based on specific criteria
1216 1216 #
1217 1217 # Options
1218 1218 # * project - Project to search in.
1219 1219 # * with_subprojects - Includes subprojects issues if set to true.
1220 1220 # * association - Symbol. Association for grouping.
1221 1221 def self.count_and_group_by(options)
1222 1222 assoc = reflect_on_association(options[:association])
1223 1223 select_field = assoc.foreign_key
1224 1224
1225 1225 Issue.
1226 1226 visible(User.current, :project => options[:project], :with_subprojects => options[:with_subprojects]).
1227 1227 joins(:status, assoc.name).
1228 1228 group(:status_id, :is_closed, select_field).
1229 1229 count.
1230 1230 map do |columns, total|
1231 1231 status_id, is_closed, field_value = columns
1232 is_closed = ['t', 'true', true].include?(is_closed)
1232 1233 {
1233 1234 "status_id" => status_id.to_s,
1234 "closed" => is_closed.to_s,
1235 "closed" => is_closed,
1235 1236 select_field => field_value.to_s,
1236 1237 "total" => total.to_s
1237 1238 }
1238 1239 end
1239 1240 end
1240 1241
1241 1242 # Returns a scope of projects that user can assign the issue to
1242 1243 def allowed_target_projects(user=User.current)
1243 1244 if new_record?
1244 1245 Project.where(Project.allowed_to_condition(user, :add_issues))
1245 1246 else
1246 1247 self.class.allowed_target_projects_on_move(user)
1247 1248 end
1248 1249 end
1249 1250
1250 1251 # Returns a scope of projects that user can move issues to
1251 1252 def self.allowed_target_projects_on_move(user=User.current)
1252 1253 Project.where(Project.allowed_to_condition(user, :move_issues))
1253 1254 end
1254 1255
1255 1256 private
1256 1257
1257 1258 def after_project_change
1258 1259 # Update project_id on related time entries
1259 1260 TimeEntry.where({:issue_id => id}).update_all(["project_id = ?", project_id])
1260 1261
1261 1262 # Delete issue relations
1262 1263 unless Setting.cross_project_issue_relations?
1263 1264 relations_from.clear
1264 1265 relations_to.clear
1265 1266 end
1266 1267
1267 1268 # Move subtasks that were in the same project
1268 1269 children.each do |child|
1269 1270 next unless child.project_id == project_id_was
1270 1271 # Change project and keep project
1271 1272 child.send :project=, project, true
1272 1273 unless child.save
1273 1274 raise ActiveRecord::Rollback
1274 1275 end
1275 1276 end
1276 1277 end
1277 1278
1278 1279 # Callback for after the creation of an issue by copy
1279 1280 # * adds a "copied to" relation with the copied issue
1280 1281 # * copies subtasks from the copied issue
1281 1282 def after_create_from_copy
1282 1283 return unless copy? && !@after_create_from_copy_handled
1283 1284
1284 1285 if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false
1285 1286 relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)
1286 1287 unless relation.save
1287 1288 logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger
1288 1289 end
1289 1290 end
1290 1291
1291 1292 unless @copied_from.leaf? || @copy_options[:subtasks] == false
1292 1293 copy_options = (@copy_options || {}).merge(:subtasks => false)
1293 1294 copied_issue_ids = {@copied_from.id => self.id}
1294 1295 @copied_from.reload.descendants.reorder("#{Issue.table_name}.lft").each do |child|
1295 1296 # Do not copy self when copying an issue as a descendant of the copied issue
1296 1297 next if child == self
1297 1298 # Do not copy subtasks of issues that were not copied
1298 1299 next unless copied_issue_ids[child.parent_id]
1299 1300 # Do not copy subtasks that are not visible to avoid potential disclosure of private data
1300 1301 unless child.visible?
1301 1302 logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger
1302 1303 next
1303 1304 end
1304 1305 copy = Issue.new.copy_from(child, copy_options)
1305 1306 copy.author = author
1306 1307 copy.project = project
1307 1308 copy.parent_issue_id = copied_issue_ids[child.parent_id]
1308 1309 unless copy.save
1309 1310 logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger
1310 1311 next
1311 1312 end
1312 1313 copied_issue_ids[child.id] = copy.id
1313 1314 end
1314 1315 end
1315 1316 @after_create_from_copy_handled = true
1316 1317 end
1317 1318
1318 1319 def update_nested_set_attributes
1319 1320 if root_id.nil?
1320 1321 # issue was just created
1321 1322 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
1322 1323 Issue.where(["id = ?", id]).update_all(["root_id = ?", root_id])
1323 1324 if @parent_issue
1324 1325 move_to_child_of(@parent_issue)
1325 1326 end
1326 1327 elsif parent_issue_id != parent_id
1327 1328 update_nested_set_attributes_on_parent_change
1328 1329 end
1329 1330 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
1330 1331 end
1331 1332
1332 1333 # Updates the nested set for when an existing issue is moved
1333 1334 def update_nested_set_attributes_on_parent_change
1334 1335 former_parent_id = parent_id
1335 1336 # moving an existing issue
1336 1337 if @parent_issue && @parent_issue.root_id == root_id
1337 1338 # inside the same tree
1338 1339 move_to_child_of(@parent_issue)
1339 1340 else
1340 1341 # to another tree
1341 1342 unless root?
1342 1343 move_to_right_of(root)
1343 1344 end
1344 1345 old_root_id = root_id
1345 1346 in_tenacious_transaction do
1346 1347 @parent_issue.reload_nested_set if @parent_issue
1347 1348 self.reload_nested_set
1348 1349 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
1349 1350 cond = ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt]
1350 1351 self.class.base_class.select('id').lock(true).where(cond)
1351 1352 offset = right_most_bound + 1 - lft
1352 1353 Issue.where(cond).
1353 1354 update_all(["root_id = ?, lft = lft + ?, rgt = rgt + ?", root_id, offset, offset])
1354 1355 end
1355 1356 if @parent_issue
1356 1357 move_to_child_of(@parent_issue)
1357 1358 end
1358 1359 end
1359 1360 # delete invalid relations of all descendants
1360 1361 self_and_descendants.each do |issue|
1361 1362 issue.relations.each do |relation|
1362 1363 relation.destroy unless relation.valid?
1363 1364 end
1364 1365 end
1365 1366 # update former parent
1366 1367 recalculate_attributes_for(former_parent_id) if former_parent_id
1367 1368 end
1368 1369
1369 1370 def update_parent_attributes
1370 1371 recalculate_attributes_for(parent_id) if parent_id
1371 1372 end
1372 1373
1373 1374 def recalculate_attributes_for(issue_id)
1374 1375 if issue_id && p = Issue.find_by_id(issue_id)
1375 1376 # priority = highest priority of children
1376 1377 if priority_position = p.children.joins(:priority).maximum("#{IssuePriority.table_name}.position")
1377 1378 p.priority = IssuePriority.find_by_position(priority_position)
1378 1379 end
1379 1380
1380 1381 # start/due dates = lowest/highest dates of children
1381 1382 p.start_date = p.children.minimum(:start_date)
1382 1383 p.due_date = p.children.maximum(:due_date)
1383 1384 if p.start_date && p.due_date && p.due_date < p.start_date
1384 1385 p.start_date, p.due_date = p.due_date, p.start_date
1385 1386 end
1386 1387
1387 1388 # done ratio = weighted average ratio of leaves
1388 1389 unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
1389 1390 leaves_count = p.leaves.count
1390 1391 if leaves_count > 0
1391 1392 average = p.leaves.where("estimated_hours > 0").average(:estimated_hours).to_f
1392 1393 if average == 0
1393 1394 average = 1
1394 1395 end
1395 1396 done = p.leaves.joins(:status).
1396 1397 sum("COALESCE(CASE WHEN estimated_hours > 0 THEN estimated_hours ELSE NULL END, #{average}) " +
1397 1398 "* (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)").to_f
1398 1399 progress = done / (average * leaves_count)
1399 1400 p.done_ratio = progress.round
1400 1401 end
1401 1402 end
1402 1403
1403 1404 # estimate = sum of leaves estimates
1404 1405 p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
1405 1406 p.estimated_hours = nil if p.estimated_hours == 0.0
1406 1407
1407 1408 # ancestors will be recursively updated
1408 1409 p.save(:validate => false)
1409 1410 end
1410 1411 end
1411 1412
1412 1413 # Update issues so their versions are not pointing to a
1413 1414 # fixed_version that is not shared with the issue's project
1414 1415 def self.update_versions(conditions=nil)
1415 1416 # Only need to update issues with a fixed_version from
1416 1417 # a different project and that is not systemwide shared
1417 1418 Issue.includes(:project, :fixed_version).
1418 1419 where("#{Issue.table_name}.fixed_version_id IS NOT NULL" +
1419 1420 " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
1420 1421 " AND #{Version.table_name}.sharing <> 'system'").
1421 1422 where(conditions).each do |issue|
1422 1423 next if issue.project.nil? || issue.fixed_version.nil?
1423 1424 unless issue.project.shared_versions.include?(issue.fixed_version)
1424 1425 issue.init_journal(User.current)
1425 1426 issue.fixed_version = nil
1426 1427 issue.save
1427 1428 end
1428 1429 end
1429 1430 end
1430 1431
1431 1432 # Callback on file attachment
1432 1433 def attachment_added(obj)
1433 1434 if @current_journal && !obj.new_record?
1434 1435 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
1435 1436 end
1436 1437 end
1437 1438
1438 1439 # Callback on attachment deletion
1439 1440 def attachment_removed(obj)
1440 1441 if @current_journal && !obj.new_record?
1441 1442 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)
1442 1443 @current_journal.save
1443 1444 end
1444 1445 end
1445 1446
1446 1447 # Default assignment based on category
1447 1448 def default_assign
1448 1449 if assigned_to.nil? && category && category.assigned_to
1449 1450 self.assigned_to = category.assigned_to
1450 1451 end
1451 1452 end
1452 1453
1453 1454 # Updates start/due dates of following issues
1454 1455 def reschedule_following_issues
1455 1456 if start_date_changed? || due_date_changed?
1456 1457 relations_from.each do |relation|
1457 1458 relation.set_issue_to_dates
1458 1459 end
1459 1460 end
1460 1461 end
1461 1462
1462 1463 # Closes duplicates if the issue is being closed
1463 1464 def close_duplicates
1464 1465 if closing?
1465 1466 duplicates.each do |duplicate|
1466 1467 # Reload is needed in case the duplicate was updated by a previous duplicate
1467 1468 duplicate.reload
1468 1469 # Don't re-close it if it's already closed
1469 1470 next if duplicate.closed?
1470 1471 # Same user and notes
1471 1472 if @current_journal
1472 1473 duplicate.init_journal(@current_journal.user, @current_journal.notes)
1473 1474 end
1474 1475 duplicate.update_attribute :status, self.status
1475 1476 end
1476 1477 end
1477 1478 end
1478 1479
1479 1480 # Make sure updated_on is updated when adding a note and set updated_on now
1480 1481 # so we can set closed_on with the same value on closing
1481 1482 def force_updated_on_change
1482 1483 if @current_journal || changed?
1483 1484 self.updated_on = current_time_from_proper_timezone
1484 1485 if new_record?
1485 1486 self.created_on = updated_on
1486 1487 end
1487 1488 end
1488 1489 end
1489 1490
1490 1491 # Callback for setting closed_on when the issue is closed.
1491 1492 # The closed_on attribute stores the time of the last closing
1492 1493 # and is preserved when the issue is reopened.
1493 1494 def update_closed_on
1494 1495 if closing? || (new_record? && closed?)
1495 1496 self.closed_on = updated_on
1496 1497 end
1497 1498 end
1498 1499
1499 1500 # Saves the changes in a Journal
1500 1501 # Called after_save
1501 1502 def create_journal
1502 1503 if @current_journal
1503 1504 # attributes changes
1504 1505 if @attributes_before_change
1505 1506 (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)).each {|c|
1506 1507 before = @attributes_before_change[c]
1507 1508 after = send(c)
1508 1509 next if before == after || (before.blank? && after.blank?)
1509 1510 @current_journal.details << JournalDetail.new(:property => 'attr',
1510 1511 :prop_key => c,
1511 1512 :old_value => before,
1512 1513 :value => after)
1513 1514 }
1514 1515 end
1515 1516 if @custom_values_before_change
1516 1517 # custom fields changes
1517 1518 custom_field_values.each {|c|
1518 1519 before = @custom_values_before_change[c.custom_field_id]
1519 1520 after = c.value
1520 1521 next if before == after || (before.blank? && after.blank?)
1521 1522
1522 1523 if before.is_a?(Array) || after.is_a?(Array)
1523 1524 before = [before] unless before.is_a?(Array)
1524 1525 after = [after] unless after.is_a?(Array)
1525 1526
1526 1527 # values removed
1527 1528 (before - after).reject(&:blank?).each do |value|
1528 1529 @current_journal.details << JournalDetail.new(:property => 'cf',
1529 1530 :prop_key => c.custom_field_id,
1530 1531 :old_value => value,
1531 1532 :value => nil)
1532 1533 end
1533 1534 # values added
1534 1535 (after - before).reject(&:blank?).each do |value|
1535 1536 @current_journal.details << JournalDetail.new(:property => 'cf',
1536 1537 :prop_key => c.custom_field_id,
1537 1538 :old_value => nil,
1538 1539 :value => value)
1539 1540 end
1540 1541 else
1541 1542 @current_journal.details << JournalDetail.new(:property => 'cf',
1542 1543 :prop_key => c.custom_field_id,
1543 1544 :old_value => before,
1544 1545 :value => after)
1545 1546 end
1546 1547 }
1547 1548 end
1548 1549 @current_journal.save
1549 1550 # reset current journal
1550 1551 init_journal @current_journal.user, @current_journal.notes
1551 1552 end
1552 1553 end
1553 1554
1554 1555 def send_notification
1555 1556 if Setting.notified_events.include?('issue_added')
1556 1557 Mailer.deliver_issue_add(self)
1557 1558 end
1558 1559 end
1559 1560
1560 1561 # Stores the previous assignee so we can still have access
1561 1562 # to it during after_save callbacks (assigned_to_id_was is reset)
1562 1563 def set_assigned_to_was
1563 1564 @previous_assigned_to_id = assigned_to_id_was
1564 1565 end
1565 1566
1566 1567 # Clears the previous assignee at the end of after_save callbacks
1567 1568 def clear_assigned_to_was
1568 1569 @assigned_to_was = nil
1569 1570 @previous_assigned_to_id = nil
1570 1571 end
1571 1572 end
General Comments 0
You need to be logged in to leave comments. Login now