##// END OF EJS Templates
Code cleanup....
Jean-Philippe Lang -
r9810:5097f5178418
parent child
Show More
@@ -1,128 +1,126
1 # Redmine - project management software
1 # Redmine - project management software
2 # Copyright (C) 2006-2012 Jean-Philippe Lang
2 # Copyright (C) 2006-2012 Jean-Philippe Lang
3 #
3 #
4 # This program is free software; you can redistribute it and/or
4 # This program is free software; you can redistribute it and/or
5 # modify it under the terms of the GNU General Public License
5 # modify it under the terms of the GNU General Public License
6 # as published by the Free Software Foundation; either version 2
6 # as published by the Free Software Foundation; either version 2
7 # of the License, or (at your option) any later version.
7 # of the License, or (at your option) any later version.
8 #
8 #
9 # This program is distributed in the hope that it will be useful,
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
12 # GNU General Public License for more details.
13 #
13 #
14 # You should have received a copy of the GNU General Public License
14 # You should have received a copy of the GNU General Public License
15 # along with this program; if not, write to the Free Software
15 # along with this program; if not, write to the Free Software
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17
17
18 class WorkflowsController < ApplicationController
18 class WorkflowsController < ApplicationController
19 layout 'admin'
19 layout 'admin'
20
20
21 before_filter :require_admin
21 before_filter :require_admin, :find_roles, :find_trackers
22 before_filter :find_roles
23 before_filter :find_trackers
24
22
25 def index
23 def index
26 @workflow_counts = WorkflowTransition.count_by_tracker_and_role
24 @workflow_counts = WorkflowTransition.count_by_tracker_and_role
27 end
25 end
28
26
29 def edit
27 def edit
30 @role = Role.find_by_id(params[:role_id])
28 @role = Role.find_by_id(params[:role_id])
31 @tracker = Tracker.find_by_id(params[:tracker_id])
29 @tracker = Tracker.find_by_id(params[:tracker_id])
32
30
33 if request.post?
31 if request.post?
34 WorkflowTransition.destroy_all( ["role_id=? and tracker_id=?", @role.id, @tracker.id])
32 WorkflowTransition.destroy_all( ["role_id=? and tracker_id=?", @role.id, @tracker.id])
35 (params[:issue_status] || []).each { |status_id, transitions|
33 (params[:issue_status] || []).each { |status_id, transitions|
36 transitions.each { |new_status_id, options|
34 transitions.each { |new_status_id, options|
37 author = options.is_a?(Array) && options.include?('author') && !options.include?('always')
35 author = options.is_a?(Array) && options.include?('author') && !options.include?('always')
38 assignee = options.is_a?(Array) && options.include?('assignee') && !options.include?('always')
36 assignee = options.is_a?(Array) && options.include?('assignee') && !options.include?('always')
39 WorkflowTransition.create(:role_id => @role.id, :tracker_id => @tracker.id, :old_status_id => status_id, :new_status_id => new_status_id, :author => author, :assignee => assignee)
37 WorkflowTransition.create(:role_id => @role.id, :tracker_id => @tracker.id, :old_status_id => status_id, :new_status_id => new_status_id, :author => author, :assignee => assignee)
40 }
38 }
41 }
39 }
42 if @role.save
40 if @role.save
43 redirect_to :action => 'edit', :role_id => @role, :tracker_id => @tracker
41 redirect_to :action => 'edit', :role_id => @role, :tracker_id => @tracker
44 return
42 return
45 end
43 end
46 end
44 end
47
45
48 @used_statuses_only = (params[:used_statuses_only] == '0' ? false : true)
46 @used_statuses_only = (params[:used_statuses_only] == '0' ? false : true)
49 if @tracker && @used_statuses_only && @tracker.issue_statuses.any?
47 if @tracker && @used_statuses_only && @tracker.issue_statuses.any?
50 @statuses = @tracker.issue_statuses
48 @statuses = @tracker.issue_statuses
51 end
49 end
52 @statuses ||= IssueStatus.sorted.all
50 @statuses ||= IssueStatus.sorted.all
53
51
54 if @tracker && @role && @statuses.any?
52 if @tracker && @role && @statuses.any?
55 workflows = WorkflowTransition.where(:role_id => @role.id, :tracker_id => @tracker.id).all
53 workflows = WorkflowTransition.where(:role_id => @role.id, :tracker_id => @tracker.id).all
56 @workflows = {}
54 @workflows = {}
57 @workflows['always'] = workflows.select {|w| !w.author && !w.assignee}
55 @workflows['always'] = workflows.select {|w| !w.author && !w.assignee}
58 @workflows['author'] = workflows.select {|w| w.author}
56 @workflows['author'] = workflows.select {|w| w.author}
59 @workflows['assignee'] = workflows.select {|w| w.assignee}
57 @workflows['assignee'] = workflows.select {|w| w.assignee}
60 end
58 end
61 end
59 end
62
60
63 def permissions
61 def permissions
64 @role = Role.find_by_id(params[:role_id])
62 @role = Role.find_by_id(params[:role_id])
65 @tracker = Tracker.find_by_id(params[:tracker_id])
63 @tracker = Tracker.find_by_id(params[:tracker_id])
66
64
67 if @role && @tracker
65 if @role && @tracker
68 if request.post?
66 if request.post?
69 WorkflowPermission.replace_permissions(@tracker, @role, params[:permissions] || {})
67 WorkflowPermission.replace_permissions(@tracker, @role, params[:permissions] || {})
70 redirect_to :action => 'permissions', :role_id => @role, :tracker_id => @tracker
68 redirect_to :action => 'permissions', :role_id => @role, :tracker_id => @tracker
71 return
69 return
72 end
70 end
73
71
74 @statuses = @tracker.issue_statuses
72 @statuses = @tracker.issue_statuses
75 if @statuses.empty?
73 if @statuses.empty?
76 @statuses = IssueStatus.sorted.all
74 @statuses = IssueStatus.sorted.all
77 end
75 end
78 @fields = (Tracker::CORE_FIELDS_ALL - @tracker.disabled_core_fields).map {|field| [field, l("field_"+field.sub(/_id$/, ''))]}
76 @fields = (Tracker::CORE_FIELDS_ALL - @tracker.disabled_core_fields).map {|field| [field, l("field_"+field.sub(/_id$/, ''))]}
79 @custom_fields = @tracker.custom_fields
77 @custom_fields = @tracker.custom_fields
80
78
81 @permissions = WorkflowPermission.where(:tracker_id => @tracker.id, :role_id => @role.id).all.inject({}) do |h, w|
79 @permissions = WorkflowPermission.where(:tracker_id => @tracker.id, :role_id => @role.id).all.inject({}) do |h, w|
82 h[w.old_status_id] ||= {}
80 h[w.old_status_id] ||= {}
83 h[w.old_status_id][w.field_name] = w.rule
81 h[w.old_status_id][w.field_name] = w.rule
84 h
82 h
85 end
83 end
86 @statuses.each {|status| @permissions[status.id] ||= {}}
84 @statuses.each {|status| @permissions[status.id] ||= {}}
87 end
85 end
88 end
86 end
89
87
90 def copy
88 def copy
91
89
92 if params[:source_tracker_id].blank? || params[:source_tracker_id] == 'any'
90 if params[:source_tracker_id].blank? || params[:source_tracker_id] == 'any'
93 @source_tracker = nil
91 @source_tracker = nil
94 else
92 else
95 @source_tracker = Tracker.find_by_id(params[:source_tracker_id].to_i)
93 @source_tracker = Tracker.find_by_id(params[:source_tracker_id].to_i)
96 end
94 end
97 if params[:source_role_id].blank? || params[:source_role_id] == 'any'
95 if params[:source_role_id].blank? || params[:source_role_id] == 'any'
98 @source_role = nil
96 @source_role = nil
99 else
97 else
100 @source_role = Role.find_by_id(params[:source_role_id].to_i)
98 @source_role = Role.find_by_id(params[:source_role_id].to_i)
101 end
99 end
102
100
103 @target_trackers = params[:target_tracker_ids].blank? ? nil : Tracker.find_all_by_id(params[:target_tracker_ids])
101 @target_trackers = params[:target_tracker_ids].blank? ? nil : Tracker.find_all_by_id(params[:target_tracker_ids])
104 @target_roles = params[:target_role_ids].blank? ? nil : Role.find_all_by_id(params[:target_role_ids])
102 @target_roles = params[:target_role_ids].blank? ? nil : Role.find_all_by_id(params[:target_role_ids])
105
103
106 if request.post?
104 if request.post?
107 if params[:source_tracker_id].blank? || params[:source_role_id].blank? || (@source_tracker.nil? && @source_role.nil?)
105 if params[:source_tracker_id].blank? || params[:source_role_id].blank? || (@source_tracker.nil? && @source_role.nil?)
108 flash.now[:error] = l(:error_workflow_copy_source)
106 flash.now[:error] = l(:error_workflow_copy_source)
109 elsif @target_trackers.nil? || @target_roles.nil?
107 elsif @target_trackers.nil? || @target_roles.nil?
110 flash.now[:error] = l(:error_workflow_copy_target)
108 flash.now[:error] = l(:error_workflow_copy_target)
111 else
109 else
112 WorkflowRule.copy(@source_tracker, @source_role, @target_trackers, @target_roles)
110 WorkflowRule.copy(@source_tracker, @source_role, @target_trackers, @target_roles)
113 flash[:notice] = l(:notice_successful_update)
111 flash[:notice] = l(:notice_successful_update)
114 redirect_to :action => 'copy', :source_tracker_id => @source_tracker, :source_role_id => @source_role
112 redirect_to :action => 'copy', :source_tracker_id => @source_tracker, :source_role_id => @source_role
115 end
113 end
116 end
114 end
117 end
115 end
118
116
119 private
117 private
120
118
121 def find_roles
119 def find_roles
122 @roles = Role.sorted.all
120 @roles = Role.sorted.all
123 end
121 end
124
122
125 def find_trackers
123 def find_trackers
126 @trackers = Tracker.sorted.all
124 @trackers = Tracker.sorted.all
127 end
125 end
128 end
126 end
General Comments 0
You need to be logged in to leave comments. Login now