jro_apps/redmine Commit - r15226:4c78b63d58b7

Wrong filters are applied when exporting issues to CSV with blank filter (#23206)....

Jean-Philippe Lang -

r15226:4c78b63d58b7

parent child

Context file:

r15226:4c78b63d58b7

app/helpers/queries_helper.rb +2 0

                       tags << hidden_field_tag("v[#{field}][]", value, :id => nil)
                     end
                   end
+                else
+                  tags << hidden_field_tag("f[]", "", :id => nil)
                 end
                 if query.column_names.present?
                   query.column_names.each do |name|

test/functional/issues_controller_test.rb +11 0

                   assert_select 'input[name=?][value=?]', 'sort', 'status'
                 end
+                get :index, :project_id => 1, :set_filter => "1", :f => []
+                assert_select '#csv-export-form input[name=?][value=?]', 'f[]', ''
               end
               def test_index_csv
                 assert_equal 'text/csv; header=present', @response.content_type
               end
+              def test_index_csv_without_any_filters
+                @request.session[:user_id] = 1
+                Issue.create!(:project_id => 1, :tracker_id => 1, :status_id => 5, :subject => 'Closed issue', :author_id => 1)
+                get :index, :set_filter => 1, :f => [], :format => 'csv'
+                assert_response :success
+                assert_equal Issue.count, assigns(:issues).count
+              end
               def test_index_csv_with_description
                 Issue.generate!(:description => 'test_index_csv_with_description')

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages