##// END OF EJS Templates
Fixed a nil method error in Setting#value=...
Eric Davis -
r3303:4a67c211ca7b
parent child
Show More
@@ -1,168 +1,168
1 # redMine - project management software
1 # redMine - project management software
2 # Copyright (C) 2006-2007 Jean-Philippe Lang
2 # Copyright (C) 2006-2007 Jean-Philippe Lang
3 #
3 #
4 # This program is free software; you can redistribute it and/or
4 # This program is free software; you can redistribute it and/or
5 # modify it under the terms of the GNU General Public License
5 # modify it under the terms of the GNU General Public License
6 # as published by the Free Software Foundation; either version 2
6 # as published by the Free Software Foundation; either version 2
7 # of the License, or (at your option) any later version.
7 # of the License, or (at your option) any later version.
8 #
8 #
9 # This program is distributed in the hope that it will be useful,
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
12 # GNU General Public License for more details.
13 #
13 #
14 # You should have received a copy of the GNU General Public License
14 # You should have received a copy of the GNU General Public License
15 # along with this program; if not, write to the Free Software
15 # along with this program; if not, write to the Free Software
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17
17
18 class Setting < ActiveRecord::Base
18 class Setting < ActiveRecord::Base
19
19
20 DATE_FORMATS = [
20 DATE_FORMATS = [
21 '%Y-%m-%d',
21 '%Y-%m-%d',
22 '%d/%m/%Y',
22 '%d/%m/%Y',
23 '%d.%m.%Y',
23 '%d.%m.%Y',
24 '%d-%m-%Y',
24 '%d-%m-%Y',
25 '%m/%d/%Y',
25 '%m/%d/%Y',
26 '%d %b %Y',
26 '%d %b %Y',
27 '%d %B %Y',
27 '%d %B %Y',
28 '%b %d, %Y',
28 '%b %d, %Y',
29 '%B %d, %Y'
29 '%B %d, %Y'
30 ]
30 ]
31
31
32 TIME_FORMATS = [
32 TIME_FORMATS = [
33 '%H:%M',
33 '%H:%M',
34 '%I:%M %p'
34 '%I:%M %p'
35 ]
35 ]
36
36
37 ENCODINGS = %w(US-ASCII
37 ENCODINGS = %w(US-ASCII
38 windows-1250
38 windows-1250
39 windows-1251
39 windows-1251
40 windows-1252
40 windows-1252
41 windows-1253
41 windows-1253
42 windows-1254
42 windows-1254
43 windows-1255
43 windows-1255
44 windows-1256
44 windows-1256
45 windows-1257
45 windows-1257
46 windows-1258
46 windows-1258
47 windows-31j
47 windows-31j
48 ISO-2022-JP
48 ISO-2022-JP
49 ISO-2022-KR
49 ISO-2022-KR
50 ISO-8859-1
50 ISO-8859-1
51 ISO-8859-2
51 ISO-8859-2
52 ISO-8859-3
52 ISO-8859-3
53 ISO-8859-4
53 ISO-8859-4
54 ISO-8859-5
54 ISO-8859-5
55 ISO-8859-6
55 ISO-8859-6
56 ISO-8859-7
56 ISO-8859-7
57 ISO-8859-8
57 ISO-8859-8
58 ISO-8859-9
58 ISO-8859-9
59 ISO-8859-13
59 ISO-8859-13
60 ISO-8859-15
60 ISO-8859-15
61 KOI8-R
61 KOI8-R
62 UTF-8
62 UTF-8
63 UTF-16
63 UTF-16
64 UTF-16BE
64 UTF-16BE
65 UTF-16LE
65 UTF-16LE
66 EUC-JP
66 EUC-JP
67 Shift_JIS
67 Shift_JIS
68 GB18030
68 GB18030
69 GBK
69 GBK
70 ISCII91
70 ISCII91
71 EUC-KR
71 EUC-KR
72 Big5
72 Big5
73 Big5-HKSCS
73 Big5-HKSCS
74 TIS-620)
74 TIS-620)
75
75
76 cattr_accessor :available_settings
76 cattr_accessor :available_settings
77 @@available_settings = YAML::load(File.open("#{RAILS_ROOT}/config/settings.yml"))
77 @@available_settings = YAML::load(File.open("#{RAILS_ROOT}/config/settings.yml"))
78 Redmine::Plugin.all.each do |plugin|
78 Redmine::Plugin.all.each do |plugin|
79 next unless plugin.settings
79 next unless plugin.settings
80 @@available_settings["plugin_#{plugin.id}"] = {'default' => plugin.settings[:default], 'serialized' => true}
80 @@available_settings["plugin_#{plugin.id}"] = {'default' => plugin.settings[:default], 'serialized' => true}
81 end
81 end
82
82
83 validates_uniqueness_of :name
83 validates_uniqueness_of :name
84 validates_inclusion_of :name, :in => @@available_settings.keys
84 validates_inclusion_of :name, :in => @@available_settings.keys
85 validates_numericality_of :value, :only_integer => true, :if => Proc.new { |setting| @@available_settings[setting.name]['format'] == 'int' }
85 validates_numericality_of :value, :only_integer => true, :if => Proc.new { |setting| @@available_settings[setting.name]['format'] == 'int' }
86
86
87 # Hash used to cache setting values
87 # Hash used to cache setting values
88 @cached_settings = {}
88 @cached_settings = {}
89 @cached_cleared_on = Time.now
89 @cached_cleared_on = Time.now
90
90
91 def value
91 def value
92 v = read_attribute(:value)
92 v = read_attribute(:value)
93 # Unserialize serialized settings
93 # Unserialize serialized settings
94 v = YAML::load(v) if @@available_settings[name]['serialized'] && v.is_a?(String)
94 v = YAML::load(v) if @@available_settings[name]['serialized'] && v.is_a?(String)
95 v = v.to_sym if @@available_settings[name]['format'] == 'symbol' && !v.blank?
95 v = v.to_sym if @@available_settings[name]['format'] == 'symbol' && !v.blank?
96 v
96 v
97 end
97 end
98
98
99 def value=(v)
99 def value=(v)
100 v = v.to_yaml if v && @@available_settings[name]['serialized']
100 v = v.to_yaml if v && @@available_settings[name] && @@available_settings[name]['serialized']
101 write_attribute(:value, v.to_s)
101 write_attribute(:value, v.to_s)
102 end
102 end
103
103
104 # Returns the value of the setting named name
104 # Returns the value of the setting named name
105 def self.[](name)
105 def self.[](name)
106 v = @cached_settings[name]
106 v = @cached_settings[name]
107 v ? v : (@cached_settings[name] = find_or_default(name).value)
107 v ? v : (@cached_settings[name] = find_or_default(name).value)
108 end
108 end
109
109
110 def self.[]=(name, v)
110 def self.[]=(name, v)
111 setting = find_or_default(name)
111 setting = find_or_default(name)
112 setting.value = (v ? v : "")
112 setting.value = (v ? v : "")
113 @cached_settings[name] = nil
113 @cached_settings[name] = nil
114 setting.save
114 setting.save
115 setting.value
115 setting.value
116 end
116 end
117
117
118 # Defines getter and setter for each setting
118 # Defines getter and setter for each setting
119 # Then setting values can be read using: Setting.some_setting_name
119 # Then setting values can be read using: Setting.some_setting_name
120 # or set using Setting.some_setting_name = "some value"
120 # or set using Setting.some_setting_name = "some value"
121 @@available_settings.each do |name, params|
121 @@available_settings.each do |name, params|
122 src = <<-END_SRC
122 src = <<-END_SRC
123 def self.#{name}
123 def self.#{name}
124 self[:#{name}]
124 self[:#{name}]
125 end
125 end
126
126
127 def self.#{name}?
127 def self.#{name}?
128 self[:#{name}].to_i > 0
128 self[:#{name}].to_i > 0
129 end
129 end
130
130
131 def self.#{name}=(value)
131 def self.#{name}=(value)
132 self[:#{name}] = value
132 self[:#{name}] = value
133 end
133 end
134 END_SRC
134 END_SRC
135 class_eval src, __FILE__, __LINE__
135 class_eval src, __FILE__, __LINE__
136 end
136 end
137
137
138 # Helper that returns an array based on per_page_options setting
138 # Helper that returns an array based on per_page_options setting
139 def self.per_page_options_array
139 def self.per_page_options_array
140 per_page_options.split(%r{[\s,]}).collect(&:to_i).select {|n| n > 0}.sort
140 per_page_options.split(%r{[\s,]}).collect(&:to_i).select {|n| n > 0}.sort
141 end
141 end
142
142
143 def self.openid?
143 def self.openid?
144 Object.const_defined?(:OpenID) && self[:openid].to_i > 0
144 Object.const_defined?(:OpenID) && self[:openid].to_i > 0
145 end
145 end
146
146
147 # Checks if settings have changed since the values were read
147 # Checks if settings have changed since the values were read
148 # and clears the cache hash if it's the case
148 # and clears the cache hash if it's the case
149 # Called once per request
149 # Called once per request
150 def self.check_cache
150 def self.check_cache
151 settings_updated_on = Setting.maximum(:updated_on)
151 settings_updated_on = Setting.maximum(:updated_on)
152 if settings_updated_on && @cached_cleared_on <= settings_updated_on
152 if settings_updated_on && @cached_cleared_on <= settings_updated_on
153 @cached_settings.clear
153 @cached_settings.clear
154 @cached_cleared_on = Time.now
154 @cached_cleared_on = Time.now
155 logger.info "Settings cache cleared." if logger
155 logger.info "Settings cache cleared." if logger
156 end
156 end
157 end
157 end
158
158
159 private
159 private
160 # Returns the Setting instance for the setting named name
160 # Returns the Setting instance for the setting named name
161 # (record found in database or new record with default value)
161 # (record found in database or new record with default value)
162 def self.find_or_default(name)
162 def self.find_or_default(name)
163 name = name.to_s
163 name = name.to_s
164 raise "There's no setting named #{name}" unless @@available_settings.has_key?(name)
164 raise "There's no setting named #{name}" unless @@available_settings.has_key?(name)
165 setting = find_by_name(name)
165 setting = find_by_name(name)
166 setting ||= new(:name => name, :value => @@available_settings[name]['default']) if @@available_settings.has_key? name
166 setting ||= new(:name => name, :value => @@available_settings[name]['default']) if @@available_settings.has_key? name
167 end
167 end
168 end
168 end
General Comments 0
You need to be logged in to leave comments. Login now