jro_apps/redmine Commit - r15835:4a5ebfb77845

Fixed that Query#has_column? returns false with default columns....

Jean-Philippe Lang -

r15835:4a5ebfb77845

parent child

Context file:

r15835:4a5ebfb77845

app/models/query.rb +2 -1

               end
               def has_column?(column)
-                column_names && column_names.include?(column.is_a?(QueryColumn) ? column.name : column)
+                name = column.is_a?(QueryColumn) ? column.name : column
+                columns.detect {|c| c.name == name}
               end
               def has_custom_field_column?

test/unit/query_test.rb +8 0

                 assert !q.has_column?(category_column)
               end
+              def test_has_column_should_return_true_for_default_column
+                with_settings :issue_list_default_columns => %w(tracker subject) do
+                  q = IssueQuery.new
+                  assert q.has_column?(:tracker)
+                  assert !q.has_column?(:category)
+                end
+              end
               def test_inline_and_block_columns
                 q = IssueQuery.new
                 q.column_names = ['subject', 'description', 'tracker']

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages