jro_apps/redmine Commit - r3353:4878d749f499

Do not query git for tags and branches multiple times per request....

Jean-Philippe Lang -

r3353:4878d749f499

parent child

Context file:

r3353:4878d749f499

lib/redmine/scm/adapters/git_adapter.rb +6 -5

                      end
                      def branches
-                       branches = []
+                       return @branches if @branches
+                       @branches = []
                        cmd = "#{GIT_BIN} --git-dir #{target('')} branch"
                        shellout(cmd) do |io|
                          io.each_line do |line|
-                           branches << line.match('\s*\*?\s*(.*)$')[1]
+                           @branches << line.match('\s*\*?\s*(.*)$')[1]
                          end
                        end
-                       branches.sort!
+                       @branches.sort!
                      end
                      def tags
-                       tags = []
+                       return @tags if @tags
                        cmd = "#{GIT_BIN} --git-dir #{target('')} tag"
                        shellout(cmd) do |io|
-                         io.readlines.sort!.map{|t| t.strip}
+                         @tags = io.readlines.sort!.map{|t| t.strip}
                        end
                      end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages