jro_apps/redmine Commit - r11004:4620b8b8dbe1

Backported r11233 from trunk (#12833)....

Jean-Philippe Lang -

r11004:4620b8b8dbe1

parent child

Context file:

r11004:4620b8b8dbe1

Collapse all files

app/views/issues/_form.html.erb +1 -1

             <%= labelled_fields_for :issue, @issue do |f| %>
             <%= call_hook(:view_issues_form_details_top, { :issue => @issue, :form => f }) %>
             <% if @issue.safe_attribute? 'is_private' %>
             <p style="float:right; margin-right:1em;">
               <%= f.check_box :is_private, :no_label => true %><label class="inline" for="issue_is_private" id="issue_is_private_label"><%= l(:field_is_private) %></label>
             </p>
             <% end %>
             <% if @issue.safe_attribute? 'project_id' %>
             <p><%= f.select :project_id, project_tree_options_for_select(@issue.allowed_target_projects, :selected => @issue.project), {:required => true},
                             :onchange => "updateIssueFrom('#{escape_javascript project_issue_form_path(@project, :id => @issue, :format => 'js')}')" %></p>
             <% end %>
             <% if @issue.safe_attribute? 'tracker_id' %>
             <p><%= f.select :tracker_id, @issue.project.trackers.collect {|t| [t.name, t.id]}, {:required => true},
                             :onchange => "updateIssueFrom('#{escape_javascript project_issue_form_path(@project, :id => @issue, :format => 'js')}')" %></p>
             <% end %>
             <% if @issue.safe_attribute? 'subject' %>
-            <p><%= f.text_field :subject, :size => 80, :required => true %></p>
+            <p><%= f.text_field :subject, :size => 80, :maxlength => 255, :required => true %></p>
             <% end %>
             <% if @issue.safe_attribute? 'description' %>
             <p>
               <%= f.label_for_field :description, :required => @issue.required_attribute?('description') %>
               <%= link_to_function image_tag('edit.png'), '$(this).hide(); $("#issue_description_and_toolbar").show()' unless @issue.new_record? %>
               <%= content_tag 'span', :id => "issue_description_and_toolbar", :style => (@issue.new_record? ? nil : 'display:none') do %>
                 <%= f.text_area :description,
                                :cols => 60,
                                :rows => (@issue.description.blank? ? 10 : [[10, @issue.description.length / 50].max, 100].min),
                                :accesskey => accesskey(:edit),
                                :class => 'wiki-edit',
                                :no_label => true %>
               <% end %>
             </p>
             <%= wikitoolbar_for 'issue_description' %>
             <% end %>
             <div id="attributes" class="attributes">
               <%= render :partial => 'issues/attributes' %>
             </div>
             <%= call_hook(:view_issues_form_details_bottom, { :issue => @issue, :form => f }) %>
             <% end %>

app/views/timelog/_form.html.erb +1 -1

             <%= error_messages_for 'time_entry' %>
             <%= back_url_hidden_field_tag %>
             <div class="box tabular">
             	<% if @time_entry.new_record? %>
             	  <% if params[:project_id] || @time_entry.issue %>
             	    <%= f.hidden_field :project_id %>
             	  <% else %>
             	    <p><%= f.select :project_id, project_tree_options_for_select(Project.allowed_to(:log_time).all, :selected => @time_entry.project), :required => true %></p>
             	  <% end %>
             	<% end %>
             	<p><%= f.text_field :issue_id, :size => 6 %> <em><%= h("#{@time_entry.issue.tracker.name} ##{@time_entry.issue.id}: #{@time_entry.issue.subject}") if @time_entry.issue %></em></p>
             	<p><%= f.text_field :spent_on, :size => 10, :required => true %><%= calendar_for('time_entry_spent_on') %></p>
             	<p><%= f.text_field :hours, :size => 6, :required => true %></p>
-            	<p><%= f.text_field :comments, :size => 100 %></p>
+            	<p><%= f.text_field :comments, :size => 100, :maxlength => 255 %></p>
             	<p><%= f.select :activity_id, activity_collection_for_select_options(@time_entry), :required => true %></p>
             	<% @time_entry.custom_field_values.each do |value| %>
             	  <p><%= custom_field_tag_with_label :time_entry, value %></p>
             	<% end %>
             	<%= call_hook(:view_timelog_edit_form_bottom, { :time_entry => @time_entry, :form => f }) %>
             </div>
             <%= javascript_tag "observeAutocompleteField('time_entry_issue_id', '#{escape_javascript auto_complete_issues_path(:project_id => @project, :scope => (@project ? nil : 'all'))}')" %>

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages