jro_apps/redmine Commit - r8568:45e3dafa8fc7

Adds a <<me>> option at the top of the assignee drop-down (#1102)....

Jean-Philippe Lang -

r8568:45e3dafa8fc7

parent child

Context file:

r8568:45e3dafa8fc7

Collapse all files

app/helpers/application_helper.rb +3 0

               # Returns a string for users/groups option tags
               def principals_options_for_select(collection, selected=nil)
                 s = ''
+                if collection.include?(User.current)
+                  s << content_tag('option', "<< #{l(:label_me)} >>", :value => User.current.id)
+                end
                 groups = ''
                 collection.sort.each do |element|
                   selected_attribute = ' selected="selected"' if option_value_selected?(element, selected)

test/unit/helpers/application_helper_test.rb +9 0

               end
               def test_principals_options_for_select_with_users
+                User.current = nil
                 users = [User.find(2), User.find(4)]
                 assert_equal %(<option value="2">John Smith</option><option value="4">Robert Hill</option>),
                   principals_options_for_select(users)
               end
               def test_principals_options_for_select_with_selected
+                User.current = nil
                 users = [User.find(2), User.find(4)]
                 assert_equal %(<option value="2">John Smith</option><option value="4" selected="selected">Robert Hill</option>),
                   principals_options_for_select(users, User.find(4))
               end
               def test_principals_options_for_select_with_users_and_groups
+                User.current = nil
                 users = [User.find(2), Group.find(11), User.find(4), Group.find(10)]
                 assert_equal %(<option value="2">John Smith</option><option value="4">Robert Hill</option>) +
                   %(<optgroup label="Groups"><option value="10">A Team</option><option value="11">B Team</option></optgroup>),
               def test_principals_options_for_select_with_empty_collection
                 assert_equal '', principals_options_for_select([])
               end
+              def test_principals_options_for_select_should_include_me_option_when_current_user_is_in_collection
+                users = [User.find(2), User.find(4)]
+                User.current = User.find(4)
+                assert_include '<option value="4"><< me >></option>', principals_options_for_select(users)
+              end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages