##// END OF EJS Templates
Refactor: Extract similar logic in IssuesHelper#show_detail to a new method....
Eric Davis -
r3439:43e3c43cbdcf
parent child
Show More
@@ -1,199 +1,209
1 1 # redMine - project management software
2 2 # Copyright (C) 2006 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 module IssuesHelper
19 19 include ApplicationHelper
20 20
21 21 def render_issue_tooltip(issue)
22 22 @cached_label_start_date ||= l(:field_start_date)
23 23 @cached_label_due_date ||= l(:field_due_date)
24 24 @cached_label_assigned_to ||= l(:field_assigned_to)
25 25 @cached_label_priority ||= l(:field_priority)
26 26
27 27 link_to_issue(issue) + "<br /><br />" +
28 28 "<strong>#{@cached_label_start_date}</strong>: #{format_date(issue.start_date)}<br />" +
29 29 "<strong>#{@cached_label_due_date}</strong>: #{format_date(issue.due_date)}<br />" +
30 30 "<strong>#{@cached_label_assigned_to}</strong>: #{issue.assigned_to}<br />" +
31 31 "<strong>#{@cached_label_priority}</strong>: #{issue.priority.name}"
32 32 end
33 33
34 34 def render_custom_fields_rows(issue)
35 35 return if issue.custom_field_values.empty?
36 36 ordered_values = []
37 37 half = (issue.custom_field_values.size / 2.0).ceil
38 38 half.times do |i|
39 39 ordered_values << issue.custom_field_values[i]
40 40 ordered_values << issue.custom_field_values[i + half]
41 41 end
42 42 s = "<tr>\n"
43 43 n = 0
44 44 ordered_values.compact.each do |value|
45 45 s << "</tr>\n<tr>\n" if n > 0 && (n % 2) == 0
46 46 s << "\t<th>#{ h(value.custom_field.name) }:</th><td>#{ simple_format_without_paragraph(h(show_value(value))) }</td>\n"
47 47 n += 1
48 48 end
49 49 s << "</tr>\n"
50 50 s
51 51 end
52 52
53 53 def sidebar_queries
54 54 unless @sidebar_queries
55 55 # User can see public queries and his own queries
56 56 visible = ARCondition.new(["is_public = ? OR user_id = ?", true, (User.current.logged? ? User.current.id : 0)])
57 57 # Project specific queries and global queries
58 58 visible << (@project.nil? ? ["project_id IS NULL"] : ["project_id IS NULL OR project_id = ?", @project.id])
59 59 @sidebar_queries = Query.find(:all,
60 60 :select => 'id, name',
61 61 :order => "name ASC",
62 62 :conditions => visible.conditions)
63 63 end
64 64 @sidebar_queries
65 65 end
66 66
67 67 def show_detail(detail, no_html=false)
68 68 case detail.property
69 69 when 'attr'
70 label = l(("field_" + detail.prop_key.to_s.gsub(/\_id$/, "")).to_sym)
70 field = detail.prop_key.to_s.gsub(/\_id$/, "")
71 label = l(("field_" + field).to_sym)
71 72 case detail.prop_key
72 73 when 'due_date', 'start_date'
73 74 value = format_date(detail.value.to_date) if detail.value
74 75 old_value = format_date(detail.old_value.to_date) if detail.old_value
75 76 when 'project_id'
76 p = Project.find_by_id(detail.value) and value = p.name if detail.value
77 p = Project.find_by_id(detail.old_value) and old_value = p.name if detail.old_value
77 value = find_name_by_reflection(field, detail.value)
78 old_value = find_name_by_reflection(field, detail.old_value)
78 79 when 'status_id'
79 s = IssueStatus.find_by_id(detail.value) and value = s.name if detail.value
80 s = IssueStatus.find_by_id(detail.old_value) and old_value = s.name if detail.old_value
80 value = find_name_by_reflection(field, detail.value)
81 old_value = find_name_by_reflection(field, detail.old_value)
81 82 when 'tracker_id'
82 t = Tracker.find_by_id(detail.value) and value = t.name if detail.value
83 t = Tracker.find_by_id(detail.old_value) and old_value = t.name if detail.old_value
83 value = find_name_by_reflection(field, detail.value)
84 old_value = find_name_by_reflection(field, detail.old_value)
84 85 when 'assigned_to_id'
85 u = User.find_by_id(detail.value) and value = u.name if detail.value
86 u = User.find_by_id(detail.old_value) and old_value = u.name if detail.old_value
86 value = find_name_by_reflection(field, detail.value)
87 old_value = find_name_by_reflection(field, detail.old_value)
87 88 when 'priority_id'
88 e = IssuePriority.find_by_id(detail.value) and value = e.name if detail.value
89 e = IssuePriority.find_by_id(detail.old_value) and old_value = e.name if detail.old_value
89 value = find_name_by_reflection(field, detail.value)
90 old_value = find_name_by_reflection(field, detail.old_value)
90 91 when 'category_id'
91 c = IssueCategory.find_by_id(detail.value) and value = c.name if detail.value
92 c = IssueCategory.find_by_id(detail.old_value) and old_value = c.name if detail.old_value
92 value = find_name_by_reflection(field, detail.value)
93 old_value = find_name_by_reflection(field, detail.old_value)
93 94 when 'fixed_version_id'
94 v = Version.find_by_id(detail.value) and value = v.name if detail.value
95 v = Version.find_by_id(detail.old_value) and old_value = v.name if detail.old_value
95 value = find_name_by_reflection(field, detail.value)
96 old_value = find_name_by_reflection(field, detail.old_value)
96 97 when 'estimated_hours'
97 98 value = "%0.02f" % detail.value.to_f unless detail.value.blank?
98 99 old_value = "%0.02f" % detail.old_value.to_f unless detail.old_value.blank?
99 100 end
100 101 when 'cf'
101 102 custom_field = CustomField.find_by_id(detail.prop_key)
102 103 if custom_field
103 104 label = custom_field.name
104 105 value = format_value(detail.value, custom_field.field_format) if detail.value
105 106 old_value = format_value(detail.old_value, custom_field.field_format) if detail.old_value
106 107 end
107 108 when 'attachment'
108 109 label = l(:label_attachment)
109 110 end
110 111 call_hook(:helper_issues_show_detail_after_setting, {:detail => detail, :label => label, :value => value, :old_value => old_value })
111 112
112 113 label ||= detail.prop_key
113 114 value ||= detail.value
114 115 old_value ||= detail.old_value
115 116
116 117 unless no_html
117 118 label = content_tag('strong', label)
118 119 old_value = content_tag("i", h(old_value)) if detail.old_value
119 120 old_value = content_tag("strike", old_value) if detail.old_value and (!detail.value or detail.value.empty?)
120 121 if detail.property == 'attachment' && !value.blank? && a = Attachment.find_by_id(detail.prop_key)
121 122 # Link to the attachment if it has not been removed
122 123 value = link_to_attachment(a)
123 124 else
124 125 value = content_tag("i", h(value)) if value
125 126 end
126 127 end
127 128
128 129 if !detail.value.blank?
129 130 case detail.property
130 131 when 'attr', 'cf'
131 132 if !detail.old_value.blank?
132 133 l(:text_journal_changed, :label => label, :old => old_value, :new => value)
133 134 else
134 135 l(:text_journal_set_to, :label => label, :value => value)
135 136 end
136 137 when 'attachment'
137 138 l(:text_journal_added, :label => label, :value => value)
138 139 end
139 140 else
140 141 l(:text_journal_deleted, :label => label, :old => old_value)
141 142 end
142 143 end
144
145 # Find the name of an associated record stored in the field attribute
146 def find_name_by_reflection(field, id)
147 association = Issue.reflect_on_association(field.to_sym)
148 if association
149 record = association.class_name.constantize.find_by_id(id)
150 return record.name if record
151 end
152 end
143 153
144 154 def issues_to_csv(issues, project = nil)
145 155 ic = Iconv.new(l(:general_csv_encoding), 'UTF-8')
146 156 decimal_separator = l(:general_csv_decimal_separator)
147 157 export = FCSV.generate(:col_sep => l(:general_csv_separator)) do |csv|
148 158 # csv header fields
149 159 headers = [ "#",
150 160 l(:field_status),
151 161 l(:field_project),
152 162 l(:field_tracker),
153 163 l(:field_priority),
154 164 l(:field_subject),
155 165 l(:field_assigned_to),
156 166 l(:field_category),
157 167 l(:field_fixed_version),
158 168 l(:field_author),
159 169 l(:field_start_date),
160 170 l(:field_due_date),
161 171 l(:field_done_ratio),
162 172 l(:field_estimated_hours),
163 173 l(:field_created_on),
164 174 l(:field_updated_on)
165 175 ]
166 176 # Export project custom fields if project is given
167 177 # otherwise export custom fields marked as "For all projects"
168 178 custom_fields = project.nil? ? IssueCustomField.for_all : project.all_issue_custom_fields
169 179 custom_fields.each {|f| headers << f.name}
170 180 # Description in the last column
171 181 headers << l(:field_description)
172 182 csv << headers.collect {|c| begin; ic.iconv(c.to_s); rescue; c.to_s; end }
173 183 # csv lines
174 184 issues.each do |issue|
175 185 fields = [issue.id,
176 186 issue.status.name,
177 187 issue.project.name,
178 188 issue.tracker.name,
179 189 issue.priority.name,
180 190 issue.subject,
181 191 issue.assigned_to,
182 192 issue.category,
183 193 issue.fixed_version,
184 194 issue.author.name,
185 195 format_date(issue.start_date),
186 196 format_date(issue.due_date),
187 197 issue.done_ratio,
188 198 issue.estimated_hours.to_s.gsub('.', decimal_separator),
189 199 format_time(issue.created_on),
190 200 format_time(issue.updated_on)
191 201 ]
192 202 custom_fields.each {|f| fields << show_value(issue.custom_value_for(f)) }
193 203 fields << issue.description
194 204 csv << fields.collect {|c| begin; ic.iconv(c.to_s); rescue; c.to_s; end }
195 205 end
196 206 end
197 207 export
198 208 end
199 209 end
General Comments 0
You need to be logged in to leave comments. Login now