jro_apps/redmine Commit - r14587:430b0b7a812a

Don't set default due date in the past (#21488)....

Jean-Philippe Lang -

r14587:430b0b7a812a

parent child

Context file:

r14587:430b0b7a812a

Collapse all files

public/javascripts/application.js +7 -1

             /* Redmine - project management software
                Copyright (C) 2006-2015  Jean-Philippe Lang */
             function checkAll(id, checked) {
               $('#'+id).find('input[type=checkbox]:enabled').prop('checked', checked);
             }
             function toggleCheckboxesBySelector(selector) {
               var all_checked = true;
               $(selector).each(function(index) {
                 if (!$(this).is(':checked')) { all_checked = false; }
               });
               $(selector).prop('checked', !all_checked);
             }
             function showAndScrollTo(id, focus) {
               $('#'+id).show();
               if (focus !== null) {
                 $('#'+focus).focus();
               }
               $('html, body').animate({scrollTop: $('#'+id).offset().top}, 100);
             }
             function toggleRowGroup(el) {
               var tr = $(el).parents('tr').first();
               var n = tr.next();
               tr.toggleClass('open');
               while (n.length && !n.hasClass('group')) {
                 n.toggle();
                 n = n.next('tr');
               }
             }
             function collapseAllRowGroups(el) {
               var tbody = $(el).parents('tbody').first();
               tbody.children('tr').each(function(index) {
                 if ($(this).hasClass('group')) {
                   $(this).removeClass('open');
                 } else {
                   $(this).hide();
                 }
               });
             }
             function expandAllRowGroups(el) {
               var tbody = $(el).parents('tbody').first();
               tbody.children('tr').each(function(index) {
                 if ($(this).hasClass('group')) {
                   $(this).addClass('open');
                 } else {
                   $(this).show();
                 }
               });
             }
             function toggleAllRowGroups(el) {
               var tr = $(el).parents('tr').first();
               if (tr.hasClass('open')) {
                 collapseAllRowGroups(el);
               } else {
                 expandAllRowGroups(el);
               }
             }
             function toggleFieldset(el) {
               var fieldset = $(el).parents('fieldset').first();
               fieldset.toggleClass('collapsed');
               fieldset.children('div').toggle();
             }
             function hideFieldset(el) {
               var fieldset = $(el).parents('fieldset').first();
               fieldset.toggleClass('collapsed');
               fieldset.children('div').hide();
             }
             // columns selection
             function moveOptions(theSelFrom, theSelTo) {
               $(theSelFrom).find('option:selected').detach().prop("selected", false).appendTo($(theSelTo));
             }
             function moveOptionUp(theSel) {
               $(theSel).find('option:selected').each(function(){
                 $(this).prev(':not(:selected)').detach().insertAfter($(this));
               });
             }
             function moveOptionTop(theSel) {
               $(theSel).find('option:selected').detach().prependTo($(theSel));
             }
             function moveOptionDown(theSel) {
               $($(theSel).find('option:selected').get().reverse()).each(function(){
                 $(this).next(':not(:selected)').detach().insertBefore($(this));
               });
             }
             function moveOptionBottom(theSel) {
               $(theSel).find('option:selected').detach().appendTo($(theSel));
             }
             function initFilters() {
               $('#add_filter_select').change(function() {
                 addFilter($(this).val(), '', []);
               });
               $('#filters-table td.field input[type=checkbox]').each(function() {
                 toggleFilter($(this).val());
               });
               $('#filters-table').on('click', 'td.field input[type=checkbox]', function() {
                 toggleFilter($(this).val());
               });
               $('#filters-table').on('click', '.toggle-multiselect', function() {
                 toggleMultiSelect($(this).siblings('select'));
               });
               $('#filters-table').on('keypress', 'input[type=text]', function(e) {
                 if (e.keyCode == 13) $(this).closest('form').submit();
               });
             }
             function addFilter(field, operator, values) {
               var fieldId = field.replace('.', '_');
               var tr = $('#tr_'+fieldId);
               if (tr.length > 0) {
                 tr.show();
               } else {
                 buildFilterRow(field, operator, values);
               }
               $('#cb_'+fieldId).prop('checked', true);
               toggleFilter(field);
               $('#add_filter_select').val('').find('option').each(function() {
                 if ($(this).attr('value') == field) {
                   $(this).attr('disabled', true);
                 }
               });
             }
             function buildFilterRow(field, operator, values) {
               var fieldId = field.replace('.', '_');
               var filterTable = $("#filters-table");
               var filterOptions = availableFilters[field];
               if (!filterOptions) return;
               var operators = operatorByType[filterOptions['type']];
               var filterValues = filterOptions['values'];
               var i, select;
               var tr = $('<tr class="filter">').attr('id', 'tr_'+fieldId).html(
                 '<td class="field"><input checked="checked" id="cb_'+fieldId+'" name="f[]" value="'+field+'" type="checkbox"><label for="cb_'+fieldId+'"> '+filterOptions['name']+'</label></td>' +
                 '<td class="operator"><select id="operators_'+fieldId+'" name="op['+field+']"></td>' +
                 '<td class="values"></td>'
               );
               filterTable.append(tr);
               select = tr.find('td.operator select');
               for (i = 0; i < operators.length; i++) {
                 var option = $('<option>').val(operators[i]).text(operatorLabels[operators[i]]);
                 if (operators[i] == operator) { option.attr('selected', true); }
                 select.append(option);
               }
               select.change(function(){ toggleOperator(field); });
               switch (filterOptions['type']) {
               case "list":
               case "list_optional":
               case "list_status":
               case "list_subprojects":
                 tr.find('td.values').append(
                   '<span style="display:none;"><select class="value" id="values_'+fieldId+'_1" name="v['+field+'][]"></select>' +
                   ' <span class="toggle-multiselect">&nbsp;</span></span>'
                 );
                 select = tr.find('td.values select');
                 if (values.length > 1) { select.attr('multiple', true); }
                 for (i = 0; i < filterValues.length; i++) {
                   var filterValue = filterValues[i];
                   var option = $('<option>');
                   if ($.isArray(filterValue)) {
                     option.val(filterValue[1]).text(filterValue[0]);
                     if ($.inArray(filterValue[1], values) > -1) {option.attr('selected', true);}
                   } else {
                     option.val(filterValue).text(filterValue);
                     if ($.inArray(filterValue, values) > -1) {option.attr('selected', true);}
                   }
                   select.append(option);
                 }
                 break;
               case "date":
               case "date_past":
                 tr.find('td.values').append(
                   '<span style="display:none;"><input type="text" name="v['+field+'][]" id="values_'+fieldId+'_1" size="10" class="value date_value" /></span>' +
                   ' <span style="display:none;"><input type="text" name="v['+field+'][]" id="values_'+fieldId+'_2" size="10" class="value date_value" /></span>' +
                   ' <span style="display:none;"><input type="text" name="v['+field+'][]" id="values_'+fieldId+'" size="3" class="value" /> '+labelDayPlural+'</span>'
                 );
                 $('#values_'+fieldId+'_1').val(values[0]).datepicker(datepickerOptions);
                 $('#values_'+fieldId+'_2').val(values[1]).datepicker(datepickerOptions);
                 $('#values_'+fieldId).val(values[0]);
                 break;
               case "string":
               case "text":
                 tr.find('td.values').append(
                   '<span style="display:none;"><input type="text" name="v['+field+'][]" id="values_'+fieldId+'" size="30" class="value" /></span>'
                 );
                 $('#values_'+fieldId).val(values[0]);
                 break;
               case "relation":
                 tr.find('td.values').append(
                   '<span style="display:none;"><input type="text" name="v['+field+'][]" id="values_'+fieldId+'" size="6" class="value" /></span>' +
                   '<span style="display:none;"><select class="value" name="v['+field+'][]" id="values_'+fieldId+'_1"></select></span>'
                 );
                 $('#values_'+fieldId).val(values[0]);
                 select = tr.find('td.values select');
                 for (i = 0; i < allProjects.length; i++) {
                   var filterValue = allProjects[i];
                   var option = $('<option>');
                   option.val(filterValue[1]).text(filterValue[0]);
                   if (values[0] == filterValue[1]) { option.attr('selected', true); }
                   select.append(option);
                 }
                 break;
               case "integer":
               case "float":
               case "tree":
                 tr.find('td.values').append(
                   '<span style="display:none;"><input type="text" name="v['+field+'][]" id="values_'+fieldId+'_1" size="6" class="value" /></span>' +
                   ' <span style="display:none;"><input type="text" name="v['+field+'][]" id="values_'+fieldId+'_2" size="6" class="value" /></span>'
                 );
                 $('#values_'+fieldId+'_1').val(values[0]);
                 $('#values_'+fieldId+'_2').val(values[1]);
                 break;
               }
             }
             function toggleFilter(field) {
               var fieldId = field.replace('.', '_');
               if ($('#cb_' + fieldId).is(':checked')) {
                 $("#operators_" + fieldId).show().removeAttr('disabled');
                 toggleOperator(field);
               } else {
                 $("#operators_" + fieldId).hide().attr('disabled', true);
                 enableValues(field, []);
               }
             }
             function enableValues(field, indexes) {
               var fieldId = field.replace('.', '_');
               $('#tr_'+fieldId+' td.values .value').each(function(index) {
                 if ($.inArray(index, indexes) >= 0) {
                   $(this).removeAttr('disabled');
                   $(this).parents('span').first().show();
                 } else {
                   $(this).val('');
                   $(this).attr('disabled', true);
                   $(this).parents('span').first().hide();
                 }
                 if ($(this).hasClass('group')) {
                   $(this).addClass('open');
                 } else {
                   $(this).show();
                 }
               });
             }
             function toggleOperator(field) {
               var fieldId = field.replace('.', '_');
               var operator = $("#operators_" + fieldId);
               switch (operator.val()) {
                 case "!*":
                 case "*":
                 case "t":
                 case "ld":
                 case "w":
                 case "lw":
                 case "l2w":
                 case "m":
                 case "lm":
                 case "y":
                 case "o":
                 case "c":
                 case "*o":
                 case "!o":
                   enableValues(field, []);
                   break;
                 case "><":
                   enableValues(field, [0,1]);
                   break;
                 case "<t+":
                 case ">t+":
                 case "><t+":
                 case "t+":
                 case ">t-":
                 case "<t-":
                 case "><t-":
                 case "t-":
                   enableValues(field, [2]);
                   break;
                 case "=p":
                 case "=!p":
                 case "!p":
                   enableValues(field, [1]);
                   break;
                 default:
                   enableValues(field, [0]);
                   break;
               }
             }
             function toggleMultiSelect(el) {
               if (el.attr('multiple')) {
                 el.removeAttr('multiple');
                 el.attr('size', 1);
               } else {
                 el.attr('multiple', true);
                 if (el.children().length > 10)
                   el.attr('size', 10);
                 else
                   el.attr('size', 4);
               }
             }
             function showTab(name, url) {
               $('#tab-content-' + name).parent().find('.tab-content').hide();
               $('#tab-content-' + name).parent().find('div.tabs a').removeClass('selected');
               $('#tab-content-' + name).show();
               $('#tab-' + name).addClass('selected');
               //replaces current URL with the "href" attribute of the current link
               //(only triggered if supported by browser)
               if ("replaceState" in window.history) {
                 window.history.replaceState(null, document.title, url);
               }
               return false;
             }
             function moveTabRight(el) {
               var lis = $(el).parents('div.tabs').first().find('ul').children();
               var tabsWidth = 0;
               var i = 0;
               lis.each(function() {
                 if ($(this).is(':visible')) {
                   tabsWidth += $(this).width() + 6;
                 }
               });
               if (tabsWidth < $(el).parents('div.tabs').first().width() - 60) { return; }
               while (i<lis.length && !lis.eq(i).is(':visible')) { i++; }
               lis.eq(i).hide();
             }
             function moveTabLeft(el) {
               var lis = $(el).parents('div.tabs').first().find('ul').children();
               var i = 0;
               while (i < lis.length && !lis.eq(i).is(':visible')) { i++; }
               if (i > 0) {
                 lis.eq(i-1).show();
               }
             }
             function displayTabsButtons() {
               var lis;
               var tabsWidth;
               var el;
               $('div.tabs').each(function() {
                 el = $(this);
                 lis = el.find('ul').children();
                 tabsWidth = 0;
                 lis.each(function(){
                   if ($(this).is(':visible')) {
                     tabsWidth += $(this).width() + 6;
                   }
                 });
                 if ((tabsWidth < el.width() - 60) && (lis.first().is(':visible'))) {
                   el.find('div.tabs-buttons').hide();
                 } else {
                   el.find('div.tabs-buttons').show();
                 }
               });
             }
             function setPredecessorFieldsVisibility() {
               var relationType = $('#relation_relation_type');
               if (relationType.val() == "precedes" || relationType.val() == "follows") {
                 $('#predecessor_fields').show();
               } else {
                 $('#predecessor_fields').hide();
               }
             }
             function showModal(id, width, title) {
               var el = $('#'+id).first();
               if (el.length === 0 || el.is(':visible')) {return;}
               if (!title) title = el.find('h3.title').text();
               // moves existing modals behind the transparent background
               $(".modal").zIndex(99);
               el.dialog({
                 width: width,
                 modal: true,
                 resizable: false,
                 dialogClass: 'modal',
                 title: title
               }).on('dialogclose', function(){
                 $(".modal").zIndex(101);
               });
               el.find("input[type=text], input[type=submit]").first().focus();
             }
             function hideModal(el) {
               var modal;
               if (el) {
                 modal = $(el).parents('.ui-dialog-content');
               } else {
                 modal = $('#ajax-modal');
               }
               modal.dialog("close");
             }
             function submitPreview(url, form, target) {
               $.ajax({
                 url: url,
                 type: 'post',
                 data: $('#'+form).serialize(),
                 success: function(data){
                   $('#'+target).html(data);
                 }
               });
             }
             function collapseScmEntry(id) {
               $('.'+id).each(function() {
                 if ($(this).hasClass('open')) {
                   collapseScmEntry($(this).attr('id'));
                 }
                 $(this).hide();
               });
               $('#'+id).removeClass('open');
             }
             function expandScmEntry(id) {
               $('.'+id).each(function() {
                 $(this).show();
                 if ($(this).hasClass('loaded') && !$(this).hasClass('collapsed')) {
                   expandScmEntry($(this).attr('id'));
                 }
               });
               $('#'+id).addClass('open');
             }
             function scmEntryClick(id, url) {
                 var el = $('#'+id);
                 if (el.hasClass('open')) {
                     collapseScmEntry(id);
                     el.addClass('collapsed');
                     return false;
                 } else if (el.hasClass('loaded')) {
                     expandScmEntry(id);
                     el.removeClass('collapsed');
                     return false;
                 }
                 if (el.hasClass('loading')) {
                     return false;
                 }
                 el.addClass('loading');
                 $.ajax({
                   url: url,
                   success: function(data) {
                     el.after(data);
                     el.addClass('open').addClass('loaded').removeClass('loading');
                   }
                 });
                 return true;
             }
             function randomKey(size) {
               var chars = '0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz';
               var key = '';
               for (var i = 0; i < size; i++) {
                 key += chars.charAt(Math.floor(Math.random() * chars.length));
               }
               return key;
             }
             function updateIssueFrom(url, el) {
               $('#all_attributes input, #all_attributes textarea, #all_attributes select').each(function(){
                 $(this).data('valuebeforeupdate', $(this).val());
               });
               if (el) {
                 $("#form_update_triggered_by").val($(el).attr('id'));
               }
               return $.ajax({
                 url: url,
                 type: 'post',
                 data: $('#issue-form').serialize()
               });
             }
             function replaceIssueFormWith(html){
               var replacement = $(html);
               $('#all_attributes input, #all_attributes textarea, #all_attributes select').each(function(){
                 var object_id = $(this).attr('id');
                 if (object_id && $(this).data('valuebeforeupdate')!=$(this).val()) {
                   replacement.find('#'+object_id).val($(this).val());
                 }
               });
               $('#all_attributes').empty();
               $('#all_attributes').prepend(replacement);
             }
             function updateBulkEditFrom(url) {
               $.ajax({
                 url: url,
                 type: 'post',
                 data: $('#bulk_edit_form').serialize()
               });
             }
             function observeAutocompleteField(fieldId, url, options) {
               $(document).ready(function() {
                 $('#'+fieldId).autocomplete($.extend({
                   source: url,
                   minLength: 2,
                   search: function(){$('#'+fieldId).addClass('ajax-loading');},
                   response: function(){$('#'+fieldId).removeClass('ajax-loading');}
                 }, options));
                 $('#'+fieldId).addClass('autocomplete');
               });
             }
             function observeSearchfield(fieldId, targetId, url) {
               $('#'+fieldId).each(function() {
                 var $this = $(this);
                 $this.addClass('autocomplete');
                 $this.attr('data-value-was', $this.val());
                 var check = function() {
                   var val = $this.val();
                   if ($this.attr('data-value-was') != val){
                     $this.attr('data-value-was', val);
                     $.ajax({
                       url: url,
                       type: 'get',
                       data: {q: $this.val()},
                       success: function(data){ if(targetId) $('#'+targetId).html(data); },
                       beforeSend: function(){ $this.addClass('ajax-loading'); },
                       complete: function(){ $this.removeClass('ajax-loading'); }
                     });
                   }
                 };
                 var reset = function() {
                   if (timer) {
                     clearInterval(timer);
                     timer = setInterval(check, 300);
                   }
                 };
                 var timer = setInterval(check, 300);
                 $this.bind('keyup click mousemove', reset);
               });
             }
             function beforeShowDatePicker(input, inst) {
               var default_date = null;
               switch ($(input).attr("id")) {
                 case "issue_start_date" :
                   if ($("#issue_due_date").size() > 0) {
                     default_date = $("#issue_due_date").val();
                   }
                   break;
                 case "issue_due_date" :
                   if ($("#issue_start_date").size() > 0) {
-                    default_date = $("#issue_start_date").val();
+                    var start_date = $("#issue_start_date").val();
+                    if (start_date != "") {
+                      start_date = new Date(Date.parse(start_date));
+                      if (start_date > new Date()) {
+                        default_date = $("#issue_start_date").val();
+                      }
+                    }
                   }
                   break;
               }
               $(input).datepicker("option", "defaultDate", default_date);
             }
             function initMyPageSortable(list, url) {
               $('#list-'+list).sortable({
                 connectWith: '.block-receiver',
                 tolerance: 'pointer',
                 update: function(){
                   $.ajax({
                     url: url,
                     type: 'post',
                     data: {'blocks': $.map($('#list-'+list).children(), function(el){return $(el).attr('id');})}
                   });
                 }
               });
               $("#list-top, #list-left, #list-right").disableSelection();
             }
             var warnLeavingUnsavedMessage;
             function warnLeavingUnsaved(message) {
               warnLeavingUnsavedMessage = message;
               $(document).on('submit', 'form', function(){
                 $('textarea').removeData('changed');
               });
               $(document).on('change', 'textarea', function(){
                 $(this).data('changed', 'changed');
               });
               window.onbeforeunload = function(){
                 var warn = false;
                 $('textarea').blur().each(function(){
                   if ($(this).data('changed')) {
                     warn = true;
                   }
                 });
                 if (warn) {return warnLeavingUnsavedMessage;}
               };
             }
             function setupAjaxIndicator() {
               $(document).bind('ajaxSend', function(event, xhr, settings) {
                 if ($('.ajax-loading').length === 0 && settings.contentType != 'application/octet-stream') {
                   $('#ajax-indicator').show();
                 }
               });
               $(document).bind('ajaxStop', function() {
                 $('#ajax-indicator').hide();
               });
             }
             function hideOnLoad() {
               $('.hol').hide();
             }
             function addFormObserversForDoubleSubmit() {
               $('form[method=post]').each(function() {
                 if (!$(this).hasClass('multiple-submit')) {
                   $(this).submit(function(form_submission) {
                     if ($(form_submission.target).attr('data-submitted')) {
                       form_submission.preventDefault();
                     } else {
                       $(form_submission.target).attr('data-submitted', true);
                     }
                   });
                 }
               });
             }
             function defaultFocus(){
               if (($('#content :focus').length == 0) && (window.location.hash == '')) {
                 $('#content input[type=text], #content textarea').first().focus();
               }
             }
             function blockEventPropagation(event) {
               event.stopPropagation();
               event.preventDefault();
             }
             function toggleDisabledOnChange() {
               var checked = $(this).is(':checked');
               $($(this).data('disables')).attr('disabled', checked);
               $($(this).data('enables')).attr('disabled', !checked);
             }
             function toggleDisabledInit() {
               $('input[data-disables], input[data-enables]').each(toggleDisabledOnChange);
             }
             $(document).ready(function(){
               $('#content').on('change', 'input[data-disables], input[data-enables]', toggleDisabledOnChange);
               toggleDisabledInit();
             });
             function keepAnchorOnSignIn(form){
               var hash = decodeURIComponent(self.document.location.hash);
               if (hash) {
                 if (hash.indexOf("#") === -1) {
                   hash = "#" + hash;
                 }
                 form.action = form.action + hash;
               }
               return true;
             }
             $(document).ready(setupAjaxIndicator);
             $(document).ready(hideOnLoad);
             $(document).ready(addFormObserversForDoubleSubmit);
             $(document).ready(defaultFocus);

test/ui/issues_test_ui.rb +17 -2

             # Redmine - project management software
             # Copyright (C) 2006-2015  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../base', __FILE__)
             class Redmine::UiTest::IssuesTest < Redmine::UiTest::Base
               fixtures :projects, :users, :email_addresses, :roles, :members, :member_roles,
                        :trackers, :projects_trackers, :enabled_modules, :issue_statuses, :issues,
                        :enumerations, :custom_fields, :custom_values, :custom_fields_trackers,
                        :watchers, :journals, :journal_details
               def test_create_issue
                 log_user('jsmith', 'jsmith')
                 visit '/projects/ecookbook/issues/new'
                 within('form#issue-form') do
                   select 'Bug', :from => 'Tracker'
                   select 'Low', :from => 'Priority'
                   fill_in 'Subject', :with => 'new test issue'
                   fill_in 'Description', :with => 'new issue'
                   select '0 %', :from => 'Done'
                   fill_in 'Due date', :with => ''
                   fill_in 'Searchable field', :with => 'Value for field 2'
                   # click_button 'Create' would match both 'Create' and 'Create and continue' buttons
                   find('input[name=commit]').click
                 end
                 # find created issue
                 issue = Issue.find_by_subject("new test issue")
                 assert_kind_of Issue, issue
                 # check redirection
                 find 'div#flash_notice', :visible => true, :text => "Issue \##{issue.id} created."
                 assert_equal issue_path(:id => issue), current_path
                 # check issue attributes
                 assert_equal 'jsmith', issue.author.login
                 assert_equal 1, issue.project.id
                 assert_equal IssueStatus.find_by_name('New'), issue.status
                 assert_equal Tracker.find_by_name('Bug'), issue.tracker
                 assert_equal IssuePriority.find_by_name('Low'), issue.priority
                 assert_equal 'Value for field 2', issue.custom_field_value(CustomField.find_by_name('Searchable field'))
               end
               def test_create_issue_with_form_update
                 field1 = IssueCustomField.create!(
                   :field_format => 'string',
                   :name => 'Field1',
                   :is_for_all => true,
                   :trackers => Tracker.where(:id => [1, 2])
                 )
                 field2 = IssueCustomField.create!(
                   :field_format => 'string',
                   :name => 'Field2',
                   :is_for_all => true,
                   :trackers => Tracker.where(:id => 2)
                 )
                 Role.non_member.add_permission! :add_issues
                 Role.non_member.remove_permission! :edit_issues, :add_issue_notes
                 log_user('someone', 'foo')
                 visit '/projects/ecookbook/issues/new'
                 assert page.has_no_content?(field2.name)
                 assert page.has_content?(field1.name)
                 fill_in 'Subject', :with => 'New test issue'
                 fill_in 'Description', :with => 'New test issue description'
                 fill_in field1.name, :with => 'CF1 value'
                 select 'Low', :from => 'Priority'
                 # field2 should show up when changing tracker
                 select 'Feature request', :from => 'Tracker'
                 assert page.has_content?(field2.name)
                 assert page.has_content?(field1.name)
                 fill_in field2.name, :with => 'CF2 value'
                 assert_difference 'Issue.count' do
                   page.first(:button, 'Create').click
                 end
                 issue = Issue.order('id desc').first
                 assert_equal 'New test issue', issue.subject
                 assert_equal 'New test issue description', issue.description
                 assert_equal 'Low', issue.priority.name
                 assert_equal 'CF1 value', issue.custom_field_value(field1)
                 assert_equal 'CF2 value', issue.custom_field_value(field2)
               end
               def test_create_issue_with_watchers
                 user = User.generate!(:firstname => 'Some', :lastname => 'Watcher')
                 assert_equal 'Some Watcher', user.name
                 log_user('jsmith', 'jsmith')
                 visit '/projects/ecookbook/issues/new'
                 fill_in 'Subject', :with => 'Issue with watchers'
                 # Add a project member as watcher
                 check 'Dave Lopper'
                 # Search for another user
                 assert page.has_no_css?('form#new-watcher-form')
                 assert page.has_no_content?('Some Watcher')
                 click_link 'Search for watchers to add'
                 within('form#new-watcher-form') do
                   fill_in 'user_search', :with => 'watch'
                   assert page.has_content?('Some Watcher')
                   check 'Some Watcher'
                   click_button 'Add'
                 end
                 assert page.has_css?('form#issue-form')
                 assert page.has_css?('p#watchers_form')
                 using_wait_time(30) do
                   within('span#watchers_inputs') do
                     within("label#issue_watcher_user_ids_#{user.id}") do
                       assert has_content?('Some Watcher'), "No watcher content"
                     end
                   end
                 end
                 assert_difference 'Issue.count' do
                   find('input[name=commit]').click
                 end
                 issue = Issue.order('id desc').first
                 assert_equal ['Dave Lopper', 'Some Watcher'], issue.watcher_users.map(&:name).sort
               end
               def test_create_issue_start_due_date
                 with_settings :default_issue_start_date_to_creation_date => 0 do
                   log_user('jsmith', 'jsmith')
                   visit '/projects/ecookbook/issues/new'
                   assert_equal "", page.find('input#issue_start_date').value
                   assert_equal "", page.find('input#issue_due_date').value
                   page.first('p#start_date_area img').click
                   page.first("td.ui-datepicker-days-cell-over a").click
                   assert_equal Date.today.to_s, page.find('input#issue_start_date').value
                   page.first('p#due_date_area img').click
                   page.first("td.ui-datepicker-days-cell-over a").click
                   assert_equal Date.today.to_s, page.find('input#issue_due_date').value
                 end
               end
-              def test_create_issue_start_due_date_default
+              def test_default_due_date_proposed_in_date_picker
                 log_user('jsmith', 'jsmith')
                 visit '/projects/ecookbook/issues/new'
+                # Future start date: due date should default to start date
+                fill_in 'Start date', :with => '2027-04-01'
+                fill_in 'Due date', :with => ''
+                page.first('p#due_date_area img').click
+                page.first("td.ui-datepicker-days-cell-over a").click
+                assert_equal '2027-04-01', page.find('input#issue_due_date').value
+                # Passed start date: due date should default to today
                 fill_in 'Start date', :with => '2012-04-01'
                 fill_in 'Due date', :with => ''
                 page.first('p#due_date_area img').click
                 page.first("td.ui-datepicker-days-cell-over a").click
-                assert_equal '2012-04-01', page.find('input#issue_due_date').value
+                assert_equal Date.today.to_s, page.find('input#issue_due_date').value
+              end
+              def test_default_start_date_proposed_in_date_picker
+                log_user('jsmith', 'jsmith')
+                visit '/projects/ecookbook/issues/new'
+                # Passed due date: start date should default to due date
                 fill_in 'Start date', :with => ''
                 fill_in 'Due date', :with => '2012-04-01'
                 page.first('p#start_date_area img').click
                 page.first("td.ui-datepicker-days-cell-over a").click
                 assert_equal '2012-04-01', page.find('input#issue_start_date').value
               end
               def test_preview_issue_description
                 log_user('jsmith', 'jsmith')
                 visit '/projects/ecookbook/issues/new'
                 within('form#issue-form') do
                   fill_in 'Subject', :with => 'new issue subject'
                   fill_in 'Description', :with => 'new issue description'
                   click_link 'Preview'
                 end
                 find 'div#preview fieldset', :visible => true, :text => 'new issue description'
                 assert_difference 'Issue.count' do
                   find('input[name=commit]').click
                 end
                 issue = Issue.order('id desc').first
                 assert_equal 'new issue description', issue.description
               end
               def test_update_issue_with_form_update
                 field = IssueCustomField.create!(
                   :field_format => 'string',
                   :name => 'Form update CF',
                   :is_for_all => true,
                   :trackers => Tracker.where(:name => 'Feature request')
                 )
                 Role.non_member.add_permission! :edit_issues
                 Role.non_member.remove_permission! :add_issues, :add_issue_notes
                 log_user('someone', 'foo')
                 visit '/issues/1'
                 assert page.has_no_content?('Form update CF')
                 page.first(:link, 'Edit').click
                 # the custom field should show up when changing tracker
                 select 'Feature request', :from => 'Tracker'
                 assert page.has_content?('Form update CF')
                 fill_in 'Form update', :with => 'CF value'
                 assert_no_difference 'Issue.count' do
                   page.first(:button, 'Submit').click
                 end
                 issue = Issue.find(1)
                 assert_equal 'CF value', issue.custom_field_value(field)
               end
               def test_remove_issue_watcher_from_sidebar
                 user = User.find(3)
                 Watcher.create!(:watchable => Issue.find(1), :user => user)
                 log_user('jsmith', 'jsmith')
                 visit '/issues/1'
                 assert page.first('#sidebar').has_content?('Watchers (1)')
                 assert page.first('#sidebar').has_content?(user.name)
                 assert_difference 'Watcher.count', -1 do
                   page.first('ul.watchers .user-3 a.delete').click
                   assert page.first('#sidebar').has_content?('Watchers (0)')
                 end
                 assert page.first('#sidebar').has_no_content?(user.name)
               end
               def test_watch_should_update_watchers_list
                 user = User.find(2)
                 log_user('jsmith', 'jsmith')
                 visit '/issues/1'
                 assert page.first('#sidebar').has_content?('Watchers (0)')
                 page.first('a.issue-1-watcher').click
                 assert page.first('#sidebar').has_content?('Watchers (1)')
                 assert page.first('#sidebar').has_content?(user.name)
               end
               def test_watch_issue_via_context_menu
                 log_user('jsmith', 'jsmith')
                 visit '/issues'
                 assert page.has_css?('tr#issue-1')
                 find('tr#issue-1 td.updated_on').click
                 page.execute_script "$('tr#issue-1 td.updated_on').trigger('contextmenu');"
                 assert_difference 'Watcher.count' do
                   within('#context-menu') do
                     click_link 'Watch'
                   end
                   # wait for ajax response
                   assert page.has_css?('#context-menu .issue-1-watcher.icon-fav')
                   assert page.has_css?('tr#issue-1')
                 end
                 assert Issue.find(1).watched_by?(User.find_by_login('jsmith'))
               end
               def test_bulk_watch_issues_via_context_menu
                 log_user('jsmith', 'jsmith')
                 visit '/issues'
                 assert page.has_css?('tr#issue-1')
                 assert page.has_css?('tr#issue-4')
                 find('tr#issue-1 input[type=checkbox]').click
                 find('tr#issue-4 input[type=checkbox]').click
                 page.execute_script "$('tr#issue-1 td.updated_on').trigger('contextmenu');"
                 assert_difference 'Watcher.count', 2 do
                   within('#context-menu') do
                     click_link 'Watch'
                   end
                   # wait for ajax response
                   assert page.has_css?('#context-menu .issue-bulk-watcher.icon-fav')
                   assert page.has_css?('tr#issue-1')
                   assert page.has_css?('tr#issue-4')
                 end
                 assert Issue.find(1).watched_by?(User.find_by_login('jsmith'))
                 assert Issue.find(4).watched_by?(User.find_by_login('jsmith'))
               end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages