jro_apps/redmine Commit - r15169:42e8ff4493e5

1

# encoding: utf-8

1

# encoding: utf-8

2

#

2

#

3

# Redmine - project management software

3

# Redmine - project management software

4

5

#

5

#

6

# This program is free software; you can redistribute it and/or

6

# This program is free software; you can redistribute it and/or

7

# modify it under the terms of the GNU General Public License

7

# modify it under the terms of the GNU General Public License

8

# as published by the Free Software Foundation; either version 2

8

# as published by the Free Software Foundation; either version 2

9

# of the License, or (at your option) any later version.

9

# of the License, or (at your option) any later version.

10

#

10

#

11

# This program is distributed in the hope that it will be useful,

11

# This program is distributed in the hope that it will be useful,

12

# but WITHOUT ANY WARRANTY; without even the implied warranty of

12

# but WITHOUT ANY WARRANTY; without even the implied warranty of

13

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

13

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

14

# GNU General Public License for more details.

14

# GNU General Public License for more details.

15

#

15

#

16

# You should have received a copy of the GNU General Public License

16

# You should have received a copy of the GNU General Public License

17

# along with this program; if not, write to the Free Software

17

# along with this program; if not, write to the Free Software

18

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

18

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

19

20

module IssuesHelper

20

module IssuesHelper

21

include ApplicationHelper

21

include ApplicationHelper

22

include Redmine::Export::PDF::IssuesPdfHelper

22

include Redmine::Export::PDF::IssuesPdfHelper

23

24

def issue_list(issues, &block)

24

def issue_list(issues, &block)

25

ancestors = []

25

ancestors = []

26

issues.each do |issue|

26

issues.each do |issue|

27

while (ancestors.any? && !issue.is_descendant_of?(ancestors.last))

27

while (ancestors.any? && !issue.is_descendant_of?(ancestors.last))

28

ancestors.pop

28

ancestors.pop

29

end

29

end

30

yield issue, ancestors.size

30

yield issue, ancestors.size

31

ancestors << issue unless issue.leaf?

31

ancestors << issue unless issue.leaf?

32

end

32

end

33

end

33

end

34

35

def grouped_issue_list(issues, query, issue_count_by_group, &block)

35

def grouped_issue_list(issues, query, issue_count_by_group, &block)

36

previous_group, first = false, true

36

previous_group, first = false, true

37

totals_by_group = query.totalable_columns.inject({}) do |h, column|

37

totals_by_group = query.totalable_columns.inject({}) do |h, column|

38

h[column] = query.total_by_group_for(column)

38

h[column] = query.total_by_group_for(column)

39

h

39

h

40

end

40

end

41

issue_list(issues) do |issue, level|

41

issue_list(issues) do |issue, level|

42

group_name = group_count = nil

42

group_name = group_count = nil

43

if query.grouped?

43

if query.grouped?

44

group = query.group_by_column.value(issue)

44

group = query.group_by_column.value(issue)

45

if first || group != previous_group

45

if first || group != previous_group

46

if group.blank? && group != false

46

if group.blank? && group != false

47

group_name = "(#{l(:label_blank_value)})"

47

group_name = "(#{l(:label_blank_value)})"

48

else

48

else

49

group_name = format_object(group)

49

group_name = format_object(group)

50

end

50

end

51

group_name ||= ""

51

group_name ||= ""

52

group_count = issue_count_by_group[group]

52

group_count = issue_count_by_group[group]

53

group_totals = totals_by_group.map {|column, t| total_tag(column, t[group] || 0)}.join(" ").html_safe

53

group_totals = totals_by_group.map {|column, t| total_tag(column, t[group] || 0)}.join(" ").html_safe

54

end

54

end

55

end

55

end

56

yield issue, level, group_name, group_count, group_totals

56

yield issue, level, group_name, group_count, group_totals

57

previous_group, first = group, false

57

previous_group, first = group, false

58

end

58

end

59

end

59

end

60

61

# Renders a HTML/CSS tooltip

61

# Renders a HTML/CSS tooltip

62

#

62

#

63

# To use, a trigger div is needed. This is a div with the class of "tooltip"

63

# To use, a trigger div is needed. This is a div with the class of "tooltip"

64

# that contains this method wrapped in a span with the class of "tip"

64

# that contains this method wrapped in a span with the class of "tip"

65

#

65

#

66

# <div class="tooltip"><%= link_to_issue(issue) %>

66

# <div class="tooltip"><%= link_to_issue(issue) %>

67

# <span class="tip"><%= render_issue_tooltip(issue) %></span>

67

# <span class="tip"><%= render_issue_tooltip(issue) %></span>

68

# </div>

68

# </div>

69

#

69

#

70

def render_issue_tooltip(issue)

70

def render_issue_tooltip(issue)

71

@cached_label_status ||= l(:field_status)

71

@cached_label_status ||= l(:field_status)

72

@cached_label_start_date ||= l(:field_start_date)

72

@cached_label_start_date ||= l(:field_start_date)

73

@cached_label_due_date ||= l(:field_due_date)

73

@cached_label_due_date ||= l(:field_due_date)

74

@cached_label_assigned_to ||= l(:field_assigned_to)

74

@cached_label_assigned_to ||= l(:field_assigned_to)

75

@cached_label_priority ||= l(:field_priority)

75

@cached_label_priority ||= l(:field_priority)

76

@cached_label_project ||= l(:field_project)

76

@cached_label_project ||= l(:field_project)

77

78

link_to_issue(issue) + "<br /><br />".html_safe +

78

link_to_issue(issue) + "<br /><br />".html_safe +

79

"<strong>#{@cached_label_project}</strong>: #{link_to_project(issue.project)}<br />".html_safe +

79

"<strong>#{@cached_label_project}</strong>: #{link_to_project(issue.project)}<br />".html_safe +

80

"<strong>#{@cached_label_status}</strong>: #{h(issue.status.name)}<br />".html_safe +

80

"<strong>#{@cached_label_status}</strong>: #{h(issue.status.name)}<br />".html_safe +

81

"<strong>#{@cached_label_start_date}</strong>: #{format_date(issue.start_date)}<br />".html_safe +

81

"<strong>#{@cached_label_start_date}</strong>: #{format_date(issue.start_date)}<br />".html_safe +

82

"<strong>#{@cached_label_due_date}</strong>: #{format_date(issue.due_date)}<br />".html_safe +

82

"<strong>#{@cached_label_due_date}</strong>: #{format_date(issue.due_date)}<br />".html_safe +

83

"<strong>#{@cached_label_assigned_to}</strong>: #{h(issue.assigned_to)}<br />".html_safe +

83

"<strong>#{@cached_label_assigned_to}</strong>: #{h(issue.assigned_to)}<br />".html_safe +

84

"<strong>#{@cached_label_priority}</strong>: #{h(issue.priority.name)}".html_safe

84

"<strong>#{@cached_label_priority}</strong>: #{h(issue.priority.name)}".html_safe

85

end

85

end

86

87

def issue_heading(issue)

87

def issue_heading(issue)

88

h("#{issue.tracker} ##{issue.id}")

88

h("#{issue.tracker} ##{issue.id}")

89

end

89

end

90

91

def render_issue_subject_with_tree(issue)

91

def render_issue_subject_with_tree(issue)

92

s = ''

92

s = ''

93

ancestors = issue.root? ? [] : issue.ancestors.visible.to_a

93

ancestors = issue.root? ? [] : issue.ancestors.visible.to_a

94

ancestors.each do |ancestor|

94

ancestors.each do |ancestor|

95

s << '<div>' + content_tag('p', link_to_issue(ancestor, :project => (issue.project_id != ancestor.project_id)))

95

s << '<div>' + content_tag('p', link_to_issue(ancestor, :project => (issue.project_id != ancestor.project_id)))

96

end

96

end

97

s << '<div>'

97

s << '<div>'

98

subject = h(issue.subject)

98

subject = h(issue.subject)

99

if issue.is_private?

99

if issue.is_private?

100

subject = content_tag('span', l(:field_is_private), :class => 'private') + ' ' + subject

100

subject = content_tag('span', l(:field_is_private), :class => 'private') + ' ' + subject

101

end

101

end

102

s << content_tag('h3', subject)

102

s << content_tag('h3', subject)

103

s << '</div>' * (ancestors.size + 1)

103

s << '</div>' * (ancestors.size + 1)

104

s.html_safe

104

s.html_safe

105

end

105

end

106

107

def render_descendants_tree(issue)

107

def render_descendants_tree(issue)

108

s = '<form><table class="list issues">'

108

s = '<form><table class="list issues">'

109

issue_list(issue.descendants.visible.preload(:status, :priority, :tracker, :assigned_to).sort_by(&:lft)) do |child, level|

109

issue_list(issue.descendants.visible.preload(:status, :priority, :tracker, :assigned_to).sort_by(&:lft)) do |child, level|

110

css = "issue issue-#{child.id} hascontextmenu #{issue.css_classes}"

110

css = "issue issue-#{child.id} hascontextmenu #{issue.css_classes}"

111

css << " idnt idnt-#{level}" if level > 0

111

css << " idnt idnt-#{level}" if level > 0

112

s << content_tag('tr',

112

s << content_tag('tr',

113

content_tag('td', check_box_tag("ids[]", child.id, false, :id => nil), :class => 'checkbox') +

113

content_tag('td', check_box_tag("ids[]", child.id, false, :id => nil), :class => 'checkbox') +

114

content_tag('td', link_to_issue(child, :project => (issue.project_id != child.project_id)), :class => 'subject', :style => 'width: 50%') +

114

content_tag('td', link_to_issue(child, :project => (issue.project_id != child.project_id)), :class => 'subject', :style => 'width: 50%') +

115

content_tag('td', h(child.status), :class => 'status') +

115

content_tag('td', h(child.status), :class => 'status') +

116

content_tag('td', link_to_user(child.assigned_to), :class => 'assigned_to') +

116

content_tag('td', link_to_user(child.assigned_to), :class => 'assigned_to') +

117

content_tag('td', child.disabled_core_fields.include?('done_ratio') ? '' : progress_bar(child.done_ratio), :class=> 'done_ratio'),

117

content_tag('td', child.disabled_core_fields.include?('done_ratio') ? '' : progress_bar(child.done_ratio), :class=> 'done_ratio'),

118

:class => css)

118

:class => css)

119

end

119

end

120

s << '</table></form>'

120

s << '</table></form>'

121

s.html_safe

121

s.html_safe

122

end

122

end

123

124

def issue_estimated_hours_details(issue)

124

def issue_estimated_hours_details(issue)

125

if issue.total_estimated_hours.present?

125

if issue.total_estimated_hours.present?

126

if issue.total_estimated_hours == issue.estimated_hours

126

if issue.total_estimated_hours == issue.estimated_hours

127

l_hours_short(issue.estimated_hours)

127

l_hours_short(issue.estimated_hours)

128

else

128

else

129

s = issue.estimated_hours.present? ? l_hours_short(issue.estimated_hours) : ""

129

s = issue.estimated_hours.present? ? l_hours_short(issue.estimated_hours) : ""

130

s << " (#{l(:label_total)}: #{l_hours_short(issue.total_estimated_hours)})"

130

s << " (#{l(:label_total)}: #{l_hours_short(issue.total_estimated_hours)})"

131

s.html_safe

131

s.html_safe

132

end

132

end

133

end

133

end

134

end

134

end

135

136

def issue_spent_hours_details(issue)

136

def issue_spent_hours_details(issue)

137

if issue.total_spent_hours > 0

137

if issue.total_spent_hours > 0

138

if issue.total_spent_hours == issue.spent_hours

138

if issue.total_spent_hours == issue.spent_hours

139

link_to(l_hours_short(issue.spent_hours), issue_time_entries_path(issue))

139

link_to(l_hours_short(issue.spent_hours), issue_time_entries_path(issue))

140

else

140

else

141

s = issue.spent_hours > 0 ? l_hours_short(issue.spent_hours) : ""

141

s = issue.spent_hours > 0 ? l_hours_short(issue.spent_hours) : ""

142

s << " (#{l(:label_total)}: #{link_to l_hours_short(issue.total_spent_hours), issue_time_entries_path(issue)})"

142

s << " (#{l(:label_total)}: #{link_to l_hours_short(issue.total_spent_hours), issue_time_entries_path(issue)})"

143

s.html_safe

143

s.html_safe

144

end

144

end

145

end

145

end

146

end

146

end

147

148

# Returns an array of error messages for bulk edited issues

148

# Returns an array of error messages for bulk edited issues

149

def bulk_edit_error_messages(issues)

149

def bulk_edit_error_messages(issues)

150

messages = {}

150

messages = {}

151

issues.each do |issue|

151

issues.each do |issue|

152

issue.errors.full_messages.each do |message|

152

issue.errors.full_messages.each do |message|

153

messages[message] ||= []

153

messages[message] ||= []

154

messages[message] << issue

154

messages[message] << issue

155

end

155

end

156

end

156

end

157

messages.map { |message, issues|

157

messages.map { |message, issues|

158

"#{message}: " + issues.map {|i| "##{i.id}"}.join(', ')

158

"#{message}: " + issues.map {|i| "##{i.id}"}.join(', ')

159

}

159

}

160

end

160

end

161

162

# Returns a link for adding a new subtask to the given issue

162

# Returns a link for adding a new subtask to the given issue

163

def link_to_new_subtask(issue)

163

def link_to_new_subtask(issue)

164

attrs = {

164

attrs = {

165

:parent_issue_id => issue

165

:parent_issue_id => issue

166

}

166

}

167

attrs[:tracker_id] = issue.tracker unless issue.tracker.disabled_core_fields.include?('parent_issue_id')

167

attrs[:tracker_id] = issue.tracker unless issue.tracker.disabled_core_fields.include?('parent_issue_id')

168

link_to(l(:button_add), new_project_issue_path(issue.project, :issue => attrs))

168

link_to(l(:button_add), new_project_issue_path(issue.project, :issue => attrs))

169

end

169

end

170

171

def trackers_options_for_select(issue)

171

def trackers_options_for_select(issue)

172

trackers = issue.allowed_target_trackers

172

trackers = issue.allowed_target_trackers

173

if issue.new_record? && issue.parent_issue_id.present?

173

if issue.new_record? && issue.parent_issue_id.present?

174

trackers = trackers.reject do |tracker|

174

trackers = trackers.reject do |tracker|

175

issue.tracker_id != tracker.id && tracker.disabled_core_fields.include?('parent_issue_id')

175

issue.tracker_id != tracker.id && tracker.disabled_core_fields.include?('parent_issue_id')

176

end

176

end

177

end

177

end

178

trackers.collect {|t| [t.name, t.id]}

178

trackers.collect {|t| [t.name, t.id]}

179

end

179

end

180

181

class IssueFieldsRows

181

class IssueFieldsRows

182

include ActionView::Helpers::TagHelper

182

include ActionView::Helpers::TagHelper

183

184

def initialize

184

def initialize

185

@left = []

185

@left = []

186

@right = []

186

@right = []

187

end

187

end

188

189

def left(*args)

189

def left(*args)

190

args.any? ? @left << cells(*args) : @left

190

args.any? ? @left << cells(*args) : @left

191

end

191

end

192

193

def right(*args)

193

def right(*args)

194

args.any? ? @right << cells(*args) : @right

194

args.any? ? @right << cells(*args) : @right

195

end

195

end

196

197

def size

197

def size

198

@left.size > @right.size ? @left.size : @right.size

198

@left.size > @right.size ? @left.size : @right.size

199

end

199

end

200

201

def to_html

201

def to_html

202

content =

202

content =

203

content_tag('div', @left.reduce(&:+), :class => 'splitcontentleft') +

203

content_tag('div', @left.reduce(&:+), :class => 'splitcontentleft') +

204

content_tag('div', @right.reduce(&:+), :class => 'splitcontentleft')

204

content_tag('div', @right.reduce(&:+), :class => 'splitcontentleft')

205

206

content_tag('div', content, :class => 'splitcontent')

206

content_tag('div', content, :class => 'splitcontent')

207

end

207

end

208

209

def cells(label, text, options={})

209

def cells(label, text, options={})

210

options[:class] = [options[:class] || "", 'attribute'].join(' ')

210

options[:class] = [options[:class] || "", 'attribute'].join(' ')

211

content_tag 'div',

211

content_tag 'div',

212

content_tag('div', label + ":", :class => 'label') + content_tag('div', text, :class => 'value'),

212

content_tag('div', label + ":", :class => 'label') + content_tag('div', text, :class => 'value'),

213

options

213

options

214

end

214

end

215

end

215

end

216

217

def issue_fields_rows

217

def issue_fields_rows

218

r = IssueFieldsRows.new

218

r = IssueFieldsRows.new

219

yield r

219

yield r

220

r.to_html

220

r.to_html

221

end

221

end

222

223

def render_custom_fields_rows(issue)

223

def render_custom_fields_rows(issue)

224

values = issue.visible_custom_field_values

224

values = issue.visible_custom_field_values

225

return if values.empty?

225

return if values.empty?

226

half = (values.size / 2.0).ceil

226

half = (values.size / 2.0).ceil

227

issue_fields_rows do |rows|

227

issue_fields_rows do |rows|

228

values.each_with_index do |value, i|

228

values.each_with_index do |value, i|

229

css = "cf_#{value.custom_field.id}"

229

css = "cf_#{value.custom_field.id}"

230

m = (i < half ? :left : :right)

230

m = (i < half ? :left : :right)

231

rows.send m, custom_field_name_tag(value.custom_field), show_value(value), :class => css

231

rows.send m, custom_field_name_tag(value.custom_field), show_value(value), :class => css

232

end

232

end

233

end

233

end

234

end

234

end

235

236

# Returns the path for updating the issue form

236

# Returns the path for updating the issue form

237

# with project as the current project

237

# with project as the current project

238

def update_issue_form_path(project, issue)

238

def update_issue_form_path(project, issue)

239

options = {:format => 'js'}

239

options = {:format => 'js'}

240

if issue.new_record?

240

if issue.new_record?

241

if project

241

if project

242

new_project_issue_path(project, options)

242

new_project_issue_path(project, options)

243

else

243

else

244

new_issue_path(options)

244

new_issue_path(options)

245

end

245

end

246

else

246

else

247

edit_issue_path(issue, options)

247

edit_issue_path(issue, options)

248

end

248

end

249

end

249

end

250

251

# Returns the number of descendants for an array of issues

251

# Returns the number of descendants for an array of issues

252

def issues_descendant_count(issues)

252

def issues_descendant_count(issues)

253

ids = issues.reject(&:leaf?).map {|issue| issue.descendants.ids}.flatten.uniq

253

ids = issues.reject(&:leaf?).map {|issue| issue.descendants.ids}.flatten.uniq

254

ids -= issues.map(&:id)

254

ids -= issues.map(&:id)

255

ids.size

255

ids.size

256

end

256

end

257

258

def issues_destroy_confirmation_message(issues)

258

def issues_destroy_confirmation_message(issues)

259

issues = [issues] unless issues.is_a?(Array)

259

issues = [issues] unless issues.is_a?(Array)

260

message = l(:text_issues_destroy_confirmation)

260

message = l(:text_issues_destroy_confirmation)

261

262

descendant_count = issues_descendant_count(issues)

262

descendant_count = issues_descendant_count(issues)

263

if descendant_count > 0

263

if descendant_count > 0

264

message << "\n" + l(:text_issues_destroy_descendants_confirmation, :count => descendant_count)

264

message << "\n" + l(:text_issues_destroy_descendants_confirmation, :count => descendant_count)

265

end

265

end

266

message

266

message

267

end

267

end

268

269

# Returns an array of users that are proposed as watchers

269

# Returns an array of users that are proposed as watchers

270

# on the new issue form

270

# on the new issue form

271

def users_for_new_issue_watchers(issue)

271

def users_for_new_issue_watchers(issue)

272

users = issue.watcher_users

272

users = issue.watcher_users

273

if issue.project.users.count <= 20

273

if issue.project.users.count <= 20

274

users = (users + issue.project.users.sort).uniq

274

users = (users + issue.project.users.sort).uniq

275

end

275

end

276

users

276

users

277

end

277

end

278

279

def sidebar_queries

279

def sidebar_queries

280

unless @sidebar_queries

280

unless @sidebar_queries

281

@sidebar_queries = IssueQuery.visible.

281

@sidebar_queries = IssueQuery.visible.

282

order("#{Query.table_name}.name ASC").

282

order("#{Query.table_name}.name ASC").

283

# Project specific queries and global queries

283

# Project specific queries and global queries

284

where(@project.nil? ? ["project_id IS NULL"] : ["project_id IS NULL OR project_id = ?", @project.id]).

284

where(@project.nil? ? ["project_id IS NULL"] : ["project_id IS NULL OR project_id = ?", @project.id]).

285

to_a

285

to_a

286

end

286

end

287

@sidebar_queries

287

@sidebar_queries

288

end

288

end

289

290

def query_links(title, queries)

290

def query_links(title, queries)

291

return '' if queries.empty?

291

return '' if queries.empty?

292

# links to #index on issues/show

292

# links to #index on issues/show

293

url_params = controller_name == 'issues' ? {:controller => 'issues', :action => 'index', :project_id => @project} : params

293

url_params = controller_name == 'issues' ? {:controller => 'issues', :action => 'index', :project_id => @project} : params

294

295

content_tag('h3', title) + "\n" +

295

content_tag('h3', title) + "\n" +

296

content_tag('ul',

296

content_tag('ul',

297

queries.collect {|query|

297

queries.collect {|query|

298

css = 'query'

298

css = 'query'

299

css << ' selected' if query == @query

299

css << ' selected' if query == @query

300

content_tag('li', link_to(query.name, url_params.merge(:query_id => query), :class => css))

300

content_tag('li', link_to(query.name, url_params.merge(:query_id => query), :class => css))

301

}.join("\n").html_safe,

301

}.join("\n").html_safe,

302

:class => 'queries'

302

:class => 'queries'

303

) + "\n"

303

) + "\n"

304

end

304

end

305

306

def render_sidebar_queries

306

def render_sidebar_queries

307

out = ''.html_safe

307

out = ''.html_safe

308

out << query_links(l(:label_my_queries), sidebar_queries.select(&:is_private?))

308

out << query_links(l(:label_my_queries), sidebar_queries.select(&:is_private?))

309

out << query_links(l(:label_query_plural), sidebar_queries.reject(&:is_private?))

309

out << query_links(l(:label_query_plural), sidebar_queries.reject(&:is_private?))

310

out

310

out

311

end

311

end

312

313

def email_issue_attributes(issue, user)

313

def email_issue_attributes(issue, user)

314

items = []

314

items = []

315

%w(author status priority assigned_to category fixed_version).each do |attribute|

315

%w(author status priority assigned_to category fixed_version).each do |attribute|

316

unless issue.disabled_core_fields.include?(attribute+"_id")

316

unless issue.disabled_core_fields.include?(attribute+"_id")

317

items << "#{l("field_#{attribute}")}: #{issue.send attribute}"

317

items << "#{l("field_#{attribute}")}: #{issue.send attribute}"

318

end

318

end

319

end

319

end

320

issue.visible_custom_field_values(user).each do |value|

320

issue.visible_custom_field_values(user).each do |value|

321

items << "#{value.custom_field.name}: #{show_value(value, false)}"

321

items << "#{value.custom_field.name}: #{show_value(value, false)}"

322

end

322

end

323

items

323

items

324

end

324

end

325

326

def render_email_issue_attributes(issue, user, html=false)

326

def render_email_issue_attributes(issue, user, html=false)

327

items = email_issue_attributes(issue, user)

327

items = email_issue_attributes(issue, user)

328

if html

328

if html

329

content_tag('ul', items.map{|s| content_tag('li', s)}.join("\n").html_safe)

329

content_tag('ul', items.map{|s| content_tag('li', s)}.join("\n").html_safe)

330

else

330

else

331

items.map{|s| "* #{s}"}.join("\n")

331

items.map{|s| "* #{s}"}.join("\n")

332

end

332

end

333

end

333

end

334

335

# Returns the textual representation of a journal details

335

# Returns the textual representation of a journal details

336

# as an array of strings

336

# as an array of strings

337

def details_to_strings(details, no_html=false, options={})

337

def details_to_strings(details, no_html=false, options={})

338

options[:only_path] = (options[:only_path] == false ? false : true)

338

options[:only_path] = (options[:only_path] == false ? false : true)

339

strings = []

339

strings = []

340

values_by_field = {}

340

values_by_field = {}

341

details.each do |detail|

341

details.each do |detail|

342

if detail.property == 'cf'

342

if detail.property == 'cf'

343

field = detail.custom_field

343

field = detail.custom_field

344

if field && field.multiple?

344

if field && field.multiple?

345

values_by_field[field] ||= {:added => [], :deleted => []}

345

values_by_field[field] ||= {:added => [], :deleted => []}

346

if detail.old_value

346

if detail.old_value

347

values_by_field[field][:deleted] << detail.old_value

347

values_by_field[field][:deleted] << detail.old_value

348

end

348

end

349

if detail.value

349

if detail.value

350

values_by_field[field][:added] << detail.value

350

values_by_field[field][:added] << detail.value

351

end

351

end

352

end

353

end

354

end

354

end

355

strings << show_detail(detail, no_html, options)

355

strings << show_detail(detail, no_html, options)

356

end

356

end

357

if values_by_field.present?

357

if values_by_field.present?

358

multiple_values_detail = Struct.new(:property, :prop_key, :custom_field, :old_value, :value)

358

multiple_values_detail = Struct.new(:property, :prop_key, :custom_field, :old_value, :value)

359

values_by_field.each do |field, changes|

359

values_by_field.each do |field, changes|

360

if changes[:added].any?

360

if changes[:added].any?

361

detail = multiple_values_detail.new('cf', field.id.to_s, field)

361

detail = multiple_values_detail.new('cf', field.id.to_s, field)

362

detail.value = changes[:added]

362

detail.value = changes[:added]

363

strings << show_detail(detail, no_html, options)

363

strings << show_detail(detail, no_html, options)

364

end

364

end

365

if changes[:deleted].any?

365

if changes[:deleted].any?

366

detail = multiple_values_detail.new('cf', field.id.to_s, field)

366

detail = multiple_values_detail.new('cf', field.id.to_s, field)

367

detail.old_value = changes[:deleted]

367

detail.old_value = changes[:deleted]

368

strings << show_detail(detail, no_html, options)

368

strings << show_detail(detail, no_html, options)

369

end

369

end

370

end

370

end

371

end

371

end

372

strings

372

strings

373

end

373

end

374

375

# Returns the textual representation of a single journal detail

375

# Returns the textual representation of a single journal detail

376

def show_detail(detail, no_html=false, options={})

376

def show_detail(detail, no_html=false, options={})

377

multiple = false

377

multiple = false

378

show_diff = false

378

show_diff = false

379

380

case detail.property

380

case detail.property

381

when 'attr'

381

when 'attr'

382

field = detail.prop_key.to_s.gsub(/\_id$/, "")

382

field = detail.prop_key.to_s.gsub(/\_id$/, "")

383

label = l(("field_" + field).to_sym)

383

label = l(("field_" + field).to_sym)

384

case detail.prop_key

384

case detail.prop_key

385

when 'due_date', 'start_date'

385

when 'due_date', 'start_date'

386

value = format_date(detail.value.to_date) if detail.value

386

value = format_date(detail.value.to_date) if detail.value

387

old_value = format_date(detail.old_value.to_date) if detail.old_value

387

old_value = format_date(detail.old_value.to_date) if detail.old_value

388

389

when 'project_id', 'status_id', 'tracker_id', 'assigned_to_id',

389

when 'project_id', 'status_id', 'tracker_id', 'assigned_to_id',

390

'priority_id', 'category_id', 'fixed_version_id'

390

'priority_id', 'category_id', 'fixed_version_id'

391

value = find_name_by_reflection(field, detail.value)

391

value = find_name_by_reflection(field, detail.value)

392

old_value = find_name_by_reflection(field, detail.old_value)

392

old_value = find_name_by_reflection(field, detail.old_value)

393

394

when 'estimated_hours'

394

when 'estimated_hours'

395

value = l_hours_short(detail.value.to_f) unless detail.value.blank?

395

value = l_hours_short(detail.value.to_f) unless detail.value.blank?

396

old_value = l_hours_short(detail.old_value.to_f) unless detail.old_value.blank?

396

old_value = l_hours_short(detail.old_value.to_f) unless detail.old_value.blank?

397

398

when 'parent_id'

398

when 'parent_id'

399

label = l(:field_parent_issue)

399

label = l(:field_parent_issue)

400

value = "##{detail.value}" unless detail.value.blank?

400

value = "##{detail.value}" unless detail.value.blank?

401

old_value = "##{detail.old_value}" unless detail.old_value.blank?

401

old_value = "##{detail.old_value}" unless detail.old_value.blank?

402

403

when 'is_private'

403

when 'is_private'

404

value = l(detail.value == "0" ? :general_text_No : :general_text_Yes) unless detail.value.blank?

404

value = l(detail.value == "0" ? :general_text_No : :general_text_Yes) unless detail.value.blank?

405

old_value = l(detail.old_value == "0" ? :general_text_No : :general_text_Yes) unless detail.old_value.blank?

405

old_value = l(detail.old_value == "0" ? :general_text_No : :general_text_Yes) unless detail.old_value.blank?

406

407

when 'description'

407

when 'description'

408

show_diff = true

408

show_diff = true

409

end

409

end

410

when 'cf'

410

when 'cf'

411

custom_field = detail.custom_field

411

custom_field = detail.custom_field

412

if custom_field

412

if custom_field

413

label = custom_field.name

413

label = custom_field.name

414

if custom_field.format.class.change_as_diff

414

if custom_field.format.class.change_as_diff

415

show_diff = true

415

show_diff = true

416

else

416

else

417

multiple = custom_field.multiple?

417

multiple = custom_field.multiple?

418

value = format_value(detail.value, custom_field) if detail.value

418

value = format_value(detail.value, custom_field) if detail.value

419

old_value = format_value(detail.old_value, custom_field) if detail.old_value

419

old_value = format_value(detail.old_value, custom_field) if detail.old_value

420

end

420

end

421

end

421

end

422

when 'attachment'

422

when 'attachment'

423

label = l(:label_attachment)

423

label = l(:label_attachment)

424

when 'relation'

424

when 'relation'

425

if detail.value && !detail.old_value

425

if detail.value && !detail.old_value

426

rel_issue = Issue.visible.find_by_id(detail.value)

426

rel_issue = Issue.visible.find_by_id(detail.value)

427

value = rel_issue.nil? ? "#{l(:label_issue)} ##{detail.value}" :

427

value = rel_issue.nil? ? "#{l(:label_issue)} ##{detail.value}" :

428

(no_html ? rel_issue : link_to_issue(rel_issue, :only_path => options[:only_path]))

428

(no_html ? rel_issue : link_to_issue(rel_issue, :only_path => options[:only_path]))

429

elsif detail.old_value && !detail.value

429

elsif detail.old_value && !detail.value

430

rel_issue = Issue.visible.find_by_id(detail.old_value)

430

rel_issue = Issue.visible.find_by_id(detail.old_value)

431

old_value = rel_issue.nil? ? "#{l(:label_issue)} ##{detail.old_value}" :

431

old_value = rel_issue.nil? ? "#{l(:label_issue)} ##{detail.old_value}" :

432

(no_html ? rel_issue : link_to_issue(rel_issue, :only_path => options[:only_path]))

432

(no_html ? rel_issue : link_to_issue(rel_issue, :only_path => options[:only_path]))

433

end

433

end

434

relation_type = IssueRelation::TYPES[detail.prop_key]

434

relation_type = IssueRelation::TYPES[detail.prop_key]

435

label = l(relation_type[:name]) if relation_type

435

label = l(relation_type[:name]) if relation_type

436

end

436

end

437

call_hook(:helper_issues_show_detail_after_setting,

437

call_hook(:helper_issues_show_detail_after_setting,

438

{:detail => detail, :label => label, :value => value, :old_value => old_value })

438

{:detail => detail, :label => label, :value => value, :old_value => old_value })

439

440

label ||= detail.prop_key

440

label ||= detail.prop_key

441

value ||= detail.value

441

value ||= detail.value

442

old_value ||= detail.old_value

442

old_value ||= detail.old_value

443

444

unless no_html

444

unless no_html

445

label = content_tag('strong', label)

445

label = content_tag('strong', label)

446

old_value = content_tag("i", h(old_value)) if detail.old_value

446

old_value = content_tag("i", h(old_value)) if detail.old_value

447

if detail.old_value && detail.value.blank? && detail.property != 'relation'

447

if detail.old_value && detail.value.blank? && detail.property != 'relation'

448

old_value = content_tag("del", old_value)

448

old_value = content_tag("del", old_value)

449

end

449

end

450

if detail.property == 'attachment' && value.present? &&

450

if detail.property == 'attachment' && value.present? &&

451

atta = detail.journal.journalized.attachments.detect {|a| a.id == detail.prop_key.to_i}

451

atta = detail.journal.journalized.attachments.detect {|a| a.id == detail.prop_key.to_i}

452

# Link to the attachment if it has not been removed

452

# Link to the attachment if it has not been removed

453

value = link_to_attachment(atta, :download => true, :only_path => options[:only_path])

453

value = link_to_attachment(atta, :download => true, :only_path => options[:only_path])

454

if options[:only_path] != false && atta.is_text?

454

if options[:only_path] != false && (atta.is_text? || atta.is_image?)

455

value += ' '

455

value += link_to(l(:button_view),

456

value += link_to(l(:button_view),

456

{ :controller => 'attachments', :action => 'show',

457

{ :controller => 'attachments', :action => 'show',

457

:id => atta, :filename => atta.filename },

458

:id => atta, :filename => atta.filename },

458

:class => 'icon-only icon-magnifier',

459

:class => 'icon-only icon-magnifier',

459

:title => l(:button_view))

460

:title => l(:button_view))

460

end

461

end

461

else

462

else

462

value = content_tag("i", h(value)) if value

463

value = content_tag("i", h(value)) if value

463

end

464

end

464

end

465

end

465

466

if show_diff

467

if show_diff

467

s = l(:text_journal_changed_no_detail, :label => label)

468

s = l(:text_journal_changed_no_detail, :label => label)

468

unless no_html

469

unless no_html

469

diff_link = link_to 'diff',

470

diff_link = link_to 'diff',

470

diff_journal_url(detail.journal_id, :detail_id => detail.id, :only_path => options[:only_path]),

471

diff_journal_url(detail.journal_id, :detail_id => detail.id, :only_path => options[:only_path]),

471

:title => l(:label_view_diff)

472

:title => l(:label_view_diff)

472

s << " (#{ diff_link })"

473

s << " (#{ diff_link })"

473

end

474

end

474

s.html_safe

475

s.html_safe

475

elsif detail.value.present?

476

elsif detail.value.present?

476

case detail.property

477

case detail.property

477

when 'attr', 'cf'

478

when 'attr', 'cf'

478

if detail.old_value.present?

479

if detail.old_value.present?

479

l(:text_journal_changed, :label => label, :old => old_value, :new => value).html_safe

480

l(:text_journal_changed, :label => label, :old => old_value, :new => value).html_safe

480

elsif multiple

481

elsif multiple

481

l(:text_journal_added, :label => label, :value => value).html_safe

482

l(:text_journal_added, :label => label, :value => value).html_safe

482

else

483

else

483

l(:text_journal_set_to, :label => label, :value => value).html_safe

484

l(:text_journal_set_to, :label => label, :value => value).html_safe

484

end

485

end

485

when 'attachment', 'relation'

486

when 'attachment', 'relation'

486

l(:text_journal_added, :label => label, :value => value).html_safe

487

l(:text_journal_added, :label => label, :value => value).html_safe

487

end

488

end

488

else

489

else

489

l(:text_journal_deleted, :label => label, :old => old_value).html_safe

490

l(:text_journal_deleted, :label => label, :old => old_value).html_safe

490

end

491

end

491

end

492

end

492

493

# Find the name of an associated record stored in the field attribute

494

# Find the name of an associated record stored in the field attribute

494

def find_name_by_reflection(field, id)

495

def find_name_by_reflection(field, id)

495

unless id.present?

496

unless id.present?

496

return nil

497

return nil

497

end

498

end

498

@detail_value_name_by_reflection ||= Hash.new do |hash, key|

499

@detail_value_name_by_reflection ||= Hash.new do |hash, key|

499

association = Issue.reflect_on_association(key.first.to_sym)

500

association = Issue.reflect_on_association(key.first.to_sym)

500

name = nil

501

name = nil

501

if association

502

if association

502

record = association.klass.find_by_id(key.last)

503

record = association.klass.find_by_id(key.last)

503

if record

504

if record

504

name = record.name.force_encoding('UTF-8')

505

name = record.name.force_encoding('UTF-8')

505

end

506

end

506

end

507

end

507

hash[key] = name

508

hash[key] = name

508

end

509

end

509

@detail_value_name_by_reflection[[field, id]]

510

@detail_value_name_by_reflection[[field, id]]

510

end

511

end

511

512

# Renders issue children recursively

513

# Renders issue children recursively

513

def render_api_issue_children(issue, api)

514

def render_api_issue_children(issue, api)

514

return if issue.leaf?

515

return if issue.leaf?

515

api.array :children do

516

api.array :children do

516

issue.children.each do |child|

517

issue.children.each do |child|

517

api.issue(:id => child.id) do

518

api.issue(:id => child.id) do

518

api.tracker(:id => child.tracker_id, :name => child.tracker.name) unless child.tracker.nil?

519

api.tracker(:id => child.tracker_id, :name => child.tracker.name) unless child.tracker.nil?

519

api.subject child.subject

520

api.subject child.subject

520

render_api_issue_children(child, api)

521

render_api_issue_children(child, api)

521

end

522

end

522

end

523

end

523

end

524

end

524

end

525

end

525

end

526

end

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

             # encoding: utf-8
             #
             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             module IssuesHelper
               include ApplicationHelper
               include Redmine::Export::PDF::IssuesPdfHelper
               def issue_list(issues, &block)
                 ancestors = []
                 issues.each do |issue|
                   while (ancestors.any? && !issue.is_descendant_of?(ancestors.last))
                     ancestors.pop
                   end
                   yield issue, ancestors.size
                   ancestors << issue unless issue.leaf?
                 end
               end
               def grouped_issue_list(issues, query, issue_count_by_group, &block)
                 previous_group, first = false, true
                 totals_by_group = query.totalable_columns.inject({}) do |h, column|
                   h[column] = query.total_by_group_for(column)
                   h
                 end
                 issue_list(issues) do |issue, level|
                   group_name = group_count = nil
                   if query.grouped?
                     group = query.group_by_column.value(issue)
                     if first || group != previous_group
                       if group.blank? && group != false
                         group_name = "(#{l(:label_blank_value)})"
                       else
                         group_name = format_object(group)
                       end
                       group_name ||= ""
                       group_count = issue_count_by_group[group]
                       group_totals = totals_by_group.map {|column, t| total_tag(column, t[group] || 0)}.join(" ").html_safe
                     end
                   end
                   yield issue, level, group_name, group_count, group_totals
                   previous_group, first = group, false
                 end
               end
               # Renders a HTML/CSS tooltip
               #
               # To use, a trigger div is needed.  This is a div with the class of "tooltip"
               # that contains this method wrapped in a span with the class of "tip"
               #
               #    <div class="tooltip"><%= link_to_issue(issue) %>
               #      <span class="tip"><%= render_issue_tooltip(issue) %></span>
               #    </div>
               #
               def render_issue_tooltip(issue)
                 @cached_label_status ||= l(:field_status)
                 @cached_label_start_date ||= l(:field_start_date)
                 @cached_label_due_date ||= l(:field_due_date)
                 @cached_label_assigned_to ||= l(:field_assigned_to)
                 @cached_label_priority ||= l(:field_priority)
                 @cached_label_project ||= l(:field_project)
                 link_to_issue(issue) + "<br /><br />".html_safe +
                   "<strong>#{@cached_label_project}</strong>: #{link_to_project(issue.project)}<br />".html_safe +
                   "<strong>#{@cached_label_status}</strong>: #{h(issue.status.name)}<br />".html_safe +
                   "<strong>#{@cached_label_start_date}</strong>: #{format_date(issue.start_date)}<br />".html_safe +
                   "<strong>#{@cached_label_due_date}</strong>: #{format_date(issue.due_date)}<br />".html_safe +
                   "<strong>#{@cached_label_assigned_to}</strong>: #{h(issue.assigned_to)}<br />".html_safe +
                   "<strong>#{@cached_label_priority}</strong>: #{h(issue.priority.name)}".html_safe
               end
               def issue_heading(issue)
                 h("#{issue.tracker} ##{issue.id}")
               end
               def render_issue_subject_with_tree(issue)
                 s = ''
                 ancestors = issue.root? ? [] : issue.ancestors.visible.to_a
                 ancestors.each do |ancestor|
                   s << '<div>' + content_tag('p', link_to_issue(ancestor, :project => (issue.project_id != ancestor.project_id)))
                 end
                 s << '<div>'
                 subject = h(issue.subject)
                 if issue.is_private?
                   subject = content_tag('span', l(:field_is_private), :class => 'private') + ' ' + subject
                 end
                 s << content_tag('h3', subject)
                 s << '</div>' * (ancestors.size + 1)
                 s.html_safe
               end
               def render_descendants_tree(issue)
                 s = '<form><table class="list issues">'
                 issue_list(issue.descendants.visible.preload(:status, :priority, :tracker, :assigned_to).sort_by(&:lft)) do |child, level|
                   css = "issue issue-#{child.id} hascontextmenu #{issue.css_classes}"
                   css << " idnt idnt-#{level}" if level > 0
                   s << content_tag('tr',
                          content_tag('td', check_box_tag("ids[]", child.id, false, :id => nil), :class => 'checkbox') +
                          content_tag('td', link_to_issue(child, :project => (issue.project_id != child.project_id)), :class => 'subject', :style => 'width: 50%') +
                          content_tag('td', h(child.status), :class => 'status') +
                          content_tag('td', link_to_user(child.assigned_to), :class => 'assigned_to') +
                          content_tag('td', child.disabled_core_fields.include?('done_ratio') ? '' : progress_bar(child.done_ratio), :class=> 'done_ratio'),
                          :class => css)
                 end
                 s << '</table></form>'
                 s.html_safe
               end
               def issue_estimated_hours_details(issue)
                 if issue.total_estimated_hours.present?
                   if issue.total_estimated_hours == issue.estimated_hours
                     l_hours_short(issue.estimated_hours)
                   else
                     s = issue.estimated_hours.present? ? l_hours_short(issue.estimated_hours) : ""
                     s << " (#{l(:label_total)}: #{l_hours_short(issue.total_estimated_hours)})"
                     s.html_safe
                   end
                 end
               end
               def issue_spent_hours_details(issue)
                 if issue.total_spent_hours > 0
                   if issue.total_spent_hours == issue.spent_hours
                     link_to(l_hours_short(issue.spent_hours), issue_time_entries_path(issue))
                   else
                     s = issue.spent_hours > 0 ? l_hours_short(issue.spent_hours) : ""
                     s << " (#{l(:label_total)}: #{link_to l_hours_short(issue.total_spent_hours), issue_time_entries_path(issue)})"
                     s.html_safe
                   end
                 end
               end
               # Returns an array of error messages for bulk edited issues
               def bulk_edit_error_messages(issues)
                 messages = {}
                 issues.each do |issue|
                   issue.errors.full_messages.each do |message|
                     messages[message] ||= []
                     messages[message] << issue
                   end
                 end
                 messages.map { |message, issues|
                   "#{message}: " + issues.map {|i| "##{i.id}"}.join(', ')
                 }
              end
               # Returns a link for adding a new subtask to the given issue
               def link_to_new_subtask(issue)
                 attrs = {
                   :parent_issue_id => issue
                 }
                 attrs[:tracker_id] = issue.tracker unless issue.tracker.disabled_core_fields.include?('parent_issue_id')
                 link_to(l(:button_add), new_project_issue_path(issue.project, :issue => attrs))
               end
               def trackers_options_for_select(issue)
                 trackers = issue.allowed_target_trackers
                 if issue.new_record? && issue.parent_issue_id.present?
                   trackers = trackers.reject do |tracker|
                     issue.tracker_id != tracker.id && tracker.disabled_core_fields.include?('parent_issue_id')
                   end
                 end
                 trackers.collect {|t| [t.name, t.id]}
               end
               class IssueFieldsRows
                 include ActionView::Helpers::TagHelper
                 def initialize
                   @left = []
                   @right = []
                 end
                 def left(*args)
                   args.any? ? @left << cells(*args) : @left
                 end
                 def right(*args)
                   args.any? ? @right << cells(*args) : @right
                 end
                 def size
                   @left.size > @right.size ? @left.size : @right.size
                 end
                 def to_html
                   content =
                     content_tag('div', @left.reduce(&:+), :class => 'splitcontentleft') +
                     content_tag('div', @right.reduce(&:+), :class => 'splitcontentleft')
                   content_tag('div', content, :class => 'splitcontent')
                 end
                 def cells(label, text, options={})
                   options[:class] = [options[:class] || "", 'attribute'].join(' ')
                   content_tag 'div',
                     content_tag('div', label + ":", :class => 'label') + content_tag('div', text, :class => 'value'),
                     options
                 end
               end
               def issue_fields_rows
                 r = IssueFieldsRows.new
                 yield r
                 r.to_html
               end
               def render_custom_fields_rows(issue)
                 values = issue.visible_custom_field_values
                 return if values.empty?
                 half = (values.size / 2.0).ceil
                 issue_fields_rows do |rows|
                   values.each_with_index do |value, i|
                     css = "cf_#{value.custom_field.id}"
                     m = (i < half ? :left : :right)
                     rows.send m, custom_field_name_tag(value.custom_field), show_value(value), :class => css
                   end
                 end
               end
               # Returns the path for updating the issue form
               # with project as the current project
               def update_issue_form_path(project, issue)
                 options = {:format => 'js'}
                 if issue.new_record?
                   if project
                     new_project_issue_path(project, options)
                   else
                     new_issue_path(options)
                   end
                 else
                   edit_issue_path(issue, options)
                 end
               end
               # Returns the number of descendants for an array of issues
               def issues_descendant_count(issues)
                 ids = issues.reject(&:leaf?).map {|issue| issue.descendants.ids}.flatten.uniq
                 ids -= issues.map(&:id)
                 ids.size
               end
               def issues_destroy_confirmation_message(issues)
                 issues = [issues] unless issues.is_a?(Array)
                 message = l(:text_issues_destroy_confirmation)
                 descendant_count = issues_descendant_count(issues)
                 if descendant_count > 0
                   message << "\n" + l(:text_issues_destroy_descendants_confirmation, :count => descendant_count)
                 end
                 message
               end
               # Returns an array of users that are proposed as watchers
               # on the new issue form
               def users_for_new_issue_watchers(issue)
                 users = issue.watcher_users
                 if issue.project.users.count <= 20
                   users = (users + issue.project.users.sort).uniq
                 end
                 users
               end
               def sidebar_queries
                 unless @sidebar_queries
                   @sidebar_queries = IssueQuery.visible.
                     order("#{Query.table_name}.name ASC").
                     # Project specific queries and global queries
                     where(@project.nil? ? ["project_id IS NULL"] : ["project_id IS NULL OR project_id = ?", @project.id]).
                     to_a
                 end
                 @sidebar_queries
               end
               def query_links(title, queries)
                 return '' if queries.empty?
                 # links to #index on issues/show
                 url_params = controller_name == 'issues' ? {:controller => 'issues', :action => 'index', :project_id => @project} : params
                 content_tag('h3', title) + "\n" +
                   content_tag('ul',
                     queries.collect {|query|
                         css = 'query'
                         css << ' selected' if query == @query
                         content_tag('li', link_to(query.name, url_params.merge(:query_id => query), :class => css))
                       }.join("\n").html_safe,
                     :class => 'queries'
                   ) + "\n"
               end
               def render_sidebar_queries
                 out = ''.html_safe
                 out << query_links(l(:label_my_queries), sidebar_queries.select(&:is_private?))
                 out << query_links(l(:label_query_plural), sidebar_queries.reject(&:is_private?))
                 out
               end
               def email_issue_attributes(issue, user)
                 items = []
                 %w(author status priority assigned_to category fixed_version).each do |attribute|
                   unless issue.disabled_core_fields.include?(attribute+"_id")
                     items << "#{l("field_#{attribute}")}: #{issue.send attribute}"
                   end
                 end
                 issue.visible_custom_field_values(user).each do |value|
                   items << "#{value.custom_field.name}: #{show_value(value, false)}"
                 end
                 items
               end
               def render_email_issue_attributes(issue, user, html=false)
                 items = email_issue_attributes(issue, user)
                 if html
                   content_tag('ul', items.map{|s| content_tag('li', s)}.join("\n").html_safe)
                 else
                   items.map{|s| "* #{s}"}.join("\n")
                 end
               end
               # Returns the textual representation of a journal details
               # as an array of strings
               def details_to_strings(details, no_html=false, options={})
                 options[:only_path] = (options[:only_path] == false ? false : true)
                 strings = []
                 values_by_field = {}
                 details.each do |detail|
                   if detail.property == 'cf'
                     field = detail.custom_field
                     if field && field.multiple?
                       values_by_field[field] ||= {:added => [], :deleted => []}
                       if detail.old_value
                         values_by_field[field][:deleted] << detail.old_value
                       end
                       if detail.value
                         values_by_field[field][:added] << detail.value
                       end
                       next
                     end
                   end
                   strings << show_detail(detail, no_html, options)
                 end
                 if values_by_field.present?
                   multiple_values_detail = Struct.new(:property, :prop_key, :custom_field, :old_value, :value)
                   values_by_field.each do |field, changes|
                     if changes[:added].any?
                       detail = multiple_values_detail.new('cf', field.id.to_s, field)
                       detail.value = changes[:added]
                       strings << show_detail(detail, no_html, options)
                     end
                     if changes[:deleted].any?
                       detail = multiple_values_detail.new('cf', field.id.to_s, field)
                       detail.old_value = changes[:deleted]
                       strings << show_detail(detail, no_html, options)
                     end
                   end
                 end
                 strings
               end
               # Returns the textual representation of a single journal detail
               def show_detail(detail, no_html=false, options={})
                 multiple = false
                 show_diff = false
                 case detail.property
                 when 'attr'
                   field = detail.prop_key.to_s.gsub(/\_id$/, "")
                   label = l(("field_" + field).to_sym)
                   case detail.prop_key
                   when 'due_date', 'start_date'
                     value = format_date(detail.value.to_date) if detail.value
                     old_value = format_date(detail.old_value.to_date) if detail.old_value
                   when 'project_id', 'status_id', 'tracker_id', 'assigned_to_id',
                         'priority_id', 'category_id', 'fixed_version_id'
                     value = find_name_by_reflection(field, detail.value)
                     old_value = find_name_by_reflection(field, detail.old_value)
                   when 'estimated_hours'
                     value = l_hours_short(detail.value.to_f) unless detail.value.blank?
                     old_value = l_hours_short(detail.old_value.to_f) unless detail.old_value.blank?
                   when 'parent_id'
                     label = l(:field_parent_issue)
                     value = "##{detail.value}" unless detail.value.blank?
                     old_value = "##{detail.old_value}" unless detail.old_value.blank?
                   when 'is_private'
                     value = l(detail.value == "0" ? :general_text_No : :general_text_Yes) unless detail.value.blank?
                     old_value = l(detail.old_value == "0" ? :general_text_No : :general_text_Yes) unless detail.old_value.blank?
                   when 'description'
                     show_diff = true
                   end
                 when 'cf'
                   custom_field = detail.custom_field
                   if custom_field
                     label = custom_field.name
                     if custom_field.format.class.change_as_diff
                       show_diff = true
                     else
                       multiple = custom_field.multiple?
                       value = format_value(detail.value, custom_field) if detail.value
                       old_value = format_value(detail.old_value, custom_field) if detail.old_value
                     end
                   end
                 when 'attachment'
                   label = l(:label_attachment)
                 when 'relation'
                   if detail.value && !detail.old_value
                     rel_issue = Issue.visible.find_by_id(detail.value)
                     value = rel_issue.nil? ? "#{l(:label_issue)} ##{detail.value}" :
                               (no_html ? rel_issue : link_to_issue(rel_issue, :only_path => options[:only_path]))
                   elsif detail.old_value && !detail.value
                     rel_issue = Issue.visible.find_by_id(detail.old_value)
                     old_value = rel_issue.nil? ? "#{l(:label_issue)} ##{detail.old_value}" :
                                       (no_html ? rel_issue : link_to_issue(rel_issue, :only_path => options[:only_path]))
                   end
                   relation_type = IssueRelation::TYPES[detail.prop_key]
                   label = l(relation_type[:name]) if relation_type
                 end
                 call_hook(:helper_issues_show_detail_after_setting,
                           {:detail => detail, :label => label, :value => value, :old_value => old_value })
                 label ||= detail.prop_key
                 value ||= detail.value
                 old_value ||= detail.old_value
                 unless no_html
                   label = content_tag('strong', label)
                   old_value = content_tag("i", h(old_value)) if detail.old_value
                   if detail.old_value && detail.value.blank? && detail.property != 'relation'
                     old_value = content_tag("del", old_value)
                   end
                   if detail.property == 'attachment' && value.present? &&
                       atta = detail.journal.journalized.attachments.detect {|a| a.id == detail.prop_key.to_i}
                     # Link to the attachment if it has not been removed
                     value = link_to_attachment(atta, :download => true, :only_path => options[:only_path])
-                    if options[:only_path] != false && atta.is_text?
+                    if options[:only_path] != false && (atta.is_text? || atta.is_image?)
+                      value += ' '
                       value += link_to(l(:button_view),
                                        { :controller => 'attachments', :action => 'show',
                                          :id => atta, :filename => atta.filename },
                                        :class => 'icon-only icon-magnifier',
                                        :title => l(:button_view))
                     end
                   else
                     value = content_tag("i", h(value)) if value
                   end
                 end
                 if show_diff
                   s = l(:text_journal_changed_no_detail, :label => label)
                   unless no_html
                     diff_link = link_to 'diff',
                       diff_journal_url(detail.journal_id, :detail_id => detail.id, :only_path => options[:only_path]),
                       :title => l(:label_view_diff)
                     s << " (#{ diff_link })"
                   end
                   s.html_safe
                 elsif detail.value.present?
                   case detail.property
                   when 'attr', 'cf'
                     if detail.old_value.present?
                       l(:text_journal_changed, :label => label, :old => old_value, :new => value).html_safe
                     elsif multiple
                       l(:text_journal_added, :label => label, :value => value).html_safe
                     else
                       l(:text_journal_set_to, :label => label, :value => value).html_safe
                     end
                   when 'attachment', 'relation'
                     l(:text_journal_added, :label => label, :value => value).html_safe
                   end
                 else
                   l(:text_journal_deleted, :label => label, :old => old_value).html_safe
                 end
               end
               # Find the name of an associated record stored in the field attribute
               def find_name_by_reflection(field, id)
                 unless id.present?
                   return nil
                 end
                 @detail_value_name_by_reflection ||= Hash.new do |hash, key|
                   association = Issue.reflect_on_association(key.first.to_sym)
                   name = nil
                   if association
                     record = association.klass.find_by_id(key.last)
                     if record
                       name = record.name.force_encoding('UTF-8')
                     end
                   end
                   hash[key] = name
                 end
                 @detail_value_name_by_reflection[[field, id]]
               end
               # Renders issue children recursively
               def render_api_issue_children(issue, api)
                 return if issue.leaf?
                 api.array :children do
                   issue.children.each do |child|
                     api.issue(:id => child.id) do
                       api.tracker(:id => child.tracker_id, :name => child.tracker.name) unless child.tracker.nil?
                       api.subject child.subject
                       render_api_issue_children(child, api)
                     end
                   end
                 end
               end
             end