jro_apps/redmine Commit - r4615:419b195019a2

Fixed: subtasks are deleted (not destroyed) when destroying parent issue (#7385)....

Jean-Philippe Lang -

r4615:419b195019a2

parent child

Context file:

r4615:419b195019a2

Collapse all files

app/models/issue.rb +1 -10

              # redMine - project management software
              # Copyright (C) 2006-2007  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              class Issue < ActiveRecord::Base
                include Redmine::SafeAttributes
                belongs_to :project
                belongs_to :tracker
                belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
                belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
                belongs_to :assigned_to, :class_name => 'User', :foreign_key => 'assigned_to_id'
                belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
                belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
                belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
                has_many :journals, :as => :journalized, :dependent => :destroy
                has_many :time_entries, :dependent => :delete_all
                has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
                has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
                has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
-               acts_as_nested_set :scope => 'root_id'
+               acts_as_nested_set :scope => 'root_id', :dependent => :destroy
                acts_as_attachable :after_remove => :attachment_removed
                acts_as_customizable
                acts_as_watchable
                acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
                                   :include => [:project, :journals],
                                   # sort by id so that limited eager loading doesn't break with postgresql
                                   :order_column => "#{table_name}.id"
                acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
                              :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
                              :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
                acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
                                          :author_key => :author_id
                DONE_RATIO_OPTIONS = %w(issue_field issue_status)
                attr_reader :current_journal
                validates_presence_of :subject, :priority, :project, :tracker, :author, :status
                validates_length_of :subject, :maximum => 255
                validates_inclusion_of :done_ratio, :in => 0..100
                validates_numericality_of :estimated_hours, :allow_nil => true
                named_scope :visible, lambda {|*args| { :include => :project,
                                                        :conditions => Project.allowed_to_condition(args.first || User.current, :view_issues) } }
                named_scope :open, :conditions => ["#{IssueStatus.table_name}.is_closed = ?", false], :include => :status
                named_scope :recently_updated, :order => "#{Issue.table_name}.updated_on DESC"
                named_scope :with_limit, lambda { |limit| { :limit => limit} }
                named_scope :on_active_project, :include => [:status, :project, :tracker],
                                                :conditions => ["#{Project.table_name}.status=#{Project::STATUS_ACTIVE}"]
                named_scope :for_gantt, lambda {
                  {
                    :include => [:tracker, :status, :assigned_to, :priority, :project, :fixed_version]
                  }
                }
                named_scope :without_version, lambda {
                  {
                    :conditions => { :fixed_version_id => nil}
                  }
                }
                named_scope :with_query, lambda {|query|
                  {
                    :conditions => Query.merge_conditions(query.statement)
                  }
                }
                before_create :default_assign
                before_save :close_duplicates, :update_done_ratio_from_issue_status
                after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
-               after_destroy :destroy_children
                after_destroy :update_parent_attributes
                # Returns true if usr or current user is allowed to view the issue
                def visible?(usr=nil)
                  (usr || User.current).allowed_to?(:view_issues, self.project)
                end
                def after_initialize
                  if new_record?
                    # set default values for new records only
                    self.status ||= IssueStatus.default
                    self.priority ||= IssuePriority.default
                  end
                end
                # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
                def available_custom_fields
                  (project && tracker) ? project.all_issue_custom_fields.select {|c| tracker.custom_fields.include? c } : []
                end
                def copy_from(arg)
                  issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
                  self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
                  self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
                  self.status = issue.status
                  self
                end
                # Moves/copies an issue to a new project and tracker
                # Returns the moved/copied issue on success, false on failure
                def move_to_project(*args)
                  ret = Issue.transaction do
                    move_to_project_without_transaction(*args) || raise(ActiveRecord::Rollback)
                  end || false
                end
                def move_to_project_without_transaction(new_project, new_tracker = nil, options = {})
                  options ||= {}
                  issue = options[:copy] ? self.class.new.copy_from(self) : self
                  if new_project && issue.project_id != new_project.id
                    # delete issue relations
                    unless Setting.cross_project_issue_relations?
                      issue.relations_from.clear
                      issue.relations_to.clear
                    end
                    # issue is moved to another project
                    # reassign to the category with same name if any
                    new_category = issue.category.nil? ? nil : new_project.issue_categories.find_by_name(issue.category.name)
                    issue.category = new_category
                    # Keep the fixed_version if it's still valid in the new_project
                    unless new_project.shared_versions.include?(issue.fixed_version)
                      issue.fixed_version = nil
                    end
                    issue.project = new_project
                    if issue.parent && issue.parent.project_id != issue.project_id
                      issue.parent_issue_id = nil
                    end
                  end
                  if new_tracker
                    issue.tracker = new_tracker
                    issue.reset_custom_values!
                  end
                  if options[:copy]
                    issue.custom_field_values = self.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
                    issue.status = if options[:attributes] && options[:attributes][:status_id]
                                     IssueStatus.find_by_id(options[:attributes][:status_id])
                                   else
                                     self.status
                                   end
                  end
                  # Allow bulk setting of attributes on the issue
                  if options[:attributes]
                    issue.attributes = options[:attributes]
                  end
                  if issue.save
                    unless options[:copy]
                      # Manually update project_id on related time entries
                      TimeEntry.update_all("project_id = #{new_project.id}", {:issue_id => id})
                      issue.children.each do |child|
                        unless child.move_to_project_without_transaction(new_project)
                          # Move failed and transaction was rollback'd
                          return false
                        end
                      end
                    end
                  else
                    return false
                  end
                  issue
                end
                def status_id=(sid)
                  self.status = nil
                  write_attribute(:status_id, sid)
                end
                def priority_id=(pid)
                  self.priority = nil
                  write_attribute(:priority_id, pid)
                end
                def tracker_id=(tid)
                  self.tracker = nil
                  result = write_attribute(:tracker_id, tid)
                  @custom_field_values = nil
                  result
                end
                # Overrides attributes= so that tracker_id gets assigned first
                def attributes_with_tracker_first=(new_attributes, *args)
                  return if new_attributes.nil?
                  new_tracker_id = new_attributes['tracker_id'] || new_attributes[:tracker_id]
                  if new_tracker_id
                    self.tracker_id = new_tracker_id
                  end
                  send :attributes_without_tracker_first=, new_attributes, *args
                end
                # Do not redefine alias chain on reload (see #4838)
                alias_method_chain(:attributes=, :tracker_first) unless method_defined?(:attributes_without_tracker_first=)
                def estimated_hours=(h)
                  write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
                end
                safe_attributes 'tracker_id',
                  'status_id',
                  'parent_issue_id',
                  'category_id',
                  'assigned_to_id',
                  'priority_id',
                  'fixed_version_id',
                  'subject',
                  'description',
                  'start_date',
                  'due_date',
                  'done_ratio',
                  'estimated_hours',
                  'custom_field_values',
                  'custom_fields',
                  'lock_version',
                  :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
                safe_attributes 'status_id',
                  'assigned_to_id',
                  'fixed_version_id',
                  'done_ratio',
                  :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
                # Safely sets attributes
                # Should be called from controllers instead of #attributes=
                # attr_accessible is too rough because we still want things like
                # Issue.new(:project => foo) to work
                # TODO: move workflow/permission checks from controllers to here
                def safe_attributes=(attrs, user=User.current)
                  return unless attrs.is_a?(Hash)
                  # User can change issue attributes only if he has :edit permission or if a workflow transition is allowed
                  attrs = delete_unsafe_attributes(attrs, user)
                  return if attrs.empty?
                  # Tracker must be set before since new_statuses_allowed_to depends on it.
                  if t = attrs.delete('tracker_id')
                    self.tracker_id = t
                  end
                  if attrs['status_id']
                    unless new_statuses_allowed_to(user).collect(&:id).include?(attrs['status_id'].to_i)
                      attrs.delete('status_id')
                    end
                  end
                  unless leaf?
                    attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
                  end
                  if attrs.has_key?('parent_issue_id')
                    if !user.allowed_to?(:manage_subtasks, project)
                      attrs.delete('parent_issue_id')
                    elsif !attrs['parent_issue_id'].blank?
                      attrs.delete('parent_issue_id') unless Issue.visible(user).exists?(attrs['parent_issue_id'].to_i)
                    end
                  end
                  self.attributes = attrs
                end
                def done_ratio
                  if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
                    status.default_done_ratio
                  else
                    read_attribute(:done_ratio)
                  end
                end
                def self.use_status_for_done_ratio?
                  Setting.issue_done_ratio == 'issue_status'
                end
                def self.use_field_for_done_ratio?
                  Setting.issue_done_ratio == 'issue_field'
                end
                def validate
                  if self.due_date.nil? && @attributes['due_date'] && !@attributes['due_date'].empty?
                    errors.add :due_date, :not_a_date
                  end
                  if self.due_date and self.start_date and self.due_date < self.start_date
                    errors.add :due_date, :greater_than_start_date
                  end
                  if start_date && soonest_start && start_date < soonest_start
                    errors.add :start_date, :invalid
                  end
                  if fixed_version
                    if !assignable_versions.include?(fixed_version)
                      errors.add :fixed_version_id, :inclusion
                    elsif reopened? && fixed_version.closed?
                      errors.add_to_base I18n.t(:error_can_not_reopen_issue_on_closed_version)
                    end
                  end
                  # Checks that the issue can not be added/moved to a disabled tracker
                  if project && (tracker_id_changed? || project_id_changed?)
                    unless project.trackers.include?(tracker)
                      errors.add :tracker_id, :inclusion
                    end
                  end
                  # Checks parent issue assignment
                  if @parent_issue
                    if @parent_issue.project_id != project_id
                      errors.add :parent_issue_id, :not_same_project
                    elsif !new_record?
                      # moving an existing issue
                      if @parent_issue.root_id != root_id
                        # we can always move to another tree
                      elsif move_possible?(@parent_issue)
                        # move accepted inside tree
                      else
                        errors.add :parent_issue_id, :not_a_valid_parent
                      end
                    end
                  end
                end
                # Set the done_ratio using the status if that setting is set.  This will keep the done_ratios
                # even if the user turns off the setting later
                def update_done_ratio_from_issue_status
                  if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
                    self.done_ratio = status.default_done_ratio
                  end
                end
                def init_journal(user, notes = "")
                  @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
                  @issue_before_change = self.clone
                  @issue_before_change.status = self.status
                  @custom_values_before_change = {}
                  self.custom_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
                  # Make sure updated_on is updated when adding a note.
                  updated_on_will_change!
                  @current_journal
                end
                # Return true if the issue is closed, otherwise false
                def closed?
                  self.status.is_closed?
                end
                # Return true if the issue is being reopened
                def reopened?
                  if !new_record? && status_id_changed?
                    status_was = IssueStatus.find_by_id(status_id_was)
                    status_new = IssueStatus.find_by_id(status_id)
                    if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
                      return true
                    end
                  end
                  false
                end
                # Return true if the issue is being closed
                def closing?
                  if !new_record? && status_id_changed?
                    status_was = IssueStatus.find_by_id(status_id_was)
                    status_new = IssueStatus.find_by_id(status_id)
                    if status_was && status_new && !status_was.is_closed? && status_new.is_closed?
                      return true
                    end
                  end
                  false
                end
                # Returns true if the issue is overdue
                def overdue?
                  !due_date.nil? && (due_date < Date.today) && !status.is_closed?
                end
                # Is the amount of work done less than it should for the due date
                def behind_schedule?
                  return false if start_date.nil? || due_date.nil?
                  done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
                  return done_date <= Date.today
                end
                # Does this issue have children?
                def children?
                  !leaf?
                end
                # Users the issue can be assigned to
                def assignable_users
                  users = project.assignable_users
                  users << author if author
                  users.uniq.sort
                end
                # Versions that the issue can be assigned to
                def assignable_versions
                  @assignable_versions ||= (project.shared_versions.open + [Version.find_by_id(fixed_version_id_was)]).compact.uniq.sort
                end
                # Returns true if this issue is blocked by another issue that is still open
                def blocked?
                  !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
                end
                # Returns an array of status that user is able to apply
                def new_statuses_allowed_to(user, include_default=false)
                  statuses = status.find_new_statuses_allowed_to(user.roles_for_project(project), tracker)
                  statuses << status unless statuses.empty?
                  statuses << IssueStatus.default if include_default
                  statuses = statuses.uniq.sort
                  blocked? ? statuses.reject {|s| s.is_closed?} : statuses
                end
                # Returns the mail adresses of users that should be notified
                def recipients
                  notified = project.notified_users
                  # Author and assignee are always notified unless they have been
                  # locked or don't want to be notified
                  notified << author if author && author.active? && author.notify_about?(self)
                  notified << assigned_to if assigned_to && assigned_to.active? && assigned_to.notify_about?(self)
                  notified.uniq!
                  # Remove users that can not view the issue
                  notified.reject! {|user| !visible?(user)}
                  notified.collect(&:mail)
                end
                # Returns the total number of hours spent on this issue and its descendants
                #
                # Example:
                #   spent_hours => 0.0
                #   spent_hours => 50.2
                def spent_hours
                  @spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours", :include => :time_entries).to_f || 0.0
                end
                def relations
                  (relations_from + relations_to).sort
                end
                def all_dependent_issues(except=nil)
                  except ||= self
                  dependencies = []
                  relations_from.each do |relation|
                    if relation.issue_to && relation.issue_to != except
                      dependencies << relation.issue_to
                      dependencies += relation.issue_to.all_dependent_issues(except)
                    end
                  end
                  dependencies
                end
                # Returns an array of issues that duplicate this one
                def duplicates
                  relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
                end
                # Returns the due date or the target due date if any
                # Used on gantt chart
                def due_before
                  due_date || (fixed_version ? fixed_version.effective_date : nil)
                end
                # Returns the time scheduled for this issue.
                #
                # Example:
                #   Start Date: 2/26/09, End Date: 3/04/09
                #   duration => 6
                def duration
                  (start_date && due_date) ? due_date - start_date : 0
                end
                def soonest_start
                  @soonest_start ||= (
                      relations_to.collect{|relation| relation.successor_soonest_start} +
                      ancestors.collect(&:soonest_start)
                    ).compact.max
                end
                def reschedule_after(date)
                  return if date.nil?
                  if leaf?
                    if start_date.nil? || start_date < date
                      self.start_date, self.due_date = date, date + duration
                      save
                    end
                  else
                    leaves.each do |leaf|
                      leaf.reschedule_after(date)
                    end
                  end
                end
                def <=>(issue)
                  if issue.nil?
                    -1
                  elsif root_id != issue.root_id
                    (root_id || 0) <=> (issue.root_id || 0)
                  else
                    (lft || 0) <=> (issue.lft || 0)
                  end
                end
                def to_s
                  "#{tracker} ##{id}: #{subject}"
                end
                # Returns a string of css classes that apply to the issue
                def css_classes
                  s = "issue status-#{status.position} priority-#{priority.position}"
                  s << ' closed' if closed?
                  s << ' overdue' if overdue?
                  s << ' created-by-me' if User.current.logged? && author_id == User.current.id
                  s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
                  s
                end
                # Saves an issue, time_entry, attachments, and a journal from the parameters
                # Returns false if save fails
                def save_issue_with_child_records(params, existing_time_entry=nil)
                  Issue.transaction do
                    if params[:time_entry] && params[:time_entry][:hours].present? && User.current.allowed_to?(:log_time, project)
                      @time_entry = existing_time_entry || TimeEntry.new
                      @time_entry.project = project
                      @time_entry.issue = self
                      @time_entry.user = User.current
                      @time_entry.spent_on = Date.today
                      @time_entry.attributes = params[:time_entry]
                      self.time_entries << @time_entry
                    end
                    if valid?
                      attachments = Attachment.attach_files(self, params[:attachments])
                      attachments[:files].each {|a| @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => a.id, :value => a.filename)}
                      # TODO: Rename hook
                      Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
                      begin
                        if save
                          # TODO: Rename hook
                          Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
                        else
                          raise ActiveRecord::Rollback
                        end
                      rescue ActiveRecord::StaleObjectError
                        attachments[:files].each(&:destroy)
                        errors.add_to_base l(:notice_locking_conflict)
                        raise ActiveRecord::Rollback
                      end
                    end
                  end
                end
                # Unassigns issues from +version+ if it's no longer shared with issue's project
                def self.update_versions_from_sharing_change(version)
                  # Update issues assigned to the version
                  update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
                end
                # Unassigns issues from versions that are no longer shared
                # after +project+ was moved
                def self.update_versions_from_hierarchy_change(project)
                  moved_project_ids = project.self_and_descendants.reload.collect(&:id)
                  # Update issues of the moved projects and issues assigned to a version of a moved project
                  Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
                end
                def parent_issue_id=(arg)
                  parent_issue_id = arg.blank? ? nil : arg.to_i
                  if parent_issue_id && @parent_issue = Issue.find_by_id(parent_issue_id)
                    @parent_issue.id
                  else
                    @parent_issue = nil
                    nil
                  end
                end
                def parent_issue_id
                  if instance_variable_defined? :@parent_issue
                    @parent_issue.nil? ? nil : @parent_issue.id
                  else
                    parent_id
                  end
                end
                # Extracted from the ReportsController.
                def self.by_tracker(project)
                  count_and_group_by(:project => project,
                                     :field => 'tracker_id',
                                     :joins => Tracker.table_name)
                end
                def self.by_version(project)
                  count_and_group_by(:project => project,
                                     :field => 'fixed_version_id',
                                     :joins => Version.table_name)
                end
                def self.by_priority(project)
                  count_and_group_by(:project => project,
                                     :field => 'priority_id',
                                     :joins => IssuePriority.table_name)
                end
                def self.by_category(project)
                  count_and_group_by(:project => project,
                                     :field => 'category_id',
                                     :joins => IssueCategory.table_name)
                end
                def self.by_assigned_to(project)
                  count_and_group_by(:project => project,
                                     :field => 'assigned_to_id',
                                     :joins => User.table_name)
                end
                def self.by_author(project)
                  count_and_group_by(:project => project,
                                     :field => 'author_id',
                                     :joins => User.table_name)
                end
                def self.by_subproject(project)
                  ActiveRecord::Base.connection.select_all("select    s.id as status_id,
                                                              s.is_closed as closed,
                                                              i.project_id as project_id,
                                                              count(i.id) as total
                                                            from
                                                              #{Issue.table_name} i, #{IssueStatus.table_name} s
                                                            where
                                                              i.status_id=s.id
                                                              and i.project_id IN (#{project.descendants.active.collect{|p| p.id}.join(',')})
                                                            group by s.id, s.is_closed, i.project_id") if project.descendants.active.any?
                end
                # End ReportsController extraction
                # Returns an array of projects that current user can move issues to
                def self.allowed_target_projects_on_move
                  projects = []
                  if User.current.admin?
                    # admin is allowed to move issues to any active (visible) project
                    projects = Project.visible.all
                  elsif User.current.logged?
                    if Role.non_member.allowed_to?(:move_issues)
                      projects = Project.visible.all
                    else
                      User.current.memberships.each {|m| projects << m.project if m.roles.detect {|r| r.allowed_to?(:move_issues)}}
                    end
                  end
                  projects
                end
                private
                def update_nested_set_attributes
                  if root_id.nil?
                    # issue was just created
                    self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
                    set_default_left_and_right
                    Issue.update_all("root_id = #{root_id}, lft = #{lft}, rgt = #{rgt}", ["id = ?", id])
                    if @parent_issue
                      move_to_child_of(@parent_issue)
                    end
                    reload
                  elsif parent_issue_id != parent_id
                    former_parent_id = parent_id
                    # moving an existing issue
                    if @parent_issue && @parent_issue.root_id == root_id
                      # inside the same tree
                      move_to_child_of(@parent_issue)
                    else
                      # to another tree
                      unless root?
                        move_to_right_of(root)
                        reload
                      end
                      old_root_id = root_id
                      self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
                      target_maxright = nested_set_scope.maximum(right_column_name) || 0
                      offset = target_maxright + 1 - lft
                      Issue.update_all("root_id = #{root_id}, lft = lft + #{offset}, rgt = rgt + #{offset}",
                                        ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
                      self[left_column_name] = lft + offset
                      self[right_column_name] = rgt + offset
                      if @parent_issue
                        move_to_child_of(@parent_issue)
                      end
                    end
                    reload
                    # delete invalid relations of all descendants
                    self_and_descendants.each do |issue|
                      issue.relations.each do |relation|
                        relation.destroy unless relation.valid?
                      end
                    end
                    # update former parent
                    recalculate_attributes_for(former_parent_id) if former_parent_id
                  end
                  remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
                end
                def update_parent_attributes
                  recalculate_attributes_for(parent_id) if parent_id
                end
                def recalculate_attributes_for(issue_id)
                  if issue_id && p = Issue.find_by_id(issue_id)
                    # priority = highest priority of children
                    if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :include => :priority)
                      p.priority = IssuePriority.find_by_position(priority_position)
                    end
                    # start/due dates = lowest/highest dates of children
                    p.start_date = p.children.minimum(:start_date)
                    p.due_date = p.children.maximum(:due_date)
                    if p.start_date && p.due_date && p.due_date < p.start_date
                      p.start_date, p.due_date = p.due_date, p.start_date
                    end
                    # done ratio = weighted average ratio of leaves
                    unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
                      leaves_count = p.leaves.count
                      if leaves_count > 0
                        average = p.leaves.average(:estimated_hours).to_f
                        if average == 0
                          average = 1
                        end
                        done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :include => :status).to_f
                        progress = done / (average * leaves_count)
                        p.done_ratio = progress.round
                      end
                    end
                    # estimate = sum of leaves estimates
                    p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
                    p.estimated_hours = nil if p.estimated_hours == 0.0
                    # ancestors will be recursively updated
                    p.save(false)
                  end
                end
-               def destroy_children
-                 unless leaf?
-                   children.each do |child|
-                     child.destroy
-                   end
-                 end
-               end
                # Update issues so their versions are not pointing to a
                # fixed_version that is not shared with the issue's project
                def self.update_versions(conditions=nil)
                  # Only need to update issues with a fixed_version from
                  # a different project and that is not systemwide shared
                  Issue.all(:conditions => merge_conditions("#{Issue.table_name}.fixed_version_id IS NOT NULL" +
                                                              " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
                                                              " AND #{Version.table_name}.sharing <> 'system'",
                                                              conditions),
                            :include => [:project, :fixed_version]
                            ).each do |issue|
                    next if issue.project.nil? || issue.fixed_version.nil?
                    unless issue.project.shared_versions.include?(issue.fixed_version)
                      issue.init_journal(User.current)
                      issue.fixed_version = nil
                      issue.save
                    end
                  end
                end
                # Callback on attachment deletion
                def attachment_removed(obj)
                  journal = init_journal(User.current)
                  journal.details << JournalDetail.new(:property => 'attachment',
                                                       :prop_key => obj.id,
                                                       :old_value => obj.filename)
                  journal.save
                end
                # Default assignment based on category
                def default_assign
                  if assigned_to.nil? && category && category.assigned_to
                    self.assigned_to = category.assigned_to
                  end
                end
                # Updates start/due dates of following issues
                def reschedule_following_issues
                  if start_date_changed? || due_date_changed?
                    relations_from.each do |relation|
                      relation.set_issue_to_dates
                    end
                  end
                end
                # Closes duplicates if the issue is being closed
                def close_duplicates
                  if closing?
                    duplicates.each do |duplicate|
                      # Reload is need in case the duplicate was updated by a previous duplicate
                      duplicate.reload
                      # Don't re-close it if it's already closed
                      next if duplicate.closed?
                      # Same user and notes
                      if @current_journal
                        duplicate.init_journal(@current_journal.user, @current_journal.notes)
                      end
                      duplicate.update_attribute :status, self.status
                    end
                  end
                end
                # Saves the changes in a Journal
                # Called after_save
                def create_journal
                  if @current_journal
                    # attributes changes
                    (Issue.column_names - %w(id description root_id lft rgt lock_version created_on updated_on)).each {|c|
                      @current_journal.details << JournalDetail.new(:property => 'attr',
                                                                    :prop_key => c,
                                                                    :old_value => @issue_before_change.send(c),
                                                                    :value => send(c)) unless send(c)==@issue_before_change.send(c)
                    }
                    # custom fields changes
                    custom_values.each {|c|
                      next if (@custom_values_before_change[c.custom_field_id]==c.value ||
                                (@custom_values_before_change[c.custom_field_id].blank? && c.value.blank?))
                      @current_journal.details << JournalDetail.new(:property => 'cf',
                                                                    :prop_key => c.custom_field_id,
                                                                    :old_value => @custom_values_before_change[c.custom_field_id],
                                                                    :value => c.value)
                    }
                    @current_journal.save
                    # reset current journal
                    init_journal @current_journal.user, @current_journal.notes
                  end
                end
                # Query generator for selecting groups of issue counts for a project
                # based on specific criteria
                #
                # Options
                # * project - Project to search in.
                # * field - String. Issue field to key off of in the grouping.
                # * joins - String. The table name to join against.
                def self.count_and_group_by(options)
                  project = options.delete(:project)
                  select_field = options.delete(:field)
                  joins = options.delete(:joins)
                  where = "i.#{select_field}=j.id"
                  ActiveRecord::Base.connection.select_all("select    s.id as status_id,
                                                              s.is_closed as closed,
                                                              j.id as #{select_field},
                                                              count(i.id) as total
                                                            from
                                                                #{Issue.table_name} i, #{IssueStatus.table_name} s, #{joins} j
                                                            where
                                                              i.status_id=s.id
                                                              and #{where}
                                                              and i.project_id=#{project.id}
                                                            group by s.id, s.is_closed, j.id")
                end
              end

test/unit/issue_nested_set_test.rb +33 -1

              # redMine - project management software
              # Copyright (C) 2006-2007  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              require File.expand_path('../../test_helper', __FILE__)
              class IssueNestedSetTest < ActiveSupport::TestCase
                fixtures :projects, :users, :members, :member_roles, :roles,
                         :trackers, :projects_trackers,
                         :versions,
                         :issue_statuses, :issue_categories, :issue_relations, :workflows,
                         :enumerations,
                         :issues,
                         :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
                         :time_entries
                self.use_transactional_fixtures = false
                def test_create_root_issue
                  issue1 = create_issue!
                  issue2 = create_issue!
                  issue1.reload
                  issue2.reload
                  assert_equal [issue1.id, nil, 1, 2], [issue1.root_id, issue1.parent_id, issue1.lft, issue1.rgt]
                  assert_equal [issue2.id, nil, 1, 2], [issue2.root_id, issue2.parent_id, issue2.lft, issue2.rgt]
                end
                def test_create_child_issue
                  parent = create_issue!
                  child =  create_issue!(:parent_issue_id => parent.id)
                  parent.reload
                  child.reload
                  assert_equal [parent.id, nil, 1, 4], [parent.root_id, parent.parent_id, parent.lft, parent.rgt]
                  assert_equal [parent.id, parent.id, 2, 3], [child.root_id, child.parent_id, child.lft, child.rgt]
                end
                def test_creating_a_child_in_different_project_should_not_validate
                  issue = create_issue!
                  child = Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1, :subject => 'child', :parent_issue_id => issue.id)
                  assert !child.save
                  assert_not_nil child.errors.on(:parent_issue_id)
                end
                def test_move_a_root_to_child
                  parent1 = create_issue!
                  parent2 = create_issue!
                  child = create_issue!(:parent_issue_id => parent1.id)
                  parent2.parent_issue_id = parent1.id
                  parent2.save!
                  child.reload
                  parent1.reload
                  parent2.reload
                  assert_equal [parent1.id, 1, 6], [parent1.root_id, parent1.lft, parent1.rgt]
                  assert_equal [parent1.id, 4, 5], [parent2.root_id, parent2.lft, parent2.rgt]
                  assert_equal [parent1.id, 2, 3], [child.root_id, child.lft, child.rgt]
                end
                def test_move_a_child_to_root
                  parent1 = create_issue!
                  parent2 = create_issue!
                  child =   create_issue!(:parent_issue_id => parent1.id)
                  child.parent_issue_id = nil
                  child.save!
                  child.reload
                  parent1.reload
                  parent2.reload
                  assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
                  assert_equal [parent2.id, 1, 2], [parent2.root_id, parent2.lft, parent2.rgt]
                  assert_equal [child.id, 1, 2], [child.root_id, child.lft, child.rgt]
                end
                def test_move_a_child_to_another_issue
                  parent1 = create_issue!
                  parent2 = create_issue!
                  child =   create_issue!(:parent_issue_id => parent1.id)
                  child.parent_issue_id = parent2.id
                  child.save!
                  child.reload
                  parent1.reload
                  parent2.reload
                  assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
                  assert_equal [parent2.id, 1, 4], [parent2.root_id, parent2.lft, parent2.rgt]
                  assert_equal [parent2.id, 2, 3], [child.root_id, child.lft, child.rgt]
                end
                def test_move_a_child_with_descendants_to_another_issue
                  parent1 = create_issue!
                  parent2 = create_issue!
                  child =   create_issue!(:parent_issue_id => parent1.id)
                  grandchild = create_issue!(:parent_issue_id => child.id)
                  parent1.reload
                  parent2.reload
                  child.reload
                  grandchild.reload
                  assert_equal [parent1.id, 1, 6], [parent1.root_id, parent1.lft, parent1.rgt]
                  assert_equal [parent2.id, 1, 2], [parent2.root_id, parent2.lft, parent2.rgt]
                  assert_equal [parent1.id, 2, 5], [child.root_id, child.lft, child.rgt]
                  assert_equal [parent1.id, 3, 4], [grandchild.root_id, grandchild.lft, grandchild.rgt]
                  child.reload.parent_issue_id = parent2.id
                  child.save!
                  child.reload
                  grandchild.reload
                  parent1.reload
                  parent2.reload
                  assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
                  assert_equal [parent2.id, 1, 6], [parent2.root_id, parent2.lft, parent2.rgt]
                  assert_equal [parent2.id, 2, 5], [child.root_id, child.lft, child.rgt]
                  assert_equal [parent2.id, 3, 4], [grandchild.root_id, grandchild.lft, grandchild.rgt]
                end
                def test_move_a_child_with_descendants_to_another_project
                  parent1 = create_issue!
                  child =   create_issue!(:parent_issue_id => parent1.id)
                  grandchild = create_issue!(:parent_issue_id => child.id)
                  assert child.reload.move_to_project(Project.find(2))
                  child.reload
                  grandchild.reload
                  parent1.reload
                  assert_equal [1, parent1.id, 1, 2], [parent1.project_id, parent1.root_id, parent1.lft, parent1.rgt]
                  assert_equal [2, child.id, 1, 4], [child.project_id, child.root_id, child.lft, child.rgt]
                  assert_equal [2, child.id, 2, 3], [grandchild.project_id, grandchild.root_id, grandchild.lft, grandchild.rgt]
                end
                def test_invalid_move_to_another_project
                  parent1 = create_issue!
                  child =   create_issue!(:parent_issue_id => parent1.id)
                  grandchild = create_issue!(:parent_issue_id => child.id, :tracker_id => 2)
                  Project.find(2).tracker_ids = [1]
                  parent1.reload
                  assert_equal [1, parent1.id, 1, 6], [parent1.project_id, parent1.root_id, parent1.lft, parent1.rgt]
                  # child can not be moved to Project 2 because its child is on a disabled tracker
                  assert_equal false, Issue.find(child.id).move_to_project(Project.find(2))
                  child.reload
                  grandchild.reload
                  parent1.reload
                  # no change
                  assert_equal [1, parent1.id, 1, 6], [parent1.project_id, parent1.root_id, parent1.lft, parent1.rgt]
                  assert_equal [1, parent1.id, 2, 5], [child.project_id, child.root_id, child.lft, child.rgt]
                  assert_equal [1, parent1.id, 3, 4], [grandchild.project_id, grandchild.root_id, grandchild.lft, grandchild.rgt]
                end
                def test_moving_an_issue_to_a_descendant_should_not_validate
                  parent1 = create_issue!
                  parent2 = create_issue!
                  child =   create_issue!(:parent_issue_id => parent1.id)
                  grandchild = create_issue!(:parent_issue_id => child.id)
                  child.reload
                  child.parent_issue_id = grandchild.id
                  assert !child.save
                  assert_not_nil child.errors.on(:parent_issue_id)
                end
                def test_moving_an_issue_should_keep_valid_relations_only
                  issue1 = create_issue!
                  issue2 = create_issue!
                  issue3 = create_issue!(:parent_issue_id => issue2.id)
                  issue4 = create_issue!
                  r1 = IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
                  r2 = IssueRelation.create!(:issue_from => issue1, :issue_to => issue3, :relation_type => IssueRelation::TYPE_PRECEDES)
                  r3 = IssueRelation.create!(:issue_from => issue2, :issue_to => issue4, :relation_type => IssueRelation::TYPE_PRECEDES)
                  issue2.reload
                  issue2.parent_issue_id = issue1.id
                  issue2.save!
                  assert !IssueRelation.exists?(r1.id)
                  assert !IssueRelation.exists?(r2.id)
                  assert IssueRelation.exists?(r3.id)
                end
                def test_destroy_should_destroy_children
                  issue1 = create_issue!
                  issue2 = create_issue!
                  issue3 = create_issue!(:parent_issue_id => issue2.id)
                  issue4 = create_issue!(:parent_issue_id => issue1.id)
-                 issue2.reload.destroy
+                 issue3.init_journal(User.find(2))
+                 issue3.subject = 'child with journal'
+                 issue3.save!
+                 assert_difference 'Issue.count', -2 do
+                   assert_difference 'Journal.count', -1 do
+                     assert_difference 'JournalDetail.count', -1 do
+                       Issue.find(issue2.id).destroy
+                     end
+                   end
+                 end
                  issue1.reload
                  issue4.reload
                  assert !Issue.exists?(issue2.id)
                  assert !Issue.exists?(issue3.id)
                  assert_equal [issue1.id, 1, 4], [issue1.root_id, issue1.lft, issue1.rgt]
                  assert_equal [issue1.id, 2, 3], [issue4.root_id, issue4.lft, issue4.rgt]
                end
+               def test_destroy_child_issue_with_children
+                 root = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'root')
+                 child = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => root.id)
+                 leaf = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'leaf', :parent_issue_id => child.id)
+                 leaf.init_journal(User.find(2))
+                 leaf.subject = 'leaf with journal'
+                 leaf.save!
+                 assert_difference 'Issue.count', -2 do
+                   assert_difference 'Journal.count', -1 do
+                     assert_difference 'JournalDetail.count', -1 do
+                       Issue.find(child.id).destroy
+                     end
+                   end
+                 end
+                 root = Issue.find(root.id)
+                 assert root.leaf?, "Root issue is not a leaf (lft: #{root.lft}, rgt: #{root.rgt})"
+               end
                def test_parent_priority_should_be_the_highest_child_priority
                  parent = create_issue!(:priority => IssuePriority.find_by_name('Normal'))
                  # Create children
                  child1 = create_issue!(:priority => IssuePriority.find_by_name('High'), :parent_issue_id => parent.id)
                  assert_equal 'High', parent.reload.priority.name
                  child2 = create_issue!(:priority => IssuePriority.find_by_name('Immediate'), :parent_issue_id => child1.id)
                  assert_equal 'Immediate', child1.reload.priority.name
                  assert_equal 'Immediate', parent.reload.priority.name
                  child3 = create_issue!(:priority => IssuePriority.find_by_name('Low'), :parent_issue_id => parent.id)
                  assert_equal 'Immediate', parent.reload.priority.name
                  # Destroy a child
                  child1.destroy
                  assert_equal 'Low', parent.reload.priority.name
                  # Update a child
                  child3.reload.priority = IssuePriority.find_by_name('Normal')
                  child3.save!
                  assert_equal 'Normal', parent.reload.priority.name
                end
                def test_parent_dates_should_be_lowest_start_and_highest_due_dates
                  parent = create_issue!
                  create_issue!(:start_date => '2010-01-25', :due_date => '2010-02-15', :parent_issue_id => parent.id)
                  create_issue!(                             :due_date => '2010-02-13', :parent_issue_id => parent.id)
                  create_issue!(:start_date => '2010-02-01', :due_date => '2010-02-22', :parent_issue_id => parent.id)
                  parent.reload
                  assert_equal Date.parse('2010-01-25'), parent.start_date
                  assert_equal Date.parse('2010-02-22'), parent.due_date
                end
                def test_parent_done_ratio_should_be_average_done_ratio_of_leaves
                  parent = create_issue!
                  create_issue!(:done_ratio => 20, :parent_issue_id => parent.id)
                  assert_equal 20, parent.reload.done_ratio
                  create_issue!(:done_ratio => 70, :parent_issue_id => parent.id)
                  assert_equal 45, parent.reload.done_ratio
                  child = create_issue!(:done_ratio => 0, :parent_issue_id => parent.id)
                  assert_equal 30, parent.reload.done_ratio
                  create_issue!(:done_ratio => 30, :parent_issue_id => child.id)
                  assert_equal 30, child.reload.done_ratio
                  assert_equal 40, parent.reload.done_ratio
                end
                def test_parent_done_ratio_should_be_weighted_by_estimated_times_if_any
                  parent = create_issue!
                  create_issue!(:estimated_hours => 10, :done_ratio => 20, :parent_issue_id => parent.id)
                  assert_equal 20, parent.reload.done_ratio
                  create_issue!(:estimated_hours => 20, :done_ratio => 50, :parent_issue_id => parent.id)
                  assert_equal (50 * 20 + 20 * 10) / 30, parent.reload.done_ratio
                end
                def test_parent_estimate_should_be_sum_of_leaves
                  parent = create_issue!
                  create_issue!(:estimated_hours => nil, :parent_issue_id => parent.id)
                  assert_equal nil, parent.reload.estimated_hours
                  create_issue!(:estimated_hours => 5, :parent_issue_id => parent.id)
                  assert_equal 5, parent.reload.estimated_hours
                  create_issue!(:estimated_hours => 7, :parent_issue_id => parent.id)
                  assert_equal 12, parent.reload.estimated_hours
                end
                def test_move_parent_updates_old_parent_attributes
                  first_parent = create_issue!
                  second_parent = create_issue!
                  child = create_issue!(:estimated_hours => 5, :parent_issue_id => first_parent.id)
                  assert_equal 5, first_parent.reload.estimated_hours
                  child.update_attributes(:estimated_hours => 7, :parent_issue_id => second_parent.id)
                  assert_equal 7, second_parent.reload.estimated_hours
                  assert_nil first_parent.reload.estimated_hours
                end
                def test_reschuling_a_parent_should_reschedule_subtasks
                  parent = create_issue!
                  c1 = create_issue!(:start_date => '2010-05-12', :due_date => '2010-05-18', :parent_issue_id => parent.id)
                  c2 = create_issue!(:start_date => '2010-06-03', :due_date => '2010-06-10', :parent_issue_id => parent.id)
                  parent.reload
                  parent.reschedule_after(Date.parse('2010-06-02'))
                  c1.reload
                  assert_equal [Date.parse('2010-06-02'), Date.parse('2010-06-08')], [c1.start_date, c1.due_date]
                  c2.reload
                  assert_equal [Date.parse('2010-06-03'), Date.parse('2010-06-10')], [c2.start_date, c2.due_date] # no change
                  parent.reload
                  assert_equal [Date.parse('2010-06-02'), Date.parse('2010-06-10')], [parent.start_date, parent.due_date]
                end
                def test_project_copy_should_copy_issue_tree
                  p = Project.create!(:name => 'Tree copy', :identifier => 'tree-copy', :tracker_ids => [1, 2])
                  i1 = create_issue!(:project_id => p.id, :subject => 'i1')
                  i2 = create_issue!(:project_id => p.id, :subject => 'i2', :parent_issue_id => i1.id)
                  i3 = create_issue!(:project_id => p.id, :subject => 'i3', :parent_issue_id => i1.id)
                  i4 = create_issue!(:project_id => p.id, :subject => 'i4', :parent_issue_id => i2.id)
                  i5 = create_issue!(:project_id => p.id, :subject => 'i5')
                  c = Project.new(:name => 'Copy', :identifier => 'copy', :tracker_ids => [1, 2])
                  c.copy(p, :only => 'issues')
                  c.reload
                  assert_equal 5, c.issues.count
                  ic1, ic2, ic3, ic4, ic5 = c.issues.find(:all, :order => 'subject')
                  assert ic1.root?
                  assert_equal ic1, ic2.parent
                  assert_equal ic1, ic3.parent
                  assert_equal ic2, ic4.parent
                  assert ic5.root?
                end
                # Helper that creates an issue with default attributes
                def create_issue!(attributes={})
                  Issue.create!({:project_id => 1, :tracker_id => 1, :author_id => 1, :subject => 'test'}.merge(attributes))
                end
              end

vendor/plugins/awesome_nested_set/lib/awesome_nested_set.rb +4 -2

              module CollectiveIdea #:nodoc:
                module Acts #:nodoc:
                  module NestedSet #:nodoc:
                    def self.included(base)
                      base.extend(SingletonMethods)
                    end
                    # This acts provides Nested Set functionality. Nested Set is a smart way to implement
                    # an _ordered_ tree, with the added feature that you can select the children and all of their
                    # descendants with a single query. The drawback is that insertion or move need some complex
                    # sql queries. But everything is done here by this module!
                    #
                    # Nested sets are appropriate each time you want either an orderd tree (menus,
                    # commercial categories) or an efficient way of querying big trees (threaded posts).
                    #
                    # == API
                    #
                    # Methods names are aligned with acts_as_tree as much as possible, to make replacment from one
                    # by another easier, except for the creation:
                    #
                    # in acts_as_tree:
                    #   item.children.create(:name => "child1")
                    #
                    # in acts_as_nested_set:
                    #   # adds a new item at the "end" of the tree, i.e. with child.left = max(tree.right)+1
                    #   child = MyClass.new(:name => "child1")
                    #   child.save
                    #   # now move the item to its right place
                    #   child.move_to_child_of my_item
                    #
                    # You can pass an id or an object to:
                    # * <tt>#move_to_child_of</tt>
                    # * <tt>#move_to_right_of</tt>
                    # * <tt>#move_to_left_of</tt>
                    #
                    module SingletonMethods
                      # Configuration options are:
                      #
                      # * +:parent_column+ - specifies the column name to use for keeping the position integer (default: parent_id)
                      # * +:left_column+ - column name for left boundry data, default "lft"
                      # * +:right_column+ - column name for right boundry data, default "rgt"
                      # * +:scope+ - restricts what is to be considered a list. Given a symbol, it'll attach "_id"
                      #   (if it hasn't been already) and use that as the foreign key restriction. You
                      #   can also pass an array to scope by multiple attributes.
                      #   Example: <tt>acts_as_nested_set :scope => [:notable_id, :notable_type]</tt>
                      # * +:dependent+ - behavior for cascading destroy. If set to :destroy, all the
                      #   child objects are destroyed alongside this object by calling their destroy
                      #   method. If set to :delete_all (default), all the child objects are deleted
                      #   without calling their destroy method.
                      #
                      # See CollectiveIdea::Acts::NestedSet::ClassMethods for a list of class methods and
                      # CollectiveIdea::Acts::NestedSet::InstanceMethods for a list of instance methods added
                      # to acts_as_nested_set models
                      def acts_as_nested_set(options = {})
                        options = {
                          :parent_column => 'parent_id',
                          :left_column => 'lft',
                          :right_column => 'rgt',
                          :order => 'id',
                          :dependent => :delete_all, # or :destroy
                        }.merge(options)
                        if options[:scope].is_a?(Symbol) && options[:scope].to_s !~ /_id$/
                          options[:scope] = "#{options[:scope]}_id".intern
                        end
                        write_inheritable_attribute :acts_as_nested_set_options, options
                        class_inheritable_reader :acts_as_nested_set_options
                        include Comparable
                        include Columns
                        include InstanceMethods
                        extend Columns
                        extend ClassMethods
                        # no bulk assignment
                        attr_protected  left_column_name.intern,
                                        right_column_name.intern,
                                        parent_column_name.intern
                        before_create :set_default_left_and_right
                        before_destroy :prune_from_tree
                        # no assignment to structure fields
                        [left_column_name, right_column_name, parent_column_name].each do |column|
                          module_eval <<-"end_eval", __FILE__, __LINE__
                            def #{column}=(x)
                              raise ActiveRecord::ActiveRecordError, "Unauthorized assignment to #{column}: it's an internal field handled by acts_as_nested_set code, use move_to_* methods instead."
                            end
                          end_eval
                        end
                        named_scope :roots, :conditions => {parent_column_name => nil}, :order => quoted_left_column_name
                        named_scope :leaves, :conditions => "#{quoted_right_column_name} - #{quoted_left_column_name} = 1", :order => quoted_left_column_name
                        if self.respond_to?(:define_callbacks)
                          define_callbacks("before_move", "after_move")
                        end
                      end
                    end
                    module ClassMethods
                      # Returns the first root
                      def root
                        roots.find(:first)
                      end
                      def valid?
                        left_and_rights_valid? && no_duplicates_for_columns? && all_roots_valid?
                      end
                      def left_and_rights_valid?
                        count(
                          :joins => "LEFT OUTER JOIN #{quoted_table_name} AS parent ON " +
                            "#{quoted_table_name}.#{quoted_parent_column_name} = parent.#{primary_key}",
                          :conditions =>
                            "#{quoted_table_name}.#{quoted_left_column_name} IS NULL OR " +
                            "#{quoted_table_name}.#{quoted_right_column_name} IS NULL OR " +
                            "#{quoted_table_name}.#{quoted_left_column_name} >= " +
                              "#{quoted_table_name}.#{quoted_right_column_name} OR " +
                            "(#{quoted_table_name}.#{quoted_parent_column_name} IS NOT NULL AND " +
                              "(#{quoted_table_name}.#{quoted_left_column_name} <= parent.#{quoted_left_column_name} OR " +
                              "#{quoted_table_name}.#{quoted_right_column_name} >= parent.#{quoted_right_column_name}))"
                        ) == 0
                      end
                      def no_duplicates_for_columns?
                        scope_string = Array(acts_as_nested_set_options[:scope]).map do |c|
                          connection.quote_column_name(c)
                        end.push(nil).join(", ")
                        [quoted_left_column_name, quoted_right_column_name].all? do |column|
                          # No duplicates
                          find(:first,
                            :select => "#{scope_string}#{column}, COUNT(#{column})",
                            :group => "#{scope_string}#{column}
                              HAVING COUNT(#{column}) > 1").nil?
                        end
                      end
                      # Wrapper for each_root_valid? that can deal with scope.
                      def all_roots_valid?
                        if acts_as_nested_set_options[:scope]
                          roots(:group => scope_column_names).group_by{|record| scope_column_names.collect{|col| record.send(col.to_sym)}}.all? do |scope, grouped_roots|
                            each_root_valid?(grouped_roots)
                          end
                        else
                          each_root_valid?(roots)
                        end
                      end
                      def each_root_valid?(roots_to_validate)
                        left = right = 0
                        roots_to_validate.all? do |root|
                          (root.left > left && root.right > right).tap do
                            left = root.left
                            right = root.right
                          end
                        end
                      end
                      # Rebuilds the left & rights if unset or invalid.  Also very useful for converting from acts_as_tree.
                      def rebuild!
                        # Don't rebuild a valid tree.
                        return true if valid?
                        scope = lambda{|node|}
                        if acts_as_nested_set_options[:scope]
                          scope = lambda{|node|
                            scope_column_names.inject(""){|str, column_name|
                              str << "AND #{connection.quote_column_name(column_name)} = #{connection.quote(node.send(column_name.to_sym))} "
                            }
                          }
                        end
                        indices = {}
                        set_left_and_rights = lambda do |node|
                          # set left
                          node[left_column_name] = indices[scope.call(node)] += 1
                          # find
                          find(:all, :conditions => ["#{quoted_parent_column_name} = ? #{scope.call(node)}", node], :order => "#{quoted_left_column_name}, #{quoted_right_column_name}, #{acts_as_nested_set_options[:order]}").each{|n| set_left_and_rights.call(n) }
                          # set right
                          node[right_column_name] = indices[scope.call(node)] += 1
                          node.save!
                        end
                        # Find root node(s)
                        root_nodes = find(:all, :conditions => "#{quoted_parent_column_name} IS NULL", :order => "#{quoted_left_column_name}, #{quoted_right_column_name}, #{acts_as_nested_set_options[:order]}").each do |root_node|
                          # setup index for this scope
                          indices[scope.call(root_node)] ||= 0
                          set_left_and_rights.call(root_node)
                        end
                      end
                    end
                    # Mixed into both classes and instances to provide easy access to the column names
                    module Columns
                      def left_column_name
                        acts_as_nested_set_options[:left_column]
                      end
                      def right_column_name
                        acts_as_nested_set_options[:right_column]
                      end
                      def parent_column_name
                        acts_as_nested_set_options[:parent_column]
                      end
                      def scope_column_names
                        Array(acts_as_nested_set_options[:scope])
                      end
                      def quoted_left_column_name
                        connection.quote_column_name(left_column_name)
                      end
                      def quoted_right_column_name
                        connection.quote_column_name(right_column_name)
                      end
                      def quoted_parent_column_name
                        connection.quote_column_name(parent_column_name)
                      end
                      def quoted_scope_column_names
                        scope_column_names.collect {|column_name| connection.quote_column_name(column_name) }
                      end
                    end
                    # Any instance method that returns a collection makes use of Rails 2.1's named_scope (which is bundled for Rails 2.0), so it can be treated as a finder.
                    #
                    #   category.self_and_descendants.count
                    #   category.ancestors.find(:all, :conditions => "name like '%foo%'")
                    module InstanceMethods
                      # Value of the parent column
                      def parent_id
                        self[parent_column_name]
                      end
                      # Value of the left column
                      def left
                        self[left_column_name]
                      end
                      # Value of the right column
                      def right
                        self[right_column_name]
                      end
                      # Returns true if this is a root node.
                      def root?
                        parent_id.nil?
                      end
                      def leaf?
                        new_record? || (right - left == 1)
                      end
                      # Returns true is this is a child node
                      def child?
                        !parent_id.nil?
                      end
                      # order by left column
                      def <=>(x)
                        left <=> x.left
                      end
                      # Redefine to act like active record
                      def ==(comparison_object)
                        comparison_object.equal?(self) ||
                          (comparison_object.instance_of?(self.class) &&
                            comparison_object.id == id &&
                            !comparison_object.new_record?)
                      end
                      # Returns root
                      def root
                        self_and_ancestors.find(:first)
                      end
                      # Returns the immediate parent
                      def parent
                        nested_set_scope.find_by_id(parent_id) if parent_id
                      end
                      # Returns the array of all parents and self
                      def self_and_ancestors
                        nested_set_scope.scoped :conditions => [
                          "#{self.class.table_name}.#{quoted_left_column_name} <= ? AND #{self.class.table_name}.#{quoted_right_column_name} >= ?", left, right
                        ]
                      end
                      # Returns an array of all parents
                      def ancestors
                        without_self self_and_ancestors
                      end
                      # Returns the array of all children of the parent, including self
                      def self_and_siblings
                        nested_set_scope.scoped :conditions => {parent_column_name => parent_id}
                      end
                      # Returns the array of all children of the parent, except self
                      def siblings
                        without_self self_and_siblings
                      end
                      # Returns a set of all of its nested children which do not have children
                      def leaves
                        descendants.scoped :conditions => "#{self.class.table_name}.#{quoted_right_column_name} - #{self.class.table_name}.#{quoted_left_column_name} = 1"
                      end
                      # Returns the level of this object in the tree
                      # root level is 0
                      def level
                        parent_id.nil? ? 0 : ancestors.count
                      end
                      # Returns a set of itself and all of its nested children
                      def self_and_descendants
                        nested_set_scope.scoped :conditions => [
                          "#{self.class.table_name}.#{quoted_left_column_name} >= ? AND #{self.class.table_name}.#{quoted_right_column_name} <= ?", left, right
                        ]
                      end
                      # Returns a set of all of its children and nested children
                      def descendants
                        without_self self_and_descendants
                      end
                      # Returns a set of only this entry's immediate children
                      def children
                        nested_set_scope.scoped :conditions => {parent_column_name => self}
                      end
                      def is_descendant_of?(other)
                        other.left < self.left && self.left < other.right && same_scope?(other)
                      end
                      def is_or_is_descendant_of?(other)
                        other.left <= self.left && self.left < other.right && same_scope?(other)
                      end
                      def is_ancestor_of?(other)
                        self.left < other.left && other.left < self.right && same_scope?(other)
                      end
                      def is_or_is_ancestor_of?(other)
                        self.left <= other.left && other.left < self.right && same_scope?(other)
                      end
                      # Check if other model is in the same scope
                      def same_scope?(other)
                        Array(acts_as_nested_set_options[:scope]).all? do |attr|
                          self.send(attr) == other.send(attr)
                        end
                      end
                      # Find the first sibling to the left
                      def left_sibling
                        siblings.find(:first, :conditions => ["#{self.class.table_name}.#{quoted_left_column_name} < ?", left],
                          :order => "#{self.class.table_name}.#{quoted_left_column_name} DESC")
                      end
                      # Find the first sibling to the right
                      def right_sibling
                        siblings.find(:first, :conditions => ["#{self.class.table_name}.#{quoted_left_column_name} > ?", left])
                      end
                      # Shorthand method for finding the left sibling and moving to the left of it.
                      def move_left
                        move_to_left_of left_sibling
                      end
                      # Shorthand method for finding the right sibling and moving to the right of it.
                      def move_right
                        move_to_right_of right_sibling
                      end
                      # Move the node to the left of another node (you can pass id only)
                      def move_to_left_of(node)
                        move_to node, :left
                      end
                      # Move the node to the left of another node (you can pass id only)
                      def move_to_right_of(node)
                        move_to node, :right
                      end
                      # Move the node to the child of another node (you can pass id only)
                      def move_to_child_of(node)
                        move_to node, :child
                      end
                      # Move the node to root nodes
                      def move_to_root
                        move_to nil, :root
                      end
                      def move_possible?(target)
                        self != target && # Can't target self
                        same_scope?(target) && # can't be in different scopes
                        # !(left..right).include?(target.left..target.right) # this needs tested more
                        # detect impossible move
                        !((left <= target.left && right >= target.left) or (left <= target.right && right >= target.right))
                      end
                      def to_text
                        self_and_descendants.map do |node|
                          "#{'*'*(node.level+1)} #{node.id} #{node.to_s} (#{node.parent_id}, #{node.left}, #{node.right})"
                        end.join("\n")
                      end
                    protected
                      def without_self(scope)
                        scope.scoped :conditions => ["#{self.class.table_name}.#{self.class.primary_key} != ?", self]
                      end
                      # All nested set queries should use this nested_set_scope, which performs finds on
                      # the base ActiveRecord class, using the :scope declared in the acts_as_nested_set
                      # declaration.
                      def nested_set_scope
                        options = {:order => quoted_left_column_name}
                        scopes = Array(acts_as_nested_set_options[:scope])
                        options[:conditions] = scopes.inject({}) do |conditions,attr|
                          conditions.merge attr => self[attr]
                        end unless scopes.empty?
                        self.class.base_class.scoped options
                      end
                      # on creation, set automatically lft and rgt to the end of the tree
                      def set_default_left_and_right
                        maxright = nested_set_scope.maximum(right_column_name) || 0
                        # adds the new node to the right of all existing nodes
                        self[left_column_name] = maxright + 1
                        self[right_column_name] = maxright + 2
                      end
                      # Prunes a branch off of the tree, shifting all of the elements on the right
                      # back to the left so the counts still work.
                      def prune_from_tree
-                       return if right.nil? || left.nil?
-                       diff = right - left + 1
+                       return if right.nil? || left.nil? || !self.class.exists?(id)
                        delete_method = acts_as_nested_set_options[:dependent] == :destroy ?
                          :destroy_all : :delete_all
                        self.class.base_class.transaction do
+                         reload_nested_set
                          nested_set_scope.send(delete_method,
                            ["#{quoted_left_column_name} > ? AND #{quoted_right_column_name} < ?",
                              left, right]
                          )
+                         reload_nested_set
+                         diff = right - left + 1
                          nested_set_scope.update_all(
                            ["#{quoted_left_column_name} = (#{quoted_left_column_name} - ?)", diff],
                            ["#{quoted_left_column_name} >= ?", right]
                          )
                          nested_set_scope.update_all(
                            ["#{quoted_right_column_name} = (#{quoted_right_column_name} - ?)", diff],
                            ["#{quoted_right_column_name} >= ?", right]
                          )
                        end
                      end
                      # reload left, right, and parent
                      def reload_nested_set
                        reload(:select => "#{quoted_left_column_name}, " +
                          "#{quoted_right_column_name}, #{quoted_parent_column_name}")
                      end
                      def move_to(target, position)
                        raise ActiveRecord::ActiveRecordError, "You cannot move a new node" if self.new_record?
                        return if callback(:before_move) == false
                        transaction do
                          if target.is_a? self.class.base_class
                            target.reload_nested_set
                          elsif position != :root
                            # load object if node is not an object
                            target = nested_set_scope.find(target)
                          end
                          self.reload_nested_set
                          unless position == :root || move_possible?(target)
                            raise ActiveRecord::ActiveRecordError, "Impossible move, target node cannot be inside moved tree."
                          end
                          bound = case position
                            when :child;  target[right_column_name]
                            when :left;   target[left_column_name]
                            when :right;  target[right_column_name] + 1
                            when :root;   1
                            else raise ActiveRecord::ActiveRecordError, "Position should be :child, :left, :right or :root ('#{position}' received)."
                          end
                          if bound > self[right_column_name]
                            bound = bound - 1
                            other_bound = self[right_column_name] + 1
                          else
                            other_bound = self[left_column_name] - 1
                          end
                          # there would be no change
                          return if bound == self[right_column_name] || bound == self[left_column_name]
                          # we have defined the boundaries of two non-overlapping intervals,
                          # so sorting puts both the intervals and their boundaries in order
                          a, b, c, d = [self[left_column_name], self[right_column_name], bound, other_bound].sort
                          new_parent = case position
                            when :child;  target.id
                            when :root;   nil
                            else          target[parent_column_name]
                          end
                          self.class.base_class.update_all([
                            "#{quoted_left_column_name} = CASE " +
                              "WHEN #{quoted_left_column_name} BETWEEN :a AND :b " +
                                "THEN #{quoted_left_column_name} + :d - :b " +
                              "WHEN #{quoted_left_column_name} BETWEEN :c AND :d " +
                                "THEN #{quoted_left_column_name} + :a - :c " +
                              "ELSE #{quoted_left_column_name} END, " +
                            "#{quoted_right_column_name} = CASE " +
                              "WHEN #{quoted_right_column_name} BETWEEN :a AND :b " +
                                "THEN #{quoted_right_column_name} + :d - :b " +
                              "WHEN #{quoted_right_column_name} BETWEEN :c AND :d " +
                                "THEN #{quoted_right_column_name} + :a - :c " +
                              "ELSE #{quoted_right_column_name} END, " +
                            "#{quoted_parent_column_name} = CASE " +
                              "WHEN #{self.class.base_class.primary_key} = :id THEN :new_parent " +
                              "ELSE #{quoted_parent_column_name} END",
                            {:a => a, :b => b, :c => c, :d => d, :id => self.id, :new_parent => new_parent}
                          ], nested_set_scope.proxy_options[:conditions])
                        end
                        target.reload_nested_set if target
                        self.reload_nested_set
                        callback(:after_move)
                      end
                    end
                  end
                end
              end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages