jro_apps/redmine Commit - r15667:3e86a2ab52bc

Use .unscoped when querying and creating builtin objects (#24156)....

Jean-Philippe Lang -

r15667:3e86a2ab52bc

parent child

Context file:

r15667:3e86a2ab52bc

app/models/group_builtin.rb +2 -2

               class << self
                 def load_instance
                   return nil if self == GroupBuiltin
-                  instance = order('id').first || create_instance
+                  instance = unscoped.order('id').first || create_instance
                 end
                 def create_instance
                   raise 'The builtin group already exists.' if exists?
-                  instance = new
+                  instance = unscoped.new
                   instance.lastname = name
                   instance.save :validate => false
                   raise 'Unable to create builtin group.' if instance.new_record?

app/models/role.rb +2 -2

               end
               def self.find_or_create_system_role(builtin, name)
-                role = where(:builtin => builtin).first
+                role = unscoped.where(:builtin => builtin).first
                 if role.nil?
-                  role = create(:name => name) do |r|
+                  role = unscoped.create(:name => name) do |r|
                     r.builtin = builtin
                   end
                   raise "Unable to create the #{name} role (#{role.errors.full_messages.join(',')})." if role.new_record?

app/models/user.rb +2 -2

               # Returns the anonymous user.  If the anonymous user does not exist, it is created.  There can be only
               # one anonymous user per database.
               def self.anonymous
-                anonymous_user = AnonymousUser.first
+                anonymous_user = AnonymousUser.unscoped.first
                 if anonymous_user.nil?
-                  anonymous_user = AnonymousUser.create(:lastname => 'Anonymous', :firstname => '', :login => '', :status => 0)
+                  anonymous_user = AnonymousUser.unscoped.create(:lastname => 'Anonymous', :firstname => '', :login => '', :status => 0)
                   raise 'Unable to create the anonymous user.' if anonymous_user.new_record?
                 end
                 anonymous_user

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages