jro_apps/redmine Commit - r2767:3d0fbea9fdfd

Merged r2797, r2804, r2814, r2820, r2837, r2838 from trunk....

Jean-Philippe Lang -

r2767:3d0fbea9fdfd

parent child

Context file:

r2767:3d0fbea9fdfd

Collapse all files

test/fixtures/mail_handler/ticket_with_spaces_between_attribute_and_separator.eml created 644 +43 0

@@ -0,0 +1,43
	1	Return-Path: <jsmith@somenet.foo>
	2	Received: from osiris ([127.0.0.1])
	3	by OSIRIS
	4	with hMailServer ; Sun, 22 Jun 2008 12:28:07 +0200
	5	Message-ID: <000501c8d452$a95cd7e0$0a00a8c0@osiris>
	6	From: "John Smith" <jsmith@somenet.foo>
	7	To: <redmine@somenet.foo>
	8	Subject: New ticket on a given project
	9	Date: Sun, 22 Jun 2008 12:28:07 +0200
	10	MIME-Version: 1.0
	11	Content-Type: text/plain;
	12	format=flowed;
	13	charset="iso-8859-1";
	14	reply-type=original
	15	Content-Transfer-Encoding: 7bit
	16	X-Priority: 3
	17	X-MSMail-Priority: Normal
	18	X-Mailer: Microsoft Outlook Express 6.00.2900.2869
	19	X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2869
	20
	21	Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Maecenas imperdiet
	22	turpis et odio. Integer eget pede vel dolor euismod varius. Phasellus
	23	blandit eleifend augue. Nulla facilisi. Duis id diam. Class aptent taciti
	24	sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. In
	25	in urna sed tellus aliquet lobortis. Morbi scelerisque tortor in dolor. Cras
	26	sagittis odio eu lacus. Aliquam sem tortor, consequat sit amet, vestibulum
	27	id, iaculis at, lectus. Fusce tortor libero, congue ut, euismod nec, luctus
	28	eget, eros. Pellentesque tortor enim, feugiat in, dignissim eget, tristique
	29	sed, mauris. Pellentesque habitant morbi tristique senectus et netus et
	30	malesuada fames ac turpis egestas. Quisque sit amet libero. In hac habitasse
	31	platea dictumst.
	32
	33	Nulla et nunc. Duis pede. Donec et ipsum. Nam ut dui tincidunt neque
	34	sollicitudin iaculis. Duis vitae dolor. Vestibulum eget massa. Sed lorem.
	35	Nullam volutpat cursus erat. Cras felis dolor, lacinia quis, rutrum et,
	36	dictum et, ligula. Sed erat nibh, gravida in, accumsan non, placerat sed,
	37	massa. Sed sodales, ante fermentum ultricies sollicitudin, massa leo
	38	pulvinar dui, a gravida orci mi eget odio. Nunc a lacus.
	39
	40	Project : onlinestore
	41	Tracker: Feature request
	42	category : Stock management
	43	priority: Urgent

app/controllers/news_controller.rb +1 0

             # redMine - project management software
             # Copyright (C) 2006  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class NewsController < ApplicationController
               before_filter :find_news, :except => [:new, :index, :preview]
               before_filter :find_project, :only => [:new, :preview]
               before_filter :authorize, :except => [:index, :preview]
               before_filter :find_optional_project, :only => :index
               accept_key_auth :index
               def index
                 @news_pages, @newss = paginate :news,
                                                :per_page => 10,
                                                :conditions => (@project ? {:project_id => @project.id} : Project.visible_by(User.current)),
                                                :include => [:author, :project],
                                                :order => "#{News.table_name}.created_on DESC"
                 respond_to do |format|
                   format.html { render :layout => false if request.xhr? }
                   format.atom { render_feed(@newss, :title => (@project ? @project.name : Setting.app_title) + ": #{l(:label_news_plural)}") }
                 end
               end
               def show
                 @comments = @news.comments
                 @comments.reverse! if User.current.wants_comments_in_reverse_order?
               end
               def new
                 @news = News.new(:project => @project, :author => User.current)
                 if request.post?
                   @news.attributes = params[:news]
                   if @news.save
                     flash[:notice] = l(:notice_successful_create)
                     Mailer.deliver_news_added(@news) if Setting.notified_events.include?('news_added')
                     redirect_to :controller => 'news', :action => 'index', :project_id => @project
                   end
                 end
               end
               def edit
                 if request.post? and @news.update_attributes(params[:news])
                   flash[:notice] = l(:notice_successful_update)
                   redirect_to :action => 'show', :id => @news
                 end
               end
               def add_comment
                 @comment = Comment.new(params[:comment])
                 @comment.author = User.current
                 if @news.comments << @comment
                   flash[:notice] = l(:label_comment_added)
                   redirect_to :action => 'show', :id => @news
                 else
+                  show
                   render :action => 'show'
                 end
               end
               def destroy_comment
                 @news.comments.find(params[:comment_id]).destroy
                 redirect_to :action => 'show', :id => @news
               end
               def destroy
                 @news.destroy
                 redirect_to :action => 'index', :project_id => @project
               end
               def preview
                 @text = (params[:news] ? params[:news][:description] : nil)
                 render :partial => 'common/preview'
               end
             private
               def find_news
                 @news = News.find(params[:id])
                 @project = @news.project
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               def find_project
                 @project = Project.find(params[:project_id])
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               def find_optional_project
                 return true unless params[:project_id]
                 @project = Project.find(params[:project_id])
                 authorize
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
             end

app/helpers/application_helper.rb +1 -1

             # redMine - project management software
             # Copyright (C) 2006-2007  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require 'coderay'
             require 'coderay/helpers/file_type'
             require 'forwardable'
             require 'cgi'
             module ApplicationHelper
               include Redmine::WikiFormatting::Macros::Definitions
               include GravatarHelper::PublicMethods
               extend Forwardable
               def_delegators :wiki_helper, :wikitoolbar_for, :heads_for_wiki_formatter
               def current_role
                 @current_role ||= User.current.role_for_project(@project)
               end
               # Return true if user is authorized for controller/action, otherwise false
               def authorize_for(controller, action)
                 User.current.allowed_to?({:controller => controller, :action => action}, @project)
               end
               # Display a link if user is authorized
               def link_to_if_authorized(name, options = {}, html_options = nil, *parameters_for_method_reference)
                 link_to(name, options, html_options, *parameters_for_method_reference) if authorize_for(options[:controller] || params[:controller], options[:action])
               end
               # Display a link to remote if user is authorized
               def link_to_remote_if_authorized(name, options = {}, html_options = nil)
                 url = options[:url] || {}
                 link_to_remote(name, options, html_options) if authorize_for(url[:controller] || params[:controller], url[:action])
               end
               # Display a link to user's account page
               def link_to_user(user, options={})
                 (user && !user.anonymous?) ? link_to(user.name(options[:format]), :controller => 'account', :action => 'show', :id => user) : 'Anonymous'
               end
               def link_to_issue(issue, options={})
                 options[:class] ||= ''
                 options[:class] << ' issue'
                 options[:class] << ' closed' if issue.closed?
                 link_to "#{issue.tracker.name} ##{issue.id}", {:controller => "issues", :action => "show", :id => issue}, options
               end
               # Generates a link to an attachment.
               # Options:
               # * :text - Link text (default to attachment filename)
               # * :download - Force download (default: false)
               def link_to_attachment(attachment, options={})
                 text = options.delete(:text) || attachment.filename
                 action = options.delete(:download) ? 'download' : 'show'
                 link_to(h(text), {:controller => 'attachments', :action => action, :id => attachment, :filename => attachment.filename }, options)
               end
               def toggle_link(name, id, options={})
                 onclick = "Element.toggle('#{id}'); "
                 onclick << (options[:focus] ? "Form.Element.focus('#{options[:focus]}'); " : "this.blur(); ")
                 onclick << "return false;"
                 link_to(name, "#", :onclick => onclick)
               end
               def image_to_function(name, function, html_options = {})
                 html_options.symbolize_keys!
                 tag(:input, html_options.merge({
                     :type => "image", :src => image_path(name),
                     :onclick => (html_options[:onclick] ? "#{html_options[:onclick]}; " : "") + "#{function};"
                     }))
               end
               def prompt_to_remote(name, text, param, url, html_options = {})
                 html_options[:onclick] = "promptToRemote('#{text}', '#{param}', '#{url_for(url)}'); return false;"
                 link_to name, {}, html_options
               end
               def format_date(date)
                 return nil unless date
                 # "Setting.date_format.size < 2" is a temporary fix (content of date_format setting changed)
                 @date_format ||= (Setting.date_format.blank? || Setting.date_format.size < 2 ? l(:general_fmt_date) : Setting.date_format)
                 date.strftime(@date_format)
               end
               def format_time(time, include_date = true)
                 return nil unless time
                 time = time.to_time if time.is_a?(String)
                 zone = User.current.time_zone
                 local = zone ? time.in_time_zone(zone) : (time.utc? ? time.localtime : time)
                 @date_format ||= (Setting.date_format.blank? || Setting.date_format.size < 2 ? l(:general_fmt_date) : Setting.date_format)
                 @time_format ||= (Setting.time_format.blank? ? l(:general_fmt_time) : Setting.time_format)
                 include_date ? local.strftime("#{@date_format} #{@time_format}") : local.strftime(@time_format)
               end
               def format_activity_title(text)
                 h(truncate_single_line(text, 100))
               end
               def format_activity_day(date)
                 date == Date.today ? l(:label_today).titleize : format_date(date)
               end
               def format_activity_description(text)
                 h(truncate(text.to_s, 250).gsub(%r{<(pre|code)>.*$}m, '...'))
               end
               def distance_of_date_in_words(from_date, to_date = 0)
                 from_date = from_date.to_date if from_date.respond_to?(:to_date)
                 to_date = to_date.to_date if to_date.respond_to?(:to_date)
                 distance_in_days = (to_date - from_date).abs
                 lwr(:actionview_datehelper_time_in_words_day, distance_in_days)
               end
               def due_date_distance_in_words(date)
                 if date
                   l((date < Date.today ? :label_roadmap_overdue : :label_roadmap_due_in), distance_of_date_in_words(Date.today, date))
                 end
               end
               def render_page_hierarchy(pages, node=nil)
                 content = ''
                 if pages[node]
                   content << "<ul class=\"pages-hierarchy\">\n"
                   pages[node].each do |page|
                     content << "<li>"
                     content << link_to(h(page.pretty_title), {:controller => 'wiki', :action => 'index', :id => page.project, :page => page.title},
                                        :title => (page.respond_to?(:updated_on) ? l(:label_updated_time, distance_of_time_in_words(Time.now, page.updated_on)) : nil))
                     content << "\n" + render_page_hierarchy(pages, page.id) if pages[page.id]
                     content << "</li>\n"
                   end
                   content << "</ul>\n"
                 end
                 content
               end
               # Renders flash messages
               def render_flash_messages
                 s = ''
                 flash.each do |k,v|
                   s << content_tag('div', v, :class => "flash #{k}")
                 end
                 s
               end
               # Truncates and returns the string as a single line
               def truncate_single_line(string, *args)
                 truncate(string, *args).gsub(%r{[\r\n]+}m, ' ')
               end
               def html_hours(text)
                 text.gsub(%r{(\d+)\.(\d+)}, '<span class="hours hours-int">\1</span><span class="hours hours-dec">.\2</span>')
               end
               def authoring(created, author, options={})
                 time_tag = @project.nil? ? content_tag('acronym', distance_of_time_in_words(Time.now, created), :title => format_time(created)) :
                                            link_to(distance_of_time_in_words(Time.now, created),
                                                    {:controller => 'projects', :action => 'activity', :id => @project, :from => created.to_date},
                                                    :title => format_time(created))
                 author_tag = (author.is_a?(User) && !author.anonymous?) ? link_to(h(author), :controller => 'account', :action => 'show', :id => author) : h(author || 'Anonymous')
                 l(options[:label] || :label_added_time_by, author_tag, time_tag)
               end
               def l_or_humanize(s, options={})
                 k = "#{options[:prefix]}#{s}".to_sym
                 l_has_string?(k) ? l(k) : s.to_s.humanize
               end
               def day_name(day)
                 l(:general_day_names).split(',')[day-1]
               end
               def month_name(month)
                 l(:actionview_datehelper_select_month_names).split(',')[month-1]
               end
               def syntax_highlight(name, content)
                 type = CodeRay::FileType[name]
                 type ? CodeRay.scan(content, type).html : h(content)
               end
               def to_path_param(path)
                 path.to_s.split(%r{[/\\]}).select {|p| !p.blank?}
               end
               def pagination_links_full(paginator, count=nil, options={})
                 page_param = options.delete(:page_param) || :page
                 url_param = params.dup
                 # don't reuse params if filters are present
                 url_param.clear if url_param.has_key?(:set_filter)
                 html = ''
                 html << link_to_remote(('&#171; ' + l(:label_previous)),
                                         {:update => 'content',
                                          :url => url_param.merge(page_param => paginator.current.previous),
                                          :complete => 'window.scrollTo(0,0)'},
                                         {:href => url_for(:params => url_param.merge(page_param => paginator.current.previous))}) + ' ' if paginator.current.previous
                 html << (pagination_links_each(paginator, options) do |n|
                   link_to_remote(n.to_s,
                                   {:url => {:params => url_param.merge(page_param => n)},
                                    :update => 'content',
                                    :complete => 'window.scrollTo(0,0)'},
                                   {:href => url_for(:params => url_param.merge(page_param => n))})
                 end || '')
                 html << ' ' + link_to_remote((l(:label_next) + ' &#187;'),
                                              {:update => 'content',
                                               :url => url_param.merge(page_param => paginator.current.next),
                                               :complete => 'window.scrollTo(0,0)'},
                                              {:href => url_for(:params => url_param.merge(page_param => paginator.current.next))}) if paginator.current.next
                 unless count.nil?
                   html << [" (#{paginator.current.first_item}-#{paginator.current.last_item}/#{count})", per_page_links(paginator.items_per_page)].compact.join(' | ')
                 end
                 html
               end
               def per_page_links(selected=nil)
                 url_param = params.dup
                 url_param.clear if url_param.has_key?(:set_filter)
                 links = Setting.per_page_options_array.collect do |n|
                   n == selected ? n : link_to_remote(n, {:update => "content", :url => params.dup.merge(:per_page => n)},
                                                         {:href => url_for(url_param.merge(:per_page => n))})
                 end
                 links.size > 1 ? l(:label_display_per_page, links.join(', ')) : nil
               end
               def breadcrumb(*args)
                 elements = args.flatten
                 elements.any? ? content_tag('p', args.join(' &#187; ') + ' &#187; ', :class => 'breadcrumb') : nil
               end
               def html_title(*args)
                 if args.empty?
                   title = []
                   title << @project.name if @project
                   title += @html_title if @html_title
                   title << Setting.app_title
                   title.compact.join(' - ')
                 else
                   @html_title ||= []
                   @html_title += args
                 end
               end
               def accesskey(s)
                 Redmine::AccessKeys.key_for s
               end
               # Formats text according to system settings.
               # 2 ways to call this method:
               # * with a String: textilizable(text, options)
               # * with an object and one of its attribute: textilizable(issue, :description, options)
               def textilizable(*args)
                 options = args.last.is_a?(Hash) ? args.pop : {}
                 case args.size
                 when 1
                   obj = options[:object]
                   text = args.shift
                 when 2
                   obj = args.shift
                   text = obj.send(args.shift).to_s
                 else
                   raise ArgumentError, 'invalid arguments to textilizable'
                 end
                 return '' if text.blank?
                 only_path = options.delete(:only_path) == false ? false : true
                 # when using an image link, try to use an attachment, if possible
                 attachments = options[:attachments] || (obj && obj.respond_to?(:attachments) ? obj.attachments : nil)
                 if attachments
                   attachments = attachments.sort_by(&:created_on).reverse
                   text = text.gsub(/!((\<|\=|\>)?(\([^\)]+\))?(\[[^\]]+\])?(\{[^\}]+\})?)(\S+\.(bmp|gif|jpg|jpeg|png))!/i) do |m|
                     style = $1
                     filename = $6.downcase
                     # search for the picture in attachments
                     if found = attachments.detect { |att| att.filename.downcase == filename }
                       image_url = url_for :only_path => only_path, :controller => 'attachments', :action => 'download', :id => found
                       desc = found.description.to_s.gsub(/^([^\(\)]*).*$/, "\\1")
                       alt = desc.blank? ? nil : "(#{desc})"
                       "!#{style}#{image_url}#{alt}!"
                     else
                       m
                     end
                   end
                 end
                 text = Redmine::WikiFormatting.to_html(Setting.text_formatting, text) { |macro, args| exec_macro(macro, obj, args) }
                 # different methods for formatting wiki links
                 case options[:wiki_links]
                 when :local
                   # used for local links to html files
                   format_wiki_link = Proc.new {|project, title, anchor| "#{title}.html" }
                 when :anchor
                   # used for single-file wiki export
                   format_wiki_link = Proc.new {|project, title, anchor| "##{title}" }
                 else
                   format_wiki_link = Proc.new {|project, title, anchor| url_for(:only_path => only_path, :controller => 'wiki', :action => 'index', :id => project, :page => title, :anchor => anchor) }
                 end
                 project = options[:project] || @project || (obj && obj.respond_to?(:project) ? obj.project : nil)
                 # Wiki links
                 #
                 # Examples:
                 #   [[mypage]]
                 #   [[mypage|mytext]]
                 # wiki links can refer other project wikis, using project name or identifier:
                 #   [[project:]] -> wiki starting page
                 #   [[project:|mytext]]
                 #   [[project:mypage]]
                 #   [[project:mypage|mytext]]
                 text = text.gsub(/(!)?(\[\[([^\]\n\|]+)(\|([^\]\n\|]+))?\]\])/) do |m|
                   link_project = project
                   esc, all, page, title = $1, $2, $3, $5
                   if esc.nil?
                     if page =~ /^([^\:]+)\:(.*)$/
                       link_project = Project.find_by_name($1) || Project.find_by_identifier($1)
                       page = $2
                       title ||= $1 if page.blank?
                     end
                     if link_project && link_project.wiki
                       # extract anchor
                       anchor = nil
                       if page =~ /^(.+?)\#(.+)$/
                         page, anchor = $1, $2
                       end
                       # check if page exists
                       wiki_page = link_project.wiki.find_page(page)
                       link_to((title || page), format_wiki_link.call(link_project, Wiki.titleize(page), anchor),
                                                :class => ('wiki-page' + (wiki_page ? '' : ' new')))
                     else
                       # project or wiki doesn't exist
                       title || page
                     end
                   else
                     all
                   end
                 end
                 # Redmine links
                 #
                 # Examples:
                 #   Issues:
                 #     #52 -> Link to issue #52
                 #   Changesets:
                 #     r52 -> Link to revision 52
                 #     commit:a85130f -> Link to scmid starting with a85130f
                 #   Documents:
                 #     document#17 -> Link to document with id 17
                 #     document:Greetings -> Link to the document with title "Greetings"
                 #     document:"Some document" -> Link to the document with title "Some document"
                 #   Versions:
                 #     version#3 -> Link to version with id 3
                 #     version:1.0.0 -> Link to version named "1.0.0"
                 #     version:"1.0 beta 2" -> Link to version named "1.0 beta 2"
                 #   Attachments:
                 #     attachment:file.zip -> Link to the attachment of the current object named file.zip
                 #   Source files:
                 #     source:some/file -> Link to the file located at /some/file in the project's repository
                 #     source:some/file@52 -> Link to the file's revision 52
                 #     source:some/file#L120 -> Link to line 120 of the file
                 #     source:some/file@52#L120 -> Link to line 120 of the file's revision 52
                 #     export:some/file -> Force the download of the file
                 #  Forum messages:
                 #     message#1218 -> Link to message with id 1218
-                text = text.gsub(%r{([\s\(,\-\>]|^)(!)?(attachment|document|version|commit|source|export|message)?((#|r)(\d+)|(:)([^"\s<>][^\s<>]*?|"[^"]+?"))(?=(?=[[:punct:]]\W)|\s|<|$)}) do |m|
+                text = text.gsub(%r{([\s\(,\-\>]|^)(!)?(attachment|document|version|commit|source|export|message)?((#|r)(\d+)|(:)([^"\s<>][^\s<>]*?|"[^"]+?"))(?=(?=[[:punct:]]\W)|,|\s|<|$)}) do |m|
                   leading, esc, prefix, sep, oid = $1, $2, $3, $5 || $7, $6 || $8
                   link = nil
                   if esc.nil?
                     if prefix.nil? && sep == 'r'
                       if project && (changeset = project.changesets.find_by_revision(oid))
                         link = link_to("r#{oid}", {:only_path => only_path, :controller => 'repositories', :action => 'revision', :id => project, :rev => oid},
                                                   :class => 'changeset',
                                                   :title => truncate_single_line(changeset.comments, 100))
                       end
                     elsif sep == '#'
                       oid = oid.to_i
                       case prefix
                       when nil
                         if issue = Issue.find_by_id(oid, :include => [:project, :status], :conditions => Project.visible_by(User.current))
                           link = link_to("##{oid}", {:only_path => only_path, :controller => 'issues', :action => 'show', :id => oid},
                                                     :class => (issue.closed? ? 'issue closed' : 'issue'),
                                                     :title => "#{truncate(issue.subject, 100)} (#{issue.status.name})")
                           link = content_tag('del', link) if issue.closed?
                         end
                       when 'document'
                         if document = Document.find_by_id(oid, :include => [:project], :conditions => Project.visible_by(User.current))
                           link = link_to h(document.title), {:only_path => only_path, :controller => 'documents', :action => 'show', :id => document},
                                                             :class => 'document'
                         end
                       when 'version'
                         if version = Version.find_by_id(oid, :include => [:project], :conditions => Project.visible_by(User.current))
                           link = link_to h(version.name), {:only_path => only_path, :controller => 'versions', :action => 'show', :id => version},
                                                           :class => 'version'
                         end
                       when 'message'
                         if message = Message.find_by_id(oid, :include => [:parent, {:board => :project}], :conditions => Project.visible_by(User.current))
                           link = link_to h(truncate(message.subject, 60)), {:only_path => only_path,
                                                                             :controller => 'messages',
                                                                             :action => 'show',
                                                                             :board_id => message.board,
                                                                             :id => message.root,
                                                                             :anchor => (message.parent ? "message-#{message.id}" : nil)},
                                                              :class => 'message'
                         end
                       end
                     elsif sep == ':'
                       # removes the double quotes if any
                       name = oid.gsub(%r{^"(.*)"$}, "\\1")
                       case prefix
                       when 'document'
                         if project && document = project.documents.find_by_title(name)
                           link = link_to h(document.title), {:only_path => only_path, :controller => 'documents', :action => 'show', :id => document},
                                                             :class => 'document'
                         end
                       when 'version'
                         if project && version = project.versions.find_by_name(name)
                           link = link_to h(version.name), {:only_path => only_path, :controller => 'versions', :action => 'show', :id => version},
                                                           :class => 'version'
                         end
                       when 'commit'
                         if project && (changeset = project.changesets.find(:first, :conditions => ["scmid LIKE ?", "#{name}%"]))
                           link = link_to h("#{name}"), {:only_path => only_path, :controller => 'repositories', :action => 'revision', :id => project, :rev => changeset.revision},
                                                        :class => 'changeset',
                                                        :title => truncate_single_line(changeset.comments, 100)
                         end
                       when 'source', 'export'
                         if project && project.repository
                           name =~ %r{^[/\\]*(.*?)(@([0-9a-f]+))?(#(L\d+))?$}
                           path, rev, anchor = $1, $3, $5
                           link = link_to h("#{prefix}:#{name}"), {:controller => 'repositories', :action => 'entry', :id => project,
                                                                   :path => to_path_param(path),
                                                                   :rev => rev,
                                                                   :anchor => anchor,
                                                                   :format => (prefix == 'export' ? 'raw' : nil)},
                                                                  :class => (prefix == 'export' ? 'source download' : 'source')
                         end
                       when 'attachment'
                         if attachments && attachment = attachments.detect {|a| a.filename == name }
                           link = link_to h(attachment.filename), {:only_path => only_path, :controller => 'attachments', :action => 'download', :id => attachment},
                                                                  :class => 'attachment'
                         end
                       end
                     end
                   end
                   leading + (link || "#{prefix}#{sep}#{oid}")
                 end
                 text
               end
               # Same as Rails' simple_format helper without using paragraphs
               def simple_format_without_paragraph(text)
                 text.to_s.
                   gsub(/\r\n?/, "\n").                    # \r\n and \r -> \n
                   gsub(/\n\n+/, "<br /><br />").          # 2+ newline  -> 2 br
                   gsub(/([^\n]\n)(?=[^\n])/, '\1<br />')  # 1 newline   -> br
               end
               def error_messages_for(object_name, options = {})
                 options = options.symbolize_keys
                 object = instance_variable_get("@#{object_name}")
                 if object && !object.errors.empty?
                   # build full_messages here with controller current language
                   full_messages = []
                   object.errors.each do |attr, msg|
                     next if msg.nil?
                     msg = [msg] unless msg.is_a?(Array)
                     if attr == "base"
                       full_messages << l(*msg)
                     else
                       full_messages << "&#171; " + (l_has_string?("field_" + attr) ? l("field_" + attr) : object.class.human_attribute_name(attr)) + " &#187; " + l(*msg) unless attr == "custom_values"
                     end
                   end
                   # retrieve custom values error messages
                   if object.errors[:custom_values]
                     object.custom_values.each do |v|
                       v.errors.each do |attr, msg|
                         next if msg.nil?
                         msg = [msg] unless msg.is_a?(Array)
                         full_messages << "&#171; " + v.custom_field.name + " &#187; " + l(*msg)
                       end
                     end
                   end
                   content_tag("div",
                     content_tag(
                       options[:header_tag] || "span", lwr(:gui_validation_error, full_messages.length) + ":"
                     ) +
                     content_tag("ul", full_messages.collect { |msg| content_tag("li", msg) }),
                     "id" => options[:id] || "errorExplanation", "class" => options[:class] || "errorExplanation"
                   )
                 else
                   ""
                 end
               end
               def lang_options_for_select(blank=true)
                 (blank ? [["(auto)", ""]] : []) +
                   GLoc.valid_languages.collect{|lang| [ ll(lang.to_s, :general_lang_name), lang.to_s]}.sort{|x,y| x.last <=> y.last }
               end
               def label_tag_for(name, option_tags = nil, options = {})
                 label_text = l(("field_"+field.to_s.gsub(/\_id$/, "")).to_sym) + (options.delete(:required) ? @template.content_tag("span", " *", :class => "required"): "")
                 content_tag("label", label_text)
               end
               def labelled_tabular_form_for(name, object, options, &proc)
                 options[:html] ||= {}
                 options[:html][:class] = 'tabular' unless options[:html].has_key?(:class)
                 form_for(name, object, options.merge({ :builder => TabularFormBuilder, :lang => current_language}), &proc)
               end
               def back_url_hidden_field_tag
                 back_url = params[:back_url] || request.env['HTTP_REFERER']
                 back_url = CGI.unescape(back_url.to_s)
                 hidden_field_tag('back_url', CGI.escape(back_url)) unless back_url.blank?
               end
               def check_all_links(form_name)
                 link_to_function(l(:button_check_all), "checkAll('#{form_name}', true)") +
                 " | " +
                 link_to_function(l(:button_uncheck_all), "checkAll('#{form_name}', false)")
               end
               def progress_bar(pcts, options={})
                 pcts = [pcts, pcts] unless pcts.is_a?(Array)
                 pcts[1] = pcts[1] - pcts[0]
                 pcts << (100 - pcts[1] - pcts[0])
                 width = options[:width] || '100px;'
                 legend = options[:legend] || ''
                 content_tag('table',
                   content_tag('tr',
                     (pcts[0] > 0 ? content_tag('td', '', :style => "width: #{pcts[0].floor}%;", :class => 'closed') : '') +
                     (pcts[1] > 0 ? content_tag('td', '', :style => "width: #{pcts[1].floor}%;", :class => 'done') : '') +
                     (pcts[2] > 0 ? content_tag('td', '', :style => "width: #{pcts[2].floor}%;", :class => 'todo') : '')
                   ), :class => 'progress', :style => "width: #{width};") +
                   content_tag('p', legend, :class => 'pourcent')
               end
               def context_menu_link(name, url, options={})
                 options[:class] ||= ''
                 if options.delete(:selected)
                   options[:class] << ' icon-checked disabled'
                   options[:disabled] = true
                 end
                 if options.delete(:disabled)
                   options.delete(:method)
                   options.delete(:confirm)
                   options.delete(:onclick)
                   options[:class] << ' disabled'
                   url = '#'
                 end
                 link_to name, url, options
               end
               def calendar_for(field_id)
                 include_calendar_headers_tags
                 image_tag("calendar.png", {:id => "#{field_id}_trigger",:class => "calendar-trigger"}) +
                 javascript_tag("Calendar.setup({inputField : '#{field_id}', ifFormat : '%Y-%m-%d', button : '#{field_id}_trigger' });")
               end
               def include_calendar_headers_tags
                 unless @calendar_headers_tags_included
                   @calendar_headers_tags_included = true
                   content_for :header_tags do
                     javascript_include_tag('calendar/calendar') +
                     javascript_include_tag("calendar/lang/calendar-#{current_language}.js") +
                     javascript_include_tag('calendar/calendar-setup') +
                     stylesheet_link_tag('calendar')
                   end
                 end
               end
               def content_for(name, content = nil, &block)
                 @has_content ||= {}
                 @has_content[name] = true
                 super(name, content, &block)
               end
               def has_content?(name)
                 (@has_content && @has_content[name]) || false
               end
               # Returns the avatar image tag for the given +user+ if avatars are enabled
               # +user+ can be a User or a string that will be scanned for an email address (eg. 'joe <joe@foo.bar>')
               def avatar(user, options = { })
                 if Setting.gravatar_enabled?
                   email = nil
                   if user.respond_to?(:mail)
                     email = user.mail
                   elsif user.to_s =~ %r{<(.+?)>}
                     email = $1
                   end
                   return gravatar(email.to_s.downcase, options) unless email.blank? rescue nil
                 end
               end
               private
               def wiki_helper
                 helper = Redmine::WikiFormatting.helper_for(Setting.text_formatting)
                 extend helper
                 return self
               end
             end

app/models/mail_handler.rb +1 -1

             # redMine - project management software
             # Copyright (C) 2006-2007  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class MailHandler < ActionMailer::Base
               include ActionView::Helpers::SanitizeHelper
               class UnauthorizedAction < StandardError; end
               class MissingInformation < StandardError; end
               attr_reader :email, :user
               def self.receive(email, options={})
                 @@handler_options = options.dup
                 @@handler_options[:issue] ||= {}
                 @@handler_options[:allow_override] = @@handler_options[:allow_override].split(',').collect(&:strip) if @@handler_options[:allow_override].is_a?(String)
                 @@handler_options[:allow_override] ||= []
                 # Project needs to be overridable if not specified
                 @@handler_options[:allow_override] << 'project' unless @@handler_options[:issue].has_key?(:project)
                 # Status overridable by default
                 @@handler_options[:allow_override] << 'status' unless @@handler_options[:issue].has_key?(:status)
                 super email
               end
               # Processes incoming emails
               def receive(email)
                 @email = email
                 @user = User.active.find(:first, :conditions => ["LOWER(mail) = ?", email.from.to_a.first.to_s.strip.downcase])
                 unless @user
                   # Unknown user => the email is ignored
                   # TODO: ability to create the user's account
                   logger.info "MailHandler: email submitted by unknown user [#{email.from.first}]" if logger && logger.info
                   return false
                 end
                 User.current = @user
                 dispatch
               end
               private
               ISSUE_REPLY_SUBJECT_RE = %r{\[[^\]]+#(\d+)\]}
               def dispatch
                 if m = email.subject.match(ISSUE_REPLY_SUBJECT_RE)
                   receive_issue_update(m[1].to_i)
                 else
                   receive_issue
                 end
               rescue ActiveRecord::RecordInvalid => e
                 # TODO: send a email to the user
                 logger.error e.message if logger
                 false
               rescue MissingInformation => e
                 logger.error "MailHandler: missing information from #{user}: #{e.message}" if logger
                 false
               rescue UnauthorizedAction => e
                 logger.error "MailHandler: unauthorized attempt from #{user}" if logger
                 false
               end
               # Creates a new issue
               def receive_issue
                 project = target_project
                 tracker = (get_keyword(:tracker) && project.trackers.find_by_name(get_keyword(:tracker))) || project.trackers.find(:first)
                 category = (get_keyword(:category) && project.issue_categories.find_by_name(get_keyword(:category)))
                 priority = (get_keyword(:priority) && Enumeration.find_by_opt_and_name('IPRI', get_keyword(:priority)))
                 status =  (get_keyword(:status) && IssueStatus.find_by_name(get_keyword(:status)))
                 # check permission
                 raise UnauthorizedAction unless user.allowed_to?(:add_issues, project)
                 issue = Issue.new(:author => user, :project => project, :tracker => tracker, :category => category, :priority => priority)
                 # check workflow
                 if status && issue.new_statuses_allowed_to(user).include?(status)
                   issue.status = status
                 end
                 issue.subject = email.subject.chomp.toutf8
                 issue.description = plain_text_body
                 # custom fields
                 issue.custom_field_values = issue.available_custom_fields.inject({}) do |h, c|
                   if value = get_keyword(c.name, :override => true)
                     h[c.id] = value
                   end
                   h
                 end
                 issue.save!
                 add_attachments(issue)
                 logger.info "MailHandler: issue ##{issue.id} created by #{user}" if logger && logger.info
                 # add To and Cc as watchers
                 add_watchers(issue)
                 # send notification after adding watchers so that they can reply to Redmine
                 Mailer.deliver_issue_add(issue) if Setting.notified_events.include?('issue_added')
                 issue
               end
               def target_project
                 # TODO: other ways to specify project:
                 # * parse the email To field
                 # * specific project (eg. Setting.mail_handler_target_project)
                 target = Project.find_by_identifier(get_keyword(:project))
                 raise MissingInformation.new('Unable to determine target project') if target.nil?
                 target
               end
               # Adds a note to an existing issue
               def receive_issue_update(issue_id)
                 status =  (get_keyword(:status) && IssueStatus.find_by_name(get_keyword(:status)))
                 issue = Issue.find_by_id(issue_id)
                 return unless issue
                 # check permission
                 raise UnauthorizedAction unless user.allowed_to?(:add_issue_notes, issue.project) || user.allowed_to?(:edit_issues, issue.project)
                 raise UnauthorizedAction unless status.nil? || user.allowed_to?(:edit_issues, issue.project)
                 # add the note
                 journal = issue.init_journal(user, plain_text_body)
                 add_attachments(issue)
                 # check workflow
                 if status && issue.new_statuses_allowed_to(user).include?(status)
                   issue.status = status
                 end
                 issue.save!
                 logger.info "MailHandler: issue ##{issue.id} updated by #{user}" if logger && logger.info
                 Mailer.deliver_issue_edit(journal) if Setting.notified_events.include?('issue_updated')
                 journal
               end
               def add_attachments(obj)
                 if email.has_attachments?
                   email.attachments.each do |attachment|
                     Attachment.create(:container => obj,
                                       :file => attachment,
                                       :author => user,
                                       :content_type => attachment.content_type)
                   end
                 end
               end
               # Adds To and Cc as watchers of the given object if the sender has the
               # appropriate permission
               def add_watchers(obj)
                 if user.allowed_to?("add_#{obj.class.name.underscore}_watchers".to_sym, obj.project)
                   addresses = [email.to, email.cc].flatten.compact.uniq.collect {|a| a.strip.downcase}
                   unless addresses.empty?
                     watchers = User.active.find(:all, :conditions => ['LOWER(mail) IN (?)', addresses])
                     watchers.each {|w| obj.add_watcher(w)}
                   end
                 end
               end
               def get_keyword(attr, options={})
                 @keywords ||= {}
                 if @keywords.has_key?(attr)
                   @keywords[attr]
                 else
                   @keywords[attr] = begin
-                    if (options[:override] || @@handler_options[:allow_override].include?(attr.to_s)) && plain_text_body.gsub!(/^#{attr}:[ \t]*(.+)\s*$/i, '')
+                    if (options[:override] || @@handler_options[:allow_override].include?(attr.to_s)) && plain_text_body.gsub!(/^#{attr}[ \t]*:[ \t]*(.+)\s*$/i, '')
                       $1.strip
                     elsif !@@handler_options[:issue][attr].blank?
                       @@handler_options[:issue][attr]
                     end
                   end
                 end
               end
               # Returns the text/plain part of the email
               # If not found (eg. HTML-only email), returns the body with tags removed
               def plain_text_body
                 return @plain_text_body unless @plain_text_body.nil?
                 parts = @email.parts.collect {|c| (c.respond_to?(:parts) && !c.parts.empty?) ? c.parts : c}.flatten
                 if parts.empty?
                   parts << @email
                 end
                 plain_text_part = parts.detect {|p| p.content_type == 'text/plain'}
                 if plain_text_part.nil?
                   # no text/plain part found, assuming html-only email
                   # strip html tags and remove doctype directive
                   @plain_text_body = strip_tags(@email.body.to_s)
                   @plain_text_body.gsub! %r{^<!DOCTYPE .*$}, ''
                 else
                   @plain_text_body = plain_text_part.body.to_s
                 end
                 @plain_text_body.strip!
                 @plain_text_body
               end
             end

app/views/mailer/reminder.text.html.rhtml +1 -1

             <p><%= l(:mail_body_reminder, @issues.size, @days) %></p>
             <ul>
             <% @issues.each do |issue| -%>
-                <li><%=h "#{issue.project} - #{issue.tracker} ##{issue.id}: #{issue.subject}" %></li>
+              <li><%=h issue.project %> - <%=link_to("#{issue.tracker} ##{issue.id}", :controller => 'issues', :action => 'show', :id => issue, :only_path => false)%>: <%=h issue.subject %></li>
             <% end -%>
             </ul>
             <p><%= link_to l(:label_issue_view_all), @issues_url %></p>

app/views/wiki/special_date_index.rhtml +2 -2

             <h2><%= l(:label_index_by_date) %></h2>
             <% if @pages.empty? %>
             <p class="nodata"><%= l(:label_no_data) %></p>
             <% end %>
             <% @pages_by_date.keys.sort.reverse.each do |date| %>
             <h3><%= format_date(date) %></h3>
             <ul>
             <% @pages_by_date[date].each do |page| %>
                 <li><%= link_to page.pretty_title, :action => 'index', :page => page.title %></li>
             <% end %>
             </ul>
             <% end %>
             <% content_for :sidebar do %>
               <%= render :partial => 'sidebar' %>
             <% end %>
             <% unless @pages.empty? %>
             <p class="other-formats">
             <%= l(:label_export_to) %>
-            <span><%= link_to 'Atom', {:controller => 'projects', :action => 'activity', :id => @project, :show_wiki_pages => 1, :format => 'atom', :key => User.current.rss_key}, :class => 'feed' %></span>
+            <span><%= link_to 'Atom', {:controller => 'projects', :action => 'activity', :id => @project, :show_wiki_edits => 1, :format => 'atom', :key => User.current.rss_key}, :class => 'feed' %></span>
             <span><%= link_to 'HTML', {:action => 'special', :page => 'export'}, :class => 'html' %></span>
             </p>
             <% end %>
             <% content_for :header_tags do %>
-            <%= auto_discovery_link_tag(:atom, :controller => 'projects', :action => 'activity', :id => @project, :show_wiki_pages => 1, :format => 'atom', :key => User.current.rss_key) %>
+            <%= auto_discovery_link_tag(:atom, :controller => 'projects', :action => 'activity', :id => @project, :show_wiki_edits => 1, :format => 'atom', :key => User.current.rss_key) %>
             <% end %>

app/views/wiki/special_page_index.rhtml +2 -2

             <h2><%= l(:label_index_by_title) %></h2>
             <% if @pages.empty? %>
             <p class="nodata"><%= l(:label_no_data) %></p>
             <% end %>
             <%= render_page_hierarchy(@pages_by_parent_id) %>
             <% content_for :sidebar do %>
               <%= render :partial => 'sidebar' %>
             <% end %>
             <% unless @pages.empty? %>
             <p class="other-formats">
             <%= l(:label_export_to) %>
-            <span><%= link_to 'Atom', {:controller => 'projects', :action => 'activity', :id => @project, :show_wiki_pages => 1, :format => 'atom', :key => User.current.rss_key}, :class => 'feed' %></span>
+            <span><%= link_to 'Atom', {:controller => 'projects', :action => 'activity', :id => @project, :show_wiki_edits => 1, :format => 'atom', :key => User.current.rss_key}, :class => 'feed' %></span>
             <span><%= link_to 'HTML', {:action => 'special', :page => 'export'} %></span>
             </p>
             <% end %>
             <% content_for :header_tags do %>
-            <%= auto_discovery_link_tag(:atom, :controller => 'projects', :action => 'activity', :id => @project, :show_wiki_pages => 1, :format => 'atom', :key => User.current.rss_key) %>
+            <%= auto_discovery_link_tag(:atom, :controller => 'projects', :action => 'activity', :id => @project, :show_wiki_edits => 1, :format => 'atom', :key => User.current.rss_key) %>
             <% end %>

doc/CHANGELOG +5 0

             == Redmine changelog
             Redmine - project management software
             Copyright (C) 2006-2009  Jean-Philippe Lang
             http://www.redmine.org/
             == 2009-xx-xx v0.8.5
+            * Incoming mail handler : Allow spaces between keywords and colon
+            * Do not require a non-word character after a comma in Redmine links
+            * Include issue hyperlinks in reminder emails
+            * Fixed: 500 Internal Server Error is raised if add an empty comment to the news
+            * Fixes: Atom links for wiki pages are not correct
             * Fixed: Atom feeds leak email address
             == 2009-05-17 v0.8.4
             * Allow textile mailto links
             * Fixed: memory consumption when uploading file
             * Fixed: Mercurial integration doesn't work if Redmine is installed in folder path containing space
             * Fixed: an error is raised when no tab is available on project settings
             * Fixed: insert image macro corrupts urls with excalamation marks
             * Fixed: error on cross-project gantt PNG export
             * Fixed: self and alternate links in atom feeds do not respect Atom specs
             * Fixed: accept any svn tunnel scheme in repository URL
             * Fixed: issues/show should accept user's rss key
             * Fixed: consistency of custom fields display on the issue detail view
             * Fixed: wiki comments length validation is missing
             * Fixed: weak autologin token generation algorithm causes duplicate tokens
             == 2009-04-05 v0.8.3
             * Separate project field and subject in cross-project issue view
             * Ability to set language for redmine:load_default_data task using REDMINE_LANG environment variable
             * Rescue Redmine::DefaultData::DataAlreadyLoaded in redmine:load_default_data task
             * CSS classes to highlight own and assigned issues
             * Hide "New file" link on wiki pages from printing
             * Flush buffer when asking for language in redmine:load_default_data task
             * Minimum project identifier length set to 1
             * Include headers so that emails don't trigger vacation auto-responders
             * Fixed: Time entries csv export links for all projects are malformed
             * Fixed: Files without Version aren't visible in the Activity page
             * Fixed: Commit logs are centered in the repo browser
             * Fixed: News summary field content is not searchable
             * Fixed: Journal#save has a wrong signature
             * Fixed: Email footer signature convention
             * Fixed: Timelog report do not show time for non-versioned issues
             == 2009-03-07 v0.8.2
             * Send an email to the user when an administrator activates a registered user
             * Strip keywords from received email body
             * Footer updated to 2009
             * Show RSS-link even when no issues is found
             * One click filter action in activity view
             * Clickable/linkable line #'s while browsing the repo or viewing a file
             * Links to versions on files list
             * Added request and controller objects to the hooks by default
             * Fixed: exporting an issue with attachments to PDF raises an error
             * Fixed: "too few arguments" error may occur on activerecord error translation
             * Fixed: "Default columns Displayed on the Issues list" setting is not easy to read
             * Fixed: visited links to closed tickets are not striked through with IE6
             * Fixed: MailHandler#plain_text_body returns nil if there was nothing to strip
             * Fixed: MailHandler raises an error when processing an email without From header
             == 2009-02-15 v0.8.1
             * Select watchers on new issue form
             * Issue description is no longer a required field
             * Files module: ability to add files without version
             * Jump to the current tab when using the project quick-jump combo
             * Display a warning if some attachments were not saved
             * Import custom fields values from emails on issue creation
             * Show view/annotate/download links on entry and annotate views
             * Admin Info Screen: Display if plugin assets directory is writable
             * Adds a 'Create and continue' button on the new issue form
             * IMAP: add options to move received emails
             * Do not show Category field when categories are not defined
             * Lower the project identifier limit to a minimum of two characters
             * Add "closed" html class to closed entries in issue list
             * Fixed: broken redirect URL on login failure
             * Fixed: Deleted files are shown when using Darcs
             * Fixed: Darcs adapter works on Win32 only
             * Fixed: syntax highlight doesn't appear in new ticket preview
             * Fixed: email notification for changes I make still occurs when running Repository.fetch_changesets
             * Fixed: no error is raised when entering invalid hours on the issue update form
             * Fixed: Details time log report CSV export doesn't honour date format from settings
             * Fixed: invalid css classes on issue details
             * Fixed: Trac importer creates duplicate custom values
             * Fixed: inline attached image should not match partial filename
             == 2008-12-30 v0.8.0
             * Setting added in order to limit the number of diff lines that should be displayed
             * Makes logged-in username in topbar linking to
             * Mail handler: strip tags when receiving a html-only email
             * Mail handler: add watchers before sending notification
             * Adds a css class (overdue) to overdue issues on issue lists and detail views
             * Fixed: project activity truncated after viewing user's activity
             * Fixed: email address entered for password recovery shouldn't be case-sensitive
             * Fixed: default flag removed when editing a default enumeration
             * Fixed: default category ignored when adding a document
             * Fixed: error on repository user mapping when a repository username is blank
             * Fixed: Firefox cuts off large diffs
             * Fixed: CVS browser should not show dead revisions (deleted files)
             * Fixed: escape double-quotes in image titles
             * Fixed: escape textarea content when editing a issue note
             * Fixed: JS error on context menu with IE
             * Fixed: bold syntax around single character in series doesn't work
             * Fixed several XSS vulnerabilities
             * Fixed a SQL injection vulnerability
             == 2008-12-07 v0.8.0-rc1
             * Wiki page protection
             * Wiki page hierarchy. Parent page can be assigned on the Rename screen
             * Adds support for issue creation via email
             * Adds support for free ticket filtering and custom queries on Gantt chart and calendar
             * Cross-project search
             * Ability to search a project and its subprojects
             * Ability to search the projects the user belongs to
             * Adds custom fields on time entries
             * Adds boolean and list custom fields for time entries as criteria on time report
             * Cross-project time reports
             * Display latest user's activity on account/show view
             * Show last connexion time on user's page
             * Obfuscates email address on user's account page using javascript
             * wiki TOC rendered as an unordered list
             * Adds the ability to search for a user on the administration users list
             * Adds the ability to search for a project name or identifier on the administration projects list
             * Redirect user to the previous page after logging in
             * Adds a permission 'view wiki edits' so that wiki history can be hidden to certain users
             * Adds permissions for viewing the watcher list and adding new watchers on the issue detail view
             * Adds permissions to let users edit and/or delete their messages
             * Link to activity view when displaying dates
             * Hide Redmine version in atom feeds and pdf properties
             * Maps repository users to Redmine users. Users with same username or email are automatically mapped. Mapping can be manually adjusted in repository settings. Multiple usernames can be mapped to the same Redmine user.
             * Sort users by their display names so that user dropdown lists are sorted alphabetically
             * Adds estimated hours to issue filters
             * Switch order of current and previous revisions in side-by-side diff
             * Render the commit changes list as a tree
             * Adds watch/unwatch functionality at forum topic level
             * When moving an issue to another project, reassign it to the category with same name if any
             * Adds child_pages macro for wiki pages
             * Use GET instead of POST on roadmap (#718), gantt and calendar forms
             * Search engine: display total results count and count by result type
             * Email delivery configuration moved to an unversioned YAML file (config/email.yml, see the sample file)
             * Adds icons on search results
             * Adds 'Edit' link on account/show for admin users
             * Adds Lock/Unlock/Activate link on user edit screen
             * Adds user count in status drop down on admin user list
             * Adds multi-levels blockquotes support by using > at the beginning of lines
             * Adds a Reply link to each issue note
             * Adds plain text only option for mail notifications
             * Gravatar support for issue detail, user grid, and activity stream (disabled by default)
             * Adds 'Delete wiki pages attachments' permission
             * Show the most recent file when displaying an inline image
             * Makes permission screens localized
             * AuthSource list: display associated users count and disable 'Delete' buton if any
             * Make the 'duplicates of' relation asymmetric
             * Adds username to the password reminder email
             * Adds links to forum messages using message#id syntax
             * Allow same name for custom fields on different object types
             * One-click bulk edition using the issue list context menu within the same project
             * Adds support for commit logs reencoding to UTF-8 before insertion in the database. Source encoding of commit logs can be selected in Application settings -> Repositories.
             * Adds checkboxes toggle links on permissions report
             * Adds Trac-Like anchors on wiki headings
             * Adds support for wiki links with anchor
             * Adds category to the issue context menu
             * Adds a workflow overview screen
             * Appends the filename to the attachment url so that clients that ignore content-disposition http header get the real filename
             * Dots allowed in custom field name
             * Adds posts quoting functionality
             * Adds an option to generate sequential project identifiers
             * Adds mailto link on the user administration list
             * Ability to remove enumerations (activities, priorities, document categories) that are in use. Associated objects can be reassigned to another value
             * Gantt chart: display issues that don't have a due date if they are assigned to a version with a date
             * Change projects homepage limit to 255 chars
             * Improved on-the-fly account creation. If some attributes are missing (eg. not present in the LDAP) or are invalid, the registration form is displayed so that the user is able to fill or fix these attributes
             * Adds "please select" to activity select box if no activity is set as default
             * Do not silently ignore timelog validation failure on issue edit
             * Adds a rake task to send reminder emails
             * Allow empty cells in wiki tables
             * Makes wiki text formatter pluggable
             * Adds back textile acronyms support
             * Remove pre tag attributes
             * Plugin hooks
             * Pluggable admin menu
             * Plugins can provide activity content
             * Moves plugin list to its own administration menu item
             * Adds url and author_url plugin attributes
             * Adds Plugin#requires_redmine method so that plugin compatibility can be checked against current Redmine version
             * Adds atom feed on time entries details
             * Adds project name to issues feed title
             * Adds a css class on menu items in order to apply item specific styles (eg. icons)
             * Adds a Redmine plugin generators
             * Adds timelog link to the issue context menu
             * Adds links to the user page on various views
             * Turkish translation by Ismail Sezen
             * Catalan translation
             * Vietnamese translation
             * Slovak translation
             * Better naming of activity feed if only one kind of event is displayed
             * Enable syntax highlight on issues, messages and news
             * Add target version to the issue list context menu
             * Hide 'Target version' filter if no version is defined
             * Add filters on cross-project issue list for custom fields marked as 'For all projects'
             * Turn ftp urls into links
             * Hiding the View Differences button when a wiki page's history only has one version
             * Messages on a Board can now be sorted by the number of replies
             * Adds a class ('me') to events of the activity view created by current user
             * Strip pre/code tags content from activity view events
             * Display issue notes in the activity view
             * Adds links to changesets atom feed on repository browser
             * Track project and tracker changes in issue history
             * Adds anchor to atom feed messages links
             * Adds a key in lang files to set the decimal separator (point or comma) in csv exports
             * Makes importer work with Trac 0.8.x
             * Upgraded to Prototype 1.6.0.1
             * File viewer for attached text files
             * Menu mapper: add support for :before, :after and :last options to #push method and add #delete method
             * Removed inconsistent revision numbers on diff view
             * CVS: add support for modules names with spaces
             * Log the user in after registration if account activation is not needed
             * Mercurial adapter improvements
             * Trac importer: read session_attribute table to find user's email and real name
             * Ability to disable unused SCM adapters in application settings
             * Adds Filesystem adapter
             * Clear changesets and changes with raw sql when deleting a repository for performance
             * Redmine.pm now uses the 'commit access' permission defined in Redmine
             * Reposman can create any type of scm (--scm option)
             * Reposman creates a repository if the 'repository' module is enabled at project level only
             * Display svn properties in the browser, svn >= 1.5.0 only
             * Reduces memory usage when importing large git repositories
             * Wider SVG graphs in repository stats
             * SubversionAdapter#entries performance improvement
             * SCM browser: ability to download raw unified diffs
             * More detailed error message in log when scm command fails
             * Adds support for file viewing with Darcs 2.0+
             * Check that git changeset is not in the database before creating it
             * Unified diff viewer for attached files with .patch or .diff extension
             * File size display with Bazaar repositories
             * Git adapter: use commit time instead of author time
             * Prettier url for changesets
             * Makes changes link to entries on the revision view
             * Adds a field on the repository view to browse at specific revision
             * Adds new projects atom feed
             * Added rake tasks to generate rcov code coverage reports
             * Add Redcloth's :block_markdown_rule to allow horizontal rules in wiki
             * Show the project hierarchy in the drop down list for new membership on user administration screen
             * Split user edit screen into tabs
             * Renames bundled RedCloth to RedCloth3 to avoid RedCloth 4 to be loaded instead
             * Fixed: Roadmap crashes when a version has a due date > 2037
             * Fixed: invalid effective date (eg. 99999-01-01) causes an error on version edition screen
             * Fixed: login filter providing incorrect back_url for Redmine installed in sub-directory
             * Fixed: logtime entry duplicated when edited from parent project
             * Fixed: wrong digest for text files under Windows
             * Fixed: associated revisions are displayed in wrong order on issue view
             * Fixed: Git Adapter date parsing ignores timezone
             * Fixed: Printing long roadmap doesn't split across pages
             * Fixes custom fields display order at several places
             * Fixed: urls containing @ are parsed as email adress by the wiki formatter
             * Fixed date filters accuracy with SQLite
             * Fixed: tokens not escaped in highlight_tokens regexp
             * Fixed Bazaar shared repository browsing
             * Fixes platform determination under JRuby
             * Fixed: Estimated time in issue's journal should be rounded to two decimals
             * Fixed: 'search titles only' box ignored after one search is done on titles only
             * Fixed: non-ASCII subversion path can't be displayed
             * Fixed: Inline images don't work if file name has upper case letters or if image is in BMP format
             * Fixed: document listing shows on "my page" when viewing documents is disabled for the role
             * Fixed: Latest news appear on the homepage for projects with the News module disabled
             * Fixed: cross-project issue list should not show issues of projects for which the issue tracking module was disabled
             * Fixed: the default status is lost when reordering issue statuses
             * Fixes error with Postgresql and non-UTF8 commit logs
             * Fixed: textile footnotes no longer work
             * Fixed: http links containing parentheses fail to reder correctly
             * Fixed: GitAdapter#get_rev should use current branch instead of hardwiring master
             == 2008-07-06 v0.7.3
             * Allow dot in firstnames and lastnames
             * Add project name to cross-project Atom feeds
             * Encoding set to utf8 in example database.yml
             * HTML titles on forums related views
             * Fixed: various XSS vulnerabilities
             * Fixed: Entourage (and some old client) fails to correctly render notification styles
             * Fixed: Fixed: timelog redirects inappropriately when :back_url is blank
             * Fixed: wrong relative paths to images in wiki_syntax.html
             == 2008-06-15 v0.7.2
             * "New Project" link on Projects page
             * Links to repository directories on the repo browser
             * Move status to front in Activity View
             * Remove edit step from Status context menu
             * Fixed: No way to do textile horizontal rule
             * Fixed: Repository: View differences doesn't work
             * Fixed: attachement's name maybe invalid.
             * Fixed: Error when creating a new issue
             * Fixed: NoMethodError on @available_filters.has_key?
             * Fixed: Check All / Uncheck All in Email Settings
             * Fixed: "View differences" of one file at /repositories/revision/ fails
             * Fixed: Column width in "my page"
             * Fixed: private subprojects are listed on Issues view
             * Fixed: Textile: bold, italics, underline, etc... not working after parentheses
             * Fixed: Update issue form: comment field from log time end out of screen
             * Fixed: Editing role: "issue can be assigned to this role" out of box
             * Fixed: Unable use angular braces after include word
             * Fixed: Using '*' as keyword for repository referencing keywords doesn't work
             * Fixed: Subversion repository "View differences" on each file rise ERROR
             * Fixed: View differences for individual file of a changeset fails if the repository URL doesn't point to the repository root
             * Fixed: It is possible to lock out the last admin account
             * Fixed: Wikis are viewable for anonymous users on public projects, despite not granting access
             * Fixed: Issue number display clipped on 'my issues'
             * Fixed: Roadmap version list links not carrying state
             * Fixed: Log Time fieldset in IssueController#edit doesn't set default Activity as default
             * Fixed: git's "get_rev" API should use repo's current branch instead of hardwiring "master"
             * Fixed: browser's language subcodes ignored
             * Fixed: Error on project selection with numeric (only) identifier.
             * Fixed: Link to PDF doesn't work after creating new issue
             * Fixed: "Replies" should not be shown on forum threads that are locked
             * Fixed: SVN errors lead to svn username/password being displayed to end users (security issue)
             * Fixed: http links containing hashes don't display correct
             * Fixed: Allow ampersands in Enumeration names
             * Fixed: Atom link on saved query does not include query_id
             * Fixed: Logtime info lost when there's an error updating an issue
             * Fixed: TOC does not parse colorization markups
             * Fixed: CVS: add support for modules names with spaces
             * Fixed: Bad rendering on projects/add
             * Fixed: exception when viewing differences on cvs
             * Fixed: export issue to pdf will messup when use Chinese language
             * Fixed: Redmine::Scm::Adapters::GitAdapter#get_rev ignored GIT_BIN constant
             * Fixed: Adding non-ASCII new issue type in the New Issue page have encoding error using IE
             * Fixed: Importing from trac : some wiki links are messed
             * Fixed: Incorrect weekend definition in Hebrew calendar locale
             * Fixed: Atom feeds don't provide author section for repository revisions
             * Fixed: In Activity views, changesets titles can be multiline while they should not
             * Fixed: Ignore unreadable subversion directories (read disabled using authz)
             * Fixed: lib/SVG/Graph/Graph.rb can't externalize stylesheets
             * Fixed: Close statement handler in Redmine.pm
             == 2008-05-04 v0.7.1
             * Thai translation added (Gampol Thitinilnithi)
             * Translations updates
             * Escape HTML comment tags
             * Prevent "can't convert nil into String" error when :sort_order param is not present
             * Fixed: Updating tickets add a time log with zero hours
             * Fixed: private subprojects names are revealed on the project overview
             * Fixed: Search for target version of "none" fails with postgres 8.3
             * Fixed: Home, Logout, Login links shouldn't be absolute links
             * Fixed: 'Latest projects' box on the welcome screen should be hidden if there are no projects
             * Fixed: error when using upcase language name in coderay
             * Fixed: error on Trac import when :due attribute is nil
             == 2008-04-28 v0.7.0
             * Forces Redmine to use rails 2.0.2 gem when vendor/rails is not present
             * Queries can be marked as 'For all projects'. Such queries will be available on all projects and on the global issue list.
             * Add predefined date ranges to the time report
             * Time report can be done at issue level
             * Various timelog report enhancements
             * Accept the following formats for "hours" field: 1h, 1 h, 1 hour, 2 hours, 30m, 30min, 1h30, 1h30m, 1:30
             * Display the context menu above and/or to the left of the click if needed
             * Make the admin project files list sortable
             * Mercurial: display working directory files sizes unless browsing a specific revision
             * Preserve status filter and page number when using lock/unlock/activate links on the users list
             * Redmine.pm support for LDAP authentication
             * Better error message and AR errors in log for failed LDAP on-the-fly user creation
             * Redirected user to where he is coming from after logging hours
             * Warn user that subprojects are also deleted when deleting a project
             * Include subprojects versions on calendar and gantt
             * Notify project members when a message is posted if they want to receive notifications
             * Fixed: Feed content limit setting has no effect
             * Fixed: Priorities not ordered when displayed as a filter in issue list
             * Fixed: can not display attached images inline in message replies
             * Fixed: Boards are not deleted when project is deleted
             * Fixed: trying to preview a new issue raises an exception with postgresql
             * Fixed: single file 'View difference' links do not work because of duplicate slashes in url
             * Fixed: inline image not displayed when including a wiki page
             * Fixed: CVS duplicate key violation
             * Fixed: ActiveRecord::StaleObjectError exception on closing a set of circular duplicate issues
             * Fixed: custom field filters behaviour
             * Fixed: Postgresql 8.3 compatibility
             * Fixed: Links to repository directories don't work
             == 2008-03-29 v0.7.0-rc1
             * Overall activity view and feed added, link is available on the project list
             * Git VCS support
             * Rails 2.0 sessions cookie store compatibility
             * Use project identifiers in urls instead of ids
             * Default configuration data can now be loaded from the administration screen
             * Administration settings screen split to tabs (email notifications options moved to 'Settings')
             * Project description is now unlimited and optional
             * Wiki annotate view
             * Escape HTML tag in textile content
             * Add Redmine links to documents, versions, attachments and repository files
             * New setting to specify how many objects should be displayed on paginated lists. There are 2 ways to select a set of issues on the issue list:
                 * by using checkbox and/or the little pencil that will select/unselect all issues
                 * by clicking on the rows (but not on the links), Ctrl and Shift keys can be used to select multiple issues
             * Context menu disabled on links so that the default context menu of the browser is displayed when right-clicking on a link (click anywhere else on the row to display the context menu)
             * User display format is now configurable in administration settings
             * Issue list now supports bulk edit/move/delete (for a set of issues that belong to the same project)
             * Merged 'change status', 'edit issue' and 'add note' actions:
                 * Users with 'edit issues' permission can now update any property including custom fields when adding a note or changing the status
                 * 'Change issue status' permission removed. To change an issue status, a user just needs to have either 'Edit' or 'Add note' permissions and some workflow transitions allowed
             * Details by assignees on issue summary view
             * 'New issue' link in the main menu (accesskey 7). The drop-down lists to add an issue on the project overview and the issue list are removed
             * Change status select box default to current status
             * Preview for issue notes, news and messages
             * Optional description for attachments
             * 'Fixed version' label changed to 'Target version'
             * Let the user choose when deleting issues with reported hours to:
                 * delete the hours
                 * assign the hours to the project
                 * reassign the hours to another issue
             * Date range filter and pagination on time entries detail view
             * Propagate time tracking to the parent project
             * Switch added on the project activity view to include subprojects
             * Display total estimated and spent hours on the version detail view
             * Weekly time tracking block for 'My page'
             * Permissions to edit time entries
             * Include subprojects on the issue list, calendar, gantt and timelog by default (can be turned off is administration settings)
             * Roadmap enhancements (separate related issues from wiki contents, leading h1 in version wiki pages is hidden, smaller wiki headings)
             * Make versions with same date sorted by name
             * Allow issue list to be sorted by target version
             * Related changesets messages displayed on the issue details view
             * Create a journal and send an email when an issue is closed by commit
             * Add 'Author' to the available columns for the issue list
             * More appropriate default sort order on sortable columns
             * Add issue subject to the time entries view and issue subject, description and tracker to the csv export
             * Permissions to edit issue notes
             * Display date/time instead of date on files list
             * Do not show Roadmap menu item if the project doesn't define any versions
             * Allow longer version names (60 chars)
             * Ability to copy an existing workflow when creating a new role
             * Display custom fields in two columns on the issue form
             * Added 'estimated time' in the csv export of the issue list
             * Display the last 30 days on the activity view rather than the current month (number of days can be configured in the application settings)
             * Setting for whether new projects should be public by default
             * User preference to choose how comments/replies are displayed: in chronological or reverse chronological order
             * Added default value for custom fields
             * Added tabindex property on wiki toolbar buttons (to easily move from field to field using the tab key)
             * Redirect to issue page after creating a new issue
             * Wiki toolbar improvements (mainly for Firefox)
             * Display wiki syntax quick ref link on all wiki textareas
             * Display links to Atom feeds
             * Breadcrumb nav for the forums
             * Show replies when choosing to display messages in the activity
             * Added 'include' macro to include another wiki page
             * RedmineWikiFormatting page available as a static HTML file locally
             * Wrap diff content
             * Strip out email address from authors in repository screens
             * Highlight the current item of the main menu
             * Added simple syntax highlighters for php and java languages
             * Do not show empty diffs
             * Show explicit error message when the scm command failed (eg. when svn binary is not available)
             * Lithuanian translation added (Sergej Jegorov)
             * Ukrainan translation added (Natalia Konovka & Mykhaylo Sorochan)
             * Danish translation added (Mads Vestergaard)
             * Added i18n support to the jstoolbar and various settings screen
             * RedCloth's glyphs no longer user
             * New icons for the wiki toolbar (from http://www.famfamfam.com/lab/icons/silk/)
             * The following menus can now be extended by plugins: top_menu, account_menu, application_menu
             * Added a simple rake task to fetch changesets from the repositories: rake redmine:fetch_changesets
             * Remove hardcoded "Redmine" strings in account related emails and use application title instead
             * Mantis importer preserve bug ids
             * Trac importer: Trac guide wiki pages skipped
             * Trac importer: wiki attachments migration added
             * Trac importer: support database schema for Trac migration
             * Trac importer: support CamelCase links
             * Removes the Redmine version from the footer (can be viewed on admin -> info)
             * Rescue and display an error message when trying to delete a role that is in use
             * Add various 'X-Redmine' headers to email notifications: X-Redmine-Host, X-Redmine-Site, X-Redmine-Project, X-Redmine-Issue-Id, -Author, -Assignee, X-Redmine-Topic-Id
             * Add "--encoding utf8" option to the Mercurial "hg log" command in order to get utf8 encoded commit logs
             * Fixed: Gantt and calendar not properly refreshed (fragment caching removed)
             * Fixed: Textile image with style attribute cause internal server error
             * Fixed: wiki TOC not rendered properly when used in an issue or document description
             * Fixed: 'has already been taken' error message on username and email fields if left empty
             * Fixed: non-ascii attachement filename with IE
             * Fixed: wrong url for wiki syntax pop-up when Redmine urls are prefixed
             * Fixed: search for all words doesn't work
             * Fixed: Do not show sticky and locked checkboxes when replying to a message
             * Fixed: Mantis importer: do not duplicate Mantis username in firstname and lastname if realname is blank
             * Fixed: Date custom fields not displayed as specified in application settings
             * Fixed: titles not escaped in the activity view
             * Fixed: issue queries can not use custom fields marked as 'for all projects' in a project context
             * Fixed: on calendar, gantt and in the tracker filter on the issue list, only active trackers of the project (and its sub projects) should be available
             * Fixed: locked users should not receive email notifications
             * Fixed: custom field selection is not saved when unchecking them all on project settings
             * Fixed: can not lock a topic when creating it
             * Fixed: Incorrect filtering for unset values when using 'is not' filter
             * Fixed: PostgreSQL issues_seq_id not updated when using Trac importer
             * Fixed: ajax pagination does not scroll up
             * Fixed: error when uploading a file with no content-type specified by the browser
             * Fixed: wiki and changeset links not displayed when previewing issue description or notes
             * Fixed: 'LdapError: no bind result' error when authenticating
             * Fixed: 'LdapError: invalid binding information' when no username/password are set on the LDAP account
             * Fixed: CVS repository doesn't work if port is used in the url
             * Fixed: Email notifications: host name is missing in generated links
             * Fixed: Email notifications: referenced changesets, wiki pages, attachments... are not turned into links
             * Fixed: Do not clear issue relations when moving an issue to another project if cross-project issue relations are allowed
             * Fixed: "undefined method 'textilizable'" error on email notification when running Repository#fetch_changesets from the console
             * Fixed: Do not send an email with no recipient, cc or bcc
             * Fixed: fetch_changesets fails on commit comments that close 2 duplicates issues.
             * Fixed: Mercurial browsing under unix-like os and for directory depth > 2
             * Fixed: Wiki links with pipe can not be used in wiki tables
             * Fixed: migrate_from_trac doesn't import timestamps of wiki and tickets
             * Fixed: when bulk editing, setting "Assigned to" to "nobody" causes an sql error with Postgresql
             == 2008-03-12 v0.6.4
             * Fixed: private projects name are displayed on account/show even if the current user doesn't have access to these private projects
             * Fixed: potential LDAP authentication security flaw
             * Fixed: context submenus on the issue list don't show up with IE6.
             * Fixed: Themes are not applied with Rails 2.0
             * Fixed: crash when fetching Mercurial changesets if changeset[:files] is nil
             * Fixed: Mercurial repository browsing
             * Fixed: undefined local variable or method 'log' in CvsAdapter when a cvs command fails
             * Fixed: not null constraints not removed with Postgresql
             * Doctype set to transitional
             == 2007-12-18 v0.6.3
             * Fixed: upload doesn't work in 'Files' section
             == 2007-12-16 v0.6.2
             * Search engine: issue custom fields can now be searched
             * News comments are now textilized
             * Updated Japanese translation (Satoru Kurashiki)
             * Updated Chinese translation (Shortie Lo)
             * Fixed Rails 2.0 compatibility bugs:
               * Unable to create a wiki
               * Gantt and calendar error
               * Trac importer error (readonly? is defined by ActiveRecord)
             * Fixed: 'assigned to me' filter broken
             * Fixed: crash when validation fails on issue edition with no custom fields
             * Fixed: reposman "can't find group" error
             * Fixed: 'LDAP account password is too long' error when leaving the field empty on creation
             * Fixed: empty lines when displaying repository files with Windows style eol
             * Fixed: missing body closing tag in repository annotate and entry views
             == 2007-12-10 v0.6.1
             * Rails 2.0 compatibility
             * Custom fields can now be displayed as columns on the issue list
             * Added version details view (accessible from the roadmap)
             * Roadmap: more accurate completion percentage calculation (done ratio of open issues is now taken into account)
             * Added per-project tracker selection. Trackers can be selected on project settings
             * Anonymous users can now be allowed to create, edit, comment issues, comment news and post messages in the forums
             * Forums: messages can now be edited/deleted (explicit permissions need to be given)
             * Forums: topics can be locked so that no reply can be added
             * Forums: topics can be marked as sticky so that they always appear at the top of the list
             * Forums: attachments can now be added to replies
             * Added time zone support
             * Added a setting to choose the account activation strategy (available in application settings)
             * Added 'Classic' theme (inspired from the v0.51 design)
             * Added an alternate theme which provides issue list colorization based on issues priority
             * Added Bazaar SCM adapter
             * Added Annotate/Blame view in the repository browser (except for Darcs SCM)
             * Diff style (inline or side by side) automatically saved as a user preference
             * Added issues status changes on the activity view (by Cyril Mougel)
             * Added forums topics on the activity view (disabled by default)
             * Added an option on 'My account' for users who don't want to be notified of changes that they make
             * Trac importer now supports mysql and postgresql databases
             * Trac importer improvements (by Mat Trudel)
             * 'fixed version' field can now be displayed on the issue list
             * Added a couple of new formats for the 'date format' setting
             * Added Traditional Chinese translation (by Shortie Lo)
             * Added Russian translation (iGor kMeta)
             * Project name format limitation removed (name can now contain any character)
             * Project identifier maximum length changed from 12 to 20
             * Changed the maximum length of LDAP account to 255 characters
             * Removed the 12 characters limit on passwords
             * Added wiki macros support
             * Performance improvement on workflow setup screen
             * More detailed html title on several views
             * Custom fields can now be reordered
             * Search engine: search can be restricted to an exact phrase by using quotation marks
             * Added custom fields marked as 'For all projects' to the csv export of the cross project issue list
             * Email notifications are now sent as Blind carbon copy by default
             * Fixed: all members (including non active) should be deleted when deleting a project
             * Fixed: Error on wiki syntax link (accessible from wiki/edit)
             * Fixed: 'quick jump to a revision' form on the revisions list
             * Fixed: error on admin/info if there's more than 1 plugin installed
             * Fixed: svn or ldap password can be found in clear text in the html source in editing mode
             * Fixed: 'Assigned to' drop down list is not sorted
             * Fixed: 'View all issues' link doesn't work on issues/show
             * Fixed: error on account/register when validation fails
             * Fixed: Error when displaying the issue list if a float custom field is marked as 'used as filter'
             * Fixed: Mercurial adapter breaks on missing :files entry in changeset hash (James Britt)
             * Fixed: Wrong feed URLs on the home page
             * Fixed: Update of time entry fails when the issue has been moved to an other project
             * Fixed: Error when moving an issue without changing its tracker (Postgresql)
             * Fixed: Changes not recorded when using :pserver string (CVS adapter)
             * Fixed: admin should be able to move issues to any project
             * Fixed: adding an attachment is not possible when changing the status of an issue
             * Fixed: No mime-types in documents/files downloading
             * Fixed: error when sorting the messages if there's only one board for the project
             * Fixed: 'me' doesn't appear in the drop down filters on a project issue list.
             == 2007-11-04 v0.6.0
             * Permission model refactoring.
             * Permissions: there are now 2 builtin roles that can be used to specify permissions given to other users than members of projects
             * Permissions: some permissions (eg. browse the repository) can be removed for certain roles
             * Permissions: modules (eg. issue tracking, news, documents...) can be enabled/disabled at project level
             * Added Mantis and Trac importers
             * New application layout
             * Added "Bulk edit" functionality on the issue list
             * More flexible mail notifications settings at user level
             * Added AJAX based context menu on the project issue list that provide shortcuts for editing, re-assigning, changing the status or the priority, moving or deleting an issue
             * Added the hability to copy an issue. It can be done from the "issue/show" view or from the context menu on the issue list
             * Added the ability to customize issue list columns (at application level or for each saved query)
             * Overdue versions (date reached and open issues > 0) are now always displayed on the roadmap
             * Added the ability to rename wiki pages (specific permission required)
             * Search engines now supports pagination. Results are sorted in reverse chronological order
             * Added "Estimated hours" attribute on issues
             * A category with assigned issue can now be deleted. 2 options are proposed: remove assignments or reassign issues to another category
             * Forum notifications are now also sent to the authors of the thread, even if they don�t watch the board
             * Added an application setting to specify the application protocol (http or https) used to generate urls in emails
             * Gantt chart: now starts at the current month by default
             * Gantt chart: month count and zoom factor are automatically saved as user preferences
             * Wiki links can now refer to other project wikis
             * Added wiki index by date
             * Added preview on add/edit issue form
             * Emails footer can now be customized from the admin interface (Admin -> Email notifications)
             * Default encodings for repository files can now be set in application settings (used to convert files content and diff to UTF-8 so that they�re properly displayed)
             * Calendar: first day of week can now be set in lang files
             * Automatic closing of duplicate issues
             * Added a cross-project issue list
             * AJAXified the SCM browser (tree view)
             * Pretty URL for the repository browser (Cyril Mougel)
             * Search engine: added a checkbox to search titles only
             * Added "% done" in the filter list
             * Enumerations: values can now be reordered and a default value can be specified (eg. default issue priority)
             * Added some accesskeys
             * Added "Float" as a custom field format
             * Added basic Theme support
             * Added the ability to set the �done ratio� of issues fixed by commit (Nikolay Solakov)
             * Added custom fields in issue related mail notifications
             * Email notifications are now sent in plain text and html
             * Gantt chart can now be exported to a graphic file (png). This functionality is only available if RMagick is installed.
             * Added syntax highlightment for repository files and wiki
             * Improved automatic Redmine links
             * Added automatic table of content support on wiki pages
             * Added radio buttons on the documents list to sort documents by category, date, title or author
             * Added basic plugin support, with a sample plugin
             * Added a link to add a new category when creating or editing an issue
             * Added a "Assignable" boolean on the Role model. If unchecked, issues can not be assigned to users having this role.
             * Added an option to be able to relate issues in different projects
             * Added the ability to move issues (to another project) without changing their trackers.
             * Atom feeds added on project activity, news and changesets
             * Added the ability to reset its own RSS access key
             * Main project list now displays root projects with their subprojects
             * Added anchor links to issue notes
             * Added reposman Ruby version. This script can now register created repositories in Redmine (Nicolas Chuche)
             * Issue notes are now included in search
             * Added email sending test functionality
             * Added LDAPS support for LDAP authentication
             * Removed hard-coded URLs in mail templates
             * Subprojects are now grouped by projects in the navigation drop-down menu
             * Added a new value for date filters: this week
             * Added cache for application settings
             * Added Polish translation (Tomasz Gawryl)
             * Added Czech translation (Jan Kadlecek)
             * Added Romanian translation (Csongor Bartus)
             * Added Hebrew translation (Bob Builder)
             * Added Serbian translation (Dragan Matic)
             * Added Korean translation (Choi Jong Yoon)
             * Fixed: the link to delete issue relations is displayed even if the user is not authorized to delete relations
             * Performance improvement on calendar and gantt
             * Fixed: wiki preview doesn�t work on long entries
             * Fixed: queries with multiple custom fields return no result
             * Fixed: Can not authenticate user against LDAP if its DN contains non-ascii characters
             * Fixed: URL with ~ broken in wiki formatting
             * Fixed: some quotation marks are rendered as strange characters in pdf
             == 2007-07-15 v0.5.1
             * per project forums added
             * added the ability to archive projects
             * added �Watch� functionality on issues. It allows users to receive notifications about issue changes
             * custom fields for issues can now be used as filters on issue list
             * added per user custom queries
             * commit messages are now scanned for referenced or fixed issue IDs (keywords defined in Admin -> Settings)
             * projects list now shows the list of public projects and private projects for which the user is a member
             * versions can now be created with no date
             * added issue count details for versions on Reports view
             * added time report, by member/activity/tracker/version and year/month/week for the selected period
             * each category can now be associated to a user, so that new issues in that category are automatically assigned to that user
             * added autologin feature (disabled by default)
             * optimistic locking added for wiki edits
             * added wiki diff
             * added the ability to destroy wiki pages (requires permission)
             * a wiki page can now be attached to each version, and displayed on the roadmap
             * attachments can now be added to wiki pages (original patch by Pavol Murin) and displayed online
             * added an option to see all versions in the roadmap view (including completed ones)
             * added basic issue relations
             * added the ability to log time when changing an issue status
             * account information can now be sent to the user when creating an account
             * author and assignee of an issue always receive notifications (even if they turned of mail notifications)
             * added a quick search form in page header
             * added 'me' value for 'assigned to' and 'author' query filters
             * added a link on revision screen to see the entire diff for the revision
             * added last commit message for each entry in repository browser
             * added the ability to view a file diff with free to/from revision selection.
             * text files can now be viewed online when browsing the repository
             * added basic support for other SCM: CVS (Ralph Vater), Mercurial and Darcs
             * added fragment caching for svn diffs
             * added fragment caching for calendar and gantt views
             * login field automatically focused on login form
             * subproject name displayed on issue list, calendar and gantt
             * added an option to choose the date format: language based or ISO 8601
             * added a simple mail handler. It lets users add notes to an existing issue by replying to the initial notification email.
             * a 403 error page is now displayed (instead of a blank page) when trying to access a protected page
             * added portuguese translation (Joao Carlos Clementoni)
             * added partial online help japanese translation (Ken Date)
             * added bulgarian translation (Nikolay Solakov)
             * added dutch translation (Linda van den Brink)
             * added swedish translation (Thomas Habets)
             * italian translation update (Alessio Spadaro)
             * japanese translation update (Satoru Kurashiki)
             * fixed: error on history atom feed when there�s no notes on an issue change
             * fixed: error in journalizing an issue with longtext custom fields (Postgresql)
             * fixed: creation of Oracle schema
             * fixed: last day of the month not included in project activity
             * fixed: files with an apostrophe in their names can't be accessed in SVN repository
             * fixed: performance issue on RepositoriesController#revisions when a changeset has a great number of changes (eg. 100,000)
             * fixed: open/closed issue counts are always 0 on reports view (postgresql)
             * fixed: date query filters (wrong results and sql error with postgresql)
             * fixed: confidentiality issue on account/show (private project names displayed to anyone)
             * fixed: Long text custom fields displayed without line breaks
             * fixed: Error when editing the wokflow after deleting a status
             * fixed: SVN commit dates are now stored as local time
             == 2007-04-11 v0.5.0
             * added per project Wiki
             * added rss/atom feeds at project level (custom queries can be used as feeds)
             * added search engine (search in issues, news, commits, wiki pages, documents)
             * simple time tracking functionality added
             * added version due dates on calendar and gantt
             * added subprojects issue count on project Reports page
             * added the ability to copy an existing workflow when creating a new tracker
             * added the ability to include subprojects on calendar and gantt
             * added the ability to select trackers to display on calendar and gantt (Jeffrey Jones)
             * added side by side svn diff view (Cyril Mougel)
             * added back subproject filter on issue list
             * added permissions report in admin area
             * added a status filter on users list
             * support for password-protected SVN repositories
             * SVN commits are now stored in the database
             * added simple svn statistics SVG graphs
             * progress bars for roadmap versions (Nick Read)
             * issue history now shows file uploads and deletions
             * #id patterns are turned into links to issues in descriptions and commit messages
             * japanese translation added (Satoru Kurashiki)
             * chinese simplified translation added (Andy Wu)
             * italian translation added (Alessio Spadaro)
             * added scripts to manage SVN repositories creation and user access control using ssh+svn (Nicolas Chuche)
             * better calendar rendering time
             * fixed migration scripts to work with mysql 5 running in strict mode
             * fixed: error when clicking "add" with no block selected on my/page_layout
             * fixed: hard coded links in navigation bar
             * fixed: table_name pre/suffix support
             == 2007-02-18 v0.4.2
             * Rails 1.2 is now required
             * settings are now stored in the database and editable through the application in: Admin -> Settings (config_custom.rb is no longer used)
             * added project roadmap view
             * mail notifications added when a document, a file or an attachment is added
             * tooltips added on Gantt chart and calender to view the details of the issues
             * ability to set the sort order for roles, trackers, issue statuses
             * added missing fields to csv export: priority, start date, due date, done ratio
             * added total number of issues per tracker on project overview
             * all icons replaced (new icons are based on GPL icon set: "KDE Crystal Diamond 2.5" -by paolino- and "kNeu! Alpha v0.1" -by Pablo Fabregat-)
             * added back "fixed version" field on issue screen and in filters
             * project settings screen split in 4 tabs
             * custom fields screen split in 3 tabs (one for each kind of custom field)
             * multiple issues pdf export now rendered as a table
             * added a button on users/list to manually activate an account
             * added a setting option to disable "password lost" functionality
             * added a setting option to set max number of issues in csv/pdf exports
             * fixed: subprojects count is always 0 on projects list
             * fixed: locked users are proposed when adding a member to a project
             * fixed: setting an issue status as default status leads to an sql error with SQLite
             * fixed: unable to delete an issue status even if it's not used yet
             * fixed: filters ignored when exporting a predefined query to csv/pdf
             * fixed: crash when french "issue_edit" email notification is sent
             * fixed: hide mail preference not saved (my/account)
             * fixed: crash when a new user try to edit its "my page" layout
             == 2007-01-03 v0.4.1
             * fixed: emails have no recipient when one of the project members has notifications disabled
             == 2007-01-02 v0.4.0
             * simple SVN browser added (just needs svn binaries in PATH)
             * comments can now be added on news
             * "my page" is now customizable
             * more powerfull and savable filters for issues lists
             * improved issues change history
             * new functionality: move an issue to another project or tracker
             * new functionality: add a note to an issue
             * new report: project activity
             * "start date" and "% done" fields added on issues
             * project calendar added
             * gantt chart added (exportable to pdf)
             * single/multiple issues pdf export added
             * issues reports improvements
             * multiple file upload for issues, documents and files
             * option to set maximum size of uploaded files
             * textile formating of issue and news descritions (RedCloth required)
             * integration of DotClear jstoolbar for textile formatting
             * calendar date picker for date fields (LGPL DHTML Calendar http://sourceforge.net/projects/jscalendar)
             * new filter in issues list: Author
             * ajaxified paginators
             * news rss feed added
             * option to set number of results per page on issues list
             * localized csv separator (comma/semicolon)
             * csv output encoded to ISO-8859-1
             * user custom field displayed on account/show
             * default configuration improved (default roles, trackers, status, permissions and workflows)
             * language for default configuration data can now be chosen when running 'load_default_data' task
             * javascript added on custom field form to show/hide fields according to the format of custom field
             * fixed: custom fields not in csv exports
             * fixed: project settings now displayed according to user's permissions
             * fixed: application error when no version is selected on projects/add_file
             * fixed: public actions not authorized for members of non public projects
             * fixed: non public projects were shown on welcome screen even if current user is not a member
             == 2006-10-08 v0.3.0
             * user authentication against multiple LDAP (optional)
             * token based "lost password" functionality
             * user self-registration functionality (optional)
             * custom fields now available for issues, users and projects
             * new custom field format "text" (displayed as a textarea field)
             * project & administration drop down menus in navigation bar for quicker access
             * text formatting is preserved for long text fields (issues, projects and news descriptions)
             * urls and emails are turned into clickable links in long text fields
             * "due date" field added on issues
             * tracker selection filter added on change log
             * Localization plugin replaced with GLoc 1.1.0 (iconv required)
             * error messages internationalization
             * german translation added (thanks to Karim Trott)
             * data locking for issues to prevent update conflicts (using ActiveRecord builtin optimistic locking)
             * new filter in issues list: "Fixed version"
             * active filters are displayed with colored background on issues list
             * custom configuration is now defined in config/config_custom.rb
             * user object no more stored in session (only user_id)
             * news summary field is no longer required
             * tables and forms redesign
             * Fixed: boolean custom field not working
             * Fixed: error messages for custom fields are not displayed
             * Fixed: invalid custom fields should have a red border
             * Fixed: custom fields values are not validated on issue update
             * Fixed: unable to choose an empty value for 'List' custom fields
             * Fixed: no issue categories sorting
             * Fixed: incorrect versions sorting
             == 2006-07-12 - v0.2.2
             * Fixed: bug in "issues list"
             == 2006-07-09 - v0.2.1
             * new databases supported: Oracle, PostgreSQL, SQL Server
             * projects/subprojects hierarchy (1 level of subprojects only)
             * environment information display in admin/info
             * more filter options in issues list (rev6)
             * default language based on browser settings (Accept-Language HTTP header)
             * issues list exportable to CSV (rev6)
             * simple_format and auto_link on long text fields
             * more data validations
             * Fixed: error when all mail notifications are unchecked in admin/mail_options
             * Fixed: all project news are displayed on project summary
             * Fixed: Can't change user password in users/edit
             * Fixed: Error on tables creation with PostgreSQL (rev5)
             * Fixed: SQL error in "issue reports" view with PostgreSQL (rev5)
             == 2006-06-25 - v0.1.0
             * multiple users/multiple projects
             * role based access control
             * issue tracking system
             * fully customizable workflow
             * documents/files repository
             * email notifications on issue creation and update
             * multilanguage support (except for error messages):english, french, spanish
             * online manual in french (unfinished)

test/functional/news_controller_test.rb +9 0

             # redMine - project management software
             # Copyright (C) 2006-2007  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.dirname(__FILE__) + '/../test_helper'
             require 'news_controller'
             # Re-raise errors caught by the controller.
             class NewsController; def rescue_action(e) raise e end; end
             class NewsControllerTest < Test::Unit::TestCase
               fixtures :projects, :users, :roles, :members, :enabled_modules, :news, :comments
               def setup
                 @controller = NewsController.new
                 @request    = ActionController::TestRequest.new
                 @response   = ActionController::TestResponse.new
                 User.current = nil
               end
               def test_index
                 get :index
                 assert_response :success
                 assert_template 'index'
                 assert_not_nil assigns(:newss)
                 assert_nil assigns(:project)
               end
               def test_index_with_project
                 get :index, :project_id => 1
                 assert_response :success
                 assert_template 'index'
                 assert_not_nil assigns(:newss)
               end
               def test_show
                 get :show, :id => 1
                 assert_response :success
                 assert_template 'show'
                 assert_tag :tag => 'h2', :content => /eCookbook first release/
               end
               def test_show_not_found
                 get :show, :id => 999
                 assert_response 404
               end
               def test_get_new
                 @request.session[:user_id] = 2
                 get :new, :project_id => 1
                 assert_response :success
                 assert_template 'new'
               end
               def test_post_new
                 @request.session[:user_id] = 2
                 post :new, :project_id => 1, :news => { :title => 'NewsControllerTest',
                                                         :description => 'This is the description',
                                                         :summary => '' }
                 assert_redirected_to 'projects/ecookbook/news'
                 news = News.find_by_title('NewsControllerTest')
                 assert_not_nil news
                 assert_equal 'This is the description', news.description
                 assert_equal User.find(2), news.author
                 assert_equal Project.find(1), news.project
               end
               def test_get_edit
                 @request.session[:user_id] = 2
                 get :edit, :id => 1
                 assert_response :success
                 assert_template 'edit'
               end
               def test_post_edit
                 @request.session[:user_id] = 2
                 post :edit, :id => 1, :news => { :description => 'Description changed by test_post_edit' }
                 assert_redirected_to 'news/show/1'
                 news = News.find(1)
                 assert_equal 'Description changed by test_post_edit', news.description
               end
               def test_post_new_with_validation_failure
                 @request.session[:user_id] = 2
                 post :new, :project_id => 1, :news => { :title => '',
                                                         :description => 'This is the description',
                                                         :summary => '' }
                 assert_response :success
                 assert_template 'new'
                 assert_not_nil assigns(:news)
                 assert assigns(:news).new_record?
                 assert_tag :tag => 'div', :attributes => { :id => 'errorExplanation' },
                                           :content => /1 error/
               end
               def test_add_comment
                 @request.session[:user_id] = 2
                 post :add_comment, :id => 1, :comment => { :comments => 'This is a NewsControllerTest comment' }
                 assert_redirected_to 'news/show/1'
                 comment = News.find(1).comments.find(:first, :order => 'created_on DESC')
                 assert_not_nil comment
                 assert_equal 'This is a NewsControllerTest comment', comment.comments
                 assert_equal User.find(2), comment.author
               end
+              def test_empty_comment_should_not_be_added
+                @request.session[:user_id] = 2
+                assert_no_difference 'Comment.count' do
+                  post :add_comment, :id => 1, :comment => { :comments => '' }
+                  assert_response :success
+                  assert_template 'show'
+                end
+              end
               def test_destroy_comment
                 comments_count = News.find(1).comments.size
                 @request.session[:user_id] = 2
                 post :destroy_comment, :id => 1, :comment_id => 2
                 assert_redirected_to 'news/show/1'
                 assert_nil Comment.find_by_id(2)
                 assert_equal comments_count - 1, News.find(1).comments.size
               end
               def test_destroy
                 @request.session[:user_id] = 2
                 post :destroy, :id => 1
                 assert_redirected_to 'projects/ecookbook/news'
                 assert_nil News.find_by_id(1)
               end
               def test_preview
                 get :preview, :project_id => 1,
                               :news => {:title => '',
                                         :description => 'News description',
                                         :summary => ''}
                 assert_response :success
                 assert_template 'common/_preview'
                 assert_tag :tag => 'fieldset', :attributes => { :class => 'preview' },
                                                :content => /News description/
               end
             end

test/unit/helpers/application_helper_test.rb +5 0

             # redMine - project management software
             # Copyright (C) 2006-2007  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.dirname(__FILE__) + '/../../test_helper'
             class ApplicationHelperTest < HelperTestCase
               include ApplicationHelper
               include ActionView::Helpers::TextHelper
               fixtures :projects, :roles, :enabled_modules, :users,
                                   :repositories, :changesets,
                                   :trackers, :issue_statuses, :issues, :versions, :documents,
                                   :wikis, :wiki_pages, :wiki_contents,
                                   :boards, :messages,
                                   :attachments
               def setup
                 super
               end
               def test_auto_links
                 to_test = {
                   'http://foo.bar' => '<a class="external" href="http://foo.bar">http://foo.bar</a>',
                   'http://foo.bar/~user' => '<a class="external" href="http://foo.bar/~user">http://foo.bar/~user</a>',
                   'http://foo.bar.' => '<a class="external" href="http://foo.bar">http://foo.bar</a>.',
                   'https://foo.bar.' => '<a class="external" href="https://foo.bar">https://foo.bar</a>.',
                   'This is a link: http://foo.bar.' => 'This is a link: <a class="external" href="http://foo.bar">http://foo.bar</a>.',
                   'A link (eg. http://foo.bar).' => 'A link (eg. <a class="external" href="http://foo.bar">http://foo.bar</a>).',
                   'http://foo.bar/foo.bar#foo.bar.' => '<a class="external" href="http://foo.bar/foo.bar#foo.bar">http://foo.bar/foo.bar#foo.bar</a>.',
                   'http://www.foo.bar/Test_(foobar)' => '<a class="external" href="http://www.foo.bar/Test_(foobar)">http://www.foo.bar/Test_(foobar)</a>',
                   '(see inline link : http://www.foo.bar/Test_(foobar))' => '(see inline link : <a class="external" href="http://www.foo.bar/Test_(foobar)">http://www.foo.bar/Test_(foobar)</a>)',
                   '(see inline link : http://www.foo.bar/Test)' => '(see inline link : <a class="external" href="http://www.foo.bar/Test">http://www.foo.bar/Test</a>)',
                   '(see inline link : http://www.foo.bar/Test).' => '(see inline link : <a class="external" href="http://www.foo.bar/Test">http://www.foo.bar/Test</a>).',
                   '(see "inline link":http://www.foo.bar/Test_(foobar))' => '(see <a href="http://www.foo.bar/Test_(foobar)" class="external">inline link</a>)',
                   '(see "inline link":http://www.foo.bar/Test)' => '(see <a href="http://www.foo.bar/Test" class="external">inline link</a>)',
                   '(see "inline link":http://www.foo.bar/Test).' => '(see <a href="http://www.foo.bar/Test" class="external">inline link</a>).',
                   'www.foo.bar' => '<a class="external" href="http://www.foo.bar">www.foo.bar</a>',
                   'http://foo.bar/page?p=1&t=z&s=' => '<a class="external" href="http://foo.bar/page?p=1&#38;t=z&#38;s=">http://foo.bar/page?p=1&#38;t=z&#38;s=</a>',
                   'http://foo.bar/page#125' => '<a class="external" href="http://foo.bar/page#125">http://foo.bar/page#125</a>',
                   'http://foo@www.bar.com' => '<a class="external" href="http://foo@www.bar.com">http://foo@www.bar.com</a>',
                   'http://foo:bar@www.bar.com' => '<a class="external" href="http://foo:bar@www.bar.com">http://foo:bar@www.bar.com</a>',
                   'ftp://foo.bar' => '<a class="external" href="ftp://foo.bar">ftp://foo.bar</a>',
                   'ftps://foo.bar' => '<a class="external" href="ftps://foo.bar">ftps://foo.bar</a>',
                   'sftp://foo.bar' => '<a class="external" href="sftp://foo.bar">sftp://foo.bar</a>',
                   # two exclamation marks
                   'http://example.net/path!602815048C7B5C20!302.html' => '<a class="external" href="http://example.net/path!602815048C7B5C20!302.html">http://example.net/path!602815048C7B5C20!302.html</a>',
                 }
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text) }
               end
               def test_auto_mailto
                 assert_equal '<p><a href="mailto:test@foo.bar" class="email">test@foo.bar</a></p>',
                   textilizable('test@foo.bar')
               end
               def test_inline_images
                 to_test = {
                   '!http://foo.bar/image.jpg!' => '<img src="http://foo.bar/image.jpg" alt="" />',
                   'floating !>http://foo.bar/image.jpg!' => 'floating <div style="float:right"><img src="http://foo.bar/image.jpg" alt="" /></div>',
                   'with class !(some-class)http://foo.bar/image.jpg!' => 'with class <img src="http://foo.bar/image.jpg" class="some-class" alt="" />',
                   # inline styles should be stripped
                   'with style !{width:100px;height100px}http://foo.bar/image.jpg!' => 'with style <img src="http://foo.bar/image.jpg" alt="" />',
                   'with title !http://foo.bar/image.jpg(This is a title)!' => 'with title <img src="http://foo.bar/image.jpg" title="This is a title" alt="This is a title" />',
                   'with title !http://foo.bar/image.jpg(This is a double-quoted "title")!' => 'with title <img src="http://foo.bar/image.jpg" title="This is a double-quoted &quot;title&quot;" alt="This is a double-quoted &quot;title&quot;" />',
                 }
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text) }
               end
               def test_acronyms
                 to_test = {
                   'this is an acronym: GPL(General Public License)' => 'this is an acronym: <acronym title="General Public License">GPL</acronym>',
                   'GPL(This is a double-quoted "title")' => '<acronym title="This is a double-quoted &quot;title&quot;">GPL</acronym>',
                 }
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text) }
               end
               def test_attached_images
                 to_test = {
                   'Inline image: !logo.gif!' => 'Inline image: <img src="/attachments/download/3" title="This is a logo" alt="This is a logo" />',
                   'Inline image: !logo.GIF!' => 'Inline image: <img src="/attachments/download/3" title="This is a logo" alt="This is a logo" />',
                   'No match: !ogo.gif!' => 'No match: <img src="ogo.gif" alt="" />',
                   'No match: !ogo.GIF!' => 'No match: <img src="ogo.GIF" alt="" />'
                 }
                 attachments = Attachment.find(:all)
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text, :attachments => attachments) }
               end
               def test_textile_external_links
                 to_test = {
                   'This is a "link":http://foo.bar' => 'This is a <a href="http://foo.bar" class="external">link</a>',
                   'This is an intern "link":/foo/bar' => 'This is an intern <a href="/foo/bar">link</a>',
                   '"link (Link title)":http://foo.bar' => '<a href="http://foo.bar" title="Link title" class="external">link</a>',
                   '"link (Link title with "double-quotes")":http://foo.bar' => '<a href="http://foo.bar" title="Link title with &quot;double-quotes&quot;" class="external">link</a>',
                   "This is not a \"Link\":\n\nAnother paragraph" => "This is not a \"Link\":</p>\n\n\n\t<p>Another paragraph",
                   # no multiline link text
                   "This is a double quote \"on the first line\nand another on a second line\":test" => "This is a double quote \"on the first line<br />\nand another on a second line\":test",
                   # mailto link
                   "\"system administrator\":mailto:sysadmin@example.com?subject=redmine%20permissions" => "<a href=\"mailto:sysadmin@example.com?subject=redmine%20permissions\">system administrator</a>",
                   # two exclamation marks
                   '"a link":http://example.net/path!602815048C7B5C20!302.html' => '<a href="http://example.net/path!602815048C7B5C20!302.html" class="external">a link</a>',
                 }
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text) }
               end
               def test_redmine_links
                 issue_link = link_to('#3', {:controller => 'issues', :action => 'show', :id => 3},
                                            :class => 'issue', :title => 'Error 281 when updating a recipe (New)')
                 changeset_link = link_to('r1', {:controller => 'repositories', :action => 'revision', :id => 'ecookbook', :rev => 1},
                                                :class => 'changeset', :title => 'My very first commit')
+                changeset_link2 = link_to('r2', {:controller => 'repositories', :action => 'revision', :id => 'ecookbook', :rev => 2},
+                                                :class => 'changeset', :title => 'This commit fixes #1, #2 and references #1 & #3')
                 document_link = link_to('Test document', {:controller => 'documents', :action => 'show', :id => 1},
                                                          :class => 'document')
                 version_link = link_to('1.0', {:controller => 'versions', :action => 'show', :id => 2},
                                               :class => 'version')
                 message_url = {:controller => 'messages', :action => 'show', :board_id => 1, :id => 4}
                 source_url = {:controller => 'repositories', :action => 'entry', :id => 'ecookbook', :path => ['some', 'file']}
                 source_url_with_ext = {:controller => 'repositories', :action => 'entry', :id => 'ecookbook', :path => ['some', 'file.ext']}
                 to_test = {
                   # tickets
                   '#3, #3 and #3.'              => "#{issue_link}, #{issue_link} and #{issue_link}.",
                   # changesets
                   'r1'                          => changeset_link,
+                  'r1.'                         => "#{changeset_link}.",
+                  'r1, r2'                      => "#{changeset_link}, #{changeset_link2}",
+                  'r1,r2'                       => "#{changeset_link},#{changeset_link2}",
                   # documents
                   'document#1'                  => document_link,
                   'document:"Test document"'    => document_link,
                   # versions
                   'version#2'                   => version_link,
                   'version:1.0'                 => version_link,
                   'version:"1.0"'               => version_link,
                   # source
                   'source:/some/file'           => link_to('source:/some/file', source_url, :class => 'source'),
                   'source:/some/file.'          => link_to('source:/some/file', source_url, :class => 'source') + ".",
                   'source:/some/file.ext.'      => link_to('source:/some/file.ext', source_url_with_ext, :class => 'source') + ".",
                   'source:/some/file. '         => link_to('source:/some/file', source_url, :class => 'source') + ".",
                   'source:/some/file.ext. '     => link_to('source:/some/file.ext', source_url_with_ext, :class => 'source') + ".",
                   'source:/some/file, '         => link_to('source:/some/file', source_url, :class => 'source') + ",",
                   'source:/some/file@52'        => link_to('source:/some/file@52', source_url.merge(:rev => 52), :class => 'source'),
                   'source:/some/file.ext@52'    => link_to('source:/some/file.ext@52', source_url_with_ext.merge(:rev => 52), :class => 'source'),
                   'source:/some/file#L110'      => link_to('source:/some/file#L110', source_url.merge(:anchor => 'L110'), :class => 'source'),
                   'source:/some/file.ext#L110'  => link_to('source:/some/file.ext#L110', source_url_with_ext.merge(:anchor => 'L110'), :class => 'source'),
                   'source:/some/file@52#L110'   => link_to('source:/some/file@52#L110', source_url.merge(:rev => 52, :anchor => 'L110'), :class => 'source'),
                   'export:/some/file'           => link_to('export:/some/file', source_url.merge(:format => 'raw'), :class => 'source download'),
                   # message
                   'message#4'                   => link_to('Post 2', message_url, :class => 'message'),
                   'message#5'                   => link_to('RE: post 2', message_url.merge(:anchor => 'message-5'), :class => 'message'),
                   # escaping
                   '!#3.'                        => '#3.',
                   '!r1'                         => 'r1',
                   '!document#1'                 => 'document#1',
                   '!document:"Test document"'   => 'document:"Test document"',
                   '!version#2'                  => 'version#2',
                   '!version:1.0'                => 'version:1.0',
                   '!version:"1.0"'              => 'version:"1.0"',
                   '!source:/some/file'          => 'source:/some/file',
                   # invalid expressions
                   'source:'                     => 'source:',
                   # url hash
                   "http://foo.bar/FAQ#3"       => '<a class="external" href="http://foo.bar/FAQ#3">http://foo.bar/FAQ#3</a>',
                 }
                 @project = Project.find(1)
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text) }
               end
               def test_wiki_links
                 to_test = {
                   '[[CookBook documentation]]' => '<a href="/wiki/ecookbook/CookBook_documentation" class="wiki-page">CookBook documentation</a>',
                   '[[Another page|Page]]' => '<a href="/wiki/ecookbook/Another_page" class="wiki-page">Page</a>',
                   # link with anchor
                   '[[CookBook documentation#One-section]]' => '<a href="/wiki/ecookbook/CookBook_documentation#One-section" class="wiki-page">CookBook documentation</a>',
                   '[[Another page#anchor|Page]]' => '<a href="/wiki/ecookbook/Another_page#anchor" class="wiki-page">Page</a>',
                   # page that doesn't exist
                   '[[Unknown page]]' => '<a href="/wiki/ecookbook/Unknown_page" class="wiki-page new">Unknown page</a>',
                   '[[Unknown page|404]]' => '<a href="/wiki/ecookbook/Unknown_page" class="wiki-page new">404</a>',
                   # link to another project wiki
                   '[[onlinestore:]]' => '<a href="/wiki/onlinestore/" class="wiki-page">onlinestore</a>',
                   '[[onlinestore:|Wiki]]' => '<a href="/wiki/onlinestore/" class="wiki-page">Wiki</a>',
                   '[[onlinestore:Start page]]' => '<a href="/wiki/onlinestore/Start_page" class="wiki-page">Start page</a>',
                   '[[onlinestore:Start page|Text]]' => '<a href="/wiki/onlinestore/Start_page" class="wiki-page">Text</a>',
                   '[[onlinestore:Unknown page]]' => '<a href="/wiki/onlinestore/Unknown_page" class="wiki-page new">Unknown page</a>',
                   # striked through link
                   '-[[Another page|Page]]-' => '<del><a href="/wiki/ecookbook/Another_page" class="wiki-page">Page</a></del>',
                   '-[[Another page|Page]] link-' => '<del><a href="/wiki/ecookbook/Another_page" class="wiki-page">Page</a> link</del>',
                   # escaping
                   '![[Another page|Page]]' => '[[Another page|Page]]',
                 }
                 @project = Project.find(1)
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text) }
               end
               def test_html_tags
                 to_test = {
                   "<div>content</div>" => "<p>&lt;div&gt;content&lt;/div&gt;</p>",
                   "<div class=\"bold\">content</div>" => "<p>&lt;div class=\"bold\"&gt;content&lt;/div&gt;</p>",
                   "<script>some script;</script>" => "<p>&lt;script&gt;some script;&lt;/script&gt;</p>",
                   # do not escape pre/code tags
                   "<pre>\nline 1\nline2</pre>" => "<pre>\nline 1\nline2</pre>",
                   "<pre><code>\nline 1\nline2</code></pre>" => "<pre><code>\nline 1\nline2</code></pre>",
                   "<pre><div>content</div></pre>" => "<pre>&lt;div&gt;content&lt;/div&gt;</pre>",
                   "HTML comment: <!-- no comments -->" => "<p>HTML comment: &lt;!-- no comments --&gt;</p>",
                   "<!-- opening comment" => "<p>&lt;!-- opening comment</p>",
                   # remove attributes except class
                   "<pre class='foo'>some text</pre>" => "<pre class='foo'>some text</pre>",
                   "<pre onmouseover='alert(1)'>some text</pre>" => "<pre>some text</pre>",
                 }
                 to_test.each { |text, result| assert_equal result, textilizable(text) }
               end
               def test_allowed_html_tags
                 to_test = {
                   "<pre>preformatted text</pre>" => "<pre>preformatted text</pre>",
                   "<notextile>no *textile* formatting</notextile>" => "no *textile* formatting",
                   "<notextile>this is <tag>a tag</tag></notextile>" => "this is &lt;tag&gt;a tag&lt;/tag&gt;"
                 }
                 to_test.each { |text, result| assert_equal result, textilizable(text) }
               end
               def syntax_highlight
                 raw = <<-RAW
             <pre><code class="ruby">
             # Some ruby code here
             </pre></code>
             RAW
                 expected = <<-EXPECTED
             <pre><code class="ruby CodeRay"><span class="no">1</span> <span class="c"># Some ruby code here</span>
             </pre></code>
             EXPECTED
                 assert_equal expected.gsub(%r{[\r\n\t]}, ''), textilizable(raw).gsub(%r{[\r\n\t]}, '')
               end
               def test_wiki_links_in_tables
                 to_test = {"|[[Page|Link title]]|[[Other Page|Other title]]|\n|Cell 21|[[Last page]]|" =>
                              '<tr><td><a href="/wiki/ecookbook/Page" class="wiki-page new">Link title</a></td>' +
                              '<td><a href="/wiki/ecookbook/Other_Page" class="wiki-page new">Other title</a></td>' +
                              '</tr><tr><td>Cell 21</td><td><a href="/wiki/ecookbook/Last_page" class="wiki-page new">Last page</a></td></tr>'
                 }
                 @project = Project.find(1)
                 to_test.each { |text, result| assert_equal "<table>#{result}</table>", textilizable(text).gsub(/[\t\n]/, '') }
               end
               def test_text_formatting
                 to_test = {'*_+bold, italic and underline+_*' => '<strong><em><ins>bold, italic and underline</ins></em></strong>',
                            '(_text within parentheses_)' => '(<em>text within parentheses</em>)',
                            'a *Humane Web* Text Generator' => 'a <strong>Humane Web</strong> Text Generator',
                            'a H *umane* W *eb* T *ext* G *enerator*' => 'a H <strong>umane</strong> W <strong>eb</strong> T <strong>ext</strong> G <strong>enerator</strong>',
                            'a *H* umane *W* eb *T* ext *G* enerator' => 'a <strong>H</strong> umane <strong>W</strong> eb <strong>T</strong> ext <strong>G</strong> enerator',
                           }
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text) }
               end
               def test_wiki_horizontal_rule
                 assert_equal '<hr />', textilizable('---')
                 assert_equal '<p>Dashes: ---</p>', textilizable('Dashes: ---')
               end
               def test_acronym
                 assert_equal '<p>This is an acronym: <acronym title="American Civil Liberties Union">ACLU</acronym>.</p>',
                              textilizable('This is an acronym: ACLU(American Civil Liberties Union).')
               end
               def test_footnotes
                 raw = <<-RAW
             This is some text[1].
             fn1. This is the foot note
             RAW
                 expected = <<-EXPECTED
             <p>This is some text<sup><a href=\"#fn1\">1</a></sup>.</p>
             <p id="fn1" class="footnote"><sup>1</sup> This is the foot note</p>
             EXPECTED
                 assert_equal expected.gsub(%r{[\r\n\t]}, ''), textilizable(raw).gsub(%r{[\r\n\t]}, '')
               end
               def test_table_of_content
                 raw = <<-RAW
             {{toc}}
             h1. Title
             Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Maecenas sed libero.
             h2. Subtitle
             Nullam commodo metus accumsan nulla. Curabitur lobortis dui id dolor.
             h2. Subtitle with %{color:red}red text%
             h1. Another title
             RAW
                 expected = '<ul class="toc">' +
                            '<li class="heading1"><a href="#Title">Title</a></li>' +
                            '<li class="heading2"><a href="#Subtitle">Subtitle</a></li>' +
                            '<li class="heading2"><a href="#Subtitle-with-red-text">Subtitle with red text</a></li>' +
                            '<li class="heading1"><a href="#Another-title">Another title</a></li>' +
                            '</ul>'
                 assert textilizable(raw).gsub("\n", "").include?(expected)
               end
               def test_blockquote
                 # orig raw text
                 raw = <<-RAW
             John said:
             > Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Maecenas sed libero.
             > Nullam commodo metus accumsan nulla. Curabitur lobortis dui id dolor.
             > * Donec odio lorem,
             > * sagittis ac,
             > * malesuada in,
             > * adipiscing eu, dolor.
             >
             > >Nulla varius pulvinar diam. Proin id arcu id lorem scelerisque condimentum. Proin vehicula turpis vitae lacus.
             > Proin a tellus. Nam vel neque.
             He's right.
             RAW
                 # expected html
                 expected = <<-EXPECTED
             <p>John said:</p>
             <blockquote>
             Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Maecenas sed libero.
             Nullam commodo metus accumsan nulla. Curabitur lobortis dui id dolor.
             <ul>
               <li>Donec odio lorem,</li>
               <li>sagittis ac,</li>
               <li>malesuada in,</li>
               <li>adipiscing eu, dolor.</li>
             </ul>
             <blockquote>
             <p>Nulla varius pulvinar diam. Proin id arcu id lorem scelerisque condimentum. Proin vehicula turpis vitae lacus.</p>
             </blockquote>
             <p>Proin a tellus. Nam vel neque.</p>
             </blockquote>
             <p>He's right.</p>
             EXPECTED
                 assert_equal expected.gsub(%r{\s+}, ''), textilizable(raw).gsub(%r{\s+}, '')
               end
               def test_table
                 raw = <<-RAW
             This is a table with empty cells:
             |cell11|cell12||
             |cell21||cell23|
             |cell31|cell32|cell33|
             RAW
                 expected = <<-EXPECTED
             <p>This is a table with empty cells:</p>
             <table>
               <tr><td>cell11</td><td>cell12</td><td></td></tr>
               <tr><td>cell21</td><td></td><td>cell23</td></tr>
               <tr><td>cell31</td><td>cell32</td><td>cell33</td></tr>
             </table>
             EXPECTED
                 assert_equal expected.gsub(%r{\s+}, ''), textilizable(raw).gsub(%r{\s+}, '')
               end
               def test_default_formatter
                 Setting.text_formatting = 'unknown'
                 text = 'a *link*: http://www.example.net/'
                 assert_equal '<p>a *link*: <a href="http://www.example.net/">http://www.example.net/</a></p>', textilizable(text)
                 Setting.text_formatting = 'textile'
               end
               def test_date_format_default
                 today = Date.today
                 Setting.date_format = ''
                 assert_equal l_date(today), format_date(today)
               end
               def test_date_format
                 today = Date.today
                 Setting.date_format = '%d %m %Y'
                 assert_equal today.strftime('%d %m %Y'), format_date(today)
               end
               def test_time_format_default
                 now = Time.now
                 Setting.date_format = ''
                 Setting.time_format = ''
                 assert_equal l_datetime(now), format_time(now)
                 assert_equal l_time(now), format_time(now, false)
               end
               def test_time_format
                 now = Time.now
                 Setting.date_format = '%d %m %Y'
                 Setting.time_format = '%H %M'
                 assert_equal now.strftime('%d %m %Y %H %M'), format_time(now)
                 assert_equal now.strftime('%H %M'), format_time(now, false)
               end
               def test_utc_time_format
                 now = Time.now.utc
                 Setting.date_format = '%d %m %Y'
                 Setting.time_format = '%H %M'
                 assert_equal Time.now.strftime('%d %m %Y %H %M'), format_time(now)
                 assert_equal Time.now.strftime('%H %M'), format_time(now, false)
               end
               def test_due_date_distance_in_words
                 to_test = { Date.today => 'Due in 0 days',
                             Date.today + 1 => 'Due in 1 day',
                             Date.today + 100 => 'Due in 100 days',
                             Date.today + 20000 => 'Due in 20000 days',
                             Date.today - 1 => '1 day late',
                             Date.today - 100 => '100 days late',
                             Date.today - 20000 => '20000 days late',
                            }
                 to_test.each do |date, expected|
                   assert_equal expected, due_date_distance_in_words(date)
                 end
               end
               def test_avatar
                 # turn on avatars
                 Setting.gravatar_enabled = '1'
                 assert avatar(User.find_by_mail('jsmith@somenet.foo')).include?(Digest::MD5.hexdigest('jsmith@somenet.foo'))
                 assert avatar('jsmith <jsmith@somenet.foo>').include?(Digest::MD5.hexdigest('jsmith@somenet.foo'))
                 assert_nil avatar('jsmith')
                 assert_nil avatar(nil)
                 # turn off avatars
                 Setting.gravatar_enabled = '0'
                 assert_nil avatar(User.find_by_mail('jsmith@somenet.foo'))
               end
             end

test/unit/mail_handler_test.rb +15 0

             # redMine - project management software
             # Copyright (C) 2006-2007  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.dirname(__FILE__) + '/../test_helper'
             class MailHandlerTest < Test::Unit::TestCase
               fixtures :users, :projects,
                                :enabled_modules,
                                :roles,
                                :members,
                                :issues,
                                :issue_statuses,
                                :workflows,
                                :trackers,
                                :projects_trackers,
                                :enumerations,
                                :issue_categories,
                                :custom_fields,
                                :custom_fields_trackers
               FIXTURES_PATH = File.dirname(__FILE__) + '/../fixtures/mail_handler'
               def setup
                 ActionMailer::Base.deliveries.clear
               end
               def test_add_issue
                 # This email contains: 'Project: onlinestore'
                 issue = submit_email('ticket_on_given_project.eml')
                 assert issue.is_a?(Issue)
                 assert !issue.new_record?
                 issue.reload
                 assert_equal 'New ticket on a given project', issue.subject
                 assert_equal User.find_by_login('jsmith'), issue.author
                 assert_equal Project.find(2), issue.project
                 assert_equal IssueStatus.find_by_name('Resolved'), issue.status
                 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
                 # keywords should be removed from the email body
                 assert !issue.description.match(/^Project:/i)
                 assert !issue.description.match(/^Status:/i)
               end
               def test_add_issue_with_status
                 # This email contains: 'Project: onlinestore' and 'Status: Resolved'
                 issue = submit_email('ticket_on_given_project.eml')
                 assert issue.is_a?(Issue)
                 assert !issue.new_record?
                 issue.reload
                 assert_equal Project.find(2), issue.project
                 assert_equal IssueStatus.find_by_name("Resolved"), issue.status
               end
               def test_add_issue_with_attributes_override
                 issue = submit_email('ticket_with_attributes.eml', :allow_override => 'tracker,category,priority')
                 assert issue.is_a?(Issue)
                 assert !issue.new_record?
                 issue.reload
                 assert_equal 'New ticket on a given project', issue.subject
                 assert_equal User.find_by_login('jsmith'), issue.author
                 assert_equal Project.find(2), issue.project
                 assert_equal 'Feature request', issue.tracker.to_s
                 assert_equal 'Stock management', issue.category.to_s
                 assert_equal 'Urgent', issue.priority.to_s
                 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
               end
               def test_add_issue_with_partial_attributes_override
                 issue = submit_email('ticket_with_attributes.eml', :issue => {:priority => 'High'}, :allow_override => ['tracker'])
                 assert issue.is_a?(Issue)
                 assert !issue.new_record?
                 issue.reload
                 assert_equal 'New ticket on a given project', issue.subject
                 assert_equal User.find_by_login('jsmith'), issue.author
                 assert_equal Project.find(2), issue.project
                 assert_equal 'Feature request', issue.tracker.to_s
                 assert_nil issue.category
                 assert_equal 'High', issue.priority.to_s
                 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
               end
+              def test_add_issue_with_spaces_between_attribute_and_separator
+                issue = submit_email('ticket_with_spaces_between_attribute_and_separator.eml', :allow_override => 'tracker,category,priority')
+                assert issue.is_a?(Issue)
+                assert !issue.new_record?
+                issue.reload
+                assert_equal 'New ticket on a given project', issue.subject
+                assert_equal User.find_by_login('jsmith'), issue.author
+                assert_equal Project.find(2), issue.project
+                assert_equal 'Feature request', issue.tracker.to_s
+                assert_equal 'Stock management', issue.category.to_s
+                assert_equal 'Urgent', issue.priority.to_s
+                assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
+              end
               def test_add_issue_with_attachment_to_specific_project
                 issue = submit_email('ticket_with_attachment.eml', :issue => {:project => 'onlinestore'})
                 assert issue.is_a?(Issue)
                 assert !issue.new_record?
                 issue.reload
                 assert_equal 'Ticket created by email with attachment', issue.subject
                 assert_equal User.find_by_login('jsmith'), issue.author
                 assert_equal Project.find(2), issue.project
                 assert_equal 'This is  a new ticket with attachments', issue.description
                 # Attachment properties
                 assert_equal 1, issue.attachments.size
                 assert_equal 'Paella.jpg', issue.attachments.first.filename
                 assert_equal 'image/jpeg', issue.attachments.first.content_type
                 assert_equal 10790, issue.attachments.first.filesize
               end
               def test_add_issue_with_custom_fields
                 issue = submit_email('ticket_with_custom_fields.eml', :issue => {:project => 'onlinestore'})
                 assert issue.is_a?(Issue)
                 assert !issue.new_record?
                 issue.reload
                 assert_equal 'New ticket with custom field values', issue.subject
                 assert_equal 'Value for a custom field', issue.custom_value_for(CustomField.find_by_name('Searchable field')).value
                 assert !issue.description.match(/^searchable field:/i)
               end
               def test_add_issue_with_cc
                 issue = submit_email('ticket_with_cc.eml', :issue => {:project => 'ecookbook'})
                 assert issue.is_a?(Issue)
                 assert !issue.new_record?
                 issue.reload
                 assert issue.watched_by?(User.find_by_mail('dlopper@somenet.foo'))
                 assert_equal 1, issue.watchers.size
               end
               def test_add_issue_without_from_header
                 Role.anonymous.add_permission!(:add_issues)
                 assert_equal false, submit_email('ticket_without_from_header.eml')
               end
               def test_add_issue_note
                 journal = submit_email('ticket_reply.eml')
                 assert journal.is_a?(Journal)
                 assert_equal User.find_by_login('jsmith'), journal.user
                 assert_equal Issue.find(2), journal.journalized
                 assert_match /This is reply/, journal.notes
               end
               def test_add_issue_note_with_status_change
                 # This email contains: 'Status: Resolved'
                 journal = submit_email('ticket_reply_with_status.eml')
                 assert journal.is_a?(Journal)
                 issue = Issue.find(journal.issue.id)
                 assert_equal User.find_by_login('jsmith'), journal.user
                 assert_equal Issue.find(2), journal.journalized
                 assert_match /This is reply/, journal.notes
                 assert_equal IssueStatus.find_by_name("Resolved"), issue.status
               end
               def test_should_strip_tags_of_html_only_emails
                 issue = submit_email('ticket_html_only.eml', :issue => {:project => 'ecookbook'})
                 assert issue.is_a?(Issue)
                 assert !issue.new_record?
                 issue.reload
                 assert_equal 'HTML email', issue.subject
                 assert_equal 'This is a html-only email.', issue.description
               end
               private
               def submit_email(filename, options={})
                 raw = IO.read(File.join(FIXTURES_PATH, filename))
                 MailHandler.receive(raw, options)
               end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages