##// END OF EJS Templates
Fixed test failure with ruby1.8 (#8842)....
Jean-Philippe Lang -
r12204:3c540594dc59
parent child
Show More
@@ -1,869 +1,869
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class QueryColumn
19 19 attr_accessor :name, :sortable, :groupable, :default_order
20 20 include Redmine::I18n
21 21
22 22 def initialize(name, options={})
23 23 self.name = name
24 24 self.sortable = options[:sortable]
25 25 self.groupable = options[:groupable] || false
26 26 if groupable == true
27 27 self.groupable = name.to_s
28 28 end
29 29 self.default_order = options[:default_order]
30 30 @inline = options.key?(:inline) ? options[:inline] : true
31 31 @caption_key = options[:caption] || "field_#{name}".to_sym
32 32 @frozen = options[:frozen]
33 33 end
34 34
35 35 def caption
36 36 @caption_key.is_a?(Symbol) ? l(@caption_key) : @caption_key
37 37 end
38 38
39 39 # Returns true if the column is sortable, otherwise false
40 40 def sortable?
41 41 !@sortable.nil?
42 42 end
43 43
44 44 def sortable
45 45 @sortable.is_a?(Proc) ? @sortable.call : @sortable
46 46 end
47 47
48 48 def inline?
49 49 @inline
50 50 end
51 51
52 52 def frozen?
53 53 @frozen
54 54 end
55 55
56 56 def value(object)
57 57 object.send name
58 58 end
59 59
60 60 def css_classes
61 61 name
62 62 end
63 63 end
64 64
65 65 class QueryCustomFieldColumn < QueryColumn
66 66
67 67 def initialize(custom_field)
68 68 self.name = "cf_#{custom_field.id}".to_sym
69 69 self.sortable = custom_field.order_statement || false
70 70 self.groupable = custom_field.group_statement || false
71 71 @inline = true
72 72 @cf = custom_field
73 73 end
74 74
75 75 def caption
76 76 @cf.name
77 77 end
78 78
79 79 def custom_field
80 80 @cf
81 81 end
82 82
83 83 def value(object)
84 84 if custom_field.visible_by?(object.project, User.current)
85 85 cv = object.custom_values.select {|v| v.custom_field_id == @cf.id}.collect {|v| @cf.cast_value(v.value)}
86 86 cv.size > 1 ? cv.sort {|a,b| a.to_s <=> b.to_s} : cv.first
87 87 else
88 88 nil
89 89 end
90 90 end
91 91
92 92 def css_classes
93 93 @css_classes ||= "#{name} #{@cf.field_format}"
94 94 end
95 95 end
96 96
97 97 class QueryAssociationCustomFieldColumn < QueryCustomFieldColumn
98 98
99 99 def initialize(association, custom_field)
100 100 super(custom_field)
101 101 self.name = "#{association}.cf_#{custom_field.id}".to_sym
102 102 # TODO: support sorting/grouping by association custom field
103 103 self.sortable = false
104 104 self.groupable = false
105 105 @association = association
106 106 end
107 107
108 108 def value(object)
109 109 if assoc = object.send(@association)
110 110 super(assoc)
111 111 end
112 112 end
113 113
114 114 def css_classes
115 115 @css_classes ||= "#{@association}_cf_#{@cf.id} #{@cf.field_format}"
116 116 end
117 117 end
118 118
119 119 class Query < ActiveRecord::Base
120 120 class StatementInvalid < ::ActiveRecord::StatementInvalid
121 121 end
122 122
123 123 VISIBILITY_PRIVATE = 0
124 124 VISIBILITY_ROLES = 1
125 125 VISIBILITY_PUBLIC = 2
126 126
127 127 belongs_to :project
128 128 belongs_to :user
129 129 has_and_belongs_to_many :roles, :join_table => "#{table_name_prefix}queries_roles#{table_name_suffix}", :foreign_key => "query_id"
130 130 serialize :filters
131 131 serialize :column_names
132 132 serialize :sort_criteria, Array
133 133 serialize :options, Hash
134 134
135 135 attr_protected :project_id, :user_id
136 136
137 137 validates_presence_of :name
138 138 validates_length_of :name, :maximum => 255
139 139 validates :visibility, :inclusion => { :in => [VISIBILITY_PUBLIC, VISIBILITY_ROLES, VISIBILITY_PRIVATE] }
140 140 validate :validate_query_filters
141 141 validate do |query|
142 142 errors.add(:base, l(:label_role_plural) + ' ' + l('activerecord.errors.messages.blank')) if query.visibility == VISIBILITY_ROLES && roles.blank?
143 143 end
144 144
145 145 after_save do |query|
146 146 if query.visibility_changed? && query.visibility != VISIBILITY_ROLES
147 147 query.roles.clear
148 148 end
149 149 end
150 150
151 151 class_attribute :operators
152 152 self.operators = {
153 153 "=" => :label_equals,
154 154 "!" => :label_not_equals,
155 155 "o" => :label_open_issues,
156 156 "c" => :label_closed_issues,
157 157 "!*" => :label_none,
158 158 "*" => :label_any,
159 159 ">=" => :label_greater_or_equal,
160 160 "<=" => :label_less_or_equal,
161 161 "><" => :label_between,
162 162 "<t+" => :label_in_less_than,
163 163 ">t+" => :label_in_more_than,
164 164 "><t+"=> :label_in_the_next_days,
165 165 "t+" => :label_in,
166 166 "t" => :label_today,
167 167 "ld" => :label_yesterday,
168 168 "w" => :label_this_week,
169 169 "lw" => :label_last_week,
170 170 "l2w" => [:label_last_n_weeks, {:count => 2}],
171 171 "m" => :label_this_month,
172 172 "lm" => :label_last_month,
173 173 "y" => :label_this_year,
174 174 ">t-" => :label_less_than_ago,
175 175 "<t-" => :label_more_than_ago,
176 176 "><t-"=> :label_in_the_past_days,
177 177 "t-" => :label_ago,
178 178 "~" => :label_contains,
179 179 "!~" => :label_not_contains,
180 180 "=p" => :label_any_issues_in_project,
181 181 "=!p" => :label_any_issues_not_in_project,
182 182 "!p" => :label_no_issues_in_project
183 183 }
184 184
185 185 class_attribute :operators_by_filter_type
186 186 self.operators_by_filter_type = {
187 187 :list => [ "=", "!" ],
188 188 :list_status => [ "o", "=", "!", "c", "*" ],
189 189 :list_optional => [ "=", "!", "!*", "*" ],
190 190 :list_subprojects => [ "*", "!*", "=" ],
191 191 :date => [ "=", ">=", "<=", "><", "<t+", ">t+", "><t+", "t+", "t", "ld", "w", "lw", "l2w", "m", "lm", "y", ">t-", "<t-", "><t-", "t-", "!*", "*" ],
192 192 :date_past => [ "=", ">=", "<=", "><", ">t-", "<t-", "><t-", "t-", "t", "ld", "w", "lw", "l2w", "m", "lm", "y", "!*", "*" ],
193 193 :string => [ "=", "~", "!", "!~", "!*", "*" ],
194 194 :text => [ "~", "!~", "!*", "*" ],
195 195 :integer => [ "=", ">=", "<=", "><", "!*", "*" ],
196 196 :float => [ "=", ">=", "<=", "><", "!*", "*" ],
197 197 :relation => ["=", "=p", "=!p", "!p", "!*", "*"]
198 198 }
199 199
200 200 class_attribute :available_columns
201 201 self.available_columns = []
202 202
203 203 class_attribute :queried_class
204 204
205 205 def queried_table_name
206 206 @queried_table_name ||= self.class.queried_class.table_name
207 207 end
208 208
209 209 def initialize(attributes=nil, *args)
210 210 super attributes
211 211 @is_for_all = project.nil?
212 212 end
213 213
214 214 # Builds the query from the given params
215 215 def build_from_params(params)
216 216 if params[:fields] || params[:f]
217 217 self.filters = {}
218 218 add_filters(params[:fields] || params[:f], params[:operators] || params[:op], params[:values] || params[:v])
219 219 else
220 220 available_filters.keys.each do |field|
221 221 add_short_filter(field, params[field]) if params[field]
222 222 end
223 223 end
224 224 self.group_by = params[:group_by] || (params[:query] && params[:query][:group_by])
225 225 self.column_names = params[:c] || (params[:query] && params[:query][:column_names])
226 226 self
227 227 end
228 228
229 229 # Builds a new query from the given params and attributes
230 230 def self.build_from_params(params, attributes={})
231 231 new(attributes).build_from_params(params)
232 232 end
233 233
234 234 def validate_query_filters
235 235 filters.each_key do |field|
236 236 if values_for(field)
237 237 case type_for(field)
238 238 when :integer
239 239 add_filter_error(field, :invalid) if values_for(field).detect {|v| v.present? && !v.match(/^[+-]?\d+$/) }
240 240 when :float
241 241 add_filter_error(field, :invalid) if values_for(field).detect {|v| v.present? && !v.match(/^[+-]?\d+(\.\d*)?$/) }
242 242 when :date, :date_past
243 243 case operator_for(field)
244 244 when "=", ">=", "<=", "><"
245 245 add_filter_error(field, :invalid) if values_for(field).detect {|v|
246 v.present? && (!v.match(/\A\d{4}-\d{2}-\d{2}(T\d{2}((:)?\d{2}){,2}(Z|\d{2}:?\d{2})?)?\z/) || parse_date(v).nil?)
246 v.present? && (!v.match(/\A\d{4}-\d{2}-\d{2}(T\d{2}((:)?\d{2}){0,2}(Z|\d{2}:?\d{2})?)?\z/) || parse_date(v).nil?)
247 247 }
248 248 when ">t-", "<t-", "t-", ">t+", "<t+", "t+", "><t+", "><t-"
249 249 add_filter_error(field, :invalid) if values_for(field).detect {|v| v.present? && !v.match(/^\d+$/) }
250 250 end
251 251 end
252 252 end
253 253
254 254 add_filter_error(field, :blank) unless
255 255 # filter requires one or more values
256 256 (values_for(field) and !values_for(field).first.blank?) or
257 257 # filter doesn't require any value
258 258 ["o", "c", "!*", "*", "t", "ld", "w", "lw", "l2w", "m", "lm", "y"].include? operator_for(field)
259 259 end if filters
260 260 end
261 261
262 262 def add_filter_error(field, message)
263 263 m = label_for(field) + " " + l(message, :scope => 'activerecord.errors.messages')
264 264 errors.add(:base, m)
265 265 end
266 266
267 267 def editable_by?(user)
268 268 return false unless user
269 269 # Admin can edit them all and regular users can edit their private queries
270 270 return true if user.admin? || (is_private? && self.user_id == user.id)
271 271 # Members can not edit public queries that are for all project (only admin is allowed to)
272 272 is_public? && !@is_for_all && user.allowed_to?(:manage_public_queries, project)
273 273 end
274 274
275 275 def trackers
276 276 @trackers ||= project.nil? ? Tracker.sorted.all : project.rolled_up_trackers
277 277 end
278 278
279 279 # Returns a hash of localized labels for all filter operators
280 280 def self.operators_labels
281 281 operators.inject({}) {|h, operator| h[operator.first] = l(*operator.last); h}
282 282 end
283 283
284 284 # Returns a representation of the available filters for JSON serialization
285 285 def available_filters_as_json
286 286 json = {}
287 287 available_filters.each do |field, options|
288 288 json[field] = options.slice(:type, :name, :values).stringify_keys
289 289 end
290 290 json
291 291 end
292 292
293 293 def all_projects
294 294 @all_projects ||= Project.visible.all
295 295 end
296 296
297 297 def all_projects_values
298 298 return @all_projects_values if @all_projects_values
299 299
300 300 values = []
301 301 Project.project_tree(all_projects) do |p, level|
302 302 prefix = (level > 0 ? ('--' * level + ' ') : '')
303 303 values << ["#{prefix}#{p.name}", p.id.to_s]
304 304 end
305 305 @all_projects_values = values
306 306 end
307 307
308 308 # Adds available filters
309 309 def initialize_available_filters
310 310 # implemented by sub-classes
311 311 end
312 312 protected :initialize_available_filters
313 313
314 314 # Adds an available filter
315 315 def add_available_filter(field, options)
316 316 @available_filters ||= ActiveSupport::OrderedHash.new
317 317 @available_filters[field] = options
318 318 @available_filters
319 319 end
320 320
321 321 # Removes an available filter
322 322 def delete_available_filter(field)
323 323 if @available_filters
324 324 @available_filters.delete(field)
325 325 end
326 326 end
327 327
328 328 # Return a hash of available filters
329 329 def available_filters
330 330 unless @available_filters
331 331 initialize_available_filters
332 332 @available_filters.each do |field, options|
333 333 options[:name] ||= l(options[:label] || "field_#{field}".gsub(/_id$/, ''))
334 334 end
335 335 end
336 336 @available_filters
337 337 end
338 338
339 339 def add_filter(field, operator, values=nil)
340 340 # values must be an array
341 341 return unless values.nil? || values.is_a?(Array)
342 342 # check if field is defined as an available filter
343 343 if available_filters.has_key? field
344 344 filter_options = available_filters[field]
345 345 filters[field] = {:operator => operator, :values => (values || [''])}
346 346 end
347 347 end
348 348
349 349 def add_short_filter(field, expression)
350 350 return unless expression && available_filters.has_key?(field)
351 351 field_type = available_filters[field][:type]
352 352 operators_by_filter_type[field_type].sort.reverse.detect do |operator|
353 353 next unless expression =~ /^#{Regexp.escape(operator)}(.*)$/
354 354 values = $1
355 355 add_filter field, operator, values.present? ? values.split('|') : ['']
356 356 end || add_filter(field, '=', expression.split('|'))
357 357 end
358 358
359 359 # Add multiple filters using +add_filter+
360 360 def add_filters(fields, operators, values)
361 361 if fields.is_a?(Array) && operators.is_a?(Hash) && (values.nil? || values.is_a?(Hash))
362 362 fields.each do |field|
363 363 add_filter(field, operators[field], values && values[field])
364 364 end
365 365 end
366 366 end
367 367
368 368 def has_filter?(field)
369 369 filters and filters[field]
370 370 end
371 371
372 372 def type_for(field)
373 373 available_filters[field][:type] if available_filters.has_key?(field)
374 374 end
375 375
376 376 def operator_for(field)
377 377 has_filter?(field) ? filters[field][:operator] : nil
378 378 end
379 379
380 380 def values_for(field)
381 381 has_filter?(field) ? filters[field][:values] : nil
382 382 end
383 383
384 384 def value_for(field, index=0)
385 385 (values_for(field) || [])[index]
386 386 end
387 387
388 388 def label_for(field)
389 389 label = available_filters[field][:name] if available_filters.has_key?(field)
390 390 label ||= l("field_#{field.to_s.gsub(/_id$/, '')}", :default => field)
391 391 end
392 392
393 393 def self.add_available_column(column)
394 394 self.available_columns << (column) if column.is_a?(QueryColumn)
395 395 end
396 396
397 397 # Returns an array of columns that can be used to group the results
398 398 def groupable_columns
399 399 available_columns.select {|c| c.groupable}
400 400 end
401 401
402 402 # Returns a Hash of columns and the key for sorting
403 403 def sortable_columns
404 404 available_columns.inject({}) {|h, column|
405 405 h[column.name.to_s] = column.sortable
406 406 h
407 407 }
408 408 end
409 409
410 410 def columns
411 411 # preserve the column_names order
412 412 cols = (has_default_columns? ? default_columns_names : column_names).collect do |name|
413 413 available_columns.find { |col| col.name == name }
414 414 end.compact
415 415 available_columns.select(&:frozen?) | cols
416 416 end
417 417
418 418 def inline_columns
419 419 columns.select(&:inline?)
420 420 end
421 421
422 422 def block_columns
423 423 columns.reject(&:inline?)
424 424 end
425 425
426 426 def available_inline_columns
427 427 available_columns.select(&:inline?)
428 428 end
429 429
430 430 def available_block_columns
431 431 available_columns.reject(&:inline?)
432 432 end
433 433
434 434 def default_columns_names
435 435 []
436 436 end
437 437
438 438 def column_names=(names)
439 439 if names
440 440 names = names.select {|n| n.is_a?(Symbol) || !n.blank? }
441 441 names = names.collect {|n| n.is_a?(Symbol) ? n : n.to_sym }
442 442 # Set column_names to nil if default columns
443 443 if names == default_columns_names
444 444 names = nil
445 445 end
446 446 end
447 447 write_attribute(:column_names, names)
448 448 end
449 449
450 450 def has_column?(column)
451 451 column_names && column_names.include?(column.is_a?(QueryColumn) ? column.name : column)
452 452 end
453 453
454 454 def has_custom_field_column?
455 455 columns.any? {|column| column.is_a? QueryCustomFieldColumn}
456 456 end
457 457
458 458 def has_default_columns?
459 459 column_names.nil? || column_names.empty?
460 460 end
461 461
462 462 def sort_criteria=(arg)
463 463 c = []
464 464 if arg.is_a?(Hash)
465 465 arg = arg.keys.sort.collect {|k| arg[k]}
466 466 end
467 467 c = arg.select {|k,o| !k.to_s.blank?}.slice(0,3).collect {|k,o| [k.to_s, (o == 'desc' || o == false) ? 'desc' : 'asc']}
468 468 write_attribute(:sort_criteria, c)
469 469 end
470 470
471 471 def sort_criteria
472 472 read_attribute(:sort_criteria) || []
473 473 end
474 474
475 475 def sort_criteria_key(arg)
476 476 sort_criteria && sort_criteria[arg] && sort_criteria[arg].first
477 477 end
478 478
479 479 def sort_criteria_order(arg)
480 480 sort_criteria && sort_criteria[arg] && sort_criteria[arg].last
481 481 end
482 482
483 483 def sort_criteria_order_for(key)
484 484 sort_criteria.detect {|k, order| key.to_s == k}.try(:last)
485 485 end
486 486
487 487 # Returns the SQL sort order that should be prepended for grouping
488 488 def group_by_sort_order
489 489 if grouped? && (column = group_by_column)
490 490 order = sort_criteria_order_for(column.name) || column.default_order
491 491 column.sortable.is_a?(Array) ?
492 492 column.sortable.collect {|s| "#{s} #{order}"}.join(',') :
493 493 "#{column.sortable} #{order}"
494 494 end
495 495 end
496 496
497 497 # Returns true if the query is a grouped query
498 498 def grouped?
499 499 !group_by_column.nil?
500 500 end
501 501
502 502 def group_by_column
503 503 groupable_columns.detect {|c| c.groupable && c.name.to_s == group_by}
504 504 end
505 505
506 506 def group_by_statement
507 507 group_by_column.try(:groupable)
508 508 end
509 509
510 510 def project_statement
511 511 project_clauses = []
512 512 if project && !project.descendants.active.empty?
513 513 ids = [project.id]
514 514 if has_filter?("subproject_id")
515 515 case operator_for("subproject_id")
516 516 when '='
517 517 # include the selected subprojects
518 518 ids += values_for("subproject_id").each(&:to_i)
519 519 when '!*'
520 520 # main project only
521 521 else
522 522 # all subprojects
523 523 ids += project.descendants.collect(&:id)
524 524 end
525 525 elsif Setting.display_subprojects_issues?
526 526 ids += project.descendants.collect(&:id)
527 527 end
528 528 project_clauses << "#{Project.table_name}.id IN (%s)" % ids.join(',')
529 529 elsif project
530 530 project_clauses << "#{Project.table_name}.id = %d" % project.id
531 531 end
532 532 project_clauses.any? ? project_clauses.join(' AND ') : nil
533 533 end
534 534
535 535 def statement
536 536 # filters clauses
537 537 filters_clauses = []
538 538 filters.each_key do |field|
539 539 next if field == "subproject_id"
540 540 v = values_for(field).clone
541 541 next unless v and !v.empty?
542 542 operator = operator_for(field)
543 543
544 544 # "me" value subsitution
545 545 if %w(assigned_to_id author_id user_id watcher_id).include?(field)
546 546 if v.delete("me")
547 547 if User.current.logged?
548 548 v.push(User.current.id.to_s)
549 549 v += User.current.group_ids.map(&:to_s) if field == 'assigned_to_id'
550 550 else
551 551 v.push("0")
552 552 end
553 553 end
554 554 end
555 555
556 556 if field == 'project_id'
557 557 if v.delete('mine')
558 558 v += User.current.memberships.map(&:project_id).map(&:to_s)
559 559 end
560 560 end
561 561
562 562 if field =~ /cf_(\d+)$/
563 563 # custom field
564 564 filters_clauses << sql_for_custom_field(field, operator, v, $1)
565 565 elsif respond_to?("sql_for_#{field}_field")
566 566 # specific statement
567 567 filters_clauses << send("sql_for_#{field}_field", field, operator, v)
568 568 else
569 569 # regular field
570 570 filters_clauses << '(' + sql_for_field(field, operator, v, queried_table_name, field) + ')'
571 571 end
572 572 end if filters and valid?
573 573
574 574 if (c = group_by_column) && c.is_a?(QueryCustomFieldColumn)
575 575 # Excludes results for which the grouped custom field is not visible
576 576 filters_clauses << c.custom_field.visibility_by_project_condition
577 577 end
578 578
579 579 filters_clauses << project_statement
580 580 filters_clauses.reject!(&:blank?)
581 581
582 582 filters_clauses.any? ? filters_clauses.join(' AND ') : nil
583 583 end
584 584
585 585 private
586 586
587 587 def sql_for_custom_field(field, operator, value, custom_field_id)
588 588 db_table = CustomValue.table_name
589 589 db_field = 'value'
590 590 filter = @available_filters[field]
591 591 return nil unless filter
592 592 if filter[:field].format.target_class && filter[:field].format.target_class <= User
593 593 if value.delete('me')
594 594 value.push User.current.id.to_s
595 595 end
596 596 end
597 597 not_in = nil
598 598 if operator == '!'
599 599 # Makes ! operator work for custom fields with multiple values
600 600 operator = '='
601 601 not_in = 'NOT'
602 602 end
603 603 customized_key = "id"
604 604 customized_class = queried_class
605 605 if field =~ /^(.+)\.cf_/
606 606 assoc = $1
607 607 customized_key = "#{assoc}_id"
608 608 customized_class = queried_class.reflect_on_association(assoc.to_sym).klass.base_class rescue nil
609 609 raise "Unknown #{queried_class.name} association #{assoc}" unless customized_class
610 610 end
611 611 where = sql_for_field(field, operator, value, db_table, db_field, true)
612 612 if operator =~ /[<>]/
613 613 where = "(#{where}) AND #{db_table}.#{db_field} <> ''"
614 614 end
615 615 "#{queried_table_name}.#{customized_key} #{not_in} IN (" +
616 616 "SELECT #{customized_class.table_name}.id FROM #{customized_class.table_name}" +
617 617 " LEFT OUTER JOIN #{db_table} ON #{db_table}.customized_type='#{customized_class}' AND #{db_table}.customized_id=#{customized_class.table_name}.id AND #{db_table}.custom_field_id=#{custom_field_id}" +
618 618 " WHERE (#{where}) AND (#{filter[:field].visibility_by_project_condition}))"
619 619 end
620 620
621 621 # Helper method to generate the WHERE sql for a +field+, +operator+ and a +value+
622 622 def sql_for_field(field, operator, value, db_table, db_field, is_custom_filter=false)
623 623 sql = ''
624 624 case operator
625 625 when "="
626 626 if value.any?
627 627 case type_for(field)
628 628 when :date, :date_past
629 629 sql = date_clause(db_table, db_field, parse_date(value.first), parse_date(value.first))
630 630 when :integer
631 631 if is_custom_filter
632 632 sql = "(#{db_table}.#{db_field} <> '' AND CAST(CASE #{db_table}.#{db_field} WHEN '' THEN '0' ELSE #{db_table}.#{db_field} END AS decimal(30,3)) = #{value.first.to_i})"
633 633 else
634 634 sql = "#{db_table}.#{db_field} = #{value.first.to_i}"
635 635 end
636 636 when :float
637 637 if is_custom_filter
638 638 sql = "(#{db_table}.#{db_field} <> '' AND CAST(CASE #{db_table}.#{db_field} WHEN '' THEN '0' ELSE #{db_table}.#{db_field} END AS decimal(30,3)) BETWEEN #{value.first.to_f - 1e-5} AND #{value.first.to_f + 1e-5})"
639 639 else
640 640 sql = "#{db_table}.#{db_field} BETWEEN #{value.first.to_f - 1e-5} AND #{value.first.to_f + 1e-5}"
641 641 end
642 642 else
643 643 sql = "#{db_table}.#{db_field} IN (" + value.collect{|val| "'#{connection.quote_string(val)}'"}.join(",") + ")"
644 644 end
645 645 else
646 646 # IN an empty set
647 647 sql = "1=0"
648 648 end
649 649 when "!"
650 650 if value.any?
651 651 sql = "(#{db_table}.#{db_field} IS NULL OR #{db_table}.#{db_field} NOT IN (" + value.collect{|val| "'#{connection.quote_string(val)}'"}.join(",") + "))"
652 652 else
653 653 # NOT IN an empty set
654 654 sql = "1=1"
655 655 end
656 656 when "!*"
657 657 sql = "#{db_table}.#{db_field} IS NULL"
658 658 sql << " OR #{db_table}.#{db_field} = ''" if is_custom_filter
659 659 when "*"
660 660 sql = "#{db_table}.#{db_field} IS NOT NULL"
661 661 sql << " AND #{db_table}.#{db_field} <> ''" if is_custom_filter
662 662 when ">="
663 663 if [:date, :date_past].include?(type_for(field))
664 664 sql = date_clause(db_table, db_field, parse_date(value.first), nil)
665 665 else
666 666 if is_custom_filter
667 667 sql = "(#{db_table}.#{db_field} <> '' AND CAST(CASE #{db_table}.#{db_field} WHEN '' THEN '0' ELSE #{db_table}.#{db_field} END AS decimal(30,3)) >= #{value.first.to_f})"
668 668 else
669 669 sql = "#{db_table}.#{db_field} >= #{value.first.to_f}"
670 670 end
671 671 end
672 672 when "<="
673 673 if [:date, :date_past].include?(type_for(field))
674 674 sql = date_clause(db_table, db_field, nil, parse_date(value.first))
675 675 else
676 676 if is_custom_filter
677 677 sql = "(#{db_table}.#{db_field} <> '' AND CAST(CASE #{db_table}.#{db_field} WHEN '' THEN '0' ELSE #{db_table}.#{db_field} END AS decimal(30,3)) <= #{value.first.to_f})"
678 678 else
679 679 sql = "#{db_table}.#{db_field} <= #{value.first.to_f}"
680 680 end
681 681 end
682 682 when "><"
683 683 if [:date, :date_past].include?(type_for(field))
684 684 sql = date_clause(db_table, db_field, parse_date(value[0]), parse_date(value[1]))
685 685 else
686 686 if is_custom_filter
687 687 sql = "(#{db_table}.#{db_field} <> '' AND CAST(CASE #{db_table}.#{db_field} WHEN '' THEN '0' ELSE #{db_table}.#{db_field} END AS decimal(30,3)) BETWEEN #{value[0].to_f} AND #{value[1].to_f})"
688 688 else
689 689 sql = "#{db_table}.#{db_field} BETWEEN #{value[0].to_f} AND #{value[1].to_f}"
690 690 end
691 691 end
692 692 when "o"
693 693 sql = "#{queried_table_name}.status_id IN (SELECT id FROM #{IssueStatus.table_name} WHERE is_closed=#{connection.quoted_false})" if field == "status_id"
694 694 when "c"
695 695 sql = "#{queried_table_name}.status_id IN (SELECT id FROM #{IssueStatus.table_name} WHERE is_closed=#{connection.quoted_true})" if field == "status_id"
696 696 when "><t-"
697 697 # between today - n days and today
698 698 sql = relative_date_clause(db_table, db_field, - value.first.to_i, 0)
699 699 when ">t-"
700 700 # >= today - n days
701 701 sql = relative_date_clause(db_table, db_field, - value.first.to_i, nil)
702 702 when "<t-"
703 703 # <= today - n days
704 704 sql = relative_date_clause(db_table, db_field, nil, - value.first.to_i)
705 705 when "t-"
706 706 # = n days in past
707 707 sql = relative_date_clause(db_table, db_field, - value.first.to_i, - value.first.to_i)
708 708 when "><t+"
709 709 # between today and today + n days
710 710 sql = relative_date_clause(db_table, db_field, 0, value.first.to_i)
711 711 when ">t+"
712 712 # >= today + n days
713 713 sql = relative_date_clause(db_table, db_field, value.first.to_i, nil)
714 714 when "<t+"
715 715 # <= today + n days
716 716 sql = relative_date_clause(db_table, db_field, nil, value.first.to_i)
717 717 when "t+"
718 718 # = today + n days
719 719 sql = relative_date_clause(db_table, db_field, value.first.to_i, value.first.to_i)
720 720 when "t"
721 721 # = today
722 722 sql = relative_date_clause(db_table, db_field, 0, 0)
723 723 when "ld"
724 724 # = yesterday
725 725 sql = relative_date_clause(db_table, db_field, -1, -1)
726 726 when "w"
727 727 # = this week
728 728 first_day_of_week = l(:general_first_day_of_week).to_i
729 729 day_of_week = Date.today.cwday
730 730 days_ago = (day_of_week >= first_day_of_week ? day_of_week - first_day_of_week : day_of_week + 7 - first_day_of_week)
731 731 sql = relative_date_clause(db_table, db_field, - days_ago, - days_ago + 6)
732 732 when "lw"
733 733 # = last week
734 734 first_day_of_week = l(:general_first_day_of_week).to_i
735 735 day_of_week = Date.today.cwday
736 736 days_ago = (day_of_week >= first_day_of_week ? day_of_week - first_day_of_week : day_of_week + 7 - first_day_of_week)
737 737 sql = relative_date_clause(db_table, db_field, - days_ago - 7, - days_ago - 1)
738 738 when "l2w"
739 739 # = last 2 weeks
740 740 first_day_of_week = l(:general_first_day_of_week).to_i
741 741 day_of_week = Date.today.cwday
742 742 days_ago = (day_of_week >= first_day_of_week ? day_of_week - first_day_of_week : day_of_week + 7 - first_day_of_week)
743 743 sql = relative_date_clause(db_table, db_field, - days_ago - 14, - days_ago - 1)
744 744 when "m"
745 745 # = this month
746 746 date = Date.today
747 747 sql = date_clause(db_table, db_field, date.beginning_of_month, date.end_of_month)
748 748 when "lm"
749 749 # = last month
750 750 date = Date.today.prev_month
751 751 sql = date_clause(db_table, db_field, date.beginning_of_month, date.end_of_month)
752 752 when "y"
753 753 # = this year
754 754 date = Date.today
755 755 sql = date_clause(db_table, db_field, date.beginning_of_year, date.end_of_year)
756 756 when "~"
757 757 sql = "LOWER(#{db_table}.#{db_field}) LIKE '%#{connection.quote_string(value.first.to_s.downcase)}%'"
758 758 when "!~"
759 759 sql = "LOWER(#{db_table}.#{db_field}) NOT LIKE '%#{connection.quote_string(value.first.to_s.downcase)}%'"
760 760 else
761 761 raise "Unknown query operator #{operator}"
762 762 end
763 763
764 764 return sql
765 765 end
766 766
767 767 # Adds a filter for the given custom field
768 768 def add_custom_field_filter(field, assoc=nil)
769 769 options = field.format.query_filter_options(field, self)
770 770 if field.format.target_class && field.format.target_class <= User
771 771 if options[:values].is_a?(Array) && User.current.logged?
772 772 options[:values].unshift ["<< #{l(:label_me)} >>", "me"]
773 773 end
774 774 end
775 775
776 776 filter_id = "cf_#{field.id}"
777 777 filter_name = field.name
778 778 if assoc.present?
779 779 filter_id = "#{assoc}.#{filter_id}"
780 780 filter_name = l("label_attribute_of_#{assoc}", :name => filter_name)
781 781 end
782 782 add_available_filter filter_id, options.merge({
783 783 :name => filter_name,
784 784 :field => field
785 785 })
786 786 end
787 787
788 788 # Adds filters for the given custom fields scope
789 789 def add_custom_fields_filters(scope, assoc=nil)
790 790 scope.visible.where(:is_filter => true).sorted.each do |field|
791 791 add_custom_field_filter(field, assoc)
792 792 end
793 793 end
794 794
795 795 # Adds filters for the given associations custom fields
796 796 def add_associations_custom_fields_filters(*associations)
797 797 fields_by_class = CustomField.visible.where(:is_filter => true).group_by(&:class)
798 798 associations.each do |assoc|
799 799 association_klass = queried_class.reflect_on_association(assoc).klass
800 800 fields_by_class.each do |field_class, fields|
801 801 if field_class.customized_class <= association_klass
802 802 fields.sort.each do |field|
803 803 add_custom_field_filter(field, assoc)
804 804 end
805 805 end
806 806 end
807 807 end
808 808 end
809 809
810 810 # Returns a SQL clause for a date or datetime field.
811 811 def date_clause(table, field, from, to)
812 812 s = []
813 813 if from
814 814 if from.is_a?(Date)
815 815 from = Time.local(from.year, from.month, from.day).yesterday.end_of_day
816 816 else
817 817 from = from - 1 # second
818 818 end
819 819 if self.class.default_timezone == :utc
820 820 from = from.utc
821 821 end
822 822 s << ("#{table}.#{field} > '%s'" % [connection.quoted_date(from)])
823 823 end
824 824 if to
825 825 if to.is_a?(Date)
826 826 to = Time.local(to.year, to.month, to.day).end_of_day
827 827 end
828 828 if self.class.default_timezone == :utc
829 829 to = to.utc
830 830 end
831 831 s << ("#{table}.#{field} <= '%s'" % [connection.quoted_date(to)])
832 832 end
833 833 s.join(' AND ')
834 834 end
835 835
836 836 # Returns a SQL clause for a date or datetime field using relative dates.
837 837 def relative_date_clause(table, field, days_from, days_to)
838 838 date_clause(table, field, (days_from ? Date.today + days_from : nil), (days_to ? Date.today + days_to : nil))
839 839 end
840 840
841 841 # Returns a Date or Time from the given filter value
842 842 def parse_date(arg)
843 843 if arg.to_s =~ /\A\d{4}-\d{2}-\d{2}T/
844 844 Time.parse(arg) rescue nil
845 845 else
846 846 Date.parse(arg) rescue nil
847 847 end
848 848 end
849 849
850 850 # Additional joins required for the given sort options
851 851 def joins_for_order_statement(order_options)
852 852 joins = []
853 853
854 854 if order_options
855 855 if order_options.include?('authors')
856 856 joins << "LEFT OUTER JOIN #{User.table_name} authors ON authors.id = #{queried_table_name}.author_id"
857 857 end
858 858 order_options.scan(/cf_\d+/).uniq.each do |name|
859 859 column = available_columns.detect {|c| c.name.to_s == name}
860 860 join = column && column.custom_field.join_for_order_statement
861 861 if join
862 862 joins << join
863 863 end
864 864 end
865 865 end
866 866
867 867 joins.any? ? joins.join(' ') : nil
868 868 end
869 869 end
@@ -1,1406 +1,1420
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class QueryTest < ActiveSupport::TestCase
21 21 include Redmine::I18n
22 22
23 23 fixtures :projects, :enabled_modules, :users, :members,
24 24 :member_roles, :roles, :trackers, :issue_statuses,
25 25 :issue_categories, :enumerations, :issues,
26 26 :watchers, :custom_fields, :custom_values, :versions,
27 27 :queries,
28 28 :projects_trackers,
29 29 :custom_fields_trackers
30 30
31 31 def test_query_with_roles_visibility_should_validate_roles
32 32 set_language_if_valid 'en'
33 33 query = IssueQuery.new(:name => 'Query', :visibility => IssueQuery::VISIBILITY_ROLES)
34 34 assert !query.save
35 35 assert_include "Roles can't be blank", query.errors.full_messages
36 36 query.role_ids = [1, 2]
37 37 assert query.save
38 38 end
39 39
40 40 def test_changing_roles_visibility_should_clear_roles
41 41 query = IssueQuery.create!(:name => 'Query', :visibility => IssueQuery::VISIBILITY_ROLES, :role_ids => [1, 2])
42 42 assert_equal 2, query.roles.count
43 43
44 44 query.visibility = IssueQuery::VISIBILITY_PUBLIC
45 45 query.save!
46 46 assert_equal 0, query.roles.count
47 47 end
48 48
49 49 def test_available_filters_should_be_ordered
50 50 set_language_if_valid 'en'
51 51 query = IssueQuery.new
52 52 assert_equal 0, query.available_filters.keys.index('status_id')
53 53 expected_order = [
54 54 "Status",
55 55 "Project",
56 56 "Tracker",
57 57 "Priority"
58 58 ]
59 59 assert_equal expected_order,
60 60 (query.available_filters.values.map{|v| v[:name]} & expected_order)
61 61 end
62 62
63 63 def test_available_filters_with_custom_fields_should_be_ordered
64 64 set_language_if_valid 'en'
65 65 UserCustomField.create!(
66 66 :name => 'order test', :field_format => 'string',
67 67 :is_for_all => true, :is_filter => true
68 68 )
69 69 query = IssueQuery.new
70 70 expected_order = [
71 71 "Searchable field",
72 72 "Database",
73 73 "Project's Development status",
74 74 "Author's order test",
75 75 "Assignee's order test"
76 76 ]
77 77 assert_equal expected_order,
78 78 (query.available_filters.values.map{|v| v[:name]} & expected_order)
79 79 end
80 80
81 81 def test_custom_fields_for_all_projects_should_be_available_in_global_queries
82 82 query = IssueQuery.new(:project => nil, :name => '_')
83 83 assert query.available_filters.has_key?('cf_1')
84 84 assert !query.available_filters.has_key?('cf_3')
85 85 end
86 86
87 87 def test_system_shared_versions_should_be_available_in_global_queries
88 88 Version.find(2).update_attribute :sharing, 'system'
89 89 query = IssueQuery.new(:project => nil, :name => '_')
90 90 assert query.available_filters.has_key?('fixed_version_id')
91 91 assert query.available_filters['fixed_version_id'][:values].detect {|v| v.last == '2'}
92 92 end
93 93
94 94 def test_project_filter_in_global_queries
95 95 query = IssueQuery.new(:project => nil, :name => '_')
96 96 project_filter = query.available_filters["project_id"]
97 97 assert_not_nil project_filter
98 98 project_ids = project_filter[:values].map{|p| p[1]}
99 99 assert project_ids.include?("1") #public project
100 100 assert !project_ids.include?("2") #private project user cannot see
101 101 end
102 102
103 103 def find_issues_with_query(query)
104 104 Issue.includes([:assigned_to, :status, :tracker, :project, :priority]).where(
105 105 query.statement
106 106 ).all
107 107 end
108 108
109 109 def assert_find_issues_with_query_is_successful(query)
110 110 assert_nothing_raised do
111 111 find_issues_with_query(query)
112 112 end
113 113 end
114 114
115 115 def assert_query_statement_includes(query, condition)
116 116 assert_include condition, query.statement
117 117 end
118 118
119 119 def assert_query_result(expected, query)
120 120 assert_nothing_raised do
121 121 assert_equal expected.map(&:id).sort, query.issues.map(&:id).sort
122 122 assert_equal expected.size, query.issue_count
123 123 end
124 124 end
125 125
126 126 def test_query_should_allow_shared_versions_for_a_project_query
127 127 subproject_version = Version.find(4)
128 128 query = IssueQuery.new(:project => Project.find(1), :name => '_')
129 129 query.add_filter('fixed_version_id', '=', [subproject_version.id.to_s])
130 130
131 131 assert query.statement.include?("#{Issue.table_name}.fixed_version_id IN ('4')")
132 132 end
133 133
134 134 def test_query_with_multiple_custom_fields
135 135 query = IssueQuery.find(1)
136 136 assert query.valid?
137 137 assert query.statement.include?("#{CustomValue.table_name}.value IN ('MySQL')")
138 138 issues = find_issues_with_query(query)
139 139 assert_equal 1, issues.length
140 140 assert_equal Issue.find(3), issues.first
141 141 end
142 142
143 143 def test_operator_none
144 144 query = IssueQuery.new(:project => Project.find(1), :name => '_')
145 145 query.add_filter('fixed_version_id', '!*', [''])
146 146 query.add_filter('cf_1', '!*', [''])
147 147 assert query.statement.include?("#{Issue.table_name}.fixed_version_id IS NULL")
148 148 assert query.statement.include?("#{CustomValue.table_name}.value IS NULL OR #{CustomValue.table_name}.value = ''")
149 149 find_issues_with_query(query)
150 150 end
151 151
152 152 def test_operator_none_for_integer
153 153 query = IssueQuery.new(:project => Project.find(1), :name => '_')
154 154 query.add_filter('estimated_hours', '!*', [''])
155 155 issues = find_issues_with_query(query)
156 156 assert !issues.empty?
157 157 assert issues.all? {|i| !i.estimated_hours}
158 158 end
159 159
160 160 def test_operator_none_for_date
161 161 query = IssueQuery.new(:project => Project.find(1), :name => '_')
162 162 query.add_filter('start_date', '!*', [''])
163 163 issues = find_issues_with_query(query)
164 164 assert !issues.empty?
165 165 assert issues.all? {|i| i.start_date.nil?}
166 166 end
167 167
168 168 def test_operator_none_for_string_custom_field
169 169 query = IssueQuery.new(:project => Project.find(1), :name => '_')
170 170 query.add_filter('cf_2', '!*', [''])
171 171 assert query.has_filter?('cf_2')
172 172 issues = find_issues_with_query(query)
173 173 assert !issues.empty?
174 174 assert issues.all? {|i| i.custom_field_value(2).blank?}
175 175 end
176 176
177 177 def test_operator_all
178 178 query = IssueQuery.new(:project => Project.find(1), :name => '_')
179 179 query.add_filter('fixed_version_id', '*', [''])
180 180 query.add_filter('cf_1', '*', [''])
181 181 assert query.statement.include?("#{Issue.table_name}.fixed_version_id IS NOT NULL")
182 182 assert query.statement.include?("#{CustomValue.table_name}.value IS NOT NULL AND #{CustomValue.table_name}.value <> ''")
183 183 find_issues_with_query(query)
184 184 end
185 185
186 186 def test_operator_all_for_date
187 187 query = IssueQuery.new(:project => Project.find(1), :name => '_')
188 188 query.add_filter('start_date', '*', [''])
189 189 issues = find_issues_with_query(query)
190 190 assert !issues.empty?
191 191 assert issues.all? {|i| i.start_date.present?}
192 192 end
193 193
194 194 def test_operator_all_for_string_custom_field
195 195 query = IssueQuery.new(:project => Project.find(1), :name => '_')
196 196 query.add_filter('cf_2', '*', [''])
197 197 assert query.has_filter?('cf_2')
198 198 issues = find_issues_with_query(query)
199 199 assert !issues.empty?
200 200 assert issues.all? {|i| i.custom_field_value(2).present?}
201 201 end
202 202
203 203 def test_numeric_filter_should_not_accept_non_numeric_values
204 204 query = IssueQuery.new(:name => '_')
205 205 query.add_filter('estimated_hours', '=', ['a'])
206 206
207 207 assert query.has_filter?('estimated_hours')
208 208 assert !query.valid?
209 209 end
210 210
211 211 def test_operator_is_on_float
212 212 Issue.update_all("estimated_hours = 171.2", "id=2")
213 213
214 214 query = IssueQuery.new(:name => '_')
215 215 query.add_filter('estimated_hours', '=', ['171.20'])
216 216 issues = find_issues_with_query(query)
217 217 assert_equal 1, issues.size
218 218 assert_equal 2, issues.first.id
219 219 end
220 220
221 221 def test_operator_is_on_integer_custom_field
222 222 f = IssueCustomField.create!(:name => 'filter', :field_format => 'int', :is_for_all => true, :is_filter => true, :trackers => Tracker.all)
223 223 CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => '7')
224 224 CustomValue.create!(:custom_field => f, :customized => Issue.find(2), :value => '12')
225 225 CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => '')
226 226
227 227 query = IssueQuery.new(:name => '_')
228 228 query.add_filter("cf_#{f.id}", '=', ['12'])
229 229 issues = find_issues_with_query(query)
230 230 assert_equal 1, issues.size
231 231 assert_equal 2, issues.first.id
232 232 end
233 233
234 234 def test_operator_is_on_integer_custom_field_should_accept_negative_value
235 235 f = IssueCustomField.create!(:name => 'filter', :field_format => 'int', :is_for_all => true, :is_filter => true, :trackers => Tracker.all)
236 236 CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => '7')
237 237 CustomValue.create!(:custom_field => f, :customized => Issue.find(2), :value => '-12')
238 238 CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => '')
239 239
240 240 query = IssueQuery.new(:name => '_')
241 241 query.add_filter("cf_#{f.id}", '=', ['-12'])
242 242 assert query.valid?
243 243 issues = find_issues_with_query(query)
244 244 assert_equal 1, issues.size
245 245 assert_equal 2, issues.first.id
246 246 end
247 247
248 248 def test_operator_is_on_float_custom_field
249 249 f = IssueCustomField.create!(:name => 'filter', :field_format => 'float', :is_filter => true, :is_for_all => true, :trackers => Tracker.all)
250 250 CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => '7.3')
251 251 CustomValue.create!(:custom_field => f, :customized => Issue.find(2), :value => '12.7')
252 252 CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => '')
253 253
254 254 query = IssueQuery.new(:name => '_')
255 255 query.add_filter("cf_#{f.id}", '=', ['12.7'])
256 256 issues = find_issues_with_query(query)
257 257 assert_equal 1, issues.size
258 258 assert_equal 2, issues.first.id
259 259 end
260 260
261 261 def test_operator_is_on_float_custom_field_should_accept_negative_value
262 262 f = IssueCustomField.create!(:name => 'filter', :field_format => 'float', :is_filter => true, :is_for_all => true, :trackers => Tracker.all)
263 263 CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => '7.3')
264 264 CustomValue.create!(:custom_field => f, :customized => Issue.find(2), :value => '-12.7')
265 265 CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => '')
266 266
267 267 query = IssueQuery.new(:name => '_')
268 268 query.add_filter("cf_#{f.id}", '=', ['-12.7'])
269 269 assert query.valid?
270 270 issues = find_issues_with_query(query)
271 271 assert_equal 1, issues.size
272 272 assert_equal 2, issues.first.id
273 273 end
274 274
275 275 def test_operator_is_on_multi_list_custom_field
276 276 f = IssueCustomField.create!(:name => 'filter', :field_format => 'list', :is_filter => true, :is_for_all => true,
277 277 :possible_values => ['value1', 'value2', 'value3'], :multiple => true, :trackers => Tracker.all)
278 278 CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => 'value1')
279 279 CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => 'value2')
280 280 CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => 'value1')
281 281
282 282 query = IssueQuery.new(:name => '_')
283 283 query.add_filter("cf_#{f.id}", '=', ['value1'])
284 284 issues = find_issues_with_query(query)
285 285 assert_equal [1, 3], issues.map(&:id).sort
286 286
287 287 query = IssueQuery.new(:name => '_')
288 288 query.add_filter("cf_#{f.id}", '=', ['value2'])
289 289 issues = find_issues_with_query(query)
290 290 assert_equal [1], issues.map(&:id).sort
291 291 end
292 292
293 293 def test_operator_is_not_on_multi_list_custom_field
294 294 f = IssueCustomField.create!(:name => 'filter', :field_format => 'list', :is_filter => true, :is_for_all => true,
295 295 :possible_values => ['value1', 'value2', 'value3'], :multiple => true, :trackers => Tracker.all)
296 296 CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => 'value1')
297 297 CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => 'value2')
298 298 CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => 'value1')
299 299
300 300 query = IssueQuery.new(:name => '_')
301 301 query.add_filter("cf_#{f.id}", '!', ['value1'])
302 302 issues = find_issues_with_query(query)
303 303 assert !issues.map(&:id).include?(1)
304 304 assert !issues.map(&:id).include?(3)
305 305
306 306 query = IssueQuery.new(:name => '_')
307 307 query.add_filter("cf_#{f.id}", '!', ['value2'])
308 308 issues = find_issues_with_query(query)
309 309 assert !issues.map(&:id).include?(1)
310 310 assert issues.map(&:id).include?(3)
311 311 end
312 312
313 313 def test_operator_is_on_is_private_field
314 314 # is_private filter only available for those who can set issues private
315 315 User.current = User.find(2)
316 316
317 317 query = IssueQuery.new(:name => '_')
318 318 assert query.available_filters.key?('is_private')
319 319
320 320 query.add_filter("is_private", '=', ['1'])
321 321 issues = find_issues_with_query(query)
322 322 assert issues.any?
323 323 assert_nil issues.detect {|issue| !issue.is_private?}
324 324 ensure
325 325 User.current = nil
326 326 end
327 327
328 328 def test_operator_is_not_on_is_private_field
329 329 # is_private filter only available for those who can set issues private
330 330 User.current = User.find(2)
331 331
332 332 query = IssueQuery.new(:name => '_')
333 333 assert query.available_filters.key?('is_private')
334 334
335 335 query.add_filter("is_private", '!', ['1'])
336 336 issues = find_issues_with_query(query)
337 337 assert issues.any?
338 338 assert_nil issues.detect {|issue| issue.is_private?}
339 339 ensure
340 340 User.current = nil
341 341 end
342 342
343 343 def test_operator_greater_than
344 344 query = IssueQuery.new(:project => Project.find(1), :name => '_')
345 345 query.add_filter('done_ratio', '>=', ['40'])
346 346 assert query.statement.include?("#{Issue.table_name}.done_ratio >= 40.0")
347 347 find_issues_with_query(query)
348 348 end
349 349
350 350 def test_operator_greater_than_a_float
351 351 query = IssueQuery.new(:project => Project.find(1), :name => '_')
352 352 query.add_filter('estimated_hours', '>=', ['40.5'])
353 353 assert query.statement.include?("#{Issue.table_name}.estimated_hours >= 40.5")
354 354 find_issues_with_query(query)
355 355 end
356 356
357 357 def test_operator_greater_than_on_int_custom_field
358 358 f = IssueCustomField.create!(:name => 'filter', :field_format => 'int', :is_filter => true, :is_for_all => true, :trackers => Tracker.all)
359 359 CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => '7')
360 360 CustomValue.create!(:custom_field => f, :customized => Issue.find(2), :value => '12')
361 361 CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => '')
362 362
363 363 query = IssueQuery.new(:project => Project.find(1), :name => '_')
364 364 query.add_filter("cf_#{f.id}", '>=', ['8'])
365 365 issues = find_issues_with_query(query)
366 366 assert_equal 1, issues.size
367 367 assert_equal 2, issues.first.id
368 368 end
369 369
370 370 def test_operator_lesser_than
371 371 query = IssueQuery.new(:project => Project.find(1), :name => '_')
372 372 query.add_filter('done_ratio', '<=', ['30'])
373 373 assert query.statement.include?("#{Issue.table_name}.done_ratio <= 30.0")
374 374 find_issues_with_query(query)
375 375 end
376 376
377 377 def test_operator_lesser_than_on_custom_field
378 378 f = IssueCustomField.create!(:name => 'filter', :field_format => 'int', :is_filter => true, :is_for_all => true)
379 379 query = IssueQuery.new(:project => Project.find(1), :name => '_')
380 380 query.add_filter("cf_#{f.id}", '<=', ['30'])
381 381 assert_match /CAST.+ <= 30\.0/, query.statement
382 382 find_issues_with_query(query)
383 383 end
384 384
385 385 def test_operator_lesser_than_on_date_custom_field
386 386 f = IssueCustomField.create!(:name => 'filter', :field_format => 'date', :is_filter => true, :is_for_all => true, :trackers => Tracker.all)
387 387 CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => '2013-04-11')
388 388 CustomValue.create!(:custom_field => f, :customized => Issue.find(2), :value => '2013-05-14')
389 389 CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => '')
390 390
391 391 query = IssueQuery.new(:project => Project.find(1), :name => '_')
392 392 query.add_filter("cf_#{f.id}", '<=', ['2013-05-01'])
393 393 issue_ids = find_issues_with_query(query).map(&:id)
394 394 assert_include 1, issue_ids
395 395 assert_not_include 2, issue_ids
396 396 assert_not_include 3, issue_ids
397 397 end
398 398
399 399 def test_operator_between
400 400 query = IssueQuery.new(:project => Project.find(1), :name => '_')
401 401 query.add_filter('done_ratio', '><', ['30', '40'])
402 402 assert_include "#{Issue.table_name}.done_ratio BETWEEN 30.0 AND 40.0", query.statement
403 403 find_issues_with_query(query)
404 404 end
405 405
406 406 def test_operator_between_on_custom_field
407 407 f = IssueCustomField.create!(:name => 'filter', :field_format => 'int', :is_filter => true, :is_for_all => true)
408 408 query = IssueQuery.new(:project => Project.find(1), :name => '_')
409 409 query.add_filter("cf_#{f.id}", '><', ['30', '40'])
410 410 assert_match /CAST.+ BETWEEN 30.0 AND 40.0/, query.statement
411 411 find_issues_with_query(query)
412 412 end
413 413
414 414 def test_date_filter_should_not_accept_non_date_values
415 415 query = IssueQuery.new(:name => '_')
416 416 query.add_filter('created_on', '=', ['a'])
417 417
418 418 assert query.has_filter?('created_on')
419 419 assert !query.valid?
420 420 end
421 421
422 422 def test_date_filter_should_not_accept_invalid_date_values
423 423 query = IssueQuery.new(:name => '_')
424 424 query.add_filter('created_on', '=', ['2011-01-34'])
425 425
426 426 assert query.has_filter?('created_on')
427 427 assert !query.valid?
428 428 end
429 429
430 430 def test_relative_date_filter_should_not_accept_non_integer_values
431 431 query = IssueQuery.new(:name => '_')
432 432 query.add_filter('created_on', '>t-', ['a'])
433 433
434 434 assert query.has_filter?('created_on')
435 435 assert !query.valid?
436 436 end
437 437
438 438 def test_operator_date_equals
439 439 query = IssueQuery.new(:name => '_')
440 440 query.add_filter('due_date', '=', ['2011-07-10'])
441 441 assert_match /issues\.due_date > '2011-07-09 23:59:59(\.9+)?' AND issues\.due_date <= '2011-07-10 23:59:59(\.9+)?/, query.statement
442 442 find_issues_with_query(query)
443 443 end
444 444
445 445 def test_operator_date_lesser_than
446 446 query = IssueQuery.new(:name => '_')
447 447 query.add_filter('due_date', '<=', ['2011-07-10'])
448 448 assert_match /issues\.due_date <= '2011-07-10 23:59:59(\.9+)?/, query.statement
449 449 find_issues_with_query(query)
450 450 end
451 451
452 def test_operator_date_lesser_than_with_timestamp
453 query = IssueQuery.new(:name => '_')
454 query.add_filter('updated_on', '<=', ['2011-07-10T19:13:52'])
455 assert_match /issues\.updated_on <= '2011-07-10 19:13:52/, query.statement
456 find_issues_with_query(query)
457 end
458
452 459 def test_operator_date_greater_than
453 460 query = IssueQuery.new(:name => '_')
454 461 query.add_filter('due_date', '>=', ['2011-07-10'])
455 462 assert_match /issues\.due_date > '2011-07-09 23:59:59(\.9+)?'/, query.statement
456 463 find_issues_with_query(query)
457 464 end
458 465
466 def test_operator_date_greater_than_with_timestamp
467 query = IssueQuery.new(:name => '_')
468 query.add_filter('updated_on', '>=', ['2011-07-10T19:13:52'])
469 assert_match /issues\.updated_on > '2011-07-10 19:13:51'/, query.statement
470 find_issues_with_query(query)
471 end
472
459 473 def test_operator_date_between
460 474 query = IssueQuery.new(:name => '_')
461 475 query.add_filter('due_date', '><', ['2011-06-23', '2011-07-10'])
462 476 assert_match /issues\.due_date > '2011-06-22 23:59:59(\.9+)?' AND issues\.due_date <= '2011-07-10 23:59:59(\.9+)?'/, query.statement
463 477 find_issues_with_query(query)
464 478 end
465 479
466 480 def test_operator_in_more_than
467 481 Issue.find(7).update_attribute(:due_date, (Date.today + 15))
468 482 query = IssueQuery.new(:project => Project.find(1), :name => '_')
469 483 query.add_filter('due_date', '>t+', ['15'])
470 484 issues = find_issues_with_query(query)
471 485 assert !issues.empty?
472 486 issues.each {|issue| assert(issue.due_date >= (Date.today + 15))}
473 487 end
474 488
475 489 def test_operator_in_less_than
476 490 query = IssueQuery.new(:project => Project.find(1), :name => '_')
477 491 query.add_filter('due_date', '<t+', ['15'])
478 492 issues = find_issues_with_query(query)
479 493 assert !issues.empty?
480 494 issues.each {|issue| assert(issue.due_date <= (Date.today + 15))}
481 495 end
482 496
483 497 def test_operator_in_the_next_days
484 498 query = IssueQuery.new(:project => Project.find(1), :name => '_')
485 499 query.add_filter('due_date', '><t+', ['15'])
486 500 issues = find_issues_with_query(query)
487 501 assert !issues.empty?
488 502 issues.each {|issue| assert(issue.due_date >= Date.today && issue.due_date <= (Date.today + 15))}
489 503 end
490 504
491 505 def test_operator_less_than_ago
492 506 Issue.find(7).update_attribute(:due_date, (Date.today - 3))
493 507 query = IssueQuery.new(:project => Project.find(1), :name => '_')
494 508 query.add_filter('due_date', '>t-', ['3'])
495 509 issues = find_issues_with_query(query)
496 510 assert !issues.empty?
497 511 issues.each {|issue| assert(issue.due_date >= (Date.today - 3))}
498 512 end
499 513
500 514 def test_operator_in_the_past_days
501 515 Issue.find(7).update_attribute(:due_date, (Date.today - 3))
502 516 query = IssueQuery.new(:project => Project.find(1), :name => '_')
503 517 query.add_filter('due_date', '><t-', ['3'])
504 518 issues = find_issues_with_query(query)
505 519 assert !issues.empty?
506 520 issues.each {|issue| assert(issue.due_date >= (Date.today - 3) && issue.due_date <= Date.today)}
507 521 end
508 522
509 523 def test_operator_more_than_ago
510 524 Issue.find(7).update_attribute(:due_date, (Date.today - 10))
511 525 query = IssueQuery.new(:project => Project.find(1), :name => '_')
512 526 query.add_filter('due_date', '<t-', ['10'])
513 527 assert query.statement.include?("#{Issue.table_name}.due_date <=")
514 528 issues = find_issues_with_query(query)
515 529 assert !issues.empty?
516 530 issues.each {|issue| assert(issue.due_date <= (Date.today - 10))}
517 531 end
518 532
519 533 def test_operator_in
520 534 Issue.find(7).update_attribute(:due_date, (Date.today + 2))
521 535 query = IssueQuery.new(:project => Project.find(1), :name => '_')
522 536 query.add_filter('due_date', 't+', ['2'])
523 537 issues = find_issues_with_query(query)
524 538 assert !issues.empty?
525 539 issues.each {|issue| assert_equal((Date.today + 2), issue.due_date)}
526 540 end
527 541
528 542 def test_operator_ago
529 543 Issue.find(7).update_attribute(:due_date, (Date.today - 3))
530 544 query = IssueQuery.new(:project => Project.find(1), :name => '_')
531 545 query.add_filter('due_date', 't-', ['3'])
532 546 issues = find_issues_with_query(query)
533 547 assert !issues.empty?
534 548 issues.each {|issue| assert_equal((Date.today - 3), issue.due_date)}
535 549 end
536 550
537 551 def test_operator_today
538 552 query = IssueQuery.new(:project => Project.find(1), :name => '_')
539 553 query.add_filter('due_date', 't', [''])
540 554 issues = find_issues_with_query(query)
541 555 assert !issues.empty?
542 556 issues.each {|issue| assert_equal Date.today, issue.due_date}
543 557 end
544 558
545 559 def test_operator_this_week_on_date
546 560 query = IssueQuery.new(:project => Project.find(1), :name => '_')
547 561 query.add_filter('due_date', 'w', [''])
548 562 find_issues_with_query(query)
549 563 end
550 564
551 565 def test_operator_this_week_on_datetime
552 566 query = IssueQuery.new(:project => Project.find(1), :name => '_')
553 567 query.add_filter('created_on', 'w', [''])
554 568 find_issues_with_query(query)
555 569 end
556 570
557 571 def test_operator_contains
558 572 query = IssueQuery.new(:project => Project.find(1), :name => '_')
559 573 query.add_filter('subject', '~', ['uNable'])
560 574 assert query.statement.include?("LOWER(#{Issue.table_name}.subject) LIKE '%unable%'")
561 575 result = find_issues_with_query(query)
562 576 assert result.empty?
563 577 result.each {|issue| assert issue.subject.downcase.include?('unable') }
564 578 end
565 579
566 580 def test_range_for_this_week_with_week_starting_on_monday
567 581 I18n.locale = :fr
568 582 assert_equal '1', I18n.t(:general_first_day_of_week)
569 583
570 584 Date.stubs(:today).returns(Date.parse('2011-04-29'))
571 585
572 586 query = IssueQuery.new(:project => Project.find(1), :name => '_')
573 587 query.add_filter('due_date', 'w', [''])
574 588 assert query.statement.match(/issues\.due_date > '2011-04-24 23:59:59(\.9+)?' AND issues\.due_date <= '2011-05-01 23:59:59(\.9+)?/), "range not found in #{query.statement}"
575 589 I18n.locale = :en
576 590 end
577 591
578 592 def test_range_for_this_week_with_week_starting_on_sunday
579 593 I18n.locale = :en
580 594 assert_equal '7', I18n.t(:general_first_day_of_week)
581 595
582 596 Date.stubs(:today).returns(Date.parse('2011-04-29'))
583 597
584 598 query = IssueQuery.new(:project => Project.find(1), :name => '_')
585 599 query.add_filter('due_date', 'w', [''])
586 600 assert query.statement.match(/issues\.due_date > '2011-04-23 23:59:59(\.9+)?' AND issues\.due_date <= '2011-04-30 23:59:59(\.9+)?/), "range not found in #{query.statement}"
587 601 end
588 602
589 603 def test_operator_does_not_contains
590 604 query = IssueQuery.new(:project => Project.find(1), :name => '_')
591 605 query.add_filter('subject', '!~', ['uNable'])
592 606 assert query.statement.include?("LOWER(#{Issue.table_name}.subject) NOT LIKE '%unable%'")
593 607 find_issues_with_query(query)
594 608 end
595 609
596 610 def test_filter_assigned_to_me
597 611 user = User.find(2)
598 612 group = Group.find(10)
599 613 User.current = user
600 614 i1 = Issue.generate!(:project_id => 1, :tracker_id => 1, :assigned_to => user)
601 615 i2 = Issue.generate!(:project_id => 1, :tracker_id => 1, :assigned_to => group)
602 616 i3 = Issue.generate!(:project_id => 1, :tracker_id => 1, :assigned_to => Group.find(11))
603 617 group.users << user
604 618
605 619 query = IssueQuery.new(:name => '_', :filters => { 'assigned_to_id' => {:operator => '=', :values => ['me']}})
606 620 result = query.issues
607 621 assert_equal Issue.visible.where(:assigned_to_id => ([2] + user.reload.group_ids)).sort_by(&:id), result.sort_by(&:id)
608 622
609 623 assert result.include?(i1)
610 624 assert result.include?(i2)
611 625 assert !result.include?(i3)
612 626 end
613 627
614 628 def test_user_custom_field_filtered_on_me
615 629 User.current = User.find(2)
616 630 cf = IssueCustomField.create!(:field_format => 'user', :is_for_all => true, :is_filter => true, :name => 'User custom field', :tracker_ids => [1])
617 631 issue1 = Issue.create!(:project_id => 1, :tracker_id => 1, :custom_field_values => {cf.id.to_s => '2'}, :subject => 'Test', :author_id => 1)
618 632 issue2 = Issue.generate!(:project_id => 1, :tracker_id => 1, :custom_field_values => {cf.id.to_s => '3'})
619 633
620 634 query = IssueQuery.new(:name => '_', :project => Project.find(1))
621 635 filter = query.available_filters["cf_#{cf.id}"]
622 636 assert_not_nil filter
623 637 assert_include 'me', filter[:values].map{|v| v[1]}
624 638
625 639 query.filters = { "cf_#{cf.id}" => {:operator => '=', :values => ['me']}}
626 640 result = query.issues
627 641 assert_equal 1, result.size
628 642 assert_equal issue1, result.first
629 643 end
630 644
631 645 def test_filter_my_projects
632 646 User.current = User.find(2)
633 647 query = IssueQuery.new(:name => '_')
634 648 filter = query.available_filters['project_id']
635 649 assert_not_nil filter
636 650 assert_include 'mine', filter[:values].map{|v| v[1]}
637 651
638 652 query.filters = { 'project_id' => {:operator => '=', :values => ['mine']}}
639 653 result = query.issues
640 654 assert_nil result.detect {|issue| !User.current.member_of?(issue.project)}
641 655 end
642 656
643 657 def test_filter_watched_issues
644 658 User.current = User.find(1)
645 659 query = IssueQuery.new(:name => '_', :filters => { 'watcher_id' => {:operator => '=', :values => ['me']}})
646 660 result = find_issues_with_query(query)
647 661 assert_not_nil result
648 662 assert !result.empty?
649 663 assert_equal Issue.visible.watched_by(User.current).sort_by(&:id), result.sort_by(&:id)
650 664 User.current = nil
651 665 end
652 666
653 667 def test_filter_unwatched_issues
654 668 User.current = User.find(1)
655 669 query = IssueQuery.new(:name => '_', :filters => { 'watcher_id' => {:operator => '!', :values => ['me']}})
656 670 result = find_issues_with_query(query)
657 671 assert_not_nil result
658 672 assert !result.empty?
659 673 assert_equal((Issue.visible - Issue.watched_by(User.current)).sort_by(&:id).size, result.sort_by(&:id).size)
660 674 User.current = nil
661 675 end
662 676
663 677 def test_filter_on_custom_field_should_ignore_projects_with_field_disabled
664 678 field = IssueCustomField.generate!(:trackers => Tracker.all, :project_ids => [1, 3, 4], :is_filter => true)
665 679 Issue.generate!(:project_id => 3, :tracker_id => 2, :custom_field_values => {field.id.to_s => 'Foo'})
666 680 Issue.generate!(:project_id => 4, :tracker_id => 2, :custom_field_values => {field.id.to_s => 'Foo'})
667 681
668 682 query = IssueQuery.new(:name => '_', :project => Project.find(1))
669 683 query.filters = {"cf_#{field.id}" => {:operator => '=', :values => ['Foo']}}
670 684 assert_equal 2, find_issues_with_query(query).size
671 685
672 686 field.project_ids = [1, 3] # Disable the field for project 4
673 687 field.save!
674 688 assert_equal 1, find_issues_with_query(query).size
675 689 end
676 690
677 691 def test_filter_on_custom_field_should_ignore_trackers_with_field_disabled
678 692 field = IssueCustomField.generate!(:tracker_ids => [1, 2], :is_for_all => true, :is_filter => true)
679 693 Issue.generate!(:project_id => 1, :tracker_id => 1, :custom_field_values => {field.id.to_s => 'Foo'})
680 694 Issue.generate!(:project_id => 1, :tracker_id => 2, :custom_field_values => {field.id.to_s => 'Foo'})
681 695
682 696 query = IssueQuery.new(:name => '_', :project => Project.find(1))
683 697 query.filters = {"cf_#{field.id}" => {:operator => '=', :values => ['Foo']}}
684 698 assert_equal 2, find_issues_with_query(query).size
685 699
686 700 field.tracker_ids = [1] # Disable the field for tracker 2
687 701 field.save!
688 702 assert_equal 1, find_issues_with_query(query).size
689 703 end
690 704
691 705 def test_filter_on_project_custom_field
692 706 field = ProjectCustomField.create!(:name => 'Client', :is_filter => true, :field_format => 'string')
693 707 CustomValue.create!(:custom_field => field, :customized => Project.find(3), :value => 'Foo')
694 708 CustomValue.create!(:custom_field => field, :customized => Project.find(5), :value => 'Foo')
695 709
696 710 query = IssueQuery.new(:name => '_')
697 711 filter_name = "project.cf_#{field.id}"
698 712 assert_include filter_name, query.available_filters.keys
699 713 query.filters = {filter_name => {:operator => '=', :values => ['Foo']}}
700 714 assert_equal [3, 5], find_issues_with_query(query).map(&:project_id).uniq.sort
701 715 end
702 716
703 717 def test_filter_on_author_custom_field
704 718 field = UserCustomField.create!(:name => 'Client', :is_filter => true, :field_format => 'string')
705 719 CustomValue.create!(:custom_field => field, :customized => User.find(3), :value => 'Foo')
706 720
707 721 query = IssueQuery.new(:name => '_')
708 722 filter_name = "author.cf_#{field.id}"
709 723 assert_include filter_name, query.available_filters.keys
710 724 query.filters = {filter_name => {:operator => '=', :values => ['Foo']}}
711 725 assert_equal [3], find_issues_with_query(query).map(&:author_id).uniq.sort
712 726 end
713 727
714 728 def test_filter_on_assigned_to_custom_field
715 729 field = UserCustomField.create!(:name => 'Client', :is_filter => true, :field_format => 'string')
716 730 CustomValue.create!(:custom_field => field, :customized => User.find(3), :value => 'Foo')
717 731
718 732 query = IssueQuery.new(:name => '_')
719 733 filter_name = "assigned_to.cf_#{field.id}"
720 734 assert_include filter_name, query.available_filters.keys
721 735 query.filters = {filter_name => {:operator => '=', :values => ['Foo']}}
722 736 assert_equal [3], find_issues_with_query(query).map(&:assigned_to_id).uniq.sort
723 737 end
724 738
725 739 def test_filter_on_fixed_version_custom_field
726 740 field = VersionCustomField.create!(:name => 'Client', :is_filter => true, :field_format => 'string')
727 741 CustomValue.create!(:custom_field => field, :customized => Version.find(2), :value => 'Foo')
728 742
729 743 query = IssueQuery.new(:name => '_')
730 744 filter_name = "fixed_version.cf_#{field.id}"
731 745 assert_include filter_name, query.available_filters.keys
732 746 query.filters = {filter_name => {:operator => '=', :values => ['Foo']}}
733 747 assert_equal [2], find_issues_with_query(query).map(&:fixed_version_id).uniq.sort
734 748 end
735 749
736 750 def test_filter_on_relations_with_a_specific_issue
737 751 IssueRelation.delete_all
738 752 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Issue.find(2))
739 753 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(3), :issue_to => Issue.find(1))
740 754
741 755 query = IssueQuery.new(:name => '_')
742 756 query.filters = {"relates" => {:operator => '=', :values => ['1']}}
743 757 assert_equal [2, 3], find_issues_with_query(query).map(&:id).sort
744 758
745 759 query = IssueQuery.new(:name => '_')
746 760 query.filters = {"relates" => {:operator => '=', :values => ['2']}}
747 761 assert_equal [1], find_issues_with_query(query).map(&:id).sort
748 762 end
749 763
750 764 def test_filter_on_relations_with_any_issues_in_a_project
751 765 IssueRelation.delete_all
752 766 with_settings :cross_project_issue_relations => '1' do
753 767 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Project.find(2).issues.first)
754 768 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(2), :issue_to => Project.find(2).issues.first)
755 769 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Project.find(3).issues.first)
756 770 end
757 771
758 772 query = IssueQuery.new(:name => '_')
759 773 query.filters = {"relates" => {:operator => '=p', :values => ['2']}}
760 774 assert_equal [1, 2], find_issues_with_query(query).map(&:id).sort
761 775
762 776 query = IssueQuery.new(:name => '_')
763 777 query.filters = {"relates" => {:operator => '=p', :values => ['3']}}
764 778 assert_equal [1], find_issues_with_query(query).map(&:id).sort
765 779
766 780 query = IssueQuery.new(:name => '_')
767 781 query.filters = {"relates" => {:operator => '=p', :values => ['4']}}
768 782 assert_equal [], find_issues_with_query(query).map(&:id).sort
769 783 end
770 784
771 785 def test_filter_on_relations_with_any_issues_not_in_a_project
772 786 IssueRelation.delete_all
773 787 with_settings :cross_project_issue_relations => '1' do
774 788 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Project.find(2).issues.first)
775 789 #IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(2), :issue_to => Project.find(1).issues.first)
776 790 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Project.find(3).issues.first)
777 791 end
778 792
779 793 query = IssueQuery.new(:name => '_')
780 794 query.filters = {"relates" => {:operator => '=!p', :values => ['1']}}
781 795 assert_equal [1], find_issues_with_query(query).map(&:id).sort
782 796 end
783 797
784 798 def test_filter_on_relations_with_no_issues_in_a_project
785 799 IssueRelation.delete_all
786 800 with_settings :cross_project_issue_relations => '1' do
787 801 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Project.find(2).issues.first)
788 802 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(2), :issue_to => Project.find(3).issues.first)
789 803 IssueRelation.create!(:relation_type => "relates", :issue_to => Project.find(2).issues.first, :issue_from => Issue.find(3))
790 804 end
791 805
792 806 query = IssueQuery.new(:name => '_')
793 807 query.filters = {"relates" => {:operator => '!p', :values => ['2']}}
794 808 ids = find_issues_with_query(query).map(&:id).sort
795 809 assert_include 2, ids
796 810 assert_not_include 1, ids
797 811 assert_not_include 3, ids
798 812 end
799 813
800 814 def test_filter_on_relations_with_no_issues
801 815 IssueRelation.delete_all
802 816 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Issue.find(2))
803 817 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(3), :issue_to => Issue.find(1))
804 818
805 819 query = IssueQuery.new(:name => '_')
806 820 query.filters = {"relates" => {:operator => '!*', :values => ['']}}
807 821 ids = find_issues_with_query(query).map(&:id)
808 822 assert_equal [], ids & [1, 2, 3]
809 823 assert_include 4, ids
810 824 end
811 825
812 826 def test_filter_on_relations_with_any_issues
813 827 IssueRelation.delete_all
814 828 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Issue.find(2))
815 829 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(3), :issue_to => Issue.find(1))
816 830
817 831 query = IssueQuery.new(:name => '_')
818 832 query.filters = {"relates" => {:operator => '*', :values => ['']}}
819 833 assert_equal [1, 2, 3], find_issues_with_query(query).map(&:id).sort
820 834 end
821 835
822 836 def test_filter_on_relations_should_not_ignore_other_filter
823 837 issue = Issue.generate!
824 838 issue1 = Issue.generate!(:status_id => 1)
825 839 issue2 = Issue.generate!(:status_id => 2)
826 840 IssueRelation.create!(:relation_type => "relates", :issue_from => issue, :issue_to => issue1)
827 841 IssueRelation.create!(:relation_type => "relates", :issue_from => issue, :issue_to => issue2)
828 842
829 843 query = IssueQuery.new(:name => '_')
830 844 query.filters = {
831 845 "status_id" => {:operator => '=', :values => ['1']},
832 846 "relates" => {:operator => '=', :values => [issue.id.to_s]}
833 847 }
834 848 assert_equal [issue1], find_issues_with_query(query)
835 849 end
836 850
837 851 def test_statement_should_be_nil_with_no_filters
838 852 q = IssueQuery.new(:name => '_')
839 853 q.filters = {}
840 854
841 855 assert q.valid?
842 856 assert_nil q.statement
843 857 end
844 858
845 859 def test_default_columns
846 860 q = IssueQuery.new
847 861 assert q.columns.any?
848 862 assert q.inline_columns.any?
849 863 assert q.block_columns.empty?
850 864 end
851 865
852 866 def test_set_column_names
853 867 q = IssueQuery.new
854 868 q.column_names = ['tracker', :subject, '', 'unknonw_column']
855 869 assert_equal [:id, :tracker, :subject], q.columns.collect {|c| c.name}
856 870 end
857 871
858 872 def test_has_column_should_accept_a_column_name
859 873 q = IssueQuery.new
860 874 q.column_names = ['tracker', :subject]
861 875 assert q.has_column?(:tracker)
862 876 assert !q.has_column?(:category)
863 877 end
864 878
865 879 def test_has_column_should_accept_a_column
866 880 q = IssueQuery.new
867 881 q.column_names = ['tracker', :subject]
868 882
869 883 tracker_column = q.available_columns.detect {|c| c.name==:tracker}
870 884 assert_kind_of QueryColumn, tracker_column
871 885 category_column = q.available_columns.detect {|c| c.name==:category}
872 886 assert_kind_of QueryColumn, category_column
873 887
874 888 assert q.has_column?(tracker_column)
875 889 assert !q.has_column?(category_column)
876 890 end
877 891
878 892 def test_inline_and_block_columns
879 893 q = IssueQuery.new
880 894 q.column_names = ['subject', 'description', 'tracker']
881 895
882 896 assert_equal [:id, :subject, :tracker], q.inline_columns.map(&:name)
883 897 assert_equal [:description], q.block_columns.map(&:name)
884 898 end
885 899
886 900 def test_custom_field_columns_should_be_inline
887 901 q = IssueQuery.new
888 902 columns = q.available_columns.select {|column| column.is_a? QueryCustomFieldColumn}
889 903 assert columns.any?
890 904 assert_nil columns.detect {|column| !column.inline?}
891 905 end
892 906
893 907 def test_query_should_preload_spent_hours
894 908 q = IssueQuery.new(:name => '_', :column_names => [:subject, :spent_hours])
895 909 assert q.has_column?(:spent_hours)
896 910 issues = q.issues
897 911 assert_not_nil issues.first.instance_variable_get("@spent_hours")
898 912 end
899 913
900 914 def test_groupable_columns_should_include_custom_fields
901 915 q = IssueQuery.new
902 916 column = q.groupable_columns.detect {|c| c.name == :cf_1}
903 917 assert_not_nil column
904 918 assert_kind_of QueryCustomFieldColumn, column
905 919 end
906 920
907 921 def test_groupable_columns_should_not_include_multi_custom_fields
908 922 field = CustomField.find(1)
909 923 field.update_attribute :multiple, true
910 924
911 925 q = IssueQuery.new
912 926 column = q.groupable_columns.detect {|c| c.name == :cf_1}
913 927 assert_nil column
914 928 end
915 929
916 930 def test_groupable_columns_should_include_user_custom_fields
917 931 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1], :field_format => 'user')
918 932
919 933 q = IssueQuery.new
920 934 assert q.groupable_columns.detect {|c| c.name == "cf_#{cf.id}".to_sym}
921 935 end
922 936
923 937 def test_groupable_columns_should_include_version_custom_fields
924 938 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1], :field_format => 'version')
925 939
926 940 q = IssueQuery.new
927 941 assert q.groupable_columns.detect {|c| c.name == "cf_#{cf.id}".to_sym}
928 942 end
929 943
930 944 def test_grouped_with_valid_column
931 945 q = IssueQuery.new(:group_by => 'status')
932 946 assert q.grouped?
933 947 assert_not_nil q.group_by_column
934 948 assert_equal :status, q.group_by_column.name
935 949 assert_not_nil q.group_by_statement
936 950 assert_equal 'status', q.group_by_statement
937 951 end
938 952
939 953 def test_grouped_with_invalid_column
940 954 q = IssueQuery.new(:group_by => 'foo')
941 955 assert !q.grouped?
942 956 assert_nil q.group_by_column
943 957 assert_nil q.group_by_statement
944 958 end
945 959
946 960 def test_sortable_columns_should_sort_assignees_according_to_user_format_setting
947 961 with_settings :user_format => 'lastname_coma_firstname' do
948 962 q = IssueQuery.new
949 963 assert q.sortable_columns.has_key?('assigned_to')
950 964 assert_equal %w(users.lastname users.firstname users.id), q.sortable_columns['assigned_to']
951 965 end
952 966 end
953 967
954 968 def test_sortable_columns_should_sort_authors_according_to_user_format_setting
955 969 with_settings :user_format => 'lastname_coma_firstname' do
956 970 q = IssueQuery.new
957 971 assert q.sortable_columns.has_key?('author')
958 972 assert_equal %w(authors.lastname authors.firstname authors.id), q.sortable_columns['author']
959 973 end
960 974 end
961 975
962 976 def test_sortable_columns_should_include_custom_field
963 977 q = IssueQuery.new
964 978 assert q.sortable_columns['cf_1']
965 979 end
966 980
967 981 def test_sortable_columns_should_not_include_multi_custom_field
968 982 field = CustomField.find(1)
969 983 field.update_attribute :multiple, true
970 984
971 985 q = IssueQuery.new
972 986 assert !q.sortable_columns['cf_1']
973 987 end
974 988
975 989 def test_default_sort
976 990 q = IssueQuery.new
977 991 assert_equal [], q.sort_criteria
978 992 end
979 993
980 994 def test_set_sort_criteria_with_hash
981 995 q = IssueQuery.new
982 996 q.sort_criteria = {'0' => ['priority', 'desc'], '2' => ['tracker']}
983 997 assert_equal [['priority', 'desc'], ['tracker', 'asc']], q.sort_criteria
984 998 end
985 999
986 1000 def test_set_sort_criteria_with_array
987 1001 q = IssueQuery.new
988 1002 q.sort_criteria = [['priority', 'desc'], 'tracker']
989 1003 assert_equal [['priority', 'desc'], ['tracker', 'asc']], q.sort_criteria
990 1004 end
991 1005
992 1006 def test_create_query_with_sort
993 1007 q = IssueQuery.new(:name => 'Sorted')
994 1008 q.sort_criteria = [['priority', 'desc'], 'tracker']
995 1009 assert q.save
996 1010 q.reload
997 1011 assert_equal [['priority', 'desc'], ['tracker', 'asc']], q.sort_criteria
998 1012 end
999 1013
1000 1014 def test_sort_by_string_custom_field_asc
1001 1015 q = IssueQuery.new
1002 1016 c = q.available_columns.find {|col| col.is_a?(QueryCustomFieldColumn) && col.custom_field.field_format == 'string' }
1003 1017 assert c
1004 1018 assert c.sortable
1005 1019 issues = q.issues(:order => "#{c.sortable} ASC")
1006 1020 values = issues.collect {|i| i.custom_value_for(c.custom_field).to_s}
1007 1021 assert !values.empty?
1008 1022 assert_equal values.sort, values
1009 1023 end
1010 1024
1011 1025 def test_sort_by_string_custom_field_desc
1012 1026 q = IssueQuery.new
1013 1027 c = q.available_columns.find {|col| col.is_a?(QueryCustomFieldColumn) && col.custom_field.field_format == 'string' }
1014 1028 assert c
1015 1029 assert c.sortable
1016 1030 issues = q.issues(:order => "#{c.sortable} DESC")
1017 1031 values = issues.collect {|i| i.custom_value_for(c.custom_field).to_s}
1018 1032 assert !values.empty?
1019 1033 assert_equal values.sort.reverse, values
1020 1034 end
1021 1035
1022 1036 def test_sort_by_float_custom_field_asc
1023 1037 q = IssueQuery.new
1024 1038 c = q.available_columns.find {|col| col.is_a?(QueryCustomFieldColumn) && col.custom_field.field_format == 'float' }
1025 1039 assert c
1026 1040 assert c.sortable
1027 1041 issues = q.issues(:order => "#{c.sortable} ASC")
1028 1042 values = issues.collect {|i| begin; Kernel.Float(i.custom_value_for(c.custom_field).to_s); rescue; nil; end}.compact
1029 1043 assert !values.empty?
1030 1044 assert_equal values.sort, values
1031 1045 end
1032 1046
1033 1047 def test_invalid_query_should_raise_query_statement_invalid_error
1034 1048 q = IssueQuery.new
1035 1049 assert_raise Query::StatementInvalid do
1036 1050 q.issues(:conditions => "foo = 1")
1037 1051 end
1038 1052 end
1039 1053
1040 1054 def test_issue_count
1041 1055 q = IssueQuery.new(:name => '_')
1042 1056 issue_count = q.issue_count
1043 1057 assert_equal q.issues.size, issue_count
1044 1058 end
1045 1059
1046 1060 def test_issue_count_with_archived_issues
1047 1061 p = Project.generate! do |project|
1048 1062 project.status = Project::STATUS_ARCHIVED
1049 1063 end
1050 1064 i = Issue.generate!( :project => p, :tracker => p.trackers.first )
1051 1065 assert !i.visible?
1052 1066
1053 1067 test_issue_count
1054 1068 end
1055 1069
1056 1070 def test_issue_count_by_association_group
1057 1071 q = IssueQuery.new(:name => '_', :group_by => 'assigned_to')
1058 1072 count_by_group = q.issue_count_by_group
1059 1073 assert_kind_of Hash, count_by_group
1060 1074 assert_equal %w(NilClass User), count_by_group.keys.collect {|k| k.class.name}.uniq.sort
1061 1075 assert_equal %w(Fixnum), count_by_group.values.collect {|k| k.class.name}.uniq
1062 1076 assert count_by_group.has_key?(User.find(3))
1063 1077 end
1064 1078
1065 1079 def test_issue_count_by_list_custom_field_group
1066 1080 q = IssueQuery.new(:name => '_', :group_by => 'cf_1')
1067 1081 count_by_group = q.issue_count_by_group
1068 1082 assert_kind_of Hash, count_by_group
1069 1083 assert_equal %w(NilClass String), count_by_group.keys.collect {|k| k.class.name}.uniq.sort
1070 1084 assert_equal %w(Fixnum), count_by_group.values.collect {|k| k.class.name}.uniq
1071 1085 assert count_by_group.has_key?('MySQL')
1072 1086 end
1073 1087
1074 1088 def test_issue_count_by_date_custom_field_group
1075 1089 q = IssueQuery.new(:name => '_', :group_by => 'cf_8')
1076 1090 count_by_group = q.issue_count_by_group
1077 1091 assert_kind_of Hash, count_by_group
1078 1092 assert_equal %w(Date NilClass), count_by_group.keys.collect {|k| k.class.name}.uniq.sort
1079 1093 assert_equal %w(Fixnum), count_by_group.values.collect {|k| k.class.name}.uniq
1080 1094 end
1081 1095
1082 1096 def test_issue_count_with_nil_group_only
1083 1097 Issue.update_all("assigned_to_id = NULL")
1084 1098
1085 1099 q = IssueQuery.new(:name => '_', :group_by => 'assigned_to')
1086 1100 count_by_group = q.issue_count_by_group
1087 1101 assert_kind_of Hash, count_by_group
1088 1102 assert_equal 1, count_by_group.keys.size
1089 1103 assert_nil count_by_group.keys.first
1090 1104 end
1091 1105
1092 1106 def test_issue_ids
1093 1107 q = IssueQuery.new(:name => '_')
1094 1108 order = "issues.subject, issues.id"
1095 1109 issues = q.issues(:order => order)
1096 1110 assert_equal issues.map(&:id), q.issue_ids(:order => order)
1097 1111 end
1098 1112
1099 1113 def test_label_for
1100 1114 set_language_if_valid 'en'
1101 1115 q = IssueQuery.new
1102 1116 assert_equal 'Assignee', q.label_for('assigned_to_id')
1103 1117 end
1104 1118
1105 1119 def test_label_for_fr
1106 1120 set_language_if_valid 'fr'
1107 1121 q = IssueQuery.new
1108 1122 s = "Assign\xc3\xa9 \xc3\xa0"
1109 1123 s.force_encoding('UTF-8') if s.respond_to?(:force_encoding)
1110 1124 assert_equal s, q.label_for('assigned_to_id')
1111 1125 end
1112 1126
1113 1127 def test_editable_by
1114 1128 admin = User.find(1)
1115 1129 manager = User.find(2)
1116 1130 developer = User.find(3)
1117 1131
1118 1132 # Public query on project 1
1119 1133 q = IssueQuery.find(1)
1120 1134 assert q.editable_by?(admin)
1121 1135 assert q.editable_by?(manager)
1122 1136 assert !q.editable_by?(developer)
1123 1137
1124 1138 # Private query on project 1
1125 1139 q = IssueQuery.find(2)
1126 1140 assert q.editable_by?(admin)
1127 1141 assert !q.editable_by?(manager)
1128 1142 assert q.editable_by?(developer)
1129 1143
1130 1144 # Private query for all projects
1131 1145 q = IssueQuery.find(3)
1132 1146 assert q.editable_by?(admin)
1133 1147 assert !q.editable_by?(manager)
1134 1148 assert q.editable_by?(developer)
1135 1149
1136 1150 # Public query for all projects
1137 1151 q = IssueQuery.find(4)
1138 1152 assert q.editable_by?(admin)
1139 1153 assert !q.editable_by?(manager)
1140 1154 assert !q.editable_by?(developer)
1141 1155 end
1142 1156
1143 1157 def test_visible_scope
1144 1158 query_ids = IssueQuery.visible(User.anonymous).map(&:id)
1145 1159
1146 1160 assert query_ids.include?(1), 'public query on public project was not visible'
1147 1161 assert query_ids.include?(4), 'public query for all projects was not visible'
1148 1162 assert !query_ids.include?(2), 'private query on public project was visible'
1149 1163 assert !query_ids.include?(3), 'private query for all projects was visible'
1150 1164 assert !query_ids.include?(7), 'public query on private project was visible'
1151 1165 end
1152 1166
1153 1167 def test_query_with_public_visibility_should_be_visible_to_anyone
1154 1168 q = IssueQuery.create!(:name => 'Query', :visibility => IssueQuery::VISIBILITY_PUBLIC)
1155 1169
1156 1170 assert q.visible?(User.anonymous)
1157 1171 assert IssueQuery.visible(User.anonymous).find_by_id(q.id)
1158 1172
1159 1173 assert q.visible?(User.find(7))
1160 1174 assert IssueQuery.visible(User.find(7)).find_by_id(q.id)
1161 1175
1162 1176 assert q.visible?(User.find(2))
1163 1177 assert IssueQuery.visible(User.find(2)).find_by_id(q.id)
1164 1178
1165 1179 assert q.visible?(User.find(1))
1166 1180 assert IssueQuery.visible(User.find(1)).find_by_id(q.id)
1167 1181 end
1168 1182
1169 1183 def test_query_with_roles_visibility_should_be_visible_to_user_with_role
1170 1184 q = IssueQuery.create!(:name => 'Query', :visibility => IssueQuery::VISIBILITY_ROLES, :role_ids => [1,2])
1171 1185
1172 1186 assert !q.visible?(User.anonymous)
1173 1187 assert_nil IssueQuery.visible(User.anonymous).find_by_id(q.id)
1174 1188
1175 1189 assert !q.visible?(User.find(7))
1176 1190 assert_nil IssueQuery.visible(User.find(7)).find_by_id(q.id)
1177 1191
1178 1192 assert q.visible?(User.find(2))
1179 1193 assert IssueQuery.visible(User.find(2)).find_by_id(q.id)
1180 1194
1181 1195 assert q.visible?(User.find(1))
1182 1196 assert IssueQuery.visible(User.find(1)).find_by_id(q.id)
1183 1197 end
1184 1198
1185 1199 def test_query_with_private_visibility_should_be_visible_to_owner
1186 1200 q = IssueQuery.create!(:name => 'Query', :visibility => IssueQuery::VISIBILITY_PRIVATE, :user => User.find(7))
1187 1201
1188 1202 assert !q.visible?(User.anonymous)
1189 1203 assert_nil IssueQuery.visible(User.anonymous).find_by_id(q.id)
1190 1204
1191 1205 assert q.visible?(User.find(7))
1192 1206 assert IssueQuery.visible(User.find(7)).find_by_id(q.id)
1193 1207
1194 1208 assert !q.visible?(User.find(2))
1195 1209 assert_nil IssueQuery.visible(User.find(2)).find_by_id(q.id)
1196 1210
1197 1211 assert q.visible?(User.find(1))
1198 1212 assert_nil IssueQuery.visible(User.find(1)).find_by_id(q.id)
1199 1213 end
1200 1214
1201 1215 test "#available_filters should include users of visible projects in cross-project view" do
1202 1216 users = IssueQuery.new.available_filters["assigned_to_id"]
1203 1217 assert_not_nil users
1204 1218 assert users[:values].map{|u|u[1]}.include?("3")
1205 1219 end
1206 1220
1207 1221 test "#available_filters should include users of subprojects" do
1208 1222 user1 = User.generate!
1209 1223 user2 = User.generate!
1210 1224 project = Project.find(1)
1211 1225 Member.create!(:principal => user1, :project => project.children.visible.first, :role_ids => [1])
1212 1226
1213 1227 users = IssueQuery.new(:project => project).available_filters["assigned_to_id"]
1214 1228 assert_not_nil users
1215 1229 assert users[:values].map{|u|u[1]}.include?(user1.id.to_s)
1216 1230 assert !users[:values].map{|u|u[1]}.include?(user2.id.to_s)
1217 1231 end
1218 1232
1219 1233 test "#available_filters should include visible projects in cross-project view" do
1220 1234 projects = IssueQuery.new.available_filters["project_id"]
1221 1235 assert_not_nil projects
1222 1236 assert projects[:values].map{|u|u[1]}.include?("1")
1223 1237 end
1224 1238
1225 1239 test "#available_filters should include 'member_of_group' filter" do
1226 1240 query = IssueQuery.new
1227 1241 assert query.available_filters.keys.include?("member_of_group")
1228 1242 assert_equal :list_optional, query.available_filters["member_of_group"][:type]
1229 1243 assert query.available_filters["member_of_group"][:values].present?
1230 1244 assert_equal Group.all.sort.map {|g| [g.name, g.id.to_s]},
1231 1245 query.available_filters["member_of_group"][:values].sort
1232 1246 end
1233 1247
1234 1248 test "#available_filters should include 'assigned_to_role' filter" do
1235 1249 query = IssueQuery.new
1236 1250 assert query.available_filters.keys.include?("assigned_to_role")
1237 1251 assert_equal :list_optional, query.available_filters["assigned_to_role"][:type]
1238 1252
1239 1253 assert query.available_filters["assigned_to_role"][:values].include?(['Manager','1'])
1240 1254 assert query.available_filters["assigned_to_role"][:values].include?(['Developer','2'])
1241 1255 assert query.available_filters["assigned_to_role"][:values].include?(['Reporter','3'])
1242 1256
1243 1257 assert ! query.available_filters["assigned_to_role"][:values].include?(['Non member','4'])
1244 1258 assert ! query.available_filters["assigned_to_role"][:values].include?(['Anonymous','5'])
1245 1259 end
1246 1260
1247 1261 def test_available_filters_should_include_custom_field_according_to_user_visibility
1248 1262 visible_field = IssueCustomField.generate!(:is_for_all => true, :is_filter => true, :visible => true)
1249 1263 hidden_field = IssueCustomField.generate!(:is_for_all => true, :is_filter => true, :visible => false, :role_ids => [1])
1250 1264
1251 1265 with_current_user User.find(3) do
1252 1266 query = IssueQuery.new
1253 1267 assert_include "cf_#{visible_field.id}", query.available_filters.keys
1254 1268 assert_not_include "cf_#{hidden_field.id}", query.available_filters.keys
1255 1269 end
1256 1270 end
1257 1271
1258 1272 def test_available_columns_should_include_custom_field_according_to_user_visibility
1259 1273 visible_field = IssueCustomField.generate!(:is_for_all => true, :is_filter => true, :visible => true)
1260 1274 hidden_field = IssueCustomField.generate!(:is_for_all => true, :is_filter => true, :visible => false, :role_ids => [1])
1261 1275
1262 1276 with_current_user User.find(3) do
1263 1277 query = IssueQuery.new
1264 1278 assert_include :"cf_#{visible_field.id}", query.available_columns.map(&:name)
1265 1279 assert_not_include :"cf_#{hidden_field.id}", query.available_columns.map(&:name)
1266 1280 end
1267 1281 end
1268 1282
1269 1283 context "#statement" do
1270 1284 context "with 'member_of_group' filter" do
1271 1285 setup do
1272 1286 Group.destroy_all # No fixtures
1273 1287 @user_in_group = User.generate!
1274 1288 @second_user_in_group = User.generate!
1275 1289 @user_in_group2 = User.generate!
1276 1290 @user_not_in_group = User.generate!
1277 1291
1278 1292 @group = Group.generate!.reload
1279 1293 @group.users << @user_in_group
1280 1294 @group.users << @second_user_in_group
1281 1295
1282 1296 @group2 = Group.generate!.reload
1283 1297 @group2.users << @user_in_group2
1284 1298
1285 1299 end
1286 1300
1287 1301 should "search assigned to for users in the group" do
1288 1302 @query = IssueQuery.new(:name => '_')
1289 1303 @query.add_filter('member_of_group', '=', [@group.id.to_s])
1290 1304
1291 1305 assert_query_statement_includes @query, "#{Issue.table_name}.assigned_to_id IN ('#{@user_in_group.id}','#{@second_user_in_group.id}','#{@group.id}')"
1292 1306 assert_find_issues_with_query_is_successful @query
1293 1307 end
1294 1308
1295 1309 should "search not assigned to any group member (none)" do
1296 1310 @query = IssueQuery.new(:name => '_')
1297 1311 @query.add_filter('member_of_group', '!*', [''])
1298 1312
1299 1313 # Users not in a group
1300 1314 assert_query_statement_includes @query, "#{Issue.table_name}.assigned_to_id IS NULL OR #{Issue.table_name}.assigned_to_id NOT IN ('#{@user_in_group.id}','#{@second_user_in_group.id}','#{@user_in_group2.id}','#{@group.id}','#{@group2.id}')"
1301 1315 assert_find_issues_with_query_is_successful @query
1302 1316 end
1303 1317
1304 1318 should "search assigned to any group member (all)" do
1305 1319 @query = IssueQuery.new(:name => '_')
1306 1320 @query.add_filter('member_of_group', '*', [''])
1307 1321
1308 1322 # Only users in a group
1309 1323 assert_query_statement_includes @query, "#{Issue.table_name}.assigned_to_id IN ('#{@user_in_group.id}','#{@second_user_in_group.id}','#{@user_in_group2.id}','#{@group.id}','#{@group2.id}')"
1310 1324 assert_find_issues_with_query_is_successful @query
1311 1325 end
1312 1326
1313 1327 should "return an empty set with = empty group" do
1314 1328 @empty_group = Group.generate!
1315 1329 @query = IssueQuery.new(:name => '_')
1316 1330 @query.add_filter('member_of_group', '=', [@empty_group.id.to_s])
1317 1331
1318 1332 assert_equal [], find_issues_with_query(@query)
1319 1333 end
1320 1334
1321 1335 should "return issues with ! empty group" do
1322 1336 @empty_group = Group.generate!
1323 1337 @query = IssueQuery.new(:name => '_')
1324 1338 @query.add_filter('member_of_group', '!', [@empty_group.id.to_s])
1325 1339
1326 1340 assert_find_issues_with_query_is_successful @query
1327 1341 end
1328 1342 end
1329 1343
1330 1344 context "with 'assigned_to_role' filter" do
1331 1345 setup do
1332 1346 @manager_role = Role.find_by_name('Manager')
1333 1347 @developer_role = Role.find_by_name('Developer')
1334 1348
1335 1349 @project = Project.generate!
1336 1350 @manager = User.generate!
1337 1351 @developer = User.generate!
1338 1352 @boss = User.generate!
1339 1353 @guest = User.generate!
1340 1354 User.add_to_project(@manager, @project, @manager_role)
1341 1355 User.add_to_project(@developer, @project, @developer_role)
1342 1356 User.add_to_project(@boss, @project, [@manager_role, @developer_role])
1343 1357
1344 1358 @issue1 = Issue.generate!(:project => @project, :assigned_to_id => @manager.id)
1345 1359 @issue2 = Issue.generate!(:project => @project, :assigned_to_id => @developer.id)
1346 1360 @issue3 = Issue.generate!(:project => @project, :assigned_to_id => @boss.id)
1347 1361 @issue4 = Issue.generate!(:project => @project, :assigned_to_id => @guest.id)
1348 1362 @issue5 = Issue.generate!(:project => @project)
1349 1363 end
1350 1364
1351 1365 should "search assigned to for users with the Role" do
1352 1366 @query = IssueQuery.new(:name => '_', :project => @project)
1353 1367 @query.add_filter('assigned_to_role', '=', [@manager_role.id.to_s])
1354 1368
1355 1369 assert_query_result [@issue1, @issue3], @query
1356 1370 end
1357 1371
1358 1372 should "search assigned to for users with the Role on the issue project" do
1359 1373 other_project = Project.generate!
1360 1374 User.add_to_project(@developer, other_project, @manager_role)
1361 1375
1362 1376 @query = IssueQuery.new(:name => '_', :project => @project)
1363 1377 @query.add_filter('assigned_to_role', '=', [@manager_role.id.to_s])
1364 1378
1365 1379 assert_query_result [@issue1, @issue3], @query
1366 1380 end
1367 1381
1368 1382 should "return an empty set with empty role" do
1369 1383 @empty_role = Role.generate!
1370 1384 @query = IssueQuery.new(:name => '_', :project => @project)
1371 1385 @query.add_filter('assigned_to_role', '=', [@empty_role.id.to_s])
1372 1386
1373 1387 assert_query_result [], @query
1374 1388 end
1375 1389
1376 1390 should "search assigned to for users without the Role" do
1377 1391 @query = IssueQuery.new(:name => '_', :project => @project)
1378 1392 @query.add_filter('assigned_to_role', '!', [@manager_role.id.to_s])
1379 1393
1380 1394 assert_query_result [@issue2, @issue4, @issue5], @query
1381 1395 end
1382 1396
1383 1397 should "search assigned to for users not assigned to any Role (none)" do
1384 1398 @query = IssueQuery.new(:name => '_', :project => @project)
1385 1399 @query.add_filter('assigned_to_role', '!*', [''])
1386 1400
1387 1401 assert_query_result [@issue4, @issue5], @query
1388 1402 end
1389 1403
1390 1404 should "search assigned to for users assigned to any Role (all)" do
1391 1405 @query = IssueQuery.new(:name => '_', :project => @project)
1392 1406 @query.add_filter('assigned_to_role', '*', [''])
1393 1407
1394 1408 assert_query_result [@issue1, @issue2, @issue3], @query
1395 1409 end
1396 1410
1397 1411 should "return issues with ! empty role" do
1398 1412 @empty_role = Role.generate!
1399 1413 @query = IssueQuery.new(:name => '_', :project => @project)
1400 1414 @query.add_filter('assigned_to_role', '!', [@empty_role.id.to_s])
1401 1415
1402 1416 assert_query_result [@issue1, @issue2, @issue3, @issue4, @issue5], @query
1403 1417 end
1404 1418 end
1405 1419 end
1406 1420 end
General Comments 0
You need to be logged in to leave comments. Login now