##// END OF EJS Templates
jro_apps » redmine
RSS
code layout clean up of test_create_with_group_assignment at test/unit/issue_test.rb...
Toshi MARUYAMA -
r7357:3a7c4a0417ec
parent child
Show More
Side by Side Unified
Context file:
r7357:3a7c4a0417ec Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,1093 +1,1095
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssueTest < ActiveSupport::TestCase
21 21 fixtures :projects, :users, :members, :member_roles, :roles,
22 22 :trackers, :projects_trackers,
23 23 :enabled_modules,
24 24 :versions,
25 25 :issue_statuses, :issue_categories, :issue_relations, :workflows,
26 26 :enumerations,
27 27 :issues,
28 28 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
29 29 :time_entries
30 30
31 31 def test_create
32 32 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
33 33 :status_id => 1, :priority => IssuePriority.all.first,
34 34 :subject => 'test_create',
35 35 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
36 36 assert issue.save
37 37 issue.reload
38 38 assert_equal 1.5, issue.estimated_hours
39 39 end
40 40
41 41 def test_create_minimal
42 42 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
43 43 :status_id => 1, :priority => IssuePriority.all.first,
44 44 :subject => 'test_create')
45 45 assert issue.save
46 46 assert issue.description.nil?
47 47 end
48 48
49 49 def test_create_with_required_custom_field
50 50 field = IssueCustomField.find_by_name('Database')
51 51 field.update_attribute(:is_required, true)
52 52
53 53 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
54 54 :status_id => 1, :subject => 'test_create',
55 55 :description => 'IssueTest#test_create_with_required_custom_field')
56 56 assert issue.available_custom_fields.include?(field)
57 57 # No value for the custom field
58 58 assert !issue.save
59 59 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
60 60 # Blank value
61 61 issue.custom_field_values = { field.id => '' }
62 62 assert !issue.save
63 63 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
64 64 # Invalid value
65 65 issue.custom_field_values = { field.id => 'SQLServer' }
66 66 assert !issue.save
67 67 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
68 68 # Valid value
69 69 issue.custom_field_values = { field.id => 'PostgreSQL' }
70 70 assert issue.save
71 71 issue.reload
72 72 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
73 73 end
74 74
75 75 def test_create_with_group_assignment
76 76 with_settings :issue_group_assignment => '1' do
77 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1, :subject => 'Group assignment', :assigned_to_id => 11).save
77 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
78 :subject => 'Group assignment',
79 :assigned_to_id => 11).save
78 80 issue = Issue.first(:order => 'id DESC')
79 81 assert_kind_of Group, issue.assigned_to
80 82 assert_equal Group.find(11), issue.assigned_to
81 83 end
82 84 end
83 85
84 86 def assert_visibility_match(user, issues)
85 87 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
86 88 end
87 89
88 90 def test_visible_scope_for_anonymous
89 91 # Anonymous user should see issues of public projects only
90 92 issues = Issue.visible(User.anonymous).all
91 93 assert issues.any?
92 94 assert_nil issues.detect {|issue| !issue.project.is_public?}
93 95 assert_nil issues.detect {|issue| issue.is_private?}
94 96 assert_visibility_match User.anonymous, issues
95 97 end
96 98
97 99 def test_visible_scope_for_anonymous_with_own_issues_visibility
98 100 Role.anonymous.update_attribute :issues_visibility, 'own'
99 101 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => User.anonymous.id, :subject => 'Issue by anonymous')
100 102
101 103 issues = Issue.visible(User.anonymous).all
102 104 assert issues.any?
103 105 assert_nil issues.detect {|issue| issue.author != User.anonymous}
104 106 assert_visibility_match User.anonymous, issues
105 107 end
106 108
107 109 def test_visible_scope_for_anonymous_without_view_issues_permissions
108 110 # Anonymous user should not see issues without permission
109 111 Role.anonymous.remove_permission!(:view_issues)
110 112 issues = Issue.visible(User.anonymous).all
111 113 assert issues.empty?
112 114 assert_visibility_match User.anonymous, issues
113 115 end
114 116
115 117 def test_visible_scope_for_non_member
116 118 user = User.find(9)
117 119 assert user.projects.empty?
118 120 # Non member user should see issues of public projects only
119 121 issues = Issue.visible(user).all
120 122 assert issues.any?
121 123 assert_nil issues.detect {|issue| !issue.project.is_public?}
122 124 assert_nil issues.detect {|issue| issue.is_private?}
123 125 assert_visibility_match user, issues
124 126 end
125 127
126 128 def test_visible_scope_for_non_member_with_own_issues_visibility
127 129 Role.non_member.update_attribute :issues_visibility, 'own'
128 130 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
129 131 user = User.find(9)
130 132
131 133 issues = Issue.visible(user).all
132 134 assert issues.any?
133 135 assert_nil issues.detect {|issue| issue.author != user}
134 136 assert_visibility_match user, issues
135 137 end
136 138
137 139 def test_visible_scope_for_non_member_without_view_issues_permissions
138 140 # Non member user should not see issues without permission
139 141 Role.non_member.remove_permission!(:view_issues)
140 142 user = User.find(9)
141 143 assert user.projects.empty?
142 144 issues = Issue.visible(user).all
143 145 assert issues.empty?
144 146 assert_visibility_match user, issues
145 147 end
146 148
147 149 def test_visible_scope_for_member
148 150 user = User.find(9)
149 151 # User should see issues of projects for which he has view_issues permissions only
150 152 Role.non_member.remove_permission!(:view_issues)
151 153 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
152 154 issues = Issue.visible(user).all
153 155 assert issues.any?
154 156 assert_nil issues.detect {|issue| issue.project_id != 3}
155 157 assert_nil issues.detect {|issue| issue.is_private?}
156 158 assert_visibility_match user, issues
157 159 end
158 160
159 161 def test_visible_scope_for_admin
160 162 user = User.find(1)
161 163 user.members.each(&:destroy)
162 164 assert user.projects.empty?
163 165 issues = Issue.visible(user).all
164 166 assert issues.any?
165 167 # Admin should see issues on private projects that he does not belong to
166 168 assert issues.detect {|issue| !issue.project.is_public?}
167 169 # Admin should see private issues of other users
168 170 assert issues.detect {|issue| issue.is_private? && issue.author != user}
169 171 assert_visibility_match user, issues
170 172 end
171 173
172 174 def test_visible_scope_with_project
173 175 project = Project.find(1)
174 176 issues = Issue.visible(User.find(2), :project => project).all
175 177 projects = issues.collect(&:project).uniq
176 178 assert_equal 1, projects.size
177 179 assert_equal project, projects.first
178 180 end
179 181
180 182 def test_visible_scope_with_project_and_subprojects
181 183 project = Project.find(1)
182 184 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
183 185 projects = issues.collect(&:project).uniq
184 186 assert projects.size > 1
185 187 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
186 188 end
187 189
188 190 def test_visible_and_nested_set_scopes
189 191 assert_equal 0, Issue.find(1).descendants.visible.all.size
190 192 end
191 193
192 194 def test_errors_full_messages_should_include_custom_fields_errors
193 195 field = IssueCustomField.find_by_name('Database')
194 196
195 197 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
196 198 :status_id => 1, :subject => 'test_create',
197 199 :description => 'IssueTest#test_create_with_required_custom_field')
198 200 assert issue.available_custom_fields.include?(field)
199 201 # Invalid value
200 202 issue.custom_field_values = { field.id => 'SQLServer' }
201 203
202 204 assert !issue.valid?
203 205 assert_equal 1, issue.errors.full_messages.size
204 206 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}", issue.errors.full_messages.first
205 207 end
206 208
207 209 def test_update_issue_with_required_custom_field
208 210 field = IssueCustomField.find_by_name('Database')
209 211 field.update_attribute(:is_required, true)
210 212
211 213 issue = Issue.find(1)
212 214 assert_nil issue.custom_value_for(field)
213 215 assert issue.available_custom_fields.include?(field)
214 216 # No change to custom values, issue can be saved
215 217 assert issue.save
216 218 # Blank value
217 219 issue.custom_field_values = { field.id => '' }
218 220 assert !issue.save
219 221 # Valid value
220 222 issue.custom_field_values = { field.id => 'PostgreSQL' }
221 223 assert issue.save
222 224 issue.reload
223 225 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
224 226 end
225 227
226 228 def test_should_not_update_attributes_if_custom_fields_validation_fails
227 229 issue = Issue.find(1)
228 230 field = IssueCustomField.find_by_name('Database')
229 231 assert issue.available_custom_fields.include?(field)
230 232
231 233 issue.custom_field_values = { field.id => 'Invalid' }
232 234 issue.subject = 'Should be not be saved'
233 235 assert !issue.save
234 236
235 237 issue.reload
236 238 assert_equal "Can't print recipes", issue.subject
237 239 end
238 240
239 241 def test_should_not_recreate_custom_values_objects_on_update
240 242 field = IssueCustomField.find_by_name('Database')
241 243
242 244 issue = Issue.find(1)
243 245 issue.custom_field_values = { field.id => 'PostgreSQL' }
244 246 assert issue.save
245 247 custom_value = issue.custom_value_for(field)
246 248 issue.reload
247 249 issue.custom_field_values = { field.id => 'MySQL' }
248 250 assert issue.save
249 251 issue.reload
250 252 assert_equal custom_value.id, issue.custom_value_for(field).id
251 253 end
252 254
253 255 def test_assigning_tracker_id_should_reload_custom_fields_values
254 256 issue = Issue.new(:project => Project.find(1))
255 257 assert issue.custom_field_values.empty?
256 258 issue.tracker_id = 1
257 259 assert issue.custom_field_values.any?
258 260 end
259 261
260 262 def test_assigning_attributes_should_assign_tracker_id_first
261 263 attributes = ActiveSupport::OrderedHash.new
262 264 attributes['custom_field_values'] = { '1' => 'MySQL' }
263 265 attributes['tracker_id'] = '1'
264 266 issue = Issue.new(:project => Project.find(1))
265 267 issue.attributes = attributes
266 268 assert_not_nil issue.custom_value_for(1)
267 269 assert_equal 'MySQL', issue.custom_value_for(1).value
268 270 end
269 271
270 272 def test_should_update_issue_with_disabled_tracker
271 273 p = Project.find(1)
272 274 issue = Issue.find(1)
273 275
274 276 p.trackers.delete(issue.tracker)
275 277 assert !p.trackers.include?(issue.tracker)
276 278
277 279 issue.reload
278 280 issue.subject = 'New subject'
279 281 assert issue.save
280 282 end
281 283
282 284 def test_should_not_set_a_disabled_tracker
283 285 p = Project.find(1)
284 286 p.trackers.delete(Tracker.find(2))
285 287
286 288 issue = Issue.find(1)
287 289 issue.tracker_id = 2
288 290 issue.subject = 'New subject'
289 291 assert !issue.save
290 292 assert_not_nil issue.errors.on(:tracker_id)
291 293 end
292 294
293 295 def test_category_based_assignment
294 296 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
295 297 :status_id => 1, :priority => IssuePriority.all.first,
296 298 :subject => 'Assignment test',
297 299 :description => 'Assignment test', :category_id => 1)
298 300 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
299 301 end
300 302
301 303 def test_new_statuses_allowed_to
302 304 Workflow.delete_all
303 305
304 306 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2, :author => false, :assignee => false)
305 307 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3, :author => true, :assignee => false)
306 308 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4, :author => false, :assignee => true)
307 309 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5, :author => true, :assignee => true)
308 310 status = IssueStatus.find(1)
309 311 role = Role.find(1)
310 312 tracker = Tracker.find(1)
311 313 user = User.find(2)
312 314
313 315 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1)
314 316 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
315 317
316 318 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user)
317 319 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
318 320
319 321 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :assigned_to => user)
320 322 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
321 323
322 324 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user, :assigned_to => user)
323 325 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
324 326 end
325 327
326 328 def test_copy
327 329 issue = Issue.new.copy_from(1)
328 330 assert issue.save
329 331 issue.reload
330 332 orig = Issue.find(1)
331 333 assert_equal orig.subject, issue.subject
332 334 assert_equal orig.tracker, issue.tracker
333 335 assert_equal "125", issue.custom_value_for(2).value
334 336 end
335 337
336 338 def test_copy_should_copy_status
337 339 orig = Issue.find(8)
338 340 assert orig.status != IssueStatus.default
339 341
340 342 issue = Issue.new.copy_from(orig)
341 343 assert issue.save
342 344 issue.reload
343 345 assert_equal orig.status, issue.status
344 346 end
345 347
346 348 def test_should_close_duplicates
347 349 # Create 3 issues
348 350 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Duplicates test', :description => 'Duplicates test')
349 351 assert issue1.save
350 352 issue2 = issue1.clone
351 353 assert issue2.save
352 354 issue3 = issue1.clone
353 355 assert issue3.save
354 356
355 357 # 2 is a dupe of 1
356 358 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
357 359 # And 3 is a dupe of 2
358 360 IssueRelation.create(:issue_from => issue3, :issue_to => issue2, :relation_type => IssueRelation::TYPE_DUPLICATES)
359 361 # And 3 is a dupe of 1 (circular duplicates)
360 362 IssueRelation.create(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
361 363
362 364 assert issue1.reload.duplicates.include?(issue2)
363 365
364 366 # Closing issue 1
365 367 issue1.init_journal(User.find(:first), "Closing issue1")
366 368 issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
367 369 assert issue1.save
368 370 # 2 and 3 should be also closed
369 371 assert issue2.reload.closed?
370 372 assert issue3.reload.closed?
371 373 end
372 374
373 375 def test_should_not_close_duplicated_issue
374 376 # Create 3 issues
375 377 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Duplicates test', :description => 'Duplicates test')
376 378 assert issue1.save
377 379 issue2 = issue1.clone
378 380 assert issue2.save
379 381
380 382 # 2 is a dupe of 1
381 383 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
382 384 # 2 is a dup of 1 but 1 is not a duplicate of 2
383 385 assert !issue2.reload.duplicates.include?(issue1)
384 386
385 387 # Closing issue 2
386 388 issue2.init_journal(User.find(:first), "Closing issue2")
387 389 issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
388 390 assert issue2.save
389 391 # 1 should not be also closed
390 392 assert !issue1.reload.closed?
391 393 end
392 394
393 395 def test_assignable_versions
394 396 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
395 397 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
396 398 end
397 399
398 400 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
399 401 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
400 402 assert !issue.save
401 403 assert_not_nil issue.errors.on(:fixed_version_id)
402 404 end
403 405
404 406 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
405 407 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
406 408 assert !issue.save
407 409 assert_not_nil issue.errors.on(:fixed_version_id)
408 410 end
409 411
410 412 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
411 413 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 3, :subject => 'New issue')
412 414 assert issue.save
413 415 end
414 416
415 417 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
416 418 issue = Issue.find(11)
417 419 assert_equal 'closed', issue.fixed_version.status
418 420 issue.subject = 'Subject changed'
419 421 assert issue.save
420 422 end
421 423
422 424 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
423 425 issue = Issue.find(11)
424 426 issue.status_id = 1
425 427 assert !issue.save
426 428 assert_not_nil issue.errors.on_base
427 429 end
428 430
429 431 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
430 432 issue = Issue.find(11)
431 433 issue.status_id = 1
432 434 issue.fixed_version_id = 3
433 435 assert issue.save
434 436 end
435 437
436 438 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
437 439 issue = Issue.find(12)
438 440 assert_equal 'locked', issue.fixed_version.status
439 441 issue.status_id = 1
440 442 assert issue.save
441 443 end
442 444
443 445 def test_move_to_another_project_with_same_category
444 446 issue = Issue.find(1)
445 447 assert issue.move_to_project(Project.find(2))
446 448 issue.reload
447 449 assert_equal 2, issue.project_id
448 450 # Category changes
449 451 assert_equal 4, issue.category_id
450 452 # Make sure time entries were move to the target project
451 453 assert_equal 2, issue.time_entries.first.project_id
452 454 end
453 455
454 456 def test_move_to_another_project_without_same_category
455 457 issue = Issue.find(2)
456 458 assert issue.move_to_project(Project.find(2))
457 459 issue.reload
458 460 assert_equal 2, issue.project_id
459 461 # Category cleared
460 462 assert_nil issue.category_id
461 463 end
462 464
463 465 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
464 466 issue = Issue.find(1)
465 467 issue.update_attribute(:fixed_version_id, 1)
466 468 assert issue.move_to_project(Project.find(2))
467 469 issue.reload
468 470 assert_equal 2, issue.project_id
469 471 # Cleared fixed_version
470 472 assert_equal nil, issue.fixed_version
471 473 end
472 474
473 475 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
474 476 issue = Issue.find(1)
475 477 issue.update_attribute(:fixed_version_id, 4)
476 478 assert issue.move_to_project(Project.find(5))
477 479 issue.reload
478 480 assert_equal 5, issue.project_id
479 481 # Keep fixed_version
480 482 assert_equal 4, issue.fixed_version_id
481 483 end
482 484
483 485 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
484 486 issue = Issue.find(1)
485 487 issue.update_attribute(:fixed_version_id, 1)
486 488 assert issue.move_to_project(Project.find(5))
487 489 issue.reload
488 490 assert_equal 5, issue.project_id
489 491 # Cleared fixed_version
490 492 assert_equal nil, issue.fixed_version
491 493 end
492 494
493 495 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
494 496 issue = Issue.find(1)
495 497 issue.update_attribute(:fixed_version_id, 7)
496 498 assert issue.move_to_project(Project.find(2))
497 499 issue.reload
498 500 assert_equal 2, issue.project_id
499 501 # Keep fixed_version
500 502 assert_equal 7, issue.fixed_version_id
501 503 end
502 504
503 505 def test_move_to_another_project_with_disabled_tracker
504 506 issue = Issue.find(1)
505 507 target = Project.find(2)
506 508 target.tracker_ids = [3]
507 509 target.save
508 510 assert_equal false, issue.move_to_project(target)
509 511 issue.reload
510 512 assert_equal 1, issue.project_id
511 513 end
512 514
513 515 def test_copy_to_the_same_project
514 516 issue = Issue.find(1)
515 517 copy = nil
516 518 assert_difference 'Issue.count' do
517 519 copy = issue.move_to_project(issue.project, nil, :copy => true)
518 520 end
519 521 assert_kind_of Issue, copy
520 522 assert_equal issue.project, copy.project
521 523 assert_equal "125", copy.custom_value_for(2).value
522 524 end
523 525
524 526 def test_copy_to_another_project_and_tracker
525 527 issue = Issue.find(1)
526 528 copy = nil
527 529 assert_difference 'Issue.count' do
528 530 copy = issue.move_to_project(Project.find(3), Tracker.find(2), :copy => true)
529 531 end
530 532 copy.reload
531 533 assert_kind_of Issue, copy
532 534 assert_equal Project.find(3), copy.project
533 535 assert_equal Tracker.find(2), copy.tracker
534 536 # Custom field #2 is not associated with target tracker
535 537 assert_nil copy.custom_value_for(2)
536 538 end
537 539
538 540 context "#move_to_project" do
539 541 context "as a copy" do
540 542 setup do
541 543 @issue = Issue.find(1)
542 544 @copy = nil
543 545 end
544 546
545 547 should "not create a journal" do
546 548 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
547 549 assert_equal 0, @copy.reload.journals.size
548 550 end
549 551
550 552 should "allow assigned_to changes" do
551 553 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
552 554 assert_equal 3, @copy.assigned_to_id
553 555 end
554 556
555 557 should "allow status changes" do
556 558 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:status_id => 2}})
557 559 assert_equal 2, @copy.status_id
558 560 end
559 561
560 562 should "allow start date changes" do
561 563 date = Date.today
562 564 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
563 565 assert_equal date, @copy.start_date
564 566 end
565 567
566 568 should "allow due date changes" do
567 569 date = Date.today
568 570 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:due_date => date}})
569 571
570 572 assert_equal date, @copy.due_date
571 573 end
572 574
573 575 should "set current user as author" do
574 576 User.current = User.find(9)
575 577 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {}})
576 578
577 579 assert_equal User.current, @copy.author
578 580 end
579 581
580 582 should "keep journal notes" do
581 583 date = Date.today
582 584 notes = "Notes added when copying"
583 585 User.current = User.find(9)
584 586 @issue.init_journal(User.current, notes)
585 587 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
586 588
587 589 assert_equal 1, @copy.journals.size
588 590 journal = @copy.journals.first
589 591 assert_equal 0, journal.details.size
590 592 assert_equal notes, journal.notes
591 593 end
592 594 end
593 595 end
594 596
595 597 def test_recipients_should_not_include_users_that_cannot_view_the_issue
596 598 issue = Issue.find(12)
597 599 assert issue.recipients.include?(issue.author.mail)
598 600 # move the issue to a private project
599 601 copy = issue.move_to_project(Project.find(5), Tracker.find(2), :copy => true)
600 602 # author is not a member of project anymore
601 603 assert !copy.recipients.include?(copy.author.mail)
602 604 end
603 605
604 606 def test_recipients_should_include_the_assigned_group_members
605 607 group_member = User.generate_with_protected!
606 608 group = Group.generate!
607 609 group.users << group_member
608 610
609 611 issue = Issue.find(12)
610 612 issue.assigned_to = group
611 613 assert issue.recipients.include?(group_member.mail)
612 614 end
613 615
614 616 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
615 617 user = User.find(3)
616 618 issue = Issue.find(9)
617 619 Watcher.create!(:user => user, :watchable => issue)
618 620 assert issue.watched_by?(user)
619 621 assert !issue.watcher_recipients.include?(user.mail)
620 622 end
621 623
622 624 def test_issue_destroy
623 625 Issue.find(1).destroy
624 626 assert_nil Issue.find_by_id(1)
625 627 assert_nil TimeEntry.find_by_issue_id(1)
626 628 end
627 629
628 630 def test_blocked
629 631 blocked_issue = Issue.find(9)
630 632 blocking_issue = Issue.find(10)
631 633
632 634 assert blocked_issue.blocked?
633 635 assert !blocking_issue.blocked?
634 636 end
635 637
636 638 def test_blocked_issues_dont_allow_closed_statuses
637 639 blocked_issue = Issue.find(9)
638 640
639 641 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
640 642 assert !allowed_statuses.empty?
641 643 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
642 644 assert closed_statuses.empty?
643 645 end
644 646
645 647 def test_unblocked_issues_allow_closed_statuses
646 648 blocking_issue = Issue.find(10)
647 649
648 650 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
649 651 assert !allowed_statuses.empty?
650 652 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
651 653 assert !closed_statuses.empty?
652 654 end
653 655
654 656 def test_rescheduling_an_issue_should_reschedule_following_issue
655 657 issue1 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
656 658 issue2 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
657 659 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
658 660 assert_equal issue1.due_date + 1, issue2.reload.start_date
659 661
660 662 issue1.due_date = Date.today + 5
661 663 issue1.save!
662 664 assert_equal issue1.due_date + 1, issue2.reload.start_date
663 665 end
664 666
665 667 def test_overdue
666 668 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
667 669 assert !Issue.new(:due_date => Date.today).overdue?
668 670 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
669 671 assert !Issue.new(:due_date => nil).overdue?
670 672 assert !Issue.new(:due_date => 1.day.ago.to_date, :status => IssueStatus.find(:first, :conditions => {:is_closed => true})).overdue?
671 673 end
672 674
673 675 context "#behind_schedule?" do
674 676 should "be false if the issue has no start_date" do
675 677 assert !Issue.new(:start_date => nil, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
676 678 end
677 679
678 680 should "be false if the issue has no end_date" do
679 681 assert !Issue.new(:start_date => 1.day.from_now.to_date, :due_date => nil, :done_ratio => 0).behind_schedule?
680 682 end
681 683
682 684 should "be false if the issue has more done than it's calendar time" do
683 685 assert !Issue.new(:start_date => 50.days.ago.to_date, :due_date => 50.days.from_now.to_date, :done_ratio => 90).behind_schedule?
684 686 end
685 687
686 688 should "be true if the issue hasn't been started at all" do
687 689 assert Issue.new(:start_date => 1.day.ago.to_date, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
688 690 end
689 691
690 692 should "be true if the issue has used more calendar time than it's done ratio" do
691 693 assert Issue.new(:start_date => 100.days.ago.to_date, :due_date => Date.today, :done_ratio => 90).behind_schedule?
692 694 end
693 695 end
694 696
695 697 context "#assignable_users" do
696 698 should "be Users" do
697 699 assert_kind_of User, Issue.find(1).assignable_users.first
698 700 end
699 701
700 702 should "include the issue author" do
701 703 project = Project.find(1)
702 704 non_project_member = User.generate!
703 705 issue = Issue.generate_for_project!(project, :author => non_project_member)
704 706
705 707 assert issue.assignable_users.include?(non_project_member)
706 708 end
707 709
708 710 should "include the current assignee" do
709 711 project = Project.find(1)
710 712 user = User.generate!
711 713 issue = Issue.generate_for_project!(project, :assigned_to => user)
712 714 user.lock!
713 715
714 716 assert Issue.find(issue.id).assignable_users.include?(user)
715 717 end
716 718
717 719 should "not show the issue author twice" do
718 720 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
719 721 assert_equal 2, assignable_user_ids.length
720 722
721 723 assignable_user_ids.each do |user_id|
722 724 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length, "User #{user_id} appears more or less than once"
723 725 end
724 726 end
725 727
726 728 context "with issue_group_assignment" do
727 729 should "include groups" do
728 730 issue = Issue.new(:project => Project.find(2))
729 731
730 732 with_settings :issue_group_assignment => '1' do
731 733 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
732 734 assert issue.assignable_users.include?(Group.find(11))
733 735 end
734 736 end
735 737 end
736 738
737 739 context "without issue_group_assignment" do
738 740 should "not include groups" do
739 741 issue = Issue.new(:project => Project.find(2))
740 742
741 743 with_settings :issue_group_assignment => '0' do
742 744 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
743 745 assert !issue.assignable_users.include?(Group.find(11))
744 746 end
745 747 end
746 748 end
747 749 end
748 750
749 751 def test_create_should_send_email_notification
750 752 ActionMailer::Base.deliveries.clear
751 753 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create', :estimated_hours => '1:30')
752 754
753 755 assert issue.save
754 756 assert_equal 1, ActionMailer::Base.deliveries.size
755 757 end
756 758
757 759 def test_stale_issue_should_not_send_email_notification
758 760 ActionMailer::Base.deliveries.clear
759 761 issue = Issue.find(1)
760 762 stale = Issue.find(1)
761 763
762 764 issue.init_journal(User.find(1))
763 765 issue.subject = 'Subjet update'
764 766 assert issue.save
765 767 assert_equal 1, ActionMailer::Base.deliveries.size
766 768 ActionMailer::Base.deliveries.clear
767 769
768 770 stale.init_journal(User.find(1))
769 771 stale.subject = 'Another subjet update'
770 772 assert_raise ActiveRecord::StaleObjectError do
771 773 stale.save
772 774 end
773 775 assert ActionMailer::Base.deliveries.empty?
774 776 end
775 777
776 778 def test_journalized_description
777 779 IssueCustomField.delete_all
778 780
779 781 i = Issue.first
780 782 old_description = i.description
781 783 new_description = "This is the new description"
782 784
783 785 i.init_journal(User.find(2))
784 786 i.description = new_description
785 787 assert_difference 'Journal.count', 1 do
786 788 assert_difference 'JournalDetail.count', 1 do
787 789 i.save!
788 790 end
789 791 end
790 792
791 793 detail = JournalDetail.first(:order => 'id DESC')
792 794 assert_equal i, detail.journal.journalized
793 795 assert_equal 'attr', detail.property
794 796 assert_equal 'description', detail.prop_key
795 797 assert_equal old_description, detail.old_value
796 798 assert_equal new_description, detail.value
797 799 end
798 800
799 801 def test_blank_descriptions_should_not_be_journalized
800 802 IssueCustomField.delete_all
801 803 Issue.update_all("description = NULL", "id=1")
802 804
803 805 i = Issue.find(1)
804 806 i.init_journal(User.find(2))
805 807 i.subject = "blank description"
806 808 i.description = "\r\n"
807 809
808 810 assert_difference 'Journal.count', 1 do
809 811 assert_difference 'JournalDetail.count', 1 do
810 812 i.save!
811 813 end
812 814 end
813 815 end
814 816
815 817 def test_description_eol_should_be_normalized
816 818 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
817 819 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
818 820 end
819 821
820 822 def test_saving_twice_should_not_duplicate_journal_details
821 823 i = Issue.find(:first)
822 824 i.init_journal(User.find(2), 'Some notes')
823 825 # initial changes
824 826 i.subject = 'New subject'
825 827 i.done_ratio = i.done_ratio + 10
826 828 assert_difference 'Journal.count' do
827 829 assert i.save
828 830 end
829 831 # 1 more change
830 832 i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id])
831 833 assert_no_difference 'Journal.count' do
832 834 assert_difference 'JournalDetail.count', 1 do
833 835 i.save
834 836 end
835 837 end
836 838 # no more change
837 839 assert_no_difference 'Journal.count' do
838 840 assert_no_difference 'JournalDetail.count' do
839 841 i.save
840 842 end
841 843 end
842 844 end
843 845
844 846 def test_all_dependent_issues
845 847 IssueRelation.delete_all
846 848 assert IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => IssueRelation::TYPE_PRECEDES)
847 849 assert IssueRelation.create!(:issue_from => Issue.find(2), :issue_to => Issue.find(3), :relation_type => IssueRelation::TYPE_PRECEDES)
848 850 assert IssueRelation.create!(:issue_from => Issue.find(3), :issue_to => Issue.find(8), :relation_type => IssueRelation::TYPE_PRECEDES)
849 851
850 852 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
851 853 end
852 854
853 855 def test_all_dependent_issues_with_persistent_circular_dependency
854 856 IssueRelation.delete_all
855 857 assert IssueRelation.create!(:issue_from => Issue.find(1),
856 858 :issue_to => Issue.find(2),
857 859 :relation_type => IssueRelation::TYPE_PRECEDES)
858 860 assert IssueRelation.create!(:issue_from => Issue.find(2),
859 861 :issue_to => Issue.find(3),
860 862 :relation_type => IssueRelation::TYPE_PRECEDES)
861 863 # Validation skipping
862 864 assert IssueRelation.new(:issue_from => Issue.find(3),
863 865 :issue_to => Issue.find(1),
864 866 :relation_type => IssueRelation::TYPE_PRECEDES).save(false)
865 867
866 868 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
867 869 end
868 870
869 871 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
870 872 IssueRelation.delete_all
871 873 assert IssueRelation.create!(:issue_from => Issue.find(1),
872 874 :issue_to => Issue.find(2),
873 875 :relation_type => IssueRelation::TYPE_RELATES)
874 876 assert IssueRelation.create!(:issue_from => Issue.find(2),
875 877 :issue_to => Issue.find(3),
876 878 :relation_type => IssueRelation::TYPE_RELATES)
877 879 assert IssueRelation.create!(:issue_from => Issue.find(3),
878 880 :issue_to => Issue.find(8),
879 881 :relation_type => IssueRelation::TYPE_RELATES)
880 882 # Validation skipping
881 883 assert IssueRelation.new(:issue_from => Issue.find(8),
882 884 :issue_to => Issue.find(2),
883 885 :relation_type => IssueRelation::TYPE_RELATES).save(false)
884 886 assert IssueRelation.new(:issue_from => Issue.find(3),
885 887 :issue_to => Issue.find(1),
886 888 :relation_type => IssueRelation::TYPE_RELATES).save(false)
887 889
888 890 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
889 891 end
890 892
891 893 context "#done_ratio" do
892 894 setup do
893 895 @issue = Issue.find(1)
894 896 @issue_status = IssueStatus.find(1)
895 897 @issue_status.update_attribute(:default_done_ratio, 50)
896 898 @issue2 = Issue.find(2)
897 899 @issue_status2 = IssueStatus.find(2)
898 900 @issue_status2.update_attribute(:default_done_ratio, 0)
899 901 end
900 902
901 903 context "with Setting.issue_done_ratio using the issue_field" do
902 904 setup do
903 905 Setting.issue_done_ratio = 'issue_field'
904 906 end
905 907
906 908 should "read the issue's field" do
907 909 assert_equal 0, @issue.done_ratio
908 910 assert_equal 30, @issue2.done_ratio
909 911 end
910 912 end
911 913
912 914 context "with Setting.issue_done_ratio using the issue_status" do
913 915 setup do
914 916 Setting.issue_done_ratio = 'issue_status'
915 917 end
916 918
917 919 should "read the Issue Status's default done ratio" do
918 920 assert_equal 50, @issue.done_ratio
919 921 assert_equal 0, @issue2.done_ratio
920 922 end
921 923 end
922 924 end
923 925
924 926 context "#update_done_ratio_from_issue_status" do
925 927 setup do
926 928 @issue = Issue.find(1)
927 929 @issue_status = IssueStatus.find(1)
928 930 @issue_status.update_attribute(:default_done_ratio, 50)
929 931 @issue2 = Issue.find(2)
930 932 @issue_status2 = IssueStatus.find(2)
931 933 @issue_status2.update_attribute(:default_done_ratio, 0)
932 934 end
933 935
934 936 context "with Setting.issue_done_ratio using the issue_field" do
935 937 setup do
936 938 Setting.issue_done_ratio = 'issue_field'
937 939 end
938 940
939 941 should "not change the issue" do
940 942 @issue.update_done_ratio_from_issue_status
941 943 @issue2.update_done_ratio_from_issue_status
942 944
943 945 assert_equal 0, @issue.read_attribute(:done_ratio)
944 946 assert_equal 30, @issue2.read_attribute(:done_ratio)
945 947 end
946 948 end
947 949
948 950 context "with Setting.issue_done_ratio using the issue_status" do
949 951 setup do
950 952 Setting.issue_done_ratio = 'issue_status'
951 953 end
952 954
953 955 should "change the issue's done ratio" do
954 956 @issue.update_done_ratio_from_issue_status
955 957 @issue2.update_done_ratio_from_issue_status
956 958
957 959 assert_equal 50, @issue.read_attribute(:done_ratio)
958 960 assert_equal 0, @issue2.read_attribute(:done_ratio)
959 961 end
960 962 end
961 963 end
962 964
963 965 test "#by_tracker" do
964 966 User.current = User.anonymous
965 967 groups = Issue.by_tracker(Project.find(1))
966 968 assert_equal 3, groups.size
967 969 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
968 970 end
969 971
970 972 test "#by_version" do
971 973 User.current = User.anonymous
972 974 groups = Issue.by_version(Project.find(1))
973 975 assert_equal 3, groups.size
974 976 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
975 977 end
976 978
977 979 test "#by_priority" do
978 980 User.current = User.anonymous
979 981 groups = Issue.by_priority(Project.find(1))
980 982 assert_equal 4, groups.size
981 983 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
982 984 end
983 985
984 986 test "#by_category" do
985 987 User.current = User.anonymous
986 988 groups = Issue.by_category(Project.find(1))
987 989 assert_equal 2, groups.size
988 990 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
989 991 end
990 992
991 993 test "#by_assigned_to" do
992 994 User.current = User.anonymous
993 995 groups = Issue.by_assigned_to(Project.find(1))
994 996 assert_equal 2, groups.size
995 997 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
996 998 end
997 999
998 1000 test "#by_author" do
999 1001 User.current = User.anonymous
1000 1002 groups = Issue.by_author(Project.find(1))
1001 1003 assert_equal 4, groups.size
1002 1004 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1003 1005 end
1004 1006
1005 1007 test "#by_subproject" do
1006 1008 User.current = User.anonymous
1007 1009 groups = Issue.by_subproject(Project.find(1))
1008 1010 # Private descendant not visible
1009 1011 assert_equal 1, groups.size
1010 1012 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1011 1013 end
1012 1014
1013 1015 context ".allowed_target_projects_on_move" do
1014 1016 should "return all active projects for admin users" do
1015 1017 User.current = User.find(1)
1016 1018 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
1017 1019 end
1018 1020
1019 1021 should "return allowed projects for non admin users" do
1020 1022 User.current = User.find(2)
1021 1023 Role.non_member.remove_permission! :move_issues
1022 1024 assert_equal 3, Issue.allowed_target_projects_on_move.size
1023 1025
1024 1026 Role.non_member.add_permission! :move_issues
1025 1027 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
1026 1028 end
1027 1029 end
1028 1030
1029 1031 def test_recently_updated_with_limit_scopes
1030 1032 #should return the last updated issue
1031 1033 assert_equal 1, Issue.recently_updated.with_limit(1).length
1032 1034 assert_equal Issue.find(:first, :order => "updated_on DESC"), Issue.recently_updated.with_limit(1).first
1033 1035 end
1034 1036
1035 1037 def test_on_active_projects_scope
1036 1038 assert Project.find(2).archive
1037 1039
1038 1040 before = Issue.on_active_project.length
1039 1041 # test inclusion to results
1040 1042 issue = Issue.generate_for_project!(Project.find(1), :tracker => Project.find(2).trackers.first)
1041 1043 assert_equal before + 1, Issue.on_active_project.length
1042 1044
1043 1045 # Move to an archived project
1044 1046 issue.project = Project.find(2)
1045 1047 assert issue.save
1046 1048 assert_equal before, Issue.on_active_project.length
1047 1049 end
1048 1050
1049 1051 context "Issue#recipients" do
1050 1052 setup do
1051 1053 @project = Project.find(1)
1052 1054 @author = User.generate_with_protected!
1053 1055 @assignee = User.generate_with_protected!
1054 1056 @issue = Issue.generate_for_project!(@project, :assigned_to => @assignee, :author => @author)
1055 1057 end
1056 1058
1057 1059 should "include project recipients" do
1058 1060 assert @project.recipients.present?
1059 1061 @project.recipients.each do |project_recipient|
1060 1062 assert @issue.recipients.include?(project_recipient)
1061 1063 end
1062 1064 end
1063 1065
1064 1066 should "include the author if the author is active" do
1065 1067 assert @issue.author, "No author set for Issue"
1066 1068 assert @issue.recipients.include?(@issue.author.mail)
1067 1069 end
1068 1070
1069 1071 should "include the assigned to user if the assigned to user is active" do
1070 1072 assert @issue.assigned_to, "No assigned_to set for Issue"
1071 1073 assert @issue.recipients.include?(@issue.assigned_to.mail)
1072 1074 end
1073 1075
1074 1076 should "not include users who opt out of all email" do
1075 1077 @author.update_attribute(:mail_notification, :none)
1076 1078
1077 1079 assert !@issue.recipients.include?(@issue.author.mail)
1078 1080 end
1079 1081
1080 1082 should "not include the issue author if they are only notified of assigned issues" do
1081 1083 @author.update_attribute(:mail_notification, :only_assigned)
1082 1084
1083 1085 assert !@issue.recipients.include?(@issue.author.mail)
1084 1086 end
1085 1087
1086 1088 should "not include the assigned user if they are only notified of owned issues" do
1087 1089 @assignee.update_attribute(:mail_notification, :only_owner)
1088 1090
1089 1091 assert !@issue.recipients.include?(@issue.assigned_to.mail)
1090 1092 end
1091 1093
1092 1094 end
1093 1095 end
General Comments 0
You need to be logged in to leave comments. Login now