jro_apps/redmine Commit - r14957:39ff11ba06a7

Removes #move_to= (#12909)....

Jean-Philippe Lang -

r14957:39ff11ba06a7

parent child

Context file:

r14957:39ff11ba06a7

lib/redmine/acts/positioned.rb 0 -16

@@ -47,22 +47,6 module Redmine
47	base.extend ClassMethods	47	base.extend ClassMethods
48	end	48	end
49		49
50	# Move to the given position
51	# For compatibility with the previous way of sorting items
52	def move_to=(pos)
53	case pos.to_s
54	when 'highest'
55	self.position = 1
56	when 'higher'
57	self.position -= 1 if position > 1
58	when 'lower'
59	self.position += 1
60	when 'lowest'
61	self.position = nil
62	set_default_position
63	end
64	end
65
66	private	50	private
67		51
68	def position_scope	52	def position_scope

test/functional/roles_controller_test.rb +4 -4

               end
               def test_move_highest
-                put :update, :id => 3, :role => {:move_to => 'highest'}
+                put :update, :id => 3, :role => {:position => 1}
                 assert_redirected_to '/roles'
                 assert_equal 1, Role.find(3).position
               end
               def test_move_higher
                 position = Role.find(3).position
-                put :update, :id => 3, :role => {:move_to => 'higher'}
+                put :update, :id => 3, :role => {:position => position - 1}
                 assert_redirected_to '/roles'
                 assert_equal position - 1, Role.find(3).position
               end
               def test_move_lower
                 position = Role.find(2).position
-                put :update, :id => 2, :role => {:move_to => 'lower'}
+                put :update, :id => 2, :role => {:position => position + 1}
                 assert_redirected_to '/roles'
                 assert_equal position + 1, Role.find(2).position
               end
               def test_move_lowest
-                put :update, :id => 2, :role => {:move_to => 'lowest'}
+                put :update, :id => 2, :role => {:position => Role.givable.count}
                 assert_redirected_to '/roles'
                 assert_equal Role.givable.count, Role.find(2).position
               end

test/unit/enumeration_test.rb +1 -1

                 a = IssuePriority.create!(:name => 'A')
                 b = IssuePriority.create!(:name => 'B')
                 override = IssuePriority.create!(:name => 'BB', :parent_id => b.id)
-                b.move_to = 'higher'
+                b.position -= 1
                 b.save!
                 assert_equal [2, 1, 1], [a, b, override].map(&:reload).map(&:position)

test/unit/issue_priority_test.rb +1 -1

               def test_moving_a_priority_should_update_position_names
                 prio = IssuePriority.first
-                prio.move_to = 'lowest'
+                prio.position = IssuePriority.count
                 prio.save!
                 prio.reload
                 assert_equal 'highest', prio.position_name

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages