##// END OF EJS Templates
Omit blank fields as we do for the description (#21705)....
Jean-Philippe Lang -
r15875:37301d75b3fe
parent child
Show More
@@ -1,544 +1,546
1 1 # encoding: utf-8
2 2 #
3 3 # Redmine - project management software
4 4 # Copyright (C) 2006-2016 Jean-Philippe Lang
5 5 #
6 6 # This program is free software; you can redistribute it and/or
7 7 # modify it under the terms of the GNU General Public License
8 8 # as published by the Free Software Foundation; either version 2
9 9 # of the License, or (at your option) any later version.
10 10 #
11 11 # This program is distributed in the hope that it will be useful,
12 12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
13 13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 14 # GNU General Public License for more details.
15 15 #
16 16 # You should have received a copy of the GNU General Public License
17 17 # along with this program; if not, write to the Free Software
18 18 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
19 19
20 20 module IssuesHelper
21 21 include ApplicationHelper
22 22 include Redmine::Export::PDF::IssuesPdfHelper
23 23
24 24 def issue_list(issues, &block)
25 25 ancestors = []
26 26 issues.each do |issue|
27 27 while (ancestors.any? && !issue.is_descendant_of?(ancestors.last))
28 28 ancestors.pop
29 29 end
30 30 yield issue, ancestors.size
31 31 ancestors << issue unless issue.leaf?
32 32 end
33 33 end
34 34
35 35 def grouped_issue_list(issues, query, issue_count_by_group, &block)
36 36 ancestors = []
37 37 grouped_query_results(issues, query, issue_count_by_group) do |issue, group_name, group_count, group_totals|
38 38 while (ancestors.any? && !issue.is_descendant_of?(ancestors.last))
39 39 ancestors.pop
40 40 end
41 41 yield issue, ancestors.size, group_name, group_count, group_totals
42 42 ancestors << issue unless issue.leaf?
43 43 end
44 44 end
45 45
46 46 # Renders a HTML/CSS tooltip
47 47 #
48 48 # To use, a trigger div is needed. This is a div with the class of "tooltip"
49 49 # that contains this method wrapped in a span with the class of "tip"
50 50 #
51 51 # <div class="tooltip"><%= link_to_issue(issue) %>
52 52 # <span class="tip"><%= render_issue_tooltip(issue) %></span>
53 53 # </div>
54 54 #
55 55 def render_issue_tooltip(issue)
56 56 @cached_label_status ||= l(:field_status)
57 57 @cached_label_start_date ||= l(:field_start_date)
58 58 @cached_label_due_date ||= l(:field_due_date)
59 59 @cached_label_assigned_to ||= l(:field_assigned_to)
60 60 @cached_label_priority ||= l(:field_priority)
61 61 @cached_label_project ||= l(:field_project)
62 62
63 63 link_to_issue(issue) + "<br /><br />".html_safe +
64 64 "<strong>#{@cached_label_project}</strong>: #{link_to_project(issue.project)}<br />".html_safe +
65 65 "<strong>#{@cached_label_status}</strong>: #{h(issue.status.name)}<br />".html_safe +
66 66 "<strong>#{@cached_label_start_date}</strong>: #{format_date(issue.start_date)}<br />".html_safe +
67 67 "<strong>#{@cached_label_due_date}</strong>: #{format_date(issue.due_date)}<br />".html_safe +
68 68 "<strong>#{@cached_label_assigned_to}</strong>: #{h(issue.assigned_to)}<br />".html_safe +
69 69 "<strong>#{@cached_label_priority}</strong>: #{h(issue.priority.name)}".html_safe
70 70 end
71 71
72 72 def issue_heading(issue)
73 73 h("#{issue.tracker} ##{issue.id}")
74 74 end
75 75
76 76 def render_issue_subject_with_tree(issue)
77 77 s = ''
78 78 ancestors = issue.root? ? [] : issue.ancestors.visible.to_a
79 79 ancestors.each do |ancestor|
80 80 s << '<div>' + content_tag('p', link_to_issue(ancestor, :project => (issue.project_id != ancestor.project_id)))
81 81 end
82 82 s << '<div>'
83 83 subject = h(issue.subject)
84 84 if issue.is_private?
85 85 subject = content_tag('span', l(:field_is_private), :class => 'private') + ' ' + subject
86 86 end
87 87 s << content_tag('h3', subject)
88 88 s << '</div>' * (ancestors.size + 1)
89 89 s.html_safe
90 90 end
91 91
92 92 def render_descendants_tree(issue)
93 93 s = '<table class="list issues">'
94 94 issue_list(issue.descendants.visible.preload(:status, :priority, :tracker, :assigned_to).sort_by(&:lft)) do |child, level|
95 95 css = "issue issue-#{child.id} hascontextmenu #{child.css_classes}"
96 96 css << " idnt idnt-#{level}" if level > 0
97 97 s << content_tag('tr',
98 98 content_tag('td', check_box_tag("ids[]", child.id, false, :id => nil), :class => 'checkbox') +
99 99 content_tag('td', link_to_issue(child, :project => (issue.project_id != child.project_id)), :class => 'subject', :style => 'width: 50%') +
100 100 content_tag('td', h(child.status), :class => 'status') +
101 101 content_tag('td', link_to_user(child.assigned_to), :class => 'assigned_to') +
102 102 content_tag('td', child.disabled_core_fields.include?('done_ratio') ? '' : progress_bar(child.done_ratio), :class=> 'done_ratio'),
103 103 :class => css)
104 104 end
105 105 s << '</table>'
106 106 s.html_safe
107 107 end
108 108
109 109 # Renders the list of related issues on the issue details view
110 110 def render_issue_relations(issue, relations)
111 111 manage_relations = User.current.allowed_to?(:manage_issue_relations, issue.project)
112 112
113 113 s = ''.html_safe
114 114 relations.each do |relation|
115 115 other_issue = relation.other_issue(issue)
116 116 css = "issue hascontextmenu #{other_issue.css_classes}"
117 117 link = manage_relations ? link_to(l(:label_relation_delete),
118 118 relation_path(relation),
119 119 :remote => true,
120 120 :method => :delete,
121 121 :data => {:confirm => l(:text_are_you_sure)},
122 122 :title => l(:label_relation_delete),
123 123 :class => 'icon-only icon-link-break'
124 124 ) : nil
125 125
126 126 s << content_tag('tr',
127 127 content_tag('td', check_box_tag("ids[]", other_issue.id, false, :id => nil), :class => 'checkbox') +
128 128 content_tag('td', relation.to_s(@issue) {|other| link_to_issue(other, :project => Setting.cross_project_issue_relations?)}.html_safe, :class => 'subject', :style => 'width: 50%') +
129 129 content_tag('td', other_issue.status, :class => 'status') +
130 130 content_tag('td', other_issue.start_date, :class => 'start_date') +
131 131 content_tag('td', other_issue.due_date, :class => 'due_date') +
132 132 content_tag('td', other_issue.disabled_core_fields.include?('done_ratio') ? '' : progress_bar(other_issue.done_ratio), :class=> 'done_ratio') +
133 133 content_tag('td', link, :class => 'buttons'),
134 134 :id => "relation-#{relation.id}",
135 135 :class => css)
136 136 end
137 137
138 138 content_tag('table', s, :class => 'list issues')
139 139 end
140 140
141 141 def issue_estimated_hours_details(issue)
142 142 if issue.total_estimated_hours.present?
143 143 if issue.total_estimated_hours == issue.estimated_hours
144 144 l_hours_short(issue.estimated_hours)
145 145 else
146 146 s = issue.estimated_hours.present? ? l_hours_short(issue.estimated_hours) : ""
147 147 s << " (#{l(:label_total)}: #{l_hours_short(issue.total_estimated_hours)})"
148 148 s.html_safe
149 149 end
150 150 end
151 151 end
152 152
153 153 def issue_spent_hours_details(issue)
154 154 if issue.total_spent_hours > 0
155 155 path = project_time_entries_path(issue.project, :issue_id => "~#{issue.id}")
156 156
157 157 if issue.total_spent_hours == issue.spent_hours
158 158 link_to(l_hours_short(issue.spent_hours), path)
159 159 else
160 160 s = issue.spent_hours > 0 ? l_hours_short(issue.spent_hours) : ""
161 161 s << " (#{l(:label_total)}: #{link_to l_hours_short(issue.total_spent_hours), path})"
162 162 s.html_safe
163 163 end
164 164 end
165 165 end
166 166
167 167 # Returns an array of error messages for bulk edited issues
168 168 def bulk_edit_error_messages(issues)
169 169 messages = {}
170 170 issues.each do |issue|
171 171 issue.errors.full_messages.each do |message|
172 172 messages[message] ||= []
173 173 messages[message] << issue
174 174 end
175 175 end
176 176 messages.map { |message, issues|
177 177 "#{message}: " + issues.map {|i| "##{i.id}"}.join(', ')
178 178 }
179 179 end
180 180
181 181 # Returns a link for adding a new subtask to the given issue
182 182 def link_to_new_subtask(issue)
183 183 attrs = {
184 184 :parent_issue_id => issue
185 185 }
186 186 attrs[:tracker_id] = issue.tracker unless issue.tracker.disabled_core_fields.include?('parent_issue_id')
187 187 link_to(l(:button_add), new_project_issue_path(issue.project, :issue => attrs))
188 188 end
189 189
190 190 def trackers_options_for_select(issue)
191 191 trackers = issue.allowed_target_trackers
192 192 if issue.new_record? && issue.parent_issue_id.present?
193 193 trackers = trackers.reject do |tracker|
194 194 issue.tracker_id != tracker.id && tracker.disabled_core_fields.include?('parent_issue_id')
195 195 end
196 196 end
197 197 trackers.collect {|t| [t.name, t.id]}
198 198 end
199 199
200 200 class IssueFieldsRows
201 201 include ActionView::Helpers::TagHelper
202 202
203 203 def initialize
204 204 @left = []
205 205 @right = []
206 206 end
207 207
208 208 def left(*args)
209 209 args.any? ? @left << cells(*args) : @left
210 210 end
211 211
212 212 def right(*args)
213 213 args.any? ? @right << cells(*args) : @right
214 214 end
215 215
216 216 def size
217 217 @left.size > @right.size ? @left.size : @right.size
218 218 end
219 219
220 220 def to_html
221 221 content =
222 222 content_tag('div', @left.reduce(&:+), :class => 'splitcontentleft') +
223 223 content_tag('div', @right.reduce(&:+), :class => 'splitcontentleft')
224 224
225 225 content_tag('div', content, :class => 'splitcontent')
226 226 end
227 227
228 228 def cells(label, text, options={})
229 229 options[:class] = [options[:class] || "", 'attribute'].join(' ')
230 230 content_tag 'div',
231 231 content_tag('div', label + ":", :class => 'label') + content_tag('div', text, :class => 'value'),
232 232 options
233 233 end
234 234 end
235 235
236 236 def issue_fields_rows
237 237 r = IssueFieldsRows.new
238 238 yield r
239 239 r.to_html
240 240 end
241 241
242 242 def render_half_width_custom_fields_rows(issue)
243 243 values = issue.visible_custom_field_values.reject {|value| value.custom_field.full_width_layout?}
244 244 return if values.empty?
245 245 half = (values.size / 2.0).ceil
246 246 issue_fields_rows do |rows|
247 247 values.each_with_index do |value, i|
248 248 css = "cf_#{value.custom_field.id}"
249 249 m = (i < half ? :left : :right)
250 250 rows.send m, custom_field_name_tag(value.custom_field), show_value(value), :class => css
251 251 end
252 252 end
253 253 end
254 254
255 255 def render_full_width_custom_fields_rows(issue)
256 256 values = issue.visible_custom_field_values.select {|value| value.custom_field.full_width_layout?}
257 257 return if values.empty?
258 258
259 259 s = ''.html_safe
260 260 values.each_with_index do |value, i|
261 attr_value = show_value(value)
262 next if attr_value.blank?
263
261 264 if value.custom_field.text_formatting == 'full'
262 attr_value = content_tag('div', show_value(value), class: 'wiki')
263 else
264 attr_value = show_value(value)
265 attr_value = content_tag('div', attr_value, class: 'wiki')
265 266 end
267
266 268 content =
267 269 content_tag('hr') +
268 270 content_tag('p', content_tag('strong', custom_field_name_tag(value.custom_field) )) +
269 271 content_tag('div', attr_value, class: 'value')
270 272 s << content_tag('div', content, class: "cf_#{value.custom_field.id} attribute")
271 273 end
272 274 s
273 275 end
274 276
275 277 # Returns the path for updating the issue form
276 278 # with project as the current project
277 279 def update_issue_form_path(project, issue)
278 280 options = {:format => 'js'}
279 281 if issue.new_record?
280 282 if project
281 283 new_project_issue_path(project, options)
282 284 else
283 285 new_issue_path(options)
284 286 end
285 287 else
286 288 edit_issue_path(issue, options)
287 289 end
288 290 end
289 291
290 292 # Returns the number of descendants for an array of issues
291 293 def issues_descendant_count(issues)
292 294 ids = issues.reject(&:leaf?).map {|issue| issue.descendants.ids}.flatten.uniq
293 295 ids -= issues.map(&:id)
294 296 ids.size
295 297 end
296 298
297 299 def issues_destroy_confirmation_message(issues)
298 300 issues = [issues] unless issues.is_a?(Array)
299 301 message = l(:text_issues_destroy_confirmation)
300 302
301 303 descendant_count = issues_descendant_count(issues)
302 304 if descendant_count > 0
303 305 message << "\n" + l(:text_issues_destroy_descendants_confirmation, :count => descendant_count)
304 306 end
305 307 message
306 308 end
307 309
308 310 # Returns an array of users that are proposed as watchers
309 311 # on the new issue form
310 312 def users_for_new_issue_watchers(issue)
311 313 users = issue.watcher_users
312 314 if issue.project.users.count <= 20
313 315 users = (users + issue.project.users.sort).uniq
314 316 end
315 317 users
316 318 end
317 319
318 320 def email_issue_attributes(issue, user, html)
319 321 items = []
320 322 %w(author status priority assigned_to category fixed_version).each do |attribute|
321 323 unless issue.disabled_core_fields.include?(attribute+"_id")
322 324 if html
323 325 items << content_tag('strong', "#{l("field_#{attribute}")}: ") + (issue.send attribute)
324 326 else
325 327 items << "#{l("field_#{attribute}")}: #{issue.send attribute}"
326 328 end
327 329 end
328 330 end
329 331 issue.visible_custom_field_values(user).each do |value|
330 332 if html
331 333 items << content_tag('strong', "#{value.custom_field.name}: ") + show_value(value, false)
332 334 else
333 335 items << "#{value.custom_field.name}: #{show_value(value, false)}"
334 336 end
335 337 end
336 338 items
337 339 end
338 340
339 341 def render_email_issue_attributes(issue, user, html=false)
340 342 items = email_issue_attributes(issue, user, html)
341 343 if html
342 344 content_tag('ul', items.map{|s| content_tag('li', s)}.join("\n").html_safe, :class => "details")
343 345 else
344 346 items.map{|s| "* #{s}"}.join("\n")
345 347 end
346 348 end
347 349
348 350 # Returns the textual representation of a journal details
349 351 # as an array of strings
350 352 def details_to_strings(details, no_html=false, options={})
351 353 options[:only_path] = (options[:only_path] == false ? false : true)
352 354 strings = []
353 355 values_by_field = {}
354 356 details.each do |detail|
355 357 if detail.property == 'cf'
356 358 field = detail.custom_field
357 359 if field && field.multiple?
358 360 values_by_field[field] ||= {:added => [], :deleted => []}
359 361 if detail.old_value
360 362 values_by_field[field][:deleted] << detail.old_value
361 363 end
362 364 if detail.value
363 365 values_by_field[field][:added] << detail.value
364 366 end
365 367 next
366 368 end
367 369 end
368 370 strings << show_detail(detail, no_html, options)
369 371 end
370 372 if values_by_field.present?
371 373 multiple_values_detail = Struct.new(:property, :prop_key, :custom_field, :old_value, :value)
372 374 values_by_field.each do |field, changes|
373 375 if changes[:added].any?
374 376 detail = multiple_values_detail.new('cf', field.id.to_s, field)
375 377 detail.value = changes[:added]
376 378 strings << show_detail(detail, no_html, options)
377 379 end
378 380 if changes[:deleted].any?
379 381 detail = multiple_values_detail.new('cf', field.id.to_s, field)
380 382 detail.old_value = changes[:deleted]
381 383 strings << show_detail(detail, no_html, options)
382 384 end
383 385 end
384 386 end
385 387 strings
386 388 end
387 389
388 390 # Returns the textual representation of a single journal detail
389 391 def show_detail(detail, no_html=false, options={})
390 392 multiple = false
391 393 show_diff = false
392 394 no_details = false
393 395
394 396 case detail.property
395 397 when 'attr'
396 398 field = detail.prop_key.to_s.gsub(/\_id$/, "")
397 399 label = l(("field_" + field).to_sym)
398 400 case detail.prop_key
399 401 when 'due_date', 'start_date'
400 402 value = format_date(detail.value.to_date) if detail.value
401 403 old_value = format_date(detail.old_value.to_date) if detail.old_value
402 404
403 405 when 'project_id', 'status_id', 'tracker_id', 'assigned_to_id',
404 406 'priority_id', 'category_id', 'fixed_version_id'
405 407 value = find_name_by_reflection(field, detail.value)
406 408 old_value = find_name_by_reflection(field, detail.old_value)
407 409
408 410 when 'estimated_hours'
409 411 value = l_hours_short(detail.value.to_f) unless detail.value.blank?
410 412 old_value = l_hours_short(detail.old_value.to_f) unless detail.old_value.blank?
411 413
412 414 when 'parent_id'
413 415 label = l(:field_parent_issue)
414 416 value = "##{detail.value}" unless detail.value.blank?
415 417 old_value = "##{detail.old_value}" unless detail.old_value.blank?
416 418
417 419 when 'is_private'
418 420 value = l(detail.value == "0" ? :general_text_No : :general_text_Yes) unless detail.value.blank?
419 421 old_value = l(detail.old_value == "0" ? :general_text_No : :general_text_Yes) unless detail.old_value.blank?
420 422
421 423 when 'description'
422 424 show_diff = true
423 425 end
424 426 when 'cf'
425 427 custom_field = detail.custom_field
426 428 if custom_field
427 429 label = custom_field.name
428 430 if custom_field.format.class.change_no_details
429 431 no_details = true
430 432 elsif custom_field.format.class.change_as_diff
431 433 show_diff = true
432 434 else
433 435 multiple = custom_field.multiple?
434 436 value = format_value(detail.value, custom_field) if detail.value
435 437 old_value = format_value(detail.old_value, custom_field) if detail.old_value
436 438 end
437 439 end
438 440 when 'attachment'
439 441 label = l(:label_attachment)
440 442 when 'relation'
441 443 if detail.value && !detail.old_value
442 444 rel_issue = Issue.visible.find_by_id(detail.value)
443 445 value = rel_issue.nil? ? "#{l(:label_issue)} ##{detail.value}" :
444 446 (no_html ? rel_issue : link_to_issue(rel_issue, :only_path => options[:only_path]))
445 447 elsif detail.old_value && !detail.value
446 448 rel_issue = Issue.visible.find_by_id(detail.old_value)
447 449 old_value = rel_issue.nil? ? "#{l(:label_issue)} ##{detail.old_value}" :
448 450 (no_html ? rel_issue : link_to_issue(rel_issue, :only_path => options[:only_path]))
449 451 end
450 452 relation_type = IssueRelation::TYPES[detail.prop_key]
451 453 label = l(relation_type[:name]) if relation_type
452 454 end
453 455 call_hook(:helper_issues_show_detail_after_setting,
454 456 {:detail => detail, :label => label, :value => value, :old_value => old_value })
455 457
456 458 label ||= detail.prop_key
457 459 value ||= detail.value
458 460 old_value ||= detail.old_value
459 461
460 462 unless no_html
461 463 label = content_tag('strong', label)
462 464 old_value = content_tag("i", h(old_value)) if detail.old_value
463 465 if detail.old_value && detail.value.blank? && detail.property != 'relation'
464 466 old_value = content_tag("del", old_value)
465 467 end
466 468 if detail.property == 'attachment' && value.present? &&
467 469 atta = detail.journal.journalized.attachments.detect {|a| a.id == detail.prop_key.to_i}
468 470 # Link to the attachment if it has not been removed
469 471 value = link_to_attachment(atta, :download => true, :only_path => options[:only_path])
470 472 if options[:only_path] != false && (atta.is_text? || atta.is_image?)
471 473 value += ' '
472 474 value += link_to(l(:button_view),
473 475 { :controller => 'attachments', :action => 'show',
474 476 :id => atta, :filename => atta.filename },
475 477 :class => 'icon-only icon-magnifier',
476 478 :title => l(:button_view))
477 479 end
478 480 else
479 481 value = content_tag("i", h(value)) if value
480 482 end
481 483 end
482 484
483 485 if no_details
484 486 s = l(:text_journal_changed_no_detail, :label => label).html_safe
485 487 elsif show_diff
486 488 s = l(:text_journal_changed_no_detail, :label => label)
487 489 unless no_html
488 490 diff_link = link_to 'diff',
489 491 diff_journal_url(detail.journal_id, :detail_id => detail.id, :only_path => options[:only_path]),
490 492 :title => l(:label_view_diff)
491 493 s << " (#{ diff_link })"
492 494 end
493 495 s.html_safe
494 496 elsif detail.value.present?
495 497 case detail.property
496 498 when 'attr', 'cf'
497 499 if detail.old_value.present?
498 500 l(:text_journal_changed, :label => label, :old => old_value, :new => value).html_safe
499 501 elsif multiple
500 502 l(:text_journal_added, :label => label, :value => value).html_safe
501 503 else
502 504 l(:text_journal_set_to, :label => label, :value => value).html_safe
503 505 end
504 506 when 'attachment', 'relation'
505 507 l(:text_journal_added, :label => label, :value => value).html_safe
506 508 end
507 509 else
508 510 l(:text_journal_deleted, :label => label, :old => old_value).html_safe
509 511 end
510 512 end
511 513
512 514 # Find the name of an associated record stored in the field attribute
513 515 def find_name_by_reflection(field, id)
514 516 unless id.present?
515 517 return nil
516 518 end
517 519 @detail_value_name_by_reflection ||= Hash.new do |hash, key|
518 520 association = Issue.reflect_on_association(key.first.to_sym)
519 521 name = nil
520 522 if association
521 523 record = association.klass.find_by_id(key.last)
522 524 if record
523 525 name = record.name.force_encoding('UTF-8')
524 526 end
525 527 end
526 528 hash[key] = name
527 529 end
528 530 @detail_value_name_by_reflection[[field, id]]
529 531 end
530 532
531 533 # Renders issue children recursively
532 534 def render_api_issue_children(issue, api)
533 535 return if issue.leaf?
534 536 api.array :children do
535 537 issue.children.each do |child|
536 538 api.issue(:id => child.id) do
537 539 api.tracker(:id => child.tracker_id, :name => child.tracker.name) unless child.tracker.nil?
538 540 api.subject child.subject
539 541 render_api_issue_children(child, api)
540 542 end
541 543 end
542 544 end
543 545 end
544 546 end
General Comments 0
You need to be logged in to leave comments. Login now