jro_apps/redmine Commit - r13293:372b24627b70

Test API authentification once....

Jean-Philippe Lang -

r13293:372b24627b70

parent child

Context file:

r13293:372b24627b70

Collapse all files

test/integration/api_test/authentication_test.rb +73 0

             # Redmine - project management software
             # Copyright (C) 2006-2014  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../../test_helper', __FILE__)
             class Redmine::ApiTest::AuthenticationTest < Redmine::ApiTest::Base
               fixtures :users
               def setup
                 Setting.rest_api_enabled = '1'
               end
               def teardown
                 Setting.rest_api_enabled = '0'
               end
+              def test_api_should_deny_without_credentials
+                get '/users/current.xml', {}
+                assert_response 401
+                assert_equal User.anonymous, User.current
+                assert response.headers.has_key?('WWW-Authenticate')
+              end
+              def test_api_should_accept_http_basic_auth_using_username_and_password
+                user = User.generate! do |user|
+                  user.password = 'my_password'
+                end
+                get '/users/current.xml', {}, credentials(user.login, 'my_password')
+                assert_response 200
+                assert_equal user, User.current
+              end
+              def test_api_should_deny_http_basic_auth_using_username_and_wrong_password
+                user = User.generate! do |user|
+                  user.password = 'my_password'
+                end
+                get '/users/current.xml', {}, credentials(user.login, 'wrong_password')
+                assert_response 401
+                assert_equal User.anonymous, User.current
+              end
+              def test_api_should_accept_http_basic_auth_using_api_key
+                user = User.generate!
+                token = Token.create!(:user => user, :action => 'api')
+                get '/users/current.xml', {}, credentials(token.value, 'X')
+                assert_response 200
+                assert_equal user, User.current
+              end
+              def test_api_should_deny_http_basic_auth_using_wrong_api_key
+                user = User.generate!
+                token = Token.create!(:user => user, :action => 'feeds') # not the API key
+                get '/users/current.xml', {}, credentials(token.value, 'X')
+                assert_response 401
+                assert_equal User.anonymous, User.current
+              end
+              def test_api_should_accept_auth_using_api_key_as_parameter
+                user = User.generate!
+                token = Token.create!(:user => user, :action => 'api')
+                get "/users/current.xml?key=#{token.value}", {}
+                assert_response 200
+                assert_equal user, User.current
+              end
+              def test_api_should_deny_auth_using_wrong_api_key_as_parameter
+                user = User.generate!
+                token = Token.create!(:user => user, :action => 'feeds') # not the API key
+                get "/users/current.xml?key=#{token.value}", {}
+                assert_response 401
+                assert_equal User.anonymous, User.current
+              end
+              def test_api_should_accept_auth_using_api_key_as_request_header
+                user = User.generate!
+                token = Token.create!(:user => user, :action => 'api')
+                get "/users/current.xml", {}, {'X-Redmine-API-Key' => token.value.to_s}
+                assert_response 200
+                assert_equal user, User.current
+              end
+              def test_api_should_deny_auth_using_wrong_api_key_as_request_header
+                user = User.generate!
+                token = Token.create!(:user => user, :action => 'feeds') # not the API key
+                get "/users/current.xml", {}, {'X-Redmine-API-Key' => token.value.to_s}
+                assert_response 401
+                assert_equal User.anonymous, User.current
+              end
               def test_api_should_trigger_basic_http_auth_with_basic_authorization_header
                 ApplicationController.any_instance.expects(:authenticate_with_http_basic).once
                 get '/users/current.xml', {}, credentials('jsmith')
                 assert_response 401
               end
               def test_api_should_not_trigger_basic_http_auth_with_non_basic_authorization_header
                 ApplicationController.any_instance.expects(:authenticate_with_http_basic).never
                 get '/users/current.xml', {}, 'HTTP_AUTHORIZATION' => 'Digest foo bar'
                 assert_response 401
               end
               def test_invalid_utf8_credentials_should_not_trigger_an_error
                 invalid_utf8 = "\x82".force_encoding('UTF-8')
                 assert !invalid_utf8.valid_encoding?
                 assert_nothing_raised do
                   get '/users/current.xml', {}, credentials(invalid_utf8, "foo")
                 end
               end
               def test_api_request_should_not_use_user_session
                 log_user('jsmith', 'jsmith')
                 get '/users/current'
                 assert_response :success
                 get '/users/current.json'
                 assert_response 401
               end
               def test_api_should_accept_switch_user_header_for_admin_user
                 user = User.find(1)
                 su = User.find(4)
                 get '/users/current', {}, {'X-Redmine-API-Key' => user.api_key, 'X-Redmine-Switch-User' => su.login}
                 assert_response :success
                 assert_equal su, assigns(:user)
                 assert_equal su, User.current
               end
               def test_api_should_respond_with_412_when_trying_to_switch_to_a_invalid_user
                 get '/users/current', {}, {'X-Redmine-API-Key' => User.find(1).api_key, 'X-Redmine-Switch-User' => 'foobar'}
                 assert_response 412
               end
               def test_api_should_respond_with_412_when_trying_to_switch_to_a_locked_user
                 user = User.find(5)
                 assert user.locked?
                 get '/users/current', {}, {'X-Redmine-API-Key' => User.find(1).api_key, 'X-Redmine-Switch-User' => user.login}
                 assert_response 412
               end
               def test_api_should_not_accept_switch_user_header_for_non_admin_user
                 user = User.find(2)
                 su = User.find(4)
                 get '/users/current', {}, {'X-Redmine-API-Key' => user.api_key, 'X-Redmine-Switch-User' => su.login}
                 assert_response :success
                 assert_equal user, assigns(:user)
                 assert_equal user, User.current
               end
             end

test/integration/api_test/issues_test.rb 0 -38

             # Redmine - project management software
             # Copyright (C) 2006-2014  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../../test_helper', __FILE__)
             class Redmine::ApiTest::IssuesTest < Redmine::ApiTest::Base
               fixtures :projects,
                 :users,
                 :roles,
                 :members,
                 :member_roles,
                 :issues,
                 :issue_statuses,
                 :issue_relations,
                 :versions,
                 :trackers,
                 :projects_trackers,
                 :issue_categories,
                 :enabled_modules,
                 :enumerations,
                 :attachments,
                 :workflows,
                 :custom_fields,
                 :custom_values,
                 :custom_fields_projects,
                 :custom_fields_trackers,
                 :time_entries,
                 :journals,
                 :journal_details,
                 :queries,
                 :attachments
               def setup
                 Setting.rest_api_enabled = '1'
               end
-              # Use a private project to make sure auth is really working and not just
-              # only showing public issues.
-              should_allow_api_authentication(:get, "/projects/private-child/issues.xml")
-              should_allow_api_authentication(:get, "/projects/private-child/issues.json")
-              should_allow_api_authentication(:get, "/issues/6.xml")
-              should_allow_api_authentication(:get, "/issues/6.json")
-              should_allow_api_authentication(
-                :post,
-                '/issues.xml',
-                {:issue => {:project_id => 1, :subject => 'API test', :tracker_id => 2, :status_id => 3}},
-                {:success_code => :created}
-              should_allow_api_authentication(:post,
-                                              '/issues.json',
-                                              {:issue => {:project_id => 1, :subject => 'API test',
-                                               :tracker_id => 2, :status_id => 3}},
-                                              {:success_code => :created})
-              should_allow_api_authentication(:put,
-                                              '/issues/6.xml',
-                                              {:issue => {:subject => 'API update', :notes => 'A new note'}},
-                                              {:success_code => :ok})
-              should_allow_api_authentication(:put,
-                                              '/issues/6.json',
-                                              {:issue => {:subject => 'API update', :notes => 'A new note'}},
-                                              {:success_code => :ok})
-              should_allow_api_authentication(:delete,
-                                              '/issues/6.xml',
-                                              {},
-                                              {:success_code => :ok})
-              should_allow_api_authentication(:delete,
-                                              '/issues/6.json',
-                                              {},
-                                              {:success_code => :ok})
               test "GET /issues.xml should contain metadata" do
                 get '/issues.xml'
                 assert_select 'issues[type=array][total_count=?][limit="25"][offset="0"]',
                   assigns(:issue_count).to_s
               end
               test "GET /issues.xml with nometa param should not contain metadata" do
                 get '/issues.xml?nometa=1'
                 assert_select 'issues[type=array]:not([total_count]):not([limit]):not([offset])'
               end
               test "GET /issues.xml with nometa header should not contain metadata" do
                 get '/issues.xml', {}, {'X-Redmine-Nometa' => '1'}
                 assert_select 'issues[type=array]:not([total_count]):not([limit]):not([offset])'
               end
               test "GET /issues.xml with offset and limit" do
                 get '/issues.xml?offset=2&limit=3'
                 assert_equal 3, assigns(:limit)
                 assert_equal 2, assigns(:offset)
                 assert_select 'issues issue', 3
               end
               test "GET /issues.xml with relations" do
                 get '/issues.xml?include=relations'
                 assert_response :success
                 assert_equal 'application/xml', @response.content_type
                 assert_select 'issue id:content(3)' do
                   assert_select '~ relations relation', 1
                   assert_select '~ relations relation[id="2"][issue_id="2"][issue_to_id="3"][relation_type=relates]'
                 end
                 assert_select 'issue id:content(1)' do
                   assert_select '~ relations'
                   assert_select '~ relations relation', 0
                 end
               end
               test "GET /issues.xml with invalid query params" do
                 get '/issues.xml', {:f => ['start_date'], :op => {:start_date => '='}}
                 assert_response :unprocessable_entity
                 assert_equal 'application/xml', @response.content_type
                 assert_select 'errors error', :text => "Start date can't be blank"
               end
               test "GET /issues.xml with custom field filter" do
                 get '/issues.xml',
                   {:set_filter => 1, :f => ['cf_1'], :op => {:cf_1 => '='}, :v => {:cf_1 => ['MySQL']}}
                 expected_ids = Issue.visible.
                     joins(:custom_values).
                     where(:custom_values => {:custom_field_id => 1, :value => 'MySQL'}).map(&:id)
                 assert expected_ids.any?
                 assert_select 'issues > issue > id', :count => expected_ids.count do |ids|
                    ids.each { |id| assert expected_ids.delete(id.children.first.content.to_i) }
                 end
               end
               test "GET /issues.xml with custom field filter (shorthand method)" do
                 get '/issues.xml', {:cf_1 => 'MySQL'}
                 expected_ids = Issue.visible.
                     joins(:custom_values).
                     where(:custom_values => {:custom_field_id => 1, :value => 'MySQL'}).map(&:id)
                 assert expected_ids.any?
                 assert_select 'issues > issue > id', :count => expected_ids.count do |ids|
                   ids.each { |id| assert expected_ids.delete(id.children.first.content.to_i) }
                 end
               end
               def test_index_should_include_issue_attributes
                 get '/issues.xml'
                 assert_select 'issues>issue>is_private', :text => 'false'
               end
               def test_index_should_allow_timestamp_filtering
                 Issue.delete_all
                 Issue.generate!(:subject => '1').update_column(:updated_on, Time.parse("2014-01-02T10:25:00Z"))
                 Issue.generate!(:subject => '2').update_column(:updated_on, Time.parse("2014-01-02T12:13:00Z"))
                 get '/issues.xml',
                   {:set_filter => 1, :f => ['updated_on'], :op => {:updated_on => '<='},
                    :v => {:updated_on => ['2014-01-02T12:00:00Z']}}
                 assert_select 'issues>issue', :count => 1
                 assert_select 'issues>issue>subject', :text => '1'
                 get '/issues.xml',
                   {:set_filter => 1, :f => ['updated_on'], :op => {:updated_on => '>='},
                    :v => {:updated_on => ['2014-01-02T12:00:00Z']}}
                 assert_select 'issues>issue', :count => 1
                 assert_select 'issues>issue>subject', :text => '2'
                 get '/issues.xml',
                   {:set_filter => 1, :f => ['updated_on'], :op => {:updated_on => '>='},
                    :v => {:updated_on => ['2014-01-02T08:00:00Z']}}
                 assert_select 'issues>issue', :count => 2
               end
               test "GET /issues.xml with filter" do
                 get '/issues.xml?status_id=5'
                 expected_ids = Issue.visible.where(:status_id => 5).map(&:id)
                 assert expected_ids.any?
                 assert_select 'issues > issue > id', :count => expected_ids.count do |ids|
                    ids.each { |id| assert expected_ids.delete(id.children.first.content.to_i) }
                 end
               end
               test "GET /issues.json with filter" do
                 get '/issues.json?status_id=5'
                 json = ActiveSupport::JSON.decode(response.body)
                 status_ids_used = json['issues'].collect {|j| j['status']['id'] }
                 assert_equal 3, status_ids_used.length
                 assert status_ids_used.all? {|id| id == 5 }
               end
               test "GET /issues/:id.xml with journals" do
                 get '/issues/1.xml?include=journals'
                 assert_select 'issue journals[type=array]' do
                   assert_select 'journal[id="1"]' do
                     assert_select 'details[type=array]' do
                       assert_select 'detail[name=status_id]' do
                         assert_select 'old_value', :text => '1'
                         assert_select 'new_value', :text => '2'
                       end
                     end
                   end
                 end
               end
               test "GET /issues/:id.xml with custom fields" do
                 get '/issues/3.xml'
                 assert_select 'issue custom_fields[type=array]' do
                   assert_select 'custom_field[id="1"]' do
                     assert_select 'value', :text => 'MySQL'
                   end
                 end
                 assert_nothing_raised do
                   Hash.from_xml(response.body).to_xml
                 end
               end
               test "GET /issues/:id.xml with multi custom fields" do
                 field = CustomField.find(1)
                 field.update_attribute :multiple, true
                 issue = Issue.find(3)
                 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
                 issue.save!
                 get '/issues/3.xml'
                 assert_response :success
                 assert_select 'issue custom_fields[type=array]' do
                   assert_select 'custom_field[id="1"]' do
                     assert_select 'value[type=array] value', 2
                   end
                 end
                 xml = Hash.from_xml(response.body)
                 custom_fields = xml['issue']['custom_fields']
                 assert_kind_of Array, custom_fields
                 field = custom_fields.detect {|f| f['id'] == '1'}
                 assert_kind_of Hash, field
                 assert_equal ['MySQL', 'Oracle'], field['value'].sort
               end
               test "GET /issues/:id.json with multi custom fields" do
                 field = CustomField.find(1)
                 field.update_attribute :multiple, true
                 issue = Issue.find(3)
                 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
                 issue.save!
                 get '/issues/3.json'
                 assert_response :success
                 json = ActiveSupport::JSON.decode(response.body)
                 custom_fields = json['issue']['custom_fields']
                 assert_kind_of Array, custom_fields
                 field = custom_fields.detect {|f| f['id'] == 1}
                 assert_kind_of Hash, field
                 assert_equal ['MySQL', 'Oracle'], field['value'].sort
               end
               test "GET /issues/:id.xml with empty value for multi custom field" do
                 field = CustomField.find(1)
                 field.update_attribute :multiple, true
                 issue = Issue.find(3)
                 issue.custom_field_values = {1 => ['']}
                 issue.save!
                 get '/issues/3.xml'
                 assert_select 'issue custom_fields[type=array]' do
                   assert_select 'custom_field[id="1"]' do
                     assert_select 'value[type=array]:empty'
                   end
                 end
                 xml = Hash.from_xml(response.body)
                 custom_fields = xml['issue']['custom_fields']
                 assert_kind_of Array, custom_fields
                 field = custom_fields.detect {|f| f['id'] == '1'}
                 assert_kind_of Hash, field
                 assert_equal [], field['value']
               end
               test "GET /issues/:id.json with empty value for multi custom field" do
                 field = CustomField.find(1)
                 field.update_attribute :multiple, true
                 issue = Issue.find(3)
                 issue.custom_field_values = {1 => ['']}
                 issue.save!
                 get '/issues/3.json'
                 assert_response :success
                 json = ActiveSupport::JSON.decode(response.body)
                 custom_fields = json['issue']['custom_fields']
                 assert_kind_of Array, custom_fields
                 field = custom_fields.detect {|f| f['id'] == 1}
                 assert_kind_of Hash, field
                 assert_equal [], field['value'].sort
               end
               test "GET /issues/:id.xml with attachments" do
                 get '/issues/3.xml?include=attachments'
                 assert_select 'issue attachments[type=array]' do
                   assert_select 'attachment', 5
                   assert_select 'attachment id:content(4)' do
                     assert_select '~ filename', :text => 'source.rb'
                     assert_select '~ content_url', :text => 'http://www.example.com/attachments/download/4/source.rb'
                   end
                 end
               end
               test "GET /issues/:id.xml with subtasks" do
                 issue = Issue.generate_with_descendants!(:project_id => 1)
                 get "/issues/#{issue.id}.xml?include=children"
                 assert_select 'issue children[type=array]' do
                   assert_select 'issue', 2
                   assert_select 'issue children', 1
                 end
               end
               test "GET /issues/:id.json with subtasks" do
                 issue = Issue.generate_with_descendants!(:project_id => 1)
                 get "/issues/#{issue.id}.json?include=children"
                 json = ActiveSupport::JSON.decode(response.body)
                 assert_equal 2, json['issue']['children'].size
                 assert_equal 1, json['issue']['children'].select {|child| child.key?('children')}.size
               end
               def test_show_should_include_issue_attributes
                 get '/issues/1.xml'
                 assert_select 'issue>is_private', :text => 'false'
               end
               test "GET /issues/:id.xml?include=watchers should include watchers" do
                 Watcher.create!(:user_id => 3, :watchable => Issue.find(1))
                 get '/issues/1.xml?include=watchers', {}, credentials('jsmith')
                 assert_response :ok
                 assert_equal 'application/xml', response.content_type
                 assert_select 'issue' do
                   assert_select 'watchers', Issue.find(1).watchers.count
                   assert_select 'watchers' do
                     assert_select 'user[id=3]'
                   end
                 end
               end
               test "POST /issues.xml should create an issue with the attributes" do
                 assert_difference('Issue.count') do
                   post '/issues.xml',
                        {:issue => {:project_id => 1, :subject => 'API test',
                         :tracker_id => 2, :status_id => 3}}, credentials('jsmith')
                 end
                 issue = Issue.order('id DESC').first
                 assert_equal 1, issue.project_id
                 assert_equal 2, issue.tracker_id
                 assert_equal 3, issue.status_id
                 assert_equal 'API test', issue.subject
                 assert_response :created
                 assert_equal 'application/xml', @response.content_type
                 assert_select 'issue > id', :text => issue.id.to_s
               end
               test "POST /issues.xml with watcher_user_ids should create issue with watchers" do
                 assert_difference('Issue.count') do
                   post '/issues.xml',
                        {:issue => {:project_id => 1, :subject => 'Watchers',
                         :tracker_id => 2, :status_id => 3, :watcher_user_ids => [3, 1]}}, credentials('jsmith')
                   assert_response :created
                 end
                 issue = Issue.order('id desc').first
                 assert_equal 2, issue.watchers.size
                 assert_equal [1, 3], issue.watcher_user_ids.sort
               end
               test "POST /issues.xml with failure should return errors" do
                 assert_no_difference('Issue.count') do
                   post '/issues.xml', {:issue => {:project_id => 1}}, credentials('jsmith')
                 end
                 assert_select 'errors error', :text => "Subject can't be blank"
               end
               test "POST /issues.json should create an issue with the attributes" do
                 assert_difference('Issue.count') do
                   post '/issues.json',
                        {:issue => {:project_id => 1, :subject => 'API test',
                                    :tracker_id => 2, :status_id => 3}},
                        credentials('jsmith')
                 end
                 issue = Issue.order('id DESC').first
                 assert_equal 1, issue.project_id
                 assert_equal 2, issue.tracker_id
                 assert_equal 3, issue.status_id
                 assert_equal 'API test', issue.subject
               end
               test "POST /issues.json with failure should return errors" do
                 assert_no_difference('Issue.count') do
                   post '/issues.json', {:issue => {:project_id => 1}}, credentials('jsmith')
                 end
                 json = ActiveSupport::JSON.decode(response.body)
                 assert json['errors'].include?("Subject can't be blank")
               end
               test "PUT /issues/:id.xml" do
                 assert_difference('Journal.count') do
                   put '/issues/6.xml',
                     {:issue => {:subject => 'API update', :notes => 'A new note'}},
                     credentials('jsmith')
                 end
                 issue = Issue.find(6)
                 assert_equal "API update", issue.subject
                 journal = Journal.last
                 assert_equal "A new note", journal.notes
               end
               test "PUT /issues/:id.xml with custom fields" do
                 put '/issues/3.xml',
                   {:issue => {:custom_fields => [
                     {'id' => '1', 'value' => 'PostgreSQL' },
                     {'id' => '2', 'value' => '150'}
                     ]}},
                   credentials('jsmith')
                 issue = Issue.find(3)
                 assert_equal '150', issue.custom_value_for(2).value
                 assert_equal 'PostgreSQL', issue.custom_value_for(1).value
               end
               test "PUT /issues/:id.xml with multi custom fields" do
                 field = CustomField.find(1)
                 field.update_attribute :multiple, true
                 put '/issues/3.xml',
                   {:issue => {:custom_fields => [
                     {'id' => '1', 'value' => ['MySQL', 'PostgreSQL'] },
                     {'id' => '2', 'value' => '150'}
                     ]}},
                   credentials('jsmith')
                 issue = Issue.find(3)
                 assert_equal '150', issue.custom_value_for(2).value
                 assert_equal ['MySQL', 'PostgreSQL'], issue.custom_field_value(1).sort
               end
               test "PUT /issues/:id.xml with project change" do
                 put '/issues/3.xml',
                   {:issue => {:project_id => 2, :subject => 'Project changed'}},
                   credentials('jsmith')
                 issue = Issue.find(3)
                 assert_equal 2, issue.project_id
                 assert_equal 'Project changed', issue.subject
               end
               test "PUT /issues/:id.xml with failed update" do
                 put '/issues/6.xml', {:issue => {:subject => ''}}, credentials('jsmith')
                 assert_response :unprocessable_entity
                 assert_select 'errors error', :text => "Subject can't be blank"
               end
               test "PUT /issues/:id.json" do
                 assert_difference('Journal.count') do
                   put '/issues/6.json',
                     {:issue => {:subject => 'API update', :notes => 'A new note'}},
                     credentials('jsmith')
                   assert_response :ok
                   assert_equal '', response.body
                 end
                 issue = Issue.find(6)
                 assert_equal "API update", issue.subject
                 journal = Journal.last
                 assert_equal "A new note", journal.notes
               end
               test "PUT /issues/:id.json with failed update" do
                 put '/issues/6.json', {:issue => {:subject => ''}}, credentials('jsmith')
                 assert_response :unprocessable_entity
                 json = ActiveSupport::JSON.decode(response.body)
                 assert json['errors'].include?("Subject can't be blank")
               end
               test "DELETE /issues/:id.xml" do
                 assert_difference('Issue.count', -1) do
                   delete '/issues/6.xml', {}, credentials('jsmith')
                   assert_response :ok
                   assert_equal '', response.body
                 end
                 assert_nil Issue.find_by_id(6)
               end
               test "DELETE /issues/:id.json" do
                 assert_difference('Issue.count', -1) do
                   delete '/issues/6.json', {}, credentials('jsmith')
                   assert_response :ok
                   assert_equal '', response.body
                 end
                 assert_nil Issue.find_by_id(6)
               end
               test "POST /issues/:id/watchers.xml should add watcher" do
                 assert_difference 'Watcher.count' do
                   post '/issues/1/watchers.xml', {:user_id => 3}, credentials('jsmith')
                   assert_response :ok
                   assert_equal '', response.body
                 end
                 watcher = Watcher.order('id desc').first
                 assert_equal Issue.find(1), watcher.watchable
                 assert_equal User.find(3), watcher.user
               end
               test "DELETE /issues/:id/watchers/:user_id.xml should remove watcher" do
                 Watcher.create!(:user_id => 3, :watchable => Issue.find(1))
                 assert_difference 'Watcher.count', -1 do
                   delete '/issues/1/watchers/3.xml', {}, credentials('jsmith')
                   assert_response :ok
                   assert_equal '', response.body
                 end
                 assert_equal false, Issue.find(1).watched_by?(User.find(3))
               end
               def test_create_issue_with_uploaded_file
                 set_tmp_attachments_directory
                 # upload the file
                 assert_difference 'Attachment.count' do
                   post '/uploads.xml', 'test_create_with_upload',
                        {"CONTENT_TYPE" => 'application/octet-stream'}.merge(credentials('jsmith'))
                   assert_response :created
                 end
                 xml = Hash.from_xml(response.body)
                 token = xml['upload']['token']
                 attachment = Attachment.order('id DESC').first
                 # create the issue with the upload's token
                 assert_difference 'Issue.count' do
                   post '/issues.xml',
                        {:issue => {:project_id => 1, :subject => 'Uploaded file',
                                    :uploads => [{:token => token, :filename => 'test.txt',
                                                  :content_type => 'text/plain'}]}},
                        credentials('jsmith')
                   assert_response :created
                 end
                 issue = Issue.order('id DESC').first
                 assert_equal 1, issue.attachments.count
                 assert_equal attachment, issue.attachments.first
                 attachment.reload
                 assert_equal 'test.txt', attachment.filename
                 assert_equal 'text/plain', attachment.content_type
                 assert_equal 'test_create_with_upload'.size, attachment.filesize
                 assert_equal 2, attachment.author_id
                 # get the issue with its attachments
                 get "/issues/#{issue.id}.xml", :include => 'attachments'
                 assert_response :success
                 xml = Hash.from_xml(response.body)
                 attachments = xml['issue']['attachments']
                 assert_kind_of Array, attachments
                 assert_equal 1, attachments.size
                 url = attachments.first['content_url']
                 assert_not_nil url
                 # download the attachment
                 get url
                 assert_response :success
               end
               def test_update_issue_with_uploaded_file
                 set_tmp_attachments_directory
                 # upload the file
                 assert_difference 'Attachment.count' do
                   post '/uploads.xml', 'test_upload_with_upload',
                        {"CONTENT_TYPE" => 'application/octet-stream'}.merge(credentials('jsmith'))
                   assert_response :created
                 end
                 xml = Hash.from_xml(response.body)
                 token = xml['upload']['token']
                 attachment = Attachment.order('id DESC').first
                 # update the issue with the upload's token
                 assert_difference 'Journal.count' do
                   put '/issues/1.xml',
                       {:issue => {:notes => 'Attachment added',
                                   :uploads => [{:token => token, :filename => 'test.txt',
                                                 :content_type => 'text/plain'}]}},
                       credentials('jsmith')
                   assert_response :ok
                   assert_equal '', @response.body
                 end
                 issue = Issue.find(1)
                 assert_include attachment, issue.attachments
               end
             end

test/integration/api_test/news_test.rb 0 -3

             # Redmine - project management software
             # Copyright (C) 2006-2014  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../../test_helper', __FILE__)
             class Redmine::ApiTest::NewsTest < Redmine::ApiTest::Base
               fixtures :projects, :trackers, :issue_statuses, :issues,
                        :enumerations, :users, :issue_categories,
                        :projects_trackers,
                        :roles,
                        :member_roles,
                        :members,
                        :enabled_modules,
                        :news
               def setup
                 Setting.rest_api_enabled = '1'
               end
-              should_allow_api_authentication(:get, "/projects/onlinestore/news.xml")
-              should_allow_api_authentication(:get, "/projects/onlinestore/news.json")
               test "GET /news.xml should return news" do
                 get '/news.xml'
                 assert_select 'news[type=array] news id', :text => '2'
               end
               test "GET /news.json should return news" do
                 get '/news.json'
                 json = ActiveSupport::JSON.decode(response.body)
                 assert_kind_of Hash, json
                 assert_kind_of Array, json['news']
                 assert_kind_of Hash, json['news'].first
                 assert_equal 2, json['news'].first['id']
               end
               test "GET /projects/:project_id/news.xml should return news" do
                 get '/projects/ecookbook/news.xml'
                 assert_select 'news[type=array] news id', :text => '2'
               end
               test "GET /projects/:project_id/news.json should return news" do
                 get '/projects/ecookbook/news.json'
                 json = ActiveSupport::JSON.decode(response.body)
                 assert_kind_of Hash, json
                 assert_kind_of Array, json['news']
                 assert_kind_of Hash, json['news'].first
                 assert_equal 2, json['news'].first['id']
               end
             end

test/integration/api_test/projects_test.rb 0 -17

             # Redmine - project management software
             # Copyright (C) 2006-2014  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../../test_helper', __FILE__)
             class Redmine::ApiTest::ProjectsTest < Redmine::ApiTest::Base
               fixtures :projects, :versions, :users, :roles, :members, :member_roles, :issues, :journals, :journal_details,
                        :trackers, :projects_trackers, :issue_statuses, :enabled_modules, :enumerations, :boards, :messages,
                        :attachments, :custom_fields, :custom_values, :time_entries, :issue_categories
               def setup
                 Setting.rest_api_enabled = '1'
                 set_tmp_attachments_directory
               end
-              # TODO: A private project is needed because should_allow_api_authentication
-              # actually tests that authentication is *required*, not just allowed
-              should_allow_api_authentication(:get, "/projects/2.xml")
-              should_allow_api_authentication(:get, "/projects/2.json")
-              should_allow_api_authentication(:post,
-                                              '/projects.xml',
-                                              {:project => {:name => 'API test', :identifier => 'api-test'}},
-                                              {:success_code => :created})
-              should_allow_api_authentication(:put,
-                                              '/projects/2.xml',
-                                              {:project => {:name => 'API update'}},
-                                              {:success_code => :ok})
-              should_allow_api_authentication(:delete,
-                                              '/projects/2.xml',
-                                              {},
-                                              {:success_code => :ok})
               test "GET /projects.xml should return projects" do
                 get '/projects.xml'
                 assert_response :success
                 assert_equal 'application/xml', @response.content_type
                 assert_select 'projects>project>id', :text => '1'
                 assert_select 'projects>project>status', :text => '1'
                 assert_select 'projects>project>is_public', :text => 'true'
               end
               test "GET /projects.json should return projects" do
                 get '/projects.json'
                 assert_response :success
                 assert_equal 'application/json', @response.content_type
                 json = ActiveSupport::JSON.decode(response.body)
                 assert_kind_of Hash, json
                 assert_kind_of Array, json['projects']
                 assert_kind_of Hash, json['projects'].first
                 assert json['projects'].first.has_key?('id')
               end
               test "GET /projects.xml with include=issue_categories should return categories" do
                 get '/projects.xml?include=issue_categories'
                 assert_response :success
                 assert_equal 'application/xml', @response.content_type
                 assert_select 'issue_categories[type=array] issue_category[id=2][name=Recipes]'
               end
               test "GET /projects.xml with include=trackers should return trackers" do
                 get '/projects.xml?include=trackers'
                 assert_response :success
                 assert_equal 'application/xml', @response.content_type
                 assert_select 'trackers[type=array] tracker[id=2][name=Feature request]'
               end
               test "GET /projects.xml with include=enabled_modules should return enabled modules" do
                 get '/projects.xml?include=enabled_modules'
                 assert_response :success
                 assert_equal 'application/xml', @response.content_type
                 assert_select 'enabled_modules[type=array] enabled_module[name=issue_tracking]'
               end
               test "GET /projects/:id.xml should return the project" do
                 get '/projects/1.xml'
                 assert_response :success
                 assert_equal 'application/xml', @response.content_type
                 assert_select 'project>id', :text => '1'
                 assert_select 'project>status', :text => '1'
                 assert_select 'project>is_public', :text => 'true'
                 assert_select 'custom_field[name=Development status]', :text => 'Stable'
                 assert_select 'trackers', 0
                 assert_select 'issue_categories', 0
               end
               test "GET /projects/:id.json should return the project" do
                 get '/projects/1.json'
                 json = ActiveSupport::JSON.decode(response.body)
                 assert_kind_of Hash, json
                 assert_kind_of Hash, json['project']
                 assert_equal 1, json['project']['id']
               end
               test "GET /projects/:id.xml with hidden custom fields should not display hidden custom fields" do
                 ProjectCustomField.find_by_name('Development status').update_attribute :visible, false
                 get '/projects/1.xml'
                 assert_response :success
                 assert_equal 'application/xml', @response.content_type
                 assert_select 'custom_field[name=?]', 'Development status', 0
               end
               test "GET /projects/:id.xml with include=issue_categories should return categories" do
                 get '/projects/1.xml?include=issue_categories'
                 assert_response :success
                 assert_equal 'application/xml', @response.content_type
                 assert_select 'issue_categories[type=array] issue_category[id=2][name=Recipes]'
               end
               test "GET /projects/:id.xml with include=trackers should return trackers" do
                 get '/projects/1.xml?include=trackers'
                 assert_response :success
                 assert_equal 'application/xml', @response.content_type
                 assert_select 'trackers[type=array] tracker[id=2][name=Feature request]'
               end
               test "GET /projects/:id.xml with include=enabled_modules should return enabled modules" do
                 get '/projects/1.xml?include=enabled_modules'
                 assert_response :success
                 assert_equal 'application/xml', @response.content_type
                 assert_select 'enabled_modules[type=array] enabled_module[name=issue_tracking]'
               end
               test "POST /projects.xml with valid parameters should create the project" do
                 with_settings :default_projects_modules => ['issue_tracking', 'repository'] do
                   assert_difference('Project.count') do
                     post '/projects.xml',
                       {:project => {:name => 'API test', :identifier => 'api-test'}},
                       credentials('admin')
                   end
                 end
                 project = Project.order('id DESC').first
                 assert_equal 'API test', project.name
                 assert_equal 'api-test', project.identifier
                 assert_equal ['issue_tracking', 'repository'], project.enabled_module_names.sort
                 assert_equal Tracker.all.size, project.trackers.size
                 assert_response :created
                 assert_equal 'application/xml', @response.content_type
                 assert_select 'project id', :text => project.id.to_s
               end
               test "POST /projects.xml should accept enabled_module_names attribute" do
                 assert_difference('Project.count') do
                   post '/projects.xml',
                     {:project => {:name => 'API test', :identifier => 'api-test', :enabled_module_names => ['issue_tracking', 'news', 'time_tracking']}},
                     credentials('admin')
                 end
                 project = Project.order('id DESC').first
                 assert_equal ['issue_tracking', 'news', 'time_tracking'], project.enabled_module_names.sort
               end
               test "POST /projects.xml should accept tracker_ids attribute" do
                 assert_difference('Project.count') do
                   post '/projects.xml',
                     {:project => {:name => 'API test', :identifier => 'api-test', :tracker_ids => [1, 3]}},
                     credentials('admin')
                 end
                 project = Project.order('id DESC').first
                 assert_equal [1, 3], project.trackers.map(&:id).sort
               end
               test "POST /projects.xml with invalid parameters should return errors" do
                 assert_no_difference('Project.count') do
                   post '/projects.xml', {:project => {:name => 'API test'}}, credentials('admin')
                 end
                 assert_response :unprocessable_entity
                 assert_equal 'application/xml', @response.content_type
                 assert_select 'errors error', :text => "Identifier can't be blank"
               end
               test "PUT /projects/:id.xml with valid parameters should update the project" do
                 assert_no_difference 'Project.count' do
                   put '/projects/2.xml', {:project => {:name => 'API update'}}, credentials('jsmith')
                 end
                 assert_response :ok
                 assert_equal '', @response.body
                 assert_equal 'application/xml', @response.content_type
                 project = Project.find(2)
                 assert_equal 'API update', project.name
               end
               test "PUT /projects/:id.xml should accept enabled_module_names attribute" do
                 assert_no_difference 'Project.count' do
                   put '/projects/2.xml', {:project => {:name => 'API update', :enabled_module_names => ['issue_tracking', 'news', 'time_tracking']}}, credentials('admin')
                 end
                 assert_response :ok
                 assert_equal '', @response.body
                 project = Project.find(2)
                 assert_equal ['issue_tracking', 'news', 'time_tracking'], project.enabled_module_names.sort
               end
               test "PUT /projects/:id.xml should accept tracker_ids attribute" do
                 assert_no_difference 'Project.count' do
                   put '/projects/2.xml', {:project => {:name => 'API update', :tracker_ids => [1, 3]}}, credentials('admin')
                 end
                 assert_response :ok
                 assert_equal '', @response.body
                 project = Project.find(2)
                 assert_equal [1, 3], project.trackers.map(&:id).sort
               end
               test "PUT /projects/:id.xml with invalid parameters should return errors" do
                 assert_no_difference('Project.count') do
                   put '/projects/2.xml', {:project => {:name => ''}}, credentials('admin')
                 end
                 assert_response :unprocessable_entity
                 assert_equal 'application/xml', @response.content_type
                 assert_select 'errors error', :text => "Name can't be blank"
               end
               test "DELETE /projects/:id.xml should delete the project" do
                 assert_difference('Project.count',-1) do
                   delete '/projects/2.xml', {}, credentials('admin')
                 end
                 assert_response :ok
                 assert_equal '', @response.body
                 assert_nil Project.find_by_id(2)
               end
             end

test/integration/api_test/users_test.rb 0 -39

             # Redmine - project management software
             # Copyright (C) 2006-2014  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../../test_helper', __FILE__)
             class Redmine::ApiTest::UsersTest < Redmine::ApiTest::Base
               fixtures :users, :members, :member_roles, :roles, :projects
               def setup
                 Setting.rest_api_enabled = '1'
               end
-              should_allow_api_authentication(:get, "/users.xml")
-              should_allow_api_authentication(:get, "/users.json")
-              should_allow_api_authentication(:post,
-                '/users.xml',
-                 {:user => {
-                    :login => 'foo', :firstname => 'Firstname', :lastname => 'Lastname',
-                    :mail => 'foo@example.net', :password => 'secret123'
-                  }},
-                {:success_code => :created})
-              should_allow_api_authentication(:post,
-                '/users.json',
-                {:user => {
-                   :login => 'foo', :firstname => 'Firstname', :lastname => 'Lastname',
-                   :mail => 'foo@example.net'
-                }},
-                {:success_code => :created})
-              should_allow_api_authentication(:put,
-                '/users/2.xml',
-                {:user => {
-                    :login => 'jsmith', :firstname => 'John', :lastname => 'Renamed',
-                    :mail => 'jsmith@somenet.foo'
-                }},
-                {:success_code => :ok})
-              should_allow_api_authentication(:put,
-                '/users/2.json',
-                {:user => {
-                    :login => 'jsmith', :firstname => 'John', :lastname => 'Renamed',
-                    :mail => 'jsmith@somenet.foo'
-                }},
-                {:success_code => :ok})
-              should_allow_api_authentication(:delete,
-                '/users/2.xml',
-                {},
-                {:success_code => :ok})
-              should_allow_api_authentication(:delete,
-                '/users/2.xml',
-                {},
-                {:success_code => :ok})
               test "GET /users/:id.xml should return the user" do
                 get '/users/2.xml'
                 assert_response :success
                 assert_select 'user id', :text => '2'
               end
               test "GET /users/:id.json should return the user" do
                 get '/users/2.json'
                 assert_response :success
                 json = ActiveSupport::JSON.decode(response.body)
                 assert_kind_of Hash, json
                 assert_kind_of Hash, json['user']
                 assert_equal 2, json['user']['id']
               end
               test "GET /users/:id.xml with include=memberships should include memberships" do
                 get '/users/2.xml?include=memberships'
                 assert_response :success
                 assert_select 'user memberships', 1
               end
               test "GET /users/:id.json with include=memberships should include memberships" do
                 get '/users/2.json?include=memberships'
                 assert_response :success
                 json = ActiveSupport::JSON.decode(response.body)
                 assert_kind_of Array, json['user']['memberships']
                 assert_equal [{
                   "id"=>1,
                   "project"=>{"name"=>"eCookbook", "id"=>1},
                   "roles"=>[{"name"=>"Manager", "id"=>1}]
                 }], json['user']['memberships']
               end
               test "GET /users/current.xml should require authentication" do
                 get '/users/current.xml'
                 assert_response 401
               end
               test "GET /users/current.xml should return current user" do
                 get '/users/current.xml', {}, credentials('jsmith')
                 assert_select 'user id', :text => '2'
               end
               test "GET /users/:id should not return login for other user" do
                 get '/users/3.xml', {}, credentials('jsmith')
                 assert_response :success
                 assert_select 'user login', 0
               end
               test "GET /users/:id should return login for current user" do
                 get '/users/2.xml', {}, credentials('jsmith')
                 assert_response :success
                 assert_select 'user login', :text => 'jsmith'
               end
               test "GET /users/:id should not return api_key for other user" do
                 get '/users/3.xml', {}, credentials('jsmith')
                 assert_response :success
                 assert_select 'user api_key', 0
               end
               test "GET /users/:id should return api_key for current user" do
                 get '/users/2.xml', {}, credentials('jsmith')
                 assert_response :success
                 assert_select 'user api_key', :text => User.find(2).api_key
               end
               test "GET /users/:id should not return status for standard user" do
                 get '/users/3.xml', {}, credentials('jsmith')
                 assert_response :success
                 assert_select 'user status', 0
               end
               test "GET /users/:id should return status for administrators" do
                 get '/users/2.xml', {}, credentials('admin')
                 assert_response :success
                 assert_select 'user status', :text => User.find(1).status.to_s
               end
               test "POST /users.xml with valid parameters should create the user" do
                 assert_difference('User.count') do
                   post '/users.xml', {
                     :user => {
                       :login => 'foo', :firstname => 'Firstname', :lastname => 'Lastname',
                       :mail => 'foo@example.net', :password => 'secret123',
                       :mail_notification => 'only_assigned'}
                     },
                     credentials('admin')
                 end
                 user = User.order('id DESC').first
                 assert_equal 'foo', user.login
                 assert_equal 'Firstname', user.firstname
                 assert_equal 'Lastname', user.lastname
                 assert_equal 'foo@example.net', user.mail
                 assert_equal 'only_assigned', user.mail_notification
                 assert !user.admin?
                 assert user.check_password?('secret123')
                 assert_response :created
                 assert_equal 'application/xml', @response.content_type
                 assert_select 'user id', :text => user.id.to_s
               end
               test "POST /users.json with valid parameters should create the user" do
                 assert_difference('User.count') do
                   post '/users.json', {
                     :user => {
                       :login => 'foo', :firstname => 'Firstname', :lastname => 'Lastname',
                       :mail => 'foo@example.net', :password => 'secret123',
                       :mail_notification => 'only_assigned'}
                     },
                     credentials('admin')
                 end
                 user = User.order('id DESC').first
                 assert_equal 'foo', user.login
                 assert_equal 'Firstname', user.firstname
                 assert_equal 'Lastname', user.lastname
                 assert_equal 'foo@example.net', user.mail
                 assert !user.admin?
                 assert_response :created
                 assert_equal 'application/json', @response.content_type
                 json = ActiveSupport::JSON.decode(response.body)
                 assert_kind_of Hash, json
                 assert_kind_of Hash, json['user']
                 assert_equal user.id, json['user']['id']
               end
               test "POST /users.xml with with invalid parameters should return errors" do
                 assert_no_difference('User.count') do
                   post '/users.xml', {:user => {:login => 'foo', :lastname => 'Lastname', :mail => 'foo'}}, credentials('admin')
                 end
                 assert_response :unprocessable_entity
                 assert_equal 'application/xml', @response.content_type
                 assert_select 'errors error', :text => "First name can't be blank"
               end
               test "POST /users.json with with invalid parameters should return errors" do
                 assert_no_difference('User.count') do
                   post '/users.json', {:user => {:login => 'foo', :lastname => 'Lastname', :mail => 'foo'}}, credentials('admin')
                 end
                 assert_response :unprocessable_entity
                 assert_equal 'application/json', @response.content_type
                 json = ActiveSupport::JSON.decode(response.body)
                 assert_kind_of Hash, json
                 assert json.has_key?('errors')
                 assert_kind_of Array, json['errors']
               end
               test "PUT /users/:id.xml with valid parameters should update the user" do
                 assert_no_difference('User.count') do
                   put '/users/2.xml', {
                     :user => {
                       :login => 'jsmith', :firstname => 'John', :lastname => 'Renamed',
                       :mail => 'jsmith@somenet.foo'}
                     },
                     credentials('admin')
                 end
                 user = User.find(2)
                 assert_equal 'jsmith', user.login
                 assert_equal 'John', user.firstname
                 assert_equal 'Renamed', user.lastname
                 assert_equal 'jsmith@somenet.foo', user.mail
                 assert !user.admin?
                 assert_response :ok
                 assert_equal '', @response.body
               end
               test "PUT /users/:id.json with valid parameters should update the user" do
                 assert_no_difference('User.count') do
                   put '/users/2.json', {
                     :user => {
                       :login => 'jsmith', :firstname => 'John', :lastname => 'Renamed',
                       :mail => 'jsmith@somenet.foo'}
                     },
                     credentials('admin')
                 end
                 user = User.find(2)
                 assert_equal 'jsmith', user.login
                 assert_equal 'John', user.firstname
                 assert_equal 'Renamed', user.lastname
                 assert_equal 'jsmith@somenet.foo', user.mail
                 assert !user.admin?
                 assert_response :ok
                 assert_equal '', @response.body
               end
               test "PUT /users/:id.xml with invalid parameters" do
                 assert_no_difference('User.count') do
                   put '/users/2.xml', {
                     :user => {
                       :login => 'jsmith', :firstname => '', :lastname => 'Lastname',
                       :mail => 'foo'}
                     },
                     credentials('admin')
                 end
                 assert_response :unprocessable_entity
                 assert_equal 'application/xml', @response.content_type
                 assert_select 'errors error', :text => "First name can't be blank"
               end
               test "PUT /users/:id.json with invalid parameters" do
                 assert_no_difference('User.count') do
                   put '/users/2.json', {
                     :user => {
                       :login => 'jsmith', :firstname => '', :lastname => 'Lastname',
                       :mail => 'foo'}
                     },
                     credentials('admin')
                 end
                 assert_response :unprocessable_entity
                 assert_equal 'application/json', @response.content_type
                 json = ActiveSupport::JSON.decode(response.body)
                 assert_kind_of Hash, json
                 assert json.has_key?('errors')
                 assert_kind_of Array, json['errors']
               end
               test "DELETE /users/:id.xml should delete the user" do
                 assert_difference('User.count', -1) do
                   delete '/users/2.xml', {}, credentials('admin')
                 end
                 assert_response :ok
                 assert_equal '', @response.body
               end
               test "DELETE /users/:id.json should delete the user" do
                 assert_difference('User.count', -1) do
                   delete '/users/2.json', {}, credentials('admin')
                 end
                 assert_response :ok
                 assert_equal '', @response.body
               end
             end

test/test_helper.rb 0 -249

             # Redmine - project management software
             # Copyright (C) 2006-2014  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             #require 'shoulda'
             ENV["RAILS_ENV"] = "test"
             require File.expand_path(File.dirname(__FILE__) + "/../config/environment")
             require 'rails/test_help'
             require Rails.root.join('test', 'mocks', 'open_id_authentication_mock.rb').to_s
             require File.expand_path(File.dirname(__FILE__) + '/object_helpers')
             include ObjectHelpers
             require 'awesome_nested_set/version'
             require 'net/ldap'
             class ActionView::TestCase
               helper :application
               include ApplicationHelper
             end
             class ActiveSupport::TestCase
               include ActionDispatch::TestProcess
               include Shoulda::Context::Assertions
               include Shoulda::Context::InstanceMethods
               extend Shoulda::Context::ClassMethods
               self.use_transactional_fixtures = true
               self.use_instantiated_fixtures  = false
               #ESCAPED_CANT  = 'can&#x27;t'
               #ESCAPED_UCANT = 'Can&#x27;t'
               # Rails 4.0.2
               ESCAPED_CANT  = 'can&#39;t'
               ESCAPED_UCANT = 'Can&#39;t'
               def log_user(login, password)
                 User.anonymous
                 get "/login"
                 assert_equal nil, session[:user_id]
                 assert_response :success
                 assert_template "account/login"
                 post "/login", :username => login, :password => password
                 assert_equal login, User.find(session[:user_id]).login
               end
               def uploaded_test_file(name, mime)
                 fixture_file_upload("files/#{name}", mime, true)
               end
               def credentials(user, password=nil)
                 {'HTTP_AUTHORIZATION' => ActionController::HttpAuthentication::Basic.encode_credentials(user, password || user)}
               end
               # Mock out a file
               def self.mock_file
                 file = 'a_file.png'
                 file.stubs(:size).returns(32)
                 file.stubs(:original_filename).returns('a_file.png')
                 file.stubs(:content_type).returns('image/png')
                 file.stubs(:read).returns(false)
                 file
               end
               def mock_file
                 self.class.mock_file
               end
               def mock_file_with_options(options={})
                 file = ''
                 file.stubs(:size).returns(32)
                 original_filename = options[:original_filename] || nil
                 file.stubs(:original_filename).returns(original_filename)
                 content_type = options[:content_type] || nil
                 file.stubs(:content_type).returns(content_type)
                 file.stubs(:read).returns(false)
                 file
               end
               # Use a temporary directory for attachment related tests
               def set_tmp_attachments_directory
                 Dir.mkdir "#{Rails.root}/tmp/test" unless File.directory?("#{Rails.root}/tmp/test")
                 unless File.directory?("#{Rails.root}/tmp/test/attachments")
                   Dir.mkdir "#{Rails.root}/tmp/test/attachments"
                 end
                 Attachment.storage_path = "#{Rails.root}/tmp/test/attachments"
               end
               def set_fixtures_attachments_directory
                 Attachment.storage_path = "#{Rails.root}/test/fixtures/files"
               end
               def with_settings(options, &block)
                 saved_settings = options.keys.inject({}) do |h, k|
                   h[k] = case Setting[k]
                     when Symbol, false, true, nil
                       Setting[k]
                     else
                       Setting[k].dup
                     end
                   h
                 end
                 options.each {|k, v| Setting[k] = v}
                 yield
               ensure
                 saved_settings.each {|k, v| Setting[k] = v} if saved_settings
               end
               # Yields the block with user as the current user
               def with_current_user(user, &block)
                 saved_user = User.current
                 User.current = user
                 yield
               ensure
                 User.current = saved_user
               end
               def with_locale(locale, &block)
                 saved_localed = ::I18n.locale
                 ::I18n.locale = locale
                 yield
               ensure
                 ::I18n.locale = saved_localed
               end
               def change_user_password(login, new_password)
                 user = User.where(:login => login).first
                 user.password, user.password_confirmation = new_password, new_password
                 user.save!
               end
               def self.ldap_configured?
                 @test_ldap = Net::LDAP.new(:host => '127.0.0.1', :port => 389)
                 return @test_ldap.bind
               rescue Exception => e
                 # LDAP is not listening
                 return nil
               end
               def self.convert_installed?
                 Redmine::Thumbnail.convert_available?
               end
               # Returns the path to the test +vendor+ repository
               def self.repository_path(vendor)
                 path = Rails.root.join("tmp/test/#{vendor.downcase}_repository").to_s
                 # Unlike ruby, JRuby returns Rails.root with backslashes under Windows
                 path.tr("\\", "/")
               end
               # Returns the url of the subversion test repository
               def self.subversion_repository_url
                 path = repository_path('subversion')
                 path = '/' + path unless path.starts_with?('/')
                 "file://#{path}"
               end
               # Returns true if the +vendor+ test repository is configured
               def self.repository_configured?(vendor)
                 File.directory?(repository_path(vendor))
               end
               def repository_path_hash(arr)
                 hs = {}
                 hs[:path]  = arr.join("/")
                 hs[:param] = arr.join("/")
                 hs
               end
               def assert_save(object)
                 saved = object.save
                 message = "#{object.class} could not be saved"
                 errors = object.errors.full_messages.map {|m| "- #{m}"}
                 message << ":\n#{errors.join("\n")}" if errors.any?
                 assert_equal true, saved, message
               end
               def assert_select_error(arg)
                 assert_select '#errorExplanation', :text => arg
               end
               def assert_include(expected, s, message=nil)
                 assert s.include?(expected), (message || "\"#{expected}\" not found in \"#{s}\"")
               end
               def assert_not_include(expected, s, message=nil)
                 assert !s.include?(expected), (message || "\"#{expected}\" found in \"#{s}\"")
               end
               def assert_select_in(text, *args, &block)
                 d = HTML::Document.new(CGI::unescapeHTML(String.new(text))).root
                 assert_select(d, *args, &block)
               end
               def assert_mail_body_match(expected, mail, message=nil)
                 if expected.is_a?(String)
                   assert_include expected, mail_body(mail), message
                 else
                   assert_match expected, mail_body(mail), message
                 end
               end
               def assert_mail_body_no_match(expected, mail, message=nil)
                 if expected.is_a?(String)
                   assert_not_include expected, mail_body(mail), message
                 else
                   assert_no_match expected, mail_body(mail), message
                 end
               end
               def mail_body(mail)
                 mail.parts.first.body.encoded
               end
               # awesome_nested_set new node lft and rgt value changed this refactor revision.
               #   https://github.com/collectiveidea/awesome_nested_set/commit/199fca9bb938e40200cd90714dc69247ef017c61
               # The reason of behavior change is that "self.class.base_class.unscoped" was added to this line.
               #   https://github.com/collectiveidea/awesome_nested_set/commit/199fca9bb9#diff-f61b59a5e6319024e211b0ffdd0e4ef1R273
               # It seems correct behavior because of this line comment.
               #   https://github.com/collectiveidea/awesome_nested_set/blame/199fca9bb9/lib/awesome_nested_set/model.rb#L278
               def new_issue_lft
                 # ::AwesomeNestedSet::VERSION > "2.1.6" ? Issue.maximum(:rgt) + 1 : 1
                 Issue.maximum(:rgt) + 1
               end
             end
             module Redmine
               class RoutingTest < ActionDispatch::IntegrationTest
                 def should_route(arg)
                   arg = arg.dup
                   request = arg.keys.detect {|key| key.is_a?(String)}
                   raise ArgumentError unless request
                   options = arg.slice!(request)
                   raise ArgumentError unless request =~ /\A(GET|POST|PUT|PATCH|DELETE)\s+(.+)\z/
                   method, path = $1.downcase.to_sym, $2
                   raise ArgumentError unless arg.values.first =~ /\A(.+)#(.+)\z/
                   controller, action = $1, $2
                   assert_routing(
                     {:method => method, :path => path},
                     options.merge(:controller => controller, :action => action)
                   )
                 end
               end
               module ApiTest
                 API_FORMATS = %w(json xml).freeze
                 # Base class for API tests
                 class Base < ActionDispatch::IntegrationTest
-                  # Test that a request allows the three types of API authentication
-                  # * HTTP Basic with username and password
-                  # * HTTP Basic with an api key for the username
-                  # * Key based with the key=X parameter
-                  # @param [Symbol] http_method the HTTP method for request (:get, :post, :put, :delete)
-                  # @param [String] url the request url
-                  # @param [optional, Hash] parameters additional request parameters
-                  # @param [optional, Hash] options additional options
-                  # @option options [Symbol] :success_code Successful response code (:success)
-                  # @option options [Symbol] :failure_code Failure response code (:unauthorized)
-                  def self.should_allow_api_authentication(http_method, url, parameters={}, options={})
-                    should_allow_http_basic_auth_with_username_and_password(http_method, url, parameters, options)
-                    should_allow_http_basic_auth_with_key(http_method, url, parameters, options)
-                    should_allow_key_based_auth(http_method, url, parameters, options)
-                  end
-                  # Test that a request allows the username and password for HTTP BASIC
-                  # @param [Symbol] http_method the HTTP method for request (:get, :post, :put, :delete)
-                  # @param [String] url the request url
-                  # @param [optional, Hash] parameters additional request parameters
-                  # @param [optional, Hash] options additional options
-                  # @option options [Symbol] :success_code Successful response code (:success)
-                  # @option options [Symbol] :failure_code Failure response code (:unauthorized)
-                  def self.should_allow_http_basic_auth_with_username_and_password(http_method, url, parameters={}, options={})
-                    success_code = options[:success_code] || :success
-                    failure_code = options[:failure_code] || :unauthorized
-                    context "should allow http basic auth using a username and password for #{http_method} #{url}" do
-                      context "with a valid HTTP authentication" do
-                        setup do
-                          @user = User.generate! do |user|
-                            user.admin = true
-                            user.password = 'my_password'
-                          end
-                          send(http_method, url, parameters, credentials(@user.login, 'my_password'))
-                        end
-                        should_respond_with success_code
-                        should_respond_with_content_type_based_on_url(url)
-                        should "login as the user" do
-                          assert_equal @user, User.current
-                        end
-                      end
-                      context "with an invalid HTTP authentication" do
-                        setup do
-                          @user = User.generate!
-                          send(http_method, url, parameters, credentials(@user.login, 'wrong_password'))
-                        end
-                        should_respond_with failure_code
-                        should_respond_with_content_type_based_on_url(url)
-                        should "not login as the user" do
-                          assert_equal User.anonymous, User.current
-                        end
-                      end
-                      context "without credentials" do
-                        setup do
-                          send(http_method, url, parameters)
-                        end
-                        should_respond_with failure_code
-                        should_respond_with_content_type_based_on_url(url)
-                        should "include_www_authenticate_header" do
-                          assert @controller.response.headers.has_key?('WWW-Authenticate')
-                        end
-                      end
-                    end
-                  end
-                  # Test that a request allows the API key with HTTP BASIC
-                  # @param [Symbol] http_method the HTTP method for request (:get, :post, :put, :delete)
-                  # @param [String] url the request url
-                  # @param [optional, Hash] parameters additional request parameters
-                  # @param [optional, Hash] options additional options
-                  # @option options [Symbol] :success_code Successful response code (:success)
-                  # @option options [Symbol] :failure_code Failure response code (:unauthorized)
-                  def self.should_allow_http_basic_auth_with_key(http_method, url, parameters={}, options={})
-                    success_code = options[:success_code] || :success
-                    failure_code = options[:failure_code] || :unauthorized
-                    context "should allow http basic auth with a key for #{http_method} #{url}" do
-                      context "with a valid HTTP authentication using the API token" do
-                        setup do
-                          @user = User.generate! do |user|
-                            user.admin = true
-                          end
-                          @token = Token.create!(:user => @user, :action => 'api')
-                          send(http_method, url, parameters, credentials(@token.value, 'X'))
-                        end
-                        should_respond_with success_code
-                        should_respond_with_content_type_based_on_url(url)
-                        should_be_a_valid_response_string_based_on_url(url)
-                        should "login as the user" do
-                          assert_equal @user, User.current
-                        end
-                      end
-                      context "with an invalid HTTP authentication" do
-                        setup do
-                          @user = User.generate!
-                          @token = Token.create!(:user => @user, :action => 'feeds')
-                          send(http_method, url, parameters, credentials(@token.value, 'X'))
-                        end
-                        should_respond_with failure_code
-                        should_respond_with_content_type_based_on_url(url)
-                        should "not login as the user" do
-                          assert_equal User.anonymous, User.current
-                        end
-                      end
-                    end
-                  end
-                  # Test that a request allows full key authentication
-                  # @param [Symbol] http_method the HTTP method for request (:get, :post, :put, :delete)
-                  # @param [String] url the request url, without the key=ZXY parameter
-                  # @param [optional, Hash] parameters additional request parameters
-                  # @param [optional, Hash] options additional options
-                  # @option options [Symbol] :success_code Successful response code (:success)
-                  # @option options [Symbol] :failure_code Failure response code (:unauthorized)
-                  def self.should_allow_key_based_auth(http_method, url, parameters={}, options={})
-                    success_code = options[:success_code] || :success
-                    failure_code = options[:failure_code] || :unauthorized
-                    context "should allow key based auth using key=X for #{http_method} #{url}" do
-                      context "with a valid api token" do
-                        setup do
-                          @user = User.generate! do |user|
-                            user.admin = true
-                          end
-                          @token = Token.create!(:user => @user, :action => 'api')
-                          # Simple url parse to add on ?key= or &key=
-                          request_url = if url.match(/\?/)
-                                          url + "&key=#{@token.value}"
-                                        else
-                                          url + "?key=#{@token.value}"
-                                        end
-                          send(http_method, request_url, parameters)
-                        end
-                        should_respond_with success_code
-                        should_respond_with_content_type_based_on_url(url)
-                        should_be_a_valid_response_string_based_on_url(url)
-                        should "login as the user" do
-                          assert_equal @user, User.current
-                        end
-                      end
-                      context "with an invalid api token" do
-                        setup do
-                          @user = User.generate! do |user|
-                            user.admin = true
-                          end
-                          @token = Token.create!(:user => @user, :action => 'feeds')
-                          # Simple url parse to add on ?key= or &key=
-                          request_url = if url.match(/\?/)
-                                          url + "&key=#{@token.value}"
-                                        else
-                                          url + "?key=#{@token.value}"
-                                        end
-                          send(http_method, request_url, parameters)
-                        end
-                        should_respond_with failure_code
-                        should_respond_with_content_type_based_on_url(url)
-                        should "not login as the user" do
-                          assert_equal User.anonymous, User.current
-                        end
-                      end
-                    end
-                    context "should allow key based auth using X-Redmine-API-Key header for #{http_method} #{url}" do
-                      setup do
-                        @user = User.generate! do |user|
-                          user.admin = true
-                        end
-                        @token = Token.create!(:user => @user, :action => 'api')
-                        send(http_method, url, parameters, {'X-Redmine-API-Key' => @token.value.to_s})
-                      end
-                      should_respond_with success_code
-                      should_respond_with_content_type_based_on_url(url)
-                      should_be_a_valid_response_string_based_on_url(url)
-                      should "login as the user" do
-                        assert_equal @user, User.current
-                      end
-                    end
-                  end
-                  # Uses should_respond_with_content_type based on what's in the url:
-                  # '/project/issues.xml' => should_respond_with_content_type :xml
-                  # '/project/issues.json' => should_respond_with_content_type :json
-                  # @param [String] url Request
-                  def self.should_respond_with_content_type_based_on_url(url)
-                    case
-                    when url.match(/xml/i)
-                      should "respond with XML" do
-                        assert_equal 'application/xml', @response.content_type
-                      end
-                    when url.match(/json/i)
-                      should "respond with JSON" do
-                        assert_equal 'application/json', @response.content_type
-                      end
-                    else
-                      raise "Unknown content type for should_respond_with_content_type_based_on_url: #{url}"
-                    end
-                  end
-                  # Uses the url to assert which format the response should be in
-                  # '/project/issues.xml' => should_be_a_valid_xml_string
-                  # '/project/issues.json' => should_be_a_valid_json_string
-                  # @param [String] url Request
-                  def self.should_be_a_valid_response_string_based_on_url(url)
-                    case
-                    when url.match(/xml/i)
-                      should_be_a_valid_xml_string
-                    when url.match(/json/i)
-                      should_be_a_valid_json_string
-                    else
-                      raise "Unknown content type for should_be_a_valid_response_based_on_url: #{url}"
-                    end
-                  end
-                  # Checks that the response is a valid JSON string
-                  def self.should_be_a_valid_json_string
-                    should "be a valid JSON string (or empty)" do
-                      assert(response.body.blank? || ActiveSupport::JSON.decode(response.body))
-                    end
-                  end
-                  # Checks that the response is a valid XML string
-                  def self.should_be_a_valid_xml_string
-                    should "be a valid XML string" do
-                      assert REXML::Document.new(response.body)
-                    end
-                  end
-                  def self.should_respond_with(status)
-                    should "respond with #{status}" do
-                      assert_response status
-                    end
-                  end
                 end
                 class Routing < Redmine::RoutingTest
                   def should_route(arg)
                     arg = arg.dup
                     request = arg.keys.detect {|key| key.is_a?(String)}
                     raise ArgumentError unless request
                     options = arg.slice!(request)
                     API_FORMATS.each do |format|
                       format_request = request.sub /$/, ".#{format}"
                       super options.merge(format_request => arg[request], :format => format)
                     end
                   end
                 end
               end
             end
             # URL helpers do not work with config.threadsafe!
             # https://github.com/rspec/rspec-rails/issues/476#issuecomment-4705454
             ActionView::TestCase::TestController.instance_eval do
               helper Rails.application.routes.url_helpers
             end
             ActionView::TestCase::TestController.class_eval do
               def _routes
                 Rails.application.routes
               end
             end

test/integration/api_test/http_basic_login_test.rb removed 0 -43

NO CONTENT: file was removed

test/integration/api_test/http_basic_login_with_api_token_test.rb removed 0 -41

NO CONTENT: file was removed

test/integration/api_test/token_authentication_test.rb removed 0 -42

NO CONTENT: file was removed

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages