jro_apps/redmine Commit - r13620:36426260527d

Fixed Stack level too deep error when calling #find_name_by_reflection for missing record....

Jean-Philippe Lang -

r13620:36426260527d

parent child

Context file:

r13620:36426260527d

app/helpers/issues_helper.rb +3 -3

                 end
                 @detail_value_name_by_reflection ||= Hash.new do |hash, key|
                   association = Issue.reflect_on_association(key.first.to_sym)
+                  name = nil
                   if association
                     record = association.klass.find_by_id(key.last)
                     if record
-                      record.name.force_encoding('UTF-8')
+                      name = record.name.force_encoding('UTF-8')
-                      hash[key] = record.name
                     end
                   end
-                  hash[key] ||= nil
+                  hash[key] = name
                 end
                 @detail_value_name_by_reflection[[field, id]]
               end

test/unit/helpers/issues_helper_test.rb +4 0

                 assert_equal "Precedes deleted (Issue ##{issue.id})", show_detail(detail, true)
                 assert_equal "<strong>Precedes</strong> deleted (<i>Issue ##{issue.id}</i>)", show_detail(detail, false)
               end
+              def test_find_name_by_reflection_should_return_nil_for_missing_record
+                assert_nil find_name_by_reflection('status', 99)
+              end
             end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages