##// END OF EJS Templates
View progress bar of related issues (#3425)....
Jean-Philippe Lang -
r15600:33d78d605d0b
parent child
Show More
@@ -1,515 +1,516
1 # encoding: utf-8
1 # encoding: utf-8
2 #
2 #
3 # Redmine - project management software
3 # Redmine - project management software
4 # Copyright (C) 2006-2016 Jean-Philippe Lang
4 # Copyright (C) 2006-2016 Jean-Philippe Lang
5 #
5 #
6 # This program is free software; you can redistribute it and/or
6 # This program is free software; you can redistribute it and/or
7 # modify it under the terms of the GNU General Public License
7 # modify it under the terms of the GNU General Public License
8 # as published by the Free Software Foundation; either version 2
8 # as published by the Free Software Foundation; either version 2
9 # of the License, or (at your option) any later version.
9 # of the License, or (at your option) any later version.
10 #
10 #
11 # This program is distributed in the hope that it will be useful,
11 # This program is distributed in the hope that it will be useful,
12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 # GNU General Public License for more details.
14 # GNU General Public License for more details.
15 #
15 #
16 # You should have received a copy of the GNU General Public License
16 # You should have received a copy of the GNU General Public License
17 # along with this program; if not, write to the Free Software
17 # along with this program; if not, write to the Free Software
18 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
19
19
20 module IssuesHelper
20 module IssuesHelper
21 include ApplicationHelper
21 include ApplicationHelper
22 include Redmine::Export::PDF::IssuesPdfHelper
22 include Redmine::Export::PDF::IssuesPdfHelper
23
23
24 def issue_list(issues, &block)
24 def issue_list(issues, &block)
25 ancestors = []
25 ancestors = []
26 issues.each do |issue|
26 issues.each do |issue|
27 while (ancestors.any? && !issue.is_descendant_of?(ancestors.last))
27 while (ancestors.any? && !issue.is_descendant_of?(ancestors.last))
28 ancestors.pop
28 ancestors.pop
29 end
29 end
30 yield issue, ancestors.size
30 yield issue, ancestors.size
31 ancestors << issue unless issue.leaf?
31 ancestors << issue unless issue.leaf?
32 end
32 end
33 end
33 end
34
34
35 def grouped_issue_list(issues, query, issue_count_by_group, &block)
35 def grouped_issue_list(issues, query, issue_count_by_group, &block)
36 ancestors = []
36 ancestors = []
37 grouped_query_results(issues, query, issue_count_by_group) do |issue, group_name, group_count, group_totals|
37 grouped_query_results(issues, query, issue_count_by_group) do |issue, group_name, group_count, group_totals|
38 while (ancestors.any? && !issue.is_descendant_of?(ancestors.last))
38 while (ancestors.any? && !issue.is_descendant_of?(ancestors.last))
39 ancestors.pop
39 ancestors.pop
40 end
40 end
41 yield issue, ancestors.size, group_name, group_count, group_totals
41 yield issue, ancestors.size, group_name, group_count, group_totals
42 ancestors << issue unless issue.leaf?
42 ancestors << issue unless issue.leaf?
43 end
43 end
44 end
44 end
45
45
46 # Renders a HTML/CSS tooltip
46 # Renders a HTML/CSS tooltip
47 #
47 #
48 # To use, a trigger div is needed. This is a div with the class of "tooltip"
48 # To use, a trigger div is needed. This is a div with the class of "tooltip"
49 # that contains this method wrapped in a span with the class of "tip"
49 # that contains this method wrapped in a span with the class of "tip"
50 #
50 #
51 # <div class="tooltip"><%= link_to_issue(issue) %>
51 # <div class="tooltip"><%= link_to_issue(issue) %>
52 # <span class="tip"><%= render_issue_tooltip(issue) %></span>
52 # <span class="tip"><%= render_issue_tooltip(issue) %></span>
53 # </div>
53 # </div>
54 #
54 #
55 def render_issue_tooltip(issue)
55 def render_issue_tooltip(issue)
56 @cached_label_status ||= l(:field_status)
56 @cached_label_status ||= l(:field_status)
57 @cached_label_start_date ||= l(:field_start_date)
57 @cached_label_start_date ||= l(:field_start_date)
58 @cached_label_due_date ||= l(:field_due_date)
58 @cached_label_due_date ||= l(:field_due_date)
59 @cached_label_assigned_to ||= l(:field_assigned_to)
59 @cached_label_assigned_to ||= l(:field_assigned_to)
60 @cached_label_priority ||= l(:field_priority)
60 @cached_label_priority ||= l(:field_priority)
61 @cached_label_project ||= l(:field_project)
61 @cached_label_project ||= l(:field_project)
62
62
63 link_to_issue(issue) + "<br /><br />".html_safe +
63 link_to_issue(issue) + "<br /><br />".html_safe +
64 "<strong>#{@cached_label_project}</strong>: #{link_to_project(issue.project)}<br />".html_safe +
64 "<strong>#{@cached_label_project}</strong>: #{link_to_project(issue.project)}<br />".html_safe +
65 "<strong>#{@cached_label_status}</strong>: #{h(issue.status.name)}<br />".html_safe +
65 "<strong>#{@cached_label_status}</strong>: #{h(issue.status.name)}<br />".html_safe +
66 "<strong>#{@cached_label_start_date}</strong>: #{format_date(issue.start_date)}<br />".html_safe +
66 "<strong>#{@cached_label_start_date}</strong>: #{format_date(issue.start_date)}<br />".html_safe +
67 "<strong>#{@cached_label_due_date}</strong>: #{format_date(issue.due_date)}<br />".html_safe +
67 "<strong>#{@cached_label_due_date}</strong>: #{format_date(issue.due_date)}<br />".html_safe +
68 "<strong>#{@cached_label_assigned_to}</strong>: #{h(issue.assigned_to)}<br />".html_safe +
68 "<strong>#{@cached_label_assigned_to}</strong>: #{h(issue.assigned_to)}<br />".html_safe +
69 "<strong>#{@cached_label_priority}</strong>: #{h(issue.priority.name)}".html_safe
69 "<strong>#{@cached_label_priority}</strong>: #{h(issue.priority.name)}".html_safe
70 end
70 end
71
71
72 def issue_heading(issue)
72 def issue_heading(issue)
73 h("#{issue.tracker} ##{issue.id}")
73 h("#{issue.tracker} ##{issue.id}")
74 end
74 end
75
75
76 def render_issue_subject_with_tree(issue)
76 def render_issue_subject_with_tree(issue)
77 s = ''
77 s = ''
78 ancestors = issue.root? ? [] : issue.ancestors.visible.to_a
78 ancestors = issue.root? ? [] : issue.ancestors.visible.to_a
79 ancestors.each do |ancestor|
79 ancestors.each do |ancestor|
80 s << '<div>' + content_tag('p', link_to_issue(ancestor, :project => (issue.project_id != ancestor.project_id)))
80 s << '<div>' + content_tag('p', link_to_issue(ancestor, :project => (issue.project_id != ancestor.project_id)))
81 end
81 end
82 s << '<div>'
82 s << '<div>'
83 subject = h(issue.subject)
83 subject = h(issue.subject)
84 if issue.is_private?
84 if issue.is_private?
85 subject = content_tag('span', l(:field_is_private), :class => 'private') + ' ' + subject
85 subject = content_tag('span', l(:field_is_private), :class => 'private') + ' ' + subject
86 end
86 end
87 s << content_tag('h3', subject)
87 s << content_tag('h3', subject)
88 s << '</div>' * (ancestors.size + 1)
88 s << '</div>' * (ancestors.size + 1)
89 s.html_safe
89 s.html_safe
90 end
90 end
91
91
92 def render_descendants_tree(issue)
92 def render_descendants_tree(issue)
93 s = '<table class="list issues">'
93 s = '<table class="list issues">'
94 issue_list(issue.descendants.visible.preload(:status, :priority, :tracker, :assigned_to).sort_by(&:lft)) do |child, level|
94 issue_list(issue.descendants.visible.preload(:status, :priority, :tracker, :assigned_to).sort_by(&:lft)) do |child, level|
95 css = "issue issue-#{child.id} hascontextmenu #{child.css_classes}"
95 css = "issue issue-#{child.id} hascontextmenu #{child.css_classes}"
96 css << " idnt idnt-#{level}" if level > 0
96 css << " idnt idnt-#{level}" if level > 0
97 s << content_tag('tr',
97 s << content_tag('tr',
98 content_tag('td', check_box_tag("ids[]", child.id, false, :id => nil), :class => 'checkbox') +
98 content_tag('td', check_box_tag("ids[]", child.id, false, :id => nil), :class => 'checkbox') +
99 content_tag('td', link_to_issue(child, :project => (issue.project_id != child.project_id)), :class => 'subject', :style => 'width: 50%') +
99 content_tag('td', link_to_issue(child, :project => (issue.project_id != child.project_id)), :class => 'subject', :style => 'width: 50%') +
100 content_tag('td', h(child.status), :class => 'status') +
100 content_tag('td', h(child.status), :class => 'status') +
101 content_tag('td', link_to_user(child.assigned_to), :class => 'assigned_to') +
101 content_tag('td', link_to_user(child.assigned_to), :class => 'assigned_to') +
102 content_tag('td', child.disabled_core_fields.include?('done_ratio') ? '' : progress_bar(child.done_ratio), :class=> 'done_ratio'),
102 content_tag('td', child.disabled_core_fields.include?('done_ratio') ? '' : progress_bar(child.done_ratio), :class=> 'done_ratio'),
103 :class => css)
103 :class => css)
104 end
104 end
105 s << '</table>'
105 s << '</table>'
106 s.html_safe
106 s.html_safe
107 end
107 end
108
108
109 # Renders the list of related issues on the issue details view
109 # Renders the list of related issues on the issue details view
110 def render_issue_relations(issue, relations)
110 def render_issue_relations(issue, relations)
111 manage_relations = User.current.allowed_to?(:manage_issue_relations, issue.project)
111 manage_relations = User.current.allowed_to?(:manage_issue_relations, issue.project)
112
112
113 s = ''.html_safe
113 s = ''.html_safe
114 relations.each do |relation|
114 relations.each do |relation|
115 other_issue = relation.other_issue(issue)
115 other_issue = relation.other_issue(issue)
116 css = "issue hascontextmenu #{other_issue.css_classes}"
116 css = "issue hascontextmenu #{other_issue.css_classes}"
117 link = manage_relations ? link_to(l(:label_relation_delete),
117 link = manage_relations ? link_to(l(:label_relation_delete),
118 relation_path(relation),
118 relation_path(relation),
119 :remote => true,
119 :remote => true,
120 :method => :delete,
120 :method => :delete,
121 :data => {:confirm => l(:text_are_you_sure)},
121 :data => {:confirm => l(:text_are_you_sure)},
122 :title => l(:label_relation_delete),
122 :title => l(:label_relation_delete),
123 :class => 'icon-only icon-link-break'
123 :class => 'icon-only icon-link-break'
124 ) : nil
124 ) : nil
125
125
126 s << content_tag('tr',
126 s << content_tag('tr',
127 content_tag('td', check_box_tag("ids[]", other_issue.id, false, :id => nil), :class => 'checkbox') +
127 content_tag('td', check_box_tag("ids[]", other_issue.id, false, :id => nil), :class => 'checkbox') +
128 content_tag('td', relation.to_s(@issue) {|other| link_to_issue(other, :project => Setting.cross_project_issue_relations?)}.html_safe, :class => 'subject', :style => 'width: 50%') +
128 content_tag('td', relation.to_s(@issue) {|other| link_to_issue(other, :project => Setting.cross_project_issue_relations?)}.html_safe, :class => 'subject', :style => 'width: 50%') +
129 content_tag('td', other_issue.status, :class => 'status') +
129 content_tag('td', other_issue.status, :class => 'status') +
130 content_tag('td', other_issue.start_date, :class => 'start_date') +
130 content_tag('td', other_issue.start_date, :class => 'start_date') +
131 content_tag('td', other_issue.due_date, :class => 'due_date') +
131 content_tag('td', other_issue.due_date, :class => 'due_date') +
132 content_tag('td', other_issue.disabled_core_fields.include?('done_ratio') ? '' : progress_bar(other_issue.done_ratio), :class=> 'done_ratio') +
132 content_tag('td', link, :class => 'buttons'),
133 content_tag('td', link, :class => 'buttons'),
133 :id => "relation-#{relation.id}",
134 :id => "relation-#{relation.id}",
134 :class => css)
135 :class => css)
135 end
136 end
136
137
137 content_tag('table', s, :class => 'list issues')
138 content_tag('table', s, :class => 'list issues')
138 end
139 end
139
140
140 def issue_estimated_hours_details(issue)
141 def issue_estimated_hours_details(issue)
141 if issue.total_estimated_hours.present?
142 if issue.total_estimated_hours.present?
142 if issue.total_estimated_hours == issue.estimated_hours
143 if issue.total_estimated_hours == issue.estimated_hours
143 l_hours_short(issue.estimated_hours)
144 l_hours_short(issue.estimated_hours)
144 else
145 else
145 s = issue.estimated_hours.present? ? l_hours_short(issue.estimated_hours) : ""
146 s = issue.estimated_hours.present? ? l_hours_short(issue.estimated_hours) : ""
146 s << " (#{l(:label_total)}: #{l_hours_short(issue.total_estimated_hours)})"
147 s << " (#{l(:label_total)}: #{l_hours_short(issue.total_estimated_hours)})"
147 s.html_safe
148 s.html_safe
148 end
149 end
149 end
150 end
150 end
151 end
151
152
152 def issue_spent_hours_details(issue)
153 def issue_spent_hours_details(issue)
153 if issue.total_spent_hours > 0
154 if issue.total_spent_hours > 0
154 path = project_time_entries_path(issue.project, :issue_id => "~#{issue.id}")
155 path = project_time_entries_path(issue.project, :issue_id => "~#{issue.id}")
155
156
156 if issue.total_spent_hours == issue.spent_hours
157 if issue.total_spent_hours == issue.spent_hours
157 link_to(l_hours_short(issue.spent_hours), path)
158 link_to(l_hours_short(issue.spent_hours), path)
158 else
159 else
159 s = issue.spent_hours > 0 ? l_hours_short(issue.spent_hours) : ""
160 s = issue.spent_hours > 0 ? l_hours_short(issue.spent_hours) : ""
160 s << " (#{l(:label_total)}: #{link_to l_hours_short(issue.total_spent_hours), path})"
161 s << " (#{l(:label_total)}: #{link_to l_hours_short(issue.total_spent_hours), path})"
161 s.html_safe
162 s.html_safe
162 end
163 end
163 end
164 end
164 end
165 end
165
166
166 # Returns an array of error messages for bulk edited issues
167 # Returns an array of error messages for bulk edited issues
167 def bulk_edit_error_messages(issues)
168 def bulk_edit_error_messages(issues)
168 messages = {}
169 messages = {}
169 issues.each do |issue|
170 issues.each do |issue|
170 issue.errors.full_messages.each do |message|
171 issue.errors.full_messages.each do |message|
171 messages[message] ||= []
172 messages[message] ||= []
172 messages[message] << issue
173 messages[message] << issue
173 end
174 end
174 end
175 end
175 messages.map { |message, issues|
176 messages.map { |message, issues|
176 "#{message}: " + issues.map {|i| "##{i.id}"}.join(', ')
177 "#{message}: " + issues.map {|i| "##{i.id}"}.join(', ')
177 }
178 }
178 end
179 end
179
180
180 # Returns a link for adding a new subtask to the given issue
181 # Returns a link for adding a new subtask to the given issue
181 def link_to_new_subtask(issue)
182 def link_to_new_subtask(issue)
182 attrs = {
183 attrs = {
183 :parent_issue_id => issue
184 :parent_issue_id => issue
184 }
185 }
185 attrs[:tracker_id] = issue.tracker unless issue.tracker.disabled_core_fields.include?('parent_issue_id')
186 attrs[:tracker_id] = issue.tracker unless issue.tracker.disabled_core_fields.include?('parent_issue_id')
186 link_to(l(:button_add), new_project_issue_path(issue.project, :issue => attrs))
187 link_to(l(:button_add), new_project_issue_path(issue.project, :issue => attrs))
187 end
188 end
188
189
189 def trackers_options_for_select(issue)
190 def trackers_options_for_select(issue)
190 trackers = issue.allowed_target_trackers
191 trackers = issue.allowed_target_trackers
191 if issue.new_record? && issue.parent_issue_id.present?
192 if issue.new_record? && issue.parent_issue_id.present?
192 trackers = trackers.reject do |tracker|
193 trackers = trackers.reject do |tracker|
193 issue.tracker_id != tracker.id && tracker.disabled_core_fields.include?('parent_issue_id')
194 issue.tracker_id != tracker.id && tracker.disabled_core_fields.include?('parent_issue_id')
194 end
195 end
195 end
196 end
196 trackers.collect {|t| [t.name, t.id]}
197 trackers.collect {|t| [t.name, t.id]}
197 end
198 end
198
199
199 class IssueFieldsRows
200 class IssueFieldsRows
200 include ActionView::Helpers::TagHelper
201 include ActionView::Helpers::TagHelper
201
202
202 def initialize
203 def initialize
203 @left = []
204 @left = []
204 @right = []
205 @right = []
205 end
206 end
206
207
207 def left(*args)
208 def left(*args)
208 args.any? ? @left << cells(*args) : @left
209 args.any? ? @left << cells(*args) : @left
209 end
210 end
210
211
211 def right(*args)
212 def right(*args)
212 args.any? ? @right << cells(*args) : @right
213 args.any? ? @right << cells(*args) : @right
213 end
214 end
214
215
215 def size
216 def size
216 @left.size > @right.size ? @left.size : @right.size
217 @left.size > @right.size ? @left.size : @right.size
217 end
218 end
218
219
219 def to_html
220 def to_html
220 content =
221 content =
221 content_tag('div', @left.reduce(&:+), :class => 'splitcontentleft') +
222 content_tag('div', @left.reduce(&:+), :class => 'splitcontentleft') +
222 content_tag('div', @right.reduce(&:+), :class => 'splitcontentleft')
223 content_tag('div', @right.reduce(&:+), :class => 'splitcontentleft')
223
224
224 content_tag('div', content, :class => 'splitcontent')
225 content_tag('div', content, :class => 'splitcontent')
225 end
226 end
226
227
227 def cells(label, text, options={})
228 def cells(label, text, options={})
228 options[:class] = [options[:class] || "", 'attribute'].join(' ')
229 options[:class] = [options[:class] || "", 'attribute'].join(' ')
229 content_tag 'div',
230 content_tag 'div',
230 content_tag('div', label + ":", :class => 'label') + content_tag('div', text, :class => 'value'),
231 content_tag('div', label + ":", :class => 'label') + content_tag('div', text, :class => 'value'),
231 options
232 options
232 end
233 end
233 end
234 end
234
235
235 def issue_fields_rows
236 def issue_fields_rows
236 r = IssueFieldsRows.new
237 r = IssueFieldsRows.new
237 yield r
238 yield r
238 r.to_html
239 r.to_html
239 end
240 end
240
241
241 def render_custom_fields_rows(issue)
242 def render_custom_fields_rows(issue)
242 values = issue.visible_custom_field_values
243 values = issue.visible_custom_field_values
243 return if values.empty?
244 return if values.empty?
244 half = (values.size / 2.0).ceil
245 half = (values.size / 2.0).ceil
245 issue_fields_rows do |rows|
246 issue_fields_rows do |rows|
246 values.each_with_index do |value, i|
247 values.each_with_index do |value, i|
247 css = "cf_#{value.custom_field.id}"
248 css = "cf_#{value.custom_field.id}"
248 m = (i < half ? :left : :right)
249 m = (i < half ? :left : :right)
249 rows.send m, custom_field_name_tag(value.custom_field), show_value(value), :class => css
250 rows.send m, custom_field_name_tag(value.custom_field), show_value(value), :class => css
250 end
251 end
251 end
252 end
252 end
253 end
253
254
254 # Returns the path for updating the issue form
255 # Returns the path for updating the issue form
255 # with project as the current project
256 # with project as the current project
256 def update_issue_form_path(project, issue)
257 def update_issue_form_path(project, issue)
257 options = {:format => 'js'}
258 options = {:format => 'js'}
258 if issue.new_record?
259 if issue.new_record?
259 if project
260 if project
260 new_project_issue_path(project, options)
261 new_project_issue_path(project, options)
261 else
262 else
262 new_issue_path(options)
263 new_issue_path(options)
263 end
264 end
264 else
265 else
265 edit_issue_path(issue, options)
266 edit_issue_path(issue, options)
266 end
267 end
267 end
268 end
268
269
269 # Returns the number of descendants for an array of issues
270 # Returns the number of descendants for an array of issues
270 def issues_descendant_count(issues)
271 def issues_descendant_count(issues)
271 ids = issues.reject(&:leaf?).map {|issue| issue.descendants.ids}.flatten.uniq
272 ids = issues.reject(&:leaf?).map {|issue| issue.descendants.ids}.flatten.uniq
272 ids -= issues.map(&:id)
273 ids -= issues.map(&:id)
273 ids.size
274 ids.size
274 end
275 end
275
276
276 def issues_destroy_confirmation_message(issues)
277 def issues_destroy_confirmation_message(issues)
277 issues = [issues] unless issues.is_a?(Array)
278 issues = [issues] unless issues.is_a?(Array)
278 message = l(:text_issues_destroy_confirmation)
279 message = l(:text_issues_destroy_confirmation)
279
280
280 descendant_count = issues_descendant_count(issues)
281 descendant_count = issues_descendant_count(issues)
281 if descendant_count > 0
282 if descendant_count > 0
282 message << "\n" + l(:text_issues_destroy_descendants_confirmation, :count => descendant_count)
283 message << "\n" + l(:text_issues_destroy_descendants_confirmation, :count => descendant_count)
283 end
284 end
284 message
285 message
285 end
286 end
286
287
287 # Returns an array of users that are proposed as watchers
288 # Returns an array of users that are proposed as watchers
288 # on the new issue form
289 # on the new issue form
289 def users_for_new_issue_watchers(issue)
290 def users_for_new_issue_watchers(issue)
290 users = issue.watcher_users
291 users = issue.watcher_users
291 if issue.project.users.count <= 20
292 if issue.project.users.count <= 20
292 users = (users + issue.project.users.sort).uniq
293 users = (users + issue.project.users.sort).uniq
293 end
294 end
294 users
295 users
295 end
296 end
296
297
297 def email_issue_attributes(issue, user)
298 def email_issue_attributes(issue, user)
298 items = []
299 items = []
299 %w(author status priority assigned_to category fixed_version).each do |attribute|
300 %w(author status priority assigned_to category fixed_version).each do |attribute|
300 unless issue.disabled_core_fields.include?(attribute+"_id")
301 unless issue.disabled_core_fields.include?(attribute+"_id")
301 items << "#{l("field_#{attribute}")}: #{issue.send attribute}"
302 items << "#{l("field_#{attribute}")}: #{issue.send attribute}"
302 end
303 end
303 end
304 end
304 issue.visible_custom_field_values(user).each do |value|
305 issue.visible_custom_field_values(user).each do |value|
305 items << "#{value.custom_field.name}: #{show_value(value, false)}"
306 items << "#{value.custom_field.name}: #{show_value(value, false)}"
306 end
307 end
307 items
308 items
308 end
309 end
309
310
310 def render_email_issue_attributes(issue, user, html=false)
311 def render_email_issue_attributes(issue, user, html=false)
311 items = email_issue_attributes(issue, user)
312 items = email_issue_attributes(issue, user)
312 if html
313 if html
313 content_tag('ul', items.map{|s| content_tag('li', s)}.join("\n").html_safe)
314 content_tag('ul', items.map{|s| content_tag('li', s)}.join("\n").html_safe)
314 else
315 else
315 items.map{|s| "* #{s}"}.join("\n")
316 items.map{|s| "* #{s}"}.join("\n")
316 end
317 end
317 end
318 end
318
319
319 # Returns the textual representation of a journal details
320 # Returns the textual representation of a journal details
320 # as an array of strings
321 # as an array of strings
321 def details_to_strings(details, no_html=false, options={})
322 def details_to_strings(details, no_html=false, options={})
322 options[:only_path] = (options[:only_path] == false ? false : true)
323 options[:only_path] = (options[:only_path] == false ? false : true)
323 strings = []
324 strings = []
324 values_by_field = {}
325 values_by_field = {}
325 details.each do |detail|
326 details.each do |detail|
326 if detail.property == 'cf'
327 if detail.property == 'cf'
327 field = detail.custom_field
328 field = detail.custom_field
328 if field && field.multiple?
329 if field && field.multiple?
329 values_by_field[field] ||= {:added => [], :deleted => []}
330 values_by_field[field] ||= {:added => [], :deleted => []}
330 if detail.old_value
331 if detail.old_value
331 values_by_field[field][:deleted] << detail.old_value
332 values_by_field[field][:deleted] << detail.old_value
332 end
333 end
333 if detail.value
334 if detail.value
334 values_by_field[field][:added] << detail.value
335 values_by_field[field][:added] << detail.value
335 end
336 end
336 next
337 next
337 end
338 end
338 end
339 end
339 strings << show_detail(detail, no_html, options)
340 strings << show_detail(detail, no_html, options)
340 end
341 end
341 if values_by_field.present?
342 if values_by_field.present?
342 multiple_values_detail = Struct.new(:property, :prop_key, :custom_field, :old_value, :value)
343 multiple_values_detail = Struct.new(:property, :prop_key, :custom_field, :old_value, :value)
343 values_by_field.each do |field, changes|
344 values_by_field.each do |field, changes|
344 if changes[:added].any?
345 if changes[:added].any?
345 detail = multiple_values_detail.new('cf', field.id.to_s, field)
346 detail = multiple_values_detail.new('cf', field.id.to_s, field)
346 detail.value = changes[:added]
347 detail.value = changes[:added]
347 strings << show_detail(detail, no_html, options)
348 strings << show_detail(detail, no_html, options)
348 end
349 end
349 if changes[:deleted].any?
350 if changes[:deleted].any?
350 detail = multiple_values_detail.new('cf', field.id.to_s, field)
351 detail = multiple_values_detail.new('cf', field.id.to_s, field)
351 detail.old_value = changes[:deleted]
352 detail.old_value = changes[:deleted]
352 strings << show_detail(detail, no_html, options)
353 strings << show_detail(detail, no_html, options)
353 end
354 end
354 end
355 end
355 end
356 end
356 strings
357 strings
357 end
358 end
358
359
359 # Returns the textual representation of a single journal detail
360 # Returns the textual representation of a single journal detail
360 def show_detail(detail, no_html=false, options={})
361 def show_detail(detail, no_html=false, options={})
361 multiple = false
362 multiple = false
362 show_diff = false
363 show_diff = false
363 no_details = false
364 no_details = false
364
365
365 case detail.property
366 case detail.property
366 when 'attr'
367 when 'attr'
367 field = detail.prop_key.to_s.gsub(/\_id$/, "")
368 field = detail.prop_key.to_s.gsub(/\_id$/, "")
368 label = l(("field_" + field).to_sym)
369 label = l(("field_" + field).to_sym)
369 case detail.prop_key
370 case detail.prop_key
370 when 'due_date', 'start_date'
371 when 'due_date', 'start_date'
371 value = format_date(detail.value.to_date) if detail.value
372 value = format_date(detail.value.to_date) if detail.value
372 old_value = format_date(detail.old_value.to_date) if detail.old_value
373 old_value = format_date(detail.old_value.to_date) if detail.old_value
373
374
374 when 'project_id', 'status_id', 'tracker_id', 'assigned_to_id',
375 when 'project_id', 'status_id', 'tracker_id', 'assigned_to_id',
375 'priority_id', 'category_id', 'fixed_version_id'
376 'priority_id', 'category_id', 'fixed_version_id'
376 value = find_name_by_reflection(field, detail.value)
377 value = find_name_by_reflection(field, detail.value)
377 old_value = find_name_by_reflection(field, detail.old_value)
378 old_value = find_name_by_reflection(field, detail.old_value)
378
379
379 when 'estimated_hours'
380 when 'estimated_hours'
380 value = l_hours_short(detail.value.to_f) unless detail.value.blank?
381 value = l_hours_short(detail.value.to_f) unless detail.value.blank?
381 old_value = l_hours_short(detail.old_value.to_f) unless detail.old_value.blank?
382 old_value = l_hours_short(detail.old_value.to_f) unless detail.old_value.blank?
382
383
383 when 'parent_id'
384 when 'parent_id'
384 label = l(:field_parent_issue)
385 label = l(:field_parent_issue)
385 value = "##{detail.value}" unless detail.value.blank?
386 value = "##{detail.value}" unless detail.value.blank?
386 old_value = "##{detail.old_value}" unless detail.old_value.blank?
387 old_value = "##{detail.old_value}" unless detail.old_value.blank?
387
388
388 when 'is_private'
389 when 'is_private'
389 value = l(detail.value == "0" ? :general_text_No : :general_text_Yes) unless detail.value.blank?
390 value = l(detail.value == "0" ? :general_text_No : :general_text_Yes) unless detail.value.blank?
390 old_value = l(detail.old_value == "0" ? :general_text_No : :general_text_Yes) unless detail.old_value.blank?
391 old_value = l(detail.old_value == "0" ? :general_text_No : :general_text_Yes) unless detail.old_value.blank?
391
392
392 when 'description'
393 when 'description'
393 show_diff = true
394 show_diff = true
394 end
395 end
395 when 'cf'
396 when 'cf'
396 custom_field = detail.custom_field
397 custom_field = detail.custom_field
397 if custom_field
398 if custom_field
398 label = custom_field.name
399 label = custom_field.name
399 if custom_field.format.class.change_no_details
400 if custom_field.format.class.change_no_details
400 no_details = true
401 no_details = true
401 elsif custom_field.format.class.change_as_diff
402 elsif custom_field.format.class.change_as_diff
402 show_diff = true
403 show_diff = true
403 else
404 else
404 multiple = custom_field.multiple?
405 multiple = custom_field.multiple?
405 value = format_value(detail.value, custom_field) if detail.value
406 value = format_value(detail.value, custom_field) if detail.value
406 old_value = format_value(detail.old_value, custom_field) if detail.old_value
407 old_value = format_value(detail.old_value, custom_field) if detail.old_value
407 end
408 end
408 end
409 end
409 when 'attachment'
410 when 'attachment'
410 label = l(:label_attachment)
411 label = l(:label_attachment)
411 when 'relation'
412 when 'relation'
412 if detail.value && !detail.old_value
413 if detail.value && !detail.old_value
413 rel_issue = Issue.visible.find_by_id(detail.value)
414 rel_issue = Issue.visible.find_by_id(detail.value)
414 value = rel_issue.nil? ? "#{l(:label_issue)} ##{detail.value}" :
415 value = rel_issue.nil? ? "#{l(:label_issue)} ##{detail.value}" :
415 (no_html ? rel_issue : link_to_issue(rel_issue, :only_path => options[:only_path]))
416 (no_html ? rel_issue : link_to_issue(rel_issue, :only_path => options[:only_path]))
416 elsif detail.old_value && !detail.value
417 elsif detail.old_value && !detail.value
417 rel_issue = Issue.visible.find_by_id(detail.old_value)
418 rel_issue = Issue.visible.find_by_id(detail.old_value)
418 old_value = rel_issue.nil? ? "#{l(:label_issue)} ##{detail.old_value}" :
419 old_value = rel_issue.nil? ? "#{l(:label_issue)} ##{detail.old_value}" :
419 (no_html ? rel_issue : link_to_issue(rel_issue, :only_path => options[:only_path]))
420 (no_html ? rel_issue : link_to_issue(rel_issue, :only_path => options[:only_path]))
420 end
421 end
421 relation_type = IssueRelation::TYPES[detail.prop_key]
422 relation_type = IssueRelation::TYPES[detail.prop_key]
422 label = l(relation_type[:name]) if relation_type
423 label = l(relation_type[:name]) if relation_type
423 end
424 end
424 call_hook(:helper_issues_show_detail_after_setting,
425 call_hook(:helper_issues_show_detail_after_setting,
425 {:detail => detail, :label => label, :value => value, :old_value => old_value })
426 {:detail => detail, :label => label, :value => value, :old_value => old_value })
426
427
427 label ||= detail.prop_key
428 label ||= detail.prop_key
428 value ||= detail.value
429 value ||= detail.value
429 old_value ||= detail.old_value
430 old_value ||= detail.old_value
430
431
431 unless no_html
432 unless no_html
432 label = content_tag('strong', label)
433 label = content_tag('strong', label)
433 old_value = content_tag("i", h(old_value)) if detail.old_value
434 old_value = content_tag("i", h(old_value)) if detail.old_value
434 if detail.old_value && detail.value.blank? && detail.property != 'relation'
435 if detail.old_value && detail.value.blank? && detail.property != 'relation'
435 old_value = content_tag("del", old_value)
436 old_value = content_tag("del", old_value)
436 end
437 end
437 if detail.property == 'attachment' && value.present? &&
438 if detail.property == 'attachment' && value.present? &&
438 atta = detail.journal.journalized.attachments.detect {|a| a.id == detail.prop_key.to_i}
439 atta = detail.journal.journalized.attachments.detect {|a| a.id == detail.prop_key.to_i}
439 # Link to the attachment if it has not been removed
440 # Link to the attachment if it has not been removed
440 value = link_to_attachment(atta, :download => true, :only_path => options[:only_path])
441 value = link_to_attachment(atta, :download => true, :only_path => options[:only_path])
441 if options[:only_path] != false && (atta.is_text? || atta.is_image?)
442 if options[:only_path] != false && (atta.is_text? || atta.is_image?)
442 value += ' '
443 value += ' '
443 value += link_to(l(:button_view),
444 value += link_to(l(:button_view),
444 { :controller => 'attachments', :action => 'show',
445 { :controller => 'attachments', :action => 'show',
445 :id => atta, :filename => atta.filename },
446 :id => atta, :filename => atta.filename },
446 :class => 'icon-only icon-magnifier',
447 :class => 'icon-only icon-magnifier',
447 :title => l(:button_view))
448 :title => l(:button_view))
448 end
449 end
449 else
450 else
450 value = content_tag("i", h(value)) if value
451 value = content_tag("i", h(value)) if value
451 end
452 end
452 end
453 end
453
454
454 if no_details
455 if no_details
455 s = l(:text_journal_changed_no_detail, :label => label).html_safe
456 s = l(:text_journal_changed_no_detail, :label => label).html_safe
456 elsif show_diff
457 elsif show_diff
457 s = l(:text_journal_changed_no_detail, :label => label)
458 s = l(:text_journal_changed_no_detail, :label => label)
458 unless no_html
459 unless no_html
459 diff_link = link_to 'diff',
460 diff_link = link_to 'diff',
460 diff_journal_url(detail.journal_id, :detail_id => detail.id, :only_path => options[:only_path]),
461 diff_journal_url(detail.journal_id, :detail_id => detail.id, :only_path => options[:only_path]),
461 :title => l(:label_view_diff)
462 :title => l(:label_view_diff)
462 s << " (#{ diff_link })"
463 s << " (#{ diff_link })"
463 end
464 end
464 s.html_safe
465 s.html_safe
465 elsif detail.value.present?
466 elsif detail.value.present?
466 case detail.property
467 case detail.property
467 when 'attr', 'cf'
468 when 'attr', 'cf'
468 if detail.old_value.present?
469 if detail.old_value.present?
469 l(:text_journal_changed, :label => label, :old => old_value, :new => value).html_safe
470 l(:text_journal_changed, :label => label, :old => old_value, :new => value).html_safe
470 elsif multiple
471 elsif multiple
471 l(:text_journal_added, :label => label, :value => value).html_safe
472 l(:text_journal_added, :label => label, :value => value).html_safe
472 else
473 else
473 l(:text_journal_set_to, :label => label, :value => value).html_safe
474 l(:text_journal_set_to, :label => label, :value => value).html_safe
474 end
475 end
475 when 'attachment', 'relation'
476 when 'attachment', 'relation'
476 l(:text_journal_added, :label => label, :value => value).html_safe
477 l(:text_journal_added, :label => label, :value => value).html_safe
477 end
478 end
478 else
479 else
479 l(:text_journal_deleted, :label => label, :old => old_value).html_safe
480 l(:text_journal_deleted, :label => label, :old => old_value).html_safe
480 end
481 end
481 end
482 end
482
483
483 # Find the name of an associated record stored in the field attribute
484 # Find the name of an associated record stored in the field attribute
484 def find_name_by_reflection(field, id)
485 def find_name_by_reflection(field, id)
485 unless id.present?
486 unless id.present?
486 return nil
487 return nil
487 end
488 end
488 @detail_value_name_by_reflection ||= Hash.new do |hash, key|
489 @detail_value_name_by_reflection ||= Hash.new do |hash, key|
489 association = Issue.reflect_on_association(key.first.to_sym)
490 association = Issue.reflect_on_association(key.first.to_sym)
490 name = nil
491 name = nil
491 if association
492 if association
492 record = association.klass.find_by_id(key.last)
493 record = association.klass.find_by_id(key.last)
493 if record
494 if record
494 name = record.name.force_encoding('UTF-8')
495 name = record.name.force_encoding('UTF-8')
495 end
496 end
496 end
497 end
497 hash[key] = name
498 hash[key] = name
498 end
499 end
499 @detail_value_name_by_reflection[[field, id]]
500 @detail_value_name_by_reflection[[field, id]]
500 end
501 end
501
502
502 # Renders issue children recursively
503 # Renders issue children recursively
503 def render_api_issue_children(issue, api)
504 def render_api_issue_children(issue, api)
504 return if issue.leaf?
505 return if issue.leaf?
505 api.array :children do
506 api.array :children do
506 issue.children.each do |child|
507 issue.children.each do |child|
507 api.issue(:id => child.id) do
508 api.issue(:id => child.id) do
508 api.tracker(:id => child.tracker_id, :name => child.tracker.name) unless child.tracker.nil?
509 api.tracker(:id => child.tracker_id, :name => child.tracker.name) unless child.tracker.nil?
509 api.subject child.subject
510 api.subject child.subject
510 render_api_issue_children(child, api)
511 render_api_issue_children(child, api)
511 end
512 end
512 end
513 end
513 end
514 end
514 end
515 end
515 end
516 end
General Comments 0
You need to be logged in to leave comments. Login now