##// END OF EJS Templates
jro_apps » redmine
RSS
Redmine.pm fails when permissions are NULL (#11818)....
Jean-Philippe Lang -
r10192:338d81d6e3f9
parent child
Show More
Side by Side Unified
Context file:
r10192:338d81d6e3f9 Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,543 +1,544
1 package Apache::Authn::Redmine;
1 package Apache::Authn::Redmine;
2
2
3 =head1 Apache::Authn::Redmine
3 =head1 Apache::Authn::Redmine
4
4
5 Redmine - a mod_perl module to authenticate webdav subversion users
5 Redmine - a mod_perl module to authenticate webdav subversion users
6 against redmine database
6 against redmine database
7
7
8 =head1 SYNOPSIS
8 =head1 SYNOPSIS
9
9
10 This module allow anonymous users to browse public project and
10 This module allow anonymous users to browse public project and
11 registred users to browse and commit their project. Authentication is
11 registred users to browse and commit their project. Authentication is
12 done against the redmine database or the LDAP configured in redmine.
12 done against the redmine database or the LDAP configured in redmine.
13
13
14 This method is far simpler than the one with pam_* and works with all
14 This method is far simpler than the one with pam_* and works with all
15 database without an hassle but you need to have apache/mod_perl on the
15 database without an hassle but you need to have apache/mod_perl on the
16 svn server.
16 svn server.
17
17
18 =head1 INSTALLATION
18 =head1 INSTALLATION
19
19
20 For this to automagically work, you need to have a recent reposman.rb
20 For this to automagically work, you need to have a recent reposman.rb
21 (after r860) and if you already use reposman, read the last section to
21 (after r860) and if you already use reposman, read the last section to
22 migrate.
22 migrate.
23
23
24 Sorry ruby users but you need some perl modules, at least mod_perl2,
24 Sorry ruby users but you need some perl modules, at least mod_perl2,
25 DBI and DBD::mysql (or the DBD driver for you database as it should
25 DBI and DBD::mysql (or the DBD driver for you database as it should
26 work on allmost all databases).
26 work on allmost all databases).
27
27
28 On debian/ubuntu you must do :
28 On debian/ubuntu you must do :
29
29
30 aptitude install libapache-dbi-perl libapache2-mod-perl2 libdbd-mysql-perl
30 aptitude install libapache-dbi-perl libapache2-mod-perl2 libdbd-mysql-perl
31
31
32 If your Redmine users use LDAP authentication, you will also need
32 If your Redmine users use LDAP authentication, you will also need
33 Authen::Simple::LDAP (and IO::Socket::SSL if LDAPS is used):
33 Authen::Simple::LDAP (and IO::Socket::SSL if LDAPS is used):
34
34
35 aptitude install libauthen-simple-ldap-perl libio-socket-ssl-perl
35 aptitude install libauthen-simple-ldap-perl libio-socket-ssl-perl
36
36
37 =head1 CONFIGURATION
37 =head1 CONFIGURATION
38
38
39 ## This module has to be in your perl path
39 ## This module has to be in your perl path
40 ## eg: /usr/lib/perl5/Apache/Authn/Redmine.pm
40 ## eg: /usr/lib/perl5/Apache/Authn/Redmine.pm
41 PerlLoadModule Apache::Authn::Redmine
41 PerlLoadModule Apache::Authn::Redmine
42 <Location /svn>
42 <Location /svn>
43 DAV svn
43 DAV svn
44 SVNParentPath "/var/svn"
44 SVNParentPath "/var/svn"
45
45
46 AuthType Basic
46 AuthType Basic
47 AuthName redmine
47 AuthName redmine
48 Require valid-user
48 Require valid-user
49
49
50 PerlAccessHandler Apache::Authn::Redmine::access_handler
50 PerlAccessHandler Apache::Authn::Redmine::access_handler
51 PerlAuthenHandler Apache::Authn::Redmine::authen_handler
51 PerlAuthenHandler Apache::Authn::Redmine::authen_handler
52
52
53 ## for mysql
53 ## for mysql
54 RedmineDSN "DBI:mysql:database=databasename;host=my.db.server"
54 RedmineDSN "DBI:mysql:database=databasename;host=my.db.server"
55 ## for postgres
55 ## for postgres
56 # RedmineDSN "DBI:Pg:dbname=databasename;host=my.db.server"
56 # RedmineDSN "DBI:Pg:dbname=databasename;host=my.db.server"
57
57
58 RedmineDbUser "redmine"
58 RedmineDbUser "redmine"
59 RedmineDbPass "password"
59 RedmineDbPass "password"
60 ## Optional where clause (fulltext search would be slow and
60 ## Optional where clause (fulltext search would be slow and
61 ## database dependant).
61 ## database dependant).
62 # RedmineDbWhereClause "and members.role_id IN (1,2)"
62 # RedmineDbWhereClause "and members.role_id IN (1,2)"
63 ## Optional credentials cache size
63 ## Optional credentials cache size
64 # RedmineCacheCredsMax 50
64 # RedmineCacheCredsMax 50
65 </Location>
65 </Location>
66
66
67 To be able to browse repository inside redmine, you must add something
67 To be able to browse repository inside redmine, you must add something
68 like that :
68 like that :
69
69
70 <Location /svn-private>
70 <Location /svn-private>
71 DAV svn
71 DAV svn
72 SVNParentPath "/var/svn"
72 SVNParentPath "/var/svn"
73 Order deny,allow
73 Order deny,allow
74 Deny from all
74 Deny from all
75 # only allow reading orders
75 # only allow reading orders
76 <Limit GET PROPFIND OPTIONS REPORT>
76 <Limit GET PROPFIND OPTIONS REPORT>
77 Allow from redmine.server.ip
77 Allow from redmine.server.ip
78 </Limit>
78 </Limit>
79 </Location>
79 </Location>
80
80
81 and you will have to use this reposman.rb command line to create repository :
81 and you will have to use this reposman.rb command line to create repository :
82
82
83 reposman.rb --redmine my.redmine.server --svn-dir /var/svn --owner www-data -u http://svn.server/svn-private/
83 reposman.rb --redmine my.redmine.server --svn-dir /var/svn --owner www-data -u http://svn.server/svn-private/
84
84
85 =head1 REPOSITORIES NAMING
85 =head1 REPOSITORIES NAMING
86
86
87 A projet repository must be named with the projet identifier. In case
87 A projet repository must be named with the projet identifier. In case
88 of multiple repositories for the same project, use the project identifier
88 of multiple repositories for the same project, use the project identifier
89 and the repository identifier separated with a dot:
89 and the repository identifier separated with a dot:
90
90
91 /var/svn/foo
91 /var/svn/foo
92 /var/svn/foo.otherrepo
92 /var/svn/foo.otherrepo
93
93
94 =head1 MIGRATION FROM OLDER RELEASES
94 =head1 MIGRATION FROM OLDER RELEASES
95
95
96 If you use an older reposman.rb (r860 or before), you need to change
96 If you use an older reposman.rb (r860 or before), you need to change
97 rights on repositories to allow the apache user to read and write
97 rights on repositories to allow the apache user to read and write
98 S<them :>
98 S<them :>
99
99
100 sudo chown -R www-data /var/svn/*
100 sudo chown -R www-data /var/svn/*
101 sudo chmod -R u+w /var/svn/*
101 sudo chmod -R u+w /var/svn/*
102
102
103 And you need to upgrade at least reposman.rb (after r860).
103 And you need to upgrade at least reposman.rb (after r860).
104
104
105 =head1 GIT SMART HTTP SUPPORT
105 =head1 GIT SMART HTTP SUPPORT
106
106
107 Git's smart HTTP protocol (available since Git 1.7.0) will not work with the
107 Git's smart HTTP protocol (available since Git 1.7.0) will not work with the
108 above settings. Redmine.pm normally does access control depending on the HTTP
108 above settings. Redmine.pm normally does access control depending on the HTTP
109 method used: read-only methods are OK for everyone in public projects and
109 method used: read-only methods are OK for everyone in public projects and
110 members with read rights in private projects. The rest require membership with
110 members with read rights in private projects. The rest require membership with
111 commit rights in the project.
111 commit rights in the project.
112
112
113 However, this scheme doesn't work for Git's smart HTTP protocol, as it will use
113 However, this scheme doesn't work for Git's smart HTTP protocol, as it will use
114 POST even for a simple clone. Instead, read-only requests must be detected using
114 POST even for a simple clone. Instead, read-only requests must be detected using
115 the full URL (including the query string): anything that doesn't belong to the
115 the full URL (including the query string): anything that doesn't belong to the
116 git-receive-pack service is read-only.
116 git-receive-pack service is read-only.
117
117
118 To activate this mode of operation, add this line inside your <Location /git>
118 To activate this mode of operation, add this line inside your <Location /git>
119 block:
119 block:
120
120
121 RedmineGitSmartHttp yes
121 RedmineGitSmartHttp yes
122
122
123 Here's a sample Apache configuration which integrates git-http-backend with
123 Here's a sample Apache configuration which integrates git-http-backend with
124 a MySQL database and this new option:
124 a MySQL database and this new option:
125
125
126 SetEnv GIT_PROJECT_ROOT /var/www/git/
126 SetEnv GIT_PROJECT_ROOT /var/www/git/
127 SetEnv GIT_HTTP_EXPORT_ALL
127 SetEnv GIT_HTTP_EXPORT_ALL
128 ScriptAlias /git/ /usr/libexec/git-core/git-http-backend/
128 ScriptAlias /git/ /usr/libexec/git-core/git-http-backend/
129 <Location /git>
129 <Location /git>
130 Order allow,deny
130 Order allow,deny
131 Allow from all
131 Allow from all
132
132
133 AuthType Basic
133 AuthType Basic
134 AuthName Git
134 AuthName Git
135 Require valid-user
135 Require valid-user
136
136
137 PerlAccessHandler Apache::Authn::Redmine::access_handler
137 PerlAccessHandler Apache::Authn::Redmine::access_handler
138 PerlAuthenHandler Apache::Authn::Redmine::authen_handler
138 PerlAuthenHandler Apache::Authn::Redmine::authen_handler
139 # for mysql
139 # for mysql
140 RedmineDSN "DBI:mysql:database=redmine;host=127.0.0.1"
140 RedmineDSN "DBI:mysql:database=redmine;host=127.0.0.1"
141 RedmineDbUser "redmine"
141 RedmineDbUser "redmine"
142 RedmineDbPass "xxx"
142 RedmineDbPass "xxx"
143 RedmineGitSmartHttp yes
143 RedmineGitSmartHttp yes
144 </Location>
144 </Location>
145
145
146 Make sure that all the names of the repositories under /var/www/git/ have a
146 Make sure that all the names of the repositories under /var/www/git/ have a
147 matching identifier for some project: /var/www/git/myproject and
147 matching identifier for some project: /var/www/git/myproject and
148 /var/www/git/myproject.git will work. You can put both bare and non-bare
148 /var/www/git/myproject.git will work. You can put both bare and non-bare
149 repositories in /var/www/git, though bare repositories are strongly
149 repositories in /var/www/git, though bare repositories are strongly
150 recommended. You should create them with the rights of the user running Redmine,
150 recommended. You should create them with the rights of the user running Redmine,
151 like this:
151 like this:
152
152
153 cd /var/www/git
153 cd /var/www/git
154 sudo -u user-running-redmine mkdir myproject
154 sudo -u user-running-redmine mkdir myproject
155 cd myproject
155 cd myproject
156 sudo -u user-running-redmine git init --bare
156 sudo -u user-running-redmine git init --bare
157
157
158 Once you have activated this option, you have three options when cloning a
158 Once you have activated this option, you have three options when cloning a
159 repository:
159 repository:
160
160
161 - Cloning using "http://user@host/git/repo(.git)" works, but will ask for the password
161 - Cloning using "http://user@host/git/repo(.git)" works, but will ask for the password
162 all the time.
162 all the time.
163
163
164 - Cloning with "http://user:pass@host/git/repo(.git)" does not have this problem, but
164 - Cloning with "http://user:pass@host/git/repo(.git)" does not have this problem, but
165 this could reveal accidentally your password to the console in some versions
165 this could reveal accidentally your password to the console in some versions
166 of Git, and you would have to ensure that .git/config is not readable except
166 of Git, and you would have to ensure that .git/config is not readable except
167 by the owner for each of your projects.
167 by the owner for each of your projects.
168
168
169 - Use "http://host/git/repo(.git)", and store your credentials in the ~/.netrc
169 - Use "http://host/git/repo(.git)", and store your credentials in the ~/.netrc
170 file. This is the recommended solution, as you only have one file to protect
170 file. This is the recommended solution, as you only have one file to protect
171 and passwords will not be leaked accidentally to the console.
171 and passwords will not be leaked accidentally to the console.
172
172
173 IMPORTANT NOTE: It is *very important* that the file cannot be read by other
173 IMPORTANT NOTE: It is *very important* that the file cannot be read by other
174 users, as it will contain your password in cleartext. To create the file, you
174 users, as it will contain your password in cleartext. To create the file, you
175 can use the following commands, replacing yourhost, youruser and yourpassword
175 can use the following commands, replacing yourhost, youruser and yourpassword
176 with the right values:
176 with the right values:
177
177
178 touch ~/.netrc
178 touch ~/.netrc
179 chmod 600 ~/.netrc
179 chmod 600 ~/.netrc
180 echo -e "machine yourhost\nlogin youruser\npassword yourpassword" > ~/.netrc
180 echo -e "machine yourhost\nlogin youruser\npassword yourpassword" > ~/.netrc
181
181
182 =cut
182 =cut
183
183
184 use strict;
184 use strict;
185 use warnings FATAL => 'all', NONFATAL => 'redefine';
185 use warnings FATAL => 'all', NONFATAL => 'redefine';
186
186
187 use DBI;
187 use DBI;
188 use Digest::SHA;
188 use Digest::SHA;
189 # optional module for LDAP authentication
189 # optional module for LDAP authentication
190 my $CanUseLDAPAuth = eval("use Authen::Simple::LDAP; 1");
190 my $CanUseLDAPAuth = eval("use Authen::Simple::LDAP; 1");
191
191
192 use Apache2::Module;
192 use Apache2::Module;
193 use Apache2::Access;
193 use Apache2::Access;
194 use Apache2::ServerRec qw();
194 use Apache2::ServerRec qw();
195 use Apache2::RequestRec qw();
195 use Apache2::RequestRec qw();
196 use Apache2::RequestUtil qw();
196 use Apache2::RequestUtil qw();
197 use Apache2::Const qw(:common :override :cmd_how);
197 use Apache2::Const qw(:common :override :cmd_how);
198 use APR::Pool ();
198 use APR::Pool ();
199 use APR::Table ();
199 use APR::Table ();
200
200
201 # use Apache2::Directive qw();
201 # use Apache2::Directive qw();
202
202
203 my @directives = (
203 my @directives = (
204 {
204 {
205 name => 'RedmineDSN',
205 name => 'RedmineDSN',
206 req_override => OR_AUTHCFG,
206 req_override => OR_AUTHCFG,
207 args_how => TAKE1,
207 args_how => TAKE1,
208 errmsg => 'Dsn in format used by Perl DBI. eg: "DBI:Pg:dbname=databasename;host=my.db.server"',
208 errmsg => 'Dsn in format used by Perl DBI. eg: "DBI:Pg:dbname=databasename;host=my.db.server"',
209 },
209 },
210 {
210 {
211 name => 'RedmineDbUser',
211 name => 'RedmineDbUser',
212 req_override => OR_AUTHCFG,
212 req_override => OR_AUTHCFG,
213 args_how => TAKE1,
213 args_how => TAKE1,
214 },
214 },
215 {
215 {
216 name => 'RedmineDbPass',
216 name => 'RedmineDbPass',
217 req_override => OR_AUTHCFG,
217 req_override => OR_AUTHCFG,
218 args_how => TAKE1,
218 args_how => TAKE1,
219 },
219 },
220 {
220 {
221 name => 'RedmineDbWhereClause',
221 name => 'RedmineDbWhereClause',
222 req_override => OR_AUTHCFG,
222 req_override => OR_AUTHCFG,
223 args_how => TAKE1,
223 args_how => TAKE1,
224 },
224 },
225 {
225 {
226 name => 'RedmineCacheCredsMax',
226 name => 'RedmineCacheCredsMax',
227 req_override => OR_AUTHCFG,
227 req_override => OR_AUTHCFG,
228 args_how => TAKE1,
228 args_how => TAKE1,
229 errmsg => 'RedmineCacheCredsMax must be decimal number',
229 errmsg => 'RedmineCacheCredsMax must be decimal number',
230 },
230 },
231 {
231 {
232 name => 'RedmineGitSmartHttp',
232 name => 'RedmineGitSmartHttp',
233 req_override => OR_AUTHCFG,
233 req_override => OR_AUTHCFG,
234 args_how => TAKE1,
234 args_how => TAKE1,
235 },
235 },
236 );
236 );
237
237
238 sub RedmineDSN {
238 sub RedmineDSN {
239 my ($self, $parms, $arg) = @_;
239 my ($self, $parms, $arg) = @_;
240 $self->{RedmineDSN} = $arg;
240 $self->{RedmineDSN} = $arg;
241 my $query = "SELECT
241 my $query = "SELECT
242 users.hashed_password, users.salt, users.auth_source_id, roles.permissions, projects.status
242 users.hashed_password, users.salt, users.auth_source_id, roles.permissions, projects.status
243 FROM projects, users, roles
243 FROM projects, users, roles
244 WHERE
244 WHERE
245 users.login=?
245 users.login=?
246 AND projects.identifier=?
246 AND projects.identifier=?
247 AND users.status=1
247 AND users.status=1
248 AND (
248 AND (
249 roles.id IN (SELECT member_roles.role_id FROM members, member_roles WHERE members.user_id = users.id AND members.project_id = projects.id AND members.id = member_roles.member_id)
249 roles.id IN (SELECT member_roles.role_id FROM members, member_roles WHERE members.user_id = users.id AND members.project_id = projects.id AND members.id = member_roles.member_id)
250 OR
250 OR
251 (roles.builtin=1 AND cast(projects.is_public as CHAR) IN ('t', '1'))
251 (roles.builtin=1 AND cast(projects.is_public as CHAR) IN ('t', '1'))
252 ) ";
252 )
253 AND roles.permissions IS NOT NULL";
253 $self->{RedmineQuery} = trim($query);
254 $self->{RedmineQuery} = trim($query);
254 }
255 }
255
256
256 sub RedmineDbUser { set_val('RedmineDbUser', @_); }
257 sub RedmineDbUser { set_val('RedmineDbUser', @_); }
257 sub RedmineDbPass { set_val('RedmineDbPass', @_); }
258 sub RedmineDbPass { set_val('RedmineDbPass', @_); }
258 sub RedmineDbWhereClause {
259 sub RedmineDbWhereClause {
259 my ($self, $parms, $arg) = @_;
260 my ($self, $parms, $arg) = @_;
260 $self->{RedmineQuery} = trim($self->{RedmineQuery}.($arg ? $arg : "")." ");
261 $self->{RedmineQuery} = trim($self->{RedmineQuery}.($arg ? $arg : "")." ");
261 }
262 }
262
263
263 sub RedmineCacheCredsMax {
264 sub RedmineCacheCredsMax {
264 my ($self, $parms, $arg) = @_;
265 my ($self, $parms, $arg) = @_;
265 if ($arg) {
266 if ($arg) {
266 $self->{RedmineCachePool} = APR::Pool->new;
267 $self->{RedmineCachePool} = APR::Pool->new;
267 $self->{RedmineCacheCreds} = APR::Table::make($self->{RedmineCachePool}, $arg);
268 $self->{RedmineCacheCreds} = APR::Table::make($self->{RedmineCachePool}, $arg);
268 $self->{RedmineCacheCredsCount} = 0;
269 $self->{RedmineCacheCredsCount} = 0;
269 $self->{RedmineCacheCredsMax} = $arg;
270 $self->{RedmineCacheCredsMax} = $arg;
270 }
271 }
271 }
272 }
272
273
273 sub RedmineGitSmartHttp {
274 sub RedmineGitSmartHttp {
274 my ($self, $parms, $arg) = @_;
275 my ($self, $parms, $arg) = @_;
275 $arg = lc $arg;
276 $arg = lc $arg;
276
277
277 if ($arg eq "yes" || $arg eq "true") {
278 if ($arg eq "yes" || $arg eq "true") {
278 $self->{RedmineGitSmartHttp} = 1;
279 $self->{RedmineGitSmartHttp} = 1;
279 } else {
280 } else {
280 $self->{RedmineGitSmartHttp} = 0;
281 $self->{RedmineGitSmartHttp} = 0;
281 }
282 }
282 }
283 }
283
284
284 sub trim {
285 sub trim {
285 my $string = shift;
286 my $string = shift;
286 $string =~ s/\s{2,}/ /g;
287 $string =~ s/\s{2,}/ /g;
287 return $string;
288 return $string;
288 }
289 }
289
290
290 sub set_val {
291 sub set_val {
291 my ($key, $self, $parms, $arg) = @_;
292 my ($key, $self, $parms, $arg) = @_;
292 $self->{$key} = $arg;
293 $self->{$key} = $arg;
293 }
294 }
294
295
295 Apache2::Module::add(__PACKAGE__, \@directives);
296 Apache2::Module::add(__PACKAGE__, \@directives);
296
297
297
298
298 my %read_only_methods = map { $_ => 1 } qw/GET HEAD PROPFIND REPORT OPTIONS/;
299 my %read_only_methods = map { $_ => 1 } qw/GET HEAD PROPFIND REPORT OPTIONS/;
299
300
300 sub request_is_read_only {
301 sub request_is_read_only {
301 my ($r) = @_;
302 my ($r) = @_;
302 my $cfg = Apache2::Module::get_config(__PACKAGE__, $r->server, $r->per_dir_config);
303 my $cfg = Apache2::Module::get_config(__PACKAGE__, $r->server, $r->per_dir_config);
303
304
304 # Do we use Git's smart HTTP protocol, or not?
305 # Do we use Git's smart HTTP protocol, or not?
305 if (defined $cfg->{RedmineGitSmartHttp} and $cfg->{RedmineGitSmartHttp}) {
306 if (defined $cfg->{RedmineGitSmartHttp} and $cfg->{RedmineGitSmartHttp}) {
306 my $uri = $r->unparsed_uri;
307 my $uri = $r->unparsed_uri;
307 my $location = $r->location;
308 my $location = $r->location;
308 my $is_read_only = $uri !~ m{^$location/*[^/]+/+(info/refs\?service=)?git\-receive\-pack$}o;
309 my $is_read_only = $uri !~ m{^$location/*[^/]+/+(info/refs\?service=)?git\-receive\-pack$}o;
309 return $is_read_only;
310 return $is_read_only;
310 } else {
311 } else {
311 # Standard behaviour: check the HTTP method
312 # Standard behaviour: check the HTTP method
312 my $method = $r->method;
313 my $method = $r->method;
313 return defined $read_only_methods{$method};
314 return defined $read_only_methods{$method};
314 }
315 }
315 }
316 }
316
317
317 sub access_handler {
318 sub access_handler {
318 my $r = shift;
319 my $r = shift;
319
320
320 unless ($r->some_auth_required) {
321 unless ($r->some_auth_required) {
321 $r->log_reason("No authentication has been configured");
322 $r->log_reason("No authentication has been configured");
322 return FORBIDDEN;
323 return FORBIDDEN;
323 }
324 }
324
325
325 return OK unless request_is_read_only($r);
326 return OK unless request_is_read_only($r);
326
327
327 my $project_id = get_project_identifier($r);
328 my $project_id = get_project_identifier($r);
328
329
329 $r->set_handlers(PerlAuthenHandler => [\&OK])
330 $r->set_handlers(PerlAuthenHandler => [\&OK])
330 if is_public_project($project_id, $r) && anonymous_role_allows_browse_repository($r);
331 if is_public_project($project_id, $r) && anonymous_role_allows_browse_repository($r);
331
332
332 return OK
333 return OK
333 }
334 }
334
335
335 sub authen_handler {
336 sub authen_handler {
336 my $r = shift;
337 my $r = shift;
337
338
338 my ($res, $redmine_pass) = $r->get_basic_auth_pw();
339 my ($res, $redmine_pass) = $r->get_basic_auth_pw();
339 return $res unless $res == OK;
340 return $res unless $res == OK;
340
341
341 if (is_member($r->user, $redmine_pass, $r)) {
342 if (is_member($r->user, $redmine_pass, $r)) {
342 return OK;
343 return OK;
343 } else {
344 } else {
344 $r->note_auth_failure();
345 $r->note_auth_failure();
345 return DECLINED;
346 return DECLINED;
346 }
347 }
347 }
348 }
348
349
349 # check if authentication is forced
350 # check if authentication is forced
350 sub is_authentication_forced {
351 sub is_authentication_forced {
351 my $r = shift;
352 my $r = shift;
352
353
353 my $dbh = connect_database($r);
354 my $dbh = connect_database($r);
354 my $sth = $dbh->prepare(
355 my $sth = $dbh->prepare(
355 "SELECT value FROM settings where settings.name = 'login_required';"
356 "SELECT value FROM settings where settings.name = 'login_required';"
356 );
357 );
357
358
358 $sth->execute();
359 $sth->execute();
359 my $ret = 0;
360 my $ret = 0;
360 if (my @row = $sth->fetchrow_array) {
361 if (my @row = $sth->fetchrow_array) {
361 if ($row[0] eq "1" || $row[0] eq "t") {
362 if ($row[0] eq "1" || $row[0] eq "t") {
362 $ret = 1;
363 $ret = 1;
363 }
364 }
364 }
365 }
365 $sth->finish();
366 $sth->finish();
366 undef $sth;
367 undef $sth;
367
368
368 $dbh->disconnect();
369 $dbh->disconnect();
369 undef $dbh;
370 undef $dbh;
370
371
371 $ret;
372 $ret;
372 }
373 }
373
374
374 sub is_public_project {
375 sub is_public_project {
375 my $project_id = shift;
376 my $project_id = shift;
376 my $r = shift;
377 my $r = shift;
377
378
378 if (is_authentication_forced($r)) {
379 if (is_authentication_forced($r)) {
379 return 0;
380 return 0;
380 }
381 }
381
382
382 my $dbh = connect_database($r);
383 my $dbh = connect_database($r);
383 my $sth = $dbh->prepare(
384 my $sth = $dbh->prepare(
384 "SELECT is_public FROM projects WHERE projects.identifier = ? AND projects.status <> 9;"
385 "SELECT is_public FROM projects WHERE projects.identifier = ? AND projects.status <> 9;"
385 );
386 );
386
387
387 $sth->execute($project_id);
388 $sth->execute($project_id);
388 my $ret = 0;
389 my $ret = 0;
389 if (my @row = $sth->fetchrow_array) {
390 if (my @row = $sth->fetchrow_array) {
390 if ($row[0] eq "1" || $row[0] eq "t") {
391 if ($row[0] eq "1" || $row[0] eq "t") {
391 $ret = 1;
392 $ret = 1;
392 }
393 }
393 }
394 }
394 $sth->finish();
395 $sth->finish();
395 undef $sth;
396 undef $sth;
396 $dbh->disconnect();
397 $dbh->disconnect();
397 undef $dbh;
398 undef $dbh;
398
399
399 $ret;
400 $ret;
400 }
401 }
401
402
402 sub anonymous_role_allows_browse_repository {
403 sub anonymous_role_allows_browse_repository {
403 my $r = shift;
404 my $r = shift;
404
405
405 my $dbh = connect_database($r);
406 my $dbh = connect_database($r);
406 my $sth = $dbh->prepare(
407 my $sth = $dbh->prepare(
407 "SELECT permissions FROM roles WHERE builtin = 2;"
408 "SELECT permissions FROM roles WHERE builtin = 2;"
408 );
409 );
409
410
410 $sth->execute();
411 $sth->execute();
411 my $ret = 0;
412 my $ret = 0;
412 if (my @row = $sth->fetchrow_array) {
413 if (my @row = $sth->fetchrow_array) {
413 if ($row[0] =~ /:browse_repository/) {
414 if ($row[0] =~ /:browse_repository/) {
414 $ret = 1;
415 $ret = 1;
415 }
416 }
416 }
417 }
417 $sth->finish();
418 $sth->finish();
418 undef $sth;
419 undef $sth;
419 $dbh->disconnect();
420 $dbh->disconnect();
420 undef $dbh;
421 undef $dbh;
421
422
422 $ret;
423 $ret;
423 }
424 }
424
425
425 # perhaps we should use repository right (other read right) to check public access.
426 # perhaps we should use repository right (other read right) to check public access.
426 # it could be faster BUT it doesn't work for the moment.
427 # it could be faster BUT it doesn't work for the moment.
427 # sub is_public_project_by_file {
428 # sub is_public_project_by_file {
428 # my $project_id = shift;
429 # my $project_id = shift;
429 # my $r = shift;
430 # my $r = shift;
430
431
431 # my $tree = Apache2::Directive::conftree();
432 # my $tree = Apache2::Directive::conftree();
432 # my $node = $tree->lookup('Location', $r->location);
433 # my $node = $tree->lookup('Location', $r->location);
433 # my $hash = $node->as_hash;
434 # my $hash = $node->as_hash;
434
435
435 # my $svnparentpath = $hash->{SVNParentPath};
436 # my $svnparentpath = $hash->{SVNParentPath};
436 # my $repos_path = $svnparentpath . "/" . $project_id;
437 # my $repos_path = $svnparentpath . "/" . $project_id;
437 # return 1 if (stat($repos_path))[2] & 00007;
438 # return 1 if (stat($repos_path))[2] & 00007;
438 # }
439 # }
439
440
440 sub is_member {
441 sub is_member {
441 my $redmine_user = shift;
442 my $redmine_user = shift;
442 my $redmine_pass = shift;
443 my $redmine_pass = shift;
443 my $r = shift;
444 my $r = shift;
444
445
445 my $dbh = connect_database($r);
446 my $dbh = connect_database($r);
446 my $project_id = get_project_identifier($r);
447 my $project_id = get_project_identifier($r);
447
448
448 my $pass_digest = Digest::SHA::sha1_hex($redmine_pass);
449 my $pass_digest = Digest::SHA::sha1_hex($redmine_pass);
449
450
450 my $access_mode = request_is_read_only($r) ? "R" : "W";
451 my $access_mode = request_is_read_only($r) ? "R" : "W";
451
452
452 my $cfg = Apache2::Module::get_config(__PACKAGE__, $r->server, $r->per_dir_config);
453 my $cfg = Apache2::Module::get_config(__PACKAGE__, $r->server, $r->per_dir_config);
453 my $usrprojpass;
454 my $usrprojpass;
454 if ($cfg->{RedmineCacheCredsMax}) {
455 if ($cfg->{RedmineCacheCredsMax}) {
455 $usrprojpass = $cfg->{RedmineCacheCreds}->get($redmine_user.":".$project_id.":".$access_mode);
456 $usrprojpass = $cfg->{RedmineCacheCreds}->get($redmine_user.":".$project_id.":".$access_mode);
456 return 1 if (defined $usrprojpass and ($usrprojpass eq $pass_digest));
457 return 1 if (defined $usrprojpass and ($usrprojpass eq $pass_digest));
457 }
458 }
458 my $query = $cfg->{RedmineQuery};
459 my $query = $cfg->{RedmineQuery};
459 my $sth = $dbh->prepare($query);
460 my $sth = $dbh->prepare($query);
460 $sth->execute($redmine_user, $project_id);
461 $sth->execute($redmine_user, $project_id);
461
462
462 my $ret;
463 my $ret;
463 while (my ($hashed_password, $salt, $auth_source_id, $permissions, $project_status) = $sth->fetchrow_array) {
464 while (my ($hashed_password, $salt, $auth_source_id, $permissions, $project_status) = $sth->fetchrow_array) {
464 if ($project_status eq "9" || ($project_status ne "1" && $access_mode eq "W")) {
465 if ($project_status eq "9" || ($project_status ne "1" && $access_mode eq "W")) {
465 last;
466 last;
466 }
467 }
467
468
468 unless ($auth_source_id) {
469 unless ($auth_source_id) {
469 my $method = $r->method;
470 my $method = $r->method;
470 my $salted_password = Digest::SHA::sha1_hex($salt.$pass_digest);
471 my $salted_password = Digest::SHA::sha1_hex($salt.$pass_digest);
471 if ($hashed_password eq $salted_password && (($access_mode eq "R" && $permissions =~ /:browse_repository/) || $permissions =~ /:commit_access/) ) {
472 if ($hashed_password eq $salted_password && (($access_mode eq "R" && $permissions =~ /:browse_repository/) || $permissions =~ /:commit_access/) ) {
472 $ret = 1;
473 $ret = 1;
473 last;
474 last;
474 }
475 }
475 } elsif ($CanUseLDAPAuth) {
476 } elsif ($CanUseLDAPAuth) {
476 my $sthldap = $dbh->prepare(
477 my $sthldap = $dbh->prepare(
477 "SELECT host,port,tls,account,account_password,base_dn,attr_login from auth_sources WHERE id = ?;"
478 "SELECT host,port,tls,account,account_password,base_dn,attr_login from auth_sources WHERE id = ?;"
478 );
479 );
479 $sthldap->execute($auth_source_id);
480 $sthldap->execute($auth_source_id);
480 while (my @rowldap = $sthldap->fetchrow_array) {
481 while (my @rowldap = $sthldap->fetchrow_array) {
481 my $bind_as = $rowldap[3] ? $rowldap[3] : "";
482 my $bind_as = $rowldap[3] ? $rowldap[3] : "";
482 my $bind_pw = $rowldap[4] ? $rowldap[4] : "";
483 my $bind_pw = $rowldap[4] ? $rowldap[4] : "";
483 if ($bind_as =~ m/\$login/) {
484 if ($bind_as =~ m/\$login/) {
484 # replace $login with $redmine_user and use $redmine_pass
485 # replace $login with $redmine_user and use $redmine_pass
485 $bind_as =~ s/\$login/$redmine_user/g;
486 $bind_as =~ s/\$login/$redmine_user/g;
486 $bind_pw = $redmine_pass
487 $bind_pw = $redmine_pass
487 }
488 }
488 my $ldap = Authen::Simple::LDAP->new(
489 my $ldap = Authen::Simple::LDAP->new(
489 host => ($rowldap[2] eq "1" || $rowldap[2] eq "t") ? "ldaps://$rowldap[0]:$rowldap[1]" : $rowldap[0],
490 host => ($rowldap[2] eq "1" || $rowldap[2] eq "t") ? "ldaps://$rowldap[0]:$rowldap[1]" : $rowldap[0],
490 port => $rowldap[1],
491 port => $rowldap[1],
491 basedn => $rowldap[5],
492 basedn => $rowldap[5],
492 binddn => $bind_as,
493 binddn => $bind_as,
493 bindpw => $bind_pw,
494 bindpw => $bind_pw,
494 filter => "(".$rowldap[6]."=%s)"
495 filter => "(".$rowldap[6]."=%s)"
495 );
496 );
496 my $method = $r->method;
497 my $method = $r->method;
497 $ret = 1 if ($ldap->authenticate($redmine_user, $redmine_pass) && (($access_mode eq "R" && $permissions =~ /:browse_repository/) || $permissions =~ /:commit_access/));
498 $ret = 1 if ($ldap->authenticate($redmine_user, $redmine_pass) && (($access_mode eq "R" && $permissions =~ /:browse_repository/) || $permissions =~ /:commit_access/));
498
499
499 }
500 }
500 $sthldap->finish();
501 $sthldap->finish();
501 undef $sthldap;
502 undef $sthldap;
502 }
503 }
503 }
504 }
504 $sth->finish();
505 $sth->finish();
505 undef $sth;
506 undef $sth;
506 $dbh->disconnect();
507 $dbh->disconnect();
507 undef $dbh;
508 undef $dbh;
508
509
509 if ($cfg->{RedmineCacheCredsMax} and $ret) {
510 if ($cfg->{RedmineCacheCredsMax} and $ret) {
510 if (defined $usrprojpass) {
511 if (defined $usrprojpass) {
511 $cfg->{RedmineCacheCreds}->set($redmine_user.":".$project_id.":".$access_mode, $pass_digest);
512 $cfg->{RedmineCacheCreds}->set($redmine_user.":".$project_id.":".$access_mode, $pass_digest);
512 } else {
513 } else {
513 if ($cfg->{RedmineCacheCredsCount} < $cfg->{RedmineCacheCredsMax}) {
514 if ($cfg->{RedmineCacheCredsCount} < $cfg->{RedmineCacheCredsMax}) {
514 $cfg->{RedmineCacheCreds}->set($redmine_user.":".$project_id.":".$access_mode, $pass_digest);
515 $cfg->{RedmineCacheCreds}->set($redmine_user.":".$project_id.":".$access_mode, $pass_digest);
515 $cfg->{RedmineCacheCredsCount}++;
516 $cfg->{RedmineCacheCredsCount}++;
516 } else {
517 } else {
517 $cfg->{RedmineCacheCreds}->clear();
518 $cfg->{RedmineCacheCreds}->clear();
518 $cfg->{RedmineCacheCredsCount} = 0;
519 $cfg->{RedmineCacheCredsCount} = 0;
519 }
520 }
520 }
521 }
521 }
522 }
522
523
523 $ret;
524 $ret;
524 }
525 }
525
526
526 sub get_project_identifier {
527 sub get_project_identifier {
527 my $r = shift;
528 my $r = shift;
528
529
529 my $cfg = Apache2::Module::get_config(__PACKAGE__, $r->server, $r->per_dir_config);
530 my $cfg = Apache2::Module::get_config(__PACKAGE__, $r->server, $r->per_dir_config);
530 my $location = $r->location;
531 my $location = $r->location;
531 $location =~ s/\.git$// if (defined $cfg->{RedmineGitSmartHttp} and $cfg->{RedmineGitSmartHttp});
532 $location =~ s/\.git$// if (defined $cfg->{RedmineGitSmartHttp} and $cfg->{RedmineGitSmartHttp});
532 my ($identifier) = $r->uri =~ m{$location/*([^/.]+)};
533 my ($identifier) = $r->uri =~ m{$location/*([^/.]+)};
533 $identifier;
534 $identifier;
534 }
535 }
535
536
536 sub connect_database {
537 sub connect_database {
537 my $r = shift;
538 my $r = shift;
538
539
539 my $cfg = Apache2::Module::get_config(__PACKAGE__, $r->server, $r->per_dir_config);
540 my $cfg = Apache2::Module::get_config(__PACKAGE__, $r->server, $r->per_dir_config);
540 return DBI->connect($cfg->{RedmineDSN}, $cfg->{RedmineDbUser}, $cfg->{RedmineDbPass});
541 return DBI->connect($cfg->{RedmineDSN}, $cfg->{RedmineDbUser}, $cfg->{RedmineDbPass});
541 }
542 }
542
543
543 1;
544 1;
General Comments 0
You need to be logged in to leave comments. Login now