jro_apps/redmine Commit - r8644:333a6cc37005

Fixed rounding issue on spent hours column in CSV export (#10150)....

Jean-Philippe Lang -

r8644:333a6cc37005

parent child

Context file:

r8644:333a6cc37005

Collapse all files

app/helpers/issues_helper.rb +1 -1

                          elsif value.is_a?(Time)
                            format_time(value)
                          elsif value.is_a?(Float)
-                           value.to_s.gsub('.', decimal_separator)
+                           ("%.2f" % value).gsub('.', decimal_separator)
                          else
                            value
                          end

test/functional/issues_controller_test.rb +13 -2

                  assert_equal assigns(:query).columns.size + 2, lines[0].split(',').size
                end
+               def test_index_csv_with_spent_time_column
+                 issue = Issue.generate!(:project_id => 1, :tracker_id => 1, :subject => 'test_index_csv_with_spent_time_column')
+                 TimeEntry.generate!(:project_id => issue.project_id, :issue_id => issue.id, :hours => 7.33)
+                 get :index, :format => 'csv', :set_filter => '1', :c => %w(subject spent_hours)
+                 assert_response :success
+                 assert_equal 'text/csv', @response.content_type
+                 lines = @response.body.chomp.split("\n")
+                 assert_include "#{issue.id},#{issue.subject},7.33", lines
+               end
                def test_index_csv_with_all_columns
                  get :index, :format => 'csv', :columns => 'all'
                  assert_response :success
                                :set_filter => 1
                    assert_equal 'text/csv', @response.content_type
                    lines = @response.body.chomp.split("\n")
-                   assert_equal "#{issue.id},1234.5,#{str1}", lines[1]
+                   assert_equal "#{issue.id},1234.50,#{str1}", lines[1]
                    str_tw = "Traditional Chinese (\xe7\xb9\x81\xe9\xab\x94\xe4\xb8\xad\xe6\x96\x87)"
                    if str_tw.respond_to?(:force_encoding)
                                :set_filter => 1
                    assert_equal 'text/csv', @response.content_type
                    lines = @response.body.chomp.split("\n")
-                   assert_equal "#{issue.id};1234,5;#{str1}", lines[1]
+                   assert_equal "#{issue.id};1234,50;#{str1}", lines[1]
                    str_fr = "Fran\xc3\xa7ais"
                    if str_fr.respond_to?(:force_encoding)

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages